WebKit-https.git
16 years ago Rubber stamped by Brady.
mjs [Mon, 14 Aug 2006 07:20:52 +0000 (07:20 +0000)]
    Rubber stamped by Brady.

        - move WebFormDataStream from WebView to Loader

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebFormDataStream.h: Removed.
        * WebView/WebFormDataStream.m: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Brady.
mjs [Mon, 14 Aug 2006 07:09:26 +0000 (07:09 +0000)]
    Reviewed by Brady.

        - remove WebKit dependencies from WebSubresourceLoader, except WebFormDataStream

        (WebFormDataStream will be moved into the Loader directory soon)

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
        * Loader/WebSubresourceLoader.m:
        (isConditionalRequest):
        (hasCaseInsensitivePrefix):
        (isFileURLString):
        (setHTTPReferrer):
        (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej
beidson [Mon, 14 Aug 2006 06:50:35 +0000 (06:50 +0000)]
    Reviewed by Maciej

        Relocated the WebIconLoaders

        * Misc/WebIconLoader.h: Moved to Loader/
        * Misc/WebIconLoader.m: Moved to Loader/
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFixed my inaccurately stated Changelog
beidson [Mon, 14 Aug 2006 06:46:45 +0000 (06:46 +0000)]
Fixed my inaccurately stated Changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Beth.
mjs [Mon, 14 Aug 2006 06:45:34 +0000 (06:45 +0000)]
    Reviewed by Beth.

        - removed non-Loader WebKit dependencies from WebDataProtocol for
        real (whoops) and fix some typos.

        * Loader/WebDataProtocol.m:
        (isCaseInsensitiveEqual): Added.
        (+[WebDataProtocol _webIsDataProtocolURL:]): Avoid WebKit calls.
        (-[WebDataProtocol startLoading]): ditto
        * Loader/WebFrameLoader.m:
        (isCaseInsensitiveEqual): Fixed spelling from isCaseSensitiveEqual.
        (-[WebFrameLoader _canUseResourceForRequest:]): Use proper call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej
beidson [Mon, 14 Aug 2006 06:44:37 +0000 (06:44 +0000)]
    Reviewed by Maciej

        The way of detecting a failed icon load before was to try and construct
        an image from the icon and if that image construction failed, mark the icon
        as missing.
        A much more efficient way is to check for a 404 response.  We'll still
        check for invalid image data, but most servers will correctly return 404
        on a missing icon.

        * Misc/WebIconLoader.m:
        (-[WebIconLoader didFinishLoading]): Added check for 404 response

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Mon, 14 Aug 2006 03:22:34 +0000 (03:22 +0000)]
    Reviewed by Darin.

        - remove all non-Loader dependencies from WebLoader

        As part of this I moved WebDataProtocol to the loader directory
        and removed dependencies on the rest of WebKit from that too.

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader setDefersCallbacks:]):
        (-[WebFrameLoader stopLoading]):
        (-[WebFrameLoader cancelledErrorWithRequest:]):
        (-[WebFrameLoader clearArchivedResources]):
        (-[WebFrameLoader deliverArchivedResources]):
        (-[WebFrameLoader deliverArchivedResourcesAfterDelay]):
        (isCaseSensitiveEqual):
        (-[WebFrameLoader _canUseResourceForRequest:]):
        (-[WebFrameLoader _canUseResourceWithResponse:]):
        (-[WebFrameLoader pendingArchivedResources]):
        (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
        (-[WebFrameLoader archiveLoadPendingForLoader:]):
        (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
        * Loader/WebLoader.h:
        * Loader/WebLoader.m:
        (-[NSURLProtocol releaseResources]):
        (-[NSURLProtocol loadWithRequest:]):
        (-[NSURLProtocol setDefersCallbacks:]):
        (-[NSURLProtocol addData:allAtOnce:]):
        (-[NSURLProtocol resourceData]):
        (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
        (-[NSURLProtocol connection:didReceiveData:lengthReceived:]):
        (-[NSURLProtocol cancelWithError:]):
        (-[NSURLProtocol cancelledError]):
        * Loader/WebMainResourceLoader.m:
        (-[WebMainResourceLoader addData:allAtOnce:]):
        (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
        * Loader/WebNetscapePlugInStreamLoader.m:
        (-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:allAtOnce:]):
        * Loader/WebSubresourceLoader.m:
        (-[WebSubresourceLoader didReceiveData:lengthReceived:allAtOnce:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataProtocol.h: Removed.
        * WebView/WebDataProtocol.m: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
mjs [Mon, 14 Aug 2006 03:06:14 +0000 (03:06 +0000)]
JavaScriptCore:

        Reviewed (and tweaked a little) by Maciej.

        - shrank the size of JSObject by 8 bytes and made the corresponding reduction to the cell size, resulting
        in a 1.2% speed improvement on JS iBench (and probably overall memory savings).

        This was done by removing _scope and _internalValue data members
        from JSObject and moving them only to the subclasses that actually
        make use of them.

        * kjs/object.cpp:
        (KJS::JSObject::mark): No need to mark scope or internal value here.
        * kjs/object.h:
        (KJS::JSObject::JSObject): Don't initialize them.
        * kjs/JSWrapperObject.cpp: Added. New base class for object types that
        wrap primitive values (Number, String, Boolean, Date).
        (KJS::JSWrapperObject::mark):
        * kjs/JSWrapperObject.h: Added.
        (KJS::JSWrapperObject::JSWrapperObject):
        (KJS::JSWrapperObject::internalValue):
        (KJS::JSWrapperObject::setInternalValue):
        * kjs/array_object.cpp:
        (ArrayPrototype::ArrayPrototype): Don't set useless internal value.
        * kjs/bool_object.cpp:
        (BooleanInstance::BooleanInstance): Inherit from JSWrapperObject.
        (BooleanProtoFunc::callAsFunction): Fixed to account for fact that not all
        JSObjects have an internal value.
        (BooleanObjectImp::construct): ditto.
        * kjs/bool_object.h:
        * kjs/collector.cpp: Lowered cell size to 48.
        (KJS::Collector::allocate): meaningless whitespace change
        * kjs/date_object.cpp:
        (KJS::DateInstance::DateInstance): Inherit from JSWrapperObject.
        (KJS::DateProtoFunc::callAsFunction): adjusted for move of internalValue
        (KJS::DateObjectImp::construct): ditto
        * kjs/date_object.h:
        * kjs/error_object.cpp:
        (ErrorPrototype::ErrorPrototype): don't set internal value
        * kjs/function.cpp: move _scope and related handling here
        (KJS::FunctionImp::mark): mark scope
        * kjs/function.h:
        (KJS::FunctionImp::scope): moved here from JSObject
        (KJS::FunctionImp::setScope): ditto
        * kjs/number_object.cpp:
        (NumberInstance::NumberInstance): inherit from JSWrapperObject
        (NumberProtoFunc::callAsFunction): adjusted
        (NumberObjectImp::construct): adjusted
        * kjs/number_object.h: shring RegExp-related objects a little
        * kjs/regexp_object.cpp:
        (RegExpPrototype::RegExpPrototype): Adjust for size tweaks
        (RegExpObjectImp::RegExpObjectImp): ditto
        * kjs/regexp_object.h:
        * kjs/string_object.cpp:
        (StringInstance::StringInstance): inherit from JSWrapperObject
        (StringProtoFunc::callAsFunction): adjusted
        * kjs/string_object.h:
        * JavaScriptCore.exp: Exported new methods as needed.
        * JavaScriptCore.xcodeproj/project.pbxproj: Added new files to build.

WebCore:

        Reviewed (and tweaked a little) by Maciej.

        - shrank the size of JSObject by 8 bytes and made the corresponding reduction to the cell size, resulting
        in a 1.2% speed improvement on JS iBench (and probably overall memory savings).

        The WebCore part of this is to expect only FunctionImp to have a scope, not all JSObjects.

        * bindings/js/kjs_events.cpp:
        (KJS::JSLazyEventListener::parseCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
tomernic [Sun, 13 Aug 2006 01:38:46 +0000 (01:38 +0000)]
    Reviewed by Darin.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
        <rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins.  This is a
        generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that
        have already been drawn and are not expected to be redrawn in the same update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-08-12 Eric Seidel <eric@eseidel.com>
eseidel [Sat, 12 Aug 2006 05:59:43 +0000 (05:59 +0000)]
2006-08-12  Eric Seidel  <eric@eseidel.com>

        Reviewed by hyatt and mjs.

        Fix two missing null checks causing layout test crashes.

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle): check e for null (null for pseudo styles)
        * kcanvas/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::requiresLayer): check parent()->element() for null

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
ddkilzer [Sat, 12 Aug 2006 05:46:11 +0000 (05:46 +0000)]
LayoutTests:

        Reviewed by NOBODY (layout test fix).

        Additional layout test fixes from hyatt's "Eliminate RenderImageButton" change
        in r15839.  See also r15840 for more layout test fixes.

        * tables/mozilla/bugs/bug19599-expected.txt: Changed RenderImageButton to RenderImage.
        * tables/mozilla/bugs/bug24200-expected.txt: Ditto.
        * tables/mozilla/bugs/bug4527-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-08-11 Eric Seidel <eric@eseidel.com>
eseidel [Sat, 12 Aug 2006 04:07:25 +0000 (04:07 +0000)]
2006-08-11  Eric Seidel  <eric@eseidel.com>

        Reviewed by andersca.

        The outermost <svg> element needs to clip itself
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5358

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle): adjust for SVG overflow rules
        * kcanvas/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::requiresLayer): only require layers for absolute/relative positioning of outermost SVG
        (WebCore::RenderSVGContainer::paint):
        * kcanvas/device/KRenderingDevice.h:
        * kcanvas/device/quartz/KRenderingDeviceQuartz.h: remove dead methods
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: remove dead methods
        (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz):
        * ksvg2/svg/SVGPaint.cpp: spacing changes
        (WebCore::SVGPaint::SVGPaint): spacing cleanup
        * ksvg2/svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::parseMappedAttribute): spacing cleanup
        * platform/GraphicsContext.h: Added concatCTM
        * platform/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::concatCTM): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
beidson [Sat, 12 Aug 2006 03:22:32 +0000 (03:22 +0000)]
WebCore:

        Reviewed by Maciej

        Renamed a method/parameter for clarity and consistency, as well as some style
        cleanups and removing some ridiculously verbose log messages.
        Also added an _isEmpty method to the database and bridge for WebKit's use.
        Finally, added a central way for both WebKit and WebCore to get the icon database filename

        * bridge/mac/WebCoreIconDatabaseBridge.h:  Added _isEmpty and defaultDatabaseFilename
        * bridge/mac/WebCoreIconDatabaseBridge.mm:  Removed an unnecessary semicolon off most of these methods
        (-[WebCoreIconDatabaseBridge openSharedDatabaseWithPath:]):
        (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
        (-[WebCoreIconDatabaseBridge isOpen]):
        (-[WebCoreIconDatabaseBridge _isEmpty]):  Added
        (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
        (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
        (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
        (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
        (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
        (-[WebCoreIconDatabaseBridge retainIconForURL:]):
        (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
        (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
        (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
        (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
        (-[WebCoreIconDatabaseBridge _hasIconForIconURL:]):
        (-[WebCoreIconDatabaseBridge defaultDatabaseFilename]):  Added

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::defaultDatabaseFilename):  Added
        (WebCore::IconDatabase::open):
        (WebCore::IconDatabase::isEmpty):  Added
        (WebCore::IconDatabase::retainIconForURL):  Removed log message
        (WebCore::IconDatabase::releaseIconForURL):  Removed log message
        * loader/icon/IconDatabase.h:

WebKit:

        Reviewed by John, Timo, Adele, and Darin

        In addition to a few style/good-practice cleanups, this patch will convert the old icon database
        format to the WebCore format if the WebCore db is empty (implying this conversion has yet to take
        place).  After the conversion, it will delete all traces of the old format to free the unneeded space

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):
        (-[WebIconDatabase _setIconURL:forURL:]):  Changed the bridge's name for this method to be more clear
        (-[WebIconDatabase _createFileDatabase]):
        (-[WebIconDatabase _iconDataForIconURL:]):  This grabs the raw data for use in the conversion function
        (-[WebIconDatabase _convertToWebCoreFormat]):  This does the actual conversion

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoUpdate layout tests for removal of RenderImageButton
hyatt [Fri, 11 Aug 2006 23:53:05 +0000 (23:53 +0000)]
Update layout tests for removal of RenderImageButton

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Eliminate RenderImageButton.
hyatt [Fri, 11 Aug 2006 23:52:36 +0000 (23:52 +0000)]
    Eliminate RenderImageButton.

        Reviewed by darin

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject isImageButton]):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::createRenderer):
        * rendering/RenderImage.h:
        (WebCore::RenderImage::isImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Fri, 11 Aug 2006 23:49:39 +0000 (23:49 +0000)]
LayoutTests:

        Reviewed by Brady.

        Test case for <rdar://problem/4656274>
        REGRESSION: option elements are selected when added regardless of "selected" property

        * fast/forms/option-constructor-selected-expected.txt: Added.
        * fast/forms/option-constructor-selected.html: Added.

WebCore:

        Reviewed by Brady.

        - Fix for <rdar://problem/4656274>
        REGRESSION: option elements are selected when added regardless of "selected" property

        Test: fast/forms/option-constructor-selected.html

        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption):
        When adding an option element, check that the option element is selected before calling setSelectedIndex.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
tomernic [Fri, 11 Aug 2006 23:06:10 +0000 (23:06 +0000)]
    Reviewed by John Sullivan.

        Needed for <rdar://problem/4678070>.

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView sendEvent:]):
        Changed an assertion to an early return.  It should be possible to send events, especially updateEvt (for image capturing
        purposes), to off-screen plug-ins.  It just doesn't work right now.  See <rdar://problem/4318269>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin
sullivan [Fri, 11 Aug 2006 22:35:26 +0000 (22:35 +0000)]
    Reviewed by Darin

        - fixed <rdar://problem/4522894> Would be nice if Safari shrank pages a little if necessary
        to avoid printing an almost-empty page

        * WebView/WebHTMLView.m:
        (-[NSArray knowsPageRange:]):
        If the last page has a short-enough orphan (< 1/10 of the page height is the number I pulled
        out of ... the air), then we adjust the scale factor slightly and check whether this reduces
        the page count and thus eliminates the orphan.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdd layout test for link bug.
hyatt [Fri, 11 Aug 2006 21:26:15 +0000 (21:26 +0000)]
Add layout test for link bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix for bug 10349, make sure to call setChanged when an anchor changes
hyatt [Fri, 11 Aug 2006 21:18:47 +0000 (21:18 +0000)]
    Fix for bug 10349, make sure to call setChanged when an anchor changes
        from not being a link to being a link (and vice versa).

        Test is in fast/dynamic/link-href-change.html

        Reviewed by darin

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::HTMLAnchorElement):
        (WebCore::HTMLAnchorElement::parseMappedAttribute):
        * html/HTMLAnchorElement.h:
        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
rwlbuis [Fri, 11 Aug 2006 20:58:09 +0000 (20:58 +0000)]
    Reviewed by Darin.

        Revert an over-optimization step that messed up the HashSet lookup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoRemoving unnecessary comment from patch for bug 10346
oliver [Fri, 11 Aug 2006 17:46:45 +0000 (17:46 +0000)]
Removing unnecessary comment from patch for bug 10346

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix for bug #10346, fixes regression in svg image layout
oliver [Fri, 11 Aug 2006 17:15:16 +0000 (17:15 +0000)]
Fix for bug #10346, fixes regression in svg image layout

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-08-10 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 11 Aug 2006 00:28:46 +0000 (00:28 +0000)]
2006-08-10  Anders Carlsson  <acarlsson@apple.com>

        Rubber-stamped by Maciej.

        Move xpath to xml.

        * DerivedSources.make:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * xpath/XPathEvaluator.cpp: Removed.
        * xpath/XPathEvaluator.h: Removed.
        * xpath/XPathEvaluator.idl: Removed.
        * xpath/XPathExpression.cpp: Removed.
        * xpath/XPathExpression.h: Removed.
        * xpath/XPathExpression.idl: Removed.
        * xpath/XPathNSResolver.cpp: Removed.
        * xpath/XPathNSResolver.h: Removed.
        * xpath/XPathNSResolver.idl: Removed.
        * xpath/XPathNamespace.cpp: Removed.
        * xpath/XPathNamespace.h: Removed.
        * xpath/XPathResult.cpp: Removed.
        * xpath/XPathResult.h: Removed.
        * xpath/XPathResult.idl: Removed.
        * xpath/impl/XPathExpressionNode.cpp: Removed.
        * xpath/impl/XPathExpressionNode.h: Removed.
        * xpath/impl/XPathFunctions.cpp: Removed.
        * xpath/impl/XPathFunctions.h: Removed.
        * xpath/impl/XPathGrammar.y: Removed.
        * xpath/impl/XPathParser.cpp: Removed.
        * xpath/impl/XPathParser.h: Removed.
        * xpath/impl/XPathPath.cpp: Removed.
        * xpath/impl/XPathPath.h: Removed.
        * xpath/impl/XPathPredicate.cpp: Removed.
        * xpath/impl/XPathPredicate.h: Removed.
        * xpath/impl/XPathStep.cpp: Removed.
        * xpath/impl/XPathStep.h: Removed.
        * xpath/impl/XPathUtil.cpp: Removed.
        * xpath/impl/XPathUtil.h: Removed.
        * xpath/impl/XPathValue.cpp: Removed.
        * xpath/impl/XPathValue.h: Removed.
        * xpath/impl/XPathVariableReference.cpp: Removed.
        * xpath/impl/XPathVariableReference.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
harrison [Thu, 10 Aug 2006 20:37:34 +0000 (20:37 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4600112> REGRESSION: VO no longer able to review text within an edit field on web pages

        Test cases added: None.  Manual AX testing is way too awkward, and automated testing
        is not possible.  See following bug...
            <rdar://problem/4256882> Need automated testing support for accessibility APIs

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject value]):
        Add handling for text input fields.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
ddkilzer [Thu, 10 Aug 2006 05:11:25 +0000 (05:11 +0000)]
WebCore:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10247
        REGRESSION: Unable to build webkit without SVG/XPATH

        * bindings/js/kjs_binding.cpp:
        (KJS::setDOMException):
        * bindings/js/kjs_dom.cpp:
        (KJS::toJS):
        * bindings/js/kjs_html.cpp:
        (KJS::HTMLElementFunction::callAsFunction):
        * bindings/js/kjs_proxy.cpp:
        * bindings/js/kjs_proxy.h:
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMInternal.mm:
        (raiseDOMException):
        * bindings/objc/DOMXPath.mm:
        * bindings/objc/DOMXPathInternal.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/mac/WebCoreFrameBridge.mm:
        (+[WebCoreFrameBridge supportedNonImageMIMETypes]):
        * css/CSSGrammar.y:
        * css/CSSStyleDeclaration.cpp:
        (WebCore::propertyID):
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssparser.h:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::loadDefaultStyle):
        (WebCore::CSSStyleSelector::applyProperty):
        * css/cssstyleselector.h:
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::createElementNS):
        (WebCore::Document::implicitClose):
        (WebCore::Document::recalcStyleSelector):
        (WebCore::Document::createEvent):
        * dom/Document.h:
        * dom/Document.idl:
        * dom/Node.cpp:
        (WebCore::Node::createRendererIfNeeded):
        * dom/Node.h:
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::endElementNs):
        (WebCore::XMLTokenizer::insertErrorMessageBlock):
        * html/HTMLEmbedElement.cpp:
        * html/HTMLEmbedElement.h:
        * html/HTMLObjectElement.cpp:
        * html/HTMLObjectElement.h:
        * kcanvas/KCanvasCreator.cpp:
        * kcanvas/KCanvasCreator.h:
        * kcanvas/KCanvasFilters.cpp:
        * kcanvas/KCanvasFilters.h:
        * kcanvas/KCanvasImage.h:
        * kcanvas/KCanvasMatrix.cpp:
        * kcanvas/KCanvasMatrix.h:
        * kcanvas/KCanvasPath.cpp:
        * kcanvas/KCanvasPath.h:
        * kcanvas/KCanvasResourceListener.h:
        * kcanvas/KCanvasResources.cpp:
        * kcanvas/KCanvasResources.h:
        * kcanvas/KCanvasTreeDebug.cpp:
        * kcanvas/RenderForeignObject.cpp:
        * kcanvas/RenderForeignObject.h:
        * kcanvas/RenderPath.cpp:
        * kcanvas/RenderPath.h:
        * kcanvas/RenderSVGContainer.cpp:
        * kcanvas/RenderSVGContainer.h:
        * kcanvas/RenderSVGImage.cpp:
        * kcanvas/RenderSVGImage.h:
        * kcanvas/RenderSVGText.cpp:
        * kcanvas/RenderSVGText.h:
        * kcanvas/device/KRenderingDevice.cpp:
        * kcanvas/device/KRenderingDevice.h:
        * kcanvas/device/KRenderingFillPainter.cpp:
        * kcanvas/device/KRenderingFillPainter.h:
        * kcanvas/device/KRenderingPaintServer.h:
        * kcanvas/device/KRenderingPaintServerGradient.cpp:
        * kcanvas/device/KRenderingPaintServerGradient.h:
        * kcanvas/device/KRenderingPaintServerPattern.cpp:
        * kcanvas/device/KRenderingPaintServerPattern.h:
        * kcanvas/device/KRenderingPaintServerSolid.cpp:
        * kcanvas/device/KRenderingPaintServerSolid.h:
        * kcanvas/device/KRenderingStrokePainter.cpp:
        * kcanvas/device/KRenderingStrokePainter.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
        * kcanvas/device/quartz/KCanvasPathQuartz.mm:
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        * kcanvas/device/quartz/QuartzSupport.h:
        * kcanvas/device/quartz/QuartzSupport.mm:
        * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
        * ksvg2/bindings/js/JSSVGElementWrapperFactory.h:
        * ksvg2/css/SVGCSSParser.cpp:
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        * ksvg2/css/SVGRenderStyle.cpp:
        * ksvg2/css/SVGRenderStyle.h:
        * ksvg2/css/SVGRenderStyleDefs.cpp:
        * ksvg2/css/SVGRenderStyleDefs.h:
        * ksvg2/ecma/GlobalObject.cpp:
        * ksvg2/ecma/GlobalObject.h:
        * ksvg2/events/JSSVGLazyEventListener.cpp:
        * ksvg2/events/JSSVGLazyEventListener.h:
        * ksvg2/events/SVGZoomEvent.cpp:
        * ksvg2/events/SVGZoomEvent.h:
        * ksvg2/ksvg.h:
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        * ksvg2/misc/KCanvasRenderingStyle.h:
        * ksvg2/misc/KSVGTimeScheduler.cpp:
        * ksvg2/misc/KSVGTimeScheduler.h:
        * ksvg2/misc/SVGDocumentExtensions.cpp:
        * ksvg2/misc/SVGDocumentExtensions.h:
        * ksvg2/misc/SVGImageLoader.cpp:
        * ksvg2/misc/SVGImageLoader.h:
        * ksvg2/svg/DOMList.h:
        * ksvg2/svg/SVGAElement.cpp:
        * ksvg2/svg/SVGAElement.h:
        * ksvg2/svg/SVGAngle.cpp:
        * ksvg2/svg/SVGAngle.h:
        * ksvg2/svg/SVGAnimateColorElement.cpp:
        * ksvg2/svg/SVGAnimateColorElement.h:
        * ksvg2/svg/SVGAnimateElement.cpp:
        * ksvg2/svg/SVGAnimateElement.h:
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        * ksvg2/svg/SVGAnimateTransformElement.h:
        * ksvg2/svg/SVGAnimatedAngle.cpp:
        * ksvg2/svg/SVGAnimatedAngle.h:
        * ksvg2/svg/SVGAnimatedBoolean.cpp:
        * ksvg2/svg/SVGAnimatedBoolean.h:
        * ksvg2/svg/SVGAnimatedColor.cpp:
        * ksvg2/svg/SVGAnimatedColor.h:
        * ksvg2/svg/SVGAnimatedEnumeration.cpp:
        * ksvg2/svg/SVGAnimatedEnumeration.h:
        * ksvg2/svg/SVGAnimatedInteger.cpp:
        * ksvg2/svg/SVGAnimatedInteger.h:
        * ksvg2/svg/SVGAnimatedLength.cpp:
        * ksvg2/svg/SVGAnimatedLength.h:
        * ksvg2/svg/SVGAnimatedLengthList.cpp:
        * ksvg2/svg/SVGAnimatedLengthList.h:
        * ksvg2/svg/SVGAnimatedNumber.cpp:
        * ksvg2/svg/SVGAnimatedNumber.h:
        * ksvg2/svg/SVGAnimatedNumberList.cpp:
        * ksvg2/svg/SVGAnimatedNumberList.h:
        * ksvg2/svg/SVGAnimatedPathData.cpp:
        * ksvg2/svg/SVGAnimatedPathData.h:
        * ksvg2/svg/SVGAnimatedPoints.cpp:
        * ksvg2/svg/SVGAnimatedPoints.h:
        * ksvg2/svg/SVGAnimatedPreserveAspectRatio.cpp:
        * ksvg2/svg/SVGAnimatedPreserveAspectRatio.h:
        * ksvg2/svg/SVGAnimatedRect.cpp:
        * ksvg2/svg/SVGAnimatedRect.h:
        * ksvg2/svg/SVGAnimatedString.cpp:
        * ksvg2/svg/SVGAnimatedString.h:
        * ksvg2/svg/SVGAnimatedTemplate.h:
        * ksvg2/svg/SVGAnimatedTransformList.cpp:
        * ksvg2/svg/SVGAnimatedTransformList.h:
        * ksvg2/svg/SVGAnimationElement.cpp:
        * ksvg2/svg/SVGAnimationElement.h:
        * ksvg2/svg/SVGCircleElement.cpp:
        * ksvg2/svg/SVGCircleElement.h:
        * ksvg2/svg/SVGClipPathElement.cpp:
        * ksvg2/svg/SVGClipPathElement.h:
        * ksvg2/svg/SVGColor.cpp:
        * ksvg2/svg/SVGColor.h:
        * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
        * ksvg2/svg/SVGComponentTransferFunctionElement.h:
        * ksvg2/svg/SVGCursorElement.cpp:
        * ksvg2/svg/SVGCursorElement.h:
        * ksvg2/svg/SVGDOMImplementation.cpp:
        * ksvg2/svg/SVGDOMImplementation.h:
        * ksvg2/svg/SVGDefsElement.cpp:
        * ksvg2/svg/SVGDefsElement.h:
        * ksvg2/svg/SVGDescElement.cpp:
        * ksvg2/svg/SVGDescElement.h:
        * ksvg2/svg/SVGDocument.cpp:
        * ksvg2/svg/SVGDocument.h:
        * ksvg2/svg/SVGElement.cpp:
        * ksvg2/svg/SVGElement.h:
        * ksvg2/svg/SVGElementInstance.cpp:
        * ksvg2/svg/SVGElementInstance.h:
        * ksvg2/svg/SVGElementInstanceList.cpp:
        * ksvg2/svg/SVGElementInstanceList.h:
        * ksvg2/svg/SVGEllipseElement.cpp:
        * ksvg2/svg/SVGEllipseElement.h:
        * ksvg2/svg/SVGExternalResourcesRequired.cpp:
        * ksvg2/svg/SVGExternalResourcesRequired.h:
        * ksvg2/svg/SVGFEBlendElement.cpp:
        * ksvg2/svg/SVGFEBlendElement.h:
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        * ksvg2/svg/SVGFEColorMatrixElement.h:
        * ksvg2/svg/SVGFEComponentTransferElement.cpp:
        * ksvg2/svg/SVGFEComponentTransferElement.h:
        * ksvg2/svg/SVGFECompositeElement.cpp:
        * ksvg2/svg/SVGFECompositeElement.h:
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElement.h:
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        * ksvg2/svg/SVGFEDisplacementMapElement.h:
        * ksvg2/svg/SVGFEDistantLightElement.cpp:
        * ksvg2/svg/SVGFEDistantLightElement.h:
        * ksvg2/svg/SVGFEFloodElement.cpp:
        * ksvg2/svg/SVGFEFloodElement.h:
        * ksvg2/svg/SVGFEFuncAElement.cpp:
        * ksvg2/svg/SVGFEFuncAElement.h:
        * ksvg2/svg/SVGFEFuncBElement.cpp:
        * ksvg2/svg/SVGFEFuncBElement.h:
        * ksvg2/svg/SVGFEFuncGElement.cpp:
        * ksvg2/svg/SVGFEFuncGElement.h:
        * ksvg2/svg/SVGFEFuncRElement.cpp:
        * ksvg2/svg/SVGFEFuncRElement.h:
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        * ksvg2/svg/SVGFEGaussianBlurElement.h:
        * ksvg2/svg/SVGFEImageElement.cpp:
        * ksvg2/svg/SVGFEImageElement.h:
        * ksvg2/svg/SVGFELightElement.cpp:
        * ksvg2/svg/SVGFELightElement.h:
        * ksvg2/svg/SVGFEMergeElement.cpp:
        * ksvg2/svg/SVGFEMergeElement.h:
        * ksvg2/svg/SVGFEMergeNodeElement.cpp:
        * ksvg2/svg/SVGFEMergeNodeElement.h:
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        * ksvg2/svg/SVGFEOffsetElement.h:
        * ksvg2/svg/SVGFEPointLightElement.cpp:
        * ksvg2/svg/SVGFEPointLightElement.h:
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        * ksvg2/svg/SVGFESpecularLightingElement.h:
        * ksvg2/svg/SVGFESpotLightElement.cpp:
        * ksvg2/svg/SVGFESpotLightElement.h:
        * ksvg2/svg/SVGFETileElement.cpp:
        * ksvg2/svg/SVGFETileElement.h:
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        * ksvg2/svg/SVGFETurbulenceElement.h:
        * ksvg2/svg/SVGFilterElement.cpp:
        * ksvg2/svg/SVGFilterElement.h:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
        * ksvg2/svg/SVGFitToViewBox.cpp:
        * ksvg2/svg/SVGFitToViewBox.h:
        * ksvg2/svg/SVGForeignObjectElement.cpp:
        * ksvg2/svg/SVGForeignObjectElement.h:
        * ksvg2/svg/SVGGElement.cpp:
        * ksvg2/svg/SVGGElement.h:
        * ksvg2/svg/SVGGradientElement.cpp:
        * ksvg2/svg/SVGGradientElement.h:
        * ksvg2/svg/SVGHelper.cpp:
        * ksvg2/svg/SVGHelper.h:
        * ksvg2/svg/SVGImageElement.cpp:
        * ksvg2/svg/SVGImageElement.h:
        * ksvg2/svg/SVGLangSpace.cpp:
        * ksvg2/svg/SVGLangSpace.h:
        * ksvg2/svg/SVGLength.cpp:
        * ksvg2/svg/SVGLength.h:
        * ksvg2/svg/SVGLengthList.cpp:
        * ksvg2/svg/SVGLengthList.h:
        * ksvg2/svg/SVGLineElement.cpp:
        * ksvg2/svg/SVGLineElement.h:
        * ksvg2/svg/SVGLinearGradientElement.cpp:
        * ksvg2/svg/SVGLinearGradientElement.h:
        * ksvg2/svg/SVGList.h:
        * ksvg2/svg/SVGLocatable.cpp:
        * ksvg2/svg/SVGLocatable.h:
        * ksvg2/svg/SVGMarkerElement.cpp:
        * ksvg2/svg/SVGMarkerElement.h:
        * ksvg2/svg/SVGMaskElement.cpp:
        * ksvg2/svg/SVGMaskElement.h:
        * ksvg2/svg/SVGMatrix.cpp:
        * ksvg2/svg/SVGMatrix.h:
        * ksvg2/svg/SVGNumber.cpp:
        * ksvg2/svg/SVGNumber.h:
        * ksvg2/svg/SVGNumberList.cpp:
        * ksvg2/svg/SVGNumberList.h:
        * ksvg2/svg/SVGPaint.cpp:
        * ksvg2/svg/SVGPaint.h:
        * ksvg2/svg/SVGPathElement.cpp:
        * ksvg2/svg/SVGPathElement.h:
        * ksvg2/svg/SVGPathSeg.cpp:
        * ksvg2/svg/SVGPathSeg.h:
        * ksvg2/svg/SVGPathSegArc.cpp:
        * ksvg2/svg/SVGPathSegArc.h:
        * ksvg2/svg/SVGPathSegClosePath.cpp:
        * ksvg2/svg/SVGPathSegClosePath.h:
        * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
        * ksvg2/svg/SVGPathSegCurvetoCubic.h:
        * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
        * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
        * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
        * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
        * ksvg2/svg/SVGPathSegLineto.cpp:
        * ksvg2/svg/SVGPathSegLineto.h:
        * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
        * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
        * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
        * ksvg2/svg/SVGPathSegLinetoVertical.h:
        * ksvg2/svg/SVGPathSegList.cpp:
        * ksvg2/svg/SVGPathSegList.h:
        * ksvg2/svg/SVGPathSegMoveto.cpp:
        * ksvg2/svg/SVGPathSegMoveto.h:
        * ksvg2/svg/SVGPatternElement.cpp:
        * ksvg2/svg/SVGPatternElement.h:
        * ksvg2/svg/SVGPoint.cpp:
        * ksvg2/svg/SVGPoint.h:
        * ksvg2/svg/SVGPointList.cpp:
        * ksvg2/svg/SVGPointList.h:
        * ksvg2/svg/SVGPolyElement.cpp:
        * ksvg2/svg/SVGPolyElement.h:
        * ksvg2/svg/SVGPolygonElement.cpp:
        * ksvg2/svg/SVGPolygonElement.h:
        * ksvg2/svg/SVGPolylineElement.cpp:
        * ksvg2/svg/SVGPolylineElement.h:
        * ksvg2/svg/SVGPreserveAspectRatio.cpp:
        * ksvg2/svg/SVGPreserveAspectRatio.h:
        * ksvg2/svg/SVGRadialGradientElement.cpp:
        * ksvg2/svg/SVGRadialGradientElement.h:
        * ksvg2/svg/SVGRect.cpp:
        * ksvg2/svg/SVGRect.h:
        * ksvg2/svg/SVGRectElement.cpp:
        * ksvg2/svg/SVGRectElement.h:
        * ksvg2/svg/SVGSVGElement.cpp:
        * ksvg2/svg/SVGSVGElement.h:
        * ksvg2/svg/SVGScriptElement.cpp:
        * ksvg2/svg/SVGScriptElement.h:
        * ksvg2/svg/SVGSetElement.cpp:
        * ksvg2/svg/SVGSetElement.h:
        * ksvg2/svg/SVGStopElement.cpp:
        * ksvg2/svg/SVGStopElement.h:
        * ksvg2/svg/SVGStringList.cpp:
        * ksvg2/svg/SVGStringList.h:
        * ksvg2/svg/SVGStylable.cpp:
        * ksvg2/svg/SVGStylable.h:
        * ksvg2/svg/SVGStyleElement.cpp:
        * ksvg2/svg/SVGStyleElement.h:
        * ksvg2/svg/SVGStyledElement.cpp:
        * ksvg2/svg/SVGStyledElement.h:
        * ksvg2/svg/SVGStyledLocatableElement.cpp:
        * ksvg2/svg/SVGStyledLocatableElement.h:
        * ksvg2/svg/SVGStyledTransformableElement.cpp:
        * ksvg2/svg/SVGStyledTransformableElement.h:
        * ksvg2/svg/SVGSwitchElement.cpp:
        * ksvg2/svg/SVGSwitchElement.h:
        * ksvg2/svg/SVGSymbolElement.cpp:
        * ksvg2/svg/SVGSymbolElement.h:
        * ksvg2/svg/SVGTRefElement.cpp:
        * ksvg2/svg/SVGTRefElement.h:
        * ksvg2/svg/SVGTSpanElement.cpp:
        * ksvg2/svg/SVGTSpanElement.h:
        * ksvg2/svg/SVGTests.cpp:
        * ksvg2/svg/SVGTests.h:
        * ksvg2/svg/SVGTextContentElement.cpp:
        * ksvg2/svg/SVGTextContentElement.h:
        * ksvg2/svg/SVGTextElement.cpp:
        * ksvg2/svg/SVGTextElement.h:
        * ksvg2/svg/SVGTextPositioningElement.cpp:
        * ksvg2/svg/SVGTextPositioningElement.h:
        * ksvg2/svg/SVGTitleElement.cpp:
        * ksvg2/svg/SVGTitleElement.h:
        * ksvg2/svg/SVGTransform.cpp:
        * ksvg2/svg/SVGTransform.h:
        * ksvg2/svg/SVGTransformList.cpp:
        * ksvg2/svg/SVGTransformList.h:
        * ksvg2/svg/SVGTransformable.cpp:
        * ksvg2/svg/SVGTransformable.h:
        * ksvg2/svg/SVGURIReference.cpp:
        * ksvg2/svg/SVGURIReference.h:
        * ksvg2/svg/SVGUseElement.cpp:
        * ksvg2/svg/SVGUseElement.h:
        * ksvg2/svg/SVGViewElement.cpp:
        * ksvg2/svg/SVGViewElement.h:
        * ksvg2/svg/SVGZoomAndPan.cpp:
        * ksvg2/svg/SVGZoomAndPan.h:
        * ksvg2/svg/svgpathparser.cpp:
        * ksvg2/svg/svgpathparser.h:
        * page/DOMWindow.idl:
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        (WebCore::Frame::begin):
        (WebCore::Frame::pauseTimeouts):
        (WebCore::Frame::resumeTimeouts):
        * platform/GraphicsContext.h:
        * platform/cg/GraphicsContextCG.cpp:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::isTransparent):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::containingBlock):
        * rendering/RenderObject.h:
        * rendering/RenderStyle.cpp:
        (WebCore::RenderStyle::RenderStyle):
        (WebCore::RenderStyle::inheritFrom):
        (WebCore::RenderStyle::operator==):
        (WebCore::RenderStyle::inheritedNotEqual):
        (WebCore::RenderStyle::diff):
        * rendering/RenderStyle.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
        (WebCore::externalRepresentation):
        * xpath/XPathEvaluator.cpp:
        * xpath/XPathEvaluator.h:
        * xpath/XPathExpression.cpp:
        * xpath/XPathExpression.h:
        * xpath/XPathNSResolver.cpp:
        * xpath/XPathNSResolver.h:
        * xpath/XPathNamespace.cpp:
        * xpath/XPathNamespace.h:
        * xpath/XPathResult.cpp:
        * xpath/XPathResult.h:
        * xpath/impl/XPathExpressionNode.cpp:
        * xpath/impl/XPathExpressionNode.h:
        * xpath/impl/XPathFunctions.cpp:
        * xpath/impl/XPathFunctions.h:
        * xpath/impl/XPathGrammar.y:
        * xpath/impl/XPathParser.cpp:
        * xpath/impl/XPathParser.h:
        * xpath/impl/XPathPath.cpp:
        * xpath/impl/XPathPath.h:
        * xpath/impl/XPathPredicate.cpp:
        * xpath/impl/XPathPredicate.h:
        * xpath/impl/XPathStep.cpp:
        * xpath/impl/XPathStep.h:
        * xpath/impl/XPathUtil.cpp:
        * xpath/impl/XPathUtil.h:
        * xpath/impl/XPathValue.cpp:
        * xpath/impl/XPathValue.h:
        * xpath/impl/XPathVariableReference.cpp:
        * xpath/impl/XPathVariableReference.h:

        Change all #if SVG_SUPPORT to #ifdef SVG_SUPPORT and
        #if XPATH_SUPPORT to #ifdef XPATH_SUPPORT
        (except for one #if !SVG_SUPPORT to a #ifndef SVG_SUPPORT
        in RenderTreeAsText.cpp)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
rwlbuis [Tue, 8 Aug 2006 19:28:37 +0000 (19:28 +0000)]
    Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10230
        SVGDOMImplementation should die (and be rolled into DOMImplementation)

        Delete SVGDOMImplementation and references to it. The
        svg specific functionality is now in DOMImplementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
beidson [Tue, 8 Aug 2006 07:28:51 +0000 (07:28 +0000)]
WebCore:

        Reviewed by Anders and John

        Icons can now refresh when new data is sent from WebKit, both on disk and in memory

        * bridge/mac/WebCoreIconDatabaseBridge.h:
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (WebCore::IconDatabase::loadIconFromURL):  Allows WebCore/Kit to kick off a load
        outside of any greater context
        (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
        (-[WebCoreIconDatabaseBridge isIconExpiredForPageURL:]): Allows WebKit
        to get whether or not an icon has expired

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::recreateDatabase): Changed database schema slightly
        (WebCore::IconDatabase::createPrivateTables): Changed database schema slightly
        (WebCore::IconDatabase::iconForPageURL):
        (WebCore::IconDatabase::isIconExpiredForIconURL): Get if an icon has expired
        (WebCore::IconDatabase::isIconExpiredForPageURL): Get if an icon has expired
        (WebCore::IconDatabase::setIconDataForIconURL): Force a refresh of the in memory
        image when new icon data is loaded
        (WebCore::IconDatabase::setIconURLForPageURL): added a check for null iconID

        * loader/icon/IconDatabase.h: added/changed some methods
        * loader/icon/SiteIcon.cpp:
        (SiteIcon::getImage): simplified/removed debugging code
        (SiteIcon::manuallySetImageData): allow the image data to be changed when new icon
        data is loaded

WebKit:

        Reviewed by Anders and John

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):
        (-[WebIconDatabase isIconExpiredForIconURL:]): Get if an icon expired
        (-[WebIconDatabase isIconExpiredForPageURL:]): Ditto
        (-[WebIconDatabase _setIconURL:forURL:]):
        (-[WebIconDatabase _sendNotificationForURL:]): Moved to WebKitPendingPublic for use outside of WebIconDatabase
        (-[WebIconDatabase loadIconFromURL:]): Allow a load outside the context of a page load
        * Misc/WebIconDatabasePrivate.h:

        * Misc/WebIconLoader.m:
        (-[WebIconLoader didFinishLoading]): fixed up the "flipping the switch" #defs a bit
        (-[WebIconLoader willSendRequest:redirectResponse:]): override to allow a load
        outside of the context of a page load

        * WebCoreSupport/WebIconDatabaseBridge.h: Added.
        * WebCoreSupport/WebIconDatabaseBridge.m: Added.
        (-[WebIconDatabaseBridge init]):
        (-[WebIconDatabaseBridge dealloc]):
        (-[WebIconDatabaseBridge loadIconFromURL:]):  Kick off a load on an icon outside
        of the context of any page load
        (-[WebIconDatabaseBridge _setIconData:forIconURL:]):  WebKit side of bridge method
        (-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]):  WebKit side of bridge method
        (-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]):
        (+[WebIconDatabaseBridge sharedBridgeInstance]): Moved this from WebCore to WebKit
        so both sides of the bridge get the WebKit version
        * WebKit.xcodeproj/project.pbxproj: Added some files
        * WebView/WebDataSource.m:
        (-[WebDataSource _loadIcon]): Added check for reload/expired icon to force
        a load even if we already have it

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFixing the build for the newer Bison and our new use of -Wundef. Turns off -Wundef...
thatcher [Mon, 7 Aug 2006 06:10:29 +0000 (06:10 +0000)]
Fixing the build for the newer Bison and our new use of -Wundef. Turns off -Wundef for WebKit because <CoreGraphics/CGBase.h> causes a warning we can't fix. We can turn it back on once this radar is fixed: <rdar://problem/4669823> CGBase.h fails to build with -Wundef enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric Seidel.
darin [Sat, 5 Aug 2006 23:53:03 +0000 (23:53 +0000)]
    Reviewed by Eric Seidel.

        - fix a storage leak

        * rendering/RenderView.cpp: (WebCore::RenderView::setSelection):
        Delete the values if we are going to exit without using the maps.
        Otherwise all the values leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Sat, 5 Aug 2006 20:14:47 +0000 (20:14 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10213
          REGRESSION: Crash in WebCore::RenderLayer::isTransparent involving <iframe> and <select>

        * fast/frames/iframe-option-crash-expected.checksum: Added.
        * fast/frames/iframe-option-crash-expected.png: Added.
        * fast/frames/iframe-option-crash-expected.txt: Added.
        * fast/frames/iframe-option-crash.xhtml: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10213
          REGRESSION: Crash in WebCore::RenderLayer::isTransparent involving <iframe> and <select>

        Test: fast/frames/iframe-option-crash.xhtml

        * rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
        Check for a nil renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix for Radar bug #4644045, regression where dragging selection no longer
hyatt [Fri, 4 Aug 2006 23:27:12 +0000 (23:27 +0000)]
    Fix for Radar bug #4644045, regression where dragging selection no longer
        works for floats contained inside layers.  I added an optimization to
        refine dirty rect checking for layers, and it incorrectly excluded floats
        from the paint bounds since PaintPhaseSelection was not considered when
        analyzing the floatRect().

        Reviewed by beth

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix remove() so that it is equivalent to calling removeChild on the
hyatt [Fri, 4 Aug 2006 23:19:34 +0000 (23:19 +0000)]
    Fix remove() so that it is equivalent to calling removeChild on the
        parent.  This involved moving three operations that remove did.

        (1) Move the accessibility object cache removal into the destroy methods,
        since this really should just happen when a render object is going away.

        (2) removeFromObjectLists shifted into removeChild, which means it will
        now be called more often (this is a correct change).  Note that there is
        also now a new guard on removeFromObjectLists so that it won't do any
        work unless the document is not being destroyed.

        (3) The big one.  deleteLineBoxWrapper was not getting called to clean up
        the line box tree.  This moved right into RenderContainer's removeChildNode so
        that it is now done even in the lowest level RenderContainer removal primitive.

        Reviewed by beth

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::removeChildNode):
        (WebCore::RenderContainer::removeChild):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::removeFromObjectLists):
        (WebCore::RenderObject::destroy):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::remove):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff's rubber stamp
beidson [Fri, 4 Aug 2006 21:12:32 +0000 (21:12 +0000)]
    Reviewed by Geoff's rubber stamp

        Fix a build break on Intel hardware causes by adapting stricter
        compiler warnings (-Wshorten-64-to-32)

        * API/testapi.c:
        (assertEqualsAsNumber): manually cast some doubles to floats
        (main): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdd layout test for list marker crash
hyatt [Fri, 4 Aug 2006 21:04:35 +0000 (21:04 +0000)]
Add layout test for list marker crash

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Back out the fix for list marker crashes. The actual bug here is that
hyatt [Fri, 4 Aug 2006 21:04:11 +0000 (21:04 +0000)]
    Back out the fix for list marker crashes.  The actual bug here is that
        there is a confusing mismatch between remove() and removeChild() in the
        render tree.  remove() does a little bit of extra work that removeChild
        should be doing instead (so that remove() can just be a shorthand for
        removeChild).

        This conservative fix does not solve the remove/removeChild mismatch
        but instead just changes the list marker updating code to use remove
        instead.

        Reviewed by beth

        Test Case: fast/lists/dynamic-marker-crash.html

        * rendering/ListMarkerBox.cpp:
        * rendering/ListMarkerBox.h:
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::updateMarkerLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
weinig [Fri, 4 Aug 2006 18:57:40 +0000 (18:57 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192
          Make WebCore (and friends) compile with -Wshorten-64-to-32

          * Adds -Wshorten-64-to-32 flag to Xcode project.
          * Adds explicit casts where OK.

        * API/JSNodeList.c:
        (JSNodeList_item):
        (JSNodeList_getProperty):
        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Reviewed by Darin.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192
          Make WebCore (and friends) compile with -Wshorten-64-to-32

          * Adds -Wshorten-64-to-32 flag to Xcode project.

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Reviewed by Darin.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192
          Make WebCore (and friends) compile with -Wshorten-64-to-32

          * Adds -Wshorten-64-to-32 flag to Xcode project.
          * Adds 'f' to float literals where expecting a float.
          * Use cosf() instead of cos() when assigning to a float.

        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/device/quartz/filters/WKDiffuseLightingFilter.m:
        (+[WKDiffuseLightingFilter initialize]):
        * kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m:
        (-[WKDiscreteTransferFilter outputImage]):
        * kcanvas/device/quartz/filters/WKDisplacementMapFilter.m:
        (+[WKDisplacementMapFilter initialize]):
        * kcanvas/device/quartz/filters/WKSpecularLightingFilter.m:
        (+[WKSpecularLightingFilter initialize]):
        * kcanvas/device/quartz/filters/WKSpotLightFilter.m:
        (-[WKSpotLightFilter outputImage]):
        * kcanvas/device/quartz/filters/WKTableTransferFilter.m:
        (-[WKTableTransferFilter outputImage]):

WebKit:

        Reviewed by Darin.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192
          Make WebCore (and friends) compile with -Wshorten-64-to-32

          * Adds 'f' to float literals where expecting a float.
          * Use ceilf() instead of ceil() when assigning to a float.
          * Adds explicit casts where OK.

          NOTE: The -Wshorten-64-to-32 flag was not added for WebKit
          because there are still a few places where no error handling
          is in place.  The flag can be added as soon as those are worked
          out.

        * Misc/WebNSControlExtras.m:
        (-[NSControl sizeToFitAndAdjustWindowHeight]):
        * Misc/WebNSImageExtras.m:
        (-[NSImage _web_scaleToMaxSize:]):
        * Misc/WebNSViewExtras.h:
        * Misc/WebNSViewExtras.m:
        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView drawRect:]):
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge expiresTimeForResponse:]):
        * WebInspector/WebInspector.m:
        (-[NSWindow window]):
        (-[WebInspector treeViewScrollTo:]):
        (-[WebInspector _updateSystemColors]):
        (-[WebInspector webView:plugInViewWithArguments:]):
        (-[WebInspector outlineView:objectValueForTableColumn:byItem:]):
        * WebInspector/WebInspectorOutlineView.m:
        (-[WebInspectorOutlineView _highlightRow:clipRect:]):
        * WebInspector/WebNodeHighlight.m:
        (-[WebNodeHighlight initWithBounds:andRects:forView:]):
        * WebInspector/WebNodeHighlightView.m:
        (-[WebNodeHighlightView roundedRect:withRadius:]):
        (-[WebNodeHighlightView initWithHighlight:andRects:forView:]):
        (-[WebNodeHighlightView drawRect:]):
        * WebView/WebFrame.m:
        (-[WebFrame _opened]):
        * WebView/WebFrameView.m:
        (-[WebFrameView initWithFrame:]):
        * WebView/WebHTMLView.m:
        (-[WebHTMLView _dragImageForLinkElement:]):
        (-[WebHTMLView _web_setPrintingModeRecursive]):
        (-[WebHTMLView _web_clearPrintingModeRecursive]):
        (-[NSArray layout]):
        (-[NSArray _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
        (-[NSArray adjustPageHeightNew:top:bottom:limit:]):
        (-[NSArray _scaleFactorForPrintOperation:]):
        (-[NSArray setPageWidthForPrinting:]):
        (-[NSArray _endPrintMode]):
        (-[NSArray knowsPageRange:]):
        (-[NSArray _originalFontA]):
        (-[NSArray _originalFontB]):
        (-[WebTextCompleteController _buildUI]):
        (-[WebTextCompleteController _placePopupWindow:]):
        * WebView/WebPDFView.m:
        (-[WebPDFView _makeTextStandardSize:]):
        (-[WebPDFView selectionImageForcingWhiteText:]):
        (-[PDFPrefUpdatingProxy forwardInvocation:]):
        * WebView/WebPreferences.m:
        (-[WebPreferences _floatValueForKey:]):
        * WebView/WebView.m:
        (-[WebView makeTextSmaller:]):
        (-[WebView canMakeTextStandardSize]):
        (-[WebView makeTextStandardSize:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Anders.
aroben [Fri, 4 Aug 2006 16:55:33 +0000 (16:55 +0000)]
    Reviewed by Anders.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Convert
        spaces to tabs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebKit:
ddkilzer [Fri, 4 Aug 2006 11:23:37 +0000 (11:23 +0000)]
WebKit:

        Reviewed by NOBODY (build fix).

        * WebCoreSupport/WebSubresourceLoader.m: REALLY moved to Loader/
        * WebView/WebFrameLoader.h: REALLY moved to Loader/
        * WebView/WebFrameLoader.m: REALLY moved to Loader/
        * WebView/WebLoader.h: REALLY moved to Loader/
        * WebView/WebLoader.m: REALLY moved to Loader/
        * WebView/WebMainResourceLoader.m: REALLY moved to Loader/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoMinor tweak to earlier patch. Use containsFloats instad.
hyatt [Fri, 4 Aug 2006 05:41:43 +0000 (05:41 +0000)]
Minor tweak to earlier patch.  Use containsFloats instad.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Fri, 4 Aug 2006 05:35:47 +0000 (05:35 +0000)]
    Reviewed by Darin.

        - moved all loader code that is slated to be moved down to WebCore to a new Loader directory

        (next step is to remove dependencies on the rest of WebKit from this directory)

        * Loader/WebNetscapePlugInStreamLoader.h: Added.
        * Loader/WebNetscapePlugInStreamLoader.m: Added. Cut out of WebNetscapePluginStream.m
        (-[WebNetscapePlugInStreamLoader initWithStream:view:]):
        (-[WebNetscapePlugInStreamLoader isDone]):
        (-[WebNetscapePlugInStreamLoader releaseResources]):
        (-[WebNetscapePlugInStreamLoader didReceiveResponse:]):
        (-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:]):
        (-[WebNetscapePlugInStreamLoader didFinishLoading]):
        (-[WebNetscapePlugInStreamLoader didFailWithError:]):
        (-[WebNetscapePlugInStreamLoader cancelWithError:]):
        * Plugins/WebNetscapePluginStream.m:
        * WebKit.xcodeproj/project.pbxproj:
        * WebCoreSupport/WebSubresourceLoader.h: Moved to Loader/
        * WebCoreSupport/WebSubresourceLoader.m: Moved to Loader/
        * WebView/WebFrameLoader.h: Moved to Loader/
        * WebView/WebFrameLoader.m: Moved to Loader/
        * WebView/WebLoader.h: Moved to Loader/
        * WebView/WebLoader.m: Moved to Loader/
        * WebView/WebMainResourceLoader.h: Moved to Loader/
        * WebView/WebMainResourceLoader.m: Moved to Loader/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Kevin Decker.
tomernic [Fri, 4 Aug 2006 02:08:09 +0000 (02:08 +0000)]
    Reviewed by Kevin Decker.

        <rdar://problem/4667460> Windowless OpenGL plug-ins render incorrectly on PowerPC

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
        Fixed color component swapping so that it works on both x86 and PPC.  See comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@15792 268f45cc-cd09-0410...
hyatt [Fri, 4 Aug 2006 01:38:14 +0000 (01:38 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix for bug 10229, don't bother trying to clear when no floats are
hyatt [Fri, 4 Aug 2006 01:35:07 +0000 (01:35 +0000)]
    Fix for bug 10229, don't bother trying to clear when no floats are
        present.  I suspect there's still a bug in the math that follows, but
        this fix is safer in that it just does the obvious thing (and doesn't
        compute any clearance if no floats are even around).

        Reviewed by maciej

        * ChangeLog:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::getClearDelta):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
justing [Fri, 4 Aug 2006 00:42:39 +0000 (00:42 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/style/non-inheritable-styles-expected.checksum: Added.
        * editing/style/non-inheritable-styles-expected.png: Added.
        * editing/style/non-inheritable-styles-expected.txt: Added.
        * editing/style/non-inheritable-styles.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4641033/4515463/4052426/4046570/4053718/4053724/4060115/4062858>
        Copy/Paste fidelity was bad.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyInlineStyle):
        * editing/markup.cpp:
        (WebCore::startMarkup): We were not adding non-inheritable styles
        to the markup for an element unless they were in the elements inline
        style declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Cleaned up the ChangeLog from last checkin
beidson [Fri, 4 Aug 2006 00:37:55 +0000 (00:37 +0000)]
    Cleaned up the ChangeLog from last checkin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim Hatcher's rubber stamp
beidson [Fri, 4 Aug 2006 00:00:48 +0000 (00:00 +0000)]
    Reviewed by Tim Hatcher's rubber stamp
        Fixed Intel build break caused by weinig's -W change in r15781

        * WebView/WebView.m: wrapped cpu-dependent defs with defined() macro

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John.
mjs [Thu, 3 Aug 2006 22:58:11 +0000 (22:58 +0000)]
    Reviewed by John.

        - fixed problem that could cause assertion failures in Safari

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Don't
        allow a plugin to start new loads once its document is no longer the one actively loading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John.
mjs [Thu, 3 Aug 2006 22:33:56 +0000 (22:33 +0000)]
    Reviewed by John.

        - remove use of WebDataSource from WebLoader and subclasses, just have them talk to the
        WebFrameLoader instead.

        For now this is done by forarding all the calls.

        * Misc/WebIconLoader.m:
        (-[WebIconLoader didFinishLoading]):
        * Plugins/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
        (-[WebNetscapePluginStream start]):
        (-[WebNetscapePlugInStreamLoader didFinishLoading]):
        (-[WebNetscapePlugInStreamLoader didFailWithError:]):
        (-[WebNetscapePlugInStreamLoader cancelWithError:]):
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
        (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
        * WebCoreSupport/WebSubresourceLoader.h:
        * WebCoreSupport/WebSubresourceLoader.m:
        (-[WebSubresourceLoader initWithLoader:frameLoader:]):
        (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
        (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forFrameLoader:]):
        (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forFrameLoader:]):
        (-[WebSubresourceLoader receivedError:]):
        (-[WebSubresourceLoader signalFinish]):
        (-[WebSubresourceLoader didFailWithError:]):
        (-[WebSubresourceLoader cancel]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m:
        (-[WebDataSource _updateLoading]):
        (-[WebDataSource textEncodingName]):
        (-[WebDataSource _mainReceivedBytesSoFar:complete:]):
        * WebView/WebFrameLoader.h:
        * WebView/WebFrameLoader.m:
        (-[WebFrameLoader loadIconWithRequest:]):
        (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
        (-[WebFrameLoader clearIconLoader]):
        (-[WebFrameLoader commitProvisionalLoad]):
        (-[WebFrameLoader activeDataSource]):
        (-[WebFrameLoader _archivedSubresourceForURL:]):
        (-[WebFrameLoader _defersCallbacks]):
        (-[WebFrameLoader _identifierForInitialRequest:]):
        (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
        (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
        (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
        (-[WebFrameLoader _didReceiveResponse:forResource:]):
        (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
        (-[WebFrameLoader _didFinishLoadingForResource:]):
        (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
        (-[WebFrameLoader _privateBrowsingEnabled]):
        (-[WebFrameLoader _addPlugInStreamLoader:]):
        (-[WebFrameLoader _removePlugInStreamLoader:]):
        (-[WebFrameLoader _finishedLoadingResource]):
        (-[WebFrameLoader _receivedError:]):
        (-[WebFrameLoader _addSubresourceLoader:]):
        (-[WebFrameLoader _removeSubresourceLoader:]):
        (-[WebFrameLoader _originalRequest]):
        (-[WebFrameLoader webFrame]):
        (-[WebFrameLoader _receivedMainResourceError:complete:]):
        (-[WebFrameLoader initialRequest]):
        (-[WebFrameLoader _receivedData:]):
        (-[WebFrameLoader _setRequest:]):
        (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
        (-[WebFrameLoader _handleFallbackContent]):
        (-[WebFrameLoader _isStopping]):
        (-[WebFrameLoader _decidePolicyForMIMEType:decisionListener:]):
        (-[WebFrameLoader _setupForReplaceByMIMEType:]):
        (-[WebFrameLoader _setResponse:]):
        (-[WebFrameLoader _mainReceivedError:complete:]):
        (-[WebFrameLoader _finishedLoading]):
        (-[WebFrameLoader _mainReceivedBytesSoFar:complete:]):
        (-[WebFrameLoader _iconLoaderReceivedPageIcon:]):
        (-[WebFrameLoader _URL]):
        * WebView/WebLoader.h:
        * WebView/WebLoader.m:
        (-[NSURLProtocol releaseResources]):
        (-[NSURLProtocol loadWithRequest:]):
        (-[NSURLProtocol setFrameLoader:]):
        (-[NSURLProtocol frameLoader]):
        (-[NSURLProtocol willSendRequest:redirectResponse:]):
        (-[NSURLProtocol didReceiveAuthenticationChallenge:]):
        (-[NSURLProtocol didCancelAuthenticationChallenge:]):
        (-[NSURLProtocol didReceiveResponse:]):
        (-[NSURLProtocol didReceiveData:lengthReceived:]):
        (-[NSURLProtocol signalFinish]):
        (-[NSURLProtocol didFailWithError:]):
        (-[NSURLProtocol willCacheResponse:]):
        (-[NSURLProtocol cancelWithError:]):
        * WebView/WebMainResourceLoader.h:
        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader initWithFrameLoader:]):
        (-[WebMainResourceLoader receivedError:]):
        (-[WebMainResourceLoader cancelWithError:]):
        (-[WebMainResourceLoader _isPostOrRedirectAfterPost:redirectResponse:]):
        (-[WebMainResourceLoader addData:]):
        (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
        (-[WebMainResourceLoader continueAfterContentPolicy:]):
        (-[WebMainResourceLoader checkContentPolicyForResponse:]):
        (-[WebMainResourceLoader didReceiveResponse:]):
        (-[WebMainResourceLoader didReceiveData:lengthReceived:]):
        (-[WebMainResourceLoader didFinishLoading]):
        (-[WebMainResourceLoader didFailWithError:]):
        (-[WebMainResourceLoader loadWithRequestNow:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
weinig [Thu, 3 Aug 2006 21:55:57 +0000 (21:55 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176
          Make WebCore compile with -Wundef

          * Adds -Wundef flag to Xcode project
          * Converts #ifs to #ifdef and #ifndefs where needed.
          * Added #define YYMAXDEPTH 10000 in kjs/grammar.y
            to fix a warning from within Bison.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/jni/jni_jsobject.cpp:
        (JavaJSObject::getSlot):
        (JavaJSObject::setSlot):
        * bindings/npapi.h:
        * bindings/objc/objc_class.mm:
        (KJS::Bindings::ObjcClass::methodsNamed):
        (KJS::Bindings::ObjcClass::fieldNamed):
        * bindings/objc/objc_instance.mm:
        (ObjcInstance::invokeMethod):
        * bindings/objc/objc_runtime.mm:
        (ObjcMethod::getMethodSignature):
        (ObjcField::name):
        (ObjcField::type):
        * kjs/grammar.y:
        * kjs/identifier.h:

JavaScriptGlue:

        Reviewed by Darin.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176
          Make WebCore compile with -Wundef

          * Adds -Wundef flag to Xcode project

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Reviewed by Darin.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176
          Make WebCore compile with -Wundef

          * Adds -Wundef flag to Xcode project
          * Converts #ifs to #ifdef and #ifndefs where needed.
          * Replaces #ifdef WIN32 with #if PLATFORM(WIN_OS) or PLATFORM(WIN)
            (and in one instance in config.h with #if !COMPILER(MSVC))
          * Added #define YYMAXDEPTH 10000 in XPathGrammar.y and CSSGrammar.y
            to fix a warning from within Bison.
          * Cleaned up style a little in surrounding code.

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
        * config.h:
        * css/CSSGrammar.y:
        * css/MediaFeatureNames.cpp:
        * css/MediaFeatureNames.h:
        * css/cssparser.cpp:
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::setActive):
        * dom/Element.cpp:
        (WebCore::Element::attach):
        * dom/Element.h:
        * dom/EventNames.cpp:
        * dom/EventNames.h:
        * dom/NamedAttrMap.h:
        * dom/Position.cpp:
        * dom/QualifiedName.cpp:
        * dom/QualifiedName.h:
        * dom/Range.h:
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::error):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptHandler):
        (WebCore::HTMLTokenizer::scriptExecution):
        (WebCore::HTMLTokenizer::parseTag):
        (WebCore::HTMLTokenizer::continueProcessing):
        (WebCore::HTMLTokenizer::write):
        (WebCore::HTMLTokenizer::timerFired):
        (WebCore::HTMLTokenizer::notifyFinished):
        * kcanvas/device/quartz/KCanvasFilterQuartz.h:
        * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
        * ksvg2/css/SVGRenderStyle.h:
        * ksvg2/css/SVGRenderStyleDefs.h:
        * ksvg2/scripts/make_names.pl:
        * loader/CachedResource.h:
        * loader/LoaderFunctions.h:
        * loader/loader.h:
        * page/Frame.cpp:
        * page/FrameTree.cpp:
        * page/FrameView.cpp:
        (WebCore::FrameView::clear):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::layoutTimerFired):
        (WebCore::FrameView::scheduleRelayout):
        (WebCore::FrameView::unscheduleRelayout):
        * platform/AtomicString.cpp:
        * platform/AtomicString.h:
        * platform/Cursor.h:
        * platform/DeprecatedArray.h:
        * platform/DeprecatedString.cpp:
        (WebCore::allocateHandle):
        (WebCore::initializeHandleNodeBlock):
        (WebCore::freeHandle):
        * platform/FloatPoint.h:
        * platform/FloatRect.h:
        * platform/FloatSize.h:
        * platform/GraphicsContext.h:
        * platform/Image.h:
        * platform/IntPoint.h:
        * platform/IntRect.h:
        (WebCore::IntRect::inflateX):
        (WebCore::IntRect::inflateY):
        * platform/IntSize.h:
        * platform/PlatformKeyboardEvent.h:
        * platform/PlatformMouseEvent.h:
        * platform/PlatformString.h:
        * platform/ResourceLoader.h:
        * platform/ResourceLoaderInternal.h:
        (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
        * platform/ScrollView.h:
        * platform/StaticConstructors.h:
        * platform/StreamingTextDecoderICU.cpp:
        (WebCore::StreamingTextDecoderICU::convert):
        * platform/StringImpl.h:
        * platform/Widget.h:
        * platform/mac/BlockExceptions.mm:
        * platform/mac/ColorMac.mm:
        (+[WebCoreControlTintObserver WebCore]):
        * platform/mac/FloatPointMac.mm:
        * platform/mac/FloatRectMac.mm:
        * platform/mac/FloatSizeMac.mm:
        * platform/mac/FontMac.mm:
        * platform/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/mac/IntPointMac.mm:
        * platform/mac/IntRectMac.mm:
        * platform/mac/IntSizeMac.mm:
        * platform/mac/WebCoreSystemInterface.h:
        * rendering/RenderBlock.h:
        * rendering/RenderTableCell.h:
        * rendering/bidi.cpp:
        (WebCore::appendRun):
        (WebCore::RenderBlock::layoutInlineChildren):
        * xml/XSLTProcessor.cpp:
        (WebCore::parseErrorFunc):
        * xpath/impl/XPathGrammar.y:

WebKit:

        Reviewed by Darin.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176
          Make WebCore compile with -Wundef

          * Adds -Wundef flag to Xcode project
          * Converts #ifs to #ifdef and #ifndefs where needed.

        * Carbon/CarbonUtils.m:
        * Carbon/CarbonWindowAdapter.m:
        * Carbon/HIViewAdapter.m:
        (+[NSView bindHIViewToNSView:nsView:]):
        * Carbon/HIWebView.m:
        (HIWebViewEventHandler):
        * Misc/WebFileDatabase.m:
        (UniqueFilePathForKey):
        * Misc/WebNSWindowExtras.m:
        (swizzleInstanceMethod):
        * Misc/WebTypesInternal.h:
        * Plugins/WebNetscapeDeprecatedFunctions.c:
        * Plugins/WebNetscapeDeprecatedFunctions.h:
        * Plugins/WebNetscapePluginPackage.h:
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage unloadWithoutShutdown]):
        (-[WebNetscapePluginPackage load]):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by darin
justing [Thu, 3 Aug 2006 20:25:28 +0000 (20:25 +0000)]
    Reviewed by darin

        * fast/forms/plaintext-mode-1-expected.txt:
        * fast/forms/plaintext-mode-1.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-08-03 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 3 Aug 2006 19:33:38 +0000 (19:33 +0000)]
2006-08-03  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by John Sullivan.

       * wtf/HashSet.h:
        (WTF::::operator):
        Return *this in operator=

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej and Beth.
aroben [Thu, 3 Aug 2006 19:29:13 +0000 (19:29 +0000)]
    Reviewed by Maciej and Beth.

        Fix use-after-dispose heap corruption bug.

        * rendering/ListMarkerBox.cpp:
        (WebCore::ListMarkerBox::destroy): Only call removeChild if we're not
        destroying the document

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
aroben [Thu, 3 Aug 2006 19:18:11 +0000 (19:18 +0000)]
JavaScriptCore:
        Reviewed by Anders.

        - Fixed Windows build

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * wtf/MathExtras.h: Implement inline versions of these functions
        (nextafter):
        (nextafterf):

WebCore:
        Reviewed by Anders.

        - Fixed Windows build.

        * platform/Color.cpp:
        (WebCore::makeRGBAFromHSLA): Whitespace change
        * platform/win/TemporaryLinkStubs.cpp: Add new method stubs
        (PlatformScrollBar::PlatformScrollBar):
        (PlatformScrollBar::~PlatformScrollBar):
        (PlatformScrollBar::width):
        (PlatformScrollBar::height):
        (PlatformScrollBar::setEnabled):
        (PlatformScrollBar::paint):
        (PlatformScrollBar::setScrollBarValue):
        (PlatformScrollBar::setKnobProportion):
        (PlatformScrollBar::setRect):
        (ScrollBar::ScrollBar):
        (ScrollBar::scroll):
        (ScrollBar::setValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
justing [Thu, 3 Aug 2006 18:04:42 +0000 (18:04 +0000)]
LayoutTests:

        Reviewed by mjs

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=10225>
        GMail Editor: Change Hilite Color doesn't work

        * editing/execCommand/hilitecolor-expected.checksum: Added.
        * editing/execCommand/hilitecolor-expected.png: Added.
        * editing/execCommand/hilitecolor-expected.txt: Added.
        * editing/execCommand/hilitecolor.html: Added.

WebCore:

        Reviewed by mjs

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=10225>
        GMail Editor: Change Hilite Color doesn't work

        * editing/JSEditor.cpp: Added support for execCommand("HiliteColor", ...).
        It's what GMail uses to implement text hiliting.  It's just a synonym for BackColor.
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::nodeWillBeRemoved): Moved a comment
        a more appropriate place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-08-03 Mark Rowe <opendarwin.org@bdash.net.nz>
darin [Thu, 3 Aug 2006 15:36:13 +0000 (15:36 +0000)]
2006-08-03  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Darin.

        Bug 10224: [Drosera] Drosera icon should be set on DroseraLauncher so it appears in nightly builds
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10224

        * Drosera/Drosera.xcodeproj/project.pbxproj:
        * Drosera/LauncherInfo.plist:

2006-08-03  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        - fix ASSERTION FAILURE: draggingDocumentView == nil in -[WebViewPrivate dealloc]
          when a test performs an unsuccessful drag and drop operation.

        * DumpRenderTree/EventSendingController.m:
        (-[EventSendingController mouseUp]): Added a call to -draggingExited: if the
        drag operation for the mouse release is NSDragOperationNone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Thu, 3 Aug 2006 15:34:13 +0000 (15:34 +0000)]
LayoutTests:

        Reviewed by Adele and Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10177
          REGRESSION: Successfully dragging text into a disabled field

        * fast/forms/textfield-drag-into-disabled-expected.checksum: Added.
        * fast/forms/textfield-drag-into-disabled-expected.png: Added.
        * fast/forms/textfield-drag-into-disabled-expected.txt: Added.
        * fast/forms/textfield-drag-into-disabled.html: Added.

        * fast/forms/input-disabled-color-expected.txt: Updated.

WebCore:

        Reviewed by Adele and Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10177
          REGRESSION: Successfully dragging text into a disabled field

        Test: fast/forms/textfield-drag-into-disabled.html

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::createDivStyle): Changed to set -webkit-user-modify
        to read-only on the inner div if the control is disabled.
        (WebCore::RenderTextControl::updateFromElement): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Thu, 3 Aug 2006 15:24:49 +0000 (15:24 +0000)]
LayoutTests:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10198
          REGRESSION: WebKit r15750 crashes while loading anthem.com

        * fast/overflow/generated-content-crash-expected.txt: Added.
        * fast/overflow/generated-content-crash.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10198
          REGRESSION: WebKit r15750 crashes while loading anthem.com

        Test: fast/overflow/generated-content-crash.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateScrollInfoAfterLayout): Added a null check for
        the renderer's element. Generated content does not have an element and
        therefore does not need to maintain overflow status.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Thu, 3 Aug 2006 15:22:52 +0000 (15:22 +0000)]
LayoutTests:

        Reviewed by Anders.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10202
          REGRESSION: Repro crash when loading an empty image document

        * fast/tokenizer/image-empty-crash-expected.txt: Added.
        * fast/tokenizer/image-empty-crash.html: Added.

WebCore:

        Reviewed by Anders.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10202
          REGRESSION: Repro crash when loading an empty image document

        Test: fast/tokenizer/image-empty-crash.html

        * loader/ImageDocument.cpp:
        (WebCore::ImageTokenizer::stopParsing): Added null check for m_imageElement.
        (WebCore::ImageTokenizer::finish): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Anders.
darin [Thu, 3 Aug 2006 15:21:10 +0000 (15:21 +0000)]
    Reviewed by Anders.

        - clean up "flip"-related code a tiny bit

        * platform/Screen.h: Removed redundant parameter names.
        * platform/mac/ScreenMac.mm:
        (WebCore::flipScreenRect): Changed to call flipScreenPoint so we only have one
        copy of the flipping code.
        (WebCore::flipScreenPoint): Fixed indentation.

        * bridge/mac/WebCoreFrameBridge.mm: (globalPoint): Removed type casts and
        simplified a bit.

        * platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPositionForEvent):
        * platform/mac/WheelEventMac.mm: (WebCore::globalPositionForEvent):
        Removed unneeded local variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric Seidel.
darin [Thu, 3 Aug 2006 15:17:54 +0000 (15:17 +0000)]
    Reviewed by Eric Seidel.

        - fix storage leak

        * WebView/WebFrame.m: (-[WebFramePrivate dealloc]): Release the frame loader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rubber stamped by Maciej.
thatcher [Thu, 3 Aug 2006 06:08:04 +0000 (06:08 +0000)]
    Rubber stamped by Maciej.

        Adding back resultsWithXpathQuery, removed by Darin's earlier change.
        This function is called from ObjC, but not used from JavaScript.

        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
thatcher [Wed, 2 Aug 2006 23:18:00 +0000 (23:18 +0000)]
    Reviewed by Darin.

        Bug 9632: [Drosera] syntax highlighting is slow (reproducible 40 second hang)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9632

        Do not change the file source when normalizing the line endings.
        We use this file source to compare against new versions of the source
        as it comes in, so we can skip re-syntax highlighting if they are the same.
        The problem is apparent on yahoo.com since they have mixed line endings and
        once we normalize them the source will always be different. This was
        compounded by the fact that yahoo has around 40 inline scripts. Each
        inline script causes us to check if the main document has more loaded,
        that is when we compare the source strings. Since they are always different
        we would syntax highlight yahoo.com 40 times! We do check source length before
        doing a more expensive string comparison, but the lengths were the same.

        * Drosera/debugger.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
thatcher [Wed, 2 Aug 2006 23:15:27 +0000 (23:15 +0000)]
    Reviewed by Darin.

        Bug 10200: [Drosera] Deadlock between Drosera and Safari while loading page
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10200

        Prevent reentrancy in our debugger callbacks. This was causing a deadlock in Drosera because
        suspendProcessIfPaused was being called during a DO call into Safari.

        Preventing reentrancy also prevents scripts that Drosera injects and evaluates from showing
        up in rare cases (such as a iframe loading about:blank). I thought this would prevent cases
        where you call a function from the console and expect it to break on a breakpoint in them, but
        this appears to never have worked even without this change. When that is figured out we can
        reconsider a better solution to reentrancy. I have filed that as bug 10214.

        I also removed the NSRunLoop runMode:beforeDate: calls since DO handles this for us since
        we don't use "onway void" as the return type for the callbacks. Note: using onway void for
        the listener callbacks causes bad synchronization issues and obscure crashes.

        * DefaultDelegates/WebScriptDebugServer.m:
        (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]):
        (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
        (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
        (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
        (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]):
        (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
        (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
        * DefaultDelegates/WebScriptDebugServerPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Abstract RenderLayer scrollbar creation and destruction so that there
hyatt [Wed, 2 Aug 2006 22:59:51 +0000 (22:59 +0000)]
    Abstract RenderLayer scrollbar creation and destruction so that there
        is a clean spot in which to drop in engine scrollbar stuff.

        Reviewed by timo

        * platform/ScrollBar.h:
        (WebCore::ScrollBar::hasPlatformScrollBars):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::createScrollbar):
        (WebCore::RenderLayer::destroyScrollbar):
        (WebCore::RenderLayer::setHasHorizontalScrollbar):
        (WebCore::RenderLayer::setHasVerticalScrollbar):
        * rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by TimO.
ggaren [Wed, 2 Aug 2006 22:58:23 +0000 (22:58 +0000)]
    Reviewed by TimO.

        Tweaked the build instructions a bit.

        * building/build.html:
        * building/debug.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix by Mitz Pettel, reviewed by Darin.
ap [Wed, 2 Aug 2006 20:32:45 +0000 (20:32 +0000)]
    Fix by Mitz Pettel, reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3438
          incorrect display of transparent 1x1 PNGs

        Test: fast/replaced/image-solid-color-with-alpha.html

        * platform/mac/ImageMac.mm:
        (WebCore::Image::checkForSolidColor): Changed to divide each color component
        by the alpha component. You need to do that since the bitmap context has
        premultiplied alpha but m_solidColor should be non-premultiplied.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
aroben [Wed, 2 Aug 2006 20:26:11 +0000 (20:26 +0000)]
    Reviewed by Darin.

        - Fixed build

        * kjs/date_object.cpp:
        (KJS::formatTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John.
mjs [Wed, 2 Aug 2006 19:06:45 +0000 (19:06 +0000)]
    Reviewed by John.

        - fix assertion failure on layout tests by stopping plugins from loading at a clearly defined time
        - add more assertions for safety

        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]): Removed obsolete comment.
        (-[WebDataSource _updateLoading]): Add assertion ensuring this method is only called
        at a time when this data source is the one that might be loading for a frame.
        (-[WebDataSource _stopLoading]): Stop loading plugins as a FIXME suggests we should.
        * WebView/WebFrameLoader.m:
        (-[WebFrameLoader isLoadingPlugIns]): New helper method.
        (-[WebFrameLoader isLoading]): Consider plugin loads too - otherwise we won't stop them
        at stopLoading time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * building/checkout.html: Fix a typo: "OpenSource" instead of "Open Source".
darin [Wed, 2 Aug 2006 18:35:45 +0000 (18:35 +0000)]
    * building/checkout.html: Fix a typo: "OpenSource" instead of "Open Source".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
aroben [Wed, 2 Aug 2006 18:14:06 +0000 (18:14 +0000)]
WebCore:
        Reviewed by Brady.

        - Remove redundant #include

        * loader/loader.cpp:

WebKit:
        Reviewed by Brady.

        - Rename TransferJob to ResourceLoader (this file was forgotten in an
        earlier change by Maciej)

        * COM/WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Timothy.
thatcher [Wed, 2 Aug 2006 18:13:46 +0000 (18:13 +0000)]
    Reviewed by Timothy.

        Bug 9931: [Drosera] Needs a cool icon
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9931

        * Drosera/Drosera.icns: Added.
        * Drosera/Drosera.xcodeproj/project.pbxproj:
        * Drosera/Info.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
mjs [Wed, 2 Aug 2006 08:11:39 +0000 (08:11 +0000)]
    Reviewed by Adele.

        - Change things around so WebFrameLoader tracks the main and provisional data source,
        as well as the frame load state, pulling much code out of WebFrame along the way.

        The most significant aspects of this change are:

        - management of WebDataSources and WebFrameState was moved into WebFrameLoader
        - there is now just one WebFrameLoader shared between the primary and provisional data source

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _updateLoading]):
        (-[WebDataSource _loadIcon]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource _addSubresourceLoader:]):
        (-[WebDataSource _removeSubresourceLoader:]):
        (-[WebDataSource _addPlugInStreamLoader:]):
        (-[WebDataSource _removePlugInStreamLoader:]):
        (-[WebDataSource _defersCallbacksChanged]):
        (-[WebDataSource _stopLoadingWithError:]):
        (-[WebDataSource _revertToProvisionalState]):
        (-[WebDataSource _setupForReplaceByMIMEType:]):
        (-[WebDataSource initWithRequest:]):
        (-[WebDataSource data]):
        (-[WebDataSource isLoading]):
        * WebView/WebFrame.m:
        (-[WebFramePrivate init]):
        (-[WebFramePrivate dealloc]):
        (-[WebFrame _closeOldDataSources]):
        (-[WebFrame _detachFromParent]):
        (-[WebFrame _makeDocumentView]):
        (-[WebFrame _receivedMainResourceError:]):
        (-[WebFrame _transitionToCommitted:]):
        (+[WebFrame _timeOfLastCompletedLoad]):
        (-[WebFrame _checkLoadCompleteForThisFrame]):
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _continueAfterWillSubmitForm:]):
        (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
        (-[WebFrame _initWithWebFrameView:webView:bridge:]):
        (-[WebFrame _frameLoader]):
        (-[WebFrame _provisionalLoadStarted]):
        (-[WebFrame _prepareForDataSourceReplacement]):
        (-[WebFrame _frameLoadCompleted]):
        (-[WebFrame provisionalDataSource]):
        (-[WebFrame dataSource]):
        (-[WebFrame stopLoading]):
        * WebView/WebFrameInternal.h:
        * WebView/WebFrameLoader.h:
        * WebView/WebFrameLoader.m:
        (-[WebFrameLoader initWithWebFrame:]):
        (-[WebFrameLoader dealloc]):
        (-[WebFrameLoader dataSource]):
        (-[WebFrameLoader _setDataSource:]):
        (-[WebFrameLoader clearDataSource]):
        (-[WebFrameLoader provisionalDataSource]):
        (-[WebFrameLoader _setProvisionalDataSource:]):
        (-[WebFrameLoader _clearProvisionalDataSource]):
        (-[WebFrameLoader state]):
        (+[WebFrameLoader timeOfLastCompletedLoad]):
        (-[WebFrameLoader _setState:]):
        (-[WebFrameLoader clearProvisionalLoad]):
        (-[WebFrameLoader markLoadComplete]):
        (-[WebFrameLoader commitProvisionalLoad]):
        (-[WebFrameLoader stopLoading]):
        (-[WebFrameLoader startLoading]):
        (-[WebFrameLoader startProvisionalLoad:]):
        (-[WebFrameLoader setupForReplace]):
        * WebView/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
tomernic [Tue, 1 Aug 2006 23:06:00 +0000 (23:06 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4480737> Flash crashes after it replaces itself via a document.write()

        I kind of hate to do this, but this is the best way to work around buggy plug-ins like Flash that assume that
        NPP_Destroy() cannot be called while the browser is calling one of its other plug-in functions.  The classic
        situation is a plug-in that replaces itself via an NPN_Invoke() that executes a document.write().

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView sendEvent:]):
        Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions.
        (-[WebBaseNetscapePluginView setWindowIfNecessary]):
        ditto
        (-[WebBaseNetscapePluginView start]):
        It should not be possible to start a plug-in instance while we are calling into it (one of those chicken/egg
        problems).  Added a sanity-checking assertion.
        (-[WebBaseNetscapePluginView stop]):
        If we're already calling a plug-in function, do not call NPP_Destroy().  The plug-in function we are calling
        may assume that its instance->pdata, or other memory freed by NPP_Destroy(), is valid and unchanged until said
        plugin-function returns.
        (-[WebBaseNetscapePluginView pluginScriptableObject]):
        Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions.
        (-[WebBaseNetscapePluginView willCallPlugInFunction]):
        Increment plug-in function call depth.
        (-[WebBaseNetscapePluginView didCallPlugInFunction]):
        Decrement plug-in function call depth.  Stop if we're supposed to stop.
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
        Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions.
        (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
        ditto
        (-[WebBaseNetscapePluginView _printedPluginBitmap]):
        ditto

        * Plugins/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
        Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions.
        (-[WebBaseNetscapePluginStream _destroyStream]):
        ditto
        (-[WebBaseNetscapePluginStream _deliverData]):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fix build after last change
mjs [Tue, 1 Aug 2006 22:53:40 +0000 (22:53 +0000)]
    - fix build after last change

        * WebView/WebFrame.m:
        (-[WebFrame _checkLoadCompleteForThisFrame]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Beth.
mjs [Tue, 1 Aug 2006 22:05:57 +0000 (22:05 +0000)]
    Reviewed by Beth.

        - revert part of my last fix that broke the Safari bookmarks view

        * WebView/WebFrame.m:
        (-[WebFrame _checkLoadCompleteForThisFrame]): still send layout message for non-HTML views

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Anders.
tomernic [Tue, 1 Aug 2006 20:20:42 +0000 (20:20 +0000)]
    Reviewed by Anders.

        Fixed an assertion failure I ran into while debugging <rdar://problem/4652683>.

        * Plugins/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView redeliverStream]):
        Don't clear the "instance" ivar here.  This code was refactored here from the old WebNetscapePluginRepresentation,
        which also had an "instance" ivar.  It is never appropriate to clear a plug-in view's instance.  That is done when
        the plug-in is destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Beth.
ggaren [Tue, 1 Aug 2006 18:41:04 +0000 (18:41 +0000)]
    Reviewed by Beth.

        - Added instructions for debugging in Xcode

        * building/build-window.png: Added.
        * building/build.html:
        * building/custom-executable.png: Added.
        * building/info-tab.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
mjs [Tue, 1 Aug 2006 18:38:33 +0000 (18:38 +0000)]
    Reviewed by Geoff.

        - some refactoring in preparation for moving more stuff to WebFrameLoader.

        * WebView/WebFrame.m:
        (-[WebFrame _clearDataSource]):
        (-[WebFrame _detachFromParent]):
        (-[WebFrame _commitProvisionalLoad]):
        (-[WebFrame _transitionToCommitted:]):
        (-[WebFrame _clearProvisionalLoad]):
        (-[WebFrame _markLoadComplete]):
        (-[WebFrame _checkLoadCompleteForThisFrame]):
        (-[WebFrame _startProvisionalLoad:]):
        (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
        (-[WebFrame stopLoading]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Tue, 1 Aug 2006 16:40:22 +0000 (16:40 +0000)]
LayoutTests:

        - updated a test affected by changes to the DumpRenderTree tool
          to return a current mouse position

        * fast/inline/dirtyLinesForInline-expected.txt: Updated.

WebKitTools:

        - fix a bug in my recent change where the mouse position at the end of
          the last test would affect the results of the next test

        * DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Set lastMousePosition to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Tue, 1 Aug 2006 06:15:38 +0000 (06:15 +0000)]
LayoutTests:

        Reviewed by Darin.

        - tests changed by http://bugzilla.opendarwin.org/show_bug.cgi?id=9955
        Colors scaled from [0, 1] range to [0, 255] incorrectly

        * fast/css/hsl-color-expected.checksum:
        * fast/css/hsl-color-expected.png:
        * fast/css/hsl-color-expected.txt:
        * fast/forms/input-disabled-color-expected.checksum:
        * fast/forms/input-disabled-color-expected.png:
        * fast/forms/input-disabled-color-expected.txt:

WebCore:

        Reviewed by Darin.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=9955
        Colors scaled from [0, 1] range to [0, 255] incorrectly

        Fixes scaling issue and fixes Color to follow style guidelines.

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
        * platform/Color.cpp:
        (WebCore::calcHue):
        (WebCore::makeRGBAFromHSLA):
        (WebCore::Color::Color):
        (WebCore::Color::name):
        (WebCore::Color::setNamedColor):
        (WebCore::Color::light):
        (WebCore::Color::dark):
        (WebCore::blend):
        * platform/Color.h:
        (WebCore::Color::Color):
        (WebCore::Color::isValid):
        (WebCore::Color::red):
        (WebCore::Color::green):
        (WebCore::Color::blue):
        (WebCore::Color::alpha):
        (WebCore::Color::rgb):
        (WebCore::Color::setRGB):
        (WebCore::operator==):
        (WebCore::operator!=):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Tue, 1 Aug 2006 06:13:20 +0000 (06:13 +0000)]
LayoutTests:

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10158
          REGRESSION: Selection highlight is dark and opaque when solid-color images are used

        Reviewed by Darin.

        * fast/backgrounds/solid-color-context-restore-expected.checksum: Added.
        * fast/backgrounds/solid-color-context-restore-expected.png: Added.
        * fast/backgrounds/solid-color-context-restore-expected.txt: Added.
        * fast/backgrounds/solid-color-context-restore.html: Added.

WebCore:

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10158
          REGRESSION: Selection highlight is dark and opaque when solid-color images are used

        Reviewed by Darin.

        Pixel test: fast/backgrounds/solid-color-context-restore.html

        * platform/mac/ImageMac.mm:
        (WebCore::Image::draw): Added calls to preserve the graphics context
        around the painting of a solid color image.
        (WebCore::Image::drawTiled): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Tue, 1 Aug 2006 06:10:04 +0000 (06:10 +0000)]
    Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10182
        Bug 10182: [Drosera] Evaluating expressions in Console is slow when current frame has many variables

        * Drosera/console.js: String.indexOf returns -1 when the string is not found.
        Correct the logic to not reload local variable list unless an '=' character is in the expression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Tue, 1 Aug 2006 06:00:32 +0000 (06:00 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10171
          REGRESSION: failing layout test: fast/events/objc-event-api.html

        * fast/events/objc-event-api-expected.txt: Updated test results for changes in the
        DumpRenderTree tool.

WebKitTools:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10171
          REGRESSION: failing layout test: fast/events/objc-event-api.html

        * DumpRenderTree/DumpRenderTree.m:
        (main): Add pose so we can implement +[NSEvent mouseLocation]. Put the window at a predictable
        location in flipped coordinates, since those are the coordinates that we use.
        (+[DumpRenderTreeEvent mouseLocation]): Implement this, since it's used for mouse event handling
        inside WebHTMLView.

        * DumpRenderTree/EventSendingController.m:
        (+[EventSendingController initialize]): Removed unused webkitDomEventProperties array.
        (-[EventSendingController init]): Removed, since the whole thing was a no-op.
        (-[EventSendingController mouseMoveToX:Y:]): Convert the x,y pair to window coordinates. The old code
        probably worked OK, but this is needed to be correct.
        (-[EventSendingController handleEvent:]): Put clientX/Y before screenX/Y and removed the flipping
        code from screenY. We didn't really need to flip screenY -- what was actually happening was that the
        position that DumpRenderTree chose was in non-flipped coordinates, and with that fixed we can just
        dump the screenY as-is.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
mjs [Tue, 1 Aug 2006 05:15:40 +0000 (05:15 +0000)]
WebCore:

        Rubber-stamped by Tim Hatcher.

        - renamed TransferJob to ResourceLoader

        * Projects/gdk/webcore-gdk.bkl:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bridge/mac/FrameMac.mm:
        * bridge/mac/WebCoreResourceLoaderImp.h:
        * bridge/mac/WebCoreResourceLoaderImp.mm:
        (-[WebCoreResourceLoaderImp redirectedToURL:]):
        (-[WebCoreResourceLoaderImp addData:]):
        (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
        * bridge/win/FrameWin.cpp:
        * dom/XMLTokenizer.cpp:
        (WebCore::openFunc):
        * loader/Cache.cpp:
        * loader/LoaderFunctions.h:
        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::receivedAllData):
        (WebCore::Loader::receivedResponse):
        (WebCore::Loader::receivedData):
        (WebCore::Loader::cancelRequests):
        (WebCore::Loader::jobForRequest):
        * loader/loader.h:
        * loader/mac/LoaderFunctionsMac.mm:
        (WebCore::ServeSynchronousRequest):
        * platform/ResourceLoader.cpp: Added.
        (WebCore::ResourceLoader::ResourceLoader):
        (WebCore::ResourceLoader::isErrorPage):
        (WebCore::ResourceLoader::error):
        (WebCore::ResourceLoader::setError):
        (WebCore::ResourceLoader::queryMetaData):
        (WebCore::ResourceLoader::addMetaData):
        (WebCore::ResourceLoader::kill):
        (WebCore::ResourceLoader::url):
        (WebCore::ResourceLoader::postData):
        (WebCore::ResourceLoader::method):
        (WebCore::ResourceLoader::client):
        * platform/ResourceLoader.h: Added.
        (WebCore::ResourceLoader::getInternal):
        * platform/ResourceLoaderClient.h: Added.
        (WebCore::ResourceLoaderClient::~ResourceLoaderClient):
        (WebCore::ResourceLoaderClient::receivedRedirect):
        (WebCore::ResourceLoaderClient::receivedResponse):
        (WebCore::ResourceLoaderClient::receivedData):
        (WebCore::ResourceLoaderClient::receivedAllData):
        * platform/ResourceLoaderInternal.h: Added.
        (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
        * platform/TransferJob.cpp: Removed.
        * platform/TransferJob.h: Removed.
        * platform/TransferJobClient.h: Removed.
        * platform/TransferJobInternal.h: Removed.
        * platform/gdk/FrameGdk.cpp:
        (WebCore::FrameGdk::openURL):
        (WebCore::FrameGdk::urlSelected):
        (WebCore::FrameGdk::receivedData):
        (WebCore::FrameGdk::receivedAllData):
        * platform/gdk/FrameGdk.h:
        * platform/gdk/ResourceLoaderCurl.cpp: Added.
        (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
        (WebCore::ResourceLoader::~ResourceLoader):
        (WebCore::ResourceLoader::start):
        (WebCore::ResourceLoader::cancel):
        * platform/gdk/ResourceLoaderManager.cpp: Added.
        (WebCore::ResourceLoaderManager::ResourceLoaderManager):
        (WebCore::ResourceLoaderManager::get):
        (WebCore::ResourceLoaderManager::useSimpleTransfer):
        (WebCore::writeCallback):
        (WebCore::ResourceLoaderManager::downloadTimerCallback):
        (WebCore::ResourceLoaderManager::remove):
        (WebCore::ResourceLoaderManager::add):
        (WebCore::ResourceLoaderManager::cancel):
        * platform/gdk/ResourceLoaderManager.h: Added.
        * platform/gdk/TemporaryLinkStubs.cpp:
        (WebCore::ServeSynchronousRequest):
        (WebCore::ResourceLoader::assembleResponseHeaders):
        (WebCore::ResourceLoader::retrieveCharset):
        * platform/gdk/TransferJobCurl.cpp: Removed.
        * platform/gdk/TransferJobManager.cpp: Removed.
        * platform/gdk/TransferJobManager.h: Removed.
        * platform/mac/ResourceLoaderMac.mm: Added.
        (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
        (WebCore::ResourceLoader::~ResourceLoader):
        (WebCore::ResourceLoader::start):
        (WebCore::ResourceLoader::assembleResponseHeaders):
        (WebCore::ResourceLoader::retrieveCharset):
        (WebCore::ResourceLoader::setLoader):
        (WebCore::ResourceLoader::receivedResponse):
        (WebCore::ResourceLoader::cancel):
        * platform/mac/TransferJobMac.mm: Removed.
        * platform/win/ResourceLoaderWin.cpp: Added.
        (WebCore::addToOutstandingJobs):
        (WebCore::lookupResourceLoader):
        (WebCore::ResourceLoaderWndProc):
        (WebCore::initializeOffScreenResourceLoaderWindow):
        (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
        (WebCore::ResourceLoader::~ResourceLoader):
        (WebCore::ResourceLoader::start):
        (WebCore::ResourceLoader::fileLoadTimer):
        (WebCore::ResourceLoader::cancel):
        * platform/win/ResourceLoaderWin.h: Added.
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::ServeSynchronousRequest):
        (WebCore::ResourceLoader::assembleResponseHeaders):
        (WebCore::ResourceLoader::retrieveCharset):
        * platform/win/TransferJobWin.cpp: Removed.
        * platform/win/TransferJobWin.h: Removed.
        * xml/XSLTProcessor.cpp:
        (WebCore::docLoaderFunc):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::receivedAllData):
        (WebCore::XMLHttpRequest::receivedRedirect):
        (WebCore::XMLHttpRequest::receivedData):
        * xml/xmlhttprequest.h:

WebKit:

        Reviewed by Tim Hatcher.

        - renamed TransferJob to ResourceLoader in WebCore

        * COM/WebFrame.cpp:
        (WebFrame::loadDataSource):
        (WebFrame::receivedRedirect):
        (WebFrame::receivedResponse):
        (WebFrame::receivedData):
        (WebFrame::receivedAllData):
        (WebFrame::setStatusText):
        * COM/WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Tue, 1 Aug 2006 04:54:55 +0000 (04:54 +0000)]
    Reviewed by Maciej.

        - omit the margin and padding boxes for display types where they are ignored
        - use CSS instead of properties for table spacing and padding as suggested by Tim H.

        * WebInspector/webInspector/inspector.css: Added rules for spacing and padding.
        Added rules that hide the margin and padding boxes (borders and all but the center cell)
        when the hide attribute is present.
        * WebInspector/webInspector/inspector.html: Added classes for the rules above.
        Removed cellpadding and cellspacing attributes.
        * WebInspector/webInspector/inspector.js: Added code to hide/show the margin and
        padding boxes based on the display type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Hyatt.
darin [Tue, 1 Aug 2006 04:14:20 +0000 (04:14 +0000)]
    Reviewed by Hyatt.

        - removed obsolete cell margin hack

        * rendering/RenderBox.cpp: (WebCore::RenderBox::calcVerticalMargins):
        Set top and bottom margins to 0 for table cells instead of -16384.
        No effect on layout (including layout tests).

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        Added a few comments about differences between this class and the
        what the CSS specification says about computed style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
thatcher [Tue, 1 Aug 2006 04:00:57 +0000 (04:00 +0000)]
LayoutTests:

        Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9738
        Bug 9738: Unqualified :hover selector ignored in strict parsing mode

        * fast/selectors/unqualified-hover-quirks-expected.checksum: Added.
        * fast/selectors/unqualified-hover-quirks-expected.png: Added.
        * fast/selectors/unqualified-hover-quirks-expected.txt: Added.
        * fast/selectors/unqualified-hover-quirks.html: Added.
        * fast/selectors/unqualified-hover-strict-expected.checksum: Added.
        * fast/selectors/unqualified-hover-strict-expected.png: Added.
        * fast/selectors/unqualified-hover-strict-expected.txt: Added.
        * fast/selectors/unqualified-hover-strict.html: Added.

WebCore:

        Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9738
        Bug 9738: Unqualified :hover selector ignored in strict parsing mode

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::checkSelector): Restrict the :hover and :active
        exclusion based on onlyHoverActive to quirks mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
thatcher [Tue, 1 Aug 2006 03:54:30 +0000 (03:54 +0000)]
    Reviewed by Darin.

        Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=10159>
        "REGRESSION: delegate returning no menu elements crashes webkit"

        No automated test, because there's no way to programmatically open a context menu,
        no manual test because there's no way to customize the context menu delegate.

        * WebView/WebView.m:
        (-[WebView _menuForElement:defaultItems:]): Make sure the context menu returned
        some menu items before accessing the first one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
thatcher [Tue, 1 Aug 2006 03:51:45 +0000 (03:51 +0000)]
    Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10178
        Bug 10178: [Drosera] Selecting a frame in the stack list should take you to that location in the source

        * Drosera/debugger.js:  Keep a stack that contains the source file and line number references for outer
        frames.  Use this stack to determine which file and line to highlight when a stack frame is selected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
thatcher [Tue, 1 Aug 2006 03:48:39 +0000 (03:48 +0000)]
    Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10175
        Bug 10175: [Drosera] Anonymous functions show up as "(global scope)" in stack list

        * Drosera/DebuggerDocument.m:
        (-[WebScriptObject currentFunctionStack]): If the frame has a caller it isn't the global scope.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdd ScrollBar.cpp to fix the build.
hyatt [Tue, 1 Aug 2006 02:27:57 +0000 (02:27 +0000)]
Add ScrollBar.cpp to fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix for bug 10179, digg.com scrolls slowly. Improve fixed positioning
hyatt [Tue, 1 Aug 2006 02:25:43 +0000 (02:25 +0000)]
    Fix for bug 10179, digg.com scrolls slowly.  Improve fixed positioning
        and fixed backgrounds so that a count of them is kept on the FrameView.
        This allows us to switch slow scrolling on and off as these objects come
        and go.

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        (WebCore::CSSStyleSelector::applyProperty):
        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::reset):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::useSlowRepaints):
        (WebCore::FrameView::setUseSlowRepaints):
        (WebCore::FrameView::addSlowRepaintObject):
        (WebCore::FrameView::removeSlowRepaintObject):
        * page/FrameView.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBackgroundExtended):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::paintBoxDecorations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Begin disentangling of scrollbar logic in preparation for engine-implemented
hyatt [Tue, 1 Aug 2006 01:50:45 +0000 (01:50 +0000)]
    Begin disentangling of scrollbar logic in preparation for engine-implemented
        scrollbars.  Split ScrollBar into two classes, an abstract base (still named
        ScrollBar) and a new PlatformScrollBar subclass.  This subclass is used only
        by platforms that want to continue to use a platform scrollbar (rather than
        the engine one).

        Reviewed by darin

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLCanvasElement.h:
        * page/Frame.cpp:
        * platform/PlatformScrollBar.h: Added.
        (WebCore::PlatformScrollBar::isWidget):
        * platform/ScrollBar.h:
        (WebCore::ScrollBarClient::~ScrollBarClient):
        (WebCore::ScrollBar::~ScrollBar):
        (WebCore::ScrollBar::orientation):
        (WebCore::ScrollBar::value):
        (WebCore::ScrollBar::client):
        * platform/mac/PlatformScrollBarMac.mm: Added.
        (-[WebCoreScrollBar initWithPlatformScrollBar:]):
        (-[WebCoreScrollBar detachPlatformScrollBar]):
        (-[WebCoreScrollBar scroll:]):
        (-[WebCoreScrollBar widget]):
        (-[WebCoreScrollBar mouseDown:]):
        (WebCore::PlatformScrollBar::PlatformScrollBar):
        (WebCore::PlatformScrollBar::~PlatformScrollBar):
        (WebCore::PlatformScrollBar::setScrollBarValue):
        (WebCore::PlatformScrollBar::setKnobProportion):
        (WebCore::PlatformScrollBar::scrollbarHit):
        (WebCore::PlatformScrollBar::width):
        (WebCore::PlatformScrollBar::height):
        (WebCore::PlatformScrollBar::setRect):
        (WebCore::PlatformScrollBar::setEnabled):
        (WebCore::PlatformScrollBar::paint):
        * platform/mac/ScrollBarMac.mm: Removed.
        * platform/mac/WebCoreTextArea.mm:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isPointInScrollbar):
        * rendering/RenderFormElement.cpp:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::horizontalScrollbarWidget):
        (WebCore::RenderLayer::verticalScrollbarWidget):
        (WebCore::RenderLayer::valueChanged):
        (WebCore::RenderLayer::setHasHorizontalScrollbar):
        (WebCore::RenderLayer::setHasVerticalScrollbar):
        (WebCore::RenderLayer::positionScrollbars):
        * rendering/RenderLayer.h:
        * rendering/RenderWidget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Tue, 1 Aug 2006 00:05:30 +0000 (00:05 +0000)]
LayoutTests:

        Reviewed by John and Anders.

        - Test for <rdar://problem/4380576> onChange does not get called when field changed by return key

        * fast/forms/onchange-enter-submit-expected.txt: Added.
        * fast/forms/onchange-enter-submit.html: Added.

WebCore:

        Reviewed by John and Anders.

        - Fix for <rdar://problem/4380576> onChange does not get called when field changed by return key

        Test: fast/forms/onchange-enter-submit.html

        Blur (which will fire onChange appropriately) before submitting a form when pressing Enter.
        This matches the sequence of events fired in WinIE.

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John.
thatcher [Mon, 31 Jul 2006 23:55:15 +0000 (23:55 +0000)]
    Reviewed by John.

        <rdar://problem/4658194> REGRESSION: "Search in Google"
        and "Search in Spotlight" fail to work on text selected in a frame

        Use selectedFrame to get the frame with the text selection.

        * WebView/WebView.m:
        (-[WebView _searchWithGoogleFromMenu:]):
        (-[WebView _searchWithSpotlightFromMenu:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Kevin.
ggaren [Mon, 31 Jul 2006 22:27:46 +0000 (22:27 +0000)]
    Reviewed by Kevin.

        Moved string debug function outside of the WebCore namespace so that it's
        easier to call in the debugger. I will never doubt Darin again (x100).

        * platform/String.cpp:
        (string):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoGet rid of the -50000 nonsense on scrollbars when they're first added to overflow...
hyatt [Mon, 31 Jul 2006 21:06:15 +0000 (21:06 +0000)]
Get rid of the -50000 nonsense on scrollbars when they're first added to overflow blocks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Partial fix for 5453. Improve overflow so that when it changes
hyatt [Mon, 31 Jul 2006 20:59:48 +0000 (20:59 +0000)]
    Partial fix for 5453.  Improve overflow so that when it changes
        dynamically from scroll/auto to hidden that we properly hide the
        scrollbars.  Also refine the dirty dashboard region updating so that
        it only happens if the scrollbars genuinely come and go.

        Also eliminate the extra repaint of the entire block.  This should not be
        necessary, since the scrollbars repaint themselves already and children
        will repaint already if they move.

        Reviewed by darin

        Adding test case from bug into fast/overflow/dynamic-hidden.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::setHasHorizontalScrollbar):
        (WebCore::RenderLayer::setHasVerticalScrollbar):
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdd layout test for bug 5453.
hyatt [Mon, 31 Jul 2006 20:58:28 +0000 (20:58 +0000)]
Add layout test for bug 5453.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15715 268f45cc-cd09-0410-ab3c-d52691b4dbfc