abarth@webkit.org [Wed, 22 Jun 2011 01:04:53 +0000 (01:04 +0000)]
2011-06-21 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
bugs.webkit.org should use Strict-Transport-Security
https://bugs.webkit.org/show_bug.cgi?id=63097
Strict-Transport-Security forces all connections to bugs.webkit.org to
use HTTPS, preventing sslstrip and other attacks.
* .htaccess:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 22 Jun 2011 00:50:13 +0000 (00:50 +0000)]
2011-06-21 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
REGRESSION: Fullscreen videos are broken (affects embedded vimeo, vimeo.com, and apple.com)
https://bugs.webkit.org/show_bug.cgi?id=63098
<rdar://problem/
9645393>
Force a repaint after completing entering full-screen mode only after the notification
is sent for the QTMovie to tear down its layer. Then, the QTMovie will build up its
layer again during the repaint.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Wed, 22 Jun 2011 00:40:41 +0000 (00:40 +0000)]
2011-06-21 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
beginTransparencyLayer leaves context color out of sync, bleeds color into text
https://bugs.webkit.org/show_bug.cgi?id=63093
Test: fast/css/color-leakage.html
* platform/graphics/cg/GraphicsContextCG.cpp: Swap out CGContextSave/Restore with
GraphicsContext::save/restore to keep the context in sync with its CG context
(WebCore::GraphicsContext::beginTransparencyLayer): Added save(), removed redundant calls.
(WebCore::GraphicsContext::endTransparencyLayer): Added restore(), removed redundant calls.
2011-06-21 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
beginTransparencyLayer leaves context color out of sync, bleeds color into text
https://bugs.webkit.org/show_bug.cgi?id=63093
* fast/css/color-leakage.html: Added pixel regression test that previously would have the
border's color spilling into the text.
* platform/mac/fast/css/color-leakage-expected.png: Added.
* platform/mac/fast/css/color-leakage-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 22 Jun 2011 00:26:01 +0000 (00:26 +0000)]
2011-06-21 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
add css parsing of flex()
https://bugs.webkit.org/show_bug.cgi?id=62050
Add a new script-test, but skip it on all platforms since we don't
build with ENABLE_CSS3_FLEXBOX anywhere.
* css3/flexbox/flex-parsing-expected.txt: Added.
* css3/flexbox/flex-parsing.html: Added.
* css3/flexbox/script-tests/TEMPLATE.html: Added.
* css3/flexbox/script-tests/flex-parsing.js: Added.
(testFlex):
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
2011-06-21 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
add css parsing of flex()
https://bugs.webkit.org/show_bug.cgi?id=62050
Test: css3/flexbox/flex-parsing.html
* CMakeLists.txt: Add CSSFlexValue.*
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* css/CSSFlexValue.cpp: Added.
(WebCore::CSSFlexValue::~CSSFlexValue):
(WebCore::CSSFlexValue::cssText):
* css/CSSFlexValue.h: Added.
(WebCore::CSSFlexValue::create): Hold positive flex, negative flex and sizing.
(WebCore::CSSFlexValue::CSSFlexValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValidPrimitive): Pull out code from parseValue.
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex): Parse the different version of flex().
* css/CSSParser.h:
2011-06-21 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
add css parsing of flex()
https://bugs.webkit.org/show_bug.cgi?id=62050
* features.gypi: Add a gyp flag (enable_css3_flexbox) for setting ENABLE_CSS3_FLEXBOX.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 22 Jun 2011 00:09:44 +0000 (00:09 +0000)]
2011-06-21 Ryosuke Niwa <rniwa@webkit.org>
Remove failing test expectations from various tests for Chromium Windows.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 21 Jun 2011 23:52:04 +0000 (23:52 +0000)]
2011-06-21 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Add child layers to the overlap map if their parent belatedly becomes composited
https://bugs.webkit.org/show_bug.cgi?id=62181
* compositing/layer-creation/overlap-transformed-layer-expected.txt: Added.
* compositing/layer-creation/overlap-transformed-layer.html: Added.
2011-06-21 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Add child layers to the overlap map if their parent belatedly becomes composited
https://bugs.webkit.org/show_bug.cgi?id=62181
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
* rendering/RenderLayerCompositor.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 21 Jun 2011 23:46:49 +0000 (23:46 +0000)]
2011-06-21 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Implement drawingBufferWidth/drawingBufferHeight in WebGL
https://bugs.webkit.org/show_bug.cgi?id=58497
* fast/canvas/webgl/webgl-specific-expected.txt:
* fast/canvas/webgl/webgl-specific.html: Test drawingBufferWidth/Height attributes.
* fast/canvas/webgl/canvas-zero-size-expected.txt:
* fast/canvas/webgl/canvas-zero-size.html: Added.
* fast/canvas/webgl/drawingbuffer-test-expected.txt:
* fast/canvas/webgl/drawingbuffer-test.html: Added.
2011-06-21 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Implement drawingBufferWidth/drawingBufferHeight in WebGL
https://bugs.webkit.org/show_bug.cgi?id=58497
* src/GraphicsContext3DChromium.cpp: Make getInternalFramebufferSize method const.
(WebCore::GraphicsContext3DInternal::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
* src/GraphicsContext3DInternal.h:
2011-06-21 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Implement drawingBufferWidth/drawingBufferHeight in WebGL
https://bugs.webkit.org/show_bug.cgi?id=58497
* html/canvas/WebGLRenderingContext.cpp: Add drawingBufferWidth/Height method and call getInternalFramebufferSize().
(WebCore::WebGLRenderingContext::drawingBufferWidth):
(WebCore::WebGLRenderingContext::drawingBufferHeight):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLRenderingContext.idl: Add readonly attributes drawingBufferWidth/Height.
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Make getInternalFramebufferSize const.
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
* platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto.
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Tue, 21 Jun 2011 23:39:28 +0000 (23:39 +0000)]
2011-06-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Moved 'const' off the global-variable-as-local-variable crack pipe
https://bugs.webkit.org/show_bug.cgi?id=63105
This is necessary for moving the rest of the code off of same.
Many problems remain in our handling of const. I have fixed none of them.
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::scopeChain): New accessor, needed to enable
const to directly implement its unique scoping rules.
* bytecompiler/NodesCodegen.cpp:
(JSC::PrefixResolveNode::emitBytecode): Do specify that our resolve is
for writing, so we don't overwrite const variables.
(JSC::ConstDeclNode::emitCodeSingle): Don't assume that all declared const
variables are available as local variables, since this won't be the case
once global variables are not available as local variables. Instead, use
put_scoped_var in the case where there is no local variable. Like a local
variable, put_scoped_var succeeds even though const properties are
read-only, since put_scoped_var skips read-only checks. (Yay?)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Tue, 21 Jun 2011 23:12:19 +0000 (23:12 +0000)]
[Chromium] Unreviewed update of test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 23:09:15 +0000 (23:09 +0000)]
2011-06-21 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62653
[V8][Chromium] Make StringCache in V8 bindings per-isolate
This moves StringCache into V8BindingPerIsolateData.
* bindings/v8/V8Binding.cpp:
(WebCore::cachedStringCallback):
(WebCore::StringCache::remove):
(WebCore::StringCache::v8ExternalStringSlow):
* bindings/v8/V8Binding.h:
(WebCore::StringCache::StringCache):
(WebCore::StringCache::v8ExternalString):
(WebCore::StringCache::clearOnGC):
(WebCore::V8BindingPerIsolateData::stringCache):
(WebCore::v8ExternalString):
* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::gcPrologue):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
2011-06-21 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62653
[V8][Chromium] Make StringCache in V8 bindings per-isolate
* src/WebKit.cpp:
(WebKit::initialize): Initialize V8PerIsolateBindingData eagerly
* src/WebScriptController.cpp:
(WebKit::WebScriptController::enableV8SingleThreadMode): StringCache is now per-isolate, so ok in multithreaded contexts.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Tue, 21 Jun 2011 22:51:13 +0000 (22:51 +0000)]
2011-06-21 Stephen White <senorblanco@chromium.org>
Unreviewed.
Adjust some GPU test expectations to match bot reality.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 21 Jun 2011 22:51:08 +0000 (22:51 +0000)]
Clang build fix.
* platform/mac/WebCoreSystemInterface.h: Give the enum a name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 21 Jun 2011 22:35:00 +0000 (22:35 +0000)]
Fix Mac build in some configurations.
* platform/mac/WebCoreSystemInterface.h: Added an enum matching WKSI one, since we cannot use
WKSI in WebCore.
* platform/mac/WebVideoFullscreenHUDWindowController.mm: Removed an include of WebKitSystemInterface.h.
It's not meant to be used from WebCore, and if included, a wrong copy may be used.
(createControlWithMediaUIControlType): Added a FIXME about problems with Leopard build.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Ditto. Switched enum values to
WCSI style (lower level "wk").
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 21 Jun 2011 22:31:21 +0000 (22:31 +0000)]
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099
Broke tests on Mac (Requested by rniwa on #webkit).
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099
Broke tests on Mac (Requested by rniwa on #webkit).
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::destroyInspectorView):
* WebCoreSupport/WebInspectorClient.h:
* WebInspector.cpp:
(WebInspector::createInstance):
(WebInspector::WebInspector):
(WebInspector::webViewClosed):
(WebInspector::showConsole):
(WebInspector::isDebuggingJavaScript):
(WebInspector::toggleDebuggingJavaScript):
(WebInspector::isProfilingJavaScript):
(WebInspector::toggleProfilingJavaScript):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::isTimelineProfilingEnabled):
(WebInspector::setTimelineProfilingEnabled):
* WebInspector.h:
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099
Broke tests on Mac (Requested by rniwa on #webkit).
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController destroyInspectorView:]):
* WebInspector/WebInspector.mm:
(-[WebInspector show:]):
(-[WebInspector showConsole:]):
(-[WebInspector isDebuggingJavaScript]):
(-[WebInspector toggleDebuggingJavaScript:]):
(-[WebInspector startDebuggingJavaScript:]):
(-[WebInspector stopDebuggingJavaScript:]):
(-[WebInspector isProfilingJavaScript]):
(-[WebInspector toggleProfilingJavaScript:]):
(-[WebInspector startProfilingJavaScript:]):
(-[WebInspector stopProfilingJavaScript:]):
(-[WebInspector isJavaScriptProfilingEnabled]):
(-[WebInspector setJavaScriptProfilingEnabled:]):
(-[WebInspector isTimelineProfilingEnabled]):
(-[WebInspector setTimelineProfilingEnabled:]):
(-[WebInspector setFrontend:]):
(-[WebInspector showWindow:]):
* WebInspector/WebInspectorFrontend.h:
* WebInspector/WebInspectorFrontend.mm:
* WebInspector/WebInspectorPrivate.h:
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099
Broke tests on Mac (Requested by rniwa on #webkit).
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
* inspector/InspectorFrontendClientLocal.h:
* inspector/front-end/InspectorFrontendAPI.js: Removed.
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileType):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._enableProfiling):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._enableDebugging):
(WebInspector.ScriptsPanel.prototype._toggleDebugging):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Tue, 21 Jun 2011 22:28:45 +0000 (22:28 +0000)]
[Chromium] Unreviewed update of test expectations after r89381.
* platform/chromium-linux/svg/custom/pointer-events-text-expected.png:
* platform/chromium-win/svg/custom/pointer-events-text-expected.png:
* platform/chromium-win/svg/custom/pointer-events-text-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Tue, 21 Jun 2011 21:31:56 +0000 (21:31 +0000)]
[Qt] Add an internal API for accessing the QGraphicsView.
https://bugs.webkit.org/show_bug.cgi?id=63095
Reviewed by Kenneth Rohde Christiansen.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::ownerWidget):
* UIProcess/API/qt/qwkpage_p.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 21:20:15 +0000 (21:20 +0000)]
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB: IDBObjectStore methods should throw TypeError if required arguments are missing
https://bugs.webkit.org/show_bug.cgi?id=63087
* storage/indexeddb/objectStore-required-arguments-expected.txt: Added.
* storage/indexeddb/objectStore-required-arguments.html: Added.
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB: IDBObjectStore methods should throw TypeError if required arguments are missing
https://bugs.webkit.org/show_bug.cgi?id=63087
Test: storage/indexeddb/objectStore-required-arguments.html
* storage/IDBObjectStore.idl: Remove LegacyDefaultOptionalArguments flag
so missing required arguments will throw TypeError, as per WebIDL spec.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 21:18:25 +0000 (21:18 +0000)]
2011-06-21 Wyatt Carss <wcarss@chromium.org>
Reviewed by Ryosuke Niwa.
convert editing/deleting/delete-
3608430-fix.html to DumpAsTextEditingTest
https://bugs.webkit.org/show_bug.cgi?id=62823
Fixed a superfluous quote, added a doctype, fixed a broken reference to 'abe.gif'
(now points to abe.png, in the correct location), added a description, and converted
to a DumpAsTextEditingTest. This test checks that deletion over an image will correctly
remove an empty element before the image.
* editing/deleting/delete-
3608430-fix-expected.txt: Added.
* editing/deleting/delete-
3608430-fix.html:
* platform/chromium-linux/editing/deleting/delete-
3608430-fix-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-
3608430-fix-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-
3608430-fix-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-
3608430-fix-expected.txt: Removed.
* platform/mac/editing/deleting/delete-
3608430-fix-expected.png: Removed.
* platform/mac/editing/deleting/delete-
3608430-fix-expected.txt: Removed.
* platform/qt/editing/deleting/delete-
3608430-fix-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Tue, 21 Jun 2011 21:13:28 +0000 (21:13 +0000)]
2011-06-21 Rob Buis <rbuis@rim.com>
Reviewed by Dirk Schulze.
All pointer-events fail if text has visibility="hidden"
https://bugs.webkit.org/show_bug.cgi?id=62209
Update test results (improvement).
* platform/mac/svg/custom/pointer-events-text-expected.png:
* platform/mac/svg/custom/pointer-events-text-expected.txt:
2011-06-21 Rob Buis <rbuis@rim.com>
Reviewed by Dirk Schulze.
All pointer-events fail if text has visibility="hidden"
https://bugs.webkit.org/show_bug.cgi?id=62209
Use PointerEventsHitRules to make hit-testing for SVG text inline boxes work.
No new tests; covered by existing test pointer-events-text.svg.
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):
* rendering/svg/SVGInlineTextBox.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 21:09:58 +0000 (21:09 +0000)]
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB: keyrange methods should throw TypeError if required arguments are missing
https://bugs.webkit.org/show_bug.cgi?id=63085
* storage/indexeddb/keyrange-required-arguments-expected.txt: Added.
* storage/indexeddb/keyrange-required-arguments.html: Added.
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IndexedDB: keyrange methods should throw TypeError if required arguments are missing
https://bugs.webkit.org/show_bug.cgi?id=63085
Test: storage/indexeddb/keyrange-required-arguments.html
* storage/IDBKeyRange.idl: remove LegacyDefaultOptionalArguments flag
so missing required arguments throw TypeError, as per WebIDL spec.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Tue, 21 Jun 2011 21:08:24 +0000 (21:08 +0000)]
[Chromium] Unreviewed, updating test expectations after r89367,
fixing typo in test_expectations.txt
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Removed.
* platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Removed.
* platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 21:07:00 +0000 (21:07 +0000)]
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: should throw TypeError when indexedDB.open() name argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63065
* storage/indexeddb/database-name-undefined-expected.txt:
* storage/indexeddb/database-name-undefined.html:
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: should throw TypeError when indexedDB.open() name argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63065
* storage/IDBFactory.idl: remove LegacyDefaultOptionalArguments flag
and fix function argument flags
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 20:57:35 +0000 (20:57 +0000)]
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: should throw TypeError when index .get() key argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63079
* storage/indexeddb/index-get-key-argument-required-expected.txt: Added.
* storage/indexeddb/index-get-key-argument-required.html: Added.
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: should throw TypeError when index .get() key argument is missing
https://bugs.webkit.org/show_bug.cgi?id=63079
Test: storage/indexeddb/index-get-key-argument-required.html
* storage/IDBIndex.idl: remove LegacyDefaultOptionalArguments flag
so missing required arguments throw a TypeError as per WebIDL spec.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 20:54:39 +0000 (20:54 +0000)]
2011-06-21 Chris Evans <cevans@chromium.org>
Reviewed by Darin Fisher.
Wire in checkIfRunInsecureContent to the chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=63026
* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::checkIfRunInsecureContent): add in basic plumbing.
* src/WebFrameImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 20:42:27 +0000 (20:42 +0000)]
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: cursor update() value argument is required
https://bugs.webkit.org/show_bug.cgi?id=63032
* storage/indexeddb/cursor-update-value-argument-required-expected.txt: Added.
* storage/indexeddb/cursor-update-value-argument-required.html: Added.
2011-06-21 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: cursor update() value argument is required
https://bugs.webkit.org/show_bug.cgi?id=63032
Test: storage/indexeddb/cursor-update-value-argument-required.html
* storage/IDBCursor.idl: remove LegacyDefaultOptionalArguments flag so
calling functions with missing required arguments will raise a TypeError
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 20:30:04 +0000 (20:30 +0000)]
2011-06-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[GTK] r89314 caused several shadow tests to start failing
https://bugs.webkit.org/show_bug.cgi?id=63045
* platform/gtk/Skipped: Unskip tests that are now passing.
2011-06-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[GTK] r89314 caused several shadow tests to start failing
https://bugs.webkit.org/show_bug.cgi?id=63045
Use prepareForFilling and prepareForStroking when rendering the shadowed
image of a path. This ensures that the shadowed image has the proper alpha.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawPathShadow): Properly prepare the shadow image.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 19:58:38 +0000 (19:58 +0000)]
2011-06-21 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=63080
Unit-tests step on test-only bot is broken.
Removing the step until run-api-tests is fixed.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Tue, 21 Jun 2011 19:52:51 +0000 (19:52 +0000)]
2011-06-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Remove old (aggregating) heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=63049
* inspector/profiler/detailed-heapshots-test.js:
2011-06-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Remove old (aggregating) heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=63049
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::takeHeapSnapshot):
* inspector/Inspector.json:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::takeHeapSnapshot):
* inspector/InspectorProfilerAgent.h:
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.get profile):
(WebInspector.DetailedHeapshotView.prototype.get baseProfile):
(WebInspector.DetailedHeapshotView.prototype._profiles):
(WebInspector.DetailedHeapshotProfileType):
(WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
* inspector/front-end/HeapSnapshotView.js: Removed.
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.parsed):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/heapProfiler.css:
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 21 Jun 2011 19:30:31 +0000 (19:30 +0000)]
2011-06-21 Oliver Hunt <oliver@apple.com>
Reviewed by Alexey Proskuryakov.
REGRESSION(r89257): It broke 2 jscore tests (Requested by Ossy_away on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=63052
Release mode only failure, the stack overflow guards were getting there error
handling inlined, so that they were essentially causing their own demise.
* parser/JSParser.cpp:
(JSC::JSParser::updateErrorMessage):
(JSC::JSParser::updateErrorWithNameAndMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Tue, 21 Jun 2011 19:29:58 +0000 (19:29 +0000)]
2011-06-21 Dmitry Titov <dimich@chromium.org>
[Chromium] Not reviewed, updating expectations for a flaky test.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Tue, 21 Jun 2011 19:18:11 +0000 (19:18 +0000)]
2011-06-21 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Regression(60942) wrong default action for drag-and-drop.
https://bugs.webkit.org/show_bug.cgi?id=63004
Added special handling for the case that dragOperation is not initialized.
Save the last dropOperation and pass it to the dropEvent, so that it can
be accepted by QDrag.
Call event->accepted() and not event->acceptProposedAction(), because the
later ignores the dropAction specified in JavaScript.
Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401
and did not see any issue.
Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html
and they all pass.
* Api/qwebpage.cpp:
(dropActionToDragOp):
(QWebPagePrivate::dragMoveEvent):
(QWebPagePrivate::dropEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 18:16:35 +0000 (18:16 +0000)]
2011-06-21 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Move logic for deciding whether resource content should be base64 encoded on backend.
https://bugs.webkit.org/show_bug.cgi?id=63069
* inspector/Inspector.json:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourceContent):
(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::getResourceContent):
(WebCore::InspectorPageAgent::searchInResources):
* inspector/InspectorPageAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::getResourceContent):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._innerRequestContent.onResourceContent):
(WebInspector.Resource.prototype._innerRequestContent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Tue, 21 Jun 2011 18:14:12 +0000 (18:14 +0000)]
2011-06-21 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVG no fallback to discrete animation on attribute 'values' for SVGString
https://bugs.webkit.org/show_bug.cgi?id=57085
Check for AnimatedString, AnimatedBoolean and AnimatedEnumeration on 'values' calculation.
If the property type matches one of the above values, fallback to discrete animation.
The patch also changes behavior for String animation. The animation code doesn't handle inheritance
for strings anymore. This is done by the CSS parser itself now, we just need to handle inheritance
on animations that interpolate between two values like for calcMode="linear".
Test: svg/animations/svgstring-animation-fallback-to-discrete.html
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateAnimatedValue):
* svg/SVGAnimateElement.h:
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
2011-06-21 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVG no fallback to discrete animation on attribute 'values' for SVGString
https://bugs.webkit.org/show_bug.cgi?id=57085
Added new test to check fallback to discrete animations on string values. One
test needed rebaseline. Even if we do not pass the test it is still a progression.
* platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
* svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/svgstring-animation-fallback-to-discrete-expected.txt: Added.
* svg/animations/svgstring-animation-fallback-to-discrete.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 18:05:09 +0000 (18:05 +0000)]
2011-06-21 Cary Clark <caryclark@google.com>
Reviewed by Eric Seidel.
Update GraphicsContextSkia when the Chromium platform is Mac
https://bugs.webkit.org/show_bug.cgi?id=62867
No new tests. This does not modify existing code;
there is no change in functionality.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::drawOuterPath):
(WebCore::drawInnerPath):
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):
The OS X framework draws a fatter focus ring than the
Chromium port. Increase the diameter, and add an inner
stroke with more transparency, to match the look of
Chromium on Mac when Skia is the rendering engine.
(WebCore::deviceRGBColorSpaceRef):
Add deviceRGBColorSpaceRef, a static cache of
CGColorSpaceCreateDeviceRGB(). This is called by
the Mac-specific UI when Skia is the rendering engine.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 21 Jun 2011 18:03:36 +0000 (18:03 +0000)]
2011-06-21 Tony Chang <tony@chromium.org>
Try to fix WinCE build. Replace cat with perl -ne "print".
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Tue, 21 Jun 2011 17:47:05 +0000 (17:47 +0000)]
2011-06-21 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Adding version of fast/events/offsetX-offsetY.html without text run or line height deps
https://bugs.webkit.org/show_bug.cgi?id=63073
* fast/events/document-elementFromPoint-expected.txt: Added.
* fast/events/document-elementFromPoint.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 17:32:29 +0000 (17:32 +0000)]
2011-06-21 Alexandru Chiculita <achicu@adobe.com>
Reviewed by Tony Chang.
"WebCore/css/makeprop.pl" and "WebCore/css/makevalues.pl" should take ENABLE_ flags into account
https://bugs.webkit.org/show_bug.cgi?id=62114
Changed the line commenting style in WebCore/css/*.in files from "#" prefixed to "//" prefixed.
That's needed because we now pre-process the files with the C++ pre-processor. Also, there's
no need to manually strip the comments anymore.
Moved the duplication checks from project files to makeprop.pl and makevalues.pl.
In addition makevalues.pl will also lower case the values.
This is a build script refactoring, so no tests are provided.
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_csspropertynames.py:
* WebCore.gyp/scripts/action_cssvaluekeywords.py:
* css/CSSPropertyNames.in: comment style only
* css/CSSValueKeywords.in: comment style only
* css/SVGCSSPropertyNames.in: comment style only
* css/SVGCSSValueKeywords.in: comment style only
* css/WCSSValueKeywords.in: comment style only
* css/makeprop.pl:
* css/makevalues.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 21 Jun 2011 17:30:35 +0000 (17:30 +0000)]
2011-06-21 Ryosuke Niwa <rniwa@webkit.org>
Rolled DEPS.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 16:59:56 +0000 (16:59 +0000)]
2011-06-21 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Sam Weinig.
[GTK] [WK2] WebKit2 build break fixes.
https://bugs.webkit.org/show_bug.cgi?id=62950
When building WebKit2 for GTK there are few build breaks connected with missing include files.
* Platform/unix/SharedMemoryUnix.cpp:
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
* UIProcess/API/gtk/PageClientImpl.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pvarga@webkit.org [Tue, 21 Jun 2011 16:00:05 +0000 (16:00 +0000)]
2011-06-21 Peter Varga <pvarga@webkit.org>
Reviewed by Andreas Kling.
[Qt][V8] Enable ScriptController::disableEval functionality in QtWebkit-V8 build
https://bugs.webkit.org/show_bug.cgi?id=61187
No new tests needed.
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::disableEval):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pvarga@webkit.org [Tue, 21 Jun 2011 15:58:33 +0000 (15:58 +0000)]
2011-06-21 Peter Varga <pvarga@webkit.org>
Reviewed by Andreas Kling.
[Qt][V8] Enable marking objects with complex GC rules
https://bugs.webkit.org/show_bug.cgi?id=61291
No new tests needed.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Tue, 21 Jun 2011 15:11:37 +0000 (15:11 +0000)]
2011-06-21 Stephen White <senorblanco@chromium.org>
Unreviewed.
Remove a now-passing test from chromium's text_expectations. Also
comment out expectations for a few newly-added tests which were
removed by a revert. This makes lint-test-files run cleanly.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Tue, 21 Jun 2011 14:45:14 +0000 (14:45 +0000)]
2011-06-21 Stephen White <senorblanco@chromium.org>
Unreviewed.
Removing a now-passing test from chromium's test_expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 21 Jun 2011 14:32:25 +0000 (14:32 +0000)]
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985
Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
(WebCore::InspectorFrontendClientLocal::isDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::setDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::isJavaScriptProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setJavaScriptProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::startProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::evaluateAsBoolean):
(WebCore::InspectorFrontendClientLocal::evaluateOnLoad):
* inspector/InspectorFrontendClientLocal.h:
* inspector/front-end/InspectorFrontendAPI.js: Added.
(InspectorFrontendAPI.isDebuggingEnabled):
(InspectorFrontendAPI.setDebuggingEnabled):
(InspectorFrontendAPI.isJavaScriptProfilingEnabled):
(InspectorFrontendAPI.setJavaScriptProfilingEnabled):
(InspectorFrontendAPI.isTimelineProfilingEnabled):
(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.isProfilingJavaScript):
(InspectorFrontendAPI.startProfilingJavaScript):
(InspectorFrontendAPI.stopProfilingJavaScript):
(InspectorFrontendAPI.setAttachedWindow):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.isRecordingProfile):
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.stopRecordingProfile):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.get profilerEnabled):
(WebInspector.ProfilesPanel.prototype.enableProfiler):
(WebInspector.ProfilesPanel.prototype.disableProfiler):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.get debuggingEnabled):
(WebInspector.ScriptsPanel.prototype.enableDebugging):
(WebInspector.ScriptsPanel.prototype.disableDebugging):
(WebInspector.ScriptsPanel.prototype.toggleDebugging):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):
(WebInspector.TimelinePanel.prototype.setTimelineProfilingEnabled):
(WebInspector.TimelinePanel.prototype.get timelineProfilingEnabled):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985
Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController destroyInspectorView:]):
* WebInspector/WebInspector.mm:
(-[WebInspector showWindow]):
(-[WebInspector show:]):
(-[WebInspector showConsole:]):
(-[WebInspector isDebuggingJavaScript]):
(-[WebInspector toggleDebuggingJavaScript:]):
(-[WebInspector startDebuggingJavaScript:]):
(-[WebInspector stopDebuggingJavaScript:]):
(-[WebInspector isProfilingJavaScript]):
(-[WebInspector toggleProfilingJavaScript:]):
(-[WebInspector startProfilingJavaScript:]):
(-[WebInspector stopProfilingJavaScript:]):
(-[WebInspector isJavaScriptProfilingEnabled]):
(-[WebInspector setJavaScriptProfilingEnabled:]):
(-[WebInspector isTimelineProfilingEnabled]):
(-[WebInspector setTimelineProfilingEnabled:]):
(-[WebInspector setFrontend:]):
(-[WebInspector releaseFrontend]):
(-[WebInspector showWindow:]):
* WebInspector/WebInspectorFrontend.h:
* WebInspector/WebInspectorFrontend.mm:
(-[WebInspectorFrontend isDebuggingEnabled]):
(-[WebInspectorFrontend setDebuggingEnabled:]):
(-[WebInspectorFrontend isProfilingJavaScript]):
(-[WebInspectorFrontend startProfilingJavaScript]):
(-[WebInspectorFrontend stopProfilingJavaScript]):
(-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
(-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
(-[WebInspectorFrontend isTimelineProfilingEnabled]):
(-[WebInspectorFrontend setTimelineProfilingEnabled:]):
* WebInspector/WebInspectorPrivate.h:
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985
Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.
* WebInspector.cpp:
(WebInspector::createInstance):
(WebInspector::WebInspector):
(WebInspector::webViewClosed):
(WebInspector::showConsole):
(WebInspector::isDebuggingJavaScript):
(WebInspector::toggleDebuggingJavaScript):
(WebInspector::isProfilingJavaScript):
(WebInspector::toggleProfilingJavaScript):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::isTimelineProfilingEnabled):
(WebInspector::setTimelineProfilingEnabled):
* WebInspector.h:
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 14:28:27 +0000 (14:28 +0000)]
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89185.
http://trac.webkit.org/changeset/89185
https://bugs.webkit.org/show_bug.cgi?id=63068
For breaking navigation with inspector opened. (Requested by
pfeldman on #webkit).
* bindings/v8/V8Binding.cpp:
(WebCore::enableStringImplCache):
(WebCore::getStringCache):
(WebCore::cachedStringCallback):
(WebCore::v8ExternalStringSlow):
* bindings/v8/V8Binding.h:
(WebCore::v8ExternalString):
* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::gcPrologue):
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89185.
http://trac.webkit.org/changeset/89185
https://bugs.webkit.org/show_bug.cgi?id=63068
For breaking navigation with inspector opened. (Requested by
pfeldman on #webkit).
* src/WebScriptController.cpp:
(WebKit::WebScriptController::enableV8SingleThreadMode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Tue, 21 Jun 2011 14:16:48 +0000 (14:16 +0000)]
2011-06-21 Stephen White <senorblanco@chromium.org>
Unreviewed.
Skip a test that takes too long on the GPU.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Tue, 21 Jun 2011 13:49:57 +0000 (13:49 +0000)]
2011-06-20 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
New test for patch introduced in r89250
https://bugs.webkit.org/show_bug.cgi?id=63016
* fast/canvas/script-tests/text-globalAlpha.js: Added.
* fast/canvas/text-globalAlpha-expected.txt: Added.
* fast/canvas/text-globalAlpha.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 21 Jun 2011 13:25:07 +0000 (13:25 +0000)]
2011-06-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: rename editScriptSource to setScriptSource.
https://bugs.webkit.org/show_bug.cgi?id=63059
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setScriptSource):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setScriptSource):
* bindings/v8/ScriptDebugServer.h:
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setScriptSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setScriptSource):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didReceiveSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.editSource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.editContent):
(WebInspector.SourceFrameDelegate.prototype.setScriptSource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 13:00:47 +0000 (13:00 +0000)]
2011-06-21 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Show content in network panel correctly when two resources were loaded from the same url with different content.
https://bugs.webkit.org/show_bug.cgi?id=62992
* http/tests/inspector/network/network-cachedresources-with-same-urls.html: Added.
* http/tests/inspector/network/resources/resource.php:
2011-06-21 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Show content in network panel correctly when two resources were loaded from the same url with different content.
https://bugs.webkit.org/show_bug.cgi?id=62992
Test: http/tests/inspector/network/network-cachedresources-with-same-urls.html
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourceContent):
* inspector/InspectorPageAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::getResourceContent):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::addCachedResource):
* inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(WebCore::NetworkResourcesData::ResourceData::setCachedResource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 21 Jun 2011 12:38:00 +0000 (12:38 +0000)]
2011-06-21 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Attached state changes do not affect the drawer height
https://bugs.webkit.org/show_bug.cgi?id=63061
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.enterPanelMode):
(WebInspector.Drawer.prototype.exitPanelMode):
(WebInspector.Drawer.prototype.updateHeight):
* inspector/front-end/inspector.js:
(WebInspector.set attached):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 21 Jun 2011 12:29:02 +0000 (12:29 +0000)]
2011-06-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: Chromium layout test failure after r89317
https://bugs.webkit.org/show_bug.cgi?id=63031
Event Listener sidebar output prints out the full path
to the source file in the sourceName property. For testing
purposes, since the path will be different per system,
clip the early part of the path and leave the expected part.
* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpSelectedElementEventListeners):
(initialize_ElementTest.InspectorTest.dumpObjectPropertySection):
* platform/chromium/inspector/elements/event-listener-sidebar-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 21 Jun 2011 10:30:11 +0000 (10:30 +0000)]
2011-06-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: can't set breakpoint on the last script line.
https://bugs.webkit.org/show_bug.cgi?id=62861
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/debugger-pause-on-breakpoint-expected.txt:
* inspector/debugger/debugger-pause-on-breakpoint.html:
2011-06-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: can't set breakpoint on the last script line.
https://bugs.webkit.org/show_bug.cgi?id=62861
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 21 Jun 2011 09:58:15 +0000 (09:58 +0000)]
2011-06-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: console messages shouldn't prevent garbage collection of iframes
https://bugs.webkit.org/show_bug.cgi?id=62996
* http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt: Added.
* http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html: Added.
* http/tests/inspector-enabled/resources/console-clear-arguments-iframe.html: Added.
2011-06-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: console messages shouldn't prevent garbage collection of iframes
https://bugs.webkit.org/show_bug.cgi?id=62996
When DOMWindow is detached from its frame run through all console messages and clear
their arguments and ScriptState references. The message text in this case will be
the first argument serialized to string.
Test: http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html
* bindings/js/ScriptState.cpp:
(WebCore::domWindowFromScriptState):
* bindings/js/ScriptState.h:
* bindings/v8/ScriptState.cpp:
(WebCore::ScriptState::domWindow):
(WebCore::domWindowFromScriptState):
* bindings/v8/ScriptState.h:
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::windowCleared):
* inspector/ConsoleMessage.h:
* inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
* inspector/InjectedScriptManager.h:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::domWindowCleared):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::pageDestroyedImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::pageDestroyed):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::pageDestroyed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Tue, 21 Jun 2011 09:51:17 +0000 (09:51 +0000)]
2011-06-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] Fix path finding to window objects.
https://bugs.webkit.org/show_bug.cgi?id=63051
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89344
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Tue, 21 Jun 2011 08:56:07 +0000 (08:56 +0000)]
2011-06-21 Yuta Kitamura <yutak@chromium.org>
Unreviewed, update Chromium test expectations for some flaky tests.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 21 Jun 2011 08:43:30 +0000 (08:43 +0000)]
2011-06-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: hovering over linkified nodes
in the UI does not highlight elements on the page.
https://bugs.webkit.org/show_bug.cgi?id=60630
* inspector/front-end/inspector.js:
(WebInspector.wireElementWithDOMNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 21 Jun 2011 07:10:48 +0000 (07:10 +0000)]
[Qt] Unreviewed rollout r89237, r89238 and part of r89243,
because the original patch r89233 was rolled out by r89320.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Tue, 21 Jun 2011 06:56:56 +0000 (06:56 +0000)]
2011-06-20 Yuzo Fujishima <yuzo@google.com>
Reviewed by Kent Tamura.
Fix for Bug 62975 - Refactor local variable usage in CSSFontFaceSource::getFontData
https://bugs.webkit.org/show_bug.cgi?id=62975
No new tests because no behavioral changes.
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): Remove one of fontData variable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Tue, 21 Jun 2011 06:16:48 +0000 (06:16 +0000)]
2011-06-20 Yuta Kitamura <yutak@chromium.org>
Unreviewed, update expected test results on Chromium Mac-Leopard.
* platform/chromium-mac-leopard/svg/dom/SVGNumberList-basics-expected.png: Added.
* platform/chromium-mac-leopard/svg/dom/SVGStringList-basics-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 21 Jun 2011 06:10:54 +0000 (06:10 +0000)]
2011-06-20 Martin Robinson <mrobinson@igalia.com>
Rebaseline a few more SVG tests for GTK+.
* platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
* platform/gtk/svg/batik/text/textEffect-expected.txt:
* platform/gtk/svg/batik/text/textEffect3-expected.txt:
* platform/gtk/svg/batik/text/xmlSpace-expected.txt:
* platform/gtk/svg/custom/glyph-selection-lang-attribute-expected.txt:
* platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
* platform/gtk/svg/text/text-altglyph-01-b-expected.txt:
* platform/gtk/svg/text/text-text-04-t-expected.txt:
* platform/gtk/svg/text/text-text-05-t-expected.txt:
* platform/gtk/svg/text/text-text-06-t-expected.txt:
* platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
* platform/gtk/svg/wicd/test-rightsizing-b-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 21 Jun 2011 06:07:30 +0000 (06:07 +0000)]
2011-06-20 Martin Robinson <mrobinson@igalia.com>
Update the GTK+ skipped list.
Unskip some tests which should now be passing and skip a bunch that
were caused by a recent regression. Reclassify one failure that isn't
actually a crasher.
* platform/gtk/Skipped: Update the skipped list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Tue, 21 Jun 2011 06:05:22 +0000 (06:05 +0000)]
2011-06-20 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
KURL::protocolIs(const char* protocol) asserts in Debug builds with
valid protocols
https://bugs.webkit.org/show_bug.cgi?id=61572
No new tests. No code currently calls protocolIs() with a protocol that
contains a non-letter character.
* platform/KURL.cpp:
(WebCore::isSchemeCharacterMatchIgnoringCase): A helper function that
compares two characters ignoring case. It assumes (and asserts) that
both characters are valid scheme characters, and that if the second
argument is a letter that it is lowercase.
(WebCore::KURL::protocolIs): Call isSchemeCharacterMatchIgnoringCase()
instead of isLetterMatchIgnoringCase().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 21 Jun 2011 03:57:40 +0000 (03:57 +0000)]
2011-06-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed. Fix style error.
* WebCoreSupport/EditorClientEfl.h:
(WebCore::EditorClientEfl::requestCheckingOfString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Tue, 21 Jun 2011 03:54:33 +0000 (03:54 +0000)]
2011-06-20 Yuta Kitamura <yutak@chromium.org>
Unreviewed. Update Chromium test expectation for inspector/elements/event-listener-sidebar.html
and rebaseline SVG tests changed in r89315.
* platform/chromium-win/svg/dom/SVGNumberList-basics-expected.png:
* platform/chromium-win/svg/dom/SVGStringList-basics-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Tue, 21 Jun 2011 03:32:04 +0000 (03:32 +0000)]
2011-06-20 Kenneth Russell <kbr@google.com>
Unreviewed. Updated Chromium test expectations to fix ui_test
WorkerTest.WorkerScriptError after WebKit roll to r89329.
* platform/chromium-win/fast/workers/worker-script-error-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 03:00:16 +0000 (03:00 +0000)]
2011-06-20 Dai Mikurube <dmikurube@chromium.org>
Reviewed by Kent Tamura.
Webkit allows disabled option as value of "required" select
https://bugs.webkit.org/show_bug.cgi?id=62668
* fast/forms/ValidityState-valueMissing-001-expected.txt:
* fast/forms/ValidityState-valueMissing-001.html: Changed to generate form validation error for disabled placeholder label option.
2011-06-20 Dai Mikurube <dmikurube@chromium.org>
Reviewed by Kent Tamura.
Webkit allows disabled option as value of "required" select
https://bugs.webkit.org/show_bug.cgi?id=62668
* html/HTMLSelectElement.cpp: Removed "disabled" checking due to spec change.
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 21 Jun 2011 02:58:22 +0000 (02:58 +0000)]
2011-06-20 Kent Tamura <tkent@chromium.org>
[Chromium] text expectation update for r89116.
* platform/chromium-linux/media/media-controls-clone-expected.png: Added.
* platform/chromium-mac/media/media-controls-clone-expected.png: Added.
* platform/chromium-mac/media/media-controls-clone-expected.txt: Added.
* platform/chromium-win/media/media-controls-clone-expected.png: Added.
* platform/chromium-win/media/media-controls-clone-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 21 Jun 2011 02:23:19 +0000 (02:23 +0000)]
2011-06-20 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Update ANGLE to r696.
https://bugs.webkit.org/show_bug.cgi?id=56396
* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::validateShaderSource): Specify backend.
2011-06-20 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Update ANGLE to r696
https://bugs.webkit.org/show_bug.cgi?id=56396
* ANGLE.xcodeproj/project.pbxproj:
* include/EGL/eglext.h:
* include/GLSLANG/ShaderLang.h:
* src/build_angle.xcodeproj/project.pbxproj:
* src/common/debug.cpp:
(gl::output):
(gl::trace):
(gl::perfActive):
(gl::ScopedPerfEventHelper::ScopedPerfEventHelper):
(gl::ScopedPerfEventHelper::~ScopedPerfEventHelper):
* src/common/debug.h:
* src/common/version.h: Added.
* src/compiler/CodeGenGLSL.cpp:
(ConstructCompiler):
* src/compiler/CodeGenHLSL.cpp:
(ConstructCompiler):
* src/compiler/Compiler.cpp:
(TCompiler::compile):
(TCompiler::mapLongVariableNames):
(TCompiler::getMappedNameMaxLength):
(TCompiler::getExtensionBehavior):
* src/compiler/ConstantUnion.h:
(ConstantUnion::operator==):
(ConstantUnion::operator>):
(ConstantUnion::operator<):
* src/compiler/ExtensionBehavior.h:
(getBehaviorString):
* src/compiler/ForLoopUnroll.cpp: Added.
(ForLoopUnroll::FillLoopIndexInfo):
(ForLoopUnroll::Step):
(ForLoopUnroll::SatisfiesLoopCondition):
(ForLoopUnroll::NeedsToReplaceSymbolWithValue):
(ForLoopUnroll::GetLoopIndexValue):
(ForLoopUnroll::Push):
(ForLoopUnroll::Pop):
(ForLoopUnroll::getLoopIncrement):
(ForLoopUnroll::evaluateIntConstant):
* src/compiler/ForLoopUnroll.h: Added.
(ForLoopUnroll::ForLoopUnroll):
* src/compiler/Initialize.cpp:
(BuiltInFunctionsVertex):
* src/compiler/MapLongVariableNames.cpp: Added.
(MapLongVariableNames::MapLongVariableNames):
(MapLongVariableNames::visitSymbol):
(MapLongVariableNames::visitConstantUnion):
(MapLongVariableNames::visitBinary):
(MapLongVariableNames::visitUnary):
(MapLongVariableNames::visitSelection):
(MapLongVariableNames::visitAggregate):
(MapLongVariableNames::visitLoop):
(MapLongVariableNames::visitBranch):
(MapLongVariableNames::mapVaryingLongName):
* src/compiler/MapLongVariableNames.h: Added.
* src/compiler/OutputESSL.cpp: Added.
(TOutputESSL::TOutputESSL):
(TOutputESSL::writeVariablePrecision):
* src/compiler/OutputESSL.h: Added.
* src/compiler/OutputGLSL.cpp:
(TOutputGLSL::TOutputGLSL):
(TOutputGLSL::writeVariablePrecision):
* src/compiler/OutputGLSL.h:
* src/compiler/OutputGLSLBase.cpp: Added.
(TOutputGLSLBase::TOutputGLSLBase):
(TOutputGLSLBase::writeTriplet):
(TOutputGLSLBase::writeVariableType):
(TOutputGLSLBase::writeFunctionParameters):
(TOutputGLSLBase::writeConstantUnion):
(TOutputGLSLBase::visitSymbol):
(TOutputGLSLBase::visitConstantUnion):
(TOutputGLSLBase::visitBinary):
(TOutputGLSLBase::visitUnary):
(TOutputGLSLBase::visitSelection):
(TOutputGLSLBase::visitAggregate):
(TOutputGLSLBase::visitLoop):
(TOutputGLSLBase::visitBranch):
(TOutputGLSLBase::visitCodeBlock):
* src/compiler/OutputGLSLBase.h: Added.
(TOutputGLSLBase::objSink):
* src/compiler/OutputHLSL.cpp:
(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitUnary):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::visitBranch):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::outputLineDirective):
* src/compiler/OutputHLSL.h:
* src/compiler/ParseHelper.cpp:
(TParseContext::precisionErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::nonInitErrorCheck):
* src/compiler/ParseHelper.h:
(TParseContext::TParseContext):
* src/compiler/ShHandle.h:
* src/compiler/ShaderLang.cpp:
(getVariableInfo):
(ShConstructCompiler):
(ShGetInfo):
(ShGetActiveAttrib):
(ShGetActiveUniform):
* src/compiler/TranslatorESSL.cpp: Added.
(TranslatorESSL::TranslatorESSL):
(TranslatorESSL::translate):
(TranslatorESSL::writeExtensionBehavior):
* src/compiler/TranslatorESSL.h: Added.
* src/compiler/ValidateLimitations.cpp:
(ValidateLimitations::visitBinary):
(ValidateLimitations::visitLoop):
* src/compiler/ValidateLimitations.h:
* src/compiler/VariableInfo.cpp:
(getVariableInfo):
(getBuiltInVariableInfo):
(getUserDefinedVariableInfo):
(CollectAttribsUniforms::visitAggregate):
* src/compiler/VariableInfo.h:
* src/compiler/VersionGLSL.cpp:
(TVersionGLSL::visitSymbol):
(TVersionGLSL::visitConstantUnion):
(TVersionGLSL::visitBinary):
(TVersionGLSL::visitUnary):
(TVersionGLSL::visitSelection):
(TVersionGLSL::visitAggregate):
(TVersionGLSL::visitLoop):
(TVersionGLSL::visitBranch):
* src/compiler/VersionGLSL.h:
* src/compiler/glslang.y:
* src/compiler/glslang_tab.cpp:
* src/compiler/glslang_tab.h:
* src/compiler/intermediate.h:
(TIntermLoop::TIntermLoop):
(TIntermLoop::setUnrollFlag):
(TIntermLoop::getUnrollFlag):
(TIntermSymbol::TIntermSymbol):
(TIntermSymbol::setId):
(TIntermSymbol::setSymbol):
(TIntermSymbol::getOriginalSymbol):
(TIntermAggregate::TIntermAggregate):
(TIntermAggregate::setEndLine):
(TIntermAggregate::getEndLine):
* src/compiler/preprocessor/atom.c:
(AddString):
* src/compiler/preprocessor/compile.h:
* src/compiler/preprocessor/cpp.c:
(CPPelse):
(eval):
(CPPif):
(CPPifdef):
(readCPPline):
(ChkCorrectElseNesting):
* src/compiler/preprocessor/cppstruct.c:
(ResetPreprocessor):
* src/compiler/preprocessor/scanner.c:
(byte_scan):
(yylex_CPP):
* src/compiler/preprocessor/scanner.h:
* src/libEGL/Config.cpp:
(egl::Config::Config):
(egl::Config::set):
(egl::ConfigSet::add):
(egl::ConfigSet::getConfigs):
* src/libEGL/Config.h:
* src/libEGL/Display.cpp:
(egl::Display::Display):
(egl::Display::initialize):
(egl::Display::terminate):
(egl::Display::getConfigAttrib):
(egl::Display::createDevice):
(egl::Display::createWindowSurface):
(egl::Display::createOffscreenSurface):
(egl::Display::createContext):
(egl::Display::destroyContext):
(egl::Display::isInitialized):
(egl::Display::getAdapterIdentifier):
(egl::Display::isDeviceLost):
(egl::Display::getBufferPool):
(egl::Display::initExtensionString):
(egl::Display::getExtensionString):
(egl::Display::getVertexTextureSupport):
(egl::Display::getNonPower2TextureSupport):
* src/libEGL/Display.h:
(egl::Display::isD3d9ExDevice):
* src/libEGL/Surface.cpp:
(egl::Surface::Surface):
(egl::Surface::initialize):
(egl::Surface::release):
(egl::Surface::resetSwapChain):
(egl::SurfaceWindowProc):
(egl::Surface::subclassWindow):
(egl::Surface::unsubclassWindow):
(egl::Surface::swap):
(egl::Surface::getRenderTarget):
(egl::Surface::getOffscreenTexture):
(egl::Surface::getTextureFormat):
(egl::Surface::getTextureTarget):
(egl::Surface::setBoundTexture):
(egl::Surface::getBoundTexture):
(egl::Surface::getFormat):
* src/libEGL/Surface.h:
(egl::Surface::getShareHandle):
* src/libEGL/libEGL.cpp:
(validateDisplay):
(validateConfig):
(validateContext):
(validateSurface):
* src/libEGL/libEGL.rc: Added.
* src/libEGL/libEGL.vcproj:
* src/libEGL/main.cpp:
(DllMain):
* src/libEGL/main.h:
* src/libEGL/resource.h: Added.
* src/libGLESv2/Blit.cpp:
(gl::Blit::initGeometry):
(gl::Blit::copy):
* src/libGLESv2/Blit.h:
* src/libGLESv2/Buffer.cpp:
(gl::Buffer::Buffer):
(gl::Buffer::~Buffer):
(gl::Buffer::bufferData):
(gl::Buffer::bufferSubData):
(gl::Buffer::getStaticVertexBuffer):
(gl::Buffer::getStaticIndexBuffer):
(gl::Buffer::invalidateStaticData):
(gl::Buffer::promoteStaticUsage):
* src/libGLESv2/Buffer.h:
* src/libGLESv2/Context.cpp:
(gl::Context::Context):
(gl::Context::~Context):
(gl::Context::makeCurrent):
(gl::Context::markAllStateDirty):
(gl::Context::setActiveSampler):
(gl::Context::createFramebuffer):
(gl::Context::createFence):
(gl::Context::deleteFramebuffer):
(gl::Context::deleteFence):
(gl::Context::bindTexture2D):
(gl::Context::bindTextureCubeMap):
(gl::Context::getTexture2D):
(gl::Context::getTextureCubeMap):
(gl::Context::getSamplerTexture):
(gl::Context::getIntegerv):
(gl::Context::applyRenderTarget):
(gl::Context::applyState):
(gl::Context::applyVertexBuffer):
(gl::Context::applyShaders):
(gl::Context::applyTextures):
(gl::Context::readPixels):
(gl::Context::clear):
(gl::Context::drawArrays):
(gl::Context::drawElements):
(gl::Context::finish):
(gl::Context::flush):
(gl::Context::drawClosingLine):
(gl::Context::getMaximumVertexTextureImageUnits):
(gl::Context::getMaximumCombinedTextureImageUnits):
(gl::Context::supportsNonPower2Texture):
(gl::Context::detachTexture):
(gl::Context::getIncompleteTexture):
(gl::Context::initExtensionString):
(gl::Context::blitFramebuffer):
(gl::VertexDeclarationCache::VertexDeclarationCache):
(gl::VertexDeclarationCache::~VertexDeclarationCache):
(gl::VertexDeclarationCache::applyDeclaration):
* src/libGLESv2/Context.h:
* src/libGLESv2/Framebuffer.cpp:
(gl::Framebuffer::lookupRenderbuffer):
(gl::Framebuffer::completeness):
* src/libGLESv2/Framebuffer.h:
* src/libGLESv2/HandleAllocator.cpp: Added.
(gl::HandleAllocator::HandleAllocator):
(gl::HandleAllocator::~HandleAllocator):
(gl::HandleAllocator::setBaseHandle):
(gl::HandleAllocator::allocate):
(gl::HandleAllocator::release):
* src/libGLESv2/HandleAllocator.h: Added.
* src/libGLESv2/IndexDataManager.cpp: Added.
(gl::IndexDataManager::IndexDataManager):
(gl::IndexDataManager::~IndexDataManager):
(gl::convertIndices):
(gl::computeRange):
(gl::IndexDataManager::prepareIndexData):
(gl::IndexDataManager::indexSize):
(gl::IndexDataManager::typeSize):
(gl::IndexBuffer::IndexBuffer):
(gl::IndexBuffer::~IndexBuffer):
(gl::IndexBuffer::getBuffer):
(gl::IndexBuffer::unmap):
(gl::StreamingIndexBuffer::StreamingIndexBuffer):
(gl::StreamingIndexBuffer::~StreamingIndexBuffer):
(gl::StreamingIndexBuffer::map):
(gl::StreamingIndexBuffer::reserveSpace):
(gl::StaticIndexBuffer::StaticIndexBuffer):
(gl::StaticIndexBuffer::~StaticIndexBuffer):
(gl::StaticIndexBuffer::map):
(gl::StaticIndexBuffer::reserveSpace):
(gl::StaticIndexBuffer::lookupType):
(gl::StaticIndexBuffer::lookupRange):
(gl::StaticIndexBuffer::addRange):
* src/libGLESv2/IndexDataManager.h: Added.
(gl::IndexBuffer::size):
* src/libGLESv2/Program.cpp:
(gl::Program::getSemanticIndex):
(gl::Program::getSamplerMapping):
(gl::Program::getSamplerTextureType):
(gl::Program::compileToBinary):
(gl::Program::packVaryings):
(gl::Program::linkVaryings):
(gl::Program::link):
(gl::Program::linkUniforms):
(gl::Program::defineUniform):
(gl::Program::applyUniform1iv):
(gl::Program::appendToInfoLogSanitized):
(gl::Program::unlink):
(gl::Program::getActiveUniformMaxLength):
(gl::Program::validate):
(gl::Program::validateSamplers):
* src/libGLESv2/Program.h:
* src/libGLESv2/Renderbuffer.cpp:
(gl::Renderbuffer::getWidth):
(gl::Renderbuffer::getHeight):
(gl::Renderbuffer::getInternalFormat):
(gl::Renderbuffer::getRedSize):
(gl::Renderbuffer::getGreenSize):
(gl::Renderbuffer::getBlueSize):
(gl::Renderbuffer::getAlphaSize):
(gl::Renderbuffer::getDepthSize):
(gl::Renderbuffer::getStencilSize):
(gl::Renderbuffer::getSamples):
(gl::RenderbufferStorage::RenderbufferStorage):
(gl::RenderbufferStorage::getWidth):
(gl::RenderbufferStorage::getHeight):
(gl::RenderbufferStorage::getInternalFormat):
(gl::RenderbufferStorage::getRedSize):
(gl::RenderbufferStorage::getGreenSize):
(gl::RenderbufferStorage::getBlueSize):
(gl::RenderbufferStorage::getAlphaSize):
(gl::RenderbufferStorage::getDepthSize):
(gl::RenderbufferStorage::getStencilSize):
(gl::RenderbufferStorage::getD3DFormat):
(gl::Colorbuffer::Colorbuffer):
(gl::Colorbuffer::getWidth):
(gl::Colorbuffer::getHeight):
(gl::Colorbuffer::getInternalFormat):
(gl::Colorbuffer::getType):
(gl::Colorbuffer::getD3DFormat):
(gl::Colorbuffer::isColorbuffer):
(gl::Colorbuffer::getRenderTarget):
(gl::DepthStencilbuffer::DepthStencilbuffer):
(gl::Depthbuffer::Depthbuffer):
(gl::Stencilbuffer::Stencilbuffer):
* src/libGLESv2/Renderbuffer.h:
* src/libGLESv2/ResourceManager.cpp:
(gl::ResourceManager::createBuffer):
(gl::ResourceManager::createShader):
(gl::ResourceManager::createProgram):
(gl::ResourceManager::createTexture):
(gl::ResourceManager::createRenderbuffer):
(gl::ResourceManager::deleteBuffer):
(gl::ResourceManager::deleteShader):
(gl::ResourceManager::deleteProgram):
(gl::ResourceManager::deleteTexture):
(gl::ResourceManager::deleteRenderbuffer):
(gl::ResourceManager::checkTextureAllocation):
* src/libGLESv2/ResourceManager.h:
* src/libGLESv2/Shader.cpp:
(gl::Shader::Shader):
(gl::Shader::compileToHLSL):
* src/libGLESv2/Shader.h:
* src/libGLESv2/Texture.cpp:
(gl::Texture::Image::Image):
(gl::Texture::Image::~Image):
(gl::Texture::Image::isRenderable):
(gl::Texture::Image::getD3DFormat):
(gl::Texture::Texture):
(gl::Texture::setMinFilter):
(gl::Texture::setMagFilter):
(gl::Texture::setWrapS):
(gl::Texture::setWrapT):
(gl::Texture::loadImageData):
(gl::Texture::loadAlphaImageData):
(gl::Texture::loadAlphaFloatImageData):
(gl::Texture::loadAlphaHalfFloatImageData):
(gl::Texture::loadLuminanceImageData):
(gl::Texture::loadLuminanceFloatImageData):
(gl::Texture::loadLuminanceHalfFloatImageData):
(gl::Texture::loadLuminanceAlphaImageData):
(gl::Texture::loadLuminanceAlphaFloatImageData):
(gl::Texture::loadLuminanceAlphaHalfFloatImageData):
(gl::Texture::loadRGBUByteImageData):
(gl::Texture::loadRGB565ImageData):
(gl::Texture::loadRGBFloatImageData):
(gl::Texture::loadRGBHalfFloatImageData):
(gl::Texture::loadRGBAUByteImageDataSSE2):
(gl::Texture::loadRGBAUByteImageData):
(gl::Texture::loadRGBA4444ImageData):
(gl::Texture::loadRGBA5551ImageData):
(gl::Texture::loadRGBAFloatImageData):
(gl::Texture::loadRGBAHalfFloatImageData):
(gl::Texture::loadBGRAImageData):
(gl::Texture::loadCompressedImageData):
(gl::Texture::createSurface):
(gl::Texture::setImage):
(gl::Texture::setCompressedImage):
(gl::Texture::subImage):
(gl::Texture::subImageCompressed):
(gl::Texture::copyToImage):
(gl::Texture::getTexture):
(gl::Texture::isDirtyParameter):
(gl::Texture::isDirtyImage):
(gl::Texture::resetDirty):
(gl::Texture::getSerial):
(gl::Texture::creationLevels):
(gl::Texture::levelCount):
(gl::Texture::issueSerial):
(gl::Texture2D::Texture2D):
(gl::Texture2D::~Texture2D):
(gl::Texture2D::getWidth):
(gl::Texture2D::getHeight):
(gl::Texture2D::getInternalFormat):
(gl::Texture2D::getType):
(gl::Texture2D::getD3DFormat):
(gl::Texture2D::redefineTexture):
(gl::Texture2D::setImage):
(gl::Texture2D::bindTexImage):
(gl::Texture2D::releaseTexImage):
(gl::Texture2D::setCompressedImage):
(gl::Texture2D::commitRect):
(gl::Texture2D::copyImage):
(gl::Texture2D::copySubImage):
(gl::Texture2D::isComplete):
(gl::Texture2D::isCompressed):
(gl::Texture2D::getBaseTexture):
(gl::Texture2D::createTexture):
(gl::Texture2D::updateTexture):
(gl::Texture2D::convertToRenderTarget):
(gl::Texture2D::generateMipmaps):
(gl::Texture2D::getRenderbuffer):
(gl::Texture2D::getRenderTarget):
(gl::TextureCubeMap::getWidth):
(gl::TextureCubeMap::getHeight):
(gl::TextureCubeMap::getInternalFormat):
(gl::TextureCubeMap::getType):
(gl::TextureCubeMap::getD3DFormat):
(gl::TextureCubeMap::setImagePosX):
(gl::TextureCubeMap::setImageNegX):
(gl::TextureCubeMap::setImagePosY):
(gl::TextureCubeMap::setImageNegY):
(gl::TextureCubeMap::setImagePosZ):
(gl::TextureCubeMap::setImageNegZ):
(gl::TextureCubeMap::setCompressedImage):
(gl::TextureCubeMap::commitRect):
(gl::TextureCubeMap::isComplete):
(gl::TextureCubeMap::isCompressed):
(gl::TextureCubeMap::getBaseTexture):
(gl::TextureCubeMap::createTexture):
(gl::TextureCubeMap::updateTexture):
(gl::TextureCubeMap::convertToRenderTarget):
(gl::TextureCubeMap::setImage):
(gl::TextureCubeMap::redefineTexture):
(gl::TextureCubeMap::copyImage):
(gl::TextureCubeMap::getCubeMapSurface):
(gl::TextureCubeMap::copySubImage):
(gl::TextureCubeMap::generateMipmaps):
(gl::TextureCubeMap::getRenderbuffer):
(gl::TextureCubeMap::getRenderTarget):
* src/libGLESv2/Texture.h:
* src/libGLESv2/VertexDataManager.cpp: Added.
(gl::VertexDataManager::VertexDataManager):
(gl::VertexDataManager::~VertexDataManager):
(gl::VertexDataManager::writeAttributeData):
(gl::VertexDataManager::prepareVertexData):
(gl::VertexDataManager::spaceRequired):
(gl::VertexDataManager::checkVertexCaps):
(gl::VertexDataManager::typeIndex):
(gl::VertexBuffer::VertexBuffer):
(gl::VertexBuffer::~VertexBuffer):
(gl::VertexBuffer::unmap):
(gl::VertexBuffer::getBuffer):
(gl::ConstantVertexBuffer::ConstantVertexBuffer):
(gl::ConstantVertexBuffer::~ConstantVertexBuffer):
(gl::ArrayVertexBuffer::ArrayVertexBuffer):
(gl::ArrayVertexBuffer::~ArrayVertexBuffer):
(gl::ArrayVertexBuffer::addRequiredSpace):
(gl::ArrayVertexBuffer::addRequiredSpaceFor):
(gl::StreamingVertexBuffer::StreamingVertexBuffer):
(gl::StreamingVertexBuffer::~StreamingVertexBuffer):
(gl::StreamingVertexBuffer::map):
(gl::StreamingVertexBuffer::reserveRequiredSpace):
(gl::StaticVertexBuffer::StaticVertexBuffer):
(gl::StaticVertexBuffer::~StaticVertexBuffer):
(gl::StaticVertexBuffer::map):
(gl::StaticVertexBuffer::reserveRequiredSpace):
(gl::StaticVertexBuffer::lookupAttribute):
(gl::VertexDataManager::formatConverter):
* src/libGLESv2/VertexDataManager.h: Added.
(gl::ArrayVertexBuffer::size):
(gl::VertexDataManager::dirtyCurrentValue):
* src/libGLESv2/libGLESv2.cpp:
(validImageSize):
(Extension::glBindTexImage):
* src/libGLESv2/libGLESv2.def:
* src/libGLESv2/libGLESv2.rc: Added.
* src/libGLESv2/libGLESv2.vcproj:
* src/libGLESv2/main.cpp:
(error):
* src/libGLESv2/mathutil.h:
(gl::clamp):
(gl::clamp01):
(gl::transformPixelRect):
(gl::transformPixelYOffset):
(gl::adjustWinding):
(gl::supportsSSE2):
* src/libGLESv2/resource.h: Added.
* src/libGLESv2/utilities.cpp:
(gl::ComputeCompressedPitch):
(es2dx::ConvertCubeFace):
(es2dx::ConvertPrimitiveType):
(es2dx::ConvertRenderbufferFormat):
(es2dx::GetMultisampleTypeFromSamples):
(dx2es::GetStencilSize):
(dx2es::GetAlphaSize):
(dx2es::GetRedSize):
(dx2es::GetGreenSize):
(dx2es::GetBlueSize):
(dx2es::GetDepthSize):
(getTempPath):
(writeFile):
* src/libGLESv2/utilities.h:
* src/libGLESv2/vertexconversion.h: Added.
(gl::Identity::convert):
(gl::Cast::convert):
(gl::Normalize::convert):
(gl::FixedToFloat::convert):
(gl::SimpleDefaultValues::zero):
(gl::SimpleDefaultValues::one):
(gl::NormalizedDefaultValues::zero):
(gl::NormalizedDefaultValues::one):
(gl::VertexDataConverter::convertArray):
(gl::VertexDataConverter::pointerAddBytes):
(gl::VertexDataConverter::copyComponent):
2011-06-20 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Update ANGLE to r696
https://bugs.webkit.org/show_bug.cgi?id=56396
* fast/canvas/webgl/glsl-conformance.html: Fix a bug in the test (otherwise after the roll this test will fail).
* platform/chromium/test_expectations.txt: Once this test is fixed, it should pass in chromium.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Tue, 21 Jun 2011 01:41:58 +0000 (01:41 +0000)]
2011-06-20 Kenneth Russell <kbr@google.com>
Unreviewed Chromium expectations update. Suppressions after recent commits.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 21 Jun 2011 01:35:18 +0000 (01:35 +0000)]
2011-06-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Group load-initiating and stopping functions in FrameLoader.h
https://bugs.webkit.org/show_bug.cgi?id=63030
No function change, thus no tests.
* loader/FrameLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 01:33:33 +0000 (01:33 +0000)]
2011-06-20 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] ChromeClientEfl doesn't need to check whether m_view is null.
https://bugs.webkit.org/show_bug.cgi?id=62978
Remove unnecessary check routines of m_view because ChromeClientEfl have
valid m_view always.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::ChromeClientEfl): Add ASSERT(m_view)
(WebCore::ChromeClientEfl::windowRect):
(WebCore::ChromeClientEfl::setWindowRect):
(WebCore::ChromeClientEfl::pageRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 01:22:07 +0000 (01:22 +0000)]
2011-06-20 Sailesh Agrawal <sail@chromium.org>
Reviewed by Mihai Parparita.
[Chromium] Draw search tickmarks on overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=62783
This change adds search tickmark support for overlay scrollbars. Tickmarks are only drawn when the scroll track is visible.
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:Split the scrollbar drawing code into a track and knob version.
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarPainterPaint):
(wkScrollbarPainterPaintTrack):
(wkScrollbarPainterPaintKnob):
* platform/chromium/ScrollbarThemeChromiumMac.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:Factor out the paint tickmark code and call it from the overlay scrollbar drawing code.
(WebCore::ScrollbarThemeChromiumMac::paint):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 21 Jun 2011 01:07:04 +0000 (01:07 +0000)]
2011-06-20 Adam Barth <abarth@webkit.org>
Mac build fix. In addition to adding the files to the project, we need
to add them to the WebCore target.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 21 Jun 2011 01:01:36 +0000 (01:01 +0000)]
2011-06-20 Adam Barth <abarth@webkit.org>
Update image results after mpilgrim's exception type change.
* platform/chromium-linux/svg/dom/SVGNumberList-basics-expected.png:
* platform/chromium-linux/svg/dom/SVGStringList-basics-expected.png:
* platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 21 Jun 2011 01:00:18 +0000 (01:00 +0000)]
2011-06-20 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove numRequests
https://bugs.webkit.org/show_bug.cgi?id=63028
numRequests exists just to cargo-cult null-check m_frame->document(),
which is always non-null.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):
(WebCore::FrameLoader::numPendingOrLoadingRequests):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 21 Jun 2011 00:57:31 +0000 (00:57 +0000)]
2011-06-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
startWordBoundary() in visible_units.cpp assumes that all characters are 16 bit
https://bugs.webkit.org/show_bug.cgi?id=63027
No new tests, because I don't see this affect any webkit.org ports.
* editing/visible_units.cpp: (WebCore::startWordBoundary): Previous offset is not just minus
one - we need to use a proper macro to iterate.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jcivelli@chromium.org [Tue, 21 Jun 2011 00:36:27 +0000 (00:36 +0000)]
2011-06-20 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Making SharedBufferCRLFLineReader more generic, so it can be used to read MHTML
file with binary parts.
https://bugs.webkit.org/show_bug.cgi?id=62966
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/archive/mhtml/MHTMLParser.cpp:
(WebCore::skipLinesUntilBoundaryFound):
(WebCore::MHTMLParser::MHTMLParser):
(WebCore::MHTMLParser::parseNextPart):
* loader/archive/mhtml/MHTMLParser.h:
* platform/SharedBufferChunkReader.cpp: Renamed from Source/WebCore/platform/SharedBufferCRLFLineReader.cpp.
(WebCore::SharedBufferChunkReader::SharedBufferChunkReader):
(WebCore::SharedBufferChunkReader::setSeparator):
(WebCore::SharedBufferChunkReader::nextChunk):
* platform/SharedBufferChunkReader.h: Renamed from Source/WebCore/platform/SharedBufferCRLFLineReader.h.
* platform/network/MIMEHeader.cpp:
(WebCore::retrieveKeyValuePairs):
(WebCore::MIMEHeader::parseHeader):
* platform/network/MIMEHeader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Tue, 21 Jun 2011 00:36:09 +0000 (00:36 +0000)]
2011-06-20 Kenneth Russell <kbr@google.com>
Unreviewed Chromium expectations update. Revert the expectations
for http/tests/misc/acid3.html after r89233 was rolled out.
Commented on other test expectations added for r89233.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 21 Jun 2011 00:34:12 +0000 (00:34 +0000)]
2011-06-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Windowless plugins sometimes crash with a BadMatch error
https://bugs.webkit.org/show_bug.cgi?id=63020
Do not try to create an XPixmap with any of the dimensions as zero.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget): Guard against and empty window rect
before trying to create a windowless plugin pixmap.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Tue, 21 Jun 2011 00:04:23 +0000 (00:04 +0000)]
2011-06-20 Antonio Gomes <agomes@rim.com>
Reviewed by Ryosuke Niwa.
Stop adding empty rects in FrameSelection::getClippedVisibleTextRectangles
https://bugs.webkit.org/show_bug.cgi?id=63018
No new tests needed, since it causes no behavioral change.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::getClippedVisibleTextRectangles):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Tue, 21 Jun 2011 00:01:18 +0000 (00:01 +0000)]
2011-06-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: CRASH if Expanding Event Listener on document
https://bugs.webkit.org/show_bug.cgi?id=61834
Add a test to list the event listeners in the sidebar.
This test includes event listeners on the document, and
it expands each of the sections which would have caused
the CRASH fixed by this patch.
* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.expandAndDumpSelectedElementEventListeners):
(initialize_ElementTest.InspectorTest.expandSelectedElementEventListeners):
(initialize_ElementTest.InspectorTest.expandSelectedElementEventListenersSubsections):
(initialize_ElementTest.InspectorTest.expandSelectedElementEventListenersEventBars):
(initialize_ElementTest.InspectorTest.dumpSelectedElementEventListeners):
(initialize_ElementTest.InspectorTest.dumpObjectPropertySection):
* inspector/elements/event-listener-sidebar-expected.txt: Added.
* inspector/elements/event-listener-sidebar.html: Added.
* platform/chromium/inspector/elements/event-listener-sidebar-expected.txt: Added.
Chromium has slightly different results. It has more properties
and includes extra information, like line numbers, for functions.
2011-06-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: CRASH if Expanding Event Listener on document
https://bugs.webkit.org/show_bug.cgi?id=61834
Node::ownerDocument returns null for a document node. So, in
the case of a document node in resolveNode, use Node::document
which returns the node, as a document.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::resolveNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Tue, 21 Jun 2011 00:01:04 +0000 (00:01 +0000)]
2011-06-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Darin Adler.
Minimize memory due to layer backing stores for pages in the Page Cache
https://bugs.webkit.org/show_bug.cgi?id=62675
Test the layer tree of a page with composited content,
including content in iframes, looks like we expect.
Enabling clearing backing stores in the PageCache should
produce the same expected results.
* compositing/iframes/page-cache-layer-tree-expected.txt: Added.
* compositing/iframes/page-cache-layer-tree.html: Added.
* compositing/iframes/resources/page-cache-helper.html: Added.
* compositing/iframes/resources/page-cache-iframe.html: Added.
2011-06-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Simon Fraser.
Minimize memory due to layer backing stores for pages in the Page Cache
https://bugs.webkit.org/show_bug.cgi?id=62675
When a page enters the page cache there is now an option on
the PageCache singleton to clear the backing stores and layers
of the cached page. This can be useful to minimize the amount
of memory the stored page consumes.
This only affects memory usage and is disabled by default, so no test.
* history/CachedFrame.h:
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::CachedFrameBase):
Save whether or not the page had composited content or not
in a new instance variable, m_isComposited.
(WebCore::CachedFrameBase::restore):
When restoring, rebuild the compositing tree if it may have
been destroyed.
(WebCore::CachedFrame::CachedFrame):
When saving, clear the backing stores if the page is in
compositing mode, and the PageCache setting is enabled.
* history/PageCache.cpp:
(WebCore::PageCache::PageCache):
* history/PageCache.h:
(WebCore::PageCache::shouldClearBackingStores):
(WebCore::PageCache::setShouldClearBackingStores):
A setting to opt-in to the new behavior of clearing
the backing stores.
* page/FrameView.h:
* page/FrameView.cpp:
(WebCore::FrameView::clearBackingStores):
(WebCore::FrameView::restoreBackingStores):
To clear all backing stores we disable compositing
for the frame, to detach the root platform layer,
and recursively clear backing stores from the root
layer of the FrameView.
* rendering/RenderLayer.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clearBackingIncludingDescendants):
Recursively call clearBacking.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 20 Jun 2011 23:54:07 +0000 (23:54 +0000)]
2011-06-20 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IDL generator should throw TypeError instead of SyntaxError on not enough arguments
https://bugs.webkit.org/show_bug.cgi?id=63011
To align with WebIDL, we should throw TypeError whenever a function
is called with missing required arguments.
* fast/canvas/canvas-overloads-drawImageFromRect-expected.txt:
* fast/canvas/canvas-overloads-fillText-expected.txt:
* fast/canvas/canvas-overloads-strokeText-expected.txt:
* fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js:
* fast/canvas/script-tests/canvas-overloads-fillText.js:
* fast/canvas/script-tests/canvas-overloads-strokeText.js:
* fast/canvas/webgl/data-view-test-expected.txt:
* http/tests/xmlhttprequest/exceptions-expected.txt:
* platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
* platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
* svg/dom/SVGAngle-expected.txt:
* svg/dom/SVGColor-expected.txt:
* svg/dom/SVGLength-expected.txt:
* svg/dom/SVGLengthList-basics-expected.txt:
* svg/dom/SVGMatrix-expected.txt:
* svg/dom/SVGNumberList-basics-expected.txt:
* svg/dom/SVGPaint-expected.txt:
* svg/dom/SVGPoint-expected.txt:
* svg/dom/SVGPointList-basics-expected.txt:
* svg/dom/SVGStringList-basics-expected.txt:
* svg/dom/SVGTransform-expected.txt:
* svg/dom/SVGTransformList-basics-expected.txt:
* svg/dom/SVGTransformList-expected.txt:
* svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
2011-06-20 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Adam Barth.
IDL generator should throw TypeError instead of SyntaxError on not enough arguments
https://bugs.webkit.org/show_bug.cgi?id=63011
To align with WebIDL, we should throw TypeError whenever a function
is called with missing required arguments.
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 20 Jun 2011 23:51:54 +0000 (23:51 +0000)]
2011-05-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
REGRESSION: [CAIRO] wrong drawing of Gradients and Patterns on texts
https://bugs.webkit.org/show_bug.cgi?id=31507
Unskip a test which is now passing and update pixel results with correct
output.
* platform/gtk/Skipped:
* platform/gtk/fast/canvas/canvas-text-alignment-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
* platform/gtk/svg/batik/text/textDecoration-expected.png:
* platform/gtk/svg/batik/text/textEffect-expected.png:
* platform/gtk/svg/batik/text/textEffect3-expected.png:
* platform/gtk/svg/css/composite-shadow-text-expected.png:
* platform/gtk/svg/css/text-gradient-shadow-expected.png:
* platform/gtk/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/gtk/svg/custom/js-late-gradient-creation-expected.png:
* platform/gtk/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/gtk/svg/custom/js-late-pattern-creation-expected.png:
* platform/gtk/svg/custom/pattern-with-transformation-expected.png:
* platform/gtk/svg/text/text-align-03-b-expected.png:
* platform/gtk/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
2011-05-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
REGRESSION: [CAIRO] wrong drawing of Gradients and Patterns on texts
https://bugs.webkit.org/show_bug.cgi?id=31507
When painting text, be sure to set the pattern fill or gradient before modifying the Cairo
context CTM. This ensures that gradients and patterns are scaled and positioned properly in
the coordinate system of the page. Abstract out the fill preparation to avoid repeating this
logic and perform a bit of cleanup.
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::prepareContextForGlyphDrawing): Now set the x and y position of the text using the glyph
offsets. This avoids having to set a transformation matrix when there is no synthetic oblique.
(WebCore::drawGlyphsToContext): Add a newline as part of cleanup. Call prepareContextForGlyphDrawing from here
and restor the original CTM when exiting.
(WebCore::drawGlyphsShadow): Use drawGlyphsToContext here to ensure that all glyph drawing goes through
the same path.
(WebCore::Font::drawGlyphs): Fix a C-style cast and use the glyph offsets to position the glyphs instead
of adjusting the transformation matrix. Use GC::prepareForFilling and GC::prepareForStroking instead of
setting up the fill and stroke manually.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::fillRectWithColor): Renamed fillRectSourceOver to fillRectWithColor to make it clearer
why this is different than the slower fill method. Moved the no transparency early return here.
(WebCore::drawPathShadow): Instead of calling setPlatformFill, just perform a cheap fill and stroke
with red color. Since the shadow is used as a mask, the actual fill shouldn't matter.
(WebCore::reduceSourceByAlpha): Added this helper.
(WebCore::GraphicsContext::prepareForFilling): Added this method adapted from setPlatformFill, which
correctly handles the transformation matrix.
(WebCore::GraphicsContext::prepareForStroking): Ditto for stroking.
(WebCore::shadowAndFillCurrentCairoPath): Adapted from fillCurrentCairoPath, but renamed to clarify
what it does and no uses prepareForFilling.
(WebCore::shadowAndStrokeCurrentCairoPath): Ditto for stroking.
(WebCore::GraphicsContext::drawRect): Update for new method names.
(WebCore::GraphicsContext::drawLine): Ditto.
(WebCore::GraphicsContext::fillPath): Ditto.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto. Remove the unnecessary save/restore pair here.
(WebCore::GraphicsContext::strokeRect): Update to reflect new method names.
* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::reduceSourceByAlpha): Added this helper.
(WebCore::GraphicsContext::prepareForFilling): Added this method adapted from setPlatformFill, which
correctly handles the transformation matrix.
(WebCore::GraphicsContext::prepareForStroking): Ditto for stroking.
(WebCore::reduceSourceByAlpha):
* platform/graphics/cairo/PlatformContextCairo.h: Added new method declarations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Jun 2011 23:44:19 +0000 (23:44 +0000)]
2011-06-20 Tim Horton <timothy_horton@apple.com>
Reviewed by Darin Adler.
Incorrect clamping on SVG masks when root element is not located at (0,0)
https://bugs.webkit.org/show_bug.cgi?id=63019
* platform/mac/svg/custom/absolute-root-position-masking-expected.png: Added.
* platform/mac/svg/custom/absolute-root-position-masking-expected.txt: Added.
* platform/qt/svg/custom/absolute-root-position-masking-expected.png: Added.
* platform/qt/svg/custom/absolute-root-position-masking-expected.txt: Added.
* svg/custom/absolute-root-position-masking.xhtml: Added.
2011-06-20 Tim Horton <timothy_horton@apple.com>
Reviewed by Darin Adler.
Incorrect clamping on SVG masks when root element is not located at (0,0)
https://bugs.webkit.org/show_bug.cgi?id=63019
We should be using frameRect(), not contentBoxRect() for the rect to
clamp to when creating an SVG mask image.
Test: svg/custom/absolute-root-position-masking.xhtml
* rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::clampedAbsoluteTargetRectForRenderer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 20 Jun 2011 23:32:54 +0000 (23:32 +0000)]
2011-06-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FrameLoader::m_workingURL
https://bugs.webkit.org/show_bug.cgi?id=63021
FrameLoader shouldn't keep the working URL in separate state. It's
just a function of other state. m_workingURL exists only to create
bugs and confusion.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::documentURL):
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::willSetEncoding):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::finishedLoadingDocument):
* loader/FrameLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Mon, 20 Jun 2011 23:29:57 +0000 (23:29 +0000)]
2011-06-20 Kenneth Russell <kbr@google.com>
Unreviewed.
Rolled out r89233 and r89235 because of crashes in http/tests/misc/acid3.html on Snow Leopard and other platforms
https://bugs.webkit.org/show_bug.cgi?id=63022
* platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
* platform/mac/svg/batik/text/textEffect-expected.png:
* platform/mac/svg/batik/text/textEffect-expected.txt:
* platform/mac/svg/batik/text/textEffect3-expected.png:
* platform/mac/svg/batik/text/textEffect3-expected.txt:
* platform/mac/svg/batik/text/xmlSpace-expected.png:
* platform/mac/svg/batik/text/xmlSpace-expected.txt:
* platform/mac/svg/custom/glyph-selection-lang-attribute-expected.png:
* platform/mac/svg/custom/glyph-selection-lang-attribute-expected.txt:
* platform/mac/svg/custom/svg-fonts-fallback-expected.png: Removed.
* platform/mac/svg/custom/svg-fonts-fallback-expected.txt: Removed.
* platform/mac/svg/custom/svg-fonts-segmented-expected.png: Removed.
* platform/mac/svg/custom/svg-fonts-segmented-expected.txt: Removed.
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
* platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
* platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/mac/svg/custom/svg-fonts-word-spacing-expected.png: Removed.
* platform/mac/svg/custom/svg-fonts-word-spacing-expected.txt: Removed.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
* platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
* platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
* platform/mac/svg/text/text-altglyph-01-b-expected.png:
* platform/mac/svg/text/text-altglyph-01-b-expected.txt:
* platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.png: Removed.
* platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Removed.
* platform/mac/svg/text/text-text-04-t-expected.png:
* platform/mac/svg/text/text-text-04-t-expected.txt:
* platform/mac/svg/text/text-text-05-t-expected.png:
* platform/mac/svg/text/text-text-05-t-expected.txt:
* platform/mac/svg/text/text-text-06-t-expected.png:
* platform/mac/svg/text/text-text-06-t-expected.txt:
* platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
* platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
* platform/mac/svg/wicd/test-rightsizing-b-expected.png:
* platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
* svg/custom/resources/ABCFont.svg:
* svg/custom/svg-fonts-fallback.xhtml: Removed.
* svg/custom/svg-fonts-segmented.xhtml: Removed.
* svg/custom/svg-fonts-word-spacing.html: Removed.
* svg/text/select-text-svgfont-expected.txt: Removed.
* svg/text/select-text-svgfont.html: Removed.
* svg/text/text-overflow-ellipsis-svgfont.html: Removed.
2011-06-20 Kenneth Russell <kbr@google.com>
Unreviewed.
Rolled out r89233 and r89235 because of crashes in http/tests/misc/acid3.html on Snow Leopard and other platforms
https://bugs.webkit.org/show_bug.cgi?id=63022
* wtf/Platform.h:
2011-06-20 Kenneth Russell <kbr@google.com>
Unreviewed.
Rolled out r89233 and r89235 because of crashes in http/tests/misc/acid3.html on Snow Leopard and other platforms
https://bugs.webkit.org/show_bug.cgi?id=63022
* features.pri:
* page/DOMWindow.idl:
* platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::width):
(WebCore::Font::selectionRectForText):
(WebCore::Font::offsetForPosition):
(WebCore::Font::codePath):
* platform/graphics/Font.h:
* platform/graphics/FontFallbackList.h:
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter):
(WebCore::Font::getEmphasisMarkGlyphData):
(WebCore::Font::drawGlyphBuffer):
* platform/graphics/FontMetrics.h:
* platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::fill):
* platform/graphics/SVGGlyph.h:
(WebCore::SVGGlyph::SVGGlyph):
(WebCore::SVGGlyph::operator==):
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::widthForGlyph):
* platform/graphics/TextRun.h:
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance):
* platform/graphics/WidthIterator.h:
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::scaleEmToUnits):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::scaleEmToUnits):
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::scaleEmToUnits):
* rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::SVGTextMetrics):
(WebCore::constructTextRun):
(WebCore::SVGTextMetrics::measureCharacterRange):
* rendering/svg/SVGTextMetrics.h:
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::convertEmUnitToPixel):
(WebCore::isVerticalWritingMode):
(WebCore::firstParentRendererForNonTextNode):
(WebCore::referencingRenderObjectFromRun):
(WebCore::SVGTextRunWalker::SVGTextRunWalker):
(WebCore::SVGTextRunWalker::walk):
(WebCore::floatWidthUsingSVGFontCallback):
(WebCore::floatWidthMissingGlyphCallback):
(WebCore::floatWidthOfSubStringUsingSVGFont):
(WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont):
(WebCore::drawTextUsingSVGFontCallback):
(WebCore::drawTextMissingGlyphCallback):
(WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont):
(WebCore::SVGTextRunRenderingContext::selectionRectForTextUsingSVGFont):
(WebCore::SVGTextRunRenderingContext::offsetForPositionForTextUsingSVGFont):
* rendering/svg/SVGTextRunRenderingContext.h:
* svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::glyphElement):
* svg/SVGAltGlyphElement.h:
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::initializeFontData):
* svg/SVGFontData.h:
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
(WebCore::SVGFontElement::ensureGlyphCache):
* svg/SVGGlyphMap.h:
(WebCore::SVGGlyphMap::addGlyphByUnicodeString):
* svg/svgtags.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Jun 2011 23:23:11 +0000 (23:23 +0000)]
2011-06-20 Dmitry Lomov <dslomov@google.com>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=63017
"Unit tests" step on bots should provide more information in case of failure.
* BuildSlaveSupport/build.webkit.org-config/master.cfg: added --verbose flag to UnitTests step.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Jun 2011 23:16:24 +0000 (23:16 +0000)]
2011-06-20 Scott Byer <scottbyer@chromium.org>
Reviewed by Adam Barth.
Smooth scrolling for Chromium, initial patch.
https://bugs.webkit.org/show_bug.cgi?id=61878
Add in a default scrolling animator in the platform directory, with a run time enable switch, to provide
animated / smooth scrolling on platforms and for input devices where it's not provided by the platform, and to
be easily configurable to what situatuations the animations are provided for. The smooth scrolling code is
compiled out by default.
Unit tests in chromium/ScrollAnimatorNoneTest.cpp
* WebCore.gypi:
* page/FrameView.cpp:
(WebCore::FrameView::scrollAnimatorEnabled):
* page/FrameView.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setEnableScrollAnimator):
(WebCore::Settings::scrollAnimatorEnabled):
* platform/ScrollAnimatorNone.cpp: Added.
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorNone::Parameters::Parameters):
(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::attackCurve):
(WebCore::ScrollAnimatorNone::PerAxisData::releaseCurve):
(WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):
(WebCore::ScrollAnimatorNone::PerAxisData::PerAxisData):
(WebCore::ScrollAnimatorNone::PerAxisData::reset):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::PerAxisData::animateScroll):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::~ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):
* platform/ScrollAnimatorNone.h: Added.
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollAnimatorEnabled):
2011-06-20 Scott Byer <scottbyer@chromium.org>
Reviewed by Adam Barth.
Smooth scrolling for Chromium, initial patch.
https://bugs.webkit.org/show_bug.cgi?id=61878
Add in a default scrolling animator in the platform directory, with a run time enable switch, to provide
animated / smooth scrolling on platforms and for input devices where it's not provided by the platform, and to
be easily configurable to what situatuations the animations are provided for. The smooth scrolling code is
compiled out by default.
Unit tests ScrollAnimatorNoneTest.cpp
* WebKit.gypi:
* features.gypi:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setEnableScrollAnimator):
* src/WebSettingsImpl.h:
* tests/ScrollAnimatorNoneTest.cpp: Added.
(MockScrollableArea::MockScrollableArea):
(MockScrollableArea::scrollAnimatorEnabled):
(MockScrollAnimatorNone::MockScrollAnimatorNone):
(MockScrollAnimatorNone::currentX):
(MockScrollAnimatorNone::currentY):
(MockScrollAnimatorNone::reset):
(TEST):
(ScrollAnimatorNoneTest::ScrollAnimatorNoneTest):
(ScrollAnimatorNoneTest::SetUp):
(ScrollAnimatorNoneTest::TearDown):
(ScrollAnimatorNoneTest::reset):
(ScrollAnimatorNoneTest::updateDataFromParameters):
(ScrollAnimatorNoneTest::animateScroll):
(ScrollAnimatorNoneTest::curveIntegralAt):
(ScrollAnimatorNoneTest::attackArea):
(ScrollAnimatorNoneTest::releaseArea):
(ScrollAnimatorNoneTest::attackCurve):
(ScrollAnimatorNoneTest::releaseCurve):
(ScrollAnimatorNoneTest::curveDerivativeAt):
(ScrollAnimatorNoneTest::curveTestInner):
(ScrollAnimatorNoneTest::curveTest):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Mon, 20 Jun 2011 23:14:23 +0000 (23:14 +0000)]
2011-06-20 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Remove some unsafe static_cast in rendering/
https://bugs.webkit.org/show_bug.cgi?id=63014
Mechanical refactoring, no test needed.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::getEmphasisMarkPosition):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::destroyScrollbar):
* rendering/RenderRuby.cpp:
(WebCore::rubyBeforeBlock):
(WebCore::rubyAfterBlock):
(WebCore::lastRubyRun):
(WebCore::findRubyRunParent):
* rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::rubyRun):
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::removeChild):
Use the proper conversion methods at the previous call-sites.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 20 Jun 2011 23:11:52 +0000 (23:11 +0000)]
2011-06-20 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Web archive resource loads are scheduled together with network loads
https://bugs.webkit.org/show_bug.cgi?id=63024
<rdar://problem/
9508564>
If the resource being loaded is loaded from a web archive we don't need to schedule the load
since it won't touch the network.
* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleLoad):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 20 Jun 2011 23:05:40 +0000 (23:05 +0000)]
2011-06-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: order shards by name, not number of tests
https://bugs.webkit.org/show_bug.cgi?id=62753
* Scripts/webkitpy/layout_tests/layout_package/manager.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 20 Jun 2011 23:02:58 +0000 (23:02 +0000)]
2011-06-20 Ryosuke Niwa <rniwa@webkit.org>
Qt Rebaseline for r89257.
* platform/qt/fast/tokenizer/002-expected.txt:
* platform/qt/fast/tokenizer/external-script-document-write_2-expected.txt:
* platform/qt/fast/tokenizer/script_extra_close-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
psolanki@apple.com [Mon, 20 Jun 2011 22:45:45 +0000 (22:45 +0000)]
2011-06-20 Pratik Solanki <psolanki@apple.com>
Reviewed by David Kilzer.
HTTP pipelining functions on mac should match windows
https://bugs.webkit.org/show_bug.cgi?id=63012
Use a CFURLRequestRef instead of NSURLRequest for the HTTP pipelining functions.
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
2011-06-20 Pratik Solanki <psolanki@apple.com>
Reviewed by David Kilzer.
HTTP pipelining functions on mac should match windows
https://bugs.webkit.org/show_bug.cgi?id=63012
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 20 Jun 2011 22:36:44 +0000 (22:36 +0000)]
2011-06-20 Ryosuke Niwa <rniwa@webkit.org>
Fix bit flag collision.
* editing/FrameSelection.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 20 Jun 2011 22:25:13 +0000 (22:25 +0000)]
2011-06-20 Ryosuke Niwa <rniwa@webkit.org>
WinCE build fix after r89293.
* WebCoreSupport/EditorClientWinCE.cpp:
(WebKit::EditorClientWinCE::handleEditingKeyboardEvent):
2011-06-20 Ryosuke Niwa <rniwa@webkit.org>
EFL build fix after r89293.
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::handleEditingKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 20 Jun 2011 22:22:53 +0000 (22:22 +0000)]
2011-06-20 Martin Robinson <mrobinson@igalia.com>
Rebaseline some tests for GTK+ after r89257.
* platform/gtk/fast/tokenizer/002-expected.txt:
* platform/gtk/fast/tokenizer/external-script-document-write_2-expected.txt:
* platform/gtk/fast/tokenizer/script_extra_close-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Mon, 20 Jun 2011 22:21:48 +0000 (22:21 +0000)]
Unreviewed build fix; Fix Leopard WebCore build.
* platform/mac/WebVideoFullscreenHUDWindowController.mm: On Leopard, NSWindowDelegate
is a category, not a protocol.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 20 Jun 2011 22:13:17 +0000 (22:13 +0000)]
2011-06-20 Martin Robinson <mrobinson@igalia.com>
Rebaseline many SVG tests for GTK+ after r89233 and update the skipped list to include
a new test that relies on the didRunInsecureContent callback. Add a platform-specific
result for fast/dom/Window/window-properties.html as we now have the media stream
feature enabled on the bots.
* platform/gtk/Skipped: Update the skipped list.
* platform/gtk/fast/dom/Window/window-properties-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
* platform/gtk/svg/batik/text/textEffect-expected.png:
* platform/gtk/svg/batik/text/textEffect-expected.txt:
* platform/gtk/svg/batik/text/textEffect3-expected.png:
* platform/gtk/svg/batik/text/textEffect3-expected.txt:
* platform/gtk/svg/batik/text/xmlSpace-expected.png:
* platform/gtk/svg/batik/text/xmlSpace-expected.txt:
* platform/gtk/svg/custom/glyph-selection-lang-attribute-expected.png:
* platform/gtk/svg/custom/glyph-selection-lang-attribute-expected.txt:
* platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.png:
* platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/gtk/svg/foreignObject/text-tref-02-b-expected.png:
* platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
* platform/gtk/svg/text/text-altglyph-01-b-expected.png:
* platform/gtk/svg/text/text-altglyph-01-b-expected.txt:
* platform/gtk/svg/text/text-text-04-t-expected.png:
* platform/gtk/svg/text/text-text-04-t-expected.txt:
* platform/gtk/svg/text/text-text-05-t-expected.png:
* platform/gtk/svg/text/text-text-05-t-expected.txt:
* platform/gtk/svg/text/text-text-06-t-expected.png:
* platform/gtk/svg/text/text-text-06-t-expected.txt:
* platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.png:
* platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
* platform/gtk/svg/wicd/test-rightsizing-b-expected.png:
* platform/gtk/svg/wicd/test-rightsizing-b-expected.txt:
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 20 Jun 2011 22:03:28 +0000 (22:03 +0000)]
2011-06-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Various editing functions take boolean userTriggered but should be replaced by an enum
https://bugs.webkit.org/show_bug.cgi?id=62933
Replaced boolean userTriggered in many functions by new EUserTriggered enum.
* WebCore.exp.in: FrameSelection::modify's signature changed.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange): Calls FrameSelection::moveTo.
* editing/EditorCommand.cpp:
(WebCore::executeMoveBackward): Calls FrameSelection::modify.
(WebCore::executeMoveBackwardAndModifySelection): Ditto.
(WebCore::executeMoveDown): Ditto.
(WebCore::executeMoveDownAndModifySelection): Ditto.
(WebCore::executeMoveForward): Ditto.
(WebCore::executeMoveForwardAndModifySelection): Ditto.
(WebCore::executeMoveLeft): Ditto.
(WebCore::executeMoveLeftAndModifySelection): Ditto.
(WebCore::executeMovePageDown): Ditto.
(WebCore::executeMovePageDownAndModifySelection): Ditto.
(WebCore::executeMovePageUp): Ditto.
(WebCore::executeMovePageUpAndModifySelection): Ditto.
(WebCore::executeMoveRight): Ditto.
(WebCore::executeMoveRightAndModifySelection): Ditto.
(WebCore::executeMoveToBeginningOfDocument): Ditto.
(WebCore::executeMoveToBeginningOfDocumentAndModifySelection): Ditto.
(WebCore::executeMoveToBeginningOfLine): Ditto.
(WebCore::executeMoveToBeginningOfLineAndModifySelection): Ditto.
(WebCore::executeMoveToBeginningOfParagraph): Ditto.
(WebCore::executeMoveToBeginningOfParagraphAndModifySelection): Ditto.
(WebCore::executeMoveToBeginningOfSentence): Ditto.
(WebCore::executeMoveToBeginningOfSentenceAndModifySelection): Ditto.
(WebCore::executeMoveToEndOfDocument): Ditto.
(WebCore::executeMoveToEndOfDocumentAndModifySelection): Ditto.
(WebCore::executeMoveToEndOfSentence): Ditto.
(WebCore::executeMoveToEndOfSentenceAndModifySelection): Ditto.
(WebCore::executeMoveToEndOfLine): Ditto.
(WebCore::executeMoveToEndOfLineAndModifySelection): Ditto.
(WebCore::executeMoveToEndOfParagraph): Ditto.
(WebCore::executeMoveToEndOfParagraphAndModifySelection): Ditto.
(WebCore::executeMoveParagraphBackwardAndModifySelection): Ditto.
(WebCore::executeMoveParagraphForwardAndModifySelection): Ditto.
(WebCore::executeMoveUp): Ditto.
(WebCore::executeMoveUpAndModifySelection): Ditto.
(WebCore::executeMoveWordBackward): Ditto.
(WebCore::executeMoveWordBackwardAndModifySelection): Ditto.
(WebCore::executeMoveWordForward): Ditto.
(WebCore::executeMoveWordForwardAndModifySelection): Ditto.
(WebCore::executeMoveWordLeft): Ditto.
(WebCore::executeMoveWordLeftAndModifySelection): Ditto.
(WebCore::executeMoveWordRight): Ditto.
(WebCore::executeMoveWordRightAndModifySelection): Ditto.
(WebCore::executeMoveToLeftEndOfLine): Ditto.
(WebCore::executeMoveToLeftEndOfLineAndModifySelection): Ditto.
(WebCore::executeMoveToRightEndOfLine): Ditto.
(WebCore::executeMoveToRightEndOfLineAndModifySelection): Ditto.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::moveTo): Takes EUserTriggered instead of a boolean.
(WebCore::FrameSelection::setSelection): Ditto.
(WebCore::FrameSelection::modify): Ditto.
(WebCore::FrameSelection::setStart): Ditto.
(WebCore::FrameSelection::setEnd): Ditto.
(WebCore::FrameSelection::setBase): Ditto.
(WebCore::FrameSelection::setExtent): Ditto.
(WebCore::FrameSelection::selectAll): Ditto.
(WebCore::FrameSelection::notifyRendererOfSelectionChange): Ditto.
* editing/FrameSelection.h: Extracted EUserTriggered out of SetSelectionOption; SetSelectionOptions
now takes the union of values of SetSelectionOption and EUserTriggered.
(WebCore::FrameSelection::selectionOptionsToUserTriggered): Converts SetSelectionOptions to
EUserTriggered.
* page/DOMSelection.cpp:
(WebCore::DOMSelection::modify): Calls FrameSelection::modify.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent): Ditto.
(WebCore::handleKeyboardSelectionMovement): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc