WebKit-https.git
10 years ago2011-02-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 1 Mar 2011 07:06:12 +0000 (07:06 +0000)]
2011-02-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Teach JavaScriptGlue gyp build about DEPTH
        https://bugs.webkit.org/show_bug.cgi?id=55421

        Moves the previously JavaScriptGlue-specific GYP helper shell scripts
        to the gyp directory in Source, where they can be shared by multiple
        frameworks.

        * Source/gyp: Added.
        * Source/gyp/remove-headers-if-needed.sh: Copied from Source/JavaScriptGlue/gyp/remove-headers-if-needed.sh.
        * Source/gyp/run-if-exists.sh: Copied from Source/JavaScriptGlue/gyp/run-if-exists.sh.
        * Source/gyp/update-info-plist.sh: Copied from Source/JavaScriptGlue/gyp/update-info-plist.sh.
2011-02-28  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig & Darin Adler.

        Bug 55423 - Clean up property tables in Structure

        Encapsulate, reduce duplication of table search code,
        and reduce the size of the tables (remove the index,
        just maintain the tables in the correct order).

        Shows a 0.5% - 1% progression on sunspider.

        * ForwardingHeaders/wtf/HashTable.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 1 Mar 2011 06:26:00 +0000 (06:26 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: chromium rebuilds XMLViewer after noop. Fixed gyp file.

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
barraclough@apple.com [Tue, 1 Mar 2011 05:26:39 +0000 (05:26 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 1 Mar 2011 05:12:37 +0000 (05:12 +0000)]
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79948.
        http://trac.webkit.org/changeset/79948
        https://bugs.webkit.org/show_bug.cgi?id=55439

        "caused crashes on the SL release bot" (Requested by ggaren on
        #webkit).

        * runtime/JSGlobalData.h:
        * runtime/WriteBarrier.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=54898
alice.liu@apple.com [Tue, 1 Mar 2011 04:40:31 +0000 (04:40 +0000)]
Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=54898
InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle

Reviewed by Adam Roben and Gavin Barraclough.

* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultCopyNodeHandle):
Instead of .get(), call .release.leakRef() like other functions that return WKBundleNodeHandleRef.
* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
Renamed from "get" to "copy", because it leaksRef.

Tools: Test for https://bugs.webkit.org/show_bug.cgi?id=54898
InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.

Reviewed by Adam Roben and Gavin Barraclough.

* TestWebKitAPI/InjectedBundleController.h:
(TestWebKitAPI::InjectedBundleController::bundle):
* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
(TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
(TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
(TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::simulateRightClick):
* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::simulateRightClick):

Added files to:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=55442
alice.liu@apple.com [Tue, 1 Mar 2011 04:27:25 +0000 (04:27 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55442
Webarchives don't contain subframe content

Reviewed by Gavin Barraclough.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getWebArchiveOfFrame):
Pass the frame's document instead of just the frame, to use a different LegacyWebArchive::create function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
barraclough@apple.com [Tue, 1 Mar 2011 03:59:00 +0000 (03:59 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 55423 - Clean up property tables in Structure
barraclough@apple.com [Tue, 1 Mar 2011 03:53:09 +0000 (03:53 +0000)]
Bug 55423 - Clean up property tables in Structure

Reviewed by Sam Weinig & Darin Adler.

Encapsulate, reduce duplication of table search code,
and reduce the size of the tables (remove the index,
just maintain the tables in the correct order).

Shows a 0.5% - 1% progression on sunspider.

../JavaScriptCore:

* JavaScriptCore.exp:
* runtime/PropertyMapHashTable.h:
(JSC::isPowerOf2):
(JSC::nextPowerOf2):
    bit ops used to calculate table size.
(JSC::PropertyMapEntry::PropertyMapEntry):
(JSC::PropertyTable::ordered_iterator::operator++):
(JSC::PropertyTable::ordered_iterator::operator==):
(JSC::PropertyTable::ordered_iterator::operator!=):
(JSC::PropertyTable::ordered_iterator::operator*):
(JSC::PropertyTable::ordered_iterator::operator->):
(JSC::PropertyTable::ordered_iterator::ordered_iterator):
    implementation of the iterator types
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::~PropertyTable):
    constructors take an initial capacity for the table,
    a table to copy, or both.
(JSC::PropertyTable::begin):
(JSC::PropertyTable::end):
    create in-order iterators.
(JSC::PropertyTable::find):
    search the hash table
(JSC::PropertyTable::add):
    add a value to the hash table
(JSC::PropertyTable::remove):
    remove a value from the hash table
(JSC::PropertyTable::size):
(JSC::PropertyTable::isEmpty):
    accessors.
(JSC::PropertyTable::propertyStorageSize):
(JSC::PropertyTable::clearDeletedOffsets):
(JSC::PropertyTable::hasDeletedOffset):
(JSC::PropertyTable::getDeletedOffset):
(JSC::PropertyTable::addDeletedOffset):
    cache deleted (available) offsets in the property storage array.
(JSC::PropertyTable::copy):
    take a copy of the PropertyTable, potentially expanding the capacity.
(JSC::PropertyTable::sizeInMemory):
    used for DEBUG build statistics
(JSC::PropertyTable::reinsert):
(JSC::PropertyTable::rehash):
(JSC::PropertyTable::tableCapacity):
(JSC::PropertyTable::deletedEntryIndex):
(JSC::PropertyTable::skipDeletedEntries):
(JSC::PropertyTable::table):
(JSC::PropertyTable::usedCount):
(JSC::PropertyTable::dataSize):
(JSC::PropertyTable::sizeForCapacity):
(JSC::PropertyTable::canInsert):
    these methods provide internal implementation.
* runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::~Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::put):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNames):
(JSC::PropertyTable::checkConsistency):
(JSC::Structure::checkConsistency):
    factored out code to PropertyMapHashTable.h
* runtime/Structure.h:
(JSC::Structure::propertyStorageSize):
(JSC::Structure::isEmpty):
(JSC::Structure::get):
    factored out code to PropertyMapHashTable.h

../JavaScriptGlue:

* ForwardingHeaders/wtf/HashTable.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 1 Mar 2011 03:42:13 +0000 (03:42 +0000)]
2011-02-28  James Robinson  <jamesr@chromium.org>

        Chromium baseline updates.

        * platform/chromium-linux/svg/text/font-size-below-point-five-expected.txt:
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 1 Mar 2011 03:21:25 +0000 (03:21 +0000)]
2011-02-28  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations change.

        Rebaseline editing/ tests for Snow Leopard (mac/ baselines can't be used
        due to spell checking differences).

        * platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-002-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-002-expected.png: Added.
        * platform/chromium-mac-leopard/editing/inserting/typing-around-br-001-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/inserting/typing-around-br-001-expected.png: Added.
        * platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/4932260-3-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/selection/4932260-3-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/5234383-1-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/selection/5234383-1-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/5234383-2-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/selection/5234383-2-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/drag-in-iframe-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/selection/drag-in-iframe-expected.png: Added.
        * platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png: Added.
        * platform/chromium-mac/editing/inserting/typing-around-br-001-expected.checksum: Added.
        * platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png: Added.
        * platform/chromium-mac/editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-blockquote-3-expected.png: Added.
        * platform/chromium-mac/editing/selection/4932260-3-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/4932260-3-expected.png: Added.
        * platform/chromium-mac/editing/selection/5234383-1-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/5234383-1-expected.png: Added.
        * platform/chromium-mac/editing/selection/5234383-2-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/5234383-2-expected.png: Added.
        * platform/chromium-mac/editing/selection/drag-in-iframe-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/drag-in-iframe-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 1 Mar 2011 02:34:02 +0000 (02:34 +0000)]
2011-02-28  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations change.

        Update Snow Leopard expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 1 Mar 2011 02:30:36 +0000 (02:30 +0000)]
2011-02-28  Xan Lopez  <xlopez@igalia.com>

        Another fix build :(

        Fix typo.

        * runtime/MachineStackMarker.cpp:
        (JSC::freePlatformThreadRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 1 Mar 2011 02:26:19 +0000 (02:26 +0000)]
2011-02-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed build fix for Snow Leopard.

        * runtime/MachineStackMarker.cpp:
        (JSC::freePlatformThreadRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Tue, 1 Mar 2011 02:20:33 +0000 (02:20 +0000)]
2011-02-28  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, fix SnowLeopard compilation after r79952.

        * runtime/MachineStackMarker.cpp:
        (JSC::freePlatformThreadRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoKURL should expose a referrer property.
levin@chromium.org [Tue, 1 Mar 2011 02:10:28 +0000 (02:10 +0000)]
KURL should expose a referrer property.
https://bugs.webkit.org/show_bug.cgi?id=55415

Reviewed by Darin Adler.

No change in functionality so no new tests.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setOutgoingReferrer): Refactor to put the majority
of functionality in KURL::strippedForUseAsReferrer() so that this code can
be more easily reused.
* platform/KURL.cpp:
(WebCore::KURL::strippedForUseAsReferrer): Converts the url to a string
which is suitable for use as a referrer.
* platform/KURL.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/55430> OwnArrayPtr.h's LOOSE_OWN_ARRAY_PTR results in link errors.
mrowe@apple.com [Tue, 1 Mar 2011 01:55:24 +0000 (01:55 +0000)]
<webkit.org/b/55430> OwnArrayPtr.h's LOOSE_OWN_ARRAY_PTR results in link errors.

Reviewed by Darin Adler.

* wtf/OwnArrayPtr.h:
(WTF::::set): Implement OwnArrayPtr::set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNumber type input cannot be set to empty string if it has an initial value
tkent@chromium.org [Tue, 1 Mar 2011 01:51:45 +0000 (01:51 +0000)]
Number type input cannot be set to empty string if it has an initial value
https://bugs.webkit.org/show_bug.cgi?id=53744

Reviewed by Darin Adler.

Source/WebCore:

We need to distinguish null strings and empty strings for
InputElementData::value. So InputType::sanitizeValue() also needs to
take care of it.

* dom/InputElement.h: Add a comment to InputElementData::value and
  setValue about null strings.
* html/InputType.h: Add a comment to sanitizeValue about null strings.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::sanitizeValue): Returns a null string if the
  proposed value is a null string. Returning an empty string if the
  proposed value is not a number.

LayoutTests:

* fast/forms/input-value-sanitization-expected.txt:
* fast/forms/script-tests/input-value-sanitization.js: Add some tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Tue, 1 Mar 2011 01:47:06 +0000 (01:47 +0000)]
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Updated expected results after the change that syncs the WebKit isEditable
        and WebCore isContentEditable.

        * platform/mac/editing/selection/designmode-no-caret-expected.txt:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Frame::isContentEditable is currently based on two things: Editor::clientIsEditable and
        Document::inDesignMode. In fact, it should only rely on Document::inDesignMode. As a result,
        Editor::clientIsEditable and its client-side implementation can be removed.

        * WebCore.exp.in:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isReadOnly):
        * editing/Editor.cpp:
        * editing/Editor.h:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelectionFromNone):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::isContentEditable):
        (WebCore::HTMLElement::isContentRichlyEditable):
        * page/DragController.cpp:
        (WebCore::DragController::operationForLoad):
        * page/EditorClient.h:
        * page/Frame.cpp:
        * page/Frame.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation.

        * src/EditorClientImpl.cpp:
        * src/EditorClientImpl.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation.

        * WebCoreSupport/EditorClientEfl.cpp:
        * WebCoreSupport/EditorClientEfl.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.

        * WebCoreSupport/EditorClientGtk.cpp:
        * WebCoreSupport/EditorClientGtk.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_init):
        (webkit_web_view_get_editable):
        (webkit_web_view_set_editable):
        * webkit/webkitwebviewprivate.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation.

        * WebCoreSupport/EditorClientHaiku.cpp:
        * WebCoreSupport/EditorClientHaiku.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        * WebView/WebView.mm:
        (-[WebView setEditable:]):
        (-[WebView isEditable]):
        * WebView/WebViewData.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        (QWebPage::setContentEditable):
        (QWebPage::isContentEditable):
        * Api/qwebpage_p.h:
        * WebCoreSupport/EditorClientQt.cpp:
        * WebCoreSupport/EditorClientQt.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation.

        * WebCoreSupport/WebEditorClient.cpp:
        * WebCoreSupport/WebEditorClient.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation.

        * WebCoreSupport/EditorClientWinCE.cpp:
        * WebCoreSupport/EditorClientWinCE.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.

        * WebFrame.cpp:
        (wxWebFrame::wxWebFrame):
        (wxWebFrame::MakeEditable):
        (wxWebFrame::IsEditable):
        * WebFrame.h:
        * WebKitSupport/EditorClientWx.cpp:
        * WebKitSupport/EditorClientWx.h:
        * WebView.cpp:
        (wxWebView::wxWebView):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Martin Zoubek <martin.zoubek@acision.com> and Alejandro G. Castro ...
alex@webkit.org [Tue, 1 Mar 2011 01:45:01 +0000 (01:45 +0000)]
2011-02-28  Martin Zoubek  <martin.zoubek@acision.com> and Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        Multithread support for JSC on UNIX
        https://bugs.webkit.org/show_bug.cgi?id=26838

        Implement suspendThread() and resumeThread() for systems with
        pthread.h using thread signal handler.

        * runtime/MachineStackMarker.cpp:
        (JSC::pthreadSignalHandlerSuspendResume):
        (JSC::MachineStackMarker::Thread::Thread):
        (JSC::getCurrentPlatformThread):
        (JSC::suspendThread):
        (JSC::resumeThread):
        (JSC::getPlatformThreadRegisters):
        (JSC::otherThreadStackPointer):
        (JSC::freePlatformThreadRegisters):
        (JSC::MachineStackMarker::markOtherThreadConservatively):
        * wtf/Platform.h: Added Gtk port to use
        ENABLE_JSC_MULTIPLE_THREADS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNumber type input should not handle mouse wheel events if it has no focus.
tkent@chromium.org [Tue, 1 Mar 2011 01:40:22 +0000 (01:40 +0000)]
Number type input should not handle mouse wheel events if it has no focus.
https://bugs.webkit.org/show_bug.cgi?id=53638

Reviewed by Darin Adler.

Source/WebCore:

* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleWheelEventForSpinButton): Check focused().

LayoutTests:

Add a test case.

* fast/forms/input-number-wheel-expected.txt:
* fast/forms/script-tests/input-number-wheel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Tue, 1 Mar 2011 01:33:49 +0000 (01:33 +0000)]
2011-02-28  Noel Gordon  <noel.gordon@gmail.com>
        Reviewed by James Robinson.

        [chromium] GradientSkia: use the common Gradient stop sorting methods.
        https://bugs.webkit.org/show_bug.cgi?id=54625

        Remove a FIXME: call the Gradient.cpp stop storting routines, no need
        to duplicate that code herein.

        No change in behavior, so no new tests.

        * platform/graphics/skia/GradientSkia.cpp:
        (WebCore::Gradient::platformGradient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 1 Mar 2011 01:31:35 +0000 (01:31 +0000)]
2011-02-28  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Adler.

        Fix race condition in 4 media tests
        https://bugs.webkit.org/show_bug.cgi?id=55414

        The parser may yield and give events a chance to dispatch between any two tokens. So
        it is possible that the loadstart event fires immediately after the video tag is
        inserted into the document but before the subsequent script is parsed. This is very
        rare in the layout test environment since these small files are loaded from disk.

        This patch eliminates that race condition by allowing waitForEvent to register for
        events that bubble up to the document from any element. Then the registration can
        happen before before the element is inserted into the document.

        * media/video-source-media.html:
        * media/video-source-none-supported.html:
        * media/video-source-type-params.html:
        * media/video-source-type.html:
        * media/video-test.js:
        (waitForEvent):
        (waitForEventAndTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 1 Mar 2011 01:06:21 +0000 (01:06 +0000)]
2011-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        Stop using DeprecatedPtr for the global exception slot
        https://bugs.webkit.org/show_bug.cgi?id=55424

        Create GCRootPtr to signify that the exception slot is
        a gcroot, and so is exempt from the usual writebarrier
        restrictions.

        * runtime/JSGlobalData.h:
        * runtime/WriteBarrier.h:
        (JSC::GCRootPtr::GCRootPtr):
        (JSC::GCRootPtr::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 1 Mar 2011 01:02:30 +0000 (01:02 +0000)]
2011-02-28  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        JNI code should include <jni.h> on non-OSX platforms.
        https://bugs.webkit.org/show_bug.cgi?id=55219

        On Mac we need to include <JavaVM/jni.h> as this is a framework
        include. We include jni.h through JNIUtility.h to minimize the
        number of ifdefs.

        No new tests, build fix only.

        * WebCore.xcodeproj/project.pbxproj
        * bridge/jni/JNIUtility.h:
        * bridge/jni/jni_jsobject.h:
        * bridge/jni/jsc/JNIBridgeJSC.h:
        * bridge/jni/jsc/JavaInstanceJSC.h:
        * bridge/jni/v8/JavaInstanceV8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Nebojsa Sabovic <neb@chromium.org>
jamesr@google.com [Tue, 1 Mar 2011 00:59:56 +0000 (00:59 +0000)]
2011-02-28  Nebojsa Sabovic  <neb@chromium.org>

        Reviewed by James Robinson.

        [chromium] Pepper plugins render upside down
        https://bugs.webkit.org/show_bug.cgi?id=55101

        No layout tests for pepper plugins (yet).

        * platform/graphics/chromium/PluginLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Tue, 1 Mar 2011 00:57:09 +0000 (00:57 +0000)]
2011-02-28  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Add a way to test the WebKit 2 APIs
        https://bugs.webkit.org/show_bug.cgi?id=55408

        Add the build file for test to the build system.

        * Source/WebKit.pri: Add the include path for WebKit 2 APIs.
        * Source/WebKit.pro: Add the dependency to build the new test project.
2011-02-28  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Add a way to test the WebKit 2 APIs
        https://bugs.webkit.org/show_bug.cgi?id=55408

        Add an initial test for the WebKit 2 APIs of Qt.

        * UIProcess/API/qt/tests/html/basic_page.html: Added.
        * UIProcess/API/qt/tests/qgraphicswkview/qgraphicswkview.pro: Added.
        * UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: Added.
        (View::View):
        (View::resizeEvent):
        (tst_QGraphicsWKView::init):
        (tst_QGraphicsWKView::cleanup):
        (tst_QGraphicsWKView::loadEmptyPage):
        * UIProcess/API/qt/tests/tests.pri: Added.
        * UIProcess/API/qt/tests/tests.pro: Added.
        * UIProcess/API/qt/tests/util.h: Added.
        (waitForSignal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 1 Mar 2011 00:54:55 +0000 (00:54 +0000)]
2011-02-28  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Follow HTML5 spec for document.open() a little more closely
        https://bugs.webkit.org/show_bug.cgi?id=55392

        * fast/parser/double-write-from-closed-iframe-expected.txt: Added.
        * fast/parser/double-write-from-closed-iframe.html: Added. Prior to this patch, the second write of 'PASS' could fail indeterminately.
        * fast/parser/script-tests/double-write-from-closed-iframe.js: Added.
        * fast/regex/script-tests/cross-frame-callable.js: Necessary to close late writes.
2011-02-28  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Follow HTML5 spec for document.open() a little more closely
        https://bugs.webkit.org/show_bug.cgi?id=55392

        See: 3.5.1.4 at http://www.whatwg.org/specs/web-apps/current-work/#dom-document-open.

        The second return check matches the spec. The first return check (isExecutingScript())
        was left in place because without it, fast/tokenizer/write-external-script-open.html
        would fail. It also possible there is a spec bug because FF4 crashes on that test and
        IE9 prints "FAILURE." The isLoadingMainResource() check was removed because the main
        resource is always loading while parser->isParsing().

        Test: fast/parser/double-write-from-closed-iframe.html

        * dom/Document.cpp:
        (WebCore::Document::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix clang build.
andersca@apple.com [Tue, 1 Mar 2011 00:54:06 +0000 (00:54 +0000)]
Fix clang build.

* UIProcess/API/mac/FindIndicatorWindow.mm:
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::deprecatedUpdate):
(WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveMessage):
* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::deprecatedResumePainting):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Avi Drissman <avi@google.com>
commit-queue@webkit.org [Tue, 1 Mar 2011 00:51:45 +0000 (00:51 +0000)]
2011-02-28  Avi Drissman  <avi@google.com>

        Reviewed by James Robinson.

        WebCursorInfo needs to match enums in platform/Cursor.h
        https://bugs.webkit.org/show_bug.cgi?id=55094

        * platform/chromium/CursorChromium.cpp:
        (WebCore::grabCursor):
        (WebCore::grabbingCursor):
        * platform/chromium/PlatformCursor.h:
2011-02-28  Avi Drissman  <avi@google.com>

        Reviewed by James Robinson.

        WebCursorInfo needs to match enums in platform/Cursor.h
        https://bugs.webkit.org/show_bug.cgi?id=55094

        * public/WebCursorInfo.h:
        * src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 1 Mar 2011 00:49:44 +0000 (00:49 +0000)]
2011-02-28  James Robinson  <jamesr@chromium.org>

        Update chromium expectations and baselines.

        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/001-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/001-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/002-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/002-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/003-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/003-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/004-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/004-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/005-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/005-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/006-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/006-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/001-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/002-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/002-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/003-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/003-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/004-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/004-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/005-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/005-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/006-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/006-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
        * platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
        * platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/005-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/005-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/005-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/006-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/006-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/006-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/005-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/005-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/005-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/006-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/006-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/006-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.txt: Added.
        * platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
        * platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
        * platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDo not copy config.h into WebKit2.
mitz@apple.com [Tue, 1 Mar 2011 00:02:45 +0000 (00:02 +0000)]
Do not copy config.h into WebKit2.

Rubber-stamped by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLLVM Compiler build fix.
mitz@apple.com [Mon, 28 Feb 2011 23:59:14 +0000 (23:59 +0000)]
LLVM Compiler build fix.

* Scripts/webkit2/messages.py:
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStart running InjectedBundle API tests on Windows
aroben@apple.com [Mon, 28 Feb 2011 23:59:04 +0000 (23:59 +0000)]
Start running InjectedBundle API tests on Windows

A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.

Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows

Reviewed by Darin Adler.

Source/WebKit/win:

Build TestWebKitAPIInjectedBundle on Windows

* WebKit.vcproj/WebKit.sln: Added TestWebKitAPIInjectedBundle. Let VS simplify the paths to
the project files.

Tools:

* TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
* TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
* TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
* TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
* TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
These are just extracted from TestWebKitAPI.vcproj.

* TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
up the DLL's filename.

* TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
(TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.

* TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
"all" configuration.

* TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
injected bundle tests. Let VS resort things.

* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 28 Feb 2011 23:55:34 +0000 (23:55 +0000)]
2011-02-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein, Sam Weinig, Alexey Proskuryakov and Darin Adler.

        Open PDF in Preview doesn't work
        https://bugs.webkit.org/show_bug.cgi?id=55400
        <rdar://problem/8750353>

        * UIProcess/API/mac/PDFViewController.mm:
        (-[WKPDFView initWithFrame:PDFViewController:]):
        Set the WKPDFView as the delegate of itself.

        (-[WKPDFView PDFViewOpenPDFInNativeApplication:]):
        Call PDFViewController::openPDFInFinder.

        (WebKit::PDFViewController::PDFViewController):
        Initialize m_hasWrittenPDFToDisk to false.

        (WebKit::PDFViewController::openPDFInFinder):
        Write the PDF to disk if needed and then open it using -[NSWorkspace openFile:].

        (WebKit::temporaryPDFDirectoryPath):
        Create a directory to put PDFs in.

        (WebKit::PDFViewController::pathToPDFOnDisk):
        Return a path to a (non-existent) file in the temporary PDF directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Mon, 28 Feb 2011 23:50:27 +0000 (23:50 +0000)]
2011-02-28  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        [Mac] Make "Change back to …" contextual menu item work with new autocorrection.
        https://bugs.webkit.org/show_bug.cgi?id=55396
        <rdar://problem/8836093>

        The change in InlineTextBox.cpp fixes a bug, where the rectangle of Replacement marker isn't
        calculated. We need this to do hit test when deciding whether to show "Change back to ..." on
        contextual menu.

        The change in Editor.cpp is for notifying spellchecker about the reversion whenever "Change
        back to ..." is clicked.

        * editing/Editor.cpp:
        (WebCore::Editor::changeBackToReplacedString):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintDocumentMarkers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Victoria Kirst <vrk@google.com>
commit-queue@webkit.org [Mon, 28 Feb 2011 23:35:54 +0000 (23:35 +0000)]
2011-02-28  Victoria Kirst  <vrk@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in VideoLayerChromium
        https://bugs.webkit.org/show_bug.cgi?id=55269

        Mesa does not support mapTexSubImage2D, so this change lets
        GPU-accelerated video work with DRT layout tests.

        * platform/graphics/chromium/VideoLayerChromium.cpp:
        (WebCore::VideoLayerChromium::updateTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 23:33:28 +0000 (23:33 +0000)]
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Antonio Gomes.

        REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
        https://bugs.webkit.org/show_bug.cgi?id=55323

        Added test case that draws focus rings on selected items when spatial navigation is enabled.

        * fast/spatial-navigation/snav-multiple-select-focusring.html: Added.
        * platform/mac/fast/spatial-navigation: Added.
        * platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.checksum: Added.
        * platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.
        * platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with...
hyatt@apple.com [Mon, 28 Feb 2011 23:21:36 +0000 (23:21 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.  Change staticX and staticY
to be staticInlinePosition and staticBlockPosition.  Patch all of the computations involving these variables to be writing
mode aware.  Mixed writing modes are not yet supported.

Reviewed by Dan Bernstein.

Added new tests in fast/block/positioning/auto.

Source/WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::layoutPositionedObjects):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::startOffsetForLine):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendRunsForObject):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderAndPaddingLogicalLeft):
(WebCore::RenderBoxModelObject::borderAndPaddingStart):
(WebCore::RenderBoxModelObject::borderLogicalLeft):
(WebCore::RenderBoxModelObject::borderLogicalRight):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::relativePositionedInlineOffset):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::staticInlinePosition):
(WebCore::RenderLayer::staticBlockPosition):
(WebCore::RenderLayer::setStaticInlinePosition):
(WebCore::RenderLayer::setStaticBlockPosition):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasAutoLeftAndRight):
(WebCore::InheritedFlags::hasAutoTopAndBottom):
(WebCore::InheritedFlags::hasStaticInlinePosition):
(WebCore::InheritedFlags::hasStaticBlockPosition):

LayoutTests:

* fast/block/positioning/auto/vertical-lr: Added.
* fast/block/positioning/auto/vertical-lr/001.html: Added.
* fast/block/positioning/auto/vertical-lr/002.html: Added.
* fast/block/positioning/auto/vertical-lr/003.html: Added.
* fast/block/positioning/auto/vertical-lr/004.html: Added.
* fast/block/positioning/auto/vertical-lr/005.html: Added.
* fast/block/positioning/auto/vertical-lr/006.html: Added.
* fast/block/positioning/auto/vertical-lr/007.html: Added.
* fast/block/positioning/auto/vertical-rl: Added.
* fast/block/positioning/auto/vertical-rl/001.html: Added.
* fast/block/positioning/auto/vertical-rl/002.html: Added.
* fast/block/positioning/auto/vertical-rl/003.html: Added.
* fast/block/positioning/auto/vertical-rl/004.html: Added.
* fast/block/positioning/auto/vertical-rl/005.html: Added.
* fast/block/positioning/auto/vertical-rl/006.html: Added.
* fast/block/positioning/auto/vertical-rl/007.html: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/001-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/001-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/001-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/002-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/002-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/002-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/003-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/003-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/003-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/004-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/004-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/004-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/001-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/001-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/002-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/002-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/002-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/003-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/003-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/003-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/004-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/004-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/004-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Dan Bernstein.
ap@apple.com [Mon, 28 Feb 2011 23:05:48 +0000 (23:05 +0000)]
    Reviewed by Dan Bernstein.

        Frequent crashes in CFURLCache code on Snow Leopard
        https://bugs.webkit.org/show_bug.cgi?id=55412
        <rdar://problem/9063922>

        CString is evil, it has two lengths which can be different - specifically, fileSystemRepresentation()
        creates a string with maximum possible buffer size. A path with garbage at the end confused
        CFURLCache into corrupting its data structures.

        * Shared/WebProcessCreationParameters.h: Added a FIXME about merging Mac and Windows code.
        This problem wouldn't have occured if we didn't use CString in the first place.

        * UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess):
        Added an assertion matching Windows behavior (seems likely that NSURLCache also wouldn't
        have liked trailing slash).

        * UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess):
        Made slash removal conditional for robustness.

        * WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess):
        Use actual string length, not CString::length().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Mon, 28 Feb 2011 22:48:29 +0000 (22:48 +0000)]
2011-02-28  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Anders Carlsson.

        [Qt][WK2] Plugin initialization
        https://bugs.webkit.org/show_bug.cgi?id=48127

        * Source/WebKit.pri: Lift the definition of the XP_UNIX macro
        from WebCore.pri to WebKit.pri to apply it to WebKit2 as well.
2011-02-28  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Anders Carlsson.

        [Qt][WK2] Plugin initialization
        https://bugs.webkit.org/show_bug.cgi?id=48127

        No function change so no new tests.

        * WebCore.pri: Lift the definition of the XP_UNIX macro
        from WebCore.pri to WebKit.pri to apply it to WebKit2 as well.
2011-02-28  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Anders Carlsson.

        [Qt][WK2] Plugin initialization
        https://bugs.webkit.org/show_bug.cgi?id=48127

        Specialize the way of initializing the plugin for X11.
        Introduce PLUGIN_ARCHITECTURE macros to allow code sharing
        across platforms.

        * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
        (WebKit::NetscapePluginModule::tryLoad):
        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 28 Feb 2011 22:40:30 +0000 (22:40 +0000)]
2011-02-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Use more xcconfig files in JavaScriptCore gyp build
        https://bugs.webkit.org/show_bug.cgi?id=55391

        The GYP experts tell me that we have have a total of two xcconfig
        files: one for the xcodeproj as a whole and one for each target.  This
        patch uses that technique to re-use the existing xcconfig files and
        eliminate the duplication.

        Technically, this patch introduces some build errors because the
        xcconfig files assume that the xcodeproj file is one level higher in
        the directory hierarchy.  Specifically, the xcodeproj file can no
        longer find the Info.plist or the prefix header.  I plan to fix that in
        a subsequent patch.

        Also, this patch introduces the Release and Production configurations,
        which should work correctly now.

        * gyp/JavaScriptCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Dean Jackson <dino@apple.com>
dino@apple.com [Mon, 28 Feb 2011 22:32:38 +0000 (22:32 +0000)]
2011-02-28  Dean Jackson  <dino@apple.com>

        Reviewed by Eric Carlson.

        https://bugs.webkit.org/show_bug.cgi?id=55239

        Allow webkitEnterFullScreen to be called from outside
        a user gesture, but only when the correct restrictions
        have been lifted in WebCore. Add a new restriction type
        for this situation. Meanwhile, expose the current
        restrictions externally from HTMLMediaElement, so that
        clients can easily set restrictions on their port.

        No new tests. This doesn't change existing behavior. Some
        WebKit clients may lift the restriction.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement):
        - ensure restrictions initialize with fullscreen restricted
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::requireUserGestureForLoad):
        (WebCore::HTMLMediaElement::requireUserGestureForRateChange):
        (WebCore::HTMLMediaElement::requireUserGestureForFullScreen):
        (WebCore::HTMLMediaElement::setBehaviorRestrictions):
        - new methods to expose the current restrictions
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::webkitEnterFullscreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Jungshik Shin <jshin@chromium.org>
jshin@chromium.org [Mon, 28 Feb 2011 22:18:37 +0000 (22:18 +0000)]
2011-02-28  Jungshik Shin  <jshin@chromium.org>

        https://bugs.webkit.org/show_bug.cgi?id=55121

        [chromium] Unreviewed change of test_expectations.txt
        With the platform-specific expectation file landed in r79912,
        fast/xsl/sort-locale-expected.txt should pass now on chromium.
        So, remove it from the failure list.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
inferno@chromium.org [Mon, 28 Feb 2011 22:14:21 +0000 (22:14 +0000)]
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78789.
        http://trac.webkit.org/changeset/78789
        https://bugs.webkit.org/show_bug.cgi?id=55409

        Incorrect canvas fallback implementation (Requested by
        inferno-sec on #webkit).

        * public/WebAccessibilityRole.h:
        * src/AssertMatchingEnums.cpp:
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78789.
        http://trac.webkit.org/changeset/78789
        https://bugs.webkit.org/show_bug.cgi?id=55409

        Incorrect canvas fallback implementation (Requested by
        inferno-sec on #webkit).

        * AccessibleBase.cpp:
        (MSAARole):
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78789.
        http://trac.webkit.org/changeset/78789
        https://bugs.webkit.org/show_bug.cgi?id=55409

        Incorrect canvas fallback implementation (Requested by
        inferno-sec on #webkit).

        * accessibility/AccessibilityObject.h:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
        (WebCore::AccessibilityRenderObject::canHaveChildren):
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkRole):
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::isFocusable):
        * rendering/RenderHTMLCanvas.cpp:
        * rendering/RenderHTMLCanvas.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaint):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78789.
        http://trac.webkit.org/changeset/78789
        https://bugs.webkit.org/show_bug.cgi?id=55409

        Incorrect canvas fallback implementation (Requested by
        inferno-sec on #webkit).

        * accessibility/canvas-fallback-content-expected.txt: Removed.
        * accessibility/canvas-fallback-content.html: Removed.
        * accessibility/canvas.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
inferno@chromium.org [Mon, 28 Feb 2011 22:09:45 +0000 (22:09 +0000)]
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79425.
        http://trac.webkit.org/changeset/79425
        https://bugs.webkit.org/show_bug.cgi?id=55406

        Incorrect canvas fallback implementation. (Requested by
        inferno-sec on #webkit).

        * canvas/canvas-mouse-events-expected.txt: Removed.
        * canvas/canvas-mouse-events.html: Removed.
        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
        * platform/win-wk2/Skipped:
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79425.
        http://trac.webkit.org/changeset/79425
        https://bugs.webkit.org/show_bug.cgi?id=55406

        Incorrect canvas fallback implementation. (Requested by
        inferno-sec on #webkit).

        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
jhoneycutt@apple.com [Mon, 28 Feb 2011 22:00:58 +0000 (22:00 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Add symbol to export.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 21:55:18 +0000 (21:55 +0000)]
2011-02-28  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        [fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
        https://bugs.webkit.org/show_bug.cgi?id=54774

        Tests for resolveLocalFileSystemURI.

        * fast/filesystem/resolve-uri-expected.txt: Added.
        * fast/filesystem/resolve-uri.html: Added.
        * fast/filesystem/script-tests/resolve-uri.js: Added.
2011-02-28  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        [fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
        https://bugs.webkit.org/show_bug.cgi?id=54774

        See http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods
        for the spec implemented by this patch.

        Test: fast/filesystem/resolve-uri.html

        * fileapi/DOMFileSystemBase.cpp:
        (WebCore::DOMFileSystemBase::crackFileSystemURL):
        * fileapi/DOMFileSystemBase.h:
        Added constants for "temporary" and "persistent".
        * fileapi/EntryBase.cpp:
        Replace hardcoded strings with aforementioned constants.
        * fileapi/FileSystemCallbacks.cpp:
        (WebCore::ResolveURICallbacks::create):
        (WebCore::ResolveURICallbacks::ResolveURICallbacks):
        (WebCore::ResolveURICallbacks::didOpenFileSystem):
        Chains a call of openFileSystem to calls to getDirectory/getFile.
        * fileapi/FileSystemCallbacks.h:
        * fileapi/LocalFileSystem.cpp:
        (WebCore::LocalFileSystem::readFileSystem):
        * fileapi/LocalFileSystem.h:
        Remove size argument from readFileSystem()
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::resolveLocalFileSystemURI):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
2011-02-28  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        [fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
        https://bugs.webkit.org/show_bug.cgi?id=54774

        * src/LocalFileSystemChromium.cpp:
        (WebCore::LocalFileSystem::readFileSystem):
        Removed size argument to readFileSystem()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
ossy@webkit.org [Mon, 28 Feb 2011 21:51:58 +0000 (21:51 +0000)]
Build fix for Qt port after API changes of trac.webkit.org/changeset/79904.

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-02-28
Reviewed by Oliver Hunt.

Source/WebCore:

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::execute):

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::evaluateJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 28 Feb 2011 21:41:26 +0000 (21:41 +0000)]
2011-02-28  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium rebaseline.

        Fix 3 tests for Snow Leopard by removing out of date chromium-mac
        baselines (there are already chromium-mac-leopard results).

        Revert rebaseline done by r79881 since the behavior was reverted by
        r79900.

        * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Removed.
        * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Removed.
        * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Removed.
        * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Removed.
        * platform/chromium-mac/fast/forms/placeholder-position-expected.checksum: Removed.
        * platform/chromium-mac/fast/forms/placeholder-position-expected.png: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
        * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWK2 Context Menus - Implement LookUpInDictionary
weinig@apple.com [Mon, 28 Feb 2011 21:39:27 +0000 (21:39 +0000)]
WK2 Context Menus - Implement LookUpInDictionary
https://bugs.webkit.org/show_bug.cgi?id=55405

Reviewed by Brady Eidson.

* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h:
Add type to differentiate between HotKey and ContextMenu triggered
dictionary popups. This is necessary since HotKey triggered ones want
to override the style to always be overlay.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
Only force the overlay style for HotKey triggered dictionary lookups.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::performDictionaryLookupForRange):
Factor out shared functionality into performDictionaryLookupForRange.

* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::lookUpInDictionary):
Get selected range and call newly factored out performDictionaryLookupForRange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Jungshik Shin <jshin@chromium.org>
jshin@chromium.org [Mon, 28 Feb 2011 21:35:13 +0000 (21:35 +0000)]
2011-02-28  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Tony Chang

        https://bugs.webkit.org/show_bug.cgi?id=55121

[chromium] Recently, French Academy changed the sorting
rules for French in such a way that accents are not weighted
from the end of a word any more. ICU 4.6 / CLDR 1.9
incorporated the change. Canadian French hasn't adopted the
change, yet.

        Chrome is the only port that uses new rules with ICU 4.6. So,
        for now, I'm changing the expectation file for Chrome only.

        * platform/chromium/fast/xsl: Added.
        * platform/chromium/fast/xsl/sort-locale-expected.txt: Copied from LayoutTests/fast/xsl/sort-locale-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove some duplicate code from KURLGoogle.cpp
levin@chromium.org [Mon, 28 Feb 2011 21:07:41 +0000 (21:07 +0000)]
Remove some duplicate code from KURLGoogle.cpp
https://bugs.webkit.org/show_bug.cgi?id=55266

Reviewed by Darin Adler.

No change in functionality so no new tests.

* WebCore.gyp/WebCore.gyp: Make KURL.cpp get built by Chromium.
* platform/KURL.cpp:
Simply moved #include's and some code that was identical (i.e.
had been copied) to KURLGoogle.cpp outside of ifdef !USE(GOOGLEURL)
to reduce duplication.
* platform/KURLGoogle.cpp:
Removed the duplicate code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 28 Feb 2011 21:07:24 +0000 (21:07 +0000)]
2011-02-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Use more xcconfig files in JavaScriptGlue gyp build
        https://bugs.webkit.org/show_bug.cgi?id=55395

        Technically this patch breaks the build because the generated project
        can't find the Info.plist file or the list of exported symbols.  I'll
        fix that in a follow-up patch.

        * gyp/JavaScriptGlue.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 28 Feb 2011 21:05:22 +0000 (21:05 +0000)]
2011-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make ScopeChainNode GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=55283

        Simplify lifetime and other issues with the scopechain
        by making it gc allocated.  This allows us to simplify
        function exit and unwinding, as well as making the
        current iterative refcounting go away.

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::createActivation):
        * bytecode/StructureStubInfo.cpp:
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::generate):
        (JSC::BytecodeGenerator::BytecodeGenerator):
        (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
        (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
        * bytecompiler/BytecodeGenerator.h:
        * debugger/Debugger.cpp:
        (JSC::Recompiler::operator()):
        * debugger/DebuggerCallFrame.h:
        (JSC::DebuggerCallFrame::scopeChain):
        * interpreter/CachedCall.h:
        (JSC::CachedCall::CachedCall):
        * interpreter/CallFrame.h:
        * interpreter/Interpreter.cpp:
        (JSC::depth):
        (JSC::Interpreter::unwindCallFrame):
        (JSC::Interpreter::throwException):
        (JSC::Interpreter::execute):
        (JSC::Interpreter::executeCall):
        (JSC::Interpreter::executeConstruct):
        (JSC::Interpreter::privateExecute):
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::compileOpCall):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::emit_op_ret):
        (JSC::JIT::emit_op_ret_object_or_this):
        (JSC::JIT::compileOpCall):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_end):
        (JSC::JIT::emit_op_ret):
        (JSC::JIT::emit_op_ret_object_or_this):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_end):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        * jit/JITStubs.h:
        * runtime/ArgList.cpp:
        * runtime/Completion.cpp:
        (JSC::evaluate):
        * runtime/Completion.h:
        * runtime/DateConversion.cpp:
        * runtime/Executable.cpp:
        (JSC::EvalExecutable::compileInternal):
        (JSC::ProgramExecutable::compileInternal):
        (JSC::FunctionExecutable::compileForCallInternal):
        (JSC::FunctionExecutable::compileForConstructInternal):
        * runtime/FunctionConstructor.cpp:
        (JSC::constructFunction):
        * runtime/GCActivityCallbackCF.cpp:
        * runtime/Identifier.cpp:
        * runtime/JSCell.h:
        * runtime/JSChunk.cpp: Added.
        * runtime/JSChunk.h: Added.
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::JSFunction):
        (JSC::JSFunction::markChildren):
        (JSC::JSFunction::getCallData):
        (JSC::JSFunction::getOwnPropertySlot):
        (JSC::JSFunction::getConstructData):
        * runtime/JSFunction.h:
        (JSC::JSFunction::scope):
        (JSC::JSFunction::setScope):
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * runtime/JSGlobalData.h:
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::init):
        (JSC::JSGlobalObject::markChildren):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
        (JSC::JSGlobalObject::globalScopeChain):
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncEval):
        * runtime/JSLock.cpp:
        * runtime/JSNumberCell.cpp:
        * runtime/JSZombie.cpp:
        * runtime/MarkedBlock.cpp:
        * runtime/MarkedSpace.cpp:
        * runtime/PropertyNameArray.cpp:
        * runtime/ScopeChain.cpp:
        (JSC::ScopeChainNode::print):
        (JSC::ScopeChainNode::localDepth):
        (JSC::ScopeChainNode::markChildren):
        * runtime/ScopeChain.h:
        (JSC::ScopeChainNode::ScopeChainNode):
        (JSC::ScopeChainNode::createStructure):
        (JSC::ScopeChainNode::push):
        (JSC::ScopeChainNode::pop):
        (JSC::ScopeChainIterator::ScopeChainIterator):
        (JSC::ScopeChainIterator::operator*):
        (JSC::ScopeChainIterator::operator->):
        (JSC::ScopeChainIterator::operator++):
        (JSC::ScopeChainNode::begin):
        (JSC::ScopeChainNode::end):
        (JSC::ExecState::globalData):
        (JSC::ExecState::lexicalGlobalObject):
        (JSC::ExecState::globalThisValue):
        * runtime/ScopeChainMark.h:
        * wtf/DateMath.cpp:
2011-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make ScopeChainNode GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=55283

        Update WebCore to deal with the absence of the ScopeChain
        class.

        * ForwardingHeaders/runtime/ScopeChain.h: Added.
        * bindings/js/JSHTMLElementCustom.cpp:
        (WebCore::JSHTMLElement::pushEventHandlerScope):
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::scopeChain):
        (WebCore::JSJavaScriptCallFrame::scopeType):
        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::initializeJSFunction):
        * bindings/js/JSMainThreadExecState.h:
        (WebCore::JSMainThreadExecState::evaluate):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::pushEventHandlerScope):
        * bindings/js/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::scopeChain):
        * bindings/js/JavaScriptCallFrame.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/c/c_class.cpp:
        * bridge/c/c_runtime.cpp:
        * bridge/jni/JNIBridge.cpp:
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtConnectionObject::execute):
        * plugins/PluginViewNone.cpp:
2011-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make ScopeChainNode GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=55283

        More updates for the absence of the ScopeChain class

        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame scopeChain]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 20:51:44 +0000 (20:51 +0000)]
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Adele Peterson.

        REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
        https://bugs.webkit.org/show_bug.cgi?id=55323

        Added test case to make sure no focus ring is drawn on selected items.

        * fast/forms/select-listbox-multiple-no-focusring.html: Added.
        * platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
        * platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
        * platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Adele Peterson.

        REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
        https://bugs.webkit.org/show_bug.cgi?id=55323

        Draw focus ring on selected items only if spatial navigation is enabled.

        Test: fast/forms/select-listbox-multiple-no-focusring.html

        * rendering/RenderBlock.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::addFocusRingRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Mon, 28 Feb 2011 20:29:51 +0000 (20:29 +0000)]
2011-02-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Anders Carlsson.

        We can cancel the plugin load and fail with error before m_manualStream
        got a chance to initialize in PluginView::didReceiveResponse. This can
        happen when we run pending document onload events during plugin load that
        remove the frame from underneath. So, change the assert into a null check.
        https://bugs.webkit.org/show_bug.cgi?id=55307

        * plugins/PluginView.cpp:
        (WebCore::PluginView::didFail):
2011-02-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Anders Carlsson.

        Unskip crashing test fast/frames/iframe-plugin-load-remove-document-crash.html.
        https://bugs.webkit.org/show_bug.cgi?id=55307

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 20:25:04 +0000 (20:25 +0000)]
2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Alexey Proskuryakov.

        Build fix for Intel ICC Compiler.
        https://bugs.webkit.org/show_bug.cgi?id=55221

        The virtual inheritance seems to confuse ICC.
        Anything that links with webkit has an undefined reference otherwise.

        * svg/SVGTransformable.cpp:
        (WebCore::SVGTransformable::~SVGTransformable):
        * svg/SVGTransformable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 20:18:14 +0000 (20:18 +0000)]
2011-02-28  Adam Klein  <adamk@chromium.org>

        Reviewed by James Robinson.

        [chromium] Remove "PASS TEXT" expectation for fast/filesystem/op-get-entry.html
        https://bugs.webkit.org/show_bug.cgi?id=55262

        Test now passes as Chromium has rolled past r76098.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt]tst_QDeclarativeWebView - 8 test cases fail
ossy@webkit.org [Mon, 28 Feb 2011 20:12:40 +0000 (20:12 +0000)]
[Qt]tst_QDeclarativeWebView - 8 test cases fail
https://bugs.webkit.org/show_bug.cgi?id=55214

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-02-28
Reviewed by Andreas Kling.

Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
I also refactored the tests so we don't use the network but instead a local html file.
QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.

* tests/qdeclarativewebview/resources/sample.html: Added.
* tests/qdeclarativewebview/resources/webviewtest.qml:
* tests/qdeclarativewebview/resources/webviewtestdefault.qml:
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::preferredWidthTest):
(tst_QDeclarativeWebView::preferredHeightTest):
(tst_QDeclarativeWebView::preferredWidthDefaultTest):
(tst_QDeclarativeWebView::preferredHeightDefaultTest):
* tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 28 Feb 2011 20:03:47 +0000 (20:03 +0000)]
2011-02-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        PDFViewController should hold a reference to the PDF data
        https://bugs.webkit.org/show_bug.cgi?id=55394

        * UIProcess/API/mac/PDFViewController.h:
        * UIProcess/API/mac/PDFViewController.mm:
        (WebKit::PDFViewController::setPDFDocumentData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Dimitri Glazkov <dglazkov@chromium.org>
abarth@webkit.org [Mon, 28 Feb 2011 19:50:24 +0000 (19:50 +0000)]
2011-02-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Add necessary build steps to JavaScriptGlue GYP project.
        https://bugs.webkit.org/show_bug.cgi?id=55196

        * gyp/JavaScriptGlue.gyp: Added pre- and post- build steps.
        * gyp/JavaScriptGlue.gypi: Added Info.plist.
        * gyp/remove-headers-if-needed.sh: Added.
        * gyp/run-if-exists.sh: Added.
        * gyp/update-info-plist.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Mon, 28 Feb 2011 19:44:13 +0000 (19:44 +0000)]
2011-02-28  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Resource size is incorrectly reported to WebCore
        https://bugs.webkit.org/show_bug.cgi?id=53228

        * platform/gtk/Skipped: unskipped http/tests/inspector/network-size.html
2011-02-28  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Resource size is incorrectly reported to WebCore
        https://bugs.webkit.org/show_bug.cgi?id=53228

        When calling didReceiveData we are sending an invalid value for
        lengthReceived. Sometimes we were even passing a boolean value instead of the
        expected integer. We should pass the size of the received data instead of the
        total amount of data received.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::gotChunkCallback):
        (WebCore::sendRequestCallback):
        (WebCore::readCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Mon, 28 Feb 2011 19:42:28 +0000 (19:42 +0000)]
2011-02-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Dan Bernstein.

        Cleanup the include guard form an Objective-C files
        https://bugs.webkit.org/show_bug.cgi?id=55379

        Normally Objective-C files do not need include guard.
        r76916 introduced an include guard in EmptyProtocolDefinitions.h.
        The guard is no longer needed after r76991.

        No new tests as there is no new functionality.

        * platform/mac/EmptyProtocolDefinitions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Podivilov <podivilov@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 19:29:59 +0000 (19:29 +0000)]
2011-02-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] no resources in scripts panel because debugger is enabled too early.
        https://bugs.webkit.org/show_bug.cgi?id=55389

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::populateScriptObjects):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::setFrontend):
        (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
        * inspector/InspectorDebuggerAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSize of text in popup menu doesn't match size of text in <select> itself in WebKit2
weinig@apple.com [Mon, 28 Feb 2011 19:19:02 +0000 (19:19 +0000)]
Size of text in popup menu doesn't match size of text in <select> itself in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48234

Reviewed by Darin Adler.

* Shared/TextInfo.cpp: Removed.
* Shared/TextInfo.h: Removed.
Replace this with the more appropriately DictionaryPopupInfo.

* Shared/DictionaryPopupInfo.cpp: Copied from Source/WebKit2/Shared/TextInfo.cpp.
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h: Copied from Source/WebKit2/Shared/TextInfo.h.
(WebKit::DictionaryPopupInfo::DictionaryPopupInfo):
Replace individual font related fields with FontInfo.

* Shared/FontInfo.cpp: Added.
(WebKit::FontInfo::FontInfo):
(WebKit::FontInfo::encode):
(WebKit::FontInfo::decode):
* Shared/FontInfo.h: Added.
Add class to encapsulate passing a font description over the wire.

* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
* Shared/PlatformPopupMenuData.h:
Add FontInfo as extra data for the Mac.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
* UIProcess/PageClient.h:
Add scaleFactor and use it to construct a font at the right size.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebPopupMenuProxy.h:
* UIProcess/mac/WebPopupMenuProxyMac.h:
(WebKit::WebPopupMenuProxyMac::create):
* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac):
(WebKit::WebPopupMenuProxyMac::populate):
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
* UIProcess/qt/WebPopupMenuProxyQt.h:
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
* UIProcess/win/WebPopupMenuProxyWin.h:
* WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
Pass scale factor through and rename TextInfo -> DictionaryPopupInfo.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Mon, 28 Feb 2011 19:08:42 +0000 (19:08 +0000)]
Unreviewed.

[Qt] Add Qt specific expected results for passing fast tests.

* platform/qt/Skipped: Unskip passing tests.
* platform/qt/fast/transforms [...] : Added.
* platform/qt/fast/tokenizer [...] : Added.
* platform/qt/fast/replaced [...] : Added.
* platform/qt/fast/runin [...] : Added.
* platform/qt/fast/selectors [...] : Added.
* platform/qt/fast/table [...] : Added.
* ChangeLog : Remove duplicated ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue@webkit.org [Mon, 28 Feb 2011 19:08:22 +0000 (19:08 +0000)]
2011-02-28  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Add clipped version of QWebElement::render method.
        Allows faster rendering of web element part.
        https://bugs.webkit.org/show_bug.cgi?id=50311

        * Api/qwebelement.cpp:
        (QWebElement::render):
        * Api/qwebelement.h:
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::render):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 28 Feb 2011 18:58:46 +0000 (18:58 +0000)]
2011-02-28  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations change.

        Skip over fast/overflow/horizontal-scroll-after-back.html added by
        r79844, since it's page cache-specific.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
pfeldman@chromium.org [Mon, 28 Feb 2011 18:30:18 +0000 (18:30 +0000)]
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79877.
        http://trac.webkit.org/changeset/79877
        https://bugs.webkit.org/show_bug.cgi?id=55388

        Breaks chromium build (Requested by antonm_ on #webkit).

        * WebCore.gypi:
        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::updateContentsIfDirty):
        (WebCore::ContentLayerChromium::resizeUploadBufferForImage):
        (WebCore::ContentLayerChromium::resizeUploadBuffer):
        (WebCore::SkBitmapConditionalAutoLockerPixels::SkBitmapConditionalAutoLockerPixels):
        (WebCore::SkBitmapConditionalAutoLockerPixels::~SkBitmapConditionalAutoLockerPixels):
        (WebCore::SkBitmapConditionalAutoLockerPixels::lockPixels):
        (WebCore::ContentLayerChromium::updateTextureIfNeeded):
        (WebCore::ContentLayerChromium::draw):
        * platform/graphics/chromium/ContentLayerChromium.h:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::contentRectToTileIndices):
        (WebCore::LayerTilerChromium::update):
        * platform/graphics/chromium/LayerTilerChromium.h:
        * platform/graphics/chromium/PlatformCanvas.cpp: Removed.
        * platform/graphics/chromium/PlatformCanvas.h: Removed.
        * platform/graphics/chromium/PlatformImage.cpp: Removed.
        * platform/graphics/chromium/PlatformImage.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 28 Feb 2011 18:29:40 +0000 (18:29 +0000)]
2011-02-28  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations change.

        Rebaseline fast/forms/listbox-hit-test-zoomed.html after r79762.
        Also make a new other expectations more specific.

        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
        * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 28 Feb 2011 18:23:06 +0000 (18:23 +0000)]
2011-02-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add live edit test.
        https://bugs.webkit.org/show_bug.cgi?id=55360

        * http/tests/inspector/debugger-test.js:
        (initialize_DebuggerTest):
        * inspector/debugger/debug-inlined-scripts.html:
        * inspector/debugger/live-edit-expected.txt: Added.
        * inspector/debugger/live-edit.html: Added.
        * inspector/debugger/resources/edit-me.js: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-02-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add live edit test.
        https://bugs.webkit.org/show_bug.cgi?id=55360

        Test: inspector/debugger/live-edit.html

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._doubleClick):
        (WebInspector.SourceFrame.prototype._didEditLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 18:16:13 +0000 (18:16 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. More follow ups to XML Viewer tests commit.

        * http/tests/xmlviewer/dumpAsText/frames.html:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 18:11:21 +0000 (18:11 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Follow up to r79858, removing optimistic assertion that fails on debug bot.

        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Adrienne Walker <enne@google.com>
enne@google.com [Mon, 28 Feb 2011 18:03:29 +0000 (18:03 +0000)]
2011-02-25  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Abstract "pixels with a graphics context" into its own class
        https://bugs.webkit.org/show_bug.cgi?id=55259

        This creates new PlatformCanvas/PlatformImage classes which wrap
        all of the #ifdef Skia/Cg warts from the compositor.  All classes
        (LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
        modified to use these abstractions.

        Tests: LayoutTests/compositing

        * WebCore.gypi:
        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::updateContentsIfDirty):
        (WebCore::ContentLayerChromium::resizeUploadBuffer):
        (WebCore::ContentLayerChromium::updateTextureIfNeeded):
        (WebCore::ContentLayerChromium::updateTexture):
        (WebCore::ContentLayerChromium::draw):
        * platform/graphics/chromium/ContentLayerChromium.h:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        (WebCore::ImageLayerChromium::updateTextureIfNeeded):
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::contentRectToTileIndices):
        (WebCore::LayerTilerChromium::update):
        (WebCore::LayerTilerChromium::updateFromPixels):
        * platform/graphics/chromium/LayerTilerChromium.h:
        * platform/graphics/chromium/PlatformCanvas.cpp: Added.
        (WebCore::PlatformCanvas::PlatformCanvas):
        (WebCore::PlatformCanvas::~PlatformCanvas):
        (WebCore::PlatformCanvas::resize):
        (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
        (WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
        (WebCore::PlatformCanvas::Painter::Painter):
        (WebCore::PlatformCanvas::Painter::~Painter):
        * platform/graphics/chromium/PlatformCanvas.h: Added.
        (WebCore::PlatformCanvas::AutoLocker::pixels):
        (WebCore::PlatformCanvas::Painter::context):
        (WebCore::PlatformCanvas::size):
        * platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp.
        (WebCore::PlatformImage::PlatformImage):
        (WebCore::PlatformImage::updateFromImage):
        * platform/graphics/chromium/PlatformImage.h: Added.
        (WebCore::PlatformImage::pixels):
        (WebCore::PlatformImage::size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
pfeldman@chromium.org [Mon, 28 Feb 2011 17:54:42 +0000 (17:54 +0000)]
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79784.
        http://trac.webkit.org/changeset/79784
        https://bugs.webkit.org/show_bug.cgi?id=55386

        This change causes lots of assertion failures in Debug builds
        (Requested by aroben on #webkit).

        * transitions/matched-transform-functions.html:
        * transitions/retargetted-transition.html:
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79784.
        http://trac.webkit.org/changeset/79784
        https://bugs.webkit.org/show_bug.cgi?id=55386

        This change causes lots of assertion failures in Debug builds
        (Requested by aroben on #webkit).

        * css/CSSStyleSelector.cpp:
        (WebCore::convertToLength):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::createTransformOperations):
        * platform/Length.h:
        (WebCore::Length::Length):
        (WebCore::Length::operator==):
        (WebCore::Length::operator!=):
        (WebCore::Length::rawValue):
        (WebCore::Length::type):
        (WebCore::Length::quirk):
        (WebCore::Length::setValue):
        (WebCore::Length::setRawValue):
        (WebCore::Length::calcFloatValue):
        (WebCore::Length::isZero):
        (WebCore::Length::blend):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 28 Feb 2011 17:51:03 +0000 (17:51 +0000)]
2011-02-28  Andreas Kling  <kling@webkit.org>

        Reviewed by Darin Adler.

        Use Frame::ownerElement() directly where appropriate.
        https://bugs.webkit.org/show_bug.cgi?id=55385

        Don't take the roundabout way through frame->document->ownerElement
        which just checks that the document->frame is non-null.

        No new test, refactoring only.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadWithDocumentLoader):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::scrollRecursively):
        (WebCore::EventHandler::logicalScrollRecursively):
        * page/FrameView.cpp:
        (WebCore::FrameView::init):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::repaintContentRectangle):
        (WebCore::FrameView::windowClipRect):
        (WebCore::FrameView::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 17:43:11 +0000 (17:43 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: follow up to r79861, moved utf-16-no-bom to its new home, fixed flaky frames.html.

        * fast/encoding/dumpAsText/utf-16-no-bom.xml: Renamed from LayoutTests/fast/encoding/utf-16-no-bom.xml.
        * http/tests/xmlviewer/dumpAsText/frames.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 28 Feb 2011 17:29:51 +0000 (17:29 +0000)]
2011-02-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] source frame is recreated for each inlined script in document.
        https://bugs.webkit.org/show_bug.cgi?id=55377

        * inspector/debugger/scripts-panel-expected.txt:
        * inspector/debugger/scripts-panel.html:
2011-02-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] source frame is recreated for each inlined script in document.
        https://bugs.webkit.org/show_bug.cgi?id=55377

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName):
        (WebInspector.ScriptsPanel.prototype._createSourceFrame):
        (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Mon, 28 Feb 2011 17:22:45 +0000 (17:22 +0000)]
Unreviewed.

[Qt] Remove non-existent tests from Skipped list after r79861.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 28 Feb 2011 17:20:22 +0000 (17:20 +0000)]
2011-02-28  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r79569.

        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Mon, 28 Feb 2011 17:16:08 +0000 (17:16 +0000)]
Unreviewed.

[Qt] Add Qt specific expected results for passing fast/css tests.

* platform/qt/Skipped:
* platform/qt/fast/css [...] : Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOne more rename as a followup to r79868
aroben@apple.com [Mon, 28 Feb 2011 16:55:46 +0000 (16:55 +0000)]
One more rename as a followup to r79868

Rubber-stamped by Anders Carlsson.

* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
Rename stateDidChange to backingStoreStateDidChange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename DrawingArea[Proxy]Impl's "state ID" concept to "backing store state ID"
aroben@apple.com [Mon, 28 Feb 2011 16:53:03 +0000 (16:53 +0000)]
Rename DrawingArea[Proxy]Impl's "state ID" concept to "backing store state ID"

Rubber-stamped (and suggested) by Anders Carlsson.

* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/DrawingAreaImpl.h:
Perform the rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDecouple state changes from sending of UpdateState messages in DrawingAreaProxyImpl
aroben@apple.com [Mon, 28 Feb 2011 16:35:32 +0000 (16:35 +0000)]
Decouple state changes from sending of UpdateState messages in DrawingAreaProxyImpl

The new DrawingAreaProxyImpl::stateDidChange function should be called whenever
DrawingAreaProxyImpl's state changes in a way that will require allocating a new backing
store. (Currently, this is just when the size changes.) This function will sometimes (but
not always, as when we're waiting for a DidUpdateState message) send an UpdateState message
to the web process. This means it's now possible for the state IDs sent in consecutive
UpdateState messages to increase by more than one, but that's OK.

This should cause no change in behavior.

Fixes <http://webkit.org/b/55382> DrawingAreaProxyImpl's state ID should be updated whenever
its state changes, not just when we send an UpdateState message

Reviewed by Anders Carlsson.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Updated for rename.
(WebKit::DrawingAreaProxyImpl::sizeDidChange): Changed to call stateDidChange.
(WebKit::DrawingAreaProxyImpl::didUpdateState): Updated for rename, and changed to call
sendUpdateState whenever our state has changed for any reason since the last UpdateState
message was sent.
(WebKit::DrawingAreaProxyImpl::stateDidChange): Added. Increments m_nextStateID and calls
through to sendUpdateState.
(WebKit::DrawingAreaProxyImpl::sendUpdateState): Updated for rename, moved incrementing of
the state ID we send to the web process from here to stateDidChange, and added an assertion.

* UIProcess/DrawingAreaProxyImpl.h: Renamed m_requestedStateID to m_nextStateID, and updated
the comment explaining its meaning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Mon, 28 Feb 2011 16:16:39 +0000 (16:16 +0000)]
2011-02-28  Renata Hodovan  <reni@webkit.org>

        Reviewed by Andreas Kling.

        Optimize parameter transmissions in FEConvolveMatrix.
        https://bugs.webkit.org/show_bug.cgi?id=55381

        Parameter transmission via reference is more efficient than with copy. So they are substituted.

        No new tests are needed since this is a refactoring.

        * platform/graphics/filters/FEConvolveMatrix.cpp:
        (WebCore::FEConvolveMatrix::setKernelSize):
        (WebCore::FEConvolveMatrix::setTargetOffset):
        (WebCore::FEConvolveMatrix::setKernelUnitLength):
        * platform/graphics/filters/FEConvolveMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip a sometimes-crashing test on Windows
aroben@apple.com [Mon, 28 Feb 2011 16:05:42 +0000 (16:05 +0000)]
Skip a sometimes-crashing test on Windows

The failure is tracked by <http://webkit.org/b/55375>.

* platform/win/Skipped: Added http/tests/websocket/tests/reload-crash.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 28 Feb 2011 15:50:29 +0000 (15:50 +0000)]
2011-02-28  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Fix Chromium tests failures due to r79858.

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::inspectedPageDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPass the right dirty rect to Plugin::paint
aroben@apple.com [Mon, 28 Feb 2011 15:31:47 +0000 (15:31 +0000)]
Pass the right dirty rect to Plugin::paint

A typo in r79040 broke this. Much of this patch is just support for testing the fix.

Fixes <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
Large portions of pages with plugins paint black

Reviewed by Anders Carlsson.

Source/WebKit2:

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint): Pass the dirty rect we calculated earlier to Plugin::paint,
rather than just passing along the dirty rect that was passed into this function. This is
the bug fix.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageForceRepaint):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
Added new SPI. Just calls through to WebPage::forceRepaintWithoutCallback.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::forceRepaintWithoutCallback): Moved code to force a repaint here...
(WebKit::WebPage::forceRepaint): ...from here.

* WebProcess/WebPage/WebPage.h: Added forceRepaintWithoutCallback.

Tools:

Add a test for the paint rect passed via WM_PAINT to windowless plugins

* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPP_HandleEvent):
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
Added NPP_HandleEvent. Just returns 0 at this level.

* DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
(WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
(WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
(WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
WM_PAINT has the expected coordinates.

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
else.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
resort things.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
webView:didFinishLoadForFrame:] in DumpRenderTree.

* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
can start running.

LayoutTests:

Add a test for the paint rect passed via WM_PAINT to windowless plugins

* platform/win-wk2/platform/win/plugins/windowless-paint-rect-coordinates-expected.txt: Added.
* platform/win/plugins/windowless-paint-rect-coordinates-expected.txt: Added. WebKit1
doesn't pass a paint rect via WM_PAINT, so we have different results there.
* platform/win/plugins/windowless-paint-rect-coordinates.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTell MiniBrowser's WKViews that they're in a window
aroben@apple.com [Mon, 28 Feb 2011 15:30:33 +0000 (15:30 +0000)]
Tell MiniBrowser's WKViews that they're in a window

Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows

Reviewed by Anders Carlsson.

* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create): Call WKViewSetIsInWindow after creating the view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Vsevolod Vlasov <vsevik@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 15:26:44 +0000 (15:26 +0000)]
2011-02-28  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        XML without style should render as syntax-highlighted source.
        https://bugs.webkit.org/show_bug.cgi?id=13807

        Added tests for XML tree view mode. Testing both logic for entering
        XML tree view mode and rendering itself.
        Tests are disabled for QT since this logic is not yet implemented, see
        https://bugs.webkit.org/show_bug.cgi?id=55302

        * fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Copied from LayoutTests/fast/css/xml-stylesheet-pi-not-in-prolog.xml.
        * fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog.xml: Renamed from LayoutTests/fast/css/xml-stylesheet-pi-not-in-prolog.xml.
        * fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Added.
        * fast/encoding/dumpAsText/utf-16-no-bom.xml: Renamed from LayoutTests/fast/encoding/utf-16-no-bom.xml.
        * http/tests/xmlviewer/dumpAsText/css-stylesheet-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/css-stylesheet.xml: Added.
        * http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/frames.html: Added.
        * http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/mathml.xml: Added.
        * http/tests/xmlviewer/dumpAsText/resources/css-stylesheet.css: Added.
        (assertion):
        * http/tests/xmlviewer/dumpAsText/resources/frames-helper.xml: Added.
        * http/tests/xmlviewer/dumpAsText/resources/xsl.xml: Added.
        * http/tests/xmlviewer/dumpAsText/svg-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/svg.xml: Added.
        * http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/wml.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xhtml-tag-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xhtml-tag.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xlink-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xlink.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xsl-stylesheet-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xul-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xul.xml: Added.
        * platform/chromium-linux/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
        * platform/chromium-linux/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
        * platform/chromium-linux/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
        * platform/chromium-linux/fast/encoding/utf-16-no-bom-expected.png: Removed.
        * platform/chromium-linux/svg/hixie/error/004-expected.checksum: Removed.
        * platform/chromium-linux/svg/hixie/error/004-expected.png: Removed.
        * platform/chromium-linux/svg/hixie/error/005-expected.checksum: Removed.
        * platform/chromium-linux/svg/hixie/error/005-expected.png: Removed.
        * platform/chromium-win/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
        * platform/chromium-win/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
        * platform/chromium-win/fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
        * platform/chromium-win/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
        * platform/chromium-win/fast/encoding/utf-16-no-bom-expected.png: Removed.
        * platform/chromium-win/fast/encoding/utf-16-no-bom-expected.txt: Removed.
        * platform/chromium-win/svg/hixie/error/004-expected.checksum: Removed.
        * platform/chromium-win/svg/hixie/error/004-expected.png: Removed.
        * platform/chromium-win/svg/hixie/error/004-expected.txt: Removed.
        * platform/chromium-win/svg/hixie/error/005-expected.checksum: Removed.
        * platform/chromium-win/svg/hixie/error/005-expected.png: Removed.
        * platform/chromium-win/svg/hixie/error/005-expected.txt: Removed.
        * platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
        * platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
        * platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
        * platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
        * platform/gtk/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
        * platform/gtk/fast/encoding/utf-16-no-bom-expected.png: Removed.
        * platform/gtk/fast/encoding/utf-16-no-bom-expected.txt: Removed.
        * platform/gtk/svg/hixie/error/004-expected.checksum: Removed.
        * platform/gtk/svg/hixie/error/004-expected.png: Removed.
        * platform/gtk/svg/hixie/error/004-expected.txt: Removed.
        * platform/gtk/svg/hixie/error/005-expected.checksum: Removed.
        * platform/gtk/svg/hixie/error/005-expected.png: Removed.
        * platform/gtk/svg/hixie/error/005-expected.txt: Removed.
        * platform/mac-leopard/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
        * platform/mac-leopard/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
        * platform/mac-leopard/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
        * platform/mac-leopard/fast/encoding/utf-16-no-bom-expected.png: Removed.
        * platform/mac-leopard/svg/hixie/error/004-expected.checksum: Removed.
        * platform/mac-leopard/svg/hixie/error/004-expected.png: Removed.
        * platform/mac-leopard/svg/hixie/error/005-expected.checksum: Removed.
        * platform/mac-leopard/svg/hixie/error/005-expected.png: Removed.
        * platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
        * platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
        * platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
        * platform/mac/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
        * platform/mac/fast/encoding/utf-16-no-bom-expected.png: Removed.
        * platform/mac/fast/encoding/utf-16-no-bom-expected.txt: Removed.
        * platform/mac/svg/hixie/error/004-expected.checksum: Removed.
        * platform/mac/svg/hixie/error/004-expected.png: Removed.
        * platform/mac/svg/hixie/error/004-expected.txt: Removed.
        * platform/mac/svg/hixie/error/005-expected.checksum: Removed.
        * platform/mac/svg/hixie/error/005-expected.png: Removed.
        * platform/mac/svg/hixie/error/005-expected.txt: Removed.
        * platform/qt/Skipped:
        * platform/qt/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Added.
        * platform/qt/fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
        * platform/qt/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Added.
        * platform/qt/fast/encoding/utf-16-no-bom-expected.txt: Removed.
        * platform/qt/svg/hixie/error/004-expected.txt: Removed.
        * platform/qt/svg/hixie/error/005-expected.txt: Removed.
        * platform/qt/svg/hixie/error/dumpAsText/004-expected.txt: Added.
        * platform/qt/svg/hixie/error/dumpAsText/005-expected.txt: Added.
        * svg/hixie/error/dumpAsText/004-expected.txt: Added.
        * svg/hixie/error/dumpAsText/004.xml: Renamed from LayoutTests/svg/hixie/error/004.xml.
        * svg/hixie/error/dumpAsText/005-expected.txt: Added.
        * svg/hixie/error/dumpAsText/005.xml: Renamed from LayoutTests/svg/hixie/error/005.xml.
2011-02-28  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        XML without style should render as syntax-highlighted source.
        https://bugs.webkit.org/show_bug.cgi?id=13807

        XML tree view mode implemented. If XML does not have any style
        information, it is rendered as highlighted source with collapsable
        elements.

        Tests: fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog.xml
               fast/encoding/dumpAsText/utf-16-no-bom.xml
               http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
               http/tests/xmlviewer/dumpAsText/frames.html
               http/tests/xmlviewer/dumpAsText/mathml.xml
               http/tests/xmlviewer/dumpAsText/svg.xml
               http/tests/xmlviewer/dumpAsText/wml.xml
               http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
               http/tests/xmlviewer/dumpAsText/xlink.xml
               http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
               http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
               http/tests/xmlviewer/dumpAsText/xmlviewer.xml
               http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
               http/tests/xmlviewer/dumpAsText/xul.xml
               svg/hixie/error/dumpAsText/004.xml
               svg/hixie/error/dumpAsText/005.xml

        * CMakeLists.txt:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchUARules):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::createElement):
        * dom/Document.h:
        (WebCore::Document::usesViewSourceStyles):
        (WebCore::Document::setUsesViewSourceStyles):
        (WebCore::Document::sawElementsInKnownNamespaces):
        * dom/XMLDocumentParser.h:
        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        (WebCore::XMLDocumentParser::processingInstruction):
        (WebCore::XMLDocumentParser::initializeParserContext):
        (WebCore::XMLDocumentParser::doEnd):
        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        (WebCore::XMLDocumentParser::initializeParserContext):
        (WebCore::XMLDocumentParser::parseProcessingInstruction):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        * xml/XMLTreeViewer.cpp: Added.
        (WebCore::XMLTreeViewer::XMLTreeViewer):
        (WebCore::XMLTreeViewer::hasNoStyleInformation):
        (WebCore::XMLTreeViewer::transformDocumentToTreeView):
        * xml/XMLTreeViewer.h: Added.
        (WebCore::XMLTreeViewer::~XMLTreeViewer):
        * xml/XMLViewer.xsl: Added.
        * xml/XSLStyleSheet.h:
        (WebCore::XSLStyleSheet::createForXMLTreeViewer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNvel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 15:14:18 +0000 (15:14 +0000)]
Nvel Feldman  <pfeldman@chromium.org>

        Not reviewed: skipping new inspector network tests on win.

        * platform/win/Skipped:ot reviewed: skipping new inspector network tests on win.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 14:55:44 +0000 (14:55 +0000)]
2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Csaba Osztrogonác.

        The new QML tests require QML_IMPORT_PATH variable to be set in order to
        load the proper plugin.

        * Scripts/run-qtwebkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 28 Feb 2011 14:49:33 +0000 (14:49 +0000)]
2011-02-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: debugger agents should have same livetime as InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=55369

        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
2011-02-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: debugger agents should have same livetime as InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=55369

        DOM and JS debugger agents are now created in InspectorAgent's constructor and owned
        by the agent. Debugger state is cleared on frontend disconnect.

        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::populateScriptObjects):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::showScriptsPanel):
        * inspector/InspectorAgent.h:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::create):
        (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::debuggerWasEnabled):
        (WebCore::InspectorBrowserDebuggerAgent::debuggerWasDisabled):
        (WebCore::InspectorBrowserDebuggerAgent::disable):
        (WebCore::InspectorBrowserDebuggerAgent::setFrontend):
        (WebCore::InspectorBrowserDebuggerAgent::clearFrontend):
        (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
        (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
        (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
        (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
        (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
        (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
        (WebCore::InspectorBrowserDebuggerAgent::clear):
        * inspector/InspectorBrowserDebuggerAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::debuggerEnabled):
        (WebCore::InspectorController::showAndEnableDebugger):
        (WebCore::InspectorController::disableDebugger):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::create):
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::startUserInitiatedDebugging):
        (WebCore::InspectorDebuggerAgent::enable):
        (WebCore::InspectorDebuggerAgent::disable):
        (WebCore::InspectorDebuggerAgent::enabled):
        (WebCore::InspectorDebuggerAgent::restore):
        (WebCore::InspectorDebuggerAgent::setFrontend):
        (WebCore::InspectorDebuggerAgent::clearFrontend):
        (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint):
        (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint):
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
        (WebCore::InspectorDebuggerAgent::currentCallFrames):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        (WebCore::InspectorDebuggerAgent::clear):
        * inspector/InspectorDebuggerAgent.h:
        (WebCore::InspectorDebuggerAgent::enable):
        (WebCore::InspectorDebuggerAgent::disable):
        (WebCore::InspectorDebuggerAgent::Listener::~Listener):
        (WebCore::InspectorDebuggerAgent::setListener):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.enableDebugger):
        (WebInspector.DebuggerModel.prototype.disableDebugger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 14:25:05 +0000 (14:25 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: updated inspector test harness and chromium expectations.

        * http/tests/inspector/network/network-size-expected.txt:
        * http/tests/inspector/network/network-timing.html:
        * http/tests/inspector/network/resources/resource.php:
        * platform/chromium/http/tests/inspector/network/network-size-expected.txt: Copied from LayoutTests/http/tests/inspector/network/network-size-expected.txt.
        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Mon, 28 Feb 2011 14:03:06 +0000 (14:03 +0000)]
2011-02-28  Renata Hodovan  <reni@webkit.org>

        Reviewed by Andreas Kling.

        FECompositeElement changes doesn't require relayout.
        https://bugs.webkit.org/show_bug.cgi?id=55367

        When the FECompositeElement receives an update message but the given value remains the same we don't need
        to relayout the filter.

        No new tests are needed because this modification is covered by the dynamic update tests of FEComposite.

        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::FEComposite::setOperation):
        (WebCore::FEComposite::setK1):
        (WebCore::FEComposite::setK2):
        (WebCore::FEComposite::setK3):
        (WebCore::FEComposite::setK4):
        * platform/graphics/filters/FEComposite.h:
        * svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::setFilterEffectAttribute):
        (WebCore::SVGFECompositeElement::svgAttributeChanged):
        * svg/SVGFECompositeElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 28 Feb 2011 13:46:06 +0000 (13:46 +0000)]
2011-02-28  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        FrameLoader: Reorder early-returns in checkCompleted()
        https://bugs.webkit.org/show_bug.cgi?id=55366

        Check allChildrenAreComplete() last, since it's the most expensive.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkCompleted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 28 Feb 2011 13:24:25 +0000 (13:24 +0000)]
2011-02-28  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Range::processContents needs cleanup
        https://bugs.webkit.org/show_bug.cgi?id=51006

        Refactored Range::processContents.  Extracted childOfCommonRootBeforeOffset from processContents
        which is used to find processStart and processEnd respectively.  In the case of processStart,
        we use the next sibling of the node returned by childOfCommonRootBeforeOffset when m_start is not
        the common root because copying m_start's ancestors will result in processing too much contents.

        Also extracted processNodes and deleteCharacterData from processContents and processContentsBetweenOffsets.

        In addition, lengthOfContentsInNode was modified to return the correct length instead of
        numeric_limits<unsigned>::max() because the convention that processContentsBetweenOffsets automatically
        corrects the length when endOffset is numeric_limits<unsigned>::max() seemed more confusing than
        having two switch statements that need to be consistent.

        Historically, lengthOfContentsInNode was introduced in r78413 as a build fix because unsigned const
        LengthOfContentsInNode added in r78409 violated WebKit C++ rules and caused build failures on Mac and
        other ports.

        * dom/Range.cpp:
        (WebCore::childOfCommonRootBeforeOffset): Extracted from processContents.
        (WebCore::lengthOfContentsInNode): Added.
        (WebCore::Range::processContents): Calls childOfCommonRootBeforeOffset, lengthOfContentsInNode,
        and processNodes.
        (WebCore::deleteCharacterData): Added.
        (WebCore::Range::processContentsBetweenOffsets): Calls deleteCharacterData and processNodes.
        (WebCore::Range::processNodes): Extracted from processContents and processContentsBetweenOffsets.
        (WebCore::Range::processAncestorsAndTheirSiblings):
        * dom/Range.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 11:47:46 +0000 (11:47 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Test harness change follow up.
        Consider missing localized string a warning, not an error in the front-end.

        * inspector/front-end/inspector.js:
        (WebInspector.UIString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Steve Block <steveblock@google.com>
steveblock@google.com [Mon, 28 Feb 2011 11:40:22 +0000 (11:40 +0000)]
2011-02-28  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        getJNIEnv() passes wrong type to AttachCurrentThread() for JNIEnv argument on Android
        https://bugs.webkit.org/show_bug.cgi?id=55218

        AttachCurrentThread() in Android's JVM takes a JINEnv**
        argument.

        No new tests, build fix only.

        * bridge/jni/JNIUtility.cpp:
        (JSC::Bindings::getJNIEnv):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Mon, 28 Feb 2011 11:31:11 +0000 (11:31 +0000)]
2011-02-28  Renata Hodovan  <reni@webkit.org>

        Reviewed by Andreas Kling.

        FETurbulenceElement changes doesn't require relayout
        https://bugs.webkit.org/show_bug.cgi?id=55141

        When the FETurbulenceElement receives an update message but the given value remains the same we don't need
        to relayout the filter.
        Besides fix a typo in FETurbulence and change the paramterer type of FETurbulence::setNumOctaves from bool
        to int according to the spec.

        No new tests are needed because this modification is covered by the dynamic update tests of FETurbulence.

        * platform/graphics/filters/FETurbulence.cpp:
        (WebCore::FETurbulence::FETurbulence):
        (WebCore::FETurbulence::create):
        (WebCore::FETurbulence::type):
        (WebCore::FETurbulence::setType):
        (WebCore::FETurbulence::setBaseFrequencyY):
        (WebCore::FETurbulence::setBaseFrequencyX):
        (WebCore::FETurbulence::setSeed):
        (WebCore::FETurbulence::setNumOctaves):
        (WebCore::FETurbulence::setStitchTiles):
        (WebCore::operator<<):
        * platform/graphics/filters/FETurbulence.h:
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute):
        (WebCore::SVGFETurbulenceElement::svgAttributeChanged):
        (WebCore::SVGFETurbulenceElement::build):
        * svg/SVGFETurbulenceElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79851 268f45cc-cd09-0410-ab3c-d52691b4dbfc