14 years agoWebCore:
ddkilzer@apple.com [Mon, 3 Mar 2008 19:45:21 +0000 (19:45 +0000)]

        Dynamically inserting CSS rule with @media query fails with DOM Exception 12

        Reviewed by Darin.

        Allow any valid rule (@font-face, @import, @media, @page or style) to be
        parsed when using CSSStyleSheet.insertRule().  Previously only import and
        style rules were allowed.  Note that @page rules always throw an exception
        because they're not implemented yet, so no test case was added for them.

        Tests: fast/css/insertRule-font-face.html

        * css/CSSGrammar.y: Extracted 'valid_rule' out of 'rule'.  Renamed
        'ruleset_or_import' to 'valid_rule_or_import' and changed its definition.


        Dynamically inserting CSS rule with @media query fails with DOM Exception 12

        Reviewed by Darin.

        * fast/css/insertRule-font-face.html: Added.
        * fast/css/insertRule-media.html: Added.
        * fast/css/resources/insertRule-font-face.js: Added.
        * fast/css/resources/insertRule-media.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
andersca@apple.com [Mon, 3 Mar 2008 19:43:29 +0000 (19:43 +0000)]
    Reviewed by Sam.

        Copy JSC bindings directory over to WebCore/bridge.

        * bridge: Copied from ../JavaScriptCore/bindings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
mitz@apple.com [Mon, 3 Mar 2008 18:56:20 +0000 (18:56 +0000)]
    Reviewed by Darin Adler.

        - remove CSSMutableStyleDeclaration::setChanged()'s change type

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setChanged): Removed the change
        type parameter and made this function determine the correct change type
        based on whether this is an inline style declaration.
        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::clear): Removed this unused
        (WebCore::CSSMutableStyleDeclaration::setChanged): Made private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Mon, 3 Mar 2008 18:44:12 +0000 (18:44 +0000)]

        Reviewed by Adam.

        - some "cleanup" on the path to removing WebCoreFrameBridge

        * WebCore.base.exp: Exported some stuff we either already use or
        I am about to use in an upcoming patch.

        * WebCore.xcodeproj/project.pbxproj: Made FileChooser.h private rather
        than project, for future use in WebKit.

        * bindings/objc/WebScriptObject.mm: Removed some dead code.

        * dom/ContainerNode.cpp: Added a now-needed or soon-to-be-needed include.
        * editing/Editor.cpp: Ditto.

        * editing/Editor.h: Removed many unneeded declarations and includes.
        Removed the unused userVisibleString function.

        * editing/EditorCommand.cpp:
        (WebCore::executeYank): Added parameter for triggeringEvent, which no
        longer has a default value.
        (WebCore::executeYankAndSelect): Ditto.

        * editing/mac/EditorMac.mm: Removed userVisibleString.

        * page/mac/EventHandlerMac.mm:
        (WebCore::isKeyboardOptionTab): Tweaked formattin.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge dragSourceMovedTo:]): Get window from -[NSView window]
        rather than from the bridge. There's no special value in the bridge's window
        method and we can use NSView directly.
        (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): Ditto.

        * platform/graphics/mac/ImageMac.mm:
        (WebCore::Image::loadPlatformResource): Use a new WebCoreBundleFinder class to
        find the bundle rather than using WebCoreFrameBridge.

        * platform/mac/ClipboardMac.mm: Added a now-needed or soon-to-be-needed include.
        * platform/mac/PasteboardMac.mm: Ditto.

        * rendering/RenderObject.h:
        (WebCore::DashboardRegionValue::operator==): Fixed mistake where this wasn't
        comparing the clip rectangle.
        (WebCore::DashboardRegionValue::operator!=): Added. Needed by my future work.


        Reviewed by Adam.

        - some "cleanup" on the path to removing WebCoreFrameBridge

        * Storage/WebDatabaseManager.mm: Tweak includes.
        * Storage/WebDatabaseTrackerClient.mm: Ditto.
        * Storage/WebSecurityOrigin.mm: Ditto.
        * Storage/WebSecurityOriginInternal.h: Ditto.

        * WebView/WebFrame.mm:
        (core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly
        match WebCore::EditableLinkBehavior.
        * WebView/WebFrameInternal.h: Removed unused kit function.

        * WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here.
        * WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here.
        * WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations.

        * WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug 17620: getImageData lies
oliver@apple.com [Mon, 3 Mar 2008 09:34:49 +0000 (09:34 +0000)]
Bug 17620: getImageData lies

Reviewed by Mark Rowe

Correct logic to actually iterate over the source row

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCorrect incorrect assertion
oliver@apple.com [Mon, 3 Mar 2008 08:17:08 +0000 (08:17 +0000)]
Correct incorrect assertion

Reviewed by Mark Rowe

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-02 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 3 Mar 2008 05:34:58 +0000 (05:34 +0000)]
2008-03-02  Alp Toker  <alp@atoker.com>

        Another fix for non-database builds after changes in r30331.

        Conditionalize a stopDatabases() call.

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Alp Toker.
kevino@webkit.org [Mon, 3 Mar 2008 05:29:38 +0000 (05:29 +0000)]
Reviewed by Alp Toker.

Scrolling fixes. Implement page scrolling, initialize mouse wheel event variables, and remove duplicate event binding for TOP scrolling event.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-02 Brent Fulgham <bfulgham@gmail.com>
alp@webkit.org [Mon, 3 Mar 2008 05:10:18 +0000 (05:10 +0000)]
2008-03-02  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Alp Toker.

        GTK Build (using autotools) on Mac OS (DarwinPorts) Fails

        Add -lstdc++ to link flags for minidom program.  This corrects
        a build error for the GTK+ on Mac OS.

        Add ICU_CPPFLAGS earlier in include path for WebCore
        so that we find $(icu_cppflags)/unicode/utf8.h, rather than
        the wtf/unicode/UTF8.h on case-insensitive file systems.

        Remove some needless LIBS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-02 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 3 Mar 2008 05:02:38 +0000 (05:02 +0000)]
2008-03-02  Alp Toker  <alp@atoker.com>

        Fix building without database support after changes in r30331.

        * dom/Document.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agowx build fix for Windows after PageWin.cpp move.
kevino@webkit.org [Mon, 3 Mar 2008 03:16:05 +0000 (03:16 +0000)]
wx build fix for Windows after PageWin.cpp move.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Dave Hyatt.
kevino@webkit.org [Mon, 3 Mar 2008 02:02:28 +0000 (02:02 +0000)]
Reviewed by Dave Hyatt.

Gracefully handle a CSS rule containing an invalid value.
(Fixes http://bugs.webkit.org/show_bug.cgi?id=16898)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-02 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 2 Mar 2008 22:58:47 +0000 (22:58 +0000)]
2008-03-02  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Improve the Cairo Path::isEmpty() function

        Use cairo_has_current_point() where available.

        * platform/graphics/cairo/PathCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-02 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 2 Mar 2008 19:51:26 +0000 (19:51 +0000)]
2008-03-02  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Split the WebKit GTK+ build out of the WebCore build and change the
        shared object name to match the package name.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate Xcode configuration to support building debug and release from the mysterious...
mrowe@apple.com [Sun, 2 Mar 2008 07:08:59 +0000 (07:08 +0000)]
Update Xcode configuration to support building debug and release from the mysterious future.

Reviewed by Tim Hatcher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug 16954: Support putImageData
oliver@apple.com [Sun, 2 Mar 2008 06:55:44 +0000 (06:55 +0000)]
Bug 16954: Support putImageData

Reviewed by Sam Weinig.

Implement support for HTML5's putImageData for the CG port.  All other ports
are currently just using stubs for the final blit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoTypo fix.
kevino@webkit.org [Sun, 2 Mar 2008 02:13:44 +0000 (02:13 +0000)]
Typo fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-01 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sun, 2 Mar 2008 02:02:38 +0000 (02:02 +0000)]
2008-03-01  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        <rdar://problem/5772987> Crashing viewing page with two VLC plug-in

        The VLC Netscape plug-in crashes if more than one instance is created.

        Added a quirk that disallows a plug-in from having more than one
        instance and set this for the VLC plug-in.

        In addition, we now sort plug-ins that handle the same MIME
        type to choose the most appropriate one. This sorting first sorts by
        whether a plug-in has an issue that should put it at the end of the
        list, then whether it appears in a "preferred" plug-in directory.

        * plugins/PluginQuirkSet.h: Added PluginQuirkDontAllowMultipleInstances.
        * plugins/PluginDatabase.cpp:
        (WebCore::PluginDatabase::preferredPluginCompare): Comparator for
        sorting plug-ins; calls PluginPackage::compare().
        (WebCore::PluginDatabase::pluginForMIMEType): Add all of the plug-ins
        that handle this MIME type to a list, sort the list, and return the
        first item.
        (WebCore::PluginDatabase::MIMETypeForExtension): Add all of the plug-ins
        that handle this extension to a list, sort the list, and return the MIME
        type used by the plug-in at the beginning of the list.
        * plugins/PluginDatabase.h:
        * plugins/PluginPackage.h:
        (WebCore::PluginPackage::version): Added; returns the module version.
        * plugins/win/PluginDatabaseWin.cpp:
        (WebCore::PluginDatabase::isPreferredPluginPath): Made static; removed
        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::compare): Sorts plug-ins with known issues to
        the end, then plug-ins in preferred directories to the beginning, then
        alphabetically by file name, numerically by version, and alphabetically
        by parent directory.
        (WebCore::PluginPackage::determineQuirks): Set the "don't allow multiple
        instances" quirk for VLC.
        (WebCore::PluginPackage::load): Return false if the plug-in library has
        already been loaded and the "don't allow multiple instances" quirk is
        * platform/gtk/TemporaryLinkStubs.cpp:
        (PluginPackage::compare): Added stub.
        (PluginDatabase::IsPreferredPluginPath): Update the GTK stub.
        * platform/qt/TemporaryLinkStubs.cpp:
        (PluginPackage::compare): Added stub.
        (PluginDatabase::IsPreferredPluginPath): Update the Qt stub.
        * platform/wx/TemporaryLinkStubs.cpp:
        (PluginPackage::compare): Added stub.
        (PluginDatabase::IsPreferredPluginPath): Update the wx stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Mark Rowe.
weinig@apple.com [Sat, 1 Mar 2008 21:55:42 +0000 (21:55 +0000)]
    Rubber-stamped by Mark Rowe.

        Remove reference to the now non-existent bridge directory.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig@apple.com [Sat, 1 Mar 2008 20:19:27 +0000 (20:19 +0000)]

        Reviewed by Darin Adler.

        Search the entire prototype chain when doing early prototype lookup in
        the Window's getOwnPropertySlot method.

        Makes fast/dom/Window/window-function-name-getter-precedence.html pass all tests.

        * bindings/js/kjs_window.cpp:


        Reviewed by Darin Adler.

        Update test result.

        * fast/dom/Window/window-function-name-getter-precedence-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Oliver.
zimmermann@webkit.org [Sat, 1 Mar 2008 13:46:29 +0000 (13:46 +0000)]
Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17568 (SVGForeignObjectElement can't react to width/height SVG DOM changes)
As the bug title says, fix all dynamic update problems that occour with SVGForeignObjectElement.

Tests: svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by build-fix karma
beidson@apple.com [Sat, 1 Mar 2008 02:15:04 +0000 (02:15 +0000)]
    Reviewed by build-fix karma

        Bonehead mistake.  Revert function to previous version for all non-Windows+CFNetwork platforms

        * platform/network/ProtectionSpace.cpp:
        (WebCore::ProtectionSpace::receivesCredentialSecurely): Make my previous change conditionally

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate Tiger version of WebKitSystemInterface to match r30690.
mrowe@apple.com [Sat, 1 Mar 2008 02:01:57 +0000 (02:01 +0000)]
Update Tiger version of WebKitSystemInterface to match r30690.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark.
adele@apple.com [Sat, 1 Mar 2008 01:56:30 +0000 (01:56 +0000)]
    Reviewed by Mark.

        Auto-generate image arrays.

        * libWebKitSystemInterfaceLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin
beidson@apple.com [Sat, 1 Mar 2008 01:50:32 +0000 (01:50 +0000)]
    Reviewed by Darin

        <rdar://problem/5771227> - Incorrect password handling text in credential sheet

        * platform/network/ProtectionSpace.cpp:
        (WebCore::ProtectionSpace::receivesCredentialSecurely): Call functional CFNetwork method to
          get "secureness" of the auth challenge instead of figuring it out ourselves

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Sam Weinig.
mitz@apple.com [Sat, 1 Mar 2008 01:35:09 +0000 (01:35 +0000)]
    Rubber-stamped by Sam Weinig.

        - update test results following r30649

        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-29 Brent Fulgham <bfulgham@gmail.com>
pewtermoose@webkit.org [Sat, 1 Mar 2008 00:29:22 +0000 (00:29 +0000)]
2008-02-29  Brent Fulgham  <bfulgham@gmail.com>

        Implement scrollbars on Windows (Cairo)

        Reviewed by Adam Roben.

        * wtf/Platform.h:


        Implement scrollbars on Windows (Cairo)

        Reviewed by Adam Roben.

        * platform/win/PlatfromScrollBarWin.cpp: Duplicate implementation
          from PlatformScrollBarWinSafari.cpp, then modify to use the
          native Windows theme engine.  Use SOFT_LINK.  Use platform
          'GetSystemMetrics' call to decide size of scrollbars and buttons.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Delete an unused file
aroben@apple.com [Sat, 1 Mar 2008 00:14:22 +0000 (00:14 +0000)]
    Delete an unused file

        Rubberstamped by Brady.

        * Interfaces/IWebScriptScope.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Change WebPreferences to be backed by CFPreferences
aroben@apple.com [Sat, 1 Mar 2008 00:14:04 +0000 (00:14 +0000)]
    Change WebPreferences to be backed by CFPreferences

        Reviewed by Ada, Geoff, Steve, and Darin.

        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::sharedStandardPreferences): Changed to call
        setAutoSaves(TRUE) before calling load(). This ensures that the
        preferences being migrated to CFPreferences are saved to disk.
        (WebPreferences::valueForKey): Changed to return a RetainPtr to ensure
        that the refcount is managed properly. Now attempts to retrieve a
        value from CFPreferences before falling back to the default settings.
        (WebPreferences::setValueForKey): Now saves the value in
        CFPreferences if m_autoSaves is true.
        (WebPreferences::stringValueForKey): Updated for valueForKey changes.
        (WebPreferences::integerValueForKey): DItto.
        (WebPreferences::boolValueForKey): Ditto.
        (WebPreferences::floatValueForKey): Ditto.
        (WebPreferences::save): Now simply calls CFPreferencesAppSynchronize.
        (WebPreferences::load): Always initializes m_privatePrefs to an empty
        (WebPreferences::migrateWebKitPreferencesToCFPreferences): Migrates
        preferences from our old custom plist to CFPreferences and then
        deletes our custom plist, if the migration has never occurred before.
        (WebPreferences::copyWebKitPreferencesToCFPreferences): Copies
        preferences to CFPreferences. If we've never migrated the default
        settings from Safari 3 Beta before, we omit them from this copying
        * WebPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Refactor value <-> CFNumber conversions into some helper functions
aroben@apple.com [Sat, 1 Mar 2008 00:13:46 +0000 (00:13 +0000)]
    Refactor value <-> CFNumber conversions into some helper functions

        Reviewed by Jon.

        * WebPreferences.cpp:
        (preferencesPath): Changed to return a const String&.
        (numberValueForPreferencesValue): Converts a value from preferences to
        a native numeric type.
        (cfNumber): Converts a native numeric value to a CFNumberRef.
        (booleanValueForPreferencesValue): Converts a value from preferences
        to a native boolean.
        (WebPreferences::integerValueForKey): Changed to call
        (WebPreferences::floatValueForKey): Ditto.
        (WebPreferences::boolValueForKey): Changed to call
        (WebPreferences::setIntegerValue): Changed to call cfNumber.
        (WebPreferences::setLongLongValue): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add WebPreferences::setValueForKey
aroben@apple.com [Sat, 1 Mar 2008 00:13:29 +0000 (00:13 +0000)]
    Add WebPreferences::setValueForKey

        This is just a small refactoring of some duplicated logic into a
        shared method.

        Reviewed by Sam.

        * WebPreferences.cpp:
        (WebPreferences::setValueForKey): Added.
        (WebPreferences::setStringValue): Call setValueForKey.
        (WebPreferences::setIntegerValue): Ditto.
        (WebPreferences::setBoolValue): Ditto.
        (WebPreferences::setLongLongValue): Ditto.
        * WebPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Remove WebPreferences' static members
aroben@apple.com [Sat, 1 Mar 2008 00:13:10 +0000 (00:13 +0000)]
    Remove WebPreferences' static members

        s_defaultSettings is now a file-level static, and
        s_standardPreferences has been removed completely (it wasn't being

        Reviewed by Sam.

        * WebPreferences.cpp:
        * WebPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix
aroben@apple.com [Sat, 1 Mar 2008 00:09:50 +0000 (00:09 +0000)]
    Windows build fix

        * WebCore.vcproj/WebCore.vcproj: Remove bridge/* from the include path
        and the post-build event, and add page/win to each. Also let VS have
        its way with the order of the files.
        * page/win/PageWin.cpp: Copied from bridge/win/PageWin.cpp in r30673
        * page/win/GlobalHistoryWin.cpp: Copied from
        bridge/win/GlobalHistoryWin.cpp in r30673

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Remove unused DebuggerImp::abort and DebuggerImp::aborted
aroben@apple.com [Fri, 29 Feb 2008 23:48:42 +0000 (23:48 +0000)]
    Remove unused DebuggerImp::abort and DebuggerImp::aborted

        Reviewed by Tim and Sam.

        * kjs/function_object.cpp:
        * kjs/internal.h:
        * kjs/nodes.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
andersca@apple.com [Fri, 29 Feb 2008 23:45:39 +0000 (23:45 +0000)]
    Build fix.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by David Harrison.
ggaren@apple.com [Fri, 29 Feb 2008 23:08:42 +0000 (23:08 +0000)]
    Reviewed by David Harrison.

        Fixed <rdar://problem/5765063> TOT REGRESSION: Software Update crash in
        KJS::Collector::collect() (missing JSLock)

        * JSValueWrapper.cpp:
        (unprotectGlobalObject): Added missing JSLock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 22:47:54 +0000 (22:47 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        64-bit build fix.

        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::pathFromFont): Provide stub implementation of pathFromFont for 64-bit as
        FMGetATSFontRefFromFont is not available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix. Only declare pathFromFont in debug builds as it is unused in release...
mrowe@apple.com [Fri, 29 Feb 2008 22:27:56 +0000 (22:27 +0000)]
Build fix.  Only declare pathFromFont in debug builds as it is unused in release builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
andersca@apple.com [Fri, 29 Feb 2008 22:19:57 +0000 (22:19 +0000)]
    Reviewed by Adam.

        Copy the remaining files in bridge/ over to page/

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bridge: Removed.
        * bridge/AXObjectCache.h: Removed.
        * bridge/EditorClient.h: Removed.
        * bridge/GlobalHistory.h: Removed.
        * bridge/win: Removed.
        * bridge/win/FrameCGWin.cpp: Removed.
        * bridge/win/FrameCairoWin.cpp: Removed.
        * bridge/win/FrameWin.cpp: Removed.
        * bridge/win/FrameWin.h: Removed.
        * bridge/win/GlobalHistoryWin.cpp: Removed.
        * bridge/win/PageWin.cpp: Removed.
        * page/AXObjectCache.h: Copied from bridge/AXObjectCache.h.
        * page/EditorClient.h: Copied from bridge/EditorClient.h.
        * page/GlobalHistory.h: Copied from bridge/GlobalHistory.h.
        * page/win/FrameCGWin.cpp: Copied from bridge/win/FrameCGWin.cpp.
        * page/win/FrameCairoWin.cpp: Copied from bridge/win/FrameCairoWin.cpp.
        * page/win/FrameWin.cpp: Copied from bridge/win/FrameWin.cpp.
        * page/win/FrameWin.h: Copied from bridge/win/FrameWin.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-29 Robert Blaut <webkit@blaut.biz>
mrowe@apple.com [Fri, 29 Feb 2008 22:10:54 +0000 (22:10 +0000)]
2008-02-29  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17532
          Webkit imports styles from <link> element which doesn't have rel=stylesheet defined

        Test: fast/html/link-rel-stylesheet.html

        * html/HTMLLinkElement.cpp:

2008-02-29  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin Adler.

        - Tests for http://bugs.webkit.org/show_bug.cgi?id=17532
          Webkit imports styles from <link> element which doesn't have rel=stylesheet defined

        * fast/html/link-rel-stylesheet.html: Added.
        * fast/media/mq-simple-query-02.html:
        * fast/media/mq-width-absolute-02.html:
        * platform/mac/fast/html/link-rel-stylesheet-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 22:06:56 +0000 (22:06 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders Carlsson.

        Replace use of WKPathFromFont with implementation in terms of public API.

        * WebCore.base.exp: Remove unused symbol.
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::pathFromFont): Implement pathFromFont in terms of public API.
        * platform/mac/WebCoreSystemInterface.h: Remove unused symbol.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders Carlsson.

        Replace use of WKPathFromFont with implementation in terms of public API.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Remove unused symbol.

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders Carlsson.

        Replace use of WKPathFromFont with implementation in terms of public API.

        * WebKitSystemInterface.h:  Remove unused symbol.
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
andersca@apple.com [Fri, 29 Feb 2008 21:56:06 +0000 (21:56 +0000)]
    Reviewed by Adam.

        Move a bunch of files from bridge/mac to page/mac.

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac: Removed.
        * bridge/mac/AXObjectCacheMac.mm: Removed.
        * bridge/mac/GlobalHistoryMac.mm: Removed.
        * bridge/mac/WebCoreAXObject.h: Removed.
        * bridge/mac/WebCoreAXObject.mm: Removed.
        * bridge/mac/WebCoreScriptDebugger.h: Removed.
        * bridge/mac/WebCoreScriptDebugger.mm: Removed.
        * page/mac/AXObjectCacheMac.mm: Copied from bridge/mac/AXObjectCacheMac.mm.
        * page/mac/GlobalHistoryMac.mm: Copied from bridge/mac/GlobalHistoryMac.mm.
        * page/mac/WebCoreAXObject.h: Copied from bridge/mac/WebCoreAXObject.h.
        * page/mac/WebCoreAXObject.mm: Copied from bridge/mac/WebCoreAXObject.mm.
        * page/mac/WebCoreScriptDebugger.h: Copied from bridge/mac/WebCoreScriptDebugger.h.
        * page/mac/WebCoreScriptDebugger.mm: Copied from bridge/mac/WebCoreScriptDebugger.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for http://bugs.webkit.org/show_bug.cgi?id=17559, media query tests crash...
hyatt@apple.com [Fri, 29 Feb 2008 21:14:25 +0000 (21:14 +0000)]
    Fix for bugs.webkit.org/show_bug.cgi?id=17559, media query tests crashing under
        guard malloc.  Pass along the style selector so it can be accessed, since it has not yet
        been assigned into the document's member variable.

        Reviewed by aroben

        * css/CSSStyleSelector.cpp:
        * css/MediaQueryEvaluator.cpp:
        * css/MediaQueryEvaluator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Don't free the VARIANT passed into Write, since it is an input parameter...
sfalken@apple.com [Fri, 29 Feb 2008 20:55:03 +0000 (20:55 +0000)]
    Don't free the VARIANT passed into Write, since it is an input parameter owned by the caller.
        Found via code inspection.

        Reviewed by Adam.

        * WebActionPropertyBag.cpp:
        * WebElementPropertyBag.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Pass the correct configuration switch (--Debug|--Release) to build-testkjs.
ddkilzer@apple.com [Fri, 29 Feb 2008 19:11:22 +0000 (19:11 +0000)]
    Pass the correct configuration switch (--Debug|--Release) to build-testkjs.

        Reviewed by Dan.

        Originally broken in r26838.

        * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
        not local, unused @args variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5755916> REGRESSION: Loading HTML5 spec is 5x slower on TOT...
hyatt@apple.com [Fri, 29 Feb 2008 18:58:06 +0000 (18:58 +0000)]
    <rdar://problem/5755916> REGRESSION: Loading HTML5 spec is 5x slower on TOT than in 3.0.4

        Improve the performance of dynamic sibling and CSS3 selectors so that there is no slowdown any more.
        Be more precise in terms of what nodes we mark dirty.

        Reviewed by Beth

        * css/CSSStyleSelector.cpp:
        * dom/Element.cpp:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Bug 15754: webarchive layout tests fail when WebKit directory path contains...
ddkilzer@apple.com [Fri, 29 Feb 2008 18:22:15 +0000 (18:22 +0000)]
    Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks


        Reviewed by Geoff and Darin.

        We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
        then removing that path from all file:/// URLs in the WebArchive output so these tests
        would pass no matter where they were run.

        The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
        current working directory, but the WebArchive does not.  This left the current working
        directory in all file:/// URLs in the test output, and thus all tests failed, for any
        developer that used symlinks to get to their WebKit source directory.

        The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
        remove the current working directory path (no matter what it is) after "file://" but
        before "/LayoutTests/".

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
        current working directory as described above.
        (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
        calls to normalizeWebResourceURL().
        (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
        normalizeWebResourceURL() and convertWebResourceResponseToDictionary().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Fri, 29 Feb 2008 17:58:00 +0000 (17:58 +0000)]
    Reviewed by Darin.

        <rdar://problem/5766352> REGRESSION (r27151): XMLHttpRequest.abort() resets response status

        Test: http/tests/xmlhttprequest/status-after-abort.html

        * xml/XMLHttpRequest.cpp:
        Changed to match Firefox more closely (IE just raises an exception in most of those cases).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Fri, 29 Feb 2008 17:28:13 +0000 (17:28 +0000)]

        Reviewed by Darin Adler.

        - fix a bug where explicit embedding past the end of a line could
          affect text that line

        Test: fast/text/embed-at-end-of-pre-wrap-line.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::skipWhitespace): Removed calls to
        (WebCore::RenderBlock::findNextLineBreak): Added calls to
        setAdjustEmbedding() around skipWhitespace() only where needed.


        Reviewed by Darin Adler.

        - test for a bug where explicit embedding past the end of a line could
          affect text that line

        * fast/text/embed-at-end-of-pre-wrap-line.html: Added.
        * platform/mac-leopard/fast/text/embed-at-end-of-pre-wrap-line-expected.checksum: Added.
        * platform/mac-leopard/fast/text/embed-at-end-of-pre-wrap-line-expected.png: Added.
        * platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 11:26:10 +0000 (11:26 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.

        * Misc/WebNSURLExtras.mm:
        (-[NSURL _webkit_canonicalize]):
        * WebKit.order:

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 11:25:55 +0000 (11:25 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.

        * platform/mac/WebCoreSystemInterface.h: Don't declare WKSupportsMultipartXMixedReplace on Leopard.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.
        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't call WKSupportsMultipartXMixedReplace on Leopard.
        * WebCore.Tiger.exp: Move Tiger-only symbol here.
        * WebCore.base.exp:

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.

        * WebCoreSupport/WebSystemInterface.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 11:25:31 +0000 (11:25 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.

        * Misc/WebNSViewExtras.m:  Remove _web_superviewOfClass:stoppingAtClass:.
        * Misc/WebNSWindowExtras.m:  Remove _webkit_displayThrottledWindows.
        * Misc/WebSearchableTextView.m:  Remove selectionImageForcingWhiteText:.
        * WebCoreSupport/WebImageRendererFactory.m:  Update comment to mention the last version of Safari that
        requires this class.
        * WebInspector/WebInspector.mm:  Remove sharedWebInspector and update comments to mention the last version
        of Safari that calls other obsolete methods.
        * WebView/WebDocumentPrivate.h:  Remove selectionImageForcingWhiteText:.
        * WebView/WebHTMLView.mm:  Ditto.
        * WebView/WebPDFView.mm:  Ditto.
        * WebView/WebView.mm:  Update comment to mentoin the last version of Safari that requires the obsolete method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 09:23:24 +0000 (09:23 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Eric Seidel.

        Remove unneeded includes of WebCoreSystemInterface.h.

        * loader/mac/LoaderNSURLExtras.m:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.mm:
        * platform/MIMETypeRegistry.cpp:
        * platform/graphics/mac/ImageMac.mm:
        * platform/mac/PasteboardMac.mm:

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Eric Seidel.

        Remove unneeded includes of WebKitSystemInterface.h.

        * History/WebHistoryItem.mm:
        * Misc/WebNSViewExtras.m:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebDataSource.mm:
        * WebView/WebPDFView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 09:05:03 +0000 (09:05 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt and Oliver Hunt.

        <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.

        * platform/mac/SystemTimeMac.cpp:  Replace use of WKSecondsSinceLastInputEvent with CGEventSourceSecondsSinceLastEventType.
        * platform/mac/WebCoreSystemInterface.h:  Remove unused symbol.
        * platform/mac/WebCoreSystemInterface.mm:  Ditto.
        * WebCore.base.exp:  Ditto.

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt and Oliver Hunt.

        <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):  Remove unused symbol.
        * WebKit.order:  Ditto.

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt and Oliver Hunt.

        <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.

        * WebKitSystemInterface.h:  Remove unused symbol.
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-28 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 07:54:45 +0000 (07:54 +0000)]
2008-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Remove two unused functions from WebKitSystemInterface.

        * WebKitSystemInterface.h:  Remove WKPreferRGB32Key and WKGetDefaultGlyphForChar as they are unused. Also remove
        a duplicate declaration of WKSecondsSinceLastInputEvent.
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-28 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 06:19:22 +0000 (06:19 +0000)]
2008-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dave Hyatt.

        Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

        * DerivedSources.make:  Add Tiger-only symbols to the export file when running on Tiger.
        * WebCore.Tiger.exp:  Added.  Move Tiger-only symbol here from WebCore.base.exp.
        * WebCore.base.exp:
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit):  Use Leopard APIs when building on Leopard.
        * platform/mac/WebCoreSystemInterface.h:  Don't declare wkGetFontMetrics on Leopard as it is unused.
        * platform/mac/WebCoreSystemInterface.mm:  Ditto.

2008-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dave Hyatt.

        Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

        * WebKitSystemInterface.h:  Only declare WKGetFontMetrics on Tiger.
        * libWebKitSystemInterfaceLeopard.a:  Update for removal of WKGetFontMetrics.

2008-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dave Hyatt.

        Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
pewtermoose@webkit.org [Thu, 28 Feb 2008 23:11:49 +0000 (23:11 +0000)]
    Reviewed by Tim Hatcher.

        Bug 16535: Stylesheets loaded with @import are not editable

        Sheets loaded using @import were incorrectly being flagged as non-editable
        user agent sheets because their parent sheet doesn't have an ownerNode. We now
        check to make sure sheets also don't have a href before restricting their editability.

        * page/inspector/StylesSidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoffrey Garen.
ggaren@apple.com [Thu, 28 Feb 2008 22:16:46 +0000 (22:16 +0000)]
    Reviewed by Geoffrey Garen.

        ** TOTAL **:          1.005x as fast    2867.6ms +/- 0.4%  2853.2ms +/- 0.3%    significant

        * kjs/nodes.cpp: Tell the compiler that exceptions are unexpected (for
        the sake of branch prediction and code organization).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-28 Rodney Dawes <dobey@wayofthemonkey.com>
pewtermoose@webkit.org [Thu, 28 Feb 2008 20:46:37 +0000 (20:46 +0000)]
2008-02-28  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Adam Roben.

        Copy PluginPackageWin.cpp to shared PluginPackage.cpp.
        Add PluginPackage.cpp to build configurations.
        Remove PluginPackage destructor from TemporaryLinkStubs.cpp.
        Use cross-platform pathGetFilename method.
        Remove platform-specific code from shared PluginPackage implementation.
        Remove shared code from PluginPackageWin.cpp.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCoreSources.bkl:
        * WebCore.vcproj/WebCore.vcproj:
        * platform/gtk/TemporaryLinkStubs.cpp:
        * platform/qt/TemporaryLinkStubs.cpp:
        * platform/wx/TemporaryLinkStubs.cpp:
        * plugins/PluginPackage.cpp:
        * plugins/win/PluginPackageWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justin.garcia@apple.com [Thu, 28 Feb 2008 20:42:27 +0000 (20:42 +0000)]

        Reviewed by Darin Adler.

        <rdar://problem/4930986> REGRESSION: Paste As Quotation pastes black text instead of blue

        Add a second style span at copy time to hold document default styles.  This helps us
        differentiate between those and user applied styles at paste time, where we'll want
        to let Mail's Paste As Quotation blockquote override document default styles, but
        not others.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed the unit type used
        for -webkit-text-stroke-width from CSS_NUMBER to CSS_PX, to match other properties that
        are thick | medium | thin | <length>.  Before, there was a mismatch between the unit
        type of -webkit-text-stroke-width property values in a CSSComputedStyleDeclaration for
        an element and that element's inlineStyleDecl(), causing identical values to always appear
        different to diff().
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Fixed.  Don't just change
        the class to an empty string, completely remove it, it's no longer needed.
        (WebCore::handleStyleSpansBeforeInsertion): Moved the optimization from doApply here.
        Added, replaces removeRedundantStyles.
        We aren't (yet) removing all redundant styles, just those on style spans, so I removed the
        unused code and renamed the function.
        There won't be more than two style spans that we need to consider, the one with the
        source document's default styles and styles on the commonAncestor of the copied Range,
        so don't look for more than two.
        Let elements that wrap the incoming fragment override the source document's styles.
        (WebCore::ReplaceSelectionCommand::doApply): Moved code to handleStyleSpansBeforeInsertion
        and call the renamed handleStyleSpans.
        * editing/ReplaceSelectionCommand.h:
        * editing/markup.cpp:
        (WebCore::removeDefaultStyles): Added.  Don't add document defaults to the style span
        that holds user applied styles, since they'll be added to their own style span.
        Add a second style span that holds just the document defaults. This lets us differentiate
        between those and user applied styles at paste time.
        Mail blockquotes are just another type of special element, moved their handling there. This
        also lets paste code make assumptions about the position of the two style spans (they are
        *always* parent-child).


        Reviewed by Darin Adler.

        <rdar://problem/4930986> REGRESSION: Paste As Quotation pastes black text instead of blue

        Demonstrates the bug:
        * editing/pasteboard/4930986-1-expected.txt: Added.
        * editing/pasteboard/4930986-1.html: Added.
        * editing/pasteboard/4930986-2-expected.txt: Added.
        * editing/pasteboard/4930986-2.html: Added.

        Demonstrates a problem with the first version of the patch:
        * editing/pasteboard/4930986-3-expected.txt: Added.
        * editing/pasteboard/4930986-3.html: Added.

        Visual problem fixed.  An anonymous renderer changed position, DOM remains unchanged:
        * editing/execCommand/5144139-1.html:
        * platform/mac/editing/execCommand/5144139-1-expected.checksum:
        * platform/mac/editing/execCommand/5144139-1-expected.png:
        * platform/mac/editing/execCommand/5144139-1-expected.txt:

        Removed unnecessary style spans, visual result unchanged:
        * platform/mac/editing/pasteboard/merge-end-blockquote-expected.checksum:
        * platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
        * platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
        * platform/mac/editing/style/font-family-with-space-expected.checksum:
        * platform/mac/editing/style/font-family-with-space-expected.png:
        * platform/mac/editing/style/font-family-with-space-expected.txt:

        A style span isn't removed because at paste time because we don't anticipate
        encountering styles on style spans that are non-inheritable, because we don't
        create style spans like that at copy time. Turned this into a text only
        test. Test remains visually unchanged:
        * editing/pasteboard/5245519-expected.txt: Added.
        * editing/pasteboard/5245519.html:
        * platform/mac/editing/pasteboard/5245519-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/5245519-expected.png: Removed.
        * platform/mac/editing/pasteboard/5245519-expected.txt: Removed.

        Added an extra empty anonymous renderer, DOM and visual result remain unchanged:
        * platform/mac/editing/execCommand/create-list-with-hr-expected.checksum:
        * platform/mac/editing/execCommand/create-list-with-hr-expected.png:
        * platform/mac/editing/execCommand/create-list-with-hr-expected.txt:
        * platform/mac/editing/pasteboard/paste-list-001-expected.checksum:
        * platform/mac/editing/pasteboard/paste-list-001-expected.png:
        * platform/mac/editing/pasteboard/paste-list-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-table-001-expected.checksum:
        * platform/mac/editing/pasteboard/paste-table-001-expected.png:
        * platform/mac/editing/pasteboard/paste-table-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-003-expected.checksum:
        * platform/mac/editing/pasteboard/paste-text-003-expected.png:
        * platform/mac/editing/pasteboard/paste-text-003-expected.txt:

        Reflects changes to CSSComputedStyleDeclaration::getPropertyCSSValue:
        * fast/css/computed-style-expected.txt:
        * fast/css/computed-style-without-renderer-expected.txt:

        We don't remove styles from style spans that are overridden by all of their
        children, even though they are unnecessary. We've never done this, but now
        that there can be two style spans at paste time we are more likely to have
        a style span left over because of this problem.  Mentioned this in the test
        case and turned this into a text only test:
        * editing/pasteboard/4840662.html:
        * editing/pasteboard/4840662-expected.txt: Added.
        * platform/mac/editing/pasteboard/4840662-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/4840662-expected.png: Removed.
        * platform/mac/editing/pasteboard/4840662-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-28 Brent Fulgham <bfulgham@gmail.com>
pewtermoose@webkit.org [Thu, 28 Feb 2008 20:24:02 +0000 (20:24 +0000)]
2008-02-28  Brent Fulgham <bfulgham@gmail.com>

        Modify RenderThemeWin to use SOFT_LINK

        Reviewed by Adam Roben.

        * rendering/RenderThemeWin.h: Remove unneeded library handle
        * rendering/RenderThemeWin.cpp: Change to use SOFT_LINK
          rather than hand-coded load library calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
mitz@apple.com [Thu, 28 Feb 2008 18:19:59 +0000 (18:19 +0000)]
    Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17590
          ASSERTION FAILED: subject in jsRegExpExecute()

        * page/mac/FrameMac.mm:
        (WebCore::Frame::matchLabelsAgainstElement): Added an early return in
        case the element name is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Dan Bernstein
justin.garcia@apple.com [Thu, 28 Feb 2008 09:26:48 +0000 (09:26 +0000)]
    Reviewed by Dan Bernstein

        Small editing speed up.

        * dom/Position.cpp:
        (WebCore::Position::upstream): Don't check for a change in editability
        if the current node hasn't changed.
        (WebCore::Position::downstream): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-28 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 28 Feb 2008 08:21:59 +0000 (08:21 +0000)]
2008-02-28  Alp Toker  <alp@atoker.com>

        Fix a configure script typo spotted by Kalle Vahlman.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Thu, 28 Feb 2008 05:38:52 +0000 (05:38 +0000)]

        Reviewed by John Sullivan.

        - fix <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear

        Test: fast/text/soft-hyphen-2.html

        * rendering/bidi.cpp:
        (WebCore::chopMidpointsAt): Changed to iterate midpoints backwards, so
        that if there are two midpoints at the given position, only the last one
        will be chopped off.


        Reviewed by John Sullivan.

        - test for <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear

        * fast/text/soft-hyphen-2.html: Added.
        * platform/mac/fast/text/soft-hyphen-2-expected.checksum: Added.
        * platform/mac/fast/text/soft-hyphen-2-expected.png: Added.
        * platform/mac/fast/text/soft-hyphen-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Updated resource used in the layout test I landed yesterday.
beidson@apple.com [Thu, 28 Feb 2008 02:52:30 +0000 (02:52 +0000)]
    Updated resource used in the layout test I landed yesterday.
        Due to a difference between Foundation on Tiger vs Leopard, the resource generated on
        Leopard caused different results on Leopard and Tiger.
        Regenerating the resource on Tiger, however, agrees with Leopard.

        * webarchive/loading/resources/cache-expired-subresource.webarchive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Thu, 28 Feb 2008 02:23:22 +0000 (02:23 +0000)]

        Reviewed by Darin Adler.

        - make centered text in right-to-left blocks spill over to the left

        Test: fast/text/align-center-rtl-spill.html

        * rendering/bidi.cpp:


        Reviewed by Darin Adler.

        - test that centered text in right-to-left blocks spills over to the left

        * fast/text/align-center-rtl-spill.html: Added.
        * platform/mac/fast/text/align-center-rtl-spill-expected.checksum: Added.
        * platform/mac/fast/text/align-center-rtl-spill-expected.png: Added.
        * platform/mac/fast/text/align-center-rtl-spill-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Tiger build fix
beidson@apple.com [Thu, 28 Feb 2008 01:40:37 +0000 (01:40 +0000)]
    Tiger build fix

        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
mitz@apple.com [Thu, 28 Feb 2008 01:06:41 +0000 (01:06 +0000)]
    Reviewed by Darin Adler.

        - more bidi.cpp cleanup

        * platform/text/BidiResolver.h:
        (WebCore::BidiCharacterRun::destroy): Added. Overridden by BidiRun .
        (WebCore::BidiResolver<Iterator, Run>::addRun): Moved BidiState::addRun()
        (WebCore::BidiResolver<Iterator, Run>::appendRun): Changed to use
        (WebCore::BidiResolver<Iterator, Run>::deleteRuns): Changed to use
        destroy(), avoiding the need to specialize this method in BidiState.
        * rendering/bidi.cpp:
        (WebCore::BidiRun::destroy): Removed the RenderArena parameter.
        (WebCore::BidiState::deleteRuns): Removed now-unnecessary specialization.
        (WebCore::BidiState::addRun): Removed now-unnecessary specialization.
        (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added a FIXME.
        * rendering/bidi.h:
        (WebCore::BidiRun): Added m_ prefixes to several member variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe
beidson@apple.com [Thu, 28 Feb 2008 00:42:34 +0000 (00:42 +0000)]
    Reviewed by Mark Rowe

        Removed some unused methods:

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Adam.
eric@webkit.org [Thu, 28 Feb 2008 00:20:00 +0000 (00:20 +0000)]
    Rubber-stamped by Adam.

        Fix svn:eol-style on all LayoutTest results
        I simply ran:
        cd LayoutTests
        find . -name "*-expected.txt" | xargs svn ps svn:eol-style native

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig@apple.com [Wed, 27 Feb 2008 23:59:54 +0000 (23:59 +0000)]

        Reviewed by Darin.

        Fix for <rdar://problem/5768769>

        - Don't allow cross-origin calls using window.functionName.call(otherFrame)

        * bindings/js/JSLocation.cpp:
        (WebCore::jsLocationProtoFuncToString): Do same-origin check.
        * bindings/js/kjs_window.cpp:
        (KJS::windowProtoFuncAToB): Ditto.
        (KJS::windowProtoFuncBToA): Ditto.
        (KJS::windowProtoFuncOpen): Ditto.
        (KJS::windowProtoFuncClearTimeout): Ditto.
        * bindings/scripts/CodeGeneratorJS.pm: Ditto.


        Reviewed by Darin.

        Updates tests for <rdar://problem/5768769>

        * http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
        * http/tests/security/cross-frame-access-call-expected.txt:
        * http/tests/security/cross-frame-access-call.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago More cleanup in preparation for fixing the HTML5 spec performance regression.
hyatt@apple.com [Wed, 27 Feb 2008 23:13:51 +0000 (23:13 +0000)]
    More cleanup in preparation for fixing the HTML5 spec performance regression.

        Reviewed by Sam Weinig

        * dom/Attr.cpp:
        * dom/Attr.h:
        * dom/ContainerNode.cpp:
        * dom/ContainerNode.h:
        * dom/Document.cpp:
        * dom/Document.h:
        * dom/Element.cpp:
        * dom/Element.h:
        * dom/Node.h:
        * html/HTMLObjectElement.cpp:
        * html/HTMLObjectElement.h:
        * html/HTMLOptGroupElement.cpp:
        * html/HTMLOptGroupElement.h:
        * html/HTMLOptionElement.cpp:
        * html/HTMLOptionElement.h:
        * html/HTMLScriptElement.cpp:
        * html/HTMLScriptElement.h:
        * html/HTMLSelectElement.cpp:
        * html/HTMLSelectElement.h:
        * html/HTMLStyleElement.cpp:
        * html/HTMLStyleElement.h:
        * html/HTMLTextAreaElement.cpp:
        * html/HTMLTextAreaElement.h:
        * html/HTMLTitleElement.cpp:
        * html/HTMLTitleElement.h:
        * svg/SVGClipPathElement.cpp:
        * svg/SVGClipPathElement.h:
        * svg/SVGDefinitionSrcElement.cpp:
        * svg/SVGDefinitionSrcElement.h:
        * svg/SVGFontFaceElement.cpp:
        * svg/SVGFontFaceElement.h:
        * svg/SVGFontFaceFormatElement.cpp:
        * svg/SVGFontFaceFormatElement.h:
        * svg/SVGFontFaceSrcElement.cpp:
        * svg/SVGFontFaceSrcElement.h:
        * svg/SVGFontFaceUriElement.cpp:
        * svg/SVGFontFaceUriElement.h:
        * svg/SVGGElement.cpp:
        * svg/SVGGElement.h:
        * svg/SVGGradientElement.cpp:
        * svg/SVGGradientElement.h:
        * svg/SVGMarkerElement.cpp:
        * svg/SVGMarkerElement.h:
        * svg/SVGMaskElement.cpp:
        * svg/SVGMaskElement.h:
        * svg/SVGPatternElement.cpp:
        * svg/SVGPatternElement.h:
        * svg/SVGStyleElement.cpp:
        * svg/SVGStyleElement.h:
        * svg/SVGStyledElement.cpp:
        * svg/SVGStyledElement.h:
        * svg/SVGTitleElement.cpp:
        * svg/SVGTitleElement.h:
        * svg/SVGUseElement.cpp:
        * svg/SVGUseElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKit/mac:
beidson@apple.com [Wed, 27 Feb 2008 23:09:00 +0000 (23:09 +0000)]

        Reviewed by Mark Rowe (code) and Darin (concept)

        Much better fix for <rdar://problem/4930688> (see r19549)
        Original fix for <rdar://problem/3947312> (and 14 dupes)

        Let me tell you a story:
        A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
        WebArchive code was intertwined with that code in bizarre and complex ways.
        During the months long loader re-factoring where we pushed much loader code down into WebCore,
        many portions of the WebKit loader were thinned out until they ceased to exist.  Others remained
        with a sole purpose.

        One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
        to WebLoader was originally rooted in the method [WebLoader loadRequest:].  This method was the
        single entry point for almost all loading (network or web archives)

        This method would check various headers and other fields on the NSURLRequest and NSURLResponse
        to make decisions about the load.  If the cache control fields were expired or other conditions
        in the headers were met, the load would be forced to go out to the network.

        As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
        At some point, all that remained was the special cases for loading WebArchives.

        Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
        to be WebArchive specific, further cementing the assumed design.

        Problem is, the design was bad.  A WebArchive is meant to be a static snapshot of a WebPage at a
        specific point in time.  Referring to the request to see if the resource should be reloaded seems
        nonsensical, as does referring to the response headers to see if the resource is "expired".  In the
        context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
        during the initial load!

        After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
        cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
        that were all symptoms of this bug, and easy to verify that they are fixed with this patch.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that
          inspect the request or response objects - We are loading from a WebArchive, and we should never
          make the decision to go out to the network when we actually have the resource available.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):  Remove two methods that are no longer used anywhere in WebKit


        Reviewed by Mark Rowe

        Test for better fix for <rdar://problem/4930688> (see r19549) and
        original fix for <rdar://problem/3947312> (and 14 dupes)

        Crafting custom WebArchives for layout tests is a pain and something that should
        be resolved if we decide to pursue a new format.

        Using a custom php script to act as a stand in for an image resource, I set its
        cache-control header to expire immediately.  Without the fix for the above bugs,
        the resource will be "expired" and an attempt to fetch it from the network will
        go out and fail.  This failure will manifest with different ResourceLoadDelegate
        information, as well as different dimensions in the render tree - the missing
        image icon versus the archived image.

        With the fix in place, the response will be ignored and the image will be pulled
        from the WebArchive.

        * webarchive/loading/cache-expired-subresource-expected.txt: Added.
        * webarchive/loading/cache-expired-subresource.html: Added.
        * webarchive/loading/resources/cache-expired-subresource.webarchive: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKit/mac:
pewtermoose@webkit.org [Wed, 27 Feb 2008 23:07:15 +0000 (23:07 +0000)]

        Reviewed by Adam Roben.

        Bug 14348: Messing up the inspector by dragging an URL into it
        <rdar://problem/5283620> and <rdar://problem/5712808>

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController init]): Remove duplicate preference setting.
        (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):


        Reviewed by Adam Roben.

        Bug 14348: Messing up the inspector by dragging an URL into it
        <rdar://problem/5283620> and <rdar://problem/5712808>

        Add a new class to handle the Inspector's delegate calls.

        * WebCoreSupport/WebInspectorClient.cpp:
        * WebCoreSupport/WebInspectorDelegate.cpp: Added.
        * WebCoreSupport/WebInspectorDelegate.h: Added.
        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Landing test that was forgotten in the original patch (r30087).
kmccullough@apple.com [Wed, 27 Feb 2008 18:06:09 +0000 (18:06 +0000)]
    Landing test that was forgotten in the original patch (r30087).

        Test for: http://bugs.webkit.org/show_bug.cgi?id=17191
        HTML5: Client-side database queries should return values of type number

        * storage/sql-data-types-expected.txt: Added.
        * storage/sql-data-types.html: Added.
        * storage/sql-data-types.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd bug number to ChangeLog.
ap@webkit.org [Wed, 27 Feb 2008 17:52:05 +0000 (17:52 +0000)]
Add bug number to ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-27 Julien Chaffraix <julien.chaffraix@gmail.com>
ap@webkit.org [Wed, 27 Feb 2008 17:46:43 +0000 (17:46 +0000)]
2008-02-27  Julien Chaffraix <julien.chaffraix@gmail.com>

        Reviewed by Alexey.

        Several consecutive calls to XMLHttpRequest::open should dispatch only one readyState event

        Test: http/tests/xmlhttprequest/xmlhttprequest-multiple-open.html

        * xml/XMLHttpRequest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam Weinig.
ap@webkit.org [Wed, 27 Feb 2008 17:13:46 +0000 (17:13 +0000)]
    Reviewed by Sam Weinig.

        Small buffer overflow within initialization

        * kjs/date_object.cpp:
        Remove unnecessary and incorrect memset() calls - GregorianDateTime can initialize itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-27 Sriram Neelakandan <sriram.neelakandan@gmail.com>
ap@webkit.org [Wed, 27 Feb 2008 16:50:19 +0000 (16:50 +0000)]
2008-02-27  Sriram Neelakandan  <sriram.neelakandan@gmail.com>

        Reviewed, tweaked and landed by ap.

        HTMLInput mysteriously fails to work if ICU dat file is missing

        * platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Assert that the iterator
        has been opened.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Attempt to fix the GTK+ build
aroben@apple.com [Wed, 27 Feb 2008 16:38:57 +0000 (16:38 +0000)]
    Attempt to fix the GTK+ build

        * webkit/webkitwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix revision number in ChangeLog
aroben@apple.com [Wed, 27 Feb 2008 16:34:58 +0000 (16:34 +0000)]
Fix revision number in ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix after r30613
aroben@apple.com [Wed, 27 Feb 2008 16:16:02 +0000 (16:16 +0000)]
    Windows build fix after r30613

        * platform/win/ClipboardWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Simon.
zimmermann@webkit.org [Wed, 27 Feb 2008 15:12:23 +0000 (15:12 +0000)]
Reviewed by Simon.

Small style cleanup, and obvious fix: SVGGElement reacted on
'clipPathUnits' changes, which is a funny copy&paste error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Simon.
zimmermann@webkit.org [Wed, 27 Feb 2008 12:38:26 +0000 (12:38 +0000)]
Reviewed by Simon.

Cleanup coding style. Still on my way to fix dynamic updates of all SVG elements.
Currently at SVGF*. SVGDefs/DescElement don't need any dyn update fixes but cleanups.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
antti@apple.com [Wed, 27 Feb 2008 06:14:56 +0000 (06:14 +0000)]
    Reviewed by Darin.

        Fix <rdar://problem/5761326>
        REGRESSION: 1.5% -2% Sunspider regression from r30009 (ebay photo upload hang)

        Generate better code with VS:
        - Use ALWAYS_INLINE macro to guarantee versions of allowsAccessFrom() are reduced to single functions
        - Refactor error reporting so that there is no need to construct/destruct Strings in common cases
        - Add a separate version of the function for cases where error messages are not wanted

        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Dave Hyatt.
weinig@apple.com [Wed, 27 Feb 2008 04:14:18 +0000 (04:14 +0000)]
    Reviewed by Dave Hyatt.

        - remove DeprecatedCString, DeprecatedArray, and ArrayImpl.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * platform/ArrayImpl.cpp: Removed.
        * platform/ArrayImpl.h: Removed.
        * platform/DeprecatedArray.h: Removed.
        * platform/DeprecatedCString.cpp: Removed.
        * platform/DeprecatedCString.h: Removed.
        * platform/text/CString.cpp:
        * platform/text/CString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Cleanup of childrenChanged in preparation for fixing the HTML5 spec slowdown.
hyatt@apple.com [Wed, 27 Feb 2008 03:12:00 +0000 (03:12 +0000)]
    Cleanup of childrenChanged in preparation for fixing the HTML5 spec slowdown.

        Reviewed by Sam Weinig

        * dom/Attr.cpp:
        * dom/ContainerNode.cpp:
        * dom/ContainerNode.h:
        * dom/EventTargetNode.cpp:
        * dom/EventTargetNode.h:
        * dom/NamedAttrMap.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImprovements to the wx build script.
kevino@webkit.org [Wed, 27 Feb 2008 01:56:38 +0000 (01:56 +0000)]
Improvements to the wx build script.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
darin@apple.com [Wed, 27 Feb 2008 01:43:52 +0000 (01:43 +0000)]
    Reviewed by Sam.

        - remove use of DeprecatedCString from Windows pasteboard code

        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::createGlobalData): Added an overload for Vector<char>.
        Streamlined the logic a bit.
        (WebCore::append): Added. Helper functions for appending to a
        (WebCore::markupToCF_HTML): Rewrote to use Vector<char> instead
        of DeprecatedCString. Also simplified the logic a bit and used
        macros to handle the integer width.
        (WebCore::urlToMarkup): Use Vector<UChar> instead of String.
        (WebCore::replaceNewlinesWithWindowsStyleNewlines): Tweaked.
        * platform/win/ClipboardUtilitiesWin.h: Update type of return
        value from markupToCF_HTML. Did a bit of streamlining too.
        * platform/win/ClipboardWin.cpp:
        (WebCore::writeURL): Update for above changes.
        (WebCore::ClipboardWin::declareAndWriteDragImage): Ditto.
        (WebCore::ClipboardWin::writeRange): Ditto.
        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::writeSelection): Ditto.
        (WebCore::Pasteboard::writeURL): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move ResourceLoadDelegate methods to WebFrameLoaderClient
aroben@apple.com [Wed, 27 Feb 2008 00:51:05 +0000 (00:51 +0000)]
     Move ResourceLoadDelegate methods to WebFrameLoaderClient

         Changed all methods to use early returns where possible and COMPtr's
         AdoptCOM/Query constructors.

         Reviewed by Anders.

         * WebCoreSupport/WebFrameLoaderClient.cpp:
         * WebCoreSupport/WebFrameLoaderClient.h:
         * WebFrame.cpp:
         * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move two more methods to WebFrameLoaderClient
aroben@apple.com [Wed, 27 Feb 2008 00:50:36 +0000 (00:50 +0000)]
     Move two more methods to WebFrameLoaderClient

         Reviewed by Anders.

         * WebCoreSupport/WebFrameLoaderClient.cpp:
         (WebFrameLoaderClient::dispatchCreatePage): Changed nested ifs to
         early returns, and changed to use the COMPtr Query constructor.
         (WebFrameLoaderClient::dispatchDidLoadMainResource): Added an early
         return, and changed to use getWebDataSource.
         * WebCoreSupport/WebFrameLoaderClient.h:
         * WebFrame.cpp:
         * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Get rid of IID_WebFrame
aroben@apple.com [Wed, 27 Feb 2008 00:50:09 +0000 (00:50 +0000)]
     Get rid of IID_WebFrame

         Reviewed by Anders.

         * WebFrame.cpp: Removed IID_WebFrame definition.
         (WebFrame::QueryInterface): Use __uuidof(WebFrame) instead of
         (WebFrame::isDescendantOfFrame): Use COMPtr's Query constructor
         instead of a manual QueryInterface.
         * WebFrame.h: Removed IID_WebFrame declaration, gave WebFrame a

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move WebHistory-related methods to WebFrameLoaderClient
aroben@apple.com [Wed, 27 Feb 2008 00:49:43 +0000 (00:49 +0000)]
     Move WebHistory-related methods to WebFrameLoaderClient

         Reviewed by Anders.

         * WebCoreSupport/WebFrameLoaderClient.cpp:
         (WebFrameLoaderClient::setTitle): Changed some nested ifs into early
         (WebFrameLoaderClient::webHistory): Changed to return a COMPtr to
         make the reference management foolproof.
         * WebCoreSupport/WebFrameLoaderClient.h:
         * WebFrame.cpp:
         * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move cache-related methods to WebFrameLoaderClient
aroben@apple.com [Wed, 27 Feb 2008 00:48:23 +0000 (00:48 +0000)]
     Move cache-related methods to WebFrameLoaderClient

         Reviewed by Anders.

         * WebCoreSupport/WebFrameLoaderClient.cpp:
         (getWebDataSource): Moved to the top of the file.
         * WebCoreSupport/WebFrameLoaderClient.h:
         * WebFrame.cpp:
         * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
timothy@apple.com [Wed, 27 Feb 2008 00:46:16 +0000 (00:46 +0000)]
    Reviewed by Adam Roben.

        <rdar://problem/5712777> REGRESSION: Arrow up/down in inspector
        source list does not scroll when item at edge is reached (16572)

        Use scrollIntoViewIfNeeded() instead of the hand-rolled scrollToElement
        we were using in utilities.js.

        * page/inspector/DocumentPanel.js: Use scrollIntoViewIfNeeded instead of scrollToElement.
        * page/inspector/Resource.js: Ditto.
        * page/inspector/inspector.js: Ditto.
        * page/inspector/SourcePanel.js: Use scrollIntoViewIfNeeded instead
        of scrollIntoView, so the source line is centered in the view if needed.
        * page/inspector/utilities.js: Removed scrollToElement().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add a skipped storage test for now
beidson@apple.com [Tue, 26 Feb 2008 23:47:27 +0000 (23:47 +0000)]
    Add a skipped storage test for now

        * platform/win/Skipped: Added storage/multiple-transactions.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@30605 268f45cc-cd09-0410...
hyatt@apple.com [Tue, 26 Feb 2008 23:17:40 +0000 (23:17 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@30604 268f45cc-cd09-0410...
hyatt@apple.com [Tue, 26 Feb 2008 23:17:16 +0000 (23:17 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Dan
hyatt@apple.com [Tue, 26 Feb 2008 23:17:03 +0000 (23:17 +0000)]
    Reviewed by Dan


        Refine our behavior for empty inlines so that they work more correctly with margins/borders/padding.
        Fixes a regression on huffingtonpost.com.

        New tests added to fast/inline

        * rendering/InlineFlowBox.cpp:
        * rendering/RenderFlow.cpp:
        * rendering/RenderFlow.h:
        * rendering/RenderObject.h:
        * rendering/bidi.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30603 268f45cc-cd09-0410-ab3c-d52691b4dbfc