WebKit-https.git
12 years ago[Qt] Add expected files for new svg tests we pass.
ossy@webkit.org [Fri, 30 Oct 2009 14:13:48 +0000 (14:13 +0000)]
[Qt] Add expected files for new svg tests we pass.
Compared to the Mac expected png files.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-30
Reviewed by Holger Hans Peter Freyther.

* platform/qt/svg/css/arrow-with-shadow-expected.txt: Added.
* platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
* platform/qt/svg/css/clippath-with-shadow-expected.txt: Added.
* platform/qt/svg/css/mask-with-shadow-expected.txt: Added.
* platform/qt/svg/css/path-with-shadow-expected.txt: Added.
* platform/qt/svg/css/stars-with-shadow-expected.txt: Added.
* platform/qt/svg/filters/shadow-on-filter-expected.txt: Added.
* platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
tonikitoo@webkit.org [Fri, 30 Oct 2009 14:02:18 +0000 (14:02 +0000)]
[Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=30953

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-30
Reviewed by Holger Freyther.

DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
makes qt DRT to share this implementation (as gtk and mac ports do).

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/WorkQueue.cpp: Removed.
* DumpRenderTree/qt/WorkQueue.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed potential buildbot fix.
kenneth@webkit.org [Fri, 30 Oct 2009 13:51:56 +0000 (13:51 +0000)]
Unreviewed potential buildbot fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
Second try: Reset page history before running each test.

Apparently the QWebHistory::clear() keeps the current page
in history which is not what we want, so we not additionally
sets the history capacity to 0 (forces removing everything)
and then sets it back to its original value.

* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agochangelog date
yurys@chromium.org [Fri, 30 Oct 2009 13:38:42 +0000 (13:38 +0000)]
changelog date

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIf the owner widget of the page has a palette set, we
kenneth@webkit.org [Fri, 30 Oct 2009 13:29:02 +0000 (13:29 +0000)]
If the owner widget of the page has a palette set, we
should use that one. This was only working when the
owner was a QWebView. This patch fixes that.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
Reviewed by Holger Hans Peter Freyther.

* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::applyTheme):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed potential buildbot fix.
kenneth@webkit.org [Fri, 30 Oct 2009 13:07:34 +0000 (13:07 +0000)]
Unreviewed potential buildbot fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
Reset page history before running each test.

* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-30 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 30 Oct 2009 10:50:24 +0000 (10:50 +0000)]
2009-10-30  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: Wire CookieJarChromium to the cookies
        backend. This is a final step of a 3-steps raw cookies
        access implementation in Chromium.

        * platform/network/chromium/CookieJarChromium.cpp:
        (WebCore::getRawCookies):
        (WebCore::deleteCookie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-30 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 30 Oct 2009 10:32:19 +0000 (10:32 +0000)]
2009-10-30  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Fix Chromium crash in console.log in "deeply recursive" function

        Check that result of 'frameSourceName' is not null handle
        before casting it to String.

        Allow V8Proxy::sourceName/sourceLineNumber() to report
        that they have failed due to JavaScript stack overflow.

        https://bugs.webkit.org/show_bug.cgi?id=30904

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::create):
        (WebCore::ScriptCallStack::ScriptCallStack):
        * bindings/v8/ScriptCallStack.h:
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::sourceLineNumber):
        (WebCore::V8Proxy::sourceName):
        * bindings/v8/V8Proxy.h:
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAllow custom memory allocation control for WebCore's MediaQueryExp
zoltan@webkit.org [Fri, 30 Oct 2009 09:27:28 +0000 (09:27 +0000)]
Allow custom memory allocation control for WebCore's MediaQueryExp
https://bugs.webkit.org/show_bug.cgi?id=30855

Reviewed by Darin Adler.

Inherits MediaQueryExp class from FastAllocBase because it is
instantiated by 'new' in WebCore/css/CSSParser.cpp:4874.

* css/MediaQueryExp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 30 Oct 2009 08:55:56 +0000 (08:55 +0000)]
2009-10-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Mark Rowe.

        Teach git to ignore some files
        https://bugs.webkit.org/show_bug.cgi?id=30951

        Ignore WebKitBuild because we never want to version that directory.
        Also, ignore the xcode project files so git clean doesn't blow away
        your project settings.  Finally, ignore the compiled python files in
        WebKitTools/Script modules because they clutter up git status.

        * .gitignore: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAllow custom memory allocation control for JavaScriptCore's ListHashSet
zoltan@webkit.org [Fri, 30 Oct 2009 08:53:27 +0000 (08:53 +0000)]
Allow custom memory allocation control for JavaScriptCore's ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=30853

Reviewed by Darin Adler.

Inherits ListHashSet class from FastAllocBase because it is
instantiated by 'new' in WebCore/rendering/RenderBlock.cpp:1813.

* wtf/ListHashSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRegression: crash enumerating properties of an object with getters or setters
oliver@apple.com [Fri, 30 Oct 2009 08:13:38 +0000 (08:13 +0000)]
Regression: crash enumerating properties of an object with getters or setters
https://bugs.webkit.org/show_bug.cgi?id=30948

Reviewed by Gavin Barraclough

Add a guard to prevent us trying to cache property enumeration on
objects with getters or setters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCommit patch 1 of ruby implementation, reviewed by Eric Seidel. (see issue 28420)
rolandsteiner@chromium.org [Fri, 30 Oct 2009 07:55:17 +0000 (07:55 +0000)]
Commit patch 1 of ruby implementation, reviewed by Eric Seidel. (see issue 28420)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoved test for an impossible condition (a glyph in a right-to-left run not having
mitz@apple.com [Fri, 30 Oct 2009 07:24:09 +0000 (07:24 +0000)]
Removed test for an impossible condition (a glyph in a right-to-left run not having
the RTL flag 0x800)

Reviewed by Adele Peterson.

* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION (r50218-r50262): E*TRADE accounts page is missing content
oliver@apple.com [Fri, 30 Oct 2009 07:13:38 +0000 (07:13 +0000)]
REGRESSION (r50218-r50262): E*TRADE accounts page is missing content
https://bugs.webkit.org/show_bug.cgi?id=30947
<rdar://problem/7348833>

Reviewed by Maciej Stachowiak

The logic for flagging that a structure has non-enumerable properties
was in addPropertyWithoutTransition, rather than in the core Structure::put
method.  Despite this I was unable to produce a testcase that caused
the failure that etrade was experiencing, but the new assertion in
getEnumerablePropertyNames triggers on numerous layout tests without
the fix, so in effecti all for..in enumeration in any test ends up
doing the required consistency check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 30 Oct 2009 06:51:51 +0000 (06:51 +0000)]
2009-10-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [V8] Out-of-memory crash in isolated worlds
        https://bugs.webkit.org/show_bug.cgi?id=30906

        We need to handle the fact that creating a V8:Context might fail.  I
        don't know how to test this change because creating a context usually
        only fails when V8 decides it's using too much memory.

        * bindings/v8/V8IsolatedWorld.cpp:
        (WebCore::V8IsolatedWorld::V8IsolatedWorld):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::evaluateInIsolatedWorld):
        (WebCore::V8Proxy::evaluateInNewContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
mitz@apple.com [Fri, 30 Oct 2009 06:12:02 +0000 (06:12 +0000)]
Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
from the two scripts that define it but don’t use it to the script that uses it but doesn’t
define it.

Reviewed by Mark Rowe.

* Scripts/VCSUtils.pm:
* Scripts/svn-apply:
* Scripts/svn-unapply:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoValidate the stopSpeaking: selector so that is not always enabled when a WebView...
mrowe@apple.com [Fri, 30 Oct 2009 05:57:29 +0000 (05:57 +0000)]
Validate the stopSpeaking: selector so that is not always enabled when a WebView is first responder.

Reviewed by Oliver Hunt.

* WebView/WebHTMLView.mm:
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<http://webkit.org/b/30938> REGRESSION(r50233): Windows nightlies crash on launch...
mrowe@apple.com [Fri, 30 Oct 2009 04:07:27 +0000 (04:07 +0000)]
<webkit.org/b/30938> REGRESSION(r50233): Windows nightlies crash on launch due to changes
to IWebFramePrivate vtable ordering

Rubber-stamped by Dan Bernstein.

* Interfaces/IWebFramePrivate.idl: Move the newly-added method to the end of the interface so that
it doesn't affect the ordering of the vtable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Erik Arvidsson <arv@chromium.org>
eric@webkit.org [Fri, 30 Oct 2009 02:39:01 +0000 (02:39 +0000)]
2009-10-29  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Eric Seidel.

        Make links mouse focusable only on GTK and QT.

        Links are now always mouse focusable on GTK and QT. On other platforms
        the link needs a tabIndex or it needs to be contentEditable.

        https://bugs.webkit.org/show_bug.cgi?id=26856

        * fast/events/click-focus-anchor-expected.txt:
        * fast/events/click-focus-anchor.html:
        * platform/gtk/fast/events/click-focus-anchor-expected.txt: Added.
        * platform/mac/fast/events/click-focus-anchor-expected.txt: Removed.
        * platform/qt/fast/events/click-focus-anchor-expected.txt: Added.
2009-10-29  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Eric Seidel.

        Make links mouse focusable only on GTK and QT.

        Links are now always mouse focusable on GTK and QT. On other platforms
        the link needs a tabIndex or it needs to be contentEditable.

        https://bugs.webkit.org/show_bug.cgi?id=26856

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::isMouseFocusable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Jonathan Dixon <joth@chromium.org>
eric@webkit.org [Fri, 30 Oct 2009 02:30:42 +0000 (02:30 +0000)]
2009-10-29  Jonathan Dixon  <joth@chromium.org>

        Reviewed by Eric Seidel.

        Add expected files for GTK and QT builds, for test text-input-webkit-radius.html
        Expected fils collected from buildbot:
        http://build.webkit.org/results/Qt%20Linux%20Release/r50286%20(3257)/fast/css/
        http://build.webkit.org/results/GTK%20Linux%20Release/r50286%20(5308)/fast/css/

        * platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
        * platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdated Tiger-specific result now that Tiger matches current behavior. A Tiger-specific
mitz@apple.com [Fri, 30 Oct 2009 02:00:54 +0000 (02:00 +0000)]
Updated Tiger-specific result now that Tiger matches current behavior. A Tiger-specific
result is still needed because of the difference in Thai fonts.

* platform/mac-tiger/fast/text/atsui-multiple-renderers-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Complete the fix for hit-testing and selection highlighting in ligatures...
mitz@apple.com [Fri, 30 Oct 2009 00:49:42 +0000 (00:49 +0000)]
WebCore: Complete the fix for hit-testing and selection highlighting in ligatures for the ATSUI
code path.

Reviewed by Sam Weinig.

* platform/graphics/mac/ComplexTextController.h: Added m_ltr member to ComplexTextRun.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Skip over deleted
glyphs, but update indexes and advances correctly.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_ltr.

LayoutTests: Updated a test to account for font metric differences between Mac OS X versions. Removed
Leopard-specific results for another test now that Leopard matches current behavior.

Reviewed by Sam Weinig.

* platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.checksum: Removed.
* platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.png: Removed.
* platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.txt: Removed.
* platform/mac/fast/text/ligature-subdivision-expected.txt:
* platform/mac/fast/text/script-tests/ligature-subdivision.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdating Radar numbers
adele@apple.com [Fri, 30 Oct 2009 00:26:30 +0000 (00:26 +0000)]
Updating Radar numbers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION(3.2.3 - 4.0.2): Message composing: when I undo a color change to text...
adele@apple.com [Thu, 29 Oct 2009 23:37:17 +0000 (23:37 +0000)]
REGRESSION(3.2.3 - 4.0.2): Message composing: when I undo a color change to text in Mail, undo/redo behaves strangely
<rdar://problem/7067033>
https://bugs.webkit.org/show_bug.cgi?id=30892

WebCore:

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-29
Reviewed by Darin Adler.

This problem shows in any scenario where it is necessary to split a text
node to apply a style. SplitElementCommand and WrapContentsInDummySpanCommand both
have member variables initialized in the constructor to keep reference to elements
they need to operate upon. These reference are not updated when reapplying the command.
For this reason it is necessary to guarantee that unapply doesn not delete the references
and that these commands implement doReapply to correctly reuse the existing
elements.

Test: editing/undo/redo-style.html

* editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::executeApply): Added.
(WebCore::SplitElementCommand::doApply): Modified to call executeApply.
(WebCore::SplitElementCommand::doUnapply): Doesn't release m_element1.
(WebCore::SplitElementCommand::doReapply): Added.
* editing/SplitElementCommand.h: Added doReapply and executeApply.
* editing/WrapContentsInDummySpanCommand.cpp:
(WebCore::WrapContentsInDummySpanCommand::executeApply): Added.
(WebCore::WrapContentsInDummySpanCommand::doApply): Modified to call executeApply.
(WebCore::WrapContentsInDummySpanCommand::doUnapply): Doesn't release m_dummySpan.
(WebCore::WrapContentsInDummySpanCommand::doReapply): Added.
* editing/WrapContentsInDummySpanCommand.h: Added doReapply and executeApply.

LayoutTests:

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-29
* editing/undo/redo-style-expected.txt: Added.
* editing/undo/redo-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 29 Oct 2009 23:22:33 +0000 (23:22 +0000)]
2009-10-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        DOM Storage's condition variable needs to handle spurious wakeups
        https://bugs.webkit.org/show_bug.cgi?id=30920

        Add a boolean to keep track of whether it's been terminated.  Clean
        up the locking code a tiny bit to make it easier to read.  There's
        no way to reproduce this reliably in a LayoutTest.

        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::LocalStorageThread):
        (WebCore::LocalStorageThread::terminate):
        (WebCore::LocalStorageThread::performTerminate):
        * storage/LocalStorageThread.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=30932
andersca@apple.com [Thu, 29 Oct 2009 23:22:26 +0000 (23:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30932
<rdar://problem/7350269>

Reviewed by Sam Weinig.

REGRESSION: Crash when turning on Private Browsing on site with flash.

Null check setValue.

* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView privateBrowsingModeDidChange]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools: Implement the Qt version of DRT dumpBackForwardList().
kenneth@webkit.org [Thu, 29 Oct 2009 22:49:35 +0000 (22:49 +0000)]
WebKitTools: Implement the Qt version of DRT dumpBackForwardList().

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Oliver Hunt.

* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::dumpHistoryItem):
(WebCore::DumpRenderTree::dumpBackForwardList):

LayoutTests: Removed test that passes after implementing the Qt DRT version
of dumpBackForwardList().

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Oliver Hunt.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 29 Oct 2009 22:43:55 +0000 (22:43 +0000)]
2009-10-29  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        [Chromium] Include ComplextTextController into Chromium Mac project.

        * WebCore.gyp/WebCore.gyp: Added include rule for ComplextText* files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 29 Oct 2009 22:32:20 +0000 (22:32 +0000)]
2009-10-29  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Kevin Decker.

        Refactor some duplicate plug-in clean up code into shared functions.

        * Plugins/WebPluginController.mm:
        (-[WebPluginController stopOnePlugin:]): New, stop a plug-in.
        (-[WebPluginController destroyOnePlugin:]): New, destroy plug-in.
        (-[WebPluginController stopAllPlugins]): Call stopOnePlugin.
        (-[WebPluginController destroyPlugin:]): Call stopOnePlugin and destroyOnePlugin.
        (-[WebPluginController destroyAllPlugins]): Call destroyOnePlugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 29 Oct 2009 22:32:04 +0000 (22:32 +0000)]
2009-10-29  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        fast/css/counters/invalidate-cached-counter-node can be dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=30931

        * fast/css/counters/invalidate-cached-counter-node-expected.txt: Added.
        * fast/css/counters/invalidate-cached-counter-node.html:
        * platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.checksum: Removed.
        * platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.png: Removed.
        * platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix tabbing through element attributes in the Web Insector.
timothy@apple.com [Thu, 29 Oct 2009 21:59:33 +0000 (21:59 +0000)]
Fix tabbing through element attributes in the Web Insector.

https://bugs.webkit.org/show_bug.cgi?id=30429

Reviewed by Pavel Feldman.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): Don't call _updateTitle,
it is called for us when removeAttribute succeeds in the back-end.
(WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto except for nodeValue.
(WebInspector.ElementsTreeElement.prototype._editingCancelled): Don't call _updateTitle, editing code reverts.
(WebInspector.ElementsTreeElement.prototype._updateTitle): Return early if we are editing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Remove some tests that now pass.
ossy@webkit.org [Thu, 29 Oct 2009 21:54:00 +0000 (21:54 +0000)]
[Qt] Remove some tests that now pass.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-29
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoProblem editing or selecting text containing ligatures
mitz@apple.com [Thu, 29 Oct 2009 21:25:59 +0000 (21:25 +0000)]
Problem editing or selecting text containing ligatures
https://bugs.webkit.org/show_bug.cgi?id=30025

Reviewed by Sam Weinig.

WebCore:

Test: platform/mac/fast/text/ligature-subdivision.html

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController): Initialize
m_characterInCurrentGlyph.
(WebCore::ComplexTextController::offsetForPosition): If the hit glyph spans multiple
characters, compute the hit character based on dividing the glyph’s total advance into
a number of equal intervals equal to the number of characters and assigning the hit to the
character corresponding to the hit interval.
(WebCore::ComplexTextController::advance): If the final offset occurs mid-glyph, advance
by a fraction of the glyph’s total advance.
* platform/graphics/mac/ComplexTextController.h: Added m_characterInCurrentGlyph.

LayoutTests:

* platform/mac/fast/text/ligature-subdivision-expected.txt: Added.
* platform/mac/fast/text/ligature-subdivision.html: Added.
* platform/mac/fast/text/script-tests: Added.
* platform/mac/fast/text/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/js/script-tests/TEMPLATE.html.
* platform/mac/fast/text/script-tests/ligature-subdivision.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes <http://webkit.org/b/30918>.
bweinstein@apple.com [Thu, 29 Oct 2009 21:25:01 +0000 (21:25 +0000)]
Fixes <http://webkit.org/b/30918>.
Web Inspector: Datagrid Rows on Windows not properly aligned.

Reviewed by Timothy Hatcher.

Use line-height for the table rows to make sure the height
of our text and the height of the table rows are consistent.

* inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 29 Oct 2009 20:33:12 +0000 (20:33 +0000)]
2009-10-29  Adam Barth  <abarth@webkit.org>

        No review, rolling out r50296.
        http://trac.webkit.org/changeset/50296

        * bindings/v8/V8IsolatedWorld.cpp:
        (WebCore::V8IsolatedWorld::V8IsolatedWorld):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::evaluateInIsolatedWorld):
        (WebCore::V8Proxy::evaluateInNewContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Oct 2009 20:25:25 +0000 (20:25 +0000)]
2009-10-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Use the GTK+ main loop instead of rolling our own mini-version of
        it.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dump):
        (runTest):
        (webViewLoadFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Adam Roben.
kenneth@webkit.org [Thu, 29 Oct 2009 20:21:23 +0000 (20:21 +0000)]
Rubberstamped by Adam Roben.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Remove two tests that pass on the buildbot.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 29 Oct 2009 20:15:13 +0000 (20:15 +0000)]
2009-10-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [V8] Out-of-memory crash in isolated worlds
        https://bugs.webkit.org/show_bug.cgi?id=30906

        We need to handle the fact that creating a V8:Context might fail.  I
        don't know how to test this change because creating a context usually
        only fails when V8 decides it's using too much memory.

        * bindings/v8/V8IsolatedWorld.cpp:
        (WebCore::V8IsolatedWorld::V8IsolatedWorld):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::evaluateInIsolatedWorld):
        (WebCore::V8Proxy::evaluateInNewContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Xan Lopez.
kov@webkit.org [Thu, 29 Oct 2009 20:05:06 +0000 (20:05 +0000)]
    Reviewed by Xan Lopez.

        Remove build warning introduced by r50284.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::duration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed Qt buildbot fix.
kenneth@webkit.org [Thu, 29 Oct 2009 20:05:02 +0000 (20:05 +0000)]
Unreviewed Qt buildbot fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Add some files to skipped that depend on phonon support,
which is disabled on the Qt buildbot for now.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 29 Oct 2009 20:01:12 +0000 (20:01 +0000)]
2009-10-29  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        [V8] Remove random crashes by removing retrieval of V8 context during garbage collection.

        https://bugs.webkit.org/show_bug.cgi?id=30919

        Unfortunately, I haven't been able to trigger this crash explicitly, so no test :(.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::jsWrapperForDOMObject): Added new "assume-it's-there" getter.
        * bindings/v8/V8DOMWrapper.h: Added getter decl.
        * bindings/v8/V8GCController.cpp:
        (WebCore::GCPrologueVisitor::visitDOMWrapper): Changed to use explicit getter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 29 Oct 2009 19:43:46 +0000 (19:43 +0000)]
2009-10-29  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        [Chromium] Adjust the project files to sync up with
        http://trac.webkit.org/changeset/50259

        * WebCore.gypi: Renamed and added files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdated expected result for Tiger
mitz@apple.com [Thu, 29 Oct 2009 19:41:30 +0000 (19:41 +0000)]
Updated expected result for Tiger

* platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Adam Roben.
kenneth@webkit.org [Thu, 29 Oct 2009 19:24:52 +0000 (19:24 +0000)]
Rubberstamped by Adam Roben.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Remove tests that pass after the change introduced in r50289.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplement DRT functionality for Qt introduced in
kenneth@webkit.org [Thu, 29 Oct 2009 19:06:55 +0000 (19:06 +0000)]
Implement DRT functionality for Qt introduced in
r28690 and r28705.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Adam Roben.

- Implemented pathToLocalResource which exposes the functionality of
converting a given unix path to the correct location on Windows.
- Implemented a way to remove machine-dependent information from paths
in layout test results.

* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::urlSuitableForTestResult):
(WebCore::WebPage::javaScriptConsoleMessage):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::pathToLocalResource):
* DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Thu, 29 Oct 2009 18:29:26 +0000 (18:29 +0000)]
2009-10-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Implement DELETE HTTP method for XmlHttpRequest
        https://bugs.webkit.org/show_bug.cgi?id=30894

        No new tests as this functionality is already tested by the
        xmlhttprequest LayoutTests. As this patch depends on an unreleased
        version of the dependent QtNetwork library and the tests will be
        enabled later once the dependent library is released (and the
        buildbot is updated).

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
        (WebCore::QNetworkReplyHandler::start):
2009-10-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Implement DELETE HTTP method for XmlHttpRequest
        https://bugs.webkit.org/show_bug.cgi?id=30894

        No new tests as this functionality is already tested by the
        xmlhttprequest LayoutTests. As this patch depends on an unreleased
        version of the dependent QtNetwork library and the tests will be
        enabled later once the dependent library is released (and the
        buildbot is updated).

        * Api/qwebframe.cpp:
        (QWebFrame::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPart of <http://webkit.org/b/30483>.
bweinstein@apple.com [Thu, 29 Oct 2009 18:15:51 +0000 (18:15 +0000)]
Part of <http://webkit.org/b/30483>.
Web Inspector: Always show the Local and Session Storage Views.

Reviewed by Timothy Hatcher.

Even if the length of the DOM Storage entry array is 0, still
generate the Datagrid because users can add things storage items
through the UI, so we should allow them to even if there isn't
anything there currently.

* English.lproj/localizedStrings.js: Removed "This Storage is Empty".
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 29 Oct 2009 17:58:27 +0000 (17:58 +0000)]
2009-10-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Add TimelinePanel into the panels enum.

        https://bugs.webkit.org/show_bug.cgi?id=30915

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::specialPanelForJSName):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Oct 2009 17:53:16 +0000 (17:53 +0000)]
2009-10-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Oliver Hunt.

        [GTK] Threading problems with some of the tests
        https://bugs.webkit.org/show_bug.cgi?id=30814

        Create strings shared among threads with crossThreadString
        constructor method.

        * storage/Database.cpp:
        (WebCore::Database::Database):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Sebastian Dröge <sebastian.droege@collabora.co.uk>
eric@webkit.org [Thu, 29 Oct 2009 17:50:49 +0000 (17:50 +0000)]
2009-10-29  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=30308

        Add support for ARGB videos.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::paint):
        Create the Cairo image surface for ARGB32 or RGB24
        depending on the buffer's caps.

        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_timeout_func):
        (webkit_video_sink_render):
        Handle ARGB video and convert GStreamer's ARGB to
        Cairo's for displaying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 29 Oct 2009 17:42:17 +0000 (17:42 +0000)]
2009-10-29  Anton Muhin  <antonm@chromium.org>

        Reviewed by David Levin.

        [chromium] expose a method to access memory usage information in ChromiumBridge
        Declare a static method to be implemented by http://codereview.chromium.org/332010/
        https://bugs.webkit.org/show_bug.cgi?id=30829

        * platform/chromium/ChromiumBridge.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Thu, 29 Oct 2009 17:34:39 +0000 (17:34 +0000)]
2009-10-29  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25679
        [Gtk] Improve accessibility of focusable lists

        Implements the AtkSelection interface and enables the corresponding
        (and expected) object:selection-changed event.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (optionFromList):
        (optionFromSelection):
        (atk_selection_interface_init):
        (webkit_accessible_selection_add_selection):
        (webkit_accessible_selection_clear_selection):
        (webkit_accessible_selection_ref_selection):
        (webkit_accessible_selection_get_selection_count):
        (webkit_accessible_selection_is_child_selected):
        (webkit_accessible_selection_remove_selection):
        (webkit_accessible_selection_select_all_selection):
        (GetAtkInterfaceTypeFromWAIType):
        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (AXObjectCache::postPlatformNotification):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTouch WebKit.idl to force a rebuild.
sfalken@apple.com [Thu, 29 Oct 2009 17:27:56 +0000 (17:27 +0000)]
Touch WebKit.idl to force a rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Steve Falkenburg.
bweinstein@apple.com [Thu, 29 Oct 2009 17:26:45 +0000 (17:26 +0000)]
Rubber-stamped by Steve Falkenburg.

Windows Release bots are having problems in xmlhttprequest tests, Skipping them temporarily
to see if this eliminates the problem, and it is a test causing httpd problems.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 30655 - Only plain text should be copied to clipboard for TextArea.
jianli@chromium.org [Thu, 29 Oct 2009 17:18:02 +0000 (17:18 +0000)]
Bug 30655 - Only plain text should be copied to clipboard for TextArea.
https://bugs.webkit.org/show_bug.cgi?id=30655

Reviewed by Darin Adler.

* editing/Editor.cpp:
(WebCore::nodeIsInTextFormControl):
(WebCore::Editor::cut):
(WebCore::Editor::copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 29 Oct 2009 16:58:17 +0000 (16:58 +0000)]
2009-10-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: hide timeline for now - not yet ready.

        https://bugs.webkit.org/show_bug.cgi?id=30912

        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 29 Oct 2009 16:46:34 +0000 (16:46 +0000)]
2009-10-29  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: deploy Web Inspector's images in WebCore.gypi.

        * WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 29 Oct 2009 16:36:18 +0000 (16:36 +0000)]
2009-10-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: get rid of timelineProfilerEnabled method.

        https://bugs.webkit.org/show_bug.cgi?id=30911

        * inspector/InspectorBackend.cpp:
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setWindowVisible):
        * inspector/InspectorController.h:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 29 Oct 2009 16:12:19 +0000 (16:12 +0000)]
2009-10-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Darin Fisher.

        Create stub methods for raw cookies access in ChromiumBridge.h

        https://bugs.webkit.org/show_bug.cgi?id=30910

        * platform/chromium/ChromiumBridge.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAllow custom memory allocation control for WebCore's RareData
zoltan@webkit.org [Thu, 29 Oct 2009 15:44:22 +0000 (15:44 +0000)]
Allow custom memory allocation control for WebCore's RareData
https://bugs.webkit.org/show_bug.cgi?id=30858

Reviewed by Darin Adler.

Inherits RareData struct from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSSelector.h:259 and
it is no need to be copyable.

* css/CSSSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAllow custom memory allocation control for WebCore's ShorthandScope
zoltan@webkit.org [Thu, 29 Oct 2009 15:41:07 +0000 (15:41 +0000)]
Allow custom memory allocation control for WebCore's ShorthandScope
https://bugs.webkit.org/show_bug.cgi?id=30859

Reviewed by Darin Adler.

Inherits ShorthandScope class from FastAllocBase because it is
instantiated by 'new' in WebCore/css/CSSParser.cpp:902 and
it is no need to be copyable.

* css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAllow custom memory allocation control for WebCore's AXObjectCache
zoltan@webkit.org [Thu, 29 Oct 2009 15:38:27 +0000 (15:38 +0000)]
Allow custom memory allocation control for WebCore's AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=30848

Reviewed by Darin Adler.

Inherits AXObjectCache class from FastAllocBase because it is
instantiated by 'new' in WebCore/dom/Document.cpp:1537 and
it is no need to be copyable.

* accessibility/AXObjectCache.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 29 Oct 2009 15:18:58 +0000 (15:18 +0000)]
2009-10-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't run JavaScript URLs in view source mode
        https://bugs.webkit.org/show_bug.cgi?id=30881

        Test that we don't run JavaScript URLs in view source mode.

        This test actually passes before this change.  I don't know how to
        actually run JavaScript URLs in view source frames using DRT, but it's
        possible in an abitrary embedding of WebKit.

        * http/tests/security/view-source-no-javascript-url-expected.txt: Added.
        * http/tests/security/view-source-no-javascript-url.html: Added.
2009-10-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't run JavaScript URLs in view source mode
        https://bugs.webkit.org/show_bug.cgi?id=30881

        Just say no.

        Test: http/tests/security/view-source-no-javascript-url.html

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeIfJavaScriptURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove QWebView::guessUrlFromString() and replace its use
kenneth@webkit.org [Thu, 29 Oct 2009 14:43:18 +0000 (14:43 +0000)]
Remove QWebView::guessUrlFromString() and replace its use
with the new QUrl::fromUserInput() if using Qt 4.6 or newer.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Tor Arne Vestbø.

* Api/qwebview.cpp:
* Api/qwebview.h:
* QGVLauncher/main.cpp:
(urlFromUserInput):
(WebPage::applyProxy):
(MainWindow::load):
* QtLauncher/main.cpp:
(urlFromUserInput):
(MainWindow::MainWindow):
(MainWindow::changeLocation):
* tests/qwebview/tst_qwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSerialize directly to the stream, and not first to an QByteArray,
kenneth@webkit.org [Thu, 29 Oct 2009 13:23:23 +0000 (13:23 +0000)]
Serialize directly to the stream, and not first to an QByteArray,
that is later serialized. That is slower and also uses more bytes.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Reviewed by Tor Arne Vestbø.

* Api/qwebhistory.cpp:
(operator<<):
(operator>>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Fixes style problems pointed out by Evan Martin.
kov@webkit.org [Thu, 29 Oct 2009 12:48:02 +0000 (12:48 +0000)]
Unreviewed. Fixes style problems pointed out by Evan Martin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Unreviewed. Trivial fix - move public API declaration into the
kov@webkit.org [Thu, 29 Oct 2009 12:46:06 +0000 (12:46 +0000)]
    Unreviewed. Trivial fix - move public API declaration into the
        public subsection of the doc.

        * docs/webkitgtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Mark Rowe.
mitz@apple.com [Thu, 29 Oct 2009 09:21:09 +0000 (09:21 +0000)]
Rubber-stamped by Mark Rowe.

64-bit Leopard build fix after r50259

* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
Declared ATSUTextInserted in 64-bit.
(WebCore::fontHasMirroringInfo): Use %d format and cast to int.
(WebCore::disableLigatures): Ditto.
(WebCore::initializeATSUStyle): Ditto.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd cacheFlush support for Thumb-2 on Linux
zoltan@webkit.org [Thu, 29 Oct 2009 07:32:33 +0000 (07:32 +0000)]
Add cacheFlush support for Thumb-2 on Linux
https://bugs.webkit.org/show_bug.cgi?id=30865

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-10-29
Reviewed by Gavin Barraclough.

* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTiger build fix after r50259
mitz@apple.com [Thu, 29 Oct 2009 07:23:35 +0000 (07:23 +0000)]
Tiger build fix after r50259

* platform/graphics/mac/ComplexTextController.h:
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTiger build fix after r50259
mitz@apple.com [Thu, 29 Oct 2009 07:12:57 +0000 (07:12 +0000)]
Tiger build fix after r50259

* platform/graphics/mac/ComplexTextControllerATSUI.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix changelog
sfalken@apple.com [Thu, 29 Oct 2009 06:07:30 +0000 (06:07 +0000)]
Fix changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=30899
sfalken@apple.com [Thu, 29 Oct 2009 06:06:01 +0000 (06:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30899
WebKit fails to build release on 32-bit Windows systems

Reviewed by Mark Rowe.

* WebCore.vcproj/WebCore.vcproj: Excluded files from project.
* bindings/js/JSBindingsAllInOne.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed typos in color names.
mitz@apple.com [Thu, 29 Oct 2009 06:04:18 +0000 (06:04 +0000)]
Fixed typos in color names.

Reviewed by Jon Honeycutt.

* inspector/front-end/Color.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Share code between the ATSUI- and Core Text-based Font implementations by...
mitz@apple.com [Thu, 29 Oct 2009 05:35:36 +0000 (05:35 +0000)]
WebCore: Share code between the ATSUI- and Core Text-based Font implementations by doing the
following:
- Generalize CoreTextController as ComplexTextController, keeping the Core Text-specific
  parts in ComplexTextControllerCoreText.cpp.
- Generalize FontMacCoreText as FontComplexTextMac using ComplexTextController
- Implement ATSUI-specific parts of ComplexTextController in ComplexTextControllerATSUI.
- Remove FontMacATSUI.

Reviewed by Sam Weinig.

* WebCore.xcodeproj/project.pbxproj: Removed CoreTextController.{cpp,h}, FontMacATSUI.mm,
and FontMacCoreText.cpp, and added ComplexTextController.{cpp,h},
ComplexTextControllerATSUI.cpp, ComplexTextControllerCoreText.cpp, and
FontComplexTextMac.cpp.

* platform/graphics/mac/ComplexTextController.cpp: Copied from CoreTextController.cpp and
kept the non-Core Text-specific bits.
(WebCore::ComplexTextController::ComplexTextController): Updated for renames, including
its own.
(WebCore::ComplexTextController::offsetForPosition): Updated for renames and for
m_complexTextRuns holding references instead of objects.
(WebCore::ComplexTextController::collectComplexTextRuns): Updated for renames, including
its own.
(WebCore::ComplexTextController::advance): Updated for renames.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Updated for renames and for
m_complexTextRuns holding references instead of objects, and changed to use the glyphs()
and advances() accessors.

* platform/graphics/mac/ComplexTextController.h: Copied from CoreTextController.h and
renamed CoreTextController to ComplexTextController and CoreTextRun to ComplexTextRun. Made
the latter RefCounted, added ATSUI-specific members to it, and made some other members
Core Text-specific. Renamed m_coreTextRuns to m_complexTextRuns and made it hold references
rather than objects.
(WebCore::ComplexTextController::ComplexTextRun::create):
(WebCore::ComplexTextController::ComplexTextRun::glyphs):
(WebCore::ComplexTextController::ComplexTextRun::advances):

* platform/graphics/mac/ComplexTextControllerATSUI.cpp: Added. Includes ATSUI-specific
parts of the ComplexTextController implementation.
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): This ATSUI
callback populates the ComplexTextRun’s glyphs, advances and indices vectors. It is invoked
when the ComplexTextRun constructor calls ATSUGetGlyphBounds().
(WebCore::isArabicLamWithAlefLigature): Helper function, copied from FontMacATSUI.mm.
(WebCore::shapeArabic): Helper function, adapted from FontMacATSUI.mm.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Sets up the
ATSUTextLayout, substituting the text buffer if necessary for things like shaping Arabic,
mirroring glyphs or directionality overrides, then calls ATSUGetGlyphBounds() in order to
get the glyphs, advances and indices vectors populated.
(WebCore::fontHasMirroringInfo): Helper function, copied from FontMacATSUI.mm.
(WebCore::disableLigatures): Ditto.
(WebCore::initializeATSUStyle): Ditto, somewhat cleaned up and simplified.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Constructs
ComplexTextRuns, either missing-glyphs ones or ATSUTextLayout-based ones.

* platform/graphics/mac/ComplexTextControllerCoreText.cpp: Copied from
CoreTextController.cpp and kept the Core Text-specific bits.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Updated for renames,
including its own, and moved the code to initialize m_glyphs and m_advances here. Previously
this was done in adjustGlyphsAndAdvances().
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Updated for renames,
including its own.
* platform/graphics/mac/CoreTextController.cpp: Removed.
* platform/graphics/mac/CoreTextController.h: Removed.
* platform/graphics/mac/FontComplexTextMac.cpp: Renamed FontMacCoreText.cpp to this.
(WebCore::Font::selectionRectForComplexText): Changed to use ComplexTextController instead
of CoreTextController.
(WebCore::Font::drawComplexText): Ditto.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.
* platform/graphics/mac/FontMacATSUI.mm: Removed.
* platform/graphics/mac/FontMacCoreText.cpp: Removed.

LayoutTests: Removed Leopard-specific result after changing ATSUI missing-glyph behavior to match the
Core Text and fast code paths' behavior.

* platform/mac-leopard/fast/text/international/khmer-selection-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-28 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Thu, 29 Oct 2009 05:23:06 +0000 (05:23 +0000)]
2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>

        Adding myself to the committers list.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdding myself to the committers list.
cfleizach@apple.com [Thu, 29 Oct 2009 04:20:27 +0000 (04:20 +0000)]
Adding myself to the committers list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: WAI-ARIA: add support for 'option' role
cfleizach@apple.com [Thu, 29 Oct 2009 02:48:19 +0000 (02:48 +0000)]
WebCore: WAI-ARIA: add support for 'option' role
https://bugs.webkit.org/show_bug.cgi?id=30843

Reviewed by Darin Adler.

Test: accessibility/aria-option-role.html

* accessibility/AccessibilityListBoxOption.h:
(WebCore::AccessibilityListBoxOption::canHaveChildren):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::RoleEntry::):
(WebCore::AccessibilityRenderObject::canHaveChildren):

LayoutTests: Fix video-pause-immediately.html to avoid using setTimeout().

Patch by Andrew Scherkus <scherkus@chromium.org> on 2009-10-28
Reviewed by Eric Carlson.

This also addresses the flakiness on Windows, where 200ms was not enough time to advance the clock past zero.

https://bugs.webkit.org/show_bug.cgi?id=30889

* media/video-pause-immediately.html: Replace setTimeout() with timeupdate events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJSC JIT on ARMv7 cannot link jumps >16Mb range
barraclough@apple.com [Thu, 29 Oct 2009 01:40:09 +0000 (01:40 +0000)]
JSC JIT on ARMv7 cannot link jumps >16Mb range
https://bugs.webkit.org/show_bug.cgi?id=30891

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-28
Reviewed by Oliver Hunt.

Start planing all relative jumps as move-32-bit-immediate-to-register-BX.
In the cases where the jump would fall within a relative jump range, use a relative jump.

* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::~ARMv7Assembler):
(JSC::ARMv7Assembler::LinkRecord::LinkRecord):
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::executableCopy):
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::relinkJump):
(JSC::ARMv7Assembler::setInt32):
(JSC::ARMv7Assembler::isB):
(JSC::ARMv7Assembler::isBX):
(JSC::ARMv7Assembler::isMOV_imm_T3):
(JSC::ARMv7Assembler::isMOVT):
(JSC::ARMv7Assembler::isNOP_T1):
(JSC::ARMv7Assembler::isNOP_T2):
(JSC::ARMv7Assembler::linkJumpAbsolute):
(JSC::ARMv7Assembler::twoWordOp5i6Imm4Reg4EncodedImmFirst):
(JSC::ARMv7Assembler::twoWordOp5i6Imm4Reg4EncodedImmSecond):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp5i6Imm4Reg4EncodedImm):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::makeJump):
(JSC::MacroAssemblerARMv7::makeBranch):
* jit/JIT.h:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImprove for..in enumeration performance
oliver@apple.com [Thu, 29 Oct 2009 01:25:02 +0000 (01:25 +0000)]
Improve for..in enumeration performance
https://bugs.webkit.org/show_bug.cgi?id=30887

Reviewed by Geoff Garen.

Improve indexing of an object with a for..in iterator by
identifying cases where get_by_val is being used with a iterator
as the subscript and replace it with a new get_by_pname
bytecode.  get_by_pname then optimizes lookups that directly access
the base object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-28 Jens Alfke <snej@chromium.org>
eric@webkit.org [Thu, 29 Oct 2009 00:54:42 +0000 (00:54 +0000)]
2009-10-28  Jens Alfke  <snej@chromium.org>

        Reviewed by Eric Seidel.

        Fix GCC compiler warnings in WebCore, and enable -Wall and -Werror for Chromium build.
        https://bugs.webkit.org/show_bug.cgi?id=30716

        * WebCore.gyp/WebCore.gyp:  Enable "chromium_code" flag, just on Mac build for now.
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::createARIARoleMap):  Fix struct visibiity warning.
        * bindings/v8/ScriptCallStack.h:  Fix out-of-order member initialization warning.
        * bindings/v8/V8Collection.h:
        (WebCore::getV8Object):  Function in header should not be 'static' (fixes unused-static warning.)
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):  Fix signed/unsigned comparison warning.
        * bindings/v8/V8GCController.cpp:
        (WebCore::ObjectGrouperVisitor::applyGrouping):  Fix unused-variable warning.
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):  Enable ListButtonPart case to avoid
            warning about missing cases in 'switch' statement.
        * editing/EditorCommand.cpp:
        (WebCore::createCommandMap):  Fix struct visibiity warning.
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::State::State):  Fix out-of-order member initialization warning.
        * rendering/RenderMediaControlsChromium.cpp:
        (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart):  Add empty 'default' case in
            'switch' statement to avoid missing-case warning.
        (WebCore::RenderMediaControlsChromium::paintMediaControlsPart):  Ditto.
        * xml/XPathFunctions.cpp:
        (WebCore::XPath::createFunctionMap):  Fix struct visibiity warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-28 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Thu, 29 Oct 2009 00:45:30 +0000 (00:45 +0000)]
2009-10-28  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson.

        Fix video-pause-immediately.html to avoid using setTimeout().

        This also addresses the flakiness on Windows, where 200ms was not enough time to advance the clock past zero.

        https://bugs.webkit.org/show_bug.cgi?id=30889

        * media/video-pause-immediately.html: Replace setTimeout() with timeupdate events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-28 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 29 Oct 2009 00:22:14 +0000 (00:22 +0000)]
2009-10-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION: crashes in WebCore::RedirectScheduler::timerFired(WebCore::Timer<WebCore::RedirectScheduler>*)
        https://bugs.webkit.org/show_bug.cgi?id=30839

        Added null check for the case when the frame is detached from the page.

        * loader/RedirectScheduler.cpp:
        (WebCore::RedirectScheduler::timerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Thu, 29 Oct 2009 00:12:42 +0000 (00:12 +0000)]
2009-10-28  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=30817
        Use parentObjectUnignored instead of parentObject in webkit_accessible_get_parent

        Also removes the hack I had originally added to solve bug 25411, because
        the fix here is what I should have done in the first place.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_parent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Ada Chan.
bweinstein@apple.com [Thu, 29 Oct 2009 00:08:51 +0000 (00:08 +0000)]
Rubber-stamped by Ada Chan.

Add accessibility test to the list of Windows Skipped tests.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, attemp to fix Windows build.
dimich@chromium.org [Wed, 28 Oct 2009 23:37:13 +0000 (23:37 +0000)]
Not reviewed, attemp to fix Windows build.

Touch the cpp file to cause recompile.

* wtf/Threading.cpp:
(WTF::threadEntryPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore: Add MessageQueue::removeIf(Predicate&) to remove certain tasks withou...
dimich@chromium.org [Wed, 28 Oct 2009 23:21:31 +0000 (23:21 +0000)]
JavaScriptCore: Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
Existing Database tests cover this since Database removes tasks when it is stopped.
https://bugs.webkit.org/show_bug.cgi?id=30805

Reviewed by David Levin.

* wtf/MessageQueue.h:
(WTF::::removeIf):

WebCore: Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
Existing Database tests cover this, no change in functionality.
https://bugs.webkit.org/show_bug.cgi?id=30805

Reviewed by David Levin.

* storage/DatabaseThread.cpp:
(WebCore::SameDatabasePredicate::SameDatabasePredicate): Added predicate that flags the tasks belonging to a specified database.
(WebCore::SameDatabasePredicate::operator()):
(WebCore::DatabaseThread::unscheduleDatabaseTasks): changed to use the new removeIf method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 28 Oct 2009 23:19:11 +0000 (23:19 +0000)]
2009-10-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Glue subsequent timeline records with same category
        and title together. Enable Timeline Panel!!!

        https://bugs.webkit.org/show_bug.cgi?id=30885

        * English.lproj/localizedStrings.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
        (WebInspector.TimelinePanel.prototype._formatRecord):
        (WebInspector.TimelineRecordTreeElement.prototype.onattach):
        (WebInspector.TimelineRecordTreeElement.prototype.refresh):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests
kov@webkit.org [Wed, 28 Oct 2009 22:56:58 +0000 (22:56 +0000)]
LayoutTests

        Reviewed by Jan Alonzo.

        [GTK] API to start inspector for a WebView
        https://bugs.webkit.org/show_bug.cgi?id=22551

        Unskip inspector tests that we are now able to run.

        * platform/gtk/Skipped:
WebKit/gtk

        Reviewed by Jan Alonzo.

        [GTK] API to start inspector for a WebView
        https://bugs.webkit.org/show_bug.cgi?id=22551

        Provide a simple, coordinates-based API to start the inspector.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::createPage): Use files from the source
        tree when running from the top of the source directory.
        (WebKit::InspectorClient::localizedStringsURL): Ditto.
        * webkit/webkitprivate.h:
        * webkit/webkitwebinspector.cpp:
        (webkit_web_inspector_inspect_coordinates):
        (webkit_web_inspector_close):
        (webkit_web_inspector_execute_script):
        * webkit/webkitwebinspector.h:

WebKitTools

        Reviewed by Jan Alonzo.

        [GTK] API to start inspector for a WebView
        https://bugs.webkit.org/show_bug.cgi?id=22551

        Use the new inspector API to implement the LayoutTestController
        interfaces used to test the inspector.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webInspectorInspectWebView):
        (createWebView):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):
        (LayoutTestController::evaluateInWebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests
kov@webkit.org [Wed, 28 Oct 2009 22:42:42 +0000 (22:42 +0000)]
LayoutTests

        Reviewed by Xan Lopez.

        [GTK] Fails new test fast/js/navigator-language.html
        https://bugs.webkit.org/show_bug.cgi?id=30440

        Unskip the test that now passes.

        * platform/gtk/Skipped:
WebCore

        Reviewed by Xan Lopez.

        [GTK] Fails new test fast/js/navigator-language.html
        https://bugs.webkit.org/show_bug.cgi?id=30440

        Reimplement WebCore::defaultLanguage to account for changes in
        locale done by setLocale.

        Already existing test: fast/js/navigator-language.html

        * platform/gtk/Language.cpp:
        (WebCore::defaultLanguage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoShould not generate/build COM DOM bindings
sfalken@apple.com [Wed, 28 Oct 2009 22:40:10 +0000 (22:40 +0000)]
Should not generate/build COM DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=30880

Reviewed by Sam "Horatio" Weinig.

* Interfaces/WebKit.idl: Remove generated interfaces.
* WebKit.vcproj/InterfacesGenerated.vcproj: Removed.
* WebKit.vcproj/WebKit.sln: Remove InterfacesGenerated.vcproj.
* WebKit.vcproj/WebKit.submit.sln: Remove InterfacesGenerated.vcproj.
* WebKit.vcproj/WebKit.vcproj: Remove generated interfaces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-28 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 28 Oct 2009 22:36:47 +0000 (22:36 +0000)]
2009-10-28  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7303145>
        Can't exit full screen mode or restart movie after pressing command -R.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::removedFromDocument):
        (WebCore::HTMLMediaElement::documentWillBecomeInactive):
            Exit from fullscreen if necessary.
        * html/HTMLMediaElement.h:

2009-10-28  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7303145>
        Can't exit full screen mode or restart movie after pressing command -R.

        * WebView/WebVideoFullscreenController.mm:
        (-[WebVideoFullscreenController _requestExit]):
            New, call media element's exitFullscreen method.
        (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
            Call mediaElement->exitFullscreen() after a delay as it turns around and calls
            WebVideoFullscreenController:exitFullscreen.

        * WebView/WebVideoFullscreenHUDWindowController.h:
        * WebView/WebVideoFullscreenHUDWindowController.mm:
        (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
            New, don't give up responder status.
        (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
            New, block all command key events.
        (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
            Remember when we are in the process of exiting fullscreen, don't allow recursion.

        * WebView/WebView.mm:
        (-[WebView _exitFullscreen]):
            Early return if fullscreen controller is nil.

        * WebView/WebWindowAnimation.h:
            Correct comment about _window retain status.
        * WebView/WebWindowAnimation.m:
        (-[WebWindowScaleAnimation dealloc]):
            Don't release _window, we never reatained it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-28 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 28 Oct 2009 22:19:28 +0000 (22:19 +0000)]
2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        [Qt] WebFrame::counterValueForElementById must not be exposed
        https://bugs.webkit.org/show_bug.cgi?id=30882

        * Api/qwebframe.cpp:
        (qt_drt_counterValueForElementById):
        * Api/qwebframe.h:
2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        [Qt] WebFrame::counterValueForElementById must not be exposed
        https://bugs.webkit.org/show_bug.cgi?id=30882

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::counterValueForElementById):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Unreviewed - a trivial fix to get Windows bots running.
ap@apple.com [Wed, 28 Oct 2009 21:45:52 +0000 (21:45 +0000)]
    Unreviewed - a trivial fix to get Windows bots running.

        https://bugs.webkit.org/show_bug.cgi?id=30841
        <rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site

        * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): Don't try to
        access empty vector's data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-28 Afonso R. Costa Jr. <afonso.costa@openbossa.org>
eric@webkit.org [Wed, 28 Oct 2009 21:44:08 +0000 (21:44 +0000)]
2009-10-28  Afonso R. Costa Jr.  <afonso.costa@openbossa.org>

        Reviewed by Oliver Hunt.

        [Qt] Enable YARR when YARR_JIT is enabled
        https://bugs.webkit.org/show_bug.cgi?id=30730

        When enabling or disabling JIT using JAVASCRIPTCORE_JIT, the ENABLE_YARR should
        be toggled also.

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Wed, 28 Oct 2009 21:36:40 +0000 (21:36 +0000)]
2009-10-28  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25897
        [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries

        Remove the extraneous object of ROLE_PANEL.

        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (AccessibilityObject::accessibilityPlatformIncludesObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-28 Jonathan Dixon <joth@chromium.org>
eric@webkit.org [Wed, 28 Oct 2009 21:29:17 +0000 (21:29 +0000)]
2009-10-28  Jonathan Dixon  <joth@chromium.org>

        Reviewed by Eric Seidel.

        Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
        https://bugs.webkit.org/show_bug.cgi?id=30547

        * fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
        * fast/css/text-input-with-webkit-border-radius-expected.png: Added.
        * fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
        * fast/css/text-input-with-webkit-border-radius.html: Added.
2009-10-28  Jonathan Dixon  <joth@chromium.org>

        Reviewed by Eric Seidel.

        Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
        https://bugs.webkit.org/show_bug.cgi?id=30547

        Test: fast/css/text-input-with-webkit-border-radius.html

        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
          Implemented rounded border rendering in Chromium Windows theme renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 28 Oct 2009 21:17:21 +0000 (21:17 +0000)]
2009-10-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Pull items collections from resources panel and
        timeline panel into AbstractTimelinePanel.

        https://bugs.webkit.org/show_bug.cgi?id=30875

        * inspector/front-end/AbstractTimelinePanel.js:
        (WebInspector.AbstractTimelinePanel):
        (WebInspector.AbstractTimelinePanel.prototype.populateSidebar):
        (WebInspector.AbstractTimelinePanel.prototype.createItemTreeElement):
        (WebInspector.AbstractTimelinePanel.prototype.createItemGraph):
        (WebInspector.AbstractTimelinePanel.prototype._showCategory):
        (WebInspector.AbstractTimelinePanel.prototype._hideCategory):
        (WebInspector.AbstractTimelinePanel.prototype.filter):
        (WebInspector.AbstractTimelinePanel.prototype._createGraph):
        (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth):
        (WebInspector.AbstractTimelinePanel.prototype.refresh):
        (WebInspector.AbstractTimelinePanel.prototype.reset):
        (WebInspector.AbstractTimelinePanel.prototype.get calculator):
        (WebInspector.AbstractTimelinePanel.prototype.set calculator):
        (WebInspector.AbstractTimelinePanel.prototype.addItem):
        (WebInspector.AbstractTimelinePanel.prototype.removeItem):
        (WebInspector.AbstractTimelinePanel.prototype.refreshItem):
        (WebInspector.AbstractTimelinePanel.prototype.revealAndSelectItem):
        (WebInspector.AbstractTimelinePanel.prototype.sortItems):
        (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition):
        (WebInspector.AbstractTimelineCategory):
        (WebInspector.AbstractTimelineCategory.prototype.toString):
        * inspector/front-end/ResourceCategory.js:
        (WebInspector.ResourceCategory):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):
        (WebInspector.ResourcesPanel.prototype.createItemTreeElement):
        (WebInspector.ResourcesPanel.prototype.createItemGraph):
        (WebInspector.ResourcesPanel.prototype.isCategoryVisible):
        (WebInspector.ResourcesPanel.prototype.populateSidebar):
        (WebInspector.ResourcesPanel.prototype.get searchableViews):
        (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction.sortFuction):
        (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction):
        (WebInspector.ResourcesPanel.prototype.searchMatchFound):
        (WebInspector.ResourcesPanel.prototype.searchCanceled):
        (WebInspector.ResourcesPanel.prototype.performSearch):
        (WebInspector.ResourcesPanel.prototype.refresh):
        (WebInspector.ResourcesPanel.prototype.reset):
        (WebInspector.ResourcesPanel.prototype.removeResource):
        (WebInspector.ResourcesPanel.prototype.addMessageToResource):
        (WebInspector.ResourcesPanel.prototype.clearMessages):
        (WebInspector.ResourcesPanel.prototype.refreshResource):
        (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
        (WebInspector.ResourcesPanel.prototype.showResource):
        (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded):
        (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
        (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
        (WebInspector.ResourcesPanel.prototype.get _resources):
        (WebInspector.ResourceTimeCalculator.prototype._upperBound):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype.get categories):
        (WebInspector.TimelinePanel.prototype.populateSidebar):
        (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
        (WebInspector.TimelinePanel.prototype.createItemTreeElement):
        (WebInspector.TimelinePanel.prototype.createItemGraph):
        (WebInspector.TimelinePanel.prototype._formatRecord):
        (WebInspector.TimelineCategory):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Oliver Hunt.
kenneth@webkit.org [Wed, 28 Oct 2009 21:05:31 +0000 (21:05 +0000)]
Rubberstamped by Oliver Hunt.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Fix the warning:

"warning: ignoring return value of 'char* getcwd(char*, size_t)',
declared with attribute warn_unused_result".

by actually checking the result. In the case it is null, an
error has occoured, so treat it as the other fatal errors.

* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::initializeFonts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50235 268f45cc-cd09-0410-ab3c-d52691b4dbfc