WebKit-https.git
10 years ago2010-07-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 6 Jul 2010 03:34:13 +0000 (03:34 +0000)]
2010-07-05  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        We were discussing this test case, so I figured I might as well add it
        to the suite.

        * html5lib/resources/webkit01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
        * html5lib/webkit-resumer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Gyuyoung Kim <gyuyoung.kim@samsung.com>
commit-queue@webkit.org [Tue, 6 Jul 2010 03:11:53 +0000 (03:11 +0000)]
2010-07-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Implement downloadURL in ContextMenuClientEfl
        When user selects a download menu from context menu, send the download
        request to application.
        https://bugs.webkit.org/show_bug.cgi?id=41149

        * efl/WebCoreSupport/ContextMenuClientEfl.cpp:
        (WebCore::ContextMenuClientEfl::downloadURL): Get url for downloading
        file and Send it to application.
        * efl/WebCoreSupport/ContextMenuClientEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Fady Samuel <fsamuel@chromium.org>
commit-queue@webkit.org [Tue, 6 Jul 2010 02:03:30 +0000 (02:03 +0000)]
2010-07-05  Fady Samuel  <fsamuel@chromium.org>

        Reviewed by Darin Adler.

        Fixed a svg crash when setting class of an svg ellipse object.

        Altering the CSS class of an attached SVG element causes WebKit to crash
        https://bugs.webkit.org/show_bug.cgi?id=40857

        * platform/chromium-linux/svg/css/svg-ellipse-render-crash-expected.txt: Added.
        * svg/css/svg-ellipse-render-crash.html: Added.
2010-07-05  Fady Samuel  <fsamuel@chromium.org>

        Reviewed by Darin Adler.

        Fixed a svg crash when setting class of an svg ellipse object.

        Altering the CSS class of an attached SVG element causes WebKit to crash
        https://bugs.webkit.org/show_bug.cgi?id=40857

        Test: svg/css/svg-ellipse-render-crash.html

        * dom/StyledElement.cpp:
        (WebCore::StyledElement::classAttributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReproducible crash with Optimize Legibility extension
mitz@apple.com [Tue, 6 Jul 2010 01:06:05 +0000 (01:06 +0000)]
Reproducible crash with Optimize Legibility extension
https://bugs.webkit.org/show_bug.cgi?id=41585

Reviewed by Sam Weinig.

WebCore:

Test: fast/css/text-rendering-priority.html

Moved the text-rendering CSS property to the “high priority” group, because applying it
during style selection invalidates the font.

* css/CSSPropertyNames.in: Moved text-rendering to the “high priority” section at the top.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyDeclarations): Updated compile-time assertion.

LayoutTests:

* fast/css/text-rendering-priority-expected.txt: Added.
* fast/css/text-rendering-priority.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash reading past end of block in UniscribeController::shapeAndPlaceItem
alice.liu@apple.com [Tue, 6 Jul 2010 00:53:14 +0000 (00:53 +0000)]
Crash reading past end of block in UniscribeController::shapeAndPlaceItem
https://bugs.webkit.org/show_bug.cgi?id=41554

Reviewed by Dan Bernstein.

* platform/win/fast/text/uniscribe-item-boundary-crash-expected.txt: Added.
* platform/win/fast/text/uniscribe-item-boundary-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=41641
barraclough@apple.com [Tue, 6 Jul 2010 00:22:42 +0000 (00:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=41641

Reviewed by Sam Weinig.

Update compile flags to allow use of ExecutableAllocatorFixedVMPool on platforms
other than x86-64 (this may be useful on 32-bit platforms, too).

Simplify ifdefs by dividing into thwo broad allocation strategies
(ENABLE_EXECUTABLE_ALLOCATOR_FIXED & ENABLE_EXECUTABLE_ALLOCATOR_DEMAND).

Rename constant used in the code to have names descriptive of their purpose,
rather than their specific value on a given platform.

* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::reprotectRegion):
(JSC::ExecutableAllocator::cacheFlush):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::free):
(JSC::ExecutablePool::systemAlloc):
* jit/ExecutableAllocatorPosix.cpp:
* jit/ExecutableAllocatorSymbian.cpp:
* jit/ExecutableAllocatorWin.cpp:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agooptimizeLegibility doesn't play nice with fonts that do not have a space glyph
mitz@apple.com [Tue, 6 Jul 2010 00:11:08 +0000 (00:11 +0000)]
optimizeLegibility doesn't play nice with fonts that do not have a space glyph
https://bugs.webkit.org/show_bug.cgi?id=41599

Reviewed by Sam Weinig.

No test because none of the fonts available to DumpRenderTree are missing a space glyph.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak): When the font does not map the space character
to a glyph, a fallback font is used for space. Therefore, wordTrailingSpaceWidth must be
initialized with the width of a space as measured by the Font rather than with the cached
space width.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Mon, 5 Jul 2010 21:39:21 +0000 (21:39 +0000)]
2010-07-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Implement HTML5's "reset insertion mode appropriately"
        https://bugs.webkit.org/show_bug.cgi?id=41628

        This has some minimal testing.  One from my previous
        </table> patch, and a few from the main suite.

        Mostly resetInsertionModeAppropriately isn't used yet
        but we're about to add a bunch of states which do use it
        and our test coverage will expand further as we do.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
        (WebCore::HTMLTreeBuilder::setInsertionModeAndEnd):
        (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
        * html/HTMLTreeBuilder.h:
2010-07-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Implement HTML5's "reset insertion mode appropriately"
        https://bugs.webkit.org/show_bug.cgi?id=41628

        Fixes a bunch of subtests!

        * html5lib/runner-expected-html5.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Mon, 5 Jul 2010 21:34:06 +0000 (21:34 +0000)]
2010-07-05  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed build fix for r62503.

        Chromium missing method. Filed bug 41632 to track.

        * loader/appcache/ApplicationCacheHost.h:
        (WebCore::ApplicationCacheHost::applicationCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Mon, 5 Jul 2010 21:25:13 +0000 (21:25 +0000)]
2010-07-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add </table> support for "in table" insertion mode
        https://bugs.webkit.org/show_bug.cgi?id=41591

        resetInsertionModeAppropriately isn't implemented yet, however
        I've added a test for the usage I added.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
        (WebCore::HTMLTreeBuilder::processEndTag):
        * html/HTMLTreeBuilder.h:
2010-07-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add </table> support for "in table" insertion mode
        https://bugs.webkit.org/show_bug.cgi?id=41591

        Add tests for </table> in "in table" mode, and
        one for ignored close tags.

        * html5lib/resources/tables01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Mon, 5 Jul 2010 21:08:36 +0000 (21:08 +0000)]
2010-07-05  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed build fix for r62503.

        Missed GTK's build file.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Mon, 5 Jul 2010 21:00:23 +0000 (21:00 +0000)]
2010-07-05  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed build fix for r62503.

        Pass a blank ResourceResponse instead of passing 0.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::createResourceHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Mon, 5 Jul 2010 20:47:04 +0000 (20:47 +0000)]
2010-07-05  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed build fix for r62503.

        Forward declare ApplicationCache for Chromium.

        * loader/appcache/ApplicationCacheHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Mon, 5 Jul 2010 20:32:47 +0000 (20:32 +0000)]
2010-07-05  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)
        https://bugs.webkit.org/show_bug.cgi?id=24529

        Parts of this patch were written by Kavita Kanetkar <kkanetkar@chromium.org>.

        Part 2: Pulling ApplicationCache Resources to Display in the Inspector.

          The InspectorApplicationCacheAgent gathers the information it
          needs and forwards it on to the inspector.

        * inspector/InspectorApplicationCacheAgent.cpp:
        (WebCore::InspectorApplicationCacheAgent::fillResourceList): get information about the resources.
        (WebCore::InspectorApplicationCacheAgent::getApplicationCaches): gathers all the information from the ApplicationCacheHost.
        (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):
        (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
        (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
        * inspector/InspectorApplicationCacheAgent.h: defines structures to hold information about caches and resources.
        (WebCore::InspectorApplicationCacheAgent::ApplicationCacheInfo::ApplicationCacheInfo):
        (WebCore::InspectorApplicationCacheAgent::ResourceInfo::ResourceInfo):
        (WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent):
        * loader/appcache/ApplicationCacheHost.h:
        (WebCore::ApplicationCacheHost::applicationCacheForInspector): new convention, public cache accessor for the inspector.
        (WebCore::ApplicationCacheHost::documentLoader): added const.

          The User Interface uses a DataGrid, like Cookies.

        * inspector/front-end/ApplicationCacheItemsView.js:
        (WebInspector.ApplicationCacheItemsView.prototype._update):
        (WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
        (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):
        (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid.numberCompare):
        (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid.localeCompare):
        (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):

          The usual frontend pull workflow, except this goes through
          InspectorApplicationCacheAgent instead of InspectorController.

        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getApplicationCaches):
        (WebCore::InspectorBackend::inspectorApplicationCacheAgent):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::didGetApplicationCaches):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype.hasChildNodes): style fix.
        (WebInspector.DOMAgent.prototype.nodeForId): style fix.
        (WebInspector.ApplicationCache.getApplicationCachesAsync): pull.
        (WebInspector.Cookies.getCookiesAsync):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.updateManifest):
        (WebInspector.ApplicationCacheSidebarTreeElement.prototype.onselect):
        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):
        (WebInspector._addAppCacheDomain):
        (WebInspector.reset):

          Miscellaneous. Localized Strings and fixes.

        * English.lproj/localizedStrings.js: "Type", "%s (%s)"
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::deleteCookie):
        * inspector/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Mon, 5 Jul 2010 20:32:30 +0000 (20:32 +0000)]
2010-07-04  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)
        https://bugs.webkit.org/show_bug.cgi?id=24529

        Part 1: Backend -> Frontend Messages. ApplicationCache Status and Connectivity Status.

        This patch adds an InspectorApplicationCacheAgent to monitor application
        cache changes, starts a UI in the Storage panel, handles the boilerplate
        of adding new files.

          Added an agent to encapsulate and handle the application cache logic.
          This is similar to the timeline agent.

        * inspector/InspectorApplicationCacheAgent.cpp: Added.
        (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
        (WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent):
        (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
        (WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
        (WebCore::InspectorApplicationCacheAgent::updateNetworkState):
        * inspector/InspectorApplicationCacheAgent.h: Added.

          InspectorController owns an InspectorApplicationCacheAgent. This
          handles its lifetime management.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::connectFrontend): create the agent with a frontend.
        (WebCore::InspectorController::disconnectFrontend): remove the agent when closing.
        (WebCore::InspectorController::releaseFrontendLifetimeAgents):
        * inspector/InspectorController.h:

          User Interface for ApplicationCache in the StoragePanel. This follows
          very closely to Cookies, it will have a sortable table of items. The
          status bar contains connectivity and application cache status
          indicators which update when backend messages are received. There
          are some stubs which the next part will implement.

        * inspector/front-end/ApplicationCacheItemsView.js: Added.
        (WebInspector.ApplicationCacheItemsView):
        (WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems): refresh, delete, connectivity, application cache status.
        (WebInspector.ApplicationCacheItemsView.prototype.show):
        (WebInspector.ApplicationCacheItemsView.prototype.hide):
        (WebInspector.ApplicationCacheItemsView.prototype.updateStatus): this is the application cache status indicator.
        (WebInspector.ApplicationCacheItemsView.prototype.updateNetworkState): this is the online/offline connectivity indicator.
        (WebInspector.ApplicationCacheItemsView.prototype._update):
        (WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
        (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):
        (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
        (WebInspector.ApplicationCacheItemsView.prototype.resize):
        (WebInspector.ApplicationCacheItemsView.prototype._deleteButtonClicked):
        (WebInspector.ApplicationCacheItemsView.prototype._deleteCallback):
        (WebInspector.ApplicationCacheItemsView.prototype._refreshButtonClicked):

          The usual dispatch flow from the backend, to the frontend, to the
          panel, and then to the visible view. Some slight refactoring to
          eliminate duplicated code.

        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::updateDOMStorage):
        (WebCore::InspectorFrontend::didGetApplicationCaches):
        (WebCore::InspectorFrontend::updateApplicationCacheStatus):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel):
        (WebInspector.StoragePanel.prototype.reset):
        (WebInspector.StoragePanel.prototype.addApplicationCache):
        (WebInspector.StoragePanel.prototype.showDatabase):
        (WebInspector.StoragePanel.prototype.showDOMStorage):
        (WebInspector.StoragePanel.prototype.showCookies):
        (WebInspector.StoragePanel.prototype.showApplicationCache):
        (WebInspector.StoragePanel.prototype._genericViewSetup):
        (WebInspector.StoragePanel.prototype.updateApplicationCacheStatus):
        (WebInspector.StoragePanel.prototype.updateNetworkState):
        (WebInspector.CookieSidebarTreeElement.prototype.set subtitle):
        (WebInspector.ApplicationCacheSidebarTreeElement):
        (WebInspector.ApplicationCacheSidebarTreeElement.prototype.onselect):
        (WebInspector.ApplicationCacheSidebarTreeElement.prototype.get mainTitle):
        (WebInspector.ApplicationCacheSidebarTreeElement.prototype.set mainTitle):
        (WebInspector.ApplicationCacheSidebarTreeElement.prototype.get subtitle):
        (WebInspector.ApplicationCacheSidebarTreeElement.prototype.set subtitle):
        * inspector/front-end/inspector.js:
        (WebInspector.dispatch.delayDispatch):
        (WebInspector.dispatch):
        (WebInspector._addAppCacheDomain):
        (WebInspector.addDOMStorage):
        (WebInspector.updateDOMStorage):

          Notify the InspectorApplicationCacheAgent on application cache changes
          or specifics. Notify the InspectorController on generic resource events.
          That is because ApplicationCacheController is a ResourceClient and needs
          to trigger the resource events normally handled by ResourceLoader.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::inspectorUpdateApplicationCacheStatus): helper method to prevent duplicated code.
        (WebCore::ApplicationCacheGroup::setNewestCache): status change.
        (WebCore::ApplicationCacheGroup::makeObsolete): status change.
        (WebCore::ApplicationCacheGroup::update): status change.
        (WebCore::ApplicationCacheGroup::createResourceHandle): resource event.
        (WebCore::ApplicationCacheGroup::willSendRequest): resource event.
        (WebCore::ApplicationCacheGroup::didReceiveResponse): resource event.
        (WebCore::ApplicationCacheGroup::didReceiveData): resource event.
        (WebCore::ApplicationCacheGroup::didFinishLoading): resource event.
        (WebCore::ApplicationCacheGroup::didFail): resource event.
        (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): resource event.
        (WebCore::ApplicationCacheGroup::manifestNotFound): status change.
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): status change.
        (WebCore::ApplicationCacheGroup::setUpdateStatus): single access point for status changes.
        * loader/appcache/ApplicationCacheGroup.h:
        * page/Page.cpp:
        (WebCore::networkStateChanged): connectivity status change.

          Final inspector details to add the new file, style new elements,
          images, and localized strings.

        * inspector/front-end/inspector.css:
        (.application-cache-sidebar-tree-item .icon):
        (.timeline-records-counter, .storage-application-cache-status, .storage-application-cache-connectivity):
        (.storage-application-cache-status-icon, .storage-application-cache-connectivity-icon):
        (.status-bar-divider):
        (.storage-application-cache-status, .storage-application-cache-connectivity):
        * inspector/front-end/inspector.html:
        * inspector/front-end/Images/applicationCache.png: Added.
        * English.lproj/localizedStrings.js: "APPLICATION CACHE", "No Application Cache information available.", "Online", "Offline"

          Updated build files.

        * CMakeLists.txt:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue@webkit.org [Mon, 5 Jul 2010 20:17:57 +0000 (20:17 +0000)]
2010-07-05  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] WebKit2 triple click
        https://bugs.webkit.org/show_bug.cgi?id=41629

        QtWebkit2 triple click implementation.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::mousePressEvent):
        (QWKPagePrivate::mouseDoubleClickEvent):
        (QWKPage::timerEvent):
        * UIProcess/API/qt/qwkpage.h:
        * UIProcess/API/qt/qwkpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Mon, 5 Jul 2010 20:03:45 +0000 (20:03 +0000)]
2010-07-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add basic <col> support to the treebuilder
        https://bugs.webkit.org/show_bug.cgi?id=41590

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
2010-07-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add basic <col> support to the treebuilder
        https://bugs.webkit.org/show_bug.cgi?id=41590

        Test the new <col> support. Turns out the old treebuilder doesn't
        handle <table><col> correctly.

        * html5lib/resources/tables01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Mon, 5 Jul 2010 20:02:11 +0000 (20:02 +0000)]
2010-07-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add basic "in row" mode to support <td> and <th> insertion
        https://bugs.webkit.org/show_bug.cgi?id=41588

        Also fixed <td> or <th> as a direct child of <table>.

        Most of this was covered by html5lib/runner.html tests,
        but I had to add a new tables01.dat to cover the <th> cases.

        * html/HTMLElementStack.cpp:
        (WebCore::HTMLNames::isTableRowScopeMarker):
        (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
        * html/HTMLElementStack.h:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
2010-07-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add basic "in row" mode to support <td> insertion
        https://bugs.webkit.org/show_bug.cgi?id=41588

        Added tables01.dat to test a previously untested
        <table><th> case.  I expect we'll add many more table
        tests there as we complete our implementation.

        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
        * html5lib/runner.html:
        * html5lib/resources/tables01.dat: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 5 Jul 2010 19:42:01 +0000 (19:42 +0000)]
2010-07-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Finish implementing "any other end tag" for "in body" mode
        https://bugs.webkit.org/show_bug.cgi?id=41582

        * html5lib/resources/inbody01.dat: Added.
        * html5lib/runner-expected-html5.txt:
         - Update the one result which was affected by this.
           That test would pass if we had text node coalescing.
        * html5lib/runner-expected.txt:
         - Update to add the extra test suite.
        * html5lib/runner.html:

2010-07-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Finish implementing "any other end tag" for "in body" mode
        https://bugs.webkit.org/show_bug.cgi?id=41582

        I believe I found a "bug" in the HTML5 spec when writing this:
        http://www.w3.org/Bugs/Public/show_bug.cgi?id=10080

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
        (WebCore::HTMLTreeBuilder::processEndTag):
        * html/HTMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 5 Jul 2010 18:32:03 +0000 (18:32 +0000)]
2010-07-05  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Add a missing slash to the list of generated sources. This
        was missing from a previous build fix.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 5 Jul 2010 18:04:26 +0000 (18:04 +0000)]
2010-07-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: preserve scroll positions in source frame when switching between panes.

        https://bugs.webkit.org/show_bug.cgi?id=41620

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.hide):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.set visible):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype.hide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Yury Semikhatsky <yury@yurys-imac.local>
yurys@chromium.org [Mon, 5 Jul 2010 17:57:55 +0000 (17:57 +0000)]
2010-07-05  Yury Semikhatsky  <yury@yurys-imac.local>

        Unreviewed. Provide Chromium specific expectations for new svg tests.

        * platform/chromium-linux/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/filter-width-update-expected.checksum: Added.
        * platform/chromium-mac/svg/filters/filter-width-update-expected.checksum: Added.
        * platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
        * platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.png: Added.
        * platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.txt: Added.
        * platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
        * platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.png: Added.
        * platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.txt: Added.
        * platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
        * platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
        * platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
        * platform/chromium-win/svg/filters/filter-width-update-expected.checksum: Added.
        * platform/chromium-win/svg/filters/filter-width-update-expected.png: Added.
        * platform/chromium-win/svg/filters/filter-width-update-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
commit-queue@webkit.org [Mon, 5 Jul 2010 17:50:38 +0000 (17:50 +0000)]
2010-07-05  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Antti Koivisto.

        [Qt] Initial WebKit2 implementation
        https://bugs.webkit.org/show_bug.cgi?id=40233

        Add stubs

        * UIProcess/Plugins/qt/PluginInfoStoreQt.cpp: Copied from WebKit2/UIProcess/Plugins/win/PluginInfoStoreWin.cpp.
        (WebKit::PluginInfoStore::pluginDirectories):
        (WebKit::PluginInfoStore::pluginPathsInDirectory):
        (WebKit::PluginInfoStore::getPluginInfo):
        (WebKit::PluginInfoStore::shouldUsePlugin):
        * WebProcess/InjectedBundle/InjectedBundle.h:
        * WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Added.
        (WebKit::InjectedBundle::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Steve Block <steveblock@google.com>
steveblock@google.com [Mon, 5 Jul 2010 17:10:03 +0000 (17:10 +0000)]
2010-07-05  Steve Block  <steveblock@google.com>

        Reviewed by Darin Adler.

        ThreadingPthreads.cpp should use JNIUtility.h on Android, not outdated jni_utility.h
        https://bugs.webkit.org/show_bug.cgi?id=41594

        * wtf/ThreadingPthreads.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Mon, 5 Jul 2010 17:01:59 +0000 (17:01 +0000)]
2010-07-05  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Dirk Schulze.

        IE SVG test fails
        https://bugs.webkit.org/show_bug.cgi?id=41619

        Make SVGSVGElement.createSVGTransform create a SVGTransform with the
        right type, thereby fixing the IE test.

        Test: svg/custom/svg-createsvgtransform-type.html

        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::createSVGTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
commit-queue@webkit.org [Mon, 5 Jul 2010 16:54:48 +0000 (16:54 +0000)]
2010-07-05  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Antti Koivisto.

        [Qt] Initial WebKit2 implementation
        https://bugs.webkit.org/show_bug.cgi?id=40233

        Add WebErrorsQt

        * WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Added.
        (WebKit::):
        (WebKit::cancelledError):
        (WebKit::blockedError):
        (WebKit::cannotShowURLError):
        (WebKit::interruptForPolicyChangeError):
        (WebKit::cannotShowMIMETypeError):
        (WebKit::fileDoesNotExistError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 5 Jul 2010 15:29:26 +0000 (15:29 +0000)]
2010-07-05  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Oliver Hunt.

        The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
        https://bugs.webkit.org/show_bug.cgi?id=41017

        * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
        * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 5 Jul 2010 15:12:10 +0000 (15:12 +0000)]
2010-07-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: computed style pane is not updated when styles pane is collapsed.

        https://bugs.webkit.org/show_bug.cgi?id=41615

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.updateStyles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 5 Jul 2010 14:32:20 +0000 (14:32 +0000)]
2010-07-05  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Logic to track whether elements are using relative lengths is incomplete
        https://bugs.webkit.org/show_bug.cgi?id=41566

        Add logic to all SVG elements which create renderes to expose a method
        "bool selfHasRelativeLengths()", that returns whether the element uses relative
        lengths (eg. <rect x="50%"...). This will be used soon to avoid relayouts of
        container children, when the bounds have not changed.

        A new method SVGStyledElement::updateRelativeLengthsInformation() is added,
        which is called from the various svgAttributeChanged() methods and insertedIntoDocument/removedFromDocument.
        It will be implemented in a follow-up patch. This patch does not affect any test behaviour related
        to relayouting. As SVGFilterElement finally got a proper svgAttributeChanged() method, it now
        properly invalidates clients on attribute changes - covered by a new test.

        Tests: svg/custom/relative-sized-inner-svg.xhtml
               svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml
               svg/filters/filter-width-update.svg

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::layout): Rename hasRelativeValues to hasRelativeLengths.
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::layout): Ditto.
        (WebCore::RenderSVGRoot::calcViewport): Ditto.
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::calcViewport): Ditto
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::layoutChildren): Ditto.
        * svg/SVGCircleElement.cpp:
        (WebCore::SVGCircleElement::svgAttributeChanged): Call updateRelativeLengthsInformation() if any attribute which may contain relative lengths changes.
        (WebCore::SVGCircleElement::selfHasRelativeLengths): Ditto. Same for all other SVG*Elements below.
        * svg/SVGCircleElement.h:
        * svg/SVGEllipseElement.cpp:
        (WebCore::SVGEllipseElement::svgAttributeChanged):
        (WebCore::SVGEllipseElement::selfHasRelativeLengths):
        * svg/SVGEllipseElement.h:
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::svgAttributeChanged):
        (WebCore::SVGFilterElement::selfHasRelativeLengths):
        * svg/SVGFilterElement.h:
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::SVGForeignObjectElement::svgAttributeChanged):
        (WebCore::SVGForeignObjectElement::selfHasRelativeLengths):
        * svg/SVGForeignObjectElement.h:
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::svgAttributeChanged):
        (WebCore::SVGImageElement::selfHasRelativeLengths):
        * svg/SVGImageElement.h:
        * svg/SVGLineElement.cpp:
        (WebCore::SVGLineElement::svgAttributeChanged):
        (WebCore::SVGLineElement::selfHasRelativeLengths):
        * svg/SVGLineElement.h:
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::svgAttributeChanged):
        (WebCore::SVGLinearGradientElement::selfHasRelativeLengths):
        * svg/SVGLinearGradientElement.h:
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::svgAttributeChanged):
        (WebCore::SVGMarkerElement::selfHasRelativeLengths):
        * svg/SVGMarkerElement.h:
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::svgAttributeChanged):
        (WebCore::SVGMaskElement::selfHasRelativeLengths):
        * svg/SVGMaskElement.h:
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::svgAttributeChanged):
        (WebCore::SVGPatternElement::selfHasRelativeLengths):
        * svg/SVGPatternElement.h:
        * svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::svgAttributeChanged):
        (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):
        * svg/SVGRadialGradientElement.h:
        * svg/SVGRectElement.cpp:
        (WebCore::SVGRectElement::svgAttributeChanged):
        (WebCore::SVGRectElement::selfHasRelativeLengths):
        * svg/SVGRectElement.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::svgAttributeChanged):
        (WebCore::SVGSVGElement::selfHasRelativeLengths):
        * svg/SVGSVGElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::insertedIntoDocument): Call updateRelativeLengthsInformation().
        (WebCore::SVGStyledElement::removedFromDocument): Ditto.
        (WebCore::SVGStyledElement::updateRelativeLengthsInformation): Not implemented so far. Will land in a follow-up patch, together with the render tree changes.
        * svg/SVGStyledElement.h:
        (WebCore::SVGStyledElement::hasRelativeLengths): Devirtualized. For now, just call selfHasRelativeLengths() - this will change in a follow-up patch.
        (WebCore::SVGStyledElement::updateRelativeLengthsInformation):
        (WebCore::SVGStyledElement::selfHasRelativeLengths): Renamed from hasRelativeValues().
        * svg/SVGSymbolElement.cpp:
        (WebCore::SVGSymbolElement::svgAttributeChanged):
        (WebCore::SVGSymbolElement::selfHasRelativeLengths):
        * svg/SVGSymbolElement.h:
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::selfHasRelativeLengths):
        * svg/SVGTextContentElement.h:
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::svgAttributeChanged):
        (WebCore::SVGTextPathElement::insertedIntoDocument): Call right base class' method. Skipped one in the hierachy before.
        (WebCore::SVGTextPathElement::selfHasRelativeLengths):
        * svg/SVGTextPathElement.h:
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::svgAttributeChanged):
        (WebCore::listContainsRelativeValue): New helper funtion that checks wheter a SVGLengthList contains relative lengths.
        (WebCore::SVGTextPositioningElement::selfHasRelativeLengths):
        * svg/SVGTextPositioningElement.h:
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::insertedIntoDocument): Call right base class' method. Skipped on in the hierachy before.
        (WebCore::SVGUseElement::removedFromDocument): Ditto.
        (WebCore::SVGUseElement::svgAttributeChanged):
        (WebCore::SVGUseElement::buildShadowAndInstanceTree): Call updateRelativeLengthsInformation() after building the shadow tree.
        (WebCore::SVGUseElement::selfHasRelativeLengths): Same as all other methods, except that it includes the shadow tree root element.
        * svg/SVGUseElement.h:

2010-07-05  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Logic to track whether elements are using relative lengths is incomplete
        https://bugs.webkit.org/show_bug.cgi?id=41566

        Add two new relative-sized-*.svg tests that would break, when relative sized kids aren't layout correctly.
        Add new test covering that filters update their clients, if any attribute changes.

        * platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
        * platform/mac/svg/custom/relative-sized-inner-svg-expected.png: Added.
        * platform/mac/svg/custom/relative-sized-inner-svg-expected.txt: Added.
        * platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
        * platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
        * platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
        * platform/mac/svg/filters/filter-width-update-expected.checksum: Added.
        * platform/mac/svg/filters/filter-width-update-expected.png: Added.
        * platform/mac/svg/filters/filter-width-update-expected.txt: Added.
        * svg/custom/relative-sized-inner-svg.xhtml: Added.
        * svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml: Added.
        * svg/filters/filter-width-update.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 5 Jul 2010 14:23:51 +0000 (14:23 +0000)]
2010-07-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Problem with copying a code from Scripts panel.

        https://bugs.webkit.org/show_bug.cgi?id=40432

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._getSelection):
        (WebInspector.TextViewer.prototype._selectionToPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
commit-queue@webkit.org [Mon, 5 Jul 2010 14:07:13 +0000 (14:07 +0000)]
2010-07-05  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Antti Koivisto.

        [Qt] Initial WebKit2 implementation
        https://bugs.webkit.org/show_bug.cgi?id=40233

        Add Qt C API integration.

        * UIProcess/API/cpp/qt/WKStringQt.cpp: Added.
        (WKStringCreateWithQString):
        (WKStringCopyQString):
        * UIProcess/API/cpp/qt/WKStringQt.h: Added.
        * UIProcess/API/cpp/qt/WKURLQt.cpp: Added.
        (WKURLCreateWithQUrl):
        (WKURLCopyQUrl):
        * UIProcess/API/cpp/qt/WKURLQt.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
commit-queue@webkit.org [Mon, 5 Jul 2010 13:41:42 +0000 (13:41 +0000)]
2010-07-05  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Antti Koivisto.

        [Qt] Initial WebKit2 implementation
        https://bugs.webkit.org/show_bug.cgi?id=40233

        Add the Qt process launcher.

        * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Added.
        (WebKit::ProcessLauncher::launchProcess):
        (WebKit::ProcessLauncher::terminateProcess):
        (WebKit::webThreadBody):
        (WebKit::ProcessLauncher::createWebThread):
        (webProcessMain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 5 Jul 2010 12:48:28 +0000 (12:48 +0000)]
2010-07-05  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze / Darin Adler.

        Node.cloneNode does not work on SVG nodes
        https://bugs.webkit.org/show_bug.cgi?id=41421

        Be sure to synchronize animated SVG properties before checking whether NamedNodeMap exists.
        When creating a SVG element from JS, and setting all attributes via SVG DOM, and not using setAttribute
        the NamedNodeMap does not exist. When cloning such an element, be sure to synchronize SVG <-> XML DOM
        attributes before attempting to clone, otherwhise the SVG animated properties are lost while cloning.

        Test: svg/custom/clone-element-with-animated-svg-properties.html

        * dom/Element.cpp:
        (WebCore::Element::cloneElementWithoutChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert unplanned project file change.
antti.j.koivisto@nokia.com [Mon, 5 Jul 2010 12:31:33 +0000 (12:31 +0000)]
Revert unplanned project file change.

.:

* WebKit.pro:

WebCore:

* WebCore.pri:
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 5 Jul 2010 12:27:35 +0000 (12:27 +0000)]
2010-07-05  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Darin Adler.

        Memory corruption with SVG <use> element
        https://bugs.webkit.org/show_bug.cgi?id=40994

        Fix race condition in svgAttributeChanged. Never call svgAttributeChanged() from attributeChanged()
        when we're synchronizing SVG attributes. It leads to either unnecessary extra work being done or
        crashes. Especially together with <polyline>/<polygon> which always synchronize the SVGAnimatedPoints
        datastructure with the points attribute, no matter if there are changes are not. This should be
        furhter optimized, but this fix is sane and fixes the root of the evil races.

        Test: svg/custom/use-property-synchronization-crash.svg

        * svg/SVGElement.cpp:
        (WebCore::SVGElement::attributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Initial WebKit2 implementation
antti.j.koivisto@nokia.com [Mon, 5 Jul 2010 12:26:10 +0000 (12:26 +0000)]
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement ChunkedUpdateDrawingArea + Proxy for Qt. Not built yet.

* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* UIProcess/qt: Added.
* UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: Added.
(WebKit::ChunkedUpdateDrawingAreaProxy::page):
(WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::invalidateBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
* WebProcess/WebPage/qt: Added.
* WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp: Added.
(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 5 Jul 2010 10:50:58 +0000 (10:50 +0000)]
2010-07-04  MORITA Hajime  <morrita@google.com>

        rebaseline-chromium-webkit-tests: UnicodeDecodeError
        https://bugs.webkit.org/show_bug.cgi?id=41589

        * run() method can result non-utf-8 bytes, that causes utf-8
          decoding fail.  Fixed to disable decoding.
        * Fixed Git.find_checkout_root() to make a test pass.

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 5 Jul 2010 10:05:44 +0000 (10:05 +0000)]
2010-07-05  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js
        https://bugs.webkit.org/show_bug.cgi?id=41595

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
2010-07-05  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js
        https://bugs.webkit.org/show_bug.cgi?id=41595

        * src/js/DebuggerScript.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Mon, 5 Jul 2010 10:03:35 +0000 (10:03 +0000)]
2010-07-04  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Dirk Schulze.

        SVG polygons should draw polygons up to the first parsing error
        https://bugs.webkit.org/show_bug.cgi?id=41140

        Render polygons up until the first parsing error.

        Test: svg/custom/poly-parsing-error.html

        * svg/SVGPolyElement.cpp:
        (WebCore::SVGPolyElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash reading past end of block in UniscribeController::shapeAndPlaceItem
alice.liu@apple.com [Mon, 5 Jul 2010 07:32:54 +0000 (07:32 +0000)]
Crash reading past end of block in UniscribeController::shapeAndPlaceItem
https://bugs.webkit.org/show_bug.cgi?id=41554

Reviewed by Dan Bernstein.

Test: platform/win/fast/text/uniscribe-item-boundary-crash.html

* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem):
Don't look one past the end of str. Instead look to the next item, if applicable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-23 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 5 Jul 2010 07:18:20 +0000 (07:18 +0000)]
2010-06-23  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GStreamer] on Mac OS use a runloop observer to process the glib context iterations
        https://bugs.webkit.org/show_bug.cgi?id=35747

        If VIDEO and GSTREAMER are enabled, make the WebView start a
        runloop observer that will trigger the glib main context
        iterations. Those are needed by the GStreamer player only at the
        moment but could later be used for other GLib-dependant components
        if required.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        (-[WebView _close]):
        (-[WebView _clearGlibLoopObserver]):
        (glibContextIterationCallback):
        (-[WebView _scheduleGlibContextIterations]):
        * WebView/WebViewData.h:
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 5 Jul 2010 06:56:27 +0000 (06:56 +0000)]
2010-07-04  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Mark fast/js/function-apply-many-args.html as
        having wrong output in debug mode.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 5 Jul 2010 04:45:30 +0000 (04:45 +0000)]
2010-07-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add basic "in table body" mode to support <tr> insertion
        https://bugs.webkit.org/show_bug.cgi?id=41587

        * html5lib/runner-expected-html5.txt:
         - <tr> tags now show up, imagine that.
2010-07-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add basic "in table body" mode to support <tr> insertion
        https://bugs.webkit.org/show_bug.cgi?id=41587

        This also adds a (currently untestable?)
        popUntilTableBodyScopeMarker code path.
        Any tags which would be between a tbody a <tr> would end up
        foster parented outside the <table>.  I think the spec was
        just being over-cautious with popUntilTableBodyScopeMarker.

        * html/HTMLElementStack.cpp:
        (WebCore::HTMLNames::isTableScopeMarker):
        (WebCore::HTMLNames::isTableBodyScopeMarker):
        (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
        * html/HTMLElementStack.h:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Update Chromium test expectations.
pkasting@chromium.org [Mon, 5 Jul 2010 02:37:57 +0000 (02:37 +0000)]
Unreviewed.  Update Chromium test expectations.

* platform/chromium-mac/html5lib/runner-expected.txt:
* platform/chromium-win/html5lib/runner-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows build.
andersca@apple.com [Sun, 4 Jul 2010 23:27:19 +0000 (23:27 +0000)]
Fix Windows build.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd simple command line parser and pass mode argument to the web process
andersca@apple.com [Sun, 4 Jul 2010 23:15:51 +0000 (23:15 +0000)]
Add simple command line parser and pass mode argument to the web process
https://bugs.webkit.org/show_bug.cgi?id=41586

Reviewed by Dan Bernstein.

* Shared/CommandLine.h:
(WebKit::CommandLine::operator[]):
Add CommandLine class.

* Shared/mac/CommandLineMac.cpp:
(WebKit::CommandLine::parse):
Implement Mac version of CommandLine::parse.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
Add "legacywebprocess" mode to the posix_spawn call.

* WebKit2.xcodeproj/project.pbxproj:
Add CommandLine to the xcode project.

* WebProcess/Launching/mac/WebProcessMain.mm:
(webProcessMain):
(main):
Parse the command line and check the mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 4 Jul 2010 22:06:18 +0000 (22:06 +0000)]
2010-07-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTMLTreeBuilder needs an adoption agency
        https://bugs.webkit.org/show_bug.cgi?id=41453

        Fix Qt Minimal build.  SVGNames.h should always
        be generated, even when SVG is off, however that's
        not how things currently work.

        * html/HTMLTreeBuilder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 4 Jul 2010 21:54:59 +0000 (21:54 +0000)]
2010-07-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add a very basic InTable insertion mode
        https://bugs.webkit.org/show_bug.cgi?id=41581

        * html5lib/runner-expected-html5.txt:
         - Update expectations now that we pass 6 more tests.
2010-07-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add a very basic InTable insertion mode
        https://bugs.webkit.org/show_bug.cgi?id=41581

        There is still a bunch of low-hanging fruit left for this
        mode, but even this most-basic support lets us pass 6 more tests. :)

        It's a progression, ship it! :)

        * html/HTMLElementStack.cpp:
        (WebCore::HTMLNames::isScopeMarker):
        (WebCore::HTMLNames::isListItemScopeMarker):
        (WebCore::HTMLNames::isTableScopeMarker):
        (WebCore::HTMLElementStack::popUntilTableScopeMarker):
        * html/HTMLElementStack.h:
        * html/HTMLFormattingElementList.cpp:
        (WebCore::HTMLFormattingElementList::appendMarker):
        * html/HTMLFormattingElementList.h:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        * html/HTMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 4 Jul 2010 21:15:44 +0000 (21:15 +0000)]
2010-07-02  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTMLTreeBuilder needs an adoption agency
        https://bugs.webkit.org/show_bug.cgi?id=41453

        Added new adoption01 suite for testing adoption agency
        bugs.  Right now only the simplest adoption test passes.
        I'll be adding more in future commits.

        * html5lib/resources/adoption01.dat: Added.
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
        * html5lib/runner.html:
2010-07-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTMLTreeBuilder needs an adoption agency
        https://bugs.webkit.org/show_bug.cgi?id=41453

        This changes some test results, but only makes the simplest
        adoption agency cases pass.  I think the code is likely
        very close, but further iteration to make this change larger
        seems counter-productive.  I recommend we check in this
        progression and work from here.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::addChildCommon):
         - Make sure callers don't assume this will reparent.
        (WebCore::ContainerNode::parserAddChild):
         - Update comment to document lack of reparenting behavior.
        * html/HTMLElementStack.cpp:
        (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
        (WebCore::HTMLElementStack::ElementRecord::~ElementRecord):
        (WebCore::HTMLElementStack::ElementRecord::replaceElement):
        (WebCore::HTMLElementStack::ElementRecord::isAbove):
         - Added for debugging.
        (WebCore::HTMLElementStack::pushHTMLHtmlElement):
        (WebCore::HTMLElementStack::insertAbove):
         - Needed for the adoption agency.
        (WebCore::HTMLElementStack::topRecord):
        (WebCore::HTMLElementStack::bottom):
        (WebCore::HTMLElementStack::removeHTMLHeadElement):
        (WebCore::HTMLElementStack::remove):
        (WebCore::HTMLElementStack::find):
        (WebCore::HTMLElementStack::topmost):
        (WebCore::HTMLElementStack::contains):
        (WebCore::HTMLElementStack::htmlElement):
        (WebCore::HTMLElementStack::headElement):
        (WebCore::HTMLElementStack::bodyElement):
        (WebCore::HTMLElementStack::pushCommon):
        (WebCore::HTMLElementStack::removeNonTopCommon):
         - Fix the name to match top/bottom.
        * html/HTMLElementStack.h:
        (WebCore::HTMLElementStack::ElementRecord::element):
        (WebCore::HTMLElementStack::ElementRecord::next):
        (WebCore::HTMLElementStack::ElementRecord::releaseNext):
        (WebCore::HTMLElementStack::ElementRecord::setNext):
        * html/HTMLFormattingElementList.cpp:
        (WebCore::HTMLFormattingElementList::closestElementInScopeWithName):
        (WebCore::HTMLFormattingElementList::contains):
        (WebCore::HTMLFormattingElementList::find):
        (WebCore::HTMLFormattingElementList::remove):
        * html/HTMLFormattingElementList.h:
        (WebCore::HTMLFormattingElementList::isEmpty):
        (WebCore::HTMLFormattingElementList::size):
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement):
         - Part of the Adoption Agency algorithm.
        (WebCore::HTMLTreeBuilder::findFosterParentFor):
         - Used to move mis-nested content out of tables.
           This doesn't seem to work quite right yet.
        (WebCore::HTMLTreeBuilder::reparentChildren):
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
         - The ridiculously long/complicated adoption agency algorithm from HTML5.
        (WebCore::HTMLTreeBuilder::processEndTag):
        * html/HTMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Sun, 4 Jul 2010 17:44:55 +0000 (17:44 +0000)]
2010-07-04  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
        https://bugs.webkit.org/show_bug.cgi?id=41578

        Remove bindings obsoleted by: http://trac.webkit.org/changeset/59866
        No new tests because behavior is not changed.

        * Android.jscbindings.mk:
        * Android.v8bindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSHTMLFrameElementCustom.cpp:
        * bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
        * bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
        * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
        * html/HTMLFrameElement.idl:
        * html/HTMLIFrameElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Sun, 4 Jul 2010 16:22:23 +0000 (16:22 +0000)]
2010-07-04  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
        https://bugs.webkit.org/show_bug.cgi?id=41578

        Remove bindings obsoleted by: http://trac.webkit.org/changeset/59866
        No new tests because behavior is not changed.

        * Android.jscbindings.mk:
        * Android.v8bindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSHTMLFrameElementCustom.cpp:
        * bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
        * bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
        * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
        * html/HTMLFrameElement.idl:
        * html/HTMLIFrameElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 4 Jul 2010 13:38:30 +0000 (13:38 +0000)]
2010-07-04  Robert Hogan  <robert@webkit.org>

        [Qt] Triage failing HTTP tests in Qt Skipped list

        Unreviewed, sorting tests and adding comments to skipped list.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix after r62456.
mrowe@apple.com [Sun, 4 Jul 2010 11:48:04 +0000 (11:48 +0000)]
Build fix after r62456.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Be slightly more consistent in using uint32_t to prevent
warnings about comparisons between signed and unsigned types, and attempts to call an overload
of std::min that doesn't exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved
robert@webkit.org [Sun, 4 Jul 2010 10:38:31 +0000 (10:38 +0000)]
[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

Unreviewed, accidental omission from r61505

https://bugs.webkit.org/show_bug.cgi?id=36702

Forgot to unskip plugins/reentrant-update-widget-positions.html
as part of http://trac.webkit.org/changeset/61505

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Yury Semikhatsky <yury@yurys-imac.local>
yurys@chromium.org [Sun, 4 Jul 2010 10:16:58 +0000 (10:16 +0000)]
2010-07-04  Yury Semikhatsky  <yury@yurys-imac.local>

        Unreviewed. Update Chromium test expectations.

        * platform/chromium-mac/fast/js/function-apply-expected.txt: Added.
        * platform/chromium-mac/fast/js/function-apply-many-args-expected.txt: Added.
        * platform/chromium-mac/html5lib/runner-expected.txt:
        * platform/chromium-win/fast/js/function-apply-expected.txt: Added.
        * platform/chromium-win/fast/js/function-apply-many-args-expected.txt: Added.
        * platform/chromium-win/html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 4 Jul 2010 09:41:06 +0000 (09:41 +0000)]
2010-07-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Mark Rowe.

        WebProcess crashes in release for simple layout tests
        https://bugs.webkit.org/show_bug.cgi?id=41575

        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        (WKBundlePageCopyRenderTreeExternalRepresentation): ref external representation StringImpl*
        before taking it out of its parent String, to avoid returning freed memory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 4 Jul 2010 05:09:51 +0000 (05:09 +0000)]
2010-07-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Implement AfterAfterFramesetMode
        https://bugs.webkit.org/show_bug.cgi?id=41561

        Test coverage of this mode was a bit ... lacking, shall we say?  This
        patch adds a test for it.

        * html5lib/resources/webkit01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
        * html5lib/webkit-resumer-expected.txt:
2010-07-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Implement AfterAfterFramesetMode
        https://bugs.webkit.org/show_bug.cgi?id=41561

        This mode is almost unobservable.  The main way to observe it seems to
        be seeing where comment nodes get attached to the DOM.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::processEndTag):
        (WebCore::HTMLTreeBuilder::processComment):
        (WebCore::HTMLTreeBuilder::processCharacter):
        (WebCore::HTMLTreeBuilder::processEndOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd stdint.h include to fix WebKitTestRunner build.
mjs@apple.com [Sun, 4 Jul 2010 04:53:02 +0000 (04:53 +0000)]
Add stdint.h include to fix WebKitTestRunner build.

Rubber stamped by Anders Carlsson.

* UIProcess/API/C/WKPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Zhenyao Mo <zmo@google.com>
zmo@google.com [Sun, 4 Jul 2010 01:33:31 +0000 (01:33 +0000)]
2010-07-03  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        WebGLRenderingContext::vertexAttrib* leads to possible out-of-range vector member visit
        https://bugs.webkit.org/show_bug.cgi?id=41572

        * platform/mac-leopard/Skipped: Adding back the program-test.html test since the failure cause is fixed in this patch.
2010-07-03  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        WebGLRenderingContext::vertexAttrib* leads to possible out-of-range vector member visit
        https://bugs.webkit.org/show_bug.cgi?id=41572

        * html/canvas/WebGLRenderingContext.cpp: Fix the out-of-range vector member visit, also refactor the code.
        (WebCore::WebGLRenderingContext::vertexAttrib1f):
        (WebCore::WebGLRenderingContext::vertexAttrib1fv):
        (WebCore::WebGLRenderingContext::vertexAttrib2f):
        (WebCore::WebGLRenderingContext::vertexAttrib2fv):
        (WebCore::WebGLRenderingContext::vertexAttrib3f):
        (WebCore::WebGLRenderingContext::vertexAttrib3fv):
        (WebCore::WebGLRenderingContext::vertexAttrib4f):
        (WebCore::WebGLRenderingContext::vertexAttrib4fv):
        (WebCore::WebGLRenderingContext::vertexAttribfImpl):
        (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
        * html/canvas/WebGLRenderingContext.h: Helper function declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=41553
weinig@apple.com [Sun, 4 Jul 2010 00:11:41 +0000 (00:11 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=41553
Make StringExtras.h versions of snprintf and vsnprintf match the unix versions.

Reviewed by Darin Adler.

- MSVC does not ensure the buffers are null terminated as the unix versions do.

* runtime/JSGlobalObjectFunctions.cpp: Cleanup includes.
* runtime/UString.cpp: Clean up includes.
(JSC::UString::from): Don't pass sizeof(buf) - 1, that is wrong.
* wtf/StringExtras.h:
(snprintf): Ensure null termination of buffer.
(vsnprintf): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Yong Li <yoli@rim.com>
darin@apple.com [Sat, 3 Jul 2010 23:49:59 +0000 (23:49 +0000)]
2010-07-03  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Make Arguments::MaxArguments clamping work for numbers >= 0x80000000 in
        the interpreter as well as the JIT.

        https://bugs.webkit.org/show_bug.cgi?id=41351
        rdar://problem/8142141

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute): Fix signed integer overflow problem
        in op_load_varargs handling. 0xFFFFFFFF was read as -1.
2010-07-03  Darin Adler  <darin@apple.com>

        Added test cases for edge cases in apply function on arrays.
        https://bugs.webkit.org/show_bug.cgi?id=41351

        * fast/js/function-apply-expected.txt: Updated to expect success.
        * fast/js/script-tests/function-apply.js: Added test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUgh. Have to put the destructor in the .h file since the .ccp isn't compiled yet.
jorlow@chromium.org [Sat, 3 Jul 2010 23:02:24 +0000 (23:02 +0000)]
Ugh.  Have to put the destructor in the .h file since the .ccp isn't compiled yet.

* storage/IDBKey.h:
(WebCore::IDBKey::~IDBKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sat, 3 Jul 2010 23:00:14 +0000 (23:00 +0000)]
2010-07-03  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix DumpRenderTree userStyleSheet handling.
        https://bugs.webkit.org/show_bug.cgi?id=41570

        DumpRenderTree did only set the userStyleSheet at
        layoutTestController.setUserStyleSheetEnabled().

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::setUserStyleSheetLocation):
        (LayoutTestController::setUserStyleSheetEnabled):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Forgot destructor.
jorlow@chromium.org [Sat, 3 Jul 2010 22:48:29 +0000 (22:48 +0000)]
Build fix.  Forgot destructor.

* storage/IDBKey.cpp:
(WebCore::IDBKey::~IDBKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-26 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Sat, 3 Jul 2010 22:18:14 +0000 (22:18 +0000)]
2010-06-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dumitru Daniliuc.

        Support for keys and in-memory storage for IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=41252

        Set the role to Private.

        * JavaScriptCore.xcodeproj/project.pbxproj:
2010-06-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dumitru Daniliuc.

        Support for keys and in-memory storage for IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=41252

        It'll take some time to get data persistence working for IndexedDB,
        so until then, we'll just store everything in an in memory tree.
        The tree uses WTF::AVLTree and is a template so that it can be used by
        object stores (IDBKey -> SerializedScriptValue) and indexes (IDBKey ->
        IDBKey).  This class will be used in a subsequent patch.

        Also add an IDBKey type that represents one of these keys.  We use a
        custom toJS function in a way similar to IDBAny to convert from WebCore
        to a JS value.  For converting the other way, we have to teach the code
        generators what to do (unfortunately).  This is done in a way similar
        to serialized script value.  Unlike serialized script value, IDBKey is
        in WebCore and only a helper function is JS engine specific.

        This code is not accessable from layout tests.  (Will fix in
        https://bugs.webkit.org/show_bug.cgi?id=41250)  The bindings tests
        show us that the generated bindings are what we expect.

        * ForwardingHeaders/wtf/AVLTree.h: Added.
        * bindings/js/IDBBindingUtilities.cpp: Added.
        (WebCore::createIDBKeyFromValue):
        * bindings/js/IDBBindingUtilities.h: Added.
        * bindings/js/JSIDBKeyCustom.cpp: Added.
        (WebCore::toJS):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
        (WebDOMTestObj::idbKey):
        * bindings/scripts/test/CPP/WebDOMTestObj.h:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        (webkit_dom_test_obj_idb_key):
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::):
        (WebCore::jsTestObjPrototypeFunctionIdbKey):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj idbKey:]):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::idbKeyCallback):
        (WebCore::):
        * bindings/v8/IDBBindingUtilities.cpp: Added.
        (WebCore::createIDBKeyFromValue):
        * bindings/v8/IDBBindingUtilities.h: Added.
        * bindings/v8/custom/V8IDBKeyCustom.cpp: Added.
        (WebCore::toV8):
        * storage/IDBCallbacks.h:
        * storage/IDBKey.cpp: Added.
        (WebCore::IDBKey::IDBKey):
        (WebCore::IDBKey::~IDBKey):
        * storage/IDBKey.h: Added.
        (WebCore::IDBKey::create):
        (WebCore::IDBKey::):
        (WebCore::IDBKey::type):
        (WebCore::IDBKey::string):
        (WebCore::IDBKey::number):
        * storage/IDBKey.idl: Added.
        * storage/IDBKeyTree.h: Added.
        (WebCore::IDBKeyTree::create):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::get_less):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::set_less):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::get_greater):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::set_greater):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::get_balance_factor):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::set_balance_factor):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::null):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::compare_key_node):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::compare_node_node):
        (WebCore::::IDBKeyTree):
        (WebCore::::~IDBKeyTree):
        (WebCore::::AVLTreeAbstractor::compare_key_key):
        (WebCore::::get):
        (WebCore::::insert):
        (WebCore::::remove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThe missing plug-in indicator should be clickable
jhoneycutt@apple.com [Sat, 3 Jul 2010 21:57:02 +0000 (21:57 +0000)]
The missing plug-in indicator should be clickable

https://bugs.webkit.org/show_bug.cgi?id=41550
<rdar://problem/8132162>

From an original patch by Kevin Decker.

Reviewed by Darin Adler.

WebCore:

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
If the renderer is a RenderEmbeddedWidget showing the missing plug-in
indicator, and the event is a click even, call the ChromeClient's
missingPluginButtonClicked() function.

* page/ChromeClient.h:
(WebCore::ChromeClient::missingPluginButtonClicked):
Declare missingPluginButtonClicked(), and stub the default
implementation.

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
Initialize m_showsMissingPluginIndicator.
(WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator):
Assert that we're not currently showing any replacement text. Set
m_showsMissingPluginIndicator after setting the replacement text.
(WebCore::RenderEmbeddedObject::setShowsCrashedPluginIndicator):
Add the same assert as above.

* rendering/RenderEmbeddedObject.h:
(WebCore::RenderEmbeddedObject::showsMissingPluginIndicator):
Getter for m_showsMissingPluginIndicator.

WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
Declare an override of missingPluginButtonClicked().

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::missingPluginButtonClicked):
Call the UIDelegate's method.

* WebView/WebUIDelegatePrivate.h:
Declare didPressMissingPluginButton.

WebKit/win:

* Interfaces/IWebUIDelegatePrivate.idl:
Added a new delegate interface, and declare a function
didPressMissingPluginButton().

* Interfaces/WebKit.idl:
Touch this file to force interfaces to be rebuilt.

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::missingPluginButtonClicked):
Get the UI delegate, and query it for IWebUIDelegatePrivate3. Call its
didPressMissingPluginButton() function.

* WebCoreSupport/WebChromeClient.h:
Declare an override of missingPluginButtonClicked().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 3 Jul 2010 21:36:41 +0000 (21:36 +0000)]
2010-07-03  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()

        Unskip fast/history/self-is-visited.html

        https://bugs.webkit.org/show_bug.cgi?id=40445

        * platform/qt/Skipped:
2010-07-03  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()

        Object property names such as 'background-color' need to be returned in camel
        case, i.e. backgroundColor so that JS can reference them. Add support for this
        to DumpRenderTreeSupportQt.

        https://bugs.webkit.org/show_bug.cgi?id=40445

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (convertToPropertyName):
        (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove BOM handling out of the lexer and parser
oliver@apple.com [Sat, 3 Jul 2010 20:30:24 +0000 (20:30 +0000)]
Move BOM handling out of the lexer and parser
https://bugs.webkit.org/show_bug.cgi?id=41539

Reviewed by Geoffrey Garen.

JavaScriptCore:

Doing the BOM stripping in the lexer meant that we could
end up having to strip the BOMs from a source multiple times.
To deal with this we now require all strings provided by
a SourceProvider to already have had the BOMs stripped.
This also simplifies some of the lexer logic.

* parser/Lexer.cpp:
(JSC::Lexer::setCode):
(JSC::Lexer::sourceCode):
* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
(JSC::UStringSourceProvider::create):
(JSC::UStringSourceProvider::getRange):
(JSC::UStringSourceProvider::UStringSourceProvider):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::copyStringWithoutBOMs):

WebCore:

Update WebCore to ensure that SourceProviders don't
produce strings with BOMs in them.

* bindings/js/ScriptSourceProvider.h:
(WebCore::ScriptSourceProvider::ScriptSourceProvider):
* bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::StringSourceProvider):
* loader/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
(WebCore::CachedScript::script):
* loader/CachedScript.h:
(WebCore::CachedScript::):
  CachedScript now stores decoded data with the BOMs stripped,
  and caches the presence of BOMs across memory purges.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 3 Jul 2010 19:20:37 +0000 (19:20 +0000)]
2010-07-03  Xan Lopez  <xlopez@igalia.com>

        Include DerivedSources/WebCore before DerivedSources/

        Recently DerivedSources generation was changed, with some files no
        longer being generated in the toplevel DerivedSources
        directory. Since that directory is first in the -I flags the build
        can be broken in some cases by including old files unless a 'make
        clean' is done. Change the -I order to fix the build in the 32 bit
        Release bot.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Sat, 3 Jul 2010 14:08:17 +0000 (14:08 +0000)]
2010-07-03  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ojan Vafai.

        Fix issue where a contextmenu event was reporting the wrong target if
        the context menu was shown due to pressing the context menu key
        (or Shift+F10).

        Split sendContextMenuForEvent into one case for keyboard events and use
        that when the contextmenu event should be dispatched due to a keypress.

        For the keboard case we now use the focused node as the target for the
        event and use the clipped rect to determine the position of the menu.

        https://bugs.webkit.org/show_bug.cgi?id=38129

        Use manual test since DRT does not handle context menu keys.

        * manual-tests/win/contextmenu-key.html: Added.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::sendContextMenuEvent):
        (WebCore::EventHandler::sendContextMenuEventForKey):
        * page/EventHandler.h:
2010-07-03  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ojan Vafai.

        Fix issue where a contextmenu event was reporting the wrong target
        if the context menu was shown due to pressing the context menu key
        (or Shift+F10).

        https://bugs.webkit.org/show_bug.cgi?id=38129

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::sendContextMenuEvent):
2010-07-03  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ojan Vafai.

        Fix issue where a contextmenu event was reporting the wrong target
        if the context menu was shown due to pressing the context menu key
        (or Shift+F10).

        * WebView.cpp:
        (WebView::handleContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 3 Jul 2010 12:03:13 +0000 (12:03 +0000)]
2010-07-03  Dirk Schulze  <krit@webkit.org>

        Unreviewed sort of XCode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 3 Jul 2010 10:42:50 +0000 (10:42 +0000)]
2010-07-03  Robert Hogan  <robert@webkit.org>

        [Qt] Update Qt expected results after r62444

        Unreviewed, update test results.

        http://trac.webkit.org/changeset/62444
        https://bugs.webkit.org/show_bug.cgi?id=41088

        Qt expected results for various fast/ tests updated to reflect
        support for dumpChildFrameScrollPositions(). Checked against Mac results
        and they are all good.

        I have not updated the .png and .checksum files for the tests. This is
        because I suspect I will not get the same pixel results as the Qt build
        bot.

        * platform/qt/fast/dynamic/anchor-lock-expected.txt:
        * platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
        * platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.txt:
        * platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
        * platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
        * platform/qt/fast/repaint/fixed-move-after-scroll-expected.txt:
        * platform/qt/fast/repaint/fixed-tranformed-expected.txt:
        * platform/qt/fast/repaint/repaint-during-scroll-expected.txt:
        * platform/qt/transforms/2d/transform-fixed-container-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 3 Jul 2010 10:00:40 +0000 (10:00 +0000)]
2010-07-03  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] support dumpChildFrameScrollPositions

        https://bugs.webkit.org/show_bug.cgi?id=41088

        Unskip:

        http/tests/navigation/anchor-subframeload.html
        http/tests/navigation/relativeanchor-frames.html

        * platform/qt/Skipped:
2010-07-03  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] support dumpChildFrameScrollPositions

        https://bugs.webkit.org/show_bug.cgi?id=41088

        Unskip:

        http/tests/navigation/anchor-subframeload.html
        http/tests/navigation/relativeanchor-frames.html

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::dumpFrameScrollPosition):
        (WebCore::DumpRenderTree::dump):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        (LayoutTestController::shouldDumpChildFrameScrollPositions):
        (LayoutTestController::dumpChildFrameScrollPositions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Sat, 3 Jul 2010 08:45:40 +0000 (08:45 +0000)]
2010-07-03  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Port Widget
        https://bugs.webkit.org/show_bug.cgi?id=41538

        Make Widget a dummy class. WebKit Brew MP uses the full screen mode
        and does not use the window system introduced in Brew MP.

        * platform/Widget.h:
        * platform/brew/WidgetBrew.cpp: Added.
        (WebCore::Widget::Widget):
        (WebCore::Widget::~Widget):
        (WebCore::Widget::frameRect):
        (WebCore::Widget::setFrameRect):
        (WebCore::Widget::setFocus):
        (WebCore::Widget::setCursor):
        (WebCore::Widget::show):
        (WebCore::Widget::hide):
        (WebCore::Widget::paint):
        (WebCore::Widget::setIsSelected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sat, 3 Jul 2010 08:30:21 +0000 (08:30 +0000)]
2010-07-03  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kent Tamura.

        [WINCE] Implement Unicode::isAlphanumeric and Unicode::isArabicChar.
        https://bugs.webkit.org/show_bug.cgi?id=41411

        * wtf/unicode/wince/UnicodeWince.cpp:
        (WTF::Unicode::isAlphanumeric):
        * wtf/unicode/wince/UnicodeWince.h:
        (WTF::Unicode::isArabicChar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Sat, 3 Jul 2010 08:17:39 +0000 (08:17 +0000)]
2010-07-03  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Change the CRASH() macro to print "WebKit CRASH" log.
        https://bugs.webkit.org/show_bug.cgi?id=41524

        Print "WebKit CRASH" before crashing.

        * wtf/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Jul 2010 07:17:39 +0000 (07:17 +0000)]
2010-07-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement AfterFramesetMode
        https://bugs.webkit.org/show_bug.cgi?id=41560

        It's somewhat hard to observe this state, so I'm not surprised that the
        diff to the expected results are small.  We still fail this test
        because we don't handle whitespace correctly.

        * html5lib/runner-expected-html5.txt:
2010-07-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement AfterFramesetMode
        https://bugs.webkit.org/show_bug.cgi?id=41560

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::processEndTag):
        (WebCore::HTMLTreeBuilder::processCharacter):
        (WebCore::HTMLTreeBuilder::processEndOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Jul 2010 07:03:51 +0000 (07:03 +0000)]
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement InFramesetMode
        https://bugs.webkit.org/show_bug.cgi?id=41559

        And the tests keep progressing.

        * html5lib/runner-expected-html5.txt:
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement InFramesetMode
        https://bugs.webkit.org/show_bug.cgi?id=41559

        Pretty straighforward.  We still don't handle character tokens
        correctly.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::processEndTag):
        (WebCore::HTMLTreeBuilder::processCharacter):
        (WebCore::HTMLTreeBuilder::processEndOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Jul 2010 06:47:33 +0000 (06:47 +0000)]
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Handle <frameset> InBody
        https://bugs.webkit.org/show_bug.cgi?id=41558

        Yay test progression.

        * html5lib/runner-expected-html5.txt:
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Handle <frameset> InBody
        https://bugs.webkit.org/show_bug.cgi?id=41558

        Handling the <frameset> tag in the InBody mode is somewhat delicate.

        * html/HTMLElementStack.cpp:
        (WebCore::HTMLElementStack::popHTMLBodyElement):
        (WebCore::HTMLElementStack::popUntil):
        (WebCore::HTMLElementStack::popCommon):
        * html/HTMLElementStack.h:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 41565 - Repatching in ARMv7Assembler::repatchLoadPtrToLEA is broken
barraclough@apple.com [Sat, 3 Jul 2010 06:45:47 +0000 (06:45 +0000)]
Bug 41565 - Repatching in ARMv7Assembler::repatchLoadPtrToLEA is broken

Reviewed by Oliver Hunt.

This method tried to repatch a LDR (T2) into an ADD (T3) - but it only
repatches the first instruction word.  The layout of the fields in the
second word is different, and also needs repatching.

* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::repatchLoadPtrToLEA):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Jul 2010 06:32:15 +0000 (06:32 +0000)]
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Special handling of <rp> and <rt> tags
        https://bugs.webkit.org/show_bug.cgi?id=41557

        There didn't seem to be test coverage of these cases in the suite, so I
        added a couple tests.

        * html5lib/resources/webkit01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
        * html5lib/webkit-resumer-expected.txt:
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Special handling of <rp> and <rt> tags
        https://bugs.webkit.org/show_bug.cgi?id=41557

        So sayeth the spec.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Jul 2010 06:20:06 +0000 (06:20 +0000)]
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement special optgroup processing
        https://bugs.webkit.org/show_bug.cgi?id=41556

        * html5lib/runner-expected-html5.txt:
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement special optgroup processing
        https://bugs.webkit.org/show_bug.cgi?id=41556

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Jul 2010 06:07:52 +0000 (06:07 +0000)]
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Handle <image> in new parser
        https://bugs.webkit.org/show_bug.cgi?id=41555

        Test progression.

        * html5lib/runner-expected-html5.txt:
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Handle <image> in new parser
        https://bugs.webkit.org/show_bug.cgi?id=41555

        This patch is kind of goofy but apparently how the world works.

        * html/HTMLToken.h:
        (WebCore::AtomicHTMLToken::setName):
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix test to account for the arg count clamping we do with function.apply
oliver@apple.com [Sat, 3 Jul 2010 05:42:56 +0000 (05:42 +0000)]
Fix test to account for the arg count clamping we do with function.apply

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClamp the number of arguments supported by function.apply
oliver@apple.com [Sat, 3 Jul 2010 04:52:45 +0000 (04:52 +0000)]
Clamp the number of arguments supported by function.apply
https://bugs.webkit.org/show_bug.cgi?id=41351
<rdar://problem/8142141>

Reviewed by Gavin Barraclough.

JavaScriptCore:

Add clamping logic to function.apply similar to that
enforced by firefox.  We have a smaller clamp than
firefox as our calling convention means that stack
usage is proportional to argument count -- the firefox
limit is larger than you could actually call.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Arguments.h:
(JSC::Arguments::):

LayoutTests:

Testcases.

* fast/js/function-apply-many-args-expected.txt: Added.
* fast/js/function-apply-many-args.html: Added.
* fast/js/script-tests/function-apply-many-args.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Sat, 3 Jul 2010 04:23:11 +0000 (04:23 +0000)]
2010-07-02  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Alexey Proskuryakov.

        Remove extra semicolon at the end of HTMLTreeBuilder::attach
        https://bugs.webkit.org/show_bug.cgi?id=41546

        This is not critical, but the extra semicolon at the end of HTMLTreeBuilder::attach
        causes a warning in RVCT.

        * html/HTMLTreeBuilder.h:
        (WebCore::HTMLTreeBuilder::attach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue@webkit.org [Sat, 3 Jul 2010 04:07:29 +0000 (04:07 +0000)]
2010-07-02  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Wrong method name in file  Connection.h
        https://bugs.webkit.org/show_bug.cgi?id=41536

        Method openConnectionHandler was spelled as openConnection in class Connection.

        * Platform/CoreIPC/Connection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 3 Jul 2010 03:53:13 +0000 (03:53 +0000)]
2010-07-02  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Adler.

        Performance::disconnectFrame() needs to disconnect its children
        https://bugs.webkit.org/show_bug.cgi?id=41533

        No new tests because no new functionality.

        * page/Performance.cpp:
        (WebCore::Performance::disconnectFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue@webkit.org [Sat, 3 Jul 2010 03:39:19 +0000 (03:39 +0000)]
2010-07-02  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Sam Weinig.

        Adding notification and touch events methods to WebChromeClient
        https://bugs.webkit.org/show_bug.cgi?id=41527

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::notificationPresenter):
        (WebKit::WebChromeClient::needTouchEvents):
        * WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue@webkit.org [Sat, 3 Jul 2010 03:08:25 +0000 (03:08 +0000)]
2010-07-02  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Sam Weinig.

        Checking if WTF_USE_JSC is defined before redefining it in config.h
        https://bugs.webkit.org/show_bug.cgi?id=41530

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, test expectation update.
pkasting@chromium.org [Sat, 3 Jul 2010 03:05:40 +0000 (03:05 +0000)]
Unreviewed, test expectation update.

Mark a newly added test as crashing.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue@webkit.org [Sat, 3 Jul 2010 02:46:08 +0000 (02:46 +0000)]
2010-07-02  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Sam Weinig.

        Removing CoreFoundation.h include from WKFrame.h
        https://bugs.webkit.org/show_bug.cgi?id=41528

        * UIProcess/API/C/WKFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 3 Jul 2010 02:18:48 +0000 (02:18 +0000)]
2010-07-02  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add vendor prefix to window.performance
        https://bugs.webkit.org/show_bug.cgi?id=41525

        No new tests because window.performance tests not landed yet.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::webkitPerformance):
        * page/DOMWindow.h:
        (WebCore::DOMWindow::optionalWebkitPerformance):
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Zoltan Herczeg <zherczeg@webkit.org>
zherczeg@webkit.org [Sat, 3 Jul 2010 02:02:09 +0000 (02:02 +0000)]
2010-07-02  Zoltan Herczeg  <zherczeg@webkit.org>

        Reviewed by Oliver Hunt.

        Minor fix: Diffuse constant is float (not integer)
        https://bugs.webkit.org/show_bug.cgi?id=10412

        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Chao-ying Fu <fu@mips.com>
commit-queue@webkit.org [Sat, 3 Jul 2010 01:49:03 +0000 (01:49 +0000)]
2010-07-02  Chao-ying Fu  <fu@mips.com>

        Reviewed by Oliver Hunt.

        Re-enable JIT_OPTIMIZE_NATIVE_CALL on MIPS
        https://bugs.webkit.org/show_bug.cgi?id=40179

        Add the MIPS part to re-enable JIT_OPTIMIZE_NATIVE_CALL.

        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTINativeCall):
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 41552 - Clean up ARMv7 vfp code generation
barraclough@apple.com [Sat, 3 Jul 2010 00:28:12 +0000 (00:28 +0000)]
Bug 41552 - Clean up ARMv7 vfp code generation
Emit separate opcode individually, remove magic numbers.

Reviewed by Oliver Hunt.

Also remove invalid assert from JSImmediate (number cells are not CELL_MASK aligned).

* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::vadd_F64):
(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcvt_F64_S32):
(JSC::ARMv7Assembler::vcvtr_S32_F64):
(JSC::ARMv7Assembler::vdiv_F64):
(JSC::ARMv7Assembler::vldr):
(JSC::ARMv7Assembler::vmov_F64_0):
(JSC::ARMv7Assembler::vmov):
(JSC::ARMv7Assembler::vmrs):
(JSC::ARMv7Assembler::vmul_F64):
(JSC::ARMv7Assembler::vstr):
(JSC::ARMv7Assembler::vsub_F64):
(JSC::ARMv7Assembler::VFPOperand::VFPOperand):
(JSC::ARMv7Assembler::VFPOperand::bits1):
(JSC::ARMv7Assembler::VFPOperand::bits4):
(JSC::ARMv7Assembler::vcvtOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpMemOp):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchDouble):
* runtime/JSImmediate.h:
(JSC::JSValue::isCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 3 Jul 2010 00:11:25 +0000 (00:11 +0000)]
2010-07-02  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Build fix for GTK+. Try to force a rebuild of the HTMLNames.h
        file first by touching HTMLTagNames.in.

        * html/HTMLTagNames.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Andreas Kling <andreas.kling@nokia.com>
commit-queue@webkit.org [Sat, 3 Jul 2010 00:08:09 +0000 (00:08 +0000)]
2010-07-02  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Oliver Hunt.

        Add test to verify proper clamping of RGB values.
        https://bugs.webkit.org/show_bug.cgi?id=39482

        Also unskip 3 canvas/philip tests that now pass.

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#colors

        * fast/canvas/canvas-color-clamping-expected.txt: Added.
        * fast/canvas/canvas-color-clamping.html: Added.
        * fast/canvas/script-tests/canvas-color-clamping.js: Added.
        * platform/mac/Skipped:
        * platform/qt/Skipped:
2010-07-02  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Oliver Hunt.

        RGB colors should be clamped to the 0-255 range
        https://bugs.webkit.org/show_bug.cgi?id=39482

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#colors

        Test: fast/canvas/canvas-color-clamping.html

        * css/CSSParser.cpp:
        (WebCore::parseColorInt):
        (WebCore::CSSParser::parseColor):
        (WebCore::parseColorIntFromValue):
        (WebCore::CSSParser::parseColorParameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 2 Jul 2010 23:49:07 +0000 (23:49 +0000)]
2010-07-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62410.
        http://trac.webkit.org/changeset/62410
        https://bugs.webkit.org/show_bug.cgi?id=41549

        accursed last minute changes (Requested by olliej on #webkit).

        * parser/Lexer.cpp:
        (JSC::Lexer::setCode):
        (JSC::Lexer::copyCodeWithoutBOMs):
        (JSC::Lexer::sourceCode):
        * parser/SourceProvider.h:
        (JSC::):
        (JSC::SourceProvider::SourceProvider):
        (JSC::SourceProvider::hasBOMs):
        (JSC::UStringSourceProvider::create):
        (JSC::UStringSourceProvider::getRange):
        (JSC::UStringSourceProvider::UStringSourceProvider):
        * wtf/text/StringImpl.h:
2010-07-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62410.
        http://trac.webkit.org/changeset/62410
        https://bugs.webkit.org/show_bug.cgi?id=41549

        accursed last minute changes (Requested by olliej on #webkit).

        * bindings/js/ScriptSourceProvider.h:
        (WebCore::ScriptSourceProvider::ScriptSourceProvider):
        * bindings/js/StringSourceProvider.h:
        (WebCore::StringSourceProvider::StringSourceProvider):
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::CachedScript):
        (WebCore::CachedScript::script):
        * loader/CachedScript.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename new scripts so that they don't make autocompleting run-webkit-tests annoying.
weinig@apple.com [Fri, 2 Jul 2010 23:46:22 +0000 (23:46 +0000)]
Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.

Reviewed by Anders Carlsson.

* Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
* Scripts/debug-webkittestrunner: Removed.
* Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
* Scripts/run-webkittestrunner: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62415 268f45cc-cd09-0410-ab3c-d52691b4dbfc