15 years ago Move JavaScriptCore thread testing code to pthread specific directory
weinig@apple.com [Tue, 4 Dec 2007 05:17:09 +0000 (05:17 +0000)]
    Move JavaScriptCore thread testing code to pthread specific directory
        and remove the dependance on CoreFoundation by using WTF::HashSet.

        Reviewed by Geoff and Oliver.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
        * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
        * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
        * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
        * DumpRenderTree/pthreads: Added.
        * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoVersioning.
aroben@apple.com [Tue, 4 Dec 2007 04:57:32 +0000 (04:57 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-03 Andrew Bonventre <andybons@google.com>
mitz@apple.com [Tue, 4 Dec 2007 01:08:26 +0000 (01:08 +0000)]
2007-12-03  Andrew Bonventre  <andybons@google.com>

        Reviewed by Darin Adler.

        * Drosera/debugger.js: Fixed javascript error where document property
        should have been used instead of contentDocument in switchFunction that
        was breaking the select symbol dropdown menu.  This is because
        window.frames will return a Window object and not a frame object like
        the author was originally expecting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Tue, 4 Dec 2007 00:28:02 +0000 (00:28 +0000)]

        Reviewed by Darin Adler.

        - fix <rdar://problem/5134044> fast/frames/frame-src-attribute.html fails on Windows

        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::visibleWidth): Do not return negative values.
        (WebCore::ScrollView::visibleHeight): Ditto.


        Reviewed by Darin Adler.

        - remove passing test

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Tue, 4 Dec 2007 00:25:38 +0000 (00:25 +0000)]

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

        Test: fast/events/resize-subframe.html

        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::FrameViewPrivate): Added a timer used when
        deferring tasks that need to be done after layout.
        (WebCore::FrameView::layout): Moved the updating of widget positions,
        loading plug-ins and sending events queued up during layout into
        performPostLayoutTasks(). performPostLayoutTasks() is called after
        layout unless the layout was triggered by a previous layout's post-
        layout tasks. In the latter case, performPostLayoutTasks() is scheduled
        to run later.
        (WebCore::FrameView::performPostLayoutTasks): Performs work that needs
        to be done after layout but which can result in arbitrary code
        execution and therefore may re-invalidate the layout. This includes
        updating widget positions, loading plug-ins, and dispatching layout-
        related DOM events (scroll, overflow and resize).
        * page/FrameView.h:
        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm: Removed -sendResizeEvent since this
        is handled by FrameView now.


        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

        * WebView/webkitwebview.cpp: Remove the call to sendResizeEvent() since
        FrameView sends it now.


        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code
        that checked if the view had resized and sent the resize event, since
        FrameView sends resize events now.
        * WebView/WebHTMLViewInternal.h:


        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

        * WebView.cpp:
        (WebViewWndProc): Removed call to sendResizeEvent() since FrameView
        sends them now.


        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

        * fast/events/resize-subframe-expected.txt: Added.
        * fast/events/resize-subframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin@apple.com [Mon, 3 Dec 2007 22:56:42 +0000 (22:56 +0000)]

        Reviewed by Geoff.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15618
          <rdar://problem/5619353> REGRESSION: Stack overflow/crash in KJS::equal (15618)

        Test: fast/js/recursion-limit-equal.html

        * kjs/operations.cpp: (KJS::equal): Check the exception from toPrimitive.


        Reviewed by Geoff.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15618
          <rdar://problem/5619353> REGRESSION: Stack overflow/crash in KJS::equal (15618)

        * fast/js/recursion-limit-equal-expected.txt: Added.
        * fast/js/recursion-limit-equal.html: Added.
        * fast/js/resources/recursion-limit-equal.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKit/win:
kmccullough@apple.com [Mon, 3 Dec 2007 22:15:50 +0000 (22:15 +0000)]

        Reviewed by Adam.

        - <rdar://5618942> Drosera: Console window does not process everything
        - <rdar://5619005> Drosera: could be sped up by moving the
        WebScriptScope stuff into the WebScriptCallFrame.
        - Now the console can correctly process objects and does not receive
        notifications from JavaScriptCore about the JavaScript in Drosera's
        own process.

        * Interfaces/IWebScriptCallFrame.idl: Moved the variable lookup
        functions from WebScriptScope to here.
        * Interfaces/WebKit.idl: Removed WebScriptScope.
        * WebKit.vcproj/Interfaces.vcproj: Ditto.
        * WebKit.vcproj/WebKit.vcproj: Ditto.
        * WebKit.vcproj/WebKitGUID.vcproj: Ditto.
        * WebScriptCallFrame.cpp: Moved WebScriptScope functionality into here.
        (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Now
        returns a string value for things that are not strings.
        (WebScriptCallFrame::variableNames): Moved from WebScriptScope.
        (WebScriptCallFrame::valueForVariable): Moved from WebScriptScope.
        (WebScriptCallFrame::jsValueToString): Helper functions that converts
        any JSValue to a String.
        * WebScriptCallFrame.h: Moved WebScriptScope functionality into here.
        * WebScriptDebugger.cpp: Added nested guards so that Drosera does not
        receive notifications about JavaScript that Drosera is running just the
        JavaScript WebKit is running.
        * WebScriptDebugger.h: Ditto.
        * WebScriptScope.cpp: Removed.
        * WebScriptScope.h: Removed.


        Reviewed by Adam.

        - <rdar://5618942> Drosera: Console window does not process everything
        - <rdar://5619005> Drosera: could be sped up by moving the
        WebScriptScope stuff into the WebScriptCallFrame.
        - Now the console can correctly process objects and does not receive
        notifications from JavaScriptCore about the JavaScript in Drosera's
        own process.

        * Drosera/win/DebuggerDocumentPlatform.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix a copy-and-paste-o
mitz@apple.com [Mon, 3 Dec 2007 22:14:45 +0000 (22:14 +0000)]
    - fix a copy-and-paste-o

        * bindings/npruntime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCheck to see if we are building a debug root
slewis@apple.com [Mon, 3 Dec 2007 22:12:28 +0000 (22:12 +0000)]
Check to see if we are building a debug root

        * Scripts/check-for-global-initializers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
mitz@apple.com [Mon, 3 Dec 2007 22:07:43 +0000 (22:07 +0000)]

        Reviewed by Darin Adler.

        - fix an ASSERT when getIntIdentifier is called with 0 or -1

        * bindings/npruntime.cpp:
        (_NPN_GetIntIdentifier): We cannot use the hashmap for 0 and -1 since
        they are the empty value and the deleted value. Instead, keep the
        identifiers for those two integers in a static array.


        Reviewed by Darin Adler.

        - added a testGetIntIdentifier() method to TestNetscapePlugIn

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:


        Reviewed by Darin Adler.

        - added a test of the behavior of getIntIdentifier with the integers
          0 and -1

        * plugins/getintidentifier-special-values-expected.txt: Added.
        * plugins/getintidentifier-special-values.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
timothy@apple.com [Mon, 3 Dec 2007 21:43:29 +0000 (21:43 +0000)]
    Reviewed by Darin.

        Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations
        to return a pointer to the implementation struct instead of a copy of the struct. This changes
        all of the callers to dereference the pointer to access the struct fields.

        * Plugins/WebNullPluginView.mm:
        (-[WebNullPluginView reportFailure]):
        * WebCoreSupport/WebFrameBridge.mm:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebView.mm:
        (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the build, move JSDOMWindow.h to the Copy Generated Headers phase.
timothy@apple.com [Mon, 3 Dec 2007 21:37:58 +0000 (21:37 +0000)]
Fix the build, move JSDOMWindow.h to the Copy Generated Headers phase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
rwlbuis@webkit.org [Mon, 3 Dec 2007 21:25:27 +0000 (21:25 +0000)]
    Reviewed by Darin.

        Text decorations do not respect "visibility" property

        Only paint decorations if visibility is "visible".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady Eidson.
timothy@apple.com [Mon, 3 Dec 2007 20:35:53 +0000 (20:35 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/5539913> 188 crashes in WebViewGetFrameLoadDelegateImplementations
        <rdar://problem/5586095> CrashTracer: [USER] 5000+ crashes in Safari and Dashboard in dispatchDidFailLoading
        <rdar://problem/5607081> CrashTracer: [USER] 2150 crashes in Safari at com.apple.WebKit:
        WebViewGetResourceLoadDelegateImplementations + 28

        * WebView/WebView.mm:
        (-[WebView _cacheResourceLoadDelegateImplementations]): If the delegate is nil, bzero the
        implementation cache. This just prevents us from calling getMethod() multiple times just to zero.
        (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.
        (WebViewGetResourceLoadDelegateImplementations): Return a zeroed implementations struct
        if the WebView is nil. This fixes the crashes.
        (WebViewGetFrameLoadDelegateImplementations): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Removing passing tests
alice.liu@apple.com [Mon, 3 Dec 2007 20:24:22 +0000 (20:24 +0000)]
    Removing passing tests

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix build.
sfalken@apple.com [Mon, 3 Dec 2007 19:55:44 +0000 (19:55 +0000)]
    Fix build.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoi Reviewed by Darin.
kdecker@apple.com [Mon, 3 Dec 2007 19:47:21 +0000 (19:47 +0000)]
i        Reviewed by Darin.

        Fixed: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang

        The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would only call into the NPP_SetWindow()
        function when we tell the plug-in to draw. This created havoc with Flash because Flash expects the browser to call NPP_SetWindow()
        and provide a valid graphics context regardless of whether or not it actually needs to draw.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned down an ASSERT that was too strict.
        (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins which would sometimes
        altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by David.
zimmermann@webkit.org [Mon, 3 Dec 2007 18:57:23 +0000 (18:57 +0000)]
Reviewed by David.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=15645
Don't allow selectors to interfere with the SVG shadow tree (<use> internal non-exposed tree).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRubber stamped by Mark.
zimmermann@webkit.org [Mon, 3 Dec 2007 18:44:25 +0000 (18:44 +0000)]
Rubber stamped by Mark.
Commit missing layout test results from my last commit (fix for bug 15403)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-03 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
zecke@webkit.org [Mon, 3 Dec 2007 18:09:35 +0000 (18:09 +0000)]
2007-12-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>

        Rubber stamped by Mark.

        Always include config.h at the beginning of the file.

        * Api/qwebsettings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Mon, 3 Dec 2007 18:09:34 +0000 (18:09 +0000)]

        Reviewed by Adam Roben.

        - fix <rdar://problem/5538651> REGRESSSION: domfuzz: null deref in WebCore::Document::canReplaceChild

        Test: fast/dom/Document/replaceChild-null-oldChild.html

        * dom/Document.cpp:


        Reviewed by Adam Roben.

        - test for <rdar://problem/5538651> REGRESSSION: domfuzz: null deref in WebCore::Document::canReplaceChild

        * fast/dom/Document/replaceChild-null-oldChild-expected.txt: Added.
        * fast/dom/Document/replaceChild-null-oldChild.html: Added.
        * fast/dom/Document/resources/replaceChild-null-oldChild.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Avoid crashes by making sure everything is layouted before
zecke@webkit.org [Mon, 3 Dec 2007 18:05:11 +0000 (18:05 +0000)]
* Avoid crashes by making sure everything is layouted before
  we start painting. This avoids a crash in Widget::invalidateRect
  because QPainter::begin would fail
* The QWebFrame::layout() methods and calls are left untouched because
  this would be an API decision.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Implement GraphicsContext::fillRoundedRect similiar to the
zecke@webkit.org [Mon, 3 Dec 2007 18:02:59 +0000 (18:02 +0000)]
* Implement GraphicsContext::fillRoundedRect similiar to the
  CoreGraphics implementation only addPath is not called this
  seems to be only needed for CoreGraphics.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* SubClass QWebPage to handle hide and close events.
zecke@webkit.org [Mon, 3 Dec 2007 18:01:56 +0000 (18:01 +0000)]
* SubClass QWebPage to handle hide and close events.
* Forward these events to the InspectorController
* The other options would have been using an eventFilter
  on the webpage and making InspectorClient a QObject or
  creating a QObject Observer.
* Provide a simple QWebPage* createWindow implementation. This is needed
  to make FrameLoaderClientQt::dispatchCreatePage stop crashing in the case
  of the inspector client.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Coding Style fixes
zecke@webkit.org [Mon, 3 Dec 2007 18:01:10 +0000 (18:01 +0000)]
* Coding Style fixes

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Implement the InspectorClient for the Qt port
zecke@webkit.org [Mon, 3 Dec 2007 18:00:14 +0000 (18:00 +0000)]
* Implement the InspectorClient for the Qt port
* It does not support highlighting of nodes yet
* Use QRC to open the internal page. The important thing is the
 '/' in the URL to make WebCore::Document::completeURL behave the
  way we want.
* To make the InspectorClient work we will have to mark qrc as secure.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Allow adding the Inspect ContextMenuItem to our Menu
zecke@webkit.org [Mon, 3 Dec 2007 17:58:23 +0000 (17:58 +0000)]
* Allow adding the Inspect ContextMenuItem to our Menu
* Open the Inspector when Inspect was activated. This requires
  that we keep the innerNonSharedNode from the HitTest around. This
  forces us to include <wtf/RefPtr.h> in the private header. It is
  the first non Qt header but should be okay.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Add the Developer Extras to the WebAttribute and propagate it
zecke@webkit.org [Mon, 3 Dec 2007 17:57:04 +0000 (17:57 +0000)]
* Add the Developer Extras to the WebAttribute and propagate it
  to WebCore::Settings. This will enable the Inspect Element menu item
* CodingStyle fixes in QWebSettings
* Enable the Developer Extras in the QtLauncher

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin@apple.com [Mon, 3 Dec 2007 15:46:14 +0000 (15:46 +0000)]

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15848
          <rdar://problem/5619330> REGRESSION: Assertion failure viewing comments page on digg.com

        Test: fast/js/sparse-array.html

        * kjs/array_instance.cpp:
        (KJS::ArrayInstance::inlineGetOwnPropertySlot): Check sparse array cutoff before looking
        in hash map. Can't avoid the branch because we can't look for 0 in the hash.
        (KJS::ArrayInstance::deleteProperty): Ditto.


        Reviewed by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15848
          <rdar://problem/5619330> REGRESSION: Assertion failure viewing comments page on digg.com

        * fast/js/resources/sparse-array.js: Added.
        * fast/js/sparse-array-expected.txt: Added.
        * fast/js/sparse-array.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-03 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 3 Dec 2007 12:57:14 +0000 (12:57 +0000)]
2007-12-03  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Don't delete the decoder if it's already been created. The one we have
        is fine.

        Cairo image cleanups. Nothing substantial.

        Notify ImageObservers where appropriate.

        * platform/graphics/cairo/ImageCairo.cpp:
        * platform/graphics/cairo/ImageSourceCairo.cpp:
        * platform/graphics/gtk/ImageGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixed crash when rendering form elements with Qt 4.4
hausmann@webkit.org [Mon, 3 Dec 2007 12:04:31 +0000 (12:04 +0000)]
Fixed crash when rendering form elements with Qt 4.4

QPainter::device() is not guaranteed to return a QWidget, so do the safe "cast" with the
help of QPaintDevice::devType().
Also fall back to the QApplication::style() if we don't have a widget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
zecke@webkit.org [Mon, 3 Dec 2007 10:36:03 +0000 (10:36 +0000)]
2007-12-02  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>

        Reviewed by Sam Weinig.

        * Add FrameLoader::shouldTreatSchemeAsLocal which is similar to
        * Make use of FrameLoader::shouldTreatSchemeAsLocal in SecurityOrigin
        and do not hardcode "file". This is needed for the WebKit/qt port to make
        the Web Inspector work as it using the qrc protocol instead of file.

        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * platform/SecurityOrigin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
zecke@webkit.org [Mon, 3 Dec 2007 10:34:17 +0000 (10:34 +0000)]
2007-12-02  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>

        Rubber stamped by Sam Weinig.

        Only add applewebdata to the localSchemes when building for the
        mac. This is in preparation of adding qrc for the Qt port there
        as well and http://bugs.webkit.org/show_bug.cgi?id=15938.

        According to Anders applewebdata is not used on the win port.

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
zecke@webkit.org [Mon, 3 Dec 2007 10:33:20 +0000 (10:33 +0000)]
2007-12-02  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>

        Rubber stamped by Sam Weinig.

        Fix a typo. It is contains and not containts

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-03 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Mon, 3 Dec 2007 09:25:45 +0000 (09:25 +0000)]
2007-12-03  Mark Rowe  <mrowe@apple.com>

        Speculative Windows build fix.

        * WebScriptCallFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-03 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Mon, 3 Dec 2007 09:19:26 +0000 (09:19 +0000)]
2007-12-03  Mark Rowe  <mrowe@apple.com>

        wx build fix.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
ap@webkit.org [Mon, 3 Dec 2007 09:10:04 +0000 (09:10 +0000)]
    Reviewed by Oliver.

        Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
        in a more fine-grained manner than eventSender.keyDown().

        * DumpRenderTree/win/EventSender.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Another speculative Windows build fix
aroben@apple.com [Mon, 3 Dec 2007 09:05:06 +0000 (09:05 +0000)]
    Another speculative Windows build fix

        * WebScriptCallFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-03 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 3 Dec 2007 08:58:06 +0000 (08:58 +0000)]
2007-12-03  Alp Toker  <alp@atoker.com>

        Add another missing DEPENDPATH.

        Noticed when fixing the build.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Speculative Windows build fix
aroben@apple.com [Mon, 3 Dec 2007 08:52:44 +0000 (08:52 +0000)]
    Speculative Windows build fix

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Speculative Windows build fix
aroben@apple.com [Mon, 3 Dec 2007 08:43:56 +0000 (08:43 +0000)]
    Speculative Windows build fix

        * WebFrame.cpp:
        * WebScriptDebugger.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Removed unnecessary and possibly incorrect #include from my last
ggaren@apple.com [Mon, 3 Dec 2007 08:13:00 +0000 (08:13 +0000)]
    Removed unnecessary and possibly incorrect #include from my last

        * Api/qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago GTK Build fix: get globalExec from the right place.
ggaren@apple.com [Mon, 3 Dec 2007 08:10:06 +0000 (08:10 +0000)]
    GTK Build fix: get globalExec from the right place.

        * WebView/webkitwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Qt build fix: Get globalExec() from the right place.
ggaren@apple.com [Mon, 3 Dec 2007 08:06:50 +0000 (08:06 +0000)]
    Qt build fix: Get globalExec() from the right place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix: added symbols to the right .exp file.
ggaren@apple.com [Mon, 3 Dec 2007 08:02:04 +0000 (08:02 +0000)]
    Build fix: added symbols to the right .exp file.

        * WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix: added an #include.
ggaren@apple.com [Mon, 3 Dec 2007 07:53:03 +0000 (07:53 +0000)]
    Build fix: added an #include.

        * kjs/collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren@apple.com [Mon, 3 Dec 2007 07:43:29 +0000 (07:43 +0000)]

        Reviewed by Eric Seidel.

        Second step in refactoring JSGlobalObject: moved virtual functions from
        Interpreter to JSGlobalObject.

        Layout and JS tests pass. SunSpider reports a .7% speedup -- don't
        believe his lies.


        Reviewed by Eric Seidel.

        Updated to match the JavaScriptCore change to move virtual methods from
        Interpreter to JSGlobalObject.

        * JSRun.cpp:
        * JSRun.h:
        * JSValueWrapper.cpp:
        * JavaScriptGlue.cpp:


        Reviewed by Eric Seidel.

        Updated to match the JavaScriptCore change to move virtual methods from
        Interpreter to JSGlobalObject.

        Moved virtual ScriptInterpreter functions to Window.


        Reviewed by Eric Seidel.

        Updated to match the JavaScriptCore change to move virtual methods from
        Interpreter to JSGlobalObject.

        * WebView/WebFrame.mm:
        (-[WebFrame globalContext]): Use the toRef function instead of manually

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin@apple.com [Mon, 3 Dec 2007 04:57:59 +0000 (04:57 +0000)]

        Reviewed by Mitz.

        - fix <rdar://problem/5601995> Hang/crash on http://ebay-uk.custhelp.com/

        There were two problems here:

            1) Incorrect HTMLCollection behavior led to us trying to insert a
               new row inside an existing row instead of next to it. The fix for
               this is to make HTMLCollection work better for table-related

            2) HTMLTableRowElement::insertCell would return a bad pointer if
               the insertion failed. The code should have failed, but not crashed,
               so it's worth fixing that too.

        While fixing the HTMLCollection issues, I did some clean-up of that
        class and its derived classes.

        Test: fast/dom/HTMLTableElement/rows.html
        Test: fast/dom/HTMLTableElement/tBodies.html
        Test: fast/dom/HTMLTableRowElement/cells.html
        Test: fast/dom/HTMLTableRowElement/insertCell.html
        Test: fast/dom/HTMLTableSectionElement/rows.html

        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::toJS): Updated because collectionType() was renamed to type().

        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::HTMLCollection): Updated for data member name
        changes. Also added a protected constructor for use by derived classes
        that pass in a CollectionInfo.
        (WebCore::HTMLCollection::CollectionInfo::copyCacheMap): Moved out of
        the header.
        (WebCore::isTableSection): Added.
        (WebCore::HTMLCollection::itemAfter): Renamed from traverseNextItem,
        because the old name was grammatically incorrect and thus a bit confusing.
        Changed to operate on Element* instead of Node*, and use 0 to start
        rather than passing in the base node (required since the base node can be
        a document, which is not an element). Generalized the code that made
        NodeChildren not descend into deeper descendants so it can be used for
        TRCells, TSectionRows, TableTBodies, and TableRows. Reformatted the
        switch statement and got rid of the "found" boolean since we can just
        return when we find something. Got rid of the default case, and instead
        listed all the enum values. Also changed to use a for loop for clarity.
        (WebCore::HTMLCollection::calcLength): Updated for itemAfter changes.
        (WebCore::HTMLCollection::item): Ditto.
        (WebCore::HTMLCollection::nextItem): Ditto.
        (WebCore::HTMLCollection::checkForNameMatch): Updated to take an Element
        instead of a Node pointer.
        (WebCore::HTMLCollection::namedItem): More of the same.
        (WebCore::HTMLCollection::updateNameCache): Ditto.
        (WebCore::HTMLCollection::namedItems): Ditto.
        (WebCore::HTMLCollection::nextNamedItem): Ditto.
        (WebCore::HTMLCollection::tags): Ditto.

        * html/HTMLCollection.h: Added a type FormElements, so that the
        HTMLFormCollection would not have a type of DocImages, which is what
        it previously did. Changed the base parameter to be a PassRefPtr to
        make it clear we take ownership of it. Added a comment explaining
        why we should change the name CollectionInfo. Made a lot more members
        private instead of protected. Renamed traverseNextItem to itemAfter.
        Changed most functions to take Element* instead of Node*.

        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::formCollectionInfo): Added.
        (WebCore::HTMLFormCollection::HTMLFormCollection): Updated to pass
        collection info into the base class.
        (WebCore::HTMLFormCollection::calcLength): Updated to use base() so we
        don't need to get at m_base directly.
        (WebCore::HTMLFormCollection::item): Same, but for info().
        (WebCore::HTMLFormCollection::getNamedItem): Removed unused first
        (WebCore::HTMLFormCollection::getNamedFormItem): Got rid of unneeded
        checks that the base is still an element and still a form, since that's
        (WebCore::HTMLFormCollection::nextItem): Use info().
        (WebCore::HTMLFormCollection::nextNamedItemInternal): Node instead of
        Element, some name changes.
        (WebCore::HTMLFormCollection::namedItem): Update for changes elsewhere.
        (WebCore::HTMLFormCollection::nextNamedItem): Ditto, also rewrote loop
        to be much simpler.
        (WebCore::HTMLFormCollection::updateNameCache): More of the same.

        * html/HTMLFormCollection.h: Changed constructor to take an
        HTMLFormElement, using a PassRefPtr to communicate transfer of
        ownership. Made everything private instead of protected. Removed
        unneeded override of firstItem. Made getNamedItem and
        nextNamedItemInternal non-virtual. Removed unused first argument of
        getNamedItem. Added declaration of formCollectionInfo.

        * html/HTMLNameCollection.cpp:
        (WebCore::HTMLNameCollection::HTMLNameCollection): Updated to pass
        collection info into the base class.
        (WebCore::HTMLNameCollection::itemAfter): Reformatted a bit and
        changed into a for loop.

        * html/HTMLNameCollection.h: Updated for name changes. Made function
        private instead of public. Used PassRefPtr in constructor.

        * html/HTMLOptionsCollection.cpp:
        (WebCore::HTMLOptionsCollection::HTMLOptionsCollection): Updated to
        pass collection info into the base class.
        (WebCore::HTMLOptionsCollection::add): Updated for public/private
        changes in the base class.
        (WebCore::HTMLOptionsCollection::selectedIndex): Ditto.
        (WebCore::HTMLOptionsCollection::setSelectedIndex): Ditto.
        (WebCore::HTMLOptionsCollection::setLength): Ditto.

        * html/HTMLOptionsCollection.h: Changed constructor parameter to be a

        * html/HTMLTableRowElement.cpp:
        (WebCore::HTMLTableRowElement::insertCell): Changed code to use RefPtr
        and PassRefPtr since this creates a new object. This alone fixed the
        crash. Also cleaned up logic a bit to be more readable.

        * html/HTMLTableRowElement.h: Changed insertCell to return a PassRefPtr.
        Also reordered functions a bit to make things a little more logical and
        removed the unused ncols data member.

        * html/HTMLTableSectionElement.cpp:
        (WebCore::HTMLTableSectionElement::rows): Pass TSectionRows, not
        TableRows. This mistake was harmless before because TableRows and
        TSectionRows were handled identically inside HTMLCollection, but that is
        no longer the case with this fix.

        * bindings/scripts/CodeGeneratorJS.pm: Add an include to cope with the
        fact that HTMLOptionsCollection no longer includes HTMLOptionElement.
        I don't think this really should be a special case -- might be worth
        returning later to see if this can be optimized.


        Reviewed by Mitz.

        - tests for table-related HTMLCollection classes for misnested
          tables and for <rdar://problem/5601995> Hang/crash on http://ebay-uk.custhelp.com/

        * fast/dom/HTMLTableElement/resources: Added.
        * fast/dom/HTMLTableElement/resources/TEMPLATE.html: Added.
        * fast/dom/HTMLTableElement/resources/rows.js: Added.
        * fast/dom/HTMLTableElement/resources/tBodies.js: Added.
        * fast/dom/HTMLTableElement/rows-expected.txt: Added.
        * fast/dom/HTMLTableElement/rows.html: Added.
        * fast/dom/HTMLTableElement/tBodies-expected.txt: Added.
        * fast/dom/HTMLTableElement/tBodies.html: Added.
        * fast/dom/HTMLTableRowElement: Added.
        * fast/dom/HTMLTableRowElement/cells-expected.txt: Added.
        * fast/dom/HTMLTableRowElement/cells.html: Added.
        * fast/dom/HTMLTableRowElement/insertCell-expected.txt: Added.
        * fast/dom/HTMLTableRowElement/insertCell.html: Added.
        * fast/dom/HTMLTableRowElement/resources: Added.
        * fast/dom/HTMLTableRowElement/resources/TEMPLATE.html: Added.
        * fast/dom/HTMLTableRowElement/resources/cells.js: Added.
        * fast/dom/HTMLTableSectionElement: Added.
        * fast/dom/HTMLTableSectionElement/resources: Added.
        * fast/dom/HTMLTableSectionElement/resources/TEMPLATE.html: Added.
        * fast/dom/HTMLTableSectionElement/resources/rows.js: Added.
        * fast/dom/HTMLTableSectionElement/rows-expected.txt: Added.
        * fast/dom/HTMLTableSectionElement/rows.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * Scripts/do-webcore-rename: More planned renaming.
darin@apple.com [Mon, 3 Dec 2007 04:41:08 +0000 (04:41 +0000)]
    * Scripts/do-webcore-rename: More planned renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Adam.
zimmermann@webkit.org [Mon, 3 Dec 2007 01:05:25 +0000 (01:05 +0000)]
Reviewed by Adam.

RenderSVGViewportContainer sets wrong width/height.
Share code with RenderSVGContainer in a central calcBounds() function.

- svg/custom/use-css-events.svg (http://bugs.webkit.org/show_bug.cgi?id=15403)
- svg/custom/deep-dynamic-updates.svg
- svg/custom/use-clipped-hit.svg
- svg/custom/image-clipped-hit.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Anders.
weinig@apple.com [Sun, 2 Dec 2007 23:40:21 +0000 (23:40 +0000)]
    Rubber stamped by Anders.

        Use [NSURL absoluteString] instead of [NSURL description] in order to get
        more uniform results cross platform.

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[NSURL _drt_descriptionSuitableForTestResult]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Niko.
weinig@apple.com [Sun, 2 Dec 2007 23:32:42 +0000 (23:32 +0000)]
    Rubber stamped by Niko.

        Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
        * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
        * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
        * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin
beidson@apple.com [Sun, 2 Dec 2007 20:20:07 +0000 (20:20 +0000)]
    Reviewed by Darin

        databaseChanged notifications were being sent out on the database thread - they need to be on the main thread
        like all other notifications we send out!

        * platform/SecurityOriginData.cpp:
        (WebCore::SecurityOriginData::copy): Add a deep copy method, for when an object thread hops
        * platform/SecurityOriginData.h:

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): Add the origin/name pair to a queue
        (WebCore::DatabaseTracker::scheduleForNotification): Schedule to deliver this queue of notifications
          on the main thread
        (WebCore::DatabaseTracker::notifyDatabasesChanged): Deliver all notifications in the queue
        * storage/DatabaseTracker.h:

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::postflightAndCommit): scheduleNotifyDatabaseChanged() instead of "notify now!"
        (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
rwlbuis@webkit.org [Sun, 2 Dec 2007 19:32:59 +0000 (19:32 +0000)]
    Reviewed by Darin.

        Load SVG (and other) UA StyleSheets dynamically when needed

        Load svg sheet when needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoSpeculative Windows build fix.
mrowe@apple.com [Sun, 2 Dec 2007 12:59:21 +0000 (12:59 +0000)]
Speculative Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRubber stamped by Eric.
zimmermann@webkit.org [Sun, 2 Dec 2007 12:02:50 +0000 (12:02 +0000)]
Rubber stamped by Eric.

Move platform/graphics/svg to graphics/svg as discussed on webkit-dev.
Updated all project files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Maciej.
zimmermann@webkit.org [Sun, 2 Dec 2007 11:22:34 +0000 (11:22 +0000)]
Reviewed by Maciej.
Fix IDL lookup in subdirectories. Missing 'my' prefix for the 'thisDir' variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add another screenshot
aroben@apple.com [Sun, 2 Dec 2007 08:32:09 +0000 (08:32 +0000)]
    Add another screenshot

        * blog-files/InspectElementMenu.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-01 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 2 Dec 2007 08:16:48 +0000 (08:16 +0000)]
2007-12-01  Alp Toker  <alp@atoker.com>

        Reviewed by Adam Roben.

        Wrap type definitions in webkitdefines.h with G_BEGIN_DECLS, which
        takes care of extern "C".

        Introduce a webkit.h convenience header.

        Remove another left-over from the old API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add some Inspector screenshots for an upcoming blog post
aroben@apple.com [Sun, 2 Dec 2007 08:07:22 +0000 (08:07 +0000)]
    Add some Inspector screenshots for an upcoming blog post

        Rubberstamped by Mark Rowe.

        * blog-files/InspectorCSSEditing.png: Added.
        * blog-files/InspectorFonts.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim
beidson@apple.com [Sun, 2 Dec 2007 07:56:42 +0000 (07:56 +0000)]
    Reviewed by Tim

        Added a default database quota of 5mb to the default WebPreferences

        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-01 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 2 Dec 2007 06:43:36 +0000 (06:43 +0000)]
2007-12-01  Alp Toker  <alp@atoker.com>

        Reviewed by Adam Roben.

        [Gtk] Allow API clients to interact with JavaScript in web pages

        Include the necessary JavaScriptCore headers directly in the public
        API headers.

        This is the last of a series of changes needed to allow GTK+
        applications to access the JS API.

        Until http://bugs.webkit.org/show_bug.cgi?id=16029 is resolved,
        developers will still have to include the individual JS API headers
        individually if they want to use it in their applications.

        Patch also removes some old legacy use of GDK that was in
        WebKitWebFrame. No ABI change.

        * WebView/webkitdefines.h:
        * WebView/webkitwebframe.h:
        * WebView/webkitwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
antti@apple.com [Sun, 2 Dec 2007 06:14:18 +0000 (06:14 +0000)]

        Reviewed by Adam.

        - Fix a crash when removing a loading media element from the tree.
        - Follow the spec by invoking pause() when element is removed from the tree instead of unloading.

        Tests: http/tests/media/remove-while-loading.html

        * html/HTMLMediaElement.cpp:


        Reviewed by Adam.

        Test that removing a media element when it is loading does not crash.
        Test that media is paused when it is removed from the tree.

        * http/tests/media/remove-while-loading-expected.txt: Added.
        * http/tests/media/remove-while-loading.html: Added.
        * media/remove-from-document-expected.txt: Added.
        * media/remove-from-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-01 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 2 Dec 2007 05:24:25 +0000 (05:24 +0000)]
2007-12-01  Alp Toker  <alp@atoker.com>

        Reviewed by Adam Roben.

        kJSClassDefinitionEmpty is not exported with JS_EXPORT

        Add JS_EXPORT to kJSClassDefinitionEmpty.

        Make the gcc compiler check take precedence over the WIN32||_WIN32
        check to ensure that symbols are exported on Windows when using gcc.

        Add a TODO referencing the bug about JS_EXPORT in the Win build

        Don't define JS_EXPORT as 'extern' when the compiler is unknown since
        it would result in the incorrect expansion:

          extern extern const JSClassDefinition kJSClassDefinitionEmpty;

        (This was something we inherited from CFBase.h that doesn't make sense
        for JSBase.h)

        * API/JSBase.h:
        * API/JSObjectRef.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth Dakin.
ggaren@apple.com [Sat, 1 Dec 2007 23:59:11 +0000 (23:59 +0000)]
    Reviewed by Beth Dakin.

        Restored the test string in this test.

        * manual-tests/window-open-features-parsing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren@apple.com [Sat, 1 Dec 2007 23:56:56 +0000 (23:56 +0000)]

        Reviewed by Beth Dakin.

        Reversed the ownership relationship between Interpreter and JSGlobalObject.
        Now, the JSGlobalObject owns the Interpreter, and top-level objects
        that need the two to persist just protect the JSGlobalObject from GC.

        Global object bootstrapping looks a little odd right now, but it will
        make much more sense soon, after further rounds of refactoring.

        * bindings/runtime_root.h: Made this class inherit from RefCounted,
        to avoid code duplication.

        * kjs/collector.cpp:
        (KJS::Collector::collect): No need to give special GC treatment to
        Interpreters, since we mark their global objects, which mark them.

        * kjs/interpreter.cpp:
        (KJS::Interpreter::mark): No need to mark our global object, since it
        marks us.
        * kjs/interpreter.h: Don't inherit from RefCounted -- JSGlobalObject
        owns us directly.

        * kjs/testkjs.cpp: Modified to follow the new rules.


        Reviewed by Beth Dakin.

        Modified to follow new JSGlobalObject/Interpreter ownership rules
        in JavaScriptCore.

        * JSRun.cpp:
        * JSRun.h:
        * JSValueWrapper.cpp:


        Reviewed by Beth Dakin.

        Modified WebCore to follow the new JSGlobalObject/Interpreter ownership
        rules in JavaScriptCore.

        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_binding.h: Removed stale, unused

        * bindings/js/kjs_proxy.cpp: Changed to store a global object, rather
        than an interpreter.
        (WebCore::KJSProxy::finishedWithEvent): Need to NULL check
        m_globalObject here because we no longer unnecessarily instantiate it.

        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h: Removed redundant and less efficient
        interpreter() function -- global objects have direct access to their
        interpreters now.

        Changed these functions to pass around JSGlobalObjects instead of

        * page/Frame.cpp:
        * page/Frame.h:
        * page/mac/WebCoreFrameBridge.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Check to see if the directory exists and exit if not.
treat@webkit.org [Sat, 1 Dec 2007 23:35:19 +0000 (23:35 +0000)]
* Check to see if the directory exists and exit if not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rename IWebViewPrivate::selectionImageRect to IWebViewPrivate::selectionRect.
weinig@apple.com [Sat, 1 Dec 2007 22:29:46 +0000 (22:29 +0000)]
    Rename IWebViewPrivate::selectionImageRect to IWebViewPrivate::selectionRect.

        Rubber stamped by Adam Roben.

        * Interfaces/IWebViewPrivate.idl:
        * WebView.cpp:
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
mitz@apple.com [Sat, 1 Dec 2007 22:15:54 +0000 (22:15 +0000)]
    Reviewed by Mark Rowe.

        * config.ini: Correct blog name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdate StringsNotToBeLocalized.txt.
timothy@apple.com [Sat, 1 Dec 2007 21:08:46 +0000 (21:08 +0000)]
Update StringsNotToBeLocalized.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
darin@apple.com [Sat, 1 Dec 2007 19:04:15 +0000 (19:04 +0000)]
    Reviewed by Mitz.

        - fix problem tracked by these bugs:
          <rdar://problem/5619305> Safari crashes during load of LexisNexis search results
          <rdar://problem/5510779> CrashTracer: [USER] 25 crashes in Safari at
          WebCore::DocumentLoader::isLoadingMultipartContent const

        * loader/ImageDocument.cpp:
        (WebCore::ImageDocument::createDocumentStructure): Create an ImageDocumentElement
        instead of an HTMLImageElement.
        (WebCore::ImageDocument::scale): Added a null check for m_imageElement.
        (WebCore::ImageDocument::resizeImageToFit): Ditto.
        (WebCore::ImageDocument::restoreImageSize): Ditto.
        (WebCore::ImageDocument::imageFitsInWindow): Ditto.
        (WebCore::ImageDocument::windowSizeChanged): Ditto.
        (WebCore::ImageDocumentElement::~ImageDocumentElement): Call
        disconnectImageElement so m_imageElement will be set to 0
         if we're still connected to the document.
        (WebCore::ImageDocumentElement::willMoveToNewOwnerDocument): Ditto.

        * loader/ImageDocument.h: Changed image element type to be
        ImageDocumentElement instead of HTMLImageElement. Also added
        a disconnectImageElement function that sets m_imageElement to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - remove the empty directories
darin@apple.com [Sat, 1 Dec 2007 18:44:08 +0000 (18:44 +0000)]
    - remove the empty directories

        * ksvg2: Removed.
        * ksvg2/css: Removed.
        * ksvg2/events: Removed.
        * ksvg2/misc: Removed.
        * ksvg2/scripts: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoIgnore another file that's now part of hosted SunSpider.
darin@apple.com [Sat, 1 Dec 2007 18:09:49 +0000 (18:09 +0000)]
Ignore another file that's now part of hosted SunSpider.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-01 Julien Chaffraix <julien.chaffraix@gmail.com>
mrowe@apple.com [Sat, 1 Dec 2007 16:51:00 +0000 (16:51 +0000)]
2007-12-01  Julien Chaffraix  <julien.chaffraix@gmail.com>

        Bug 16189: XMLHttpRequest::setRequestHeader() should not set certain headers

        Reviewed by Darin Adler.

        * xml/XMLHttpRequest.cpp:

        Test: http/tests/xmlhttprequest/set-dangerous-headers.html

2007-12-01  Julien Chaffraix  <julien.chaffraix@gmail.com>

        Bug 16189: XMLHttpRequest::setRequestHeader() should not set certain headers

        Reviewed by Darin Adler.

        * http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
        * http/tests/xmlhttprequest/set-dangerous-headers.html: Added tests for new headers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-01 Rahul Abrol <ra5ul@comcast.net>
mrowe@apple.com [Sat, 1 Dec 2007 16:41:55 +0000 (16:41 +0000)]
2007-12-01  Rahul Abrol  <ra5ul@comcast.net>

        Reviewed by Adam Roben.

        Ignore resizable=no for window.open().

        * bindings/js/kjs_window.cpp:
        * manual-tests/window-open-features-parsing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Sat, 1 Dec 2007 16:33:40 +0000 (16:33 +0000)]

        Reviewed by Darin Adler.

        - fix <rdar://problem/5619240> REGRESSION (Leopard-r28069): Reproducible crash with a Mootools-based calendar picker (jump to null in FrameView::layout)

        Test: fast/dynamic/subtree-common-root.html

        * page/FrameView.cpp:
        (WebCore::FrameView::layoutRoot): Added a parameter to let this method
        return the layout root for a pending layout as well.
        (WebCore::FrameView::scheduleRelayoutOfSubtree): Pass the new root
        to markContainingBlocksForLayout(). Otherwise,
        markContainingBlocksForLayout() could mark past the new root, if it had
        previously been marked as having a normal child needing layout and then
        was reached via a positioned child.
        * page/FrameView.h:
        * rendering/RenderBox.cpp:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::~RenderObject): Fixed the ASSERT so that
        it would really catch deletion of the layout root.
        (WebCore::RenderObject::markContainingBlocksForLayout): Added the
        newRoot parameter, which tells this method where to stop marking.
        * rendering/RenderObject.h:


        Reviewed by Darin Adler.

        - test for <rdar://problem/5619240> REGRESSION (Leopard-r28069): Reproducible crash with a Mootools-based calendar picker (jump to null in FrameView::layout)

        * fast/dynamic/subtree-common-root-expected.txt: Added.
        * fast/dynamic/subtree-common-root.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
mitz@apple.com [Sat, 1 Dec 2007 16:28:57 +0000 (16:28 +0000)]
    Reviewed by Darin Adler.

        - fold FontStyle into TextRun

        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/Font.cpp:
        * platform/graphics/Font.h:
        * platform/graphics/FontStyle.h: Removed.
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/StringTruncator.cpp:
        * platform/graphics/gtk/FontGtk.cpp:
        * platform/graphics/mac/FontMac.mm:
        * platform/graphics/qt/FontQt.cpp:
        * platform/graphics/win/FontWin.cpp:
        * platform/graphics/wx/FontWx.cpp:
        * platform/mac/WebCoreTextRenderer.mm:
        * platform/win/PopupMenuWin.cpp:
        * platform/win/UniscribeController.cpp:
        * platform/win/UniscribeController.h:
        * platform/win/WebCoreTextRenderer.cpp:
        * rendering/EllipsisBox.cpp:
        * rendering/InlineTextBox.cpp:
        * rendering/RenderFileUploadControl.cpp:
        * rendering/RenderImage.cpp:
        * rendering/RenderListBox.cpp:
        * rendering/RenderMenuList.cpp:
        * rendering/RenderText.cpp:
        * rendering/RenderText.h:
        * rendering/RenderTextControl.cpp:
        * rendering/SVGInlineTextBox.cpp:
        * rendering/SVGRootInlineBox.cpp:
        * rendering/SVGRootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add another feed
aroben@apple.com [Sat, 1 Dec 2007 06:56:29 +0000 (06:56 +0000)]
    Add another feed

        * config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add a simple script to update the site
aroben@apple.com [Sat, 1 Dec 2007 06:48:33 +0000 (06:48 +0000)]
    Add a simple script to update the site

        * update.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Include all WebKit posts from Trolltech Labs
aroben@apple.com [Sat, 1 Dec 2007 06:34:18 +0000 (06:34 +0000)]
    Include all WebKit posts from Trolltech Labs

        * config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Don't hide symbols when in Debug mode
hausmann@webkit.org [Sat, 1 Dec 2007 05:46:20 +0000 (05:46 +0000)]
* Don't hide symbols when in Debug mode
* On Linux (glibc) provide a backtrace in the test output for debugging purposes

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-30 Jan Michael Alonzo <jmalonzo@unpluggable.com>
alp@webkit.org [Sat, 1 Dec 2007 05:29:05 +0000 (05:29 +0000)]
2007-11-30  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Fix for GTK+ Debug build breakage introduced in r28273.

        * WebView/webkitprivate.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-30 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 1 Dec 2007 04:24:09 +0000 (04:24 +0000)]
2007-11-30  Alp Toker  <alp@atoker.com>

        Reviewed by Adam Roben.

        [GTK] Public API does not follow GTK+ conventions

        Refactor the WebKit/GTK+ public API. Changes:
          WebKitPage -> WebKitWebView
          WebKitFrame -> WebKitWebFrame

        Public API source and header names have been updated to mirror the API

        The API is now kept in WebKit/gtk/WebView to match other ports in the
        same class such as Mac and Win.

        API/ABI-breaking change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
aroben@apple.com [Sat, 1 Dec 2007 02:25:07 +0000 (02:25 +0000)]
    Reviewed by Eric.

        * ChangeLog:
        * pcre/pcre_compile.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
pewtermoose@webkit.org [Sat, 1 Dec 2007 01:57:07 +0000 (01:57 +0000)]
    Reviewed by Adam.

        Link to the commit and review policy.

        * coding/contributing.html:
        * nav.inc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * coding/commit-review-policy.html: A couple more typos and very
darin@apple.com [Sat, 1 Dec 2007 01:47:24 +0000 (01:47 +0000)]
    * coding/commit-review-policy.html: A couple more typos and very
        minor grammatical stuff. No substantive change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * coding/commit-review-policy.html: Fixed a typo, added a footer.
darin@apple.com [Sat, 1 Dec 2007 01:42:36 +0000 (01:42 +0000)]
    * coding/commit-review-policy.html: Fixed a typo, added a footer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Initial checkin of Planet WebKit
aroben@apple.com [Sat, 1 Dec 2007 01:37:47 +0000 (01:37 +0000)]
    Initial checkin of Planet WebKit

        Rubberstamped by Sam.

        * README: Added.
        * config.ini: Added.
        * planet/AUTHORS: Added.
        * planet/INSTALL: Added.
        * planet/LICENCE: Added.
        * planet/NEWS: Added.
        * planet/PKG-INFO: Added.
        * planet/README: Added.
        * planet/THANKS: Added.
        * planet/TODO: Added.
        * planet/examples/atom.xml.tmpl: Added.
        * planet/examples/basic/config.ini: Added.
        * planet/examples/basic/index.html.tmpl: Added.
        * planet/examples/fancy/config.ini: Added.
        * planet/examples/fancy/index.html.tmpl: Added.
        * planet/examples/foafroll.xml.tmpl: Added.
        * planet/examples/opml.xml.tmpl: Added.
        * planet/examples/output/images/edd.png: Added.
        * planet/examples/output/images/evolution.png: Added.
        * planet/examples/output/images/feed-icon-10x10.png: Added.
        * planet/examples/output/images/jdub.png: Added.
        * planet/examples/output/images/keybuk.png: Added.
        * planet/examples/output/images/logo.png: Added.
        * planet/examples/output/images/opml.png: Added.
        * planet/examples/output/images/planet.png: Added.
        * planet/examples/output/images/thom.png: Added.
        * planet/examples/output/planet.css: Added.
        * planet/examples/rss10.xml.tmpl: Added.
        * planet/examples/rss20.xml.tmpl: Added.
        * planet/planet-cache.py: Added.
        * planet/planet.py: Added.
        * planet/planet/__init__.py: Added.
        * planet/planet/atomstyler.py: Added.
        * planet/planet/cache.py: Added.
        * planet/planet/compat_logging/__init__.py: Added.
        * planet/planet/compat_logging/config.py: Added.
        * planet/planet/compat_logging/handlers.py: Added.
        * planet/planet/feedparser.py: Added.
        * planet/planet/htmltmpl.py: Added.
        * planet/planet/sanitize.py: Added.
        * planet/planet/tests/__init__.py: Added.
        * planet/planet/tests/data/simple.tmpl: Added.
        * planet/planet/tests/data/simple2.tmpl: Added.
        * planet/planet/tests/test_channel.py: Added.
        * planet/planet/tests/test_main.py: Added.
        * planet/planet/tests/test_sanitize.py: Added.
        * planet/planet/tests/test_sub.py: Added.
        * planet/planet/timeoutsocket.py: Added.
        * planet/runtests.py: Added.
        * planet/setup.py: Added.
        * templates/atom.xml.tmpl: Added.
        * templates/foafroll.xml.tmpl: Added.
        * templates/index.html.tmpl: Added.
        * templates/opml.xml.tmpl: Added.
        * templates/rss10.xml.tmpl: Added.
        * templates/rss20.xml.tmpl: Added.
        * wwwroot/images/feed-icon-10x10.png: Added.
        * wwwroot/images/planet.png: Added.
        * wwwroot/planet.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
pewtermoose@webkit.org [Sat, 1 Dec 2007 00:48:42 +0000 (00:48 +0000)]
    Reviewed by Maciej.

        Clean up a couple of typos from Maciej's last patch.

        * coding/commit-review-policy.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago <rdar://problem/5621373> Added a way for the client to clear undo/redo
adachan@apple.com [Sat, 1 Dec 2007 00:47:47 +0000 (00:47 +0000)]
    <rdar://problem/5621373> Added a way for the client to clear undo/redo
        operations from a WebView.

        Reviewed by Steve.

        * Interfaces/IWebViewPrivate.idl:
        * WebView.cpp:
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Bertrand.
mjs@apple.com [Sat, 1 Dec 2007 00:27:55 +0000 (00:27 +0000)]
    Reviewed by Bertrand.

        New commit and review policy.

        * coding/commit-review-policy.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add platform/text project group.
andersca@apple.com [Sat, 1 Dec 2007 00:18:25 +0000 (00:18 +0000)]
    Add platform/text project group.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 1 Dec 2007 00:05:11 +0000 (00:05 +0000)]
2007-11-30  Eric Seidel  <eric@webkit.org>

        No review, build fix only.

        Fix uninitialized var warnings in release build.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * pcre/pcre_compile.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Remove extra </Filter> tag which prevented the vcproj from being parsed corre...
andersca@apple.com [Fri, 30 Nov 2007 23:57:44 +0000 (23:57 +0000)]
    Remove extra </Filter> tag which prevented the vcproj from being parsed correctly.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff Garen
sullivan@apple.com [Fri, 30 Nov 2007 23:47:20 +0000 (23:47 +0000)]
    Reviewed by Geoff Garen

        Added another symbol for WebDatabaseManager clients

        * WebKit.exp:
        added .objc_class_name_WebSecurityOrigin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 30 Nov 2007 23:43:45 +0000 (23:43 +0000)]
2007-11-30  Eric Seidel  <eric@webkit.org>

        Reviewed by darin.

        PCRE crashes under GuardMalloc
        check against patternEnd to make sure we don't walk off the end of the string

        * pcre/pcre_compile.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoNot reviewed. Try to fix qt/gtk build.
zimmermann@webkit.org [Fri, 30 Nov 2007 23:25:30 +0000 (23:25 +0000)]
Not reviewed. Try to fix qt/gtk build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRubber stamped by Eric.
zimmermann@webkit.org [Fri, 30 Nov 2007 23:19:53 +0000 (23:19 +0000)]
Rubber stamped by Eric.

Final integration of ksvg2 in WebKit. Moving ksvg2/ to svg/ and killing all it's subdirectories,
by moving the files into approriate locations (css, rendering, ...) - as dicsussed on the
mailing list and on IRC with David/Darin & Eric.

Updated all build files - though I can't guarantee it builds on non-mac. Need buildbot to verify.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agowx build fix. Add WebCore/platform/graphics/wx to includes.
kevino@webkit.org [Fri, 30 Nov 2007 22:22:36 +0000 (22:22 +0000)]
wx build fix. Add WebCore/platform/graphics/wx to includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff
beidson@apple.com [Fri, 30 Nov 2007 22:08:06 +0000 (22:08 +0000)]
    Reviewed by Geoff

        Further hookup of Database API
        With this change, any database operation that writes to the database (UPDATE, INSERT, CREATE, etc) will
        result in a didModifyDatabase notification when the transaction is successfully committed

        * storage/DatabaseAuthorizer.cpp: Global rename of "m_lastActionIncreasedSize" to "m_lastActionChangedDatabase"
        * storage/DatabaseAuthorizer.h:

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::notifyDatabaseChanged): Added.  Allow external entities (SQLTransaction) to be able
          to request a didModifyDatabase notification to the delegate
        * storage/DatabaseTracker.h:

        * storage/SQLTransaction.cpp: Added m_modifiedDatabase flag which tracks if any statement over the course of
          a transaction resulted in a change to the database.
        (WebCore::SQLTransaction::runCurrentStatement): Set m_modifiedDatabase to true if the authorizer reports a mutation
          statement occurred
        (WebCore::SQLTransaction::postflightAndCommit): If the transaction successfully commits, call DatabaseTracker::notifyDatabaseChanged
        (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto
        * storage/SQLTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28256 268f45cc-cd09-0410-ab3c-d52691b4dbfc