WebKit-https.git
13 years agoBuild fix for gcc 4.3 and Gtk.
hausmann@webkit.org [Fri, 18 Apr 2008 09:31:58 +0000 (09:31 +0000)]
Build fix for gcc 4.3 and Gtk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 18 Apr 2008 07:40:17 +0000 (07:40 +0000)]
2008-04-17  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        https://bugs.webkit.org/show_bug.cgi?id=18573

        Implement supplemental transforms and use them for <animateMotion> instead of the transform list.
        This will allow <animateTransform> and <animateMotion> combine properly.

        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::resetToBaseValue):
        (WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
        (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
        * svg/SVGElement.h:
        (WebCore::SVGElement::supplementalTransform):
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
        * svg/SVGStyledTransformableElement.h:
        (WebCore::SVGStyledTransformableElement::supplementalTransform):
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::animatedLocalTransform):
        * svg/SVGTextElement.h:
        (WebCore::SVGTextElement::supplementalTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 18 Apr 2008 05:44:27 +0000 (05:44 +0000)]
2008-04-17  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        Implement calcMode=paced.

        Tested by SVG testsuite tests
        animate-elem-11-t.svg
        animate-elem-15-t.svg
        animate-elem-82-t.svg

        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateDistance):
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::calculateDistance):
        * svg/SVGAnimateMotionElement.h:
        * svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::calculateDistance):
        * svg/SVGAnimateTransformElement.h:
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced):
        (WebCore::SVGAnimationElement::startedActiveInterval):
        * svg/SVGAnimationElement.h:
        (WebCore::SVGAnimationElement::calculateDistance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 18 Apr 2008 04:02:51 +0000 (04:02 +0000)]
2008-04-17  David Hyatt  <hyatt@apple.com>

        Fix a leak in ImageBuffer's clearImage method.

        Reviewed by olliej

        * platform/graphics/ImageBuffer.h:
        (WebCore::ImageBuffer::clearImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 18 Apr 2008 03:45:59 +0000 (03:45 +0000)]
2008-04-17  Antti Koivisto  <antti@apple.com>

        Update SVG animation test results.

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 18 Apr 2008 03:45:34 +0000 (03:45 +0000)]
2008-04-17  Antti Koivisto  <antti@apple.com>

        Reviewed by Eric.

        https://bugs.webkit.org/show_bug.cgi?id=12438

        More SVG animation:

        - Make multiple additive animations work
        - Support animating <use> instance trees

        * svg/SVGAnimateColorElement.cpp:
        (WebCore::SVGAnimateColorElement::SVGAnimateColorElement):
        * svg/SVGAnimateColorElement.h:

        Made this AnimateElement subclass. All functionality is now provided by AnimateElement.

        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::determinePropertyType):
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        (WebCore::SVGAnimateElement::resetToBaseValue):
        (WebCore::SVGAnimateElement::applyResultsToTarget):
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::resetToBaseValue):
        (WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
        (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
        * svg/SVGAnimateMotionElement.h:
        * svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::resetToBaseValue):
        (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
        (WebCore::SVGAnimateTransformElement::calculateFromAndByValues):
        (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
        * svg/SVGAnimateTransformElement.h:

        Switch to new model where
        - resetToBaseValue() resets the animated value back to the base value
        - calculateAnimatedValue() computes the value and adds it to the element used for accumulation
        - applyResultsToTarget() sets the computed value the target element

        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::fromValue):
        (WebCore::SVGAnimationElement::attributeIsCSS):
        (WebCore::SVGAnimationElement::targetAttributeIsCSS):
        (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):

        Update instances too.

        (WebCore::SVGAnimationElement::startedActiveInterval):
        (WebCore::SVGAnimationElement::updateAnimation):
        (WebCore::SVGAnimationElement::endedActiveInterval):
        * svg/SVGAnimationElement.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        * svg/SVGSetElement.cpp:
        (WebCore::SVGSetElement::SVGSetElement):
        * svg/SVGSetElement.h:

        Made this AnimateElement subclass. All functionality is now provided by AnimateElement.

        * svg/animation/SMILTimeContainer.cpp:
        (WebCore::SMILTimeContainer::SMILTimeContainer):
        (WebCore::SMILTimeContainer::unschedule):
        (WebCore::SMILTimeContainer::updateDocumentOrderIndexes):
        (WebCore::PriorityCompare::PriorityCompare):
        (WebCore::PriorityCompare::operator()):
        (WebCore::SMILTimeContainer::sortByPriority):
        (WebCore::applyOrderSortFunction):
        (WebCore::sortByApplyOrder):
        (WebCore::SMILTimeContainer::baseValueFor):
        (WebCore::SMILTimeContainer::updateAnimations):
        * svg/animation/SMILTimeContainer.h:
        (WebCore::SMILTimeContainer::create):
        (WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):

        Do additive animation with the following steps
        - sort active animations based on their priority (begin time, document order).
        - if not yet saved for each (element, attribute) pair save the base value.
        - lowest priority animation for each (element, attribute) acts as the result element.
        - animation results are resolved in priority order and results are accumulated to the result element.
        - after all active animations have been processed the values in result elements are applied to the target elements.

        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::SVGSMILElement):
        (WebCore::SVGSMILElement::insertedIntoDocument):

        Invalidate document order index.

        (WebCore::SVGSMILElement::attributeName):
        (WebCore::SVGSMILElement::isInactive):
        (WebCore::SVGSMILElement::isFrozen):
        (WebCore::SVGSMILElement::beginListChanged):
        (WebCore::SVGSMILElement::determineActiveState):
        (WebCore::SVGSMILElement::isContributing):
        (WebCore::SVGSMILElement::progress):

        Take care that animations in frozen state still contribute to the total. Since we now build the result starting
        from the base value, fill="replace" works magically simply by not contributing anything.

        * svg/animation/SVGSMILElement.h:
        (WebCore::SVGSMILElement::previousIntervalBegin):
        (WebCore::SVGSMILElement::documentOrderIndex):
        (WebCore::SVGSMILElement::setDocumentOrderIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix many tests on Windows
aroben@apple.com [Fri, 18 Apr 2008 01:50:29 +0000 (01:50 +0000)]
    Fix many tests on Windows

        * Scripts/run-webkit-tests:
        (readFromDumpToolWithTimer):
         - Use read instead of sysread to ensure that we don't interfere with
           other uses of buffered IO in this script.
        (setFileHandleNonBlocking): Actually set the filehandle to blocking
        when specified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Fri, 18 Apr 2008 01:03:03 +0000 (01:03 +0000)]
2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by mrowe.

        Define HAVE_ACCESSIBILITY where WebKit, WebCore can see it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Fri, 18 Apr 2008 01:02:29 +0000 (01:02 +0000)]
2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by aliu.

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::layoutCount): Check isRenderView() before
        casting to RenderView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 18 Apr 2008 01:01:04 +0000 (01:01 +0000)]
2008-04-17  Antti Koivisto  <antti@apple.com>

        Re-enable animation tests on windows.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 18 Apr 2008 00:57:12 +0000 (00:57 +0000)]
2008-04-17  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        Fix https://bugs.webkit.org/show_bug.cgi?id=18551
        Bug 18551: REGRESSION (r31801?): Crash in ContainerNode::removedFromDocument on many SVG tests under guard malloc

        Freeing a RefPtr that is the last ref to the parent from removedFromDocument() is a bad idea.

        Caching the target element is too dangerous, let's simply not do it. Getting it is very cheap anyway.

        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::removedFromDocument):
        (WebCore::SVGSMILElement::attributeChanged):
        (WebCore::SVGSMILElement::targetElement):
        * svg/animation/SVGSMILElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix ~10 tests
aroben@apple.com [Fri, 18 Apr 2008 00:56:56 +0000 (00:56 +0000)]
    Fix ~10 tests

        * Scripts/run-webkit-tests: Only remove the newline after #EOF, not
        whatever newline happens to be at the end of what we've read.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Fri, 18 Apr 2008 00:56:23 +0000 (00:56 +0000)]
WebCore:

2008-04-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Autogenerate the XMLHttpRequest javascript binding.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:
        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/JSXMLHttpRequest.cpp: Removed.
        * bindings/js/JSXMLHttpRequest.h: Removed.
        * bindings/js/JSXMLHttpRequestConstructor.cpp: Added.
        (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
        (WebCore::JSXMLHttpRequestConstructor::implementsConstruct):
        (WebCore::JSXMLHttpRequestConstructor::construct):
        * bindings/js/JSXMLHttpRequestConstructor.h: Added.
        (WebCore::JSXMLHttpRequestConstructor::classInfo):
        * bindings/js/JSXMLHttpRequestCustom.cpp: Added.
        (WebCore::JSXMLHttpRequest::mark):
        (WebCore::JSXMLHttpRequest::onreadystatechange):
        (WebCore::JSXMLHttpRequest::setOnreadystatechange):
        (WebCore::JSXMLHttpRequest::onload):
        (WebCore::JSXMLHttpRequest::setOnload):
        (WebCore::JSXMLHttpRequest::responseXML):
        (WebCore::JSXMLHttpRequest::open):
        (WebCore::JSXMLHttpRequest::setRequestHeader):
        (WebCore::JSXMLHttpRequest::send):
        (WebCore::JSXMLHttpRequest::getResponseHeader):
        (WebCore::JSXMLHttpRequest::overrideMimeType):
        (WebCore::JSXMLHttpRequest::addEventListener):
        (WebCore::JSXMLHttpRequest::removeEventListener):
        (WebCore::JSXMLHttpRequest::dispatchEvent):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::readyState):
        (WebCore::XMLHttpRequest::responseText):
        * xml/XMLHttpRequest.h:
        * xml/XMLHttpRequest.idl: Added.

LayoutTests:

2008-04-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Update test result for additon of XMLHttpRequest constants.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove DRT/win's hang timer
aroben@apple.com [Fri, 18 Apr 2008 00:50:15 +0000 (00:50 +0000)]
    Remove DRT/win's hang timer

        run-webkit-tests takes care of this for us now

        Reviewed by Anders Carlsson.

        * DumpRenderTree/win/DumpRenderTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Don't wait for the hang timer twice in the case of a hang
aroben@apple.com [Fri, 18 Apr 2008 00:49:54 +0000 (00:49 +0000)]
    Don't wait for the hang timer twice in the case of a hang

        Previously we'd wait for a hang while reading both stdout and stderr
        from DRT. Now we'll only wait for one or the other.

        Reviewed by Anders Carlsson.

        * Scripts/run-webkit-tests:
        (top level): Don't wait for stderr to time out if stdout already timed
        out.
        (readFromDumpToolWithTimer): If $dontWaitForTimeOut is true, quit
        after the first read that returns no data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Don't throw away the output from timed out tests
aroben@apple.com [Fri, 18 Apr 2008 00:48:30 +0000 (00:48 +0000)]
    Don't throw away the output from timed out tests

        Reviewed by Anders Carlsson.

        * Scripts/run-webkit-tests:
        (top level): Updated for changes to readFromDumpToolWithTimer.
        (readFromDumpToolWithTimer): Return a hash that contains both the
        output and whether or not the test timed out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 18 Apr 2008 00:22:41 +0000 (00:22 +0000)]
2008-04-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        The SessionStorage for a Page has to be copied every time a new Page is created.

        I thought I had the right choke point for creating new Pages at FrameLoader::createWindow(),
        but it just so happens there was another - in the ContextMenuController.

        The *real* choke point for this, then, is in the Chrome itself.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createWindow): Don't do the SessionStorage copy here...

        * page/Chrome.cpp:
        (WebCore::Chrome::createWindow): Do it here, instead!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make the hang timer 60 seconds
aroben@apple.com [Fri, 18 Apr 2008 00:13:49 +0000 (00:13 +0000)]
    Make the hang timer 60 seconds

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Fri, 18 Apr 2008 00:06:50 +0000 (00:06 +0000)]
2008-04-17  Alice Liu  <alice.liu@apple.com>

        Reviewed by Jon Honeycutt.

        Added some asserts to catch undesirable usage of setWrapper and addChildren.

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::addChildren):
        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::setWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Get rid of carriage returns in DRT/win's stderr
aroben@apple.com [Thu, 17 Apr 2008 23:58:13 +0000 (23:58 +0000)]
    Get rid of carriage returns in DRT/win's stderr

        Reviewed by Eric Seidel.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (main): Mark stderr as binary like we already do for stdout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 17678: run-webkit-tests should have a watchdog timer (and timeout...
aroben@apple.com [Thu, 17 Apr 2008 23:57:55 +0000 (23:57 +0000)]
    Fix Bug 17678: run-webkit-tests should have a watchdog timer (and timeout long tests)

        <https://bugs.webkit.org/show_bug.cgi?id=17678>

        We now abort tests that take longer than 60 seconds to produce output.
        This matches the watchdog timer in DRT/mac and DRT/win (which we can
        now remove).

        Reviewed by Eric Seidel.

        * Scripts/run-webkit-tests:
        (top level): Read DRT's output using the new readFromDumpToolWithTimer
        subroutine. If readFromDumpToolWithTimer returns undefined it means
        the test timed out, so we register the test as a hang and move on.
        (sub testCrashedOrTimedOut): Renamed from testCrashed. Now handles
        both crashed and timed out tests. If the test timed out, we kill DRT
        before returning.
        (sub linksForTimedOutTest): Added. We don't have any output to link to for
        tests that timed out.
        (sub recordActualResultsAndDiff): Don't call length on undefined.
        (sub readFromDumpToolWithTimer): Added. Performs non-blocking reads
        from a filehandle until an #EOF is reached or
        $maximumSecondsWithoutOutput have elapsed.
        (sub setFileHandleNonBlocking): Marks a filehandle as blocking or
        non-blocking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Refactor test results page generation
aroben@apple.com [Thu, 17 Apr 2008 23:57:38 +0000 (23:57 +0000)]
    Refactor test results page generation

        Reviewed by Eric Seidel.

        * Scripts/run-webkit-tests:
        (sub htmlForResultsSection): Added. Takes a set of tests, a
        description, and a subroutine to generate the links for each test, and
        creates a HTML string containing a table of the tests and their
        links.
        (sub linksForExpectedAndActualResults): Added. Replaces the
        htmlForExpectedAndActualResults subroutine.
        (sub linksForMismatchTest): Added.
        (sub linksForCrashOrErrorTest): Added.
        (sub linksForNewTest): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Print the extension for all tests in the test results page
aroben@apple.com [Thu, 17 Apr 2008 23:57:21 +0000 (23:57 +0000)]
    Print the extension for all tests in the test results page

        Reviewed by Eric Seidel.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move code that counts finished tests into a subroutine
aroben@apple.com [Thu, 17 Apr 2008 23:57:04 +0000 (23:57 +0000)]
    Move code that counts finished tests into a subroutine

        Reviewed by Eric Seidel.

        * Scripts/run-webkit-tests:
        (sub countFinishedTest): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move code that handles a crash into a subroutine
aroben@apple.com [Thu, 17 Apr 2008 23:56:47 +0000 (23:56 +0000)]
    Move code that handles a crash into a subroutine

        Reviewed by Eric Seidel.

        * Scripts/run-webkit-tests:
        (sub testCrashed): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the...
mrowe@apple.com [Thu, 17 Apr 2008 23:31:56 +0000 (23:31 +0000)]
Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending

The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.

Reviewed by Dan Bernstein.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 23:22:38 +0000 (23:22 +0000)]
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Add applicationCache object.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 17 Apr 2008 23:09:33 +0000 (23:09 +0000)]
2008-04-17  Brady Eidson  <beidson@apple.com>

        Reviewed by the Mitzpettel

        Before things get much more intertwined, move away from a global LocalStorage model
        to a per-PageGroup LocalStorage model.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::localStorage): Get it from the current PageGroup, not the global
          LocalStorage (which doesn't exist anymore).

        * page/Page.cpp:
        * page/PageGroup.cpp:
        (WebCore::PageGroup::localStorage): Create a LocalStorage object on demand.
        * page/PageGroup.h:

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::LocalStorage): Hold a back pointer to the owning PageGroup.
        (WebCore::LocalStorage::storageArea):
        * storage/LocalStorage.h:
        (WebCore::LocalStorage::create):

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::LocalStorageArea): Hold a back pointer to the owning LocalStorage.
        * storage/LocalStorageArea.h:
        (WebCore::LocalStorageArea::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 17 Apr 2008 23:05:11 +0000 (23:05 +0000)]
2008-04-17  Alp Toker  <alp@atoker.com>

        GTK+ build fix. Back out the libjpeg check part of r32008 from bug
        #17865 (reopened).

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 22:47:34 +0000 (22:47 +0000)]
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Fix indentation.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::scheduleArchiveLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 22:34:06 +0000 (22:34 +0000)]
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        When in the web archive debug mode, don't call didFail immediately. Instead,
        add the loader to the substitute resource map, but with a null resource, which
        indicates to substituteResourceDeliveryTimerFired that the load should fail.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
        (WebCore::DocumentLoader::scheduleArchiveLoad):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by hyatt.
eric@webkit.org [Thu, 17 Apr 2008 21:54:50 +0000 (21:54 +0000)]
    Reviewed by hyatt.

        Rename RenderView to RenderViewport in the next rename patch.

        * Scripts/do-webcore-rename:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 21:30:36 +0000 (21:30 +0000)]
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Add JS bindings for the DOMApplicationCache object.

        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::add):
        (WebCore::JSDOMApplicationCache::remove):
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        (WebCore::JSDOMApplicationCache::dispatchEvent):
        (WebCore::JSDOMApplicationCache::setOnchecking):
        (WebCore::JSDOMApplicationCache::onchecking):
        (WebCore::JSDOMApplicationCache::setOnerror):
        (WebCore::JSDOMApplicationCache::onerror):
        (WebCore::JSDOMApplicationCache::setOnnoupdate):
        (WebCore::JSDOMApplicationCache::onnoupdate):
        (WebCore::JSDOMApplicationCache::setOndownloading):
        (WebCore::JSDOMApplicationCache::ondownloading):
        (WebCore::JSDOMApplicationCache::setOnprogress):
        (WebCore::JSDOMApplicationCache::onprogress):
        (WebCore::JSDOMApplicationCache::setOnupdateready):
        (WebCore::JSDOMApplicationCache::onupdateready):
        (WebCore::JSDOMApplicationCache::setOncached):
        (WebCore::JSDOMApplicationCache::oncached):
        (WebCore::JSDOMApplicationCache::mark):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::mark):
        * bindings/js/JSEventTargetBase.cpp:
        (WebCore::toJS):
        * loader/appcache/DOMApplicationCache.idl:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 17 Apr 2008 21:09:37 +0000 (21:09 +0000)]
2008-04-17  Alp Toker  <alp@atoker.com>

        Rubber-stamped by Holger Freyther.

        Reduce hard-coded page-cache count to 3 based on research done for the
        Mac port on value / page.

        We will need to make this more dynamic or configurable at some point
        but for now it's best to keep closer to the behaviour before page
        caching was enabled.

        Issue spotted by Mark Rowe.

        * webkit/webkitprivate.cpp:
        (webkit_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add some crashing tests to the Skipped file
aroben@apple.com [Thu, 17 Apr 2008 20:33:46 +0000 (20:33 +0000)]
    Add some crashing tests to the Skipped file

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Eric Carlson <eric.carlson@apple.com>
adele@apple.com [Thu, 17 Apr 2008 20:26:41 +0000 (20:26 +0000)]
2008-04-17 Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/5861642> QTMovieWin returns uninitialized values

        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWin::rate):
        (QTMovieWin::setRate):
        (QTMovieWin::setVolume):
        (QTMovieWin::getNaturalSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Marco Barisione <marco.barisione@collabora.co.uk>
alp@webkit.org [Thu, 17 Apr 2008 19:35:06 +0000 (19:35 +0000)]
2008-04-17  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18335
        Pango font backend unable to display japanese properly

        Different fonts can have different glyph indices, so we need to pass
        the right font when retrieving a glyph index.

        * platform/graphics/gtk/GlyphPageTreeNodePango.cpp:
        (WebCore::pango_font_get_glyph): Temporarily override the font in the
        PangoAnalysis passed to pango_shape.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Mario Bensi <mbensi@pleyo.com>
alp@webkit.org [Thu, 17 Apr 2008 19:25:41 +0000 (19:25 +0000)]
2008-04-17  Mario Bensi  <mbensi@pleyo.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18543
        DumpRenderTree gtk freeze

        fix DumpRenderTree gtk freeze

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Jan Michael Alonzo <jmalonzo@unpluggable.com>
alp@webkit.org [Thu, 17 Apr 2008 19:21:34 +0000 (19:21 +0000)]
2008-04-17  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=17865
        [Gtk] Improve detection of jpeglib and glib tools

        Improve detecting jpeglib and glib tools

        * configure.ac: Throw an error if the dependencies above are
        currently not installed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 19:10:05 +0000 (19:10 +0000)]
2008-04-17  Anders Carlsson  <andersca@apple.com>

        According to Sam and David, it's "topLevel", not "toplevel".

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::topLevelApplicationCache):
        * loader/DocumentLoader.h:
        * loader/appcache/DOMApplicationCache.cpp:
        (WebCore::DOMApplicationCache::associatedCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 19:05:54 +0000 (19:05 +0000)]
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Add DOMApplicationCache implementation.

        * dom/EventNames.h:
        Add new event names.

        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toDOMApplicationCache):
        * dom/EventTarget.h:
        Add EventTarget conversion method.

        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::):
        (WebCore::ApplicationCacheGroup::status):
        (WebCore::ApplicationCacheGroup::update):
        (WebCore::ApplicationCacheGroup::newestCache):
        Add more stubs.

        * loader/appcache/DOMApplicationCache.cpp:
        * loader/appcache/DOMApplicationCache.h:

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::clear):
        (WebCore::DOMWindow::applicationCache):
        * page/DOMWindow.h:
        (WebCore::DOMWindow::optionalApplicationCache):
        Add ApplicationCache member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Daniele Metilli <daniele.metilli@gmail.com>
alp@webkit.org [Thu, 17 Apr 2008 18:49:31 +0000 (18:49 +0000)]
2008-04-17  Daniele Metilli  <daniele.metilli@gmail.com>

        Reviewed by Eric.

        Fixed a typo in the copyright header.

        * webkit/webkitprivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 18:44:35 +0000 (18:44 +0000)]
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Build fix.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele@apple.com [Thu, 17 Apr 2008 17:26:23 +0000 (17:26 +0000)]
WebCore:

2008-04-17  Dean Jackson  <dino@apple.com>

        Reviewed by Hyatt.

        Fix for <rdar://problem/5849968> translate method should have Y=0 when only X is present

        Test: fast/css/transform-default-parameter.html

        * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
        translate function with only X parameter now leaves the Y parameter as zero.

LayoutTests:

2008-04-17  Dean Jackson  <dino@apple.com>

        Reviewed by Hyatt.

        Test for <rdar://problem/5849968> translate method should have Y=0 when only X is present

        * fast/css/transform-default-parameter.html: Added.
        * platform/mac/fast/css/transform-default-parameter-expected.checksum: Added.
        * platform/mac/fast/css/transform-default-parameter-expected.png: Added.
        * platform/mac/fast/css/transform-default-parameter-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 17:09:36 +0000 (17:09 +0000)]
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Add plumbing for associating document loaders with application caches.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::~DocumentLoader):
        (WebCore::DocumentLoader::originalURL):
        (WebCore::DocumentLoader::requestURL):
        (WebCore::DocumentLoader::responseURL):
        (WebCore::DocumentLoader::responseMIMEType):
        (WebCore::DocumentLoader::setCandidateApplicationCacheGroup):
        (WebCore::DocumentLoader::setApplicationCache):
        (WebCore::DocumentLoader::toplevelApplicationCache):
        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::candidateApplicationCacheGroup):
        (WebCore::DocumentLoader::applicationCache):
        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::documentLoaderDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
ap@webkit.org [Thu, 17 Apr 2008 16:04:48 +0000 (16:04 +0000)]
    Reviewed by Maciej.

        Thread static data destructors are not guaranteed to be called in any particular order;
        turn ThreadSpecific into a phoenix-style singleton to avoid accessing freed memory when
        deleted objects are interdependent (e.g. CommonIdentifiers and internal identifier tables).

        No change on SunSpider.

        * wtf/ThreadSpecific.h:
        (WTF::ThreadSpecific::Data::Data):
        (WTF::::get):
        (WTF::::set):
        (WTF::::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 18544: REGRESSION (r31951): Two fast/xsl tests crash
aroben@apple.com [Thu, 17 Apr 2008 15:31:50 +0000 (15:31 +0000)]
    Fix Bug 18544: REGRESSION (r31951): Two fast/xsl tests crash

        <https://bugs.webkit.org/show_bug.cgi?id=18544>

        r31951 changed XSLTProcessor::parseErrorFunc to expect a Console* as
        the context parameter. The caller in XSLTProcessor was changed, but
        the one in XSLStyleSheet was missed.

        Reviewed by Alexey Proskuryakov.

        * xml/XSLStyleSheet.cpp:
        (WebCore::XSLStyleSheet::parseString): Pass the Console as the context
        to parseErrorFunc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix after r31981
aroben@apple.com [Thu, 17 Apr 2008 15:11:54 +0000 (15:11 +0000)]
    Windows build fix after r31981

        * dom/Document.idl: Omit getCSSCanvasContext from the COM bindings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Thu, 17 Apr 2008 11:56:10 +0000 (11:56 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Implemented getFileModificationTime and pathGetFileName for the Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Thu, 17 Apr 2008 07:44:12 +0000 (07:44 +0000)]
2008-04-17  Mark Rowe  <mrowe@apple.com>

        Fix the non-Mac builds that I broke with my Mac build fix.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Explicitly use the size_t version of max
        to avoid making assumptions about sizeof(size_t).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-17 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Thu, 17 Apr 2008 07:22:51 +0000 (07:22 +0000)]
2008-04-17  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Dan Bernstein.

        Fix the Mac build.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Update to use size_t in place of unsigned.
        * dom/NamedNodeMap.h: Ditto.
        * page/AccessibilityObject.h: Forward-declare AccessibilityObjectWrapper in the non-Objective-C case too.

2008-04-17  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Dan Bernstein.

        Fix the Mac build.

        * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
        for now.  This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
        for this to live going forward.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-15 Srinivas Rao. M Hamse <msrinirao@gmail.com>
mitz@apple.com [Thu, 17 Apr 2008 05:56:36 +0000 (05:56 +0000)]
2008-04-15  Srinivas Rao. M Hamse  <msrinirao@gmail.com>

        Reviewed by Maciej Stachowiak.

        - gcc 3.x build fix

        * kjs/nodes.h: CallerType definition made public for gcc 3.x compilation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd AccessibilityObject wrapper class to WebKit.
jhoneycutt@apple.com [Thu, 17 Apr 2008 04:57:07 +0000 (04:57 +0000)]
Add AccessibilityObject wrapper class to WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix size_t -> unsigned conversion warnings.
jhoneycutt@apple.com [Thu, 17 Apr 2008 04:56:39 +0000 (04:56 +0000)]
Fix size_t -> unsigned conversion warnings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd some methods to determine the AccessibilityObject state.
jhoneycutt@apple.com [Thu, 17 Apr 2008 04:56:06 +0000 (04:56 +0000)]
Add some methods to determine the AccessibilityObject state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd AccessibilityObjectWrapper on Windows.
jhoneycutt@apple.com [Thu, 17 Apr 2008 04:55:30 +0000 (04:55 +0000)]
Add AccessibilityObjectWrapper on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd AXObjectCache to Windows.
jhoneycutt@apple.com [Thu, 17 Apr 2008 04:54:49 +0000 (04:54 +0000)]
Add AXObjectCache to Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix path to AXObjectCache.h on Windows.
jhoneycutt@apple.com [Thu, 17 Apr 2008 04:54:06 +0000 (04:54 +0000)]
Fix path to AXObjectCache.h on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 17 Apr 2008 04:41:40 +0000 (04:41 +0000)]
2008-04-16  Brady Eidson  <beidson@apple.com>

Fix ChangeLog typo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 17 Apr 2008 04:40:39 +0000 (04:40 +0000)]
2008-04-16  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Merge the StorageAreaClient into the StorageArea class itself as pure virtual methods.
        Add "LocalStorageArea" add "SessionStorageArea" implementations, and have SessionStorage
        and LocalStorage instantiate the appropriate type of StorageArea object.

        This purpose of this change is because while adding the persistent store to LocalStorage,
        it became obvious that the client approach wasn't scaling well.  Additionally, a StorageArea
        backing a local storage area required vastly different data members compared to one backing
        a session storage area.

        This will be much cleaner going forward.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):
        * storage/LocalStorage.h:

        * storage/LocalStorageArea.cpp: Added.
        (WebCore::LocalStorageArea::LocalStorageArea):
        (WebCore::LocalStorageArea::itemChanged):
        (WebCore::LocalStorageArea::itemRemoved):
        (WebCore::LocalStorageArea::dispatchStorageEvent):
        * storage/LocalStorageArea.h: Added.
        (WebCore::LocalStorageArea::create):

        * storage/SessionStorage.cpp:
        (WebCore::SessionStorage::copy):
        (WebCore::SessionStorage::storageArea):
        * storage/SessionStorage.h:

        * storage/SessionStorageArea.cpp: Added.
        (WebCore::SessionStorageArea::copy):
        (WebCore::SessionStorageArea::SessionStorageArea):
        (WebCore::SessionStorageArea::itemChanged):
        (WebCore::SessionStorageArea::itemRemoved):
        (WebCore::SessionStorageArea::dispatchStorageEvent):
        * storage/SessionStorageArea.h: Added.
        (WebCore::SessionStorageArea::create):
        (WebCore::SessionStorageArea::page):

        * storage/StorageArea.cpp:
        (WebCore::StorageArea::StorageArea):
        (WebCore::StorageArea::setItem):
        (WebCore::StorageArea::removeItem):
        (WebCore::StorageArea::storageMap):
        * storage/StorageArea.h:

        * storage/StorageAreaClient.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate window properties test for the new DOM document method.
hyatt@apple.com [Thu, 17 Apr 2008 04:15:27 +0000 (04:15 +0000)]
Update window properties test for the new DOM document method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 17 Apr 2008 04:13:36 +0000 (04:13 +0000)]
2008-04-16  David Hyatt  <hyatt@apple.com>

        Add support for the ability to draw directly into CSS images using CanvasRenderingContext2D.

        Reviewed by olliej

        Added fast/canvas/canvas-bg.html

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * css/CSSCanvasValue.cpp: Added.
        (WebCore::CSSCanvasValue::~CSSCanvasValue):
        (WebCore::CSSCanvasValue::cssText):
        (WebCore::CSSCanvasValue::canvasChanged):
        (WebCore::CSSCanvasValue::canvasResized):
        (WebCore::CSSCanvasValue::fixedSize):
        (WebCore::CSSCanvasValue::element):
        (WebCore::CSSCanvasValue::image):
        * css/CSSCanvasValue.h: Added.
        (WebCore::CSSCanvasValue::CSSCanvasValue):
        (WebCore::CSSCanvasValue::isFixedSize):
        (WebCore::CSSCanvasValue::setName):
        * css/CSSGradientValue.cpp:
        * css/CSSGradientValue.h:
        * css/CSSImageGeneratorValue.cpp:
        (WebCore::CSSImageGeneratorValue::generatedImage):
        * css/CSSImageGeneratorValue.h:
        (WebCore::CSSImageGeneratorValue::isFixedSize):
        (WebCore::CSSImageGeneratorValue::fixedSize):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseBackgroundImage):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::parseCanvas):
        * css/CSSParser.h:
        * dom/Document.cpp:
        (WebCore::Document::getCSSCanvasContext):
        (WebCore::Document::getCSSCanvasElement):
        * dom/Document.h:
        * dom/Document.idl:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::HTMLCanvasElement):
        (WebCore::HTMLCanvasElement::reset):
        * html/HTMLCanvasElement.h:
        (WebCore::HTMLCanvasElement::setSize):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calculateBackgroundSize):
        (WebCore::RenderBox::imageChanged):
        * rendering/RenderBox.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageChanged):
        * rendering/RenderImage.h:
        (WebCore::RenderImage::imagePtr):
        (WebCore::RenderImage::intrinsicSizeChanged):
        * rendering/RenderImageGeneratedContent.h:
        (WebCore::RenderImageGeneratedContent::imageSize):
        (WebCore::RenderImageGeneratedContent::imagePtr):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::layout):
        (WebCore::RenderListMarker::imageChanged):
        (WebCore::RenderListMarker::calcPrefWidths):
        (WebCore::RenderListMarker::getRelativeMarkerRect):
        * rendering/RenderListMarker.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintBorderImage):
        (WebCore::RenderObject::imageChanged):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::imageChanged):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::imageChanged):
        * rendering/RenderSVGImage.h:
        * rendering/RenderStyle.cpp:
        (WebCore::StyleCachedImage::imageSize):
        (WebCore::StyleGeneratedImage::imageSize):
        * rendering/RenderStyle.h:
        (WebCore::StyleCachedImage::data):
        (WebCore::StyleGeneratedImage::StyleGeneratedImage):
        (WebCore::StyleGeneratedImage::data):
        (WebCore::StyleGeneratedImage::imageHasRelativeWidth):
        (WebCore::StyleGeneratedImage::imageHasRelativeHeight):
        (WebCore::StyleGeneratedImage::usesImageContainerSize):
        * rendering/RenderTableCol.cpp:
        (WebCore::RenderTableCol::imageChanged):
        * rendering/RenderTableCol.h:
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::imageChanged):
        * rendering/RenderTableRow.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::imageChanged):
        * rendering/RenderTableSection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 01:27:41 +0000 (01:27 +0000)]
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add manifest parser.

        * loader/appcache/ManifestParser.cpp:
        (WebCore::):
        (WebCore::parseManifest):
        * loader/appcache/ManifestParser.h:
        * platform/text/CharacterNames.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Thu, 17 Apr 2008 01:23:12 +0000 (01:23 +0000)]
WebCore:

2008-04-16  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - fix <rdar://problem/5858617> REGRESSION (r21452-Safari 3.1):
          Safari does not find words containing ß (German letter sharp-s)

        Test: fast/text/find-case-folding.html

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::foldCase):
        Pass the folded length to foldCase rather than the original string length.
        Without this, we get an error code every time.

LayoutTests:

2008-04-16  Darin Adler  <darin@apple.com>

        Earlier version reviewed by Mitz.

        - test for <rdar://problem/5858617> REGRESSION (r21452-Safari 3.1):
          Safari does not find words containing ß (German letter sharp-s)

        * fast/text/find-case-folding-expected.txt: Added.
        * fast/text/find-case-folding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 00:51:07 +0000 (00:51 +0000)]
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::ApplicationCache):
        (WebCore::ApplicationCache::setManifestResource):
        (WebCore::ApplicationCache::addResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 00:50:34 +0000 (00:50 +0000)]
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add new protocolHostAndPortAreEqual function.

        * platform/KURL.cpp:
        (WebCore::KURL::host):
        (WebCore::KURL::setHost):
        (WebCore::KURL::setHostAndPort):
        (WebCore::protocolHostAndPortAreEqual):
        * platform/KURL.h:
        (WebCore::KURL::hostStart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 00:22:03 +0000 (00:22 +0000)]
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Fix some style nits.

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::ApplicationCache):
        (WebCore::ApplicationCache::setManifestResource):
        (WebCore::ApplicationCache::addResource):
        (WebCore::ApplicationCache::removeResource):
        (WebCore::ApplicationCache::dump):
        * loader/appcache/ApplicationCacheGroup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Apr 2008 00:17:16 +0000 (00:17 +0000)]
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady and Sam.

        Add ApplicationCache implementation. Stub out ApplicationCacheGroup methods
        needed by ApplicationCache.

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::ApplicationCache):
        (WebCore::ApplicationCache::~ApplicationCache):
        (WebCore::ApplicationCache::setManifestResource):
        (WebCore::ApplicationCache::addResource):
        (WebCore::ApplicationCache::removeResource):
        (WebCore::ApplicationCache::resourceForURL):
        (WebCore::ApplicationCache::resourceForRequest):
        (WebCore::ApplicationCache::numDynamicEntries):
        (WebCore::ApplicationCache::dynamicEntry):
        (WebCore::ApplicationCache::addDynamicEntry):
        (WebCore::ApplicationCache::removeDynamicEntry):
        (WebCore::ApplicationCache::setOnlineWhitelist):
        (WebCore::ApplicationCache::isURLInOnlineWhitelist):
        (WebCore::ApplicationCache::dump):
        * loader/appcache/ApplicationCache.h:
        (WebCore::ApplicationCache::create):
        (WebCore::ApplicationCache::manifestResource):
        (WebCore::ApplicationCache::group):
        (WebCore::ApplicationCache::begin):
        (WebCore::ApplicationCache::end):
        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::manifestURL):
        (WebCore::ApplicationCacheGroup::cacheDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 18505: REGRESSION: Search is disabled and not functional
aroben@apple.com [Wed, 16 Apr 2008 23:34:02 +0000 (23:34 +0000)]
    Fix Bug 18505: REGRESSION: Search is disabled and not functional

        <https://bugs.webkit.org/show_bug.cgi?id=18505>

        Reviewed by Tim Hatcher.

        * page/inspector/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.sourceFrameForResource): Added.
        * page/inspector/inspector.css: Added back rules for the search field
        that were removed in r31736.
        * page/inspector/inspector.html:
          - Removed the disabled attribute from the search field
          - Added back the #searchResults and #searchResultsResizer divs which
            were removed in r31736
        * page/inspector/inspector.js:
        (WebInspector.set showingSearchResults): Updated for class rename
        panels -> main-panels.
        (WebInspector.loaded): Added back the mousedown event listener for the
        search results resizer that was removed in r31736.
        (WebInspector.searchResultsResizerDrag): Updated for class rename
        panels -> main-panels.
        (WebInspector.performSearch):
          - Changed to use sourceFrameForResource
          - Changed to use showResource
          - Changed to save/restore the focused element around the setting of
            the current panel
          - Changed to get the source document from the match range instead of
            by crawling back up to the source view
          - Changed to bind the onselect handlers to this so that we can
            access the Elements/Resources panels

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
beidson@apple.com [Wed, 16 Apr 2008 23:25:13 +0000 (23:25 +0000)]
JavaScriptCore:

2008-04-16  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Change ThreadSafeShared to act like RefCounted by starting out with a single ref by default

        * wtf/Threading.h:
        (WTF::ThreadSafeShared::ThreadSafeShared):

WebCore:

2008-04-16  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Changing ThreadSafeShared to start with a ref count of 1, so updating all users to
        adoptRef() that initial reference.

        * bindings/js/JSCustomSQLStatementCallback.h:
        (WebCore::JSCustomSQLStatementCallback::create):
        * bindings/js/JSCustomSQLStatementErrorCallback.h:
        (WebCore::JSCustomSQLStatementErrorCallback::create):
        * bindings/js/JSCustomSQLTransactionCallback.h:
        (WebCore::JSCustomSQLTransactionCallback::create):
        * bindings/js/JSCustomSQLTransactionErrorCallback.h:
        (WebCore::JSCustomSQLTransactionErrorCallback::create):

        * bindings/js/JSDatabaseCustom.cpp:
        (WebCore::JSDatabase::changeVersion):
        (WebCore::JSDatabase::transaction):

        * bindings/js/JSSQLTransactionCustom.cpp:
        (WebCore::JSSQLTransaction::executeSql):

        * dom/Document.cpp:
        (WebCore::Document::databaseThread):

        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::create):

        * platform/sql/SQLiteAuthorizer.h:
        (WebCore::SQLiteAuthorizer::create):
        (WebCore::SQLiteAuthorizer::SQLiteAuthorizer):

        * storage/ChangeVersionWrapper.cpp:
        (WebCore::ChangeVersionWrapper::performPreflight):
        (WebCore::ChangeVersionWrapper::performPostflight):
        * storage/ChangeVersionWrapper.h:
        (WebCore::ChangeVersionWrapper::create):

        * storage/Database.cpp:
        (WebCore::Database::openAndVerifyVersion):
        (WebCore::Database::markAsDeletedAndClose):
        (WebCore::Database::changeVersion):
        (WebCore::Database::transaction):
        (WebCore::Database::scheduleTransaction):
        (WebCore::Database::scheduleTransactionStep):
        (WebCore::Database::tableNames):

        * storage/DatabaseAuthorizer.h:
        (WebCore::DatabaseAuthorizer::create):

        * storage/DatabaseTask.h:
        (WebCore::DatabaseOpenTask::create):
        (WebCore::DatabaseCloseTask::create):
        (WebCore::DatabaseTransactionTask::create):
        (WebCore::DatabaseTableNamesTask::create):

        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::scheduleTask): Change to take a PassRefPtr instead of raw
        (WebCore::DatabaseThread::scheduleImmediateTask): Ditto
        * storage/DatabaseThread.h:
        (WebCore::DatabaseThread::create):

        * storage/SQLError.h:
        (WebCore::SQLError::create):
        (WebCore::SQLError::SQLError):

        * storage/SQLResultSet.h:
        (WebCore::SQLResultSet::create):

        * storage/SQLStatement.cpp:
        (WebCore::SQLStatement::create):
        (WebCore::SQLStatement::execute):
        (WebCore::SQLStatement::setDatabaseDeletedError):
        (WebCore::SQLStatement::setVersionMismatchedError):
        (WebCore::SQLStatement::setFailureDueToQuota):
        * storage/SQLStatement.h:

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::create):
        (WebCore::SQLTransaction::executeSQL):
        (WebCore::SQLTransaction::openTransactionAndPreflight):
        (WebCore::SQLTransaction::deliverTransactionCallback):
        (WebCore::SQLTransaction::handleCurrentStatementError):
        (WebCore::SQLTransaction::deliverStatementCallback):
        (WebCore::SQLTransaction::postflightAndCommit):
        * storage/SQLTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 16 Apr 2008 23:23:39 +0000 (23:23 +0000)]
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam and Brady.

        Add implementation of ApplicationCacheResource.

        * loader/appcache/ApplicationCacheResource.cpp:
        (WebCore::ApplicationCacheResource::ApplicationCacheResource):
        (WebCore::ApplicationCacheResource::dumpType):
        * loader/appcache/ApplicationCacheResource.h:
        (WebCore::ApplicationCacheResource::):
        (WebCore::ApplicationCacheResource::create):
        (WebCore::ApplicationCacheResource::type):
        (WebCore::ApplicationCacheResource::addType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes an issue where the source for a resource that had errors would
timothy@apple.com [Wed, 16 Apr 2008 21:47:07 +0000 (21:47 +0000)]
Fixes an issue where the source for a resource that had errors would
not be shown because the view was created before the resource load
finished. The right view is now created, even if the resource isn't
finished. The SourceView just makes sure to not load the source until
the resource is finished. Only if the category changes, does the view
need to be recreated.

Reviewed by Adam Roben.

* page/inspector/Resource.js:
(WebInspector.Resource.prototype.set category): Call recreateViewForResourceIfNeeded.
* page/inspector/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
Added. Tries to make a new view, if the view is the same prototype of the
previous view, return early. If they differ, close and detach the old view
and associate the resource with the new view. Calling updateErrorsAndWarnings
is needed, because the errors and warnings that might have been added to the
previous view will be lost, so make the tree element match.
(WebInspector.Resource.prototype._createResourceView): Always create a view
that matches the resource category. Ignore the loading and failed status.
* page/inspector/SourceView.js:
(WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): Don't setup the
frame if the resource hasn't finished or if the load failed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdds a console formatter for Error objects. So typing a expression in the
timothy@apple.com [Wed, 16 Apr 2008 21:46:48 +0000 (21:46 +0000)]
Adds a console formatter for Error objects. So typing a expression in the
console that ends in an exception will print meaningful info. Also calling
console.{log,error,warn,info} with an error object will output nicely.

Reviewed by Adam Roben.

* page/inspector/Console.js:
(WebInspector.Console.prototype._formaterror): Added. Formats an error
object by showing it like other exceptions, with a clickable file URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRefactors code that updates the errors and warnings count in the
timothy@apple.com [Wed, 16 Apr 2008 21:46:32 +0000 (21:46 +0000)]
Refactors code that updates the errors and warnings count in the
resources sidebar so other functions can easily trigger updates.

Reviewed by Adam Roben.

* page/inspector/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.addMessageToResource): Call updateErrorsAndWarnings.
Removes code that updates the bubbleText and class names.
(WebInspector.ResourcesPanel.prototype.clearMessages): Ditto.
(WebInspector.ResourceSidebarTreeElement.prototype.updateErrorsAndWarnings):
Added. Updates the bubbleText and adds or removes the class names
depending on if the values are zero.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
antti@apple.com [Wed, 16 Apr 2008 21:41:12 +0000 (21:41 +0000)]
WebCore:

2008-04-16  Antti Koivisto  <antti@apple.com>

        Reviewed by Alexey.

        Fix <rdar://problem/5863728>
        REGRESSION: Garbage character shown in temperatures in the Weather widget (encoding issue with degree symbol)

        Parse the encoding attribute in PreloadScanner.

        Test: fast/encoding/script-preload-encoding.html

        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::processAttribute):
        (WebCore::PreloadScanner::emitTag):
        (WebCore::PreloadScanner::emitCSSRule):
        * html/PreloadScanner.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::preload):
        * loader/DocLoader.h:

LayoutTests:

2008-04-16  Antti Koivisto  <antti@apple.com>

        Reviewed by Alexey.

        Test for <rdar://problem/5863728>
        REGRESSION: Garbage character shown in temperatures in the Weather widget (encoding issue with degree symbol)

        * fast/encoding/resources/utf-8.css: Added.
        * fast/encoding/resources/utf-8.js: Added.
        * fast/encoding/preload-encoding-expected.txt: Added.
        * fast/encoding/preload-encoding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 16 Apr 2008 21:03:19 +0000 (21:03 +0000)]
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Generate the DOMApplicationCache JS wrapper, add JSDOMApplicationCacheCustom.cpp and
        fix typos in the #if line.

        * DerivedSources.make:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMApplicationCacheCustom.cpp: Added.
        * loader/appcache/ApplicationCache.cpp:
        * loader/appcache/ApplicationCache.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        * loader/appcache/ApplicationCacheGroup.h:
        * loader/appcache/ApplicationCacheResource.cpp:
        * loader/appcache/ApplicationCacheResource.h:
        * loader/appcache/DOMApplicationCache.cpp:
        * loader/appcache/DOMApplicationCache.h:
        * loader/appcache/DOMApplicationCache.idl:
        * loader/appcache/ManifestParser.cpp:
        * loader/appcache/ManifestParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
weinig@apple.com [Wed, 16 Apr 2008 20:58:46 +0000 (20:58 +0000)]
JavaScriptCore:

2008-04-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        - To keep the behavior of the WebKit and JavaScriptCore API's the same,
          we need to hide the fact that the global object and the window object
          are no longer the same thing, and the the global object now changes on
          navigations.  To do this, only the wrapper should ever be exposed.  This
          fixes the two remaining spots where the internal global object is exposed,
          the windowScriptObject returned from [WebFrame windowObject] and the object
          return by calling JSContextGetGlobalObject on [WebFrame globalContext].

        * API/JSContextRef.cpp:
        (JSContextGetGlobalObject):
        This is a bit of a hack, this returns the "this" representation of the globalObject
        which will be the WrapperWindow for WebCore and the globalObject for non-WebCore.

        * API/JSObjectRef.cpp:
        (JSObjectSetProperty):
        Call the new putWithAttributes method instead of relying on lower-level calls.
        This is needed so that the window wrapper can forward the calls.

        * JavaScriptCore.exp:
        * kjs/Activation.h:
        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::putWithAttributes):
        * kjs/JSGlobalObject.h:
        * kjs/JSVariableObject.h:
        (KJS::JSVariableObject::symbolTablePutWithAttributes):
        * kjs/function.cpp:
        (KJS::ActivationImp::putWithAttributes):
        * kjs/nodes.cpp:
        (KJS::ConstDeclNode::handleSlowCase):
        (KJS::ConstDeclNode::evaluateSingle):
        (KJS::EvalNode::processDeclarations):
        * kjs/object.cpp:
        (KJS::JSObject::putWithAttributes):
        * kjs/object.h:
        Rename initializeVariable to putWithAttributes and move it down to JSObject so it
        can be used for JSObjectSetProperty.

WebCore:

2008-04-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        - To keep the behavior of the WebKit and JavaScriptCore API's the same,
          we need to hide the fact that the global object and the window object
          are no longer the same thing, and the the global object now changes on
          navigations.  To do this, only the wrapper should ever be exposed.  This
          fixes the two remaining spots where the internal global object is exposed,
          the windowScriptObject returned from [WebFrame windowObject] and the object
          return by calling JSContextGetGlobalObject on [WebFrame globalContext]

        * bindings/js/JSDOMWindowWrapper.cpp:
        (WebCore::JSDOMWindowWrapper::putWithAttributes):
        * bindings/js/JSDOMWindowWrapper.h:
        Forward this new method so that JSObjectSetProperty doesn't set properties on the
        wrapper.

        * page/mac/FrameMac.mm:
        (WebCore::Frame::windowScriptObject):
        Return the wrapper instead of the global object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 16 Apr 2008 20:53:02 +0000 (20:53 +0000)]
2008-04-16  David Hyatt  <hyatt@apple.com>

        Eliminate the paintBuffer and drawImage(ImageBuffer*) methods from GraphicsContext* in favor of just
        snagging an Image* from the ImageBuffer and drawing that instead.

        Enhance canvas with a CanvasObserver so that notifications of dirtying or resizing can be tracked by
        a consumer.

        Reviewed by olliej

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::HTMLCanvasElement):
        (WebCore::HTMLCanvasElement::willDraw):
        (WebCore::HTMLCanvasElement::reset):
        (WebCore::HTMLCanvasElement::paint):
        * html/HTMLCanvasElement.h:
        (WebCore::CanvasObserver::~CanvasObserver):
        (WebCore::HTMLCanvasElement::setSize):
        (WebCore::HTMLCanvasElement::setObserver):
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawImage):
        (WebCore::GraphicsContext::drawTiledImage):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/ImageBuffer.h:
        (WebCore::ImageBuffer::clearImage):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):
        (WebCore::Image::drawPattern):
        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::createFrameAtIndex):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * platform/graphics/wx/GraphicsContextWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 16 Apr 2008 20:32:31 +0000 (20:32 +0000)]
2008-04-16  Steve Falkenburg  <sfalken@apple.com>

        Improve timer latency/resolution.

        The primary timing mechanism is now CreateTimerQueueTimer, with a PostMessage from
        the callback proc.  This event will be delivered sooner than if we used SetTimer(),
        since it is higher priority than other messages.

        If there is an input message pending, we'll use we SetTimer() based timers to avoid
        starving user input.

        Don't call PostMessage immediately on all timers < 10ms.  Only call immediately if
        timer is already expired.  This avoids the case where no timers would be processed,
        causing the timer to be re-posted via the slower SetTimer method.

        Don't call PostMessage immediately if there's a pending WM_PAINT, since
        we don't want to starve all paints when bombarded with a continuous stream of low
        duration timers.

        Removed reentrancy check, since we're now looking for specific starvation cases,
        and will typically defer non-expired timers through reateTimerQueueTimer.

        The reason Windows wouldn't starve paints in favor of timers with the old code:
        When we went to reset the timer when it fired, the timer reset code treated this as a
        reentrant timer, causing us to hit the slow SetTimer code rather than calling PostMessage,
        even for timers expiring in < 10ms. I corrected that, exposing the paint starvation problem.

        Use timeBeginPeriod/timeEndPeriod to improve resolution of system timers.
        Limit this resolution change to within 20ms of the last high resolution timer request.

        Corrected GetQueueStatus to check for specific input (and paint) messages rather than
        checking QS_ALLINPUT.  Contrary to its name, QS_ALLINPUT actually indicates interest
        in ALL queued messages, not just input messages.

        Fix SetTimer/KillTimer calls to pass our window handle.

        Reviewed by Brady.

        * platform/win/SharedTimerWin.cpp:
        (WebCore::):
        (WebCore::TimerWindowWndProc):
        (WebCore::queueTimerProc):
        (WebCore::setSharedTimerFireTime):
        (WebCore::stopSharedTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix console-log-formatting to truly test formatting an undefined value
aroben@apple.com [Wed, 16 Apr 2008 20:22:53 +0000 (20:22 +0000)]
    Fix console-log-formatting to truly test formatting an undefined value

        Exceptions thrown by the test will also now be shown as errors.

        Reviewed by Tim Hatcher.

        * manual-tests/inspector/console-log-formatting.html:
        (test): Use console.error to report exceptions.
        (runTests): Use window.noSuchVariable instead of just noSuchVariable
        to avoid an exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Anatoli Papirovski <apapirovski@mac.com>
jchaffraix@webkit.org [Wed, 16 Apr 2008 19:47:55 +0000 (19:47 +0000)]
2008-04-16  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by David.

        Optimized the calculation of background-size.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calculateBackgroundSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 17228: console.{log,warn,info,error} should support format strings...
aroben@apple.com [Wed, 16 Apr 2008 19:34:53 +0000 (19:34 +0000)]
    Fix Bug 17228: console.{log,warn,info,error} should support format strings, variable arguments

        <https://bugs.webkit.org/show_bug.cgi?id=17228>
        <rdar://problem/5732828>

        Reviewed by Tim Hatcher.

        Test: manual-tests/inspector/console-log-formatting.html

        * page/inspector/Console.js:
        (WebInspector.ConsoleMessage): Pass any extra arguments down to
        _format.
        (WebInspector.ConsoleMessage._format): This method constructs
        this.formattedMessage. We treat the first parameter as a format
        string. Any parameters that have not been used after substituting into
        the format string are concatenated together, separated by spaces.
        (WebInspector.ConsoleMessage.toMessageElement): Updated to use
        this.formattedMessage.
        (WebInspector.ConsoleMessage.toString): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make String.format return an array of unused substitutions
aroben@apple.com [Wed, 16 Apr 2008 19:34:29 +0000 (19:34 +0000)]
    Make String.format return an array of unused substitutions

        String.format now returns an object with two properties:
        formattedResult and unusedSubstitutions.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (String.vsprintf): Updated for changes to String.format. We throw away
        the array of unused substitutions.
        (String.format): Changed to keep track of which substitutions are used
        when formatting. We then return both the formatted result and the
        array of unused substitutions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Generalize String.format some more
aroben@apple.com [Wed, 16 Apr 2008 19:34:07 +0000 (19:34 +0000)]
    Generalize String.format some more

        String.format now takes an initial value and an append function which
        it uses to build the result. Each time a token is processed,
        append(valueSoFar, newValue) is called.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (String.vsprintf): Pass the empty string for the initial value, and
        a function that concatenates two strings as the append function.
        (String.format): Use initialValue and append to build the result
        instead of only working with strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add String.format
aroben@apple.com [Wed, 16 Apr 2008 19:20:21 +0000 (19:20 +0000)]
    Add String.format

        String.format is a more generic form of String.vsprintf that takes a
        set of formatter functions, one for each supported format specifier.
        Each formatter function is passed the relevant token and substitution
        value, and returns the formatted result.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (String.standardFormatters): Added.
        (String.vsprintf): Changed to call through to String.format.
        (String.format): Added. Most of the code came from String.vsprintf,
        except that we use the passed-in formatters to format the
        substitutions rather than hard-coding how to handle each format
        specifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Refactor String.vsprintf to separate tokenizing and substituting
aroben@apple.com [Wed, 16 Apr 2008 19:19:57 +0000 (19:19 +0000)]
    Refactor String.vsprintf to separate tokenizing and substituting

        This will eventually be useful for the various console methods that
        take a format string.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (String.tokenizeFormatString): Added. This uses the format parsing
        code from String.vsprintf but just returns an array of "string" and
        "specifier" tokens.
        (String.vsprintf): Now calls String.tokenizeFormatString and processes
        the tokens one at a time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Pass all arguments to console.{log,warn,info,error} into the Inspector's JS
aroben@apple.com [Wed, 16 Apr 2008 19:19:29 +0000 (19:19 +0000)]
    Pass all arguments to console.{log,warn,info,error} into the Inspector's JS

        Part of Bug 17228: console.{log,warn,info,error} should support format
        strings, variable arguments
        <http://bugs.webkit.org/show_bug.cgi?id=17228>
        <rdar://problem/5732828>

        We don't use the extra arguments yet.

        Reviewed by Tim Hatcher.

        * page/Console.cpp:
        (WebCore::Console::error): Pass the arguments list to
        InspectorController.
        (WebCore::Console::info): Ditto.
        (WebCore::Console::log): Ditto.
        (WebCore::Console::warn): Ditto.
        * page/InspectorController.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage): Added a new constructor
        that takes an ExecState and a List instead of a String. We wrap and
        store the JSValues from the List in a Vector<ProtectedPtr<JSValue> >.
        (WebCore::InspectorController::addMessageToConsole): Added an overload
        that takes an ExecState and a List.
        (WebCore::InspectorController::addConsoleMessage): Moved code here
        from addMessageToConsole. Both overloads of addMessageToConsole now
        call this helper method.
        (WebCore::InspectorController::addScriptConsoleMessage): Updated for
        the new parameter order of WebInspector.ConsoleMessage. If the
        ConsoleMessage has a non-empty wrappedArguments Vector, we use that
        instead of the ConsoleMessage's message String.
        * page/InspectorController.h:
        * page/inspector/Console.js:
        (WebInspector.ConsoleMessage): Removed the explicit message parameter.
        We now get the message from the unnamed 5th parameter.
        * page/inspector/Resource.js: Updated for the change to
        WebInspector.ConsoleMessage's parameter order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change calls to Chrome::addMessageToConsole to use Console::addMessage
aroben@apple.com [Wed, 16 Apr 2008 19:19:00 +0000 (19:19 +0000)]
    Change calls to Chrome::addMessageToConsole to use Console::addMessage

        Part of Bug 17228: console.{log,warn,info,error} should support format
        strings, variable arguments
        <http://bugs.webkit.org/show_bug.cgi?id=17228>
        <rdar://problem/5732828>

        Console now takes care of calling ChromeClient::addMessageToConsole
        for the appropriate messages (i.e., just messages from JavaScript). If
        you ever want to add a message to the console, Console is the place to
        do it.

        Reviewed by Darin Adler.

        * WebCore.xcodeproj/project.pbxproj: Mark Console.h Private.
        * page/Chrome.cpp: Removed addMessageToConsole
        * page/Chrome.h: Moved MessageSource/MessageLevel to Console.h.
        * page/Console.cpp:
        (WebCore::Console::addMessage): Added. Calls
        ChromeClient::addMessageToConsole for JS messages, and calls
        InspectorController::addMessageToConsole for all messages.
        (WebCore::Console::error): Changed to call directly to
        InspectorController in addition to ChromeClient.
        (WebCore::Console::info): Ditto.
        (WebCore::Console::log): Ditto.
        (WebCore::Console::warn): Ditto.
        * page/Console.h: Added MessageSource/MessageLevel enums from Chrome.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Pass JSConsole's arguments unmodified to Console
aroben@apple.com [Wed, 16 Apr 2008 19:18:11 +0000 (19:18 +0000)]
    Pass JSConsole's arguments unmodified to Console

        Part of Bug 17228: console.{log,warn,info,error} should support format
        strings, variable arguments
        <http://bugs.webkit.org/show_bug.cgi?id=17228>
        <rdar://problem/5732828>

        All of JSConsole's methods are now custom, so that we can pass the
        arguments unmodified to Console. Console now handles calling
        toString() on the first argument. Later it will pass the arguments off
        to InspectorController.

        There should be no behavioral changes caused by this patch.

        Reviewed by Darin Adler.

        * ForwardingHeaders/kjs/list.h: Added.
        * GNUmakefile.am: Added JSConsoleCustom.cpp to the project.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.
        * bindings/js/JSConsoleCustom.cpp: Added.
        (WebCore::JSConsole::error):
        (WebCore::JSConsole::info):
        (WebCore::JSConsole::log):
        (WebCore::JSConsole::warn):
        * page/Console.cpp: Changed all methods to take an ExecState* and a
        const List&. The first item in the List is toString()ed and passed to
        Chrome.
        (WebCore::Console::error):
        (WebCore::Console::info):
        (WebCore::Console::log):
        (WebCore::Console::warn):
        * page/Console.h:
        * page/Console.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 16 Apr 2008 19:08:03 +0000 (19:08 +0000)]
2008-04-16  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Sam and Geoff.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        Inital profiler prototype

        * GNUmakefile.am: Added new files to project
        * JavaScriptCore.pri: Ditto
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto
        * JavaScriptCore.xcodeproj/project.pbxproj: Ditto
        * JavaScriptCoreSources.bkl: Ditto
        * kjs/config.h: Put compiling flag in here.
        * kjs/function.cpp: Instrument calling the function eval().
        (KJS::eval):
        * kjs/interpreter.cpp: Instrument evaluating global scopes.
        (KJS::Interpreter::evaluate):
        * kjs/object.cpp: Instrument JS function calls.
        (KJS::JSObject::call):
        * profiler: Added.
        * profiler/FunctionCallProfile.cpp: Added.
        (KJS::FunctionCallProfile::FunctionCallProfile):
        (KJS::FunctionCallProfile::~FunctionCallProfile):
        (KJS::FunctionCallProfile::willExecute): Call right before the JS function or executing context is executed to start the profiler's timer.
        (KJS::FunctionCallProfile::didExecute): Call right after the JS function or executing context is executed to stop the profiler's timer.
        (KJS::FunctionCallProfile::addChild): Add a child to the current FunctionCallProfile if it isn't already a child of the current FunctionalCallProfile.
        (KJS::FunctionCallProfile::findChild): Return the child that matches the given name if there is one.
        (KJS::FunctionCallProfile::printDataSampleStyle): Print the current profiled information in a format that matches sample's output.
        * profiler/FunctionCallProfile.h: Added.
        (KJS::FunctionCallProfile::FunctionCallProfile):
        (KJS::FunctionCallProfile::~FunctionCallProfile):
        (KJS::FunctionCallProfile::functionName):
        (KJS::FunctionCallProfile::microSecs):
        * profiler/Profiler.cpp: Added.
        (KJS::Profiler::profiler):
        (KJS::Profiler::sharedProfiler): Return global singleton (may change due to multi-threading concerns)
        (KJS::Profiler::startProfiling): Don't start collecting profiling information until the user starts the profiler. Also don't clear old prfiled data until the profiler is restarted.
        (KJS::Profiler::stopProfiling): Stop collecting profile information.
        (KJS::Profiler::willExecute): Same as above.
        (KJS::Profiler::didExecute): Same as above.
        (KJS::Profiler::insertStackNamesInTree): Follow the stack of the given names and if a sub-stack is not in the current tree, add it.
        (KJS::Profiler::getStackNames): Get the names from the different passed in parameters and order them as a stack.
        (KJS::Profiler::getFunctionName): Get the function name from the given parameter.
        (KJS::Profiler::printDataSampleStyle): Print the current profiled information in a format that matches sample's output.
        (KJS::Profiler::debugLog):
        * profiler/Profiler.h: Added.
        (KJS::Profiler::Profiler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
weinig@apple.com [Wed, 16 Apr 2008 18:41:54 +0000 (18:41 +0000)]
JavaScriptCore:

2008-04-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        - Remove kjs_ prefix from strtod, dtoa, and freedtoa and put it
          in the KJS namespace.
        - Make strtod, dtoa, and freedtoa c++ functions instead of extern "C".
        - Remove mode switching from dtoa.  ~2% improvement on test 26.
        - Removes all unnecessary #defines from dtoa code.

        * JavaScriptCore.exp:
        * kjs/dtoa.cpp:
        (KJS::ulp):
        (KJS::b2d):
        (KJS::d2b):
        (KJS::ratio):
        (KJS::):
        (KJS::strtod):
        (KJS::freedtoa):
        (KJS::dtoa):
        * kjs/dtoa.h:
        * kjs/function.cpp:
        (KJS::parseInt):
        * kjs/lexer.cpp:
        (KJS::Lexer::lex):
        * kjs/number_object.cpp:
        (KJS::integer_part_noexp):
        (KJS::numberProtoFuncToExponential):
        * kjs/ustring.cpp:
        (KJS::UString::from):
        (KJS::UString::toDouble):

WebCore:

2008-04-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Rename kjs_strtod to KJS::strtod.

        * platform/text/String.cpp:
        (WebCore::charactersToDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
ap@webkit.org [Wed, 16 Apr 2008 17:30:13 +0000 (17:30 +0000)]
    Reviewed by Adam.

        http://bugs.webkit.org/show_bug.cgi?id=18259
        XML+XSLT pages in iframe contains document.location of a parent window

        Test: fast/xsl/subframe-location.html

        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource): Set resulting document URL before opening
        it, so that the document loader picks a correct URL, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Wed, 16 Apr 2008 17:23:24 +0000 (17:23 +0000)]
    Reviewed by Darin.

        Get rid of static execForCompareByStringForQSort in array_instance.cpp.

        No change on SunSpider, CelticKane or iBench JavaScript.

        * kjs/array_instance.cpp:
        (KJS::ArraySortComparator::ArraySortComparator):
        (KJS::ArraySortComparator::operator()):
        (KJS::ArrayInstance::sort):
        Switch slow case to std::sort, so that ExecState can be passed in a comparator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by John Sullivan.
mitz@apple.com [Wed, 16 Apr 2008 15:30:56 +0000 (15:30 +0000)]
    Rubber-stamped by John Sullivan.

        - remove unreachable code which was added in r8802

        * rendering/RenderText.cpp:
        (WebCore::RenderText::caretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
ap@webkit.org [Wed, 16 Apr 2008 15:26:37 +0000 (15:26 +0000)]
    Reviewed by Adam Roben.

        MSVC build fix.

        * kjs/CommonIdentifiers.cpp:
        * kjs/CommonIdentifiers.h:
        * kjs/Parser.cpp:
        * kjs/Parser.h:
        * kjs/identifier.cpp:
        * kjs/lexer.h:
        * wtf/ThreadSpecific.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
ap@webkit.org [Wed, 16 Apr 2008 14:31:40 +0000 (14:31 +0000)]
    Build fix.

        * kjs/date_object.cpp:
        * kjs/date_object.h:
        Don't include DateMath.h from date_object.h, as the latter is used from WebCore, while
        where the former is not available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdds a script resource icon. Update the CSS icon to better match the script icon.
timothy@apple.com [Wed, 16 Apr 2008 13:49:37 +0000 (13:49 +0000)]
Adds a script resource icon. Update the CSS icon to better match the script icon.

https://bugs.webkit.org/show_bug.cgi?id=18499

Rubber-stamped by Adele Peterson.

* page/inspector/Images/resourceCSSIcon.png: Updated.
* page/inspector/Images/resourceJSIcon.png: Added.
* page/inspector/inspector.css: Changed the script icon rule to reference the new image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 16 Apr 2008 12:51:07 +0000 (12:51 +0000)]
2008-04-16  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed build fix for MSVC. It does not want to have
        WTF in the KJS namespace.

        * kjs/CommonIdentifiers.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 16 Apr 2008 12:26:29 +0000 (12:26 +0000)]
2008-04-16  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed build fix for gcc.

        ::msToGregorianDateTime  is not known to it.

        * kjs/date_object.cpp:
        (KJS::DateInstance::msToGregorianDateTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
ap@webkit.org [Wed, 16 Apr 2008 09:58:04 +0000 (09:58 +0000)]
    Reviewed by Oliver Hunt.

        Initialize threadMapMutex safely (as already done in ThreadingWin).

        * wtf/ThreadingGtk.cpp:
        (WTF::threadMapMutex):
        (WTF::initializeThreading):
        * wtf/ThreadingPthreads.cpp:
        (WTF::threadMapMutex):
        (WTF::initializeThreading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31939 268f45cc-cd09-0410-ab3c-d52691b4dbfc