WebKit-https.git
9 years agoWeb Inspector: Extension sever should use Workspace.projectForType() instead of Works...
vsevik@chromium.org [Fri, 8 Feb 2013 16:09:59 +0000 (16:09 +0000)]
Web Inspector: Extension sever should use Workspace.projectForType() instead of Workspace.project()
https://bugs.webkit.org/show_bug.cgi?id=109301

Reviewed by Alexander Pavlov.

* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onGetPageResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 16:09:01 +0000 (16:09 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 3. Remaining expected failures that had platform-specific supppressions

* platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Removed.
* platform/chromium-linux-x86/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
* platform/chromium-linux/fast/css/background-clip-radius-values-expected.png:
* platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
* platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.png:
* platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png:
* platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
* platform/chromium-mac-lion/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Added.
* platform/chromium-mac-lion/fast/css/nested-rounded-corners-expected.png:
* platform/chromium-mac-lion/fast/dom/52776-expected.png:
* platform/chromium-mac-lion/fast/frames/iframe-scaling-with-scroll-expected.png:
* platform/chromium-mac-lion/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/css/nested-rounded-corners-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/52776-expected.png:
* platform/chromium-mac-snowleopard/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Added.
* platform/chromium-mac/fast/css/background-clip-radius-values-expected.png:
* platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
* platform/chromium-mac/fast/dom/52776-expected.png:
* platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png:
* platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
* platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Removed.
* platform/chromium-win-xp/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
* platform/chromium-win/fast/css/background-clip-radius-values-expected.png:
* platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png:
* platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/editing/pasteboard/emacs-cntl-y-001-expected.png: Removed.
* platform/chromium/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: simplify Memory.getDOMNodeCount implementation
yurys@chromium.org [Fri, 8 Feb 2013 16:04:28 +0000 (16:04 +0000)]
Web Inspector: simplify Memory.getDOMNodeCount implementation
https://bugs.webkit.org/show_bug.cgi?id=108821

Reviewed by Alexander Pavlov.

Removed Memory.getDOMNodeCount command from the protocol. Memory.getDOMCounters
should be used instead.

* inspector/Inspector.json:
* inspector/InspectorMemoryAgent.cpp:
* inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Reviewin Qt TestExpectations. Rebaseline and unskip passing tests.
kadam@inf.u-szeged.hu [Fri, 8 Feb 2013 15:59:12 +0000 (15:59 +0000)]
[Qt] Reviewin Qt TestExpectations. Rebaseline and unskip passing tests.

* platform/qt/TestExpectations:
* platform/qt/svg/css/arrow-with-shadow-expected.png:
* platform/qt/svg/css/arrow-with-shadow-expected.txt:
* platform/qt/svg/css/clippath-with-shadow-expected.png:
* platform/qt/svg/css/clippath-with-shadow-expected.txt:
* platform/qt/svg/css/composite-shadow-text-expected.png:
* platform/qt/svg/custom/simple-text-double-shadow-expected.png:
* platform/qt/svg/custom/simple-text-double-shadow-expected.txt:
* platform/qt/svg/repaint/repaint-webkit-svg-shadow-expected.png: Copied from LayoutTests/platform/qt/svg/css/clippath-with-shadow-expected.png.
* platform/qt/svg/repaint/repaint-webkit-svg-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 15:46:59 +0000 (15:46 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 2. Failing Linux tests with no expectations

* platform/chromium-linux/fast/forms/button-generated-content-expected.png:
* platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.png:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium-linux/fast/text/justify-ideograph-vertical-expected.png:
* platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png:
* platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png:
* platform/chromium-linux/fast/writing-mode/japanese-lr-text-expected.png:
* platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png:
* platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
* platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
* platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
* platform/chromium-linux/svg/custom/shapes-supporting-markers-expected.png:
* platform/chromium-linux/svg/text/selection-styles-expected.png:
* platform/efl-wk2/fast/repaint: Added.
* platform/efl-wk2/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
* platform/efl/fast/repaint/japanese-rl-selection-clear-expected.png: Removed.
* platform/efl/svg/batik/text/textDecoration-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: refactor MemoryStatistics.js
yurys@chromium.org [Fri, 8 Feb 2013 15:44:24 +0000 (15:44 +0000)]
Web Inspector: refactor MemoryStatistics.js
https://bugs.webkit.org/show_bug.cgi?id=109299

Reviewed by Vsevolod Vlasov.

Extracted functionality specific to DOM counter graphs drawing into
separate methods on MemoryStatistics class.
Introduced CounterUIBase base class for DOMCounterUI that contains
functionality which can be shared with native memory graph.

* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics):
(WebInspector.CounterUIBase):
(WebInspector.CounterUIBase.prototype.updateCurrentValue):
(WebInspector.CounterUIBase.prototype.clearCurrentValueAndMarker):
(WebInspector.CounterUIBase.prototype.get visible):
(WebInspector.DOMCounterUI):
(WebInspector.DOMCounterUI.prototype.discardImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._clearCurrentValueAndMarker):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype._updateCurrentValue):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._restoreImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._saveImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._drawMarker):
(WebInspector.MemoryStatistics.prototype._clear):
(WebInspector.MemoryStatistics.prototype._discardImageUnderMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 15:36:48 +0000 (15:36 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 1. Some tests that have existing expectations.

* editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
* fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
* platform/chromium-linux-x86/editing/input: Removed.
* platform/chromium-linux/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* platform/chromium-linux/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-linux/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-linux/fast/repaint/transform-absolute-in-positioned-container-expected.png:
* platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
* platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
* platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
* platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-win-xp/editing/input: Removed.
* platform/chromium-win/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* platform/chromium-win/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
* platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
* platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.txt:
* platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
* platform/efl-wk1/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
* platform/efl-wk2/editing/input: Added.
* platform/efl-wk2/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
* platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
* platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
kadam@inf.u-szeged.hu [Fri, 8 Feb 2013 15:07:58 +0000 (15:07 +0000)]
[Qt] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=109209.

* platform/qt/TestExpectations:
* platform/qt/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added after r142152.
* platform/qt/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Added after r142152.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Wk2] Unreviewed gardening. Skip failing tests.
kadam@inf.u-szeged.hu [Fri, 8 Feb 2013 14:50:40 +0000 (14:50 +0000)]
[Qt][Wk2] Unreviewed gardening. Skip failing tests.
https://bugs.webkit.org/show_bug.cgi?id=109291.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 14:42:32 +0000 (14:42 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

These are tests that failed due to bad expectations.

* platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
* platform/chromium-mac-lion/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
* platform/chromium-mac-lion/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/overhang-ne-expected.png: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/overhang-nw-expected.png: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/overhang-se-expected.png: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/overhang-sw-expected.png: Added.
* platform/chromium-win/platform/chromium/rubberbanding: Added.
* platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png: Added.
* platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.txt: Added.
* platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png: Added.
* platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.txt: Added.
* platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png: Added.
* platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-se-expected.txt: Added.
* platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png: Added.
* platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.txt: Added.
* platform/chromium-win/platform/chromium/rubberbanding/overhang-ne-expected.png: Added.
* platform/chromium-win/platform/chromium/rubberbanding/overhang-ne-expected.txt: Added.
* platform/chromium-win/platform/chromium/rubberbanding/overhang-nw-expected.png: Added.
* platform/chromium-win/platform/chromium/rubberbanding/overhang-nw-expected.txt: Added.
* platform/chromium-win/platform/chromium/rubberbanding/overhang-se-expected.png: Added.
* platform/chromium-win/platform/chromium/rubberbanding/overhang-se-expected.txt: Added.
* platform/chromium-win/platform/chromium/rubberbanding/overhang-sw-expected.png: Added.
* platform/chromium-win/platform/chromium/rubberbanding/overhang-sw-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-win/svg/custom/embedding-external-svgs-expected.png:
* platform/chromium-win/svg/custom/pointer-events-text-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 14:23:01 +0000 (14:23 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed gardening.

* platform/chromium/TestExpectations: Last of the Win failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a new IGNORE_EXCEPTION helper to ignore ExceptionCodes when they are expected...
mkwst@chromium.org [Fri, 8 Feb 2013 14:21:48 +0000 (14:21 +0000)]
Add a new IGNORE_EXCEPTION helper to ignore ExceptionCodes when they are expected but uninteresting
https://bugs.webkit.org/show_bug.cgi?id=108771

Reviewed by Eric Seidel.

In cases where the ExceptionCode passed into a function is completely
ignored, this patch replaces it with a new IGNORE_EXCEPTION macro. This
makes our expectations about possible exceptions (or lack thereof)
explicit, rather than relying on implicit assumptions about whether a
variable is intentionally uninitialized or not. It also removes
knowledge about the internals of ExceptionCodes (that they're currently
ints, for instance) from code that shouldn't care, which will help with
future refactorings.

The implementation is entirely based upon ASSERT_NO_EXCEPTION, and
shouldn't have any visible effect on the web. As long as all the
current tests pass, we're good.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::stop):
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::processBuffer):
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
* dom/ExceptionCodePlaceholder.h:
(WebCore):
* dom/Node.cpp:
(WebCore::Node::normalize):
* dom/Text.cpp:
(WebCore::Text::replaceWholeText):
* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::insertDictatedText):
* editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::doApply):
(WebCore::AppendNodeCommand::doUnapply):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt):
* editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doUnapply):
* editing/Editor.cpp:
(WebCore::dispatchEditableContentChangedEvents):
(WebCore::Editor::applyEditingStyleToElement):
* editing/EditorCommand.cpp:
(WebCore::executeFormatBlock):
* editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::elementForFormatBlockCommand):
* editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApplyForSingleParagraph):
* editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):
* editing/RemoveCSSPropertyCommand.cpp:
(WebCore::RemoveCSSPropertyCommand::doApply):
(WebCore::RemoveCSSPropertyCommand::doUnapply):
* editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doApply):
(WebCore::RemoveNodeCommand::doUnapply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
* editing/TextIterator.cpp:
(WebCore::TextIterator::getLocationAndLengthFromRange):
* editing/WrapContentsInDummySpanCommand.cpp:
(WebCore::WrapContentsInDummySpanCommand::executeApply):
(WebCore::WrapContentsInDummySpanCommand::doUnapply):
* editing/htmlediting.cpp:
(WebCore::comparePositions):
* editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup):
* html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::appendEntry):
(WebCore::FTPDirectoryDocumentParser::createTDForFilename):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::rewind):
(WebCore::HTMLMediaElement::returnToRealtime):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::percentLoaded):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::mediaPlayerDurationChanged):
(WebCore::HTMLMediaElement::applyMediaFragmentURI):
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::setTextContentInternal):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::remove):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::createTHead):
(WebCore::HTMLTableElement::deleteTHead):
(WebCore::HTMLTableElement::createTFoot):
(WebCore::HTMLTableElement::deleteTFoot):
(WebCore::HTMLTableElement::createCaption):
(WebCore::HTMLTableElement::deleteCaption):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setDefaultValue):
* html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
* html/InputType.cpp:
(WebCore::InputType::stepUpFromRenderer):
* html/MediaController.cpp:
(MediaController::bringElementUpToSpeed):
(MediaController::asyncEventTimerFired):
* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::replaceMediaElementTimerFired):
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):
* html/TimeRanges.cpp:
(TimeRanges::contain):
(TimeRanges::nearest):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
* html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlSeekButtonElement::seekTimerFired):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlStatusDisplayElement::update):
(WebCore::MediaControlRewindButtonElement::defaultEventHandler):
(WebCore::MediaControlTimelineElement::defaultEventHandler):
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::updateCurrentTimeDisplay):
(WebCore::MediaControls::createTextTrackDisplay):
* html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::updateCurrentTimeDisplay):
* html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlEmbeddedPanelElement::setPosition):
(WebCore::MediaControlEmbeddedPanelElement::resetPosition):
(WebCore::MediaControlFullscreenTimelineElement::defaultEventHandler):
(WebCore::MediaControlsBlackBerry::updateCurrentTimeDisplay):
* html/shadow/MediaControlsChromium.cpp:
(WebCore::MediaControlsChromium::updateCurrentTimeDisplay):
* html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::addGenericCue):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
* inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::markUndoableState):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::replayXHR):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* page/DOMWindow.cpp:
(WebCore::didAddStorageEventListener):
* page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):
* page/Page.cpp:
(WebCore::Page::findStringMatchingRanges):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaSliderTrack):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::percentLoaded):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaSliderTrack):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getDataSelection):
(WebCore::documentFragmentWithImageResource):
(WebCore::Pasteboard::documentFragment):
* platform/mac/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
(-[WebVideoFullscreenHUDWindowController setVolume:]):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintMediaSliderTrack):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::getRanges):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaSliderTrack):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::detachTarget):
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::endElementNs):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseEndElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 14:14:51 +0000 (14:14 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed gardening.

* platform/chromium/TestExpectations: Adding Mac rubberbanding failures

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Introduce workspace provider/project type, encapsulate uri creation...
vsevik@chromium.org [Fri, 8 Feb 2013 14:10:53 +0000 (14:10 +0000)]
Web Inspector: Introduce workspace provider/project type, encapsulate uri creation in SimpleWorkspaceProvider.
https://bugs.webkit.org/show_bug.cgi?id=109282

Reviewed by Alexander Pavlov.

Source/WebCore:

SimpleWorkspaceProvider now fully takes care of creating uri based on project/workspace provider type.
This is the first step on the way to project-per-domain mode for non file system project types.
Workspace is now partly aware of the possibility that several projects with the same type exist.
Drive-by: ScriptsPanel now uses FileMapping to show anchor location properly.
* inspector/front-end/DefaultScriptMapping.js:
(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onGetPageResources):
* inspector/front-end/FileMapping.js:
(WebInspector.FileMapping.prototype.uriForURL):
* inspector/front-end/FileSystemWorkspaceProvider.js:
(WebInspector.FileSystemWorkspaceProvider.prototype.type):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._supportsEnabledBreakpointsWhileEditing):
* inspector/front-end/LiveEditSupport.js:
(WebInspector.LiveEditSupport):
(WebInspector.LiveEditSupport.prototype.uiSourceCodeForLiveEdit):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._navigatorViewForUISourceCode):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._projectWillReset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
* inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.type):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addUniqueFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._uniqueURI):
* inspector/front-end/Workspace.js:
(WebInspector.WorkspaceProvider.prototype.type):
(WebInspector.Project.prototype.type):
(WebInspector.Project.prototype.isServiceProject):
(WebInspector.Workspace.prototype.uiSourceCodeForOriginURL):
(WebInspector.Workspace.prototype.uiSourceCodesForProjectType):
(WebInspector.Workspace.prototype.projectsForType):
* inspector/front-end/inspector.js:

LayoutTests:

* http/tests/inspector-enabled/dynamic-scripts.html:
* http/tests/inspector/compiler-script-mapping.html:
* http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/dynamic-scripts.html:
* inspector/debugger/script-snippet-model.html:
* inspector/debugger/scripts-file-selector.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:
* inspector/uisourcecode-revisions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated French translation
kov@webkit.org [Fri, 8 Feb 2013 13:55:02 +0000 (13:55 +0000)]
Updated French translation
https://bugs.webkit.org/show_bug.cgi?id=106229

Patch by Alexandre Franke <alexandre.franke@gmail.com> on 2013-02-08
Rubber-stamped by Gustavo Noronha.

* fr.po: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 13:49:42 +0000 (13:49 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed gardening.

* platform/chromium/TestExpectations: Outstanding Win failures

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 13:41:15 +0000 (13:41 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed gardening.

* platform/chromium/TestExpectations: One more to get all bots green again ready for rebaselining.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][AC] GraphicsLayerClutter doesn't need to recalculate its position after changin...
commit-queue@webkit.org [Fri, 8 Feb 2013 13:35:09 +0000 (13:35 +0000)]
[GTK][AC] GraphicsLayerClutter doesn't need to recalculate its position after changing anchor position.
https://bugs.webkit.org/show_bug.cgi?id=109226

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2013-02-08
Reviewed by Gustavo Noronha Silva.

Clutter has a different coordinate system from mac port's, so we don't need to
recalulate GraphicsLayer position after changing its anchor position.

Covered by existing ac tests.

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::updateGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 13:16:30 +0000 (13:16 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed gardening.

* platform/chromium/TestExpectations: Modified a MountainLion expectation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 13:05:23 +0000 (13:05 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMigrate ExceptionCode ASSERTs in IDB to ASSERT_NO_EXCEPTION.
mkwst@chromium.org [Fri, 8 Feb 2013 13:04:31 +0000 (13:04 +0000)]
Migrate ExceptionCode ASSERTs in IDB to ASSERT_NO_EXCEPTION.
https://bugs.webkit.org/show_bug.cgi?id=109266

Reviewed by Jochen Eisinger.

The pattern:

    ExceptionCode ec = 0;
    methodThatGeneratesException(ec);
    ASSERT(!ec);

is more clearly and succinctly written as:

    methodThatGeneratesException(ASSERT_NO_EXCEPTION);

This patch replaces the occurances of the former in IDB code that never
touch 'ec' again with the latter. No change in behavior should result
from this refactoring.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):
    These methods checked the value of the ExceptionCode without first
    initializing it to 0. Now the ExceptionCode is explicitly set to 0
    before doing potentially exception-generating work.
(WebCore::IDBCursor::direction):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::mode):
    Replace the above pattern with ASSERT_NO_EXCEPTION.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMigrate ExceptionCode ASSERTs in SVG to ASSERT_NO_EXCEPTION.
mkwst@chromium.org [Fri, 8 Feb 2013 12:54:55 +0000 (12:54 +0000)]
Migrate ExceptionCode ASSERTs in SVG to ASSERT_NO_EXCEPTION.
https://bugs.webkit.org/show_bug.cgi?id=109267

Reviewed by Jochen Eisinger.

The pattern:

    ExceptionCode ec = 0;
    methodThatGeneratesException(ec);
    ASSERT(!ec);

is more clearly and succinctly written as:

    methodThatGeneratesException(ASSERT_NO_EXCEPTION);

This patch replaces the occurances of the former in SVG code that never
touch 'ec' again with the latter. No change in behavior should result
from this refactoring.

* svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
(WebCore::SVGLength::setValue):
    This method checked the value of the ExceptionCode without first
    initializing it to 0. Now it initializes before doing potentially
    exception-generating work.
* rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):
(WebCore::SVGRenderStyle::initialStrokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeWidth):
* svg/SVGAnimatedLength.cpp:
(WebCore::sharedSVGLength):
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::textLengthAnimated):
* svg/animation/SVGSMILElement.cpp:
(WebCore::constructQualifiedName):
    Replace the above pattern with ASSERT_NO_EXCEPTION.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC: Lower minimum PropertyTable size.
akling@apple.com [Fri, 8 Feb 2013 12:45:44 +0000 (12:45 +0000)]
JSC: Lower minimum PropertyTable size.
<http://webkit.org/b/109247>

Reviewed by Darin Adler.

Lower the minimum table size for PropertyTable from 16 to 8.
3.32 MB progression on Membuster3 (a ~13% reduction in memory used by PropertyTables.)

* runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::sizeForCapacity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Replace workspace with project in UISourceCode constructor.
vsevik@chromium.org [Fri, 8 Feb 2013 12:42:31 +0000 (12:42 +0000)]
Web Inspector: Replace workspace with project in UISourceCode constructor.
https://bugs.webkit.org/show_bug.cgi?id=109256

Reviewed by Alexander Pavlov.

Source/WebCore:

Replaced workspace with project in UISourceCode constructor since every UISourceCode
operation is delegated to project anyway.

* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.project):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.requestOriginalContent):
(WebInspector.UISourceCode.prototype._commitContent):
(WebInspector.UISourceCode.prototype.searchInContent):
* inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.setFileContent):
(WebInspector.Project.prototype.searchInFileContent):

LayoutTests:

* inspector/debugger/breakpoint-manager-expected.txt:
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/script-formatter-search.html:
* inspector/debugger/scripts-file-selector.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting.html:
* inspector/debugger/ui-source-code-display-name.html:
* inspector/debugger/ui-source-code.html:
* inspector/uisourcecode-revisions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 8 Feb 2013 12:39:06 +0000 (12:39 +0000)]
Unreviewed GTK gardening.

* platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r142205.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 12:22:16 +0000 (12:22 +0000)]
Remove Skia code suppressions

Unreviewed enabling of existing optimizations

Removing all skia_webkit.gyp code suppressions and adding expectations
for the failures.

Source/WebKit/chromium:

* skia_webkit.gyp:

LayoutTests:

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate my entries in the watchlist
caio.oliveira@openbossa.org [Fri, 8 Feb 2013 12:10:24 +0000 (12:10 +0000)]
Update my entries in the watchlist

Unreviewed.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed gardening. Adjusting expectations for two failures.
schenney@chromium.org [Fri, 8 Feb 2013 12:08:18 +0000 (12:08 +0000)]
[chromium] Unreviewed gardening. Adjusting expectations for two failures.

Unreviewed Chromium expectations

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for Windows after r141981.
paroga@webkit.org [Fri, 8 Feb 2013 11:58:02 +0000 (11:58 +0000)]
Build fix for Windows after r141981.

* platform/network/win/ResourceHandleWin.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] copy normalizeLayoutTestURL code to TestRunner library
jochen@chromium.org [Fri, 8 Feb 2013 11:51:31 +0000 (11:51 +0000)]
[chromium] copy normalizeLayoutTestURL code to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109269

Reviewed by Kent Tamura.

The method doesn't have any external dependencies, so there's no reason
it should be on the delegate. It's still required by TestShell, however,
by making a copy, we can avoid implementing this in content shell.

* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
* DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
(WebTestRunner::WebPermissions::allowImage):
(WebTestRunner::WebPermissions::allowScriptFromSource):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::windowCount):
* DumpRenderTree/chromium/TestShell.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, forced commit to trigger an EFL bot cycle
rakuco@webkit.org [Fri, 8 Feb 2013 11:45:54 +0000 (11:45 +0000)]
Unreviewed, forced commit to trigger an EFL bot cycle

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r141695 and r141697.
commit-queue@webkit.org [Fri, 8 Feb 2013 11:15:27 +0000 (11:15 +0000)]
Unreviewed, rolling out r141695 and r141697.
http://trac.webkit.org/changeset/141695
http://trac.webkit.org/changeset/141697
https://bugs.webkit.org/show_bug.cgi?id=109279

broke on-disk buffering for http(s) media (Requested by philn
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-08

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcGetProtocols):
(webKitWebSrcSetUri):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[v8] isolate parameter added to all v8::peristent calls
commit-queue@webkit.org [Fri, 8 Feb 2013 10:17:15 +0000 (10:17 +0000)]
[v8] isolate parameter added to all v8::peristent calls
https://bugs.webkit.org/show_bug.cgi?id=109268

Patch by Dan Carney <dcarney@google.com> on 2013-02-08
Reviewed by Kentaro Hara.

Source/WebCore:

No new tests. No change in functionality.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::GetRawTemplate):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::V8TestActiveDOMObject::GetRawTemplate):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::GetRawTemplate):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::GetRawTemplate):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::GetRawTemplate):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::GetRawTemplate):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::GetRawTemplate):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::GetRawTemplate):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::GetRawTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::GetRawTemplate):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::GetRawTemplate):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
* bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::clear):
* bindings/v8/DOMWrapperWorld.cpp:
(WebCore::isolatedWorldWeakCallback):
(WebCore::DOMWrapperWorld::makeContextWeak):
* bindings/v8/NPV8Object.cpp:
(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):
* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::~ScheduledAction):
* bindings/v8/ScopedPersistent.h:
(WebCore::ScopedPersistent::ScopedPersistent):
(WebCore::ScopedPersistent::set):
(WebCore::ScopedPersistent::clear):
* bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::weakCallback):
* bindings/v8/V8Binding.cpp:
(WebCore::createRawTemplate):
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8GCController.cpp:
(WebCore::gcTree):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
* bindings/v8/V8GCController.h:
(V8GCController):
* bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::V8HiddenPropertyName::createString):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8NPObject.cpp:
(WebCore::V8NPTemplateMap::dispose):
(WebCore::npObjectGetProperty):
(WebCore::createV8ObjectForNPObject):
* bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8PerContextData::constructorForTypeSlowCase):
* bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):
* bindings/v8/WrapperTypeInfo.h:
(WebCore::WrapperConfiguration::configureWrapper):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::wrapInShadowObject):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):

Source/WebKit/chromium:

* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Make the Performance bot also build WebKit.
rakuco@webkit.org [Fri, 8 Feb 2013 09:56:42 +0000 (09:56 +0000)]
[EFL] Make the Performance bot also build WebKit.
https://bugs.webkit.org/show_bug.cgi?id=109273

Reviewed by Philippe Normand.

There has not been much benefit in fetching binaries compiled by
another bot; it makes the build bot take 6 to 7 minutes to upload
the binaries to build.webkit.org, we need to manually override
LD_LIBRARY_PATH to find the compiled libraries and still have
other path-related problems.

Since we have enough horsepower in the perf bot, let's experiment
with building WebKit there instead.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdjust usage of ENABLE flags to enable whole content
tkent@chromium.org [Fri, 8 Feb 2013 09:34:13 +0000 (09:34 +0000)]
Adjust usage of ENABLE flags to enable whole content
https://bugs.webkit.org/show_bug.cgi?id=109270

Reviewed by Eric Seidel.

Our common usage of ENABLE flags to enable whole content of files is:

For .cpp files:
  #include "config.h"
  #if ENABLE(FOOBAR)
  #include "FooBar.h"

For .h files:
  #ifndef FooBar_h
  #define FooBar_h
  #if ENABLE(FOOBAR)

Fix files which have uncommon usage, and fix CodeGeneratorV8.pm so that
it generates the common pattern. Note that CodeGeneratorJS.pm already
generates code in this order.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
* bindings/scripts/test/V8/V8TestCallback.cpp:
* bindings/scripts/test/V8/V8TestCallback.h:
* bindings/scripts/test/V8/V8TestInterface.cpp:
* bindings/scripts/test/V8/V8TestInterface.h:
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
* html/BaseMultipleFieldsDateAndTimeInputType.h:
* html/ColorInputType.cpp:
* html/ColorInputType.h:
* html/DateInputType.cpp:
* html/DateTimeInputType.cpp:
* html/DateTimeInputType.h:
* html/DateTimeLocalInputType.cpp:
* html/HTMLAudioElement.cpp:
* html/HTMLAudioElement.h:
* html/HTMLDataListElement.cpp:
* html/HTMLDialogElement.cpp:
* html/HTMLDialogElement.h:
* html/HTMLMediaElement.cpp:
* html/HTMLMediaElement.h:
* html/HTMLMeterElement.cpp:
* html/HTMLProgressElement.cpp:
* html/HTMLSourceElement.cpp:
* html/HTMLSourceElement.h:
* html/HTMLTrackElement.cpp:
* html/HTMLTrackElement.h:
* html/HTMLVideoElement.cpp:
* html/HTMLVideoElement.h:
* html/MonthInputType.cpp:
* html/TimeInputType.cpp:
* html/WeekInputType.cpp:
* html/shadow/DateTimeFieldElement.h:
* html/shadow/DetailsMarkerControl.cpp:
* html/shadow/MeterShadowElement.cpp:
* html/shadow/ProgressShadowElement.cpp:
* rendering/RenderDetailsMarker.cpp:
* rendering/RenderInputSpeech.cpp:
* rendering/RenderMeter.cpp:
* rendering/RenderProgress.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro.
mkwst@chromium.org [Fri, 8 Feb 2013 09:12:52 +0000 (09:12 +0000)]
Replace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro.
https://bugs.webkit.org/show_bug.cgi?id=109044

Reviewed by Darin Adler.

The pattern:

    ExceptionCode ec = 0;
    methodThatGeneratesException(ec);
    ASSERT(!ec);

is more clearly and succinctly written as:

    methodThatGeneratesException(ASSERT_NO_EXCEPTION);

This patch replaces the occurances of the former that never touch 'ec'
again with the latter. It does the same for 'ASSERT(ec == 0);' (and, as
a drive-by, replaces 'ASSERT(ec == 0)' with 'ASSERT(!ec)' in places
where it does indeed matter that 'ec' get set properly.

No change in behavior should result from this refactoring.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
* dom/Document.cpp:
(WebCore::Document::setTitle):
* dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
* editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::createDeletionUI):
    Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
(WebCore::DeleteButtonController::show):
    Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
* editing/EditorCommand.cpp:
(WebCore::unionDOMRanges):
* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::removeNode):
(WebCore::ReplacementFragment::insertNodeBefore):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
* editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doUnapply):
* editing/TextIterator.cpp:
(WebCore::CharacterIterator::range):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::collapsedToBoundary):
* editing/htmlediting.cpp:
(WebCore::createTabSpanElement):
* editing/mac/EditorMac.mm:
(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):
* editing/markup.cpp:
(WebCore::createMarkup):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
(WebCore::createFragmentFromNodes):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
    Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
    Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText):
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
* html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::addRule):
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::dispatchDOMEvent):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::deleteFromDocument):
* page/DragController.cpp:
(WebCore::prepareClipboardForImageDrag):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::visiblePositionForIndex):
    Replaced inline ASSERT with ASSERT_NO_EXCEPTION.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed gardening. Adjusting expectations for two hidpi tests.
falken@chromium.org [Fri, 8 Feb 2013 09:03:59 +0000 (09:03 +0000)]
[chromium] Unreviewed gardening. Adjusting expectations for two hidpi tests.
https://bugs.webkit.org/show_bug.cgi?id=96441

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Skip failing tests.
kadam@inf.u-szeged.hu [Fri, 8 Feb 2013 09:00:53 +0000 (09:00 +0000)]
[Qt] Unreviewed gardening. Skip failing tests.

* platform/qt-5.0/fast/js/global-constructors-expected.txt: Removed.
* platform/qt/TestExpectations:
* platform/qt/fast/js/global-constructors-expected.txt: Added after r142149.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Mark some tests as passing with incorrect expectations
commit-queue@webkit.org [Fri, 8 Feb 2013 08:57:11 +0000 (08:57 +0000)]
[EFL] Mark some tests as passing with incorrect expectations
https://bugs.webkit.org/show_bug.cgi?id=109173

Unreviewed EFL gardening.

Add new category for TestExpectations: PASSING TESTS WITH INCORRECT EXPECTATIONS.

Currently, the tests are passing with their generated incorrect expectations.
It should be checked if the test starts failing. It means, the test can be passing now.

Below tests are marked as passing tests with incorrect expectations.

fast/forms/basic-textareas-quirks.html
fast/forms/input-disabled-color.html
fast/forms/input-readonly-dimmed.html
fast/forms/listbox-hit-test-zoomed.html
fast/forms/menulist-narrow-width.html
fast/forms/menulist-style-color.html
fast/forms/plaintext-mode-2.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-rtl.html
fast/forms/select-baseline.html
fast/forms/select-style.html
fast/forms/zoomed-controls.html

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-08

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: disable profile type switching while profile in progress
commit-queue@webkit.org [Fri, 8 Feb 2013 08:25:21 +0000 (08:25 +0000)]
Web Inspector: disable profile type switching while profile in progress
https://bugs.webkit.org/show_bug.cgi?id=109178

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-08
Reviewed by Yury Semikhatsky.

Disables profile type selection controls when a profiling session
is in progress.

* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
* inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView.prototype._updateControls):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Native Memory Instrumentation: reportBaseAddress needs to be called...
loislo@chromium.org [Fri, 8 Feb 2013 08:24:16 +0000 (08:24 +0000)]
Web Inspector: Native Memory Instrumentation: reportBaseAddress needs to be called after the reportNode. So it may reuse the node index for the real address.
https://bugs.webkit.org/show_bug.cgi?id=109051

Reviewed by Yury Semikhatsky.

* wtf/MemoryInstrumentation.cpp:
(WTF::MemoryInstrumentation::WrapperBase::processPointer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Native Memory Instrumentation: adjust chunk transfer size for better...
loislo@chromium.org [Fri, 8 Feb 2013 08:18:04 +0000 (08:18 +0000)]
Web Inspector: Native Memory Instrumentation: adjust chunk transfer size for better speed.
https://bugs.webkit.org/show_bug.cgi?id=109263

Reviewed by Yury Semikhatsky.

The chunk size is changed from 100 to 10000.
addString counts only first 256 symbols of the string.o

* inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::pushUpdateIfNeeded):
(WebCore::HeapGraphSerializer::addString):
* inspector/front-end/NativeMemorySnapshotView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport a relatedTarget attribute on focus/blur events
haraken@chromium.org [Fri, 8 Feb 2013 08:05:49 +0000 (08:05 +0000)]
Support a relatedTarget attribute on focus/blur events
https://bugs.webkit.org/show_bug.cgi?id=109176

Reviewed by Ojan Vafai.

In bug 76216, we supported a relatedTarget attribute on
focusin/focusout events. We should also support it on focus/blur events.

See http://lists.w3.org/Archives/Public/www-dom/2012OctDec/0061.html
for the www-dom discussion.

Source/WebCore:

Test: fast/dom/shadow/shadow-boundary-events.html
      fast/events/related-target-focusevent.html

* dom/EventDispatchMediator.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
* dom/EventDispatchMediator.h:
(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
* dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):

LayoutTests:

* fast/dom/shadow/shadow-boundary-events-expected.txt:
* fast/dom/shadow/shadow-boundary-events.html:
* fast/events/related-target-focusevent-expected.txt:
* fast/events/related-target-focusevent.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: reduce number of native memory instrumentation categories
yurys@chromium.org [Fri, 8 Feb 2013 07:58:37 +0000 (07:58 +0000)]
Web Inspector: reduce number of native memory instrumentation categories
https://bugs.webkit.org/show_bug.cgi?id=109146

Reviewed by Pavel Feldman.

Source/WebCore:

Merged some of memory instrumentation categories.

* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
* platform/PlatformMemoryInstrumentation.cpp:
(WebCore):

LayoutTests:

Updated tests to use new memory categories.

* inspector-protocol/nmi-webaudio-expected.txt:
* inspector-protocol/nmi-webaudio-leak-test-expected.txt:
* inspector-protocol/nmi-webaudio-leak-test.html:
* inspector-protocol/nmi-webaudio.html:
* inspector/profiler/memory-instrumentation-cached-images-expected.txt:
* inspector/profiler/memory-instrumentation-cached-images.html:
* inspector/profiler/memory-instrumentation-canvas-expected.txt:
* inspector/profiler/memory-instrumentation-canvas.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed gardening. Flakiness on table-cell-before-after-content-around...
falken@chromium.org [Fri, 8 Feb 2013 07:47:00 +0000 (07:47 +0000)]
[chromium] Unreviewed gardening. Flakiness on table-cell-before-after-content-around-table-row.html
https://bugs.webkit.org/show_bug.cgi?id=109262

An assert is sometimes hit in WebCore::RenderTableCell::styleDidChange.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] turn TestRunner library into a component build
jochen@chromium.org [Fri, 8 Feb 2013 07:38:16 +0000 (07:38 +0000)]
[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466

Reviewed by Adam Barth.

To achieve this, we need to drop all dependencies on WTF.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
* DumpRenderTree/chromium/TestRunner/public/WebTask.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
* DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
* DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
* DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
* DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
* DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
* DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(WebTestRunner):
(MockGrammarCheck):
* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
* DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
* DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
(isASCIIAlpha):
(isNotASCIIAlpha):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
* DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
* DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
* DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<iframe seamless> should avoid vertical scrollbars during the initial layout passes.
mkwst@chromium.org [Fri, 8 Feb 2013 07:35:48 +0000 (07:35 +0000)]
<iframe seamless> should avoid vertical scrollbars during the initial layout passes.
https://bugs.webkit.org/show_bug.cgi?id=87707

Reviewed by Eric Seidel.

Source/WebCore:

Seamless documents currently render incorrectly when their content fills
the width of the container into which they're placed. Because FrameView
assumes that the container's size is properly set before the first pass
of layout, vertical scrollbars are incorrectly forced onto seamless
content, because seamless sets the container's height to 0 before
handing it off to FrameView for layout. The scrollbars make the
available width for the seamless document ~15px smaller than it should
be, resulting in content getting bumped to the next line.

This patch special-cases FrameView::calculateScrollbarModesForLayout in
order to force scrollbars off for seamless documents with a full visible
height of 0px. Once the layout pass has grabbed the content height and
applied it to the visible height, scrollbars will again be applicable.

The change should be covered by rebaselines for the newly-passing
results in fast/frame/seamless-{float,inline}.html

* page/FrameView.cpp:
(WebCore::FrameView::calculateScrollbarModesForLayout):
    If we're rendering a seamless document, and the full visible height
    is 0, and the vertical scrollbar would otherwise be ScrollbarAuto,
    then force ScrollbarAlwaysOff.

LayoutTests:

* fast/frames/seamless/seamless-float-expected.txt:
* fast/frames/seamless/seamless-inline-expected.txt:
    Rebaseline the now-passing bits of these tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rebaseline.
alokp@chromium.org [Fri, 8 Feb 2013 07:34:27 +0000 (07:34 +0000)]
Unreviewed rebaseline.

* platform/mac-lion/compositing/visible-rect/iframe-no-layers-expected.txt: Copied from LayoutTests/platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt.
* platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
* platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt: Copied from LayoutTests/platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt.
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Added.
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Added.
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt: Added.
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Added.
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Added.
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agodocument.activeElement should not return a non-focusable element
tkent@chromium.org [Fri, 8 Feb 2013 07:18:05 +0000 (07:18 +0000)]
document.activeElement should not return a non-focusable element
https://bugs.webkit.org/show_bug.cgi?id=86707

Reviewed by Hajime Morita.

Source/WebCore:

This is based on a patch by Arpita Bahuguna.

Test: fast/dom/HTMLDocument/set-focus-on-valid-element.html

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
Added check for verifying that the node to be focused is
focusable. However, this check should be skipped for HTMLPlugInElement
because it has special behavior.

LayoutTests:

* fast/dom/HTMLDocument/set-focus-on-valid-element-expected.txt: Added.
* fast/dom/HTMLDocument/set-focus-on-valid-element.html: Added.
This test verifies that document.activeElement does not return an
invalid or non-focusable element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed followup to r142232.
zandobersek@gmail.com [Fri, 8 Feb 2013 07:08:52 +0000 (07:08 +0000)]
Unreviewed followup to r142232.

Work around a bug in jhbuild that was incorrectly composing the source
package URL by adjusting slightly the repository and module paths.

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse a mirror for the sourceware.org repo used in jhbuild
zandobersek@gmail.com [Fri, 8 Feb 2013 06:46:06 +0000 (06:46 +0000)]
Use a mirror for the sourceware.org repo used in jhbuild

Unreviewed.

The ftp://sourceware.org site is down, causing errors when running jhbuild
and subsequently failing complete builds on the builders. Use the mirrors.kernel.org
mirror to get sources for the desired libffi dependency.

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Fix front-end compilation warnings related to WebInspector.SidebarPane
commit-queue@webkit.org [Fri, 8 Feb 2013 06:42:00 +0000 (06:42 +0000)]
Web Inspector: Fix front-end compilation warnings related to WebInspector.SidebarPane
https://bugs.webkit.org/show_bug.cgi?id=109259

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.

* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.Proxy):
* inspector/front-end/SidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix #endif comment from r142163 and r142183
ddkilzer@apple.com [Fri, 8 Feb 2013 06:41:43 +0000 (06:41 +0000)]
Fix #endif comment from r142163 and r142183

* wtf/MainThread.h:
(WTF): s/PLATFORM/USE/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed gardening. Two webgl/conformance/context tests are timing out.
falken@chromium.org [Fri, 8 Feb 2013 06:15:12 +0000 (06:15 +0000)]
[chromium] Unreviewed gardening. Two webgl/conformance/context tests are timing out.

See https://bugs.webkit.org/show_bug.cgi?id=109114

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleaning up after r142208
zoltan@webkit.org [Fri, 8 Feb 2013 06:05:58 +0000 (06:05 +0000)]
Cleaning up after r142208
https://bugs.webkit.org/show_bug.cgi?id=109228

Unreviewed.

The commit-queue didn't remove these files for some reason. Removing them manually.

* platform/chromium-mac-lion/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
* platform/chromium-mac/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
* platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
* platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
* platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
* platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
* platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebpage needs null check in BackingStore::setCurrentBackingStoreOwner
charles.wei@torchmobile.com.cn [Fri, 8 Feb 2013 05:47:47 +0000 (05:47 +0000)]
webpage needs null check in BackingStore::setCurrentBackingStoreOwner
https://bugs.webkit.org/show_bug.cgi?id=109253

Reviewed by George Staikos.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] enum V8HiddenPropertyCreationType is not used
haraken@chromium.org [Fri, 8 Feb 2013 05:37:26 +0000 (05:37 +0000)]
[V8] enum V8HiddenPropertyCreationType is not used
https://bugs.webkit.org/show_bug.cgi?id=109250

Reviewed by Adam Barth.

V8HiddenPropertyCreationType is always NewSymbol. We can remove the enum.

No tests. No change in behavior.

* bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::hiddenReferenceName):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r142212.
commit-queue@webkit.org [Fri, 8 Feb 2013 05:32:45 +0000 (05:32 +0000)]
Unreviewed, rolling out r142212.
http://trac.webkit.org/changeset/142212
https://bugs.webkit.org/show_bug.cgi?id=109255

Causes ASSERT(!m_installed) on launch (Requested by smfr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07

Source/WebCore:

* WebCore.exp.in:
* platform/MemoryPressureHandler.cpp:
(WebCore):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
* platform/MemoryPressureHandler.h:
(MemoryPressureHandler):
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure):

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(WebInstallMemoryPressureHandler):

Source/WebKit2:

* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::initializeProcess):
(WebKit::PluginProcess::shouldTerminate):
* PluginProcess/PluginProcess.h:
(PluginProcess):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline text output for contentOpaque
alokp@chromium.org [Fri, 8 Feb 2013 05:03:44 +0000 (05:03 +0000)]
Rebaseline text output for contentOpaque
https://bugs.webkit.org/show_bug.cgi?id=108656

Unreviewed rebaseline.

* platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
* platform/chromium/TestExpectations:
* platform/chromium/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
* platform/mac/TestExpectations:
* platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
* platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNamedFlowCollection should be a ContextDestructionObserver
commit-queue@webkit.org [Fri, 8 Feb 2013 04:59:23 +0000 (04:59 +0000)]
NamedFlowCollection should be a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=99239

Patch by Hanyee Kim <choco@company100.net> on 2013-02-07
Reviewed by Adam Barth

This patch removes the raw pointer of Document in NamedFlowCollection.
It could be replaced with ContextDestructionObserver.
ContextDestructionObserver has the pointer and clears the pointer
automatically when the document is destroyed.

* dom/Document.cpp:
(WebCore::Document::~Document):
* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::NamedFlowCollection):
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
(WebCore::NamedFlowCollection::document):
(WebCore):
* dom/NamedFlowCollection.h:
(NamedFlowCollection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Remove dead code after r142169
gyuyoung.kim@samsung.com [Fri, 8 Feb 2013 04:29:53 +0000 (04:29 +0000)]
[EFL][WK2] Remove dead code after r142169
https://bugs.webkit.org/show_bug.cgi?id=109251

Reviewed by Benjamin Poulain.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFollowup review suggestions from Alexey Proskuryakov on
dino@apple.com [Fri, 8 Feb 2013 04:16:53 +0000 (04:16 +0000)]
Followup review suggestions from Alexey Proskuryakov on
https://bugs.webkit.org/show_bug.cgi?id=109215

Don't provide a charset on embedded SVG, especially
with incorrect syntax :)

* css/mediaControlsQuickTime.css:
(video::-webkit-media-controls-toggle-closed-captions-button):
(video::-webkit-media-controls-closed-captions-track-list li.selected):
(video::-webkit-media-controls-closed-captions-track-list li.selected:hover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Enable non-video element enter/exit fullscreen.
mary.wu@torchmobile.com.cn [Fri, 8 Feb 2013 03:01:40 +0000 (03:01 +0000)]
[BlackBerry] Enable non-video element enter/exit fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=108314

Reviewed by Antonio Gomes.

Webkit support non-video element (like div) to enter/exit
fullscreen. We should pass this capability in blackberry porting.

RIM PR 256370, internally reviewed by Max Feil.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
(BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Gtk] RunLoop::run shuold run current thread's run loop.
commit-queue@webkit.org [Fri, 8 Feb 2013 02:41:21 +0000 (02:41 +0000)]
[Gtk] RunLoop::run shuold run current thread's run loop.
https://bugs.webkit.org/show_bug.cgi?id=107887

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-07
Reviewed by Martin Robinson.

Currently, RunLoop in Gtk can use just main thread's event loop.
But the other ports are implemented to use RunLoop in sub threads.

This patch makes RunLoop constructor create new context, not use default
context.
But in the main thread still uses default context to use main event loop
since there is some codes using glib directly (e.g. in
LayerTreeHostGtk::scheduleLayerFlush).

No new tests. There is no case that uses RunLoop in off the main thread
yet.

* platform/gtk/RunLoopGtk.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Rebaseline bidi-ignored-for-first-child-inline.html
falken@chromium.org [Fri, 8 Feb 2013 02:29:58 +0000 (02:29 +0000)]
Unreviewed gardening. Rebaseline bidi-ignored-for-first-child-inline.html
which was failing on Chromium Mac after r142152.

* platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Renamed from LayoutTests/platform/chromium/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h
haraken@chromium.org [Fri, 8 Feb 2013 02:11:03 +0000 (02:11 +0000)]
[V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h
https://bugs.webkit.org/show_bug.cgi?id=109186

Reviewed by Adam Barth.

V8HiddenPropertyName.h is a right place for setNamedHiddenReference().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
* bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::V8HiddenPropertyName::hiddenReferenceName):
(WebCore::V8HiddenPropertyName::setNamedHiddenReference):
(WebCore):
* bindings/v8/V8HiddenPropertyName.h:
(V8HiddenPropertyName):
(WebCore::V8HiddenPropertyName::V8HiddenPropertyName):
* bindings/v8/custom/V8MessageChannelCustom.cpp:
(WebCore::V8MessageChannel::constructorCallbackCustom):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r142113.
commit-queue@webkit.org [Fri, 8 Feb 2013 01:42:58 +0000 (01:42 +0000)]
Unreviewed, rolling out r142113.
http://trac.webkit.org/changeset/142113
https://bugs.webkit.org/show_bug.cgi?id=109244

tests started failing after r142081 was rolled out in r142166
(Requested by falken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07

* inspector/profiler/memory-instrumentation-cached-images-expected.txt:
* inspector/profiler/memory-instrumentation-cached-images.html:
* inspector/profiler/memory-instrumentation-canvas-expected.txt:
* inspector/profiler/memory-instrumentation-canvas.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogetComputedStyle() doesn't report intermediate values during a transition of a pseudo...
esprehn@chromium.org [Fri, 8 Feb 2013 01:40:30 +0000 (01:40 +0000)]
getComputedStyle() doesn't report intermediate values during a transition of a pseudo element
https://bugs.webkit.org/show_bug.cgi?id=106535

Reviewed by Ojan Vafai.

Source/WebCore:

Element::computedStyle and CSSComputedStyleDeclaration::getPropertyCSSValue
should use the PseudoElement and it's renderer if they exist so that
querying the computed style while an animation is running returns
the intermediate values.

No new tests, updated existing tests.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::styledNode): Added, returns either the PseudoElement or the Node.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to use styledNode.
* css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
* dom/Element.cpp:
(WebCore::Element::computedStyle): Check the PseudoElement, not just the cached pseudo style.
* dom/ElementRareData.h:
(WebCore::ElementRareData::pseudoElement): Remove ASSERT_NOT_REACHED so passing other pseudos returns 0.

LayoutTests:

Update tests to also check getComputedStyle during animations and transitions.

* fast/css-generated-content/pseudo-animation-expected.txt:
* fast/css-generated-content/pseudo-animation.html:
* fast/css-generated-content/pseudo-transition-expected.txt:
* fast/css-generated-content/pseudo-transition.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium-Android] Disable input[type=datetime]
tkent@chromium.org [Fri, 8 Feb 2013 01:28:52 +0000 (01:28 +0000)]
[Chromium-Android] Disable input[type=datetime]
https://bugs.webkit.org/show_bug.cgi?id=107614

Reviewed by Kentaro Hara.

Source/WebKit/chromium:

Reason:
http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html

* features.gypi:
Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
We enable it for non-Android ports but the runtime flag for it is
disabled by default. The runtime flag is enabled only in DumpRenderTree.

LayoutTests:

* platform/chromium/TestExpectations:
Tetsts in fast/forms/datetime/ fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a comment about how the SQLTransaction state machine works.
mark.lam@apple.com [Fri, 8 Feb 2013 01:23:45 +0000 (01:23 +0000)]
Add a comment about how the SQLTransaction state machine works.
https://bugs.webkit.org/show_bug.cgi?id=109243.

Rubber stamped by Anders Carlsson.

No new tests.

* Modules/webdatabase/SQLTransactionBackend.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPluginProcess should quit immediately if idle in response to low-memory notifications
barraclough@apple.com [Fri, 8 Feb 2013 01:22:05 +0000 (01:22 +0000)]
PluginProcess should quit immediately if idle in response to low-memory notifications
https://bugs.webkit.org/show_bug.cgi?id=109103
<rdar://problem/12679827>

Reviewed by Darin Adler.

Source/WebCore:

This patch allows a process to set a custom callback for low memory warnings
(defaulting to the current behaviour, as implemented in releaseMemory).

MemoryPressureHandler::install is currently used for two purposes - it is
called when first initializing a low memory handler for a process, and also
used to reinstall the handler (on a delay) after the notification has occured.
Since reinstallation doesn't change the callback, split these behaviours out -
MemoryPressureHandler::initialize is added to initialization, and accepts a
custom callback, install in made private.

* WebCore.exp.in:
    - Added export for releaseMemory.
* platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseMemory):
    - Added null implementation for non-Mac builds.
* platform/MemoryPressureHandler.h:
(WebCore::MemoryPressureHandler::initialize):
    - distinguish initialization from reinstallations, allow handler to be set.
(MemoryPressureHandler):
    - Added m_lowMemoryHandler function pointer member variable.
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
    - Call m_lowMemoryHandler instead of releaseMemory.

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
    - MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize.
(WebInstallMemoryPressureHandler):
    - MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize.

Source/WebKit2:

PluginProcess now initializes a MemoryPressureHandler for the process, providing
a custom callback which will call terminate if appropriate (if the plugin is not
currently in use).

* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::lowMemoryHandler):
    - Custom callback to terminate if appropriate.
(WebKit::PluginProcess::initializeProcess):
    - Initialize the MemoryPressureHandler.
(WebKit::PluginProcess::shouldTerminate):
    - This method now also needs to be callable in situations where it might return false.
* PluginProcess/PluginProcess.h:
(PluginProcess):
    - Added declaration for lowMemoryHandler.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
    - MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] Unreviewed, skip crashing test
jpfau@apple.com [Fri, 8 Feb 2013 01:13:58 +0000 (01:13 +0000)]
[Mac] Unreviewed, skip crashing test

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Corrections the exports definition file.
roger_fong@apple.com [Fri, 8 Feb 2013 01:07:03 +0000 (01:07 +0000)]
Unreviewed. Corrections the exports definition file.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
* WebKit.vcproj/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] #ifndef NDEBUG is redundant for assertContextHasCorrectPrototype()
haraken@chromium.org [Fri, 8 Feb 2013 01:06:30 +0000 (01:06 +0000)]
[V8] #ifndef NDEBUG is redundant for assertContextHasCorrectPrototype()
https://bugs.webkit.org/show_bug.cgi?id=109167

Reviewed by Andreas Kling.

Given that assertContextHasCorrectPrototype() is anyway empty in a release
build, we don't need to surround it with #ifndef NDEBUG.

No tests. No change in behavior.

* bindings/v8/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::assertContextHasCorrectPrototype):
* bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Regions] Turn selecting-text-through-different-region-flows test into a reftest
zoltan@webkit.org [Fri, 8 Feb 2013 00:59:19 +0000 (00:59 +0000)]
[CSS Regions] Turn selecting-text-through-different-region-flows test into a reftest
https://bugs.webkit.org/show_bug.cgi?id=109228

Reviewed by Eric Seidel.

Simplify and turn the test into a reftest, remove the unnecessary expected files.

* fast/regions/selecting-text-through-different-region-flows-expected.html: Added.
* fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
* fast/regions/selecting-text-through-different-region-flows.html:
* platform/chromium-linux/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
* platform/chromium-mac-lion/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
* platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
* platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
* platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
* platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
* platform/gtk/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
* platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
* platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMakefiles should work for arbitrary SDKs and architectures on Apple ports
commit-queue@webkit.org [Fri, 8 Feb 2013 00:56:03 +0000 (00:56 +0000)]
Makefiles should work for arbitrary SDKs and architectures on Apple ports
https://bugs.webkit.org/show_bug.cgi?id=107863

Patch by David Farler <dfarler@apple.com> on 2013-02-07
Reviewed by Mark Rowe.

.:

* Makefile:
Allow SDKROOT, ARCHS outside of $(ARGS).
Setting ARCHS => ONLY_ACTIVE_ARCH=NO.
* Makefile.shared: options to webkitdirs based on SDKROOT
* Source/Makefile: don't build WebKit2 for iOS

Tools:

* DumpRenderTree/Makefile: SDKROOT=iphone* => -target All-iOS
* Makefile: Only build some projects for iOS

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium: Hang parsing bidi control chars on Mac OS X 10.6
commit-queue@webkit.org [Fri, 8 Feb 2013 00:51:18 +0000 (00:51 +0000)]
Chromium: Hang parsing bidi control chars on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=108877

This was broken a while ago by:
    https://bugs.webkit.org/show_bug.cgi?id=83045

On 10.6, CoreText will not produce any runs covering the
Unicode BiDi RTL mark control char, which causes an infinite
loop in ComplexTextController::indexOfCurrentRun() due to no
run covering the character at offset 0.

This patch fixes that issue by finding the earliest run
explicitly via the minimum stringBegin() index instead of
relying on a run existing that covers offset 0.

Fixes hang on many BiDi wikipedia pages on Chromium/Mac10.6.
Chromium bug: http://crbug.com/167844

Source/WebCore:

New test in the same style as the harfbuzz-buffer-overrun.html
test (in the same folder).

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2013-02-07
Reviewed by Eric Seidel.

Test: fast/text/international/rtl-mark.html

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::indexOfCurrentRun):

LayoutTests:

New test in the same style as harfbuzz-buffer-overrun.html
in the same folder.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2013-02-07
Reviewed by Eric Seidel.

* fast/text/international/rtl-mark-expected.txt: Added.
* fast/text/international/rtl-mark.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement FocusEvent constructor
haraken@chromium.org [Fri, 8 Feb 2013 00:37:49 +0000 (00:37 +0000)]
Implement FocusEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=109170

Reviewed by Adam Barth.

Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm

FocusEvent constructor should be implemented under a DOM4_EVENTS_CONSTRUCTOR
flag, which is enabled on Chromium and Safari.

Source/WebCore:

Test: fast/events/constructors/focus-event-constructor.html

* dom/FocusEvent.cpp:
(WebCore::FocusEventInit::FocusEventInit):
(WebCore):
(WebCore::FocusEvent::FocusEvent):
* dom/FocusEvent.h:
(FocusEventInit):
(WebCore):
(WebCore::FocusEvent::create):
(FocusEvent):
* dom/FocusEvent.idl:
* page/DOMWindow.idl:

LayoutTests:

* fast/dom/constructed-objects-prototypes-expected.txt:
* fast/events/constructors/focus-event-constructor-expected.txt: Added.
* fast/events/constructors/focus-event-constructor.html: Added.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHTML parser should queue MutationRecords for its operations
esprehn@chromium.org [Fri, 8 Feb 2013 00:35:17 +0000 (00:35 +0000)]
HTML parser should queue MutationRecords for its operations
https://bugs.webkit.org/show_bug.cgi?id=89351

Reviewed by Eric Seidel.

Source/WebCore:

Generate mutation records inside the parser. This is done by using a
ChildListMutationScope in the ContainerNode::parser* methods and then
adding delivery before each <script> element would be processed by
the parser.

Test: fast/dom/MutationObserver/parser-mutations.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::parserAppendChild):
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::runScript):

LayoutTests:

Add new test mutation records in the parser and fix shadow-dom.html
test since it used setTimeout and sometimes could observe parser
mutations.

* fast/dom/MutationObserver/parser-mutations-expected.txt: Added.
* fast/dom/MutationObserver/parser-mutations.html: Added.
* fast/dom/MutationObserver/shadow-dom-expected.txt:
* fast/dom/MutationObserver/shadow-dom.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. More VS2010 WebKit solution touchups.
roger_fong@apple.com [Fri, 8 Feb 2013 00:34:25 +0000 (00:34 +0000)]
Unreviewed. More VS2010 WebKit solution touchups.

* win/tools/vsprops/common.props:
Move an ignored warning from a project to common properties.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
* WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters:
Make WebKitExports.def.in be treated as a custom build file so that changes to it cause the exports to be rebuilt.

* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters:
Make JavaScriptCoreExports.def.in be treated as a custom build file so that changes to it cause the exports to be rebuilt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix FIXMEs in WindowFeatures.h
haraken@chromium.org [Fri, 8 Feb 2013 00:30:33 +0000 (00:30 +0000)]
Fix FIXMEs in WindowFeatures.h
https://bugs.webkit.org/show_bug.cgi?id=109151

Reviewed by Adam Barth.

1. // FIXME: We can delete this constructor once V8 showModalDialog is
   // changed to use DOMWindow.

This FIXME is not right. The WindowFeatures() constructor is used by
other ports too (e.g. WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp).
So we should remove the FIXME.

2. // FIXME: We can make these functions private non-member functions
   // once V8 showModalDialog is changed to use DOMWindow.

Given that V8 now uses DOMWindow in showModalDialog(), we can make the
methods private.

No tests. No change in behavior.

* page/WindowFeatures.h:
(WebCore):
(WebCore::WindowFeatures::WindowFeatures):
(WindowFeatures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build warning after r142017
commit-queue@webkit.org [Fri, 8 Feb 2013 00:27:31 +0000 (00:27 +0000)]
Fix build warning after r142017
https://bugs.webkit.org/show_bug.cgi?id=109119

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-07
Reviewed by Alexey Proskuryakov.

Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/parser/document-write-noscript.html fails for threaded HTML parser
abarth@webkit.org [Fri, 8 Feb 2013 00:24:31 +0000 (00:24 +0000)]
fast/parser/document-write-noscript.html fails for threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109237

Reviewed by Eric Seidel.

Source/WebCore:

If there are multiple calls to document.write in an external script, we
need to wait for them all to complete before invalidating the
speculative tokens. Instead of doing this when we unwind the
document.write call stack, we do this when we're about to resume
parsing after script execution.

Test: fast/parser/document-write-basic.html

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

LayoutTests:

This tests basic document.write functionality.  There doesn't appear to
be another fast/parser test that covers this basic case (although it's
convered in some more complicated test cases incidentally.)

* fast/parser/document-write-basic-expected.txt: Added.
* fast/parser/document-write-basic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build when compiling with css3-text and css3-conditional-rules feature flags...
commit-queue@webkit.org [Fri, 8 Feb 2013 00:18:14 +0000 (00:18 +0000)]
Fix build when compiling with css3-text and css3-conditional-rules feature flags enabled.
https://bugs.webkit.org/show_bug.cgi?id=109217

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-02-07
Reviewed by Benjamin Poulain.

* css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::collect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r140778): Calendar Picker doesn't open when the element has the required...
tkent@chromium.org [Fri, 8 Feb 2013 00:06:24 +0000 (00:06 +0000)]
REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=109136

Patch by Keishi Hattori <keishi@webkit.org> on 2013-02-07
Reviewed by Kent Tamura.

Source/WebCore:

Calendar picker was using the "Clear" button to calculate the window width.
Since it doesn't exist when the input element has a required attribute,
it was throwing an error. This patch fixes the width calculating logic.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html
       platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html

* Resources/pagepopups/calendarPicker.css:
(.today-clear-area):
* Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
the width. We don't want to use clear button because it doesn't exist
when a value is required.

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Flings should not bubble up to enclosing scrollables when main-thread...
tdanderson@chromium.org [Fri, 8 Feb 2013 00:03:46 +0000 (00:03 +0000)]
[chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling
https://bugs.webkit.org/show_bug.cgi?id=108719

Reviewed by Eric Seidel.

In the event of a main-thread touch fling, dispatch a series of
GestureScrollUpdateWithoutPropagation events defined in
https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
GestureScrollUpdate events) so that the fling does not
propagate to enclosing scrollables.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollBy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNon-scrollable divs and non-scrollable iframes can scroll with touch
tdanderson@chromium.org [Thu, 7 Feb 2013 23:58:15 +0000 (23:58 +0000)]
Non-scrollable divs and non-scrollable iframes can scroll with touch
https://bugs.webkit.org/show_bug.cgi?id=109087

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/events/touch/gesture/touch-gesture-noscroll-div.html
       fast/events/touch/gesture/touch-gesture-noscroll-iframe.html

When finding a candidate for a scrollable node in
EventHandler::handleGestureScrollUpdate(), select the document node
if it is reached before any scrollable element when walking up the DOM
tree. Also ensure that calling RenderLayer::scrollBy() for a document
node does not result in scrolling if the element is not scrollable.

* page/EventHandler.cpp:
(WebCore::closestScrollableNodeCandidate):
(WebCore::EventHandler::handleGestureScrollUpdate):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollBy):

LayoutTests:

Two new layout tests added to demonstrate that the changes to
RenderLayer::scrollBy() and closestScrollableNodeCandidate() in
EventHandler.cpp are both necessary to ensure that non-scrollable
divs and non-scrollable iframes cannot be scrolled with touch.

* fast/events/touch/gesture/touch-gesture-noscroll-div-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-noscroll-div.html: Added.
* fast/events/touch/gesture/touch-gesture-noscroll-iframe-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-noscroll-iframe.html: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-div-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntroduce SQLTransactionBackend and SQLTransactionBackendSync [Part 2].
mark.lam@apple.com [Thu, 7 Feb 2013 23:52:48 +0000 (23:52 +0000)]
Introduce SQLTransactionBackend and SQLTransactionBackendSync [Part 2].
https://bugs.webkit.org/show_bug.cgi?id=109109.

Reviewed by Anders Carlsson.

Adding back the new SQLTransaction and SQLTransactionSync files.

No new tests.

* Modules/webdatabase/SQLTransaction.cpp: Added.
(WebCore::SQLTransaction::create):
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::from):
* Modules/webdatabase/SQLTransaction.h: Added.
(SQLTransaction):
* Modules/webdatabase/SQLTransactionSync.cpp: Added.
(WebCore::SQLTransactionSync::create):
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::from):
* Modules/webdatabase/SQLTransactionSync.h: Added.
(SQLTransactionSync):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntroduce SQLTransactionBackend and SQLTransactionBackendSync.
mark.lam@apple.com [Thu, 7 Feb 2013 23:49:28 +0000 (23:49 +0000)]
Introduce SQLTransactionBackend and SQLTransactionBackendSync.
https://bugs.webkit.org/show_bug.cgi?id=109109.

Reviewed by Anders Carlsson.

- Renamed SQLTransaction and SQLTransactionSync to SQLTransactionBackend
  and SQLTransactionBackendSync respectively.
- Added back SQLTransaction and SQLTransactionSync as new files, and have
  their classes extends their respective backends. This is a stop gap
  measure to keep things working until the front-end and back-end can be
  properly split.
  Note: these files will be committed in a subsequent commit to ensure
  that the patching goes smoothly.
- Where needed, I made use of new SQLTransaction::from() and
  SQLTransactionSync::from() static methods that "get" the front-end
  transactions from the back-ends. This is also a stop gap measure to
  keep things working until the proper refactoring is complete.
- Fixed up pre-existing style checker violations that are now detected
  on code that were touched during my renaming.
- Added the back-end files to all the build files.

No new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/webdatabase/Database.cpp:
(WebCore::Database::scheduleTransactionStep):
* Modules/webdatabase/Database.h:
(Database):
* Modules/webdatabase/DatabaseBackend.h:
(DatabaseBackend):
* Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::DatabaseTransactionTask):
* Modules/webdatabase/DatabaseTask.h:
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::create):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::transaction):
(DatabaseBackendAsync::DatabaseTransactionTask):
* Modules/webdatabase/SQLTransaction.cpp: Removed.
* Modules/webdatabase/SQLTransaction.h: Removed.
* Modules/webdatabase/SQLTransactionBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLTransaction.cpp.
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::~SQLTransactionBackend):
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::enqueueStatement):
(WebCore::SQLTransactionBackend::debugStepName):
(WebCore::SQLTransactionBackend::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransactionBackend::performNextStep):
(WebCore::SQLTransactionBackend::performPendingCallback):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransactionBackend::acquireLock):
(WebCore::SQLTransactionBackend::lockAcquired):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::deliverTransactionCallback):
(WebCore::SQLTransactionBackend::scheduleToRunStatements):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::getNextStatement):
(WebCore::SQLTransactionBackend::runCurrentStatement):
(WebCore::SQLTransactionBackend::handleCurrentStatementError):
(WebCore::SQLTransactionBackend::deliverStatementCallback):
(WebCore::SQLTransactionBackend::deliverQuotaIncreaseCallback):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::deliverSuccessCallback):
(WebCore::SQLTransactionBackend::cleanupAfterSuccessCallback):
(WebCore::SQLTransactionBackend::handleTransactionError):
(WebCore::SQLTransactionBackend::deliverTransactionErrorCallback):
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
* Modules/webdatabase/SQLTransactionBackend.h: Copied from Source/WebCore/Modules/webdatabase/SQLTransaction.h.
(SQLTransactionBackend):
* Modules/webdatabase/SQLTransactionBackendSync.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLTransactionSync.cpp.
(WebCore::SQLTransactionBackendSync::SQLTransactionBackendSync):
(WebCore::SQLTransactionBackendSync::~SQLTransactionBackendSync):
(WebCore::SQLTransactionBackendSync::executeSQL):
(WebCore::SQLTransactionBackendSync::begin):
(WebCore::SQLTransactionBackendSync::execute):
(WebCore::SQLTransactionBackendSync::commit):
(WebCore::SQLTransactionBackendSync::rollback):
* Modules/webdatabase/SQLTransactionBackendSync.h: Copied from Source/WebCore/Modules/webdatabase/SQLTransactionSync.h.
(SQLTransactionBackendSync):
* Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
(WebCore::SQLTransactionCoordinator::processPendingTransactions):
(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):
* Modules/webdatabase/SQLTransactionCoordinator.h:
(SQLTransactionCoordinator):
(WebCore::SQLTransactionCoordinator::SQLTransactionCoordinator):
(CoordinationInfo):
* Modules/webdatabase/SQLTransactionSync.cpp: Removed.
* Modules/webdatabase/SQLTransactionSync.h: Removed.
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add a flag to enable native form validation message
tkent@chromium.org [Thu, 7 Feb 2013 23:45:35 +0000 (23:45 +0000)]
[Chromium] Add a flag to enable native form validation message
https://bugs.webkit.org/show_bug.cgi?id=109134

Reviewed by Adam Barth.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures): Add enableNativeValidationMessage and
isNativeValidationMessageEnabled.
* src/WebRuntimeFeatures.cpp:
(WebKit): Add nativeValidationMessageEnabled.
(WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
(WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
Fill Page::PageClients::validationMessageClient if the flag is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse new speech bubble artwork for captions menu button
dino@apple.com [Thu, 7 Feb 2013 23:42:12 +0000 (23:42 +0000)]
Use new speech bubble artwork for captions menu button
https://bugs.webkit.org/show_bug.cgi?id=109215

Reviewed by Eric Carlson.

Rather than call into RenderTheme to display this button, embed artwork
into the CSS. This means we can remove some uncalled methods in
RenderTheme.

* css/mediaControlsQuickTime.css:
(video::-webkit-media-controls-toggle-closed-captions-button): New background image using SVG.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint): Don't call the specific painter for the CC button.
* rendering/RenderTheme.h: Remove unused function.
* rendering/RenderThemeMac.h: Ditto.
* rendering/RenderThemeMac.mm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Shaders] Add the last blending step
michelangelo@webkit.org [Thu, 7 Feb 2013 23:32:53 +0000 (23:32 +0000)]
[CSS Shaders] Add the last blending step
https://bugs.webkit.org/show_bug.cgi?id=104012

Source/WebCore:

The resulting blended color in mix() is now weighted according to
the original element's backdrop alpha value.

Reviewed by Dean Jackson.

Test: css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html

* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):

LayoutTests:

Added a test to check the correct blending in presence of a transparent backdrop.

Reviewed by Dean Jackson.

* css3/filters/custom/custom-filter-blend-fractional-destination-alpha-expected.html: Added.
* css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html: Added.
* platform/mac/TestExpectations: This test is currently skipped on Mac for slight color
differences, please see the relevant bug: http://webkit.org/b/107487

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix two exports of WebCore symbols on iOS
benjamin@webkit.org [Thu, 7 Feb 2013 23:29:42 +0000 (23:29 +0000)]
Fix two exports of WebCore symbols on iOS
https://bugs.webkit.org/show_bug.cgi?id=109238

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by David Kilzer.

* WebCore.exp.in: Export wkCTFontTransformGlyphs but not
wkCGContextDrawsWithCorrectShadowOffsets on iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Another temporary EWS bot fix. It'll totally work this time.
roger_fong@apple.com [Thu, 7 Feb 2013 23:25:23 +0000 (23:25 +0000)]
Unreviewed. Another temporary EWS bot fix. It'll totally work this time.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Exclusions] Ignore ExclusionPolygon edges above minLogicalIntervalTop
commit-queue@webkit.org [Thu, 7 Feb 2013 23:20:27 +0000 (23:20 +0000)]
[CSS Exclusions] Ignore ExclusionPolygon edges above minLogicalIntervalTop
https://bugs.webkit.org/show_bug.cgi?id=107566

Patch by Hans Muller <hmuller@adobe.com> on 2013-02-07
Reviewed by David Hyatt.

Source/WebCore:

Improve ExclusionPolygon::firstIncludedIntervalLogicalTop() performance by only
creating offset edges for polygon edges that are below the horizontal minLogicalIntervalTop
line. In other words, don't bother creating offset edges that can't define the polygon's
first fit location.

Test: fast/exclusions/shape-inside/shape-inside-first-fit-004.html

* rendering/ExclusionPolygon.cpp:
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Don't create offset edges for polygon edges above minLogicalIntervalTop.

LayoutTests:

Added a simple polygonal shape-inside test where only a subset of the polygon edges
should contribute to each line's offset edges.

* fast/exclusions/shape-inside/shape-inside-first-fit-004-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-first-fit-004.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove logging of MediaPlayerPrivateAVFoundation Notifications.
jer.noble@apple.com [Thu, 7 Feb 2013 23:19:12 +0000 (23:19 +0000)]
Improve logging of MediaPlayerPrivateAVFoundation Notifications.
https://bugs.webkit.org/show_bug.cgi?id=109223

Reviewed by Eric Carlson.

Convert the existing Notification enum to an expandable macro. Then add a
Logging-only function which stringifies the enums.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore):
(WebCore::notificationName):
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd layout test verifying role, subrole, and role description for all HTML elements...
commit-queue@webkit.org [Thu, 7 Feb 2013 23:17:19 +0000 (23:17 +0000)]
Add layout test verifying role, subrole, and role description for all HTML elements and ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=109027

Patch by James Craig <jcraig@apple.com> on 2013-02-07
Reviewed by Chris Fleizach.

New layout test verifies AXRole, AXSubrole, and AXRoleDescription for all HTML elements and ARIA roles.

* platform/mac/accessibility/role-subrole-roledescription-expected.txt: Added.
* platform/mac/accessibility/role-subrole-roledescription.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoObjective-C API: testapi.mm should use ARC
mhahnenberg@apple.com [Thu, 7 Feb 2013 23:11:40 +0000 (23:11 +0000)]
Objective-C API: testapi.mm should use ARC
https://bugs.webkit.org/show_bug.cgi?id=107838

Reviewed by Mark Rowe.

Removing the changes to the Xcode project file and moving the equivalent flags into
the ToolExecutable xcconfig file.

* Configurations/ToolExecutable.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix an incorrect comment from r142163
benjamin@webkit.org [Thu, 7 Feb 2013 22:53:35 +0000 (22:53 +0000)]
Fix an incorrect comment from r142163

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07

* wtf/MainThread.h:
I accidentally copied PLATFORM(IOS) instead of USE(WEB_THREAD) for the #ifdef closing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix syntax error in runtests.py.
roger_fong@apple.com [Thu, 7 Feb 2013 22:52:40 +0000 (22:52 +0000)]
Unreviewed. Fix syntax error in runtests.py.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142182 268f45cc-cd09-0410-ab3c-d52691b4dbfc