Fix a typo per Darin's comment.

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[BlackBerry] Rename InspectorOverlay in blackberry/WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=96689

Reviewed by Antonio Gomes.

Rename to InspectorClientBlackBerry to avoid include problems.

* WebCoreSupport/InspectorClientBlackBerry.h:
* WebKitSupport/InspectorOverlayBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.cpp.
(WebKit):
(BlackBerry::WebKit::InspectorOverlay::create):
(BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
(BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
(BlackBerry::WebKit::InspectorOverlay::paintContents):
(BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
(BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
(BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
(BlackBerry::WebKit::InspectorOverlay::clear):
(BlackBerry::WebKit::InspectorOverlay::update):
* WebKitSupport/InspectorOverlayBlackBerry.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.h.
(WebCore):
(WebKit):
(InspectorOverlay):
(InspectorOverlayClient):
(BlackBerry::WebKit::InspectorOverlay::setClient):
(BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] alter fling animation parameters.
https://bugs.webkit.org/show_bug.cgi?id=96666

Reviewed by Adrienne Walker.

Corrected the test to be non-fragile in the presence of altered fling
curve parameters.

* tests/PlatformGestureCurveTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Text Autosizing: Add explanations to tests.
https://bugs.webkit.org/show_bug.cgi?id=96673

Patch by John Mellor <johnme@chromium.org> on 2012-09-13
Reviewed by Julien Chaffraix.

Replaces some of the lorem ipsum filler text in Text Autosizing tests
with explanations of why the result is expected (and other minor tweaks
to tests).

* fast/text-autosizing/font-scale-factor-expected.html:
* fast/text-autosizing/font-scale-factor.html:
* fast/text-autosizing/narrow-iframe-expected.html:
* fast/text-autosizing/narrow-iframe-flattened-expected.html:
* fast/text-autosizing/narrow-iframe-flattened.html:
* fast/text-autosizing/narrow-iframe.html:
* fast/text-autosizing/nested-em-line-height-expected.html:
* fast/text-autosizing/nested-em-line-height.html:
* fast/text-autosizing/simple-paragraph-expected.html:
* fast/text-autosizing/simple-paragraph.html:
* fast/text-autosizing/span-child-expected.html:
* fast/text-autosizing/span-child.html:
* fast/text-autosizing/various-font-sizes-expected.html:
* fast/text-autosizing/various-font-sizes.html:
* fast/text-autosizing/wide-block-expected.html:
* fast/text-autosizing/wide-block.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add a style guide rule for signed and unsigned int
https://bugs.webkit.org/show_bug.cgi?id=96682

Reviewed by Geoffrey Garen.

Add a rule per http://lists.webkit.org/pipermail/webkit-dev/2012-September/022199.html.

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rename forEachCell to forEachLiveCell
https://bugs.webkit.org/show_bug.cgi?id=96685

Reviewed by Oliver Hunt.

forEachCell actually only iterates over live cells. We should rename it to
reflect what it actually does. This is also helpful because we want to add a new
forEachCell that actually does iterate each and every cell in a MarkedBlock
regardless of whether or not it is live.

* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* heap/Heap.cpp:
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
* heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::forEachLiveCell):
* heap/MarkedSpace.h:
(MarkedSpace):
(JSC::MarkedSpace::forEachLiveCell):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::releaseExecutableMemory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[BlackBerry] ResourceRequest string optimizations
https://bugs.webkit.org/show_bug.cgi?id=96661

Reviewed by Rob Buis.

RIM PR# 207965.
Call PlatformRequest's method to add the Accept-Language header.

No new tests as no functional change.

* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, rolling out r128489.
http://trac.webkit.org/changeset/128489
https://bugs.webkit.org/show_bug.cgi?id=96686

Does not compile on windows (Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebCore:

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::registerFrontendCallbacks):
(WebCore):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::close):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:
(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::unregisterDatabase):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
(IDBDatabaseCallbacksImpl):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
* Modules/indexeddb/IDBFactoryBackendInterface.h:
(IDBFactoryBackendInterface):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::onSuccess):
* Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):

Source/WebKit/chromium:

* public/WebIDBDatabase.h:
* public/WebIDBFactory.h:
(WebIDBFactory):
* src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
* src/IDBCallbacksProxy.h:
(WebKit):
(IDBCallbacksProxy):
* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):
(WebKit):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::open):
* src/IDBFactoryBackendProxy.h:
(IDBFactoryBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):
(WebKit::WebIDBDatabaseImpl::open):
(WebKit):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:
(WebIDBFactoryImpl):
* tests/IDBAbortOnCorruptTest.cpp:
(WebCore::TEST):
* tests/IDBDatabaseBackendTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

One more unreviewed trivial fix after r128399.

* BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Refactor duplicate code into RenderFlexibleBox::mainAxisContentExtent
https://bugs.webkit.org/show_bug.cgi?id=96676

Reviewed by Eric Seidel.

There was computeAvailableFreeSpace() and lineBreakLength() shared some very similar code.
Merge this code into mainAxisContentExtent().

No new tests, this is just a refactor.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisContentExtent): Take contentLogicalHeight as a parameter,
which is needed when determining the logical height.
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Use mainAxisContentExtent() and inline.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Use mainAxisContentExtent().
* rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed trivial fix after r128399.

* BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
(getLatestSVNRevision):
(waitForSVNRevision):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add new accelerated compositing for overflow scroll setting.
https://bugs.webkit.org/show_bug.cgi?id=95885

Patch by Glenn Hartmann <hartmanng@chromium.org> on 2012-09-13
Reviewed by James Robinson.

wkb.ug/91117 introduces RenderLayer::usesCompositedScrolling(), which
currently returns true if we're overflow scrolling and the element has
been styled with '-webkit-overflow-scrolling: touch'. If this is true,
we get promoted to a composited layer, the associated RenderLayerBacking
gets special scrolling layers and in response to RenderLayer::scrollTo()
we no longer have to invalidate everything to get the scrolled content
in the right spot, thereby avoiding very expensive repaints. It's
unfortunate that we require -webkit-overflow-scrolling: touch, though.
It would be nice if RenderLayer::usesCompositedScrolling() returned true
if the page would continue to behave correctly.  This is what
wkb.ug/94743 is intended to do.  Unfortunately, when we become a
composited layer, we switch from subpixel to grayscale anti-aliasing. We
only want to auto-opt into composited scrolling if we don't mind the
change in anti-aliasing, so we need a flag to enable/disable this
feature.

Source/WebCore:

No new tests -- no change in behaviour.

* page/Settings.h:
(WebCore::Settings::setAcceleratedCompositingForOverflowScrollEnabled):
(WebCore::Settings::acceleratedCompositingForOverflowScrollEnabled):
(Settings):

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedCompositingForOverflowScrollEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
https://bugs.webkit.org/show_bug.cgi?id=96366

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-13
Reviewed by Anders Carlsson.

Source/WebKit2:

Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
by calling shouldClose() on the FrameLoader.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCallShouldCloseOnWebView):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Tools:

Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
by calling shouldClose() on the FrameLoader.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::callShouldCloseOnWebView):
(WTR):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):

LayoutTests:

Unskip passing test fast/events/onbeforeunload-focused-iframe.html

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, rolling out r128453.
http://trac.webkit.org/changeset/128453
https://bugs.webkit.org/show_bug.cgi?id=96681

Having tests use the same appcache directory leads to timeouts
(Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::clearMemoryCache):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

IndexedDB: Consolidate two-phase connection to avoid race conditions
https://bugs.webkit.org/show_bug.cgi?id=90411

Reviewed by Tony Chang.

Source/WebCore:

Previously, IDB connections were opened by having the front-end (1) call through to
a back-end open() method, eventually receive a success message with a back-end object
handle, and (2) call into the back-end object to register front-end callbacks. This left
the back-end's notion of an open connection in a limbo state between these two calls.
In multi-process ports, a crash of the front-end process could leave the back-end wedged
waiting for this second call (e.g. can't delete until all connections are closed).

Simplify this by having the front-end pass through the callbacks into the back-end
during the initial open() call, which eliminates the limbo state.

No new tests - no functional changes. Chromium port's webkit_unit_tests updated.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase): Db-callbacks is available at creation time.
(WebCore::IDBDatabase::~IDBDatabase):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create): Need to track db-callbacks as well.
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create): Ditto.
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(IDBDatabaseBackendImpl::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount): Don't need to count limbo connections any more.
(WebCore::IDBDatabaseBackendImpl::processPendingCalls): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnection): No more limbo connections (yay!).
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion): Ditto.
(WebCore::IDBDatabaseBackendImpl::deleteDatabase): Style.
(WebCore::IDBDatabaseBackendImpl::close): Resolve FIXME about connectionCount.
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:
(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::connect):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
(IDBDatabaseCallbacksImpl):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open): Mint the db-callbacks here...
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open): ...passed through to here...
* Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
* Modules/indexeddb/IDBFactoryBackendInterface.h:
(IDBFactoryBackendInterface):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create): ...all the way to here...
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded): ...and finally hooked up here.
(WebCore::IDBOpenDBRequest::onSuccess): (or here, if no upgrade needed).
* Modules/indexeddb/IDBOpenDBRequest.h:
(WebCore):
(IDBOpenDBRequest):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort): Tweak event/notification ordering; the
notifying the database that the transaction is finished may unblock closing,
which fires more events, and the delivery matters. Previously the close would
be blocked by the transaction which gave the desired order.
(WebCore::IDBTransaction::onComplete): Ditto.
* inspector/InspectorIndexedDBAgent.cpp: New hookup logic.
(WebCore):

Source/WebKit/chromium:

API plumbing for simplified single-phase connection opening, and tests updated
to exercise the new APIs.

* public/WebIDBDatabase.h:
(WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API.
* public/WebIDBFactory.h:
(WebKit):
(WebIDBFactory):
(WebKit::WebIDBFactory::open): New overload that takes db-callbacks.
* src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier.
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
(WebKit):
(WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to
the db-callbacks and hook it up when the onSuccess callback comes through.
* src/IDBCallbacksProxy.h:
(WebKit):
(IDBCallbacksProxy):
* src/IDBDatabaseBackendProxy.cpp:
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::open):
* src/IDBFactoryBackendProxy.h:
(IDBFactoryBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:
(WebIDBFactoryImpl):
* tests/IDBAbortOnCorruptTest.cpp:
(FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::create):
(WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
(WebCore):
(WebCore::TEST): Updated connection sequence.
* tests/IDBDatabaseBackendTest.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
https://bugs.webkit.org/show_bug.cgi?id=96678

Reviewed by Dirk Pranke.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Flexitem margins should be based on content width, not width
https://bugs.webkit.org/show_bug.cgi?id=96674

Reviewed by Ojan Vafai.

Source/WebCore:

Margins should be based on content width. Also remove some calls to
mainAxisContentExtent() when we can use contentLogicalWidth instead.

Tests: css3/flexbox/percent-margins.html has a new testcase.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild): Use contentLogicalWidth instead of
passing in the maximum value (only used in the width case).
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Don't pass in mainAxisContentExtent.
(WebCore::RenderFlexibleBox::computeChildMarginValue): Use contentLogicalWidth and simplify the code.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Remove unnecessary mainAxisContentExtent() call.
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax): Remove unnecessary flexboxAvailableContentExtent.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Remove unnecessary mainAxisContentExtent() call.
(WebCore::RenderFlexibleBox::resolveFlexibleLengths): Remove unnecessary mainAxisContentExtent() call.
* rendering/RenderFlexibleBox.h: Remove unnecessary params.

LayoutTests:

Add a test case where contentWidth != width.

* css3/flexbox/percent-margins-expected.txt:
* css3/flexbox/percent-margins.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL] Assertion reached on RenderThemeEFL when setting a theme to an invalid path
https://bugs.webkit.org/show_bug.cgi?id=96649

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Keep the consistence by restoring the reference to the old theme path
when the new one cannot be loaded.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::setThemePath):

Source/WebKit2:

Updated the alternative test theme file. It is basically
the default theme with extra padding on the button widget as
specified by the comments on the test case.

* UIProcess/API/efl/tests/resources/big_button_theme.edj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, warning fix left over from r128456 (bug 96645)

Patch by Antonio Gomes <agomes@rim.com> on 2012-09-13

* Api/InRegionScroller.cpp:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] alter fling animation parameters.
https://bugs.webkit.org/show_bug.cgi?id=96666

Reviewed by Adrienne Walker.

Adjusted configuration parameters for fling animation to have a longer
tail and more similarity between touchpad and touchscreen.

Covered by existing tests.

* platform/TouchFlingPlatformGestureCurve.cpp:
(WebCore::TouchFlingPlatformGestureCurve::createForTouchPad):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchScreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

IndexedDB: Properties of IDBKeyRange should default to undefined
https://bugs.webkit.org/show_bug.cgi?id=96401

Reviewed by Adam Barth.

Source/WebCore:

Per the IndexedDB spec, properties of IDBKeyRange should be |undefined| if
not set (i.e. range.upper if created with lowerBound(), and vice versa), rather
than null.

Test: storage/indexeddb/keyrange.html

* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8): Since IDBKeyRange is the only place where possibly-null
keys are returned to script, change the JS value from null to undefined.
And call v8Undefined(). It's faster.
* bindings/js/custom/JSIDBKeyCustom.cpp:
(WebCore::toJS): Ditto.

LayoutTests:

Update test expectations.

* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/resources/keyrange.js:
(checkLowerBoundKeyRange):
(checkUpperBoundKeyRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed changes to watchlist.

- Add myself to BlackBerry bugs

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add an SVG entry to the watchlist

Unreviewed config change.

* Scripts/webkitpy/common/config/watchlist:
- Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
- Added myself and pdr as watchers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Continue to send mouse move events to a non-scrollable page
even if they are not consumed.
PR #207024
https://bugs.webkit.org/show_bug.cgi?id=96655

Patch by Genevieve Mak <gmak@rim.com> on 2012-09-13
Reviewed by Antonio Gomes.

* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::isMainFrameScrollable):
(WebKit):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Refactor paint overflow clipping
https://bugs.webkit.org/show_bug.cgi?id=96625

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-09-13
Reviewed by Simon Fraser.

The same logic for applying overflow clipping based on the cached size of a
RenderBox has been duplicated to four different places. Consolidate them to a
single RenderBox utility function.

This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=96087.

No new functionality; covered by existing tests.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):
(WebCore):
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[BlackBerry] Missing conditions in InRegionScrollerPrivate::canScrollRenderBox
https://bugs.webkit.org/show_bug.cgi?id=96660

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 207884
According to RenderBox::canBeScrolledAndHasScrollableArea(), we should
bail out early in InRegionScrollerPrivate::canScrollRenderBox() if the
RenderBox's scroll height equals the client height and the scroll width
equals the client width. Otherwise, we will miss the conditions.

* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Another prospective Qt/Windows build fix: Add missing CString.h include.

* platform/qt/UserAgentQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Stop shuttling PseudoId from StyleResolver to SelectorChecker.
https://bugs.webkit.org/show_bug.cgi?id=96431

Reviewed by Eric Seidel.

SelectorChecker retained extra state to store the PseudoId value of the element. It was sad, because we needed to explicitly maintain its integrity. Instead, we now just make it part of StyleResolver and feed to SelectorChecker as part of SelectorCheckingContext.

No new tests, refactoring only. Covered by existing tests.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::SelectorChecker): Removed state initializer.
(WebCore::SelectorChecker::checkSelector): Changed to look into context, rather than own member.
* css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): Added pseudoStyle as parameter.
(SelectorCheckingContext): Added pseudoStyle as member.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Changed to look at own member, rather than m_checker.
* css/StyleResolver.h:
(StyleResolver): Added new member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed prospective Qt/MSVC build fix.

* platform/qt/UserAgentQt.cpp:
(WebCore::UserAgentQt::standardUserAgent): Try to make the conversion from the 8-bit
String to a QLatin1String successful.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[WK2] LayerTreeCoordinator should release unused UpdatedAtlases
https://bugs.webkit.org/show_bug.cgi?id=95072

Reviewed by Jocelyn Turcotte.

Release graphic buffers that haven't been used for a while in order to save memory.
This way we can give back memory to the system when no user interaction happens
after a period of time, for example when we are in the background.

* Shared/ShareableBitmap.h:
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
(WebKit):
(WebKit::LayerTreeCoordinator::scheduleReleaseInactiveAtlases):
(WebKit::LayerTreeCoordinator::releaseInactiveAtlasesTimerFired):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
* WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::didSwapBuffers):
Don't call buildLayoutIfNeeded here. It's enought to call it in beginPaintingOnAvailableBuffer
and this way we can track whether this atlas is used with m_areaAllocator.
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/UpdateAtlas.h:
(WebKit::UpdateAtlas::addTimeInactive):
(WebKit::UpdateAtlas::isInactive):
(WebKit::UpdateAtlas::isInUse):
(UpdateAtlas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt][WK2] fast/forms/access-key-for-all-elements.html fails
https://bugs.webkit.org/show_bug.cgi?id=73917

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-09-13
Reviewed by Simon Hausmann.

Access-key tests were failing due to hardcoded Mac OS X in the
Qt WK2 user agent string. This commit moves the WK1 implementation
to a shared one to be used by both versions.

Source/WebCore:

Adds the shared user agent implementation.

* Target.pri:
* platform/qt/UserAgentQt.cpp: Added.
(WebCore):
(WebCore::UserAgentQt::standardUserAgent):
* platform/qt/UserAgentQt.h: Added.
(WebCore):
(UserAgentQt):

Source/WebKit/qt:

Change QWebPage to use the shared user agent implementation.

* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):

Source/WebKit2:

Use the shared implementation instead of hardcoding the user agent.

* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::standardUserAgent):

LayoutTests:

Unskip now passing tests.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[BlackBerry] Page Popup for Month is non-functional.
https://bugs.webkit.org/show_bug.cgi?id=96651

Patch by Jessica Cao <jecao@rim.com> on 2012-09-13
Reviewed by Rob Buis.

Hook up support for Month popup.

* WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::generateHTML):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[CMake] Remove some redundant warning flags and enable a few more warnings.
https://bugs.webkit.org/show_bug.cgi?id=96654

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

* Source/cmake/WebKitHelpers.cmake: Remove a few warning flags
which are already enabled by -Wall and -Wextra, remove -W which
looks useless and also enable a few more warnings by removing
their -Wno-foo counterparts which were present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL] Use RefPtr for storing cairo_surface_t
https://bugs.webkit.org/show_bug.cgi?id=96647

Reviewed by Simon Hausmann.

Refactoring, covered by existing tests.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::createSurfaceForBackingStore):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::reuse):
(WebCore::RenderThemeEfl::paintThemePart):
* platform/efl/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::surface):
(ThemePartCacheEntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Move updateHoverActiveState to Document.
https://bugs.webkit.org/show_bug.cgi?id=95858

Reviewed by Antonio Gomes.

RenderLayer::updateHoverActiveState contains the logic that updates hover and active states based on
hit-tests, but hover and active states are document states, and does have any relation to layers other
than documents having atleast one layer.

By moving the function it will be in the same place as other active/hover state maintainace, and we avoid
excessive updates of the state from hit-testing flow threads.

* dom/Document.cpp:
(WebCore::commonAncestor):
(WebCore::Document::updateHoverActiveState):
* dom/Document.h:
(Document):
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEventForKey):
* rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::nodeAtPoint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
* rendering/RenderLayer.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::hitTest):
* rendering/RenderView.h:
(RenderView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL][WK2] Gardening after r128393
https://bugs.webkit.org/show_bug.cgi?id=96640

Unreviewed gardening.

Corrected expectations for the following files:
fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
fast/dom/HTMLAnchorElement/anchor-download.html

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-13

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Make WebKit2 work on Windows with Qt 5
https://bugs.webkit.org/show_bug.cgi?id=76776

Reviewed by Tor Arne Vestbø.

WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
that for the GL TextureMapper (it's only built when that feature is set).

* qmake/mkspecs/features/configure.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Ensure that QT is finalized before loading qt_module.prf

As qt_module.prf does dependency tracking based on the content of the
QT variable. The intermediate WebKit modules modify the variable in
their .pri files, so we have to ensure we've loaded all the modules
before loading qt_module.

Reviewed by Tor Arne Vestbø.
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL] Remove a lot of C'ism from Ewk_Tiled_Backing_Store
https://bugs.webkit.org/show_bug.cgi?id=96631

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Remove a lot of C'ism from Ewk_Tiled_Backing_Store and
fix coding style.

* ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_updates_process):
(_ewk_tiled_backing_store_flush):
(_ewk_tiled_backing_store_tile_new):
(_ewk_tiled_backing_store_item_resize):
(_ewk_tiled_backing_store_tile_associate):
(_ewk_tiled_backing_store_tile_dissociate):
(_ewk_tiled_backing_store_tile_dissociate_all):
(_ewk_tiled_backing_store_pre_render_request_add):
(_ewk_tiled_backing_store_pre_render_request_del):
(_ewk_tiled_backing_store_pre_render_request_first):
(_ewk_tiled_backing_store_pre_render_request_clear):
(_ewk_tiled_backing_store_pre_render_request_process_single):
(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_disable_render):
(_ewk_tiled_backing_store_enable_render):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):
(_ewk_tiled_backing_store_item_smooth_scale_set):
(_ewk_tiled_backing_store_changed):
(_ewk_tiled_backing_store_view_cols_end_del):
(_ewk_tiled_backing_store_view_cols_end_add):
(_ewk_tiled_backing_store_view_row_del):
(_ewk_tiled_backing_store_view_rows_range_del):
(_ewk_tiled_backing_store_view_rows_all_del):
(_ewk_tiled_backing_store_smart_member_del):
(_ewk_tiled_backing_store_smart_member_add):
(_ewk_tiled_backing_store_mem_dbg):
(_ewk_tiled_backing_store_sig_usr):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_del):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_smart_calculate_size):
(_ewk_tiled_backing_store_view_dbg):
(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_wrap_right):
(_ewk_tiled_backing_store_view_refill):
(_ewk_tiled_backing_store_view_pos_apply):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(_ewk_tiled_backing_store_smart_calculate_pos):
(_ewk_tiled_backing_store_fill_renderers):
(_ewk_tiled_backing_store_smart_calculate):
(ewk_tiled_backing_store_render_cb_set):
(ewk_tiled_backing_store_tile_unused_cache_get):
(_ewk_tiled_backing_store_scroll_full_offset_set_internal):
(ewk_tiled_backing_store_scroll_full_offset_set):
(ewk_tiled_backing_store_scroll_full_offset_add):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_set):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_fix_offsets):
(ewk_tiled_backing_store_zoom_weak_smooth_scale_set):
(ewk_tiled_backing_store_alpha_set):
(ewk_tiled_backing_store_update):
(ewk_tiled_backing_store_updates_process_pre_set):
(ewk_tiled_backing_store_updates_process_post_set):
(ewk_tiled_backing_store_disabled_update_set):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_tile_add):
(ewk_tiled_backing_store_pre_render_spiral_queue):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):
(ewk_tiled_backing_store_pre_render_cancel):
(ewk_tiled_backing_store_disable_render):
(ewk_tiled_backing_store_enable_render):
* ewk/ewk_tiled_backing_store_private.h:
(_Ewk_Tile_Stats):
(_Ewk_Tile):
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_render_cb):
(_ewk_view_tiled_smart_backing_store_add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed fix for: REGRESSION(r128451): It broke inspector/profiler/memory-instrumentation-cached-images.html
https://bugs.webkit.org/show_bug.cgi?id=96653

* inspector/profiler/memory-instrumentation-cached-images.html:
* inspector/profiler/memory-instrumentation-cached-images-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

REGRESSION: hit test doesn't take iframe scroll position into account
https://bugs.webkit.org/show_bug.cgi?id=96541

Source/WebCore:

Reviewed by Antonio Gomes.

Convert the coordinate correctly by taking scroll position plus frame
borders and padding into account.

Test: fast/events/touch/touch-inside-iframe-scrolled.html

* rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::nodeAtPoint):

LayoutTests:

Reviewed by Antonio Gomes.
Test written by Rick Byers.

Test that scroll position is taken into account in hit testing.

* fast/events/touch/resources/touch-inside-iframe-scrolled2.html: Added.
* fast/events/touch/touch-inside-iframe-scrolled-expected.txt: Added.
* fast/events/touch/touch-inside-iframe-scrolled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
https://bugs.webkit.org/show_bug.cgi?id=96633

Reviewed by Csaba Osztrogonác.

WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
It's the usual problem and the usual solution is to rename one of the conflicting files.
This patch chooses to rename DRT instead of WTR and MBR.

Fixed include order at the same time to match style guide.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
(messageHandler):
(isOption):
(takeOptionValue):
(printUsage):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

The Script run-launcher should support -2 in combination with --efl
https://bugs.webkit.org/show_bug.cgi?id=96639

Reviewed by Simon Hausmann.

Support running the MiniBrowser then supplied -2 as argument.

* Scripts/run-launcher:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Fix build of WTR and the QML2 plugin on Windows
https://bugs.webkit.org/show_bug.cgi?id=96652

Reviewed by Tor Arne Vestbø.

Some components that we build such as WTR or the QML2 plugin include
WebKit2 header files as well as WebKit2's config.h. Only the include
paths of WebKit2 are required for that at the moment (WEBKIT +=
webkit2). Only on Windows WebKit2's config.h also includes
WebCore/config.h, which in turn requires to have WebCore/platform in
your include search path. That in turn means that any component that
wants to use WebKit2 headers also needs the WebCore headers, but only
one Windows. It turns out that for the Qt build we don't need it, so
skip it in our configuration and make the include path requirement
the same across all the platforms we build.

* config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, add my Intel email address to the list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt][WK2] REGRESSION(r128245): It made zillion API tests fail
https://bugs.webkit.org/show_bug.cgi?id=96531

Reviewed by Jocelyn Turcotte.

Preferences have to be updated after the drawing area was created
for compositing mode to be set.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[BlackBerry] ASSERT failure in InRegionScrollableArea::InRegionScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=96645
PR #207307

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

We use canScrollRenderBox to promote the layer as scrollable instead
of RenderBox::canScrollAndHasScrollableArea (see comment above the former).
We should assert against the former as well.

* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
* Api/InRegionScroller_p.h:
(WebCore):
(InRegionScrollerPrivate):
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS

Reviewed by Ossy.

* qmake/mkspecs/features/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL][DRT] Implement LayoutTestController::layerTreeAsText
https://bugs.webkit.org/show_bug.cgi?id=82294

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Add a support method for getting layerTreeAsText.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::layerTreeAsText):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.

* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::layerTreeAsText):

LayoutTests:

The tests are no longer failing because of missing layerTreeAsText
but due to accelerated compositing not being enabled.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] Clear application cache between tests in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=96543

Reviewed by Philippe Normand.

Source/WebKit/gtk:

Add a method to the DumpRenderTreeSupportGtk class that upon calling
clears the application cache and vacuums the database file.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::clearApplicationCache):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

Call the new DumpRenderTreeSupportGtk method to clear application cache
after each test.

Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
as well. Currently it points to a subdirectory in the layout tests results
directory. At least on the builders this ensures an empty cache directory
with each test run.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed GTK gardening.

Specifying a few slow tests on the debug configuration that pass
when given sufficient time to do so.

Branching expectations for three spellcheck test failures, on release
configuration they time out while on the debug configuration they
have enough time to fail.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: NMI: remove the dependency of platform sources from WebCore header introduced by NMI instrumentation.
https://bugs.webkit.org/show_bug.cgi?id=96367

Reviewed by Yury Semikhatsky.

the target is to move 'platform' specific instrumentation code
from WebCoreMemoryInstrumentation into the new PlatformMemoryInstrumentation.

Drive by fix: New type DOM.Image was introduced.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryTypes):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
* platform/KURL.cpp:
* platform/KURLGoogle.cpp:
* platform/PlatformMemoryInstrumentation.cpp: Copied from Source/WebCore/platform/graphics/GeneratedImage.cpp.
(WebCore):
* platform/PlatformMemoryInstrumentation.h: Copied from Source/WebCore/platform/graphics/GeneratedImage.cpp.
(WebCore):
(PlatformMemoryTypes):
* platform/SharedBuffer.cpp:
* platform/TreeShared.h:
(WebCore::TreeShared::reportMemoryUsage):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratorGeneratedImage.h:
* platform/graphics/Image.cpp:
(WebCore::Image::reportMemoryUsage):
* platform/network/FormData.cpp:
(WebCore::FormData::reportMemoryUsage):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file

Unless it's actually a dependency of the public QtWebKit API.

We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
files with their _PRIVATE equivivalent, but that's likely to break when
someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
clean up the variables in default_post.

This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
longer needed, as it was a workaround for the intermediate libraries ending
up in the prl file. And, since CONFIG -= staticlib was there to support
the explicitlib option, we can remove that too (as well as the exception
for gprof, since it would be empty). If gprof needs tweaks to always link
statically they should go in gprof.prf.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Fix UIProcess build with Qt on Windows
https://bugs.webkit.org/show_bug.cgi?id=96635

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-13
Reviewed by Csaba Osztrogonác.

Enabling setShouldCloseConnectionOnProcessTermination on the connection
is something that is only implemented in ConnectionUnix, not
ConnectionWin.cpp, where appears to be built-in functionality.

* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: NMI: instrument KURL directly.
https://bugs.webkit.org/show_bug.cgi?id=96624

Reviewed by Yury Semikhatsky.

I replaced traits based instrumentation of KURL with reportMemoryUsage functions.
CString* were also instrumented.

Drive by fix: Instrumentation code in QualifiedName was moved to cpp.

Source/WebCore:

* bindings/v8/V8DOMMap.h:
* dom/Attribute.h:
* dom/QualifiedName.cpp:
(WebCore::QualifiedName::reportMemoryUsage):
(WebCore):
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
* dom/QualifiedName.h:
(QualifiedNameImpl):
(QualifiedName):
* dom/WebCoreMemoryInstrumentation.cpp:
* dom/WebCoreMemoryInstrumentation.h:
(WebCore):
* platform/KURL.cpp:
(WebCore::KURL::reportMemoryUsage):
(WebCore):
* platform/KURL.h:
(KURL):
* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::reportMemoryUsage):
* platform/KURLGooglePrivate.h:
(KURLGooglePrivate):
* platform/KURLWTFURLImpl.h:
(KURLWTFURLImpl):
(WebCore::KURLWTFURLImpl::reportMemoryUsage):

Source/WebKit/chromium:

* tests/MemoryInstrumentationTest.cpp:
(WebCore):
(InstrumentedOwner):
(WebCore::InstrumentedOwner::InstrumentedOwner):
(WebCore::InstrumentedOwner::reportMemoryUsage):
(WebCore::TEST):

Source/WTF:

* wtf/text/CString.h:
(CStringBuffer):
(WTF::CStringBuffer::reportMemoryUsage):
(CString):
(WTF::CString::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=96632

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-13
Reviewed by Carlos Garcia Campos.

Fix this by using atk_object_get_n_accessible_children instead of
calling getChildren() from childCount.

* WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
(WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
loop by using atk_object_get_n_accessible_children().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL] Gardening after r128375, r128431
https://bugs.webkit.org/show_bug.cgi?id=96630

Unreviewed gardening.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-13

* platform/efl/TestExpectations: Unskip fast/overflow/overflow-height-float-not-removed-crash.html.
* platform/efl/fast/table/height-percent-test-vertical-expected.png: Rebase.
* platform/efl/fast/table/height-percent-test-vertical-expected.txt: Ditto.
* platform/efl/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added. Rebase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt][WK2] New fast/forms/number/number-spinbutton-click-in-iframe.html fails
https://bugs.webkit.org/show_bug.cgi?id=96634

Unreviewed gardening.

* platform/qt-5.0-wk2/Skipped: skip the failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Unreviewed gardening.

* platform/qt/Skipped: Unskip a now passing test, and add a missing URL.
* platform/qt/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Unreviewed gardening. Rebaseline after 128433. It hasn't been updated correctly in the previous revision.

* platform/qt/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Update binding test expectation for trac.webkit.org/changeset/128400
https://bugs.webkit.org/show_bug.cgi?id=91933

* bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64Array::getOwnPropertySlotByIndex):
(WebCore::JSFloat64Array::putByIndex):
* bindings/scripts/test/JS/JSFloat64Array.h:
(JSFloat64Array):
* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(JSTestActiveDOMObject):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlotByIndex):
(WebCore):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(JSTestCustomNamedGetter):
* bindings/scripts/test/JS/JSTestEventConstructor.h:
(JSTestEventConstructor):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertySlotByIndex):
* bindings/scripts/test/JS/JSTestEventTarget.h:
(JSTestEventTarget):
* bindings/scripts/test/JS/JSTestException.h:
(JSTestException):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterface::putByIndex):
(WebCore):
* bindings/scripts/test/JS/JSTestInterface.h:
(JSTestInterface):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(JSTestMediaQueryListListener):
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
(JSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestNode.h:
(JSTestNode):
* bindings/scripts/test/JS/JSTestObj.h:
(JSTestObj):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(JSTestSerializedScriptValueInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=96628

* platform/chromium/TestExpectations:
calculate-order.html is flaky on Lion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Fix qdoc executable preparation

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
Reviewed by Tor Arne Vestbø.

* docs/docs.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Fllow rename of qt_module_config.prf to qt_module.prf

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
Reviewed by Tor Arne Vestbø.

* Source/api.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Fix build against namespaced Qt

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
Reviewed by Tor Arne Vestbø.

* UIProcess/qt/PageViewportControllerClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Test expectation update

* platform/chromium/TestExpectations:
sandboxed-iframe-navigation-parent.html is slow on Lion too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL][Qt][WK2] Implement shared undo controller for EFL and Qt port.
https://bugs.webkit.org/show_bug.cgi?id=92504

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

EFL port needs an undo controller similiar to one from Qt port. Instead of
duplicating the code existing class was renamed and moved to UIProcess
directory.

* PlatformEfl.cmake:
* Target.pri:
* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):
* UIProcess/API/efl/PageClientImpl.h:
(PageClientImpl):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/DefaultUndoController.cpp: Renamed from Source/WebKit2/UIProcess/qt/QtWebUndoController.cpp.
(WebKit):
(WebKit::DefaultUndoController::registerEditCommand):
(WebKit::DefaultUndoController::clearAllEditCommands):
(WebKit::DefaultUndoController::canUndoRedo):
(WebKit::DefaultUndoController::executeUndoRedo):
* UIProcess/DefaultUndoController.h: Renamed from Source/WebKit2/UIProcess/qt/QtWebUndoController.h.
(WebKit):
(DefaultUndoController):
* UIProcess/qt/QtPageClient.cpp:
(WebKit::QtPageClient::initialize):
* UIProcess/qt/QtPageClient.h:
(WebKit):
(QtPageClient):

LayoutTests:

Unskip the editing/undo category now that the tests are passing. Also add
missing expected results.

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/Skipped:
* platform/efl/editing/undo/4063751-expected.txt: Added.
* platform/efl/editing/undo/5378473-expected.txt: Added.
* platform/efl/editing/undo/redo-typing-001-expected.txt: Added.
* platform/efl/editing/undo/undo-combined-delete-boundary-expected.txt: Added.
* platform/efl/editing/undo/undo-combined-delete-expected.txt: Added.
* platform/efl/editing/undo/undo-delete-boundary-expected.txt: Added.
* platform/efl/editing/undo/undo-delete-expected.txt: Added.
* platform/efl/editing/undo/undo-forward-delete-boundary-expected.txt: Added.
* platform/efl/editing/undo/undo-forward-delete-expected.txt: Added.
* platform/efl/editing/undo/undo-misspellings-expected.txt: Added.
* platform/efl/editing/undo/undo-typing-001-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt][Win] Enable USE(3D_GRAPHICS)
https://bugs.webkit.org/show_bug.cgi?id=90879

Reviewed by Kenneth Rohde Christiansen.

Enable it on Windows as well as on QNX (bug fixed).

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Tests] We should have tests for preserving/resetting values of input type "time" after browser navigation
https://bugs.webkit.org/show_bug.cgi?id=96595

Reviewed by Kent Tamura.

This patch adds two tests for preserving/resetting values input type
"time" with multiple fields input UI after page reload, backward and
forward browser navigation.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Added for checking value is preserved after history backward and forward navigation.
* fast/forms/time-multiple-fields/time-multiple-fields-reset-value-after-reload-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-reset-preserve-value-after-reload.html: Added for checking values are resetted after page reload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Unreviewed gardening. Skip a failing test. Added platform specific expectations after r128375.

* platform/qt/Skipped: After r128400.
* platform/qt/fast/table/height-percent-test-vertical-expected.txt: Added r128375.
* platform/qt/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added r128375..

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL] Gardening after r128270, r128400, r128389, r128393, r128274
https://bugs.webkit.org/show_bug.cgi?id=96613

Unreviewed gardening.

Adding failing test to TestExpectations.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-13

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL] REGRESSION (r128274): fast/overflow/overflow-height-float-not-removed-crash.html
https://bugs.webkit.org/show_bug.cgi?id=96619

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

ThemePartCacheEntry::create() can return '0' if creation fails, this was not checked
while Theme Part cache populating. A NULL pointer was dereferenced then causing crash.

Test: fast/overflow/overflow-height-float-not-removed-crash.html.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::getThemePartFromCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
https://bugs.webkit.org/show_bug.cgi?id=96359

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-13
Reviewed by Tor Arne Vestbø.

GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
lexer. The only viable alternative I could find on Windows that provides
binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
so let's use that one instead.

Source/ThirdParty/ANGLE:

* DerivedSources.pri:

Tools:

* Scripts/webkitdirs.pm:
(checkRequiredSystemConfig):
* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] syncqt isn't re-run when WebKit1.pro changes and we're building with --no-webkit2
https://bugs.webkit.org/show_bug.cgi?id=96545

Reviewed by Tor Arne Vestbø.

Do the QMAKE_INTERNAL_INCLUDED_FILES trick separately for WebKit1.pro and WebKit2/Target.pri,
depending on build?(webkit1) and build?(webkit2), as discussed earlier.

* Source/api.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt][Win] REGRESSION(r128400): It broke the build
https://bugs.webkit.org/show_bug.cgi?id=96617

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-09-13
Reviewed by Simon Hausmann.

Source/JavaScriptCore:

Changed "JSC::Array" to "JSC::ArrayClass" because it's not used often enough
for the brevity to be beneficial, and because "Array" causes too much namespace
pollution.

* runtime/IndexingType.h:
(JSC):
* runtime/JSArray.cpp:
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
(JSC::JSArray::compactForSorting):
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::putByIndex):
(JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::getOwnPropertyDescriptor):
* runtime/JSObject.h:
(JSC::JSObject::getArrayLength):
(JSC::JSObject::getVectorLength):
(JSC::JSObject::canGetIndexQuickly):
(JSC::JSObject::canSetIndexQuickly):
(JSC::JSObject::inSparseIndexingMode):
(JSC::JSObject::ensureArrayStorage):

Source/WebCore:

* bridge/runtime_array.h:
(JSC::RuntimeArray::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: CSS domain sends events while it is not enabled
https://bugs.webkit.org/show_bug.cgi?id=96615

Reviewed by Yury Semikhatsky.

The CSS agent is put into and removed from the instrumenting agents set upon enable() and disable(), respectively.

Tests will be shortly landed as a part of the new pure protocol testing harness.

* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::setFrontend):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::reset):
(WebCore):
(WebCore::InspectorCSSAgent::resetNonPersistentData):
(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::disable):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, rolling out r128409.
http://trac.webkit.org/changeset/128409
https://bugs.webkit.org/show_bug.cgi?id=96622

It broke Chromium browser_tests (Requested by tkent on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::shouldScopeMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Testing whether indexing type is ArrayWithArrayStorage should not compare against ArrayWithArrayStorage
https://bugs.webkit.org/show_bug.cgi?id=96611

Reviewed by Gavin Barraclough.

* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArray):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePatchGetArrayLength):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePatchGetArrayLength):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Add configuration for production builds
https://bugs.webkit.org/show_bug.cgi?id=96607

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
and enable all-in-one-files optimizations.

* qmake/mkspecs/features/production_build.prf: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Tests] We should have test for clicking spin button in iframe.
https://bugs.webkit.org/show_bug.cgi?id=96612

Reviewed by Kent Tamura.

This patch adds two tests for clicking spin button in iframe for
input type "number" and input type "time" with multiple fields UI.

These tests are added for catching regression caused by r127876.

* fast/forms/number/number-spinbutton-click-in-iframe-expected.txt: Added.
* fast/forms/number/number-spinbutton-click-in-iframe.html: Added.
* fast/forms/resources/common-spinbutton-click-in-iframe.js: Added.
(getSpinButton): Extracts spin button in shadow DOM tree.
(mouseClick): Simulates mouse click.
(mouseMoveTo): Simulates mouse pointer move.
(runIFrameLoaded): Checking spin button clicked.
(testClickSpinButtonInIFrame): Creates and populates iframe.
* fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] GStreamer detection does not work when cross-compiling
https://bugs.webkit.org/show_bug.cgi?id=96608

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

When cross-compiling it is not safe to just use system(pkg-config),
because there is a high probability that it will find packages in the
host system instead of in the target one. Instead use qmake's new
packagesExist() function that takes care of this delicate aspect of
cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
PKG_CONFIG_LIBDIR accordingly.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[WK2][WTR] More efficient string handling in InjectedBundlePage
https://bugs.webkit.org/show_bug.cgi?id=96609

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Update StringBuilder usage in InjectedBundlePage to follow
the latest recommandations for efficient string handling:
http://trac.webkit.org/wiki/EfficientStrings

This involves using appendLiteral() or appendNumber()
instead of append() whenever possible.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpPath):
(WTR::rangeToStr):
(WTR::styleDecToStr):
(WTR::frameToStr):
(WTR::dumpResourceURL):
(WTR):
(WTR::dumpFrameDescriptionSuitableForTestResult):
(WTR::dumpRequestDescriptionSuitableForTestResult):
(WTR::dumpResponseDescriptionSuitableForTestResult):
(WTR::dumpErrorDescriptionSuitableForTestResult):
(WTR::InjectedBundlePage::didReceiveIntentForFrame):
(WTR::InjectedBundlePage::registerIntentServiceForFrame):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishProgress):
(WTR::dumpFrameScrollPosition):
(WTR::dumpFrameText):
(WTR::dumpDescendantFramesText):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::didReceiveResponseForResource):
(WTR::InjectedBundlePage::didFinishLoadForResource):
(WTR::InjectedBundlePage::didFailLoadForResource):
(WTR::InjectedBundlePage::shouldCacheResponse):
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
(WTR::InjectedBundlePage::supportsFullScreen):
(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):
(WTR::InjectedBundlePage::closeFullScreen):
(WTR::dumpBackForwardListItem):
(WTR::InjectedBundlePage::dumpBackForwardList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed GTK gardening.

Rebaselining two tests after r128375.

* platform/gtk/TestExpectations:
* platform/gtk/fast/table/height-percent-test-vertical-expected.png: Added.
* platform/gtk/fast/table/height-percent-test-vertical-expected.txt:
* platform/gtk/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt][WK2] Memory leaks in Qt's TestRunner
https://bugs.webkit.org/show_bug.cgi?id=96603

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-13
Reviewed by Csaba Osztrogonác.

Fix memory leaks in Qt's TestRunner code by adopting WKString
created with WKStringCreateWithUTF8CString().

* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: NMI: migrate core instrumentation code to WTF namespace
https://bugs.webkit.org/show_bug.cgi?id=96511

Reviewed by Yury Semikhatsky.

After moving core NMI code to WTF namespace I removed forward declarations
of MemoryObjectInfo and MemoryInstrumentation from WebCore headers and add
forward declaration into wtf/Forward.h

Source/WebCore:

* bindings/v8/DOMDataStore.h:
(WebCore):
* bindings/v8/ScriptProfiler.h:
(WebCore):
* bindings/v8/V8DOMMap.h:
(WebCore):
* bindings/v8/V8PerIsolateData.h:
(WebCore):
* bindings/v8/V8ValueCache.h:
(WebCore):
* css/CSSProperty.h:
* css/CSSRule.h:
(WebCore):
* css/CSSSelectorList.h:
(WebCore):
* css/CSSStyleDeclaration.h:
(WebCore):
* css/CSSStyleSheet.h:
(WebCore):
* css/CSSValue.h:
* css/MediaList.h:
(WebCore):
* css/MediaQuery.h:
* css/MediaQueryExp.h:
* css/StylePropertySet.h:
(WebCore):
* css/StyleResolver.h:
* css/StyleRule.h:
(WebCore):
* css/StyleRuleImport.h:
(WebCore):
* css/StyleSheetContents.h:
(WebCore):
* css/WebKitCSSKeyframeRule.h:
* css/WebKitCSSKeyframesRule.h:
(WebCore):
* css/WebKitCSSMixFunctionValue.h:
* dom/DocumentEventQueue.h:
(WebCore):
* dom/ElementAttributeData.h:
(WebCore):
* dom/Event.h:
(WebCore):
* dom/Node.h:
(WebCore):
* dom/WebCoreMemoryInstrumentation.cpp:
(WTF):
(WTF::WebCore::KURL):
* dom/WebCoreMemoryInstrumentation.h:
(WebCore):
(WTF):
* inspector/MemoryInstrumentationImpl.h:
* loader/DocumentLoader.h:
(WebCore):
* loader/FrameLoader.h:
(WebCore):
* loader/ResourceLoader.h:
(WebCore):
* loader/SubstituteData.h:
* loader/cache/CachedCSSStyleSheet.h:
(WebCore):
* loader/cache/CachedRawResource.h:
(WebCore):
* loader/cache/CachedResource.h:
(WebCore):
* loader/cache/CachedResourceHandle.h:
* loader/cache/CachedResourceLoader.h:
(WebCore):
* loader/cache/CachedScript.h:
(WebCore):
* loader/cache/CachedShader.h:
* loader/cache/CachedXSLStyleSheet.h:
(WebCore):
* loader/cache/MemoryCache.h:
(WebCore):
* page/Frame.h:
(WebCore):
* platform/SharedBuffer.h:
* platform/graphics/CrossfadeGeneratedImage.h:
(WebCore):
* platform/graphics/Image.h:
(WebCore):
* platform/network/FormData.h:
(WebCore):
* platform/network/ResourceRequestBase.h:
* platform/network/ResourceResponseBase.h:
* rendering/style/RenderStyle.h:
(WebCore):
* rendering/style/StyleRareInheritedData.h:
(WebCore):
* rendering/style/StyleRareNonInheritedData.h:
(WebCore):

Source/WTF:

* wtf/Forward.h:
(WTF):
* wtf/MemoryInstrumentation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed GTK gardening.

Removing expectation for fast/canvas/canvas-css-crazy.html, the test
was fixed in r128411.

Marking fast/events/popup-blocking-timers.html as slow and adding a
timeout expectation for touchadjustment/iframe-boundary.html.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[CSSRegions][CSSOM] Implement Element.getRegionFlowRanges
https://bugs.webkit.org/show_bug.cgi?id=78493

Patch by Raul Hudea <rhudea@adobe.com> on 2012-09-13
Reviewed by David Hyatt.

Source/WebCore:

Implement the getRegionFlowRanges function from the CSS Regions spec. It is implemented by iterating over
the content nodes and figuring out which nodes have boundingBox intersecting the region box and figuring out
the start and end positions.

Tests: fast/regions/get-region-flow-ranges-absolute-pos.html
       fast/regions/get-region-flow-ranges-content-nodes.html
       fast/regions/get-region-flow-ranges-display-none.html
       fast/regions/get-region-flow-ranges-empty-regions.html
       fast/regions/get-region-flow-ranges-fixed-pos.html
       fast/regions/get-region-flow-ranges-horiz-bt.html
       fast/regions/get-region-flow-ranges-inline-only.html
       fast/regions/get-region-flow-ranges-text-vert-lr.html
       fast/regions/get-region-flow-ranges-text.html
       fast/regions/get-region-flow-ranges-vert-lr.html
       fast/regions/get-region-flow-ranges-vert-rl.html
       fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr.html
       fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr.html
       fast/regions/get-region-flow-ranges.html

* dom/Element.cpp:
(WebCore::Element::webkitGetRegionFlowRanges):
(WebCore):
* dom/Element.h:
* dom/Element.idl: added the webkitGetRegionFlowRanges method
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed)
(WebCore::RenderBlock::hasNextPage): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed)
(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage): Added a slower path which works without LayoutState
(WebCore::RenderBlock::clampToStartAndEndRegions): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed)
* rendering/RenderBox.cpp:
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed)
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed)
(WebCore::computeInlineStaticDistance): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed)
* rendering/RenderNamedFlowThread.cpp:
(WebCore::isContainedInNodes):
(WebCore):
(WebCore::boxIntersectsRegion):
(WebCore::RenderNamedFlowThread::getRanges): returns a vector of Ranges that contains Node that are part of a region
* rendering/RenderNamedFlowThread.h:
(RenderNamedFlowThread):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::logicalTopOfFlowThreadContentRect): Returns the logical top of a rectangle inside the flow thread content
(WebCore):
(WebCore::RenderRegion::logicalBottomOfFlowThreadContentRect): Returns the logical bottom of a rectangle inside the flow thread content
(WebCore::RenderRegion::getRanges): proxy the getRanges call to its named flow thread
* rendering/RenderRegion.h:
(RenderRegion):
(WebCore::RenderRegion::logicalTopForFlowThreadContent): Renamed from offsetFromLogicalTopOfFirstPage
(WebCore::RenderRegion::logicalBottomForFlowThreadContent): Returns the logical bottom of the FlowThreadContent rect

LayoutTests:

Add tests for getRegionFlowRanges call.

* fast/regions/get-region-flow-ranges-absolute-pos-expected.txt: Added.
* fast/regions/get-region-flow-ranges-absolute-pos.html: Added.
* fast/regions/get-region-flow-ranges-content-nodes-expected.txt: Added.
* fast/regions/get-region-flow-ranges-content-nodes.html: Added.
* fast/regions/get-region-flow-ranges-display-none-expected.txt: Added.
* fast/regions/get-region-flow-ranges-display-none.html: Added.
* fast/regions/get-region-flow-ranges-empty-regions-expected.txt: Added.
* fast/regions/get-region-flow-ranges-empty-regions.html: Added.
* fast/regions/get-region-flow-ranges-expected.txt: Added.
* fast/regions/get-region-flow-ranges-fixed-pos-expected.txt: Added.
* fast/regions/get-region-flow-ranges-fixed-pos.html: Added.
* fast/regions/get-region-flow-ranges-horiz-bt-expected.txt: Added.
* fast/regions/get-region-flow-ranges-horiz-bt.html: Added.
* fast/regions/get-region-flow-ranges-inline-only-expected.txt: Added.
* fast/regions/get-region-flow-ranges-inline-only.html: Added.
* fast/regions/get-region-flow-ranges-text-expected.txt: Added.
* fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt: Added.
* fast/regions/get-region-flow-ranges-text-vert-lr.html: Added.
* fast/regions/get-region-flow-ranges-text.html: Added.
* fast/regions/get-region-flow-ranges-vert-lr-expected.txt: Added.
* fast/regions/get-region-flow-ranges-vert-lr.html: Added.
* fast/regions/get-region-flow-ranges-vert-rl-expected.txt: Added.
* fast/regions/get-region-flow-ranges-vert-rl.html: Added.
* fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Added.
* fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr.html: Added.
* fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Added.
* fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr.html: Added.
* fast/regions/get-region-flow-ranges.html: Added.
* fast/regions/resources/helper.js:
(getName):
(getRangeAt):
(compareArrays):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Check if WorkerContext is terminated in WebWorkerClientImple::openFileSystem call.
https://bugs.webkit.org/show_bug.cgi?id=96601

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-09-13
Reviewed by Kent Tamura.

m_webFrame might be already deleted after terminateWorkerContext call.
This patch ensure it be NULL and change to avoid using it.

Test: fast/filesystem/workers/detached-frame-crash.html

* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::terminateWorkerContext):
(WebKit::WebWorkerClientImpl::openFileSystem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
https://bugs.webkit.org/show_bug.cgi?id=96506

Reviewed by Dirk Pranke.

Tools:

Lower the timeout value to 6 seconds for release configuration and 12 seconds
for debug configuration. These are the same values the Chromium port uses.

Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
the layout tests under WebKit2 generally) requires more attention and gardening
than what the current effort produces.

The unit test is updated as well to test these changes.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.default_timeout_ms):
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest.test_default_timeout_ms):
(GtkPortTest.assertLinesEqual):

LayoutTests:

Create a new section for slow tests. Tests listed here pass (or at least
work as expected or reliably) but require more than 6 or 12 seconds to run.

More tests are added into the timeout section. These are primarily tests
that used to take half a minute to run just to be interrupted by the watchdog
in DumpRenderTree and were then reported as text mismatch failures. Now they
will be timing out which is (arguably) a more proper way for them to fail.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL][WK2] Make _ref() functions return the object
https://bugs.webkit.org/show_bug.cgi?id=96604

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-13
Reviewed by Gyuyoung Kim.

Make _ref() functions return the ref'd object to
make them more convenient to use. Also fix their
usage to make use of the newly returned value.

This change is consistent with eina_stringshare_ref()
in EFL and g_object_ref() in glib.

* UIProcess/API/efl/ewk_back_forward_list.cpp:
(createEinaList):
* UIProcess/API/efl/ewk_back_forward_list_item.cpp:
(ewk_back_forward_list_item_ref):
* UIProcess/API/efl/ewk_back_forward_list_item.h:
* UIProcess/API/efl/ewk_context.cpp:
(ewk_context_download_job_add):
* UIProcess/API/efl/ewk_download_job.cpp:
(ewk_download_job_ref):
(ewk_download_job_response_set):
* UIProcess/API/efl/ewk_download_job.h:
* UIProcess/API/efl/ewk_form_submission_request.cpp:
(ewk_form_submission_request_ref):
* UIProcess/API/efl/ewk_form_submission_request.h:
* UIProcess/API/efl/ewk_intent.cpp:
(ewk_intent_ref):
* UIProcess/API/efl/ewk_intent.h:
* UIProcess/API/efl/ewk_intent_service.cpp:
(ewk_intent_service_ref):
* UIProcess/API/efl/ewk_intent_service.h:
* UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
(ewk_navigation_policy_decision_ref):
* UIProcess/API/efl/ewk_navigation_policy_decision.h:
* UIProcess/API/efl/ewk_url_request.cpp:
(ewk_url_request_ref):
* UIProcess/API/efl/ewk_url_request.h:
* UIProcess/API/efl/ewk_url_response.cpp:
(ewk_url_response_ref):
* UIProcess/API/efl/ewk_url_response.h:
* UIProcess/API/efl/ewk_url_scheme_request.cpp:
(ewk_url_scheme_request_ref):
* UIProcess/API/efl/ewk_url_scheme_request.h:
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_resource_load_initiated):
* UIProcess/API/efl/ewk_web_resource.cpp:
(ewk_web_resource_ref):
* UIProcess/API/efl/ewk_web_resource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on Mac, Chromium-Mac, GTK, EFL.
https://bugs.webkit.org/show_bug.cgi?id=96594.

Unreviewed.

Update TestExpectations.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

new test fast/canvas/canvas-css-crazy.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=96582

Reviewed by Csaba Osztrogonác.

We represent 0 pointers with null, not undefined.

Test: fast/canvas/canvas-css-crazy.html

* bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::toJS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=96308

* platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png:
Rebaseline for http://trac.webkit.org/changeset/128375.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Fix cases where find-in-page doesn't send a final update
https://bugs.webkit.org/show_bug.cgi?id=96402

Fix some issues in the WebKit implementation that prevented to send a final
reportFindInPageMatchCount message.

Reviewed by Adam Barth.

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::shouldScopeMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed GTK gardening.

Removing crash expectations for accessibility tests that were added in
r128342. The offending commit was reverted in r128353.

Adding text mismatch expectations for two tests that probably require
rebaselining, failing since r128375.

Adding failure expectations for other regressions:
- fast/canvas/canvas-css-crazy.html after r128374
- fast/table/bad-replaced-sizing-preferred-logical-widths.html after r128389
- fast/js/primitive-property-access-edge-cases.html after r128400

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: [Styles] Styles not updated when there is a heavy stream of DOM updates
https://bugs.webkit.org/show_bug.cgi?id=96482

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Update the Styles pane even if there is a pending rebuild update for the same current node.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):

LayoutTests:

* inspector/styles/force-pseudo-state.html:
* inspector/styles/force-pseudo-state-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

css3/filters/custom/filter-fallback-to-software.html fails.
https://bugs.webkit.org/show_bug.cgi?id=94372.

Unreviewed.

Update TestExpectations.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

AX: svg:image not accessible
https://bugs.webkit.org/show_bug.cgi?id=96341

Unreviewed.

Build fix for non-SVG ports.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

New time input needs accessibility
https://bugs.webkit.org/show_bug.cgi?id=96032

Reviewed by Chris Fleizach.

Source/WebCore:

This patch adds accessibility support into multiple fields time input
UI by setting "role" HTML attribute of DateTimeFieldElement to "spinbutton"
and changing ARIA attributes to post value change notification.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

Tests: fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html
       fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html

* html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::DateTimeFieldElement): Changed to set
"role" HTML attribute to "spinbutton".
(WebCore::DateTimeFieldElement::initialize): Changed to set new
parameter axHelpText to aria-help attribute and set aria-valuemax and
aria-valuemin attributes.
(WebCore::DateTimeFieldElement::updateVisibleValue): Changed to set
aria-valuetext and aria-valuenow attributes.
* html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Changed to add new parameter axHelpText to initialize().
* html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeAMPMFieldElement::create): Changed to add new argument.
(WebCore::DateTimeHourFieldElement::create): ditto.
(WebCore::DateTimeMillisecondFieldElement::create): ditto.
(WebCore::DateTimeMinuteFieldElement::create): ditto.
(WebCore::DateTimeSecondFieldElement::create): ditto.
* html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::maximum): Added for DateTimeFieldElement::initialize().
(WebCore::DateTimeNumericFieldElement::minimum): ditto.
* html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Added maximum() and minimum() declarations.
* html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::maximum): Added for DateTimeFieldElement::initialize().
(WebCore::DateTimeSymbolicFieldElement::minimum): ditto.
* html/shadow/DateTimeSymbolicFieldElement.h:
(DateTimeSymbolicFieldElement): Added maximum() and minimum() declarations.

LayoutTests:

This patch adds two tests for checking accessibility functionalities
in multiple fields time input UI.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

* fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html: Added to check ARIA attributes used in multiple fields time input UI.
* fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html: Added to check accessibility notification supports in multiple fields time input UI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128404 268f45cc-cd09-0410-ab3c-d52691b4dbfc