WebKit-https.git
13 years ago2008-03-05 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 6 Mar 2008 06:18:14 +0000 (06:18 +0000)]
2008-03-05  Alp Toker  <alp@atoker.com>

        Add a missing make dependency for derived sources to improve
        autotools build dependency tracking.

        Issue spotted by Ori Bernstein.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-05 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 6 Mar 2008 04:44:06 +0000 (04:44 +0000)]
2008-03-05  Alp Toker  <alp@atoker.com>

        GTK+ build fix for breakage introduced in r30800.

        Track moved bridge sources from JavaScriptCore to WebCore.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justin.garcia@apple.com [Thu, 6 Mar 2008 04:07:05 +0000 (04:07 +0000)]
WebCore:

        Reviewed by Darin.

        One part of fix for:
        <rdar://problem/5780697> Copying content with percentage based rules in a style sheet will cause fidelity issues

        * editing/markup.cpp:
        (WebCore::appendStartMarkup): Styles from matched rules should take precedence over those in
        inline style declarations, not the other way around.

LayoutTests:

        Reviewed by Darin.

        <rdar://problem/5780697> Copying content with CSS property values that are percentages can cause fidelity issues

        * editing/pasteboard/5780697-1-expected.txt: Added.
        * editing/pasteboard/5780697-1.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother buildbot fix attempt, pass SHELL=/bin/bash
alp@webkit.org [Thu, 6 Mar 2008 04:02:25 +0000 (04:02 +0000)]
Another buildbot fix attempt, pass SHELL=/bin/bash

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-05 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 6 Mar 2008 03:49:21 +0000 (03:49 +0000)]
2008-03-05  Alp Toker  <alp@atoker.com>

        Attempt to get the autotools build working again on the bot with
        build-webkit.

        Force the use of /bin/bash since we seem to have bash-isms in the
        configure script right now.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix typo in ChangeLog.
mrowe@apple.com [Thu, 6 Mar 2008 02:21:36 +0000 (02:21 +0000)]
Fix typo in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca@apple.com [Thu, 6 Mar 2008 02:08:48 +0000 (02:08 +0000)]
    Reviewed by Darin.

        Move JNI specific code from runtime_root over to jni_jsobject, where it is used.

        * bridge/jni/jni_jsobject.cpp:
        (completedJavaScriptAccess):
        (initializeJavaScriptAccessLock):
        (lockJavaScriptAccess):
        (unlockJavaScriptAccess):
        (dispatchToJavaScriptThread):
        (performJavaScriptAccess):
        (JavaJSObject::initializeJNIThreading):
        (isJavaScriptThread):
        (JavaJSObject::invoke):
        * bridge/jni/jni_jsobject.h:
        * bridge/runtime_root.cpp:
        * bridge/runtime_root.h:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Thu, 6 Mar 2008 02:05:47 +0000 (02:05 +0000)]
    Reviewed by Sam.

        - add functions giving offsets within a KURL, slated to replace the
          EncodedURL object in CSSStyleSelector (in a future "visited link" change)
        - chagned all KURL data members names to use the traditional m_ prefix
        - initialize all members to 0 in invalid KURLs rather than having all
          functions check m_isValid

        * platform/KURL.cpp:
        (WebCore::KURL::invalidate): Added. Initializes all the fields except for
        m_string to the "invalid" values. For use in the empty constructor and
        in the init and parse functions.
        (WebCore::KURL::init): Tweaked comments. Changed all code paths that return
        early to use the invalidate() function. Updated for member variable name
        changes.
        (WebCore::KURL::hasPath): Updated for member variable name changes.
        Remove now-unneeded check of m_isValid.
        (WebCore::KURL::lastPathComponent): Ditto.
        (WebCore::KURL::protocol): Ditto.
        (WebCore::KURL::host): Ditto.
        (WebCore::KURL::port): Ditto.
        (WebCore::KURL::pass): Ditto.
        (WebCore::KURL::user): Ditto.
        (WebCore::KURL::ref): Ditto.
        (WebCore::KURL::hasRef): Ditto.
        (WebCore::KURL::protocolIs): Ditto.
        (WebCore::KURL::query): Ditto.
        (WebCore::KURL::path): Ditto.
        (WebCore::KURL::setProtocol): Ditto.
        (WebCore::KURL::setHost): Ditto.
        (WebCore::KURL::setPort): Ditto.
        (WebCore::KURL::setHostAndPort): Ditto.
        (WebCore::KURL::setUser): Ditto.
        (WebCore::KURL::setPass): Ditto.
        (WebCore::KURL::setRef): Ditto.
        (WebCore::KURL::setQuery): Ditto.
        (WebCore::KURL::setPath): Ditto.
        (WebCore::KURL::prettyURL): Ditto.
        (WebCore::copyPathRemovingDots): Removed braces to match our code style.
        (WebCore::KURL::parse): Changed all code paths that return early to use
        the invalidate function. Moved code to set m_isValid to true to the very
        end of the function. Removed braces to match our code style. Removed an
        extra copy of the path/query/fragment code (there were two identical copies
        in the two sides of an if statement). Removed some commented-out code.
        Reversed an if statment. Added code to set the new m_pathAfterLastSlash
        field. Updated for member variable name changes.
        (WebCore::equalIgnoringRef): Updated for member variable name changes.
        (WebCore::KURL::isHierarchical): Ditto.

        * platform/KURL.h: Added a FIXME about ref vs. fragment. Made the empty
        constructor inline and called the new invalidate function. Added new
        pathStart, pathEnd, and pathAfterLastSlash functions, for use in the
        new visited link code. Added an invalidate function. Renamed all the
        data members to use the m_ prefix.

        * WebCore.base.exp: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Thu, 6 Mar 2008 01:39:21 +0000 (01:39 +0000)]
    Reviewed by Sam.

        * WebCore.xcodeproj/project.pbxproj:
        Change jni_jsobject.cpp to be Obj-C++ for now. The plan is to merge
        this with jni_objc.mm and create jni_jsobject.mm.

        * bridge/jni/jni_jsobject.cpp:
        (createRootObject):
        Move createRootObject here from WebCoreFrameBridge.

        (JavaJSObject::createNative):
        Call the newly added createRootObject function.

        * bridge/runtime_root.cpp:
        (KJS::Bindings::RootObject::initializeJNIThreading):
        * bridge/runtime_root.h:
        setCreateRootObject no longer takes a root object, rename it to initializeJNIThreading.

        * page/mac/FrameMac.mm:
        (WebCore::Frame::createScriptInstanceForWidget):
        Just call Frame::createRootObject here.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge init]):
        Call initializeJNIThreading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Wed, 5 Mar 2008 23:52:14 +0000 (23:52 +0000)]
    Reviewed by Sam.

        Change some static class variables to be regular static variables,
        making it easier to move the chunk of mac-specific code out of runtime_root.[cpp|h]

        * bridge/runtime_root.cpp:
        (KJS::Bindings::completedJavaScriptAccess):
        (KJS::Bindings::RootObject::dispatchToJavaScriptThread):
        (KJS::Bindings::performJavaScriptAccess):
        (KJS::Bindings::RootObject::createRootObject):
        (KJS::Bindings::RootObject::runLoop):
        (KJS::Bindings::RootObject::setCreateRootObject):
        * bridge/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-05 Brent Fulgham <bfulgham@gmail.com>
mrowe@apple.com [Wed, 5 Mar 2008 22:44:12 +0000 (22:44 +0000)]
2008-03-05  Brent Fulgham <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Modify source files to use the USE(SAFARI_THEME) macro, rather than
        USE_SAFARI_THEME.  (http://bugs.webkit.org/show_bug.cgi?id=17683)

        * WebCore/platform/win/PlatformScrollBarSafari.cpp
        * WebCore/rendering/RenderThemeSafari.cpp
        * WebCore/rendering/RenderThemeSafari.h
        * config.h: Move definition of WTF_USE_SAFARI_THEME here

2008-03-05  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Remove definition of WTF_USE_SAFARI_THEME from wtf/Platform.h
        because the PLATFORM(CG) flag is not set until config.h has
        already included this file.

        * wtf/Platform.h:  Remove useless definition of WTF_USE_SAFARI_THEME

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
beidson@apple.com [Wed, 5 Mar 2008 22:26:34 +0000 (22:26 +0000)]
JavaScriptCore:

        Reviewed by Alexey and Mark Rowe

        Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html

        DatabaseThread::unscheduleDatabaseTasks() manually filters through a MessageQueue,
        removing particular items for Databases that were shutting down.

        This filtering operation is not atomic, and therefore causes a race condition with the
        MessageQueue waking up and reading from the message queue.

        The end result was an attempt to dereference a null DatabaseTask.  Timing-wise, this never
        seemed to happen in a debug build, otherwise an assertion would've caught it.  Replacing that
        assertion with a crash in a release build is what revealed this bug.

        * wtf/MessageQueue.h:
        (WTF::::waitForMessage): Tweak the waiting logic to check the queue's empty state then go back
          to sleep if the queue was empty - checking m_killed each time it wakes up.

WebCore:

        Reviewed by Alexey and Mark Rowe

        Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html

        DatabaseThread::unscheduleDatabaseTasks() manually filters through a MessageQueue,
        removing particular items for Databases that were shutting down.

        This filtering operation is not atomic, and therefore causes a race condition with the
        database thread waking up and reading from the message queue.

        The end result was an attempt to dereference a null DatabaseTask.  Timing-wise, this never
        seemed to happen in a debug build, otherwise an assertion would've caught it.  Replacing that
        assertion with a crash in a release build is what revealed this bug.

        The fix for the above symptom was entirely in WTF::MessageQueue in JSCore.  With this fix in
        place, another crash popped up in the layout tests that was related to dereferencing a
        deallocated object - simply because SQLTransaction had a raw pointer to it's Database object
        when it needed to be a ref pointer.

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::runCurrentStatement):
        * storage/SQLTransaction.h: Change m_database to be a RefPtr
        (WebCore::SQLTransaction::database):

LayoutTests:

        Reviewed by Alexey + Mark Rowe

        Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html

        This test takes its best shot at handling two databases on a single database thread at once,
        then having one of those databases go away completely (garbage collection and everything)

        * storage/multiple-databases-garbage-collection-expected.txt: Added.
        * storage/multiple-databases-garbage-collection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove unused header includes from interpreter.cpp.
ddkilzer@apple.com [Wed, 5 Mar 2008 22:20:12 +0000 (22:20 +0000)]
    Remove unused header includes from interpreter.cpp.

        Reviewed by Darin.

        * kjs/interpreter.cpp: Remove unused header includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix. Remove symbol that no longer exists from the exports file.
mrowe@apple.com [Wed, 5 Mar 2008 22:08:17 +0000 (22:08 +0000)]
Build fix.  Remove symbol that no longer exists from the exports file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixed commit date.
ddkilzer@apple.com [Wed, 5 Mar 2008 21:51:58 +0000 (21:51 +0000)]
Fixed commit date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-05 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 5 Mar 2008 20:56:19 +0000 (20:56 +0000)]
2008-03-05  Alp Toker  <alp@atoker.com>

        Re-attempt to switch to the autotools build system for GTK+.

        Change scripts to continue when distclean fails.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove WebCoreScriptCallFrame
aroben@apple.com [Wed, 5 Mar 2008 19:35:32 +0000 (19:35 +0000)]
     Remove WebCoreScriptCallFrame

         Reviewed by Tim.

         * WebView/WebCoreScriptDebugger.h:
           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
           - Replaced -newWrapperForFrame: with
             -newFrameWithGlobalObject:caller:state:
           - Removed WebCoreScriptCallFrame interface.
         * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
         with WebScriptCallFrame.
         (-[WebCoreScriptDebugger _enterFrame:]): Changed to call
         -newFrameWithGlobalObject:caller:state.
         (-[WebCoreScriptDebugger _leaveFrame]):
         * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
         _private ivar to be of type WebScriptCallFramePrivate*.
         * WebView/WebScriptDebugDelegate.mm:
           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
           - Added WebScriptCallFramePrivate
         (-[WebScriptDebugger enteredFrame:sourceId:line:]):
         (-[WebScriptDebugger hitStatement:sourceId:line:]):
         (-[WebScriptDebugger leavingFrame:sourceId:line:]):
         (-[WebScriptDebugger exceptionRaised:sourceId:line:]):
         (-[WebScriptCallFramePrivate dealloc]): Added.
         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
         Code came from WebCoreScriptCallFrame.
         (-[WebScriptCallFrame dealloc]): Added a call to release the _private
         ivar.
         (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
         _private with direct access of _private's ivars.
         (-[WebScriptCallFrame caller]): Ditto.
         (-[WebScriptCallFrame scopeChain]): Ditto.
         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move -_convertValueToObjcValue to WebScriptCallFrame
aroben@apple.com [Wed, 5 Mar 2008 19:35:09 +0000 (19:35 +0000)]
     Move -_convertValueToObjcValue to WebScriptCallFrame

         Reviewed by Darin.

         * WebView/WebCoreScriptDebugger.h: Removed declaration of
         -_convertValueToObjcValue.
         * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
         * WebView/WebScriptDebugDelegate.mm:
         (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
         from -[WebCoreScriptCallFrame _convertValueToObjcValue].
         (-[WebScriptCallFrame scopeChain]): Changed to call
         -_convertValueToObjcValue on self instead of _private.
         (-[WebScriptCallFrame exception]): Ditto.
         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move -exception and -evaluateWebScript: to WebScriptCallFrame
aroben@apple.com [Wed, 5 Mar 2008 19:34:44 +0000 (19:34 +0000)]
     Move -exception and -evaluateWebScript: to WebScriptCallFrame

         Reviewed by Darin.

         * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
         and -evaluateWebScript:.
         * WebView/WebCoreScriptDebugger.mm: Removed -exception and
         -evaluateWebScript:.
         * WebView/WebScriptDebugDelegate.mm:
         (-[WebScriptCallFrame exception]): Added. Code came from
         -[WebCoreScriptCallFrame exception].
         (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
         -[WebCoreScriptCallFrame evaluateWebScript:].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move -scopeChain to WebScriptCallFrame
aroben@apple.com [Wed, 5 Mar 2008 19:34:29 +0000 (19:34 +0000)]
     Move -scopeChain to WebScriptCallFrame

         Reviewed by Darin.

         * WebView/WebCoreScriptDebugger.h:
           - Added declarations of -globalObject and -_convertValueToObjcValue:
             to WebCoreScriptCallFrame
           - Removed declaration of -scopeChain.
         * WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue
         within the main WebCoreScriptCallFrame implementation.
         (-[WebCoreScriptCallFrame globalObject]): Added.
         * WebView/WebScriptDebugDelegate.mm:
         (-[WebScriptCallFrame scopeChain]): Added. Code came from
         -[WebCoreScriptCallFrame scopeChain].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame
aroben@apple.com [Wed, 5 Mar 2008 19:34:13 +0000 (19:34 +0000)]
     Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame

         Reviewed by Darin.

         * WebView/WebCoreScriptDebugger.h:
           - Removed #else case of #ifdef __cplusplus since this file is only
             ever used by C++ Objective-C files
           - Removed 'using KJS::ExecState' statement since we prefer not to
             have using statements in header files
           - Consequently prefixed uses of ExecState with KJS::
           - Added declaration of toNSString method that takes a const
             UString&
           - Added declaration of -[WebCoreScriptCallFrame state]
           - Removed declaration of -[WebCoreScriptCallFrame functionName]
         * WebView/WebCoreScriptDebugger.mm:
         (toNSString): Made this no longer static.
         (-[WebCoreScriptCallFrame state]): Added.
         * WebView/WebScriptDebugDelegate.mm:
         (-[WebScriptCallFrame functionName]): Added. Code came from
         -[WebCoreScriptCallFrame functionName], though I changed some nested
         ifs into early returns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMove WebCoreScriptDebugger up to WebKit
aroben@apple.com [Wed, 5 Mar 2008 19:33:58 +0000 (19:33 +0000)]
Move WebCoreScriptDebugger up to WebKit

WebCore:

        Move WebCoreScriptDebugger up to WebKit

        Reviewed by Darin.

        * WebCore.base.exp: Exported some functions used by
        WebCoreScriptDebugger, and sorted the list.
        * WebCore.xcodeproj/project.pbxproj: Removed
        WebCoreScriptDebugger.{h,mm} from the project and marked
        a few headers private so that WebKit can use them.
        * page/mac/WebCoreScriptDebugger.h: Removed.
        * page/mac/WebCoreScriptDebugger.mm: Removed.

WebKit:

        Move WebCoreScriptDebugger to WebKit

        Reviewed by Darin.

        * WebKit.xcodeproj/project.pbxproj: Added WebCoreScriptDebugger.{h,mm}
        to the project.

WebKit/mac:

        Move WebCoreScriptDebugger to WebKit

        Reviewed by Darin.

        * WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
        * WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm.
        (toNSString):
        (toNSURL):
        (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
        (WebCoreScriptDebuggerImp::sourceParsed):
        (WebCoreScriptDebuggerImp::callEvent):
        (WebCoreScriptDebuggerImp::atStatement):
        (WebCoreScriptDebuggerImp::returnEvent):
        (WebCoreScriptDebuggerImp::exception):
        (+[WebCoreScriptDebugger initialize]):
        (-[WebCoreScriptDebugger initWithDelegate:]):
        (-[WebCoreScriptDebugger dealloc]):
        (-[WebCoreScriptDebugger finalize]):
        (-[WebCoreScriptDebugger delegate]):
        (-[WebCoreScriptDebugger _enterFrame:]):
        (-[WebCoreScriptDebugger _leaveFrame]):
        (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]):
        (-[WebCoreScriptCallFrame _setWrapper:]):
        (-[WebCoreScriptCallFrame _convertValueToObjcValue:]):
        (-[WebCoreScriptCallFrame dealloc]):
        (-[WebCoreScriptCallFrame wrapper]):
        (-[WebCoreScriptCallFrame caller]):
        (-[WebCoreScriptCallFrame scopeChain]):
        (-[WebCoreScriptCallFrame functionName]):
        (-[WebCoreScriptCallFrame exception]):
        (-[WebCoreScriptCallFrame evaluateWebScript:]):
        * WebView/WebScriptDebugDelegate.mm: Updated header path.
        * WebView/WebScriptDebugDelegatePrivate.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Wed, 5 Mar 2008 19:14:50 +0000 (19:14 +0000)]
    Reviewed by Sam.

        Remove bindings/.

        * bindings: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
andersca@apple.com [Wed, 5 Mar 2008 19:13:48 +0000 (19:13 +0000)]
    Build fix.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build bridge/. Copy some headers over to WebKit as part of the post-build...
andersca@apple.com [Wed, 5 Mar 2008 19:12:51 +0000 (19:12 +0000)]
    Build bridge/. Copy some headers over to WebKit as part of the post-build step.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Don't build bindings/ anymore.
andersca@apple.com [Wed, 5 Mar 2008 19:11:39 +0000 (19:11 +0000)]
    Don't build bindings/ anymore.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
andersca@apple.com [Wed, 5 Mar 2008 19:04:21 +0000 (19:04 +0000)]
JavaScriptCore:

        Reviewed by Geoff.

        Don't build JavaScriptCore/bindings.

        * JavaScriptCore.exp:
        Export a couple of new functions.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        Remove bindings/

        * kjs/config.h:
        No need to define HAVE_JNI anymore.

        * kjs/interpreter.cpp:
        Remove unnecessary include.

WebCore:

        Reviewed by Geoff.

        * WebCore.base.exp:
        Add the NPN and KJS methods.

        * WebCore.xcodeproj/project.pbxproj:
        Bring in bridge/

        * config.h:
        Add HAVE_JNI define.

        * bindings/js/kjs_html.cpp:
        * bindings/objc/DOMInternal.mm:
        * bindings/objc/DOMUtility.mm:
        * bindings/objc/WebScriptObject.mm:
        * html/HTMLAppletElement.cpp:
        * html/HTMLEmbedElement.cpp:
        * html/HTMLObjectElement.cpp:
        * html/HTMLPlugInElement.cpp:
        * page/Frame.cpp:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.mm:
        * page/mac/WebCoreScriptDebugger.mm:
        * plugins/win/PluginViewWin.cpp:
        Include file changes.

WebKit/mac:

        Reviewed by Geoff.

        Include file changes.

        * Plugins/WebBaseNetscapePluginView.mm:
        * Plugins/WebNetscapePluginPackage.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Allow override of default script file name using command-line argument.
ddkilzer@apple.com [Wed, 5 Mar 2008 18:19:12 +0000 (18:19 +0000)]
    Allow override of default script file name using command-line argument.

        Reviewed by Adele.

        * API/minidom.c:
        (main): Allow first command-line argument to override the default script
        file name of "minidom.js".
        * API/testapi.c:
        (main): Allow first command-line argument to override the default script
        file name of "testapi.js".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Wed, 5 Mar 2008 17:02:17 +0000 (17:02 +0000)]
    Reviewed by Sam.

        Rewrite NPRuntime string conversion routines to use WebCore::String

        * bridge/NP_jsobject.cpp:
        (_NPN_Evaluate):
        * bridge/c/c_utility.cpp:
        (KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback):
        (KJS::Bindings::convertNPVariantToValue):
        (KJS::Bindings::convertNPStringToUTF16):
        (KJS::Bindings::identifierFromNPIdentifier):
        * bridge/c/c_utility.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSmall performance improvement to putImageData (3-5% on assignment in my tests)
oliver@apple.com [Wed, 5 Mar 2008 09:13:42 +0000 (09:13 +0000)]
Small performance improvement to putImageData (3-5% on assignment in my tests)

Reviewed by Alexey P

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-05 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 5 Mar 2008 08:44:28 +0000 (08:44 +0000)]
2008-03-05  Alp Toker  <alp@atoker.com>

        Force qmake for the GTK+ build until we get the build bot to succeed
        with autotools (currently dies at make distclean)

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
weinig@apple.com [Wed, 5 Mar 2008 07:31:01 +0000 (07:31 +0000)]
    Reviewed by Adele.

        * bindings/js/JSXMLHttpRequest.h: Remove unnecessary override of toBoolean.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mjs@apple.com [Wed, 5 Mar 2008 07:08:43 +0000 (07:08 +0000)]
WebCore:

        Reviewed by Sam and Oliver.

        - fixed http://bugs.webkit.org/show_bug.cgi?id=16289
        - fixed Acid3 tests 26 and 27 (not exactly the same issue but related)

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::mark): When marking a node that's in-document,
        mark the owner document if it hasn't been already. This means holding on
        to a single node from an unreferenced document now keeps the whole document alive.

        We are now at 90/100 on Acid3.

LayoutTests:

        Reviewed by Sam and Oliver.

        - test for http://bugs.webkit.org/show_bug.cgi?id=16289
        - test for Acid3 tests 26 and 27 (not exactly the same issue but related)

        * fast/dom/gc-11-expected.txt: Added. Test case from bug 16289.
        * fast/dom/gc-11.html: Added.
        * fast/dom/gc-acid3.html: Added. DOM garbage collection part of Acid3.
        * fast/dom/gc-acid3-expected.txt: Added.
        * fast/dom/gc-6-expected.txt: Updated results. The old assumptions of this test
        were in conflict with the requirements of Acid3.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 5 Mar 2008 06:54:54 +0000 (06:54 +0000)]
2008-03-04  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Switch the default GTK+ build system from qmake to autotools.

        qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake

        * Scripts/build-webkit:
        * Scripts/run-launcher:
        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Qt build fix.
weinig@apple.com [Wed, 5 Mar 2008 06:42:15 +0000 (06:42 +0000)]
    Qt build fix.

        * page/qt/FrameQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Wed, 5 Mar 2008 06:17:10 +0000 (06:17 +0000)]
WebCore:

        Reviewed by Mark Rowe.

        Rename kjs_window to JSDOMWindowBase.

        - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
          JSDOMWindow.h

        * ChangeLog:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSCustomVoidCallback.cpp:
        * bindings/js/JSCustomXPathNSResolver.cpp:
        * bindings/js/JSDOMWindowBase.cpp: Copied from bindings/js/kjs_window.cpp.
        * bindings/js/JSDOMWindowBase.h: Copied from bindings/js/kjs_window.h.
        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/JSDatabaseCustom.cpp:
        * bindings/js/JSEventTargetBase.cpp:
        * bindings/js/JSEventTargetBase.h:
        * bindings/js/JSEventTargetNode.cpp:
        * bindings/js/JSHTMLDocumentCustom.cpp:
        * bindings/js/JSHTMLFrameSetElementCustom.cpp:
        * bindings/js/JSHistoryCustom.cpp:
        * bindings/js/JSLocation.cpp:
        * bindings/js/JSSQLTransactionCustom.cpp:
        * bindings/js/JSXMLHttpRequest.cpp:
        * bindings/js/ScheduledAction.cpp:
        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_navigator.cpp:
        * bindings/js/kjs_proxy.cpp:
        * bindings/js/kjs_window.cpp: Removed.
        * bindings/js/kjs_window.h: Removed.
        * bindings/scripts/CodeGeneratorJS.pm:
        * history/CachedPage.cpp:
        * loader/FrameLoader.cpp:
        * page/Chrome.cpp:
        * page/InspectorController.cpp:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.mm:
        * page/qt/FrameQt.cpp:
        * page/win/FrameWin.cpp:
        * plugins/win/PluginViewWin.cpp:

WebKit/gtk:

        Reviewed by Mark Rowe.

        - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
          JSDOMWindow.h

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        * webkit/webkitwebframe.cpp:

WebKit/qt:

        Reviewed by Mark Rowe.

        - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
          JSDOMWindow.h

        * Api/qwebframe.cpp:
        (QWebFrame::addToJSWindowObject):

WebKit/win:

        Reviewed by Mark Rowe.

        - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
          JSDOMWindow.h

        * WebFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Tiger build.
timothy@apple.com [Wed, 5 Mar 2008 04:48:04 +0000 (04:48 +0000)]
Fix the Tiger build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother go at fixing the Qt build.
mrowe@apple.com [Wed, 5 Mar 2008 04:40:36 +0000 (04:40 +0000)]
Another go at fixing the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate link to Windows Platform SDK to its new location.
mrowe@apple.com [Wed, 5 Mar 2008 04:34:58 +0000 (04:34 +0000)]
Update link to Windows Platform SDK to its new location.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSpeculative Qt build fix.
mrowe@apple.com [Wed, 5 Mar 2008 04:22:54 +0000 (04:22 +0000)]
Speculative Qt build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Wed, 5 Mar 2008 02:14:41 +0000 (02:14 +0000)]
    Reviewed by Sam.

        Update include paths. This code is not used yet.

        * bridge/NP_jsobject.cpp:
        * bridge/c/c_class.cpp:
        * bridge/c/c_instance.cpp:
        * bridge/c/c_utility.cpp:
        (KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback):
        #if 0 this out for now.

        * bridge/jni/jni_class.cpp:
        * bridge/jni/jni_jsobject.cpp:
        * bridge/jni/jni_objc.mm:
        * bridge/jni/jni_runtime.cpp:
        * bridge/jni/jni_utility.cpp:
        * bridge/jni/jni_utility.h:
        * bridge/npruntime.cpp:
        * bridge/objc/WebScriptObject.h:
        * bridge/objc/objc_class.h:
        * bridge/objc/objc_instance.h:
        * bridge/objc/objc_runtime.h:
        * bridge/objc/objc_utility.h:
        * bridge/objc/objc_utility.mm:
        * bridge/runtime.cpp:
        * bridge/runtime.h:
        * bridge/runtime_array.cpp:
        * bridge/runtime_array.h:
        * bridge/runtime_method.cpp:
        * bridge/runtime_method.h:
        * bridge/runtime_object.cpp:
        * bridge/runtime_object.h:
        * bridge/runtime_root.cpp:
        * bridge/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Wed, 5 Mar 2008 02:09:04 +0000 (02:09 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17676
          <rdar://problem/5781091> REGRESSION (r30240-r30267): href attribute values with non-ASCII characters in the host part do not work

        Test: fast/encoding/url-host-name-non-ascii.html

        * platform/KURL.cpp:
        (WebCore::appendEncodedHostname): Added an early return in the all-ASCII
        case to avoid copying the host name twice and corrected the error
        checking after calling uidna_IDNToASCII().

LayoutTests:

        - test for http://bugs.webkit.org/show_bug.cgi?id=17676
          <rdar://problem/5781091> REGRESSION (r30240-r30267): href attribute values with non-ASCII characters in the host part do not work

        * fast/encoding/url-host-name-non-ascii-expected.txt: Added.
        * fast/encoding/url-host-name-non-ascii.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Tiger build.
timothy@apple.com [Wed, 5 Mar 2008 01:21:42 +0000 (01:21 +0000)]
Fix the Tiger build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dan Bernstein.
weinig@apple.com [Wed, 5 Mar 2008 01:02:41 +0000 (01:02 +0000)]
    Reviewed by Dan Bernstein.

        Use JSDOMWindow exclusively instead of JSDOMWindowBase.

        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScheduledAction.h:
        * bindings/js/kjs_window.cpp:
        (WebCore::JSDOMWindowBase::timerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
timothy@apple.com [Wed, 5 Mar 2008 00:57:26 +0000 (00:57 +0000)]
WebCore:

        Reviewed by Darin Adler.

        <rdar://problem/5720160> Browser windows "do nothing" while modal
        dialog or menu is up due to run loop modes (or while scrolling)

        Adds a new SchedulePair object that holds a runloop and the mode to use.
        A HashSet of SchedulePairs is tracked by Page so it can be used for resource
        loading and, in the future, maybe SharedTimerMac.

        * WebCore.base.exp: Add new exports for WebKit.
        * WebCore.xcodeproj/project.pbxproj: Add new files.
        * loader/mac/DocumentLoaderMac.cpp: Added.
        (WebCore::scheduleAll): Call schedule all the ResourceLoader handles.
        (WebCore::unscheduleAll): Call unschedule all the ResourceLoader handles.
        (WebCore::DocumentLoader::schedule): Schedule all the ResourceLoaders owned by the DocumentLoader.
        (WebCore::DocumentLoader::unschedule): Unschedule all the ResourceLoaders owned by the DocumentLoader.
        * loader/DocumentLoader.h:
        * page/Page.h:
        (WebCore::Page::scheduledRunLoopPairs): Return m_scheduledRunLoopPairs.
        * page/mac/PageMac.cpp:
        (WebCore::Page::addSchedulePair): Add a SchedulePair to m_scheduledRunLoopPairs.
        (WebCore::Page::removeSchedulePair): Removes a SchedulePair from m_scheduledRunLoopPairs.
        * platform/cf/SchedulePair.cpp: Added.
        * platform/cf/SchedulePair.h: Added.
        * platform/mac/SchedulePairMac.mm: Added.
        * platform/network/ResourceHandle.h:
        * platform/network/mac/FormDataStreamMac.mm:
        (WebCore::advanceCurrentStream): Use the new SchedulePair.
        (WebCore::formCreate): Ditto.
        (WebCore::formFinalize): Ditto.
        (WebCore::formSchedule): Ditto.
        (WebCore::formUnschedule): Ditto.
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start): Schedule the connection with all the SchedulePairs
        that Page holds. If Page has no SchedulePairs, schedule with the current runloop, and
        pick the mode based on ResourceHandle::loadsDuringCommonRunLoopModes.
        (WebCore::ResourceHandle::schedule):
        (WebCore::ResourceHandle::unschedule):

WebKit/mac:

        Reviewed by Darin Adler.

        <rdar://problem/5720160> Browser windows "do nothing" while modal
        dialog or menu is up due to run loop modes (or while scrolling)

        Add new API that lets a WebView be scheduled with multiple runloops and modes.
        This lets loading continue when in a nested runloop or in a different mode.

        * Misc/WebKitVersionChecks.h: Add a new version define:
        WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES.
        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with
        the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise.
        (-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page.
        (-[WebView unscheduleFromRunLoop:forMode:]): Ditto.
        * WebView/WebViewPrivate.h: Add the new pending API methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Eric.
zimmermann@webkit.org [Wed, 5 Mar 2008 00:53:11 +0000 (00:53 +0000)]
Reviewed by Eric.
Fix svg/dynamic-updates time-dependancy problem. Remove unneeded setTimeout() call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
weinig@apple.com [Wed, 5 Mar 2008 00:28:28 +0000 (00:28 +0000)]
    Reviewed by Darin Adler.

        Rename kjs_css to JSRGBColor.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSRGBColor.cpp: Copied from bindings/js/kjs_css.cpp.
        * bindings/js/JSRGBColor.h: Copied from bindings/js/kjs_css.h.
        * bindings/js/kjs_css.cpp: Removed.
        * bindings/js/kjs_css.h: Removed.
        * bindings/js/kjs_window.cpp:
        * bindings/objc/DOMUtility.mm:
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix 64-bit build.
andersca@apple.com [Wed, 5 Mar 2008 00:08:13 +0000 (00:08 +0000)]
    Fix 64-bit build.

        * html/HTMLPlugInElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago WebScriptDebugServer cleanup
aroben@apple.com [Wed, 5 Mar 2008 00:05:08 +0000 (00:05 +0000)]
     WebScriptDebugServer cleanup

         Reviewed by Anders.

         * WebScriptDebugServer.cpp: Renamed m_callingServer to
         m_callingListeners.
         (WebScriptDebugServer::WebScriptDebugServer):
         (WebScriptDebugServer::sharedWebScriptDebugServer): Changed to keep
         the shared instance as a function-level static.
         (WebScriptDebugServer::didLoadMainResourceForDataSource): Made return
         void.
         (WebScriptDebugServer::sourceParsed):
         (WebScriptDebugServer::callEvent):
         (WebScriptDebugServer::atStatement):
         (WebScriptDebugServer::returnEvent):
         (WebScriptDebugServer::exception):
         (WebScriptDebugServer::serverDidDie): Made return void.
         * WebScriptDebugServer.h:
           - Removed unnecessary #includes
           - Made inheritance from KJS::Debugger private
           - Made some methods private

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove WebScriptDebugger
aroben@apple.com [Wed, 5 Mar 2008 00:04:50 +0000 (00:04 +0000)]
     Remove WebScriptDebugger

         Reviewed by Anders.

         * WebKit.vcproj/WebKit.vcproj: Removed files from project.
         * WebScriptDebugServer.cpp:
         (frame): Moved here from WebScriptDebugger.cpp.
         (webFrame): Ditto.
         (webView): Ditto.
         (WebScriptDebugServer::WebScriptDebugServer): Initialize new member.
         * WebScriptDebugServer.h: Changed to inherit directly from
         KJS::Debugger instead of from WebScriptDebugger, and added
         m_callingServer member that WebScriptDebugger used to own.
         * WebScriptDebugger.cpp: Removed.
         * WebScriptDebugger.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move sourceParsed to WebScriptDebugServer
aroben@apple.com [Wed, 5 Mar 2008 00:04:31 +0000 (00:04 +0000)]
     Move sourceParsed to WebScriptDebugServer

         Reviewed by Anders.

         * WebScriptDebugServer.cpp:
         (WebScriptDebugServer::sourceParsed): Moved here from
         WebScriptDebugger and merged with didParseSource/failedToParseSource.
         * WebScriptDebugServer.h: Removed didParseSource/failedToParseSource.
         * WebScriptDebugger.cpp: Removed sourceParsed.
         * WebScriptDebugger.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move callEvent, returnEvent, and exception to WebScriptDebugServer
aroben@apple.com [Wed, 5 Mar 2008 00:04:11 +0000 (00:04 +0000)]
 Move callEvent, returnEvent, and exception to WebScriptDebugServer

 WebCore:

         Add ExecState.h to ForwardingHeaders

         Reviewed by Anders.

         * ForwardingHeaders/kjs/ExecState.h: Added.
         * page/Page.cpp: Touch this to force WebCore to build and the headers
         to be copied.

 WebKit/win:

         Move callEvent, returnEvent, and exception to WebScriptDebugServer

         Reviewed by Anders.

         * WebScriptDebugServer.cpp:
         (WebScriptDebugServer::callEvent): Moved here from WebScriptDebugger
         and merged with didEnterCallFrame.
         (WebScriptDebugServer::returnEvent): Ditto for willLeaveCallFrame.
         (WebScriptDebugServer::exception): Ditto for exceptionWasRaised.
         * WebScriptDebugServer.h: Removed didEnterCallFrame,
         willLeaveCallFrame, and exceptionWasRaised.
         * WebScriptDebugger.cpp: Removed callEvent, returnEvent, and
         exception.
         * WebScriptDebugger.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move atStatement to WebScriptDebugServer
aroben@apple.com [Wed, 5 Mar 2008 00:03:37 +0000 (00:03 +0000)]
     Move atStatement to WebScriptDebugServer

         Reviewed by Anders.

         * WebScriptDebugServer.cpp:
         (WebScriptDebugServer::atStatement): Moved here and merged with the
         old willExecuteStatement method.
         * WebScriptDebugServer.h: Removed inheritance from
         IWebScriptDebugListener, which no one was relying on.
         * WebScriptDebugger.cpp:
         (webFrame): Made non-static.
         (webView): Ditto.
         * WebScriptDebugger.h: Added declarations of webFrame and webView
         methods for WebScriptDebugServer's benefit. Removed unused m_webView
         and m_frame members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Start to merge WebScriptDebugger and WebScriptDebugServer
aroben@apple.com [Wed, 5 Mar 2008 00:02:54 +0000 (00:02 +0000)]
     Start to merge WebScriptDebugger and WebScriptDebugServer

         WebScriptDebugServer now inherits from WebScriptDebugger.

         Reviewed by Anders.

         * WebScriptDebugServer.cpp:
         (WebScriptDebugServer::pageCreated): Use sharedWebScriptDebugServer
         instead of WebScriptDebugger::shared.
         (WebScriptDebugServer::addListener): Ditto.
         (WebScriptDebugServer::removeListener): Ditto.
         * WebScriptDebugServer.h: Changed to inherit from WebScriptDebugger.
         * WebScriptDebugger.cpp: Removed shared method.
         * WebScriptDebugger.h: Made constructor/destructor protected, and
         removed shared method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMac build fix. Add new symbol to exports file.
mrowe@apple.com [Tue, 4 Mar 2008 23:43:11 +0000 (23:43 +0000)]
Mac build fix.  Add new symbol to exports file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Eric & David.
zimmermann@webkit.org [Tue, 4 Mar 2008 23:21:50 +0000 (23:21 +0000)]
Reviewed by Eric & David.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17078
Fix getSubStringLength() handling, verified by Acid3 test 77.
Brings up Acid3 score to 88/100.

Added test: svg/custom/acid3-test-77.html
            svg/custom/getSubStringLength.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Mac build fix. Neither me, Sam nor Adam know why we need to do this though :(
andersca@apple.com [Tue, 4 Mar 2008 23:07:04 +0000 (23:07 +0000)]
    Mac build fix. Neither me, Sam nor Adam know why we need to do this though :(

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::attachDebugger):
        * page/Page.cpp:
        (WebCore::Page::setDebuggerForAllPages):
        (WebCore::Page::setDebugger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca@apple.com [Tue, 4 Mar 2008 22:35:27 +0000 (22:35 +0000)]
    Reviewed by Darin.

        Fix crash that happens when trying to load a page with a Java applet.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        Don't release the names and values array - the kit method returns an autoreleased array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move debugger-attaching code from WebKit/win to WebCore
aroben@apple.com [Tue, 4 Mar 2008 22:26:17 +0000 (22:26 +0000)]
 Move debugger-attaching code from WebKit/win to WebCore

 WebCore:

         Make it possible to set a KJS::Debugger on all Frames in a Page and
         all Pages in the process

         Reviewed by Kevin M.

         * ForwardingHeaders/kjs/debugger.h: Added.
         * bindings/js/kjs_proxy.cpp:
         (WebCore::KJSProxy::initScript): Attach the Page's debugger if there
         is one.
         (WebCore::KJSProxy::attachDebugger): Attach the passed-in debugger, or
         detach any existing debugger if none was passed in.
         * bindings/js/kjs_proxy.h:
         * page/Page.cpp:
         (WebCore::Page::Page): Initialize new member.
         (WebCore::Page::setDebuggerForAllPages): Call setDebugger on each Page
         in the process.
         (WebCore::Page::setDebugger): Store the debugger and pass it off to
         all our Frames.
         * page/Page.h:

 WebKit/win:

         Use WebCore's new debugger-attaching code

         Reviewed by Kevin M.

         * WebCoreSupport/WebFrameLoaderClient.cpp: Moved a kit() function to
         WebView.{cpp,h} so that other files can call it.
         * WebFrame.cpp:
         (WebFrame::WebFrame): Removed m_scriptDebugger member.
         (WebFrame::windowObjectCleared): Removed attach/detach calls. This is
         no longer needed because WebScriptDebugger no longer stores any
         per-WebFrame state.
         * WebFrame.h:
         * WebScriptDebugServer.cpp:
         (WebScriptDebugServer::pageCreated): Added. Attaches our shared
         debugger to the Page if we have any listeners.
         (WebScriptDebugServer::addListener): Sets our shared debugger for all
         Pages when we get our first listener.
         (WebScriptDebugServer::removeListener): Removes our shared debugger
         from all Pages when we lose our last listener.
         * WebScriptDebugServer.h:
         * WebScriptDebugger.cpp:
         (WebScriptDebugger::shared): Added.
         (WebScriptDebugger::WebScriptDebugger): Removed m_frame member.
         (WebScriptDebugger::~WebScriptDebugger): Added.
         (frame): Gets a Frame from an ExecState.
         (webFrame): Gets a WebFrame from an ExecState.
         (webView): Gets a WebView from an ExecState.
         (WebScriptDebugger::sourceParsed): Changed to call webFrame() and
         webView() instead of using m_frame and m_webView members.
         (WebScriptDebugger::callEvent): Ditto.
         (WebScriptDebugger::atStatement): Ditto.
         (WebScriptDebugger::returnEvent): Ditto.
         (WebScriptDebugger::exception): Ditto.
         * WebScriptDebugger.h:
         * WebView.cpp:
         (kit): Moved here from WebFrameLoaderClient.cpp.
         (WebView::initWithFrame): Tell the WebScriptDebugServer about the new
         Page so it can attach a debugger if needed.
         * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Tue, 4 Mar 2008 22:05:52 +0000 (22:05 +0000)]
WebCore:

        Reviewed by Darin Adler.

        Add ClassInfo to custom constructors so that they toString properly

        - Take this chance to remove the "Imp" from the end of JSXMLHttpRequestConstructorImp,
          and XSLTProcessorConstructorImp and prefix all the classes with JS.

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::): Added ClassInfo definition.
        (WebCore::JSAudioConstructor::JSAudioConstructor):
        (WebCore::JSAudioConstructor::construct): Cleanup.
        * bindings/js/JSAudioConstructor.h: Rename m_doc to m_document.
        (WebCore::JSAudioConstructor::classInfo): Added.

        * bindings/js/JSHTMLInputElementBase.cpp: Rename HTMLInputElementBasePrototype
        to JSHTMLInputElementBasePrototype as seen if toString'ed.
        (WebCore::):

        * bindings/js/JSHTMLOptionElementConstructor.cpp:
        (WebCore::): Added ClassInfo definition.
        * bindings/js/JSHTMLOptionElementConstructor.h:
        (WebCore::JSHTMLOptionElementConstructor::classInfo): Added.

        * bindings/js/JSImageConstructor.cpp:
        (WebCore::): Added ClassInfo definition.
        (WebCore::JSImageConstructor::implementsConstruct): Moved here from header.
        * bindings/js/JSImageConstructor.h:
        (WebCore::JSImageConstructor::classInfo): Added.

        * bindings/js/JSXMLHttpRequest.cpp:
        (WebCore::): Rename XMLHttpRequestPrototype  to JSXMLHttpRequestPrototype
        as seen if toString'ed.
        (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
        (WebCore::JSXMLHttpRequestConstructor::implementsConstruct):
        (WebCore::JSXMLHttpRequestConstructor::construct):
        * bindings/js/JSXMLHttpRequest.h: Renamed JSXMLHttpRequestConstructorImp to
        JSXMLHttpRequestConstructor and doc to m_document and
        (WebCore::JSXMLHttpRequestConstructor::classInfo): Added.

        * bindings/js/JSXSLTProcessor.cpp:
        (WebCore::): Renamed XSLTProcessorPrototype to JSXSLTProcessorPrototype and
        XSLTProcessorConstructorImp to JSXSLTProcessorConstructor.
        (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
        (WebCore::JSXSLTProcessorConstructor::implementsConstruct):
        (WebCore::JSXSLTProcessorConstructor::construct):
        * bindings/js/JSXSLTProcessor.h:
        (WebCore::JSXSLTProcessorConstructor::classInfo): Added.

        * bindings/js/kjs_window.cpp:
        (WebCore::JSDOMWindowBase::getValueProperty): Fixed to work with the new class names.

WebKitTools:

        Reviewed by Darin Adler.

        * Scripts/do-webcore-rename: Update renaming plan.

LayoutTests:

        Reviewed by Darin Adler.

        Update results for fixed class names.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/xmlhttprequest-get-expected.txt:
        * http/tests/xmlhttprequest/event-target-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 4 Mar 2008 21:12:31 +0000 (21:12 +0000)]
WebCore:

        Reviewed by Oliver Hunt and Geoffrey Garen.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17667
          <rdar://problem/5779658> REGRESSION (r30587): Document::implicitClose() not called when done loading page (Image does not get scaled to fit)

        * loader/loader.cpp:
        (WebCore::Loader::didFinishLoading): Changed to call
        setLoadInProgress(false) even for 4xx errors, because that triggers
        load completion check.

LayoutTests:

        Reviewed by Oliver Hunt and Geoffrey Garen.

        - extended test to cover http://bugs.webkit.org/show_bug.cgi?id=17667
          <rdar://problem/5779658> REGRESSION (r30587): Document::implicitClose() not called when done loading page (Image does not get scaled to fit)

        * http/tests/misc/missing-style-sheet-expected.txt:
        * http/tests/misc/missing-style-sheet.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele@apple.com [Tue, 4 Mar 2008 21:09:07 +0000 (21:09 +0000)]
WebCore:

        Reviewed by Beth.

        Fix for <rdar://problem/5779718> focus() does not work for anchor elements with no content

        If an anchor has zero size, don't exclude it from being focusable from JS, just exclude it
        from being keyboard focusable (using the tab key).

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::isFocusable):
        (WebCore::HTMLAnchorElement::isKeyboardFocusable):

LayoutTests:

        Reviewed by Beth.

        Test for <rdar://problem/5779718> focus() does not work for anchor elements with no content

        * fast/events/anchor-empty-focus-expected.txt: Added.
        * fast/events/anchor-empty-focus.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/5119360> ER - Seed: Google results do not have AXHeading information
cfleizach@apple.com [Tue, 4 Mar 2008 19:36:01 +0000 (19:36 +0000)]
<rdar://problem/5119360> ER - Seed: Google results do not have AXHeading information

Make headers appear in AX regardless of whether they have BlockFlow renderers or not

Reviewed by Darin Adler.

* page/mac/WebCoreAXObject.mm:
(headingLevel): no longer ignores BlockFlow rendered headers
(-[WebCoreAXObject accessibilityIsIgnored]): does not ignore headers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to be...
aroben@apple.com [Tue, 4 Mar 2008 19:15:16 +0000 (19:15 +0000)]
    * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to be omitted from the hunk header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change WebView's string-finding methods to call through to Page
aroben@apple.com [Tue, 4 Mar 2008 17:59:28 +0000 (17:59 +0000)]
     Change WebView's string-finding methods to call through to Page

         These methods were added to Page back in r28878 (and the
         implementation was copied from WebView!) but we never switched over to
         using them.

         Reviewed by Sam.

         * WebView.cpp:
         (WebView::searchFor): Call through to Page::findString.
         (WebView::markAllMatchesForText): Call through to Page.
         (WebView::unmarkAllTextMatches): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago GTK+ build fix.
weinig@apple.com [Tue, 4 Mar 2008 17:57:18 +0000 (17:57 +0000)]
    GTK+ build fix.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
weinig@apple.com [Tue, 4 Mar 2008 17:46:01 +0000 (17:46 +0000)]
    Reviewed by Darin Adler.

        Remame ImageConstructorImp to JSImageConstructor and move it into its
        own file.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSImageConstructor.cpp: Copied from bindings/js/kjs_html.cpp.
        (WebCore::JSImageConstructor::JSImageConstructor):
        (WebCore::JSImageConstructor::construct):
        * bindings/js/JSImageConstructor.h: Copied from bindings/js/kjs_html.h.
        * bindings/js/kjs_html.cpp:
        (WebCore::getRuntimeObject): Make this function static since it is only used
        in this file.
        * bindings/js/kjs_html.h:
        * bindings/js/kjs_window.cpp:
        (WebCore::JSDOMWindowBase::getValueProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
darin@apple.com [Tue, 4 Mar 2008 17:24:42 +0000 (17:24 +0000)]
    Reviewed by Adam.

        - fix 200+ failing regression tests
        - fix http://bugs.webkit.org/show_bug.cgi?id=17668
          Vertical scrollbar at slashdot.org is randomly not shown

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting
        code here to exactly match the way it was before it was moved from WebCore. I had
        introduced a storage leak and that was causing problems with scroll bars!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix an uninitialized value warning in CodeGeneratorJS.pm
aroben@apple.com [Tue, 4 Mar 2008 17:21:44 +0000 (17:21 +0000)]
    Fix an uninitialized value warning in CodeGeneratorJS.pm

        * bindings/scripts/CodeGeneratorJS.pm: Remove reference to
        non-existent $maybeOkParam (this was removed in r30753).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
weinig@apple.com [Tue, 4 Mar 2008 17:02:20 +0000 (17:02 +0000)]
    Reviewed by Darin Adler.

        Remove kjs_dom.{h,cpp}.

        - Removed custom toAttr, which took a boolean ok, and teach CodeGeneratorJS.pm
          to us a null return value as an indication of failure. (This new logic is used
          for toVoidCallback as well.)
        - Move getRuntimeObject to kjs_html where a bunch of other runtime object related
          functions currently live.
        - Move checkNodeSecurity to kjs_binding, where other frame security functions
          currently live.
        - Remove getNodeConstructor.  It had no implementation.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSAttrCustom.cpp:
        * bindings/js/JSCustomVoidCallback.cpp:
        (WebCore::toVoidCallback):
        * bindings/js/JSCustomVoidCallback.h:
        * bindings/js/JSDatabaseCustom.cpp:
        (WebCore::JSDatabase::changeVersion):
        (WebCore::JSDatabase::transaction):
        * bindings/js/JSElementCustom.cpp:
        (WebCore::JSElement::setAttributeNode):
        (WebCore::JSElement::setAttributeNodeNS):
        * bindings/js/JSEventTargetBase.cpp:
        (WebCore::toJS):
        * bindings/js/JSEventTargetBase.h:
        * bindings/js/JSHTMLAppletElementCustom.cpp:
        * bindings/js/JSHTMLElementCustom.cpp:
        * bindings/js/JSHTMLEmbedElementCustom.cpp:
        * bindings/js/JSHTMLFormElementCustom.cpp:
        * bindings/js/JSHTMLFrameElementCustom.cpp:
        * bindings/js/JSHTMLIFrameElementCustom.cpp:
        * bindings/js/JSHTMLObjectElementCustom.cpp:
        * bindings/js/JSNamedNodeMapCustom.cpp:
        * bindings/js/JSNamedNodesCollection.cpp:
        * bindings/js/JSNodeFilterCustom.cpp:
        * bindings/js/JSXSLTProcessor.cpp:
        * bindings/js/kjs_binding.cpp:
        (WebCore::checkNodeSecurity):
        * bindings/js/kjs_binding.h:
        * bindings/js/kjs_css.cpp:
        * bindings/js/kjs_dom.cpp: Removed.
        * bindings/js/kjs_dom.h: Removed.
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_html.cpp:
        (WebCore::getRuntimeObject):
        * bindings/js/kjs_html.h:
        * bindings/js/kjs_window.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Attr.idl:
        * html/HTMLPlugInElement.cpp:
        * page/InspectorController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Actually pause the process while Drosera is at a breakpoint
aroben@apple.com [Tue, 4 Mar 2008 17:00:22 +0000 (17:00 +0000)]
     Actually pause the process while Drosera is at a breakpoint

         WebScriptDebugServer::suspendProcessIfPaused is supposed to pause the
         process while Drosera is at a breakpoint. Previously we were just
         starting a message pump that would deliver messages to all windows in
         the process, allowing mouse events, JS timers, etc. to execute.

         Now we only deliver messages to COM's message window, which is all we
         need to allow RPC to function.

         Reviewed by Anders.

         * WebScriptDebugServer.cpp:
         (comMessageWindow): Added. Finds COM's message window.
         (WebScriptDebugServer::suspendProcessIfPaused): Only deliver messages
         to COM's message window so that mouse events, JS timers, etc., won't
         execute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Generate WebScriptCallFrame instances dynamically
aroben@apple.com [Tue, 4 Mar 2008 17:00:04 +0000 (17:00 +0000)]
    Generate WebScriptCallFrame instances dynamically

        WebScriptDebugger no longer holds a reference to the topmost call
        frame, and WebScriptCallFrame no longer holds a reference to its
        caller. We now generate WebScriptCallFrame instances as needed by
        walking the callingExecState chain.

        By making WebKit no longer responsible for keeping track of the call
        stack, we get one step closer to moving most JS debugging code out of
        WebKit entirely.

        This incidentally fixes a bug in Drosera where we'd never show the
        global scope in the call stack.

        Reviewed by Sam and Kevin M.

        * WebScriptCallFrame.cpp:
        (callingFunctionOrGlobalExecState): Finds the nearest calling
        ExecState that is a FunctionExecState or GlobalExecState, if any, and
        returns it.
        (WebScriptCallFrame::WebScriptCallFrame):
          - No longer takes a caller parameter.
          - Sets m_state to the callingFunctionOrGlobalExecState of the
            ExecState passed in.
        (WebScriptCallFrame::createInstance): Removed the caller parameter.
        (WebScriptCallFrame::caller): Generate a new WebScriptCallFrame on the
        fly from our ExecState.
        * WebScriptCallFrame.h: No longer holds a reference to the caller.
        * WebScriptDebugger.cpp:
        (WebScriptDebugger::WebScriptDebugger): Removed the call to callEvent
        that was supposed to set up the global scope call frame, but never
        worked because m_callingServer was set to true, which would cause
        callEvent to return early without doing anything. Also removed the
        m_callingServer guards since we're not calling callEvent anymore.
        (WebScriptDebugger::callEvent): Create a WebScriptCallFrame on the
        fly from the passed-in ExecState.
        (WebScriptDebugger::atStatement): Ditto.
        (WebScriptDebugger::returnEvent): Ditto, but use the callingExecState.
        This is equivalent to what calling leaveFrame() did before.
        (WebScriptDebugger::exception): Ditto, using the passed-in ExecState.
        * WebScriptDebugger.h: Removed m_topStackFrame member and
        enterFrame/leaveFrame methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Win/Qt/GTK+/wx build fix after r30740
aroben@apple.com [Tue, 4 Mar 2008 16:59:43 +0000 (16:59 +0000)]
    Win/Qt/GTK+/wx build fix after r30740

        * editing/Editor.cpp: Added missing #include.
        * page/qt/FrameQt.cpp: Removed Frame::dashboardRegionsChanged.
        * page/win/FrameWin.cpp: Ditto.
        * platform/wx/TemporaryLinkStubs.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 4 Mar 2008 16:57:03 +0000 (16:57 +0000)]
2008-03-04  Alp Toker  <alp@atoker.com>

        GTK+ build fix for breakage introduced in r30740.

        Remove Frame::dashboardRegionsChanged(). There's now a default
        implementation at ChromeClient::dashboardRegionsChanged().

        * page/gtk/FrameGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 4 Mar 2008 16:49:48 +0000 (16:49 +0000)]
2008-03-04  Alp Toker  <alp@atoker.com>

        GTK+ build fix suggested by aroben. Remove an unused Mac-specific
        included introduced in r30740.

        * page/ChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 4 Mar 2008 16:03:02 +0000 (16:03 +0000)]
WebCore:

        Reviewed by Sam Weinig.

        - fix <rdar://problem/5622336> Burmese text does not render on http://www.myanmarbible.com/bible/Judson/html/index.html

        Test: platform/win/fast/text/uniscribe-missing-glyph.html

        Note that default installations of Windows do not have Myanmar fonts.
        What this patch does is ensure that the Myanmar and other complex
        scripts are rendered as missing glyphs rather than not rendered at all.
        The particular page in the bug measures the relative widths of two
        rendered strings and, if they are rendered as missing glyphs, detects
        that a Myanmar fonts is not available and substitutes the text with
        images. By not rendering (and measuring) missing glyphs, WebKit was
        throwing the page's detection code off.

        * platform/graphics/win/UniscribeController.cpp:
        (WebCore::UniscribeController::shape): Removed an early return in case
        shaping resulted in missing glyphs. This is now expected if font
        fallback failed to produce a font containing glyphs for the character.
        Also changed two resize()s to shrink()s.

LayoutTests:

        - test for <rdar://problem/5622336> Burmese text does not render on http://www.myanmarbible.com/bible/Judson/html/index.html

        * platform/win/fast/text/uniscribe-missing-glyph-expected.txt: Added.
        * platform/win/fast/text/uniscribe-missing-glyph.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:34:24 +0000 (15:34 +0000)]
WebCore:

        Reviewed by Adam.

        - remove WebCoreFrameBridge reapplyStyles method

        * WebCore.base.exp: Added exports.
        * page/mac/WebCoreFrameBridge.h: Removed WebCoreDeviceType and
        reapplyStylesForDeviceType: method.
        * page/mac/WebCoreFrameBridge.mm: Ditto.

WebKit/mac:

        Reviewed by Adam.

        - remove WebCoreFrameBridge reapplyStyles method

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:29:08 +0000 (15:29 +0000)]
WebCore:

        Reviewed by Adam.

        - eliminate WebCoreFrameBridge createFrameViewWithNSView

        * WebCore.base.exp: Added some more exports.
        * page/mac/WebCoreFrameBridge.h: Deleted createFrameViewWithNSView.
        * page/mac/WebCoreFrameBridge.mm: Ditto.

WebKit/mac:

        Reviewed by Adam.

        - eliminate WebCoreFrameBridge createFrameViewWithNSView

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::transitionToCommittedForNewPage):
        Moved code here from createFrameViewWithNSView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:24:43 +0000 (15:24 +0000)]
WebCore:

        Reviewed by Adam.

        - removed WebCoreFrameBridge scrollOverflowInDirection

        * WebCore.base.exp: Export function needed by WebKit.
        * page/mac/WebCoreFrameBridge.h: Removed WebScrollDirection, WebScrollGranularity,
        and scrollOverflowInDirection.
        * page/mac/WebCoreFrameBridge.mm: Removed method.

WebKit/mac:

        Reviewed by Adam.

        - removed WebCoreFrameBridge scrollOverflowInDirection

        * WebView/WebFrameView.mm:
        (-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call
        EventHandler directly instead of using the bridge.
        (-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead
        of the ones from the bridge.
        (-[WebFrameView scrollToEndOfDocument:]): Ditto.
        (-[WebFrameView _pageVertically:]): Ditto.
        (-[WebFrameView _pageHorizontally:]): Ditto.
        (-[WebFrameView _scrollLineVertically:]): Ditto.
        (-[WebFrameView _scrollLineHorizontally:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:21:42 +0000 (15:21 +0000)]
WebCore:

        Reviewed by Adam.

        - remove WebCoreFrameBridge installInFrame: method

        * WebCore.base.exp: Export a few symbols.
        * WebCore.xcodeproj/project.pbxproj: Export a few files.
        * page/mac/WebCoreFrameBridge.h: Remove installInFrame:.
        * page/mac/WebCoreFrameBridge.mm: Ditto.

WebKit/mac:

        Reviewed by Adam.

        - remove WebCoreFrameBridge installInFrame: method

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
        -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
        * WebView/WebFrameView.mm:
        (-[WebFrameView _install]): Added. Has code from -[WebCoreFrameBridge installInFrame:].
        (-[WebFrameView _setCustomScrollViewClass:]): Used early return idiom so the entire
        method isn't nested inside an if statement. Call
        -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
        * WebView/WebFrameViewInternal.h: Added declaration of _install method so it can be
        used in WebFrameLoaderClient.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:20:16 +0000 (15:20 +0000)]
WebCore:

        Reviewed by Adam.

        - remove WebCoreFrameBridge window method

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): Get the window by calling
        window on the NSView instead of using the bridge. The WebKit side wasn't doing anything
        special, so a call to -[NSView window] is fine.

        * page/mac/WebCoreFrameBridge.h: Removed the window method.

WebKit/mac:

        Reviewed by Adam.

        - remove WebCoreFrameBridge window method

        * WebCoreSupport/WebFrameBridge.mm: Removed window method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
darin@apple.com [Tue, 4 Mar 2008 15:17:35 +0000 (15:17 +0000)]
    Reviewed by Adam.

        - move code from WebFrameBridge into WebFrameLoaderClient

        * WebCoreSupport/WebFrameBridge.h: Removed unused fields, changed frame name parameters
        to use WebCore::String instead of NSString, add initSubframeWithOwnerElement declaration,
        removed viewForPluginWithFrame, viewForJavaAppletWithFrame, createChildFrameNamed,
        redirectDataToPlugin, determineObjectFromMIMEType, and windowObjectCleared methods.
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
        Changed to use WebCore::String.
        (-[WebFrameBridge initMainFrameWithPage:frameName:WebCore::frameView:]): Ditto.
        (-[WebFrameBridge initSubframeWithOwnerElement:frameName:WebCore::frameView:]): Ditto.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::setOriginalURLForDownload): Removed some dead code I found here
        and added a FIXME.
        (WebFrameLoaderClient::createFrame): Moved the code from WebFrameBridge here.
        (WebFrameLoaderClient::objectContentType): Ditto.
        (parameterValue): Added.  Helper function, based on code originally in WebFrameBridge.
        (pluginView): Ditto.
        (WebFrameLoaderClient::createPlugin): Moved the code from WebFrameBridge here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:10:30 +0000 (15:10 +0000)]
WebCore:

        Reviewed by Adam.

        - remove -[WebCoreFrameBridge dashboardRegionsChanged:]

        * WebCore.base.exp: Updated.
        * page/Chrome.cpp:
        (WebCore::ChromeClient::dashboardRegionsChanged): Added.
        * page/ChromeClient.h: Added virtual function for dashboardRegionsChanged.
        * page/Frame.h: Removed dashboardRegionsChanged function.
        * page/FrameView.cpp:
        (WebCore::FrameView::updateDashboardRegions): Changed to call dashboardRegionsChanged
        on ChromeClient and to only call it when the regions actually changed.
        * page/mac/FrameMac.mm: Removed dashboardRegionsChanged function.
        * page/mac/WebCoreFrameBridge.h: Removed dashboardRegionsChanged: method.

WebKit/mac:

        Reviewed by Adam.

        - remove -[WebCoreFrameBridge dashboardRegionsChanged:]

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::dashboardRegionsChanged): Moved code here from the bridge.
        The WebCore side now calls this only when there's an actual change.
        * WebCoreSupport/WebFrameBridge.h: Removed lastDashboardRegions.
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge dealloc]): Removed code to release lastDashboardRegions.
        Removed _compareDashboardRegions: and dashboardRegionsChanged: methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:07:48 +0000 (15:07 +0000)]
WebCore:

        Reviewed by Adam.

        - remove WebCoreFrameBridge issuePasteComand method

        * editing/Editor.cpp:
        (WebCore::Editor::paste): Moved the Mac-specific part of this to EditorMac.
        * editing/mac/EditorMac.mm:
        (WebCore::Editor::paste): Added. Calls paste: on the document view (normally a
        WebHTMLView). We should get rid of this eventually.
        * page/Frame.h: Removed issuePasteCommand.
        * page/mac/FrameMac.mm: Ditto.
        * page/mac/WebCoreFrameBridge.h: Ditto.

WebKit/mac:

        Reviewed by Adam.

        - remove WebCoreFrameBridge issuePasteComand method

        * WebCoreSupport/WebFrameBridge.mm: Removed issuePasteCommand method.
        * WebView/WebHTMLViewInternal.h: Removed declaration of paste: method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Suggested by Darin, rubber-stamped by Mark.
ap@webkit.org [Tue, 4 Mar 2008 09:11:35 +0000 (09:11 +0000)]
    Suggested by Darin, rubber-stamped by Mark.

        http://bugs.webkit.org/show_bug.cgi?id=17569
        REGRESSION (r30571): Buzzword.com doesn't load

        Rolling out r30571, as determining what is wrong with it proved tricky.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::tokenizerProcessedData):
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-04 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Tue, 4 Mar 2008 08:25:26 +0000 (08:25 +0000)]
2008-03-04  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Add a note about preferring if over else if when the previous if is terminated by a return statement.

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
weinig@apple.com [Tue, 4 Mar 2008 08:11:50 +0000 (08:11 +0000)]
    Build fix.

        * bindings/js/kjs_events.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Tue, 4 Mar 2008 07:48:53 +0000 (07:48 +0000)]
WebCore:

        Reviewed by Mark Rowe.

        Move JSClipboard into its own file.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSAttrCustom.cpp:
        * bindings/js/JSClipboardCustom.cpp: Added.
        (WebCore::JSClipboard::types):
        (WebCore::JSClipboard::clearData):
        (WebCore::JSClipboard::getData):
        (WebCore::JSClipboard::setData):
        (WebCore::JSClipboard::setDragImage):
        * bindings/js/JSElementCustom.cpp:
        * bindings/js/JSEventCustom.cpp:
        * bindings/js/JSHTMLFrameElementCustom.cpp:
        * bindings/js/JSHTMLIFrameElementCustom.cpp:
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_window.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Clipboard.cpp:
        (WebCore::Clipboard::setDropEffect):
        (WebCore::Clipboard::setEffectAllowed):
        * dom/Clipboard.idl: Added.

LayoutTests:

        Reviewed by Mark Rowe.

        Update test results.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago GTK+ build fix.
weinig@apple.com [Tue, 4 Mar 2008 06:20:31 +0000 (06:20 +0000)]
    GTK+ build fix.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::windowObjectCleared):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix.
weinig@apple.com [Tue, 4 Mar 2008 05:33:13 +0000 (05:33 +0000)]
    Windows build fix.

        * WebFrame.cpp:
        (WebFrame::windowObjectCleared):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build-fix.
weinig@apple.com [Tue, 4 Mar 2008 05:05:16 +0000 (05:05 +0000)]
    Windows build-fix.

        * page/Chrome.cpp:
        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
weinig@apple.com [Tue, 4 Mar 2008 03:08:30 +0000 (03:08 +0000)]
    Reviewed by Darin Adler.

        Cleanup and plumbing in preparation for the great Window split.

        - Rename KJS::Window to WebCore::JSDOMWindowBase.
        - Remove KJS::Window::retrieve() and KJS::Window::retrieveWindow() and replace
          with the new toJSDOMWindow().
        - Remove KJS::Window::retrieveActive() and replace with explicit call to
          exec->dynamicGlobalObject() and toJSDOMWindow().

        * bindings/js/JSCustomVoidCallback.cpp:
        (WebCore::toVoidCallback):.
        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::create):
        * bindings/js/JSDatabaseCustom.cpp:
        (WebCore::JSDatabase::changeVersion):
        (WebCore::JSDatabase::transaction):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::location):
        (WebCore::toJS):
        * bindings/js/JSEventTargetBase.cpp:
        (WebCore::jsEventTargetAddEventListener):
        (WebCore::jsEventTargetRemoveEventListener):
        * bindings/js/JSEventTargetNode.cpp:
        (WebCore::JSEventTargetNode::setListener):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::nameGetter):
        (WebCore::JSHTMLDocument::open):
        * bindings/js/JSHTMLFrameSetElementCustom.cpp:
        (WebCore::JSHTMLFrameSetElement::nameGetter):
        * bindings/js/JSLocation.cpp:
        (WebCore::JSLocation::put):
        (WebCore::jsLocationProtoFuncReplace):
        (WebCore::jsLocationProtoFuncReload):
        (WebCore::jsLocationProtoFuncAssign):
        * bindings/js/JSLocation.h:
        * bindings/js/JSSQLTransactionCustom.cpp:
        (WebCore::JSSQLTransaction::executeSql):
        * bindings/js/JSSVGLazyEventListener.cpp:
        (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener):
        (WebCore::JSSVGLazyEventListener::eventParameterName):
        * bindings/js/JSSVGLazyEventListener.h:
        * bindings/js/JSXMLHttpRequest.cpp:
        (WebCore::JSXMLHttpRequest::putValueProperty):
        (WebCore::jsXMLHttpRequestPrototypeFunctionOpen):
        (WebCore::jsXMLHttpRequestPrototypeFunctionAddEventListener):
        (WebCore::jsXMLHttpRequestPrototypeFunctionRemoveEventListener):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScheduledAction.h:
        * bindings/js/kjs_binding.cpp:
        (WebCore::allowsAccessFromFrame):
        (WebCore::printErrorMessageForFrame):
        * bindings/js/kjs_events.cpp:
        (WebCore::JSAbstractEventListener::handleEvent):
        (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
        (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
        (WebCore::JSUnprotectedEventListener::windowObj):
        (WebCore::JSEventListener::JSEventListener):
        (WebCore::JSEventListener::~JSEventListener):
        (WebCore::JSEventListener::windowObj):
        (WebCore::JSLazyEventListener::JSLazyEventListener):
        (WebCore::JSLazyEventListener::parseCode):
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_navigator.cpp:
        (WebCore::MimeType::getValueProperty):
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::evaluate):
        (WebCore::KJSProxy::createHTMLEventHandler):
        (WebCore::KJSProxy::createSVGEventHandler):
        * bindings/js/kjs_window.cpp:
        (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate):
        (WebCore::DOMWindowTimer::DOMWindowTimer):
        (WebCore::DOMWindowTimer::action):
        (WebCore::DOMWindowTimer::takeAction):
        (WebCore::):
        (WebCore::JSDOMWindowBase::JSDOMWindowBase):
        (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
        (WebCore::JSDOMWindowBase::location):
        (WebCore::JSDOMWindowBase::mark):
        (WebCore::allowPopUp):
        (WebCore::createWindow):
        (WebCore::showModalDialog):
        (WebCore::JSDOMWindowBase::getValueProperty):
        (WebCore::JSDOMWindowBase::childFrameGetter):
        (WebCore::JSDOMWindowBase::indexGetter):
        (WebCore::JSDOMWindowBase::namedItemGetter):
        (WebCore::JSDOMWindowBase::getOwnPropertySlot):
        (WebCore::JSDOMWindowBase::put):
        (WebCore::JSDOMWindowBase::allowsAccessFrom):
        (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
        (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
        (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
        (WebCore::JSDOMWindowBase::printErrorMessage):
        (WebCore::JSDOMWindowBase::globalExec):
        (WebCore::JSDOMWindowBase::shouldInterruptScript):
        (WebCore::JSDOMWindowBase::setListener):
        (WebCore::JSDOMWindowBase::getListener):
        (WebCore::JSDOMWindowBase::findJSEventListener):
        (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
        (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
        (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
        (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
        (WebCore::JSDOMWindowBase::clear):
        (WebCore::JSDOMWindowBase::setCurrentEvent):
        (WebCore::JSDOMWindowBase::currentEvent):
        (WebCore::windowProtoFuncAToB):
        (WebCore::windowProtoFuncBToA):
        (WebCore::windowProtoFuncOpen):
        (WebCore::windowProtoFuncSetTimeout):
        (WebCore::windowProtoFuncClearTimeout):
        (WebCore::windowProtoFuncSetInterval):
        (WebCore::windowProtoFuncAddEventListener):
        (WebCore::windowProtoFuncRemoveEventListener):
        (WebCore::windowProtoFuncShowModalDialog):
        (WebCore::windowProtoFuncNotImplemented):
        (WebCore::JSDOMWindowBase::setReturnValueSlot):
        (WebCore::JSDOMWindowBase::clearAllTimeouts):
        (WebCore::JSDOMWindowBase::installTimeout):
        (WebCore::JSDOMWindowBase::pauseTimeouts):
        (WebCore::JSDOMWindowBase::resumeTimeouts):
        (WebCore::JSDOMWindowBase::clearTimeout):
        (WebCore::JSDOMWindowBase::timerFired):
        (WebCore::JSDOMWindowBase::disconnectFrame):
        (WebCore::JSDOMWindowBase::jsEventListeners):
        (WebCore::JSDOMWindowBase::jsHTMLEventListeners):
        (WebCore::JSDOMWindowBase::jsUnprotectedEventListeners):
        (WebCore::JSDOMWindowBase::jsUnprotectedHTMLEventListeners):
        (WebCore::toJS):
        (WebCore::toJSDOMWindow):
        (WebCore::toJSDOMWindow):
        * bindings/js/kjs_window.h:
        (WebCore::JSDOMWindowBase::impl):
        (WebCore::JSDOMWindowBase::classInfo):
        (WebCore::JSDOMWindowBase::):
        * bindings/objc/DOMUtility.mm:
        (KJS::createDOMWrapper):
        * bindings/scripts/CodeGeneratorJS.pm:
        * history/CachedPage.cpp:
        (WebCore::CachedPage::CachedPage):
        (WebCore::CachedPage::restore):
        * page/Chrome.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
        * page/DOMWindow.idl:
        * page/Frame.cpp:
        (WebCore::Frame::~Frame):
        (WebCore::Frame::windowScriptNPObject):
        (WebCore::Frame::pageDestroyed):
        * page/InspectorController.cpp:
        (WebCore::inspectedWindow):
        * page/mac/FrameMac.mm:
        (WebCore::Frame::windowScriptObject):
        * page/mac/WebCoreFrameBridge.mm:
        (updateRenderingForBindings):
        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canAccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake ForInNode check for the timeout interrupt
oliver@apple.com [Tue, 4 Mar 2008 00:24:54 +0000 (00:24 +0000)]
Make ForInNode check for the timeout interrupt

Reviewed by Anders

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fixes after recent Frame-related changes.
kevino@webkit.org [Mon, 3 Mar 2008 23:08:53 +0000 (23:08 +0000)]
wx build fixes after recent Frame-related changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Mon, 3 Mar 2008 22:59:30 +0000 (22:59 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - make :first-letter apply to the first letter in normal flow, skipping
          floats and positioned objects

        Test: fast/css/first-letter-skip-out-of-flow.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter):

LayoutTests:

        Reviewed by Darin Adler.

        - test that :first-letter applies to the first letter in normal flow,
          skipping floats and positioned objects

        * fast/css/first-letter-skip-out-of-flow.html: Added.
        * platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.checksum: Added.
        * platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.png: Added.
        * platform/mac/fast/css/first-letter-skip-out-of-flow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix build.
adachan@apple.com [Mon, 3 Mar 2008 22:58:34 +0000 (22:58 +0000)]
    Fix build.

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-03 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Mon, 3 Mar 2008 22:43:57 +0000 (22:43 +0000)]
2008-03-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Fix http://bugs.webkit.org/show_bug.cgi?id=17313
        Bug 17313: querySelectorAll() causing crashes when called via dojo.query() wrapper

        Node::querySelector and SelectorNodeList were not sufficiently initializing the CSSStyleSelector
        before using it to resolve styles, which lead to it having a stale m_style member in some situations.
        This stale m_style member resulted in a wild store that would write over whatever object now resided
        at the location m_style pointed to.

        Test: fast/dom/SelectorAPI/bug-17313.html

        * dom/Node.cpp:
        (WebCore::Node::querySelector): Call initForStyleResolve to further initialize the CSSStyleSelector.
        * dom/SelectorNodeList.cpp:
        (WebCore::SelectorNodeList::SelectorNodeList): Ditto.

2008-03-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Test for http://bugs.webkit.org/show_bug.cgi?id=17313
        Bug 17313: querySelectorAll() causing crashes when called via dojo.query() wrapper

        * fast/dom/SelectorAPI/bug-17313-expected.txt: Added.
        * fast/dom/SelectorAPI/bug-17313.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-03 Brent Fulgham <bfulgham@gmail.com>
alp@webkit.org [Mon, 3 Mar 2008 22:06:52 +0000 (22:06 +0000)]
2008-03-03  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=17644
        Build GTK on Mac OS X using native ICU library

        Use Apple native ICU libraries when building GTK
        webkit on Mac OS.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin and Sam.
andersca@apple.com [Mon, 3 Mar 2008 21:53:58 +0000 (21:53 +0000)]
    Reviewed by Darin and Sam.

        Include fixes, in preparation of using the headers in WebCore/bridge.

        * bindings/js/kjs_binding.h:
        * bindings/js/kjs_dom.cpp:
        * bindings/objc/DOMInternal.mm:
        * bindings/objc/DOMUtility.mm:
        * bindings/objc/WebScriptObject.mm:
        * bindings/objc/WebScriptObjectPrivate.h:
        * bridge/objc/objc_class.h:
        * bridge/objc/objc_instance.h:
        * bridge/objc/objc_runtime.h:
        * bridge/objc/objc_utility.h:
        * bridge/runtime.h:
        * bridge/runtime_object.h:
        * bridge/runtime_root.h:
        * html/HTMLAppletElement.cpp:
        * html/HTMLAppletElement.h:
        * html/HTMLEmbedElement.cpp:
        * html/HTMLEmbedElement.h:
        * html/HTMLObjectElement.cpp:
        * html/HTMLPlugInElement.cpp:
        * html/HTMLPlugInElement.h:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:
        * page/mac/WebCoreScriptDebugger.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Mon, 3 Mar 2008 21:18:22 +0000 (21:18 +0000)]
WebCore:

        Full page zoom plumbing.  Add a notion of whether or not a zoom is text only or a full zoom to the
        Frame.  setTextSizeMultiplier does a text only zoom.

        Reviewed by Tim H.

        * page/Frame.cpp:
        (WebCore::Frame::zoomFactor):
        (WebCore::Frame::isZoomFactorTextOnly):
        (WebCore::Frame::setZoomFactor):
        (WebCore::FramePrivate::FramePrivate):
        * page/Frame.h:
        * page/FramePrivate.h:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge setTextSizeMultiplier:]):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::setCurrentScale):

WebKit/win:

        Full page zoom work.  Make setting of a zoom factor take a boolean saying whether it is a text only
        or full page zoom.

        Reviewed by Tim H.

        * WebFrame.cpp:
        (WebFrame::setTextSizeMultiplier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30719 268f45cc-cd09-0410-ab3c-d52691b4dbfc