WebKit-https.git
8 years agoVersioning.
lforschler@apple.com [Thu, 20 Dec 2012 04:07:42 +0000 (04:07 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild WebKit2ExportGenerator before WebKitLib
andersca@apple.com [Thu, 20 Dec 2012 02:00:32 +0000 (02:00 +0000)]
Build WebKit2ExportGenerator before WebKitLib
https://bugs.webkit.org/show_bug.cgi?id=105487

Reviewed by Tim Horton.

* WebKit.vcproj/WebKit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLeak in StringImpl::createCFString()
jonlee@apple.com [Thu, 20 Dec 2012 01:40:57 +0000 (01:40 +0000)]
Leak in StringImpl::createCFString()
https://bugs.webkit.org/show_bug.cgi?id=105485
<rdar://problem/12801963>

Reviewed by Anders Carlsson.

* platform/text/cf/StringImplCF.cpp:
(WTF::StringImpl::createCFString): Missing adoptCF()'s.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago <rdar://problem/12890242> [WK2 NetworkProcess] Client doesn't receive SSL...
ap@apple.com [Thu, 20 Dec 2012 00:58:25 +0000 (00:58 +0000)]
    <rdar://problem/12890242> [WK2 NetworkProcess] Client doesn't receive SSL certificates
        https://bugs.webkit.org/show_bug.cgi?id=105467

        Reviewed by Brady Eidson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix some incorrect tests in testapi.c
oliver@apple.com [Thu, 20 Dec 2012 00:50:48 +0000 (00:50 +0000)]
Fix some incorrect tests in testapi.c

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add new strings to GTK+'s implementation of
kov@webkit.org [Thu, 20 Dec 2012 00:40:01 +0000 (00:40 +0000)]
Unreviewed. Add new strings to GTK+'s implementation of
LocalizedStrings, using glib's context-aware macro.

* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore):
(WebCore::textTrackClosedCaptionsText):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffText):
(WebCore::textTrackNoLabelText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a function to set the origin hash table
jonlee@apple.com [Thu, 20 Dec 2012 00:38:22 +0000 (00:38 +0000)]
Add a function to set the origin hash table
https://bugs.webkit.org/show_bug.cgi?id=105447
<rdar://problem/12910985>

Reviewed by Brian Weinstein.

Add a new API called WKContextSetPlugInAutoStartOriginHashes. It assigns the table of hashes,
keyed by main frame origin, to the WebContext. That, in turn, notifies all existing web
processes, so that each web process can update its copy of the auto-start hashes.

* UIProcess/API/C/WKContext.cpp:
(WKContextSetPlugInAutoStartOriginHashes): To clear the table, an empty dictionary must be
provided.
* UIProcess/API/C/WKContext.h:

* UIProcess/WebContext.cpp:
(WebKit::WebContext::setPlugInAutoStartOriginHashes): Forward to PlugInAutoStartProvider.
* UIProcess/WebContext.h:

* UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTable): Clear the map and set of hashes,
and convert the data from the provided dictionary. Also add it to a temporary vector, which will
be used to pass along to all of the active web processes.
* UIProcess/Plugins/PlugInAutoStartProvider.h:

* WebProcess/WebProcess.messages.in: Add plugInAutoStartOriginsChanged. Takes in a vector of
the new set of hashes.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::plugInAutoStartOriginsChanged): Clear the existing set, and copy the new
hashes.
* WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSet the original resource's response even on a 304
simonjam@chromium.org [Thu, 20 Dec 2012 00:27:40 +0000 (00:27 +0000)]
Set the original resource's response even on a 304
https://bugs.webkit.org/show_bug.cgi?id=105373

Reviewed by Nate Chapin.

The existing setResponse was renamed to responseReceived to better reflect what it does. A new
setResponse was added that only sets the response. This is used in the 304 case.

No new tests. A new Resource Timing test will depend on this soon.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::responseReceived):
* loader/cache/CachedImage.h:
(CachedImage):
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::responseReceived):
* loader/cache/CachedRawResource.h:
(CachedRawResource):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::responseReceived):
* loader/cache/CachedResource.h:
(CachedResource):
(WebCore::CachedResource::setResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSObject::ensure<IndexingType> should gracefully handle InterceptsGetOwn..., and...
fpizlo@apple.com [Thu, 20 Dec 2012 00:19:03 +0000 (00:19 +0000)]
JSObject::ensure<IndexingType> should gracefully handle InterceptsGetOwn..., and should never be called when the 'this' is not an object
https://bugs.webkit.org/show_bug.cgi?id=105468

Reviewed by Mark Hahnenberg, Oliver Hunt, and Gavin Barraclough.

Source/JavaScriptCore:

Changed JSObject::ensure<IndexingType> methods to gracefully handle
InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero. Most of them handle it by returning
null as a result of indexingShouldBeSparse() returning true, while ensureArrayStorage handles it
by entering dictionary indexing mode, which forces the object to behave correctly even if there
is proxying or weird prototype stuff going on.

Changed DFGOperations entrypoints to reject non-objects, so that JSObject doesn't have to deal
with pretending to be JSString. In particular, this would go wrong in the ArrayStorage case
since we'd try to resize a butterfly on a JSString, but JSString has something other than
m_butterfly at that offset.

Finally, removed all InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero from JIT code
since those are now redundant.

* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::arrayify):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* runtime/JSObject.cpp:
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::ensureInt32Slow):
(JSC::JSObject::ensureDoubleSlow):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::ensureArrayStorageSlow):
(JSC):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
* runtime/JSObject.h:
(JSObject):

LayoutTests:

* fast/js/dfg-ensure-array-storage-on-string-expected.txt: Added.
* fast/js/dfg-ensure-array-storage-on-string.html: Added.
* fast/js/dfg-ensure-contiguous-on-string-expected.txt: Added.
* fast/js/dfg-ensure-contiguous-on-string.html: Added.
* fast/js/jsc-test-list
* fast/js/script-tests/dfg-ensure-array-storage-on-string.js: Added.
(foo):
* fast/js/script-tests/dfg-ensure-contiguous-on-string.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTidy up JSScriptRef API
oliver@apple.com [Wed, 19 Dec 2012 23:36:13 +0000 (23:36 +0000)]
Tidy up JSScriptRef API
https://bugs.webkit.org/show_bug.cgi?id=105470

Reviewed by Anders Carlsson.

People found the API's use of a context confusing, so we'll switch to a JSContextGroup based
API, and drop a number of the unnecessary uses of contexts.

* API/JSScriptRef.cpp:
(OpaqueJSScript::globalData):
(parseScript):
* API/JSScriptRefPrivate.h:
* API/tests/testapi.c:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] plugins/npp-set-window-called-during-destruction.html is flaky on Win
wjmaclean@chromium.org [Wed, 19 Dec 2012 23:27:27 +0000 (23:27 +0000)]
[chromium] plugins/npp-set-window-called-during-destruction.html is flaky on Win
http://crbug.com/78835

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] composited scrolling tests failing on Win
wjmaclean@chromium.org [Wed, 19 Dec 2012 23:21:09 +0000 (23:21 +0000)]
[chromium] composited scrolling tests failing on Win
https://bugs.webkit.org/show_bug.cgi?id=105471

Unreviewed gardening.

Mark tests as failing on Win:

platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content.html

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Regression] text-overflow ellipsis clips content when zoomed
eae@chromium.org [Wed, 19 Dec 2012 23:07:55 +0000 (23:07 +0000)]
[Regression] text-overflow ellipsis clips content when zoomed
https://bugs.webkit.org/show_bug.cgi?id=105456

Reviewed by Levi Weintraub.

Source/WebCore:

At certain zoom levels text-overflow ellipsis incorrectly clips
content and displays the ellipsis even though the full content
would fit.

Test: fast/sub-pixel/ellipsis-zoom.html

* rendering/RenderBlock.h:
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
Add bug url to FIXME.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkLinesForTextOverflow):
Pixel snap the content edge before comparing with the line box
edge as the line box edge is aligned to a pixel boundary.

LayoutTests:

Add test for text-overflow: ellipsis.

* fast/sub-pixel/ellipsis-zoom-expected.html: Added.
* fast/sub-pixel/ellipsis-zoom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse ElementTraversal in LiveNodeListBase
antti@apple.com [Wed, 19 Dec 2012 22:39:28 +0000 (22:39 +0000)]
Use ElementTraversal in LiveNodeListBase
https://bugs.webkit.org/show_bug.cgi?id=105324

Reviewed by Ryosuke Niwa.

Factor the code so that we get clean minimally branchy traversal functions for all the common cases.

This patch changes the more performance critical forward traversal only, backwards traversal is unaffected for now.

Instruments thinks it is a progression at least in DOM/DOMDivWalk.html. Bots should tell more.

* dom/ClassNodeList.cpp:
(WebCore::ClassNodeList::nodeMatches):
* dom/ClassNodeList.h:
(ClassNodeList):
(WebCore::ClassNodeList::create):
(WebCore):
(WebCore::ClassNodeList::nodeMatchesInlined):

    Add inlined version of the matching function for class lists.

* dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::rootContainerNode):

    Root is always ContainerNode if the list has anything in it. Traversal functions are slightly more
    efficient if we know we are operating on ContainerNodes.

(WebCore):
* dom/LiveNodeList.h:
(LiveNodeListBase):
(WebCore::LiveNodeListBase::shouldOnlyIncludeDirectChildren):
* dom/Node.cpp:
(WebCore::Node::getElementsByTagName):
* dom/TagNodeList.cpp:
(WebCore::TagNodeList::TagNodeList):
(WebCore::TagNodeList::~TagNodeList):
(WebCore::HTMLTagNodeList::HTMLTagNodeList):
(WebCore::HTMLTagNodeList::nodeMatches):
* dom/TagNodeList.h:
(WebCore):
(TagNodeList):
(WebCore::TagNodeList::create):
(HTMLTagNodeList):
(WebCore::HTMLTagNodeList::create):

    Use separate ContainerType enum value for HTMLTagNodeList so we can tell it apart from TagNodeList.

(WebCore::HTMLTagNodeList::nodeMatchesInlined):

    Add inlined version of the matching function for tag lists.

* html/CollectionType.h:
* html/HTMLCollection.cpp:
(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore):
(WebCore::isMatchingElement):

    List type templated matching functions for common cases.

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::previousNode):
(WebCore::lastNode):
(WebCore::LiveNodeListBase::iterateForPreviousNode):
(WebCore::LiveNodeListBase::itemBefore):

    Leave the backwards traversal unchanged for now but remove the forward traversal code.

(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::firstMatchingChildElement):
(WebCore::nextMatchingChildElement):
(WebCore::traverseMatchingElementsForwardToOffset):

    List type templated traversal functions with matching. Separate functions for first and subsequent elements

(WebCore::LiveNodeListBase::traverseChildNodeListForwardToOffset):
(WebCore::LiveNodeListBase::traverseLiveNodeListFirstElement):
(WebCore::LiveNodeListBase::traverseLiveNodeListForwardToOffset):

    LiveNodeList traversal, picking the right template.

(WebCore::LiveNodeListBase::item):
(WebCore::LiveNodeListBase::itemBeforeOrAfterCachedItem):

    Switch to new traversal functions.

(WebCore::HTMLCollection::traverseFirstElement):
(WebCore::HTMLCollection::traverseForwardToOffset):
(WebCore::HTMLCollection::traverseNextElement):

    HTMLCollection traversal, picking the right template.

(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):

    Switch to new traversal functions.

* html/HTMLCollection.h:
(HTMLCollection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStringImpl isolatedCopy unnecessarily copies text-segment character data
oliver@apple.com [Wed, 19 Dec 2012 21:59:25 +0000 (21:59 +0000)]
StringImpl isolatedCopy unnecessarily copies text-segment character data
https://bugs.webkit.org/show_bug.cgi?id=105376

Reviewed by Anders Carlsson.

This patch adds a new (private) helper to StringImpl that tests whether the StringImpl
is backed by an ASCII literal.  This allows isolatedCopy() to safely use the createFromLiteral
constructor rather than making an unnecessary copy.

* wtf/text/StringImpl.h:
(StringImpl):
(WTF::StringImpl::isASCIILiteral):
(WTF::StringImpl::isolatedCopy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Calculate correct word offsets for form elements.
nghanavatian@rim.com [Wed, 19 Dec 2012 21:32:15 +0000 (21:32 +0000)]
Calculate correct word offsets for form elements.
    https://bugs.webkit.org/show_bug.cgi?id=105354

    Reviewed by Rob Buis.

    PR266117
    We need to calculate correct offsets for form elements, such as
    textareas, relative to the start of the field. This allows for correct
    spell checking of words in a textarea element after line breaks.

    Internally reviewed by Mike Fenton.

    * WebKitSupport/InputHandler.cpp:
    (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPerfTest.parse_output does too much
rniwa@webkit.org [Wed, 19 Dec 2012 21:31:11 +0000 (21:31 +0000)]
PerfTest.parse_output does too much
https://bugs.webkit.org/show_bug.cgi?id=105391

Reviewed by Tony Chang.

Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
Also moved the code to output test results into PerfTest._run_with_driver.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.__init__): Added _description.
(PerfTest.description): Added.
(PerfTest._run_with_driver): Moved the code to output test description and test results.
(PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
(PerfTest.parse_output): Removed the code to output test results. Return test results and description
respectively. Also removed the code that allowed some tests to omit values since all tests report each
iteration now since r136492.
(PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
(ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
(ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
(PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
(MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
so that it's not string-concatenated with the next line.
(MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
(MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago <rdar://problem/12896478> Cannot log into gmail/facebook with NetworkProcess...
ap@apple.com [Wed, 19 Dec 2012 21:06:03 +0000 (21:06 +0000)]
    <rdar://problem/12896478> Cannot log into gmail/facebook with NetworkProcess and private browsing enabled
        https://bugs.webkit.org/show_bug.cgi?id=105454

        Reviewed by Brady Eidson.

        Request was using a wrong session after a redirect, because session cannot be
        preserved over IPC.

        Just set the storage session after calling the client, it is not really meaningful
        for a client to change session behind WebKit's back.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::willSendRequest):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::willSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWTF String from ASCIILiteral fails to correctly handle empty strings.
oliver@apple.com [Wed, 19 Dec 2012 20:17:25 +0000 (20:17 +0000)]
WTF String from ASCIILiteral fails to correctly handle empty strings.
https://bugs.webkit.org/show_bug.cgi?id=105453

Reviewed by Anders Carlsson.

When we have an zero length literal we should return the empty StringImpl.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::createFromLiteral):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRe-skipping touch-input-element-chang-documents.html since it's still
leviw@chromium.org [Wed, 19 Dec 2012 20:03:12 +0000 (20:03 +0000)]
Re-skipping touch-input-element-chang-documents.html since it's still
failing on qt and efl.

* platform/efl/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNotify context client of change to table, and allow client to get a copy of it
jonlee@apple.com [Wed, 19 Dec 2012 20:01:53 +0000 (20:01 +0000)]
Notify context client of change to table, and allow client to get a copy of it
https://bugs.webkit.org/show_bug.cgi?id=105364
<rdar://problem/12906267>

Reviewed by Brady Eidson.

Add a callback to notify the context client that the origin hashes have changed.
The client may choose to get a copy of that table and save it to disk.

* UIProcess/API/C/WKContext.cpp:
(WKContextCopyPlugInAutoStartOriginHashes): Added to the context client.
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::plugInAutoStartOriginHashes): Return a copy of the origin hash
table.
* UIProcess/WebContext.h:

* UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::PlugInAutoStartProvider::addAutoStartOrigin): When the origin is added to
the table, notify the context client.
(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy): Create a copy of the
table.
* UIProcess/Plugins/PlugInAutoStartProvider.h:

* UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::plugInAutoStartOriginHashesChanged): Call the client.
* UIProcess/WebContextClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement CSS parsing for CSS transitions unprefixed.
alexis@webkit.org [Wed, 19 Dec 2012 19:35:57 +0000 (19:35 +0000)]
Implement CSS parsing for CSS transitions unprefixed.
https://bugs.webkit.org/show_bug.cgi?id=104804

Reviewed by Dean Jackson.

.:

Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to cover the work of unprefixing Transforms, Animations and
Transitions. It will let the possibility of each ports to turn it off
in their release branches until we're confident that these CSS
properties are ready to be unprefixed.

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/JavaScriptCore:

Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to cover the work of unprefixing Transforms, Animations and
Transitions. It will let the possibility of each ports to turn it off
in their release branches until we're confident that these CSS
properties are ready to be unprefixed.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add support of an unprefixed version of CSS transitions modules by adding unprefixed versions
of each CSS properties. The work is protected behind the flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off
in their release branches until we're confident that these CSS properties are ready to be unprefixed.

Test: transitions/transitions-parsing.html

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* GNUmakefile.features.am.in:
* css/CSSPropertyNames.in: alias the unprefixed versions to the prefixed versions.

Source/WebKit/chromium:

Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to cover the work of unprefixing Transforms, Animations and
Transitions. It will let the possibility of each ports to turn it off
in their release branches until we're confident that these CSS
properties are ready to be unprefixed.

* features.gypi:

Source/WebKit/mac:

Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to cover the work of unprefixing Transforms, Animations and
Transitions. It will let the possibility of each ports to turn it off
in their release branches until we're confident that these CSS
properties are ready to be unprefixed.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to cover the work of unprefixing Transforms, Animations and
Transitions. It will let the possibility of each ports to turn it off
in their release branches until we're confident that these CSS
properties are ready to be unprefixed.

* Configurations/FeatureDefines.xcconfig:

Tools:

Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to cover the work of unprefixing Transforms, Animations and
Transitions. It will let the possibility of each ports to turn it off
in their release branches until we're confident that these CSS
properties are ready to be unprefixed.

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to cover the work of unprefixing Transforms, Animations and
Transitions. It will let the possibility of each ports to turn it off
in their release branches until we're confident that these CSS
properties are ready to be unprefixed.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Add new tests to cover the unprefixed version as well as the prefixed version of the properties.
It only covers the parsing and the computed style values.

* transitions/transitions-parsing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake RenderLayerCompositor::requiresCompositingForScrollableFrame scrollbars agnostic
tonikitoo@webkit.org [Wed, 19 Dec 2012 19:27:42 +0000 (19:27 +0000)]
Make RenderLayerCompositor::requiresCompositingForScrollableFrame scrollbars agnostic
https://bugs.webkit.org/show_bug.cgi?id=97903

Reviewed by Simon Fraser.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>

Some ports (including Qt-wk1 and BlackBerry) allow disabling
scrollbars at FrameView creation level. Regardless the scrollbars
presence though, their frame's content can still be scrolled as needed.
The said, checking for the scrollbars presence in order to determine
the scrollability of an inner frame is flaky, as done in RenderLayerCompositor::requiresCompositingForScrollableFrame.

Instead, the patch factors out part of the logic in
FrameView::updateScrollableAreaSet into a new ::isScrollable method.
The later can be used to check the scrollability of a given FrameView.

No new tests added, since there is no behavior change: ports like Chromium and others
who currently check for the scrollbars presence in order to determine
an inner frame scrollability should not be affected.

* page/FrameView.cpp:
(WebCore::FrameView::isScrollable):
(WebCore):
(WebCore::FrameView::updateScrollableAreaSet):
* page/FrameView.h:
(FrameView):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPopup menu on Windows should fade in instead of sliding in.
roger_fong@apple.com [Wed, 19 Dec 2012 19:24:37 +0000 (19:24 +0000)]
Popup menu on Windows should fade in instead of sliding in.
https://bugs.webkit.org/show_bug.cgi?id=105358
<rdar://problem/7611211>

Reviewed by Timothy Horton.

Changing popup menu display animation to match what most other Windows applications do.

* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCorrect missing touch event handler de-registration for nested Documents and DOMWindows
leviw@chromium.org [Wed, 19 Dec 2012 19:22:12 +0000 (19:22 +0000)]
Correct missing touch event handler de-registration for nested Documents and DOMWindows
https://bugs.webkit.org/show_bug.cgi?id=105384

Reviewed by James Robinson.

Source/WebCore:

Correcting case by which a nested DOMWindow wouldn't clean up its event handler references
on its Document when removeAllEventListeners was called. Also, correctly propagating this
from a nested Document to its owner Document.

Updating fast/events/touch/touch-handler-count.html to catch this bug.

* dom/Document.cpp:
(WebCore::Document::didRemoveEventTargetNode):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::removeAllEventListeners):

LayoutTests:

* fast/events/touch/touch-handler-count-expected.txt:
* fast/events/touch/touch-handler-count.html: Adding case of nested DOMWindows with event handlers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. The previous rebaseline didn't quite get it right for Mac.
leviw@chromium.org [Wed, 19 Dec 2012 19:20:38 +0000 (19:20 +0000)]
Unreviewed gardening. The previous rebaseline didn't quite get it right for Mac.

* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Updating expectations following r137847.
leviw@chromium.org [Wed, 19 Dec 2012 18:01:44 +0000 (18:01 +0000)]
Unreviewed gardening. Updating expectations following r137847.

* platform/chromium-linux-x86/fast/dom/Window: Added.
* platform/chromium-linux-x86/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
* platform/chromium-linux/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
* platform/chromium-linux/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt: Removed.
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png:
* platform/chromium-mac-snowleopard/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png
* platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png:
* platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png:
* platform/chromium-win/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png: Added.
* platform/chromium-win/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt: Added.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fixing incorrect include path and unskipping broken test.
leviw@chromium.org [Wed, 19 Dec 2012 17:50:01 +0000 (17:50 +0000)]
Unreviewed. Fixing incorrect include path and unskipping broken test.

* fast/events/touch/touch-input-element-change-documents.html:
* platform/efl/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix regression from r137923 that caused all tiles to paint when scrolling
simon.fraser@apple.com [Wed, 19 Dec 2012 17:49:45 +0000 (17:49 +0000)]
Fix regression from r137923 that caused all tiles to paint when scrolling
https://bugs.webkit.org/show_bug.cgi?id=105394

Reviewed by Dean Jackson.

r137923 removed a 'continue' from the loop that ensures we have tile coverage,
but this caused us to issue repaints for all existing tiles.

Fix to 'continue' when the tile size is unchanged. Also remove 'primaryLayerCount'
which was unused.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::revalidateTiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2 clampTo unit tests are failing
jchaffraix@webkit.org [Wed, 19 Dec 2012 17:45:46 +0000 (17:45 +0000)]
2 clampTo unit tests are failing
https://bugs.webkit.org/show_bug.cgi?id=105253

Reviewed by Emil A Eklund.

Removed clampToUnsigned as it was actually testing exactly what
clampToUnsignedLong was doing. Also made clampToIntFloat more robust
to precision loss (fix suggested by Emil).

* TestWebKitAPI/Tests/WTF/MathExtras.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport titleUIElement in chromium DRT
dmazzoni@google.com [Wed, 19 Dec 2012 17:42:35 +0000 (17:42 +0000)]
Support titleUIElement in chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=96529

Reviewed by Chris Fleizach.

Source/WebKit/chromium:

Fix implementation of titleUIElement - it shouldn't return anything
if supportsTitleUIElement returns false, so that accessible label
overriding logic works correctly.

* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::titleUIElement):

LayoutTests:

Modify aria-labelledby-overrides-label.html to be more cross-platform,
with slightly different expectations on Mac & Chromium.

* accessibility/aria-labelledby-overrides-label.html:
* platform/chromium/TestExpectations:
* platform/chromium/accessibility/aria-labelledby-overrides-label-expected.txt: Copied from LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt.
* platform/mac/accessibility/aria-labelledby-overrides-label-expected.txt: Renamed from LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r137607): PluginDocument loads consume huge amounts of memory
japhet@chromium.org [Wed, 19 Dec 2012 17:38:48 +0000 (17:38 +0000)]
REGRESSION(r137607): PluginDocument loads consume huge amounts of memory
https://bugs.webkit.org/show_bug.cgi?id=105359

Reviewed by Alexey Proskuryakov.

No new tests, verified manually that http://www.scb.se/statistik/_publikationer/NR0001_2012K02_TI_A28TI1203.pdf
no longer consumes several GB of memory.

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::setShouldBufferData): shouldBufferData is an enum, not a boolean, so this is reversed.
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::data): If the dataReceived() callback tells us to stop buffering data, be sure to
    notify the ResourceLoader and clear the data buffer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] WebCore::Prerender::didStartPrerender depends on LinkLoader
gavinp@chromium.org [Wed, 19 Dec 2012 17:23:03 +0000 (17:23 +0000)]
[chromium] WebCore::Prerender::didStartPrerender depends on LinkLoader
https://bugs.webkit.org/show_bug.cgi?id=105290

Reviewed by Abhishek Arya.

The LinkLoader now removes itself from its prerender in time.

Source/WebCore:

Tested in unit tests, PrerenderingTest.FastRemoveElement.

* loader/LinkLoader.cpp:
(WebCore::LinkLoader::~LinkLoader):
(WebCore::LinkLoader::released):

Source/WebKit/chromium:

* tests/PrerenderingTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 19 Dec 2012 17:22:27 +0000 (17:22 +0000)]
[EFL] Unreviewed gardening.

Adding platform specific expectations since our error msg is chattier,
test was introduced in r138165.
Also, marking a crash failure.

* platform/efl/TestExpectations:
* platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 19 Dec 2012 17:21:13 +0000 (17:21 +0000)]
Unreviewed GTK gardening.

Rebaselining two tests after r137953 and r138102.
Updating test expectations as necessary.

* platform/gtk/TestExpectations:
* platform/gtk/editing/selection/move-by-character-6-expected.txt:
* platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium/Skia] Check whether bitmap has pixels in image encoders
commit-queue@webkit.org [Wed, 19 Dec 2012 17:16:46 +0000 (17:16 +0000)]
[Chromium/Skia] Check whether bitmap has pixels in image encoders
https://bugs.webkit.org/show_bug.cgi?id=105349

Patch by Brian Salomon <bsalomon@google.com> on 2012-12-19
Reviewed by Stephen White.

This adds NULL checks to the JPEG, PNG, WEBP encoders.

Difficult to test as condition occurs when OOM.

* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::JPEGImageEncoder::encode):
* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::PNGImageEncoder::encode):
* platform/image-encoders/skia/WEBPImageEncoder.cpp:
(WebCore::WEBPImageEncoder::encode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnable to place the caret at the end of the first line, when followed by a block...
commit-queue@webkit.org [Wed, 19 Dec 2012 17:10:44 +0000 (17:10 +0000)]
Unable to place the caret at the end of the first line, when followed by a block, in the vertical writing mode.
https://bugs.webkit.org/show_bug.cgi?id=104794

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-12-19
Reviewed by Ryosuke Niwa.

Source/WebCore:

In the vertical writing mode, when trying to place the caret at the end
of a text line which is followed by a block, the local point sent as
part of the hitTest result in the mouse click event is not correct.

When clicking on the empty region (beyond the text) in the first line,
the local point computed is not in accordance with the writing mode.

Test: editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
Modified the code to handle the point as per the writing mode when
computing the hitTest result. Calling flipForWritingMode() on the
point for achieving the same.

LayoutTests:

* editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode-expected.txt: Added.
* editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode.html: Added.
Test added for verifying that a caret is painted at the end of the text
in the first vertical line, when followed by a block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r138157.
dominik.rottsches@intel.com [Wed, 19 Dec 2012 16:40:10 +0000 (16:40 +0000)]
Unreviewed, rolling out r138157.
http://trac.webkit.org/changeset/138157
https://bugs.webkit.org/show_bug.cgi?id=105439

Crashes with assertion failures in EFL debug build. (Requested
by drott on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-19

* platform/graphics/texmap/TextureMapperGL.cpp:
(SharedGLData):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawTextureWithAntialiasing):
(WebCore::keyForFilterType):
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::TextureMapperGL::beginClip):
* platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore):
(ShaderSpec):
(WebCore::ShaderSpec::ShaderSpec):
(WebCore::getShaderSpec):
(WebCore::TextureMapperShaderManager::getShaderProgram):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(TextureMapperShaderProgram):
(TextureMapperShaderManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Enable Navigation Timing by default
zandobersek@gmail.com [Wed, 19 Dec 2012 16:33:52 +0000 (16:33 +0000)]
[GTK] Enable Navigation Timing by default
https://bugs.webkit.org/show_bug.cgi?id=105322

Reviewed by Martin Robinson.

The Navigation Timing specification (of which implementation is guarder
by the ENABLE_WEB_TIMING feature define) has been promoted to the W3C Recommendation
status. Because of this we should enable it by default in the release builds of
the GTK port.

No new tests - they already exist and are in majority passing.

* GNUmakefile.am:
* bindings/gobject/GNUmakefile.am: Move the DOM bindings for interfaces related to this
feature out of the unstable features define guard and into the general list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: default font on mac is Monaco (should do be Menlo)
pfeldman@chromium.org [Wed, 19 Dec 2012 16:23:36 +0000 (16:23 +0000)]
Web Inspector: default font on mac is Monaco (should do be Menlo)
https://bugs.webkit.org/show_bug.cgi?id=105435

Reviewed by Alexander Pavlov.

Regressed when I introduced mountain lion modifier in the inspector.css.

* inspector/front-end/inspector.css:
(body.platform-mac .monospace, body.platform-mac .source-code):
(body.platform-mac.platform-mac-tiger .source-code):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExpose WebKitShadowRoot constructor to DOMWindow.
hayato@chromium.org [Wed, 19 Dec 2012 16:09:46 +0000 (16:09 +0000)]
Expose WebKitShadowRoot constructor to DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=105385

Reviewed by Dimitri Glazkov.

Source/WebCore:

This is a follow-up patch for r137870.  WebKitShadowRoot
constructor should be in DOMWindow, just like all of the other
not-callable-constructors like HTMLDivElement, etc.  We need it
for instanceof tests and so on.

Test: fast/dom/shadow/shadow-root-js-api.html
      fast/js/global-constructors-expected.html

* page/DOMWindow.idl:

LayoutTests:

* fast/dom/shadow/shadow-root-js-api-expected.txt:
* fast/dom/shadow/shadow-root-js-api.html:
* fast/js/global-constructors-expected.txt:
* platform/efl/fast/js/global-constructors-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: refactor DefaultTextEditor's |expanded| setters
commit-queue@webkit.org [Wed, 19 Dec 2012 16:07:10 +0000 (16:07 +0000)]
Web Inspector: refactor DefaultTextEditor's |expanded| setters
https://bugs.webkit.org/show_bug.cgi?id=105415

Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-12-19
Reviewed by Pavel Feldman.

Refactor |expanded| setters and getters into |collapse()|, |expand()|
and |expanded()| methods

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
(WebInspector.TextEditorChunkedPanel.prototype._expandChunks):
(WebInspector.TextEditorGutterPanel.prototype.textChanged):
(WebInspector.TextEditorGutterChunk.prototype.expanded): Added.
(WebInspector.TextEditorGutterChunk.prototype.collapse): Added.
(WebInspector.TextEditorGutterChunk.prototype.expand): Added.
(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
(WebInspector.TextEditorMainChunk.prototype.expanded): Added.
(WebInspector.TextEditorMainChunk.prototype.collapse): Added.
(WebInspector.TextEditorMainChunk.prototype.expand): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Use Document* as argument in WebSocket Instrumentation.
commit-queue@webkit.org [Wed, 19 Dec 2012 15:43:16 +0000 (15:43 +0000)]
Web Inspector: Use Document* as argument in WebSocket Instrumentation.
https://bugs.webkit.org/show_bug.cgi?id=105279.

Patch by Pan Deng <pan.deng@intel.com> on 2012-12-19
Reviewed by Pavel Feldman.

Some WebSocket instrumentation fuctions adopted ScriptExecutionContext* as argument, it is not clear that
their clients and implementations are all using Document*. This patch adopt Document* as argument, and
Document* could supply more information in future.

No functionality changed, no new tests.

* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoText Autosizing: Work out what to do about form controls
commit-queue@webkit.org [Wed, 19 Dec 2012 15:34:36 +0000 (15:34 +0000)]
Text Autosizing: Work out what to do about form controls
https://bugs.webkit.org/show_bug.cgi?id=102560

Patch by Tim Volodine <timvolodine@chromium.org> on 2012-12-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Disallow autosizing of form input controls like buttons, text input fields, selection controls, radio buttons
and check boxes. This is a short term solution to avoid inconsistent autosizing of form controls (which is
worse than not autosizing at all).

Tests: fast/text-autosizing/form-controls-autosizing-button-input-elements.html
       fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html
       fast/text-autosizing/form-controls-autosizing-radio-input-element.html
       fast/text-autosizing/form-controls-autosizing-select-element.html
       fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html

* rendering/TextAutosizer.cpp:
(WebCore):
(WebCore::formInputTags):
(WebCore::TextAutosizer::isAutosizingContainer):
(WebCore::TextAutosizer::contentHeightIsConstrained):
(WebCore::TextAutosizer::containerShouldBeAutosized):
(WebCore::TextAutosizer::containerContainsOneOfTags):
* rendering/TextAutosizer.h:

LayoutTests:

Tests for form input elements autosizing. Added tests to check that various kinds of form elements
don't get autosized, i.e. buttons, textareas, check boxes, radio button and selection menus.

* fast/text-autosizing/form-controls-autosizing-button-input-elements-expected.html: Added.
* fast/text-autosizing/form-controls-autosizing-button-input-elements.html: Added.
* fast/text-autosizing/form-controls-autosizing-checkbox-input-element-expected.html: Added.
* fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html: Added.
* fast/text-autosizing/form-controls-autosizing-radio-input-element-expected.html: Added.
* fast/text-autosizing/form-controls-autosizing-radio-input-element.html: Added.
* fast/text-autosizing/form-controls-autosizing-select-element-expected.html: Added.
* fast/text-autosizing/form-controls-autosizing-select-element.html: Added.
* fast/text-autosizing/form-controls-autosizing-textfield-input-elements-expected.html: Added.
* fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Add Workspace.setFileContent() method
vsevik@chromium.org [Wed, 19 Dec 2012 15:32:32 +0000 (15:32 +0000)]
Web Inspector: Add Workspace.setFileContent() method
https://bugs.webkit.org/show_bug.cgi?id=105434

Reviewed by Pavel Feldman.

Added method that will be usedto save file system-based uiSourceCodes to the disk.

* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype._commitContent):
* inspector/front-end/Workspace.js:
(WebInspector.WorkspaceProvider.prototype.setFileContent):
(WebInspector.Project.prototype.setFileContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Rename workspace path to uri.
vsevik@chromium.org [Wed, 19 Dec 2012 15:29:46 +0000 (15:29 +0000)]
Web Inspector: Rename workspace path to uri.
https://bugs.webkit.org/show_bug.cgi?id=105433

Reviewed by Pavel Feldman.

URI should later become file unique id / address in workspace.

* inspector/front-end/NetworkWorkspaceProvider.js:
(WebInspector.NetworkWorkspaceProvider.prototype.requestFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.setFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.searchInFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.addFile):
(WebInspector.NetworkWorkspaceProvider.prototype.removeFile):
* inspector/front-end/Workspace.js:
(WebInspector.FileDescriptor):
(WebInspector.WorkspaceProvider.prototype.requestFileContent):
(WebInspector.WorkspaceProvider.prototype.searchInFileContent):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Workspace.prototype.addTemporaryUISourceCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Refactor CSS[Keyword]Completions to augment property metadata
apavlov@chromium.org [Wed, 19 Dec 2012 15:28:17 +0000 (15:28 +0000)]
Web Inspector: Refactor CSS[Keyword]Completions to augment property metadata
https://bugs.webkit.org/show_bug.cgi?id=105020

Reviewed by Pavel Feldman.

- CSSCompletions and CSSKeywordCompletions of WebInspector have been merged into CSSMetadata.
- Valid value keyword lists have been added or augmented for some properties.
- Some properties have been made inherited or color-aware.

* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CSSCompletions.js: Removed.
* inspector/front-end/CSSKeywordCompletions.js: Removed.
* inspector/front-end/CSSMetadata.js: Added.
(WebInspector.CSSMetadata):
(WebInspector.CSSMetadata.isColorAwareProperty):
(WebInspector.CSSMetadata.colors):
(WebInspector.CSSMetadata.valuesForProperty):
(WebInspector.CSSMetadata.descriptor):
(WebInspector.CSSMetadata.requestCSSShorthandData):
(WebInspector.CSSMetadata.cssPropertiesMetainfoKeySet):
(WebInspector.CSSMetadata.prototype.startsWith):
(WebInspector.CSSMetadata.prototype.mostUsedOf):
(WebInspector.CSSMetadata.prototype._firstIndexOfPrefix):
(WebInspector.CSSMetadata.prototype.keySet):
(WebInspector.CSSMetadata.prototype.next):
(WebInspector.CSSMetadata.prototype.previous):
(WebInspector.CSSMetadata.prototype._closest):
(WebInspector.CSSMetadata.prototype.longhands):
(WebInspector.CSSMetadata.prototype.shorthands):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleDeclaration.prototype.longhandProperties):
* inspector/front-end/SourceCSSTokenizer.js:
(WebInspector.SourceCSSTokenizer):
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.createExclamationMark):
(WebInspector.StylesSidebarPane.prototype._markUsedProperties):
(WebInspector.StylesSidebarPane.prototype._containsInherited):
(WebInspector.StylePropertiesSection.prototype.isPropertyInherited):
(WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Move ImageDiff to the Tools directory root
thiago.santos@intel.com [Wed, 19 Dec 2012 15:05:46 +0000 (15:05 +0000)]
[EFL] Move ImageDiff to the Tools directory root
https://bugs.webkit.org/show_bug.cgi?id=105305

Reviewed by Laszlo Gombos.

We previously moved this directory from the DRT directory to
efl/ImageDiff. The major reason for doing so was because ImageDiff does
not depend on DumpRenderTree but for legacy reasons was living inside the
DRT folder, even though it is needed when running pixel tests for WK2.

Now we are moving to Tool directory root as other ports agreed to do the same.

* CMakeLists.txt:
* ImageDiff/CMakeLists.txt: Added.
* ImageDiff/PlatformEfl.cmake: Added.
* ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
* efl/ImageDiff/CMakeLists.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Texmap] Instead of having multiple shaders sources with lots of duplication, we...
commit-queue@webkit.org [Wed, 19 Dec 2012 14:52:12 +0000 (14:52 +0000)]
[Texmap] Instead of having multiple shaders sources with lots of duplication, we should have one shader source with MACRO variants
https://bugs.webkit.org/show_bug.cgi?id=104815

Patch by No'am Rosenthal <noam@webkit.org> on 2012-12-19
Reviewed by Kenneth Rohde Christiansen.

Created templates for the vertex and fragment shaders, and added some MACROs in
TextureMapperShaderManager to allow GLSL precompiler-based configuration.

The template follows a pattern where the main function in the shader calls
applyFooBarIfNeeded(), while applyFooBar() is implemented. The Macros prepended to the template define whether applyIfNeeded resolves to the real function or to a noop.

In addition, made some small changes to the filter shaders so that they can use the same code as the normal shaders.

Covered by existing pixel/ref tests when run on Qt/EFL/GTK.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore::TextureMapperGL::drawTextureWithAntialiasing):
(WebCore::optionsForFilterType):
(WebCore):
(WebCore::getPassesRequiredForFilter):
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::applyFilters):
    Always draw using the drawQuad function, and use the new TextureMapperShaderManager::Options mask instead of the old ShaderKey.

* platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore):
(WebCore::getShaderSpec):
(WebCore::TextureMapperShaderManager::getShaderProgram):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(TextureMapperShaderProgram):
(TextureMapperShaderManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, update pixel results.
ossy@webkit.org [Wed, 19 Dec 2012 14:48:55 +0000 (14:48 +0000)]
[Qt] Unreviewed gardening, update pixel results.

* platform/qt-5.0-wk2/fast/backgrounds/transformed-body-background-expected.png: Removed.
* platform/qt-5.0-wk2/fast/backgrounds/transformed-body-html-background-expected.png: Removed.
* platform/qt-5.0-wk2/fast/backgrounds/transformed-html-body-background-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Removed.
* platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-getItem-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png: Removed.
* platform/qt/compositing/masks/masked-ancestor-expected.png:
* platform/qt/compositing/reflections/reflection-in-composited-expected.png:
* platform/qt/compositing/shadows/shadow-drawing-expected.png:
* platform/qt/css1/box_properties/border_style-expected.png:
* platform/qt/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
* platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-94-d-expected.png:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
* platform/qt/editing/selection/extend-by-character-002-expected.png:
* platform/qt/editing/selection/extend-by-character-004-expected.png:
* platform/qt/editing/selection/move-by-character-002-expected.png:
* platform/qt/editing/selection/move-by-character-004-expected.png:
* platform/qt/fast/backgrounds/animated-svg-as-mask-expected.png:
* platform/qt/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/qt/fast/backgrounds/transformed-body-background-expected.png: Added.
* platform/qt/fast/backgrounds/transformed-body-html-background-expected.png: Added.
* platform/qt/fast/backgrounds/transformed-html-body-background-expected.png: Added.
* platform/qt/fast/css/outline-auto-empty-rects-expected.png:
* platform/qt/fast/css/outline-auto-location-expected.png:
* platform/qt/fast/css/resize-corner-tracking-transformed-expected.png:
* platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png:
* platform/qt/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png.
* platform/qt/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png.
* platform/qt/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png.
* platform/qt/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
* platform/qt/fast/forms/number/number-appearance-rtl-expected.png:
* platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
* platform/qt/fast/forms/select-baseline-expected.png:
* platform/qt/fast/inline/continuation-outlines-expected.png:
* platform/qt/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/qt/fast/layers/scroll-with-transform-layer-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png.
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.png:
* platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png:
* platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.png:
* platform/qt/fast/repaint/reflection-repaint-test-expected.png:
* platform/qt/fast/repaint/region-painting-invalidation-expected.png:
* platform/qt/fast/repaint/region-painting-via-layout-expected.png:
* platform/qt/fast/repaint/transform-repaint-descendants-expected.png:
* platform/qt/fast/replaced/selection-rect-transform-expected.png:
* platform/qt/fast/table/035-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/001-expected.png:
* platform/qt/fast/table/border-collapsing/001-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/004-vertical-expected.png:
* platform/qt/fast/transforms/transform-table-row-expected.png:
* platform/qt/fast/transforms/transformed-caret-expected.png:
* platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/masking-path-03-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-align-02-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png:
* platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
* platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/qt/svg/as-background-image/svg-as-background-5-expected.png:
* platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/qt/svg/batik/text/smallFonts-expected.png:
* platform/qt/svg/batik/text/textAnchor-expected.png:
* platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
* platform/qt/svg/batik/text/textOnPath-expected.png:
* platform/qt/svg/batik/text/textOnPath2-expected.png:
* platform/qt/svg/batik/text/textOnPathSpaces-expected.png:
* platform/qt/svg/batik/text/verticalText-expected.png:
* platform/qt/svg/batik/text/verticalTextOnPath-expected.png:
* platform/qt/svg/batik/text/xmlSpace-expected.png:
* platform/qt/svg/carto.net/button-expected.png:
* platform/qt/svg/carto.net/colourpicker-expected.png:
* platform/qt/svg/carto.net/slider-expected.png:
* platform/qt/svg/carto.net/textbox-expected.png:
* platform/qt/svg/carto.net/window-expected.png:
* platform/qt/svg/css/text-shadow-multiple-expected.png:
* platform/qt/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/qt/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/qt/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/qt/svg/custom/feComponentTransfer-Table-expected.png:
* platform/qt/svg/custom/focus-ring-expected.png:
* platform/qt/svg/custom/font-face-simple-expected.png:
* platform/qt/svg/custom/foreign-object-skew-expected.png:
* platform/qt/svg/custom/invalid-css-expected.png:
* platform/qt/svg/custom/marker-default-width-height-expected.png:
* platform/qt/svg/custom/no-inherited-dashed-stroke-expected.png:
* platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/qt/svg/custom/shapes-supporting-markers-expected.png:
* platform/qt/svg/custom/stroked-pattern-expected.png:
* platform/qt/svg/custom/text-rotated-gradient-expected.png:
* platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.png:
* platform/qt/svg/custom/text-tref-03-b-change-href-expected.png:
* platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.png:
* platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.png:
* platform/qt/svg/custom/tref-own-content-removal-expected.png:
* platform/qt/svg/custom/use-detach-expected.png:
* platform/qt/svg/custom/viewbox-syntax-expected.png:
* platform/qt/svg/dom/SVGLengthList-appendItem-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png.
* platform/qt/svg/dom/SVGLengthList-basics-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGLengthList-basics-expected.png.
* platform/qt/svg/dom/SVGLengthList-getItem-expected.png: Added.
* platform/qt/svg/dom/SVGLengthList-initialize-expected.png: Added.
* platform/qt/svg/dom/SVGLengthList-insertItemBefore-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png.
* platform/qt/svg/dom/SVGLengthList-removeItem-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png.
* platform/qt/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
* platform/qt/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png.
* platform/qt/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGLocatable-getCTM-svg-root-expected.png.
* platform/qt/svg/dom/SVGNumberList-basics-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGNumberList-basics-expected.png.
* platform/qt/svg/dom/SVGPathSegList-appendItem-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png.
* platform/qt/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png.
* platform/qt/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png.
* platform/qt/svg/dom/SVGPathSegList-removeItem-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png.
* platform/qt/svg/dom/SVGPathSegList-replaceItem-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png.
* platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png.
* platform/qt/svg/dom/SVGPointList-basics-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPointList-basics-expected.png.
* platform/qt/svg/dom/SVGStringList-basics-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png.
* platform/qt/svg/dom/SVGTransformList-basics-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGTransformList-basics-expected.png.
* platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
* platform/qt/svg/hixie/perf/003-expected.png:
* platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.png:
* platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.png:
* platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
* platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
* platform/qt/svg/text/select-x-list-1-expected.png:
* platform/qt/svg/text/select-x-list-with-tspans-1-expected.png:
* platform/qt/svg/text/small-fonts-2-expected.png:
* platform/qt/svg/text/small-fonts-3-expected.png:
* platform/qt/svg/text/text-align-01-b-expected.png:
* platform/qt/svg/text/text-align-02-b-expected.png:
* platform/qt/svg/text/text-align-03-b-expected.png:
* platform/qt/svg/text/text-align-06-b-expected.png:
* platform/qt/svg/text/text-fonts-02-t-expected.png:
* platform/qt/svg/text/text-path-01-b-expected.png:
* platform/qt/svg/text/text-text-03-b-expected.png:
* platform/qt/svg/text/text-text-05-t-expected.png:
* platform/qt/svg/text/text-tref-01-b-expected.png:
* platform/qt/svg/text/text-tselect-01-b-expected.png:
* platform/qt/svg/text/text-tspan-01-b-expected.png:
* platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/qt/svg/transforms/svg-css-transforms-expected.png:
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
* platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/qt/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
* platform/qt/svg/zoom/text/zoom-foreignObject-expected.png:
* platform/qt/tables/mozilla/bugs/bug6674-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_position-table-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_simple-table-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
* platform/qt/transforms/svg-vs-css-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2][AC] Avoid creating an empty surface.
commit-queue@webkit.org [Wed, 19 Dec 2012 14:39:30 +0000 (14:39 +0000)]
[EFL][WK2][AC] Avoid creating an empty surface.
https://bugs.webkit.org/show_bug.cgi?id=105410

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-19
Reviewed by Kenneth Rohde Christiansen.

Ensure that the view has valid size before creating the surface.

* UIProcess/API/efl/EvasGLSurface.h:
(WebKit::EvasGLSurface::create):
* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::displayTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Support removing several tabs from TabbedEditorContainer/TabbedPane...
vsevik@chromium.org [Wed, 19 Dec 2012 14:14:01 +0000 (14:14 +0000)]
Web Inspector: Support removing several tabs from TabbedEditorContainer/TabbedPane at once.
https://bugs.webkit.org/show_bug.cgi?id=104881

Reviewed by Alexander Pavlov.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.removeUISourceCode):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.closeTab):
(WebInspector.TabbedPane.prototype.closeTabs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: scripts to evaluate on load are not removed from inspector state when...
caseq@chromium.org [Wed, 19 Dec 2012 13:56:38 +0000 (13:56 +0000)]
Web Inspector: scripts to evaluate on load are not removed from inspector state when Page agent is disabled
https://bugs.webkit.org/show_bug.cgi?id=105422

Reviewed by Alexander Pavlov.

- reset scripts to evaluate on load when InspectorPageAgent is disabled.
- added InspectorState::remove();

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::remove):
(WebCore):
* inspector/InspectorState.h:
(InspectorState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][Qt][WK2] Going back to 47-amazing-css3-animation-demos shows nothing or wrong...
kenneth@webkit.org [Wed, 19 Dec 2012 13:45:15 +0000 (13:45 +0000)]
[EFL][Qt][WK2] Going back to 47-amazing-css3-animation-demos shows nothing or wrong position
https://bugs.webkit.org/show_bug.cgi?id=104414

Reviewed by Simon Hausmann.

When contents size changes, make sure to apply any pending position
change if possible.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didChangeContentsSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoINPUT_MULTIPLE_FIELDS_UI: Make year field readonly if min and max have the same year
commit-queue@webkit.org [Wed, 19 Dec 2012 13:38:31 +0000 (13:38 +0000)]
INPUT_MULTIPLE_FIELDS_UI: Make year field readonly if min and max have the same year
https://bugs.webkit.org/show_bug.cgi?id=105383

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-12-19
Reviewed by Kent Tamura.

Source/WebCore:

Make year field readonly if min and max have the same year, and it does not have
value with different year.

Test: fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html

* css/html.css: Add CSS rule for the year field.
* html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField): Make year-field readonly when appropriate.
(WebCore::DateTimeEditBuilder::shouldYearFieldReadOnly): Added.

LayoutTests:

* fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt: Added.
* fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html: Added.
* fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html: Tweak so year field is focusable.
* fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html: Ditto.
* fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html: Ditto.
* fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] [WK2] Trailing semicolon in an #include line
commit-queue@webkit.org [Wed, 19 Dec 2012 13:32:45 +0000 (13:32 +0000)]
[GTK] [WK2] Trailing semicolon in an #include line
https://bugs.webkit.org/show_bug.cgi?id=105418

Patch by Alberto Garcia <agarcia@igalia.com> on 2012-12-19
Reviewed by Xan Lopez.

* UIProcess/gtk/WebContextGtk.cpp:
Remove trailing semicolon in #include line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Move deviceScaleFactor to our view as it's view related
kenneth@webkit.org [Wed, 19 Dec 2012 13:22:31 +0000 (13:22 +0000)]
[EFL][WK2] Move deviceScaleFactor to our view as it's view related
https://bugs.webkit.org/show_bug.cgi?id=105412

Reviewed by Laszlo Gombos.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::setDeviceScaleFactor):
(EwkViewImpl::transformFromScene):
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_device_pixel_ratio_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Fix undesired re-entrant calls during media error dialog
commit-queue@webkit.org [Wed, 19 Dec 2012 13:13:41 +0000 (13:13 +0000)]
[BlackBerry] Fix undesired re-entrant calls during media error dialog
https://bugs.webkit.org/show_bug.cgi?id=105398

Patch by Max Feil <mfeil@rim.com> on 2012-12-19
Reviewed by Rob Buis.

A recent change in libwebview (PR194379) to the dialog
handling means that dialogs are not truly blocking anymore.
While the dialog is up, a sub-event loop is called. Therefore
the HTML5 media code will continue processing pps messages from
mm-renderer, responding to periodic timers, etc., all while a
media error dialog call higher up in the stack is waiting for
the user to respond. Unfortunately certain places in our code
do not anticipate being called in this re-entrant way.

This patch restores previous behaviour, covered by existing tests.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [REGRESSION] The last remembered tab is not restored when the Settings...
apavlov@chromium.org [Wed, 19 Dec 2012 13:02:17 +0000 (13:02 +0000)]
Web Inspector: [REGRESSION] The last remembered tab is not restored when the Settings dialog is opened
https://bugs.webkit.org/show_bug.cgi?id=105414

Reviewed by Vsevolod Vlasov.

Do not force the "General" tab when opening settings upon the Cog button click.

* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsController.prototype._mouseUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, skip flakey tests.
ossy@webkit.org [Wed, 19 Dec 2012 13:00:54 +0000 (13:00 +0000)]
Unreviewed gardening, skip flakey tests.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Missing vtable for LoadStartedCatcher.
zeno.albisser@digia.com [Wed, 19 Dec 2012 12:49:16 +0000 (12:49 +0000)]
[Qt] Missing vtable for LoadStartedCatcher.
https://bugs.webkit.org/show_bug.cgi?id=105313

Properly splitting class declarations and function
definitions into headers/cpp-files.
This makes including util.moc redundant
and avoids the well known vtable issues with QObject classes.

Reviewed by Simon Hausmann.

* UIProcess/API/qt/tests/util.cpp:
(LoadSpy::LoadSpy):
(LoadSpy::onLoadingChanged):
* UIProcess/API/qt/tests/util.h:
(LoadSpy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSParser crases, when no context is available, and the value is a valid keyword
reni@webkit.org [Wed, 19 Dec 2012 11:56:08 +0000 (11:56 +0000)]
CSSParser crases, when no context is available, and the value is a valid keyword
https://bugs.webkit.org/show_bug.cgi?id=105275

Reviewed by Tony Chang.

ParserContext could be null even if the keyword is valid. We have to check it.

Source/WebCore:

Test: fast/css/invalid-parsercontext-valid-keyword-crash.svg

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

LayoutTests:

* fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt: Added.
* fast/css/invalid-parsercontext-valid-keyword-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WebGL] Refactor GLXSurface.
commit-queue@webkit.org [Wed, 19 Dec 2012 11:35:05 +0000 (11:35 +0000)]
[EFL][WebGL] Refactor GLXSurface.
https://bugs.webkit.org/show_bug.cgi?id=105357

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-19
Reviewed by Kenneth Rohde Christiansen.

This is in preparation for adding EGL support.
There is lot of X related code which could be shared between our current GLX implementation
and EGL. This patch makes it possible to share the common code but doesn't change any functionality.

* PlatformEfl.cmake:
* platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore):
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::configuration):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXTransportSurface::freeResources):
(WebCore::GLXPBuffer::GLXPBuffer):
(WebCore::GLXPBuffer::initialize):
(WebCore::GLXPBuffer::configuration):
(WebCore::GLXPBuffer::setGeometry):
* platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXPBuffer):

GLX related implementation.
* platform/graphics/surfaces/glx/GLXWindowResources.h: Added.
(WebCore):
(SharedGLXResources):
(WebCore::SharedGLXResources::create):
(WebCore::SharedGLXResources::nativeDisplay):
(WebCore::SharedGLXResources::pBufferContextConfig):
(WebCore::SharedGLXResources::surfaceContextConfig):
(WebCore::SharedGLXResources::SharedGLXResources):
(WebCore::SharedGLXResources::createConfig):

Moving X related code to a seperate class.
* platform/graphics/surfaces/glx/X11WindowResources.cpp: Added.
(WebCore):
(WebCore::X11OffScreenWindow::X11OffScreenWindow):
(WebCore::X11OffScreenWindow::~X11OffScreenWindow):
(WebCore::X11OffScreenWindow::setGeometry):
(WebCore::X11OffScreenWindow::createOffscreenWindow):
* platform/graphics/surfaces/glx/X11WindowResources.h: Added.
(WebCore):
(SharedX11Resources):
(WebCore::SharedX11Resources::deref):
(WebCore::SharedX11Resources::x11Display):
(WebCore::SharedX11Resources::getXWindow):
(WebCore::SharedX11Resources::visualInfo):
(WebCore::SharedX11Resources::isXRenderExtensionSupported):
(WebCore::SharedX11Resources::SharedX11Resources):
(WebCore::SharedX11Resources::~SharedX11Resources):
(X11OffScreenWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 19 Dec 2012 10:56:01 +0000 (10:56 +0000)]
[EFL] Unreviewed gardening.

Adding failing touch events case, details in bug 105406.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[JSC] Add support for overloaded constructors
commit-queue@webkit.org [Wed, 19 Dec 2012 10:50:36 +0000 (10:50 +0000)]
[JSC] Add support for overloaded constructors
https://bugs.webkit.org/show_bug.cgi?id=103226

Patch by Tommy Widenflycht <tommyw@chromium.org> on 2012-12-19
Reviewed by Kentaro Hara.

Source/WebCore:

This patch adds the same support for overloaded constructors to JSC as V8.
As proof of implementation soundness WebSockets custom constructor is removed.

Existing tests cover patch. As they should.

* GNUmakefile.list.am:
* Modules/websockets/WebSocket.idl:
* Target.pri:
* UseJSC.cmake:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSWebSocketCustom.cpp: Removed.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDeclaration):
(GenerateConstructorDefinitions):
(GenerateOverloadedConstructorDefinition):
(GenerateConstructorDefinition):
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors1):
(WebCore):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors2):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors3):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors4):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(JSTestOverloadedConstructorsConstructor):

LayoutTests:

* http/tests/websocket/tests/hybi/url-parsing-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Mark XHR tests flaky (unreliable console logging)
commit-queue@webkit.org [Wed, 19 Dec 2012 10:48:06 +0000 (10:48 +0000)]
[EFL] Mark XHR tests flaky (unreliable console logging)
https://bugs.webkit.org/show_bug.cgi?id=105403

Unreviewed gardening: mark a bunch of xmlhttprequest tests flaky.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-19

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
zeno.albisser@digia.com [Wed, 19 Dec 2012 10:46:03 +0000 (10:46 +0000)]
[Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
https://bugs.webkit.org/show_bug.cgi?id=105309

The version number is only used as a part
of the library name on Linux.

Reviewed by Kenneth Rohde Christiansen.

* Scripts/webkitdirs.pm:
(builtDylibPathForName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPass debuggerTaskMode as a parameter in WorkerScriptDebugServer constructor
commit-queue@webkit.org [Wed, 19 Dec 2012 10:39:17 +0000 (10:39 +0000)]
Pass debuggerTaskMode as a parameter in WorkerScriptDebugServer constructor
https://bugs.webkit.org/show_bug.cgi?id=105085

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2012-12-19
Reviewed by Yury Semikhatsky.

Leave WorkerDebuggerAgent::debuggerTaskMode
and remove WorkerScriptDebugServer::debuggerTaskMode.

No new tests, no behavior change.

* bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
* bindings/js/WorkerScriptDebugServer.h:
(WorkerScriptDebugServer):
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
* bindings/v8/WorkerScriptDebugServer.h:
(WorkerScriptDebugServer):
* inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Gardening after r138095, skip a newly added, but failing test.
jbadics@inf.u-szeged.hu [Wed, 19 Dec 2012 10:29:41 +0000 (10:29 +0000)]
[Qt] Gardening after r138095, skip a newly added, but failing test.
https://bugs.webkit.org/show_bug.cgi?id=105406

Reviewed by Csaba Osztrogon√°c.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Tests that time out are not considered as failures.
carlosgc@webkit.org [Wed, 19 Dec 2012 10:18:15 +0000 (10:18 +0000)]
[GTK] Tests that time out are not considered as failures.
https://bugs.webkit.org/show_bug.cgi?id=105318

Patch by Alberto Garcia <agarcia@igalia.com> on 2012-12-19
Reviewed by Martin Robinson.

Fix parsing of the GTK API tests log files.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests.commandComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Move chromium-mac image to chromium where it will also be used...
loislo@chromium.org [Wed, 19 Dec 2012 10:10:14 +0000 (10:10 +0000)]
Unreviewed gardening. Move chromium-mac image to chromium where it will also be used for win and linux.

* platform/chromium/fast/text/line-initial-and-final-swashes-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/line-initial-and-final-swashes-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r138129.
loislo@chromium.org [Wed, 19 Dec 2012 09:56:33 +0000 (09:56 +0000)]
Unreviewed, rolling out r138129.
http://trac.webkit.org/changeset/138129
https://bugs.webkit.org/show_bug.cgi?id=105399

reapply patch r138123. The problem was on chromium side at r173875.

Source/WebCore:

* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
* dom/Element.h:
(WebCore::Node::insertedInto):
(WebCore):
(WebCore::Node::removedFrom):
* dom/Node.cpp:

LayoutTests:

* fast/dom/shadow/getelementbyid-shadow-expected.txt: Added.
* fast/dom/shadow/getelementbyid-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow] TITLE elements in Shadow DOM should not affect document.title attribute
tasak@google.com [Wed, 19 Dec 2012 08:54:10 +0000 (08:54 +0000)]
[Shadow] TITLE elements in Shadow DOM should not affect document.title attribute
https://bugs.webkit.org/show_bug.cgi?id=85864

Reviewed by Ryosuke Niwa.

Source/WebCore:

Modified HTMLTitleElement to check whether a title element is in a
shadow tree or not when it is inserted or removed. Now if a title
element has been just removed from or inserted into a shadow tree,
document.title is not updated independent of inDocument().  If the
title element is not in a shadow tree and in document,
document.title is updated.

Test: fast/dom/shadow/title-element-in-shadow.html

* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::insertedInto):
Added a condition: isInShadowTree() to the code which checks
inDocument or not.
(WebCore::HTMLTitleElement::removedFrom):
Added a condition: insertionPoint.isInShadowTree() to the code which
checks an insertion point is in a document or not.
(WebCore::HTMLTitleElement::childrenChanged):
Added a condition: isInShadowTree() before setTitle.
If not isInShadowTree, modified to removeTitle from document.

LayoutTests:

* fast/dom/shadow/title-element-in-shadow-expected.txt: Added.
* fast/dom/shadow/title-element-in-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r138123.
loislo@chromium.org [Wed, 19 Dec 2012 08:46:12 +0000 (08:46 +0000)]
Unreviewed, rolling out r138123.
http://trac.webkit.org/changeset/138123
https://bugs.webkit.org/show_bug.cgi?id=105399

It broke compositing/visibility/visibility-simple-video-
layer.html (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-19

Source/WebCore:

* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
* dom/Element.h:
* dom/Node.cpp:
(WebCore::Node::insertedInto):
(WebCore):
(WebCore::Node::removedFrom):

LayoutTests:

* fast/dom/shadow/getelementbyid-shadow-expected.txt: Removed.
* fast/dom/shadow/getelementbyid-shadow.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agotransitions/interrupted-accelerated-transition.html should use pauseAPI
commit-queue@webkit.org [Wed, 19 Dec 2012 08:41:02 +0000 (08:41 +0000)]
transitions/interrupted-accelerated-transition.html should use pauseAPI
https://bugs.webkit.org/show_bug.cgi?id=103524

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-19
Reviewed by Simon Fraser.

In certain situations interrupted-accelerated-transition.html exceeds the
test tolerance, making the test flaky. Use the pauseAPI so we don't
depend on javascript timing.

* transitions/resources/interrupted-accelerated-transition-final.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Restore expectations for mac.
loislo@chromium.org [Wed, 19 Dec 2012 08:23:27 +0000 (08:23 +0000)]
Unreviewed gardening. Restore expectations for mac.

The tests still have problem with scroller image.

* platform/chromium/TestExpectations:
added: webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/exif-orientation.html [ ImageOnlyFailure ]
added: webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/exif-orientation-css.html [ ImageOnlyFailure ]
added: webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile.html [ ImageOnlyFailure ]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnused parameters on WebContext.cpp
commit-queue@webkit.org [Wed, 19 Dec 2012 08:21:19 +0000 (08:21 +0000)]
Unused parameters on WebContext.cpp
https://bugs.webkit.org/show_bug.cgi?id=105395

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-19
Reviewed by Kentaro Hara.

Because the parameters 'certficate', 'host' are not used if !ENABLE(NETWORK_PROCESS),
use UNUSED_PARAM macro to fix build warning -Wunused-parameter.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Update expectation for mac and remove wrong expectation for...
loislo@chromium.org [Wed, 19 Dec 2012 08:15:51 +0000 (08:15 +0000)]
Unreviewed gardening. Update expectation for mac and remove wrong expectation for win.

* platform/chromium-mac-snowleopard/fast/text/line-initial-and-final-swashes-expected.png: Added.
* platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: radio-button-checkbox-size is Mac-specific and should be moved.
dmazzoni@google.com [Wed, 19 Dec 2012 07:57:33 +0000 (07:57 +0000)]
AX: radio-button-checkbox-size is Mac-specific and should be moved.
https://bugs.webkit.org/show_bug.cgi?id=105382

Reviewed by Chris Fleizach.

Move radio-button-checkbox-size to platform/mac because the
behavior it tests for is Mac-specific. Take it out of the
Chromium TestExpectations file.

* platform/chromium/TestExpectations:
* platform/mac/accessibility/radio-button-checkbox-size-expected.txt: Renamed from LayoutTests/accessibility/radio-button-checkbox-size-expected.txt.
* platform/mac/accessibility/radio-button-checkbox-size.html: Renamed from LayoutTests/accessibility/radio-button-checkbox-size.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShadowRoot.getElementById() returns a deleted element
shinyak@chromium.org [Wed, 19 Dec 2012 07:54:57 +0000 (07:54 +0000)]
ShadowRoot.getElementById() returns a deleted element
https://bugs.webkit.org/show_bug.cgi?id=105243

Reviewed by Dimitri Glazkov.

Source/WebCore:

Only when the treeScope of an element and the treeScope of insertionPoint is the same in insertedInto or removedFrom,
we can call updatedId() etc. However, we didn't check it's same.

For removedFrom, since an element has been removed, treeScope() doesn't return the original treeScope but document()
every time.

This patch might hurt html5-full-render a bit: the result is here. The first 2 results are without this patch,
the last 2 results are with this patch.

Dromaeo/dom-modify [runs/s]
     35.97,   36.09 -->   36.05,   35.69
Parser/html5-full-render [ms]
   4156.58, 4166.09 --> 4155.22, 4216.38

Test: fast/dom/shadow/getelementbyid-shadow.html

* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
* dom/Element.h:
(WebCore::Node::insertedInto): Moved from Node.cpp to make this inline.
(WebCore):
(WebCore::Node::removedFrom): ditto.
* dom/Node.cpp:

LayoutTests:

* fast/dom/shadow/getelementbyid-shadow-expected.txt: Added.
* fast/dom/shadow/getelementbyid-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: AuditLauncherView UI components should be disabled until ongoing audit...
vivek.vg@samsung.com [Wed, 19 Dec 2012 07:37:53 +0000 (07:37 +0000)]
Web Inspector: AuditLauncherView UI components should be disabled until ongoing audit finishes
https://bugs.webkit.org/show_bug.cgi?id=105389

Reviewed by Alexander Pavlov.

While the Audit request is on-going, UI components on the AuditLauncherView are disabled
until the request is completed or explicitly stopped. Also changed the _categoriesElement
from div to fieldset and modified the associated CSS file accordingly.

No new tests as this is a UI change.

* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype._setAuditRunning):
(WebInspector.AuditLauncherView.prototype._toggleUIComponents):
* inspector/front-end/auditsPanel.css:
(.audit-launcher-view fieldset.audit-categories-container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r138061.
loislo@chromium.org [Wed, 19 Dec 2012 07:36:39 +0000 (07:36 +0000)]
Unreviewed, rolling out r138061.
https://bugs.webkit.org/show_bug.cgi?id=105396

Original patch:
http://trac.webkit.org/changeset/138061
https://bugs.webkit.org/show_bug.cgi?id=97359

It is crashing on Debug bots

Source/WebKit/chromium:

* public/WebAccessibilityObject.h:
(WebAccessibilityObject):
* src/WebAccessibilityObject.cpp:

Tools:

* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElement):

LayoutTests:

* accessibility/svg-bounds.html:
* accessibility/svg-remote-element-expected.txt:
* accessibility/svg-remote-element.html:
* platform/chromium/TestExpectations:
* platform/chromium/accessibility/svg-bounds-expected.txt: Copied from LayoutTests/accessibility/svg-bounds-expected.txt.
* platform/mac/accessibility/svg-bounds-expected.txt: Renamed from LayoutTests/accessibility/svg-bounds-expected.txt.
* platform/mac/accessibility/svg-remote-element-expected.txt: Copied from LayoutTests/accessibility/svg-remote-element-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] regression(r138071) Add mission functions for build fix
commit-queue@webkit.org [Wed, 19 Dec 2012 07:33:00 +0000 (07:33 +0000)]
[EFL] regression(r138071) Add mission functions for build fix
https://bugs.webkit.org/show_bug.cgi?id=105392

Unreviewed build fix.

r138071 add new functions to LocalizedStrings.cpp, but EFL port doesn't use them.
So, add those functions to LocalizedStringsEfl.cpp

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-18

* platform/efl/LocalizedStringsEfl.cpp:
(WebCore):
(WebCore::textTrackClosedCaptionsText):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffText):
(WebCore::textTrackNoLabelText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, skip a new failing test.
ossy@webkit.org [Wed, 19 Dec 2012 06:58:14 +0000 (06:58 +0000)]
Unreviewed gardening, skip a new failing test.

* platform/qt-5.0-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Chromium] profiler - differentiate between native code (program)...
commit-queue@webkit.org [Wed, 19 Dec 2012 06:42:06 +0000 (06:42 +0000)]
Web Inspector: [Chromium] profiler - differentiate between native code (program) and idle time
https://bugs.webkit.org/show_bug.cgi?id=88446

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-18
Reviewed by Pavel Feldman.

Now idleTime is supplied in profile object. In this patch, idleTime,
if any, is subtracted from "(program)" node, and new node "(idle)" is
injected as a top level node to profile.

* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.profileCallback): Call _injectIdleTimeNode
if non-zero idleTime is specified.
(WebInspector.CPUProfileView.prototype._injectIdleTimeNode): Lookup for
"(program)" node, modify it, add "(idle)" node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline after r138075. Remove entries for passing tests and one bad...
loislo@chromium.org [Wed, 19 Dec 2012 06:34:08 +0000 (06:34 +0000)]
Unreviewed rebaseline after r138075. Remove entries for passing tests and one bad expectation for a reftest by dpranke@chromium.org

* platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/scrollbars-on-positioned-content-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline.
loislo@chromium.org [Wed, 19 Dec 2012 06:26:11 +0000 (06:26 +0000)]
Unreviewed rebaseline.

* platform/chromium-linux-x86/fast/inline/justify-emphasis-inline-box-expected.txt: Added.
* platform/chromium-linux/fast/inline/justify-emphasis-inline-box-expected.png: Added.
* platform/chromium-linux/fast/inline/justify-emphasis-inline-box-expected.txt: Added.
* platform/chromium-win/fast/inline/justify-emphasis-inline-box-expected.png: Added.
* platform/chromium-win/fast/inline/justify-emphasis-inline-box-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Layout Test fast/events/touch/touch-input-element-change-docume...
loislo@chromium.org [Wed, 19 Dec 2012 06:14:18 +0000 (06:14 +0000)]
Unreviewed gardening. Layout Test fast/events/touch/touch-input-element-change-documents.html is failing
https://bugs.webkit.org/show_bug.cgi?id=105388

wrong path to the js-test-pre.js

* fast/events/touch/touch-input-element-change-documents.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r138097.
loislo@chromium.org [Wed, 19 Dec 2012 05:41:10 +0000 (05:41 +0000)]
Unreviewed, rolling out r138097.
http://trac.webkit.org/changeset/138097
https://bugs.webkit.org/show_bug.cgi?id=105386

multiple crashes on media tests (Requested by loislo on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-18

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType):
(WebCore::createFileURLForApplicationCacheResource):
(WebCore::stringForNetworkState):
(WebCore::HTMLMediaElement::preload):
(WebCore::HTMLMediaElement::setLoop):
(WebCore::HTMLMediaElement::getPluginProxyParams):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFree one bit in RenderObject
jchaffraix@webkit.org [Wed, 19 Dec 2012 05:19:53 +0000 (05:19 +0000)]
Free one bit in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=105065

Reviewed by Simon Fraser.

This change uses the mutual exclusivity between the different position bits to pack
the information more efficiently. Because you can be only in one position at any point
in time, you only need to store 4 states in RenderObject (ie 2 bits of information) but
we were using 3 bits to store this information, thus losing one bit that I am reclaiming.

The change covers the 3 bits into a single PositionState. In order to avoid any extra branch
on the common code path, the logic was modified to be able to convert a EPosition to a PositionState
using only a bit mask. This also means that we now sets up and clears all the bits at once instead
of several calls, which matches more closely what happens at style change.

Change covered by existing tests.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::updateFromStyle):
Removed a call, superseed by the one in RenderBoxModelObject::updateFromStyle.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::updateFromStyle):
Changed to set the positioned bits in only one call to setPositionedState.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
Changed to clear all positioned bits at once.

* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::styleDidChange):
Ditto, which was probably the intent anyway.

* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
Changed to explicitly be AbsolutelyPositioned, not that it really matters as we only store
the out-of-flow information.

* rendering/RenderObject.h:
(WebCore::RenderObject::isOutOfFlowPositioned):
(WebCore::RenderObject::isInFlowPositioned):
(WebCore::RenderObject::isRelPositioned):
(WebCore::RenderObject::isStickyPositioned):
(WebCore::RenderObject::isPositioned):
(WebCore::RenderObject::clearPositionedState):
Updated after the renaming below.

(WebCore::RenderObject::setPositionState):
Ditto, but added an ASSERT to ensure that the out-of-flow bit is only set on boxes, to match
existing code.

* rendering/style/RenderStyleConstants.h:
Changed the values so that the conversion to PositionState is a simple bit mask, e.g
FixedPosition & 0x3 == AbsolutePosition as we only store the out-of-flow position information.

(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
Introduced PositionState to hold the different bits.

(WebCore::RenderObject::RenderObjectBitfields::setPositionedState):
(WebCore::RenderObject::RenderObjectBitfields::clearPositionedState):
(WebCore::RenderObject::RenderObjectBitfields::isOutOfFlowPositioned):
(WebCore::RenderObject::RenderObjectBitfields::isRelPositioned):
(WebCore::RenderObject::RenderObjectBitfields::isStickyPositioned):
(WebCore::RenderObject::RenderObjectBitfields::isPositioned):
Re-implemented these getters / setters and renamed them to match our style while at it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: aria-controls-with-tabs should run on Chromium
dmazzoni@google.com [Wed, 19 Dec 2012 05:13:59 +0000 (05:13 +0000)]
AX: aria-controls-with-tabs should run on Chromium
https://bugs.webkit.org/show_bug.cgi?id=105381

Reviewed by Chris Fleizach.

Use accessibleElementById so the test works on all platforms,
and specifically unskip it in the Chromium expectations.

* accessibility/aria-controls-with-tabs.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoText Autosizing: containers wider than their enclosing clusters should be autosized...
commit-queue@webkit.org [Wed, 19 Dec 2012 04:33:14 +0000 (04:33 +0000)]
Text Autosizing: containers wider than their enclosing clusters should be autosized as separate clusters
https://bugs.webkit.org/show_bug.cgi?id=103627

Patch by Anton Vayvod <avayvod@chromium.org> on 2012-12-18
Reviewed by Julien Chaffraix.

Source/WebCore:

Some blocks of texts might be wider than their parent clusters and need to be autosized separately.

isAutosizingCluster() now checks for the width of the container being greater than the width of the lowest
common ancestor of the text nodes of the enclosing cluster. This block containing all text is passed to all
tree traversal methods.
An overloaded version is added for cases when we don't have the lowest common ancestor yet.

The change fixes several cases covered by existing tests.

* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):

    Calls processCluster with a new number of arguments.

(WebCore::TextAutosizer::processCluster):

    Passes block containing all text nodes into processContainer. Assertion removed since it can no longer be
    checked without passing an additional parameter (the parent block containing all text) to the function
    for the sake of this assertion only.

(WebCore::TextAutosizer::processContainer):

    |parentBlockContainingAllText| parameter passed into isAutosizingCluster.

(WebCore::TextAutosizer::isAutosizingCluster(const RenderBlock*, const RenderBlock*)):

    The overloaded method that is used when the render block checked is already known to be an autosizing
    container and there's full information necessary to determine if it's a cluster like the parent block
    containing all text within the enclosing cluster.
    Considers a block a cluster if it is wider than its parent block containing all text within enclosing
    cluster.

(WebCore::TextAutosizer::isAutosizingCluster(const RenderObject*)):

    The overloaded method that checks for the given object to be an autosizing container first (for
    convenience of the caller) and doesn't require information about the parent cluster. Used when such
    information is not available, for example, in the process of retrieving the information for the parent
    cluster or when looking for the root cluster in the tree.

(WebCore::TextAutosizer::clusterShouldBeAutosized):

    Passes new parameter to measureDescendantTextWidth.

(WebCore::TextAutosizer::measureDescendantTextWidth):

    Uses blockContainingAllText parameter to pass to isAutosizingCluster.

(WebCore::TextAutosizer::findDeepestBlockContainingAllText):

    Assertion removed since it can no longer be checked without passing an additional parameter (the
    parent block containing all text) to the function for the sake of this assertion only.

(WebCore::TextAutosizer::findFirstTextLeafNotInCluster):
    Uses shorter isAutosizingCluster call.

LayoutTests:

Modified existing tests to reflect the new autosizing approach to handling of the elements that are
wider than the lowest common ancestor of the text nodes of the enclosing autosizing cluster.

* fast/text-autosizing/cluster-wide-in-narrow-expected.html:
* fast/text-autosizing/cluster-wide-in-narrow.html:
* fast/text-autosizing/wide-child-expected.html:
* fast/text-autosizing/wide-child.html:
* fast/text-autosizing/wide-in-narrow-overflow-scroll-expected.html:
* fast/text-autosizing/wide-in-narrow-overflow-scroll.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCorrecting reviewer in ChangeLogs.
ap@apple.com [Wed, 19 Dec 2012 04:23:31 +0000 (04:23 +0000)]
Correcting reviewer in ChangeLogs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Remove unnecessary functions from CookiesStrategy
ap@apple.com [Wed, 19 Dec 2012 04:21:48 +0000 (04:21 +0000)]
    Remove unnecessary functions from CookiesStrategy
        https://bugs.webkit.org/show_bug.cgi?id=105369

        Reviewed by Sam Weinig.

        Remove CookieJar functions that are only ever called from WebKit.

        * WebCore.exp.in:
        * loader/CookieJar.cpp:
        * loader/CookieJar.h:
        * platform/CookiesStrategy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse element.webkitCreateShadowRoot instead of WebKitShadowRoot in PerformanceTests.
hayato@chromium.org [Wed, 19 Dec 2012 04:18:43 +0000 (04:18 +0000)]
Use element.webkitCreateShadowRoot instead of WebKitShadowRoot in PerformanceTests.
https://bugs.webkit.org/show_bug.cgi?id=105256

Reviewed by Dimitri Glazkov.

WebKitShadowRoot constructor was deleted in favor of element.webkitCreateShadowRoot().

* ShadowDOM/ChangingClassNameShadowDOM.html:
* ShadowDOM/ChangingSelect.html:
* ShadowDOM/ContentReprojection.html:
* ShadowDOM/DistributionWithMultipleShadowRoots.html:
* ShadowDOM/LargeDistributionWithLayout.html:
* ShadowDOM/MultipleInsertionPoints.html:
* ShadowDOM/ShadowReprojection.html:
* ShadowDOM/SmallDistributionWithLayout.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoProxies should set InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero
fpizlo@apple.com [Wed, 19 Dec 2012 03:29:41 +0000 (03:29 +0000)]
Proxies should set InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero
https://bugs.webkit.org/show_bug.cgi?id=105379

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Forgetting to set this flag led to the DFG trying to ensure array storage on a proxy. I've
now hardened the code with a release assertion as well as fixing the bug. A release assertion
is appropriate here since this is slow-path code.

* runtime/JSObject.cpp:
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::ensureInt32Slow):
(JSC::JSObject::ensureDoubleSlow):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::ensureArrayStorageSlowNoCheck):
(JSC::JSObject::ensureArrayStorageSlow):
(JSC):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
* runtime/JSObject.h:
(JSObject):
* runtime/JSProxy.h:
(JSProxy):

LayoutTests:

* fast/js/dfg-ensure-non-array-array-storage-on-window-expected.txt: Added.
* fast/js/dfg-ensure-non-array-array-storage-on-window.html: Added.
* fast/js/script-tests/dfg-ensure-non-array-array-storage-on-window.js: Added.
(foo):
(bar):
(.shouldBe):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, fix expected file to have the right test description.
fpizlo@apple.com [Wed, 19 Dec 2012 03:28:53 +0000 (03:28 +0000)]
Unreviewed, fix expected file to have the right test description.

* fast/js/dfg-ensure-array-storage-on-window-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit/mac: Add SPI to WebKit1 WebFrame for hit testing
alice.liu@apple.com [Wed, 19 Dec 2012 03:00:02 +0000 (03:00 +0000)]
Source/WebKit/mac: Add SPI to WebKit1 WebFrame for hit testing
https://bugs.webkit.org/show_bug.cgi?id=105106

Reviewed by Dan Bernstein.

* WebView/WebFrame.mm:
(-[WebFrame elementAtPoint:]): Added. Takes an NSPoint to feed to the WebCore::Frame for hit-testing.
Creates a WebElementDictionary from that WebCore::HitTestResult, and returns the element dictionary.
* WebView/WebFramePrivate.h:

Tools: Test for https://bugs.webkit.org/show_bug.cgi?id=105106
Add SPI to WebKit1 WebFrame for hit testing

Reviewed by Dan Bernstein.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
* TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
(TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
Then hit-tests at three points, expecting to hit the two divs and body element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][AC] Assertion failed while destroying GraphicsLayer
commit-queue@webkit.org [Wed, 19 Dec 2012 02:45:02 +0000 (02:45 +0000)]
[GTK][AC] Assertion failed while destroying GraphicsLayer
https://bugs.webkit.org/show_bug.cgi?id=105312

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-12-18
Reviewed by Gustavo Noronha Silva.

According to the comment in GraphicsLayer::~GraphicsLayer(), we should call
willBeDestroyed() before destructor of GraphicsLayer.

No new tests since this patch can be covered by already existing gtk ac tests.

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter): call willBeDestroyed()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/css/image-set-value-not-removed-crash.html should not InsertText with an apostrophe
timothy_horton@apple.com [Wed, 19 Dec 2012 02:35:34 +0000 (02:35 +0000)]
fast/css/image-set-value-not-removed-crash.html should not InsertText with an apostrophe
https://bugs.webkit.org/show_bug.cgi?id=105375

Reviewed by Beth Dakin.

Don't InsertText text content with an apostrophe in it, as this can break
on platforms where apostrophes turn into curly quotes.

* fast/css/image-set-value-not-removed-crash-expected.txt:
* fast/css/image-set-value-not-removed-crash.html:
* platform/win/fast/css/image-set-value-not-removed-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138102 268f45cc-cd09-0410-ab3c-d52691b4dbfc