aroben [Fri, 6 Jul 2007 08:44:11 +0000 (08:44 +0000)]
Fix <rdar://problem/
5301994> Garbled text still showing on some sites
WebCore:
Fix <rdar://problem/
5301994> Garbled text still showing on some sites
Replace calls to GetGlyphIndices with wkGetGlyphs.
Reviewed by Alice.
* platform/win/GlyphPageTreeNodeWin.cpp:
(WebCore::GlyphPage::fill): Use wkGetGlyphs.
* platform/win/FontDataWin.cpp:
(WebCore::FontData::containsCharacters):
WebKitLibraries:
Update WebKitSystemInterface.{h,lib} for <rdar://problem/
5301994>
Reviewed by Alice.
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:
* win/lib/WebKitSystemInterface_debug.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose [Fri, 6 Jul 2007 07:41:23 +0000 (07:41 +0000)]
Forgot ChangeLog description
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose [Fri, 6 Jul 2007 07:37:56 +0000 (07:37 +0000)]
Reviewed by Adam Roben.
* building/build.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose [Fri, 6 Jul 2007 07:01:56 +0000 (07:01 +0000)]
Not reviewed - Windows build fix.
* bridge/win/FrameWin.cpp:
(WebCore::imageFromSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Fri, 6 Jul 2007 06:14:55 +0000 (06:14 +0000)]
Add optional --qmake= and --qt arguments to force Qt builds and force with a
specific qmake binary
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Fri, 6 Jul 2007 05:12:47 +0000 (05:12 +0000)]
Switch USE(ICONDATABASE) to ENABLE(ICONDATABASE)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 6 Jul 2007 03:49:50 +0000 (03:49 +0000)]
WebCore:
Reviewed by Adam
- WebCore part of fix for <rdar://problem/
5315033>
* rendering/RenderObject.h:
replaced PaintRestrictionSelectionOnlyWhiteText with PaintRestrictionSelectionOnlyBlackText
(WebCore::RenderObject::PaintInfo::PaintInfo):
replaced forceWhiteText with forceBlackText
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addLineBoxRects):
added a useSelectionHeight parameter, which defaults to false; this method is unimplemented
at this level so this has no effect.
* rendering/RenderText.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::addLineBoxRects):
added a useSelectionHeight parameter, which defaults to false. If true, use the vertical position
and height returned by selectionRect rather than replacing it with the more tight-fitting position
and height of the line box.
* dom/Range.h:
* dom/Range.cpp:
(WebCore::Range::addLineBoxRects):
added a useSelectionHeight parameter, which defaults to false. Passes this along to RenderObject.
* page/Frame.h:
renamed parameter to selectionImage
* page/Frame.cpp:
(WebCore::Frame::selectionTextRects):
pass true for addLineBoxRects new useSelectionHeight parameter, so the rects returned by this new
method will match the height that the selection would be painted here
(WebCore::Frame::paint):
updated for white->black name changes
* page/mac/FrameMac.mm:
(WebCore::Frame::selectionImage):
updated for white->black name changes
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintTextDecorations):
updated for white->black name changes
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
updated for white->black name changes
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
updated for white->black name changes, and actually use black instead of white. This was the goal
of all the name changes.
WebKit:
Reviewed by Adam
- WebKit part of fix for <rdar://problem/
5315033>
* WebView/WebDocumentPrivate.h:
new selectionImageForcingBlackText: method. selectionImageForcingWhiteText: is no longer used and was never
in an official release of WebKit, so it could be removed, except that doing so would cause trouble for people
using nightly WebKit with Safari 3.0 beta. So I left it in, but made it just force black text instead of
white text, which will look different for those nightly WebKit/Safari 3.0 beta people but not break anything.
* Misc/WebSearchableTextView.m:
(-[WebSearchableTextView selectionImageForcingBlackText:]):
new unimplemented protocol method for this obsolete class
* WebView/WebHTMLView.mm:
(-[WebHTMLView selectionImageForcingBlackText:]):
calls through to WebCore the way selectionImageForcingWhiteText: used to
(-[WebHTMLView selectionImageForcingWhiteText:]):
now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name
* WebView/WebPDFView.mm:
(-[WebPDFView selectionImageForcingBlackText:]):
guts of old selectionImageForcingWhiteText:, but with black substituted for white
(-[WebPDFView selectionImageForcingWhiteText:]):
now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 6 Jul 2007 03:33:54 +0000 (03:33 +0000)]
Forgot the file extension
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 6 Jul 2007 03:31:56 +0000 (03:31 +0000)]
Updated the Windows Skipped file
* win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 6 Jul 2007 02:28:42 +0000 (02:28 +0000)]
Reviewed by Oliver.
Fix layout test failures.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
Don't make a representation if we're creating the initial document.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 6 Jul 2007 01:58:37 +0000 (01:58 +0000)]
Fix Bug 14388: Input in text fields limited to 1024 characters
WebCore:
2007-07-05 Alp Toker <alp.toker@collabora.co.uk>
Fix Bug 14388: Input in text fields limited to 1024 characters
http://bugs.webkit.org/show_bug.cgi?id=14388
Slightly modified by Adam Roben.
Reviewed by Adele.
Test: fast/forms/input-length.html
* html/HTMLInputElement.cpp: Bump limit to 524288.
(WebCore::HTMLInputElement::init):
(WebCore::HTMLInputElement::parseMappedAttribute):
* html/HTMLInputElement.h:
LayoutTests:
Added two tests for Bug 14388: Input in text fields limited to 1024 characters
fast/forms/input-maxlength-2.html is obsoleted by
fast/forms/input-maxlength.html.
Reviewed by Adele.
* fast/forms/input-implicit-length-limit-expected.txt: Added.
* fast/forms/input-implicit-length-limit.html: Added.
* fast/forms/input-maxlength-2-expected.checksum: Removed.
* fast/forms/input-maxlength-2-expected.png: Removed.
* fast/forms/input-maxlength-2-expected.txt: Removed.
* fast/forms/input-maxlength-2.html: Removed.
* fast/forms/input-maxlength-expected.txt: Added.
* fast/forms/input-maxlength.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 6 Jul 2007 01:58:27 +0000 (01:58 +0000)]
Add another hanging test to the Leopard Skipped file
Rubberstamped by Adele.
* mac/leopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 6 Jul 2007 01:02:45 +0000 (01:02 +0000)]
Updating expected results for r24027.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 5 Jul 2007 23:12:28 +0000 (23:12 +0000)]
Build fix.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 5 Jul 2007 23:04:11 +0000 (23:04 +0000)]
Forgot to add this file for the test for <rdar://problem/
5303566> REGRESSION:
XMLHttpRequest.responseXML. Darin added a dummy file before -- here's the
real one.
* fast/loader/resources/plist.app:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 5 Jul 2007 22:56:24 +0000 (22:56 +0000)]
Reviewed by Geoff.
Add focus, blur and close functions to DOMWindow implementation class
and move bindings from Window to JSDOMWindow.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::customGetOwnPropertySlot):
* bindings/js/kjs_window.cpp:
(KJS::Window::getOwnPropertySlot):
(KJS::WindowFunc::callAsFunction):
* bindings/js/kjs_window.h:
(KJS::Window::):
* bindings/scripts/CodeGeneratorJS.pm: Move prototype function declaration from
the implementation to the header.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::focus):
(WebCore::DOMWindow::blur):
(WebCore::DOMWindow::close):
* page/DOMWindow.h:
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 5 Jul 2007 22:52:38 +0000 (22:52 +0000)]
LayoutTests:
Reviewed by Harrison.
<rdar://problem/
5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body
Demonstrates bug:
* editing/style/
5279521-expected.checksum: Added.
* editing/style/
5279521-expected.png: Added.
* editing/style/
5279521-expected.txt: Added.
* editing/style/
5279521.html: Added.
Fixed:
* fast/forms/radio-check-click-and-drag-expected.txt:
* fast/forms/textarea-type-spaces-expected.txt:
WebCore:
Reviewed by Harrison.
<rdar://problem/
5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body
* editing/TextIterator.cpp:
(WebCore::TextIterator::exitNode): Previously emitted content shouldn't have
to come from a text node in order to emit a '\n' as we exit block containers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 5 Jul 2007 22:50:52 +0000 (22:50 +0000)]
Reviewed by Geoff.
<rdar://problem/
5315284> REGRESSION: Leopard Launch Time - plugins are being accessed at startup.
Set a response that has a MIME type of "text/html" on the document loader so WebKit won't refresh the
plugin database looking for a plug-in that can handle the document's MIME type (which will be null anyway).
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 5 Jul 2007 22:34:43 +0000 (22:34 +0000)]
Reviewed by Oliver.
<rdar://problem/
5106788>
WebKit loads user style sheets too late as seen in Mail (breaks DataDetectors; Mail flashes wrong font)
Let the document know when the user style sheet is loading so that it try not to display anything
until the user style sheet has finished loading.
* page/Frame.cpp:
(WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
(WebCore::UserStyleSheetLoader::~UserStyleSheetLoader):
(WebCore::UserStyleSheetLoader::setCSSStyleSheet):
(WebCore::Frame::setUserStyleSheetLocation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 21:02:41 +0000 (21:02 +0000)]
Fix a leak in WebView::setToolTip
Reviewed by Beth.
* WebView.cpp:
(WebView::setToolTip):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 5 Jul 2007 20:43:30 +0000 (20:43 +0000)]
Reviewed by John.
<rdar://problem/
5314993> Shiira 2.1 throws an exception open a new window: -[WebInspector window]: unrecognized selector
Add an empty implementation of this method to prevent Shiira from throwing an exception.
Also log that this method is obsolete and the class will be removed.
* WebInspector/WebInspector.mm:
(-[WebInspector window]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 20:16:06 +0000 (20:16 +0000)]
Fix Bug 14143: Tooltips not displayed on Windows
http://bugs.webkit.org/show_bug.cgi?id=14143
<rdar://problem/
4719799>
Reviewed by Oliver.
* WebChromeClient.cpp:
(WebChromeClient::setToolTip): Call up to WebView.
* WebView.cpp:
(WebView::WebView): Initialize m_toolTipHwnd member.
(WebView::initWithFrame): Set up the tool tip window.
(initCommonControls): Added.
(WebView::initializeToolTipWindow): Added.
(WebView::setToolTip): Set the tool tip text and enable/disable the
tool tip.
* WebView.h: Added/updated declarations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 5 Jul 2007 18:09:57 +0000 (18:09 +0000)]
Reviewed by Darin.
Move JSDOMWindow overriding getOwnPropertySlot logic from KJS::Window
up into JSDOMWindow. No change in functionality so no testcase required.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::customGetOwnPropertySlot):
* bindings/js/kjs_window.cpp:
(KJS::Window::getOwnPropertySlot):
* bindings/js/kjs_window.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 5 Jul 2007 17:51:29 +0000 (17:51 +0000)]
- tweaked IDN test and checked in both Tiger results and Leopard
* fast/encoding/idn-security.html: Changed test to only test lowercase "a" since the behavior for
uppercase letters has changed in the new ICU. Also added code to detect the older ICU and expect
different results.
* fast/encoding/idn-security-expected.txt: Regenerated results.
* mac/leopard/fast/encoding/idn-security-expected.txt: Copied from fast/encoding/idn-security-expected.txt.
The modified.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 5 Jul 2007 17:02:49 +0000 (17:02 +0000)]
Reviewed and Landed by Sam.
- fix bug 14465 for window.showModalDialog
* bindings/js/kjs_window.cpp:
(KJS::parseModalDialogFeatures):
(KJS::showModalDialog):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 5 Jul 2007 16:14:19 +0000 (16:14 +0000)]
Reviewed by Mitz.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14465
window.open() uses the literal "undefined" as the URL
* bindings/js/kjs_window.cpp:
(KJS::WindowFunc::callAsFunction): add checks for undefined and null values when setting the url.
* manual-tests/open-url-undefined.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Jul 2007 13:51:33 +0000 (13:51 +0000)]
2007-07-05 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Rob Buis.
Rework FontData and FontPlatformData for the Gdk work to make valgrind
happy.
Move destroying of FontConfig and Cairo objects held in FontPlatformData
to FontData::platformDestroy. The ownership of these objects is held by
FontData. This is following the Mac and Qt port at least.
Currently it is possible that FontPlatformData will not create cairo resources
in this case at least make sure the variables are initialized to 0.
Initialize x,y of the cairo_glyph_t with zero to avoid extents.x_advance depending
on subtracing with not defined values.
FontPlatformData::hash. Using FontDescription is a bad idea as we don't have a clue
about how it is packed, if holes are present, etc. The FcPattern and the m_fontMatrix
should be good enough to describe the Font. All other objects are created using these
variables
Replace C-style casts with C++ casts, in this case reinterpret_cast.
* platform/gdk/FontDataGdk.cpp:
(WebCore::FontData::platformInit): Don't assert
(WebCore::FontData::platformDestroy): Take over ownership
(WebCore::FontData::platformWidthForGlyph): initialize
(WebCore::FontData::setFont): be paranoid and assert
* platform/gdk/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData): Initialize everything
(WebCore::FontPlatformData::hash): make valgrind happy and don't use m_fontDescription
* platform/gdk/FontPlatformDataGdk.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData): FontData::platformDestroy will do this
(WebCore::FontPlatformData::list): Don't use C-style casts.
(WebCore::FontPlatformData::setFont): m_fontFace, m_fontMatrix, m_options might not be initialized
(WebCore::FontPlatformData::operator==): Don't use C-style casts.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Jul 2007 13:47:47 +0000 (13:47 +0000)]
2007-07-05 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=14445
GraphicsContextCairo code style cleanup
Follow the cr naming convention for cairo_t*.
Remove trailing whitespace.
Replace C casts with C++ casts.
Avoid needless casts.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::platformContext):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::drawRect):
(WebCore::adjustLineToPixelBoundaries):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc): Save/restore the graphics state.
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::origin):
(WebCore::GraphicsContext::setPlatformStrokeThickness):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::GraphicsContext::setPlatformFont):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::GraphicsContext::setCompositeOperation):
(WebCore::GraphicsContext::beginPath):
(WebCore::GraphicsContext::addPath):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::scale):
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/cairo/ImageCairo.cpp: Avoid the confusing ctxt/context naming scheme.
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Jul 2007 13:45:16 +0000 (13:45 +0000)]
2007-07-05 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=14531
Cairo SVGImage::nativeImageForCurrentFrame() has no return
Return the Cairo surface from the frame cache.
Also add a fall-through else macro with notImplemented() so that future
ports do not make the same mistake.
* platform/graphics/svg/SVGImage.cpp:
(WebCore::SVGImage::nativeImageForCurrentFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Jul 2007 13:43:44 +0000 (13:43 +0000)]
2007-07-05 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=14513
Cairo animated GIF support is broken
Implement ImageSource::frameIsCompleteAtIndex() to enable animated GIFs.
* platform/graphics/cairo/ImageSourceCairo.cpp:
(WebCore::ImageSource::frameIsCompleteAtIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 09:15:19 +0000 (09:15 +0000)]
Add a Skipped file for Leopard.
Reviewed by Mark.
* mac/leopard/Skipped: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 08:21:09 +0000 (08:21 +0000)]
Warn about tests in the Skipped file that succeeded
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 08:10:16 +0000 (08:10 +0000)]
Removed unused install-win-extras script
Rubberstamped by Mark.
* Scripts/install-win-extras: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 07:51:52 +0000 (07:51 +0000)]
Show the test's extension in the results page
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 07:49:57 +0000 (07:49 +0000)]
Add more options for controlling the interpretation of the Skipped file
Reviewed by Mark.
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 06:56:50 +0000 (06:56 +0000)]
Add --skipped-only option to run-webkit-tests
When this option is specified, only those tests listed in the Skipped
file are run.
Reviewed by Mark.
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 06:42:00 +0000 (06:42 +0000)]
Clean up/alphabetize the run-webkit-tests help message
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 06:24:03 +0000 (06:24 +0000)]
Enable a Leopard-specific Skipped list.
Reviewed by Mark.
* Scripts/run-webkit-tests: Check for Leopard.
* Scripts/webkitdirs.pm: Added isTiger/isLeopard.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Jul 2007 06:12:57 +0000 (06:12 +0000)]
... and it was reviewed by Adam.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Jul 2007 06:08:56 +0000 (06:08 +0000)]
2007-07-04 Matt Perry <mpComplete@gmail.com>
Fix for http://bugs.webkit.org/show_bug.cgi?id=13400
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
<rdar://problem/
5153025>
Treat userGesture as always true for setLocation, forcing a back/forward
entry to be created.
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::setLocation):
2007-07-04 Matt Perry <mpComplete@gmail.com>
Test for http://bugs.webkit.org/show_bug.cgi?id=13400
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
<rdar://problem/
5153025>
Test that assigning to document.location in various ways adds an
item to the back/forward list.
* http/tests/navigation/document-location-click-expected.txt: Added.
* http/tests/navigation/document-location-click-timeout-expected.txt: Added.
* http/tests/navigation/document-location-click-timeout.html: Added.
* http/tests/navigation/document-location-click.html: Added.
* http/tests/navigation/document-location-mouseover-expected.txt: Added.
* http/tests/navigation/document-location-mouseover.html: Added.
* http/tests/navigation/document-location-onload-expected.txt: Added.
* http/tests/navigation/document-location-onload.html: Added.
* http/tests/navigation/resources/document-location.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 06:04:56 +0000 (06:04 +0000)]
Restore MouseEventWithHitTestResults::targetNode's old behavior
Reviewed by Mark.
Fixes fast/images/imagemap-case and fast/replace/image-map.
* page/MouseEventWithHitTestResults.cpp:
(WebCore::MouseEventWithHitTestResults::targetNode): Use the inner
node, not the inner non-shared node.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 05:21:28 +0000 (05:21 +0000)]
Mac, Qt, and Gdk build fixes.
* page/EventHandler.h:
* page/gdk/EventHandlerGdk.cpp:
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passSubframeEventToSubframe):
* page/qt/EventHandlerQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 03:23:48 +0000 (03:23 +0000)]
Fix the Qt/Gdk builds.
* page/gdk/EventHandlerGdk.cpp:
* page/qt/EventHandlerQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 03:00:55 +0000 (03:00 +0000)]
Move tooltip logic down into WebCore so that it can be shared cross-platform
WebCore:
Move tooltip logic down into WebCore so that it can be shared cross-platform
Reviewed by Sam.
* page/Chrome.cpp:
(WebCore::Chrome::setToolTip): Added.
* page/Chrome.h:
* page/ChromeClient.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved): Call Chrome::setToolTip.
* platform/graphics/svg/SVGImageEmptyClients.h:
Added stubs for Gdk:
* platform/gdk/ChromeClientGdk.h:
* platform/gdk/TemporaryLinkStubs.cpp:
(ChromeClientGdk::setToolTip):
WebKit:
Move tooltip logic down into WebCore so that it can be shared cross-platform
Reviewed by Sam.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::setToolTip): Added.
* WebView/WebHTMLView.mm: Removed _resetCachedWebPreferences.
(-[WebHTMLView _updateMouseoverWithEvent:]): Removed tooltip code.
(-[WebHTMLView initWithFrame:]): Removed call to
_resetCachedWebPreferences.
(-[WebHTMLView setDataSource:]): Ditto.
* WebView/WebHTMLViewInternal.h: Removed showsURLsInToolTips ivar.
* WebView/WebHTMLViewPrivate.h: Added declaration for _setTooltip so
that WebChromeClient can call it.
WebKit/win:
Added a stub for WebChromeClient::setToolTip
Reviewed by Sam.
* WebChromeClient.cpp:
* WebChromeClient.h:
WebKitQt:
Added a stub for ChromeClientQt::setToolTip
Reviewed by Sam.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::setToolTip):
* WebCoreSupport/ChromeClientQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 03:00:41 +0000 (03:00 +0000)]
Add/initialize Settings::showsURLsInToolTips
WebCore:
Add Settings::showsURLsInToolTips
Reviewed by Sam.
* WebCore.exp:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
WebKit:
Initialize Settings::showsURLsInToolTips
Reviewed by Sam.
* WebView/WebView.mm:
(-[WebView _updateWebCoreSettingsFromPreferences:]):
WebKit/win:
Initialize Settings::showsURLsInToolTips
Reviewed by Sam.
* WebView.cpp:
(WebView::updateWebCoreSettingsFromPreferences):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 03:00:29 +0000 (03:00 +0000)]
Move logic for calling mouseDidMoveOverElement into WebCore
WebCore:
Move logic for calling mouseDidMoveOverElement into WebCore
Reviewed by Sam.
* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved): Added. Calls Chrome::mouseDidMoveOverElement.
(WebCore::EventHandler::handleMouseMoveEvent): Now takes an optional
HitTestResult* parameter which is used to communicate to the caller the
node the mouse is over.
* page/EventHandler.h:
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::mouseMoved): Changed to call the overloaded
mouseMoved().
(WebCore::EventHandler::passMouseMoveEventToSubframe): Pass hoveredNode
through to the subframe so we can get the deepest node hovered, not
just the node's parent frame.
* page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.
WebKit:
Removed call to mouseDidMoveOverElement now that WebCore handles it
Reviewed by Sam.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateMouseoverWithEvent:]):
WebKit/win:
Removed call to mouseDidMoveOverElement now that WebCore handles it
Reviewed by Sam.
* WebView.cpp:
(WebView::handleMouseEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 03:00:16 +0000 (03:00 +0000)]
Add Chrome::mouseDidMoveOverElement
WebCore:
Add Chrome::mouseDidMoveOverElement
This does the work of calling up to the ChromeClient (which will call
the UI delegate).
Reviewed by Sam.
* page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement): Added.
* page/Chrome.h:
* page/ChromeClient.h:
* platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to
ChromeClient.
* platform/gdk/ChromeClientGdk.h:
* platform/gdk/TemporaryLinkStubs.cpp:
(ChromeClientGdk::mouseDidMoveOverElement):
WebKit:
Add WebChromeClient::mouseDidMoveOverElement
This is not called yet.
Reviewed by Sam.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
WebKit/win:
Add WebChromeClient::mouseDidMoveOverElement
This is not called yet.
Reviewed by Sam.
* WebChromeClient.cpp:
(WebChromeClient::mouseDidMoveOverElement):
* WebChromeClient.h:
WebKitQt:
Added a stub for ChromeClientQt::mouseDidMoveOverElement
Reviewed by Sam.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::mouseDidMoveOverElement):
* WebCoreSupport/ChromeClientQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 03:00:03 +0000 (03:00 +0000)]
Changed PlatformMouseEvent to store the modifier flags of the event
Reviewed by Sam.
* platform/PlatformMouseEvent.h:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* platform/mac/PlatformMouseEventMac.mm:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* platform/win/PlatformMouseEventWin.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 02:59:52 +0000 (02:59 +0000)]
Add HitTestResult::setToNonShadowAncestor
Reviewed by Sam.
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint): Moved logic into
HitTestResult::setToNonShadowAncestor.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::setToNonShadowAncestor):
* rendering/HitTestResult.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Jul 2007 02:59:41 +0000 (02:59 +0000)]
Change MouseEventWithHitTestResults to hold onto a HitTestResult
Reviewed by Sam.
* dom/Document.cpp:
(WebCore::Document::prepareMouseEvent):
* page/MouseEventWithHitTestResults.cpp:
(WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
(WebCore::MouseEventWithHitTestResults::targetNode):
(WebCore::MouseEventWithHitTestResults::localPoint):
(WebCore::MouseEventWithHitTestResults::scrollbar):
* page/MouseEventWithHitTestResults.h:
(WebCore::MouseEventWithHitTestResults::event):
(WebCore::MouseEventWithHitTestResults::hitTestResult):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23994
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 5 Jul 2007 02:52:25 +0000 (02:52 +0000)]
- take out infinity tests from the test for bug
5292262 (see below) for now since they
give different results on PowerPC and Intel and are not an important part of the intent
of this test anyway; the bug was about normal numbers, not edge cases like infinity
If we want to test the infinity behavior, we should make a separate test later.
* fast/objc/longlongTest-expected.txt: Removed results from infinity tests.
* fast/objc/longlongTest.html: Removed infinity tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23993
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose [Thu, 5 Jul 2007 01:16:15 +0000 (01:16 +0000)]
Not reviewed, gdk build fix.
* platform/gdk/FrameGdk.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23992
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Wed, 4 Jul 2007 22:54:49 +0000 (22:54 +0000)]
LayoutTests:
Reviewed by John.
Test for Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
<rdar://problem/
5237811>
* fast/table/incomplete-table-in-fragment-hang-expected.txt: Added.
* fast/table/incomplete-table-in-fragment-hang.html: Added.
WebCore:
Reviewed by John.
Fix Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
<rdar://problem/
5237811>
It is possible to add table parts (thead etc) without table ancestor to a document fragment. If a new table element
was added to such a part, as in
div.innerHTML = '<tbody><table>';
the parser error handling code would try to pop the previous table as normal. However since
the table does not actually exist nothing would happen and parser would go to infinite recursion.
Solution here is to pop table parts one by one when handling the error inside a fragment instead of trying to pop
the table straight away (as it might not exist).
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleError):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23991
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 4 Jul 2007 21:33:18 +0000 (21:33 +0000)]
Patch from Qing Zhao to fix combobox rendering
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 4 Jul 2007 21:23:50 +0000 (21:23 +0000)]
Compile
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23988
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 4 Jul 2007 20:04:31 +0000 (20:04 +0000)]
LayoutTests:
Reviewed by Mitz.
Test for http://bugs.webkit.org/show_bug.cgi?id=14504
REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly
* fast/dom/Window/window-property-shadowing-expected.txt: Added.
* fast/dom/Window/window-property-shadowing.html: Added.
WebCore:
Reviewed by Mitz.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14504
REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly
- Made it possible (again) to shadow window properties with local variable names.
Test: fast/dom/Window/window-property-shadowing.html
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::customPut):
* bindings/js/kjs_window.cpp:
(KJS::Window::put):
* bindings/scripts/CodeGeneratorJS.pm:
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 4 Jul 2007 18:37:11 +0000 (18:37 +0000)]
Reviewed by Adam.
Fixed <rdar://problem/
5225119> support smart pasting on Windows
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Added new files
* editing/SmartReplace.cpp: Added.
(WebCore::isCharacterSmartReplaceExempt):
Added non-CF implementation placeholder
* editing/SmartReplace.h: Added.
* editing/SmartReplaceCF.cpp: Added.
(WebCore::getSmartSet):
(WebCore::isCharacterSmartReplaceExempt):
Added new implementation
* bridge/win/FrameWin.cpp:
* page/Frame.h:
* page/mac/FrameMac.mm:
Removed old declaration and implementation
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
Changed to call the new function instead of old
* page/mac/WebCoreFrameBridge.h:
* page/mac/WebCoreFrameBridge.mm:
Removed old declaration and implementation
(-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):
Changed to call the new function instead of old
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::Pasteboard):
Register new clipboard format
(WebCore::Pasteboard::writeSelection):
Set data for smartpaste format on clipboard
(WebCore::Pasteboard::canSmartReplace):
Added non-stub implementation
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23986
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 4 Jul 2007 18:33:18 +0000 (18:33 +0000)]
Reenable some code for 64-bit now that <rdar://problem/
5311640> and <rdar://problem/
5311690> are resolved.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 4 Jul 2007 15:15:15 +0000 (15:15 +0000)]
Patch from Qing Zhao: Similar to the PlatformScrollbar fixes, adjust the
painter to make the styler draw all subcontrols, and in this case the focus
rect, in the proper location
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23984
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 4 Jul 2007 10:56:08 +0000 (10:56 +0000)]
2007-07-04 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=14495
REGRESSION: Wrong cursor is displayed during drag and drop when text is selected
<rdar://problem/
5312384>
No test possible because DumpRenderTree cannot query the current cursor.
* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor): Changed into a member function and
added that if the last mouse down event could not have started a
selection, then the cursor should not change to an I-beam unconditionally.
(WebCore::EventHandler::handleMouseMoveEvent):
* page/EventHandler.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 4 Jul 2007 10:52:57 +0000 (10:52 +0000)]
2007-07-04 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Rob Buis.
A little progress in tracking dependencies.
* WebCore.pro: Add DEPENDPATH for the Gdk port.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 4 Jul 2007 03:02:32 +0000 (03:02 +0000)]
* StringsNotToBeLocalized.txt: Updated for recent changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 4 Jul 2007 01:07:36 +0000 (01:07 +0000)]
Reviewed by Darin.
Remove HIWebView in 64-bit.
Also disable a few calls that are now gone in 64-bit and filed these bugs:
<rdar://problem/
5311653> WebKit needs to adopt HIGetMousePosition where we used GetGlobalMouse before
<rdar://problem/
5311648> WebKit needs to move off of CopyEvent in WebBaseNetscapePluginView
<rdar://problem/
5311640> WebKit needs a new solution for HISearchWindowShow on 64-bit
* Carbon/CarbonUtils.m:
* Carbon/CarbonWindowAdapter.m:
* Carbon/CarbonWindowContentView.m:
* Carbon/CarbonWindowFrame.m:
* Carbon/HIViewAdapter.m:
(SetViewNeedsDisplay):
* Carbon/HIWebView.m:
(Draw):
(SyncFrame):
* Configurations/WebKit.xcconfig:
* Plugins/WebBaseNetscapePluginView.mm:
(+[WebBaseNetscapePluginView getCarbonEvent:]):
(TSMEventHandler):
* WebKit.LP64.exp: Added.
* WebView/WebView.mm:
(-[WebView _searchWithSpotlightFromMenu:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 4 Jul 2007 01:04:11 +0000 (01:04 +0000)]
Disable the strict aliasing warning until <rdar://problem/
5311093> is fixed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 4 Jul 2007 01:02:32 +0000 (01:02 +0000)]
64-bit build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 4 Jul 2007 00:58:41 +0000 (00:58 +0000)]
Fixed update-webkit-localizable-strings to work with new extract-localizable-strings
Got rid of extract-webkit-localizable-strings because it was trying to
do update-webkit-localizable-strings' job.
Rubberstamped by Darin.
* Scripts/extract-webkit-localizable-strings: Removed.
* Scripts/update-webkit-localizable-strings: Renamed from
extract-localizable-strings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 4 Jul 2007 00:40:57 +0000 (00:40 +0000)]
Merge the Windows and Mac localized strings and exceptions files
WebKit:
Merge the Windows and Mac localized strings and exceptions files
Reviewed by Darin and Anders.
* English.lproj/Localizable.strings: Added Windows strings.
* StringsNotToBeLocalized.txt: Renamed from WebKit/English.lproj/StringsNotToBeLocalized.txt.
WebKit/win:
Merge the Windows and Mac localized strings and exceptions files
Reviewed by Darin and Anders.
* English.lproj/Localizable.strings: Added Mac strings.
* English.lproj/StringsNotToBeLocalized.txt: Removed.
WebKitTools:
Modify scripts to keep Mac/Windows localized strings in sync
extract-webkit-localizable-strings now handles extracting strings from
both the Mac and Windows WebKit ports and updating their respective
Localizable.strings files. extract-localizable-strings is now really a
piece of plumbing rather than a top-level tool.
Reviewed by Darin and Anders.
* Scripts/extract-localizable-strings: Changed to handle multiple
directories.
* Scripts/extract-webkit-localizable-strings: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 4 Jul 2007 00:29:31 +0000 (00:29 +0000)]
Removed printf I accidently left in.
* Misc/WebNSURLExtras.m: (mapHostNames):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 4 Jul 2007 00:04:19 +0000 (00:04 +0000)]
LayoutTests:
Reviewed by Tim Hatcher.
- tests for <rdar://problem/
5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
* editing/style/font-family-with-space-expected.txt: Added.
* editing/style/font-family-with-space.html: Added.
* fast/inspector/style-expected.txt: Updated expected results to expect "Lucida Grande" in quote marks.
WebCore:
Reviewed by Tim Hatcher.
- fix <rdar://problem/
5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
Test: editing/style/font-family-with-space.html
* css/FontFamilyValue.cpp:
(WebCore::isValidCSSIdentifier): Added. Implements the same rule that the CSS lexer does.
(WebCore::quoteStringIfNeeded): Changed to call isValidCSSIdentifier instead of just
checking for a leading "#" character.
* editing/markup.cpp:
(WebCore::escapeTextForMarkup): Changed to take a String parameter for better efficiency.
(WebCore::renderedText): Changed to return a String for better efficiency.
(WebCore::addNamespace): Updated to pass String to escapeTextForMarkup.
(WebCore::startMarkup): Updated to pass String to escapeTextForMarkup. Added missing call
to escapeTextForMarkup in the special case for the style property.
(WebCore::createMarkup): Changed from single quotes to double quotes and also added missing
call to escapeTextForMarkup in two special cases for the style property.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 3 Jul 2007 23:54:08 +0000 (23:54 +0000)]
Updating comment
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 3 Jul 2007 23:19:14 +0000 (23:19 +0000)]
Reviewed by Darin.
Twelfth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
- Add casts and accompanying FIXMEs to avoid remaining compiler errors.
* WebCore.xcodeproj/project.pbxproj:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::opened):
(WebCore::FrameLoader::sendRemainingDelegateMessages):
* loader/FrameLoader.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveData):
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
(-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::nsURLResponse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 3 Jul 2007 23:16:02 +0000 (23:16 +0000)]
LayoutTests:
Reviewed by Darin.
Test for: <rdar://problem/
5292988> domain names shouldn't contain ignorable characters
* fast/encoding/idn-security-expected.txt: Added.
* fast/encoding/idn-security.html: Added.
* win/Skipped: Blocked by <rdar://problem/
5301954>.
WebKit:
Reviewed by Darin.
Fix for: <rdar://problem/
5292988> domain names shouldn't contain ignorable characters
* Misc/WebNSURLExtras.m:
(isLookalikeCharacter): Renamed. Also excludes any non-printable character,
any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character,
and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars
(allCharactersInIDNScriptWhiteList):
WebKitTools:
Reviewed by Darin.
Extended DumpRenderTree to test encoding and decoding host names.
* DumpRenderTree/DumpRenderTree.m:
(+[LayoutTestController isSelectorExcludedFromWebScript:]): Added cases for encodeHostName and decodeHostName.
(+[LayoutTestController webScriptNameForSelector:]): ditto.
(-[LayoutTestController decodeHostName:]): Added.
(-[LayoutTestController encodeHostName:]): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 3 Jul 2007 22:51:56 +0000 (22:51 +0000)]
Reviewed by Darin.
Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
Add functions to test long long and unsigned long long.
* DumpRenderTree/DumpRenderTree.m:
(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(+[LayoutTestController webScriptNameForSelector:]):
(-[LayoutTestController objCLongLongRoundTrip:]):
(-[LayoutTestController objCUnsignedLongLongRoundTrip:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 3 Jul 2007 22:37:15 +0000 (22:37 +0000)]
JavaScriptCore:
Reviewed by Darin.
Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
- Fixes a real bug where where we were setting long long and unsigned long long
values to a long field.
* bindings/objc/objc_utility.mm:
(KJS::Bindings::convertValueToObjcValue):
LayoutTests:
Reviewed by Darin.
Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
* fast/objc: Added.
* fast/objc/longlongTest-expected.txt: Added.
* fast/objc/longlongTest.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 3 Jul 2007 22:02:27 +0000 (22:02 +0000)]
Reviewed by Maciej.
- fix <rdar://problem/
5310848> WebDataSource lifetime problem -- may be cause of the leaks seen on the buildbot
* WebView/WebDataSource.mm:
(-[WebDataSourcePrivate dealloc]): Added a call to the new detachDataSource function.
(-[WebDataSourcePrivate finalize]): Ditto.
* WebView/WebDocumentLoaderMac.h: Added detachDataSource function to be used when the
WebDataSource is deallocated. Added retain/releaseDataSource helper functions to be
used to retain and release the data source object. Replaced the m_hasEverBeenDetached
boolean with a more primitive and hence easier to understand m_isDataSourceRetained boolean.
* WebView/WebDocumentLoaderMac.mm:
(WebDocumentLoaderMac::WebDocumentLoaderMac): Initialize m_isDataSourceRetained to false.
(WebDocumentLoaderMac::setDataSource): Call retainDataSource instead of calling HardRetain
on the dataSource parameter. Also updated a comment.
(WebDocumentLoaderMac::attachToFrame): Call retainDataSource unconditionally rather than
trying to use m_hasEverBeenDetached to decide if a retain is needed. Also got rid of an
assertion that m_loadingResources is empty -- not important any more.
(WebDocumentLoaderMac::detachFromFrame): Call releaseDataSource instead of using
HardRelease, but only if m_loadingResources is empty. If it's non-empty, then we'll
do the releaseDataSource later in decreaseLoadCount.
(WebDocumentLoaderMac::increaseLoadCount): Call retainDataSource unconditionally
rather than calling HardRetain only if the old set of resources was empty.
(WebDocumentLoaderMac::decreaseLoadCount): Call releaseDataSource if m_loadingResources
is empty and we're not attached to a frame. If we are attached to a frame, then
we'll do the releaseDataSource later in detachFromFrame.
(WebDocumentLoaderMac::retainDataSource): Added. Calls CFRetain, but only if the data
source is not already retained (according to the boolean).
(WebDocumentLoaderMac::releaseDataSource): Added. Calls CFRelease, but only if the data
source is currently retained (according to the boolean).
(WebDocumentLoaderMac::detachDataSource): Added. Sets m_dataSource to nil. Since this
is only called from WebDataSource's dealloc and finalize methods, it won't ever be called
when the m_isDataSourceRetained boolean is true.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 3 Jul 2007 22:01:29 +0000 (22:01 +0000)]
Reviewed by Adam.
<rdar://problem/
5093862>
Nothing shown in plugin area when trying to play content using the DivX plugin
Defer calling SetWindow for the DivX plugin, just like we do with the WMP plugin.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::determineQuirks):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 3 Jul 2007 21:35:25 +0000 (21:35 +0000)]
Reviewed by Brady Eidson.
Tenth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
- Add explicit casts.
* kjs/dtoa.cpp:
(Bigint::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 3 Jul 2007 21:21:56 +0000 (21:21 +0000)]
- forgot to check in one file in the fix for <rdar://problem/
5307880>
some classes need finalize methods because of non-trivial work done in dealloc methods
* WebView/WebView.mm: (-[WebViewPrivate finalize]): Delete identifierMap so it doesn't leak.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 3 Jul 2007 21:17:44 +0000 (21:17 +0000)]
Reviewed by Brady Eidson.
Ninth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
- Fix function signature to use unsigned long instead of unsigned long long.
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::completeProgress):
* loader/ProgressTracker.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 3 Jul 2007 20:46:44 +0000 (20:46 +0000)]
Reviewed by Oliver.
Eighth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
- Convert SVG implementation files to use floats instead of doubles
to match the spec/IDLs.
* bindings/scripts/CodeGeneratorJS.pm:
* ksvg2/svg/SVGAngle.cpp:
* ksvg2/svg/SVGAnimatedTemplate.h:
* ksvg2/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::getEndTime):
(WebCore::SVGAnimationElement::getStartTime):
(WebCore::SVGAnimationElement::getCurrentTime):
(WebCore::SVGAnimationElement::getSimpleDuration):
* ksvg2/svg/SVGAnimationElement.h:
* ksvg2/svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseViewBox):
* ksvg2/svg/SVGLength.cpp:
(WebCore::SVGLength::setValueAsString):
* ksvg2/svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::buildGradient):
* ksvg2/svg/SVGMatrix.idl:
* ksvg2/svg/SVGNumber.idl:
* ksvg2/svg/SVGParserUtilities.cpp:
(WebCore::SVGPathParser::parseSVG):
(WebCore::SVGPathParser::calculateArc):
(WebCore::SVGPathParser::svgLineToHorizontal):
(WebCore::SVGPathParser::svgLineToVertical):
(WebCore::SVGPathParser::svgCurveToCubicSmooth):
(WebCore::SVGPathParser::svgCurveToQuadratic):
(WebCore::SVGPathParser::svgCurveToQuadraticSmooth):
(WebCore::SVGPathParser::svgArcTo):
* ksvg2/svg/SVGParserUtilities.h:
* ksvg2/svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::getTotalLength):
(WebCore::SVGPathElement::getPointAtLength):
(WebCore::SVGPathElement::getPathSegAtLength):
(WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
(WebCore::SVGPathElement::createSVGPathSegMovetoRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
(WebCore::SVGPathElement::createSVGPathSegArcAbs):
(WebCore::SVGPathElement::createSVGPathSegArcRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
(WebCore::SVGPathElement::svgMoveTo):
(WebCore::SVGPathElement::svgLineTo):
(WebCore::SVGPathElement::svgLineToHorizontal):
(WebCore::SVGPathElement::svgLineToVertical):
(WebCore::SVGPathElement::svgCurveToCubic):
(WebCore::SVGPathElement::svgCurveToCubicSmooth):
(WebCore::SVGPathElement::svgCurveToQuadratic):
(WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
(WebCore::SVGPathElement::svgArcTo):
(WebCore::SVGPathElement::parseMappedAttribute):
* ksvg2/svg/SVGPathElement.h:
* ksvg2/svg/SVGPathSegArc.cpp:
(WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
(WebCore::SVGPathSegArcAbs::setX):
(WebCore::SVGPathSegArcAbs::x):
(WebCore::SVGPathSegArcAbs::setY):
(WebCore::SVGPathSegArcAbs::y):
(WebCore::SVGPathSegArcAbs::setR1):
(WebCore::SVGPathSegArcAbs::r1):
(WebCore::SVGPathSegArcAbs::setR2):
(WebCore::SVGPathSegArcAbs::r2):
(WebCore::SVGPathSegArcAbs::setAngle):
(WebCore::SVGPathSegArcAbs::angle):
(WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
(WebCore::SVGPathSegArcRel::setX):
(WebCore::SVGPathSegArcRel::x):
(WebCore::SVGPathSegArcRel::setY):
(WebCore::SVGPathSegArcRel::y):
(WebCore::SVGPathSegArcRel::setR1):
(WebCore::SVGPathSegArcRel::r1):
(WebCore::SVGPathSegArcRel::setR2):
(WebCore::SVGPathSegArcRel::r2):
(WebCore::SVGPathSegArcRel::setAngle):
(WebCore::SVGPathSegArcRel::angle):
* ksvg2/svg/SVGPathSegArc.h:
* ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
(WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
(WebCore::SVGPathSegCurvetoCubicAbs::setX):
(WebCore::SVGPathSegCurvetoCubicAbs::x):
(WebCore::SVGPathSegCurvetoCubicAbs::setY):
(WebCore::SVGPathSegCurvetoCubicAbs::y):
(WebCore::SVGPathSegCurvetoCubicAbs::setX1):
(WebCore::SVGPathSegCurvetoCubicAbs::x1):
(WebCore::SVGPathSegCurvetoCubicAbs::setY1):
(WebCore::SVGPathSegCurvetoCubicAbs::y1):
(WebCore::SVGPathSegCurvetoCubicAbs::setX2):
(WebCore::SVGPathSegCurvetoCubicAbs::x2):
(WebCore::SVGPathSegCurvetoCubicAbs::setY2):
(WebCore::SVGPathSegCurvetoCubicAbs::y2):
(WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
(WebCore::SVGPathSegCurvetoCubicRel::setX):
(WebCore::SVGPathSegCurvetoCubicRel::x):
(WebCore::SVGPathSegCurvetoCubicRel::setY):
(WebCore::SVGPathSegCurvetoCubicRel::y):
(WebCore::SVGPathSegCurvetoCubicRel::setX1):
(WebCore::SVGPathSegCurvetoCubicRel::x1):
(WebCore::SVGPathSegCurvetoCubicRel::setY1):
(WebCore::SVGPathSegCurvetoCubicRel::y1):
(WebCore::SVGPathSegCurvetoCubicRel::setX2):
(WebCore::SVGPathSegCurvetoCubicRel::x2):
(WebCore::SVGPathSegCurvetoCubicRel::setY2):
(WebCore::SVGPathSegCurvetoCubicRel::y2):
* ksvg2/svg/SVGPathSegCurvetoCubic.h:
* ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::x):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::y):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX2):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::x2):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY2):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::y2):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::setX):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::x):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::setY):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::y):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::setX2):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::x2):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::setY2):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::y2):
* ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
* ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
(WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
(WebCore::SVGPathSegCurvetoQuadraticAbs::setX):
(WebCore::SVGPathSegCurvetoQuadraticAbs::x):
(WebCore::SVGPathSegCurvetoQuadraticAbs::setY):
(WebCore::SVGPathSegCurvetoQuadraticAbs::y):
(WebCore::SVGPathSegCurvetoQuadraticAbs::setX1):
(WebCore::SVGPathSegCurvetoQuadraticAbs::x1):
(WebCore::SVGPathSegCurvetoQuadraticAbs::setY1):
(WebCore::SVGPathSegCurvetoQuadraticAbs::y1):
(WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
(WebCore::SVGPathSegCurvetoQuadraticRel::setX):
(WebCore::SVGPathSegCurvetoQuadraticRel::x):
(WebCore::SVGPathSegCurvetoQuadraticRel::setY):
(WebCore::SVGPathSegCurvetoQuadraticRel::y):
(WebCore::SVGPathSegCurvetoQuadraticRel::setX1):
(WebCore::SVGPathSegCurvetoQuadraticRel::x1):
(WebCore::SVGPathSegCurvetoQuadraticRel::setY1):
(WebCore::SVGPathSegCurvetoQuadraticRel::y1):
* ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
(WebCore::SVGPathSegCurvetoQuadraticRel::toString):
* ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setX):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::x):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setY):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::y):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setX):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::x):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setY):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::y):
* ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
* ksvg2/svg/SVGPathSegLineto.cpp:
(WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
(WebCore::SVGPathSegLinetoAbs::setX):
(WebCore::SVGPathSegLinetoAbs::x):
(WebCore::SVGPathSegLinetoAbs::setY):
(WebCore::SVGPathSegLinetoAbs::y):
(WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
(WebCore::SVGPathSegLinetoRel::setX):
(WebCore::SVGPathSegLinetoRel::x):
(WebCore::SVGPathSegLinetoRel::setY):
(WebCore::SVGPathSegLinetoRel::y):
* ksvg2/svg/SVGPathSegLineto.h:
* ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
(WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
(WebCore::SVGPathSegLinetoHorizontalAbs::setX):
(WebCore::SVGPathSegLinetoHorizontalAbs::x):
(WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
(WebCore::SVGPathSegLinetoHorizontalRel::setX):
(WebCore::SVGPathSegLinetoHorizontalRel::x):
* ksvg2/svg/SVGPathSegLinetoHorizontal.h:
* ksvg2/svg/SVGPathSegLinetoVertical.cpp:
(WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
(WebCore::SVGPathSegLinetoVerticalAbs::setY):
(WebCore::SVGPathSegLinetoVerticalAbs::y):
(WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
(WebCore::SVGPathSegLinetoVerticalRel::setY):
(WebCore::SVGPathSegLinetoVerticalRel::y):
* ksvg2/svg/SVGPathSegLinetoVertical.h:
* ksvg2/svg/SVGPathSegList.cpp:
(WebCore::SVGPathSegList::getPathSegAtLength):
* ksvg2/svg/SVGPathSegList.h:
* ksvg2/svg/SVGPathSegMoveto.cpp:
(WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
(WebCore::SVGPathSegMovetoAbs::setX):
(WebCore::SVGPathSegMovetoAbs::x):
(WebCore::SVGPathSegMovetoAbs::setY):
(WebCore::SVGPathSegMovetoAbs::y):
(WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
(WebCore::SVGPathSegMovetoRel::setX):
(WebCore::SVGPathSegMovetoRel::x):
(WebCore::SVGPathSegMovetoRel::setY):
(WebCore::SVGPathSegMovetoRel::y):
* ksvg2/svg/SVGPathSegMoveto.h:
* ksvg2/svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::svgPolyTo):
* ksvg2/svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::buildGradient):
* ksvg2/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::viewport):
(WebCore::SVGSVGElement::getCurrentTime):
* ksvg2/svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::SVGStopElement):
(WebCore::SVGStopElement::parseMappedAttribute):
* ksvg2/svg/SVGStopElement.h:
* ksvg2/svg/SVGTransform.cpp:
(SVGTransform::translate):
(SVGTransform::scale):
* ksvg2/svg/SVGTransformDistance.cpp:
(WebCore::SVGTransformDistance::addToSVGTransform):
(WebCore::SVGTransformDistance::distance):
* ksvg2/svg/SVGTransformable.cpp:
(WebCore::SVGTransformable::parseTransformAttribute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 3 Jul 2007 20:15:44 +0000 (20:15 +0000)]
LayoutTests:
Reviewed by Darin.
<rdar://problem/
5289718>
http://bugs.webkit.org/show_bug.cgi?id=14437
CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)
Add test from Alexey Proskuryakov.
* plugins/plugin-remove-subframe-expected.txt: Added.
* plugins/plugin-remove-subframe.html: Added.
WebCore:
Reviewed by Darin.
<rdar://problem/
5289718>
http://bugs.webkit.org/show_bug.cgi?id=14437
CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)
Based on a patch from Maxime Britto.
* page/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
If the script caused the frame to go away, return nil. This can only happen if a plugin in a subframe destroys
its frame.
(-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
ASSERT that this is only called on the main frame.
WebKit:
Reviewed by Darin.
* WebView/WebView.mm:
(-[WebView stringByEvaluatingJavaScriptFromString:]):
ASSERT that the value returned isn't nil. It can't be nil when invoked on the main frame.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 3 Jul 2007 19:22:28 +0000 (19:22 +0000)]
Written by Darin, reviewed by me
- fixed <rdar://problem/
5249730> REGRESSION (Leopard, around 9A464): Safari opens the same local
documents more than once due to canonicalization change
* loader/mac/LoaderNSURLExtras.m:
(canonicalURL):
pass URL through KURL so we get KURL's version of canonicalization as well as
NSURLProtocol's version of canonicalization
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 3 Jul 2007 19:14:44 +0000 (19:14 +0000)]
LayoutTests:
Reviewed by Darin.
Seventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
- Change from double -> float caused some slight changes.
* svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
* svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
* svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
* svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
* svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
* svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
* svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
* svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
* svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
* svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
* svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
WebCore:
Reviewed by Darin.
Seventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
- Adds more narrowPrecision functions to FloatPoint, FloatSize and FloatRect.
- Changes over more implicit conversions to use new functions.
* bindings/js/kjs_window.cpp:
(KJS::WindowFunc::callAsFunction):
* platform/graphics/FloatPoint.cpp:
(WebCore::FloatPoint::matrixTransform):
(WebCore::FloatPoint::narrowPrecision):
* platform/graphics/FloatPoint.h:
* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::narrowPrecision):
* platform/graphics/FloatRect.h:
* platform/graphics/FloatSize.cpp:
(WebCore::FloatSize::narrowPrecision):
* platform/graphics/FloatSize.h:
* platform/graphics/Path.cpp:
(WebCore::Path::createRoundedRectangle):
(WebCore::Path::createRectangle):
(WebCore::Path::createEllipse):
* platform/graphics/mac/ColorMac.mm:
(WebCore::nsColor):
* platform/graphics/mac/IconMac.mm:
(WebCore::Icon::paint):
* platform/graphics/svg/cg/CgSupport.cpp:
(WebCore::applyStrokeStyleToContext):
* platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
(WebCore::CGShadingRefForRadialGradient):
(WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
(WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
* platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
(WebCore::applyLuminanceToAlphaFilter):
(WebCore::applyExpandAlphatoGrayscaleFilter):
(WebCore::transformImageIntoGrayscaleMask):
* platform/mac/WebCoreTextRenderer.mm:
(WebCoreDrawTextAtPoint):
* rendering/RenderPath.cpp:
(WebCore::RenderPath::mapAbsolutePointToLocal):
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::calcViewport):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::nodeAtPoint):
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::relativeBBox):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 3 Jul 2007 17:55:59 +0000 (17:55 +0000)]
Reviewed by Adam.
<rdar://problem/
5261523>
Crash playing MP11 on cnbc.com
The WMP Netscape plugin still creates a window even when windowless mode is turned on. Work around this by
always removing the "windowlessvideo" parameter before passing it to the plugin.
According to http://msdn2.microsoft.com/en-us/library/
bb249373.aspx, "The windowlessVideo property is not
supported for Netscape Navigator. Setting a value for this property in Navigator may yield unexpected results."
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWndProc):
(WebCore::PluginViewWin::paint):
(WebCore::PluginViewWin::invalidateRect):
(WebCore::PluginViewWin::determineQuirks):
(WebCore::PluginViewWin::setParameters):
(WebCore::PluginViewWin::PluginViewWin):
(WebCore::PluginViewWin::init):
* plugins/win/PluginViewWin.h:
(WebCore::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 3 Jul 2007 16:21:01 +0000 (16:21 +0000)]
2007-07-04 Mark Rowe <mrowe@apple.com>
Unreviewed 64-bit build fixes.
* WebCoreSupport/WebInspectorClient.mm: Let the compiler know that WebFrameView is a subclass of NSView.
* WebView/WebDocumentInternal.h: Remove our preprocessor macro once we're done with it.
* WebView/WebHTMLView.mm:
(-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Fix argument types.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Tue, 3 Jul 2007 15:29:34 +0000 (15:29 +0000)]
Patch from Qing Zhao to fix sunken state improperly set.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Tue, 3 Jul 2007 13:42:11 +0000 (13:42 +0000)]
LayoutTests:
Reviewed by Maciej.
Test for REGRESSION: misplaced selection ring remains after link is no longer focused.
<rdar://problem/
5205580>
* fast/repaint/focus-layers-expected.checksum: Added.
* fast/repaint/focus-layers-expected.png: Added.
* fast/repaint/focus-layers-expected.txt: Added.
* fast/repaint/focus-layers.html: Added.
WebCore:
Reviewed by Maciej.
REGRESSION: misplaced selection ring remains after link is no longer focused.
<rdar://problem/
5205580>
Fix placement of selection ring when part of the ring is in a different layer.
* rendering/RenderFlow.cpp:
(WebCore::RenderFlow::addFocusRingRects): Get coordinates right when moving to a different layer.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
Don't reset state variables when not necessary. When repaint() was called at the end of setSyle() it would
get repaint rects wrong in some cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Tue, 3 Jul 2007 13:31:11 +0000 (13:31 +0000)]
Reviewed by Maciej.
Blind fix for CrashTracer: [USER] 25 crashes in Safari at com.apple.WebCore: WebCore::Frame::document const + 6
<rdar://problem/
5263939>
No one has managed to reproduce this but it looks like null check is needed here. There are plausible ways
m_frame could be null for a live FrameView object.
* page/FrameView.cpp:
(WebCore::FrameView::needsLayout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 3 Jul 2007 05:52:48 +0000 (05:52 +0000)]
Update the Windows Skipped list.
* win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 3 Jul 2007 01:36:43 +0000 (01:36 +0000)]
Update results after r23938.
* fast/inline-block/14498-positionForCoordinates-expected.txt:
* fast/table/click-near-anonymous-table-expected.txt:
* svg/custom/pointer-events-image-expected.txt:
* svg/custom/pointer-events-path-expected.txt:
* svg/custom/text-hit-test-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Tue, 3 Jul 2007 00:53:48 +0000 (00:53 +0000)]
Reviewed by Darin.
Fix for <rdar://problem/
5098378> single-pixel image optimization needs to be rewritten to not depend on floating point bitmap
Tested by fast/replaced/image-solid-color-with-alpha.html
Switch from float to byte based bitmap when pulling the color from 1x1 pixel images so
that we can use the single pixel image optimisation in WebKit/win.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::checkForSolidColor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 2 Jul 2007 23:54:22 +0000 (23:54 +0000)]
Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
WebCore:
Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
http://bugs.webkit.org/show_bug.cgi?id=14498
There were two bugs:
1) xPos/yPos were flipped
2) + binds tighter than ?:, so the order of operations was incorrect
Reviewed by Darin.
Test: fast/inline-block/14498-positionForCoordinates.html
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::positionForCoordinates):
LayoutTests:
Test for Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
http://bugs.webkit.org/show_bug.cgi?id=14498
Reviewed by Darin.
* fast/inline-block/14498-positionForCoordinates-expected.txt: Added.
* fast/inline-block/14498-positionForCoordinates.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 2 Jul 2007 23:30:13 +0000 (23:30 +0000)]
Reviewed by Kevin Decker and Tim Hatcher.
- fix <rdar://problem/
5307880> some classes need finalize methods
because of non-trivial work done in dealloc methods
* DefaultDelegates/WebScriptDebugServer.m:
(-[WebScriptDebugServer dealloc]): Added a comment about how this probably won't
work under GC.
* WebInspector/WebNodeHighlight.m:
(-[WebNodeHighlight dealloc]): Ditto.
* WebView/WebDataSource.mm:
(+[WebDataSourcePrivate initialize]): Added. Makes finalize run on main thread.
(-[WebDataSourcePrivate finalize]): Added. Calls deref on the document loader.
* WebView/WebHTMLView.mm:
(+[WebHTMLViewPrivate initialize]): Added. Makes finalize run on main thread.
(-[WebHTMLViewPrivate finalize]): Added. Calls deref on promisedDragTIFFDataSource.
* WebKit.xcodeproj/project.pbxproj: Let Xcode be Xcode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 2 Jul 2007 23:29:41 +0000 (23:29 +0000)]
Reviewed by Kevin Decker and Tim Hatcher.
- fix <rdar://problem/
5307906> some classes need finalize methods because
of non-trivial work done in dealloc methods
* bindings/objc/DOMRGBColor.mm:
(+[DOMRGBColor initialize]): Added. Tells finalizer to run on main thread,
which is needed because we are sharing a CFDictionary here with no locking.
* bridge/mac/WebCoreAXObject.mm:
(+[WebCoreAXObject initialize]): Added. Tells finalizer to run on main thread.
(-[WebCoreAXObject finalize]): Added. Calls detach.
* WebCore.xcodeproj/project.pbxproj: Let Xcode do what it wants to do.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 2 Jul 2007 23:20:41 +0000 (23:20 +0000)]
Reviewed by Darin.
Sixth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
Use new narrowPrecisionToFloat() and narrowPrecisionToCGFloat() where
appropriate.
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::applyShadow):
* html/CanvasStyle.cpp:
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
* ksvg2/svg/SVGAngle.cpp:
* ksvg2/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::parseKeyNumbers):
(WebCore::parseKeySplines):
(WebCore::SVGAnimationElement::handleTimerEvent):
(WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
* ksvg2/svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::buildPattern):
* ksvg2/svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::buildGradient):
* platform/graphics/cg/AffineTransformCG.cpp:
(WebCore::AffineTransform::AffineTransform):
(WebCore::AffineTransform::setMatrix):
(WebCore::AffineTransform::map):
(WebCore::AffineTransform::setA):
(WebCore::AffineTransform::setB):
(WebCore::AffineTransform::setC):
(WebCore::AffineTransform::setD):
(WebCore::AffineTransform::setE):
(WebCore::AffineTransform::setF):
(WebCore::AffineTransform::scale):
(WebCore::AffineTransform::rotate):
(WebCore::AffineTransform::translate):
(WebCore::AffineTransform::shear):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Mon, 2 Jul 2007 22:14:35 +0000 (22:14 +0000)]
* page/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
added a comment
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 2 Jul 2007 20:47:40 +0000 (20:47 +0000)]
Rubberstamped by Darin.
Rename FloatConversionUtilities.h to FloatConversion.h.
Fix Win32 build.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/DeprecatedString.cpp:
* platform/FloatConversion.h: Copied from platform/FloatConversionUtilities.h.
* platform/FloatConversionUtilities.h: Removed.
* platform/StringImpl.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 2 Jul 2007 20:41:11 +0000 (20:41 +0000)]
JavaScriptCore:
Reviewed by Kevin McCullough.
Fourth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
Add custom piDouble and piFloat constants to use instead of M_PI.
* kjs/math_object.cpp:
(MathObjectImp::getValueProperty):
* wtf/MathExtras.h:
(wtf_atan2):
WebCore:
Reviewed by Darin.
Fifth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
Add toFloat() method to string classes and use it where appropriate.
* WebCore.xcodeproj/project.pbxproj:
* css/cssparser.cpp:
(WebCore::CSSParser::lex):
* ksvg2/svg/SVGAngle.cpp:
(WebCore::SVGAngle::setValueAsString):
* platform/AtomicString.h:
(WebCore::AtomicString::toFloat):
* platform/DeprecatedString.cpp:
(WebCore::DeprecatedString::toFloat):
* platform/DeprecatedString.h:
* platform/FloatConversionUtilities.h: Added.
(WebCore::narrowPrecisionToFloat):
(WebCore::narrowPrecisionToCGFloat):
* platform/PlatformString.h:
* platform/String.cpp:
(WebCore::String::toFloat):
* platform/StringImpl.cpp:
(WebCore::StringImpl::toFloat):
* platform/StringImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 2 Jul 2007 18:44:00 +0000 (18:44 +0000)]
JavaScriptCore:
Reviewed by Kevin McCullough.
Third round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
Add custom piDouble and piFloat constants to use instead of M_PI.
* kjs/math_object.cpp:
(MathObjectImp::getValueProperty):
* wtf/MathExtras.h:
(wtf_atan2):
WebCore:
Reviewed by Kevin McCullough.
Third round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
Use new piDouble and piFloat constants instead of M_PI.
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::rotate):
* ksvg2/svg/SVGParserUtilities.cpp:
(WebCore::SVGPathParser::calculateArc):
* platform/graphics/Path.cpp:
(WebCore::pathLengthApplierFunction):
(WebCore::Path::createEllipse):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::setCurrentPage):
* platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
* rendering/RenderPath.cpp:
(WebCore::drawMarkerWithData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 2 Jul 2007 14:08:31 +0000 (14:08 +0000)]
2007-07-02 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=14482
Add information about the NeedsReduction and HasReduction keywords to quality/reduction.html
* quality/reduction.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc