WebKit-https.git
8 years agoAccount for device scale factor when creating image for dragging.
commit-queue@webkit.org [Wed, 20 Jun 2012 22:49:13 +0000 (22:49 +0000)]
Account for device scale factor when creating image for dragging.
https://bugs.webkit.org/show_bug.cgi?id=89489

Patch by Varun Jain <varunjain@chromium.org> on 2012-06-20
Reviewed by Adam Barth.

.:

* ManualTests/chromium/drag-image-accounts-for-device-scale.html: Added.

Source/WebCore:

Manual Test: ManualTests/chromium/drag-image-accounts-for-device-scale.html

* page/Frame.cpp:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed typos in the change log.
mitz@apple.com [Wed, 20 Jun 2012 22:36:50 +0000 (22:36 +0000)]
Fixed typos in the change log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a != operator to ViewportArguments
zhajiang@rim.com [Wed, 20 Jun 2012 22:35:33 +0000 (22:35 +0000)]
Add a != operator to ViewportArguments
https://bugs.webkit.org/show_bug.cgi?id=87505

Reviewed by Antonio Gomes.
Patch by Jacky Jiang  <zhajiang@rim.com>

Source/WebCore:

Add a != operator to ViewportArguments for convenience.

* dom/ViewportArguments.h:
(ViewportArguments):
(WebCore::ViewportArguments::operator!=):

Source/WebKit/blackberry:

Use != operator of ViewportArguments.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
* Api/WebViewportArguments.cpp:
(BlackBerry::WebKit::WebViewportArguments::operator!=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip new failing tests.
ossy@webkit.org [Wed, 20 Jun 2012 22:25:12 +0000 (22:25 +0000)]
[Qt] Unreviewed gardening, skip new failing tests.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoComputed style tests are a maintenance burden on the project
tony@chromium.org [Wed, 20 Jun 2012 22:15:10 +0000 (22:15 +0000)]
Computed style tests are a maintenance burden on the project
https://bugs.webkit.org/show_bug.cgi?id=87991

Reviewed by Eric Seidel.

Convert computed-style.html, computed-style-without-renderer.html and getComputedStyle-basic.xhtml
to use a whitelist of properties rather than a blacklist. The whitelist includes all properties
that are supported based on the checked in results so all ports can share the same values. Adding
new properties won't cause these tests to be rebaselined.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer.html: Remove indenting and use a fixed
width for the middle div so we don't get fractional pixel values for ports with fractional pixel
values enabled.
* fast/css/getComputedStyle/computed-style.html:
* fast/css/getComputedStyle/resources/property-names.js: Whitelist of common CSS properties.
* platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/gtk/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* platform/mac/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* platform/qt/svg/css/getComputedStyle-basic-expected.png: Removed.
* platform/qt/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* svg/css/getComputedStyle-basic-expected.txt:
* svg/css/getComputedStyle-basic.xhtml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLet XCode have its own way.
rniwa@webkit.org [Wed, 20 Jun 2012 22:08:15 +0000 (22:08 +0000)]
Let XCode have its own way.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove m_listsInvalidatedAtDocument from NodeListsNodeData to Document
rniwa@webkit.org [Wed, 20 Jun 2012 22:05:12 +0000 (22:05 +0000)]
Move m_listsInvalidatedAtDocument from NodeListsNodeData to Document
https://bugs.webkit.org/show_bug.cgi?id=89603

Reviewed by Andreas Kling.

Moved the variable. m_listsInvalidatedAtDocument is never used in non-Document nodes
so it was just wasting memory space.

* dom/Document.cpp:
(WebCore::Document::registerDynamicSubtreeNodeList):
(WebCore::Document::unregisterDynamicSubtreeNodeList):
(WebCore):
(WebCore::Document::clearNodeListCaches):
* dom/Document.h:
(Document):
* dom/DynamicNodeList.h:
(DynamicSubtreeNodeList):
* dom/Node.cpp:
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged):
(WebCore):
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes): RadioNodeList
is invalidated at document level. No need to invalidate it again here.
(WebCore::NodeListsNodeData::isEmpty):
* dom/NodeRareData.h:
(NodeListsNodeData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r120821.
commit-queue@webkit.org [Wed, 20 Jun 2012 22:02:41 +0000 (22:02 +0000)]
Unreviewed, rolling out r120821.
http://trac.webkit.org/changeset/120821
https://bugs.webkit.org/show_bug.cgi?id=89605

It made duplicated reviewer entries (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-20

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.set_reviewer):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_set_reviewer):
(test_set_short_description_and_bug_url):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r120854.
commit-queue@webkit.org [Wed, 20 Jun 2012 21:58:18 +0000 (21:58 +0000)]
Unreviewed, rolling out r120854.
http://trac.webkit.org/changeset/120854
https://bugs.webkit.org/show_bug.cgi?id=89604

Broke Chromium WebKit Linux (dbg) (Requested by arv on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-20

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
* bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
(WebCore):
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
(WebCore):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8TextTrackListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
* css/CSSStyleSheet.idl:
* css/StyleSheet.idl:
* dom/DOMStringMap.idl:
* dom/NamedNodeMap.idl:
* html/DOMTokenList.idl:
* html/track/TextTrackList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt outputs empty files for wdiff output if wdiff is not installed
dpranke@chromium.org [Wed, 20 Jun 2012 21:30:13 +0000 (21:30 +0000)]
nrwt outputs empty files for wdiff output if wdiff is not installed
https://bugs.webkit.org/show_bug.cgi?id=88709

Reviewed by Tony Chang.

Reviewed by Tony Chang.

Don't write -wdiff or -pretty.html files if wdiff or prettypatch
aren't available, and clean up the handling for them in the port
code.

* Scripts/webkitpy/run_webkit_tests_integrationtest.py:
(MainTest.test_output_diffs):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.create_text_diff_and_write_result):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.check_pretty_patch):
(Port.check_wdiff):
(Port._wdiff_missing_message):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort.check_build):
(ChromiumLinuxPort._wdiff_missing_message):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.check_build):
(ChromiumMacPort):
(ChromiumMacPort._wdiff_missing_message):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: fix unit tests for ensuring svn revision is correct
dpranke@chromium.org [Wed, 20 Jun 2012 21:25:08 +0000 (21:25 +0000)]
nrwt: fix unit tests for ensuring svn revision is correct
https://bugs.webkit.org/show_bug.cgi?id=89498

Reviewed by Eric Seidel.

Reviewed by Eric Seidel.

Fix the unit tests for testing that we are embedding the SVN
revision in the results json for NRWT properly; this was broken
in r120646 but because the MockHost worked differently than the
real one (by always initializing the MockSCM object) we didn't
notice. Unfortunately, just changing the default breaks all
sorts of unit tests ...

* Scripts/webkitpy/common/host_mock.py:
(MockHost.__init__):
(MockHost._initialize_scm):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_no_svn_revision):
(ResultSummaryTest.test_svn_revision):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonew-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
dpranke@chromium.org [Wed, 20 Jun 2012 21:22:35 +0000 (21:22 +0000)]
new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
https://bugs.webkit.org/show_bug.cgi?id=69360

Reviewed by Eric Seidel.

Reviewed by Eric Seidel.

Propagate the 'port_implementation' part of the platform (i.e.,
gtk,qt,chromium) to webkit-build-directory so that we can pick
up the gtk-specific handling of WEBKITOUTPUTDIR ...

I didn't write any additional tests for this; testing it
properly is an integration test between the python code and the
perl code, which I verified by hand.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.__init__):
* Scripts/webkitpy/layout_tests/port/config.py:
(Config.__init__):
(Config.build_directory):
* Scripts/webkitpy/layout_tests/port/config_mock.py:
(MockConfig.__init__):
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.test_build_directory_passes_port_implementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash on accessing a removed renderer from percent height descendant map.
inferno@chromium.org [Wed, 20 Jun 2012 21:20:29 +0000 (21:20 +0000)]
Crash on accessing a removed renderer from percent height descendant map.
https://bugs.webkit.org/show_bug.cgi?id=88017

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/block/percent-height-descendant-not-removed-crash2.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hasPercentHeightContainerMap): helper to tell
if we have a height container map.
(WebCore):
(WebCore::RenderBlock::hasPercentHeightDescendant): change from a debug
only function to a regular function for use. no need to null check
for a percent height container map in this function.
(WebCore::RenderBlock::clearPercentHeightDescendantsFrom): helper to
clear all percent height descendants under us.
(WebCore::RenderBlock::removePercentHeightDescendantIfNeeded): helper to
clear the box if it exists in the percent height descendant map.
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed): remove the assert and change the
percent height detection check to use removePercentHeightDescendantIfNeeded.
We shouldn't rely on logicalHeight().isPercent() as it can change when our
writing mode changes. Instead, just query the map directly to see if we exist.
(WebCore::RenderBox::styleDidChange): when our writing mode changes from
horizontal to vertical or vice versa, we clear all our descendants from
the percent height descendant map. Cache the value of isHorizontalWritingMode()
before it changes in styleDidChange and compare it with the new value
(can't use oldStyle->isHorizontalWritingMode() since it can be inherited
and already updated).

LayoutTests:

* fast/block/percent-height-descendant-not-removed-crash2-expected.txt: Added.
* fast/block/percent-height-descendant-not-removed-crash2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Add an API to immediately enable cross-site XHR
commit-queue@webkit.org [Wed, 20 Jun 2012 21:15:18 +0000 (21:15 +0000)]
[BlackBerry] Add an API to immediately enable cross-site XHR
https://bugs.webkit.org/show_bug.cgi?id=89594

Internally Reviewed by Yong Li.
Patch by Christopher Hutten-Czapski <chutten@rim.com> on 2012-06-20
Reviewed by Rob Buis.

There is no API to disable it as clients may rely on legacy behaviour
of not disabling until the next frame load.

* Api/WebPage.cpp:
(BlackBerry::WebKit::enableCrossSiteXHRRecursively):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::enableCrossSiteXHR):
(BlackBerry::WebKit::WebPage::enableCrossSiteXHR):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agobuild-webkit failure due to illegal 32-bit integer constants in code
fpizlo@apple.com [Wed, 20 Jun 2012 21:07:33 +0000 (21:07 +0000)]
build-webkit failure due to illegal 32-bit integer constants in code
generated by offlineasm
https://bugs.webkit.org/show_bug.cgi?id=89347

Reviewed by Geoffrey Garen.

The offending constants are the magic numbers used by offlineasm to find
offsets in the generated machine code. Added code to turn them into what
the C++ compiler will believe to be valid 32-bit values.

* offlineasm/offsets.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r113885): Margin not properly applied to elements with align=center
jchaffraix@webkit.org [Wed, 20 Jun 2012 21:04:16 +0000 (21:04 +0000)]
REGRESSION(r113885): Margin not properly applied to elements with align=center
https://bugs.webkit.org/show_bug.cgi?id=89515

Reviewed by Levi Weintraub.

Reviewed by Levi Weintraub.

Source/WebCore:

Tests: fast/block/negative-margin-start-positive-margin-end.html
       fast/block/negative-start-margin-align-center.html
       fast/block/positive-margin-block-child-align-center-rtl.html
       fast/block/positive-margin-block-child-align-center.html
       fast/block/positive-margin-start-align-center.html
       fast/block/positive-margin-start-negative-margin-end-align-center.html
       fast/table/table-cell-negative-start-margin-align-center.html

r113885 changed the code-path for elements with auto width to call computeInlineDirectionMargins.
However this uncovered an existing bug in the function when dealing with align="center" (text-align: -webkit-center)
where we would ignore the margin. This goes against what other browsers are doing and our previous behavior.

Note that align="left" and "right" are likely impacted too and will be investigated / fixed in follow-up changes.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeInlineDirectionMargins):
To match other browsers' behavior, changed the function to include margin in our computations.

LayoutTests:

* fast/block/negative-margin-start-positive-margin-end-expected.html: Added.
* fast/block/negative-margin-start-positive-margin-end.html: Added.
* fast/block/negative-start-margin-align-center-expected.html: Added.
* fast/block/negative-start-margin-align-center.html: Added.
* fast/block/positive-margin-block-child-align-center-expected.html: Added.
* fast/block/positive-margin-block-child-align-center.html: Added.
* fast/block/positive-margin-start-align-center-expected.html: Added.
* fast/block/positive-margin-start-align-center.html: Added.
* fast/block/positive-margin-start-negative-margin-end-align-center-expected.html: Added.
* fast/block/positive-margin-start-negative-margin-end-align-center.html: Added.
Those checks the combination of margin start / end both positive and negative.

* fast/block/positive-margin-block-child-align-center-rtl-expected.html: Added.
* fast/block/positive-margin-block-child-align-center-rtl.html: Added.
One ltr test as I didn't find any.

* fast/table/table-cell-negative-start-margin-align-center-expected.html: Added.
* fast/table/table-cell-negative-start-margin-align-center.html: Added.
This test is very similar to the one above but involves a table.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Separate LayerRenderer initialization from updateLayers
jamesr@google.com [Wed, 20 Jun 2012 20:48:07 +0000 (20:48 +0000)]
[chromium] Separate LayerRenderer initialization from updateLayers
https://bugs.webkit.org/show_bug.cgi?id=89525

Reviewed by Adrienne Walker.

Source/WebCore:

This adds an explicit call to initialize the layer renderer of a given CCLayerTreeHost instead of having it be
implicit in updateLayers(). This way the proxies can control the initialization sequence more closely and do
useful work between the two calls.

Refactor, no change in behavior. Covered by existing tests.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::initializeLayerRendererIfNeeded):
(WebCore):
(WebCore::CCLayerTreeHost::updateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::commitAndComposite):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::beginFrame):

Source/WebKit/chromium:

Update tests to call initializeLayerRendererIfNeeded() before calling updateLayers() to reflect what the proxies
do.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agor120844: Skip two tests on Qt
robert@webkit.org [Wed, 20 Jun 2012 20:25:07 +0000 (20:25 +0000)]
r120844: Skip two tests on Qt

The tests fast/block/float/previous-sibling-abspos-001.html and
fast/block/float/previous-sibling-float-001.html have pixel differences
on Qt. Skip them for now - bug 89597 opened.

Unreviewed, gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSecurityOrigin::canDisplay() should return true when m_universalAccess is true
commit-queue@webkit.org [Wed, 20 Jun 2012 20:23:51 +0000 (20:23 +0000)]
SecurityOrigin::canDisplay() should return true when m_universalAccess is true
https://bugs.webkit.org/show_bug.cgi?id=84865

Patch by Yong Li <yoli@rim.com> on 2012-06-20
Reviewed by Adam Barth.

Add an early return (true) in canDisplay() for if (m_universalAccess),
as we did for canAccess() and canRequest().

No new tests. We should be good as long as this change doesn't break existing
tests, which means the contents supposed to be blocked are still blocked when
m_universalAccess is false.

* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Use v8::V8::AddImplicitReferences instead of SetHiddenValue
arv@chromium.org [Wed, 20 Jun 2012 20:16:41 +0000 (20:16 +0000)]
[V8] Use v8::V8::AddImplicitReferences instead of SetHiddenValue
https://bugs.webkit.org/show_bug.cgi?id=80880

Reviewed by Adam Barth.

We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.

To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8). Interfaces that have *IsReachable
also have a dependent life time (just like if V8DependentLifetime was present).

Retry. Last time we got ASAN issues on some Cromium Linux bots.

No new tests. Covered by existing tests.

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorJS.pm:
(GetGenerateIsReachable): Abstracted GenerateIsReachable and JSGenerateIsReachable.
(GetCustomIsReachable): Ditto.
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
* bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8TextTrackListCustom.cpp: Removed.
* css/CSSStyleSheet.idl:
* css/StyleSheet.idl:
* dom/DOMStringMap.idl:
* dom/NamedNodeMap.idl:
* html/DOMTokenList.idl:
* html/track/TextTrackList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix import sorting missed in r120846
dpranke@chromium.org [Wed, 20 Jun 2012 20:00:19 +0000 (20:00 +0000)]
Fix import sorting missed in r120846

Reviewed by Tony Chang.

* Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix chromium win http servers after breakage introduced in r120846.
dpranke@chromium.org [Wed, 20 Jun 2012 19:53:21 +0000 (19:53 +0000)]
Fix chromium win http servers after breakage introduced in r120846.

Unreviewed, build fix.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.start_http_server):
* Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agotweak output of webkit-patch print-{baselines,expectations}
dpranke@chromium.org [Wed, 20 Jun 2012 19:47:23 +0000 (19:47 +0000)]
tweak output of webkit-patch print-{baselines,expectations}
https://bugs.webkit.org/show_bug.cgi?id=89588

Reviewed by Tony Chang.

Minor tweaks to the output to make it more readable, including
turning off csv by default for print-baselines with multiple ports.

* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort):
* Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.execute):
(PrintBaselines.execute):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.run_test):
(PrintExpectationsTest.test_multiple):
(PrintBaselinesTest.setUp):
(PrintBaselinesTest.test_multiple):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression(r116408): Ctrl-A (select all) on large text file hangs the tab with high...
tony@chromium.org [Wed, 20 Jun 2012 19:33:02 +0000 (19:33 +0000)]
Regression(r116408): Ctrl-A (select all) on large text file hangs the tab with high CPU usage
https://bugs.webkit.org/show_bug.cgi?id=89562

Reviewed by Ryosuke Niwa.

Rather than replace the newlines in-place (in O(n^2)), build a new string using StringBuilder, which takes O(n).

No new tests, this is a perf improvement.

* platform/chromium/ClipboardUtilitiesChromium.cpp:
(WebCore::replaceNewlinesWithWindowsStyleNewlines):
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::replaceNewlinesWithWindowsStyleNewlines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd support for fit-content etc
commit-queue@webkit.org [Wed, 20 Jun 2012 19:28:50 +0000 (19:28 +0000)]
Add support for fit-content etc
https://bugs.webkit.org/show_bug.cgi?id=38919

Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-06-20
Reviewed by Tony Chang.

Source/WebCore:

Implement the CSS3 intrinsic dimension keywords for width properties and
add most of the plumbing for height properties but don't expose them
yet since this patch doesn't enforce them (matching current Gecko).
http://dev.w3.org/csswg/css3-writing-modes/#intrinsic-sizing

This patch implements -webkit-min-content, -webkit-max-content,
-webkit-fill-available and -webkit-fit-content for all width
properties.

Tests: fast/css-intrinsic-dimensions/height-dynamic-property-value.html
       fast/css-intrinsic-dimensions/height-property-value.html
       fast/css-intrinsic-dimensions/max-width-constrained.html
       fast/css-intrinsic-dimensions/max-width-unconstrained.html
       fast/css-intrinsic-dimensions/min-width.html
       fast/css-intrinsic-dimensions/width-avoid-floats.html
       fast/css-intrinsic-dimensions/width-dynamic-property-value.html
       fast/css-intrinsic-dimensions/width-property-value.html
       fast/css-intrinsic-dimensions/width.html

* css/CSSParser.cpp: Add parser support for the new keywords.
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValue.cpp:
(WebCore):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* css/LengthFunctions.cpp: Implement conversion functions.
(WebCore::minimumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::StyleBuilder::StyleBuilder): Clean up the template for old
   intrinsic values and add new values. Rename old intrinsic to
   LegacyIntrinsic and add support for the new dimension keywords as
   Intrinsic.
* platform/Length.h:
(WebCore::Length::isIntrinsicOrAuto):
(WebCore::Length::isLegacyIntrinsic): New method to check for old
    min-intrinsic and intrinsic keywords.
(WebCore::Length::isIntrinsic): New method to check for CSS3 intrinsic
    dimension keywords like min-content.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegionUsing): Expose the max
   and min logical preferred widths as the new keywords.
(WebCore::RenderBox::sizesLogicalWidthToFitContent): Renamed method to
   be more consistent with the new MinContent naming in the spec.
* rendering/RenderBox.h:
(RenderBox):

LayoutTests:

Tests for CSS3 intrinsic dimension keywords as defined in the
writing modes spec. This tests the implementation for width and
ensures that height properties don't allow the new keywords yet
since they're not implemented by this patch.

* fast/css-intrinsic-dimensions/height-dynamic-property-value-expected.txt: Added.
* fast/css-intrinsic-dimensions/height-dynamic-property-value.html: Added.
* fast/css-intrinsic-dimensions/height-property-value-expected.txt: Added.
* fast/css-intrinsic-dimensions/height-property-value.html: Added.
* fast/css-intrinsic-dimensions/max-width-constrained-expected.html: Added.
* fast/css-intrinsic-dimensions/max-width-constrained.html: Added.
* fast/css-intrinsic-dimensions/max-width-unconstrained-expected.html: Added.
* fast/css-intrinsic-dimensions/max-width-unconstrained.html: Added.
* fast/css-intrinsic-dimensions/min-width-expected.html: Added.
* fast/css-intrinsic-dimensions/min-width.html: Added.
* fast/css-intrinsic-dimensions/width-avoid-floats-expected.html: Added.
* fast/css-intrinsic-dimensions/width-avoid-floats.html: Added.
* fast/css-intrinsic-dimensions/width-dynamic-property-value-expected.txt: Added.
* fast/css-intrinsic-dimensions/width-dynamic-property-value.html: Added.
* fast/css-intrinsic-dimensions/width-expected.html: Added.
* fast/css-intrinsic-dimensions/width-keyword-classes.css: Added.
(.min-content):
(.max-content):
(.fill-available):
(.fit-content):
(.max-width-min-content):
(.max-width-max-content):
(.max-width-fill-available):
(.max-width-fit-content):
(.min-width-min-content):
(.min-width-max-content):
(.min-width-fill-available):
(.min-width-fit-content):
* fast/css-intrinsic-dimensions/width-property-value-expected.txt: Added.
* fast/css-intrinsic-dimensions/width-property-value.html: Added.
* fast/css-intrinsic-dimensions/width.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] webkit-backface-visibility doesn't work with video
commit-queue@webkit.org [Wed, 20 Jun 2012 19:17:43 +0000 (19:17 +0000)]
[chromium] webkit-backface-visibility doesn't work with video
https://bugs.webkit.org/show_bug.cgi?id=88908

When determining a contents layer's backface culling, use the parent
layer's transform and backface-visibility properties. Track which
layers need this special treatment with useParentBackfaceVisibility
and setUseParentBackfaceVisibility functions in WebCore::LayerChromium,
WebKit::WebLayer, and WebCore::CCLayerImpl.

Patch by Christopher Cameron <ccameron@chromium.org> on 2012-06-20
Reviewed by Adrienne Walker.

Source/Platform:

* chromium/public/WebLayer.h:
    (WebLayer):
        Add an accessor to specify that a layer should use its parent's
        backface culling behavior.

Source/WebCore:

Tests: compositing/backface-visibility/backface-visibility-image.html
       compositing/backface-visibility/backface-visibility-webgl.html

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setupContentsLayer):
    When a contents layer is added, tag it as inheriting its backface
    culling from its parent.
* platform/graphics/chromium/LayerChromium.cpp:
    (WebCore::LayerChromium::LayerChromium):
        Initialize new m_useParentBackfaceVisibility member variable.
    (WebCore::LayerChromium::pushPropertiesTo):
        Propagate m_useParentBackfaceVisibility to CCLayerImpl.
* platform/graphics/chromium/LayerChromium.h:
    (WebCore::LayerChromium::setUseParentBackfaceVisibility):
    (WebCore::LayerChromium::useParentBackfaceVisibility):
    (LayerChromium):
        Add m_useParentBackfaceVisibility member variable and modify
        and query accessors.
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
    (WebCore::CCLayerImpl::CCLayerImpl):
        Initialize new m_useParentBackfaceVisibility member variable.
* platform/graphics/chromium/cc/CCLayerImpl.h:
    (WebCore::CCLayerImpl::setUseParentBackfaceVisibility):
    (WebCore::CCLayerImpl::useParentBackfaceVisibility):
    (CCLayerImpl):
        Add m_useParentBackfaceVisibility member variable and modify
        and query accessors.
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
    (WebCore::layerShouldBeSkipped):
        When examining a layer, if the layer has
        useParentBackfaceVisibility set then use the layer's parent
        layer to determine backface culling.

Source/WebKit/chromium:

* src/WebLayer.cpp:
    (WebKit::WebLayer::setUseParentBackfaceVisibility):
        Add an accessor to specify that a layer should use its parent's
        backface culling behavior.

LayoutTests:

* compositing/backface-visibility/backface-visibility-image-expected.png: Added.
* compositing/backface-visibility/backface-visibility-image-expected.txt: Added.
* compositing/backface-visibility/backface-visibility-image.html: Added.
* compositing/backface-visibility/backface-visibility-webgl-expected.png: Added.
* compositing/backface-visibility/backface-visibility-webgl-expected.txt: Added.
* compositing/backface-visibility/backface-visibility-webgl.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonew-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
dpranke@chromium.org [Wed, 20 Jun 2012 19:00:48 +0000 (19:00 +0000)]
new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
https://bugs.webkit.org/show_bug.cgi?id=88134

Reviewed by Tony Chang.

Change NRWT to spin up 2*min(child_processes, locked_shards)
http servers by default so that we are less likely to get a
bunch of http timeouts at the beginning of a test run.

Note that I had to tweak executive_mock to support mocked stderr
because the apache_http_server code reads stderr when starting a
process to ensure it started okay.

* Scripts/webkitpy/common/system/executive_mock.py:
(MockProcess.__init__):
* Scripts/webkitpy/common/system/outputcapture.py:
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
(Manager.start_servers_with_lock):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.start_http_server):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.start_http_server):
(TestPort._path_to_apache):
(TestPort):
(TestPort._path_to_apache_config_file):
* Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd.__init__):
* Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
(LayoutTestApacheHttpd.__init__):
* Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd.__init__):
* Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Don't re-enter CachedResource::removeClient() if an XHR
japhet@chromium.org [Wed, 20 Jun 2012 18:42:51 +0000 (18:42 +0000)]
Source/WebCore: Don't re-enter CachedResource::removeClient() if an XHR
is canceled and restarted multiple times.
https://bugs.webkit.org/show_bug.cgi?id=89378

Reviewed by Eric Seidel.

Test: http/tests/xmlhttprequest/reentrant-cancel.html

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::cancel):
(WebCore::DocumentThreadableLoader::clearResource): Save off a copy of m_resource
   then clear it, so we don't call clearResource() multiple times for the same resource.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=89378.
Reviewed by Eric Seidel.

* http/tests/xmlhttprequest/reentrant-cancel-expected.txt: Added.
* http/tests/xmlhttprequest/reentrant-cancel.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNegative margin block doesn't properly clear a float enclosed by a previous sibling
robert@webkit.org [Wed, 20 Jun 2012 18:40:09 +0000 (18:40 +0000)]
Negative margin block doesn't properly clear a float enclosed by a previous sibling
https://bugs.webkit.org/show_bug.cgi?id=10900

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/block/float/previous-sibling-abspos-001.html
       fast/block/float/previous-sibling-abspos-002.html
       fast/block/float/previous-sibling-float-001.html
       fast/block/float/previous-sibling-float-002.html
       fast/css/clear-float-sibling.html

Parent blocks keep a list of child floats that extend out of the parent block and
by implication overhang into the parent's siblings. But this doesn't work if the
sibling has collapsing margins - it will not find the float in the previous block's
list so will ignore the float and fail to clear it.

RenderBlock:collapseMargins() needs to check if a child's collapsing margin has
reduced the height of the parent up past the bottom of its previous sibling's lowest float
and add the now overhanging float to the parent's float list if appropriate. No need to do
this if the previous sibling is a float or is positioned - the child will clear/avoid it anyway
and attempting to avoid floated children of floats causes incorrect layout.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseMargins):

LayoutTests:

* fast/block/float/previous-sibling-abspos-001-expected.html: Added.
* fast/block/float/previous-sibling-abspos-001.html: Added.
* fast/block/float/previous-sibling-abspos-002-expected.html: Added.
* fast/block/float/previous-sibling-abspos-002.html: Added.
* fast/block/float/previous-sibling-float-001-expected.html: Added.
* fast/block/float/previous-sibling-float-001.html: Added.
* fast/block/float/previous-sibling-float-002-expected.html: Added.
* fast/block/float/previous-sibling-float-002.html: Added.
* fast/css/clear-float-sibling-expected.html: Added.
* fast/css/clear-float-sibling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Allow module injections into the InjectedScript
commit-queue@webkit.org [Wed, 20 Jun 2012 18:28:05 +0000 (18:28 +0000)]
Web Inspector: Allow module injections into the InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=89530

Add a new InjectedScriptModule abstract class that inherits InjectedScriptBase
to reuse implementation, and which javascript code is injected via
InjectedScript.

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-20
Reviewed by Pavel Feldman.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptObject::ScriptObject):
(WebCore):
* bindings/js/ScriptObject.h:
(ScriptObject):
(WebCore::ScriptObject::ScriptObject):
* bindings/v8/ScriptObject.cpp:
(WebCore::ScriptObject::ScriptObject):
(WebCore):
* bindings/v8/ScriptObject.h:
(ScriptObject):
(WebCore::ScriptObject::~ScriptObject):
* inspector/InjectedScript.cpp:
* inspector/InjectedScript.h:
(WebCore):
(WebCore::InjectedScript::name):
(InjectedScript):
* inspector/InjectedScriptBase.cpp:
(WebCore::InjectedScriptBase::callFunctionWithEvalEnabled):
* inspector/InjectedScriptBase.h:
(WebCore):
(InjectedScriptBase):
* inspector/InjectedScriptManager.h:
(InjectedScriptManager):
(WebCore::InjectedScriptManager::inspectedStateAccessCheck):
* inspector/InjectedScriptModule.cpp: Copied from Source/WebCore/inspector/InjectedScriptBase.h.
(WebCore):
(WebCore::InjectedScriptModule::InjectedScriptModule):
(WebCore::InjectedScriptModule::ensureInjected):
* inspector/InjectedScriptModule.h: Copied from Source/WebCore/bindings/js/ScriptObject.h.
(WebCore):
(InjectedScriptModule):
* inspector/InjectedScriptSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMade the incremental sweeper more aggressive
ggaren@apple.com [Wed, 20 Jun 2012 18:24:02 +0000 (18:24 +0000)]
Made the incremental sweeper more aggressive
https://bugs.webkit.org/show_bug.cgi?id=89527

Reviewed by Oliver Hunt.

This is a pre-requisite to getting rid of "berzerker GC" because we need
the sweeper to reclaim memory in a timely fashion, or we'll see a memory
footprint regression.

* heap/IncrementalSweeper.h:
* heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::scheduleTimer): Since the time slice is predictable,
no need to use a data member to record it.

(JSC::IncrementalSweeper::doSweep): Sweep as many blocks as we can in a
small time slice. This is better than sweeping only one block per timer
fire because that strategy has a heavy timer overhead, and artificially
delays memory reclamation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Enable setAcceleratedCompositingForFixedPositionEnabled
commit-queue@webkit.org [Wed, 20 Jun 2012 18:18:47 +0000 (18:18 +0000)]
[BlackBerry] Enable setAcceleratedCompositingForFixedPositionEnabled
https://bugs.webkit.org/show_bug.cgi?id=89575

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-20
Reviewed by Antonio Gomes.

Enable the flag so that we get position:fixed elemetns to be rendered
using accelerated compositing.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Timeline label bar jiggles when scrolling
pfeldman@chromium.org [Wed, 20 Jun 2012 18:11:09 +0000 (18:11 +0000)]
Web Inspector: Timeline label bar jiggles when scrolling
https://bugs.webkit.org/show_bug.cgi?id=89579

Reviewed by Vsevolod Vlasov.

Adding timeline header into the timeline panel and settings its position
to absolute. Drive-by fix that updates rulers on sidebar resize.

* inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid):
(WebInspector.TimelineGrid.prototype.get gridHeaderElement):
(WebInspector.TimelineGrid.prototype.addEventDividers):
(WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype.onResize):
* inspector/front-end/timelinePanel.css:
(#timeline-grid-header):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Make sure that render surfaces are not pixel doubled with a device scale...
commit-queue@webkit.org [Wed, 20 Jun 2012 17:58:09 +0000 (17:58 +0000)]
[chromium] Make sure that render surfaces are not pixel doubled with a device scale factor of 2
https://bugs.webkit.org/show_bug.cgi?id=86882

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-20
Reviewed by Adrienne Walker.

To ensure that render surfaces are not pixel doubled when device scale factor is
two, the render surface's owning layer's draw transform is scaled by the
contents scale (in the same way that the parent matrix is scaled by the device
scale factor). The transformedLayerRect's dimensions also need to be in pixel
space. The surface origin transform should not scale, but needs to offset the
correct number of pixels, and the replica transforms need to be modified to
account for the scaling.

Source/WebCore:

To accomplish this, CCLayerImpl's needed to be made aware of contentsScale.

Thanks to Adrienne Walker for the computation of the replica draw transform.

Unit test: CCLayerTreeHostCommonTest.verifyRenderSurfaceTranformsInHighDPI

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setContentsScale):
(WebCore::CCLayerImpl::contentsScale):
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::CCScrollbar::totalSize):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix JSC ChangeLog, forgot to add a comment to the ChangeLog before committing.
fpizlo@apple.com [Wed, 20 Jun 2012 17:51:07 +0000 (17:51 +0000)]
Fix JSC ChangeLog, forgot to add a comment to the ChangeLog before committing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS3 Backgrounds and Borders] Implement box-decoration-break rendering.
alexis.menard@openbossa.org [Wed, 20 Jun 2012 17:49:18 +0000 (17:49 +0000)]
[CSS3 Backgrounds and Borders] Implement box-decoration-break rendering.
https://bugs.webkit.org/show_bug.cgi?id=88228

Reviewed by Eric Seidel.

Source/WebCore:

Implement the new CSS property box-decoration-break. It modifies
where we decide whether the borders needs to be sliced or not by
checking if the box-decoration-break is set to clone. If it's the case
then we need to explicitely redraw all edges.

Test: fast/box-decoration-break/box-decoration-break-rendering.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::paintFillLayer):

LayoutTests:

Add new tests to cover the feature.

* fast/box-decoration-break/box-decoration-break-rendering-expected.html: Added.
* fast/box-decoration-break/box-decoration-break-rendering.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should be able to print disassembly interleaved with the IR
fpizlo@apple.com [Wed, 20 Jun 2012 17:48:23 +0000 (17:48 +0000)]
DFG should be able to print disassembly interleaved with the IR
https://bugs.webkit.org/show_bug.cgi?id=89551

Reviewed by Geoffrey Garen.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::labelIgnoringWatchpoints):
(ARMv7Assembler):
* assembler/AbstractMacroAssembler.h:
(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::labelIgnoringWatchpoints):
* assembler/X86Assembler.h:
(X86Assembler):
(JSC::X86Assembler::labelIgnoringWatchpoints):
* dfg/DFGCommon.h:
(JSC::DFG::shouldShowDisassembly):
(DFG):
* dfg/DFGDisassembler.cpp: Added.
(DFG):
(JSC::DFG::Disassembler::Disassembler):
(JSC::DFG::Disassembler::dump):
(JSC::DFG::Disassembler::dumpDisassembly):
* dfg/DFGDisassembler.h: Added.
(DFG):
(Disassembler):
(JSC::DFG::Disassembler::setStartOfCode):
(JSC::DFG::Disassembler::setForBlock):
(JSC::DFG::Disassembler::setForNode):
(JSC::DFG::Disassembler::setEndOfMainPath):
(JSC::DFG::Disassembler::setEndOfCode):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::amountOfNodeWhiteSpace):
(DFG):
(JSC::DFG::Graph::printNodeWhiteSpace):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(DFG):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JITCompiler):
(JSC::DFG::JITCompiler::setStartOfCode):
(JSC::DFG::JITCompiler::setForBlock):
(JSC::DFG::JITCompiler::setForNode):
(JSC::DFG::JITCompiler::setEndOfMainPath):
(JSC::DFG::JITCompiler::setEndOfCode):
* dfg/DFGNode.h:
(Node):
(JSC::DFG::Node::willHaveCodeGen):
* dfg/DFGNodeFlags.cpp:
(JSC::DFG::nodeFlagsAsString):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
* runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
* runtime/Options.h:
(Options):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
jsbell@chromium.org [Wed, 20 Jun 2012 17:27:08 +0000 (17:27 +0000)]
Unreviewed build fix.

* tests/IDBDatabaseBackendTest.cpp:
(WebCore::MockIDBCallbacks::~MockIDBCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse IntSize in RenderLayer to represent scroll offsets
jchaffraix@webkit.org [Wed, 20 Jun 2012 17:24:24 +0000 (17:24 +0000)]
Use IntSize in RenderLayer to represent scroll offsets
https://bugs.webkit.org/show_bug.cgi?id=89154

Reviewed by Eric Seidel.

Source/WebCore:

Refactoring, covered by existing tests.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::scrollTo):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::forwardEvent):
* page/SpatialNavigation.cpp:
(WebCore::scrollInDirection):
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::start):
Updated those call-sites to use the IntSize variant of the scrolling function.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::panScrollFromPoint):
Updated the signature to use IntPoint to avoid an extra round-trip to LayoutPoint
(furthermore touch points should be in device pixels).

(WebCore::RenderLayer::clampScrollOffset):
Added this function that clamps a scroll offset to the box's size. This enables more
code sharing between the different functions. Also removed a NULL-check that shouldn't
be needed: scrolling is a RenderBox concept so any callers should ensure that we have
a RenderBox or it makes no sense to try to scroll.

(WebCore::RenderLayer::updateLayerPosition):
(WebCore::adjustedScrollDelta):
(WebCore::RenderLayer::scrollByRecursively):
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Updated to do IntSize arithmetic. Reuse clampScrollOffset when applicable.

* rendering/RenderLayer.h:
(WebCore::RenderLayer::scrollToXOffset):
(WebCore::RenderLayer::scrollToYOffset):
Updated the functions to take IntSize as much as possible.

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::scrollRenderer):
Updated to pass an IntSize to scrollToOffset.

Source/WebKit/win:

* WebView.cpp:
(WebView::gesture):
Updated to pass an IntSize to scrollByRecursively.

Source/WebKit2:

* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::gestureDidScroll):
Updated to pass an IntSize to scrollByRecursively.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Implement Web Intent delivery
commit-queue@webkit.org [Wed, 20 Jun 2012 17:22:10 +0000 (17:22 +0000)]
[WK2] Implement Web Intent delivery
https://bugs.webkit.org/show_bug.cgi?id=88989

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-20
Reviewed by Anders Carlsson.

Add a deliverIntent() method to the WebFrame so that
Web intents can be delivered once matched to a
specific service.

* UIProcess/WebFrameProxy.cpp:
(WebKit):
(WebKit::WebFrameProxy::deliverIntent):
* UIProcess/WebFrameProxy.h:
(WebKit):
(WebFrameProxy):
* UIProcess/WebIntentData.h:
(WebKit::WebIntentData::store):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit):
(WebKit::WebFrame::deliverIntent):
* WebProcess/WebPage/WebFrame.h:
(WebKit):
(WebFrame):
* WebProcess/WebPage/WebPage.cpp:
(WebKit):
(WebKit::WebPage::deliverIntentToFrame):
* WebProcess/WebPage/WebPage.h:
(WebKit):
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: mark used/allocated JS heap on the native memory bar chart.
commit-queue@webkit.org [Wed, 20 Jun 2012 16:33:27 +0000 (16:33 +0000)]
Web Inspector: mark used/allocated JS heap on the native memory bar chart.
https://bugs.webkit.org/show_bug.cgi?id=89476

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-20
Reviewed by Yury Semikhatsky.

* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryBarChart):
(WebInspector.NativeMemoryBarChart.prototype._updateView):
* inspector/front-end/nativeMemoryProfiler.css:
(.memory-bar-chart-bar):
(.memory-bar-chart-unused):
(.memory-bar-chart-percent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] IndexedDB: Don't close database if pending connections are in flight
jsbell@chromium.org [Wed, 20 Jun 2012 16:17:50 +0000 (16:17 +0000)]
[Chromium] IndexedDB: Don't close database if pending connections are in flight
https://bugs.webkit.org/show_bug.cgi?id=89512

Source/WebCore:

Add a counter tracking connections between the two phases, which is used along with
the completed connection count to determine the total number of connections.

Reviewed by Tony Chang.

Test: webkit_unit_tests --gtest_filter='IDBDatabaseBackendTest.ConnectionLifecycle'

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::close):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::openInternal):
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):

Source/WebKit/chromium:

Reviewed by Tony Chang.

* tests/IDBDatabaseBackendTest.cpp:
(MockIDBCallbacks):
(WebCore::MockIDBCallbacks::create):
(WebCore::MockIDBCallbacks::MockIDBCallbacks):
(WebCore):
(FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::create):
(WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: duplicating selected text when Enter key is pressed
commit-queue@webkit.org [Wed, 20 Jun 2012 16:15:23 +0000 (16:15 +0000)]
Web Inspector: duplicating selected text when Enter key is pressed
https://bugs.webkit.org/show_bug.cgi?id=89559

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-06-20
Reviewed by Pavel Feldman.

* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
The returned result of method normalize() should be used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Cairo] Fix memory leak in GraphicsContext3DCairo.cpp
commit-queue@webkit.org [Wed, 20 Jun 2012 16:07:34 +0000 (16:07 +0000)]
[Cairo] Fix memory leak in GraphicsContext3DCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=89561

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-20
Reviewed by Martin Robinson.

Fix a memory leak in GraphicsContext3D::getImageData().

* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::getImageData): asNewNativeImage() returns a
caller-owned pointer to the native image data. So, using OwnPtr to manage
memory automatically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed: Back out accidentally checked in debug print which broke a test
tomz@codeaurora.org [Wed, 20 Jun 2012 16:06:02 +0000 (16:06 +0000)]
Unreviewed: Back out accidentally checked in debug print which broke a test

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.parse_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse HitTestPoint instead of LayoutPoint for nodeAtPoint.
commit-queue@webkit.org [Wed, 20 Jun 2012 15:41:57 +0000 (15:41 +0000)]
Use HitTestPoint instead of LayoutPoint for nodeAtPoint.
https://bugs.webkit.org/show_bug.cgi?id=89448

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-20
Reviewed by Eric Seidel.

This patch updates the API of nodeAtPoint without changing any
functionality. This is largest change necessary to support
transforms in area-based hit-testing, but is only boilerplate.

No change in functionality. No new tests.

* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::nodeAtPoint):
* rendering/EllipsisBox.h:
(EllipsisBox):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
* rendering/HitTestResult.h:
(WebCore::HitTestPoint::intersects):
(HitTestPoint):
(HitTestResult):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::nodeAtPoint):
* rendering/InlineBox.h:
(InlineBox):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
* rendering/InlineFlowBox.h:
(InlineFlowBox):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
* rendering/InlineTextBox.h:
(InlineTextBox):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::hitTestContents):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::nodeAtPoint):
* rendering/RenderEmbeddedObject.h:
(RenderEmbeddedObject):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::hitTestRegion):
* rendering/RenderFlowThread.h:
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::nodeAtPoint):
* rendering/RenderFrameSet.h:
(RenderFrameSet):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):
* rendering/RenderImage.h:
(RenderImage):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::nodeAtPoint):
* rendering/RenderInline.h:
(RenderInline):
* rendering/RenderLayer.cpp:
(WebCore::ClipRect::intersects):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestContents):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::hitTestPaginatedChildLayer):
(WebCore::RenderLayer::hitTestChildLayerColumns):
* rendering/RenderLayer.h:
(ClipRect):
(RenderLayer):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::hitTest):
* rendering/RenderLineBoxList.h:
(RenderLineBoxList):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::nodeAtPoint):
* rendering/RenderListBox.h:
(RenderListBox):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::hitTest):
(WebCore::RenderObject::nodeAtPoint):
* rendering/RenderObject.h:
(RenderObject):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::nodeAtPoint):
* rendering/RenderRegion.h:
(RenderRegion):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
* rendering/RenderTable.h:
(RenderTable):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::nodeAtPoint):
* rendering/RenderTableRow.h:
(RenderTableRow):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
* rendering/RenderTableSection.h:
(RenderTableSection):
* rendering/RenderText.h:
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::nodeAtPoint):
* rendering/RenderTextControlMultiLine.h:
(RenderTextControlMultiLine):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
* rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::nodeAtPoint):
* rendering/RenderWidget.h:
(RenderWidget):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::nodeAtPoint):
* rendering/RootInlineBox.h:
(RootInlineBox):
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
(WebCore::RenderSVGForeignObject::nodeAtPoint):
* rendering/svg/RenderSVGForeignObject.h:
(RenderSVGForeignObject):
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::nodeAtPoint):
* rendering/svg/RenderSVGModelObject.h:
(RenderSVGModelObject):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):
* rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::nodeAtFloatPoint):
(WebCore::RenderSVGText::nodeAtPoint):
* rendering/svg/RenderSVGText.h:
(RenderSVGText):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):
* rendering/svg/SVGInlineTextBox.h:
(SVGInlineTextBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImport themaninblue.com/experiment/AnimationBenchmark/ as performance tests
tomz@codeaurora.org [Wed, 20 Jun 2012 15:09:19 +0000 (15:09 +0000)]
Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
https://bugs.webkit.org/show_bug.cgi?id=78789

Reviewed by Ryosuke Niwa.

PerformanceTests:

Added PerfTestRunner fixture around it.

* Animation/balls.html: Added.

Tools:

Updated parser to include fps as a valid unit.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: don't report context ids before DidCommitLoad
yurys@chromium.org [Wed, 20 Jun 2012 15:07:28 +0000 (15:07 +0000)]
Web Inspector: don't report context ids before DidCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=89567

Reviewed by Pavel Feldman.

When inspector state is restored only report existing context ids
if "did commit load" even has already been dispatched.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::restore):
* inspector/PageRuntimeAgent.h:
(WebCore):
(WebCore::PageRuntimeAgent::create):
(PageRuntimeAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
ossy@webkit.org [Wed, 20 Jun 2012 15:03:23 +0000 (15:03 +0000)]
webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
https://bugs.webkit.org/show_bug.cgi?id=67935

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-06-20
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.set_reviewer):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_set_reviewer):
(test_set_short_description_and_bug_url):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove redundant #includes in compositor
commit-queue@webkit.org [Wed, 20 Jun 2012 13:52:50 +0000 (13:52 +0000)]
[Chromium] Remove redundant #includes in compositor
https://bugs.webkit.org/show_bug.cgi?id=89503

Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-20
Reviewed by Adrienne Walker.

Source/WebCore:

Removed some redundant #includes to clarify dependency
picture. Some 90 #includes removed, some 50 less disruptive
#includes added. This brings the number of class dependencies to
902 from 1383.

No new tests are required, as this is only affects compile-time behavior.

* platform/graphics/chromium/AnimationTranslationUtil.h:
(WebCore):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
* platform/graphics/chromium/Canvas2DLayerBridge.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/DrawingBufferChromium.cpp:
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/ManagedTexture.cpp:
* platform/graphics/chromium/ProgramBinding.h:
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/TextureCopier.cpp:
* platform/graphics/chromium/TextureLayerChromium.cpp:
* platform/graphics/chromium/TextureManager.cpp:
* platform/graphics/chromium/TiledLayerChromium.cpp:
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCActiveAnimation.h:
(WebCore):
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
* platform/graphics/chromium/cc/CCFontAtlas.cpp:
* platform/graphics/chromium/cc/CCFrameRateController.cpp:
* platform/graphics/chromium/cc/CCFrameRateController.h:
(WebCore):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerAnimationController.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(WebCore):
* platform/graphics/chromium/cc/CCProxy.cpp:
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
* platform/graphics/chromium/cc/CCRenderSurface.h:
* platform/graphics/chromium/cc/CCRenderer.h:
* platform/graphics/chromium/cc/CCScopedThreadProxy.h:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore):
* platform/graphics/chromium/cc/CCTimer.cpp:
* platform/graphics/chromium/cc/CCTimer.h:
(WebCore):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

Source/WebKit/chromium:

Minor adjustments to #include statements to remove
dependencies. No new tests.

* src/WebCompositorImpl.cpp:
* src/WebLayerTreeView.cpp:
* tests/CCLayerTestCommon.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/CCOcclusionTrackerTest.cpp:
* tests/CCQuadCullerTest.cpp:
* tests/CCTiledLayerImplTest.cpp:
* tests/ImageLayerChromiumTest.cpp:
* tests/LayerRendererChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Implement native memory bar diagram
commit-queue@webkit.org [Wed, 20 Jun 2012 13:32:16 +0000 (13:32 +0000)]
Web Inspector: Implement native memory bar diagram
https://bugs.webkit.org/show_bug.cgi?id=89106

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-20
Reviewed by Yury Semikhatsky.

* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryBarChart):
(WebInspector.NativeMemoryBarChart.prototype._updateStats):
(WebInspector.NativeMemoryBarChart.prototype.willHide):
(WebInspector.NativeMemoryBarChart.prototype.wasShown):
(WebInspector.NativeMemoryBarChart.prototype._updateView):
* inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/nativeMemoryProfiler.css:
(.memory-bar-chart-name):
(.memory-bar-chart-bar):
(.memory-bar-chart-size):
(.memory-bar-chart-total):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (120705) : LayerTreeHostQt asserts in debug.
alexis.menard@openbossa.org [Wed, 20 Jun 2012 13:26:56 +0000 (13:26 +0000)]
REGRESSION (120705) : LayerTreeHostQt asserts in debug.
https://bugs.webkit.org/show_bug.cgi?id=89487

Reviewed by Noam Rosenthal.

We try to call createHandle twice on the same handle when the
first matching atlas is full. This patch solved the problem by
moving the createHandle call inside UpdateAtlas and call createHandle
only when the atlas is not full. We can also remove the surface()
getter as it is not used anymore.

* WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/UpdateAtlas.h:
(UpdateAtlas):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::beginContentUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeech JavaScript API: add SpeechRecognition.maxAlternatives attribute
hans@chromium.org [Wed, 20 Jun 2012 12:35:41 +0000 (12:35 +0000)]
Speech JavaScript API: add SpeechRecognition.maxAlternatives attribute
https://bugs.webkit.org/show_bug.cgi?id=89459

Reviewed by Eric Seidel.

Source/WebCore:

Add the SpeechRecognition.maxAlternatives attribute.

Test: fast/speech/scripted/basics.html:

* Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::SpeechRecognition):
* Modules/speech/SpeechRecognition.h:
(WebCore::SpeechRecognition::maxAlternatives):
(WebCore::SpeechRecognition::setMaxAlternatives):
(SpeechRecognition):
* Modules/speech/SpeechRecognition.idl:
* Modules/speech/SpeechRecognitionClient.h:
(SpeechRecognitionClient):
* Modules/speech/SpeechRecognitionController.h:
(WebCore::SpeechRecognitionController::start):
(SpeechRecognitionController):

Source/WebKit/chromium:

Plumbing for the maxAlternatives attribute.

* public/WebSpeechRecognitionParams.h:
(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::maxAlternatives):
(WebSpeechRecognitionParams):
* src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::start):
* src/SpeechRecognitionClientProxy.h:
(SpeechRecognitionClientProxy):

LayoutTests:

Update the basic test to check for presence of the maxAlternatives attribute.

* fast/speech/scripted/basics-expected.txt:
* fast/speech/scripted/basics.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoapplyAuthorStyles makes rules declared in all enclosing shadow dom subtrees applicable.
commit-queue@webkit.org [Wed, 20 Jun 2012 11:48:24 +0000 (11:48 +0000)]
applyAuthorStyles makes rules declared in all enclosing shadow dom subtrees applicable.
https://bugs.webkit.org/show_bug.cgi?id=89061

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-20
Reviewed by Dimitri Glazkov.

Source/WebCore:

Fixing apply-author-styles bug. If there exists some shadow subtree A
and A has apply-author-styles flag set, whether some rules declared in
a tree B is applicable in A or not depends on:
- the tree B encloses the tree A, and
- all trees which enclose A and are enclosed by B has
  apply-author-styles set.
c.f.
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#styles
However the second rule was not implemented.

Test: fast/css/style-scoped/style-scoped-apply-author-styles.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::setupScopeStack):
Modified to add a new member variable, authorStyleBoundsIndex to
ScopeStackFrame used by m_scopeStack. The index means: if shadow dom
subtree A and B has the same value and A encloses B, all shadow dom
subtrees which enclose B and are enclosed by B have
apply-author-styles set. And B also has apply-author-styles set.
This means, if some element X has authorStyleBoundsIndex N, all
rulesets whose scopes have authorStyleBoundsIndex N are applicable in
B's tree scope. If all shadow dom subtrees have apply-author-styles
unset, the index looks almost the same as treeScope(). In this case,
Rules in different tree scopes have different author style bounds
index.
(WebCore::StyleResolver::pushScope):
(WebCore::StyleResolver::popScope):
Added the code for updating m_scopeStackParentBoundsIndex. The member
variable keeps m_scopeStackParent's author style bounds index.
(WebCore::StyleResolver::matchScopedAuthorRules):
Modified to consider author style's bounds index. Firstly applying
scoped styles declared in document if apply-author-styles is set.
Next, applying scoped styles declared in shadow dom subtree with
considering author style bounds index, i.e. considering
apply-author-styles flag.
* css/StyleResolver.h:
(WebCore::StyleResolver::ScopeStackFrame::ScopeStackFrame):
(ScopeStackFrame):
Added m_authorStyleBoundsIndex to keep apply-author-styles flag
information. m_authorStyleBoundsIndex increments by 1 if shadow root is
given and it has apply-author-styles unset.
Now rules in the same authorStyleBoundsIndex should be applied.
(StyleResolver):
Added m_scopeStackParentBoundsIndex.
As m_scopeStackParentAuthorStyleBoundsIndex is a little long,
used m_scopeStackParentBoundsIndex.

LayoutTests:

* fast/css/style-scoped/style-scoped-apply-author-styles-expected.txt: Added.
* fast/css/style-scoped/style-scoped-apply-author-styles.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed trivial permissions fix.
hausmann@webkit.org [Wed, 20 Jun 2012 11:07:53 +0000 (11:07 +0000)]
Unreviewed trivial permissions fix.

* qmake/mkspecs/features/features.prf: Don't mark this file as executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdds DeviceMotionClientMock
commit-queue@webkit.org [Wed, 20 Jun 2012 10:36:50 +0000 (10:36 +0000)]
Adds DeviceMotionClientMock
https://bugs.webkit.org/show_bug.cgi?id=89220

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-20
Reviewed by Steve Block.

No new tests because DeviceMotionClientMock is designed to enable future testing and cannot be tested in itself.

Adds DeviceMotionClientMock in WebCore to enable testing of DeviceMotion once it is fully implemented in WebKit.
This addition was originally included in https://bugs.webkit.org/show_bug.cgi?id=89197 but was split into a separate patch for easier review.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/mock/DeviceMotionClientMock.cpp: Added.
(WebCore):
(WebCore::DeviceMotionClientMock::DeviceMotionClientMock):
(WebCore::DeviceMotionClientMock::setController):
(WebCore::DeviceMotionClientMock::startUpdating):
(WebCore::DeviceMotionClientMock::stopUpdating):
(WebCore::DeviceMotionClientMock::setMotion):
(WebCore::DeviceMotionClientMock::timerFired):
* platform/mock/DeviceMotionClientMock.h: Added.
(WebCore):
(DeviceMotionClientMock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed build fix
hausmann@webkit.org [Wed, 20 Jun 2012 09:58:22 +0000 (09:58 +0000)]
[Qt] Unreviewed build fix

The platform plugin example uses QGridLayout and thus needs QT += widgets

* examples/platformplugin/platformplugin.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening. Removed some tests from TestExpectations
sergio@webkit.org [Wed, 20 Jun 2012 08:47:23 +0000 (08:47 +0000)]
Unreviewed GTK gardening. Removed some tests from TestExpectations
as they were passing in the tree bots.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaselining.
morrita@google.com [Wed, 20 Jun 2012 07:54:17 +0000 (07:54 +0000)]
Unreviewed rebaselining.

* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-mac-leopard/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Select the marker range when right-clicking on a marker.
hbono@chromium.org [Wed, 20 Jun 2012 07:00:34 +0000 (07:00 +0000)]
[chromium] Select the marker range when right-clicking on a marker.
https://bugs.webkit.org/show_bug.cgi?id=89331

Reviewed by Hajime Morita.

Chromium always selects only one word when right-clicking on a spelling marker.
This prevents selecting whole region specified by a marker if the marker
consists of two or more words. This change retrieves a range coverted by a
marker and select the range. This emulates the behavior of Mac Chromium and it
does not need any workarounds for Mac.

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Clicking "Clear all profiles" while ongoing recording should reset...
commit-queue@webkit.org [Wed, 20 Jun 2012 06:51:34 +0000 (06:51 +0000)]
Web Inspector: Clicking "Clear all profiles" while ongoing recording should reset the ProfileLauncherView
https://bugs.webkit.org/show_bug.cgi?id=89464

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-06-19
Reviewed by Yury Semikhatsky.

Resetting the ProfileLauncherView in order to reflect the correct states of buttons

No new tests as UI related minor fix.

* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Mac] Speculative skipping to try to paint the bot green.
ossy@webkit.org [Wed, 20 Jun 2012 06:46:31 +0000 (06:46 +0000)]
[Qt][Mac] Speculative skipping to try to paint the bot green.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][Regression] Build break after r120786
ryuan.choi@samsung.com [Wed, 20 Jun 2012 06:30:00 +0000 (06:30 +0000)]
[EFL][Regression] Build break after r120786
https://bugs.webkit.org/show_bug.cgi?id=89549

Unreviewed build fix for Efl port.

Source/WebKit2:

* CMakeLists.txt: Added disassembler in includes.

Tools:

* DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAssertion for event's target is wrong.
hayato@chromium.org [Wed, 20 Jun 2012 06:29:59 +0000 (06:29 +0000)]
Assertion for event's target is wrong.
https://bugs.webkit.org/show_bug.cgi?id=89479

Reviewed by Hajime Morita.

Fix an assertion to ensure that event's target is reachable from a current target.

No new tests. Fix an assert condition.

* dom/EventContext.cpp:
(WebCore::EventContext::EventContext):
* dom/EventContext.h:
(EventContext):
(WebCore::EventContext::setRelatedTarget):
(WebCore::EventContext::isUnreachableNode):
(WebCore):
(WebCore::EventContext::isReachable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Unreviewed speculative buildfix after r120786.
ossy@webkit.org [Wed, 20 Jun 2012 06:23:13 +0000 (06:23 +0000)]
[CMake] Unreviewed speculative buildfix after r120786.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactoring: Geolocation::startRequest() should not create the GeoNotifiers
benjamin@webkit.org [Wed, 20 Jun 2012 06:03:07 +0000 (06:03 +0000)]
Refactoring: Geolocation::startRequest() should not create the GeoNotifiers
https://bugs.webkit.org/show_bug.cgi?id=89533

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-06-19
Reviewed by David Kilzer.

It was odd to create the GeoNotifiers in Geolocation::startRequest() and having
assertions from the call site.

This patch move GeoNotifiers initialization to the exposed methods and pass them to
startRequest() as needed.
This will also help when adding support for dynamic permission reset and suspend/resume.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::startRequest):
* Modules/geolocation/Geolocation.h:
(Geolocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefine syncLayersTimeoutCallback for Accelerated Compositing.
commit-queue@webkit.org [Wed, 20 Jun 2012 05:51:07 +0000 (05:51 +0000)]
Refine syncLayersTimeoutCallback for Accelerated Compositing.
https://bugs.webkit.org/show_bug.cgi?id=89538

Patch by Chang Wan Hong <jourmoon@company100.net> on 2012-06-19
Reviewed by Martin Robinson.

syncLayersTimeout reschedules the timer so that it can render each frame
every 1/60 seconds on animation. However, because it takes to time to execute
renderLayersToWindow, the timer is delayed. To fix this, we must reschedule
the timer before calling renderLayersToWindow.

* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::syncLayersTimeout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Mac] Skip one more crashing test.
ossy@webkit.org [Wed, 20 Jun 2012 05:40:07 +0000 (05:40 +0000)]
[Qt][Mac] Skip one more crashing test.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Fixes condition where inserting a CounterNode subtree which could...
cdn@chromium.org [Wed, 20 Jun 2012 05:36:27 +0000 (05:36 +0000)]
Source/WebCore: Fixes condition where inserting a CounterNode subtree which could result in incorrect placement.
https://bugs.webkit.org/show_bug.cgi?id=88142

Reviewed by Adam Barth.

Test: fast/css/counters/counter-reset-subtree-insert-crash.html

* rendering/CounterNode.cpp:
(WebCore::CounterNode::insertAfter):

LayoutTests: Add test which inserts a CounterNode subtree which contains reset nodes into another tree.
https://bugs.webkit.org/show_bug.cgi?id=88142

Reviewed by Adam Barth.

* fast/css/counters/counter-reset-subtree-insert-crash-expected.txt: Added.
* fast/css/counters/counter-reset-subtree-insert-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed expected update after r120735.
ossy@webkit.org [Wed, 20 Jun 2012 05:34:01 +0000 (05:34 +0000)]
Unreviewed expected update after r120735.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed buildfix after r120790. Typo fix.
ossy@webkit.org [Wed, 20 Jun 2012 05:18:29 +0000 (05:18 +0000)]
[Qt] Unreviewed buildfix after r120790. Typo fix.

* platform/graphics/gstreamer/ImageGStreamerQt.cpp:
(ImageGStreamer::ImageGStreamer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse testRunner instead of layoutTestController in fast/{files,filesystem}
kinuko@chromium.org [Wed, 20 Jun 2012 05:12:22 +0000 (05:12 +0000)]
Use testRunner instead of layoutTestController in fast/{files,filesystem}
https://bugs.webkit.org/show_bug.cgi?id=89462

Reviewed by Ryosuke Niwa.

* fast/files/apply-blob-url-to-img.html:
* fast/files/apply-blob-url-to-xhr.html:
* fast/files/blob-builder-crash.html:
* fast/files/blob-slice-overflow.html:
* fast/files/blob-slice-test.html:
* fast/files/create-blob-url-crash.html:
* fast/files/domurl-script-execution-context-crash.html:
* fast/files/file-reader-abort.html:
* fast/files/file-reader-directory-crash.html:
* fast/files/file-reader-event-listener.html:
* fast/files/file-reader-file-url.html:
* fast/files/file-reader-sandbox-iframe.html:
* fast/files/null-origin-string.html:
* fast/files/read-blob-async.html:
* fast/files/read-file-async.html:
* fast/files/resources/file-reader-real.html:
* fast/files/resources/setup-for-read-common.js:
* fast/files/revoke-blob-url.html:
* fast/files/script-tests/xhr-response-blob.js:
* fast/files/workers/inline-worker-via-blob-url.html:
* fast/files/workers/worker-apply-blob-url-to-xhr.html:
* fast/files/workers/worker-read-blob-async.html:
* fast/files/workers/worker-read-blob-sync.html:
* fast/files/workers/worker-read-file-async.html:
* fast/files/workers/worker-read-file-sync.html:
* fast/filesystem/cross-filesystem-op.html:
* fast/filesystem/file-after-reload-crash.html:
* fast/filesystem/file-metadata-after-write.html:
* fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
* fast/filesystem/filesystem-uri-origin.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow DOM] ShadowRoot.host should be gone
commit-queue@webkit.org [Wed, 20 Jun 2012 04:31:37 +0000 (04:31 +0000)]
[Shadow DOM] ShadowRoot.host should be gone
https://bugs.webkit.org/show_bug.cgi?id=88387

Source/WebCore:

According to the w3c spec change,
i.e. https://www.w3.org/Bugs/Public/show_bug.cgi?id=16764
Removed host attribute from ShadowRoot.idl.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-19
Reviewed by Dimitri Glazkov.

No new tests, because this change modified only idl.

* dom/ShadowRoot.idl:
Just removed host attribute.

LayoutTests:

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-19
Reviewed by Dimitri Glazkov.

* fast/css/style-scoped/style-scoped-in-shadow-expected.txt:
* fast/css/style-scoped/style-scoped-in-shadow.html:
* fast/dom/shadow/resources/shadow-dom.js:
(isShadowRoot):
* fast/dom/shadow/shadow-root-js-api-expected.txt:
* fast/dom/shadow/shadow-root-js-api.html:
Just removed references to shadow root's host attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a form restore test broken by HTML5 parser
tkent@chromium.org [Wed, 20 Jun 2012 04:26:13 +0000 (04:26 +0000)]
Fix a form restore test broken by HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=89539

Reviewed by Kentaro Hara.

Before HTML5 parser, we parsed innerHTML input text and we attached
renderers to parsed nodes at the same time. The parsed nodes had
restored form values because we restore form values only for attached
elements.

After HTML5 parser, we don't attach renderers during innerHTML
parsing. state-restore-to-nonedited-controls.html used innerHTML to
built a form and the test haven't worked since introducing HTML5 parser.

This patch changes the test so that it uses document.write() instead of
innerHTML.

* fast/forms/state-restore-to-non-edited-controls-expected.txt:
Note that the FAIL line is expected. It's due to Bug 88685.
* fast/forms/state-restore-to-non-edited-controls.html:
Use document.write() instead of innerHTML.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNRWT spins up and down the WebSocket server when running a single HTTP test from...
dpranke@chromium.org [Wed, 20 Jun 2012 04:06:17 +0000 (04:06 +0000)]
NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
https://bugs.webkit.org/show_bug.cgi?id=64489

Reviewed by Tony Chang.

This change changes NRWT so that we don't start the websocket
server if we aren't running websocket tests and don't start the
HTTP server if we aren't running http tests.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._websocket_tests):
(Manager.start_servers_with_lock):
(Manager.stop_servers_with_lock):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_servers_started):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agotest-webkitpy: add a -p flag to pass through captured output to enable debugging
dpranke@chromium.org [Wed, 20 Jun 2012 04:01:29 +0000 (04:01 +0000)]
test-webkitpy: add a -p flag to pass through captured output to enable debugging
https://bugs.webkit.org/show_bug.cgi?id=89158

Reviewed by Eric Seidel.

Normally when outputcapture runs it intercepts stdout/stderr,
which makes running under the debugger difficult and mostly
pointless (since you can't see any output). This change adds a
flag to test-webkitpy (-p) that will cause outputcapture to pass
through the output as well as capture it.

* Scripts/webkitpy/common/system/outputcapture.py:
(OutputCapture.stream_wrapper):
(OutputCapture._capture_output_with_name):
* Scripts/webkitpy/common/system/outputcapture_unittest.py:
(OutputCaptureTest.setUp):
* Scripts/webkitpy/test/main.py:
(Tester._parse_args):
(Tester._run_tests):
(Tester._log_exception):
(_CaptureAndPassThroughStream):
(_CaptureAndPassThroughStream.__init__):
(_CaptureAndPassThroughStream.write):
(_CaptureAndPassThroughStream._message_is_from_pdb):
(_CaptureAndPassThroughStream.flush):
(_CaptureAndPassThroughStream.getvalue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTest fix after r120521.
rniwa@webkit.org [Wed, 20 Jun 2012 03:43:21 +0000 (03:43 +0000)]
Test fix after r120521.

* webarchive/resources/dump-webarchive.js:
* webarchive/test-duplicate-resources-expected.webarchive:
* webarchive/test-script-src-expected.webarchive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse testRunner instead of layoutTestController in fast/doctypes, dom, dynamic, encodi...
rniwa@webkit.org [Wed, 20 Jun 2012 03:28:42 +0000 (03:28 +0000)]
Use testRunner instead of layoutTestController in fast/doctypes, dom, dynamic, encoding, events, eventsource, and exclusions tests
https://bugs.webkit.org/show_bug.cgi?id=89438

Reviewed by Tony Chang.

* fast/doctypes/005-case-preserving.html:
* fast/doctypes/doctype-after-comment.html:
* fast/doctypes/doctype-at-end.html:
* fast/doctypes/doctype-in-element.html:
* fast/doctypes/doctype-parsing.html:
* fast/doctypes/html-doctype.html:
* fast/doctypes/xhtml-with-xhtmlmp-doctype.xhtml:
* fast/doctypes/xml-doctype.xhtml:
* fast/dom/:
* fast/dynamic/5872671.html:
* fast/dynamic/ancestor-to-absolute.html:
* fast/dynamic/checkbox-selection-crash.html:
* fast/dynamic/containing-block-change.html:
* fast/dynamic/crash-generated-counter.html:
* fast/dynamic/crash-generated-image.html:
* fast/dynamic/crash-generated-quote.html:
* fast/dynamic/crash-generated-text.html:
* fast/dynamic/crash-paint-no-documentElement-renderer.html-disabled:
* fast/dynamic/float-remove-above-line-2.html:
* fast/dynamic/float-remove-above-line.html:
* fast/dynamic/hover-before-position-after-style-change.html:
* fast/dynamic/hover-before-position-after-style-change2.html:
* fast/dynamic/hover-style-recalc-crash.html:
* fast/dynamic/hovered-detach.html:
* fast/dynamic/inline-to-block-crash.html:
* fast/dynamic/insertAdjacentElement.html:
* fast/dynamic/insertAdjacentHTML-allowed-parents.html:
* fast/dynamic/insertAdjacentHTML.html:
* fast/dynamic/insertAdjacentText.html:
* fast/dynamic/jQuery-animation-crash.html:
* fast/dynamic/layer-hit-test-crash.html:
* fast/dynamic/layer-no-longer-paginated.html:
* fast/dynamic/outerHTML-no-element.html:
* fast/dynamic/paused-event-dispatch.html:
* fast/dynamic/position-absolute-to-fixed-crash.html:
* fast/dynamic/position-change-layout.html:
* fast/dynamic/recursive-layout.html:
* fast/dynamic/style-access-late-stylesheet-load.html:
* fast/dynamic/subtree-common-root.html:
* fast/dynamic/subtree-table-cell-height.html:
* fast/dynamic/subtree-unrooted.html:
* fast/encoding/:
* fast/events/:
* platform/chromium/fast/events/drag-downloadURL.html:
* platform/chromium/fast/events/intercept-postmessage.html:
* platform/chromium/fast/events/rtl-scrollbar.html:
* platform/gtk/fast/events/event-sender-metakey.html:
* platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk.html:
* platform/mac/fast/dom/character-index-for-point.html:
* platform/mac/fast/dom/objc-wrapper-identity.html:
* platform/mac/fast/dom/wrapper-classes-objc.html:
* platform/mac/fast/dom/wrapper-round-tripping.html:
* platform/mac/fast/events/objc-event-api.html:
* platform/mac/fast/events/objc-keyboard-event-creation.html:
* platform/qt/fast/events/event-sender-keydown-frame.html:
* platform/win/fast/events/alt-numpad.html:
* platform/win/fast/events/alt-space-scroll.html:
* platform/win/fast/events/double-dead-char.html:
* platform/win/fast/events/keyLocation-numpad.html:
* platform/win/fast/events/panScroll-correct-direction.html:
* platform/win/fast/events/panScroll-event-fired.html:
* platform/win/fast/events/panScroll-image-no-scroll.html:
* platform/win/fast/events/panScroll-imageMap-href-no-scroll.html:
* platform/win/fast/events/panScroll-imageMap-noHref-scroll.html:
* platform/win/fast/events/panScroll-nested-divs.html:
* platform/win/fast/events/panScroll-no-iframe-jump.html:
* platform/win/fast/events/panScroll-preventDefault.html:
* platform/win/fast/events/script-tests/context-click-events.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPass ScriptValue by const ref where possible
adamk@chromium.org [Wed, 20 Jun 2012 03:27:27 +0000 (03:27 +0000)]
Pass ScriptValue by const ref where possible
https://bugs.webkit.org/show_bug.cgi?id=89531

Reviewed by Kentaro Hara.

Previously ScriptValue was sometimes passed by value, sometimes by const ref.

For consistency and optimality, pass by const ref everywhere (except where
ScriptValue is returned from non-accessor methods).

No new tests, no change in behavior.

* bindings/js/ScriptFunctionCall.h:
(ScriptCallback):
* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::getHeapObjectId):
* bindings/js/ScriptProfiler.h:
(ScriptProfiler):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::setException):
* bindings/js/WorkerScriptController.h:
(WorkerScriptController):
* bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptCallback::ScriptCallback):
* bindings/v8/ScriptFunctionCall.h:
(ScriptCallback):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::getHeapObjectId):
(WebCore):
* bindings/v8/ScriptProfiler.h:
(ScriptProfiler):
* bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::operator!=):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::setException):
* bindings/v8/WorkerScriptController.h:
(WorkerScriptController):
* css/MediaQueryListListener.h:
(WebCore::MediaQueryListListener::create):
(WebCore::MediaQueryListListener::MediaQueryListListener):
* dom/CustomEvent.cpp:
(WebCore::CustomEvent::initCustomEvent):
* dom/CustomEvent.h:
(CustomEvent):
(WebCore::CustomEvent::detail):
* dom/MessageEvent.h:
(WebCore::MessageEvent::dataAsScriptValue):
* dom/PopStateEvent.h:
(WebCore::PopStateEvent::state):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::wrapObject):
* inspector/InjectedScript.h:
(InjectedScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] 0.11 video-sink
philn@webkit.org [Wed, 20 Jun 2012 02:25:14 +0000 (02:25 +0000)]
[GStreamer] 0.11 video-sink
https://bugs.webkit.org/show_bug.cgi?id=77087

Reviewed by Martin Robinson.

* configure.ac: Fix required gstreamer 0.11 version

Source/WebCore:

Port the video sink to GStreamer 0.11 APIs. There is no change in
functionality compared to 0.10, for now.

* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(webkitGetVideoSizeAndFormatFromCaps):
(webkitGstCreateBuffer):
* platform/graphics/gstreamer/GStreamerVersioning.h:
(WebCore):
* platform/graphics/gstreamer/ImageGStreamer.h:
(WebCore::ImageGStreamer::createImage):
(WebCore::ImageGStreamer::setCropRect):
(WebCore::ImageGStreamer::rect):
(ImageGStreamer):
* platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer):
* platform/graphics/gstreamer/ImageGStreamerQt.cpp:
(ImageGStreamer::ImageGStreamer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(_WebKitVideoSinkPrivate):
(webkitVideoSinkRender):
(webkitVideoSinkProposeAllocation):
(webkit_video_sink_class_init):
* platform/graphics/gstreamer/VideoSinkGStreamer.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd monitor profile support for Win
commit-queue@webkit.org [Wed, 20 Jun 2012 02:15:00 +0000 (02:15 +0000)]
Add monitor profile support for Win
https://bugs.webkit.org/show_bug.cgi?id=88565

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-19
Reviewed by Eric Seidel.

Source/Platform:

* chromium/public/Platform.h:
(Platform):
(WebKit::Platform::screenColorProfile):

Source/WebCore:

Tests: fast/images/jpeg-with-color-profile.html
fast/images/png-with-color-profile.html. Also covered by numerous
layout tests.

* WebCore.gyp/WebCore.gyp:
* platform/PlatformScreen.h:
(WebCore):
* platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenColorProfile):
(WebCore):
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenColorProfile):
(WebCore):
* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenColorProfile):
(WebCore):
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenColorProfile):
(WebCore):
* platform/image-decoders/ImageDecoder.h:
(ImageFrame):
(ImageDecoder):
(WebCore::ImageDecoder::qcmsOutputDeviceProfile):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(turboSwizzled):
(colorSpaceHasAlpha):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic fails to rebaseline tests with MISSING results
abarth@webkit.org [Wed, 20 Jun 2012 02:12:29 +0000 (02:12 +0000)]
garden-o-matic fails to rebaseline tests with MISSING results
https://bugs.webkit.org/show_bug.cgi?id=89521

Reviewed by Kenneth Russell.

If the bots report "MISSING", we should try to find PNG and TXT results on the server.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosvn.delete_list fails to delete empty parent directories
abarth@webkit.org [Wed, 20 Jun 2012 01:46:34 +0000 (01:46 +0000)]
svn.delete_list fails to delete empty parent directories
https://bugs.webkit.org/show_bug.cgi?id=89520

Reviewed by Dirk Pranke.

These functions were calling scm.delete and scm.add, which already
delete the parent directory. We'd get an exception when we tried to
delete the parent directory again.

* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN._add_parent_directories):
(SVN._delete_parent_directories):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSC should be able to show disassembly for all generated JIT code
fpizlo@apple.com [Wed, 20 Jun 2012 01:33:30 +0000 (01:33 +0000)]
JSC should be able to show disassembly for all generated JIT code
https://bugs.webkit.org/show_bug.cgi?id=89536

Reviewed by Gavin Barraclough.

Now instead of doing linkBuffer.finalizeCode(), you do
FINALIZE_CODE(linkBuffer, (... explanation ...)). FINALIZE_CODE() then
prints your explanation and the disassembled code, if
Options::showDisassembly is set to true.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/LinkBuffer.cpp: Added.
(JSC):
(JSC::LinkBuffer::finalizeCodeWithoutDisassembly):
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::performFinalization):
(JSC::LinkBuffer::dumpLinkStatistics):
(JSC::LinkBuffer::dumpCode):
* assembler/LinkBuffer.h:
(LinkBuffer):
(JSC):
* assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodeRef::tryToDisassemble):
(MacroAssemblerCodeRef):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
* dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
* disassembler/Disassembler.h:
(JSC):
(JSC::tryToDisassemble):
* disassembler/UDis86Disassembler.cpp:
(JSC::tryToDisassemble):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITCode.h:
(JSC::JITCode::tryToDisassemble):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
* llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):
* runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
* runtime/Options.h:
(Options):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: Simplify fetch_bugs_matching_search()
commit-queue@webkit.org [Wed, 20 Jun 2012 01:31:29 +0000 (01:31 +0000)]
webkitpy: Simplify fetch_bugs_matching_search()
https://bugs.webkit.org/show_bug.cgi?id=89497

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-19
Reviewed by Adam Barth.

Removed parameter with default value. It's not being used
and the handling of the parameter was wrong. Saves a check.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.fetch_bugs_matching_search):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.fetch_bugs_matching_search):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the failing expected results added in
jhoneycutt@apple.com [Wed, 20 Jun 2012 01:29:26 +0000 (01:29 +0000)]
Remove the failing expected results added in
http://trac.webkit.org/changeset/119190 now that these tests pass.

Rubber-stamped by Jessie Berlin.

* platform/win/fast/frames/frame-set-scaling-hit-expected.txt: Removed.
* platform/win/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Removed.
* platform/win/fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Removed.
* platform/win/fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Fix issue where a callback got a null calling context
arv@chromium.org [Wed, 20 Jun 2012 01:04:00 +0000 (01:04 +0000)]
[V8] Fix issue where a callback got a null calling context
https://bugs.webkit.org/show_bug.cgi?id=89532

Reviewed by Kentaro Hara.

Source/WebCore:

Test: fast/dom/Window/post-message-crash.html

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback): Check the calling context and throw a type error (like JSC) if it is null.

LayoutTests:

* fast/dom/Window/post-message-crash-expected.txt: Added.
* fast/dom/Window/post-message-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor RenderFlexibleBox terminology to use grow/shrink instead of positive/negative
tony@chromium.org [Wed, 20 Jun 2012 00:40:39 +0000 (00:40 +0000)]
Refactor RenderFlexibleBox terminology to use grow/shrink instead of positive/negative
https://bugs.webkit.org/show_bug.cgi?id=89493

Reviewed by Eric Seidel.

The spec stopped referring to positive and negative flex and now
talks about flex grow and flex shrink. Also, the preferred size is
now known as the flex basis. Make the code match the terms used in
the spec. http://dev.w3.org/csswg/css3-flexbox/

This will also make it easier to split flex into long hand notation
(flex-grow, flex-shrink and flex-basis).

No new tests, covered by existing tests.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::PropertyWrapperFlex::equals):
(WebCore::PropertyWrapperFlex::blend):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flexBasisForChild):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
(WebCore::RenderFlexibleBox::freezeViolations):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
* rendering/RenderFlexibleBox.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:
(StyleFlexibleBoxData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectations update.
kbr@google.com [Wed, 20 Jun 2012 00:25:40 +0000 (00:25 +0000)]
[Chromium] Unreviewed test expectations update.

* platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/resize-while-save-active-expected.txt: Removed.
* platform/chromium/TestExpectations:
    Referenced bugs 89529 and 89534.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Mac] REGRESSION(r120742): It broke the build
mhahnenberg@apple.com [Wed, 20 Jun 2012 00:20:30 +0000 (00:20 +0000)]
[Qt][Mac] REGRESSION(r120742): It broke the build
https://bugs.webkit.org/show_bug.cgi?id=89516

Reviewed by Geoffrey Garen.

Removing GCActivityCallbackCF.cpp because it doesn't mesh well with cross-platform
code on Darwin (e.g. Qt). We now use plain ol' vanilla ifdefs to handle platforms
without CF support. These if-defs will probably disappear in the future when we
use cross-platform timers in HeapTimer.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/GCActivityCallback.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::cancel):
* runtime/GCActivityCallbackCF.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: remove unneeded imports in layout_tests/port/chromium.py
dpranke@chromium.org [Wed, 20 Jun 2012 00:15:35 +0000 (00:15 +0000)]
webkitpy: remove unneeded imports in layout_tests/port/chromium.py
https://bugs.webkit.org/show_bug.cgi?id=89522

Reviewed by Eric Seidel.

They were no longer being used. No tests necessary.

* Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Make DOMFileSystem selectively structure clonable so it can be the...
commit-queue@webkit.org [Wed, 20 Jun 2012 00:09:05 +0000 (00:09 +0000)]
Source/WebCore: Make DOMFileSystem selectively structure clonable so it can be the body of a web intent.
https://bugs.webkit.org/show_bug.cgi?id=88267

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2012-06-19
Reviewed by David Levin.

This functionality will allow FileSystem API objects to be dispatched to
web content in order to enable, for instance, an intent notifying web
content that a particular filesystem has been mounted by the local
system. The goal at this point is not to enable across-the-board
clonability, but just for handling the particular use case.

* bindings/v8/SerializedScriptValue.cpp:
(WebCore::V8ObjectMap::Writer::writeDOMFileSystem):
(WebCore::V8ObjectMap::Serializer::writeDOMFileSystem):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Reader::readDOMFileSystem):

LayoutTests: Add filesystem regression test to check that the filesystem object is
not serializable as created by javascript.
https://bugs.webkit.org/show_bug.cgi?id=88267

Patch by Greg Billock <gbillock@google.com> on 2012-06-19
Reviewed by David Levin.

* fast/filesystem/filesystem-unserializable-expected.html: Added.
* fast/filesystem/filesystem-unserializable.html: Added.
* fast/filesystem/script-tests/filesystem-unserializable.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r120772.
kbr@google.com [Wed, 20 Jun 2012 00:07:03 +0000 (00:07 +0000)]
Unreviewed, rolling out r120772.
http://trac.webkit.org/changeset/120772
https://bugs.webkit.org/show_bug.cgi?id=89503

Broke build on Chromium Mac

Source/WebCore:

* platform/graphics/chromium/AnimationTranslationUtil.h:
(WebCore):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
* platform/graphics/chromium/Canvas2DLayerBridge.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/DrawingBufferChromium.cpp:
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore):
* platform/graphics/chromium/ImageLayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/ManagedTexture.cpp:
* platform/graphics/chromium/ProgramBinding.h:
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/TextureCopier.cpp:
* platform/graphics/chromium/TextureLayerChromium.cpp:
* platform/graphics/chromium/TextureManager.cpp:
* platform/graphics/chromium/TiledLayerChromium.cpp:
* platform/graphics/chromium/TiledLayerChromium.h:
(WebCore):
* platform/graphics/chromium/cc/CCActiveAnimation.h:
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
* platform/graphics/chromium/cc/CCFontAtlas.cpp:
* platform/graphics/chromium/cc/CCFrameRateController.cpp:
* platform/graphics/chromium/cc/CCFrameRateController.h:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerAnimationController.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
* platform/graphics/chromium/cc/CCProxy.cpp:
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
* platform/graphics/chromium/cc/CCRenderPass.h:
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
* platform/graphics/chromium/cc/CCRenderSurface.h:
* platform/graphics/chromium/cc/CCRenderer.h:
(WebCore):
* platform/graphics/chromium/cc/CCScopedThreadProxy.h:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
* platform/graphics/chromium/cc/CCTimer.cpp:
* platform/graphics/chromium/cc/CCTimer.h:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

Source/WebKit/chromium:

* src/WebCompositorImpl.cpp:
* src/WebLayerTreeView.cpp:
* tests/CCLayerTestCommon.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/CCOcclusionTrackerTest.cpp:
* tests/CCQuadCullerTest.cpp:
* tests/CCTiledLayerImplTest.cpp:
* tests/ImageLayerChromiumTest.cpp:
* tests/LayerRendererChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Should check the return value of fromUTF8() before executing the script.
commit-queue@webkit.org [Tue, 19 Jun 2012 23:50:32 +0000 (23:50 +0000)]
[BlackBerry] Should check the return value of fromUTF8() before executing the script.
https://bugs.webkit.org/show_bug.cgi?id=89500

Patch by Yong Li <yoli@rim.com> on 2012-06-19
Reviewed by Rob Buis.
PR# 166623.

WebPagePrivate::executeJavaScript() should check the return value of fromUTF8()
before executing the script to avoid potential crash on invalid script source.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::executeJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkipping failing tests to keep the bots green. Filed
bdakin@apple.com [Tue, 19 Jun 2012 23:47:25 +0000 (23:47 +0000)]
Skipping failing tests to keep the bots green. Filed
https://bugs.webkit.org/show_bug.cgi?id=89528 to track fixing the
real problem.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove redundant #includes in compositor
commit-queue@webkit.org [Tue, 19 Jun 2012 23:46:26 +0000 (23:46 +0000)]
[Chromium] Remove redundant #includes in compositor
https://bugs.webkit.org/show_bug.cgi?id=89503

Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-19
Reviewed by Adrienne Walker.

Source/WebCore:

Removed some redundant #includes to clarify dependency
picture. Some 90 #includes removed, some 50 less disruptive
#includes added. This brings the number of class dependencies to
902 from 1383.

No new tests are required, as this is only affects compile-time behavior.

* platform/graphics/chromium/AnimationTranslationUtil.h:
(WebCore):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
* platform/graphics/chromium/Canvas2DLayerBridge.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/DrawingBufferChromium.cpp:
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/ManagedTexture.cpp:
* platform/graphics/chromium/ProgramBinding.h:
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/TextureCopier.cpp:
* platform/graphics/chromium/TextureLayerChromium.cpp:
* platform/graphics/chromium/TextureManager.cpp:
* platform/graphics/chromium/TiledLayerChromium.cpp:
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCActiveAnimation.h:
(WebCore):
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
* platform/graphics/chromium/cc/CCFontAtlas.cpp:
* platform/graphics/chromium/cc/CCFrameRateController.cpp:
* platform/graphics/chromium/cc/CCFrameRateController.h:
(WebCore):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerAnimationController.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(WebCore):
* platform/graphics/chromium/cc/CCProxy.cpp:
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
* platform/graphics/chromium/cc/CCRenderSurface.h:
* platform/graphics/chromium/cc/CCRenderer.h:
* platform/graphics/chromium/cc/CCScopedThreadProxy.h:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore):
* platform/graphics/chromium/cc/CCTimer.cpp:
* platform/graphics/chromium/cc/CCTimer.h:
(WebCore):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

Source/WebKit/chromium:

Minor adjustments to #include statements to remove
dependencies. No new tests.

* src/WebCompositorImpl.cpp:
* src/WebLayerTreeView.cpp:
* tests/CCLayerTestCommon.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/CCOcclusionTrackerTest.cpp:
* tests/CCQuadCullerTest.cpp:
* tests/CCTiledLayerImplTest.cpp:
* tests/ImageLayerChromiumTest.cpp:
* tests/LayerRendererChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAlign RenderLayer's descendant dependent flags semantics
jchaffraix@webkit.org [Tue, 19 Jun 2012 23:39:16 +0000 (23:39 +0000)]
Align RenderLayer's descendant dependent flags semantics
https://bugs.webkit.org/show_bug.cgi?id=89241

Reviewed by Simon Fraser.

Refactoring only, covered by existing tests.

This change aligns the naming and implementation of the different descendant
dependent flags. While aligning, I found some bugs (inefficiencies) with how
the visible descendant flags was computed.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setHasVisibleContent):
Changed this method to not take a boolean as every callers was passing 'true'.
Reworked the logic under this assumption.

(WebCore::RenderLayer::dirtyVisibleContentStatus):
Updated after the following renaming.

(WebCore::RenderLayer::dirtyAncestorChainVisibleDescendantStatus):
Renamed this function from dirtyVisibleDescendantStatus to match the hasSelfPaintingLayer
naming and implementation.

(WebCore::RenderLayer::setAncestorChainHasVisibleDescendant):
Added this function to factor the visible descendant setting out of defunct childVisibilityChanged.
Also improved the efficiency of the function by clearing the dirty flag as it goes up (an unnoticed bug).

(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
Updated to use the new functions lieu of childVisibilityChanged.
* rendering/RenderLayer.h:
(RenderLayer::childVisibilityChanged):
Removed this function as it wasn't adding much and it's a lot more clear to call
dirtyAncestorChainVisibleDescendantStatus / setAncestorChainHasVisibleDescendant.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Updated those callers after removing the boolean parameter from setHasVisibleContent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Extract InjectedScriptBase class from the InjectedScript
pfeldman@chromium.org [Tue, 19 Jun 2012 23:21:03 +0000 (23:21 +0000)]
Web Inspector: Extract InjectedScriptBase class from the InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=89107

Extract methods from the InjectedScript that do not depend on
the concrete InjectedScriptSource.js implementation.

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-19
Reviewed by Pavel Feldman.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::nodeForObjectId):
(WebCore::InjectedScript::releaseObject):
(WebCore::InjectedScript::wrapCallFrames):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapSerializedObject):
(WebCore::InjectedScript::findObjectById):
(WebCore::InjectedScript::inspectNode):
(WebCore::InjectedScript::releaseObjectGroup):
(WebCore::InjectedScript::nodeAsScriptValue):
* inspector/InjectedScript.h:
(WebCore):
(InjectedScript):
* inspector/InjectedScriptBase.cpp: Added.
(WebCore):
(WebCore::InjectedScriptBase::InjectedScriptBase):
(WebCore::InjectedScriptBase::canAccessInspectedWindow):
(WebCore::InjectedScriptBase::injectedScriptObject):
(WebCore::InjectedScriptBase::callFunctionWithEvalEnabled):
(WebCore::InjectedScriptBase::makeCall):
(WebCore::InjectedScriptBase::makeEvalCall):
* inspector/InjectedScriptBase.h: Copied from Source/WebCore/bindings/js/ScriptObject.h.
(WebCore):
(InjectedScriptBase):
(WebCore::InjectedScriptBase::~InjectedScriptBase):
(WebCore::InjectedScriptBase::hasNoValue):
(WebCore::InjectedScriptBase::scriptState):
* inspector/InspectorAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium][Mac] Layout Test ietestcenter/css3/bordersbackgrounds/border-radius-clip...
kbr@google.com [Tue, 19 Jun 2012 23:19:19 +0000 (23:19 +0000)]
[Chromium][Mac] Layout Test ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm is failing
https://bugs.webkit.org/show_bug.cgi?id=89411

Unreviewed test expectations update generated by garden-o-matic.

* ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt.
* platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Removed.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/chromium/TestExpectations:
    Removed IMAGE MISSING expectation for this test.
* platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG CFA forgets to notify subsequent phases of found constants if it proves LogicalNo...
fpizlo@apple.com [Tue, 19 Jun 2012 23:10:12 +0000 (23:10 +0000)]
DFG CFA forgets to notify subsequent phases of found constants if it proves LogicalNot to be a constant
https://bugs.webkit.org/show_bug.cgi?id=89511
<rdar://problem/11700089>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):

LayoutTests:

* fast/js/dfg-constant-fold-logical-not-branch-expected.txt: Added.
* fast/js/dfg-constant-fold-logical-not-branch.html: Added.
* fast/js/script-tests/dfg-constant-fold-logical-not-branch.js: Added.
(foo1):
(foo2):
(Stuff):
(Stuff.prototype.thingy):
(Stuff.prototype.otherThingy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120767 268f45cc-cd09-0410-ab3c-d52691b4dbfc