lars [Wed, 24 Oct 2007 12:33:02 +0000 (12:33 +0000)]
add another command.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:58 +0000 (12:32 +0000)]
convert the text to be text only, and fix it up a little so it doesn't depend on specific font metrics anymore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:55 +0000 (12:32 +0000)]
remove some notImplemented() warnings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:53 +0000 (12:32 +0000)]
add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:49 +0000 (12:32 +0000)]
remove a stupid notImplemented() warning and implement PasteBoad::clear().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:47 +0000 (12:32 +0000)]
allow paste from DOM so we pass more test cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:44 +0000 (12:32 +0000)]
implement Pasteboard::documentFragment(), and fix a mem leak.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:40 +0000 (12:32 +0000)]
implement eventSender.keyDown().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:36 +0000 (12:32 +0000)]
some changes to the way JS values are converted to Qt values in the script bindings. Added support for converting JS arrays into QStringList's.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:34 +0000 (12:32 +0000)]
Simplify the PlatformKeyEvent constructor. No need to have an extra boolean for isKeyUp in there, as the QKeyEvent has the information.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:31 +0000 (12:32 +0000)]
some smaller fixes to the editing support in DRT. Makes another few tests pass.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:27 +0000 (12:32 +0000)]
explicitly add some tests that currently cause DRT to hang.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:25 +0000 (12:32 +0000)]
first bit of implementation for the textinputcontroller.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:21 +0000 (12:32 +0000)]
implemented support for most editing shortcuts to make contentEditable usable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:19 +0000 (12:32 +0000)]
no need to call setIsActive ourselves on the frame, as the focus controller does it for us.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:17 +0000 (12:32 +0000)]
make the man webpage believe it has focus, so the editing tests work correctly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:13 +0000 (12:32 +0000)]
implement layoutTestController.dumpEditingCallbacks() correctly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:09 +0000 (12:32 +0000)]
use the new QTextBoundaryFinder class in Qt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:05 +0000 (12:32 +0000)]
Implement support for testing editing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 24 Oct 2007 08:53:45 +0000 (08:53 +0000)]
Remove old relation method, replace with specialised LessThan and lessThenEq functions for a 0.5-0.6% improvement in SunSpider
Reviewed by Darin
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 24 Oct 2007 08:50:12 +0000 (08:50 +0000)]
2007-10-24 Eric Seidel <eric@webkit.org>
Reviewed by darin.
* kjs/nodes.h:
(KJS::ImmediateNumberNode::): Fix ASSERT correctness (and debug build!)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Oct 2007 08:21:21 +0000 (08:21 +0000)]
Reviewed by Eric.
* kjs/object.cpp: (KJS::JSObject::defaultValue): Get rid of a little
Identifier ref/deref for what SunSpider claims is a 0.4% speedup.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Oct 2007 08:14:32 +0000 (08:14 +0000)]
Reviewed by Maciej.
- separate out the code to create a hash table the first time from the code
to rehash
SunSpider claims this was a 0.7% speedup.
* kjs/property_map.cpp:
(KJS::PropertyMap::expand): Changed to call either createTable or rehash.
(KJS::PropertyMap::createTable): Added. For the case where we had no table.
(KJS::PropertyMap::rehash): Removed code needed only in the case where we
had no table.
* kjs/property_map.h: Added createTable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 24 Oct 2007 08:06:03 +0000 (08:06 +0000)]
2007-10-24 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Add ImmediateNumberNode to hold a JSValue* instead of a double for numbers
which can be represented by JSImmediate.
* kjs/grammar.y:
* kjs/nodes.cpp:
(KJS::NumberNode::evaluate):
(KJS::ImmediateNumberNode::evaluate):
* kjs/nodes.h:
(KJS::Node::):
(KJS::ImmediateNumberNode::):
* kjs/nodes2string.cpp:
(ImmediateNumberNode::streamTo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Oct 2007 08:03:02 +0000 (08:03 +0000)]
JavaScriptCore:
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15657
change static hash tables to use powers of two for speed
Seems to give 0.7% SunSpider speedup.
* kjs/create_hash_table: Updated to generate new format.
* kjs/lookup.cpp:
(KJS::keysMatch): Took out unneeded typecast.
(KJS::findEntry): Updated to expect table type 3 -- changed the printf to a plain old assert.
Replaced the modulus with a bit mask.
(KJS::Lookup::findEntry): Get the hash directly, since we know identifiers already have computed
their hash -- saves a branch.
(KJS::Lookup::find): Ditto.
* kjs/lookup.h: Changed attr from 2-byte value to one-byte value. Replaced hashSize with hashSizeMask.
WebCore:
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15657
change static hash tables to use powers of two for speed
* bindings/scripts/CodeGeneratorJS.pm: Updated to generate new format.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 24 Oct 2007 07:59:21 +0000 (07:59 +0000)]
Reviewed by Darin.
- remove KJS_CHECKEXCEPTIONs in places where exceptions can't happen for 0.6% SunSpider speedup
* kjs/nodes.cpp:
(KJS::DoWhileNode::execute):
(KJS::WhileNode::execute):
(KJS::ForNode::execute):
(KJS::ForInNode::execute):
(KJS::SourceElementsNode::execute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Oct 2007 07:41:45 +0000 (07:41 +0000)]
Reviewed by Eric.
* sunspider: Open the profile in shark after completing a run.
* sunspider-compare-results: Tiny perl tweaks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 24 Oct 2007 07:40:29 +0000 (07:40 +0000)]
Fix pathByAppendingComponent for the Qt port.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 24 Oct 2007 06:52:51 +0000 (06:52 +0000)]
Make repainting work with transforms.
Reviewed by John Sullivan
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeAbsoluteRepaintRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Oct 2007 06:41:16 +0000 (06:41 +0000)]
Ignore files generated by the make-hosted script.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Oct 2007 06:19:39 +0000 (06:19 +0000)]
Reviewed by Maciej.
* kjs/JSImmediate.h: (KJS::JSImmediate::getUInt32):
Changed an && to an & for a 1% gain in SunSpider.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Wed, 24 Oct 2007 04:40:58 +0000 (04:40 +0000)]
2007-10-23 Alp Toker <alp@atoker.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14412
[GDK] Clipboard support
Initial clipboard implementation for the GTK+ port.
* platform/gtk/ClipboardGtk.cpp:
(WebCore::Editor::newGeneralClipboard):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::generalPasteboard):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::~Pasteboard):
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::plainText):
* platform/gtk/TemporaryLinkStubs.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 24 Oct 2007 04:35:26 +0000 (04:35 +0000)]
Reviewed by Adam.
Fixes the Network panel so that it refreshes as needed.
* page/inspector/ConsolePanel.js: Call the base class show() and hide() first.
* page/inspector/NetworkPanel.js: Add refreshNeeded and refreshIfNeeded back. Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 24 Oct 2007 03:47:16 +0000 (03:47 +0000)]
Check for null BSTR that can be passed to the UIDelegate methods
from javascript null and undefined. Fixes a failing test case on
Windows (fast/dom/Window/alert-undefined.html)
Reviewed by Eric Seidel.
* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::runJavaScriptAlertPanelWithMessage):
(UIDelegate::runJavaScriptConfirmPanelWithMessage):
(UIDelegate::runJavaScriptTextInputPanelWithPrompt):
(UIDelegate::webViewAddMessageToConsole):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Wed, 24 Oct 2007 02:15:32 +0000 (02:15 +0000)]
Rolled out r26941 because it of layout test failures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 24 Oct 2007 02:01:53 +0000 (02:01 +0000)]
Reduce branching in implementations of some operator implementations, yielding 1.3% boost to SunSpider.
Reviewed by Maciej
* kjs/nodes.cpp:
(KJS::MultNode::evaluate):
(KJS::DivNode::evaluate):
(KJS::ModNode::evaluate):
(KJS::add):
(KJS::sub):
(KJS::AddNode::evaluate):
(KJS::SubNode::evaluate):
(KJS::valueForReadModifyAssignment):
* kjs/operations.cpp:
* kjs/operations.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 24 Oct 2007 01:59:37 +0000 (01:59 +0000)]
Fixing an accidental change made in r25484.
* editing/pasteboard/quirks-mode-br-1.html:
* platform/mac/editing/pasteboard/quirks-mode-br-1-expected.checksum:
* platform/mac/editing/pasteboard/quirks-mode-br-1-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 24 Oct 2007 01:56:56 +0000 (01:56 +0000)]
Reviewed by Oliver Hunt.
<rdar://problem/
5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time
* platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
* platform/mac/editing/input/text-input-controller-expected.txt:
* platform/mac/editing/input/wrapped-line-char-rect-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 24 Oct 2007 01:53:53 +0000 (01:53 +0000)]
Reviewed by Oliver Hunt.
<rdar://problem/
5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time
No layout test for now because I'm having trouble getting Undo during a layout
test to only undo the last Undo step, and I want to write a test that fails
without the code change.
* editing/Editor.cpp:
(WebCore::Editor::confirmComposition): When we replace the previous composition,
delete it with a sub-command of the command used to insert the new composition,
instead of with a separate command. No new code was added because insertText
already deletes the current selection.
(WebCore::Editor::setComposition): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Wed, 24 Oct 2007 01:51:04 +0000 (01:51 +0000)]
Reviewed by Eric Seidel.
- fix http://bugs.webkit.org/show_bug.cgi?id=15405
ASSERTION FAILED: d->m_view && !d->m_view->needsLayout() in Frame::Paint
Calling updateWidget() during attach() led to arbitrary (plugin and resource load delegate)
code execution under attach(). The fix is to use the mechanism that's already in place for
deferring updateWidget() until after layout.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::attach): Replaced call to updateWidget() with call to updateWidgetSoon()
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::attach): Ditto.
* manual-tests/paint-during-plugin-attach.html: Added.
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidgetSoon): Added this function that schedules the
updateWidget() call for after the next layout.
* rendering/RenderPartObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 24 Oct 2007 01:36:05 +0000 (01:36 +0000)]
Make the WebNotificationCenter work with null (wildcard) and specific
observed objects, matching NSNotificationCenter.
- Removes the ObserverKey, ObserverHash, and ObserverKeyTraits as we now
hash against the notification name only and check the object on notification
posting.
- Use OwnPtr for the WebNotificationCenterPrivate member variable.
Reviewed by Adam Roben.
* WebNotificationCenter.cpp:
(WebNotificationCenter::WebNotificationCenter):
(WebNotificationCenter::~WebNotificationCenter):
(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::postNotification):
(WebNotificationCenter::postNotificationName):
(WebNotificationCenter::removeObserver):
* WebNotificationCenter.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 24 Oct 2007 01:30:00 +0000 (01:30 +0000)]
Fix the behavior of pathByAppendingComponent when path is empty
We now use the Windows Shell API function PathAppendW instead of
rolling our own broken implementation.
Reviewed by Anders.
* platform/win/FileSystemWin.cpp:
(WebCore::pathByAppendingComponent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 24 Oct 2007 00:56:15 +0000 (00:56 +0000)]
Reviewed by Darin.
Don't print a massive pile of setenvs from tools that automatically build testkjs.
* Scripts/build-testkjs:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 24 Oct 2007 00:40:35 +0000 (00:40 +0000)]
SunSpider:
Reviewed by Darin.
- Don't hardcode my path to testkjs
* sunspider-compare-results:
WebKitTools:
Reviewed by Darin.
- add wrapper that finds the right copy of testkjs
* Scripts/sunspider-compare-results: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 24 Oct 2007 00:12:28 +0000 (00:12 +0000)]
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/
5543228> CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::HTMLInputElement::defaultEventHandler + 872
Test: fast/forms/textfield-onchange-deletion.html
* html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
Refetch the renderer since arbitrary JS code run during onchange can do anything, including destroying it.
LayoutTests:
Reviewed by Darin.
Test for <rdar://problem/
5543228> CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::HTMLInputElement::defaultEventHandler + 872
* fast/forms/textfield-onchange-deletion-expected.txt: Added.
* fast/forms/textfield-onchange-deletion.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 24 Oct 2007 00:08:06 +0000 (00:08 +0000)]
Reviewed by Sam Weinig.
- Made seperate files for the various classes in ResourcePanel.js.
- Broke up ResourcePanel.js and created seperate panel classes for different resource types.
- Moved View code down to the Panel base-class.
- Reduced code duplication in DatabasePanel.js by sub-classing from the new ResourcePanel.
* page/inspector/DatabasePanel.js:
* page/inspector/DocumentPanel.js: Added.
* page/inspector/FontPanel.js: Added.
* page/inspector/ImagePanel.js: Added.
* page/inspector/Panel.js: Added.
* page/inspector/PropertiesSection.js: Added.
* page/inspector/Resource.js:
* page/inspector/ResourcePanel.js:
* page/inspector/SidebarPane.js: Added.
* page/inspector/SourcePanel.js: Added.
* page/inspector/inspector.css:
* page/inspector/inspector.html:
* page/inspector/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 23 Oct 2007 23:47:50 +0000 (23:47 +0000)]
Correct the version #if check.
* platform/sql/SQLDatabase.cpp:
(WebCore::SQLDatabase::authorizerFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
honeycutt [Tue, 23 Oct 2007 23:16:06 +0000 (23:16 +0000)]
2007-10-23 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
<rdar://
5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page
It is possible to load Mozilla's Java plugin instead of our own, which
can lead to a crash. The fix is to prefer plugins in our own Plugins
directory when searching for a plugin.
* plugins/win/PluginDatabaseWin.cpp:
(WebCore::safariPluginsPath): Return the path to our own Plugins
directory
(WebCore::PluginDatabaseWin::defaultPluginPaths): Use new method
safariPluginsPath()
(WebCore::PluginDatabaseWin::pluginForMIMEType): If the plugin's path is
our Plugins path, return this plugin. Otherwise, continue scanning the
list of plugins
(WebCore::PluginDatabaseWin::pluginForExtension): Same
* plugins/win/PluginPackageWin.h:
(WebCore::PluginPackageWin::path): Return this plugin's path
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan [Tue, 23 Oct 2007 23:14:58 +0000 (23:14 +0000)]
<rdar://problem/
5244261> SafariWin ignores cookie policy setting "never" in the preferences
Custom WebPreferences (not the shared WebPreferences) could override the cookie accept
policy setting on the default cookie storage. To fix that, I added a new method in
WebView called updateGlobalSettingsFromPreferences() to handle updating the global pref
options such as cookie accept policy, and it's only called to update changes from
the shared WebPreferences.
Use CLSID_WebPreferences and remove IID_WebPreferences.
Reviewed by Darin and Adam.
* WebPreferences.cpp:
(WebPreferences::QueryInterface):
* WebPreferences.h:
* WebView.cpp:
(WebView::updateWebCoreSettingsFromPreferences):
(WebView::updateGlobalSettingsFromPreferences):
(WebView::updateSettingsFromPreferences):
(WebView::developerExtrasEnabled):
(WebView::initWithFrame):
(WebView::onNotify):
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Tue, 23 Oct 2007 23:11:39 +0000 (23:11 +0000)]
Reviewed by Sam.
- After talking with Steve I now see that the WebKit server must be
running for DCOM to create the distributed objects, which makes sense
and currently WebKit only allows one instance to be running at a time
which avoids accidentally connecting to the wrong server
- In light of this I have removed the code for the attach box and
NotificationServer and known server names, since they are all extranious
now.
* Drosera/win/Drosera.cpp: Removed notification classes and known server
names.
(_tWinMain): Uses init instead of initUI.
(droseraWndProc): No longer creats an attach dialog box.
(Drosera::Drosera): Does the OleInitialize so COM is ready to go and
it's not manditory to call init before doing COM stuff.
(Drosera::init): calls initUI and will call attach when the
functionality exists.
(Drosera::initUI): Has changed very little.
(Drosera::attach): Changed the signature to reflect that we no longer
need the dictionary of known server names.
* Drosera/win/Drosera.h: Removed notification classes and known server
names. Also renamed and moved some functions.
* Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
* Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
headers to the resources folder.
* Drosera/win/resource.h: Removed the Attach box.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 23 Oct 2007 22:27:42 +0000 (22:27 +0000)]
Reviewed by Darin.
- Add a compare script to compare results, and improve formatting of standard results a bit.
* resources/sunspider-analyze-results.js:
* resources/sunspider-compare-results.js: Added.
* sunspider-compare-results: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Tue, 23 Oct 2007 21:25:44 +0000 (21:25 +0000)]
Separating all of the simple binary expression nodes into multiple classes
Reviewed by Maciej
Separating all of the simple (eg. non-read-modify-write) binary operators into separate classes in preparation for further JS optimisations.
Happily this produces a 0.8% to 1.0% performance increase in SunSpider with no further work.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Tue, 23 Oct 2007 19:29:03 +0000 (19:29 +0000)]
2007-10-23 Jasper Bryant-Greene <m@ni.ac.nz>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15058
Precedence fault in KeyEventGdk causes shift, control, alt etc to work incorrectly
Corrected precendence fault which was causing Shift, Alt, Control and
Meta to behave incorrectly on GTK.
Coding style fix by Alp.
* platform/gtk/KeyEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 23 Oct 2007 18:25:58 +0000 (18:25 +0000)]
Add some SVG tests to the Windows Skipped file
Reviewed by Oliver.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 23 Oct 2007 18:11:16 +0000 (18:11 +0000)]
Reviewed by Tim Hatcher.
Add resizing of the DOM view right sidebar. This allows us to actually see the values now.
* page/inspector/ResourcePanel.js:
* page/inspector/inspector.css:
* page/inspector/inspector.js:
* page/inspector/utilities.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 23 Oct 2007 15:52:26 +0000 (15:52 +0000)]
Get basic hit testing right for transforms.
Reviewed by ollliej
* platform/graphics/AffineTransform.cpp:
(WebCore::AffineTransform::mapPoint):
* platform/graphics/AffineTransform.h:
* rendering/InlineBox.cpp:
(WebCore::InlineBox::nodeAtPoint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestLayer):
* rendering/RenderLayer.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::hitTest):
* rendering/RenderObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Oct 2007 15:49:31 +0000 (15:49 +0000)]
- removed numeric results so the test is more platform-independent
* fast/js/math-expected.txt: Updated.
* fast/js/resources/math.js: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Oct 2007 14:12:30 +0000 (14:12 +0000)]
JavaScriptCore:
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=15639
fix Math.abs(0), Math.ceil(-0), and Math.floor(-0)
Test: fast/js/math.html
* kjs/math_object.cpp: (MathFuncImp::callAsFunction):
Fix abs to look at the sign bit. Add a special case for values in the range
between -0 and -1 and a special case for ceil and for -0 for floor.
LayoutTests:
Reviewed by Maciej.
- test for http://bugs.webkit.org/show_bug.cgi?id=15639
Math functions
* fast/js/math-expected.txt: Added.
* fast/js/math.html: Added.
* fast/js/resources/math.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 23 Oct 2007 12:11:13 +0000 (12:11 +0000)]
2007-10-23 Mark Rowe <mrowe@apple.com>
Build fix for Eric's build fix in r26916.
* MigrateHeaders.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 23 Oct 2007 09:44:06 +0000 (09:44 +0000)]
2007-10-23 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Fix leaks seen on TOT from new font-face code.
* ksvg2/svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace): use a stack allocated CSSProperty instead of mallocing
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 23 Oct 2007 08:33:05 +0000 (08:33 +0000)]
2007-10-23 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Sacrifice three virgin hours upon the altar of the heathen XCode gods
and pray that our build troubles are finally over. :(
* DerivedSources.make: add DOMSVGException.h
* WebCore.xcodeproj/project.pbxproj: Remove DOMSVG*Interal.h files from "Copy Generated Headers" phase. Why? Who knows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 23 Oct 2007 07:07:37 +0000 (07:07 +0000)]
Reviewed by Darin.
* resources/sunspider-analyze-results.js: Do the error range
properly, using the t-distribution instead of 1.96 (which was
based on the normal distribution).
* sunspider: Print results in a way that will be friendlier to the
soon-to-come compare mode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Oct 2007 07:00:37 +0000 (07:00 +0000)]
Reviewed by Eric.
- streamline exception handling code for a >1% speed-up of SunSpider
* kjs/nodes.cpp: Changed macros to use functions for everything that's not
part of normal execution. We'll take function call overhead when propagating
an exception or out of memory.
(KJS::createOutOfMemoryCompletion): Added.
(KJS::substitute): Use append instead of the relatively inefficient + operator.
(KJS::Node::rethrowException): Added.
* kjs/nodes.h: Added rethrowException.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Tue, 23 Oct 2007 06:45:32 +0000 (06:45 +0000)]
Fix build.
* plugins/win/PluginViewWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Oct 2007 06:44:27 +0000 (06:44 +0000)]
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=15636
some JavaScriptCore regression tests are failing due to numeric conversion
This should restore correctness and make speed better too, restoring some
of the optimization we lost in my last check-in.
* kjs/JSImmediate.h:
(KJS::JSImmediate::getTruncatedInt32): Added. Uses the range checking idiom
I used in my patch yesterday.
(KJS::JSImmediate::getTruncatedUInt32): Ditto.
* kjs/internal.h: Removed getInt32 and added getTruncatedInt/UInt32.
* kjs/internal.cpp:
(KJS::NumberImp::getUInt32): Changed to always use double, since I can't find
a way to write this more efficiently for float.
(KJS::NumberImp::getTruncatedInt32): Added.
(KJS::NumberImp::getTruncatedUInt32): Added.
* kjs/value.h: Removed getInt32 and added getTruncatedInt/UInt32.
(KJS::JSValue::getUInt32):
(KJS::JSValue::getTruncatedInt32): Added.
(KJS::JSValue::getTruncatedUInt32): Added.
(KJS::JSValue::toInt32): Changed getInt32 call to getTruncatedInt32.
(KJS::JSValue::toUInt32): Changed getUInt32 call to getTruncatedUInt32.
* kjs/value.cpp:
(KJS::JSCell::getTruncatedInt32): Added.
(KJS::JSCell::getTruncatedUInt32): Added.
(KJS::JSValue::toInteger): Changed getUInt32 call to getTruncatedInt32.
(KJS::JSValue::toInt32SlowCase): Removed extra getInt32 call I accidentally
had left in here.
(KJS::JSValue::toUInt32SlowCase): Ditto.
(KJS::JSValue::toUInt16): Changed getUInt32 call to getTruncatedUInt32.
* JavaScriptCore.exp: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 23 Oct 2007 06:28:09 +0000 (06:28 +0000)]
2007-10-22 Eric Seidel <eric@webkit.org>
Build fix only, no review.
* WebCore.xcodeproj/project.pbxproj: re-add all DOMSVG headers to copy-files phase to make sure.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 23 Oct 2007 06:22:02 +0000 (06:22 +0000)]
2007-10-22 Eric Seidel <eric@webkit.org>
Build fix only, no review.
* WebCore.xcodeproj/project.pbxproj: make sure DOMSVGAnimateElement.h is copied into headers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 23 Oct 2007 06:07:23 +0000 (06:07 +0000)]
Touch SVGAnimateElement.idl to force to bots to rebuild *SVGAnimateElement.*
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 23 Oct 2007 04:19:10 +0000 (04:19 +0000)]
Reviewed by Review.
- add more tests (probably the final set for now)
Already balanced. Added date, regexp, control flow, and a few
more string and object/array access tests.
* tests/LIST:
* tests/access-fannkuch.js: Added.
* tests/access-nbody.js: Added.
* tests/controlflow-recursive.js: Added.
* tests/date-format-tofte.js: Added.
* tests/date-format-xparb.js: Added.
* tests/regexp-dna.js: Added.
* tests/string-validate-input.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 23 Oct 2007 03:49:17 +0000 (03:49 +0000)]
2007-10-22 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
Fix build by properly exposing SVG font-face dom bindings.
* DerivedSources.make:
* WebCore.vcproj/WebCore.vcproj: add font-face files to build
* WebCore.xcodeproj/project.pbxproj: add missing DOM bindings files
* bindings/js/JSSVGElementWrapperFactory.cpp:
* bindings/objc/DOM.mm:
(WebCore::createElementClassMap):
* bindings/objc/DOMSVG.h:
* ksvg2/svg/SVGDefinitionSrcElement.idl: inherit from SVGElement
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 23 Oct 2007 02:44:41 +0000 (02:44 +0000)]
2007-10-22 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Oct 2007 02:30:00 +0000 (02:30 +0000)]
- a first cut at fixing the Qt and GTK builds
* WebCore.pro: Add new .idl and .cpp files.
* DerivedSources.make: Re-sorted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 23 Oct 2007 00:38:49 +0000 (00:38 +0000)]
2007-10-22 Eric Seidel <eric@webkit.org>
Reviewed by hyatt.
Implement <font-face> and friends for SVG.
http://bugs.webkit.org/show_bug.cgi?id=10652
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSSVGElementWrapperFactory.cpp:
* dom/Document.cpp:
(WebCore::Document::mappedElementSheet):
(WebCore::Document::recalcStyleSelector):
* dom/Document.h:
* ksvg2/scripts/make_names.pl:
* ksvg2/svg/SVGDefinitionSrcElement.cpp: Added.
(WebCore::SVGDefinitionSrcElement::SVGDefinitionSrcElement):
(WebCore::SVGDefinitionSrcElement::~SVGDefinitionSrcElement):
(WebCore::SVGDefinitionSrcElement::childrenChanged):
* ksvg2/svg/SVGDefinitionSrcElement.h: Added.
* ksvg2/svg/SVGDefinitionSrcElement.idl: Added.
* ksvg2/svg/SVGFontFaceElement.cpp: Added.
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::~SVGFontFaceElement):
(WebCore::cssPropertyIdForName):
(WebCore::mapAttributeToCSSProperty):
(WebCore::cssPropertyIdForSVGAttributeName):
(WebCore::SVGFontFaceElement::parseMappedAttribute):
(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::childrenChanged):
* ksvg2/svg/SVGFontFaceElement.h: Added.
* ksvg2/svg/SVGFontFaceElement.idl: Added.
* ksvg2/svg/SVGFontFaceFormatElement.cpp: Added.
(WebCore::SVGFontFaceFormatElement::SVGFontFaceFormatElement):
(WebCore::SVGFontFaceFormatElement::~SVGFontFaceFormatElement):
(WebCore::SVGFontFaceFormatElement::childrenChanged):
* ksvg2/svg/SVGFontFaceFormatElement.h: Added.
* ksvg2/svg/SVGFontFaceFormatElement.idl: Added.
* ksvg2/svg/SVGFontFaceNameElement.cpp: Added.
(WebCore::SVGFontFaceNameElement::SVGFontFaceNameElement):
(WebCore::SVGFontFaceNameElement::~SVGFontFaceNameElement):
(WebCore::SVGFontFaceNameElement::srcValue):
* ksvg2/svg/SVGFontFaceNameElement.h: Added.
* ksvg2/svg/SVGFontFaceNameElement.idl: Added.
* ksvg2/svg/SVGFontFaceSrcElement.cpp: Added.
(WebCore::SVGFontFaceSrcElement::SVGFontFaceSrcElement):
(WebCore::SVGFontFaceSrcElement::~SVGFontFaceSrcElement):
(WebCore::SVGFontFaceSrcElement::srcValue):
(WebCore::SVGFontFaceSrcElement::childrenChanged):
* ksvg2/svg/SVGFontFaceSrcElement.h: Added.
* ksvg2/svg/SVGFontFaceSrcElement.idl: Added.
* ksvg2/svg/SVGFontFaceUriElement.cpp: Added.
(WebCore::SVGFontFaceUriElement::SVGFontFaceUriElement):
(WebCore::SVGFontFaceUriElement::~SVGFontFaceUriElement):
(WebCore::SVGFontFaceUriElement::srcValue):
(WebCore::SVGFontFaceUriElement::childrenChanged):
* ksvg2/svg/SVGFontFaceUriElement.h: Added.
* ksvg2/svg/SVGFontFaceUriElement.idl: Added.
* ksvg2/svg/svgtags.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 23 Oct 2007 00:33:27 +0000 (00:33 +0000)]
Windows build fix
Reviewed by NOBODY.
* Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 22 Oct 2007 23:36:36 +0000 (23:36 +0000)]
JavaScriptCore:
Reviewed by Geoff.
- fix http://bugs.webkit.org/show_bug.cgi?id=15632
js1_5/Array/array-001.js test failing
One of the JavaScriptCore tests was failing; it failed because of
my change to NumberImp::getUInt32. The incorrect code I copied was
from JSImmediate::getUInt32, and was a pre-existing bug.
This patch fixes correctness, but will surely slow down SunSpider.
We may be able to code this tighter and get the speed back.
* kjs/JSImmediate.h:
(KJS::JSImmediate::getInt32): Renamed from toInt32 to more accurately
reflect the fact that this function only returns true if the value is
accurate (no fractional part, etc.). Changed code so that it returns
false when the value has a fraction.
(KJS::JSImmediate::getUInt32): Ditto.
* kjs/internal.cpp:
(KJS::NumberImp::getInt32): Changed code so that it returns false when
the value has a fraction. Restores the old behavior.
(KJS::NumberImp::getUInt32): Ditto.
* kjs/value.h:
(KJS::JSValue::getInt32): Updated for name change.
(KJS::JSValue::getUInt32): Ditto.
(KJS::JSValue::toInt32): Ditto.
(KJS::JSValue::toUInt32): Ditto.
LayoutTests:
Reviewed by Geoff.
- tests for http://bugs.webkit.org/show_bug.cgi?id=15632
Added tests for cases where you use something that looks like an array
index, but it has a fractional part.
* fast/js/kde/resources/Array.js: Added tests.
* fast/js/kde/Array-expected.txt: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
honeycutt [Mon, 22 Oct 2007 23:29:21 +0000 (23:29 +0000)]
2007-10-22 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
<rdar://
5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page
We purposefully do not destroy our Java VM when its reference count
reaches 0, but we were unloading our JavaPlugin.dll when its reference
count reached 0, which lost the reference to the VM. This led to our
process trying to create a new VM the next time a page using Java was
loaded, and the JNI spec states that a single process is not allowed to
create more than one VM. The fix is to avoid unloading the Java plugin
via our PluginQuirkDontUnloadPlugin.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::determineQuirks):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 22 Oct 2007 22:18:24 +0000 (22:18 +0000)]
Reviewed by Brady.
- fix crash seen when running JavaScriptCore tests
* kjs/array_instance.cpp: (KJS::ArrayInstance::mark):
Copy and paste error: I accidentally had code here that was
making a copy of the HashMap -- that's illegal inside a mark
function and was unnecessary. The other callsite was modifying
the map as it iterated it, but this function is not.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 22 Oct 2007 21:32:56 +0000 (21:32 +0000)]
Add results for new layout tests for transforms.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 22 Oct 2007 21:32:24 +0000 (21:32 +0000)]
Add two new layout tests for transforms.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 22 Oct 2007 21:29:37 +0000 (21:29 +0000)]
Fix for bug 15624, make transforms work properly with opacity.
Make sure a unitless 0 is allowed as an angle argument to rotation/skew.
Reviewed by Mitz Pettel
fast/transforms/transforms-with-opacity.html
fast/transforms/skew-with-unitless-zero.html
* css/CSSParser.cpp:
(WebCore::CSSParser::validUnit):
* rendering/RenderLayer.cpp:
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::transform):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 22 Oct 2007 21:26:52 +0000 (21:26 +0000)]
Reviewed by Oliver.
- Avoid moving floats into integer registers in jsNumber() for 3% speedup on SunSpider
http://bugs.webkit.org/show_bug.cgi?id=15627
* kjs/JSImmediate.h:
(KJS::JSImmediate::fromDouble): Avoid moving floats to integer
registers since this is very slow.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 22 Oct 2007 18:39:46 +0000 (18:39 +0000)]
Reviewed by Eric Seidel.
- http://bugs.webkit.org/show_bug.cgi?id=15617
improve speed of integer conversions
Makes SunSpider 6% faster.
* kjs/JSImmediate.h: Added toInt32 and toUInt32, with separate versions for
32-bit and 64-bit.
* kjs/value.h:
(KJS::JSValue::getUInt32): Call JSImmediate::toUInt32.
* kjs/internal.h: Added getInt32.
* kjs/internal.cpp:
(KJS::NumberImp::getInt32): Added.
(KJS::NumberImp::getUInt32): Replaced with more-optimal implementation
stolen from JSValue.
* kjs/value.h:
(KJS::jsNumber): Marked ALWAYS_INLINE, because this wasn't getting
inlined.
(KJS::JSValue::getInt32): Added.
(KJS::JSValue::getUInt32): Changed to call the new JSImmediate::toUInt32
to avoid converting from float to double.
(KJS::JSValue::toInt32): Made inline, separated out the slow case.
(KJS::JSValue::toUInt32): Ditto.
* kjs/value.cpp:
(KJS::JSCell::getInt32): Added.
(KJS::JSValue::toInt32SlowCase): Renamed from toInt32. Changed to use the
new getInt32. Added a faster case for in-range numbers.
(KJS::JSValue::toUInt32SlowCase): Ditto.
(KJS::JSValue::toUInt16): Added a faster case for in-range numbers.
* JavaScriptCore.exp: Updated for changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Mon, 22 Oct 2007 18:02:46 +0000 (18:02 +0000)]
- Removed a leak that was fixed.
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Mon, 22 Oct 2007 17:48:15 +0000 (17:48 +0000)]
Reviewed by Darin.
- Changed the Client so that the DebuggerDocument now own the
ServerConnection. This simplifies ownership and cleanup.
* Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
ServerConnection.
(DebuggerClient::initWithServerName):
(DebuggerClient::didFinishLoadForFrame):
* Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
ServerConnection.
* Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
until after we have a server which we are attached to.
(Drosera::initUI):
(Drosera::attach):
* Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
out previously.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 22 Oct 2007 17:43:49 +0000 (17:43 +0000)]
Windows build fix
JavaScriptCore:
Windows build fix
Reviewed by NOBODY.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Turn off
warning about implicit conversion to bool.
WebCore:
Windows build fix
Reviewed by NOBODY.
* WebCore.vcproj/WebCore.vcproj: Copy header files from platform/sql.
* page/Page.cpp: Touched to force the header files to be copied.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Mon, 22 Oct 2007 17:14:58 +0000 (17:14 +0000)]
Reviewed by Simon.
Move textPath related SVGChar data in it's own structure SVGCharOnPath.
Store a pointer to that datastructure inside SVGChar, instead of 4 floats & one bool.
Saves space for the common case. And allows me to add more data (another float) to support
glyph-orientation-* on textPath later on...
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 22 Oct 2007 16:01:04 +0000 (16:01 +0000)]
When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Mon, 22 Oct 2007 15:06:58 +0000 (15:06 +0000)]
2007-10-22 Alp Toker <alp@atoker.com>
Reviewed by Nikolas Zimmermann.
Implement more GraphicsContextCairo stubs.
Remove a hack "to work around no current point bug" that was breaking
canvas tests.
Fix warnings.
* platform/graphics/cairo/CairoPath.h:
(WebCore::CairoPath::CairoPath):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::strokeRect):
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::isEmpty):
* platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp:
(WebCore::SVGPaintServerGradient::setup):
* platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp:
(WebCore::SVGPaintServerSolid::setup):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 22 Oct 2007 14:54:05 +0000 (14:54 +0000)]
Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 22 Oct 2007 14:53:57 +0000 (14:53 +0000)]
Fix compilation from a clean build with the database feature disabled.
JSCustomVersionChangeCallback.cpp doesn't actually need the SQL header file, just ScriptInterpreter.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 22 Oct 2007 13:56:45 +0000 (13:56 +0000)]
2007-10-22 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* kjs/array_instance.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 22 Oct 2007 13:46:35 +0000 (13:46 +0000)]
* fast/js/kde/resources/Array.js: Added tests to cover missing value behavior
(not the same as undefined values in arrays). This matches the ECMA JavaScript
specification, but doesn't exactly match Firefox, because Firefox incorrectly
inserts undefined values rather than missing values in array literals with
extra commas.
* fast/js/kde/Array-expected.txt: Updated with results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 22 Oct 2007 13:35:17 +0000 (13:35 +0000)]
JavaScriptCore:
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15606
make cut-off for sparse vs. dense arrays smarter for speed with large arrays
Makes the morph test in SunSpider 26% faster, and the overall
benchmark 3% faster.
This also fixes some small problems we had with the distinction
between nonexistent and undefined values in arrays.
* kjs/array_instance.h: Tweaked formatting and naming.
* kjs/array_instance.cpp: Copied from kjs/array_object.cpp.
(KJS::storageSize): Added. Computes the size of the storage given a vector length.
(KJS::increasedVectorLength): Added. Implements the rule for resizing the vector.
(KJS::isDenseEnoughForVector): Added.
(KJS::ArrayInstance::ArrayInstance): Initialize the new fields.
(KJS::ArrayInstance::~ArrayInstance): Since m_storage is now never 0, delete it.
(KJS::ArrayInstance::getItem): Updated for name changes.
(KJS::ArrayInstance::lengthGetter): Ditto.
(KJS::ArrayInstance::inlineGetOwnPropertySlot): Added. Allows both versions of
getOwnPropertySlot to share more code.
(KJS::ArrayInstance::getOwnPropertySlot): Just refactored, no code change.
(KJS::ArrayInstance::put): Added logic for extending the vector as long as the
array is dense enough. Also keep m_numValuesInVector up to date.
(KJS::ArrayInstance::deleteProperty): Added code to keep m_numValuesInVector
up to date.
(KJS::ArrayInstance::getPropertyNames): Fixed bug where this would omit names
for array indices with undefined values.
(KJS::ArrayInstance::increaseVectorLength): Renamed from resizeStorage. Also
simplified to only handle getting larger.
(KJS::ArrayInstance::setLength): Added code to update m_numValuesInVector, to
zero out the unused part of the vector and to delete the map if it's no longer
needed.
(KJS::ArrayInstance::mark): Tweaked formatting.
(KJS::compareByStringForQSort): Ditto.
(KJS::ArrayInstance::sort): Ditto.
(KJS::CompareWithCompareFunctionArguments::CompareWithCompareFunctionArguments):
Ditto.
(KJS::compareWithCompareFunctionForQSort): Ditto.
(KJS::ArrayInstance::compactForSorting): Fixed bug where this would turn
undefined values into nonexistent values in some cases.
* kjs/array_object.h: Removed MAX_ARRAY_INDEX.
* kjs/array_object.cpp: Removed ArrayInstance. Moved to a separate file.
* JavaScriptCore.pri: Added array_instance.cpp.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
* kjs/AllInOneFile.cpp: Ditto.
LayoutTests:
* fast/js/kde/resources/Array.js: Added tests to cover missing value behavior
(not the same as undefined values in arrays). This matches the ECMA JavaScript
specification, but doesn't exactly match Firefox.
* fast/js/kde/Array-expected.txt: Updated with results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andrew [Mon, 22 Oct 2007 12:56:02 +0000 (12:56 +0000)]
JavaScriptCore:
Reviewed by Mark Rowe.
Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
* Configurations/JavaScriptCore.xcconfig:
WebCore:
Reviewed by Mark Rowe.
Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
* Configurations/WebCore.xcconfig:
* WebCore.pro:
* WebCore.vcproj/build-generated-files.sh:
WebKit:
Reviewed by Mark Rowe.
Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
* Configurations/WebKit.xcconfig:
WebKitTools:
Reviewed by Mark Rowe.
Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 22 Oct 2007 11:39:34 +0000 (11:39 +0000)]
Build fix for the non-qmake builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 22 Oct 2007 11:28:44 +0000 (11:28 +0000)]
Disable the database feature in the qmake build for now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 22 Oct 2007 11:22:53 +0000 (11:22 +0000)]
Make disabling the database feature (ENABLE_DATABASE=0) work by
placing various #ifdefs into the code and making the compilation of
some files optional.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Mon, 22 Oct 2007 10:41:36 +0000 (10:41 +0000)]
2007-10-22 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=15611
[GTK] Text selection behaviour different in Debug and Release builds
http://bugs.webkit.org/show_bug.cgi?id=15578
[GTK] Text editor caret does not blink
Never allow control to reach the end of non-void functions.
Return more sensible values, or in some cases, nulls.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 22 Oct 2007 09:35:10 +0000 (09:35 +0000)]
Implement ResourceHandle::loadResourceSynchronously using ResourceHandle and a special ResourceHandleClient. This approach has the possible danger of reentrancy.
Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 22 Oct 2007 09:33:10 +0000 (09:33 +0000)]
- Do not build testkjs as an application bundle. This is
needed for run-javascriptcore-tests on OSX.
- Also, based on r26633, allow to test the WebKit/Qt port on OSX.
- Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
as we do not have -rpath on OSX.
Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc