18 years ago Reviewed by Ken.
mjs [Fri, 21 Jan 2005 01:36:41 +0000 (01:36 +0000)]
    Reviewed by Ken.

<rdar://problem/3965466> editing needs to insert text before applying typing style

        * khtml/editing/htmlediting.cpp:
        (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Remove a FIXME comment.
        (khtml::InsertLineBreakCommand::doApply): Apply style to the BR
node after inserting it.
        (khtml::InsertTextCommand::prepareForTextInsertion): Don't try to
apply style to any new nodes created before inserting.
        (khtml::InsertTextCommand::input): Apply style to the inserted range
after doing the text insert.
        * khtml/editing/htmlediting.h:

This change leads to improved results on one of the layout tests:

* layout-tests/editing/inserting/insert-div-024-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by me, changes by Han Ming Ong.
darin [Fri, 21 Jan 2005 01:22:08 +0000 (01:22 +0000)]
    Reviewed by me, changes by Han Ming Ong.

        - <rdar://problem/3964302> SWB: A few files need to be updated to be compilable under GCC 4.0

        * bindings/objc/WebScriptObjectPrivate.h: Make members public.
        * kjs/lookup.h: Change "value.h" to "object.h" because we need KJS::Object to compile a template.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agomove the Safari-180 release-marker in the ChangeLog, since the fix for 3786659 will...
vicki [Fri, 21 Jan 2005 00:58:23 +0000 (00:58 +0000)]
move the Safari-180 release-marker in the ChangeLog, since the fix for 3786659 will be included in Safari-180

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John
kocienda [Fri, 21 Jan 2005 00:50:30 +0000 (00:50 +0000)]
    Reviewed by John

        Fix for this bug:

        <rdar://problem/3786659> REGRESSION (Mail): editable WebViews don't work with "size up" and "size down" NSFontManager changes

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _addToStyle:fontA:fontB:]): This is the WebKit side of the fix. Replaced unimplemented code blocks
        with FIXME's in them for make bigger and make smaller with real working code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed <rdar://problem/3964634> undefined property value from binding seems to evalua...
rjw [Fri, 21 Jan 2005 00:41:59 +0000 (00:41 +0000)]
Fixed <rdar://problem/3964634> undefined property value from binding seems to evaluate to true in an if statement

The comprehensive fix for this problem requires new API, as described in 3965326.  However,
given that we can't add new API at this point, the 'ObjcFallbackObjectImp' will behave
like and Undefined object if  invokeUndefinedMethodFromWebScript:withArguments: isn't
implemented on the bound object.

        Reviewed by Chris.

        * bindings/objc/objc_runtime.h:
        * bindings/objc/objc_runtime.mm:
        * bindings/testbindings.mm:
        (+[MyFirstInterface isSelectorExcludedFromWebScript:]):
        (+[MyFirstInterface isKeyExcludedFromWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFinished my thought in the changelog. I left a comment half-written earlier.
kocienda [Fri, 21 Jan 2005 00:01:07 +0000 (00:01 +0000)]
Finished my thought in the changelog. I left a comment half-written earlier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoVersioning for TOT, Safari 2.0 (180+).
vicki [Thu, 20 Jan 2005 23:47:42 +0000 (23:47 +0000)]
Versioning for TOT, Safari 2.0 (180+).

The tree is open!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-180 stamp
vicki [Thu, 20 Jan 2005 23:33:44 +0000 (23:33 +0000)]
Safari-180 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John
kocienda [Thu, 20 Jan 2005 22:02:17 +0000 (22:02 +0000)]
    Reviewed by John

        Fix for this bug:

        <rdar://problem/3964646> REGRESSION (179-180): Typing space at end of line makes following paragraph disappear

        * khtml/editing/htmlediting.cpp:
        (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): Recent change to block placeholder removal code
        caused this regression. The code became too aggressive in removing block placeholders, and would remove them
        from blocks other than the block containing the selection.
        * layout-tests/editing/inserting/insert-div-023-expected.txt: This file had a spur
        * layout-tests/editing/inserting/insert-div-024-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for oddness on albertsons.com. Make sure not to crash when setting/removing...
hyatt [Thu, 20 Jan 2005 20:36:29 +0000 (20:36 +0000)]
Fix for oddness on albertsons.com.  Make sure not to crash when setting/removing style properties on a node
with no document.  The bug # is 3813900.

        Reviewed by john

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
harrison [Thu, 20 Jan 2005 19:34:48 +0000 (19:34 +0000)]
    Reviewed by Darin.

        PARTIAL fix for following bug.  Create attributed string with fonts and links.  Still need to add attachments.
        <rdar://problem/3942606> AX: Support kAXAttributedStringForTextMarkerRangeParameterizedAttribute

        * kwq/KWQAccObject.mm:
        (-[KWQAccObject textUnderElement]):
        Touched up previous checkin to match code review comments.

        (-[KWQAccObject value]):
        Use plainText for this one instead of obsolete attributedString.

        (-[KWQAccObject accessibilityParameterizedAttributeNames]):
        Advertise AXAttributedStringForTextMarkerRange.

        (-[KWQAccObject linkUIElementForNode:]):
        (-[KWQAccObject _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
        (-[KWQAccObject accessibilityAttributedStringForRange:]):
        New routines to support AXAttributedStringForTextMarkerRange.

        (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]):
        Use new routines instead of obsolete attributedString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
harrison [Thu, 20 Jan 2005 19:01:44 +0000 (19:01 +0000)]
    Reviewed by Darin.

        <rdar://problem/3960196> AX Crash in DOM::Range::setStartBefore

        * khtml/xml/dom_docimpl.cpp:
        Adjust when detecting cache in non-top level WebArea.
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject textUnderElement]):
        (-[KWQAccObject accessibilityAttributeValue:]):
        Make sure the elements document is the current one for the part.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Thu, 20 Jan 2005 18:05:19 +0000 (18:05 +0000)]
    Reviewed by John.

        - fixed <rdar://problem/3922980> Mail not crashing, just quitting itself suddenly in -[WebHTMLView(MailExtras) findString:options:]

        * khtml/dom/dom2_range.cpp: (DOM::operator==): Handle null and detached ranges without raising exceptions.
        The uncaught exception would make the entire program terminate.

        - fixed <rdar://problem/3885729> attempting to modify a computed style does nothing, but should raise a DOM exception

        * kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration setProperty:::]): Uncommented this code which I had to disable
        back in November because Mail was stumbling over it.

        - fixed <rdar://problem/3943049> focus() called during onload handler results in square text field on <input type=search>

        * kwq/KWQLineEdit.mm: (QLineEdit::baselinePosition): Change computation so it will work even for fields
        that position their text in a way that depends on vertical size. In the case of a search field, the text
        is centered, so the old logic was broken.
        * kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]): Set the frame size to
        something large enough to accomodate the field editor. If we start the frame at size 0,0 we run into
        AppKit trouble when it insets the frame to figure out the frame for the field editor. In the case of this
        bug this happens because we become first responder before being sized and positioned by the HTML layout code.

        - improved debugging output when using "po" from gdb with Objective-C DOM

        * kwq/DOM.mm:
        (-[DOMNode description]): Added. Includes node name ("<tr>") and node value (e.g., string for text node).
        (-[DOMRange description]): Tweaked format.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago After further discussion with Real we have decided to NOT include the
rjw [Thu, 20 Jan 2005 02:09:23 +0000 (02:09 +0000)]
After further discussion with Real we have decided to NOT include the
additional CLSID for the real plugin.  See 3958601.

        Reviewed by Darin.

        * khtml/rendering/render_frames.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed <rdar://problem/3853676> Browser Crash when accessing CCWeb Progress Page...
rjw [Thu, 20 Jan 2005 01:39:19 +0000 (01:39 +0000)]
Fixed <rdar://problem/3853676> Browser Crash when accessing CCWeb Progress Page - KJS::Bindings::convertValueToJValue

Fixed the following problems with LiveConnect that are demonstrated by the application
described in 3853676.

1.  If a nil object is passed in an array from Java to JavaScript we will crash.
2.  We sometimes will incorrectly attempt to access a generic JavaScript as a Java runtime object wrapper.
3.  We will sometimes fail to find the correct static method ID.

        Reviewed by Maciej.

        * bindings/jni/jni_jsobject.cpp:
        * bindings/jni/jni_runtime.cpp:
        * bindings/jni/jni_utility.cpp:
        * bindings/runtime_array.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
harrison [Thu, 20 Jan 2005 00:45:57 +0000 (00:45 +0000)]
    Reviewed by Maciej.

        <rdar://problem/3949429> AX: word marker routines returns incorrect data for empty line

        Previous checkin for this bug was missing some of the patch.  Editing snafu with multiple changes in tree.

        * kwq/KWQAccObject.mm:
        (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]):
        (-[KWQAccObject doAXNextWordEndTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXPreviousWordStartTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3513067, spaces being lost when RTL text is rendered. Make sure not to...
hyatt [Thu, 20 Jan 2005 00:05:14 +0000 (00:05 +0000)]
Fix for 3513067, spaces being lost when RTL text is rendered.  Make sure not to allow hangers or spaces
in the margin.

        Reviewed by john

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _createATSUTextLayoutForRun:style:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John
kocienda [Thu, 20 Jan 2005 00:01:58 +0000 (00:01 +0000)]
    Reviewed by John

        * khtml/editing/htmlediting.cpp:
        (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Small, cosmetic change John and I decided
        to do on my last checkin, but I forgot to do before landing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John
kocienda [Wed, 19 Jan 2005 23:54:09 +0000 (23:54 +0000)]
    Reviewed by John

        Fix for this bug:

        <rdar://problem/3959727> REGRESSION (Mail): Style not preserved on blank lines

        * khtml/editing/htmlediting.cpp:
        (khtml::CompositeEditCommand::insertBlockPlaceholder): New function that unconditionally adds a block placeholder.
        (khtml::CompositeEditCommand::insertBlockPlaceholderIfNeeded): Now returns bool based on whether
        placeholder was added or not.
        (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): Now searches all the descendents of a block
        looking for a placeholder. The old code, which just looked at the last child of a node, started missing
        once block placeholders became styled (which started happening with this patch).
        (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Now handles applying typing style
        to a block placeholder at call time, rather than setting the typing style as a latent style that
        might be applied later. This is an important part of the bug fix.
        (khtml::DeleteSelectionCommand::doApply): Now uses bool return value from insertBlockPlaceholderIfNeeded()
        and passes it along to calculateStyleBeforeInsertion, so the case where a block placeholder needs to
        be styled can be detected.
        (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Changed the way this class
        managed style. Before it would calculate and set typing style for the block added. This is not
        sufficient. Added blocks need to styled immediately. Some name changes to instance variables in
        this class due to the change to accommodate this change.
        (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): Name changes, as above.
        (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Ditto.
        (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto.
        (khtml::InsertParagraphSeparatorCommand::doApply): Ditto.
        (khtml::ReplaceSelectionCommand::doApply): Improve check for testing when a placeholder
        block can be removed in its entirety after the insertion.
        * khtml/editing/htmlediting.h: Update header accordingly.
        * khtml/khtml_part.cpp:
        (KHTMLPart::selectionComputedStyle): Move position for computed style check downstream before
        doing check when the position is in an empty block (this makes sure any style on any block
        placeholder is accounted for).

        New layout tests to check bug fix.

        * layout-tests/editing/style/block-style-004-expected.txt: Added.
        * layout-tests/editing/style/block-style-004.html: Added.
        * layout-tests/editing/style/block-style-005-expected.txt: Added.
        * layout-tests/editing/style/block-style-005.html: Added.
        * layout-tests/editing/style/block-style-006-expected.txt: Added.
        * layout-tests/editing/style/block-style-006.html: Added.

        Results updated to reflect new block placeholder code.

        * layout-tests/editing/inserting/insert-div-004-expected.txt
        * layout-tests/editing/inserting/insert-div-005-expected.txt
        * layout-tests/editing/inserting/insert-div-006-expected.txt
        * layout-tests/editing/inserting/insert-div-008-expected.txt
        * layout-tests/editing/inserting/insert-div-011-expected.txt
        * layout-tests/editing/inserting/insert-div-012-expected.txt
        * layout-tests/editing/inserting/insert-div-013-expected.txt
        * layout-tests/editing/inserting/insert-div-014-expected.txt
        * layout-tests/editing/inserting/insert-div-015-expected.txt
        * layout-tests/editing/inserting/insert-div-016-expected.txt
        * layout-tests/editing/inserting/insert-div-017-expected.txt
        * layout-tests/editing/inserting/insert-div-018-expected.txt
        * layout-tests/editing/inserting/insert-div-019-expected.txt
        * layout-tests/editing/inserting/insert-div-021-expected.txt
        * layout-tests/editing/inserting/insert-div-022-expected.txt
        * layout-tests/editing/inserting/insert-div-023-expected.txt
        * layout-tests/editing/inserting/insert-div-024-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by vicki
vicki [Wed, 19 Jan 2005 22:57:03 +0000 (22:57 +0000)]
    Reviewed by vicki

- fixed <rdar://problem/3962559> stopAnimationsInView leaks after cvs-base

        * WebCoreSupport.subproj/WebImageData.m: (+[WebImageData stopAnimationsInView:]): add a release

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Dont null-check the renderer before submitting, since a script can set it to display...
hyatt [Wed, 19 Jan 2005 22:43:39 +0000 (22:43 +0000)]
Dont null-check the renderer before submitting, since a script can set it to display:none and still expect the
submission to occur.  Fixes bug #3477282.

        Reviewed by kdecker


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3961809> plug-in code attempts to load empty URL
cblu [Wed, 19 Jan 2005 18:39:11 +0000 (18:39 +0000)]
Fixed: <rdar://problem/3961809> plug-in code attempts to load empty URL

        Reviewed by john.

        * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView didStart]): don't start load if URL is empty

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
rjw [Wed, 19 Jan 2005 02:34:22 +0000 (02:34 +0000)]
Fixed several issues all arising from analysis of plugin detection code at ifilm.com:

Fixed <rdar://problem/3958592> can't script plug-ins if plug-in is invoked with <object> element instead of <embed>
Fixed <rdar://problem/3958597> <object> elements with IDs do not show up as named properties of the document
Fixed <rdar://problem/3960973> DOM objects for plugin elements are not accessible
Fixed <rdar://problem/3958601> need an additional class ID in WebCore for the Real plug-in

We now support accessing scriptable plugin objects that are specified with <applet>, <embed>, or <object>
tags.  Also, if any of these elements are named they can be accessed from the document or window objects.
Finally, DOM methods are properties will be forwarded appropriately for the plugin's root scriptable object.

        Reviewed by Chris.

        * khtml/dom/html_document.cpp:
        * khtml/dom/html_document.h:
        * khtml/ecma/kjs_dom.cpp:
        * khtml/ecma/kjs_dom.h:
        * khtml/ecma/kjs_html.cpp:
        * khtml/ecma/kjs_window.cpp:
        * khtml/html/html_miscimpl.cpp:
        * khtml/html/html_miscimpl.h:
        * khtml/html/html_objectimpl.cpp:
        * khtml/html/html_objectimpl.h:
        * khtml/rendering/render_frames.cpp:
        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:

Fixed several issues all arising from analysis of plugin detection code at ifilm.com:

Fixed <rdar://problem/3958592> can't script plug-ins if plug-in is invoked with <object> element instead of <embed>
Fixed <rdar://problem/3958597> <object> elements with IDs do not show up as named properties of the document
Fixed <rdar://problem/3960973> DOM objects for plugin elements are not accessible
Fixed <rdar://problem/3958601> need an additional class ID in WebCore for the Real plug-in

We now support accessing scriptable plugin objects that are specified with <applet>, <embed>, or <object>
tags.  Also, if any of these elements are named they can be accessed from the document or window objects.
Finally, DOM methods are properties will be forwarded appropriately for the plugin's root scriptable object.

        Reviewed by Chris.

        * bindings/objc/objc_instance.h:
        * bindings/objc/objc_instance.mm:
        * bindings/runtime.h:
        * bindings/runtime_object.cpp:
        * bindings/runtime_object.h:
        * kjs/object.cpp:
        * kjs/object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3948123, rolling over link erases nearby text. The repaint rect check for...
hyatt [Tue, 18 Jan 2005 23:08:50 +0000 (23:08 +0000)]
Fix for 3948123, rolling over link erases nearby text.  The repaint rect check for lines was wrong whenever
two lines overlapped.

        Reviewed by kocienda

        * khtml/rendering/render_flow.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Hyatt
kocienda [Tue, 18 Jan 2005 22:58:47 +0000 (22:58 +0000)]
    Reviewed by Hyatt

        Fix for this bug:

        <rdar://problem/3960116> Focus rings paint incorrectly for contenteditable blocks in web pages

        * khtml/rendering/render_flow.cpp:
        (RenderFlow::addFocusRingRects): Fix painting of focus rings so that ring only paints around
        outermost contenteditable elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Back out a change that was incorrectly committed yesterday.
rjw [Tue, 18 Jan 2005 22:52:52 +0000 (22:52 +0000)]
Back out a change that was incorrectly committed yesterday.

        Reviewed by Chris.

        * bindings/objc/objc_utility.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
harrison [Tue, 18 Jan 2005 21:03:46 +0000 (21:03 +0000)]
    Reviewed by Darin.

        <rdar://problem/3959668> accessibilityFocusedUIElement sometimes returns an ignored element; it must not

        * kwq/KWQAccObject.mm:
        (-[KWQAccObject accessibilityFocusedUIElement]):
        Return parentObjectUnignored if focused object is ignored.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John
kocienda [Tue, 18 Jan 2005 18:11:21 +0000 (18:11 +0000)]
    Reviewed by John

        Fix for this bug:

        <rdar://problem/3952877> REGRESSION (Mail): Command-left/right-arrows don't work with file attachment

        * khtml/editing/selection.cpp:
        (khtml::nodeForInlineBox): New helper function used in reimplementation of function below.
        (khtml::selectionForLine): Reimplemented using line box smarts. I originally wrote this code when
        I had a less than full understanding of line layout. I can do better now, and my new version no
        longer fails to notice attachments when doing the kind of navigation mentioned in the bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John Sullivan.
harrison [Tue, 18 Jan 2005 01:44:49 +0000 (01:44 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/3949429> AX: word marker routines returns incorrect data for empty line
        <rdar://problem/3949848> AX: paragraph marker routines do not work when given a paragraph end marker

        Also fixed sentence support in the same way.

        * kwq/KWQAccObject.mm:
        (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXNextSentenceEndTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXNextParagraphEndTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]):
        Move one position in desired direction before calling visible_units.cpp code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Updated expected test results.
harrison [Tue, 18 Jan 2005 01:33:40 +0000 (01:33 +0000)]
    Updated expected test results.

        <rdar://problem/3945880> line-ending space seems not to be present

        * layout-tests/editing/deleting/delete-ws-fixup-001-expected.txt:
        * layout-tests/editing/deleting/delete-ws-fixup-002-expected.txt:
        * layout-tests/editing/inserting/insert-div-020-expected.txt:
        * layout-tests/editing/inserting/insert-div-021-expected.txt:
        * layout-tests/editing/inserting/insert-div-022-expected.txt:
        * layout-tests/editing/inserting/insert-div-023-expected.txt:
        * layout-tests/editing/inserting/insert-div-024-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave Hyatt (bidi.cpp) and Darin Adler (selection.cpp).
harrison [Tue, 18 Jan 2005 01:07:26 +0000 (01:07 +0000)]
    Reviewed by Dave Hyatt (bidi.cpp) and Darin Adler (selection.cpp).

        <rdar://problem/3945880> line-ending space seems not to be present

        * khtml/editing/selection.cpp:
        Extend AFTER_WHITE_SPACE code to support white spac in the middle of paragraphs, not just the end.
        * khtml/rendering/bidi.cpp:
        Pick left/rightness of word selection based on being at the end of paragraph (i.e. after a hard line break).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago * DOM.subproj/DOMPrivate.h: Check in generated file.
darin [Tue, 18 Jan 2005 01:06:27 +0000 (01:06 +0000)]
    * DOM.subproj/DOMPrivate.h: Check in generated file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John Louch.
darin [Tue, 18 Jan 2005 00:43:14 +0000 (00:43 +0000)]
    Reviewed by John Louch.

        - fixed <rdar://problem/3958503> need screenX and screenY to use WebKit windowFrame delegate

        * khtml/ecma/kjs_window.cpp: (Window::get): Change screenX and screenY to use frameGeometry instead
        of using mapToGlobal and screen in a complicated way.
        * kwq/KWQKHTMLView.mm: Removed unused mapToGlobal function.
        * kwq/KWQWindowWidget.h: Ditto.
        * kwq/KWQWindowWidget.mm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoAdd layout test for overflow float bug.
hyatt [Mon, 17 Jan 2005 23:30:10 +0000 (23:30 +0000)]
Add layout test for overflow float bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix a screwup in rightmost/lowets position computation. 3955207. Make sure floats...
hyatt [Mon, 17 Jan 2005 23:27:03 +0000 (23:27 +0000)]
Fix a screwup in rightmost/lowets position computation.  3955207.  Make sure floats with layers are still checked.

        Reviewed by kocienda

* khtml/rendering/render_block.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John and Richard.
darin [Mon, 17 Jan 2005 23:23:21 +0000 (23:23 +0000)]
    Reviewed by John and Richard.

        - fixed <rdar://problem/3907453> printing a multi-page PDF document from Safari doesn't produce correct output

        * WebView.subproj/WebFrameViewPrivate.h: Added.
        * WebView.subproj/WebFrameView.m:
        (-[WebFrameView canPrintHeadersAndFooters]): Added. Returnes NO for documents that can't print headers or footers,
        and delegates to the document view to answer the question. Defaults to NO, since only a view that actively does
        the work is compatible with our header and footer code.
        (-[WebFrameView printOperationWithPrintInfo:]): Added. Returns an NSPrintOperation set up for printing. The reason
        we return this rather than an NSView is that in the PDFView case, the print info is changed around before creating
        the NSPrintOperation, and also the PDFKit SPI works this way.

        * WebView.subproj/WebHTMLView.m: (-[WebHTMLView canPrintHeadersAndFooters]): Added. Returns YES.
        * WebView.subproj/WebImageView.m: (-[WebImageView canPrintHeadersAndFooters]): Ditto.
        * WebView.subproj/WebTextView.m: (-[WebTextView canPrintHeadersAndFooters]): Ditto.

        * WebView.subproj/WebPDFView.m:
        (-[WebPDFView canPrintHeadersAndFooters]): Added. Returns NO.
        (-[WebPDFView printOperationWithPrintInfo:]): Added. Calls getPrintOperationForPrintInfo: autoRotate:YES on the PDFView.

        * WebKit.pbproj/project.pbxproj: Added WebFrameViewPrivate.h as a new private header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed build snafu.
rjw [Mon, 17 Jan 2005 23:08:05 +0000 (23:08 +0000)]
Fixed build snafu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John
kocienda [Mon, 17 Jan 2005 22:54:43 +0000 (22:54 +0000)]
    Reviewed by John

        <rdar://problem/3953366> Problems with typing attributes in HTML compose

        * khtml/editing/htmlediting.cpp:
        (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Remove misguided "optimization"
        that tried to sense when typing style could be cleared without actually doing a style diff between
        before-delete and after-delete positions. Removing this extra check and running the
        general-purpose code fixes the bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
rjw [Mon, 17 Jan 2005 22:41:22 +0000 (22:41 +0000)]
Fixed <rdar://problem/3753030> Need to ensure same origin for plugin binding invocations (origin security rules)

Keep track of originating execution context and target execution
context for native JS object wrappers, and perform appropriate
security checks.

        Reviewed by David Harrison.

        * khtml/ecma/kjs_binding.cpp:
        * khtml/ecma/kjs_binding.h:
        * khtml/ecma/kjs_window.cpp:
        * khtml/ecma/kjs_window.h:
        * kwq/DOMInternal.mm:
        (-[WebScriptObject _initializeScriptDOMNodeImp]):
        * kwq/KWQKHTMLPart.mm:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge init]):

Fixed <rdar://problem/3753030> Need to ensure same origin for plugin binding invocations (origin security rules)

Keep track of originating execution context and target execution
context for native JS object wrappers, and perform appropriate
security checks.

        Reviewed by David Harrison.

        * bindings/NP_jsobject.cpp:
        * bindings/NP_jsobject.h:
        * bindings/c/c_instance.cpp:
        * bindings/c/c_instance.h:
        * bindings/c/c_utility.cpp:
        * bindings/jni/jni_instance.cpp:
        * bindings/jni/jni_instance.h:
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject _initializeWithObjectImp:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
        (-[WebScriptObject _initWithObjectImp:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
        (-[WebScriptObject KJS::Bindings::]):
        (-[WebScriptObject _setOriginExecutionContext:KJS::Bindings::]):
        (-[WebScriptObject _isSafeScript]):
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (-[WebScriptObject evaluateWebScript:]):
        (-[WebScriptObject setValue:forKey:]):
        (-[WebScriptObject valueForKey:]):
        (-[WebScriptObject removeWebScriptKey:]):
        (-[WebScriptObject stringRepresentation]):
        (-[WebScriptObject webScriptValueAtIndex:]):
        (-[WebScriptObject setWebScriptValueAtIndex:value:]):
        (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
        * bindings/objc/WebScriptObjectPrivate.h:
        * bindings/objc/objc_instance.h:
        * bindings/objc/objc_runtime.mm:
        * bindings/objc/objc_utility.mm:
        * bindings/runtime.cpp:
        * bindings/runtime.h:
        * bindings/runtime_root.cpp:
        * bindings/runtime_root.h:
        * kjs/interpreter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoRoll out unintended work-in-progress change
kocienda [Mon, 17 Jan 2005 22:20:50 +0000 (22:20 +0000)]
Roll out unintended work-in-progress change

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John
kocienda [Mon, 17 Jan 2005 22:18:47 +0000 (22:18 +0000)]
    Reviewed by John

        Fix for this bug:

        <rdar://problem/3786659> REGRESSION (Mail): editable WebViews don't work with
        "size up" and "size down" NSFontManager changes

        * khtml/css/cssparser.cpp:
        (CSSParser::parseValue): Add support for parsing new font size delta property.
        * khtml/css/cssproperties.c: Generated file.
        * khtml/css/cssproperties.h: Ditto.
        * khtml/css/cssproperties.in: Add support for parsing new font size delta property.
        * khtml/editing/htmlediting.cpp:
        (khtml::isEmptyStyleSpan): New helper function. Code existed before, but now factored out for convenient use.
        (khtml::CompositeEditCommand::removeNodeAttribute): Does check on value to see it exists before creating
        and running command to do the removal.
        (khtml::ApplyStyleCommand::doApply): Now calls new applyRelativeFontStyleChange() function as part of its work.
        (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): New function that does the "heavy lifting" to handle
        relative font size changes.
        (khtml::ApplyStyleCommand::applyInlineStyle): Range check the start and end positions to make sure the start is
        before or equal to the end. Swap them if not true. I ran into this problem in some similar code in
        applyRelativeFontStyleChange(). Moving that goodness here too.
        (khtml::ApplyStyleCommand::splitTextAtEndIfNeeded): Uses a local variable to save a value used often.
        Code is the same, but reads better now. Function now returns bool as well, just like splitTextAtStartIfNeeded.
        I use the bool return value now (I obviously did not need it before).
        (khtml::ApplyStyleCommand::computedFontSize): New helper function.
        (khtml::ApplyStyleCommand::joinChildTextNodes): Ditto.
        (khtml::createStyleSpanElement): Ditto.
        * khtml/editing/htmlediting.h: Update header accordingly.
        * khtml/editing/jsediting.cpp: Add new command string to enable relative font size changes.
        * kwq/DOM-CSS.mm:
        (-[DOMCSSStyleDeclaration _fontSizeDelta]): New convenience.
        (-[DOMCSSStyleDeclaration _setFontSizeDelta:]): Ditto.
        * kwq/DOMPrivate.h: Declare new conveniences.
        * layout-tests/editing/editing.js: Add new JS to enable relative font size changes, as well as explicit font size setting.
        * layout-tests/editing/style/relative-font-size-change-001-expected.txt: Added.
        * layout-tests/editing/style/relative-font-size-change-001.html: Added.
        * layout-tests/editing/style/relative-font-size-change-002-expected.txt: Added.
        * layout-tests/editing/style/relative-font-size-change-002.html: Added.
        * layout-tests/editing/style/relative-font-size-change-003-expected.txt: Added.
        * layout-tests/editing/style/relative-font-size-change-003.html: Added.
        * layout-tests/editing/style/relative-font-size-change-004-expected.txt: Added.
        * layout-tests/editing/style/relative-font-size-change-004.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago * khtml/css/cssproperties.c: Regenerated with gperf 3.0.1.
darin [Fri, 14 Jan 2005 23:55:37 +0000 (23:55 +0000)]
    * khtml/css/cssproperties.c: Regenerated with gperf 3.0.1.
        * khtml/css/cssvalues.c: Regenerated with gperf 3.0.1.
        * khtml/misc/htmlattrs.c: Regenerated with gperf 3.0.1.
        * khtml/misc/htmltags.c: Regenerated with gperf 3.0.1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3886415> arrow keys don't work when the user hits Back to...
cblu [Fri, 14 Jan 2005 20:09:32 +0000 (20:09 +0000)]
Fixed: <rdar://problem/3886415> arrow keys don't work when the user hits Back to return to RSS page

        Reviewed by hyatt.

        (KWQKHTMLPart::openURLFromPageCache): restore mousePressNode
        (KWQKHTMLPart::mousePressNode): new
        * kwq/KWQPageState.h:
        * kwq/KWQPageState.mm:
        (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]): save the mousePressNode
        (-[KWQPageState clear]): clear the mousePressNode
        (-[KWQPageState dealloc]): deref the mousePressNode
        (-[KWQPageState mousePressNode]): new

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3932107> Safari does not load QT Cocoa plug-in if the WebPlug...
cblu [Fri, 14 Jan 2005 01:01:03 +0000 (01:01 +0000)]
Fixed: <rdar://problem/3932107> Safari does not load QT Cocoa plug-in if the WebPluginMIMETypes key is not in the info.plist

Fixing this bug required that we allow WebKit plug-ins (as well as Netscape plug-ins) support BP_CreatePluginMIMETypesPreferences
which allows plug-ins create an auxiliary MIME types file.

        Reviewed by adele.

        * Plugins.subproj/WebBasePluginPackage.h:
        * Plugins.subproj/WebBasePluginPackage.m:
        (+[WebBasePluginPackage preferredLocalizationName]): moved from WebNetscapePluginPackage
        (-[WebBasePluginPackage pListForPath:createFile:]): ditto
        (-[WebBasePluginPackage getPluginInfoFromPLists]): ditto
        (-[WebBasePluginPackage isLoaded]): return isLoaded ivar
        (-[WebBasePluginPackage load]): if loaded, get BP_CreatePluginMIMETypesPreferences symbol
        * Plugins.subproj/WebNetscapePluginPackage.h:
        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]): call super when done so BP_CreatePluginMIMETypesPreferences can be initialized
        * Plugins.subproj/WebPluginPackage.m:
        (-[WebPluginPackage initWithPath:]): call getPluginInfoFromPLists
        (-[WebPluginPackage load]): call super when done so BP_CreatePluginMIMETypesPreferences can be initialized

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Changed another place where the method name was incorrect in
rjw [Fri, 14 Jan 2005 00:17:57 +0000 (00:17 +0000)]
Changed another place where the method name was incorrect in
the comment.

Reviewed (and found) by Darin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed <rdar://problem/3952809> WebJavaPlugIn.h comments need method name corrected...
rjw [Fri, 14 Jan 2005 00:11:52 +0000 (00:11 +0000)]
Fixed <rdar://problem/3952809> WebJavaPlugIn.h comments need method name corrected (webPlugInCallJava)

        Reviewed by Maciej.

        * Plugins.subproj/WebJavaPlugIn.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-179+ for TOT. The tree is open!
vicki [Fri, 14 Jan 2005 00:05:35 +0000 (00:05 +0000)]
Safari-179+ for TOT.  The tree is open!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-179 stamp
vicki [Thu, 13 Jan 2005 23:58:31 +0000 (23:58 +0000)]
Safari-179 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoReviewed by Adele.
vicki [Thu, 13 Jan 2005 23:54:30 +0000 (23:54 +0000)]
Reviewed by Adele.

- fix <rdar://problem/3946836> Safari about box lists 2004 instead of 2005

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed <rdar://problem/3951911> REGRESSION: Animated GIF images with loop counts...
rjw [Thu, 13 Jan 2005 22:13:04 +0000 (22:13 +0000)]
Fixed <rdar://problem/3951911> REGRESSION: Animated GIF images with loop counts no longer update

Draw last image after animation loop terminates.  (We
were drawing the image at index+1, which doesn't exist!)

        Reviewed by Darin.

        * WebCoreSupport.subproj/WebImageData.m:
        (-[WebImageData _nextFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed <rdar://problem/3952084> REGRESSION: Links at projectseven.com now draw and...
rjw [Thu, 13 Jan 2005 22:02:58 +0000 (22:02 +0000)]
Fixed <rdar://problem/3952084> REGRESSION: Links at projectseven.com now draw and update incorrectly during hover

Turn off use of new CGContextStrokeLineSegments API.  We should
turn back on when 3952944 is fixed.

        Reviewed by Darin.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agofixed incorrect check-in date
darin [Thu, 13 Jan 2005 21:17:34 +0000 (21:17 +0000)]
fixed incorrect check-in date

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Ken Kocienda.
harrison [Thu, 13 Jan 2005 19:45:33 +0000 (19:45 +0000)]
    Reviewed by Ken Kocienda.

        Better fix for 3905066.

        * khtml/editing/htmlediting.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3937663> repro assertion failure and crash dragging image...
cblu [Thu, 13 Jan 2005 19:41:52 +0000 (19:41 +0000)]
Fixed: <rdar://problem/3937663> repro assertion failure and crash dragging image that has PDF source

        Reviewed by adele.

        * Misc.subproj/WebNSViewExtras.m:
        (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]): if [WebImageRenderer image] returns nil, fallback to code that uses a file icon as the drag image
        * WebCoreSupport.subproj/WebImageRendererFactory.m:
        (-[WebImageRendererFactory supportedMIMETypes]): removed code that omits PDF and PostScript from the list since this omission is only needed in WebImageView
        * WebView.subproj/WebImageView.m:
        (+[WebImageView supportedImageMIMETypes]): added code that omits PDF and PostScript since we don't want WebImageView to render these types

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
mjs [Thu, 13 Jan 2005 19:09:58 +0000 (19:09 +0000)]

        Reviewed by Darin.

<rdar://problem/3758033> REGRESSION (Mail): Support attributes in marked text (International input)

        * khtml/rendering/render_text.cpp:
        (InlineTextBox::paint): Support painting custom underline markers for
marked text in place of generic yellow.
        (InlineTextBox::paintMarkedTextUnderline): New method that handles this.
        * khtml/rendering/render_text.h:
        * kwq/KWQKHTMLPart.h: Declare new methods and structs.
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::clear): Clear marked test underlines.
        (KWQKHTMLPart::setMarkedTextRange): Takes attributes and ranges now.
        (convertAttributesToUnderlines): Converts NSAttributedString attributes
to simplified and C++-friendly form.
        (KWQKHTMLPart::markedTextUsesUnderlines): New method.
        (KWQKHTMLPart::markedTextUnderlines): New method.
        * kwq/KWQPainter.mm:
        (QPainter::drawLineForText): Handle pen width.
        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge setMarkedTextDOMRange:customAttributes:ranges:]): Take attributes
and ranges.
        * kwq/WebCoreTextRenderer.h:


        Reviewed by Darin.

<rdar://problem/3758033> REGRESSION (Mail): Support attributes in marked text (International input)

* WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]): Changed to support
underline thickness. Also added a bit of a hack here to move thickness 2 underlines down by
.5 pixels, since the rendering engine can't give a fractional pixel offset.
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView validAttributesForMarkedText]): Support underline, underline color and marked
clause attributes. Others that NSText supports are unimplemented for now.
        (-[WebHTMLView firstRectForCharacterRange:]): Remove needless logging.
        (-[WebHTMLView unmarkText]): Updated for new WebCore SPI.
        (-[WebHTMLView _extractAttributes:ranges:fromAttributedString:]): New method to pull the attributes
and ranges out of an attributed string.
        (-[WebHTMLView setMarkedText:selectedRange:]): Extract attributes and pass to WebCore.
        (-[WebHTMLView insertText:]): Add comment noting that we don't really handle attributed strings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave Hyatt.
harrison [Thu, 13 Jan 2005 01:31:43 +0000 (01:31 +0000)]
    Reviewed by Dave Hyatt.

        <rdar://problem/3888973> AX: Parent AXWebArea of nested AXWebAreas is messed up

        * kwq/KWQAccObject.mm:
        (-[KWQAccObject addChildrenToArray:]):
        Use the widget's outer view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin Adler.
harrison [Thu, 13 Jan 2005 01:19:52 +0000 (01:19 +0000)]
    Reviewed by Darin Adler.

        * khtml/xml/dom_nodeimpl.cpp:
        Add quotes around text node content.
        Add nil check to return nil rather than crash when child node not found.
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject doAXStringForTextMarkerRange:]):
        Pass range compliant positions to TextIterator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Ken.
darin [Wed, 12 Jan 2005 23:55:08 +0000 (23:55 +0000)]
    Reviewed by Ken.

        - fixed <rdar://problem/3848257> WebView will draw more than AppKit asks it to, so views behind won't redraw enough (transparent WebView)

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]): As recommended by Troy Stephens, do the
        layouts here in this call, since it's before propagating the dirty rects to our ancestors.
        This fixes the bug, but we only do it if the WebView is not opaque, because otherwise we can
        optimize by only doing layouts you really need, and doing them later on is safe because we
        know we don't need to draw any of the views behind us.
        (-[WebHTMLView _layoutIfNeeded]): Added. Factored out from the method below.
        (-[WebHTMLView _web_layoutIfNeededRecursive]): Added. Like the other "layout if needed" call,
        but unconditional.
        (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]): Factored out the guts into the
        _layoutIfNeeded method above. Otherwise unchanged.
        (-[NSView _web_layoutIfNeededRecursive]): Added.

        * WebView.subproj/WebFrame.m: (-[WebFrame _updateDrawsBackground]): Call setDrawsBackground:NO
        on the scroll view when changing the frame to no longer be in "draws background" mode. This
        is needed because the frame manages the "draws background" mode of the scroll view. It won't
        have any effect if you call setDrawsBackground:NO before starting to use a WebView, but without
        it calling setDrawsBackground:NO later won't have an immediate effect (easily visible in Safari).
        This was hidden before because the HTML view was filling with transparent color, which blew away
        the fill that was done by NSScrollView.

        - fixed <rdar://problem/3921129> reproducible crash at www.funnychristmas.com in CFSet manipulation in WebImageData

        * WebCoreSupport.subproj/WebImageData.m:
        (-[WebImageData _imageSourceOptions]): Changed types so we don't need a cast.
        (+[WebImageData stopAnimationsInView:]): Instead of building a set of sets, by putting in the sets with addObject,
        build a single set using unionSet, and then iterate the objects instead of having to iterate the sets and then the
        objects in each set. The old code ended up sharing the sets with the live code, when the whole idea was to gather
        all the renderers because the process of stopping modifies the active sets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Avoid additional work on dealloc by adding early out to
rjw [Wed, 12 Jan 2005 23:41:00 +0000 (23:41 +0000)]
Avoid additional work on dealloc by adding early out to
removeNativeReference().  (This will save time on dealloc
for all ObjC DOM objects.)

        Reviewed by Darin.

        * bindings/runtime_root.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3951203, CSS border style incorrectly clipped on inline elements. Make...
hyatt [Wed, 12 Jan 2005 23:33:21 +0000 (23:33 +0000)]
Fix for 3951203, CSS border style incorrectly clipped on inline elements.  Make sure the repaint rect set during
line layout is smarter about including the overflow for both old states and new states.

        Reviewed by john

        * khtml/rendering/bidi.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed <rdar://problem/3923356> REGRESSION: Java/JavaScript security checks working...
rjw [Wed, 12 Jan 2005 23:24:18 +0000 (23:24 +0000)]
Fixed <rdar://problem/3923356> REGRESSION: Java/JavaScript security checks working incorrectly

We were always returning the first "root" object for all runtime
objects.  Changed 0 in loop to i, the index.

        Reviewed by David Harrison.

        * bindings/runtime_root.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed <rdar://problem/3887930> Must use new Java plug-in API to get/set fields so...
rjw [Wed, 12 Jan 2005 22:03:55 +0000 (22:03 +0000)]
Fixed <rdar://problem/3887930> Must use new Java plug-in API to get/set fields so exception handling works (fixes many LiveConnect crashes)

Use the new dispatching API to invoke JNI, rather than calling JNI

        Reviewed by David Harrison.

        * bindings/jni/jni_instance.cpp:
        * bindings/jni/jni_runtime.cpp:
        * bindings/jni/jni_runtime.h:
        * bindings/jni/jni_utility.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed <rdar://problem/3926825> Safari ignores GIF loop count
rjw [Wed, 12 Jan 2005 21:41:05 +0000 (21:41 +0000)]
Fixed <rdar://problem/3926825> Safari ignores GIF loop count

Get loop count from file properties, not image properties.

        Reviewed by Ken Kocienda.

        * WebCoreSupport.subproj/WebImageData.h:
        * WebCoreSupport.subproj/WebImageData.m:
        (-[WebImageData _commonTermination]):
        (-[WebImageData fileProperties]):
        (-[WebImageData _floatProperty:type:at:]):
        (-[WebImageData _floatFileProperty:type:]):
        (-[WebImageData _repetitionCount]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for bug 3937608, versiontracker.com flashes and displays the right column below...
hyatt [Wed, 12 Jan 2005 19:13:35 +0000 (19:13 +0000)]
Fix for bug 3937608, versiontracker.com flashes and displays the right column below content.  Make sure to move
tables/overflows that dont fit within a block only in strict mode.

Fix for bug 3931049, characters dont show up when typing.  Make sure to dirty the right lines when this specific
case in editing is hit.

        Reviewed by darin (first one), kocienda (second one)

        * khtml/rendering/render_block.cpp:
        * khtml/rendering/render_flow.cpp:
        * khtml/rendering/render_line.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John
kocienda [Wed, 12 Jan 2005 17:55:08 +0000 (17:55 +0000)]
    Reviewed by John

        Fix for this bug:

        <rdar://problem/3926142> REGRESSION (Mail): Deleting text decreases quote level

        * khtml/editing/htmlediting.cpp:
        (khtml::DeleteSelectionCommand::initializePositionData): Change test that will prevent block
        merging. End-of-line test was just wrong. Call new start-of and end-of paragraph functions
        added to visible_position files.
        (khtml::DeleteSelectionCommand::moveNodesAfterNode): Add tests for BR elements, which makes
        tests to determine when to stop moving nodes more complete and correct. Also improved comments.
        * khtml/editing/visible_position.cpp:
        (khtml::isFirstVisiblePositionInParagraph): New function.
        (khtml::isLastVisiblePositionInParagraph): New function.
        * khtml/editing/visible_position.h: Update header accordingly.
        * layout-tests/editing/deleting/delete-block-merge-contents-002-expected.txt: New results, slightly different from former
        results but still correct.
        * layout-tests/editing/deleting/delete-block-merge-contents-007-expected.txt: Ditto.
        * layout-tests/editing/deleting/delete-block-merge-contents-018-expected.txt: Added.
        * layout-tests/editing/deleting/delete-block-merge-contents-018.html: Added.
        * layout-tests/editing/deleting/delete-block-merge-contents-019-expected.txt: Added.
        * layout-tests/editing/deleting/delete-block-merge-contents-019.html: Added.
        * layout-tests/editing/deleting/delete-block-merge-contents-020-expected.txt: Added.
        * layout-tests/editing/deleting/delete-block-merge-contents-020.html: Added.
        * layout-tests/editing/deleting/delete-block-merge-contents-021-expected.txt: Added.
        * layout-tests/editing/deleting/delete-block-merge-contents-021.html: Added.
        * layout-tests/editing/deleting/delete-line-014-expected.txt: These new results are actually better, and fix a bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3934749> assertion failure in WebBaseNetscapePluginView loadi...
cblu [Wed, 12 Jan 2005 00:49:51 +0000 (00:49 +0000)]
Fixed: <rdar://problem/3934749> assertion failure in WebBaseNetscapePluginView loading movie

        Reviewed by john.

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView start]): call canStart before asserting about the webView

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3922875. Fall back to DOM object is EMBED element
rjw [Wed, 12 Jan 2005 00:30:16 +0000 (00:30 +0000)]
Fixed 3922875.  Fall back to DOM object is EMBED element
has no associated runtime object.

        Reviewed by Chris.

        * khtml/ecma/kjs_dom.cpp:
        * khtml/ecma/kjs_html.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3882299, missing content on gibson.com. Change our handling of ...
hyatt [Tue, 11 Jan 2005 23:46:03 +0000 (23:46 +0000)]
    Fix for 3882299, missing content on gibson.com.  Change our handling of " and ' in certain states of the parser to match
other browsers.

        Reviewed by Maciej

        * khtml/html/htmltokenizer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
sullivan [Tue, 11 Jan 2005 23:43:39 +0000 (23:43 +0000)]
    Reviewed by Darin.

        - fixed <rdar://problem/3446838> REGRESSION (Mail): text decorations don't print
        (e.g. <strike>, underline)

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]):
        This bottleneck routine for drawing a line was setting the linewidth to 0 when
        the graphics context was not drawing to the screen. Thus, no lines. Now links
        are underlined when printing from Safari (as well as Mail).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3949145. CG has a much faster API for drawing lines.
rjw [Tue, 11 Jan 2005 22:50:01 +0000 (22:50 +0000)]
Fixed 3949145.  CG has a much faster API for drawing lines.
Switched over to that new API (CGContextStrokeLineSegments).

        Reviewed by John Sullivan.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3930733> Mail prints second page of email blank
cblu [Tue, 11 Jan 2005 22:44:53 +0000 (22:44 +0000)]
Fixed: <rdar://problem/3930733> Mail prints second page of email blank

        Reviewed by dave.

        * khtml/rendering/render_canvas.cpp:
        (RenderCanvas::paint): cache the print rect since the dirty rect can get changed during printing
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::paintLines): removed null check since the print rect should never be null
        * khtml/rendering/render_list.cpp:
        (RenderListMarker::paint): ditto
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::adjustPageHeight): don't set the print rect here since this method is not called for the last page

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3948862> REGRESSION: missing images when RTFD is pasted into...
cblu [Tue, 11 Jan 2005 21:25:03 +0000 (21:25 +0000)]
Fixed: <rdar://problem/3948862> REGRESSION: missing images when RTFD is pasted into editable WebView

This problem occurred because we were creating image elements before creating corresponding image resources. The fix is to have AppKit call us back to create the resources before it creates the elements.

        Reviewed by john.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): don't deal with subresources since that's now done by the following method
        (-[WebHTMLView resourceForData:preferredFilename:]): new handler method called by AppKit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Hyatt
kocienda [Mon, 10 Jan 2005 23:40:45 +0000 (23:40 +0000)]
    Reviewed by Hyatt

        Fix for this bug:

        <rdar://problem/3943648> extra line is inserted after pressing return within quoted text of reply

        * khtml/editing/htmlediting.cpp:
        (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): This bug was the result of a
        simple coding mistake. A local variable was erroneously redefined in a deeper scope, and so the
        result calculated in that deeper scope was not available when tested.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John
kocienda [Mon, 10 Jan 2005 23:28:56 +0000 (23:28 +0000)]
    Reviewed by John

        Fix for this bug:

        <rdar://problem/3946852> Option-e goes to next line

        * khtml/editing/htmlediting.cpp:
        (khtml::ReplaceSelectionCommand::doApply): Tweak case used to determine when merging content
        into the start line is done. We plan to change pretty substantially soon to better handle
        the problem described in <rdar://problem/3937352> Quote level not maintained when copied
        and pasted within a Mail message. In the meantime, this change does no harm, and fixes the bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin
kocienda [Mon, 10 Jan 2005 18:47:43 +0000 (18:47 +0000)]
    Reviewed by Darin

        Fix for this bug:

        <rdar://problem/3907005> Applying block styles to a line of text can unexpectedly affect other lines

        * khtml/editing/htmlediting.cpp:
        (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): New function which moves "paragraphs"
        to their own blocks if needed so that a block style can be applied.
        (khtml::CompositeEditCommand::isMailBlockquote): Moved this function to base class so it can be used more generally.
        (khtml::ApplyStyleCommand::applyBlockStyle): Pass a node instead of a block to addBlockStyleIfNeeded().
        (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): Now accepts a node instead of a block for styling.
        This function also now calls moveParagraphContentsToNewBlockIfNecessary() to make sure that only the current
        paragraph is styled.
        (khtml::SetNodeAttributeCommand::doUnapply): Should not assert on undo if old value of attribute was null.
        Should remove attributue instead.
        * khtml/editing/htmlediting.h: Touch function declarations accordingly.
        * layout-tests/editing/style/create-block-for-style-001-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-001.html: Added.
        * layout-tests/editing/style/create-block-for-style-002-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-002.html: Added.
        * layout-tests/editing/style/create-block-for-style-003-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-003.html: Added.
        * layout-tests/editing/style/create-block-for-style-004-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-004.html: Added.
        * layout-tests/editing/style/create-block-for-style-005-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-005.html: Added.
        * layout-tests/editing/style/create-block-for-style-006-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-006.html: Added.
        * layout-tests/editing/style/create-block-for-style-007-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-007.html: Added.
        * layout-tests/editing/style/create-block-for-style-008-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-008.html: Added.
        * layout-tests/editing/style/create-block-for-style-009-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-009.html: Added.
        * layout-tests/editing/style/create-block-for-style-010-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-010.html: Added.
        * layout-tests/editing/style/create-block-for-style-011-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-011.html: Added.
        * layout-tests/editing/style/create-block-for-style-012-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-012.html: Added.
        * layout-tests/editing/style/create-block-for-style-013-expected.txt: Added.
        * layout-tests/editing/style/create-block-for-style-013.html: Added.

        Unrelated updates to these expected results.
        * layout-tests/editing/inserting/insert-div-007-expected.txt
        * layout-tests/editing/pasteboard/paste-text-013-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3936844> Mail: Messages with rich text do not print
cblu [Mon, 10 Jan 2005 18:38:39 +0000 (18:38 +0000)]
Fixed: <rdar://problem/3936844> Mail: Messages with rich text do not print

        Reviewed by john.

        * khtml/rendering/render_flow.cpp:
        (RenderFlow::paintLines): don't do pagination work if printRect is not set
        * khtml/rendering/render_list.cpp:
        (RenderListMarker::paint): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
harrison [Mon, 10 Jan 2005 18:22:06 +0000 (18:22 +0000)]
    Reviewed by Darin.

        * kwq/KWQTextUtilities.mm:
        Return empty string (AKA root locale) if locale pref can not be canonicalized.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed broken Panther build.
sullivan [Mon, 10 Jan 2005 17:07:49 +0000 (17:07 +0000)]
    Fixed broken Panther build.

        * kwq/KWQTextUtilities.mm:
        This recently-added function was using code copy/pasted from CarbonCore UnicodeUtilities.
        That code used a Tiger-only function, CFLocaleCreateCanonicalLanguageIdentifierFromString.
        To fix the build, I added a BUILDING_ON_PANTHER #ifdef that avoids the call to the Tiger
        function. However, the Tiger-only code was wrong; the string generated using
        CFLocaleCreateCanonicalLanguageIdentifierFromString was not used at all, so I fixed that
        as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Ken Kocienda.
harrison [Sun, 9 Jan 2005 21:42:55 +0000 (21:42 +0000)]
    Reviewed by Ken Kocienda.

        <rdar://problem/3786362> REGRESSION (Mail): pasted text loses one newline

        * khtml/editing/htmlediting.cpp:
        Tune check for need for insertParagraphSeparator when hasInterchangeNewline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Harrison.
darin [Sun, 9 Jan 2005 19:11:54 +0000 (19:11 +0000)]
    Reviewed by Harrison.

        - fixed <rdar://problem/3939176> select() method does not work on <input type=search>

        * khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::select): Changed if statement
        to a switch statement. Added SEARCH to the set of types that treat the renderer as a

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Ken Kocienda.
harrison [Sun, 9 Jan 2005 18:54:59 +0000 (18:54 +0000)]
    Reviewed by Ken Kocienda.

        <rdar://problem/3905066> REGRESSION (Mail): Hitting return key with caret in front of space causes space to become lost (resize fixes)

        Problem was that InsertParagraphSeparatorCommand::doApply() was not collapsing
        whitespace to a single non-breaking space when splitting a text node.

        * khtml/editing/htmlediting.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Ken.
kdecker [Sun, 9 Jan 2005 18:40:48 +0000 (18:40 +0000)]
    Reviewed by Ken.

Fixed: <rdar://problem/3924219> Calling setOuterHTML: on a DOMHTMLHtmlElement can crash a program

        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::setOuterHTML): Added a nil check for fragments who don't have parents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
mjs [Sun, 9 Jan 2005 04:09:49 +0000 (04:09 +0000)]
    Reviewed by Darin.

<rdar://problem/3807144> REGRESSION (125-TOT): my bank's website doesn't work (Societe Generale, socgen.com)

        * Khtml/khtml_part.cpp:
        (KHTMLPart::checkCompleted): If the document is NULL, assume this frame has
not started loading yet so it could not possibly be finishing here...
        (KHTMLPart::stop): ...unless the part is explicitly stopped and there is still
no document, in this case we must have hit an error or been loading a non-HTML
        * khtml/khtml_part.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
harrison [Sat, 8 Jan 2005 20:42:40 +0000 (20:42 +0000)]
    Reviewed by Maciej.

        <rdar://problem/3943415> REGRESSION (Mail): double-clicking past word selects previous word instead of only blank space

        * khtml/editing/selection.cpp:
        Tune word selections left/right choice to use right if on empty last line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
harrison [Sat, 8 Jan 2005 00:17:30 +0000 (00:17 +0000)]
    Reviewed by Darin.

        <rdar://problem/3942619> AX: Support sentence ax attributes

        Needed to use the unicode utilities properly.  Twas lame before.

        * khtml/editing/visible_units.cpp:
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject accessibilityAttributeNames]):
        (-[KWQAccObject accessibilityAttributeValue:]):
        (-[KWQAccObject accessibilityParameterizedAttributeNames]):
        (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]):
        * kwq/KWQTextUtilities.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Kevin
kocienda [Fri, 7 Jan 2005 22:42:04 +0000 (22:42 +0000)]
    Reviewed by Kevin

        Fix for these bugs:

        <rdar://problem/3939523> in some cases, text does not retain style info after pressing return twice
        <rdar://problem/3944492> after pressing return twice, text is bold when it shouldn't be

        * khtml/editing/htmlediting.cpp:
        Merge the typing style with the computed style for the current position. Fixes both bugs.
        * khtml/editing/htmlediting.h:
        * layout-tests/editing/inserting/insert-div-023-expected.txt: Added.
        * layout-tests/editing/inserting/insert-div-023.html: Added.
        * layout-tests/editing/inserting/insert-div-024-expected.txt: Added.
        * layout-tests/editing/inserting/insert-div-024.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFix the layout tests.
hyatt [Fri, 7 Jan 2005 20:38:19 +0000 (20:38 +0000)]
Fix the layout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3941364, make sure tables reset overflowWidth/Height when they lay out again...
hyatt [Fri, 7 Jan 2005 20:22:13 +0000 (20:22 +0000)]
Fix for 3941364, make sure tables reset overflowWidth/Height when they lay out again.  Fixes the odd scrolling
behavior on worldofwarcraft.com.

        Reviewed by kevin

        * ChangeLog:
        * khtml/rendering/render_table.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Hyatt
kocienda [Fri, 7 Jan 2005 20:13:11 +0000 (20:13 +0000)]
    Reviewed by Hyatt

        Fix for this bug:

        <rdar://problem/3848412> for forwarded message, tabbing to message view scrolls to bottom of view

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::nextKeyViewInFrame): Don't scroll the focus node to visible if it is not
        in the document, or if it is not a descendent of the document element. In the case of the bug,
        since the selection has not yet been set up, the focus node passed here is the HTML element, and
        that does not yield a rect that is useful to us here. So now, in the case the bug mentions, we do nothing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by mjs.
kdecker [Fri, 7 Jan 2005 02:30:52 +0000 (02:30 +0000)]
    Reviewed by mjs.

Fixed: <rdar://problem/3932215> REGRESSION (125-177): iFrame example at developer.apple.com fails in Safari

        * khtml/khtml_part.cpp:
        (KHTMLPart::processObjectRequest): m_bComplete was never true for frames generated by Javascript due to our synchronous loading and as a result, scheduled redirects wouldn't fire in KHTMLPart::scheduleLocationChange().  By virtue of being an empty document, a document is complete.  In this special case it's safe at this point to call checkCompleted() which sets m_bComplete true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoversioning for TOT, Safari 2.0 (178+)
vicki [Fri, 7 Jan 2005 00:35:20 +0000 (00:35 +0000)]
versioning for TOT, Safari 2.0 (178+)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-178 stamp
vicki [Fri, 7 Jan 2005 00:27:15 +0000 (00:27 +0000)]
Safari-178 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Chris.
harrison [Thu, 6 Jan 2005 21:56:28 +0000 (21:56 +0000)]
    Reviewed by Chris.

        (addendum to previous checkin for this bug)
        <rdar://problem/3776056> AX: Editable HTML should not be viewed as AXStaticText

        Fix line navigation.  Add AXUIElementForTextMarker.

        * ChangeLog:
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject accessibilityParameterizedAttributeNames]):
        (-[KWQAccObject doAXUIElementForTextMarker:]):
        (-[KWQAccObject doAXLineForTextMarker:]):
        (-[KWQAccObject doAXTextMarkerRangeForLine:]):
        (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]):
        (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]):
        (-[KWQAccObject accessibilityAttributeValue:forParameter:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Ken.
darin [Thu, 6 Jan 2005 21:13:16 +0000 (21:13 +0000)]
    Reviewed by Ken.

        - re-fixed <rdar://problem/3760910> Request to include support for custom tag names in HTML (they already work in XML)

        (turns out the PLT regression was a false alarm)

        * khtml/html/htmlparser.h: Change forbidden tag array to be allocated in the object rather than on
        the heap. Also use ID_LAST_TAG for the array size; the old code used ID_CLOSE_TAG which is now a
        much larger number.
        * khtml/html/htmlparser.cpp:
        (KHTMLParser::KHTMLParser): Remove code that creates the forbidden tag array on the heap; makes more
        sense to just have the array be a member so we don't have to use new and delete on it. Also needed
        to eliminate code that used ID_CLOSE_TAG for an array size.
        (KHTMLParser::~KHTMLParser): Remove code that deletes the forbidden tag array. Also changed the code
        that manages isindex to use deref instead of delete.
        (KHTMLParser::reset): Use safer sizeof for clearing the forbidden tag array. Old code had the
        mistake of using ID_CLOSE_TAG for the array size too.
        (KHTMLParser::parseToken): Removed code that checks for bogus tags; it's not clear why it was ever
        there and it would prevent custom tags from working. Added range check before using the forbidden
        tag array with the token ID since custom tags will use index values past the end of the array.
        (KHTMLParser::getElement): Removed most of the code that makes an element by ID; now the work is done
        inside the DocumentImpl createHTMLElement. Any code that needs to be different than a dynamic
        createElement call is still here. Last time I left out a few form element types from this switch;
        fixed now.
        * khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): Call the tagId function in the
        document if getTagID fails; this creates a unique per-document ID.

        * khtml/misc/htmltags.c: Regenerated.
        * khtml/misc/htmltags.h: Regenerated.

        * khtml/misc/maketags: Changed the generated constants to use "const unsigned short" instead of "#define".
        Changed ID_CLOSE_TAG to be a fixed value of 32000 rather than being just past the IDs of the HTML tags.
        Also rewrote getTagName to work with the new scheme.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed Panther build. Also, do not advertize sentence support since it is...
harrison [Thu, 6 Jan 2005 19:04:57 +0000 (19:04 +0000)]
    Fixed Panther build.  Also, do not advertize sentence support since it is incomplete.

        * kwq/KWQAccObject.mm:
        (-[KWQAccObject visiblePositionForEndOfTextMarkerRange:]):
        (-[KWQAccObject accessibilityParameterizedAttributeNames]):
        (-[KWQAccObject accessibilityIsAttributeSettable:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave Hyatt.
harrison [Thu, 6 Jan 2005 18:20:51 +0000 (18:20 +0000)]
    Reviewed by Dave Hyatt.

        <rdar://problem/3776056> AX: Editable HTML should not be viewed as AXStaticText
        <rdar://problem/3588548> AX: tabbing does not work correctly with the screen reader and a focused link; need AXFocusedUIElement to work

        Many more AX attributes supported.  Numerous fixes to previous AX work.

        * khtml/editing/visible_units.cpp:
        * khtml/editing/visible_units.h:
        * khtml/khtmlview.cpp:
        * khtml/misc/helper.cpp:
        * khtml/misc/helper.h:
        * khtml/misc/htmltags.c:
        * khtml/rendering/render_container.cpp:
        * khtml/rendering/render_object.cpp:
        * khtml/xml/dom_docimpl.cpp:
        * khtml/xml/dom_docimpl.h:
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject accessibilityShouldUseUniqueId]):
        (-[KWQAccObject detach]):
        (-[KWQAccObject anchorElement]):
        (-[KWQAccObject firstChild]):
        (-[KWQAccObject lastChild]):
        (-[KWQAccObject previousSibling]):
        (-[KWQAccObject nextSibling]):
        (-[KWQAccObject parentObject]):
        (-[KWQAccObject value]):
        (-[KWQAccObject accessibilityAttributeNames]):
        (-[KWQAccObject accessibilityPerformAction:]):
        (-[KWQAccObject textMarkerForVisiblePosition:]):
        (-[KWQAccObject visiblePositionForTextMarker:]):
        (-[KWQAccObject textMarkerRangeFromVisiblePositions:andEndPos:]):
        (-[KWQAccObject topDocument]):
        (-[KWQAccObject topRenderer]):
        (-[KWQAccObject topView]):
        (-[KWQAccObject accessibilityAttributeValue:]):
        (-[KWQAccObject accessibilityParameterizedAttributeNames]):
        (-[KWQAccObject doAXLineForTextMarker:]):
        (-[KWQAccObject doAXTextMarkerRangeForLine:]):
        (-[KWQAccObject doAXStringForTextMarkerRange:]):
        (-[KWQAccObject doAXTextMarkerForPosition:]):
        (-[KWQAccObject doAXBoundsForTextMarkerRange:]):
        (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]):
        (-[KWQAccObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
        (-[KWQAccObject doAXNextTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXPreviousTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXLeftWordTextMarkerRangeForTextMarker:]):
        (-[KWQAccObject doAXRightWordTextMarkerRangeForTextMarker:]):
        (-[KWQAccObject doAXLeftLineTextMarkerRangeForTextMarker:]):
        (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]):
        (-[KWQAccObject doAXSentenceTextMarkerRangeForTextMarker:]):
        (-[KWQAccObject doAXParagraphTextMarkerRangeForTextMarker:]):
        (-[KWQAccObject doAXNextWordEndTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXPreviousWordStartTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXNextSentenceEndTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXNextParagraphEndTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]):
        (-[KWQAccObject doAXLengthForTextMarkerRange:]):
        (-[KWQAccObject accessibilityAttributeValue:forParameter:]):
        (-[KWQAccObject accessibilityHitTest:]):
        (-[KWQAccObject accessibilityFocusedUIElement]):
        (-[KWQAccObject accessibilityIsAttributeSettable:]):
        (-[KWQAccObject doSetAXSelectedTextMarkerRange:]):
        (-[KWQAccObject setAccObjectID:]):
        (-[KWQAccObject removeAccObjectID]):
        * kwq/KWQAccObjectCache.h:
        * kwq/KWQAccObjectCache.mm:
        * kwq/KWQKHTMLPart.mm:
        * kwq/KWQTextUtilities.h:
        * kwq/KWQTextUtilities.mm:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge accessibilityTree]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave Hyatt
harrison [Thu, 6 Jan 2005 18:19:01 +0000 (18:19 +0000)]
    Reviewed by Dave Hyatt

        <rdar://problem/3588548> AX: tabbing does not work correctly with the screen reader and a focused link; need AXFocusedUIElement to work.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView accessibilityFocusedUIElement]):
        Implement this so that AppKit can use it from NSAccessibilityHandleFocusChanged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFix changelog
hyatt [Thu, 6 Jan 2005 00:46:40 +0000 (00:46 +0000)]
Fix changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Ken.
darin [Wed, 5 Jan 2005 22:56:46 +0000 (22:56 +0000)]
    Reviewed by Ken.

        - re-landing a subset of my custom tag change that does not fix the bug, but also does
          not introduce a performance regression

        * khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector): Changed
        some code that used ID_LAST_TAG in a slightly wrong, but harmless, way.

        * khtml/editing/htmlediting.cpp:
        (khtml::debugPosition): Use nodeName rather than getTagName, since the latter works for
        per-document tags and is just better all around for things like the document.
        (khtml::debugNode): Ditto.
        * khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Ditto.
        * khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
        * khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayNode): Ditto.
        * khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.

        * khtml/html/dtd.cpp: (DOM::checkChild): Use ID_LAST_TAG rather than 1000 for the check that allows
        non-HTML elements to be nested as desired.

        * khtml/misc/htmlhashes.h: Changed return types to unsigned short.
        * khtml/misc/htmlhashes.cpp:
        (khtml::getTagID): Changed return type to unsigned short.
        (khtml::getAttrID): Ditto.

        * khtml/xml/dom_docimpl.h: Added overload of createHTMLElement, made it non-virtual since it's not overriden.
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::createHTMLElement): Refactored into two separate functions, one that takes the tag ID.
        Also updated for a few tags that the parser handled but this did not.

        * kwq/KWQRenderTreeDebug.cpp:
        (getTagName): Added. Works for custom nodes, because it calls nodeName rather than using getTagName on
        the tag ID directly, which only works for standard nodes.
        (operator<<): Update to call getTagName.
        (nodePositionRelativeToRoot): Ditto.
        (writeSelection): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Hyatt
kocienda [Wed, 5 Jan 2005 22:43:16 +0000 (22:43 +0000)]
    Reviewed by Hyatt

        Fix for this bug:

        <rdar://problem/3941203> REGRESSION (Mail): Paste inserts content in wrong place

        * khtml/editing/htmlediting.cpp:
        (khtml::ReplaceSelectionCommand::doApply): Some cleanup and refinement of the concepts used to make
        this operation work correctly, particularly in the logic to figure out whether to merge content, and
        also performing merges.
        * khtml/editing/visible_position.cpp:
        (khtml::isFirstVisiblePositionInBlock): Simplification of test used to make this determination.
        * khtml/editing/visible_units.cpp:
        (khtml::isStartOfParagraph): New helper, used in khtml::ReplaceSelectionCommand::doApply().
        (khtml::isEndOfParagraph): Ditto.
        * khtml/editing/visible_units.h: Declare new functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8305 268f45cc-cd09-0410-ab3c-d52691b4dbfc