sullivan@apple.com [Tue, 14 Jun 2011 22:18:05 +0000 (22:18 +0000)]
<https://bugs.webkit.org/show_bug.cgi?id=62666>
<rdar://problem/
9606676>
Callers should be robust against WebImage::create() returning an image with a null snapshot
Reviewed by Dan Bernstein.
* Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateCGImage):
Return 0 if no bitmap was created.
(WKImageCreateFromCGImage):
Ditto.
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
Check for null before dereferencing image->bitmap() in two places.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates):
Return 0 if no bitmap was created.
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):
Ditto.
(WebKit::WebPage::createSnapshotOfVisibleContent):
Bail out if no bitmap was created.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 14 Jun 2011 22:07:25 +0000 (22:07 +0000)]
2011-06-14 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Turns out, inspector/cookie-parser.html can timeout out.
* platform/chromium/test_expectations.txt: Added expectation of TIMEOUT.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Jun 2011 21:51:29 +0000 (21:51 +0000)]
2011-06-14 Jeffrey Pfau <jpfau@apple.com>
Reviewed by David Hyatt.
Null dereference in WebCore::RenderBlock::splitFlow regarding use of multicol, inline-block, and spanning elements
https://bugs.webkit.org/show_bug.cgi?id=60028
Added test for spanning elements within an inline-block child of a multicol element.
* fast/multicol/span/span-as-nested-inline-block-child.html: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
* platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.
2011-06-14 Jeffrey Pfau <jpfau@apple.com>
Reviewed by David Hyatt.
Null dereference in WebCore::RenderBlock::splitFlow regarding use of multicol, inline-block, and spanning elements
https://bugs.webkit.org/show_bug.cgi?id=60028
Ensure that the parent block of a spanning element, if it is not itself
a multicol element, is not inline.
Test: fast/multicol/span/span-as-nested-inline-block-child.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::columnsBlockForSpanningElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 14 Jun 2011 21:39:32 +0000 (21:39 +0000)]
2011-06-14 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Add functions for encoding/decoding data with a known size and alignment
https://bugs.webkit.org/show_bug.cgi?id=62663
* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::decodeFixedLengthData):
* Platform/CoreIPC/ArgumentDecoder.h:
* Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::encodeFixedLengthData):
(CoreIPC::ArgumentEncoder::encodeVariableLengthData):
* Platform/CoreIPC/ArgumentEncoder.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 14 Jun 2011 20:51:11 +0000 (20:51 +0000)]
2011-06-14 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Record expectation of crash for inspector/cookie-parser.html.
* platform/chromium/test_expectations.txt: Recorded.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 14 Jun 2011 20:36:57 +0000 (20:36 +0000)]
2011-06-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
nrwt: handle worker exceptions cleanly
https://bugs.webkit.org/show_bug.cgi?id=62614
This change modifiers new-run-webkit-tests to handle exceptions
raised by worker threads better, by:
- capturing the worker's stack and logging it in the manager
- propagating the worker's exception in the caller correctly
- attempting to cancel the workers and clean up even when
we get an unexpected exception
* Scripts/webkitpy/layout_tests/layout_package/manager.py:
* Scripts/webkitpy/layout_tests/layout_package/worker.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 14 Jun 2011 20:35:15 +0000 (20:35 +0000)]
2011-06-14 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
REGRESSION: Drawing video into canvas gets about one frame every 5 seconds (AVFoundation)
https://bugs.webkit.org/show_bug.cgi?id=62655
No new tests; we don't have any media-engine specific tests.
AVAssetImageGenerator will, by default, return the nearest keyframe. To get the generator to return
the image from the current time instead of the nearest keyframe, set the requested time tolerance to
zero (which defaults to infinity).
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 14 Jun 2011 20:20:55 +0000 (20:20 +0000)]
2011-06-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Move string ArgumentCoder template specializations out into a .cpp file
https://bugs.webkit.org/show_bug.cgi?id=62660
* GNUmakefile.am:
* Platform/CoreIPC/ArgumentCoders.cpp: Added.
(CoreIPC::::encode):
(CoreIPC::::decode):
* Platform/CoreIPC/ArgumentCoders.h:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ericu@chromium.org [Tue, 14 Jun 2011 20:01:19 +0000 (20:01 +0000)]
2011-06-14 Eric Uhrhane <ericu@chromium.org>
Reviewed by Darin Fisher.
Clean up filesystem base path code.
https://bugs.webkit.org/show_bug.cgi?id=60218
Change a bunch of url-held-in-a-string parameters into real KURLS and
WebURLs.
No new tests--no change in functionality.
* fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createWriter):
(WebCore::DOMFileSystem::createFile):
* fileapi/DOMFileSystemBase.cpp:
(WebCore::DOMFileSystemBase::getMetadata):
(WebCore::DOMFileSystemBase::move):
(WebCore::DOMFileSystemBase::copy):
(WebCore::DOMFileSystemBase::remove):
(WebCore::DOMFileSystemBase::removeRecursively):
(WebCore::DOMFileSystemBase::getParent):
(WebCore::DOMFileSystemBase::getFile):
(WebCore::DOMFileSystemBase::getDirectory):
(WebCore::DOMFileSystemBase::readDirectory):
* fileapi/DOMFileSystemSync.cpp:
(WebCore::DOMFileSystemSync::createFile):
(WebCore::DOMFileSystemSync::createWriter):
* platform/AsyncFileSystem.cpp:
(WebCore::AsyncFileSystem::openFileSystem):
* platform/AsyncFileSystem.h:
(WebCore::AsyncFileSystem::AsyncFileSystem):
2011-06-14 Eric Uhrhane <ericu@chromium.org>
Reviewed by Darin Fisher.
Clean up filesystem base path code.
https://bugs.webkit.org/show_bug.cgi?id=60218
Change a bunch of url-held-in-a-string parameters into real KURLS and
WebURLs. Also add a #define to make it easier to stage this change, as
it involves both Chromium and WebKit changes that would ideally be
simultaneous.
No new tests--no change in functionality.
* public/WebFileSystem.h:
* public/WebFileSystemCallbacks.h:
* public/WebFrame.h:
* src/AsyncFileSystemChromium.cpp:
* src/AsyncFileSystemChromium.h:
* src/WebFileSystemCallbacksImpl.cpp:
* src/WebFileSystemCallbacksImpl.h:
* src/WebFrameImpl.cpp:
* src/WorkerAsyncFileSystemChromium.cpp:
* src/WorkerAsyncFileSystemChromium.h:
* src/WorkerAsyncFileWriterChromium.cpp:
* src/WorkerAsyncFileWriterChromium.h:
* src/WorkerFileSystemCallbacksBridge.cpp:
* src/WorkerFileSystemCallbacksBridge.h:
* src/WorkerFileWriterCallbacksBridge.cpp:
* src/WorkerFileWriterCallbacksBridge.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Tue, 14 Jun 2011 19:54:49 +0000 (19:54 +0000)]
Unreviewed.
VoiceOver cannot navigate the itunes album view table
https://bugs.webkit.org/show_bug.cgi?id=62335
Tables are not supported on Leopard for accessibility.
* platform/mac-leopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 14 Jun 2011 19:37:06 +0000 (19:37 +0000)]
2011-06-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Remove PluginInfoStore::Plugin typedef
https://bugs.webkit.org/show_bug.cgi?id=62657
* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::shouldUsePlugin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 14 Jun 2011 19:10:20 +0000 (19:10 +0000)]
2011-06-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Constant array literals result in unnecessarily large amounts of code
https://bugs.webkit.org/show_bug.cgi?id=62658
Add a new version of op_new_array that simply copies values from a buffer
we hang off of the CodeBlock, rather than generating code to place each
entry into the registerfile, and then copying it from the registerfile into
the array. This is a slight improvement on some sunspider tests, but no
measurable overall change. That's okay though as our goal was to reduce
code size without hurting performance.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addImmediateBuffer):
(JSC::CodeBlock::immediateBuffer):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addImmediateBuffer):
(JSC::BytecodeGenerator::emitNewArray):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_array):
(JSC::JIT::emit_op_new_array_buffer):
* jit/JITOpcodes32_64.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Jun 2011 18:48:55 +0000 (18:48 +0000)]
2011-06-14 Wyatt Carss <wcarss@google.com>
Reviewed by Ryosuke Niwa.
dump-as-text conversion: editing/deleting/
5300379.html
https://bugs.webkit.org/show_bug.cgi?id=62620
Converted from pixel test to dump-as-text. This tests that delete backward
by word does not hang inside an empty div, and that delete backward by word
deletes exactly one word.
* editing/deleting/
5300379-expected.txt: Added.
* editing/deleting/
5300379.html:
* platform/chromium-win/editing/deleting/
5300379-expected.txt: Removed.
* platform/chromium-win/editing/deleting/
5300379-expected.png: Removed.
* platform/gtk/editing/deleting/
5300379-expected.txt: Removed.
* platform/gtk/editing/deleting/
5300379-expected.png: Removed.
* platform/mac/editing/deleting/
5300379-expected.txt: Removed.
* platform/mac/editing/deleting/
5300379-expected.png: Removed.
* platform/qt/editing/deleting/
5300379-expected.txt: Removed.
* platform/qt/editing/deleting/
5300379-expected.png: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 14 Jun 2011 18:45:33 +0000 (18:45 +0000)]
2011-06-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Create the PluginModuleInfo class and reverse the typedef so that PluginInfoStore::Plugin is now a typedef
https://bugs.webkit.org/show_bug.cgi?id=62654
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
(WebKit::PluginInfoStore::loadPlugin):
(WebKit::PluginInfoStore::findPluginForMIMEType):
(WebKit::PluginInfoStore::findPluginForExtension):
(WebKit::PluginInfoStore::findPlugin):
(WebKit::PluginInfoStore::infoForPluginWithPath):
* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::getPluginProcessConnection):
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy):
* UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::shouldUsePlugin):
* UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::shouldUsePlugin):
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::isOldWindowsMediaPlayerPlugin):
(WebKit::isNewWindowsMediaPlayerPlugin):
(WebKit::PluginInfoStore::shouldUsePlugin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
qi.2.zhang@nokia.com [Tue, 14 Jun 2011 18:44:25 +0000 (18:44 +0000)]
2011-06-14 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
https://bugs.webkit.org/show_bug.cgi?id=62227
* platform/qt/Skipped:
2011-06-14 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
https://bugs.webkit.org/show_bug.cgi?id=62227
QtWebkit does not yet support different CacheModels. This change will
expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setCacheModel):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Jun 2011 18:32:36 +0000 (18:32 +0000)]
2011-06-14 James Robinson <jamesr@chromium.org>
Reviewed by Stephen White.
[chromium] Compositor shader initialization is inefficient
https://bugs.webkit.org/show_bug.cgi?id=62618
This fixes several issues causing slowdowns in compositor shader initialization, mostly due to lack of
parallelism:
- Avoid initializing all programs eagerly. We only use two programs on every page, the other programs depend on
content and are constructed on demand.
- Defer querying uniform locations until draw time. For the eagerly constructed programs (render surface +
tiler) this means that the GPU process has a chance to compile the shader while the renderer is busy
painting+uploading instead of blocking on shader compilation in order to get uniform locations.
- Calls to query COMPILE_STATUS/LINK_STATUS moved behind #ifndef NDEBUG guards since these should never fail in
release builds and force synchronous compilation/linking.
This also adds a number of TRACE_EVENT()s to make analysing the performance of this bit of code easier.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::borderProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::tilerProgram):
(WebCore::LayerRendererChromium::canvasLayerProgram):
(WebCore::LayerRendererChromium::pluginLayerProgram):
(WebCore::LayerRendererChromium::videoLayerRGBAProgram):
(WebCore::LayerRendererChromium::videoLayerYUVProgram):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTextureSubImage.cpp:
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
* platform/graphics/chromium/ProgramBinding.cpp:
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::loadShader):
(WebCore::ProgramBindingBase::createShaderProgram):
* platform/graphics/chromium/ProgramBinding.h:
(WebCore::ProgramBinding::ProgramBinding):
(WebCore::ProgramBinding::initialize):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderPosTex::init):
(WebCore::VertexShaderPosTexYUVStretch::init):
(WebCore::VertexShaderPos::init):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::FragmentTexAlphaBinding::init):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderYUVVideo::init):
(WebCore::FragmentShaderColor::init):
* platform/graphics/chromium/ShaderChromium.h:
2011-06-14 James Robinson <jamesr@chromium.org>
Reviewed by Stephen White.
[chromium] Compositor shader initialization is inefficient
https://bugs.webkit.org/show_bug.cgi?id=62618
Add a TRACE_EVENT() around initial compositor initialization.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Jun 2011 18:31:03 +0000 (18:31 +0000)]
2011-06-14 Claudio Saavedra <csaavedra@igalia.com>
Reviewed by Xan Lopez.
Broken reference to webkitsoupauthdialog.c
https://bugs.webkit.org/show_bug.cgi?id=62650
* POTFILES: Fix reference to webkitsoupauthdialog.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Tue, 14 Jun 2011 18:30:39 +0000 (18:30 +0000)]
<rdar://problem/
9511169>
Update order files.
Rubber stamped by Oliver Hunt.
Source/JavaScriptCore:
* JavaScriptCore.order:
Source/WebCore:
Build system change, no change in functionality so no new tests.
* WebCore.order:
Source/WebKit/mac:
* WebKit.order:
Source/WebKit2:
* mac/WebKit2.order:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Tue, 14 Jun 2011 18:20:28 +0000 (18:20 +0000)]
Source/WebCore: VoiceOver cannot navigate the iTunes album view table
https://bugs.webkit.org/show_bug.cgi?id=62335
Reviewed by David Kilzer.
This is a regression from https://bugs.webkit.org/show_bug.cgi?id=57463.
Part of that patch made a change so that an ARIA table will only look at it's children and grandchildren
for possible rows. That however, doesn't allow arbitrary hierarchies to work with ARIA, like in iTunes album view.
Test: platform/mac/accessibility/aria-grid-with-strange-hierarchy.html
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addChild):
(WebCore::AccessibilityARIAGrid::addChildren):
* accessibility/AccessibilityARIAGrid.h:
LayoutTests: VoiceOver cannot navigate the itunes album view table
https://bugs.webkit.org/show_bug.cgi?id=62335
Reviewed by David Kilzer.
* platform/mac/accessibility/aria-grid-with-strange-hierarchy-expected.txt: Added.
* platform/mac/accessibility/aria-grid-with-strange-hierarchy.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Tue, 14 Jun 2011 18:17:21 +0000 (18:17 +0000)]
2011-06-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88823.
http://trac.webkit.org/changeset/88823
https://bugs.webkit.org/show_bug.cgi?id=62652
Broke the Lion build (Requested by estes on #webkit).
* platform/mac/MemoryPressureHandlerMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 14 Jun 2011 18:03:08 +0000 (18:03 +0000)]
2011-06-14 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Start replacing PluginInfoStore::Plugin with PluginModuleInfo
https://bugs.webkit.org/show_bug.cgi?id=62651
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::plugins):
(WebKit::PluginInfoStore::findPluginForMIMEType):
(WebKit::PluginInfoStore::findPluginForExtension):
(WebKit::PluginInfoStore::infoForPluginWithPath):
* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::getPluginProcessConnection):
(WebKit::PluginProcessManager::getSitesWithData):
(WebKit::PluginProcessManager::clearSiteData):
(WebKit::PluginProcessManager::getOrCreatePluginProcess):
* UIProcess/Plugins/PluginProcessManager.h:
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::create):
* UIProcess/Plugins/PluginProcessProxy.h:
(WebKit::PluginProcessProxy::pluginInfo):
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::pluginNeedsExecutableHeap):
(WebKit::PluginProcessProxy::createPropertyListFile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Tue, 14 Jun 2011 17:54:55 +0000 (17:54 +0000)]
2011-06-14 Michael Saboff <msaboff@apple.com>
Reviewed by Joseph Pecoraro.
Incorrect #if[n]def for building without DISPATCH_VM_PRESSURE
https://bugs.webkit.org/show_bug.cgi?id=62649
The #ifdef DISPATCH_VM_PRESSURE actually needs to be #ifndef
to handle when DISPATCH_VM_PRESSURE is NOT defined in the
system header files.
No functional changes, fixing build issue therefore no tests.
* platform/mac/MemoryPressureHandlerMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 14 Jun 2011 17:44:45 +0000 (17:44 +0000)]
2011-06-13 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Disable drawing for huge mask layers
https://bugs.webkit.org/show_bug.cgi?id=62607
* platform/chromium/compositing/huge-mask-layer-expected.txt: Added.
* platform/chromium/compositing/huge-mask-layer.html: Added.
2011-06-13 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Disable drawing for huge mask layers
https://bugs.webkit.org/show_bug.cgi?id=62607
Because masks have a different layer size than the layer they are
masking, they are untiled. If they are too large to be contained
within a single texture, then they should just be disabled.
Test: platform/chromium/compositing/huge-mask-layer.html
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::drawsContent):
(WebCore::ContentLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/LayerTilerChromium.h:
(WebCore::LayerTilerChromium::getSingleTexture):
(WebCore::LayerTilerChromium::numTiles):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 14 Jun 2011 17:41:02 +0000 (17:41 +0000)]
Fix dumping of constants to have the correct constant number.
Reviewed by Geoffrey Garen.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 14 Jun 2011 17:37:25 +0000 (17:37 +0000)]
2011-06-14 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Add PluginModuleInfo header and prepare for renaming of PluginInfoStore::Plugin to PluginModuleInfo
https://bugs.webkit.org/show_bug.cgi?id=62647
Make PluginModuleInfo a typedef of PluginInfoStore::Plugin for now; eventually it should be its own class,
and PluginInfoStore::Plugin should go away.
* GNUmakefile.am:
* Shared/Plugins/Netscape/NetscapePluginModule.h:
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginArchitecture):
(WebKit::getMIMETypesFromPluginBundle):
(WebKit::getPluginInfoFromPropertyLists):
(WebKit::getPluginInfoFromCarbonResources):
(WebKit::NetscapePluginModule::getPluginInfo):
(WebKit::NetscapePluginModule::determineQuirks):
* Shared/Plugins/PluginModuleInfo.cpp: Added.
* Shared/Plugins/PluginModuleInfo.h: Added.
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 14 Jun 2011 17:20:20 +0000 (17:20 +0000)]
2011-06-14 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Add expectations for flaky tests.
* platform/chromium/test_expectations.txt: Recorded flakiness.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Jun 2011 17:13:03 +0000 (17:13 +0000)]
2011-06-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [Symbian] GraphicsLayer: support plugins on symbian
https://bugs.webkit.org/show_bug.cgi?id=57418
Implement graphics layer for plugins on Symbian.
* plugins/PluginView.h:
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::shouldUseAcceleratedCompositing):
(WebCore::PluginView::platformStart):
* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::paint):
(WebCore::PluginView::shouldUseAcceleratedCompositing):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Jun 2011 17:03:38 +0000 (17:03 +0000)]
2011-06-14 Sreeram Ramachandran <sreeram@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Allow the console to persist on page refresh or navigation
https://bugs.webkit.org/show_bug.cgi?id=53359
Tests that console messages are preserved upon navigation.
* inspector/console/console-preserve-log-expected.txt: Added.
* inspector/console/console-preserve-log.html: Added.
2011-06-14 Sreeram Ramachandran <sreeram@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Allow the console to persist on page refresh or navigation
https://bugs.webkit.org/show_bug.cgi?id=53359
Adds a context menu checkbox to preserve the console log across
navigations. However, the underlying messages and objects are actually
deleted from the backend, so they are not expandable; their continued
display in the console frontend is merely cosmetic.
Test: inspector/console/console-preserve-log.html
* English.lproj/localizedStrings.js:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messagesCleared):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
(WebInspector.ConsoleView.prototype.requestClearMessages):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.preserveLogItemAction):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/inspector.js:
(WebInspector.reset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 14 Jun 2011 16:46:49 +0000 (16:46 +0000)]
2011-06-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
WebFrame::url() should use the one true URL
https://bugs.webkit.org/show_bug.cgi?id=62610
The Document's URL is the one true URL. Thou shalt have no URLs before
Document::url().
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::url):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Jun 2011 16:29:17 +0000 (16:29 +0000)]
2011-06-14 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Eric Seidel.
[CMAKE] Add ENABLE_TOUCH_ICON_LOADING feature.
https://bugs.webkit.org/show_bug.cgi?id=62604
Add feature to enable or disable ENABLE_TOUCH_ICON which supports
apple-touch-icon and apple-touch-icon-precomposed in link tag.
* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 14 Jun 2011 16:25:29 +0000 (16:25 +0000)]
2011-06-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add tooltip to file select options in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=62537
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
2011-06-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add tooltip to file select options in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=62537
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._sourceFileAdded):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.compare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Jun 2011 16:25:04 +0000 (16:25 +0000)]
2011-06-14 Benjamin Poulain <benjamin@webkit.org>
Reviewed by Eric Seidel.
KeywordLookupGenerator's Trie does not work with Python 3
https://bugs.webkit.org/show_bug.cgi?id=62635
With Python 3, dict.items() return an iterator. Since the iterator
protocol changed between Python 2 and 3, the easiest way to get the
values is to have something that use the iterator implicitely, like a
for() loop.
* KeywordLookupGenerator.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ademar.reis@openbossa.org [Tue, 14 Jun 2011 15:56:25 +0000 (15:56 +0000)]
Unreviewed: unskip test rebasedlined by r88772
[Qt] Rebaseline http/tests/misc/slow-loading-image-in-pattern.html after r69386 and r83871
http://trac.webkit.org/changeset/88772
The test was rebaselined but the committer forgot to remove it from
the Skip list.
* platform/qt/Skipped: unskip test
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 14 Jun 2011 15:48:47 +0000 (15:48 +0000)]
2011-06-14 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Implement CSS border radius properies in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=62265
No new tests / refactoring only.
* css/CSSStyleApplyProperty.cpp:
Implement new class to culculate border radius, initialize for appropriate properties.
(WebCore::ApplyPropertyBorderRadius::ApplyPropertyBorderRadius):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
Remove old implementations.
(WebCore::CSSStyleSelector::applyProperty):
* page/animation/AnimationBase.cpp:
Pass LengthSize by value.
(WebCore::AnimationBase::ensurePropertyMap):
* rendering/style/RenderStyle.h:
Pass LengthSize by value consistently.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Tue, 14 Jun 2011 15:46:24 +0000 (15:46 +0000)]
2011-06-14 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Implement CSS border radius properies in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=62265
No new tests / refactoring only.
* css/CSSStyleApplyProperty.cpp:
Implement new class to culculate border radius, initialize for appropriate properties.
(WebCore::ApplyPropertyBorderRadius::ApplyPropertyBorderRadius):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
Remove old implementations.
(WebCore::CSSStyleSelector::applyProperty):
* page/animation/AnimationBase.cpp:
Pass LengthSize by value.
(WebCore::AnimationBase::ensurePropertyMap):
* rendering/style/RenderStyle.h:
Pass LengthSize by value consistently.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 14 Jun 2011 15:03:51 +0000 (15:03 +0000)]
2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Move the code to show the context menu from WebKitWebViewBase to WebContextMenuProxyGtk
https://bugs.webkit.org/show_bug.cgi?id=62627
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::showContextMenu):
(WebKit::WebContextMenuProxyGtk::hideContextMenu):
(WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk):
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk):
(WebKit::WebContextMenuProxyGtk::menuPositionFunction):
* UIProcess/gtk/WebContextMenuProxyGtk.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 14 Jun 2011 14:58:30 +0000 (14:58 +0000)]
2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
https://bugs.webkit.org/show_bug.cgi?id=62626
The method actually converts coordinates, the rectangle size is
not affected, so it can be modified to return a point
instead. Fix also a bug in the implementation, it was translating
the coordinates twice returning the wrong position when the given
rectangle was not at 0,0.
* platform/gtk/GtkUtilities.cpp:
(WebCore::convertWidgetPointToScreenPoint):
* platform/gtk/GtkUtilities.h:
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::show): Use
convertWidgetPointToScreenPoint().
2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
https://bugs.webkit.org/show_bug.cgi?id=62626
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::windowToScreen): Update to use
convertWidgetPointToScreenPoint()
(WebKit::ChromeClient::screenToWindow): Ditto.
* webkit/webkitwebview.cpp: Remove globalPointForClientPoint()
since it does the same than convertWidgetPointToScreenPoint().
(webkit_web_view_popup_menu_handler): Use
convertWidgetPointToScreenPoint() instead of globalPointForClientPoint().
(doDragLeaveLater): Ditto.
(webkit_web_view_drag_motion): Ditto.
(webkit_web_view_drag_data_received): Ditto.
(webkit_web_view_drag_drop): Ditto.
2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
https://bugs.webkit.org/show_bug.cgi?id=62626
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::screenToWindow): Implement this method
using convertWidgetPointToScreenPoint().
(WebKit::PageClientImpl::windowToScreen): Update to use
convertWidgetPointToScreenPoint().
* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use
convertWidgetPointToScreenPoint().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Tue, 14 Jun 2011 14:38:30 +0000 (14:38 +0000)]
Unreviewed.
<progress> should support :indeterminate pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=62430
Skip new tests since Windows port does not support the progress element.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 14 Jun 2011 14:36:50 +0000 (14:36 +0000)]
2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Support authentication dialogs in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62366
Add a new class to show an authentication dialog that is used by
both WebKit1 and WebKit2.
* GNUmakefile.list.am: Add new files to compilation.
* platform/gtk/GtkAuthenticationDialog.cpp: Added.
(WebCore::addEntryToTable):
(WebCore::sessionCanSavePasswords):
(WebCore::GtkAuthenticationDialog::~GtkAuthenticationDialog):
(WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog):
(WebCore::getSavedLogin):
(WebCore::GtkAuthenticationDialog::show):
(WebCore::GtkAuthenticationDialog::destroy):
(WebCore::GtkAuthenticationDialog::savePasswordCallback):
(WebCore::GtkAuthenticationDialog::savePassword):
(WebCore::GtkAuthenticationDialog::authenticate):
(WebCore::GtkAuthenticationDialog::authenticationDialogResponseCallback):
* platform/gtk/GtkAuthenticationDialog.h: Added.
2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Support authentication dialogs in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62366
Move the common code of webkitsoupauthdialog to a common C++ class
in WebCore so that it can be used by WebKit2 too. The file has
been converted into a C++ file.
* GNUmakefile.am: Rename webkitsoupauthdialog.c to
webkitsoupauthdialog.cpp.
* webkit/webkitsoupauthdialog.c: Removed.
* webkit/webkitsoupauthdialog.cpp: Added.
(webkit_soup_auth_dialog_class_init):
(webkit_soup_auth_dialog_init):
(webkit_soup_auth_dialog_session_feature_init):
(sessionAuthenticate): Use GtkAuthenticationDialog object from
WebCore.
(attach):
(detach):
* webkit/webkitsoupauthdialog.h:
2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Support authentication dialogs in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62366
Add a new soup feature to show an authentication dialog when it
gets a 401 HTTP response.
* GNUmakefile.am: Add new files to compilation.
* WebProcess/gtk/WebAuthDialog.cpp: Added.
(web_auth_dialog_class_init):
(web_auth_dialog_init):
(sessionAuthenticate):
(attach):
(detach):
(webAuthDialogSessionFeatureInit):
* WebProcess/gtk/WebAuthDialog.h: Added.
* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Jun 2011 14:07:55 +0000 (14:07 +0000)]
2011-06-14 No'am Rosenthal <noam.rosenthal@nokia.com> and Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935
Implementing LayerTreeHost and LayerTreeContext and LayerTreeHost for Qt.
Add the necessary plumbing to make the LayerTreeHost work with Qt, based on the original Mac
implementation (the code is nearly identical). This includes creating the right layers for the
overlay and for the non-composited content, and passing the root layer to the UI process.
Also, since LayerTreeHostQt is compiled, we have to add some of the rest of the existing patches,
namely the new messages: syncCompositingLayers and updateCompositingLayerContent, and create a
stub implementation for them in DrawingAreaProxy.
Note that this is not activated yet, until we enable accelerated compositing in the settings and
create the right GraphicsLayer.
* Scripts/webkit2/messages.py:
* Shared/LayerTreeContext.h:
* Shared/qt/LayerTreeContextQt.cpp:
(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::syncCompositingLayers):
(WebKit::DrawingAreaProxy::updateCompositingLayerContent):
* UIProcess/DrawingAreaProxy.messages.in:
* WebKit2.pro:
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::collectCompositingInfoForThisLayer):
* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::create):
(WebKit::LayerTreeHostQt::~LayerTreeHostQt):
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeHostQt::scheduleLayerFlush):
(WebKit::LayerTreeHostQt::cancelPendingLayerFlush):
(WebKit::LayerTreeHostQt::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):
(WebKit::LayerTreeHostQt::invalidate):
(WebKit::LayerTreeHostQt::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostQt::scrollNonCompositedContents):
(WebKit::LayerTreeHostQt::forceRepaint):
(WebKit::LayerTreeHostQt::sizeDidChange):
(WebKit::LayerTreeHostQt::didInstallPageOverlay):
(WebKit::LayerTreeHostQt::didUninstallPageOverlay):
(WebKit::LayerTreeHostQt::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit::LayerTreeHostQt::performScheduledLayerFlush):
(WebKit::LayerTreeHostQt::layerFlushTimerFired):
(WebKit::LayerTreeHostQt::createPageOverlayLayer):
(WebKit::LayerTreeHostQt::destroyPageOverlayLayer):
(WebKit::LayerTreeHostQt::notifyAnimationStarted):
(WebKit::LayerTreeHostQt::notifySyncRequired):
(WebKit::LayerTreeHostQt::paintContents):
(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
* WebProcess/WebPage/qt/LayerTreeHostQt.h: Added.
(WebKit::LayerTreeHostQt::layerTreeContext):
(WebKit::LayerTreeHostQt::pauseRendering):
(WebKit::LayerTreeHostQt::resumeRendering):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Jun 2011 13:58:11 +0000 (13:58 +0000)]
2011-06-14 Tommy Widenflycht <tommyw@google.com>
Reviewed by Tony Gentilcore.
Media Stream PeerConnection API: adding the StreamList and supporting classes.
https://bugs.webkit.org/show_bug.cgi?id=61539
* dom/StreamContainer.h: Added.
(WebCore::StreamContainer::create):
(WebCore::StreamContainer::~StreamContainer):
(WebCore::StreamContainer::length):
(WebCore::StreamContainer::item):
(WebCore::StreamContainer::add):
(WebCore::StreamContainer::remove):
(WebCore::StreamContainer::contains):
(WebCore::StreamContainer::get):
(WebCore::StreamContainer::StreamContainer):
* dom/StreamList.cpp: Added.
(WebCore::StreamList::create):
(WebCore::StreamList::StreamList):
(WebCore::StreamList::~StreamList):
(WebCore::StreamList::length):
(WebCore::StreamList::item):
* dom/StreamList.h: Added.
* dom/StreamList.idl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Tue, 14 Jun 2011 13:54:29 +0000 (13:54 +0000)]
2011-06-14 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935
Add a createImage() function to ShareableBitmap, for now ifdef'ed to Qt only.
This allows us to support directly composited images across the WebKit2 processes.
Together with Viatcheslav Ostapenko.
* Shared/ShareableBitmap.h:
* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createQImage):
(WebKit::ShareableBitmap::createImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Tue, 14 Jun 2011 13:53:38 +0000 (13:53 +0000)]
2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319
Increase the likeness that JSElements are converted to QWebElements. When hinted
with QWebElement metatype, we qualify the conversion from JSElement as a "perfect
match".
The test was failing because the wrong slot was called, since the QWebElement
match was taken as equal to the others and not chosen when the metacall happened.
We also remove the implicit conversion between JSDocument (which is not an
element) to QWebElement. The conversion only worked for calling slots, while
without hint it returned a QVariantMap (as can be seen in domCycles test). It was
added for supporting DRT, but since this change we can use it as QVariantMap and
get the value for "documentElement".
This patch is based on Noam Rosenthal original patch in the same bug.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::hintForRealType):
Extracted function to choose the metatype hint based on the JSValue type. Add
QWebElement metatype as a hint for JSElement objects, this way if no hint is
provided, JSElement objects will always be converted to QWebElements.
(JSC::Bindings::convertValueToQVariant):
Use previous function. Identify the conversion between JSElement to QWebElement
as a "perfect match" (dist = 0). And remove the implicit conversion when the hint
is QWebElement metatype and we have a JSDocument. Changed from JSHTMLElement to
JSElement to cover the 'documentElement'.
2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319
Since the implicit conversion was removed, change support functions of DRT to
expect a QVariantMap instead of a QWebElement. This matches the exposed function
in the controller, which takes 'document' and not 'document.documentElement'.
And now that Element -> QWebElement is a perfect match, we must use QWebElement
instead of QVariantMap, like in plainText().
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::plainText): Fix to use QWebElement instead of
QVariantMap when getting the startContainer. Also use QVariantMap directly,
bridge will do conversion for us now.
(getCoreDocumentFromVariantMap): Extracts the WebCore::Document* from the
QVariantMap that Qt bridge gives us when 'document' is passed from JS.
(DumpRenderTreeSupportQt::nodesFromRect): Use helper function.
* tests/qwebframe/tst_qwebframe.cpp: Splitted the test domCycles() into two
different tests. In practice, the original test just checked whether we could
create a QVariantMap representing 'document' without infinite looping due to
cycles in the DOM. This was more evident before since we haven't a conversion
from JSElement to QWebElement, but from JSElement to QVariantMap.
(tst_QWebFrame::documentHasDocumentElement): Evaluates 'document' and extracts
'documentElement' from it. Compares to QWebFrame::documentElement().
(tst_QWebFrame::documentAllHasDocumentElement): Look inside 'document.all' for
the documentElement.
(tst_QWebFrame::overloadedSlots): Remove expected failure and fix wrong comment.
2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319
Since we don't implictly convert 'document' object to QWebElement
in metacalls anymore, change the controller to expect QVariantMap instead.
The method plainText() was updated to use QVariantMap as well to let the bridge
do the conversion directly for us.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::nodesFromRect):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/qt/PlainTextControllerQt.cpp:
(PlainTextController::plainText):
* DumpRenderTree/qt/PlainTextControllerQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 14 Jun 2011 13:42:40 +0000 (13:42 +0000)]
2011-06-14 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Don't include convenience "QWebFoo" headers in WebKit code.
https://bugs.webkit.org/show_bug.cgi?id=62632
* WebCoreSupport/FrameNetworkingContextQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 14 Jun 2011 13:27:27 +0000 (13:27 +0000)]
2011-06-14 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
Remove some unnecessary includes.
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Tue, 14 Jun 2011 13:22:18 +0000 (13:22 +0000)]
2011-06-14 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kent Tamura.
<progress> should support :indeterminate pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=62430
* fast/dom/HTMLProgressElement/indeterminate-progress-001.html: Added.
* fast/dom/HTMLProgressElement/indeterminate-progress-002-expected.txt: Added.
* fast/dom/HTMLProgressElement/indeterminate-progress-002.html: Added.
* platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Added.
* platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
* platform/chromium/test_expectations.txt:
2011-06-14 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kent Tamura.
<progress> should support :indeterminate pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=62430
Add support for :indeterminate pseudo class for progress element.
Tests: fast/dom/HTMLProgressElement/indeterminate-progress-001.html
fast/dom/HTMLProgressElement/indeterminate-progress-002.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::isDeterminate):
(WebCore::HTMLProgressElement::didElementStateChange):
* html/HTMLProgressElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 14 Jun 2011 12:53:31 +0000 (12:53 +0000)]
2011-06-14 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: reload from within inspector window does not work while debugger is paused.
https://bugs.webkit.org/show_bug.cgi?id=62631
* inspector/debugger/debugger-reload-on-pause-expected.txt: Added.
* inspector/debugger/debugger-reload-on-pause.html: Added.
2011-06-14 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: reload from within inspector window does not work while debugger is paused.
https://bugs.webkit.org/show_bug.cgi?id=62631
Test: inspector/debugger/debugger-reload-on-pause.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Tue, 14 Jun 2011 12:32:08 +0000 (12:32 +0000)]
2011-06-14 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
https://bugs.webkit.org/show_bug.cgi?id=62630
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New): remove dead variable 'forceCarbon'
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 10:15:46 +0000 (10:15 +0000)]
2011-06-14 Kent Tamura <tkent@chromium.org>
[Chromium] Test expectation update for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920
* platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-linux/fast/forms/input-appearance-range-expected.png: Added.
* platform/chromium-linux/fast/forms/slider-thumb-stylability-expected.png: Removed.
* platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png:
* platform/chromium-linux/fast/multicol/client-rects-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/forms/box-shadow-override-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-range-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.png: Added.
* platform/chromium-mac/fast/forms/box-shadow-override-expected.txt: Added.
* platform/chromium-mac/fast/forms/input-appearance-height-expected.png: Added.
* platform/chromium-mac/fast/forms/input-appearance-height-expected.txt: Added.
* platform/chromium-mac/fast/forms/input-appearance-range-expected.png: Added.
* platform/chromium-mac/fast/forms/thumbslider-no-parent-slider-expected.png:
* platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-range-expected.png: Added.
* platform/chromium-win/fast/forms/input-appearance-range-expected.txt: Added.
* platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt:
* platform/chromium-win/fast/forms/slider-padding-expected.txt:
* platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt:
* platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png:
* platform/chromium-win/fast/forms/slider-thumb-stylability-expected.txt: Removed.
* platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png:
* platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt.
* platform/chromium-win/fast/multicol/client-rects-expected.txt:
* platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 14 Jun 2011 09:49:59 +0000 (09:49 +0000)]
2011-06-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Support for painting thumb of media slider
https://bugs.webkit.org/show_bug.cgi?id=62174
Replace RenderObject parameter with RenderStyle's in adjustSliderThumbSize.
Because, parameter of the function was changed. And, add constant variable to
paintMediaSliderThumb().
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::adjustSliderThumbSize):
(WebCore::RenderThemeEfl::paintMediaSliderThumb):
* platform/efl/RenderThemeEfl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 09:22:41 +0000 (09:22 +0000)]
2011-06-14 Kent Tamura <tkent@chromium.org>
[Qt] Attempt to fix a build break by r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintSliderTrack):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 14 Jun 2011 08:36:20 +0000 (08:36 +0000)]
2011-06-14 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping test failing in the GTK bots.
* platform/gtk/Skipped: Skipped test
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 14 Jun 2011 08:13:02 +0000 (08:13 +0000)]
2011-06-14 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, added new baselines for GTK needed after r88266.
* platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
* platform/gtk/svg/custom/invalid-dasharray-expected.png: Added.
* platform/gtk/svg/custom/invalid-dasharray-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 14 Jun 2011 08:03:05 +0000 (08:03 +0000)]
2011-06-14 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping tests crashing in the GTK bots.
* platform/gtk/Skipped: Skipped tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 07:53:30 +0000 (07:53 +0000)]
2011-06-14 Kent Tamura <tkent@chromium.org>
[Mac-WK2] Rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920
* platform/mac-wk2/media/controls-without-preload-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 06:44:09 +0000 (06:44 +0000)]
2011-06-13 Kent Tamura <tkent@chromium.org>
[Win] More rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920
* platform/win/media/audio-repaint-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Tue, 14 Jun 2011 06:31:18 +0000 (06:31 +0000)]
2011-06-13 Hayato Ito <hayato@chromium.org>
Reviewed by Ojan Vafai.
[NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
https://bugs.webkit.org/show_bug.cgi?id=59188
A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
WebKitDriver should always return an actual hash value if DRT returns that.
No tests since I'll add sample reftests to make sure mismatch reftests work later,
which should be in a separate patch.
* Scripts/webkitpy/layout_tests/port/webkit.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 05:55:56 +0000 (05:55 +0000)]
2011-06-13 Kent Tamura <tkent@chromium.org>
More Leopard and GTK rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920
* platform/gtk/fast/forms/input-appearance-range-expected.txt: Added.
* platform/mac-leopard/media/audio-repaint-expected.txt: Added.
* platform/mac-leopard/media/media-document-audio-repaint-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 05:42:57 +0000 (05:42 +0000)]
2011-06-13 Kent Tamura <tkent@chromium.org>
[Win] Rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920
* platform/win/media/audio-controls-rendering-expected.txt:
* platform/win/media/controls-after-reload-expected.txt:
* platform/win/media/controls-strict-expected.txt:
* platform/win/media/controls-styling-expected.txt:
* platform/win/media/controls-without-preload-expected.txt:
* platform/win/media/media-document-audio-repaint-expected.txt:
* platform/win/media/video-controls-rendering-expected.txt:
* platform/win/media/video-display-toggle-expected.txt:
* platform/win/media/video-no-audio-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 05:25:21 +0000 (05:25 +0000)]
2011-06-13 Kent Tamura <tkent@chromium.org>
[Chromium-win] Fix two wrong assertions exposed by r88757.
* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
(WebThemeEngineDRTWin::paintTrackbar):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 05:15:25 +0000 (05:15 +0000)]
2011-06-13 Kent Tamura <tkent@chromium.org>
[GTK] Rebaseline for r88757.
* platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt:
* platform/gtk/fast/forms/slider-padding-expected.txt:
* platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt:
* platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
* platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
* platform/gtk/fast/layers/video-layer-expected.txt:
* platform/gtk/fast/multicol/client-rects-expected.txt:
* platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/audio-repaint-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-expected.txt:
* platform/gtk/media/controls-without-preload-expected.txt:
* platform/gtk/media/media-document-audio-repaint-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-zoom-controls-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Jun 2011 05:07:08 +0000 (05:07 +0000)]
2011-06-13 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Eric Seidel.
[Qt] Rebaseline http/tests/misc/slow-loading-image-in-pattern.html after r69386 and r83871
https://bugs.webkit.org/show_bug.cgi?id=62125
Rebaseline LayoutTests/platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt after r69386 and r83871
* platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Tue, 14 Jun 2011 05:02:58 +0000 (05:02 +0000)]
2011-06-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
[Qt] Pass prototype-inheritance-2.html LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=62224
Fix the expected result and remove the test from the Skipped list.
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 05:00:07 +0000 (05:00 +0000)]
2011-06-13 Kent Tamura <tkent@chromium.org>
[Mac] Leopard expectation files for r88757.
* platform/mac-leopard/media/controls-after-reload-expected.txt:
* platform/mac-leopard/media/controls-strict-expected.txt:
* platform/mac-leopard/media/controls-styling-expected.txt:
* platform/mac-leopard/media/controls-without-preload-expected.txt:
* platform/mac-leopard/media/video-controls-rendering-expected.txt:
* platform/mac-leopard/media/video-display-toggle-expected.txt:
* platform/mac-leopard/media/video-no-audio-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 04:53:00 +0000 (04:53 +0000)]
2011-06-13 Kent Tamura <tkent@chromium.org>
[Mac] Rebaseline for r88757.
* media/audio-repaint-expected.txt:
* media/media-document-audio-repaint-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 14 Jun 2011 04:45:42 +0000 (04:45 +0000)]
Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
and commit queue happy.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 14 Jun 2011 04:34:40 +0000 (04:34 +0000)]
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Fix a typo in Mac WebKit2's skipped list.
svg/custom/focus-event-handling-keyboard's extension is xhtml, not html.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 14 Jun 2011 04:29:49 +0000 (04:29 +0000)]
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Skip editing/pasteboard/smart-paste-004.html per bug 61633.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 14 Jun 2011 04:23:35 +0000 (04:23 +0000)]
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Chromium test expectation update; svg/css/group-with-shadow.svg is passing on
Windows Vista and Windows 7.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 04:15:14 +0000 (04:15 +0000)]
2011-06-13 Kent Tamura <tkent@chromium.org>
[EFL] The second try to fix a build break.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 04:08:38 +0000 (04:08 +0000)]
2011-06-13 Kent Tamura <tkent@chromium.org>
[EFL] Fix a typo.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 04:07:30 +0000 (04:07 +0000)]
2011-06-13 Kent Tamura <tkent@chromium.org>
[EFL] Try to fix a build break by r88757.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 14 Jun 2011 04:02:28 +0000 (04:02 +0000)]
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Remove failing test expectation for plugins/npruntime/browser-object-identity.html
on Chromium since it has been fixed by r88679.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 14 Jun 2011 03:46:30 +0000 (03:46 +0000)]
2011-06-10 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Use CSS machinery to position slider thumb.
https://bugs.webkit.org/show_bug.cgi?id=52920
Add two new tests, and update tests with sliders.
* fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
* fast/forms/input-appearance-range.html: Added.
* fast/forms/slider-thumb-stylability.html: Remove text.
* fast/forms/validation-message-on-range-expected.txt: Added.
* fast/forms/validation-message-on-range.html: Added.
* fast/multicol/client-rects-expected.txt:
* fast/repaint/slider-thumb-float-expected.txt:
* media/audio-repaint-expected.txt:
* media/controls-without-preload-expected.txt:
* media/media-document-audio-repaint-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped: Skip validaiton-message-on-range.html because
this platform doesn't support the interactive validation.
* platform/mac-wk2/Skipped: Skip validaiton-message-on-range.html.
* platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.png:
* platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/mac/fast/forms/box-shadow-override-expected.png:
* platform/mac/fast/forms/box-shadow-override-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.png:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/input-appearance-range-expected.png: Added.
* platform/mac/fast/forms/input-appearance-range-expected.txt: Added.
* platform/mac/fast/forms/range-thumb-height-percentage-expected.txt:
* platform/mac/fast/forms/slider-padding-expected.png:
* platform/mac/fast/forms/slider-padding-expected.txt:
* platform/mac/fast/forms/slider-thumb-shared-style-expected.png:
* platform/mac/fast/forms/slider-thumb-shared-style-expected.txt:
* platform/mac/fast/forms/slider-thumb-stylability-expected.png:
* platform/mac/fast/forms/slider-thumb-stylability-expected.txt:
* platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png:
* platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt:
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.png:
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt:
* platform/mac/media/audio-controls-rendering-expected.png:
* platform/mac/media/audio-controls-rendering-expected.txt:
* platform/mac/media/controls-after-reload-expected.png:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-styling-expected.png:
* platform/mac/media/controls-styling-expected.txt:
* platform/qt/Skipped: Skip validaiton-message-on-range.html.
* platform/win/Skipped: Skip validaiton-message-on-range.html.
2011-06-10 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Use CSS machinery to position slider thumb.
https://bugs.webkit.org/show_bug.cgi?id=52920
Remove RenderSlider::layout().
In order to remove it, we introduce new three shadow nodes:
- A flex box container occupying the whole box
- A flex box item representing a movable area of the thumb
- A flex box item limiting the movable area of the thumb
The thumb position is specified by percentage position in the second element.
This change also fixes Bug 60353.
Tests: fast/forms/input-appearance-range.html
fast/forms/validation-message-on-range.html
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect):
Use Node::getRect() for the thumb element.
* css/html.css: Add new style definitions for the new node layout.
(input[type="range"]::-webkit-slider-container):
(input[type="range"]::-webkit-slider-runnable-track):
(input[type="range"]::-webkit-slider-thumb):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
Accepts events on shadow nodes, use sliderThumbElementOf().
(WebCore::RangeInputType::createShadowSubtree):
Creates new nodes layout.
(WebCore::RangeInputType::valueChanged): Use sliderThumbElementOf().
* html/RangeInputType.h: Remove shadowSliderThumb().
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderPosition): Moved from RenderSlider.cpp.
(WebCore::hasVerticalAppearance): New utility function.
(WebCore::sliderThumbElementOf): New utility function.
(WebCore::RenderSliderThumb::layout):
Sets CSS top/left values.
(WebCore::RenderSliderContainer::RenderSliderContainer):
(WebCore::RenderSliderContainer::layout):
Add some adjustment code.
- Setting box-orient
- Adjust heights of some nodes. It is required to pass existing tests.
(WebCore::SliderThumbElement::setPositionFromValue):
Update comments.
(WebCore::SliderThumbElement::setPositionFromPoint):
Calculate the current position from absolute positions.
(WebCore::SliderThumbElement::hostInput):
Removed unnecessary variable.
(WebCore::TrackLimiterElement::TrackLimiterElement):
(WebCore::TrackLimiterElement::create): Adjust style.
(WebCore::TrackLimiterElement::createRenderer):
This node uses RenderSliderThumb.
(WebCore::TrackLimiterElement::shadowPseudoId):
This node also uses -webkit-slider-thumb.
(WebCore::SliderContainerElement::SliderContainerElement):
(WebCore::SliderContainerElement::create):
(WebCore::SliderContainerElement::createRenderer):
Uses RenderSliderContainer.
(WebCore::SliderContainerElement::shadowPseudoId):
* html/shadow/SliderThumbElement.h:
Make hostInput() public, add declarations of TrackLimiterElement
and SliderContainerElement.
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::RenderSlider): Added an assertion.
(WebCore::RenderSlider::inDragMode): Uses sliderThumbElementOf().
* rendering/RenderSlider.h: Remove declarations of removed functions.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustSliderThumbStyle):
Calls adjustSliderThumbSize().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Tue, 14 Jun 2011 02:55:15 +0000 (02:55 +0000)]
2011-06-13 James Simonsen <simonjam@chromium.org>
[Chromium] Unreviewed, rolled DEPS.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joone.hur@collabora.co.uk [Tue, 14 Jun 2011 02:27:53 +0000 (02:27 +0000)]
2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534
This patch just adds configure option to enable/disable register protocol handler.
So, it needs more code to use register protocol handler.
* configure.ac: Add configure option to enable/disable register protocol handler.
2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534
* GNUmakefile.am: Add ENABLE_REGISTER_PROTOCOL_HANDLER.
2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::registerProtocolHandler): Added.
* WebCoreSupport/ChromeClientGtk.h: Add the registerProtocolHandler method defintion.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 14 Jun 2011 02:19:43 +0000 (02:19 +0000)]
2011-06-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Support for painting thumb of media slider
https://bugs.webkit.org/show_bug.cgi?id=62174
Implement paintMediaSliderThumb() function to show thumb of media slider.
adjustSliderThumbSize() should be implemented in order to call paintMediaSliderThumb().
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::adjustSliderThumbSize):
(WebCore::RenderThemeEfl::paintMediaSliderTrack):
(WebCore::RenderThemeEfl::paintMediaSliderThumb):
(WebCore::RenderThemeEfl::paintMediaCurrentTime):
* platform/efl/RenderThemeEfl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 14 Jun 2011 02:15:45 +0000 (02:15 +0000)]
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Another GTK rebaseline after r88717 because non-breaking spaces were somehow converted to
regular spaces in r88742.
* platform/gtk/editing/pasteboard/paste-xml-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Tue, 14 Jun 2011 02:09:44 +0000 (02:09 +0000)]
2011-06-13 Keishi Hattori <keishi@webkit.org>
Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 14 Jun 2011 01:59:07 +0000 (01:59 +0000)]
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Chromium rebaselines after r88617. The test is now passing on all platforms.
* platform/chromium-mac-leopard/fast/repaint/selection-after-remove-expected.png: Added.
* platform/chromium-mac/fast/repaint/selection-after-remove-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Tue, 14 Jun 2011 01:46:22 +0000 (01:46 +0000)]
REGRESSION (r88579-r88581): compositing/iframes/invisible-nested-iframe-show.html,
compositing/tiling/huge-layer-add-remove-child.html failing on Windows 7 Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=62566
Add/update the (failing?) expected results for Windows in order to get the bots green.
* platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/win/compositing/tiling: Added.
* platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Tue, 14 Jun 2011 01:15:27 +0000 (01:15 +0000)]
2011-06-13 David Levin <levin@chromium.org>
Reviewed by Dmitry Titov.
fast/workers/worker-close.html is flaky on slower machines.
https://bugs.webkit.org/show_bug.cgi?id=62609
* fast/workers/worker-close.html: Move a setTimeout to start after
the response message is received to make the ordering of messages
deterministic.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Tue, 14 Jun 2011 01:13:56 +0000 (01:13 +0000)]
2011-06-13 James Simonsen <simonjam@chromium.org>
Reviewed by James Robinson.
[Chromium] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62162
* platform/chromium/PlatformBridge.h:
* platform/chromium/SystemTimeChromium.cpp:
(WebCore::monotonicallyIncreasingTime): Use Chrome's implementation.
2011-06-13 James Simonsen <simonjam@chromium.org>
Reviewed by James Robinson.
[Chromium] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62162
* public/WebKitClient.h:
(WebKit::WebKitClient::monotonicallyIncreasingTime): Added.
* src/PlatformBridge.cpp:
(WebCore::PlatformBridge::monotonicallyIncreasingTime): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 14 Jun 2011 01:10:31 +0000 (01:10 +0000)]
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Chromium Mac test expectation updates; Removed failing test expectations from
various tests because they seem to be passing now.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 14 Jun 2011 00:58:17 +0000 (00:58 +0000)]
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Skip test added by r88578 on GTK per bug 62585.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Tue, 14 Jun 2011 00:53:47 +0000 (00:53 +0000)]
2011-06-13 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Remove Android defines from WebCore/config.h
https://bugs.webkit.org/show_bug.cgi?id=62602
No new tests, build cleanup only.
* config.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 14 Jun 2011 00:42:09 +0000 (00:42 +0000)]
2011-06-13 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Remove redundant "true" parameter to scheduleLocationChange
https://bugs.webkit.org/show_bug.cgi?id=62612
This parameter defaults to true anyway.
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::selectCache):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Tue, 14 Jun 2011 00:39:53 +0000 (00:39 +0000)]
Add Windows-specific pixel and text results to account for the different design of the
ying-yang character on Windows (and of course to get the bots green).
* platform/win/svg/hixie/intrinsic: Added.
* platform/win/svg/hixie/intrinsic/003-expected.png: Added.
* platform/win/svg/hixie/intrinsic/003-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Tue, 14 Jun 2011 00:38:36 +0000 (00:38 +0000)]
[Chromium] WebNotification should check if ScriptExecutionContext is gone
before dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=62592
Reviewed by David Levin.
* public/WebNotification.h:
* src/WebNotification.cpp:
(WebKit::WebNotification::dispatchDisplayEvent):
(WebKit::WebNotification::dispatchErrorEvent):
(WebKit::WebNotification::dispatchCloseEvent):
(WebKit::WebNotification::dispatchClickEvent):
(WebKit::WebNotification::dispatchEvent): Added a helper method to check
the context and dispatch an event.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dominicc@chromium.org [Tue, 14 Jun 2011 00:22:50 +0000 (00:22 +0000)]
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add a new test for checking rounding error in printing codes
https://bugs.webkit.org/show_bug.cgi?id=61256
Add a new test (printing/page-count-with-one-word.html). This test
checks if only one page is printed for an HTML page with one word for
various paper sizes around A4 portrait size, i.e. [530px, 560px) for
width and [730px, 760px) for height.
* printing/page-count-with-one-word-expected.txt: Added.
* printing/page-count-with-one-word.html: Added.
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256
In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
PrintContext::computePageRects() and PrintContext::begin()
use resizePageRectsKeepingRatio() to expand/shrink a page.
Test: printing/page-count-with-one-word.html
* WebCore.exp.in:
* page/Frame.cpp:
(WebCore::Frame::resizePageRectsKeepingRatio):
* page/Frame.h:
* page/PrintContext.cpp:
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::begin):
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256
In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]
and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]
use resizePageRectsKeepingRatio() to expand/shrink a page.
Test: printing/page-count-with-one-word.html
* WebView/WebHTMLView.mm:
(-[WebHTMLView _web_setPrintingModeRecursive]):
(-[WebHTMLView _web_clearPrintingModeRecursive]):
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]):
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
(-[WebHTMLView _endPrintMode]):
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
(-[WebHTMLView _endScreenPaginationMode]):
(-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]):
(-[WebHTMLView layout]):
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
(-[WebHTMLView setPageWidthForPrinting:]):
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256
In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
WebFrame::setInPrintingMode() uses resizePageRectsKeepingRatio() to
expand/shrink a page.
Test: printing/page-count-with-one-word.html
* WebFrame.cpp:
(WebFrame::setPrinting):
(WebFrame::setInPrintingMode):
* WebFrame.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 14 Jun 2011 00:10:23 +0000 (00:10 +0000)]
2011-06-13 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash when trying to use Netflix Watch Instantly with Silverlight 3
https://bugs.webkit.org/show_bug.cgi?id=62611
<rdar://problem/
9058370>
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::getPluginInfo):
Get the plug-in version string instead of the version number.
(WebKit::PluginVersion::isValid):
(WebKit::PluginVersion::PluginVersion):
(WebKit::PluginVersion::parse):
(WebKit::PluginVersion::isLessThan):
Add a new PluginVersion class that represents a plug-in version. The idea is
that this class be made cross platform.
(WebKit::NetscapePluginModule::determineQuirks):
Add the ReturnsNonRetainedScriptableNPObject quirk for versions of Silverlight less than 4.
* Shared/Plugins/PluginQuirks.h:
Add the ReturnsNonRetainedScriptableNPObject quirk.
* UIProcess/Plugins/PluginInfoStore.h:
Use a version string. Eventually this should hold the PluginVersion class we added.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pluginScriptableNPObject):
If the plug-in has the ReturnsNonRetainedScriptableNPObject quirk, do an extra retain.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 14 Jun 2011 00:09:47 +0000 (00:09 +0000)]
2011-06-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
Update gtkdoc files and inline documentation to reduce gtkdoc errors
and ensure complete documentation output.
* docs/webkitgtk-sections.txt: Add missing sections to the list and remove
unneeded sections.
* docs/webkitgtk.types: Update the types list.
* webkit/webkithittestresult.cpp: Fix inline documentation errors.
(webkit_hit_test_result_class_init): Ditto.
* webkit/webkiticondatabase.cpp: Ditto.
* webkit/webkitwebsettings.cpp: Ditto.
(webkit_web_settings_class_init): Ditto.
* webkit/webkitwebview.cpp: Ditto.
(webkit_web_view_class_init): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 13 Jun 2011 23:51:21 +0000 (23:51 +0000)]
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Mac, GTK, and Qt rebaselines after r88717.
* platform/gtk/editing/pasteboard/paste-xml-expected.txt:
* platform/mac/editing/pasteboard/paste-xml-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Mon, 13 Jun 2011 23:49:02 +0000 (23:49 +0000)]
2011-06-13 Chris Rogers <crogers@google.com>
Unreviewed build fix.
Build fix to chromium DRT until we can rebaseline some tests
https://bugs.webkit.org/show_bug.cgi?id=62608
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Jun 2011 23:28:23 +0000 (23:28 +0000)]
2011-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
anyPageIsProcessingUserGesture is not longer needed because user gesture state is static
https://bugs.webkit.org/show_bug.cgi?id=62601
Previously, our user-gesture state was per-frame. Code needed to check
the "global" user gesture state called anyPageIsProcessingUserGesture()
to iterate through all the frames and look for one that was processing
a user gesture. Since we changed the user gesture state to be static,
iterating over every frame in existence isn't needed.
This patch also cleans up a couple other user-gesture callsites I saw
while I was in this code. Code should just call
ScriptController::processingUserGesture directly instead of
trampolining through other functions.
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeScript):
* bindings/generic/BindingSecurity.h:
(WebCore::::allowPopUp):
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation):
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptController.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptController.h:
(WebCore::ScriptController::setProcessingTimerCallback):
* bindings/v8/V8Utilities.cpp:
* bindings/v8/V8Utilities.h:
* bindings/v8/specialization/V8BindingState.cpp:
* bindings/v8/specialization/V8BindingState.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submitFromJavaScript):
(WebCore::HTMLFormElement::submit):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Jun 2011 23:20:47 +0000 (23:20 +0000)]
2011-06-13 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Darin Adler.
Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900
Added a test that tries to remove the children of munder, mover and munderover elements.
* mathml/munderover-remove-children-expected.txt: Added.
* mathml/munderover-remove-children.html: Added.
2011-06-13 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Darin Adler.
Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900
Add more null checks so that removing children in MathML elements does not cause crashes.
Note that this only half fixes the third repro in the Bugzilla bug, as another bug will
still crash that repro.
Test: mathml/munderover-remove-children.html
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::stretchToHeight):
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout):
(WebCore::RenderMathMLUnderOver::nonOperatorHeight):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Jun 2011 23:06:56 +0000 (23:06 +0000)]
2011-06-13 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62345
Use per-isolate embedder data instead of statics for caches in bindings.
This is a prerequisite for more than one v8 isolate per process.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
(WebCore::injectIDBKeyIntoSerializedValue):
* bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::~V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::create):
(WebCore::V8BindingPerIsolateData::ensureInitialized):
(WebCore::V8BindingPerIsolateData::dispose):
(WebCore::getToStringName):
(WebCore::getToStringTemplate):
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::get):
(WebCore::V8BindingPerIsolateData::current):
(WebCore::V8BindingPerIsolateData::rawTemplateMap):
(WebCore::V8BindingPerIsolateData::templateMap):
(WebCore::V8BindingPerIsolateData::toStringName):
(WebCore::V8BindingPerIsolateData::toStringTemplate):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/V8Utilities.cpp:
(WebCore::V8LocalContext::V8LocalContext):
(WebCore::V8LocalContext::~V8LocalContext):
* bindings/v8/V8Utilities.h:
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
2011-06-13 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62345
Use per-isolate embedder data instead of statics for caches in bindings.
This is a prerequisite for more than one v8 isolate per process.
* tests/IDBBindingUtilitiesTest.cpp:
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 13 Jun 2011 22:56:57 +0000 (22:56 +0000)]
2011-06-13 Lei Zhang <thestig@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add a WebSetting to control printing backgrounds
https://bugs.webkit.org/show_bug.cgi?id=62423
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setShouldPrintBackgrounds):
* src/WebSettingsImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Mon, 13 Jun 2011 22:53:05 +0000 (22:53 +0000)]
2011-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Adam Barth.
Simplify logic in ProgressTracker::progressCompleted()
https://bugs.webkit.org/show_bug.cgi?id=62598
Testing for "m_numProgressTrackedFrames != 0" is unnecessary because it is
always true, otherwise we would entered in the first part of the conditional.
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressCompleted):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Mon, 13 Jun 2011 22:50:53 +0000 (22:50 +0000)]
2011-06-13 Chris Rogers <crogers@google.com>
Reviewed by Dirk Pranke.
Add Web Audio support to chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=62306
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):
(LayoutTestController::setEncodedAudioData):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::encodedAudioData):
(LayoutTestController::shouldDumpAsAudio):
(LayoutTestController::setShouldDumpAsAudio):
* DumpRenderTree/chromium/TestEventPrinter.cpp:
(DRTPrinter::handleAudioHeader):
(TestShellPrinter::handleAudioHeader):
* DumpRenderTree/chromium/TestEventPrinter.h:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::dump):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc