WebKit-https.git
12 years agoAdding a class that allows us to enable/disable features at
dumi@chromium.org [Fri, 23 Oct 2009 19:38:21 +0000 (19:38 +0000)]
Adding a class that allows us to enable/disable features at
runtime. Adding a flag to enable database support.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-22
Reviewed by Dmitry Titov.

https://bugs.webkit.org/show_bug.cgi?id=30653

* WebCore.gypi:
* bindings/v8/RuntimeEnabledFeatures.cpp: Added.
* bindings/v8/RuntimeEnabledFeatures.h: Added.
(WebCore::RuntimeEnabledFeatures::setDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::databaseEnabled):
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
* bindings/v8/custom/V8CustomBinding.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Keishi Hattori <casey.hattori@gmail.com>
eric@webkit.org [Fri, 23 Oct 2009 19:30:54 +0000 (19:30 +0000)]
2009-10-23  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        Inspector injects _inspectorCommandLineAPI into global object when opened
        https://bugs.webkit.org/show_bug.cgi?id=30675

        * inspector/front-end/InjectedScript.js:
        (InjectedScript.getCompletions):
        (InjectedScript._evaluateOn):
        (InjectedScript.addInspectedNode):
        (InjectedScript._ensureCommandLineAPIInstalled): Moved _inspectorCommandLineAPI from window to console.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Fri, 23 Oct 2009 19:23:01 +0000 (19:23 +0000)]
2009-10-23  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] don't undef NULL in Symbian emulator

        npapi.h way of defining mwerks compiler,__intel__
        and win32 are all true for Symbian emulator.
        Changed the definions so that NULL won't be undefined
        when compiling for Symbian emulator nor target HW.

        * bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Fri, 23 Oct 2009 19:14:27 +0000 (19:14 +0000)]
2009-10-23  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Correct linking of sqlite3 for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=30569

        ".lib" will try to include library as static library
        causing the library to be searched from wrong directory and if found
        will be statically linked instead of the inteded dynamic linking.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION: Copy is copying incorrect background-color
adele@apple.com [Fri, 23 Oct 2009 19:00:02 +0000 (19:00 +0000)]
REGRESSION: Copy is copying incorrect background-color
<rdar://problem/7248529>
https://bugs.webkit.org/show_bug.cgi?id=29697

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-23
Reviewed by Adele Peterson.

WebCore:

Test: editing/execCommand/indent-paragraphs.html

This change removes the BackgroundColor from the list
of inheritable CSS properties and changes significantly
the way we perform indentation.
The new implementation of IndentOutdentCommand uses a new method
defined in CompositeEditCommand called moveParagraphWithClones.
This is an improved version of the original moveParagraph that
is aimed at preserving the original markup of the paragraph being
moved.

* editing/ApplyStyleCommand.cpp:
(WebCore::): removed CSSPropertyBackgroundColor from editingStyleProperties.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::CompositeEditCommand): Removed trailing blanks.
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Removed trailing blanks.
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added.
(WebCore::CompositeEditCommand::cleanupAfterDeletion): Added.
(WebCore::CompositeEditCommand::moveParagraphWithClones): Added.
(WebCore::CompositeEditCommand::moveParagraphs): Modified to use cleanupAfterDeletion.
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Removed trailing blanks.
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Removed trailing blanks.
(WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Removed trailing blanks.
* editing/CompositeEditCommand.h: Added three new methods.
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::tryIndentingAsListItem): Changed to use moveParagraphWithClones.
(WebCore::IndentOutdentCommand::indentIntoBlockquote): Changed to use moveParagraphWithClones.
(WebCore::IndentOutdentCommand::indentRegion): Removed comment.
* editing/IndentOutdentCommand.h: Removed prepareBlockquoteLevelForInsertion method.

LayoutTests:

All the following tests have been re-baselined because
the indent command now preserves the original markup.
A new test (indent-paragraph.html) has been added to test
several indent combinations not covered by the existing tests.

* editing/execCommand/19087-expected.txt:
* editing/execCommand/19653-1-expected.txt:
* editing/execCommand/indent-div-inside-list-expected.txt:
* editing/execCommand/indent-nested-blockquotes-expected.txt:
* editing/execCommand/indent-nested-div-expected.txt:
* editing/execCommand/indent-paragraphs.html: Added.
* editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt:
* editing/execCommand/indent-with-style-expected.txt:
* editing/inserting/5994480-2-expected.txt:
* platform/mac/editing/execCommand/4641880-2-expected.txt:
* platform/mac/editing/execCommand/4916541-expected.txt:
* platform/mac/editing/execCommand/5138441-expected.txt:
* platform/mac/editing/execCommand/5481523-expected.txt:
* platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Added.
* platform/mac/editing/execCommand/indent-selection-expected.txt:
* platform/mac/editing/pasteboard/select-element-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 23 Oct 2009 18:57:45 +0000 (18:57 +0000)]
2009-10-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Eric Carlson.

        fast/media/mq-transform-02.html failed on Leopard Commit Bot
        https://bugs.webkit.org/show_bug.cgi?id=30700

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues): Update QuickTime version check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Sam Weinig.
bweinstein@apple.com [Fri, 23 Oct 2009 17:34:07 +0000 (17:34 +0000)]
Rubber-stamped by Sam Weinig.

Isolated worlds tests now pass, removing then from the Skipped
list.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
kevino@webkit.org [Fri, 23 Oct 2009 16:45:47 +0000 (16:45 +0000)]
wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
character measurement APIs that are private on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Update the globalObject calls after changes.
kevino@webkit.org [Fri, 23 Oct 2009 16:42:45 +0000 (16:42 +0000)]
wx build fix. Update the globalObject calls after changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoChanged anchor style to take a class name
cmarrin@apple.com [Fri, 23 Oct 2009 16:34:28 +0000 (16:34 +0000)]
Changed anchor style  to take a class name

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 23 Oct 2009 15:53:18 +0000 (15:53 +0000)]
2009-10-22  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/7322847>
        Pressing space bar key in full screen mode should pause movie but doesn't

        * WebView/WebVideoFullscreenHUDWindowController.mm:
        (-[WebVideoFullscreenHUDWindowController keyDown:]):  New, toggle playback on space key.
        (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Play button action is now called togglePlaying.
        (-[WebVideoFullscreenHUDWindowController togglePlaying:]): Rename from playingChanged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoQt build fix
vestbo@webkit.org [Fri, 23 Oct 2009 14:30:09 +0000 (14:30 +0000)]
Qt build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes a leak in createThreadInternal on Android.
benm@google.com [Fri, 23 Oct 2009 14:07:39 +0000 (14:07 +0000)]
Fixes a leak in createThreadInternal on Android.
https://bugs.webkit.org/show_bug.cgi?id=30698

Patch by Steve Block <steveblock@google.com> on 2009-10-23
Reviewed by Dmitry Titov.

* wtf/ThreadingPthreads.cpp: Modified.
(WTF::createThreadInternal): Avoid leaking a ThreadData object on failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds missing UnusedParam.h includes, required when INSPECTOR is not enabled.
benm@google.com [Fri, 23 Oct 2009 12:45:03 +0000 (12:45 +0000)]
Adds missing UnusedParam.h includes, required when INSPECTOR is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=30677

Patch by Steve Block <steveblock@google.com> on 2009-10-23
Reviewed by Eric Seidel.

Build fix, no new tests required.

* page/Console.cpp: Modified. Added UnusedParam.h include.
* workers/WorkerContext.cpp: Modified. Added UnusedParam.h include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Plugins : Use window's winId() instead of the widget's.
zecke@webkit.org [Fri, 23 Oct 2009 12:02:54 +0000 (12:02 +0000)]
[Qt] Plugins : Use window's winId() instead of the widget's.

2009-10-23  Girish Ramakrishnan  <girish@forwardbias.in>

        Reviewed by Holger Freyther.

        [Qt] Plugins : Use window's winId() instead of the widget's.

        As per, https://developer.mozilla.org/en/NPN_GetValue
        NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the
        plug-in is displayed; returns Window".

        The issue was found because NPNVNetscapeWindow winId() ends up creating
        a native window resulting in flicker.

        https://bugs.webkit.org/show_bug.cgi?id=30706

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::getValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Windowless Plugins : Don't use m_clipRect when painting.
zecke@webkit.org [Fri, 23 Oct 2009 12:02:37 +0000 (12:02 +0000)]
[Qt] Windowless Plugins : Don't use m_clipRect when painting.

2009-10-23  Girish Ramakrishnan  <girish@forwardbias.in>

        Reviewed by Holger Freyther.

        [Qt] Windowless Plugins : Don't use m_clipRect when painting.

        Though it works, it is not correct to use m_clipRect for painting
        in Windowless mode. Instead, the rect paramater that is passed
        as a part of PluginView::paint() must be used. This change will
        also result in some speedup since previously we used to paint all
        the visible parts of a windowless plugin (even if those parts were
        not dirty).

        Also, fix invalidateRect() to compute the correct width and height.

        https://bugs.webkit.org/show_bug.cgi?id=30711

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::paint):
        (WebCore::PluginView::invalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPlugins : Use test.swf in the plugins manual tests.
zecke@webkit.org [Fri, 23 Oct 2009 12:02:19 +0000 (12:02 +0000)]
Plugins : Use test.swf in the plugins manual tests.

They previously referenced youtube videos which among other things are
cumbersome to use without internet connection. The old youtube link is
just commented out so that testing with youtube can be done with
little effort.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 23 Oct 2009 11:47:31 +0000 (11:47 +0000)]
2009-10-23  Xan Lopez  <xlopez@igalia.com>

        Use the correct Skipped file ...

        * platform/gtk/Skipped:
        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-23 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 23 Oct 2009 11:43:39 +0000 (11:43 +0000)]
2009-10-23  Xan Lopez  <xlopez@igalia.com>

        Skip new tests missing expected results.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Windows Release build by moving Accessibility files
bweinstein@apple.com [Fri, 23 Oct 2009 08:14:08 +0000 (08:14 +0000)]
Fix the Windows Release build by moving Accessibility files
into all-in-one file and excluding them from the build.

Reviewed by Jon Honeycutt.

* WebCore.vcproj/WebCore.vcproj:
* accessibility/AccessibilityAllInOne.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate configurations to support the mysterious future.
mrowe@apple.com [Fri, 23 Oct 2009 06:22:46 +0000 (06:22 +0000)]
Update configurations to support the mysterious future.

Rubber-stamped by Brady Eidson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix following bug #30696.
barraclough@apple.com [Fri, 23 Oct 2009 05:27:54 +0000 (05:27 +0000)]
Build fix following bug #30696.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate to WordPress 2.8.5.
mrowe@apple.com [Fri, 23 Oct 2009 05:16:15 +0000 (05:16 +0000)]
Update to WordPress 2.8.5.

* blog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix following bug #30696.
barraclough@apple.com [Fri, 23 Oct 2009 05:06:27 +0000 (05:06 +0000)]
Build fix following bug #30696.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (speculative build fix - qt is currently already broken!)

* Api/qwebelement.cpp:
(setupScriptContext):
* Api/qwebframe.cpp:
(QWebFrame::evaluateJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix following bug #30696.
barraclough@apple.com [Fri, 23 Oct 2009 04:57:10 +0000 (04:57 +0000)]
Build fix following bug #30696.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::evaluate):
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::getProperty):
(WebKit::NetscapePluginInstanceProxy::setProperty):
(WebKit::NetscapePluginInstanceProxy::removeProperty):
(WebKit::NetscapePluginInstanceProxy::hasProperty):
(WebKit::NetscapePluginInstanceProxy::hasMethod):
(WebKit::NetscapePluginInstanceProxy::enumerate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix following bug #30696.
barraclough@apple.com [Fri, 23 Oct 2009 04:48:04 +0000 (04:48 +0000)]
Build fix following bug #30696.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::windowObjectCleared):
* webkit/webkitwebframe.cpp:
(webkit_web_frame_get_global_context):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=30696
barraclough@apple.com [Fri, 23 Oct 2009 04:33:56 +0000 (04:33 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=30696
Add support for IsolatedWorlds to JSC bindings.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-16
Reviewed by Sam Weinig & Geoff Garen.

An IsolatedWorld is basically a parallel, separate copy of the window shells and DOM wrapper objects for
a given document.  To support isolation this patch:

    * Adds support to the ScriptController to track multiple window shells, one per world.
    * Adds support to Document to support multiple separate wrapper-maps, one per world.
    * Replaces the single global DOM wrapper map (on the WebCoreJSClientData) with separate maps,
      stored on the (new) IsolatedWorld objects.

In addition to supporting separate copies of these objects, two other features are supported:

    * It is necessary to track the current world on entry into JSC, so that within callbacks out to WebCore
      we can determine which world (and as such, set of DOM bindings) we should be operating on.
    * EventListeners & Callbacks are run in the world they were registered in.
      This requires the handler to retain a reference to the world.

No new tests. (Enabled existing isolated world layout tests.)

* WebCore.base.exp:
* bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSDOMBinding.cpp:
(WebCore::removeWrappers):
(WebCore::DOMObjectWrapperMap::get):
(WebCore::DOMObjectWrapperMap::set):
(WebCore::DOMObjectWrapperMap::remove):
(WebCore::DOMObjectWrapperMap::take):
(WebCore::IsolatedWorld::IsolatedWorld):
(WebCore::IsolatedWorld::~IsolatedWorld):
(WebCore::EnterIsolatedWorld::EnterIsolatedWorld):
(WebCore::EnterIsolatedWorld::~EnterIsolatedWorld):
(WebCore::JSGlobalDataWorldIterator::JSGlobalDataWorldIterator):
(WebCore::JSGlobalDataWorldIterator::operator bool):
(WebCore::JSGlobalDataWorldIterator::operator*):
(WebCore::JSGlobalDataWorldIterator::operator->):
(WebCore::JSGlobalDataWorldIterator::operator++):
(WebCore::getCurrentWorld):
(WebCore::getNormalWorld):
(WebCore::commonNormalWorld):
(WebCore::commonCurrentWorld):
(WebCore::DOMObjectHashTableMap::mapFor):
(WebCore::DOMObjectWrapperMap::mapFor):
(WebCore::forgetDOMObject):
(WebCore::getCachedDOMNodeWrapper):
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
(WebCore::forgetAllDOMNodesForDocument):
(WebCore::forgetWorldOfDOMNodesForDocument):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markActiveObjectsForContext):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::allowsAccessFromFrame):
(WebCore::printErrorMessageForFrame):
(WebCore::JSC_DebuggerCallFrame_evaluateInWorld):
(WebCore::JSC_callInWorld):
(WebCore::JSC_constructInWorld):
(WebCore::JSC_evaluateInWorld):
* bindings/js/JSDOMBinding.h:
(WebCore::IsolatedWorld::rememberDocument):
(WebCore::IsolatedWorld::forgetDocument):
(WebCore::IsolatedWorld::rememberScriptController):
(WebCore::IsolatedWorld::forgetScriptController):
(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::currentWorld):
(WebCore::WebCoreJSClientData::normalWorld):
(WebCore::WebCoreJSClientData::rememberWorld):
(WebCore::WebCoreJSClientData::forgetWorld):
(WebCore::debuggerWorld):
(WebCore::pluginWorld):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
(WebCore::toJSDOMGlobalObject):
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::printErrorMessage):
(WebCore::JSDOMWindowBase::commonJSGlobalData):
(WebCore::toJS):
(WebCore::toJSDOMWindow):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::createWindow):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):
(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::setInterval):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::toJS):
(WebCore::toJSDOMWindowShell):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::create):
* bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::nameGetter):
* bindings/js/JSInspectorBackendCustom.cpp:
(WebCore::JSInspectorBackend::databaseForId):
(WebCore::JSInspectorBackend::inspectedWindow):
(WebCore::JSInspectorBackend::nodeForId):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::parseCode):
* bindings/js/JSLazyEventListener.h:
(WebCore::JSLazyEventListener::create):
* bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::markChildren):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::markChildren):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::markChildren):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
* bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::markChildren):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::setInterval):
* bindings/js/JSXMLHttpRequestConstructor.cpp:
(WebCore::constructXMLHttpRequest):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::markChildren):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::executeFunctionInContext):
(WebCore::ScheduledAction::execute):
* bindings/js/ScheduledAction.h:
(WebCore::ScheduledAction::ScheduledAction):
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::jsObjectForPluginElement):
* bindings/js/ScriptController.h:
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::globalObject):
(WebCore::ScriptController::forgetWorld):
* bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject):
* bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
* bindings/js/ScriptObjectQuarantine.cpp:
(WebCore::getQuarantinedScriptObject):
* bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):
* bindings/js/ScriptState.h:
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::evaluate):
* bindings/objc/DOMInternal.mm:
(-[WebScriptObject _initializeScriptDOMNodeImp]):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
* dom/Document.cpp:
(WebCore::Document::createWrapperCache):
* dom/Document.h:
(WebCore::Document::wrapperCacheMap):
(WebCore::Document::getWrapperCache):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
* inspector/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchWindowObjectAvailable):
* platform/network/mac/AuthenticationMac.mm:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::dropProtection):
* xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::create):

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=30696
Update to incorporate support for IsolatedWorlds in JSC bindings.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-16
Reviewed by Sam Weinig & Geoff Garen.

* WebView/WebFrame.mm:
(-[WebFrame _attachScriptDebugger]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame globalContext]):
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]):
* WebView/WebView.mm:
(-[WebView aeDescByEvaluatingJavaScriptFromString:]):

WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=30696
Update to incorporate support for IsolatedWorlds in JSC bindings.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by Sam Weinig & Geoff Garen.

* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::globalContext):
(WebFrame::windowObjectCleared):
(WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld):
* WebFrame.h:

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=30696
Enable isolated-worlds tests on mac.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by Sam Weinig & Geoff Garen.

Add private interface for DRT to invoke execution in a given world.

* DumpRenderTree/LayoutTestController.cpp:
(evaluateScriptInIsolatedWorldCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::evaluateScriptInIsolatedWorld):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=30696
Enable isolated-worlds tests on mac.
  * Update the results to switch from windows to unix line-endings.
  * Update all-window-prototypes.html to allow for properties on
    the global object with null prototypes (just skip over them).

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-19
Reviewed by Sam Weinig & Geoff Garen.

* http/tests/security/isolatedWorld/all-window-properties-expected.txt:
* http/tests/security/isolatedWorld/all-window-prototypes-expected.txt:
* http/tests/security/isolatedWorld/all-window-prototypes.html:
* http/tests/security/isolatedWorld/body-properties-expected.txt:
* http/tests/security/isolatedWorld/body-prototype-expected.txt:
* http/tests/security/isolatedWorld/document-properties-expected.txt:
* http/tests/security/isolatedWorld/document-prototype-expected.txt:
* http/tests/security/isolatedWorld/global-variables-expected.txt:
* http/tests/security/isolatedWorld/image-properties-expected.txt:
* http/tests/security/isolatedWorld/image-prototype-expected.txt:
* http/tests/security/isolatedWorld/location-properties-expected.txt:
* http/tests/security/isolatedWorld/location-prototype-expected.txt:
* http/tests/security/isolatedWorld/number-prototype-expected.txt:
* http/tests/security/isolatedWorld/object-prototype-expected.txt:
* http/tests/security/isolatedWorld/storage-properties-expected.txt:
* http/tests/security/isolatedWorld/storage-prototype-expected.txt:
* http/tests/security/isolatedWorld/string-prototype-expected.txt:
* http/tests/security/isolatedWorld/window-properties-expected.txt:
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 23 Oct 2009 04:12:19 +0000 (04:12 +0000)]
2009-10-22  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: EventListenersSidebarPane TODO No Longer Needed
        https://bugs.webkit.org/show_bug.cgi?id=30705

        * inspector/front-end/EventListenersSidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdating expected results - unreviewed.
bweinstein@apple.com [Fri, 23 Oct 2009 00:22:40 +0000 (00:22 +0000)]
Updating expected results - unreviewed.

Updated expected computed style results on Windows after r49959.

* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Tim Hatcher.
ap@apple.com [Fri, 23 Oct 2009 00:00:50 +0000 (00:00 +0000)]
    Reviewed by Tim Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=30506
        <rdar://problem/7319845> Resources that the server sent as 304 not modified are not shown
        in the inspectors resource pane

        I don't know how to make a test for this.

        The issue here was that preloaded resources weren't added to DocLoader document resource set,
        but Web Inspector asked DocLoader to fetch data from CachedResource. Even when (if) document
        parser eventually requested the same resource for real and it got added to resource set, it
        was too late - the Inspector wasn't updated.

        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::cachedResource):
        (WebCore::InspectorResource::type):
        (WebCore::InspectorResource::resourceData):
        * inspector/InspectorResource.h:
        Fix the issue by trying to fetch corresponding CachedResource harder - also look in global
        cache. This seems safe, and easier than updating the Inspector on transitions between
        resource states (revalidate vs. revalidate done and preload vs. non-preload).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fix for <rdar://problem/6942706> ER: Add a CSS property that allows
bdakin@apple.com [Thu, 22 Oct 2009 23:34:16 +0000 (23:34 +0000)]
WebCore: Fix for <rdar://problem/6942706> ER: Add a CSS property that allows
shadows to work for SVG content
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=30479

Reviewed by Dan Bernstein.

This patch adds a new SVG-specific CSS property called -webkit-
shadow that has the same syntax as -webkit-box-shadow

Add CSSPropertyWebkitShadow to the list of SVG CSS properties, and
make valueForShadow a member function rather than a static function
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSComputedStyleDeclaration.h:

Call valueForShadow for CSSPropertyWebkitShadow
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

Do standard CSS stuff for CSSPropertyWebkitShadow
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/SVGCSSPropertyNames.in:
* css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):

Set the appropriate shadow on the paint context if we have one.
This seems to be all we have to do to have an SVG-shaped shadow.
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):

Add shadow to SVGRenderStyle. I added a new macro that I don't like
just because that's the way things are done here right now.
* rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::SVGRenderStyle):
(WebCore::SVGRenderStyle::operator==):
* rendering/style/SVGRenderStyle.h:
* rendering/style/SVGRenderStyleDefs.cpp:
(StyleShadowSVGData::StyleShadowSVGData):
(StyleShadowSVGData::operator==):
* rendering/style/SVGRenderStyleDefs.h:
(WebCore::StyleShadowSVGData::create):
(WebCore::StyleShadowSVGData::copy):
(WebCore::StyleShadowSVGData::operator!=):

LayoutTests: Tests for <rdar://problem/6942706> ER: Add a CSS property that
allows shadows to work for SVG content
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=30479

Reviewed by Dan Bernstein.

New results that include -webkit-shadow:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

New tests and their results.
* platform/mac/svg/css/arrow-with-shadow-expected.checksum: Added.
* platform/mac/svg/css/arrow-with-shadow-expected.png: Added.
* platform/mac/svg/css/arrow-with-shadow-expected.txt: Added.
* platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum: Added.
* platform/mac/svg/css/circle-in-mask-with-shadow-expected.png: Added.
* platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
* platform/mac/svg/css/clippath-with-shadow-expected.checksum: Added.
* platform/mac/svg/css/clippath-with-shadow-expected.png: Added.
* platform/mac/svg/css/clippath-with-shadow-expected.txt: Added.
* platform/mac/svg/css/group-with-shadow-expected.checksum: Added.
* platform/mac/svg/css/group-with-shadow-expected.png: Added.
* platform/mac/svg/css/group-with-shadow-expected.txt: Added.
* platform/mac/svg/css/mask-with-shadow-expected.checksum: Added.
* platform/mac/svg/css/mask-with-shadow-expected.png: Added.
* platform/mac/svg/css/mask-with-shadow-expected.txt: Added.
* platform/mac/svg/css/path-with-shadow-expected.checksum: Added.
* platform/mac/svg/css/path-with-shadow-expected.png: Added.
* platform/mac/svg/css/path-with-shadow-expected.txt: Added.
* platform/mac/svg/css/stars-with-shadow-expected.checksum: Added.
* platform/mac/svg/css/stars-with-shadow-expected.png: Added.
* platform/mac/svg/css/stars-with-shadow-expected.txt: Added.
* platform/mac/svg/filters/shadow-on-filter-expected.checksum: Added.
* platform/mac/svg/filters/shadow-on-filter-expected.png: Added.
* platform/mac/svg/filters/shadow-on-filter-expected.txt: Added.
* platform/mac/svg/filters/shadow-on-rect-with-filter-expected.checksum: Added.
* platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
* platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
* svg/css/arrow-with-shadow.svg: Added.
* svg/css/circle-in-mask-with-shadow.svg: Added.
* svg/css/clippath-with-shadow.svg: Added.
* svg/css/getComputedStyle-basic-expected.txt:
* svg/css/group-with-shadow.svg: Added.
* svg/css/mask-with-shadow.svg: Added.
* svg/css/path-with-shadow.svg: Added.
* svg/css/stars-with-shadow.html: Added.
* svg/filters/shadow-on-filter.svg: Added.
* svg/filters/shadow-on-rect-with-filter.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Thu, 22 Oct 2009 23:07:56 +0000 (23:07 +0000)]
2009-10-22  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25530
        [Gtk] Implement LABEL_FOR/LABELLED_BY relationship pair for labels

        Implements atk_object_ref_relation_set and LABEL_FOR/LABELLED_BY.
        Also causes the accessible name for labeled controls to be based on
        the label as expected, rather than based on the contents.

        * accessibility/AccessibilityRenderObject.h:
        * accessibility/AccessibilityRenderObject.cpp:
        (correspondingLabelForControlElement):
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (setAtkRelationSetFromCoreObject):
        (webkit_accessible_ref_relation_set):
        (webkit_accessible_class_init):
        (webkit_accessible_get_name):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Thu, 22 Oct 2009 21:32:58 +0000 (21:32 +0000)]
2009-10-22  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Added expected result for clicked-link-is-visited.html.
        Removed test case from qt/Skipped as it works now.

        * platform/qt/Skipped:
        * platform/qt/fast/history: Added.
        * platform/qt/fast/history/clicked-link-is-visited-expected.txt: Added.
2009-10-22  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Enable track visited links in QWebPage
        https://bugs.webkit.org/show_bug.cgi?id=30574

        Test: fast/history/clicked-link-is-visited.html

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 22 Oct 2009 21:08:58 +0000 (21:08 +0000)]
2009-10-22  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: windowFocused and windowBlured Fail to Clear/Mark Inspector as "inactive"
        https://bugs.webkit.org/show_bug.cgi?id=30663

          Correctly handle focusing/blurring on inner <iframe>'s such as Source Frames.

        * inspector/front-end/inspector.js:
        (WebInspector.windowFocused): fix for inner iframes
        (WebInspector.windowBlurred): fix for inner iframes
        (WebInspector.addMainEventListeners): change useCapture to false

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed ASSERT when opening Safari's Caches window while the Web Inspector
ggaren@apple.com [Thu, 22 Oct 2009 20:33:16 +0000 (20:33 +0000)]
Fixed ASSERT when opening Safari's Caches window while the Web Inspector
is open.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-22
Reviewed by Alexey Proskuryakov.

* runtime/Collector.cpp:
(JSC::typeName): Added two new types to the type name list in the Collector.
These types have been around for a while, but nobody remembered to consider them here.

* runtime/JSCell.h:
(JSC::JSCell::isPropertyNameIterator):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::isPropertyNameIterator): Give the Collector
a way to tell if a cell is a JSPropertyNameIterator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Jaime Yap <jaimeyap@google.com>
eric@webkit.org [Thu, 22 Oct 2009 20:19:43 +0000 (20:19 +0000)]
2009-10-22  Jaime Yap  <jaimeyap@google.com>

        Reviewed by Timothy Hatcher.

        Makes a page reload optional when activating resource monitoring in
        InspectorController. It leaves the default behavior as performing the reload.
        Reload is an optional param so callsites do not have to change.

        https://bugs.webkit.org/show_bug.cgi?id=30684

        No new tests added.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::enableResourceTracking):
        * inspector/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Girish Ramakrishnan <girish@forwardbias.in>
eric@webkit.org [Thu, 22 Oct 2009 20:10:05 +0000 (20:10 +0000)]
2009-10-22  Girish Ramakrishnan  <girish@forwardbias.in>

        Reviewed by Eric Seidel.

        [Qt] Add Print Shortcut to QtLauncher

        https://bugs.webkit.org/show_bug.cgi?id=30682

        * QtLauncher/main.cpp:
        (MainWindow::setupUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=30686
sfalken@apple.com [Thu, 22 Oct 2009 20:06:54 +0000 (20:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30686
Remove debug-specific def file.
Only Debug_All target uses JavaScriptCore_debug.dll naming, and since
that target is only used internally, maintaining two files just to
suppress a single link warning isn't worthwhile.

Reviewed by Jon Honeycutt.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Thu, 22 Oct 2009 19:56:08 +0000 (19:56 +0000)]
2009-10-22  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Fix memory leak in QNetworkReplyHandler::abort().
        In QNetworkReplyHandler::release(), m_reply should no longer point to its parent
        after being released.
        https://bugs.webkit.org/show_bug.cgi?id=30167

        No layout test available as a non-functional fix.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::abort):
        (WebCore::QNetworkReplyHandler::release):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 22 Oct 2009 19:15:36 +0000 (19:15 +0000)]
2009-10-22  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Fix DOMAgent leak.

        https://bugs.webkit.org/show_bug.cgi?id=30615

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::setFrontendProxyObject):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::releaseDOMAgent):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.h:
        (WebCore::InspectorDOMAgent::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 22 Oct 2009 18:35:33 +0000 (18:35 +0000)]
2009-10-22  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        [V8] Rework event listeners to not hold references to frame or V8 context.

        https://bugs.webkit.org/show_bug.cgi?id=30648

        Covered by existing layout tests: fast/events/attribute-listener*

        * bindings/scripts/CodeGeneratorV8.pm: Added passing ScriptExecutionContext*
            to event listener handling code.
        * bindings/v8/DateExtension.cpp:
        (WebCore::DateExtension::setAllowSleep): Changed to use currentContext().
        * bindings/v8/ScriptEventListener.cpp:
        (WebCore::createAttributeEventListener): Reworked to match JSC logic.
        (WebCore::getEventListenerHandlerBody): Added ScriptExecutionContext* param.
        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::V8AbstractEventListener): Removed Frame* param
            and usage.
        (WebCore::V8AbstractEventListener::handleEvent): Chaged to use ScriptExecutionContext*.
        (WebCore::V8AbstractEventListener::invokeEventHandler): Ditto.
        * bindings/v8/V8AbstractEventListener.h:
        (WebCore::V8AbstractEventListener::getListenerObject): Ditto.
        (WebCore::V8AbstractEventListener::prepareListenerObject): Ditto.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventListenerToV8Object):  Added ScriptExecutionContext* param.
        (WebCore::V8DOMWrapper::getEventListener): Ditto.
        * bindings/v8/V8DOMWrapper.h:
        (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Ditto.
        * bindings/v8/V8EventListenerList.h:
        (WebCore::V8EventListenerList::findOrCreateWrapper): Removed ContextType* template param,
            because it's no longer needed.
        * bindings/v8/V8IsolatedWorld.h:
        (WebCore::V8IsolatedWorld::sharedContext): Renamed from shared_context.
        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::V8LazyEventListener): Removed Frame* param and usage.
        (WebCore::V8LazyEventListener::callListenerFunction): Added ScriptExecutionContext* param.
        (WebCore::V8LazyEventListener::prepareListenerObject): Ditto.
        * bindings/v8/V8LazyEventListener.h:
        (WebCore::V8LazyEventListener::create): Reordered params to match JSC impl.
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::V8Proxy): Adjusted formatting to match WebKit style.
        (WebCore::V8Proxy::evaluateInNewContext): Changed to use m_context directly.
        (WebCore::V8Proxy::setInjectedScriptContextDebugId): Ditto.
        (WebCore::V8Proxy::createWrapperFromCacheSlowCase): Ditto.
        (WebCore::V8Proxy::isContextInitialized): Ditto.
        (WebCore::V8Proxy::updateDocumentWrapperCache): Ditto.
        (WebCore::V8Proxy::clearDocumentWrapperCache): Ditto.
        (WebCore::V8Proxy::disposeContextHandles): Added explicit disposing of m_context.
        (WebCore::V8Proxy::clearForClose): Changed to use m_context directly.
        (WebCore::V8Proxy::clearForNavigation): Ditto.
        (WebCore::V8Proxy::setSecurityToken): Ditto.
        (WebCore::V8Proxy::updateDocument): Ditto.
        (WebCore::V8Proxy::initContextIfNeeded): Ditto.
        (WebCore::V8Proxy::context): Changed to use v8::Local.
        (WebCore::V8Proxy::mainWorldContext): Changed to use m_context directly.
        (WebCore::V8Proxy::setContextDebugId): Ditto.
        (WebCore::toV8Context):
        * bindings/v8/V8Proxy.h: Removed shared_context decl, changed to use straight
            v8::Persistent for m_context.
        * bindings/v8/V8WorkerContextEventListener.cpp:
        (WebCore::workerProxy): Added.
        (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): Removed
            WorkerContextExecutionProxy* param.
        (WebCore::V8WorkerContextEventListener::handleEvent): Started using ScriptExecutionContext*.
        (WebCore::V8WorkerContextEventListener::reportError): Ditto.
        (WebCore::V8WorkerContextEventListener::callListenerFunction): Ditto.
        (WebCore::V8WorkerContextEventListener::getReceiverObject): Ditto.
        * bindings/v8/V8WorkerContextEventListener.h:
        (WebCore::V8WorkerContextEventListener::create): Removed
            WorkerContextExecutionProxy* param.
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener): Removed ContextType*
            template param.
        * bindings/v8/custom/V8CustomEventListener.cpp:
        (WebCore::V8EventListener::V8EventListener): Removed Frame* param.
        (WebCore::V8EventListener::getListenerFunction): Started using ScriptExecutionContext*.
        (WebCore::V8EventListener::callListenerFunction): Ditto.
        * bindings/v8/custom/V8CustomEventListener.h:
        (WebCore::V8EventListener::create): Removed Frame* param.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 22 Oct 2009 18:10:41 +0000 (18:10 +0000)]
2009-10-22  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein & Simon Fraser.

        <rdar://problem/7297717>
        https://bugs.webkit.org/show_bug.cgi?id=30323
        Play/pause button in full-screen video controller does not reflect current state

        * WebView/WebVideoFullscreenController.mm:
        (-[WebVideoFullscreenController setMediaElement:WebCore::]): Register for QTMovieRateDidChangeNotification
        (-[WebVideoFullscreenController rateChanged:]): Call HUD controller when rate changes.

        * WebView/WebVideoFullscreenHUDWindowController.h:
        * WebView/WebVideoFullscreenHUDWindowController.mm:
        (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Call updateRate so play button
        reflects playback state.
        (-[WebVideoFullscreenHUDWindowController updateRate]): New, set play button state according to
        movie state.
        (-[WebVideoFullscreenHUDWindowController playingChanged:]): Only call [self playing] once.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-14 Gaurav Shah <gauravsh@google.com>
darin@chromium.org [Thu, 22 Oct 2009 17:49:34 +0000 (17:49 +0000)]
2009-10-14  Gaurav Shah  <gauravsh@google.com>

        Reviewed by Darin Fisher.

        Replaces temporary link stub for <keygen> tag handler for the Chromium
        browser with a call via the Chromium Bridge.

        https://bugs.webkit.org/show_bug.cgi?id=30360

        * platform/SSLKeyGenerator.h:
        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/SSLKeyGeneratorChromium.cpp:
        (WebCore::getSupportedKeySizes):
        (WebCore::signedPublicKeyAndChallengeString):
        * platform/chromium/TemporaryLinkStubs.cpp:
        (WebCore::KURL::fileSystemPath):
        (WebCore::SharedBuffer::createWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes Chromium Mac pasteboard handling to flow through the same code paths as other...
atwilson@chromium.org [Thu, 22 Oct 2009 17:48:45 +0000 (17:48 +0000)]
Fixes Chromium Mac pasteboard handling to flow through the same code paths as other platforms.

Patch by Avi Drissman <avi@chromium.org> on 2009-10-22
Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30591

* platform/chromium/ChromiumBridge.h:
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 22 Oct 2009 17:33:03 +0000 (17:33 +0000)]
2009-10-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Make accelerated compositing debug indicators work in release builds
        https://bugs.webkit.org/show_bug.cgi?id=30588

        Allow some debug indicators, that show which page elements go into compositing layers,
        to work in release builds, when the runtime prefs are set.

        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::GraphicsLayer):
        (WebCore::GraphicsLayer::setZPosition):
        * platform/graphics/GraphicsLayer.h:
        * platform/graphics/mac/GraphicsLayerCA.h:
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::clearBorderColor):
        (WebCore::GraphicsLayer::showRepaintCounter):
        (WebCore::GraphicsLayerCA::GraphicsLayerCA):
        (WebCore::GraphicsLayerCA::updateMasksToBounds):
        (WebCore::GraphicsLayerCA::updateLayerDrawsContent):
        (WebCore::GraphicsLayerCA::setDebugBorder):
        (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
        (WebCore::GraphicsLayerCA::setupContentsLayer):
        * platform/graphics/mac/WebLayer.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 22 Oct 2009 17:30:03 +0000 (17:30 +0000)]
2009-10-22  Xan Lopez  <xlopez@igalia.com>

        Skip failing tests that seems to be somewhat tied to the Mac
        platform. See https://bugs.webkit.org/show_bug.cgi?id=30680

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCode standarlization for QGVLauncher.
tonikitoo@webkit.org [Thu, 22 Oct 2009 16:42:39 +0000 (16:42 +0000)]
Code standarlization for QGVLauncher.

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-22
RubberStamped by Tor Arne Vestbø.

1) Made member initilization lists in constructors
   to be per line.
2) Made applyProxy method inline as all other methods in
   WebPage class.

* QGVLauncher/main.cpp:
(WebPage::WebPage):
(WebPage::applyProxy):
(MainView::MainView):
(MainWindow::MainWindow):
(MainWindow::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a Y-Axis rotation to QGVLauncher.
tonikitoo@webkit.org [Thu, 22 Oct 2009 16:34:38 +0000 (16:34 +0000)]
Add a Y-Axis rotation to QGVLauncher.

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-22
Reviewed by Tor Arne Vestbø.

It uses the QStateMachine API from Qt 4.6.

* QGVLauncher/main.cpp:
(WebView::WebView):
(WebView::setYRotation):
(WebView::yRotation):
(MainView::flip):
(MainView::animatedYFlip):
(SharedScene::SharedScene):
(SharedScene::webView):
(MainWindow::init):
(MainWindow::animatedYFlip):
(MainWindow::buildUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Thu, 22 Oct 2009 15:53:11 +0000 (15:53 +0000)]
2009-10-22  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson.

        Fix video-played.js to use an error timeout based on time rather than function call count.

        https://bugs.webkit.org/show_bug.cgi?id=30657

        * media/video-played.js:
        (nowInSecs): Returns the current time in seconds.
        (playForMillisecs.callPauseIfTimeIsReached): Change from call counts to using elapsed time.
        (playForMillisecs): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Keishi Hattori <casey.hattori@gmail.com>
eric@webkit.org [Thu, 22 Oct 2009 15:45:47 +0000 (15:45 +0000)]
2009-10-22  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Pavel Feldman.

        Inspector should support monitorEvents/un monitorEvents() in the command line
        https://bugs.webkit.org/show_bug.cgi?id=19879

        * inspector/front-end/EventListenersSidebarPane.js:
        (WebInspector.EventListenersSidebarPane.prototype.update.callback): Ignores event listeners generated by monitorEvent
        * inspector/front-end/InjectedScript.js:
        (InjectedScript._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI._logEvent, _allEventTypes,
        _normalizeEventTypes, monitorEvent, unmonitorEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 22 Oct 2009 15:28:58 +0000 (15:28 +0000)]
2009-10-21  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: windowFocused and windowBlurred Fail to Clear/Mark Inspector as "inactive"
        https://bugs.webkit.org/show_bug.cgi?id=30663

        * inspector/front-end/inspector.js:
        (WebInspector.windowFocused):
        (WebInspector.windowBlurred):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 22 Oct 2009 15:23:20 +0000 (15:23 +0000)]
2009-10-22  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Error - requestContentType [undefined] is not an object
        https://bugs.webkit.org/show_bug.cgi?id=30666

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.prototype._refreshFormData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Thu, 22 Oct 2009 11:52:52 +0000 (11:52 +0000)]
2009-10-22  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Holger Freyther.

        [Haiku] Correction of the accented letter width (they were 2 characters long).
        https://bugs.webkit.org/show_bug.cgi?id=30629

        * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
        (WebCore::SimpleFontData::platformWidthForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Thu, 22 Oct 2009 10:49:44 +0000 (10:49 +0000)]
2009-10-22  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        m_webView should be private attribute of the EditorClientGtk.
        https://bugs.webkit.org/show_bug.cgi?id=30664

        * WebKit/gtk/WebCoreSupport/EditorClientGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 22 Oct 2009 10:39:12 +0000 (10:39 +0000)]
2009-10-22  Xan Lopez  <xlopez@igalia.com>

        libsoup can reconstruct URIs with empty querys now, so unskip
        another bunch of tests.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 22 Oct 2009 10:24:32 +0000 (10:24 +0000)]
2009-10-22  Xan Lopez  <xlopez@igalia.com>

        Unskip a couple of working tests.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7270320> Screenshots of off-screen plug-ins are blank
jhoneycutt@apple.com [Thu, 22 Oct 2009 07:15:28 +0000 (07:15 +0000)]
<rdar://problem/7270320> Screenshots of off-screen plug-ins are blank
<rdar://problem/7270314> After halting a transparent PluginView on
Windows, the transparency is applied twice

JavaScriptCore:

Reviewed by Dan Bernstein.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Export WTF::deleteOwnedPtr(HDC).

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Ditto.

WebCore:

Replace use of Frame::nodeImage() with a function that takes a snapshot
of a PluginView.

Reviewed by Dan Bernstein.

* plugins/PluginView.h:
Made paintWindowedPluginIntoContext() non-const, as it now calls
paintIntoTransformedContext(). Declare paintIntoTransformedContext()
and snapshot() for Windows platforms.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintIntoTransformedContext):
Paints into the passed HDC without applying any coordinate translations.
Code moved from paintWindowedPluginIntoContext() and paint(). Removed
the memset() of windowpos in lieu of assignment.
(WebCore::PluginView::paintWindowedPluginIntoContext):
Code moved to paintIntoTransformedContext().
(WebCore::PluginView::paint):
Ditto.
(WebCore::PluginView::snapshot):
Create a context, and if the plug-in is windowless, translate it so the
plug-in will draw at the correct location. Create a bitmap, and select
it into the context. Paint the plug-in, and create a BitmapImage from
the bitmap.
(WebCore::PluginView::halt):
Use snapshot().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-22 Fumitoshi Ukai <ukai@chromium.org>
eric@webkit.org [Thu, 22 Oct 2009 07:11:24 +0000 (07:11 +0000)]
2009-10-22  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix calculation of length in WebSocketChannel.cpp
        https://bugs.webkit.org/show_bug.cgi?id=30656

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Oct 2009 06:20:26 +0000 (06:20 +0000)]
2009-10-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool's "patch failed to download an apply" error should give more information
        https://bugs.webkit.org/show_bug.cgi?id=30632

        * Scripts/modules/scm.py:
         - Use the common run_command method instead of custom POpen code.
         - Make run_command know how to take pipes as input.
        * Scripts/modules/scm_unittest.py:
         - Add new tests to cover change.
         - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agocommitters
tkent@chromium.org [Thu, 22 Oct 2009 04:32:32 +0000 (04:32 +0000)]
committers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdding the ability to enable/disable functions in V8 at runtime.
dumi@chromium.org [Wed, 21 Oct 2009 23:57:01 +0000 (23:57 +0000)]
Adding the ability to enable/disable functions in V8 at runtime.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-21
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=30650

* bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCombine local and session storage tests into one and use script-tests properly
jorlow@chromium.org [Wed, 21 Oct 2009 23:47:20 +0000 (23:47 +0000)]
Combine local and session storage tests into one and use script-tests properly
https://bugs.webkit.org/show_bug.cgi?id=30640

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-21
Reviewed by Darin Adler.

I was apparently misusing the script-tests stuff.  I changed all the tests to
test both local storage and session storage so that we can use the
make-test-script-wrappers stuff as is.

* storage/domstorage/clear-expected.txt: Added.
* storage/domstorage/clear.html: Added.
* storage/domstorage/complex-keys-expected.txt: Added.
* storage/domstorage/complex-keys.html: Added.
* storage/domstorage/complex-values-expected.txt: Added.
* storage/domstorage/complex-values.html: Added.
* storage/domstorage/localstorage/clear-expected.txt: Removed.
* storage/domstorage/localstorage/clear.html: Removed.
* storage/domstorage/localstorage/complex-keys-expected.txt: Removed.
* storage/domstorage/localstorage/complex-keys.html: Removed.
* storage/domstorage/localstorage/complex-values-expected.txt: Removed.
* storage/domstorage/localstorage/complex-values.html: Removed.
* storage/domstorage/localstorage/quota-expected.txt: Removed.
* storage/domstorage/localstorage/quota.html: Removed.
* storage/domstorage/localstorage/remove-item-expected.txt: Removed.
* storage/domstorage/localstorage/remove-item.html: Removed.
* storage/domstorage/quota-expected.txt: Added.
* storage/domstorage/quota.html: Added.
* storage/domstorage/remove-item-expected.txt: Added.
* storage/domstorage/remove-item.html: Added.
* storage/domstorage/script-tests/TEMPLATE.html: Added.
* storage/domstorage/script-tests/clear.js:
(test):
(runTest):
* storage/domstorage/script-tests/complex-keys.js:
(test):
(runTest):
* storage/domstorage/script-tests/complex-values.js:
(test):
(runTest):
* storage/domstorage/script-tests/no-quota.js: Removed.
* storage/domstorage/script-tests/quota.js:
(testQuota):
(testNoQuota):
(runTest):
* storage/domstorage/script-tests/remove-item.js:
(test):
(runTest):
* storage/domstorage/sessionstorage/clear-expected.txt: Removed.
* storage/domstorage/sessionstorage/clear.html: Removed.
* storage/domstorage/sessionstorage/complex-keys-expected.txt: Removed.
* storage/domstorage/sessionstorage/complex-keys.html: Removed.
* storage/domstorage/sessionstorage/complex-values-expected.txt: Removed.
* storage/domstorage/sessionstorage/complex-values.html: Removed.
* storage/domstorage/sessionstorage/no-quota-expected.txt: Removed.
* storage/domstorage/sessionstorage/no-quota.html: Removed.
* storage/domstorage/sessionstorage/remove-item-expected.txt: Removed.
* storage/domstorage/sessionstorage/remove-item.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Wed, 21 Oct 2009 23:39:09 +0000 (23:39 +0000)]
Reviewed by Kevin Ollivier.

Update the Windows installer builder to work with Vista / Win 7 and with git.

https://bugs.webkit.org/show_bug.cgi?id=30649

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Swedish search (and other languages as well) is broken while fixing Japanese...
darin@apple.com [Wed, 21 Oct 2009 23:10:16 +0000 (23:10 +0000)]
WebCore: Swedish search (and other languages as well) is broken while fixing Japanese search
https://bugs.webkit.org/show_bug.cgi?id=30646

Patch by Darin Adler <darin@apple.com> on 2009-10-21
Rolled Japanese tailoring out that was done to fix
https://bugs.webkit.org/show_bug.cgi?id=30437 earlier.
It was overriding the locale-specific tailoring.
We'll land a fix once we figure out how to add the
Japanese tailoring without removing anything.

* editing/TextIterator.cpp: Rolled out r49924.

LayoutTests: Update since we rolled Japanese tailoring out that was done to fix
https://bugs.webkit.org/show_bug.cgi?id=30437 earlier.

Patch by Darin Adler <darin@apple.com> on 2009-10-21
* fast/text/international/japanese-kana-letters-expected.txt: Update
test results to expect failure. We'll land results that expect
success once we re-fix the bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Wed, 21 Oct 2009 23:06:47 +0000 (23:06 +0000)]
2009-10-21  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Seidel.

        Update more media layout tests to use findMediaFile().

        https://bugs.webkit.org/show_bug.cgi?id=30644

        * media/controls-drag-timebar.html: Switch to using findMediaFile().
        * media/video-currentTime-set.html: Remove src attribute and rely on findMediaFile() instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r49922 because it broke Tiger and SL in strange ways.
bweinstein@apple.com [Wed, 21 Oct 2009 22:16:34 +0000 (22:16 +0000)]
Roll out r49922 because it broke Tiger and SL in strange ways.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 21 Oct 2009 21:59:28 +0000 (21:59 +0000)]
2009-10-21  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: chromium build fix - add missing image to gypi.

        * WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fixes part of <http://webkit.org/b/30522>.
bweinstein@apple.com [Wed, 21 Oct 2009 21:51:20 +0000 (21:51 +0000)]
WebCore: Fixes part of <webkit.org/b/30522>.
Web Inspector: DOM Exceptions throughout the Inspector should be more human readable.

Reviewed by Eric Seidel.

Expose the description attribute that is now a member of
ExceptionBase as of r49723, so when a user logs an exception, they
can see the description in the Web Inspector.

Test: fast/dom/dom-exception-description.html

* dom/DOMCoreException.idl:
* dom/EventException.idl:
* dom/RangeException.idl:
* svg/SVGException.idl:
* xml/XMLHttpRequestException.idl:
* xml/XPathException.idl:

LayoutTests: Fixes part of <http://webkit.org/b/30522>.
Web Inspector: DOM Exceptions throughout the Inspector should be more human readable.

Reviewed by Eric Seidel.

Adds a test to check the name and description of some DOM Exceptions.

* fast/dom/dom-exception-description-expected.txt: Added.
* fast/dom/dom-exception-description.html: Added.
* fast/dom/script-tests/dom-exception-description.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Wed, 21 Oct 2009 20:47:21 +0000 (20:47 +0000)]
2009-10-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Added conditional code to avoid using
        gdk_window_get_root_coords if we do not have a gtk+ release newer
        than 2.17.3.
        https://bugs.webkit.org/show_bug.cgi?id=30636

        * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Dan Bernstein.
sullivan@apple.com [Wed, 21 Oct 2009 20:02:32 +0000 (20:02 +0000)]
Rubber-stamped by Dan Bernstein.

* WebView/WebDynamicScrollBarsView.h:
Corrected a couple of long-obsolete comments regarding Safari's use of this class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes <https://bugs.webkit.org/show_bug.cgi?id=30616>.
bweinstein@apple.com [Wed, 21 Oct 2009 19:53:59 +0000 (19:53 +0000)]
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30616>.
REGRESSION (r49036): Web Inspector: Summary graph no longer switching to size summary.

Reviewed by Timothy Hatcher.

Add a check to make sure a function we need to calculate percentages is
defined before we use it.

* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Wed, 21 Oct 2009 19:43:48 +0000 (19:43 +0000)]
2009-10-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Removed 5333725.html from Skipped and modified the expected
        result of 5232159-expected.txt and fake-drag-expected.txt, this
        modifications come from the changes in EventSender (bug 30633 and
        bug 30636).
        https://bugs.webkit.org/show_bug.cgi?id=30593

        * LayoutTests/platform/gtk/Skipped:
        * LayoutTests/platform/gtk/editing/selection/5232159-expected.txt:
        * LayoutTests/platform/gtk/editing/selection/fake-drag-expected.tx :

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Keishi Hattori <casey.hattori@gmail.com>
eric@webkit.org [Wed, 21 Oct 2009 19:36:08 +0000 (19:36 +0000)]
2009-10-21  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        REGRESSION: Clicking on nodes in the console should take you to the element in the DOM
        https://bugs.webkit.org/show_bug.cgi?id=27231

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._formatnode): Turns on ElementsTreeOutline.showInElementsPanelEnabled
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline): Added ElementsTreeOutline.showInElementsPanelEnabled
        (WebInspector.ElementsTreeElement.prototype.onmousedown): Reveals the node in the Elements panel if
        treeOutline.showInElementsPanelEnabled is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=30637
jorlow@chromium.org [Wed, 21 Oct 2009 19:22:36 +0000 (19:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30637
Fix a compiler warning in windows.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-21
Reviewed by Eric Seidel.

* loader/ResourceLoadNotifier.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Wed, 21 Oct 2009 19:18:49 +0000 (19:18 +0000)]
2009-10-21  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Added dummy implementation for keepWebHistory()
        https://bugs.webkit.org/show_bug.cgi?id=30592

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::keepWebHistory):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Victor Wang <victorw@chromium.org>
eric@webkit.org [Wed, 21 Oct 2009 19:10:57 +0000 (19:10 +0000)]
2009-10-21  Victor Wang  <victorw@chromium.org>

        Reviewed by Eric Seidel.

        Fix click-focus-anchor layout test to mimic click event.

        https://bugs.webkit.org/show_bug.cgi?id=30610

        * fast/events/click-focus-anchor.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Wed, 21 Oct 2009 19:03:30 +0000 (19:03 +0000)]
2009-10-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Fixed the double click condition, it is not double click if
        we move in just in one direction.
        https://bugs.webkit.org/show_bug.cgi?id=30636

        * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Wed, 21 Oct 2009 18:55:50 +0000 (18:55 +0000)]
2009-10-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Initialize the events completly before emitting them.
        https://bugs.webkit.org/show_bug.cgi?id=30633

        * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the crash when a node not in a document receives dispatchEvent.
dimich@chromium.org [Wed, 21 Oct 2009 18:32:37 +0000 (18:32 +0000)]
Fix the crash when a node not in a document receives dispatchEvent.
https://bugs.webkit.org/show_bug.cgi?id=30611

Reviewed by Darin Adler.

WebCore:

Test: fast/events/dispatch-event-no-document.html

* dom/EventTarget.cpp: Check for scriptExecutionContext() at the moment of dispatchEvent; do nothing if no context.
(WebCore::EventTarget::dispatchEvent):

LayoutTests:

* fast/events/dispatch-event-no-document-expected.txt: Added.
* fast/events/dispatch-event-no-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Fix for when linking using --as-needed with gcc.
kevino@webkit.org [Wed, 21 Oct 2009 18:25:54 +0000 (18:25 +0000)]
wx build fix. Fix for when linking using --as-needed with gcc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Adam Langley <agl@google.com>
agl@chromium.org [Wed, 21 Oct 2009 18:23:12 +0000 (18:23 +0000)]
2009-10-21  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Chromium Linux: disable subpixel text on layers.

        https://bugs.webkit.org/show_bug.cgi?id=30635
        http://code.google.com/p/chromium/issues/detail?id=25365

        With the addition of layers for drawing rounded corners in r49641,
        subpixel text on rounded rectangles broke. This is because the layer
        only contains a single alpha channel and this is insufficient to
        compose subpixel text correctly.

        On Windows, a large body of code in TransparencyWin.cpp exists to try
        to deal with this. Even then, in some cases, it downgrades to
        anti-aliased text. We need a fix for the grevious effects quickly thus
        this patch disables subpixel text when rendering into a layer.

        This would be covered by existing tests except that subpixel text is
        disabled for pixel tests on Chromium Linux.

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::isCanvasMultiLayered):
        (WebCore::adjustTextRenderMode):
        (WebCore::Font::drawGlyphs):
        (WebCore::Font::drawComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Wed, 21 Oct 2009 18:13:09 +0000 (18:13 +0000)]
Reviewed by Kevin Ollivier.

Include 'WebFrame.h' declared classes in wxPython bindings.

https://bugs.webkit.org/show_bug.cgi?id=30504

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowxMac build fixes. Fix issues with linking against wrong versions of sqlite3 and...
kevino@webkit.org [Wed, 21 Oct 2009 18:06:31 +0000 (18:06 +0000)]
wxMac build fixes. Fix issues with linking against wrong versions of sqlite3 and curl on Mac 10.4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fixed background-clip parsing regressions introduced in r46240.
mitz@apple.com [Wed, 21 Oct 2009 16:47:57 +0000 (16:47 +0000)]
WebCore: Fixed background-clip parsing regressions introduced in r46240.

Reviewed by Sam Weinig.

Test: fast/css/background-clip-text.html

* css/CSSParser.cpp:
(WebCore::parseBackgroundClip): Added this helper method.
(WebCore::CSSParser::parseFillShorthand): Use parseBackgroundClip() to
reparse the value. The old code called parseFillProperty() again, which
didn’t work, because parseFillProperty() advances the value list.
(WebCore::CSSParser::parseFillProperty): Changed to use
parseBackgroundClip().
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EFillBox): Added a case for
CSSValueWebkitText.

LayoutTests: Added a background-clip parsing test that would have caught some
regressions that were introduced in r46240.

Reviewed by Sam Weinig.

* fast/css/background-clip-text-expected.txt: Added.
* fast/css/background-clip-text.html: Added.
* fast/css/script-tests: Added.
* fast/css/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/backgrounds/repeat/script-tests/TEMPLATE.html.
* fast/css/script-tests/background-clip-text.js: Added.
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Wed, 21 Oct 2009 13:57:12 +0000 (13:57 +0000)]
2009-10-21  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.

        Enable creation of custom SidebarTreeElements for different ProfileTypes

        ProfileTypes can now create sidebar tree elements of custom types.
        https://bugs.webkit.org/show_bug.cgi?id=30520

        * inspector/front-end/ProfileView.js:
        (WebInspector.CPUProfileType.prototype.setRecordingProfile):
        (WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile):
        (WebInspector.CPUProfileType.prototype.createView):
        (WebInspector.CPUProfile.prototype.get head):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfileType.prototype.buttonClicked):
        (WebInspector.ProfileType.prototype.viewForProfile):
        (WebInspector.ProfileType.prototype.createView):
        (WebInspector.ProfileType.prototype.createSidebarTreeElementForProfile):
        (WebInspector.ProfilesPanel.prototype.addProfileHeader):
        (WebInspector.ProfilesPanel.prototype.showProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-20 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 21 Oct 2009 13:45:12 +0000 (13:45 +0000)]
2009-10-20  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Selectors in the Styles pane should trigger a search for that selector when clicked
        https://bugs.webkit.org/show_bug.cgi?id=17126

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.addNodesToSearchResult): only change focusedDOMNode on a manual search
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertiesSection.prototype._clickSelector): trigger a search
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._startEditing): correctly start editing attribute value instead of name

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-20 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 21 Oct 2009 13:33:25 +0000 (13:33 +0000)]
2009-10-20  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Fix DOM Agent leak.

        https://bugs.webkit.org/show_bug.cgi?id=30615

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::~InspectorController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Girish Ramakrishnan <girish@forwardbias.in>
eric@webkit.org [Wed, 21 Oct 2009 13:08:07 +0000 (13:08 +0000)]
2009-10-21  Girish Ramakrishnan  <girish@forwardbias.in>

        Reviewed by Holger Freyther.

        Plugins: Create manual tests for testing plugins

        Create two test files:
        1. windowed.html - Test plugin in windowed mode.
        2. windowless.html - Test plugin in windowless mode.

        https://bugs.webkit.org/show_bug.cgi?id=30503

        * manual-tests/plugins/windowed.html: Added.
        * manual-tests/plugins/windowless.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 21 Oct 2009 09:10:46 +0000 (09:10 +0000)]
2009-10-21  Xan Lopez  <xlopez@igalia.com>

        Skip another failing test.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 21 Oct 2009 07:52:08 +0000 (07:52 +0000)]
2009-10-21  Xan Lopez  <xlopez@igalia.com>

        Skip a few more libxml2 related tests.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-21 Satoshi Nakagawa <psychs@limechat.net>
eric@webkit.org [Wed, 21 Oct 2009 07:11:08 +0000 (07:11 +0000)]
2009-10-21  Satoshi Nakagawa  <psychs@limechat.net>

        Reviewed by Darin Adler.

        Fixed Japanese text search problems.
        Treat small kana letters and kana letters as different characters in search.
        Do not ignore diacritic marks in search for Japanese texts.

        https://bugs.webkit.org/show_bug.cgi?id=30437

        * fast/text/international/japanese-kana-letters-expected.txt: Added.
        * fast/text/international/japanese-kana-letters.html: Added.
2009-10-21  Satoshi Nakagawa  <psychs@limechat.net>

        Reviewed by Darin Adler.

        Fixed Japanese text search problems.
        Treat small kana letters and kana letters as different characters in search.
        Do not ignore diacritic marks in search for Japanese texts.

        https://bugs.webkit.org/show_bug.cgi?id=30437

        Test: fast/text/international/japanese-kana-letters.html

        * editing/TextIterator.cpp:
        (WebCore::createCollator):
        (WebCore::collator):
        (WebCore::createSearcher):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-20 Eric Z. Ayers <zundel@google.com>
eric@webkit.org [Wed, 21 Oct 2009 04:56:44 +0000 (04:56 +0000)]
2009-10-20  Eric Z. Ayers  <zundel@google.com>

        Reviewed by Timothy Hatcher.

        Changes TimelineItems to be created with raw timestamps as opposed
        to a time relative to a start of session.  Normalized timestamps cause
        problems when monitoring a browsing session across multiple page
        transitions.

        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
        (WebCore::InspectorTimelineAgent::willDispatchDOMEvent):
        (WebCore::InspectorTimelineAgent::willLayout):
        (WebCore::InspectorTimelineAgent::willRecalculateStyle):
        (WebCore::InspectorTimelineAgent::willPaint):
        (WebCore::InspectorTimelineAgent::willWriteHTML):
        (WebCore::InspectorTimelineAgent::reset):
        (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
        * inspector/InspectorTimelineAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-20 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 21 Oct 2009 03:37:02 +0000 (03:37 +0000)]
2009-10-20  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: simple console tests do not require testing harness.

        https://bugs.webkit.org/show_bug.cgi?id=30478

        * inspector/uncaught-dom1-exception-expected.txt:
        * inspector/uncaught-dom1-exception.html:
        * inspector/uncaught-dom3-exception-expected.txt:
        * inspector/uncaught-dom3-exception.html:
        * inspector/uncaught-dom8-exception-expected.txt:
        * inspector/uncaught-dom8-exception.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix leak of WebSocketChannel by adopting the newly-created reference.
mrowe@apple.com [Wed, 21 Oct 2009 02:31:48 +0000 (02:31 +0000)]
Fix leak of WebSocketChannel by adopting the newly-created reference.

Reviewed by Oliver Hunt.

* websockets/WebSocketChannel.h:
(WebCore::WebSocketChannel::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r49876 as it causes many assertion failures during regression tests on SnowL...
mrowe@apple.com [Wed, 21 Oct 2009 00:42:47 +0000 (00:42 +0000)]
Roll out r49876 as it causes many assertion failures during regression tests on SnowLeopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDOM Storage runtime flag changes
jorlow@chromium.org [Wed, 21 Oct 2009 00:40:55 +0000 (00:40 +0000)]
DOM Storage runtime flag changes
https://bugs.webkit.org/show_bug.cgi?id=30602

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-20
Reviewed by Adam Barth.

Part 1/2.  Removing sessionStorageEnabled in next patch after the
Chromium side of the changes lands.

Revert my changes to Settings and instead implement DOM Storage enabling via
the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240

This stuff was (intentionally) never exposed to web pages or DRT, so there's no
LayoutTest visible changes and thus no tests.

* bindings/v8/custom/V8CustomBinding.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
* page/DOMWindow.idl:
* storage/Storage.cpp:
(WebCore::Storage::setLocalStorageAvailable):
(WebCore::Storage::localStorageAvailable):
(WebCore::Storage::setSessionStorageAvailable):
(WebCore::Storage::sessionStorageAvailable):
* storage/Storage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNeed to turn off notifications properly at runtime
atwilson@chromium.org [Wed, 21 Oct 2009 00:22:12 +0000 (00:22 +0000)]
Need to turn off notifications properly at runtime
https://bugs.webkit.org/show_bug.cgi?id=30409

Patch by John Gregg <johnnyg@google.com> on 2009-10-20
Reviewed by David Levin.

This code only affects chromium, and is all behind a compile time
flag current turned off, so no new tests.

* bindings/v8/custom/V8CustomBinding.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
* notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::setIsAvailable):
(WebCore::NotificationCenter::isAvailable):
* notifications/NotificationCenter.h:
* page/DOMWindow.idl:
* workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-20 James Robinson <jamesr@chromium.org>
eric@webkit.org [Wed, 21 Oct 2009 00:08:52 +0000 (00:08 +0000)]
2009-10-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Fixes RefPtr initialization in the V8 implementation of WebCore::ScriptString to use the ::create() idiom and
        use adoptRef() properly.  I failed to read the RefPtr docs the first time through :(

        No new tests, error was caught by valgrind on the Chromium builders.

        * bindings/v8/ScriptString.h:
        (WebCore::ScriptString::ScriptString):
        (WebCore::ScriptString::operator=):
        * bindings/v8/ScriptStringImpl.h:
        (WebCore::ScriptStringImpl::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-20 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Tue, 20 Oct 2009 23:10:46 +0000 (23:10 +0000)]
2009-10-20  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: populate child nodes before sorting them.

        https://bugs.webkit.org/show_bug.cgi?id=29673

        * inspector/front-end/BottomUpProfileDataGridTree.js:
        (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode.
        (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
        (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
        (WebInspector.BottomUpProfileDataGridNode.prototype._exclude):
        (WebInspector.BottomUpProfileDataGridNode.prototype._merge):
        (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
        (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
        * inspector/front-end/ProfileDataGridTree.js:
        (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses.
        (WebInspector.ProfileDataGridNode.prototype.get _parent):
        (WebInspector.ProfileDataGridNode.prototype._populate):
        * inspector/front-end/TopDownProfileDataGridTree.js:
        (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove redundant String ref/deref calls in generated V8 bindings.
jorlow@chromium.org [Tue, 20 Oct 2009 21:56:03 +0000 (21:56 +0000)]
Remove redundant String ref/deref calls in generated V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30579

Patch by Jens Alfke <snej@chromium.org> on 2009-10-20
Reviewed by Eric Seidel.

* bindings/v8/V8Binding.h:
(WebCore::toString): Fix return type of 'toString' to make it truly a no-op
    instead of constructing/destructing a String.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49890 268f45cc-cd09-0410-ab3c-d52691b4dbfc