WebKit-https.git
15 years agoLayoutTests:
darin [Mon, 3 Apr 2006 16:25:37 +0000 (16:25 +0000)]
LayoutTests:

        Reviewed by Maciej.

        Adding tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
        REGRESSION: 404s are not displayed
        and http://bugzilla.opendarwin.org/show_bug.cgi?id=7739
        REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]

        In addition I tweaked the httpd conf file to allow us to exec perl CGI scripts.

        * http/conf/httpd.conf:
        * http/tests/misc/error404-expected.checksum: Added.
        * http/tests/misc/error404-expected.png: Added.
        * http/tests/misc/error404-expected.txt: Added.
        * http/tests/misc/error404.pl: Added.
        * http/tests/misc/iframe404-expected.checksum: Added.
        * http/tests/misc/iframe404-expected.png: Added.
        * http/tests/misc/iframe404-expected.txt: Added.
        * http/tests/misc/iframe404.html: Added.

WebCore:

        Reviewed by Maciej.

        Support for fixing http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
        REGRESSION: 404s are not displayed

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge currentForm]): Nuke redundant nil check.
        (-[WebCoreFrameBridge frameElement]): Tweak to not rely on our document, which
        gives a correct result even at the start of our loading process.
        * bindings/objc/DOM.mm:
        (-[DOMDocument _ownerElement]): Nuke redundant nil check.

WebKit:

        Reviewed by Maciej.

        fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
        REGRESSION: 404s are not displayed

        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
        Only cancel failed loads for object elements, not for frames or a whole page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Mon, 3 Apr 2006 16:04:42 +0000 (16:04 +0000)]
    Reviewed by Maciej.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8079
        REGRESSION: Redraw from page cache does not show visited links

        * page/Frame.cpp: (WebCore::Frame::reparseConfiguration): Added back
        updateStyleSelector call that was removed as part of the patch for bug 7907.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Mon, 3 Apr 2006 07:06:47 +0000 (07:06 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Tests for:
        - fixed <rdar://problem/4198619> REGRESSION: tabbing through links fails after hitting text field w/ sys's "tab to all controls" off
        - fixed <rdar://problem/4463760> REGRESSION: Can't tab from old text field (like password fields) to new text field (6811)
        (http://bugzilla.opendarwin.org/show_bug.cgi?id=6811)
        - fixed tab and shift tab don't select the right things
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5685

        * fast/forms/focus-control-to-page-expected.txt: Added.
        * fast/forms/focus-control-to-page.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fixed <rdar://problem/4198619> REGRESSION: tabbing through links fails after hitting text field w/ sys's "tab to all controls" off
        - fixed <rdar://problem/4463760> REGRESSION: Can't tab from old text field (like password fields) to new text field (6811)
        (http://bugzilla.opendarwin.org/show_bug.cgi?id=6811)
        - fixed tab and shift tab don't select the right things
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5685

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::nextKeyViewInFrame):
        * bridge/mac/WebCoreFrameBridge.h:

WebKit:

        Reviewed by Hyatt.

        - fixed <rdar://problem/4198619> REGRESSION: tabbing through links fails after hitting text field w/ sys's "tab to all controls" off
        - fixed <rdar://problem/4463760> REGRESSION: Can't tab from old text field (like password fields) to new text field (6811)
        (http://bugzilla.opendarwin.org/show_bug.cgi?id=6811)
        - fixed tab and shift tab don't select the right things
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5685

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge willMakeFirstResponderForNodeFocus]): New method
        - let WebHTMLView know that the next time it becomes first
        responder, it's to change focus within the page and the right node
        has already been set, so it should not move focus forward or
        backward inside it.
        * WebView/WebHTMLView.m:
        (-[NSArray needsPanelToBecomeKey]): Override to return YES, oddly enough this
        is the right way to tell AppKit that you should be in the tab cycle loop.
        (-[NSArray becomeFirstResponder]): Don't move forward or back in tab cycle
        when this becomeFirstResponder is for tabbing from a control in the page.
        (-[WebHTMLView _willMakeFirstResponderForNodeFocus]): Note that the next
        time this view becomes first responder, it will be for in-page focus
        navigation.
        * WebView/WebHTMLViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated one more result for change in focus ring appearance
darin [Mon, 3 Apr 2006 01:52:35 +0000 (01:52 +0000)]
    - updated one more result for change in focus ring appearance

        * fast/forms/plaintext-mode-2-expected.checksum: Updated.
        * fast/forms/plaintext-mode-2-expected.png: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - add a few stubs to get Windows closer to building
darin [Mon, 3 Apr 2006 01:39:33 +0000 (01:39 +0000)]
    - add a few stubs to get Windows closer to building

        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::focusRingColor):
        (WebCore::setFocusRingColorChangeFunction):
        (Frame::setNeedsReapplyStyles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix the build
darin [Mon, 3 Apr 2006 01:26:44 +0000 (01:26 +0000)]
    - fix the build

        * WebCore.xcodeproj/project.pbxproj: Removed a bunch of files that should not have been
        mentioned at all, and a bunch of others that should be in the project but not in the target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated layout test results, mostly for the change in focus ring appearance
darin [Mon, 3 Apr 2006 01:17:41 +0000 (01:17 +0000)]
    - updated layout test results, mostly for the change in focus ring appearance

        * editing/input/range-for-empty-document-expected.txt:

        * editing/selection/3690703-2-expected.checksum:
        * editing/selection/3690703-2-expected.png:
        * editing/selection/3690703-2-expected.txt:

        * fast/overflow/scrollRevealButton-expected.checksum:
        * fast/overflow/scrollRevealButton-expected.png:
        * fast/overflow/scrollRevealButton-expected.txt:

        * editing/deleting/collapse-whitespace-3587601-fix-expected.checksum:
        * editing/deleting/collapse-whitespace-3587601-fix-expected.png:
        * editing/deleting/delete-3608430-fix-expected.checksum:
        * editing/deleting/delete-3608430-fix-expected.png:
        * editing/deleting/delete-3608445-fix-expected.checksum:
        * editing/deleting/delete-3608445-fix-expected.png:
        * editing/deleting/delete-3608462-fix-expected.checksum:
        * editing/deleting/delete-3608462-fix-expected.png:
        * editing/deleting/delete-3959464-fix-expected.checksum:
        * editing/deleting/delete-3959464-fix-expected.png:
        * editing/deleting/delete-4038408-fix-expected.checksum:
        * editing/deleting/delete-4038408-fix-expected.png:
        * editing/deleting/delete-4083333-fix-expected.checksum:
        * editing/deleting/delete-4083333-fix-expected.png:
        * editing/deleting/delete-after-span-ws-001-expected.checksum:
        * editing/deleting/delete-after-span-ws-001-expected.png:
        * editing/deleting/delete-after-span-ws-002-expected.checksum:
        * editing/deleting/delete-after-span-ws-002-expected.png:
        * editing/deleting/delete-after-span-ws-003-expected.checksum:
        * editing/deleting/delete-after-span-ws-003-expected.png:
        * editing/deleting/delete-and-undo-expected.checksum:
        * editing/deleting/delete-and-undo-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-001-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-001-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-002-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-003-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-004-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-005-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-006-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-007-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-008-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-009-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-010-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
        * editing/deleting/delete-block-contents-001-expected.checksum:
        * editing/deleting/delete-block-contents-001-expected.png:
        * editing/deleting/delete-block-contents-002-expected.checksum:
        * editing/deleting/delete-block-contents-002-expected.png:
        * editing/deleting/delete-block-contents-003-expected.checksum:
        * editing/deleting/delete-block-contents-003-expected.png:
        * editing/deleting/delete-block-merge-contents-001-expected.checksum:
        * editing/deleting/delete-block-merge-contents-001-expected.png:
        * editing/deleting/delete-block-merge-contents-002-expected.checksum:
        * editing/deleting/delete-block-merge-contents-002-expected.png:
        * editing/deleting/delete-block-merge-contents-003-expected.checksum:
        * editing/deleting/delete-block-merge-contents-003-expected.png:
        * editing/deleting/delete-block-merge-contents-004-expected.checksum:
        * editing/deleting/delete-block-merge-contents-004-expected.png:
        * editing/deleting/delete-block-merge-contents-005-expected.checksum:
        * editing/deleting/delete-block-merge-contents-005-expected.png:
        * editing/deleting/delete-block-merge-contents-006-expected.checksum:
        * editing/deleting/delete-block-merge-contents-006-expected.png:
        * editing/deleting/delete-block-merge-contents-007-expected.checksum:
        * editing/deleting/delete-block-merge-contents-007-expected.png:
        * editing/deleting/delete-block-merge-contents-008-expected.checksum:
        * editing/deleting/delete-block-merge-contents-008-expected.png:
        * editing/deleting/delete-block-merge-contents-009-expected.checksum:
        * editing/deleting/delete-block-merge-contents-009-expected.png:
        * editing/deleting/delete-block-merge-contents-010-expected.checksum:
        * editing/deleting/delete-block-merge-contents-010-expected.png:
        * editing/deleting/delete-block-merge-contents-011-expected.checksum:
        * editing/deleting/delete-block-merge-contents-011-expected.png:
        * editing/deleting/delete-block-merge-contents-012-expected.checksum:
        * editing/deleting/delete-block-merge-contents-012-expected.png:
        * editing/deleting/delete-block-merge-contents-013-expected.checksum:
        * editing/deleting/delete-block-merge-contents-013-expected.png:
        * editing/deleting/delete-block-merge-contents-014-expected.checksum:
        * editing/deleting/delete-block-merge-contents-014-expected.png:
        * editing/deleting/delete-block-merge-contents-015-expected.checksum:
        * editing/deleting/delete-block-merge-contents-015-expected.png:
        * editing/deleting/delete-block-merge-contents-016-expected.checksum:
        * editing/deleting/delete-block-merge-contents-016-expected.png:
        * editing/deleting/delete-block-merge-contents-017-expected.checksum:
        * editing/deleting/delete-block-merge-contents-017-expected.png:
        * editing/deleting/delete-br-001-expected.checksum:
        * editing/deleting/delete-br-001-expected.png:
        * editing/deleting/delete-br-002-expected.checksum:
        * editing/deleting/delete-br-002-expected.png:
        * editing/deleting/delete-br-003-expected.checksum:
        * editing/deleting/delete-br-003-expected.png:
        * editing/deleting/delete-br-004-expected.checksum:
        * editing/deleting/delete-br-004-expected.png:
        * editing/deleting/delete-br-005-expected.checksum:
        * editing/deleting/delete-br-005-expected.png:
        * editing/deleting/delete-br-006-expected.checksum:
        * editing/deleting/delete-br-006-expected.png:
        * editing/deleting/delete-br-007-expected.checksum:
        * editing/deleting/delete-br-007-expected.png:
        * editing/deleting/delete-character-001-expected.checksum:
        * editing/deleting/delete-character-001-expected.png:
        * editing/deleting/delete-contiguous-ws-001-expected.checksum:
        * editing/deleting/delete-contiguous-ws-001-expected.png:
        * editing/deleting/delete-image-001-expected.checksum:
        * editing/deleting/delete-image-001-expected.png:
        * editing/deleting/delete-image-002-expected.checksum:
        * editing/deleting/delete-image-002-expected.png:
        * editing/deleting/delete-image-003-expected.checksum:
        * editing/deleting/delete-image-003-expected.png:
        * editing/deleting/delete-image-004-expected.checksum:
        * editing/deleting/delete-image-004-expected.png:
        * editing/deleting/delete-leading-ws-001-expected.checksum:
        * editing/deleting/delete-leading-ws-001-expected.png:
        * editing/deleting/delete-line-015-expected.checksum:
        * editing/deleting/delete-line-015-expected.png:
        * editing/deleting/delete-line-016-expected.checksum:
        * editing/deleting/delete-line-016-expected.png:
        * editing/deleting/delete-line-017-expected.checksum:
        * editing/deleting/delete-line-017-expected.png:
        * editing/deleting/delete-line-end-ws-001-expected.checksum:
        * editing/deleting/delete-line-end-ws-001-expected.png:
        * editing/deleting/delete-line-end-ws-002-expected.checksum:
        * editing/deleting/delete-line-end-ws-002-expected.png:
        * editing/deleting/delete-listitem-001-expected.checksum:
        * editing/deleting/delete-listitem-001-expected.png:
        * editing/deleting/delete-listitem-002-expected.checksum:
        * editing/deleting/delete-listitem-002-expected.png:
        * editing/deleting/delete-select-all-001-expected.checksum:
        * editing/deleting/delete-select-all-001-expected.png:
        * editing/deleting/delete-select-all-002-expected.checksum:
        * editing/deleting/delete-select-all-002-expected.png:
        * editing/deleting/delete-select-all-003-expected.checksum:
        * editing/deleting/delete-select-all-003-expected.png:
        * editing/deleting/delete-selection-001-expected.checksum:
        * editing/deleting/delete-selection-001-expected.png:
        * editing/deleting/delete-tab-001-expected.checksum:
        * editing/deleting/delete-tab-001-expected.png:
        * editing/deleting/delete-tab-002-expected.checksum:
        * editing/deleting/delete-tab-002-expected.png:
        * editing/deleting/delete-tab-003-expected.checksum:
        * editing/deleting/delete-tab-003-expected.png:
        * editing/deleting/delete-tab-004-expected.checksum:
        * editing/deleting/delete-tab-004-expected.png:
        * editing/deleting/delete-trailing-ws-001-expected.checksum:
        * editing/deleting/delete-trailing-ws-001-expected.png:
        * editing/deleting/delete-trailing-ws-002-expected.checksum:
        * editing/deleting/delete-trailing-ws-002-expected.png:
        * editing/deleting/delete-ws-fixup-001-expected.checksum:
        * editing/deleting/delete-ws-fixup-001-expected.png:
        * editing/deleting/delete-ws-fixup-002-expected.checksum:
        * editing/deleting/delete-ws-fixup-002-expected.png:
        * editing/deleting/delete-ws-fixup-003-expected.checksum:
        * editing/deleting/delete-ws-fixup-003-expected.png:
        * editing/deleting/delete-ws-fixup-004-expected.checksum:
        * editing/deleting/delete-ws-fixup-004-expected.png:
        * editing/deleting/smart-delete-001-expected.checksum:
        * editing/deleting/smart-delete-001-expected.png:
        * editing/deleting/smart-delete-002-expected.checksum:
        * editing/deleting/smart-delete-002-expected.png:
        * editing/execCommand/boldSelection-expected.checksum:
        * editing/execCommand/boldSelection-expected.png:
        * editing/execCommand/insertHTML-expected.checksum:
        * editing/execCommand/insertHTML-expected.png:
        * editing/execCommand/insertImage-expected.checksum:
        * editing/execCommand/insertImage-expected.png:
        * editing/execCommand/italicizeByCharacter-expected.checksum:
        * editing/execCommand/italicizeByCharacter-expected.png:
        * editing/execCommand/modifyForeColorByCharacter-expected.checksum:
        * editing/execCommand/modifyForeColorByCharacter-expected.png:
        * editing/execCommand/print-expected.checksum:
        * editing/execCommand/print-expected.png:
        * editing/execCommand/selectAll-expected.checksum:
        * editing/execCommand/selectAll-expected.png:
        * editing/execCommand/strikethroughSelection-expected.checksum:
        * editing/execCommand/strikethroughSelection-expected.png:
        * editing/inserting/4278698-expected.checksum:
        * editing/inserting/4278698-expected.png:
        * editing/inserting/editing-empty-divs-expected.checksum:
        * editing/inserting/editing-empty-divs-expected.png:
        * editing/inserting/insert-3659587-fix-expected.checksum:
        * editing/inserting/insert-3659587-fix-expected.png:
        * editing/inserting/insert-3775316-fix-expected.checksum:
        * editing/inserting/insert-3775316-fix-expected.png:
        * editing/inserting/insert-3778059-fix-expected.checksum:
        * editing/inserting/insert-3778059-fix-expected.png:
        * editing/inserting/insert-3800346-fix-expected.checksum:
        * editing/inserting/insert-3800346-fix-expected.png:
        * editing/inserting/insert-after-delete-001-expected.checksum:
        * editing/inserting/insert-after-delete-001-expected.png:
        * editing/inserting/insert-at-end-01-expected.checksum:
        * editing/inserting/insert-at-end-01-expected.png:
        * editing/inserting/insert-at-end-02-expected.checksum:
        * editing/inserting/insert-at-end-02-expected.png:
        * editing/inserting/insert-br-001-expected.checksum:
        * editing/inserting/insert-br-001-expected.png:
        * editing/inserting/insert-br-002-expected.checksum:
        * editing/inserting/insert-br-002-expected.png:
        * editing/inserting/insert-br-003-expected.checksum:
        * editing/inserting/insert-br-003-expected.png:
        * editing/inserting/insert-br-004-expected.checksum:
        * editing/inserting/insert-br-004-expected.png:
        * editing/inserting/insert-br-005-expected.checksum:
        * editing/inserting/insert-br-005-expected.png:
        * editing/inserting/insert-br-006-expected.checksum:
        * editing/inserting/insert-br-006-expected.png:
        * editing/inserting/insert-br-007-expected.checksum:
        * editing/inserting/insert-br-007-expected.png:
        * editing/inserting/insert-br-008-expected.checksum:
        * editing/inserting/insert-br-008-expected.png:
        * editing/inserting/insert-br-at-tabspan-001-expected.checksum:
        * editing/inserting/insert-br-at-tabspan-001-expected.png:
        * editing/inserting/insert-br-at-tabspan-002-expected.checksum:
        * editing/inserting/insert-br-at-tabspan-002-expected.png:
        * editing/inserting/insert-br-at-tabspan-003-expected.checksum:
        * editing/inserting/insert-br-at-tabspan-003-expected.png:
        * editing/inserting/insert-br-quoted-001-expected.checksum:
        * editing/inserting/insert-br-quoted-001-expected.png:
        * editing/inserting/insert-br-quoted-002-expected.checksum:
        * editing/inserting/insert-br-quoted-002-expected.png:
        * editing/inserting/insert-br-quoted-003-expected.checksum:
        * editing/inserting/insert-br-quoted-003-expected.png:
        * editing/inserting/insert-br-quoted-004-expected.checksum:
        * editing/inserting/insert-br-quoted-004-expected.png:
        * editing/inserting/insert-br-quoted-005-expected.checksum:
        * editing/inserting/insert-br-quoted-005-expected.png:
        * editing/inserting/insert-br-quoted-006-expected.checksum:
        * editing/inserting/insert-br-quoted-006-expected.png:
        * editing/inserting/insert-div-025-expected.checksum:
        * editing/inserting/insert-div-025-expected.png:
        * editing/inserting/insert-div-026-expected.checksum:
        * editing/inserting/insert-div-026-expected.png:
        * editing/inserting/insert-space-in-empty-doc-expected.checksum:
        * editing/inserting/insert-space-in-empty-doc-expected.png:
        * editing/inserting/insert-tab-001-expected.checksum:
        * editing/inserting/insert-tab-001-expected.png:
        * editing/inserting/insert-tab-002-expected.checksum:
        * editing/inserting/insert-tab-002-expected.png:
        * editing/inserting/insert-tab-003-expected.checksum:
        * editing/inserting/insert-tab-003-expected.png:
        * editing/inserting/insert-tab-004-expected.checksum:
        * editing/inserting/insert-tab-004-expected.png:
        * editing/inserting/insert-text-at-tabspan-001-expected.checksum:
        * editing/inserting/insert-text-at-tabspan-001-expected.png:
        * editing/inserting/insert-text-at-tabspan-002-expected.checksum:
        * editing/inserting/insert-text-at-tabspan-002-expected.png:
        * editing/inserting/insert-text-at-tabspan-003-expected.checksum:
        * editing/inserting/insert-text-at-tabspan-003-expected.png:
        * editing/inserting/insert-text-with-newlines-expected.checksum:
        * editing/inserting/insert-text-with-newlines-expected.png:
        * editing/inserting/return-key-with-selection-001-expected.checksum:
        * editing/inserting/return-key-with-selection-001-expected.png:
        * editing/inserting/return-key-with-selection-002-expected.checksum:
        * editing/inserting/return-key-with-selection-002-expected.png:
        * editing/inserting/return-key-with-selection-003-expected.checksum:
        * editing/inserting/return-key-with-selection-003-expected.png:
        * editing/inserting/typing-001-expected.checksum:
        * editing/inserting/typing-001-expected.png:
        * editing/inserting/typing-002-expected.checksum:
        * editing/inserting/typing-002-expected.png:
        * editing/inserting/typing-003-expected.checksum:
        * editing/inserting/typing-003-expected.png:
        * editing/inserting/typing-around-br-001-expected.checksum:
        * editing/inserting/typing-around-br-001-expected.png:
        * editing/inserting/typing-around-image-001-expected.checksum:
        * editing/inserting/typing-around-image-001-expected.png:
        * editing/pasteboard/3976872-expected.checksum:
        * editing/pasteboard/3976872-expected.png:
        * editing/pasteboard/4076267-2-expected.checksum:
        * editing/pasteboard/4076267-2-expected.png:
        * editing/pasteboard/4076267-3-expected.checksum:
        * editing/pasteboard/4076267-3-expected.png:
        * editing/pasteboard/4076267-expected.checksum:
        * editing/pasteboard/4076267-expected.png:
        * editing/pasteboard/block-wrappers-necessary-expected.checksum:
        * editing/pasteboard/block-wrappers-necessary-expected.png:
        * editing/pasteboard/cut-text-001-expected.checksum:
        * editing/pasteboard/cut-text-001-expected.png:
        * editing/pasteboard/display-block-on-spans-expected.checksum:
        * editing/pasteboard/display-block-on-spans-expected.png:
        * editing/pasteboard/paste-4035648-fix-expected.checksum:
        * editing/pasteboard/paste-4035648-fix-expected.png:
        * editing/pasteboard/paste-4038267-fix-expected.checksum:
        * editing/pasteboard/paste-4038267-fix-expected.png:
        * editing/pasteboard/paste-4039777-fix-expected.checksum:
        * editing/pasteboard/paste-4039777-fix-expected.png:
        * editing/pasteboard/paste-line-endings-001-expected.checksum:
        * editing/pasteboard/paste-line-endings-001-expected.png:
        * editing/pasteboard/paste-line-endings-002-expected.checksum:
        * editing/pasteboard/paste-line-endings-002-expected.png:
        * editing/pasteboard/paste-line-endings-003-expected.checksum:
        * editing/pasteboard/paste-line-endings-003-expected.png:
        * editing/pasteboard/paste-line-endings-004-expected.checksum:
        * editing/pasteboard/paste-line-endings-004-expected.png:
        * editing/pasteboard/paste-line-endings-005-expected.checksum:
        * editing/pasteboard/paste-line-endings-005-expected.png:
        * editing/pasteboard/paste-line-endings-006-expected.checksum:
        * editing/pasteboard/paste-line-endings-006-expected.png:
        * editing/pasteboard/paste-line-endings-007-expected.checksum:
        * editing/pasteboard/paste-line-endings-007-expected.png:
        * editing/pasteboard/paste-line-endings-008-expected.checksum:
        * editing/pasteboard/paste-line-endings-008-expected.png:
        * editing/pasteboard/paste-line-endings-009-expected.checksum:
        * editing/pasteboard/paste-line-endings-009-expected.png:
        * editing/pasteboard/paste-line-endings-010-expected.checksum:
        * editing/pasteboard/paste-line-endings-010-expected.png:
        * editing/pasteboard/paste-list-001-expected.checksum:
        * editing/pasteboard/paste-list-001-expected.png:
        * editing/pasteboard/paste-match-style-001-expected.checksum:
        * editing/pasteboard/paste-match-style-001-expected.png:
        * editing/pasteboard/paste-match-style-002-expected.checksum:
        * editing/pasteboard/paste-match-style-002-expected.png:
        * editing/pasteboard/paste-pre-001-expected.checksum:
        * editing/pasteboard/paste-pre-001-expected.png:
        * editing/pasteboard/paste-pre-002-expected.checksum:
        * editing/pasteboard/paste-pre-002-expected.png:
        * editing/pasteboard/paste-table-001-expected.checksum:
        * editing/pasteboard/paste-table-001-expected.png:
        * editing/pasteboard/paste-text-001-expected.checksum:
        * editing/pasteboard/paste-text-001-expected.png:
        * editing/pasteboard/paste-text-017-expected.checksum:
        * editing/pasteboard/paste-text-017-expected.png:
        * editing/pasteboard/paste-text-018-expected.checksum:
        * editing/pasteboard/paste-text-018-expected.png:
        * editing/pasteboard/paste-text-019-expected.checksum:
        * editing/pasteboard/paste-text-019-expected.png:
        * editing/pasteboard/paste-text-at-tabspan-001-expected.checksum:
        * editing/pasteboard/paste-text-at-tabspan-001-expected.png:
        * editing/pasteboard/paste-text-at-tabspan-002-expected.checksum:
        * editing/pasteboard/paste-text-at-tabspan-002-expected.png:
        * editing/pasteboard/paste-text-at-tabspan-003-expected.checksum:
        * editing/pasteboard/paste-text-at-tabspan-003-expected.png:
        * editing/pasteboard/smart-paste-001-expected.checksum:
        * editing/pasteboard/smart-paste-001-expected.png:
        * editing/pasteboard/smart-paste-002-expected.checksum:
        * editing/pasteboard/smart-paste-002-expected.png:
        * editing/pasteboard/smart-paste-003-expected.checksum:
        * editing/pasteboard/smart-paste-003-expected.png:
        * editing/pasteboard/smart-paste-004-expected.checksum:
        * editing/pasteboard/smart-paste-004-expected.png:
        * editing/pasteboard/smart-paste-005-expected.checksum:
        * editing/pasteboard/smart-paste-005-expected.png:
        * editing/pasteboard/smart-paste-006-expected.checksum:
        * editing/pasteboard/smart-paste-006-expected.png:
        * editing/pasteboard/smart-paste-007-expected.checksum:
        * editing/pasteboard/smart-paste-007-expected.png:
        * editing/selection/3690703-expected.checksum:
        * editing/selection/3690703-expected.png:
        * editing/selection/3690719-expected.checksum:
        * editing/selection/3690719-expected.png:
        * editing/selection/6476-expected.checksum:
        * editing/selection/6476-expected.png:
        * editing/selection/after-line-wrap-expected.checksum:
        * editing/selection/after-line-wrap-expected.png:
        * editing/selection/end-of-document-expected.checksum:
        * editing/selection/end-of-document-expected.png:
        * editing/selection/expanding-selections-expected.checksum:
        * editing/selection/expanding-selections-expected.png:
        * editing/selection/expanding-selections2-expected.checksum:
        * editing/selection/expanding-selections2-expected.png:
        * editing/selection/extend-by-character-001-expected.checksum:
        * editing/selection/extend-by-character-001-expected.png:
        * editing/selection/extend-by-character-002-expected.checksum:
        * editing/selection/extend-by-character-002-expected.png:
        * editing/selection/extend-by-character-003-expected.checksum:
        * editing/selection/extend-by-character-003-expected.png:
        * editing/selection/extend-by-character-004-expected.checksum:
        * editing/selection/extend-by-character-004-expected.png:
        * editing/selection/extend-by-character-005-expected.checksum:
        * editing/selection/extend-by-character-005-expected.png:
        * editing/selection/extend-by-character-006-expected.checksum:
        * editing/selection/extend-by-character-006-expected.png:
        * editing/selection/extend-by-word-001-expected.checksum:
        * editing/selection/extend-by-word-001-expected.png:
        * editing/selection/extend-by-word-002-expected.checksum:
        * editing/selection/extend-by-word-002-expected.png:
        * editing/selection/fake-doubleclick-expected.checksum:
        * editing/selection/fake-doubleclick-expected.png:
        * editing/selection/fake-drag-expected.checksum:
        * editing/selection/fake-drag-expected.png:
        * editing/selection/iframe-expected.checksum:
        * editing/selection/iframe-expected.png:
        * editing/selection/image-before-linebreak-expected.checksum:
        * editing/selection/image-before-linebreak-expected.png:
        * editing/selection/inline-table-expected.checksum:
        * editing/selection/inline-table-expected.png:
        * editing/selection/leave-requested-block-expected.checksum:
        * editing/selection/leave-requested-block-expected.png:
        * editing/selection/move-backwords-by-word-001-expected.checksum:
        * editing/selection/move-backwords-by-word-001-expected.png:
        * editing/selection/move-between-blocks-no-001-expected.checksum:
        * editing/selection/move-between-blocks-no-001-expected.png:
        * editing/selection/move-by-character-001-expected.checksum:
        * editing/selection/move-by-character-001-expected.png:
        * editing/selection/move-by-character-002-expected.checksum:
        * editing/selection/move-by-character-002-expected.png:
        * editing/selection/move-by-character-003-expected.checksum:
        * editing/selection/move-by-character-003-expected.png:
        * editing/selection/move-by-character-004-expected.checksum:
        * editing/selection/move-by-character-004-expected.png:
        * editing/selection/move-by-character-005-expected.checksum:
        * editing/selection/move-by-character-005-expected.png:
        * editing/selection/move-by-character-6-expected.checksum:
        * editing/selection/move-by-character-6-expected.png:
        * editing/selection/move-by-line-001-expected.checksum:
        * editing/selection/move-by-line-001-expected.png:
        * editing/selection/move-by-line-002-expected.checksum:
        * editing/selection/move-by-line-002-expected.png:
        * editing/selection/move-by-word-001-expected.checksum:
        * editing/selection/move-by-word-001-expected.png:
        * editing/selection/previous-line-position-expected.checksum:
        * editing/selection/previous-line-position-expected.png:
        * editing/selection/replaced-boundaries-1-expected.checksum:
        * editing/selection/replaced-boundaries-1-expected.png:
        * editing/selection/replaced-boundaries-2-expected.checksum:
        * editing/selection/replaced-boundaries-2-expected.png:
        * editing/selection/replaced-boundaries-3-expected.checksum:
        * editing/selection/replaced-boundaries-3-expected.png:
        * editing/selection/select-all-001-expected.checksum:
        * editing/selection/select-all-001-expected.png:
        * editing/selection/select-all-002-expected.checksum:
        * editing/selection/select-all-002-expected.png:
        * editing/selection/select-box-expected.checksum:
        * editing/selection/select-box-expected.png:
        * editing/selection/selection-3748164-fix-expected.checksum:
        * editing/selection/selection-3748164-fix-expected.png:
        * editing/selection/triple-click-in-pre-expected.checksum:
        * editing/selection/triple-click-in-pre-expected.png:
        * editing/selection/unrendered-001-expected.checksum:
        * editing/selection/unrendered-001-expected.png:
        * editing/selection/unrendered-002-expected.checksum:
        * editing/selection/unrendered-002-expected.png:
        * editing/selection/unrendered-003-expected.checksum:
        * editing/selection/unrendered-003-expected.png:
        * editing/selection/unrendered-004-expected.checksum:
        * editing/selection/unrendered-004-expected.png:
        * editing/selection/unrendered-005-expected.checksum:
        * editing/selection/unrendered-005-expected.png:
        * editing/style/block-style-004-expected.checksum:
        * editing/style/block-style-004-expected.png:
        * editing/style/block-style-005-expected.checksum:
        * editing/style/block-style-005-expected.png:
        * editing/style/block-style-006-expected.checksum:
        * editing/style/block-style-006-expected.png:
        * editing/style/block-styles-007-expected.checksum:
        * editing/style/block-styles-007-expected.png:
        * editing/style/remove-underline-across-paragraph-expected.checksum:
        * editing/style/remove-underline-across-paragraph-expected.png:
        * editing/style/remove-underline-across-paragraph-in-bold-expected.checksum:
        * editing/style/remove-underline-across-paragraph-in-bold-expected.png:
        * editing/style/remove-underline-after-paragraph-expected.checksum:
        * editing/style/remove-underline-after-paragraph-expected.png:
        * editing/style/remove-underline-after-paragraph-in-bold-expected.checksum:
        * editing/style/remove-underline-after-paragraph-in-bold-expected.png:
        * editing/style/remove-underline-expected.checksum:
        * editing/style/remove-underline-expected.png:
        * editing/style/remove-underline-from-stylesheet-expected.checksum:
        * editing/style/remove-underline-from-stylesheet-expected.png:
        * editing/style/remove-underline-in-bold-expected.checksum:
        * editing/style/remove-underline-in-bold-expected.png:
        * editing/style/smoosh-styles-001-expected.checksum:
        * editing/style/smoosh-styles-001-expected.png:
        * editing/style/smoosh-styles-002-expected.checksum:
        * editing/style/smoosh-styles-002-expected.png:
        * editing/style/smoosh-styles-003-expected.checksum:
        * editing/style/smoosh-styles-003-expected.png:
        * editing/style/style-3681552-fix-001-expected.checksum:
        * editing/style/style-3681552-fix-001-expected.png:
        * editing/style/style-3681552-fix-002-expected.checksum:
        * editing/style/style-3681552-fix-002-expected.png:
        * editing/style/style-3690704-fix-expected.checksum:
        * editing/style/style-3690704-fix-expected.png:
        * editing/style/style-3998892-fix-expected.checksum:
        * editing/style/style-3998892-fix-expected.png:
        * editing/style/style-boundary-001-expected.checksum:
        * editing/style/style-boundary-001-expected.png:
        * editing/style/style-boundary-002-expected.checksum:
        * editing/style/style-boundary-002-expected.png:
        * editing/style/style-boundary-003-expected.checksum:
        * editing/style/style-boundary-003-expected.png:
        * editing/style/style-boundary-004-expected.checksum:
        * editing/style/style-boundary-004-expected.png:
        * editing/style/typing-style-001-expected.checksum:
        * editing/style/typing-style-001-expected.png:
        * editing/style/typing-style-002-expected.checksum:
        * editing/style/typing-style-002-expected.png:
        * editing/style/typing-style-003-expected.checksum:
        * editing/style/typing-style-003-expected.png:
        * editing/style/unbold-in-bold-expected.checksum:
        * editing/style/unbold-in-bold-expected.png:
        * editing/style/underline-expected.checksum:
        * editing/style/underline-expected.png:
        * editing/undo/4063751-expected.checksum:
        * editing/undo/4063751-expected.png:
        * editing/undo/redo-typing-001-expected.checksum:
        * editing/undo/redo-typing-001-expected.png:
        * editing/undo/undo-typing-001-expected.checksum:
        * editing/undo/undo-typing-001-expected.png:
        * editing/unsupported-content/list-delete-001-expected.checksum:
        * editing/unsupported-content/list-delete-001-expected.png:
        * editing/unsupported-content/list-delete-002-expected.checksum:
        * editing/unsupported-content/list-delete-002-expected.png:
        * editing/unsupported-content/list-delete-003-expected.checksum:
        * editing/unsupported-content/list-delete-003-expected.png:
        * editing/unsupported-content/list-type-after-expected.checksum:
        * editing/unsupported-content/list-type-after-expected.png:
        * editing/unsupported-content/list-type-before-expected.checksum:
        * editing/unsupported-content/list-type-before-expected.png:
        * editing/unsupported-content/table-delete-001-expected.checksum:
        * editing/unsupported-content/table-delete-001-expected.png:
        * editing/unsupported-content/table-delete-002-expected.checksum:
        * editing/unsupported-content/table-delete-002-expected.png:
        * editing/unsupported-content/table-delete-003-expected.checksum:
        * editing/unsupported-content/table-delete-003-expected.png:
        * editing/unsupported-content/table-type-after-expected.checksum:
        * editing/unsupported-content/table-type-after-expected.png:
        * editing/unsupported-content/table-type-before-expected.checksum:
        * editing/unsupported-content/table-type-before-expected.png:
        * fast/css/outline-auto-empty-rects-expected.checksum:
        * fast/css/outline-auto-empty-rects-expected.png:
        * fast/css/outline-auto-location-expected.checksum:
        * fast/css/outline-auto-location-expected.png:
        * fast/dom/focus-contenteditable-expected.checksum:
        * fast/dom/focus-contenteditable-expected.png:
        * fast/encoding/utf-16-big-endian-expected.checksum:
        * fast/encoding/utf-16-big-endian-expected.png:
        * fast/encoding/utf-16-little-endian-expected.checksum:
        * fast/encoding/utf-16-little-endian-expected.png:
        * fast/events/focusingUnloadedFrame-expected.checksum:
        * fast/events/focusingUnloadedFrame-expected.png:
        * fast/forms/input-appearance-focus-expected.checksum:
        * fast/forms/input-appearance-focus-expected.png:
        * fast/forms/input-appearance-readonly-expected.checksum: Added.
        * fast/forms/input-appearance-readonly-expected.png: Added.
        * fast/forms/input-appearance-selection-expected.checksum:
        * fast/forms/input-appearance-selection-expected.png:
        * fast/forms/input-paste-undo-expected.checksum: Added.
        * fast/forms/input-paste-undo-expected.png: Added.
        * fast/forms/input-text-double-click-expected.checksum:
        * fast/forms/input-text-double-click-expected.png:
        * fast/forms/input-text-option-delete-expected.checksum:
        * fast/forms/input-text-option-delete-expected.png:
        * fast/forms/input-text-scroll-left-on-blur-expected.checksum:
        * fast/forms/input-text-scroll-left-on-blur-expected.png:
        * fast/lists/drag-into-marker-expected.checksum:
        * fast/lists/drag-into-marker-expected.png:
        * fast/overflow/childFocusRingClip-expected.checksum:
        * fast/overflow/childFocusRingClip-expected.png:
        * fast/overflow/overflow-focus-ring-expected.checksum:
        * fast/overflow/overflow-focus-ring-expected.png:
        * fast/text/justified-text-rect-expected.checksum:
        * fast/text/justified-text-rect-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated layout test results, mostly for the change in focus ring appearance
darin [Mon, 3 Apr 2006 01:16:44 +0000 (01:16 +0000)]
    - updated layout test results, mostly for the change in focus ring appearance

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated layout test results, mostly for the change in focus ring appearance
darin [Mon, 3 Apr 2006 01:15:48 +0000 (01:15 +0000)]
    - updated layout test results, mostly for the change in focus ring appearance

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated layout test results, mostly for the change in focus ring appearance
darin [Mon, 3 Apr 2006 01:14:58 +0000 (01:14 +0000)]
    - updated layout test results, mostly for the change in focus ring appearance

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated layout test results, mostly for the change in focus ring appearance
darin [Mon, 3 Apr 2006 01:12:38 +0000 (01:12 +0000)]
    - updated layout test results, mostly for the change in focus ring appearance

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
darin [Mon, 3 Apr 2006 01:11:28 +0000 (01:11 +0000)]
    Reviewed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8123
          focus ring on new text field doesn't look like the old one

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7685
          Focus ring color should change to match graphite when system theme is graphite

        - some cleanup to how we parse user agent style sheets

        * css/CSSValueKeywords.in: Added -webkit-focus-ring-color.

        * css/cssstyleselector.cpp:
        (WebCore::parseUASheet): Parse an array of chars instead of UTF-16.
        Cuts the size of the style sheet in half.
        (WebCore::CSSStyleSelector::applyProperty): Allow negative value for
        outline-offset. Changed shadow parsing to use getColorFromPrimitiveValue
        instead of repeating the same logic.
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Added a case
        for the focus ring color.
        * rendering/render_style.h: (WebCore::RenderStyle::setOutlineOffset):
        Changed to allow negative values.

        * css/html4.css: Removed a lot of excess spaces. Changed color of focus
        to -webkit-focus-ring-color. Changed width of focus to 5px.
        Added an outline-offset for <input type=text> of -2px.

        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue): Added focus ring color as an outline color all
        the time, and as any other color when not in strict mode. I'm confused about what's
        best for this whole strict mode policy, and I may need advice on Hyatt to perfect
        this one later.
        (WebCore::CSSParser::parseColorFromValue): Removed code to pin r, g, and b because
        the functions in platform already take care of that. Kept the pinning of a, though
        because that's done in floating point before converting to an integer.
        (WebCore::CSSParser::parseShadow): Allow focus ring color when not in strict mode.

        * bridge/mac/FrameMac.h: Eliminated the virtual detachFromView function.
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::FrameMac): Eliminated code to maintain the frame instances list.
        (WebCore::FrameMac::~FrameMac): Ditto.
        (WebCore::Frame::setNeedsReapplyStyles): Added.

        * bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]):
        * platform/mac/WebCoreTextRendererFactory.mm:
        (-[WebCoreTextRendererFactory clearCaches]):
        Changed to call the new Page::setNeedsReapplyStylesForSettingsChange instead of using the
        obsolete Frame::instances.

        * page/Frame.h: Removed instances, mutableInstances, and detachFromView.
        * page/Frame.cpp: Ditto.

        * page/FrameTree.cpp:
        (WebCore::FrameTree::~FrameTree): Call setView(0) instead of detachFromView().
        (WebCore::FrameTree::removeChild): Ditto.

        * page/Page.h:
        * page/Page.cpp:
        (WebCore::Page::init): Added a set of pages instead of a page count. Also
        register a function for when the focus ring color changes the first time this
        is called.
        (WebCore::Page::~Page): Call setView(0) instead of detachFromView. Also update
        to manager the set of pages.
        (WebCore::Page::setNeedsReapplyStyles): Call setNeedsReapplyStyles on all frames.
        (WebCore::Page::setNeedsReapplyStylesForSettingsChange): Call setNeedsReapplyStyles
        on all frames with the passed-in settings.

        * css/make-css-file-arrays.pl: Changed to run the C preprocessor on the
        input files and to generate an array of char instead of unsigned short.

        * platform/PlatformString.h: Added a constructor that takes a char* and
        a length.
        * platform/String.cpp: (WebCore::String::String): Ditto.

        * WebCore.xcodeproj/project.pbxproj: Just some tweaks; adding in a few files like
        the user agent style sheets.

        * platform/Color.h: Removed all use of DeprecatedString. Cleaned up a bit.
        Added focusRingColor and setFocusRingColorChangeFunction.
        * platform/Color.cpp:
        (WebCore::makeRGB): Rewrote using max and min.
        (WebCore::makeRGBA): Ditto.
        (WebCore::parseHexColor): Cleaned up a bit; changed partway to String instead of
        DeprecatedString.
        (WebCore::Color::Color): Changed to use String and to call setNamedColor to save code.
        (WebCore::Color::setNamedColor): Changed to use String in the interface.

        * platform/mac/ColorMac.mm:
        (WebCore::observeTheme): Added. Function used to start up the observer.
        (WebCore::setFocusRingColorChangeFunction): Added. Used to get a call back so we can
        update all the views when the color changes (including recomputing style to get the
        color change in).
        (WebCore::setFocusRingColorChangeFunction): Added. Returns one of the two focus
        ring colors. Both of these match what AppKit uses -- neither matches what we used
        to have in the html4.css file.
        (+[WebCoreControlTintObserver controlTintDidChange]): Added. Used to update when
        the appearance is changed from blue to graphite and back. We keep a global so we
        don't have to call over to AppKit every time; that's probably overkill but we need
        the obsever for the color change function anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Sun, 2 Apr 2006 19:54:25 +0000 (19:54 +0000)]
LayoutTests:

        Reviewed by Darin.

        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8118
          REGRESSION (r13595): Inline block's clipped overflow increases table row height

        * fast/inline-block/overflow-clip-expected.checksum: Added.
        * fast/inline-block/overflow-clip-expected.png: Added.
        * fast/inline-block/overflow-clip-expected.txt: Added.
        * fast/inline-block/overflow-clip.html: Added.

WebCore:

        Test: fast/inline-block/overflow-clip.html

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8118
          REGRESSION (r13595): Inline block's clipped overflow increases table row height

        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::placeBoxesVertically): Don't look at interior overflow
        when calculating the contribution to the inline's vertical overflows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-04-02 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 2 Apr 2006 12:13:27 +0000 (12:13 +0000)]
2006-04-02  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Make WebCore safe against KJS::Node in JavaScriptCore private headers.

        * editing/ReplaceSelectionCommand.h:
        * khtml/ecma/JSXMLSerializer.cpp:
        (KJS::XMLSerializerProtoFunc::callAsFunction):
        * khtml/ecma/JSXSLTProcessor.cpp:
        (KJS::XSLTProcessorProtoFunc::callAsFunction):
        * khtml/ecma/kjs_binding.cpp:
        (KJS::ScriptInterpreter::forgetDOMNodeForDocument):
        (KJS::ScriptInterpreter::putDOMNodeForDocument):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNode::DOMNode):
        (KJS::DOMNode::mark):
        (KJS::DOMNode::getValueProperty):
        (KJS::DOMNode::putValueProperty):
        (KJS::DOMNodeProtoFunc::callAsFunction):
        (KJS::toNode):
        (KJS::DOMEventTargetNode::DOMEventTargetNode):
        (KJS::DOMDocumentProtoFunc::callAsFunction):
        (KJS::DOMElement::putValueProperty):
        (KJS::DOMElementProtoFunc::callAsFunction):
        (KJS::checkNodeSecurity):
        (KJS::toJS):
        (KJS::getRuntimeObject):
        (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
        (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
        * khtml/ecma/kjs_events.cpp:
        (KJS::JSLazyEventListener::JSLazyEventListener):
        (KJS::ClipboardProtoFunc::callAsFunction):
        * khtml/ecma/kjs_html.cpp:
        (KJS::JSHTMLDocument::namedItemGetter):
        (KJS::JSHTMLElement::framesetNameGetter):
        (KJS::JSHTMLElement::getOwnPropertySlot):
        (KJS::JSHTMLElement::pushEventHandlerScope):
        (KJS::JSHTMLCollection::callAsFunction):
        (KJS::JSHTMLCollection::getNamedItems):
        (KJS::JSHTMLSelectCollection::put):
        * khtml/ecma/kjs_traversal.cpp:
        (KJS::JSNodeFilterCondition::acceptNode):
        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::put):
        * kwq/KWQPageState.mm:
        (-[KWQPageState WebCore::]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-04-02 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 2 Apr 2006 11:41:38 +0000 (11:41 +0000)]
2006-04-02  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Add missing forwarding header.

        * kxmlcore/Vector.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ggaren [Sun, 2 Apr 2006 08:55:58 +0000 (08:55 +0000)]
    Reviewed by Darin.

        - Fixed <rdar://problem/4430836> JavaScript patch crashing Quartz
        Composer

        JSValueWrappers used to hold on to the ExecState that pertained at
        the time of their creation. Since ExecStates are transient, that
        design was totally bogus, and it would crash once the ExecState had
        been deallocated.

        Unfortunately, there's no clean solution to this problem, since
        the JSGlue API has no notion of state. The solution here is to use
        a shared, global ExecState for the purpose of JSGlue calls. Given
        the pre-existing limitations in the JSGlue API, this design
        shouldn't actually introduce any new limitations (see comments in
        JSValueWrapper.cpp).

        I tested with Quartz Composer and PAC files, neither of which are
        layout-testable.

        * JSUtils.cpp:
        (KJSValueToJSObject):
        * JSValueWrapper.cpp:
        (JSValueWrapper::JSValueWrapper):
        (JSValueWrapper::GetValue):
        (getProcessGlobalExecState):
        (JSValueWrapper::JSObjectCopyPropertyNames):
        (JSValueWrapper::JSObjectCopyProperty):
        (JSValueWrapper::JSObjectSetProperty):
        (JSValueWrapper::JSObjectCallFunction):
        (JSValueWrapper::JSObjectCopyCFValue):
        * JSValueWrapper.h:

        Also added a test harness file. It was helpful while I was testing,
        and may come in handy in the future:

        * JavaScriptGlue.xcodeproj/project.pbxproj:
        testjsglue.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
darin [Sun, 2 Apr 2006 02:41:24 +0000 (02:41 +0000)]
    Reviewed by Eric.

        - removed a bunch of unneeded ForwardingHeaders and WebCore+SVG headers

        * ForwardingHeaders/kcanvas: Removed.
        * ForwardingHeaders/kcanvas/KCanvas.h: Removed.
        * ForwardingHeaders/kdom: Removed.
        * ForwardingHeaders/kdom/DOMString.h: Removed.
        * ForwardingHeaders/kdom/Helper.h: Removed.
        * ForwardingHeaders/kdom/KDOMSettings.h: Removed.
        * ForwardingHeaders/kdom/Namespace.h: Removed.
        * ForwardingHeaders/kdom/cache: Removed.
        * ForwardingHeaders/kdom/cache/KDOMCachedImage.h: Removed.
        * ForwardingHeaders/kdom/cache/KDOMCachedObject.h: Removed.
        * ForwardingHeaders/kdom/cache/KDOMCachedObjectClient.h: Removed.
        * ForwardingHeaders/kdom/cache/KDOMCachedScript.h: Removed.
        * ForwardingHeaders/kdom/cache/KDOMLoader.h: Removed.
        * ForwardingHeaders/kdom/core: Removed.
        * ForwardingHeaders/kdom/core/DOMConfiguration.h: Removed.
        * ForwardingHeaders/kdom/core/DOMException.h: Removed.
        * ForwardingHeaders/kdom/core/DOMList.h: Removed.
        * ForwardingHeaders/kdom/core/DOMString.h: Removed.
        * ForwardingHeaders/kdom/core/NamedAttrMap.h: Removed.
        * ForwardingHeaders/kdom/core/ProcessingInstruction.h: Removed.
        * ForwardingHeaders/kdom/core/domattrs.h: Removed.
        * ForwardingHeaders/kdom/ecma: Removed.
        * ForwardingHeaders/kdom/ecma/GlobalObject.h: Removed.
        * ForwardingHeaders/kdom/events: Removed.
        * ForwardingHeaders/kdom/events/Event.h: Removed.
        * ForwardingHeaders/kdom/events/EventListener.h: Removed.
        * ForwardingHeaders/kdom/events/EventTarget.h: Removed.
        * ForwardingHeaders/kdom/events/KeyboardEvent.h: Removed.
        * ForwardingHeaders/kdom/events/MouseEvent.h: Removed.
        * ForwardingHeaders/kdom/events/UIEvent.h: Removed.
        * ForwardingHeaders/kdom/events/kdomevents.h: Removed.
        * ForwardingHeaders/kdom/kdom.h: Removed.
        * ForwardingHeaders/kdom/parser: Removed.
        * ForwardingHeaders/kdom/parser/KDOMParser.h: Removed.
        * ForwardingHeaders/ksvg2: Removed.
        * ForwardingHeaders/ksvg2/KSVGPart.h: Removed.
        * ForwardingHeaders/ksvg2/KSVGView.h: Removed.
        * ForwardingHeaders/ksvg2/css: Removed.
        * ForwardingHeaders/ksvg2/css/CSSPropertyNames.h: Removed.
        * ForwardingHeaders/ksvg2/css/CSSValueKeywords.h: Removed.
        * WebCore+SVG/KDOMHeaders.h: Removed.
        * WebCore+SVG/Namespace.h: Removed.
        * WebCore+SVG/kdom.h: Removed.

        * WebCore.xcodeproj/project.pbxproj: Removed headers.

        * kcanvas/KCanvasCreator.cpp:
        * kcanvas/KCanvasResources.cpp:
        * kcanvas/KCanvasTreeDebug.cpp:
        * kcanvas/RenderPath.cpp:
        * kcanvas/RenderSVGImage.cpp:
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        * ksvg2/events/SVGZoomEvent.h:
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        * ksvg2/misc/KSVGTimeScheduler.cpp:
        * ksvg2/misc/SVGImageLoader.cpp:
        * ksvg2/svg/SVGAElement.cpp:
        * ksvg2/svg/SVGAnimationElement.cpp:
        * ksvg2/svg/SVGCircleElement.cpp:
        * ksvg2/svg/SVGClipPathElement.cpp:
        * ksvg2/svg/SVGCursorElement.cpp:
        * ksvg2/svg/SVGCursorElement.h:
        * ksvg2/svg/SVGDOMImplementation.cpp:
        * ksvg2/svg/SVGDocument.cpp:
        * ksvg2/svg/SVGDocument.h:
        * ksvg2/svg/SVGElement.cpp:
        * ksvg2/svg/SVGEllipseElement.cpp:
        * ksvg2/svg/SVGExternalResourcesRequired.cpp:
        * ksvg2/svg/SVGExternalResourcesRequired.h:
        * ksvg2/svg/SVGFEBlendElement.cpp:
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        * ksvg2/svg/SVGFEComponentTransferElement.cpp:
        * ksvg2/svg/SVGFECompositeElement.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        * ksvg2/svg/SVGFEFloodElement.cpp:
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        * ksvg2/svg/SVGFEImageElement.cpp:
        * ksvg2/svg/SVGFEImageElement.h:
        * ksvg2/svg/SVGFELightElement.cpp:
        * ksvg2/svg/SVGFEMergeElement.cpp:
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        * ksvg2/svg/SVGFETileElement.cpp:
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        * ksvg2/svg/SVGFilterElement.cpp:
        * ksvg2/svg/SVGGradientElement.cpp:
        * ksvg2/svg/SVGHelper.cpp:
        * ksvg2/svg/SVGImageElement.cpp:
        * ksvg2/svg/SVGLangSpace.cpp:
        * ksvg2/svg/SVGLength.cpp:
        * ksvg2/svg/SVGLineElement.cpp:
        * ksvg2/svg/SVGLinearGradientElement.cpp:
        * ksvg2/svg/SVGList.h:
        * ksvg2/svg/SVGLocatable.cpp:
        * ksvg2/svg/SVGMarkerElement.cpp:
        * ksvg2/svg/SVGMarkerElement.h:
        * ksvg2/svg/SVGMaskElement.cpp:
        * ksvg2/svg/SVGPathElement.cpp:
        * ksvg2/svg/SVGPatternElement.cpp:
        * ksvg2/svg/SVGPolyElement.cpp:
        * ksvg2/svg/SVGPolygonElement.cpp:
        * ksvg2/svg/SVGPolylineElement.cpp:
        * ksvg2/svg/SVGRadialGradientElement.cpp:
        * ksvg2/svg/SVGRectElement.cpp:
        * ksvg2/svg/SVGSVGElement.cpp:
        * ksvg2/svg/SVGStopElement.cpp:
        * ksvg2/svg/SVGStyleElement.cpp:
        * ksvg2/svg/SVGStyledElement.cpp:
        * ksvg2/svg/SVGStyledLocatableElement.cpp:
        * ksvg2/svg/SVGStyledTransformableElement.cpp:
        * ksvg2/svg/SVGTextElement.cpp:
        * ksvg2/svg/SVGTransformable.cpp:
        * ksvg2/svg/SVGUseElement.cpp:
        * ksvg2/svg/SVGViewElement.cpp:
        Updated includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-04-01 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 2 Apr 2006 01:57:51 +0000 (01:57 +0000)]
2006-04-01  Eric Seidel  <eseidel@apple.com>

        * libWebKitSystemInterface.a: commit a universal binary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoOops. File was in change log, but not in commit.
darin [Sun, 2 Apr 2006 00:14:54 +0000 (00:14 +0000)]
Oops. File was in change log, but not in commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Sun, 2 Apr 2006 00:04:31 +0000 (00:04 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8089
          REGRESSION: Caret position is off in native text field with text-align:right

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8082
          REGRESSION: Empty RTL text fields place the caret on the left side

        Need a way to make a test for this. No obvious way at the moment.

        * rendering/RenderFlow.cpp: (WebCore::RenderFlow::caretRect):
        Consider border, padding, and the width of the caret properly in the
        calculation of the caret's X position.

        * rendering/RenderBox.cpp: (WebCore::RenderBox::caretRect):
        Fixed some similar issues and rewrote this function for clarity.
        However, I suspect this function was and remains broken and is almost
        never called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Sat, 1 Apr 2006 23:35:17 +0000 (23:35 +0000)]
LayoutTests:

        Reviewed by Justin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8106
          REGRESSION (NativeTextField): New text fields don't scroll to the beginning when losing focus

        * fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
        * fast/forms/input-text-scroll-left-on-blur-expected.txt: Added.
        * fast/forms/input-text-scroll-left-on-blur-expected.checksum: Added.
        * fast/forms/input-text-scroll-left-on-blur.html: Added.

WebCore:

        Reviewed by Justin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8106
          REGRESSION (NativeTextField): New text fields don't scroll to the beginning when losing focus

        Test: fast/forms/input-text-scroll-left-on-blur.html

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Pass blur events
        through to the RenderTextField, as well as mouse, drag, and wheel events.
        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): Scroll all the way to
        the left on a blur.

        - unrelated small changes

        * html/HTMLTextFieldInnerElement.cpp: Removed excess includes.
        (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): Tweaked comments a bit.

        * dom/Element.cpp:
        (WebCore::Element::scrollIntoView): Removed unneeded this-> before function call.
        (WebCore::Element::scrollIntoViewIfNeeded): Ditto.

        * page/FrameView.cpp: (WebCore::FrameView::dispatchMouseEvent): Removed obsolete comment.

WebKitTools:

        Reviewed by Justin.

        * DumpRenderTree/EventSendingController.m: (-[EventSendingController keyDown:withModifiers:]):
        Fixed keyDown function so that it will work if you don't pass an array of modifiers or if
        elements in that array are not strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth.
darin [Sat, 1 Apr 2006 22:27:15 +0000 (22:27 +0000)]
    Reviewed by Beth.

        * libWebKitSystemInterface.a: Changed alpha in the focus-ring drawing
        code to use the system default alpha.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoOoops, actually land the fix with this ChangeLog entry:
mjs [Sat, 1 Apr 2006 20:59:45 +0000 (20:59 +0000)]
Ooops, actually land the fix with this ChangeLog entry:

2006-03-31  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adele.

        <rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): merge into start block when pasting into
        an empty editable subtree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - re-updated many pixel results to try to create a new baseline
darin [Sat, 1 Apr 2006 19:39:38 +0000 (19:39 +0000)]
    - re-updated many pixel results to try to create a new baseline

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Sat, 1 Apr 2006 10:14:17 +0000 (10:14 +0000)]
LayoutTests:

        Test cases for:

        <rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

        * fast/forms/input-paste-undo-expected.txt: Added.
        * fast/forms/input-paste-undo.html: Added.

WebCore:

        Reviewed by Adele.

        <rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): merge into start block when pasting into
        an empty editable subtree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Sat, 1 Apr 2006 09:40:43 +0000 (09:40 +0000)]
LayoutTests:

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8063
          REGRESSION: double clicking in new text fields won't select whole words

        * fast/forms/input-text-double-click-expected.checksum: Added.
        * fast/forms/input-text-double-click-expected.png: Added.
        * fast/forms/input-text-double-click-expected.txt: Added.
        * fast/forms/input-text-double-click.html: Added.

WebCore:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8063
          REGRESSION: double clicking in new text fields won't select whole words

        Test: fast/forms/input-text-double-click.html

        * editing/visible_units.cpp: (WebCore::nextBoundary): Set the end of the range by
        calling selectNodeContents rather than by calling setEndAfter. The problem with
        setEndAfter is that it doesn't do anything when the parent of the node is 0, and
        also it's not really what we want, since the boundary node is one with editable
        contents -- we want to stay inside the boundary node.

        * editing/Selection.cpp: (WebCore::Selection::validate): Fix a tiny formatting glitch
        I noticed at the same time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Sat, 1 Apr 2006 09:32:44 +0000 (09:32 +0000)]
LayoutTests:

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8105
          REGRESSION (NativeTextField): Option-delete deletes one space before the deleted word

        * fast/forms/input-text-option-delete-expected.checksum: Added.
        * fast/forms/input-text-option-delete-expected.png: Added.
        * fast/forms/input-text-option-delete-expected.txt: Added.
        * fast/forms/input-text-option-delete.html: Added.

WebKit:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8105
          REGRESSION (NativeTextField): Option-delete deletes one space before the deleted word

        Test: fast/forms/input-text-option-delete.html

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Pass NO for
        smartDeleteOK. Smart deletion only applies to deleting a word at a time, and none of
        the callers of this function that delete a word at a time want smart deletion.
        (-[WebHTMLView deleteToEndOfLine:]): Fixed tiny formatting glitch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoKnocking the number of PLTs we run down to 3 to see if we come in under the BuildBot...
thatcher [Sat, 1 Apr 2006 00:40:32 +0000 (00:40 +0000)]
Knocking the number of PLTs we run down to 3 to see if we come in under the BuildBot timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoKnocking the number of PLTs we run down to 4 to see if we come in under the BuildBot...
thatcher [Sat, 1 Apr 2006 00:12:24 +0000 (00:12 +0000)]
Knocking the number of PLTs we run down to 4 to see if we come in under the BuildBot timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Hatcher.
sullivan [Fri, 31 Mar 2006 23:14:47 +0000 (23:14 +0000)]
    Reviewed by Tim Hatcher.

        - fixed <rdar://problem/4372842> 10.4.4 Regression: control-clicking on a misspelled word
        doesn't select it or offer corrections (first click only)

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::sendContextMenuEvent):
        Rolled in this one-line change that Hyatt wrote ages ago.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
thatcher [Fri, 31 Mar 2006 22:39:42 +0000 (22:39 +0000)]
    Reviewed by Darin.

        We need to set reachedTerminalState to YES before we release
        the resources to prevent a double dealloc of WebView

        Fixes <rdar://problem/4372628> crash deallocating a WebView in -[WebFrame stopLoading]

        * WebView/WebLoader.m:
        (-[NSURLProtocol releaseResources]): set reachedTerminalState earlier

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John.
bdakin [Fri, 31 Mar 2006 21:50:38 +0000 (21:50 +0000)]
    Reviewed by John.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8108
        REGRESSION (r13590-r13593): Floating table's cells don't paint
        their background

        This is a regression from my painting patch yesterday. Just a silly
        error I didn't catch.

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint): Change the phase of our new
        PaintInfo, not our old one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Omernick.
sullivan [Fri, 31 Mar 2006 21:36:38 +0000 (21:36 +0000)]
    Reviewed by Tim Omernick.

        Some cleanup in the WebIconDatabase code in a fruitless search for the cause
        of the mysterious -[WebFileDatabase performSetObject:forKey] crash

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase _createFileDatabase]):
        removed obsolete comment
        (-[WebIconDatabase _loadIconDictionaries]):
        Added ERRORs for unexpected early returns. Made dictionaries be autoreleased until
        the end of the method where they are retained, so that the early returns don't leak;
        added ASSERTs that the _private->dictionary values aren't being leaked.
        (-[WebIconDatabase _updateFileDatabase]):
        Added an ERROR for an unexpected early return, and made a trivial style fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
tomernic [Fri, 31 Mar 2006 20:58:33 +0000 (20:58 +0000)]
LayoutTests:

        Reviewed by Adele.

        Layout test for:
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7858>
        <rdar://problem/4483359> REGRESSION: New text field doesn't recognize the read only attribute

        * fast/forms/input-appearance-readonly-expected.txt: Added.
        * fast/forms/input-appearance-readonly.html: Added.

WebCore:

        Reviewed by Adele.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7858>
        <rdar://problem/4483359> REGRESSION: New text field doesn't recognize the read only attribute

        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::createDivStyle):
        Set user modify based on the form element's readOnly().
        (WebCore::RenderTextField::updateFromElement):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Omernick.
adele [Fri, 31 Mar 2006 20:44:32 +0000 (20:44 +0000)]
    Reviewed by Tim Omernick.

        Updating shadowAncestorNode so it doesn't check for rootEditableElement.  Now we just walk
        up the tree to look for a shadowNode, and then we find the shadowParent.

        * dom/Node.cpp: (WebCore::Node::shadowAncestorNode):
        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange):
         Updated assertion to check for shadowAncestorNode instead of rootEditableElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix by Trey Matteson, reviewed by Maciej.
ap [Fri, 31 Mar 2006 20:30:07 +0000 (20:30 +0000)]
    Fix by Trey Matteson, reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7739
        REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]

        Tests: http/tests/misc/acid2.html, http/tests/misc/acid2-pixel.html

        The gist of this change is that we must cancel the load from the Webkit side when we
        realize we're switching to the fallback content.  This is somewhat a temp workaround
        since control of loading will be moving to WebCore.

        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
adele [Fri, 31 Mar 2006 20:12:32 +0000 (20:12 +0000)]
    Reviewed by John Sullivan.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8101
          REGSRESSION: Fix for bug 7031 causes 30 layout tests to fail

        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::placeBoxesVertically): Change top and bottom positions
        only if childAffectsTopBottomPos is true.
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::paintLines): Redo a part of the patch for bug 7031 that
        wasn't committed with the rest of the patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin, landed by Beth.
bdakin [Fri, 31 Mar 2006 19:16:36 +0000 (19:16 +0000)]
    Reviewed by Darin, landed by Beth.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8081
        REGRESSION: Drop-down menu has gap at top

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcAbsoluteVerticalValues): When calculating
        the hypothetical vertical position in normal flow, skip table rows
        in the ancestor chain, since a table cell's Y position is relative
        to the table section, not the row.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFIx theme borders on win32.
hyatt [Fri, 31 Mar 2006 19:03:19 +0000 (19:03 +0000)]
FIx theme borders on win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Fri, 31 Mar 2006 18:51:40 +0000 (18:51 +0000)]
LayoutTests:

        - updated results for tests that involve scrolling

        * editing/selection/focus_editable_html-expected.txt: Added expected scroll position.
        * fast/dom/focus-contenteditable-expected.txt: Ditto.
        * fast/overflow/scrollRevealButton.html: Ditto.

        - updated results for tests that involve new exception names

        * fast/dom/Element/attr-param-typechecking-expected.txt: Updated.

        * fast/dynamic/insertAdjacentElement-expected.txt: Updated.
        * fast/dynamic/insertAdjacentElement-expected.png: Added.
        * fast/dynamic/insertAdjacentElement-expected.checksum: Added.

WebCore:

        Reviewed by John Sullivan.

        * khtml/ecma/kjs_binding.cpp: Added names for VALIDATION_ERR and
        TYPE_MISMATCH_ERR; new DOM Level 3 errors that need to be listed in
        the mapping from error code to error name.

        * dom/Element.idl: Removed comment from bad old days where we had to
        touch these files to make them rebuild.

WebKitTools:

        Reviewed by John Sullivan.

        - added a "--reset-results" option to run-webkit-tests so you can reset
          the results without first deleting expected results
        - <rdar://problem/4185878> add scroll position to dumpRenderTree

        * Scripts/run-webkit-tests: Rearranged the code a bit to make the sequence
        more logical. Moved all the subroutines to the end of the file. Added a
        "--force" option.

        * DumpRenderTree/DumpRenderTree.m:
        (main): Added a new --dump-all-pixels option, used when forcing run-webkit-tests
        to generate new output for all tests it runs.
        (dump): Dump the scroll position if it's non-zero. Always dump the image when
        the --dump-all-pixels option is passed. Also tightened up the image dumping
        code and replaced the incorrect use of +[NSGraphicsContext saveGraphicsState]
        with code to save and restore the context.

        * DumpRenderTree/DumpRenderTree.h: Tweaked includes a bit and added (void).
        * DumpRenderTree/EventSendingController.m: Added now-needed include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
darin [Fri, 31 Mar 2006 18:02:13 +0000 (18:02 +0000)]
    Reviewed by Geoff.

        - <rdar://problem/4395622> API: WebScriptObject.h incorrectly reports that -isSelectorExcludedFromWebScript returns NO by default

        * bindings/objc/WebScriptObject.h: Fixed comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Layout test for <rdar://problem/4472371> REGRESSION(417.9-TOT):
bdakin [Fri, 31 Mar 2006 17:40:54 +0000 (17:40 +0000)]
    Layout test for <rdar://problem/4472371> REGRESSION(417.9-TOT):
        Focus ring around link in overflow:auto div isn't clipped to div

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemoved all the tabs and cleared the "allow tabs" bit.
darin [Fri, 31 Mar 2006 16:39:12 +0000 (16:39 +0000)]
Removed all the tabs and cleared the "allow tabs" bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix my build bustage with themes.
hyatt [Fri, 31 Mar 2006 11:45:15 +0000 (11:45 +0000)]
Fix my build bustage with themes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed Windows build breakage from previous change
mjs [Fri, 31 Mar 2006 11:32:27 +0000 (11:32 +0000)]
    - fixed Windows build breakage from previous change

        * platform/ScrollView.h:
        * platform/win/FontWin.cpp:
        (WebCore::Font::drawLineForText):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::scrollOffset):
        (WebCore::ScrollView::scrollBy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Fri, 31 Mar 2006 11:24:53 +0000 (11:24 +0000)]
    Reviewed by Eric.

        - various Point / Size related cleanup

        First, I clarified the semantics of some operations to keep a
        better distinction between IntPoint and IntSize:

        * platform/IntPoint.h:
        (WebCore::IntPoint::move): new convenience to move a point by separate
        x and y deltas.
        (WebCore::operator+=): You can't add a point to a point, you can only add
        a size to a point.
        (WebCore::operator+): ditto
        (WebCore::operator-): point - point = size; point - size = point
        (WebCore::operator-=): only allow subtracting a size for the mutating version
        * platform/IntRect.h:
        (WebCore::IntRect::move): tweaked to use IntPoint::move, also, move by an IntSize,
        not an IntPoint.
        * platform/IntSize.h:
        (WebCore::IntSize::shrunkTo): analog to expandedTo
        (WebCore::IntSize::clampNegativeToZero): a handy helper
        (WebCore::operator-): Added unary minus operator

        Made the same changes for FloatPoint:

        * platform/FloatPoint.h:
        (WebCore::FloatPoint::move):
        (WebCore::operator+=):
        (WebCore::operator-=):
        (WebCore::operator+):
        (WebCore::operator-):
        * platform/FloatRect.h:
        (WebCore::FloatRect::move):
        * platform/FloatSize.h:
        (WebCore::operator-):

        Then I changed a bunch of stuff to pass around IntPoint instead of separate x and y
        coordinates. The main one was:

        * platform/ScrollView.h:
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::scrollOffset): new method, return an IntSize
        (WebCore::ScrollView::contentsToViewport): take and return an IntPoint
        (WebCore::ScrollView::viewportToContents): take and return an IntPoint
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::updateContents): handle things in terms of scrollOffset,
        not scrollPoint
        (WebCore::ScrollView::visibleContentRect):
        (WebCore::ScrollView::contentsX):
        (WebCore::ScrollView::contentsY):
        (WebCore::ScrollView::viewportToContents):
        (WebCore::ScrollView::contentsToViewport):
        (WebCore::scrollOffset):
        (WebCore::ScrollView::maximumScroll):
        (WebCore::ScrollView::scrollBy):
        (WebCore::ScrollView::updateScrollBars):

        The rest is mainly updates for these changes.

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::eventMayStartDrag):
        (WebCore::FrameMac::dragHysteresisExceeded):
        (WebCore::FrameMac::handleMouseMoveEvent):
        (WebCore::FrameMac::mouseDown):
        (WebCore::FrameMac::shouldDragAutoNode):
        (WebCore::FrameMac::sendContextMenuEvent):
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge isPointInsideSelection:]):
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchMouseEvent):
        (WebCore::EventTargetNode::dispatchWheelEvent):
        * khtml/ecma/kjs_window.cpp:
        (KJS::WindowFunc::callAsFunction):
        * page/Frame.cpp:
        (WebCore::Frame::shouldDragAutoNode):
        (WebCore::Frame::isPointInsideSelection):
        (WebCore::Frame::selectClosestWordFromMouseEvent):
        (WebCore::Frame::handleMousePressEventDoubleClick):
        (WebCore::Frame::handleMousePressEventTripleClick):
        (WebCore::Frame::handleMousePressEventSingleClick):
        (WebCore::Frame::handleMouseMoveEventPart2):
        (WebCore::Frame::handleMouseReleaseEvent):
        * page/Frame.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::dispatchDragEvent):
        (WebCore::FrameView::prepareMouseEvent):
        (WebCore::FrameView::handleWheelEvent):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::draggableNode):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::positionForPoint):
        * rendering/render_list.cpp:
        (WebCore::RenderListMarker::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed windows build
mjs [Fri, 31 Mar 2006 11:18:28 +0000 (11:18 +0000)]
    - fixed windows build

        * platform/win/TemporaryLinkStubs.cpp:
        (Widget::unlockDrawingFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-31 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 31 Mar 2006 09:15:14 +0000 (09:15 +0000)]
2006-03-31  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        A bit more code cleanup.

        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertValueToNPVariant):
        * bindings/objc/objc_runtime.mm:
        (convertValueToObjcObject):
        * bindings/objc/objc_utility.mm:
        (KJS::Bindings::convertValueToObjcValue):
        * kjs/function.cpp:
        (KJS::GlobalFuncImp::callAsFunction):
        * kjs/interpreter.cpp:
        (KJS::ExecState::lexicalInterpreter):
        * kjs/interpreter.h:
        * kjs/operations.cpp:
        (KJS::equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-31 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 31 Mar 2006 09:14:13 +0000 (09:14 +0000)]
2006-03-31  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        A bit more code cleanup.

        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame evaluateWebScript:]):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::submit):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValue):
        * kwq/WebCoreTextField.mm:
        (-[KWQTextFieldController textView:shouldHandleEvent:]):
        (-[KWQSecureTextField selectText:]):
        * page/Frame.cpp:
        (WebCore::Frame::submitForm):
        * platform/Widget.h:
        * platform/mac/WidgetMac.mm:
        * rendering/render_frames.cpp:
        (WebCore::RenderFrameSet::userResize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Fri, 31 Mar 2006 07:39:01 +0000 (07:39 +0000)]
    Reviewed by Eric.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::wheelEvent):
        (WebCore::FrameMac::eventMayStartDrag):
        (WebCore::FrameMac::handleMouseMoveEvent):
        (WebCore::FrameMac::sendContextMenuEvent):
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:allowShadowContent:]):
        * dom/Document.cpp:
        (WebCore::Document::elementFromPoint):
        (WebCore::Document::prepareMouseEvent):
        * dom/Document.h:
        * kwq/WebCoreAXObject.mm:
        (-[WebCoreAXObject doAXTextMarkerForPosition:]):
        (-[WebCoreAXObject accessibilityHitTest:]):
        * manual-tests/frame-hover.html: Added.
        * manual-tests/resources/hover-subframe-1.html: Added.
        * manual-tests/resources/hover-subframe-2.html: Added.
        * page/Frame.cpp:
        (WebCore::Frame::isPointInsideSelection):
        * page/FrameView.cpp:
        (WebCore::FrameView::prepareMouseEvent):
        (WebCore::FrameView::handleWheelEvent):
        * platform/IntRect.h:
        (WebCore::IntRect::contains):
        * rendering/RenderLayer.cpp:
        (WebCore::isSubframeCanvas):
        (WebCore::frameVisibleRect):
        (WebCore::RenderLayer::hitTest):
        (WebCore::shouldApplyImplicitCapture):
        (WebCore::RenderLayer::hitTestLayer):
        * rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-31 Anders Carlsson <andersca@mac.com>
andersca [Fri, 31 Mar 2006 07:37:53 +0000 (07:37 +0000)]
2006-03-31  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        Add getter/setter GC tests.

        * fast/js/getter-setter-gc-expected.txt: Added.
        * fast/js/getter-setter-gc.html: Added.
        * fast/js/resources/getter-setter-gc.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-30 Darin Adler <darin@apple.com>
darin [Fri, 31 Mar 2006 07:25:19 +0000 (07:25 +0000)]
2006-03-30  Darin Adler  <darin@apple.com>

        - updated pixel results to create a new baseline (on a 10.4.5 system)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-30 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 31 Mar 2006 06:52:16 +0000 (06:52 +0000)]
2006-03-30  Eric Seidel  <eseidel@apple.com>

        Reviewed by anders.

        Small code-style update.

        * kjs/operations.cpp:
        (KJS::isNaN):
        (KJS::isInf):
        (KJS::isPosInf):
        (KJS::isNegInf):
        (KJS::equal):
        (KJS::strictEqual):
        (KJS::relation):
        (KJS::maxInt):
        (KJS::minInt):
        (KJS::add):
        (KJS::mult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-31 Anders Carlsson <andersca@mac.com>
andersca [Fri, 31 Mar 2006 06:48:57 +0000 (06:48 +0000)]
2006-03-31  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        Make sure the GetterSetterImp objects are marked as well.

        * kjs/internal.cpp:
        (KJS::GetterSetterImp::mark):
        Call JSCell::mark().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Fri, 31 Mar 2006 05:49:47 +0000 (05:49 +0000)]
LayoutTests:

        Reviewed by Darin.

        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8056
          Flexible boxes do not repaint their top, left and children's overflows

        * fast/repaint/flexible-box-overflow-expected.checksum: Added.
        * fast/repaint/flexible-box-overflow-expected.png: Added.
        * fast/repaint/flexible-box-overflow-expected.txt: Added.
        * fast/repaint/flexible-box-overflow-horizontal-expected.checksum: Added.
        * fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
        * fast/repaint/flexible-box-overflow-horizontal-expected.txt: Added.
        * fast/repaint/flexible-box-overflow-horizontal.html: Added.
        * fast/repaint/flexible-box-overflow.html: Added.

WebCore:

        Tests: fast/repaint/flexible-box-overflow.html fast/repaint/flexible-box-overflow-horizontal.html

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8056
          Flexible boxes do not repaint their top, left and children's overflows

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlockChildren):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::FlexBoxIterator::next):
        (WebCore::RenderFlexibleBox::layoutHorizontalBox): Update top overflow when
        determining vertical positions. Update horizontal overflows after horizontal
        positions are determined.
        (WebCore::RenderFlexibleBox::layoutVerticalBox):  Update left overflow when
        determining horizontal positions. Update vertical overflows after vertical
        positions are determined.
        (WebCore::RenderFlexibleBox::allowedChildFlex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Fri, 31 Mar 2006 05:23:14 +0000 (05:23 +0000)]
LayoutTests:

        Reviewed by Darin.

        - Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7301
          Text shadow does not repaint correctly

        * fast/repaint: Added.
        * fast/repaint/inline-block-overflow-expected.checksum: Added.
        * fast/repaint/inline-block-overflow-expected.png: Added.
        * fast/repaint/inline-block-overflow-expected.txt: Added.
        * fast/repaint/inline-block-overflow.html: Added.
        * fast/repaint/text-shadow-expected.checksum: Added.
        * fast/repaint/text-shadow-expected.png: Added.
        * fast/repaint/text-shadow-expected.txt: Added.
        * fast/repaint/text-shadow-horizontal-expected.checksum: Added.
        * fast/repaint/text-shadow-horizontal-expected.png: Added.
        * fast/repaint/text-shadow-horizontal-expected.txt: Added.
        * fast/repaint/text-shadow-horizontal.html: Added.
        * fast/repaint/text-shadow.html: Added.

WebCore:

        Tests: fast/repaint/text-shadow.html fast/repaint/text-shadow-horizontal.html

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7301
          Text shadow does not repaint correctly

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint): Paint the text box if it is within the maximum
        possible horizontal shadow overflow of the damage rect.
        * rendering/InlineTextBox.h: Removed unused function checkVerticalPoint().
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::paintLines): Use the vertical overflows instead of the
        selection vertical bounds.
        (WebCore::RenderFlow::hitTestLines):
        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally): Include overflow due to text shadow
        in leftPosition and rightPosition and keep track of the maximum horizontal shadow
        on the inline.
        (WebCore::InlineFlowBox::verticallyAlignBoxes):
        (WebCore::InlineFlowBox::placeBoxesVertically): Include overflow due to shadow and
        inline-blocks' overflow in topPosition and bottomPosition but not in the selection
        vertical bounds.
        (WebCore::RootInlineBox::selectionTop):
        * rendering/render_line.h:
        (WebCore::InlineFlowBox:::InlineRunBox):
        (WebCore::InlineFlowBox::setVerticalSelectionPositions):
        (WebCore::InlineFlowBox::maxHorizontalShadow):
        (WebCore::RootInlineBox::setVerticalSelectionPositions):
        (WebCore::RootInlineBox::selectionBottom):
        (WebCore::RootInlineBox::selectionHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLand focus ring bug fix and win theme improvements.
hyatt [Fri, 31 Mar 2006 03:12:40 +0000 (03:12 +0000)]
Land focus ring bug fix and win theme improvements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-30 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 31 Mar 2006 01:21:58 +0000 (01:21 +0000)]
2006-03-30  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        * kjs/nodes.h: Some various small style fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
bdakin [Fri, 31 Mar 2006 01:19:41 +0000 (01:19 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/4472371> REGRESSION(417.9-TOT): Focus ring
        around link in overflow:auto div isn't clipped to div

        Focus rings around the children off overflow:auto divs were not
        being appropriately clipped because they were being painted with
        the div's outlineRect, when they should be painted separately. This
        patch adds two new PaintPhases -- PaintPhaseSelfOutline and
        PaintPhaseChildOutlines -- to address this problem.

        This patch also changes the name of PaintAction back to PaintPhase.
        Because Hyatt said so.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-30 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 31 Mar 2006 01:13:22 +0000 (01:13 +0000)]
2006-03-30  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Clean-up style issues in node.h, remove redundant initializations.

        * kjs/nodes.h:
        (KJS::StatementNode::evaluate):
        (KJS::ArrayNode::ArrayNode):
        (KJS::ObjectLiteralNode::ObjectLiteralNode):
        (KJS::ArgumentsNode::ArgumentsNode):
        (KJS::NewExprNode::NewExprNode):
        (KJS::CaseClauseNode::CaseClauseNode):
        (KJS::FuncDeclNode::FuncDeclNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Manual test case for the Java aspect of <rdar://problem/4212626> REGRESSION...
tomernic [Fri, 31 Mar 2006 00:44:36 +0000 (00:44 +0000)]
    Manual test case for the Java aspect of <rdar://problem/4212626> REGRESSION: LIVECONNECT:
        JavaScript type for Java Strings is function, not object

        * manual-tests/java-string-object-type.html: Added.
        * manual-tests/resources/StringTypeTest.class: Added.
        * manual-tests/resources/StringTypeTest.java: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
tomernic [Fri, 31 Mar 2006 00:15:38 +0000 (00:15 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4212626> REGRESSION: LIVECONNECT: JavaScript type for Java Strings is function,
        not object

        * bindings/runtime.h:
        (KJS::Bindings::Instance::implementsCall):
        New method.  Returns false by default.  Concrete subclasses can override this return true when
        the bound object may be called as a function.
        (KJS::Bindings::Instance::invokeDefaultMethod):
        Since bound objects are no longer treated as functions by default, we can return jsUndefined()
        here instead of in concrete subclasses that decide not to implement the default method
        functionality.

        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::implementsCall):
        Don't assume that the bound object is a function; instead, let the object instance decide whether
        it is callable.

        * bindings/c/c_instance.h:
        * bindings/c/c_instance.cpp:
        (KJS::Bindings::CInstance::implementsCall):
        The object is callable if its class has an invokeDefault function.

        * bindings/objc/objc_instance.h:
        * bindings/objc/objc_instance.mm:
        (ObjcInstance::implementsCall):
        The object is callable if the ObjC instance responds to -invokeDefaultMethodWithArguments:.

        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_instance.cpp:
        Moved bogus invokeDefaultMethod() to superclass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
tomernic [Fri, 31 Mar 2006 00:13:46 +0000 (00:13 +0000)]
    Reviewed by Geoff.

        Test case for issues surrounding <rdar://problem/4212626> REGRESSION: LIVECONNECT:
        JavaScript type for Java Strings is function, not object

        Unfortunately, I can only test C and ObjC instances; Java does not run correctly
        in DumpRenderTree.

        * plugins/bindings-test/bindings-test.html: Added.
        * plugins/bindings-test/bindings-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by NOBODY (just fixing copyrights)
tomernic [Thu, 30 Mar 2006 23:48:53 +0000 (23:48 +0000)]
    Reviewed by NOBODY (just fixing copyrights)

        * DumpRenderTree/ObjCPlugin.h:
Fixed copyright.
        * DumpRenderTree/ObjCPlugin.m: ditto
        * DumpRenderTree/ObjCPluginFunction.h: ditto
        * DumpRenderTree/ObjCPluginFunction.m: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
tomernic [Thu, 30 Mar 2006 23:30:27 +0000 (23:30 +0000)]
    Reviewed by Geoff.

        * DumpRenderTree/DumpRenderTree.m:
        (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
        Add "objCPlugin", "objCPluginFunction" properties to the window.  objCPlugin simulates
        an Objective C object exposed to JS; objCPluginFunction simulates an Objective C method
        exposed to JS as a callable object.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        Added ObjCPlugin.[hm], ObjCPluginFunction.[hm].

        * DumpRenderTree/ObjCPlugin.h: Added.
        * DumpRenderTree/ObjCPlugin.m: Added.
        * DumpRenderTree/ObjCPluginFunction.h: Added.
        * DumpRenderTree/ObjCPluginFunction.m: Added.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
        Added a new method, "removeDefaultMethod", which removes the default method from the
        plugin object's class.  The effect is that the plugin object is mutated from a callable
        function to a simple object.
        (pluginInvoke):
        Handle "removeDefaultMethod".
        (pluginInvokeDefault):
        Made the default method actually do something (return 1).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-30 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 30 Mar 2006 22:16:41 +0000 (22:16 +0000)]
2006-03-30  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Remove WebFrame::viewImpl(), setMainFrame on page.

        * Spinneret/Spinneret/WebFrame.cpp:
        (WebKit::WebFrame::WebFrame):
        * Spinneret/Spinneret/WebFrame.h:
        * Spinneret/Spinneret/WebView.cpp:
        (WebKit::WebView::mouseMoved):
        (WebKit::WebView::mouseDown):
        (WebKit::WebView::mouseUp):
        (WebKit::WebView::mouseDoubleClick):
        (WebKit::WebViewWndProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-30 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 30 Mar 2006 21:55:26 +0000 (21:55 +0000)]
2006-03-30  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Fix html editing input & basic form submission.

        * Spinneret/Spinneret/WebFrame.cpp:
        (WebKit::WebFrame::submitForm):
        (WebKit::WebFrame::loadURL):
        * Spinneret/Spinneret/WebFrame.h:
        * Spinneret/Spinneret/WebView.cpp:
        (WebKit::WebView::keyPress):
        (WebKit::WebViewWndProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-30 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 30 Mar 2006 21:44:06 +0000 (21:44 +0000)]
2006-03-30  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Fix text form controls, and add basic submit support!

        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::submitForm):
        * bridge/win/FrameWin.h:
        * platform/win/KeyEventWin.cpp:
        (WebCore::keyIdentifierForWindowsKeyCode):
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::incomingReferrer):
        * platform/win/TransferJobWin.cpp:
        (WebCore::TransferJob::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Justin.
adele [Thu, 30 Mar 2006 20:56:03 +0000 (20:56 +0000)]
    Reviewed by Justin.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8083
        REGRESSION: Repro crash when dragging to select over a new text field

        * editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent):
        When searching for non-editable content, if the end of the selection is in a
        shadow tree, then we need to jump out of that first.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 30 Mar 2006 19:28:56 +0000 (19:28 +0000)]
LayoutTests:

        Reviewed by darin

        http://bugzilla.opendarwin.org/show_bug.cgi?id=6989
        REGRESSION: Plain-text mode needed for contenteditable area used in new text field

        * fast/forms/plaintext-mode-1-expected.txt: Added.
        * fast/forms/plaintext-mode-1.html: Added.
        * fast/forms/plaintext-mode-2-expected.checksum: Added.
        * fast/forms/plaintext-mode-2-expected.png: Added.
        * fast/forms/plaintext-mode-2-expected.txt: Added.
        * fast/forms/plaintext-mode-2.html: Added.

WebCore:

        Reviewed by darin

        http://bugzilla.opendarwin.org/show_bug.cgi?id=6989
        REGRESSION: Plain-text mode needed for contenteditable area used in new text field

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge isSelectionEditable]):
        (-[WebCoreFrameBridge isSelectionRichlyEditable]):
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSValueKeywords.in:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * dom/Node.cpp:
        (WebCore::Node::isContentRichlyEditable):
        * dom/Node.h:
        * editing/EditCommand.cpp:
        (WebCore::EditCommand::apply):
        * editing/JSEditor.cpp:
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/Selection.h:
        (WebCore::Selection::rootEditableElement):
        (WebCore::Selection::isContentEditable):
        (WebCore::Selection::isContentRichlyEditable):
        * editing/SelectionController.h:
        (WebCore::SelectionController::rootEditableElement):
        (WebCore::SelectionController::isContentEditable):
        (WebCore::SelectionController::isContentRichlyEditable):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::isContentEditable):
        (WebCore::HTMLElement::contentEditable):
        (WebCore::HTMLElement::setContentEditable):
        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::createDivStyle):
        * rendering/render_style.h:
        (WebCore::):

WebKit:

        Reviewed by darin

        http://bugzilla.opendarwin.org/show_bug.cgi?id=6989
        REGRESSION: Plain-text mode needed for contenteditable area used in new text field

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _canEditRichly]): Added.
        (-[WebHTMLView _canIncreaseSelectionListLevel]): Use _canEditRichly
        (-[WebHTMLView _canDecreaseSelectionListLevel]): Ditto.
        (-[WebHTMLView _increaseSelectionListLevel]):
        (-[WebHTMLView _decreaseSelectionListLevel]):
        (-[NSArray validateUserInterfaceItem:]):
        Split rich text editing actions off from ones that can be applied anywhere.
        (-[NSArray _applyStyleToSelection:withUndoAction:]):
        (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
        (-[NSArray _alignSelectionUsingCSSValue:withUndoAction:]):
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Justin.
harrison [Thu, 30 Mar 2006 19:21:02 +0000 (19:21 +0000)]
    Reviewed by Justin.

        <rdar://problem/4444693> REGRESSION: Deleting empty lines causes quoted text to mistakenly get "unquoted"

        * editing/deleting/delete-block-merge-contents-022-expected.checksum: Added.
        * editing/deleting/delete-block-merge-contents-022-expected.png: Added.
        * editing/deleting/delete-block-merge-contents-022-expected.txt: Added.
        * editing/deleting/delete-block-merge-contents-022.html: Added.
        * editing/deleting/delete-block-merge-contents-023-expected.checksum: Added.
        * editing/deleting/delete-block-merge-contents-023-expected.png: Added.
        * editing/deleting/delete-block-merge-contents-023-expected.txt: Added.
        * editing/deleting/delete-block-merge-contents-023.html: Added.
        * editing/deleting/delete-block-merge-contents-024-expected.checksum: Added.
        * editing/deleting/delete-block-merge-contents-024-expected.png: Added.
        * editing/deleting/delete-block-merge-contents-024-expected.txt: Added.
        * editing/deleting/delete-block-merge-contents-024.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Justin.
harrison [Thu, 30 Mar 2006 19:20:03 +0000 (19:20 +0000)]
    Reviewed by Justin.

        <rdar://problem/4444693> REGRESSION: Deleting empty lines causes quoted text to mistakenly get "unquoted"

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        Formatting.
        (WebCore::DeleteSelectionCommand::moveNodesAfterNode):
        Generalize check that preserves nesting when deleting to the beginning of an ancestor block.

        * editing/deleting/delete-block-merge-contents-022.html: Added.
        * editing/deleting/delete-block-merge-contents-023.html: Added.
        * editing/deleting/delete-block-merge-contents-024.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Thu, 30 Mar 2006 18:40:15 +0000 (18:40 +0000)]
LayoutTests:

        Test: fast/forms/visual-hebrew-text-field.html

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8076
          REGRESSION: native text fields are reversed on "visual Hebrew" pages

        * css/html4.css: Set the -kthml-rtl-ordering property to "logical" for all
        input elements. This should help also with future conversions from AppKit to
        native.

WebCore:

        Reviewed by Darin.

        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8076
          REGRESSION: native text fields are reversed on "visual Hebrew" pages

        * fast/forms/visual-hebrew-text-field-expected.checksum: Added.
        * fast/forms/visual-hebrew-text-field-expected.png: Added.
        * fast/forms/visual-hebrew-text-field-expected.txt: Added.
        * fast/forms/visual-hebrew-text-field.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
ap [Thu, 30 Mar 2006 17:35:50 +0000 (17:35 +0000)]
    Reviewed by John Sullivan.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8051
          Empty forms are submitted incorrectly

        Test: fast/forms/empty-get.html

        * platform/KURL.cpp:
        (KURL::setQuery): Add a question mark for empty query strings, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplement live scrolling on Win32.
hyatt [Thu, 30 Mar 2006 10:55:35 +0000 (10:55 +0000)]
Implement live scrolling on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd some ifdefed out paint flashing code for Win32 to the scroll view's updateContent...
hyatt [Thu, 30 Mar 2006 10:53:22 +0000 (10:53 +0000)]
Add some ifdefed out paint flashing code for Win32 to the scroll view's updateContents method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix win32 sprintf method on string to not infinite loop. r=eric
hyatt [Thu, 30 Mar 2006 10:11:21 +0000 (10:11 +0000)]
Fix win32 sprintf method on string to not infinite loop. r=eric

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRoll out the change to 7102.
hyatt [Thu, 30 Mar 2006 10:02:11 +0000 (10:02 +0000)]
Roll out the change to 7102.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLand support for JPEG image decoding on Win32.
hyatt [Thu, 30 Mar 2006 09:23:59 +0000 (09:23 +0000)]
Land support for JPEG image decoding on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixed a bug number.
justing [Thu, 30 Mar 2006 06:45:28 +0000 (06:45 +0000)]
Fixed a bug number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 30 Mar 2006 06:38:22 +0000 (06:38 +0000)]
LayoutTests:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8067>
        REGRESSION: selectionRect includes next/previous replaced elements
        <rdar://problems/4402375&4474871&4474871>

        * editing/selection/4402375-expected.checksum: Added.
        * editing/selection/4402375-expected.png: Added.
        * editing/selection/4402375-expected.txt: Added.
        * editing/selection/4402375.html: Added.
        Turned on dumpSelectionRect for these tests:
        * editing/selection/replaced-boundaries-1-expected.checksum:
        * editing/selection/replaced-boundaries-1-expected.png:
        * editing/selection/replaced-boundaries-1.html:
        * editing/selection/replaced-boundaries-2-expected.checksum:
        * editing/selection/replaced-boundaries-2-expected.png:
        * editing/selection/replaced-boundaries-2.html:
        * editing/selection/replaced-boundaries-3-expected.checksum:
        * editing/selection/replaced-boundaries-3-expected.png:
        * editing/selection/replaced-boundaries-3.html:
        * editing/selection/image-before-linebreak-expected.checksum: Added.
        * editing/selection/image-before-linebreak-expected.png: Added.
        * editing/selection/image-before-linebreak-expected.txt: Added.
        * editing/selection/image-before-linebreak.html: Added.

WebCore:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8067>
        REGRESSION: selectionRect includes next/previous replaced elements
        Also fixes: <rdar://problems/4402375&4474871&4474871>

        In the case where a selection starts at the end or ends at the start
        of o, o->selectionState() != SelectionNone, but o isn't really selected.
        Constraining the selection with upstream and downstream eliminates these
        types of endpoints, but constraining endpoints that occur at the
        start or end of a paragraph creates positions inside containers - some
        of which the selection painting code isn't equipped to handle.

        * dom/Document.cpp:
        (WebCore::Document::updateSelection):
        * rendering/render_replaced.cpp:
        (WebCore::RenderReplaced::shouldPaint):
        (WebCore::RenderReplaced::selectionRect):
        (WebCore::RenderReplaced::setSelectionState):
        (WebCore::RenderWidget::setSelectionState):

WebKitTools:

        Reviewed by darin

        <rdar://problem/4402375>
        REGRESSION (417.8-TOT): selectionRect sometimes includes adjacent images

        Added an option to draw the selectionRect.

        * DumpRenderTree/DumpRenderTree.m:
        (dump):
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController dumpSelectionRect]):
        (dumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Justin pointed out that this test should use an old-style form element,
adele [Thu, 30 Mar 2006 06:16:41 +0000 (06:16 +0000)]
    Justin pointed out that this test should use an old-style form element,
        so I changed the test to use <input type="password">.

        * fast/events/event-sender-mouse-click-expected.txt:
        * fast/events/event-sender-mouse-click.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren [Thu, 30 Mar 2006 02:39:24 +0000 (02:39 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - JavaScriptCore side of fix for <rdar://problem/4308243> 8F36
        Regression: crash in malloc_consolidate if you use a .PAC file

        The crash was a result of threaded deallocation of thread-unsafe
        objects. Pure JS objects are thread-safe because all JS execution
        is synchronized through JSLock. However, JS objects that wrap WebCore
        objects are thread-unsafe because JS and WebCore execution are not
        synchronized.  That unsafety comes into play when the collector
        deallocates a JS object that wraps a WebCore object, thus causing the
        WebCore object to be deallocated.

        The solution here is to have each JSCell know whether it is safe to
        collect on a non-main thread, and to avoid collecting unsafe cells
        when on a non-main thread.

        We don't have a way to test PAC files yet, so there's no test
        attached to this patch.

        * kjs/collector.cpp:
        (KJS::Collector::collect):
        (1) Added the test "currentThreadIsMainThread ||
        imp->m_destructorIsThreadSafe".

        * kjs/protect.h:
        (KJS::gcProtectNullTolerant):
        (KJS::gcUnprotectNullTolerant):
        * kjs/value.h:
        (KJS::JSCell::JSCell): The bools here must be bitfields, otherwise
        m_destructorIsThreadSafe becomes another whole word, ruining the
        collector optimizations we've made based on the size of a JSObject.
        * kxmlcore/FastMalloc.cpp:
        (KXMLCore::currentThreadIsMainThread):
        (KXMLCore::fastMallocRegisterThread):
        * kxmlcore/FastMalloc.h:

WebCore:

        Reviewed by Hyatt.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6986
        Switch to use new text field implementation for <input type="text">

        * css/html4.css: Added default style info for new text fields.
        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::createDivStyle): Added an extra 1px of padding on the left & right to match Win IE & the latest Mozilla.
        (WebCore::RenderTextField::updateFromElement): Removed some outdated comments.  Cleaned up the way we add text nodes to the div.
        (WebCore::RenderTextField::setSelectionStart): Tweaked selection code to better match Mozilla behavior.
        (WebCore::RenderTextField::setSelectionEnd): ditto.
        (WebCore::RenderTextField::select): Cleaned this up by having it call setSelectionRange.
        (WebCore::RenderTextField::setSelectionRange): Calls updateLayout now in case this is called in an onload handler, and no other layout has occurred.
        (WebCore::RenderTextField::calcMinMaxWidth): Use floatWidth to calculate the width of the "0" character.
        * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): If the text field's specified border is different from
         the default border, then treat the control as styled, so the engine knows to turn off the aqua appearance.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintTextField): return false so the engine knows not to try to draw the border.
        (WebCore::RenderThemeMac::adjustTextFieldStyle): text field style info has been moved to html4.css.
         We also add intrinsic margins here if the font size is large enough.
        * html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler):
         No longer check for appearance. All text fields with m_type == TEXT will use the new implementation.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isKeyboardFocusable): ditto.
        (WebCore::HTMLInputElement::focus): ditto.
        (WebCore::HTMLInputElement::selectionStart): ditto.
        (WebCore::HTMLInputElement::selectionEnd): ditto.
        (WebCore::HTMLInputElement::setSelectionStart): ditto.
        (WebCore::HTMLInputElement::setSelectionEnd): ditto.
        (WebCore::HTMLInputElement::select): ditto.
        (WebCore::HTMLInputElement::setSelectionRange): ditto.
        (WebCore::HTMLInputElement::createRenderer): ditto.
        (WebCore::HTMLInputElement::defaultEventHandler): ditto.
        (WebCore::HTMLInputElement::isMouseFocusable): Added.  Old text fields relied on the widget to provide a focus policy.
         A text field that is focusable should be mouse focusable, and shouldn't need to ask the base class.
        * html/HTMLInputElement.h: Added isMouseFocusable.
        * html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isMouseFocusable):
         Removed specific text field code since that is now done in HTMLInputElement::isMouseFocusable.
        * dom/Document.cpp: (WebCore::Document::clearSelectionIfNeeded): Check that the new selection is does not have a shadowAncestorNode that is focused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Thu, 30 Mar 2006 01:49:57 +0000 (01:49 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Updated tests for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6986
        Switch to use new text field implementation for <input type="text">

        The new text field implementation uses RenderTextFielda instead of RenderLineEdits,
        and this accounts for many of the changes here.

        Also, background color and border properties are now dumped as part of the RenderTextField.

        There is also an outstanding bug that affects many tests that make a selection in a text field.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8068
        Editing delegate should not be notified when selection change involved new text field

        Now that we support box-sizing, we count border and padding when calculating size, so some
        of the tests that specify border size have different text field sizes.

        * editing/selection/3690703-2-expected.checksum:
        * editing/selection/3690703-2-expected.png:
        * editing/selection/3690703-2-expected.txt:
        * editing/selection/3690703-expected.checksum:
        * editing/selection/3690703-expected.png:
        * editing/selection/3690703-expected.txt:
        * editing/selection/3690719-expected.checksum:
        * editing/selection/3690719-expected.png:
        * editing/selection/3690719-expected.txt:
        * fast/block/float/032-expected.checksum:
        * fast/block/float/032-expected.png:
        * fast/block/float/032-expected.txt:
        * fast/block/margin-collapse/103-expected.txt:
        * fast/events/div-focus-expected.txt:
        * fast/events/event-sender-mouse-click-expected.txt:
        * fast/forms/access-key-expected.txt:
        * fast/forms/element-by-name-expected.txt:
        * fast/forms/focus-expected.txt:
        * fast/forms/form-element-geometry-expected.checksum:
        * fast/forms/form-element-geometry-expected.png:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/indeterminate-expected.checksum:
        * fast/forms/indeterminate-expected.png:
        * fast/forms/input-appearance-bkcolor-expected.checksum:
        * fast/forms/input-appearance-bkcolor-expected.png:
        * fast/forms/input-appearance-bkcolor-expected.txt:
        * fast/forms/input-appearance-default-bkcolor-expected.checksum:
        * fast/forms/input-appearance-default-bkcolor-expected.png:
        * fast/forms/input-appearance-default-bkcolor-expected.txt:
        * fast/forms/input-appearance-disabled-expected.checksum:
        * fast/forms/input-appearance-disabled-expected.png:
        * fast/forms/input-appearance-disabled-expected.txt:
        * fast/forms/input-appearance-focus-expected.checksum:
        * fast/forms/input-appearance-focus-expected.png:
        * fast/forms/input-appearance-focus-expected.txt:
        * fast/forms/input-appearance-maxlength-expected.txt:
        * fast/forms/input-appearance-maxlength.html:
        * fast/forms/input-appearance-minWidth-expected.checksum:
        * fast/forms/input-appearance-minWidth-expected.png:
        * fast/forms/input-appearance-minWidth-expected.txt:
        * fast/forms/input-appearance-preventDefault-expected.checksum:
        * fast/forms/input-appearance-preventDefault-expected.png:
        * fast/forms/input-appearance-preventDefault-expected.txt:
        * fast/forms/input-appearance-selection-expected.checksum:
        * fast/forms/input-appearance-selection-expected.png:
        * fast/forms/input-appearance-selection-expected.txt:
        * fast/forms/input-appearance-visibility-expected.checksum:
        * fast/forms/input-appearance-visibility-expected.png:
        * fast/forms/input-appearance-visibility-expected.txt:
        * fast/forms/input-appearance-width-expected.checksum:
        * fast/forms/input-appearance-width-expected.png:
        * fast/forms/input-appearance-width-expected.txt:
        * fast/forms/input-baseline-expected.checksum:
        * fast/forms/input-baseline-expected.png:
        * fast/forms/input-baseline-expected.txt:
        * fast/forms/input-changing-value-expected.txt:
        * fast/forms/input-value-expected.txt:
        * fast/forms/input-width-expected.txt:
        * fast/forms/legend-access-key-expected.txt:
        * fast/forms/selection-functions-expected.txt:
        * fast/forms/textfield-focus-out-expected.txt:
        * fast/replaced/width100percent-expected.checksum:
        * fast/replaced/width100percent-expected.png:
        * fast/replaced/width100percent-expected.txt:
        * fast/table/003-expected.txt:
        * fast/table/colspanMinWidth-expected.txt:
        * fast/table/spanOverlapRepaint-expected.txt:
        * tables/mozilla/bugs/45621-expected.txt:
        * tables/mozilla/bugs/bug1188-expected.checksum:
        * tables/mozilla/bugs/bug1188-expected.png:
        * tables/mozilla/bugs/bug1188-expected.txt:
        * tables/mozilla/bugs/bug12384-expected.checksum:
        * tables/mozilla/bugs/bug12384-expected.png:
        * tables/mozilla/bugs/bug12384-expected.txt:
        * tables/mozilla/bugs/bug18359-expected.checksum:
        * tables/mozilla/bugs/bug18359-expected.png:
        * tables/mozilla/bugs/bug18359-expected.txt:
        * tables/mozilla/bugs/bug24200-expected.txt:
        * tables/mozilla/bugs/bug2479-3-expected.txt:
        * tables/mozilla/bugs/bug2479-4-expected.txt:
        * tables/mozilla/bugs/bug28928-expected.txt:
        * tables/mozilla/bugs/bug4382-expected.txt:
        * tables/mozilla/bugs/bug4527-expected.txt:
        * tables/mozilla/bugs/bug46368-1-expected.txt:
        * tables/mozilla/bugs/bug46368-2-expected.txt:
        * tables/mozilla/bugs/bug51037-expected.txt:
        * tables/mozilla/bugs/bug55545-expected.checksum:
        * tables/mozilla/bugs/bug55545-expected.png:
        * tables/mozilla/bugs/bug55545-expected.txt:
        * tables/mozilla/bugs/bug59354-expected.txt:
        * tables/mozilla/bugs/bug7342-expected.checksum:
        * tables/mozilla/bugs/bug7342-expected.png:
        * tables/mozilla/bugs/bug7342-expected.txt:
        * tables/mozilla/bugs/bug96334-expected.checksum:
        * tables/mozilla/bugs/bug96334-expected.png:
        * tables/mozilla/bugs/bug96334-expected.txt:
        * tables/mozilla/bugs/bug99948-expected.txt:
        * tables/mozilla/dom/tableDom-expected.txt:
        * tables/mozilla/other/move_row-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.png:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug45621-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug45621-expected.png:
        * tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

WebCore:

        Reviewed by Hyatt.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6986
        Switch to use new text field implementation for <input type="text">

        * css/html4.css: Added default style info for new text fields.
        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::createDivStyle): Added an extra 1px of padding on the left & right to match Win IE & the latest Mozilla.
        (WebCore::RenderTextField::updateFromElement): Removed some outdated comments.  Cleaned up the way we add text nodes to the div.
        (WebCore::RenderTextField::setSelectionStart): Tweaked selection code to better match Mozilla behavior.
        (WebCore::RenderTextField::setSelectionEnd): ditto.
        (WebCore::RenderTextField::select): Cleaned this up by having it call setSelectionRange.
        (WebCore::RenderTextField::setSelectionRange): Calls updateLayout now in case this is called in an onload handler, and no other layout has occurred.
        (WebCore::RenderTextField::calcMinMaxWidth): Use floatWidth to calculate the width of the "0" character.
        * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): If the text field's specified border is different from
         the default border, then treat the control as styled, so the engine knows to turn off the aqua appearance.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintTextField): return false so the engine knows not to try to draw the border.
        (WebCore::RenderThemeMac::adjustTextFieldStyle): text field style info has been moved to html4.css.
         We also add intrinsic margins here if the font size is large enough.
        * html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler):
         No longer check for appearance. All text fields with m_type == TEXT will use the new implementation.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isKeyboardFocusable): ditto.
        (WebCore::HTMLInputElement::focus): ditto.
        (WebCore::HTMLInputElement::selectionStart): ditto.
        (WebCore::HTMLInputElement::selectionEnd): ditto.
        (WebCore::HTMLInputElement::setSelectionStart): ditto.
        (WebCore::HTMLInputElement::setSelectionEnd): ditto.
        (WebCore::HTMLInputElement::select): ditto.
        (WebCore::HTMLInputElement::setSelectionRange): ditto.
        (WebCore::HTMLInputElement::createRenderer): ditto.
        (WebCore::HTMLInputElement::defaultEventHandler): ditto.
        (WebCore::HTMLInputElement::isMouseFocusable): Added.  Old text fields relied on the widget to provide a focus policy.
         A text field that is focusable should be mouse focusable, and shouldn't need to ask the base class.
        * html/HTMLInputElement.h: Added isMouseFocusable.
        * html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isMouseFocusable):
         Removed specific text field code since that is now done in HTMLInputElement::isMouseFocusable.
        * dom/Document.cpp: (WebCore::Document::clearSelectionIfNeeded): Check that the new selection is does not have a shadowAncestorNode that is focused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Wed, 29 Mar 2006 23:47:58 +0000 (23:47 +0000)]
LayoutTests:

        Reviewed by Eric.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8026
          A particular animated SVG crashes in filter code
          <rdar://problem/4494775> A particular animated SVG crashes in filter code

        * svg/custom/empty-merge-expected.checksum: Added.
        * svg/custom/empty-merge-expected.png: Added.
        * svg/custom/empty-merge-expected.txt: Added.
        * svg/custom/empty-merge.svg: Added.

WebCore:

        Reviewed by Eric.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8026
          A particular animated SVG crashes in filter code
          <rdar://problem/4494775> A particular animated SVG crashes in filter code

        - fix some code that is not handling references correctly for GC

        Test: svg/custom/empty-merge.svg

        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (WebCore::KCanvasFilterQuartz::KCanvasFilterQuartz): Use KWQRetainNSRelease to
        properly retain a reference to an Objective-C object in a C++ class.
        (WebCore::KCanvasFilterQuartz::~KCanvasFilterQuartz): Use KWQRelease instead of
        release.
        (WebCore::KCanvasFilterQuartz::prepareFilter): Use KWQRetain instead of retain.
        (WebCore::KCanvasFilterQuartz::applyFilter): Use KWQRelease instead of release.
        (WebCore::KCanvasFilterQuartz::imageForName): Use objectForKey: instead of
        valueForKey: on the dictionary to sidestep a bug in valueForKey: on empty strings
        and because what we're doing with a dictionary here has nothing to do with
        key value encoding.

        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz):
        Use KWQRelease instead of release.
        (WebCore::KRenderingDeviceContextQuartz::nsGraphicsContext): Use KWQRetain
        instead of retain to properly retain a reference to an Objective-C object
        in a C++ class.

        * platform/mac/ImageMac.mm:
        (WebCore::Image::invalidateNativeData): Use CFRelease instead of release.
        (WebCore::Image::getNSImage): Use KWQRetainNSRelease to properly retain
        a reference to an Objective-C object in a C++ class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Hatcher.
darin [Wed, 29 Mar 2006 23:42:16 +0000 (23:42 +0000)]
    Reviewed by Tim Hatcher.

        - make the global initializer check work on Xcode 2.1 (although it's better on 2.2)

        * Scripts/check-for-global-initializers: Use NATIVE_ARCH if there is no CURRENT_ARCH.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
tomernic [Wed, 29 Mar 2006 22:13:38 +0000 (22:13 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4495316> REGRESSION (420+): After page has loaded, spinning progress indicator is displayed on
        tab at versiontracker.com

        * WebView/WebFrame.m:
        (-[WebFrame _receivedMainResourceError:]):
        Call -_clientRedirectCancelledOrFinished: here so that the frame load delegate is notified that the redirect's
        status has changed, if there was a redirect.  The frame load delegate may have saved some state about
        the redirect in its -webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:.  Since we are definitely
        not going to use this provisional resource, as it was cancelled, notify the frame load delegate that the redirect
        has ended.
        The fix for 4432562 was similar to this, but only took care of the case where the redirect load was actually
        committed to the frame.  The new call to -_clientRedirectCancelledOrFinished: handles the case where the redirect
        load was successful, but was not committed.  This happens with downloads.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ggaren [Wed, 29 Mar 2006 22:11:21 +0000 (22:11 +0000)]
LayoutTests:

        - Layout test for <rdar://problem/4477126> TOT REGRESSION: with
        release build, maps.google.com zoom slider always zooms fully out

        * fast/events/mouseclick-target-and-positioning-expected.txt: Added.
        * fast/events/mouseclick-target-and-positioning.html: Added.

WebCore:

        Reviewed by Darin.

        - Fixed <rdar://problem/4477126> TOT REGRESSION: with release
        build, maps.google.com zoom slider always zooms fully out

        There were 2 problems: (1) A syntax error in the UIEvent IDL file
        prevented some things from showing up in the bindings; (2)
        MouseEvent had a duplicate isSimulated property that shadowed
        MouseRelatedEvent's isSimulated property, and MouseEvent failed to
        initialize MouseRelatedEvent's isSimulated property.

        * dom/UIEvent.idl:
        * dom/dom2_eventsimpl.cpp:
        (WebCore::MouseRelatedEvent::MouseRelatedEvent):
        (WebCore::MouseEvent::MouseEvent):
        * dom/dom2_eventsimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
tomernic [Wed, 29 Mar 2006 21:42:36 +0000 (21:42 +0000)]
    Reviewed by Darin.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType):
        If the input type is dynamically changed, reevaluate whether the element maintains its state
        (this decision is based on the input's type).  Fixes an assertion error when leaving a page
        with a text field that had been dynamically changed to a password field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Omernick.
sullivan [Wed, 29 Mar 2006 21:41:11 +0000 (21:41 +0000)]
    Reviewed by Tim Omernick.

        - fixed these bugs:
        <rdar://problem/4483806> REGRESSION (417.8-TOT): PDFs don't scale correctly with auto-size (5356)
        <rdar://problem/3874856> Safari PDF display should be full width by default rather than
        sized to show the entire page

        * WebView/WebPDFRepresentation.m:
        (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
        Let the WebPDFView handle setting the document, because that's the best time to apply
        the sizing-related preferences.

        * WebView/WebPDFView.h:
        eliminated firstLayoutDone ivar and -PDFSubview public method; added -setPDFDocument:

        * WebView/WebPDFView.m:
        (-[WebPDFView initWithFrame:]):
        eliminate use of obsolete firstLayoutDone ivar
        (-[WebPDFView _applyPDFDefaults]):
        renamed from _readPDFDefaults for clarity
        (-[WebPDFView layout]):
        removed code that applied the preferences here. This was too early to handle auto-sizing correctly,
        because -layout can be called before the document exists, and calling setAutoSize:YES at that
        point confuses PDFView into setting the scale factor to 20 (the maximum).
        (-[WebPDFView setPDFDocument:]):
        New method, does what WebPDFRepresentation used to do and also applies the preferences here.
        This is a good place to apply them because the document is guaranteed to now exist (of course).
        (-[WebPDFView PDFSubview]):
        Moved this into a new FileInternal category because it's still needed by another class in
        this file but no longer needs to be public.

        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):
        Change WebKitPDFScaleFactorPreferenceKey to 0, which represents auto-size. This fixes 3874856,
        but wasn't feasible until 4483806 was fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Wed, 29 Mar 2006 17:37:43 +0000 (17:37 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8055
          Fix most CSS grammar conflicts.

        Gets the number of shift/reduce and reduce/reduce conflicts down from 37+4 to 7+0.

        I have fixed the reduce/reduce conflicts, then noticed that two of the fixes
        were already made in KDE tree (the other two are different because declaration
        blocks are described in quite different ways). Shift/reduce fixes are just
        merged from KDE, r332845 by Michael Matz.

        * css/CSSGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Wed, 29 Mar 2006 15:57:20 +0000 (15:57 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7157
          An asterisk in a CSS property name breaks CSS handling
          (Many layout problems at letras.terra.com.br)

        Test: fast/css/error-in-last-decl.html

        * css/CSSGrammar.y: Added a rule for the case when the last CSS rule
          has a syntax error, and doesn't end with a semicolon.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-29 Darin Adler <darin@apple.com>
darin [Wed, 29 Mar 2006 15:09:35 +0000 (15:09 +0000)]
2006-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - another cut at fixing the buildbot

        * generate-derived-sources: Fix if statement that was always following
        the Windows case. I believe this is the main problem.

        * WebCore.xcodeproj/project.pbxproj: Added CharsetData.h and added CharsetData.cpp
        to the target.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Similar changes.

        * platform/CharsetData.h: Added.
        * platform/CharsetNames.cpp: Moved the actual character set data out into a
        separate source file instead of include a .cpp file.

        * platform/make-charset-table.pl: Changed to generate a file that can stand alone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-29 Darin Adler <darin@apple.com>
darin [Wed, 29 Mar 2006 14:29:22 +0000 (14:29 +0000)]
2006-03-29  Darin Adler  <darin@apple.com>

        - an attempt to fix the buildbot

        * platform/mac/mac-encodings.txt: Touched this file so the character encodings
        files will be regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-29 Darin Adler <darin@apple.com>
darin [Wed, 29 Mar 2006 11:22:39 +0000 (11:22 +0000)]
2006-03-29  Darin Adler  <darin@apple.com>

        - a quick cut at fixing the windows build

        * WebCore.vcproj/WebCore/WebCore.vcproj: Added a few recently-added files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Wed, 29 Mar 2006 09:38:54 +0000 (09:38 +0000)]
LayoutTests:

        Reviewed by Anders.

        Test cases for Element.contains, including testing fix for
        <rdar://problem/4405353> JavaScript flickers popups onmouseover

        * fast/dom/Element/contains-method-expected.txt: Added.
        * fast/dom/Element/contains-method.html: Added.
        * fast/dom/Element/resources/contains-method.js: Added.
        * fast/events/capture-on-target.html:

WebCore:

        Reviewed by Anders.

        - fixed  <rdar://problem/4454976> repro crash in -[NSTextView(NSSharing) setSelectedRanges:affinity:stillSelecting:] when navigating

        Also fixed other issues with contains. The problem that caused the bug was:
        - contains should return true for the element itself, unlike isAncestor

        Other problems I fixed:
        - contains shouldn't be present on non-Element nodes
        - contains should return false when passed a non-Element node
        - contains should return false when passed a non-Node

        * bindings/scripts/CodeGeneratorJS.pm: Handle Element as a parameter.
        * dom/Element.cpp:
        (WebCore::Element::contains): Added new implementation.
        * dom/Element.h: Added prototype for contains.
        * dom/Element.idl: Added IDL declaration for contains.
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNodeProtoFunc::callAsFunction): Added old wrong contains().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixing typo from last commit.
bdakin [Wed, 29 Mar 2006 05:11:38 +0000 (05:11 +0000)]
Fixing typo from last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej
bdakin [Wed, 29 Mar 2006 05:07:51 +0000 (05:07 +0000)]
    Reviewed by Maciej

        Fix for <rdar://problem/4493218> repro crash in
        khtml::RenderBlock::repaintFloatingDescendants with giant
        cellspacing value

        Some callers of CSSPrimitiveValue::computeLength() expect an int,
        and others a short. This patch splits computerLength() into
        computeIntLength() and computeShortLength() so that the appropriate
        bounds can be checked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ap [Wed, 29 Mar 2006 04:23:18 +0000 (04:23 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4616
          Setting nodeValue on a textnode with collapsed whitespace only has no visual effect

        Test: fast/dom/space-to-text.html

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData): Create a renderer if it's needed, but missing.
        (WebCore::CharacterData::appendData): Ditto.
        (WebCore::CharacterData::insertData): Ditto.
        (WebCore::CharacterData::replaceData): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
tomernic [Wed, 29 Mar 2006 03:02:18 +0000 (03:02 +0000)]
    Reviewed by Maciej.

        <rdar://problem/4454976> repro crash in -[NSTextView(NSSharing) setSelectedRanges:affinity:stillSelecting:] when navigating
        to another page while selecting inside textarea inside iframe

        * kwq/WebCoreTextArea.mm:
        (-[WebCoreTextArea mouseDown:]):
        Guard super's -mouseDown: with calls to Widget::beforeMouseDown() and Widget::afterMouseDown().
        Other widgets do this to protect against being removed from the page and deallocated while handling
        mouse down events.
        (-[WebCoreTextView mouseDown:]):
        ditto

        * manual-tests/textarea-iframe-navigation.html: Added.
        * manual-tests/textarea-iframe-navigation2.html: Added.
        Manual test case for this fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13551 268f45cc-cd09-0410-ab3c-d52691b4dbfc