WebKit-https.git
9 years ago[MutationObservers] Microbenchmarks for appendChild, removeChild, and innerHTML
adamk@chromium.org [Thu, 10 Nov 2011 18:39:39 +0000 (18:39 +0000)]
[MutationObservers] Microbenchmarks for appendChild, removeChild, and innerHTML
https://bugs.webkit.org/show_bug.cgi?id=71939

Reviewed by Ojan Vafai.

These benchmarks time both the DOM mutations themselves and the time taken
to call the MutationCallback. This measurement is achieved by
executing the code entirely within the MutationCallback itself.

* Mutation/append-child-deep.html: Added. Covers appendChild in a 200-node-deep tree with subtree observation.
* Mutation/append-child.html: Added. Covers appendChild in a flat tree.
* Mutation/inner-html.html: Added. Covers innerHTML adding and removing many nodes at a time.
* Mutation/remove-child-deep.html: Added. Covers removeChild in a 200-node-deep tree with subtree observation.
* Mutation/remove-child.html: Added. Covers removeChild in a flat tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: ApplicationCache UI is confusing and incorrect.
vsevik@chromium.org [Thu, 10 Nov 2011 18:36:12 +0000 (18:36 +0000)]
Web Inspector: ApplicationCache UI is confusing and incorrect.
https://bugs.webkit.org/show_bug.cgi?id=64581

Reviewed by Pavel Feldman.

Source/WebCore:

Fixed resources panel application cache UI.
Manifest urls are now shown under application cache tree element.
Under each manifest url tree element frames using relevant application
cache are listed. Application cache detailed views could be opened for each
frame.

Test: http/tests/inspector/resource-tree/appcache-iframe-manifests.html

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::setFrontend):
(WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
(WebCore::InspectorApplicationCacheAgent::networkStateChanged):
(WebCore::InspectorApplicationCacheAgent::enable):
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::assertFrameWithDocumentLoader):
(WebCore::InspectorApplicationCacheAgent::getManifestForFrame):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::getResourceContent):
(WebCore::InspectorPageAgent::assertFrame):
(WebCore::InspectorPageAgent::assertDocumentLoader):
* inspector/InspectorPageAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype._update):
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
* inspector/front-end/ApplicationCacheModel.js:
(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):
(WebInspector.ApplicationCacheModel.prototype._mainFrameNavigated):
(WebInspector.ApplicationCacheModel.prototype._manifestForFrameLoaded):
(WebInspector.ApplicationCacheModel.prototype._framesWithManifestsLoaded):
(WebInspector.ApplicationCacheModel.prototype._frameManifestUpdated):
(WebInspector.ApplicationCacheModel.prototype._frameManifestRemoved):
(WebInspector.ApplicationCacheModel.prototype.frameManifestURL):
(WebInspector.ApplicationCacheModel.prototype.frameManifestStatus):
(WebInspector.ApplicationCacheModel.prototype._statusUpdated):
(WebInspector.ApplicationCacheModel.prototype.requestApplicationCache):
(WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):
(WebInspector.ApplicationCacheDispatcher.prototype.applicationCacheStatusUpdated):
(WebInspector.ApplicationCacheDispatcher.prototype.networkStateUpdated):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.frameForId):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.wasShown):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
(WebInspector.ResourcesPanel.prototype.addDocumentURL):
(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._populateApplicationCacheTree):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestAdded):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestRemoved):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestStatusChanged):
(WebInspector.ResourcesPanel.prototype._applicationCacheNetworkStateChanged):
(WebInspector.ApplicationCacheManifestTreeElement):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get itemURL):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get manifestURL):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheFrameTreeElement):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get itemURL):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get frameId):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get manifestURL):
(WebInspector.ApplicationCacheFrameTreeElement.prototype._refreshTitles):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.frameNavigated):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.onselect):

LayoutTests:

* http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Added.
* http/tests/inspector/resource-tree/appcache-iframe-manifests.html: Added.
* http/tests/inspector/resource-tree/resources/manifest.php: Added.
* http/tests/inspector/resource-tree/resources/page-with-manifest.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium expectations for r99854.
tonyg@chromium.org [Thu, 10 Nov 2011 18:26:13 +0000 (18:26 +0000)]
Chromium expectations for r99854.

* platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png.
* platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-10 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 18:23:15 +0000 (18:23 +0000)]
2011-11-10  Andrew Scherkus  <scherkus@chromium.org>

        Few more rebaselines for media/video-frame-accurate-seek-expected.html.

        * platform/chromium-cg-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Added.
        * platform/chromium-mac-leopard/media/video-frame-accurate-seek-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixup expectations for bots that finished cycling after r99760 was committed.
ojan@chromium.org [Thu, 10 Nov 2011 18:16:54 +0000 (18:16 +0000)]
Fixup expectations for bots that finished cycling after r99760 was committed.

* platform/chromium/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png.
* platform/chromium/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png.
* platform/chromium/fast/repaint/scroll-inside-table-cell-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png.
* platform/chromium/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png.
* platform/chromium/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png.
* platform/chromium/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
* platform/chromium/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium expectations for r99862.
tonyg@chromium.org [Thu, 10 Nov 2011 18:11:53 +0000 (18:11 +0000)]
Chromium expectations for r99862.

* platform/chromium-win/svg/foreignObject/background-render-phase-expected.txt: Added.
* platform/chromium/svg/foreignObject/background-render-phase-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShrink CSSMutableStyleDeclaration.
andreas.kling@nokia.com [Thu, 10 Nov 2011 17:46:27 +0000 (17:46 +0000)]
Shrink CSSMutableStyleDeclaration.
<http://webkit.org/b/72032>

Reviewed by Antti Koivisto.

Move m_strictParsing and m_iteratorCount (debug only) up into
CSSStyleDeclaration, effectively shaving one CPU word (4/8 bytes)
off of every CSSMutableStyleDeclaration.

* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
* css/CSSMutableStyleDeclaration.h:
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
* css/CSSStyleDeclaration.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] X11 plugins need to be reworked for Qt5
kbalazs@webkit.org [Thu, 10 Nov 2011 17:32:31 +0000 (17:32 +0000)]
[Qt] X11 plugins need to be reworked for Qt5
https://bugs.webkit.org/show_bug.cgi?id=70023

Reviewed by Simon Hausmann.

.:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

* Source/api.pri: Link to xlib if necessary.

Source/WebCore:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

No new tests. Existing plugin test are sufficient.

* Target.pri:
* bridge/npruntime_internal.h: Added yet another undef
to fix build with Qt5 + X11 headers.
* plugins/qt/QtX11ImageConversion.cpp: Added.
(WebCore::qimageFromXImage):
* plugins/qt/QtX11ImageConversion.h: Added.
Added a helper function to create a QImage from an XImage.
Put it in a new file into WebCore to avoid copyright issues - as
the code has been taken directly from Qt - and to be able to resuse
it for the WK1 plugin support in the future.

Source/WebKit2:

* Target.pri:
* UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::pluginsDirectories):
Kill the last dependency from the WebKit1 plugin system.
This is necessary because currently we don't build the WebKit1
plugin code. The function is equivalent with the XP_UNIX part of
PluginDatabase::defaultPluginDirectories.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::getPluginDisplay):
(WebKit::x11Screen):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::NetscapePlugin::x11HostDisplay):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::initializeXEvent):
Rework plugin initialization and drawing model.

Tools:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

* qmake/mkspecs/features/features.prf: Enable X11
plugins if Qt is built with the xcb-xlib backend.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/dom/htmlcollection-detectability.html has strange failure output.
andreas.kling@nokia.com [Thu, 10 Nov 2011 17:25:58 +0000 (17:25 +0000)]
fast/dom/htmlcollection-detectability.html has strange failure output.
<http://webkit.org/b/71946>

Reviewed by Darin Adler.

When a collection should be detectable, but isn't, the test would
say "Failed: document.foo is detectable." It should say that it's
undetectable.

* fast/dom/htmlcollection-detectability.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
vsevik@chromium.org [Thu, 10 Nov 2011 17:12:08 +0000 (17:12 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCache and reuse HTMLCollections exposed by Document.
andreas.kling@nokia.com [Thu, 10 Nov 2011 17:09:19 +0000 (17:09 +0000)]
Cache and reuse HTMLCollections exposed by Document.
<http://webkit.org/b/71956>

Reviewed by Antti Koivisto.

Source/WebCore:

Let Document cache the various HTMLCollection objects it exposes.
They're created on-demand and stored in a tight Vector.
This is a behavior change, since the lifetime of returned collections
is now tied to the lifetime of the Document. However, this matches the
current behavior of Firefox and Opera.

This reduces memory consumption by ~800 kB (on 64-bit) when loading
the full HTML5 spec. document.links was called 34001 times, yielding
34001 separate HTMLCollections, and now we only need 1.

The document.all collection retains the old behavior, as caching it
would be a bit more complicated.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::collection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
* dom/Document.h:
* html/CollectionType.h:

LayoutTests:

Update fast/dom/gc-9.html to document the new lifetime behavior of
HTMLCollection objects returned by document.

* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium layout test rebaseline.
tonyg@chromium.org [Thu, 10 Nov 2011 17:07:17 +0000 (17:07 +0000)]
Chromium layout test rebaseline.

* platform/chromium-win/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* platform/chromium/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [SuggestBox] Correctly position the box under the first character...
apavlov@chromium.org [Thu, 10 Nov 2011 17:07:02 +0000 (17:07 +0000)]
Web Inspector: [SuggestBox] Correctly position the box under the first character of the suggestion prefix.
https://bugs.webkit.org/show_bug.cgi?id=72022

Reviewed by Pavel Feldman.

On any suggest box position update (updateSuggestions invocation) an anchor is created at the beginning
of the user-entered word, and its box is ultimately passed into _updateBoxPosition to be used as the
actual anchor box (instead of the input element box).

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._boxForAnchorAtStart):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype._onscrollresize):
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPositionWithExistingAnchor):
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPosition):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
* inspector/front-end/utilities.js:
(AnchorBox):
(Element.prototype.offsetRelativeToWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMAKE] Refactoring CMakeLists${PORT}.txt to Platform${PORT}.cmake
ryuan.choi@samsung.com [Thu, 10 Nov 2011 17:05:18 +0000 (17:05 +0000)]
[CMAKE] Refactoring CMakeLists${PORT}.txt to Platform${PORT}.cmake
https://bugs.webkit.org/show_bug.cgi?id=56705

Reviewed by Adam Roben.

Source/JavaScriptCore:

* CMakeLists.txt:
* PlatformEfl.cmake: Renamed from Source/JavaScriptCore/CMakeListsEfl.txt.
* PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/CMakeListsWinCE.txt.
* shell/CMakeLists.txt:
* shell/PlatformEfl.cmake: Renamed from Source/JavaScriptCore/shell/CMakeListsEfl.txt.
* shell/PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/shell/CMakeListsWinCE.txt.
* wtf/CMakeLists.txt:
* wtf/PlatformEfl.cmake: Renamed from Source/JavaScriptCore/wtf/CMakeListsEfl.txt.
* wtf/PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/wtf/CMakeListsWinCE.txt.

Source/WebCore:

No new tests, just renaming CMakeLists*.txt to Platform*.cmake.

* CMakeLists.txt:
* PlatformEfl.cmake: Renamed from Source/WebCore/CMakeListsEfl.txt.
* PlatformWinCE.cmake: Renamed from Source/WebCore/CMakeListsWinCE.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fix CCLayerTreeHostImplTest::scrollRootCallsCommitAndRedraw
commit-queue@webkit.org [Thu, 10 Nov 2011 17:03:07 +0000 (17:03 +0000)]
[Chromium] Fix CCLayerTreeHostImplTest::scrollRootCallsCommitAndRedraw
https://bugs.webkit.org/show_bug.cgi?id=72027

We weren't calling setScrollable(true) when setting up the test, so
scroll events were being ignored. Test failed in debug builds, but passed
in release because we were using ASSERT instead of ASSERT_TRUE.

Patch by Iain Merrick <husky@google.com> on 2011-11-10
Reviewed by Tony Gentilcore.

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: wrong JSON.stringify used in webInspector.inspectedWindow.eval() backend
caseq@chromium.org [Thu, 10 Nov 2011 16:49:32 +0000 (16:49 +0000)]
Web Inspector: wrong JSON.stringify used in webInspector.inspectedWindow.eval() backend
https://bugs.webkit.org/show_bug.cgi?id=63083

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.InspectedWindow.prototype.eval):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

LayoutTests:

* inspector/extensions/extensions-eval-expected.txt:
* inspector/extensions/extensions-eval.html:
* platform/chromium/inspector/extensions/extensions-eval-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] [WebKit2] Fix remaining gtkdoc errors
commit-queue@webkit.org [Thu, 10 Nov 2011 16:47:25 +0000 (16:47 +0000)]
[GTK] [WebKit2] Fix remaining gtkdoc errors
https://bugs.webkit.org/show_bug.cgi?id=71990

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-11-10
Reviewed by Philippe Normand.

* UIProcess/API/gtk/WebKitWebView.cpp: Update add the phrase "property" to
references to properties, because the gtkdoc stylesheet does not differeniate
between properties and signals. Standardize the way we talk about property
notifications.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add an include to silence
warnings about GIR annotations.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the decorators the private section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVG object covers CSS background in HTML foreignObject
commit-queue@webkit.org [Thu, 10 Nov 2011 16:47:16 +0000 (16:47 +0000)]
SVG object covers CSS background in HTML foreignObject
https://bugs.webkit.org/show_bug.cgi?id=58417

Patch by Florin Malita <fmalita@google.com> on 2011-11-10
Reviewed by Simon Fraser.

Source/WebCore:

Test: svg/foreignObject/background-render-phase.html

* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::paint):

    Paint SVG foreign objects atomically, following the same pattern as
    http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/InlineBox.cpp#L209.

LayoutTests:

* svg/foreignObject/background-render-phase-expected.png: Added.
* svg/foreignObject/background-render-phase-expected.txt: Added.
* svg/foreignObject/background-render-phase.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r99851.
commit-queue@webkit.org [Thu, 10 Nov 2011 16:31:33 +0000 (16:31 +0000)]
Unreviewed, rolling out r99851.
http://trac.webkit.org/changeset/99851
https://bugs.webkit.org/show_bug.cgi?id=72029

Patch breaks Qt tests (Requested by schenney on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

Source/WebCore:

* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::~SVGElementInstance):
(WebCore::SVGElementInstance::clearChildren):
* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::clearUseElements):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::detachInstance):

LayoutTests:

* svg/custom/element-instance-held-by-js-crash-expected.txt: Removed.
* svg/custom/element-instance-held-by-js-crash.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Clean up how singe / double taps are handled
kenneth@webkit.org [Thu, 10 Nov 2011 16:27:58 +0000 (16:27 +0000)]
[Qt] Clean up how singe / double taps are handled
https://bugs.webkit.org/show_bug.cgi?id=72024

Reviewed by Simon Hausmann.

Move all decision making to the QtWebPageProxy.

* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):
* UIProcess/qt/QtTapGestureRecognizer.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::handleSingleTapEvent):
(QtWebPageProxy::handleDoubleTapEvent):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 16:15:56 +0000 (16:15 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline one test on Mac, to turn SL bots green again.

        * platform/mac/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 16:09:53 +0000 (16:09 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline Qt results after r99854.

        * platform/qt/svg/batik/text/textEffect-expected.txt:
        * platform/qt/svg/batik/text/textEffect3-expected.txt:
        * platform/qt/svg/custom/text-filter-expected.txt:
        * platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/qt/svg/filters/filter-on-filter-for-text-expected.txt:
        * platform/qt/svg/filters/filter-on-tspan-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed: fixed new inspector media-query CSS test on Qt.
pfeldman@chromium.org [Thu, 10 Nov 2011 15:58:48 +0000 (15:58 +0000)]
Not reviewed: fixed new inspector media-query CSS test on Qt.

* inspector/styles/media-queries.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 15:42:19 +0000 (15:42 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        [GTK] svg/as-image/svg-image-change-content-size.xhtml crashes
        https://bugs.webkit.org/show_bug.cgi?id=71932

        Reviewed by Philippe Normand.

        * platform/gtk/Skipped: Unskip test.

2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        [GTK] svg/as-image/svg-image-change-content-size.xhtml crashes
        https://bugs.webkit.org/show_bug.cgi?id=71932

        Reviewed by Philippe Normand.

        Null check m_page in drawSVGToImageBuffer(), just like all others methods do.
        As drawSVGToImageBuffer() is fired from a timer, it may get into this state under certain conditions, as seen on the 64bit gtk bot.

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::drawSVGToImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 15:40:37 +0000 (15:40 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rolling out part of r99854, which didn't belong there.

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::drawSVGToImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 15:33:06 +0000 (15:33 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Move unit resolving for all resources to rendering/
        https://bugs.webkit.org/show_bug.cgi?id=72011

        Reviewed by Andreas Kling.

        Update expected results for some filters tests, now that their bounding box is correctly dumped.

        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/custom/text-filter-expected.txt:
        * platform/mac/svg/filters/feColorMatrix-values-expected.txt:
        * platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/mac/svg/filters/filter-on-filter-for-text-expected.txt:
        * platform/mac/svg/filters/filter-on-tspan-expected.txt:

2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Move unit resolving for all resources to rendering/
        https://bugs.webkit.org/show_bug.cgi?id=72011

        Reviewed by Andreas Kling.

        Remove maskBoundingBox()/filterBoundingBox(), to avoid doing length resolution in svg/.
        RenderSVGResource* now uses SVGLengthContext::resolveRectangle, to do this while laying out.

        Move linear gradient start/end point, radial gradient focal/center point, radius calculations into
        their RenderSVGResource classes, cleanup code a bit.

        Convert filters to use SVGLengthContext. Fix DRT dumps for filters, while I'm at it, to give
        meaningful values, when objectBoundingBox is used as primitive units, when applying to <text>/<tspan>s.

        Several tests results need rebaselines on all platforms.

        * platform/graphics/filters/Filter.h:
        * rendering/svg/RenderSVGInlineText.h:
        (WebCore::RenderSVGInlineText::objectBoundingBox):
        * rendering/svg/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::buildPrimitives):
        (WebCore::RenderSVGResourceFilter::applyResource):
        (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
        * rendering/svg/RenderSVGResourceFilter.h:
        * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
        (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
        * rendering/svg/RenderSVGResourceGradient.cpp:
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/svg/RenderSVGResourceGradient.h:
        * rendering/svg/RenderSVGResourceLinearGradient.cpp:
        (WebCore::RenderSVGResourceLinearGradient::startPoint):
        (WebCore::RenderSVGResourceLinearGradient::endPoint):
        (WebCore::RenderSVGResourceLinearGradient::buildGradient):
        * rendering/svg/RenderSVGResourceLinearGradient.h:
        * rendering/svg/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
        * rendering/svg/RenderSVGResourceRadialGradient.cpp:
        (WebCore::RenderSVGResourceRadialGradient::centerPoint):
        (WebCore::RenderSVGResourceRadialGradient::focalPoint):
        (WebCore::RenderSVGResourceRadialGradient::radius):
        (WebCore::RenderSVGResourceRadialGradient::adjustFocalPointIfNeeded):
        (WebCore::RenderSVGResourceRadialGradient::buildGradient):
        * rendering/svg/RenderSVGResourceRadialGradient.h:
        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGResourceContainer):
        * svg/SVGFilterElement.cpp:
        * svg/SVGFilterElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/SVGLinearGradientElement.cpp:
        * svg/SVGLinearGradientElement.h:
        * svg/SVGMaskElement.cpp:
        * svg/SVGMaskElement.h:
        * svg/SVGRadialGradientElement.cpp:
        * svg/SVGRadialGradientElement.h:
        * svg/graphics/filters/SVGFilter.h:
        (WebCore::SVGFilter::filterRegionInUserSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix keyboard related layout tests after API refactoring
hausmann@webkit.org [Thu, 10 Nov 2011 15:32:53 +0000 (15:32 +0000)]
[Qt] Fix keyboard related layout tests after API refactoring

Reviewed by Tor Arne Vestbø.

Send key events to the handling page item, not the view.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::sendEvent):
(WTR::PlatformWebView::postEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Make the ENABLE(FEATURE) macro work in DRT
commit-queue@webkit.org [Thu, 10 Nov 2011 15:23:53 +0000 (15:23 +0000)]
[GTK] Make the ENABLE(FEATURE) macro work in DRT
https://bugs.webkit.org/show_bug.cgi?id=71940

Patch by Alexandre Mazari <amazari@igalia.com> on 2011-11-10
Reviewed by Philippe Normand.

* GNUmakefile.am:
Add webcore_cppflags to Programs_DumpRenderTree_CPP so
ENABLE_* variables are part of the environment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNull deref when no use element exists for SVG element instance
commit-queue@webkit.org [Thu, 10 Nov 2011 15:23:40 +0000 (15:23 +0000)]
Null deref when no use element exists for SVG element instance
https://bugs.webkit.org/show_bug.cgi?id=59136

Source/WebCore:

Cleans up the object when it is detached from the shadow DOM tree,
rather than leaving it in a half-clean state with some nulled
references but not others.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-10
Reviewed by Nikolas Zimmermann.

Test: svg/custom/element-instance-held-by-js-crash.svg

* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::~SVGElementInstance): Added a call to
detach to clean up if deletion happens without a prior detach call (as
when an entire tree is removed).
(WebCore::SVGElementInstance::detach): New method that replaces other
clean-up methods when the instance is removed from the shadow DOM.
* svg/SVGElementInstance.h: Added new detach method and removed
unnecessary clear methods.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::detachInstance): Changed calls to clear to
instead detach.

LayoutTests:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-10
Reviewed by Nikolas Zimmermann.

* svg/custom/element-instance-held-by-js-crash-expected.txt: Added.
* svg/custom/element-instance-held-by-js-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix focus related layout tests after API refactoring
hausmann@webkit.org [Thu, 10 Nov 2011 15:12:19 +0000 (15:12 +0000)]
[Qt] Fix focus related layout tests after API refactoring

Reviewed by Tor Arne Vestbø.

Make sure the focus is set on the page now, not on the view
(which doesn't actually handle the focus).

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::WrapperWindow):
(WTR::WrapperWindow::handleStatusChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Show media queries associated with specific CSS rules
apavlov@chromium.org [Thu, 10 Nov 2011 14:56:28 +0000 (14:56 +0000)]
Web Inspector: Show media queries associated with specific CSS rules
https://bugs.webkit.org/show_bug.cgi?id=65626

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/media-queries.html

* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::updateLastMediaLine):
* css/CSSParser.h:
* css/MediaList.cpp:
(WebCore::MediaList::MediaList):
* css/MediaList.h:
(WebCore::MediaList::lastLine):
(WebCore::MediaList::setLastLine):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::documentURLString):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::buildMediaObject):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::buildObjectForRule):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSRule):
(WebInspector.CSSMedia):
(WebInspector.CSSMedia.parsePayload):
(WebInspector.CSSMedia.parseMediaArrayPayload):
* inspector/front-end/ResourceUtils.js:
(WebInspector.linkifyResourceAsNode):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
* inspector/front-end/elementsPanel.css:
(.styles-section .header .title .media, .styles-section .header .title .media .subtitle):
(.styles-section .header .subtitle):

LayoutTests:

* inspector/styles/media-queries-expected.txt: Added.
* inspector/styles/media-queries.html: Added.
* inspector/styles/resources/media-queries-1.css: Added.
(body):
(#main):
* inspector/styles/resources/media-queries.css: Added.
(#main):
* inspector/styles/styles-iframe-expected.txt:
* inspector/styles/styles-source-lines-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [SuggestBox] Do not display suggest box if editing in the middle of...
apavlov@chromium.org [Thu, 10 Nov 2011 14:52:17 +0000 (14:52 +0000)]
Web Inspector: [SuggestBox] Do not display suggest box if editing in the middle of prompt unless a stop character follows
https://bugs.webkit.org/show_bug.cgi?id=72018

Reviewed by Pavel Feldman.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: do not highlight files larger than 10KLOC.
pfeldman@chromium.org [Thu, 10 Nov 2011 14:49:23 +0000 (14:49 +0000)]
Web Inspector: do not highlight files larger than 10KLOC.
https://bugs.webkit.org/show_bug.cgi?id=72025

This is a temporary measure while I am improving the highlighter
footprint. Otherwise, highlighting pretty printed Gmail takes ~1.3G of RAM.

Reviewed by Yury Semikhatsky.

* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter.prototype.highlight):
(WebInspector.TextEditorHighlighter.prototype.updateHighlight):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype._didRequestContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Clean up build system
hausmann@webkit.org [Thu, 10 Nov 2011 14:32:04 +0000 (14:32 +0000)]
[Qt] Clean up build system

Reviewed by Tor Arne Vestbø.

.:

* Source/api.pri: Eliminate use of WebKit2.pri.

Source/WebKit2:

Now that we use whole-archive linking we can fold the files that contain exported
symbols back into the WebKit2 static library.

* Target.pri: Fold in sources from WebKit2.pri.
* WebKit2.pri: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Merge QTouchWebView and QDesktopWebView into one class
alexis.menard@openbossa.org [Thu, 10 Nov 2011 14:09:07 +0000 (14:09 +0000)]
[Qt] Merge QTouchWebView and QDesktopWebView into one class
https://bugs.webkit.org/show_bug.cgi?id=71355

Reviewed by Kenneth Rohde Christiansen.

.:

Remove old tests and merge them into the new QQuickWebView directory.

* Source/tests.pri:

Source/WebKit/qt:

Register only QQuickWebView and QQuickWebPage in the plugin.

* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

Merge QTouchWebView and QDesktopWebView into one class called
QQuickWebView and its attached page QQuickWebPage. You can switch to the
traditional desktop use case with the private header. Also now on desktop
platforms AC is turn on by default. I also merged our two
subclasses of QtViewInterface into one as the split doesn't make
that much sense anymore. In the future we want to be able to enable the
traditional desktop use case depending the platform the code is running.
API tests and QML tests have been updated.

* Target.pri:
* UIProcess/API/qt/WKView.h:
* UIProcess/API/qt/qbasewebview.cpp: Removed.
* UIProcess/API/qt/qbasewebview_p.h: Removed.
* UIProcess/API/qt/qdesktopwebview.cpp: Removed.
* UIProcess/API/qt/qdesktopwebview.h: Removed.
* UIProcess/API/qt/qdesktopwebview_p.h: Removed.
* UIProcess/API/qt/qquickwebpage.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp.
(QQuickWebPage::QQuickWebPage):
(QQuickWebPage::~QQuickWebPage):
(QQuickWebPage::keyPressEvent):
(QQuickWebPage::keyReleaseEvent):
(QQuickWebPage::inputMethodEvent):
(QQuickWebPage::focusInEvent):
(QQuickWebPage::focusOutEvent):
(QQuickWebPage::mousePressEvent):
(QQuickWebPage::mouseMoveEvent):
(QQuickWebPage::mouseReleaseEvent):
(QQuickWebPage::mouseDoubleClickEvent):
(QQuickWebPage::wheelEvent):
(QQuickWebPage::hoverEnterEvent):
(QQuickWebPage::hoverMoveEvent):
(QQuickWebPage::hoverLeaveEvent):
(QQuickWebPage::dragMoveEvent):
(QQuickWebPage::dragEnterEvent):
(QQuickWebPage::dragLeaveEvent):
(QQuickWebPage::dropEvent):
(QQuickWebPage::geometryChanged):
(QQuickWebPage::event):
(QQuickWebPage::touchEvent):
(QQuickWebPage::itemChange):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::initializeSceneGraphConnections):
(QQuickWebPagePrivate::setPageProxy):
(computeEffectiveOpacity):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPagePrivate::_q_onAfterSceneRender):
(QQuickWebPagePrivate::_q_onSceneGraphInitialized):
* UIProcess/API/qt/qquickwebpage.h: Renamed from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h.
* UIProcess/API/qt/qquickwebpage_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h.
* UIProcess/API/qt/qquickwebview.cpp: Added.
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::contentSizeChanged):
(QQuickWebViewPrivate::scrollPositionRequested):
(QQuickWebViewPrivate::_q_viewportUpdated):
(QQuickWebViewPrivate::_q_viewportTrajectoryVectorChanged):
(QQuickWebViewPrivate::_q_onVisibleChanged):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::updateViewportConstraints):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewPrivate::chooseFiles):
(QQuickWebViewPrivate::_q_onOpenPanelFilesSelected):
(QQuickWebViewPrivate::_q_onOpenPanelFinished):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(toPolicyAction):
(hasMetaMethod):
(QQuickWebViewPrivate::navigationPolicyForURL):
(QQuickWebViewPrivate::setPageProxy):
(QQuickWebView::QQuickWebView):
(QQuickWebView::~QQuickWebView):
(QQuickWebView::page):
(QQuickWebView::load):
(QQuickWebView::postMessage):
(QQuickWebView::url):
(QQuickWebView::loadProgress):
(QQuickWebView::title):
(QQuickWebView::navigationController):
(QQuickWebView::preferences):
(QQuickWebView::geometryChanged):
(QQuickWebView::touchEvent):
(QQuickWebView::pageRef):
* UIProcess/API/qt/qquickwebview.h: Renamed from Source/WebKit2/UIProcess/API/qt/qbasewebview.h.
* UIProcess/API/qt/qquickwebview_p.h: Added.
* UIProcess/API/qt/qtouchwebview.cpp: Removed.
* UIProcess/API/qt/qtouchwebview.h: Removed.
* UIProcess/API/qt/qtouchwebview_p.h: Removed.
* UIProcess/API/qt/tests/commonviewtests/commonviewtests.pro: Removed.
* UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp: Removed.
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp: Removed.
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h: Removed.
* UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp: Removed.
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_messaging.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
* UIProcess/API/qt/tests/qmltests/qmltests.pro:
* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(DesktopWebView::DesktopWebView):
(main):
* UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qdesktopwebview/qdesktopwebview.pro.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp: Added.
(tst_QQuickWebView::tst_QQuickWebView):
(tst_QQuickWebView::init):
(tst_QQuickWebView::cleanup):
(tst_QQuickWebView::webView):
(tst_QQuickWebView::accessPage):
(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::baseUrl):
(tst_QQuickWebView::loadEmptyUrl):
(tst_QQuickWebView::loadEmptyPageViewVisible):
(tst_QQuickWebView::loadEmptyPageViewHidden):
(tst_QQuickWebView::loadNonexistentFileUrl):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):
(tst_QQuickWebView::loadProgress):
(tst_QQuickWebView::show):
* UIProcess/API/qt/tests/qtouchwebview/qtouchwebview.pro: Removed.
* UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp: Removed.
* UIProcess/API/qt/tests/testwindow.h:
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/qt/QtGestureRecognizer.cpp:
(WebKit::QtGestureRecognizer::QtGestureRecognizer):
(WebKit::QtGestureRecognizer::setViewportInteractionEngine):
* UIProcess/qt/QtGestureRecognizer.h:
* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::setViewportInteractionEngine):
(WebKit::QtPanGestureRecognizer::recognize):
* UIProcess/qt/QtPanGestureRecognizer.h:
* UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit::QtPinchGestureRecognizer::recognize):
(WebKit::QtPinchGestureRecognizer::setViewportInteractionEngine):
* UIProcess/qt/QtPinchGestureRecognizer.h:
* UIProcess/qt/QtTouchViewInterface.cpp: Removed.
* UIProcess/qt/QtTouchViewInterface.h: Removed.
* UIProcess/qt/QtViewInterface.cpp: Added.
(WebKit::QtViewInterface::QtViewInterface):
(WebKit::QtViewInterface::didFindZoomableArea):
(WebKit::QtViewInterface::sceneGraphUpdateQueue):
(WebKit::QtViewInterface::setViewNeedsDisplay):
(WebKit::QtViewInterface::drawingAreaSize):
(WebKit::QtViewInterface::contentSizeChanged):
(WebKit::QtViewInterface::scrollPositionRequested):
(WebKit::QtViewInterface::isActive):
(WebKit::QtViewInterface::hasFocus):
(WebKit::QtViewInterface::isVisible):
(WebKit::QtViewInterface::startDrag):
(WebKit::QtViewInterface::didChangeViewportProperties):
(WebKit::QtViewInterface::didChangeUrl):
(WebKit::QtViewInterface::didChangeTitle):
(WebKit::QtViewInterface::didChangeToolTip):
(WebKit::QtViewInterface::didChangeStatusText):
(WebKit::QtViewInterface::didChangeCursor):
(WebKit::QtViewInterface::loadDidBegin):
(WebKit::QtViewInterface::loadDidCommit):
(WebKit::QtViewInterface::loadDidSucceed):
(WebKit::QtViewInterface::loadDidFail):
(WebKit::QtViewInterface::didChangeLoadProgress):
(WebKit::QtViewInterface::didMouseMoveOverElement):
(WebKit::QtViewInterface::showContextMenu):
(WebKit::QtViewInterface::hideContextMenu):
(WebKit::QtViewInterface::runJavaScriptAlert):
(WebKit::QtViewInterface::runJavaScriptConfirm):
(WebKit::QtViewInterface::runJavaScriptPrompt):
(WebKit::QtViewInterface::processDidCrash):
(WebKit::QtViewInterface::didRelaunchProcess):
(WebKit::QtViewInterface::engine):
(WebKit::QtViewInterface::downloadRequested):
(WebKit::QtViewInterface::chooseFiles):
* UIProcess/qt/QtViewInterface.h:
* UIProcess/qt/QtWebPageProxy.h:
(QtWebPageProxy::setViewportInteractionEngine):
* UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
* WebKit2.pri:

Tools:

Make MiniBrowser and WebKitTestRunner work again after the
merge.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::webView):
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
* MiniBrowser/qt/main.cpp:
* MiniBrowser/qt/qml/BrowserWindow.qml:
* MiniBrowser/qt/qml/DesktopView.qml: Removed.
* MiniBrowser/qt/qml/TouchView.qml: Removed.
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Scroll deltas are cleared during commit to the main thread
hclam@chromium.org [Thu, 10 Nov 2011 14:08:55 +0000 (14:08 +0000)]
[chromium] Scroll deltas are cleared during commit to the main thread
https://bugs.webkit.org/show_bug.cgi?id=71916

Reviewed by James Robinson.

Source/WebCore:

The patch keeps the scroll deltas and scroll position unchanged when
committing to the main thread. After commit has completed on the main
thread the submitted scroll deltas are then subtracted from the current
scroll deltas on the impl thread.

Doing so allow scroll deltas to be available at all time which enables
proper positioning for layers that are fixed-positioned to the
container layer.

This patch is tested by the following unit tests:
- CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls
  This test is modified to verify that scroll deltas and scroll position
  are unchanged during commit. And then after commit scroll deltas are
  subtracted correctly.

- CCLayerTreeHostTestScrollSimple.runMultiThread and
  CCLayerTreeHostTestScrollMultipleRedraw.runMultiThread
  These tests verifies that scroll deltas made on impl thread are
  committed to the main thread. The scroll deltas is eventually delegated
  to CCLayerTreeHostClient. When commit has completed the scroll deltas
  are subtracted correctly. There's no change to these two tests but they
  verify this patch maintains the overall behavior of scrolling.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::applyScrollAndScale):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::applyScrollAndScale):
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::applyScrollAndScaleInternal):
(WebCore::CCLayerTreeHostCommon::applyScrollAndScale):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls
This test is modified to verify that CCLayerTreeHostImpl::processScrollDeltas()
maintain the current scroll deltas and scroll positions.
It also verifies that scroll deltas are subtracted correctly by calling
CCLayerTreeHostCommon::applyScrollAndScale().
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::doBeginTest):
call setLayerTreeHost() on the root layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Change semantics of the haveQt() function to match API promises
vestbo@webkit.org [Thu, 10 Nov 2011 13:59:58 +0000 (13:59 +0000)]
[Qt] Change semantics of the haveQt() function to match API promises

Having Qt 5 does not imply that we have Qt 4, from an API point of
view, as a major version can in theory break BC/SC. Our minimum
version of Qt 4 will always be the latest released version of Qt 4,
so the only place we should use haveQt(4, x) is when checking for
the minimum requirements.

Reviewed-by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix make distcheck build.
carlosgc@webkit.org [Thu, 10 Nov 2011 13:59:12 +0000 (13:59 +0000)]
Unreviewed. Fix make distcheck build.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing files.

Source/WebCore:

* GNUmakefile.am: Add missing files.
* GNUmakefile.list.am: Ditto.

Source/WebKit2:

* GNUmakefile.am: Fix typos in gtk-doc files and scripts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed trivial fix after r99721.
ossy@webkit.org [Thu, 10 Nov 2011 13:26:02 +0000 (13:26 +0000)]
[Qt] Unreviewed trivial fix after r99721.

* platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect editing/spelling/markers.html expecations
tonyg@chromium.org [Thu, 10 Nov 2011 12:57:01 +0000 (12:57 +0000)]
Correct editing/spelling/markers.html expecations
https://bugs.webkit.org/show_bug.cgi?id=72015

This test was added in http://trac.webkit.org/changeset/99814 with no expectations so
it needs to be marked MISSING instead of FAIL.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward funct...
sergio@webkit.org [Thu, 10 Nov 2011 12:38:39 +0000 (12:38 +0000)]
[WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=69411

Reviewed by Martin Robinson.

Tools:

* WebKitTestRunner/EventSenderProxy.h:
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
use the EventSender instead of WebProcess Event Simulation.
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::WTREventQueueItem::WTREventQueueItem):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::getMouseButtonModifiers):
(WTR::eventSenderButtonToGDKButton):
(WTR::EventSenderProxy::createMouseButtonEvent):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::replaySavedEvents):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::webkitModifiersToGDKModifiers):
(WTR::getGDKKeySymForKeyRef):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::leapForward):

LayoutTests:

Unskip tests that were previously failing due to the lack of
MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward. Also
moved around some other tests to their proper section.

* platform/gtk-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 12:26:32 +0000 (12:26 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Deploy SVGLengthContext in more places
        https://bugs.webkit.org/show_bug.cgi?id=72012

        Reviewed by Simon Hausmann.

        Doesn't affect any tests.

        * svg/SVGAnimatedLength.cpp:
        (WebCore::SVGAnimatedLengthAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
        * svg/SVGAnimatedLengthList.cpp:
        (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Mac build fix: Remove TapAndHold gesture type.
hausmann@webkit.org [Thu, 10 Nov 2011 12:23:01 +0000 (12:23 +0000)]
Unreviewed Mac build fix: Remove TapAndHold gesture type.

It broke the build because it's unhandled. Remove it since it's not
supported at the moment anyway. (looks like an accidental addition?)

* Shared/WebEvent.h:
* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 11:43:20 +0000 (11:43 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix build.

        * WebCore.gypi: Need to add rendering/svg/SVGPathData.* in another place as well, cr-bots are not compiling it and thus fail linking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 6)
yutak@chromium.org [Thu, 10 Nov 2011 11:42:16 +0000 (11:42 +0000)]
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 6)

* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/embedding-external-svgs-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/as-background-image/svg-as-background-5-expected.png.
* platform/chromium-cg-mac-snowleopard/svg/custom/embedding-external-svgs-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png.
* platform/chromium-mac-snowleopard/svg/custom/embedding-external-svgs-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/embedding-external-svgs-expected.png.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebKit/qt: [Qt] Enable exports and constructor functions in static libs
hausmann@webkit.org [Thu, 10 Nov 2011 11:41:15 +0000 (11:41 +0000)]
Source/WebKit/qt: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Remove unnecessary manual Qt resource
initialization.

Source/WebKit2: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformInitialize): Remove unnecessary manual Qt resource
initialization.

Tools: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/functions.prf: Use --whole-archive and their
mac/win32-msvc equivalents when linking static libraries into a shared
library or executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 11:17:52 +0000 (11:17 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Remove virtual toPathData() method from all graphics elements
        https://bugs.webkit.org/show_bug.cgi?id=72009

        Reviewed by Zoltan Herczeg.

        In bug 71780, SVGLengthContext was introduced, to allow to resolve SVGLengths against arbitary viewports.
        SVGLength::value(), which needs a SVGLengthContext, is still used all over svg/ - that should be changed, as rendering/
        should resolve these lengths, as HTML does it using Length & RenderStyles for CSS.

        As first step, move the #1 client of the SVGLength::value() methods - toPathData() out of svg/ into rendering/svg/SVGPathData
        as free-function, replacing the virtual toPathData() function from SVGStyledTransformableElement.

        Doesn't affect any tests.

        * CMakeLists.txt: Add rendering/svg/SVGPathData.* to build.
        * GNUmakefile.list.am: Ditto.
        * Target.pri: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * rendering/svg/RenderSVGAllInOne.cpp: Ditto.
        * rendering/svg/RenderSVGPath.cpp:
        (WebCore::RenderSVGPath::layout): Use "updatePathFromGraphicsElement(element, m_path)" instead of "element->toPathData(m_path)", avoiding a virtual call.
        * rendering/svg/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::layoutPath): Ditto.
        * rendering/svg/SVGPathData.cpp: Added.
        (WebCore::updatePathFromCircleElement):
        (WebCore::updatePathFromEllipseElement):
        (WebCore::updatePathFromLineElement):
        (WebCore::updatePathFromPathElement):
        (WebCore::updatePathFromPolygonElement):
        (WebCore::updatePathFromPolylineElement):
        (WebCore::updatePathFromRectElement):
        (WebCore::updatePathFromGraphicsElement):
        * rendering/svg/SVGPathData.h: Added.
        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::animationPath): Use updatePathFromGraphicsElement instead of toPathData.
        * svg/SVGCircleElement.cpp: Remove toPathData() virtual method.
        * svg/SVGCircleElement.h: Ditto.
        * svg/SVGEllipseElement.cpp: Ditto.
        * svg/SVGEllipseElement.h: Ditto.
        * svg/SVGLineElement.cpp: Ditto.
        * svg/SVGLineElement.h: Ditto.
        * svg/SVGPathElement.cpp: Ditto.
        * svg/SVGPathElement.h: Ditto.
        * svg/SVGPolygonElement.cpp: Ditto.
        * svg/SVGPolygonElement.h: Ditto.
        * svg/SVGPolylineElement.cpp: Ditto.
        * svg/SVGPolylineElement.h: Ditto.
        * svg/SVGRectElement.cpp: Ditto.
        * svg/SVGRectElement.h: Ditto.
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::toClipPath): Use updatePathFromGraphicsElement instead of toPathData.
        * svg/SVGStyledTransformableElement.h: Remove toPathData() virtual method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Make sure headers.pri has the right relative paths for install
vestbo@webkit.org [Thu, 10 Nov 2011 11:11:06 +0000 (11:11 +0000)]
[Qt] Make sure headers.pri has the right relative paths for install

The install rules are generated from api.pri which lives in Source,
which means the paths in headers.pri, which is the basis for the
install rules, needs to be relative to Source as well.

We were also installing the headers from the forwarding headers
directory, which was wrong, as those headers contained relative paths.

We now install the actual headers, by using headers.pri as a basis.

https://bugs.webkit.org/show_bug.cgi?id=71697

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Add Tap Gesture recognition to UIProcess
zeno.albisser@nokia.com [Thu, 10 Nov 2011 10:46:15 +0000 (10:46 +0000)]
[Qt][WK2] Add Tap Gesture recognition to UIProcess
https://bugs.webkit.org/show_bug.cgi?id=71841

Add a Tap gesture recognizer that delivers GestureSingleTap
and GestureTapAndHold events through the WebPageProxy.
Add a GestureTapAndHold to WebEvent.
Add a DoubleTap gesture for zooming in and out.

This patch is based on work of Benjamin Poulain.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-11-10
Reviewed by Kenneth Rohde Christiansen.

* Shared/WebEvent.h:
* Target.pri:
* UIProcess/qt/QtTapGestureRecognizer.cpp: Added.
(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::setWebPageProxy):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):
(WebKit::QtTapGestureRecognizer::timerEvent):
* UIProcess/qt/QtTapGestureRecognizer.h: Added.
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::doneWithTouchEvent):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 5)
yutak@chromium.org [Thu, 10 Nov 2011 10:41:05 +0000 (10:41 +0000)]
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 5)

* platform/chromium-cg-mac-leopard/svg/as-image/animated-svg-as-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/animated-svg-as-mask-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/backgrounds/animated-svg-as-mask-expected.png.
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/animated-svg-as-background-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/as-background-image/animated-svg-as-background-expected.png.
* platform/chromium-cg-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png: Added.
* platform/chromium-linux/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
* platform/chromium-linux/svg/as-background-image/animated-svg-as-background-expected.png:
* platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png:
* platform/chromium-mac-leopard/svg/as-image/animated-svg-as-image-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/animated-svg-as-background-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
* platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png: Removed.
* platform/chromium-mac/svg/as-background-image/animated-svg-as-background-expected.png: Removed.
* platform/chromium-win/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
* platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
* platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [refactoring] get rid of JavaScriptSourceFrameDelegate
caseq@chromium.org [Thu, 10 Nov 2011 10:09:33 +0000 (10:09 +0000)]
Web Inspector: [refactoring] get rid of JavaScriptSourceFrameDelegate
https://bugs.webkit.org/show_bug.cgi?id=71922

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.setReadOnly):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.activateBreakpoints):
(WebInspector.ScriptsPanel.prototype.folderAndDisplayNameForScriptURL):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.ScriptsPanel.prototype.addToWatch):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
zherczeg@webkit.org [Thu, 10 Nov 2011 10:03:56 +0000 (10:03 +0000)]
Unreviewed gardening.

* fast/harness/results-expected.txt: Update after r99818.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 4)
yutak@chromium.org [Thu, 10 Nov 2011 09:46:16 +0000 (09:46 +0000)]
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 4)

* platform/chromium-cg-mac-leopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/svg-as-mask-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/backgrounds/svg-as-mask-expected.png.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/chromium-cg-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
* platform/chromium-cg-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
* platform/chromium-linux/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
* platform/chromium-linux/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/chromium-mac-leopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
* platform/chromium-mac-leopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
* platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/svg-as-mask-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/svg-as-mask-expected.png: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
* platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
* platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
* platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
* platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
* platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/chromium/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix progress load reporting for MHTML documents.
jcivelli@chromium.org [Thu, 10 Nov 2011 09:39:42 +0000 (09:39 +0000)]
Fix progress load reporting for MHTML documents.

MHTML documents containing references to resources they don't include
never finish loading.
https://bugs.webkit.org/show_bug.cgi?id=71859

Reviewed by Adam Barth.

Source/WebCore:

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit/chromium:

* tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::registerMockedURLLoadAsHTML):
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):
* tests/FrameTestHelpers.h:
* tests/WebFrameTest.cpp:
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):
* tests/WebViewTest.cpp:
(WebKit::TEST_F):
* tests/data/page_with_image.mht: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix linking with --whole-archive
hausmann@webkit.org [Thu, 10 Nov 2011 09:37:22 +0000 (09:37 +0000)]
[Qt] Fix linking with --whole-archive

Reviewed by Zoltan Herczeg.

Compile XMLTreeViewer and related files when XSLT is enabled, not
when XSLT _and_ USE_LIBXML2. The files do not depend on libxml2, they
are #ifdeffed with ENABLE(XSLT) only, and they are referenced from for
example NewXMLDocumentParser.cpp from within XSLT blocks.

* DerivedSources.pri:
* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 3)
yutak@chromium.org [Thu, 10 Nov 2011 09:22:04 +0000 (09:22 +0000)]
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 3)

* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
* platform/chromium-cg-mac/svg/wicd/test-scalable-background-image1-expected.png: Removed.
* platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
* platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
* platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png: Removed.
* platform/chromium-mac/svg/wicd/test-scalable-background-image2-expected.png: Removed.
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
* platform/chromium/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: load source maps via front-end host.
podivilov@chromium.org [Thu, 10 Nov 2011 09:19:35 +0000 (09:19 +0000)]
Web Inspector: load source maps via front-end host.
https://bugs.webkit.org/show_bug.cgi?id=71301

Reviewed by Yury Semikhatsky.

Source/WebCore:

Currently we use an auxiliary iframe hack to load source map files from inspector page. This approach has several drawbacks:
 - in addition to source map url we need to know auxiliary iframe url
 - we need a protocol to communicate with iframe
 - source map provider needs to provide auxiliary document to make our hack work
Loading source maps from front-end host solves all problems.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::loadResourceSynchronously):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.load):
(WebInspector.ClosureCompilerSourceMapping.prototype.loadSourceCode):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappingPayload):
* inspector/front-end/CompilerSourceMappingProvider.js: Removed.
* inspector/front-end/ContentProviders.js:
(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.setCompilerSourceMapping):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.installSourceMappingForTest):

LayoutTests:

* http/tests/inspector/compiler-source-mapping-provider-expected.txt: Removed.
* http/tests/inspector/compiler-source-mapping-provider.html: Removed.
* http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html: Removed.
* http/tests/inspector/resources/source-map.json: Renamed from LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map.
* http/tests/inspector/resources/source1.js: Renamed from LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app.js.
(window.onload):
(handleClick):
* http/tests/inspector/resources/source2.js: Renamed from LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/foo.js.
(ClickHandler):
(ClickHandler.prototype.handle):
* inspector/debugger/compiler-source-mapping.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 2)
yutak@chromium.org [Thu, 10 Nov 2011 08:28:28 +0000 (08:28 +0000)]
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 2)

* platform/chromium-cg-mac-leopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
* platform/chromium-cg-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-cg-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/as-background-image/svg-background-partial-redraw-expected.png.
* platform/chromium-cg-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-image/same-image-two-instances-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/chromium-linux/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-background-partial-redraw-expected.png:
* platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
* platform/chromium-linux/svg/as-image/same-image-two-instances-expected.png:
* platform/chromium-linux/svg/as-image/svg-image-change-content-size-expected.png:
* platform/chromium-mac-leopard/svg/as-background-image/svg-background-partial-redraw-expected.png:
* platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/same-image-two-instances-expected.png:
* platform/chromium-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Removed.
* platform/chromium-mac/svg/as-background-image/svg-background-partial-redraw-expected.png: Removed.
* platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Removed.
* platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
* platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png:
* platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
* platform/chromium-win/svg/as-image/same-image-two-instances-expected.png:
* platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r99816.
loislo@chromium.org [Thu, 10 Nov 2011 08:17:27 +0000 (08:17 +0000)]
Unreviewed, rolling out r99816.
http://trac.webkit.org/changeset/99816
https://bugs.webkit.org/show_bug.cgi?id=72003

compilation failed on mac (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

Source/WebCore:

* html/HTMLAttributeNames.in:
* html/HTMLInputElement.idl:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::appendFormData):
* html/HTMLTextAreaElement.idl:
* html/HTMLTextFormControlElement.cpp:
* html/HTMLTextFormControlElement.h:
* html/TextFieldInputType.cpp:
* html/TextFieldInputType.h:

LayoutTests:

* fast/forms/form-dirname-attribute-expected.txt: Removed.
* fast/forms/form-dirname-attribute.html: Removed.
* fast/forms/submit-form-with-dirname-attribute-expected.txt: Removed.
* fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Removed.
* fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Removed.
* fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Removed.
* fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Removed.
* fast/forms/submit-form-with-dirname-attribute.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 1)
yutak@chromium.org [Thu, 10 Nov 2011 08:08:32 +0000 (08:08 +0000)]
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 1)

* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-004-expected.png:
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-005-expected.png:
* platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.png:
* platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.png:
* platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png:
* platform/chromium-mac-leopard/css2.1/20110323/background-intrinsic-004-expected.png:
* platform/chromium-mac-leopard/css2.1/20110323/background-intrinsic-005-expected.png:
* platform/chromium-mac-leopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png:
* platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png:
* platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/as-background-image/svg-as-background-2-expected.png.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-4-expected.png:
* platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.png:
* platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.png:
* platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: console does not work after switching panel while editing.
pfeldman@chromium.org [Thu, 10 Nov 2011 07:59:18 +0000 (07:59 +0000)]
Web Inspector: console does not work after switching panel while editing.
https://bugs.webkit.org/show_bug.cgi?id=71918

Reviewed by Yury Semikhatsky.

* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.willHide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[NRWT] Make results.html aware of reference filename in reftests.
hayato@chromium.org [Thu, 10 Nov 2011 07:39:50 +0000 (07:39 +0000)]
[NRWT] Make results.html aware of reference filename in reftests.
https://bugs.webkit.org/show_bug.cgi?id=71574

Reviewed by Ryosuke Niwa.

If a reference filename is different from the default one, include that in result summary
so results.html can link to the correct reference file.

Tools:

* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

LayoutTests:

* fast/harness/resources/results-test.js:
* fast/harness/results.html:
* platform/chromium/fast/harness/results-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-09 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 07:12:38 +0000 (07:12 +0000)]
2011-11-09  Andrew Scherkus  <scherkus@chromium.org>

        Rebaselining media/video-frame-accurate-seek-expected.html now that it passes consistently.

        * platform/chromium-gpu-cg-mac/media/video-frame-accurate-seek-expected.png: Added.
        * platform/chromium-gpu-linux/media/video-frame-accurate-seek-expected.png: Added.
        * platform/chromium-gpu-win/media/video-frame-accurate-seek-expected.png: Added.
        * platform/chromium-linux/media/video-frame-accurate-seek-expected.png: Added.
        * platform/chromium-mac-leopard/media/video-frame-accurate-seek-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed support for dirname attribute
commit-queue@webkit.org [Thu, 10 Nov 2011 06:50:34 +0000 (06:50 +0000)]
Need support for dirname attribute
https://bugs.webkit.org/show_bug.cgi?id=65542

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-09
Reviewed by Eric Seidel.

Implemented 'dirname' form attribute.

Source/WebCore:

Tests: fast/forms/form-dirname-attribute.html
       fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html
       fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html
       fast/forms/submit-form-with-dirname-attribute.html

* html/HTMLAttributeNames.in:
Added "dirname" attribute.
* html/HTMLInputElement.idl:
Add "dirName" property to HTMLInputElement interface.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::appendFormData):
Append dirname form data.
* html/HTMLTextAreaElement.idl:
Add "dirName" property to HTMLTextAreaElement interface.
* html/HTMLTextFormControlElement.cpp:
(WebCore::parentHTMLElement):
Helper function which returns only HTML parent element.
(WebCore::HTMLTextFormControlElement::directionForFormData):
Helper function for finding directionality of the Element.
* html/HTMLTextFormControlElement.h:
Helper function for finding directionality of the Element.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::appendFormData):
Append dirname form data.
* html/TextFieldInputType.h:
Append dirname form data.

LayoutTests:

* fast/forms/form-dirname-attribute-expected.txt: Added.
* fast/forms/form-dirname-attribute.html: Added.
* fast/forms/submit-form-with-dirname-attribute-expected.txt: Added.
* fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Added.
* fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Added.
* fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Added.
* fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Added.
* fast/forms/submit-form-with-dirname-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-09 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 06:28:32 +0000 (06:28 +0000)]
2011-11-09  Andrew Scherkus  <scherkus@chromium.org>

        chromium-gpu-linux media rebaselines due to r98596.

        * platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png:
        * platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
        * platform/chromium-gpu-linux/media/controls-strict-expected.png:
        * platform/chromium-gpu-linux/media/controls-styling-expected.png:
        * platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
        * platform/chromium-gpu-linux/media/media-controls-clone-expected.png:
        * platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
        * platform/chromium-gpu-linux/media/video-empty-source-expected.png:
        * platform/chromium-gpu-linux/media/video-no-audio-expected.png:
        * platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png:
        * platform/chromium-gpu-linux/media/video-volume-slider-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInternals.markerRangeForNode should be able to take markers by specifying a marker...
commit-queue@webkit.org [Thu, 10 Nov 2011 06:10:59 +0000 (06:10 +0000)]
Internals.markerRangeForNode should be able to take markers by specifying a marker type.
https://bugs.webkit.org/show_bug.cgi?id=71792

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-09
Reviewed by Hajime Morita.

.:

* Source/autotools/symbols.filter: Exposed necessary symbols.

Source/WebCore:

Test: editing/spelling/markers.html

* WebCore.exp.in:
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::markersFor):
  Takes marker types to get only necessary markers.
* dom/DocumentMarkerController.h:
* testing/Internals.cpp:
(WebCore::markerTypesFrom): Added.
(WebCore::Internals::markerCountForNode):
  Takes marker types to get only necessary markers.
(WebCore::Internals::markerRangeForNode): ditto.
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def: Exposed necessary references.
* win/WebKit2CFLite.def: ditto.

LayoutTests:

* editing/spelling/markers.html: Added.
* editing/spelling/spelling-insert-html.html: Fixed function usage.
* platform/chromium/test_expectations.txt: Skipped chromium test.
* platform/gtk/Skipped: Skipped gtk test.
* platform/qt/Skipped: Skipped qt test.
* platform/win/Skipped: Skeipped win test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add support for painting into an SkPicture and then rasterizing into tile...
commit-queue@webkit.org [Thu, 10 Nov 2011 05:45:25 +0000 (05:45 +0000)]
[Chromium] Add support for painting into an SkPicture and then rasterizing into tile-sized chunks.
https://bugs.webkit.org/show_bug.cgi?id=71388

Patch by David Reveman <reveman@chromium.org> on 2011-11-09
Reviewed by James Robinson.

Add UpdatableTexture class, which allows texture updater to
allocate tile specific resources and paint tiles separately.
Rename texture uploader classes and move them to separate files.

No new tests. Covered by existing tests.

* WebCore.gypi:
* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp: Added.
(WebCore::BitmapCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::BitmapCanvasLayerTextureUpdater::Texture::~Texture):
(WebCore::BitmapCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapCanvasLayerTextureUpdater::create):
(WebCore::BitmapCanvasLayerTextureUpdater::BitmapCanvasLayerTextureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::~BitmapCanvasLayerTextureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::createTexture):
(WebCore::BitmapCanvasLayerTextureUpdater::sampledTexelFormat):
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/LayerTextureUpdater.h.
(WebCore::BitmapCanvasLayerTextureUpdater::Texture::textureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::orientation):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp: Renamed from Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp.
(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::~Texture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::create):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::FrameBufferSkPictureCanvasLayerTextureUpdater):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::~FrameBufferSkPictureCanvasLayerTextureUpdater):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::createTexture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::sampledTexelFormat):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/LayerTextureUpdater.h.
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::textureUpdater):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::orientation):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::Texture::Texture):
(WebCore::ImageLayerTextureUpdater::Texture::updateRect):
(WebCore::ImageLayerTextureUpdater::Texture::textureUpdater):
(WebCore::ImageLayerTextureUpdater::createTexture):
(WebCore::ImageLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore::LayerTextureUpdater::Texture::~Texture):
(WebCore::LayerTextureUpdater::Texture::texture):
(WebCore::LayerTextureUpdater::Texture::prepareRect):
(WebCore::LayerTextureUpdater::Texture::Texture):
(WebCore::LayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Removed.
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.
(WebCore::SkPictureCanvasLayerTextureUpdater::SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::~SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::SkPictureCanvasLayerTextureUpdater::drawPicture):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::texture):
(WebCore::UpdatableTile::managedTexture):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):
* platform/graphics/chromium/cc/CCTextureUpdater.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTowards 8 Bit Strings: Templatize JSC::LiteralParser class by character type
msaboff@apple.com [Thu, 10 Nov 2011 04:49:01 +0000 (04:49 +0000)]
Towards 8 Bit Strings: Templatize JSC::LiteralParser class by character type
https://bugs.webkit.org/show_bug.cgi?id=71862

Changed LiteralParser to be templatized of character type.

Moved five enums out of class definition to work around a clang compiler defect.

Added lexIdentifier templated method to break out character specific versions.
Added static setParserTokenString templated method to handle setting approriately
sized string pointer.

To keep code in LiteralParser.cpp and keep LiteralParser.h small, the two
flavors of LiteralParser are explicitly instantiated at the end of
LiteralParser.cpp.

Reviewed by Oliver Hunt.

* API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::isJSONWhiteSpace):
(JSC::::tryJSONPParse):
(JSC::::makeIdentifier):
(JSC::::Lexer::lex):
(JSC::::Lexer::lexIdentifier):
(JSC::::Lexer::next):
(JSC::LChar):
(JSC::UChar):
(JSC::isSafeStringCharacter):
(JSC::::Lexer::lexString):
(JSC::::Lexer::lexNumber):
(JSC::::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::LiteralParser):
(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::tryLiteralParse):
(JSC::LiteralParser::Lexer::Lexer):
(JSC::LiteralParser::Lexer::currentToken):
(JSC::LiteralParser::Lexer::getErrorMessage):
* runtime/UString.h:
(JSC::LChar):
(JSC::UChar):
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::append):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Update project files and add LTC stubs for new methods.
kevino@webkit.org [Thu, 10 Nov 2011 04:40:07 +0000 (04:40 +0000)]
[wx] Unreviewed build fix. Update project files and add LTC stubs for new methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMultiple CodeBlock should be able to share the same instruction
fpizlo@apple.com [Thu, 10 Nov 2011 04:37:32 +0000 (04:37 +0000)]
Multiple CodeBlock should be able to share the same instruction
stream without copying
https://bugs.webkit.org/show_bug.cgi?id=71978

Reviewed by Oliver Hunt.

This refactors CodeBlock::m_instructions to be a Vector boxed in a
ref-counted object, but otherwise does not take advantage of this.

This is performance neutral.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::hasInstructions):
(JSC::CodeBlock::numberOfInstructions):
(JSC::CodeBlock::instructions):
* jit/JIT.cpp:
(JSC::JIT::JIT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Add stub for new method.
kevino@webkit.org [Thu, 10 Nov 2011 04:35:01 +0000 (04:35 +0000)]
[wx] Unreviewed build fix. Add stub for new method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. wx should not be excluded from building ScopedFramePaintin...
kevino@webkit.org [Thu, 10 Nov 2011 04:33:38 +0000 (04:33 +0000)]
[wx] Unreviewed build fix. wx should not be excluded from building ScopedFramePaintingState code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Don't run fontDataForCombiningCharacterSequence on wx...
kevino@webkit.org [Thu, 10 Nov 2011 04:28:58 +0000 (04:28 +0000)]
[wx] Unreviewed build fix. Don't run fontDataForCombiningCharacterSequence on wx as we don't support it yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Update how we hash the font after changes to the StringHas...
kevino@webkit.org [Thu, 10 Nov 2011 04:21:31 +0000 (04:21 +0000)]
[wx] Unreviewed build fix. Update how we hash the font after changes to the StringHasher APIs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Support XCode 4 when building deps.
kevino@webkit.org [Thu, 10 Nov 2011 04:17:53 +0000 (04:17 +0000)]
[wx] Unreviewed build fix. Support XCode 4 when building deps.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Remove from WebDOMEventTarget bindings methods that have...
kevino@webkit.org [Thu, 10 Nov 2011 04:13:00 +0000 (04:13 +0000)]
[wx] Unreviewed build fix. Remove from WebDOMEventTarget bindings methods that have been removed from EventTarget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Cairo] Avoid clipping when painting more often
mrobinson@webkit.org [Thu, 10 Nov 2011 03:10:09 +0000 (03:10 +0000)]
[Cairo] Avoid clipping when painting more often
https://bugs.webkit.org/show_bug.cgi?id=71179

Reviewed by Xan Lopez.

No new tests. These changes are covered by existing tests.

* platform/graphics/Gradient.h: Add a Cairo-specific method
that gets the platform gradient with a particular alpha value.
* platform/graphics/cairo/GradientCairo.cpp: Now cache the alpha
value of the last created platform gradient.
(WebCore::Gradient::platformGradient): If the cached platform gradient
has a different alpha value than the one requested, destroy it and start
over.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawPathShadow): Adjust the source to avoid calling
cairo_clip/cairo_paint_with_alpha and just do a fill.
(WebCore::shadowAndFillCurrentCairoPath): No need to clip here. Just
call cairo_fill.
* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::drawPatternToCairoContext): If we have a >= 1 alpha value
we can simply fill and avoid calling cairo_clip here.
(WebCore::prepareCairoContextSource): Remove TODO about recreating the
gradient. No longer need to reduce the gradient source.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] [WebKit] Replace the gtkdoc autools magic with something more flexible
mrobinson@webkit.org [Thu, 10 Nov 2011 03:00:43 +0000 (03:00 +0000)]
[GTK] [WebKit] Replace the gtkdoc autools magic with something more flexible
https://bugs.webkit.org/show_bug.cgi?id=70877

Reviewed by Philippe Normand.

Add a script that runs gtkdoc manually instead of using the autotools
magic. Remove now unused gtkdoc files.

* GNUmakefile.am: Remove references to removed gtkdoc files.
* UIProcess/API/gtk/docs/GNUmakefile.am: Removed.
* UIProcess/API/gtk/docs/build-gtkdoc: Added.
* UIProcess/API/gtk/docs/gtkdoc.py: Added.
* UIProcess/API/gtk/docs/version.xml.in: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-09 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 02:56:48 +0000 (02:56 +0000)]
2011-11-09  Andrew Scherkus  <scherkus@chromium.org>

        More media rebaselines due to r98596.

        * media/controls-without-preload-expected.txt: Removed.
        * platform/chromium-gpu-win/media/audio-controls-rendering-expected.txt: Removed.
        * platform/chromium-gpu-win/media/controls-after-reload-expected.txt: Removed.
        * platform/chromium-gpu-win/media/controls-strict-expected.txt: Removed.
        * platform/chromium-gpu-win/media/controls-styling-expected.txt: Removed.
        * platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Removed.
        * platform/mac/media/controls-strict-expected.txt: Removed.
        * platform/win-wk2/media/controls-without-preload-expected.txt: Removed.
        * platform/win-xp/media/controls-without-preload-expected.txt: Removed.
        * platform/win/media/controls-without-preload-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10423024> WebProcess doesn't use AuthBrokerAgent for proxy credentials
ap@apple.com [Thu, 10 Nov 2011 02:48:40 +0000 (02:48 +0000)]
<rdar://problem/10423024> WebProcess doesn't use AuthBrokerAgent for proxy credentials
https://bugs.webkit.org/show_bug.cgi?id=71964

Reviewed by Darin Adler.

Source/WebCore:

* platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
* platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
Don't ask the client for proxy credentials. CFNetwork results are authoritative, and proxy
credentials are system-wide.

Source/WebKit2:

* WebProcess/com.apple.WebProcess.sb: Allow mach-lookup of com.apple.cfnetwork.AuthBrokerAgent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix typo in checkerboarding code
commit-queue@webkit.org [Thu, 10 Nov 2011 02:40:13 +0000 (02:40 +0000)]
[chromium] Fix typo in checkerboarding code
https://bugs.webkit.org/show_bug.cgi?id=71981

Patch by Daniel Sievers <sievers@chromium.org> on 2011-11-09
Reviewed by James Robinson.

No new tests.

* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::drawTiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRenovate ARMv7 assembler/macro-assembler
barraclough@apple.com [Thu, 10 Nov 2011 02:32:49 +0000 (02:32 +0000)]
Renovate ARMv7 assembler/macro-assembler
https://bugs.webkit.org/show_bug.cgi?id=71982

Reviewed by Geoff Garen.

ARMv7Assembler:
* add support for strb (byte stores)
* rename the VMOV_CtoS opcodes (there are currently backwards!)
* add support for adc (add with carry)
* add support for vsqrt, vabs
* add support for vmov (between FPRs, and to/from GPR pairs).
* remove '_F64' postfixes from instructions (these aren't helpful, functions can already be distinguished by their signatures).
* rename vcvt_F64_S32  to vcvt_signedToFloatingPoint, the prior postfix was unhelpful in failing to distinguish the types (S32 indicates a single precision register, but the type could be float, int32, or uint32).
* rename vcvtr_S32_F64 to vcvt_floatingPointToSigned, as for previous, also vcvtr was the incorrect name for the operation (the emitted instruction truncates).

MacroAssemblerARMv7:
* add 3-operand versions of and32, lshift32, or32, rshift32, urshift32, sub32, xor32,
* add store8, and store32 imm to base-index.
* fix load32WithCompactAddressOffsetPatch to work for all gprs (the fix is a little kludgy but functional; to do better we'll have to also fix the repatching code).
* Update supportsFloating* flags (all features now supported).
* add moveDouble, storeDouble to absolute address, addDouble to absolute address
* add 3-operand double operations.
* implement sqrtDouble/absDouble
* add branchTruncateDoubleToInt32, implement truncateDoubleToInt32
* move should do nothing if src == dest
* branchTest8-on-memory can be implemented in terms of branchTest32-on-register (branchTest8-on-register has been removed).
* add 3-operand branchAdd32, branchSub32, also branchAdd32 absolute address.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add expectation files for locale-sensitive-fonts.html
tkent@chromium.org [Thu, 10 Nov 2011 02:27:01 +0000 (02:27 +0000)]
[Chromium] Add expectation files for locale-sensitive-fonts.html
https://bugs.webkit.org/show_bug.cgi?id=67019

* platform/chromium-win/fast/text/international/locale-sensitive-fonts-expected.png: Added.
* platform/chromium/fast/text/international/locale-sensitive-fonts-expected.png: Added.
* platform/chromium/fast/text/international/locale-sensitive-fonts-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] MediaStream API: Add WebMediaStreamRegistry
commit-queue@webkit.org [Thu, 10 Nov 2011 02:25:10 +0000 (02:25 +0000)]
[chromium] MediaStream API: Add WebMediaStreamRegistry
https://bugs.webkit.org/show_bug.cgi?id=71458

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-09
Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebMediaStreamRegistry.h: Added.
* src/WebMediaStreamRegistry.cpp: Added.
(WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WinCairo] Further exclusions for unsupported features.
bfulgham@webkit.org [Thu, 10 Nov 2011 02:05:14 +0000 (02:05 +0000)]
[WinCairo] Further exclusions for unsupported features.

* platform/wincairo/Skipped: Turn off mathml and webgl tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r99782.
commit-queue@webkit.org [Thu, 10 Nov 2011 01:53:02 +0000 (01:53 +0000)]
Unreviewed, rolling out r99782.
http://trac.webkit.org/changeset/99782
https://bugs.webkit.org/show_bug.cgi?id=71979

broke most of the feImage tests (Requested by thorton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-09

Source/WebCore:

* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::parseMappedAttribute):
(WebCore::SVGFEImageElement::build):

LayoutTests:

* platform/mac/svg/filters/feImage-reference-svg-primitive-expected.png: Removed.
* platform/mac/svg/filters/feImage-reference-svg-primitive-expected.txt: Removed.
* svg/filters/feImage-reference-svg-primitive.svg: Removed.
* svg/filters/feImage-zero-size-crash-expected.txt: Removed.
* svg/filters/feImage-zero-size-crash.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove [CanBeConstructed] IDL from CodeGenerator{JS,V8}.pm
haraken@chromium.org [Thu, 10 Nov 2011 01:41:24 +0000 (01:41 +0000)]
Remove [CanBeConstructed] IDL from CodeGenerator{JS,V8}.pm
https://bugs.webkit.org/show_bug.cgi?id=71938

Reviewed by Darin Adler.

Now no IDL files are using [CanBeConstructed] IDL.
We can safely remove [CanBeConstructed] IDL from CodeGenerator{JS,V8}.pm.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm: Removed [CanBeConstructed]-related code.
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateImplementation):
* bindings/scripts/test/TestInterface.idl: Removed [CanBeConstructed].
* bindings/v8/V8Proxy.h: Removed V8Proxy::constructDOMObject and V8Proxy::constructDOMObjectWithScriptExecutionContext, which had been used only by [CanBeConstructed].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the concept of platform-dependent unittests
eric@webkit.org [Thu, 10 Nov 2011 01:21:36 +0000 (01:21 +0000)]
Remove the concept of platform-dependent unittests
https://bugs.webkit.org/show_bug.cgi?id=71963

Unreviewed.  Fix test-webkitpy on cygwin.

* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix up expected results after http://trac.webkit.org/changeset/99772.
ojan@chromium.org [Thu, 10 Nov 2011 01:16:30 +0000 (01:16 +0000)]
Fix up expected results after trac.webkit.org/changeset/99772.
The chromium mac results match the platform/mac results.

* platform/chromium/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-09 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 01:15:45 +0000 (01:15 +0000)]
2011-11-09  Andrew Scherkus  <scherkus@chromium.org>

        Rebaseline media layout tests due to r98596.

        * platform/chromium-cg-mac-snowleopard/media/audio-controls-rendering-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/audio-controls-rendering-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/controls-after-reload-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-after-reload-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/controls-strict-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-strict-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/controls-styling-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-styling-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/controls-without-preload-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-without-preload-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/media-controls-clone-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/media-controls-clone-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/video-display-toggle-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-display-toggle-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/video-empty-source-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-empty-source-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/video-no-audio-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-no-audio-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/video-volume-slider-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-volume-slider-expected.png.
        * platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png: Added.
        * platform/chromium-gpu-linux/media/media-controls-clone-expected.png: Added.
        * platform/chromium-gpu-linux/media/video-empty-source-expected.png: Added.
        * platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
        * platform/chromium-gpu-mac/media/controls-strict-expected.png:
        * platform/chromium-gpu-mac/media/controls-styling-expected.png:
        * platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
        * platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
        * platform/chromium-gpu-mac/media/video-no-audio-expected.png:
        * platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png:
        * platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
        * platform/chromium-gpu-win/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/audio-controls-rendering-expected.txt.
        * platform/chromium-gpu-win/media/controls-after-reload-expected.png:
        * platform/chromium-gpu-win/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/controls-after-reload-expected.txt.
        * platform/chromium-gpu-win/media/controls-strict-expected.png:
        * platform/chromium-gpu-win/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/controls-strict-expected.txt.
        * platform/chromium-gpu-win/media/controls-styling-expected.png:
        * platform/chromium-gpu-win/media/controls-styling-expected.txt: Added.
        * platform/chromium-gpu-win/media/controls-without-preload-expected.png:
        * platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/controls-without-preload-expected.txt.
        * platform/chromium-gpu-win/media/video-display-toggle-expected.png:
        * platform/chromium-gpu-win/media/video-no-audio-expected.png:
        * platform/chromium-gpu-win/media/video-playing-and-pause-expected.png:
        * platform/chromium-gpu-win/media/video-volume-slider-expected.png:
        * platform/chromium-linux/media/audio-controls-rendering-expected.png:
        * platform/chromium-linux/media/controls-after-reload-expected.png:
        * platform/chromium-linux/media/controls-strict-expected.png:
        * platform/chromium-linux/media/controls-styling-expected.png:
        * platform/chromium-linux/media/controls-without-preload-expected.png:
        * platform/chromium-linux/media/media-controls-clone-expected.png:
        * platform/chromium-linux/media/media-document-audio-repaint-expected.png:
        * platform/chromium-linux/media/video-display-toggle-expected.png:
        * platform/chromium-linux/media/video-empty-source-expected.png:
        * platform/chromium-linux/media/video-no-audio-expected.png:
        * platform/chromium-linux/media/video-playing-and-pause-expected.png:
        * platform/chromium-linux/media/video-volume-slider-expected.png:
        * platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
        * platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
        * platform/chromium-mac-leopard/media/controls-strict-expected.png:
        * platform/chromium-mac-leopard/media/controls-styling-expected.png:
        * platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
        * platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
        * platform/chromium-mac-leopard/media/video-empty-source-expected.png:
        * platform/chromium-mac-leopard/media/video-no-audio-expected.png:
        * platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
        * platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
        * platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png: Added.
        * platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/controls-after-reload-expected.png.
        * platform/chromium-mac-snowleopard/media/controls-strict-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/controls-strict-expected.png.
        * platform/chromium-mac-snowleopard/media/controls-styling-expected.png: Added.
        * platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png: Added.
        * platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png: Added.
        * platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-display-toggle-expected.png.
        * platform/chromium-mac-snowleopard/media/video-empty-source-expected.png: Added.
        * platform/chromium-mac-snowleopard/media/video-no-audio-expected.png: Added.
        * platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
        * platform/chromium-mac-snowleopard/media/video-volume-slider-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-volume-slider-expected.png.
        * platform/chromium-mac/media/audio-controls-rendering-expected.png: Removed.
        * platform/chromium-mac/media/controls-styling-expected.png: Removed.
        * platform/chromium-mac/media/controls-styling-expected.txt: Removed.
        * platform/chromium-mac/media/controls-without-preload-expected.png: Removed.
        * platform/chromium-mac/media/media-controls-clone-expected.png: Removed.
        * platform/chromium-mac/media/media-controls-clone-expected.txt: Removed.
        * platform/chromium-mac/media/video-display-toggle-expected.txt: Removed.
        * platform/chromium-mac/media/video-empty-source-expected.png: Removed.
        * platform/chromium-mac/media/video-no-audio-expected.png: Removed.
        * platform/chromium-mac/media/video-no-audio-expected.txt: Removed.
        * platform/chromium-mac/media/video-volume-slider-expected.txt: Removed.
        * platform/chromium-win/media/audio-controls-rendering-expected.png:
        * platform/chromium-win/media/controls-after-reload-expected.png:
        * platform/chromium-win/media/controls-strict-expected.png:
        * platform/chromium-win/media/controls-styling-expected.png:
        * platform/chromium-win/media/controls-without-preload-expected.png:
        * platform/chromium-win/media/media-controls-clone-expected.png:
        * platform/chromium-win/media/media-document-audio-repaint-expected.png:
        * platform/chromium-win/media/video-display-toggle-expected.png:
        * platform/chromium-win/media/video-empty-source-expected.png:
        * platform/chromium-win/media/video-no-audio-expected.png:
        * platform/chromium-win/media/video-playing-and-pause-expected.png:
        * platform/chromium-win/media/video-volume-slider-expected.png:
        * platform/chromium/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/audio-controls-rendering-expected.txt.
        * platform/chromium/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-after-reload-expected.txt.
        * platform/chromium/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-strict-expected.txt.
        * platform/chromium/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-styling-expected.txt.
        * platform/chromium/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-without-preload-expected.txt.
        * platform/chromium/media/media-controls-clone-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/media-controls-clone-expected.txt.
        * platform/chromium/media/video-display-toggle-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-display-toggle-expected.txt.
        * platform/chromium/media/video-no-audio-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-no-audio-expected.txt.
        * platform/chromium/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-volume-slider-expected.txt.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=71873
barraclough@apple.com [Thu, 10 Nov 2011 01:10:40 +0000 (01:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG OSR exit code should be lazily generated
fpizlo@apple.com [Thu, 10 Nov 2011 01:08:50 +0000 (01:08 +0000)]
DFG OSR exit code should be lazily generated
https://bugs.webkit.org/show_bug.cgi?id=71744

Reviewed by Gavin Barraclough.

The OSR exit code is now generated the first time it is executed,
rather than right after speculative compilation. Because most OSR
exits are never taken, this should greatly reduce both code size
and compilation time.

This is a 1% win on SunSpider, and a 1% win on V8 when running in
my harness. No change in V8 in V8's harness (due to the long runs,
so compile time is not an issue) and no change in Kraken (again,
long runs of small code so compile time has no measurable effect).

* CMakeListsEfl.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::jump):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::jump):
* assembler/X86Assembler.h:
(JSC::X86Assembler::jmp_m):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::createDFGDataIfNecessary):
(JSC::CodeBlock::appendDFGOSREntryData):
(JSC::CodeBlock::numberOfDFGOSREntries):
(JSC::CodeBlock::dfgOSREntryData):
(JSC::CodeBlock::dfgOSREntryDataForBytecodeIndex):
(JSC::CodeBlock::appendOSRExit):
(JSC::CodeBlock::appendSpeculationRecovery):
(JSC::CodeBlock::numberOfOSRExits):
(JSC::CodeBlock::numberOfSpeculationRecoveries):
(JSC::CodeBlock::osrExit):
(JSC::CodeBlock::speculationRecovery):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::debugCall):
* dfg/DFGCorrectableJumpPoint.cpp: Added.
(JSC::DFG::CorrectableJumpPoint::codeLocationForRepatch):
* dfg/DFGCorrectableJumpPoint.h: Added.
(JSC::DFG::CorrectableJumpPoint::CorrectableJumpPoint):
(JSC::DFG::CorrectableJumpPoint::switchToLateJump):
(JSC::DFG::CorrectableJumpPoint::correctInitialJump):
(JSC::DFG::CorrectableJumpPoint::correctLateJump):
(JSC::DFG::CorrectableJumpPoint::initialJump):
(JSC::DFG::CorrectableJumpPoint::lateJump):
(JSC::DFG::CorrectableJumpPoint::correctJump):
(JSC::DFG::CorrectableJumpPoint::getJump):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
* dfg/DFGOSRExit.cpp: Added.
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):
* dfg/DFGOSRExit.h:
* dfg/DFGOSRExitCompiler.cpp: Added.
* dfg/DFGOSRExitCompiler.h:
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
* dfg/DFGThunks.cpp: Added.
(JSC::DFG::osrExitGenerationThunkGenerator):
* dfg/DFGThunks.h: Added.
* jit/JITCode.h:
(JSC::JITCode::dataAddressAtOffset):
* runtime/JSGlobalData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd cc-bugs group to watch changes in chromium graphics
commit-queue@webkit.org [Thu, 10 Nov 2011 01:07:12 +0000 (01:07 +0000)]
Add cc-bugs group to watch changes in chromium graphics
https://bugs.webkit.org/show_bug.cgi?id=71690

Patch by Dana Jansens <danakj@chromium.org> on 2011-11-09
Reviewed by David Levin.

* Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
* Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
* Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
* Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove more platform-dependent unittests
eric@webkit.org [Thu, 10 Nov 2011 01:04:21 +0000 (01:04 +0000)]
Remove more platform-dependent unittests
https://bugs.webkit.org/show_bug.cgi?id=71971

Reviewed by Adam Barth.

Tests which only run on a couple platforms will break.
All tests should run on all platforms where possible.

* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMerge in results to the test results server even if build numbers conflict
ojan@chromium.org [Thu, 10 Nov 2011 00:49:03 +0000 (00:49 +0000)]
Merge in results to the test results server even if build numbers conflict
https://bugs.webkit.org/show_bug.cgi?id=71967

Reviewed by Tony Chang.

This was initially meant to be a sanity check that we don't
enter duplicate runs, but it turns out that we can reasonably get
in these situations when a builder is clobbered (e.g. the build
numbers start over again from 0).

* TestResultServer/model/jsonresults.py:
* TestResultServer/model/jsonresults_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofeImage referencing a primitive draws incorrectly
timothy_horton@apple.com [Thu, 10 Nov 2011 00:39:21 +0000 (00:39 +0000)]
feImage referencing a primitive draws incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71731
<rdar://problem/10408178>

Reviewed by Simon Fraser.

Don't attempt to resolve an <feImage>'s referenced element until it's used, as it
may not exist at the time the attribute is set on the <feImage>.

Don't attempt to render an <feImage> if the referenced element is of size 0x0.

Tests: svg/filters/feImage-reference-svg-primitive.svg
       svg/filters/feImage-zero-size-crash.svg

* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::parseMappedAttribute):
(WebCore::SVGFEImageElement::build):

Add a test (feImage-reference-svg-primitive) that ensures that having
an <feImage> referencing an SVG primitive which is declared after it
successfully paints the referenced object.

Add a test (feImage-zero-size-crash) to see if we crash when <feImage>
references an object with 0x0 size.

* platform/mac/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
* platform/mac/svg/filters/feImage-reference-svg-primitive-expected.txt: Added.
* svg/filters/feImage-reference-svg-primitive.svg: Added.
* svg/filters/feImage-zero-size-crash-expected.txt: Added.
* svg/filters/feImage-zero-size-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the concept of platform-dependent unittests
eric@webkit.org [Thu, 10 Nov 2011 00:24:08 +0000 (00:24 +0000)]
Remove the concept of platform-dependent unittests
https://bugs.webkit.org/show_bug.cgi?id=71963

Reviewed by Adam Barth.

These have been the source of never-ending sadness.
We'd change behavior and forget to update results in
some unittests because they were only run on certain platforms.
This change removes a large source of these platform-dependent
unittests, which was caused by the port_maker stuff.

It's possible that this change will break test-webkitpy
on some platforms, but that will be a one-time cost.
I will fix the breakage by removing the platform-dependantness
of any such broken tests.

* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
* Scripts/webkitpy/layout_tests/port/efl_unittest.py:
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
* Scripts/webkitpy/layout_tests/port/win_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove WebGLContextEvent.initEvent method
dominicc@chromium.org [Thu, 10 Nov 2011 00:11:52 +0000 (00:11 +0000)]
Remove WebGLContextEvent.initEvent method
https://bugs.webkit.org/show_bug.cgi?id=71720

Reviewed by Adam Barth.

The WebGL spec calls this method initWebGLContextEvent, but it may
adopt a constructor instead. Deleting the initEvent method for now
since it is definitely wrong and we don't want people to come to
depend on it.

No new tests--removing untested code.

* html/canvas/WebGLContextEvent.cpp:
* html/canvas/WebGLContextEvent.h:
* html/canvas/WebGLContextEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixing build breakage
mhahnenberg@apple.com [Thu, 10 Nov 2011 00:04:40 +0000 (00:04 +0000)]
Fixing build breakage

Unreviewed build fix

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoElement::boundsInWindowSpace should be Element::boundsInRootViewSpace
andersca@apple.com [Wed, 9 Nov 2011 23:59:21 +0000 (23:59 +0000)]
Element::boundsInWindowSpace should be Element::boundsInRootViewSpace
https://bugs.webkit.org/show_bug.cgi?id=71955

Reviewed by Sam Weinig.

Source/WebCore:

Element::boundsInWindowSpace is only used by WebKit2, where the window coordinate space is the
same as the root view coordinate space. This lets us get rid of another use of contentsToWindow.

* WebCore.exp.in:
* dom/Element.cpp:
(WebCore::Element::boundsInRootViewSpace):
* dom/Element.h:

Source/WebKit2:

* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::elementBounds):
Call Element::boundsInRootViewSpace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99778 268f45cc-cd09-0410-ab3c-d52691b4dbfc