WebKit-https.git
15 years agoLayoutTests:
justing [Thu, 15 Jun 2006 22:26:52 +0000 (22:26 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/deleting/pruning-after-merge-2-expected.checksum: Added.
        * editing/deleting/pruning-after-merge-2-expected.png: Added.
        * editing/deleting/pruning-after-merge-2-expected.txt: Added.
        * editing/deleting/pruning-after-merge-2.html: Added.

WebCore:

        Reviewed by harrison

        * editing/CompositeEditCommand.cpp:
        (WebCore::hasARenderedDescendant):
        (WebCore::CompositeEditCommand::prune): Ascend using the DOM
        (WebCore::CompositeEditCommand::moveParagraphs): Placeholder insertion
        during deletion is fixed, removing the fall back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdding :lang support, patch by Nicholas Shanks, review by Hyatt
jdevalk [Thu, 15 Jun 2006 21:37:13 +0000 (21:37 +0000)]
Adding :lang support, patch by Nicholas Shanks, review by Hyatt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImprove wording of first paragraph of index.html
jdevalk [Thu, 15 Jun 2006 21:09:32 +0000 (21:09 +0000)]
Improve wording of first paragraph of index.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 15 Jun 2006 20:05:00 +0000 (20:05 +0000)]
LayoutTests:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
        REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E

        * editing/execCommand/findString-2-expected.checksum: Added.
        * editing/execCommand/findString-2-expected.png: Added.
        * editing/execCommand/findString-2-expected.txt: Added.
        * editing/execCommand/findString-2.html: Added.

WebCore:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
        REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E

        * page/Frame.cpp:
        (WebCore::Frame::findString): When comparing the found range with
        what's currently selected a) build a selection with the found
        range to remove collapsed whitespace and b) compare ranges
        instead of selection objects to ignore the way that the
        current selection was made (to ignore the base and extent).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim O.
sullivan [Thu, 15 Jun 2006 17:37:44 +0000 (17:37 +0000)]
    Reviewed by Tim O.

        Fixed bug in WebKit support for computing but not highlighting rects for text matches.

        * WebView/WebView.m:
        (-[WebView rectsForTextMatches]):
        leave out empty rects, and convert rects to WebView coordinates. Since this makes a batch
        of autoreleased NSValue objects, use a local autorelease pool

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
sullivan [Thu, 15 Jun 2006 13:37:17 +0000 (13:37 +0000)]
    Reviewed by John Sullivan.

        * Plugins/WebPluginController.m:
        (-[WebPluginController _cancelOutstandingChecks]):
        add nil check before calling CFSetApplyFunction

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ddkilzer [Thu, 15 Jun 2006 11:12:18 +0000 (11:12 +0000)]
WebCore:

        Reviewed by mjs.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9382
        IDL files missing copyright/license headers

        Add Apple BSD license and copyright to IDL files.

        * ksvg2/bindings/idl/svg/GetSVGDocument.idl:
        * ksvg2/bindings/idl/svg/SVGAElement.idl:
        * ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl:
        * ksvg2/bindings/idl/svg/SVGAnimateElement.idl:
        * ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedRect.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedString.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl:
        * ksvg2/bindings/idl/svg/SVGAnimationElement.idl:
        * ksvg2/bindings/idl/svg/SVGCircleElement.idl:
        * ksvg2/bindings/idl/svg/SVGClipPathElement.idl:
        * ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl:
        * ksvg2/bindings/idl/svg/SVGCursorElement.idl:
        * ksvg2/bindings/idl/svg/SVGDOMImplementation.idl:
        * ksvg2/bindings/idl/svg/SVGDefsElement.idl:
        * ksvg2/bindings/idl/svg/SVGDescElement.idl:
        * ksvg2/bindings/idl/svg/SVGElementInstance.idl:
        * ksvg2/bindings/idl/svg/SVGElementInstanceList.idl:
        * ksvg2/bindings/idl/svg/SVGEllipseElement.idl:
        * ksvg2/bindings/idl/svg/SVGEvent.idl:
        * ksvg2/bindings/idl/svg/SVGException.idl:
        * ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl:
        * ksvg2/bindings/idl/svg/SVGFEBlendElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl:
        * ksvg2/bindings/idl/svg/SVGFECompositeElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFloodElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEImageElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEMergeElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl:
        * ksvg2/bindings/idl/svg/SVGFETileElement.idl:
        * ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl:
        * ksvg2/bindings/idl/svg/SVGFilterElement.idl:
        * ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl:
        * ksvg2/bindings/idl/svg/SVGFitToViewBox.idl:
        * ksvg2/bindings/idl/svg/SVGGElement.idl:
        * ksvg2/bindings/idl/svg/SVGGradientElement.idl:
        * ksvg2/bindings/idl/svg/SVGICCColor.idl:
        * ksvg2/bindings/idl/svg/SVGImageElement.idl:
        * ksvg2/bindings/idl/svg/SVGLangSpace.idl:
        * ksvg2/bindings/idl/svg/SVGLengthList.idl:
        * ksvg2/bindings/idl/svg/SVGLineElement.idl:
        * ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl:
        * ksvg2/bindings/idl/svg/SVGLocatable.idl:
        * ksvg2/bindings/idl/svg/SVGMarkerElement.idl:
        * ksvg2/bindings/idl/svg/SVGNumberList.idl:
        * ksvg2/bindings/idl/svg/SVGPaint.idl:
        * ksvg2/bindings/idl/svg/SVGPathElement.idl:
        * ksvg2/bindings/idl/svg/SVGPathSeg.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegArc.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegLineto.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegList.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl:
        * ksvg2/bindings/idl/svg/SVGPatternElement.idl:
        * ksvg2/bindings/idl/svg/SVGPointList.idl:
        * ksvg2/bindings/idl/svg/SVGPolygonElement.idl:
        * ksvg2/bindings/idl/svg/SVGPolylineElement.idl:
        * ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl:
        * ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl:
        * ksvg2/bindings/idl/svg/SVGRectElement.idl:
        * ksvg2/bindings/idl/svg/SVGRenderingIntent.idl:
        * ksvg2/bindings/idl/svg/SVGScriptElement.idl:
        * ksvg2/bindings/idl/svg/SVGSetElement.idl:
        * ksvg2/bindings/idl/svg/SVGStopElement.idl:
        * ksvg2/bindings/idl/svg/SVGStringList.idl:
        * ksvg2/bindings/idl/svg/SVGStylable.idl:
        * ksvg2/bindings/idl/svg/SVGStyleElement.idl:
        * ksvg2/bindings/idl/svg/SVGSwitchElement.idl:
        * ksvg2/bindings/idl/svg/SVGSymbolElement.idl:
        * ksvg2/bindings/idl/svg/SVGTSpanElement.idl:
        * ksvg2/bindings/idl/svg/SVGTests.idl:
        * ksvg2/bindings/idl/svg/SVGTextContentElement.idl:
        * ksvg2/bindings/idl/svg/SVGTextElement.idl:
        * ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl:
        * ksvg2/bindings/idl/svg/SVGTitleElement.idl:
        * ksvg2/bindings/idl/svg/SVGTransformList.idl:
        * ksvg2/bindings/idl/svg/SVGTransformable.idl:
        * ksvg2/bindings/idl/svg/SVGURIReference.idl:
        * ksvg2/bindings/idl/svg/SVGUnitTypes.idl:
        * ksvg2/bindings/idl/svg/SVGUseElement.idl:
        * ksvg2/bindings/idl/svg/SVGViewElement.idl:
        * ksvg2/bindings/idl/svg/SVGZoomAndPan.idl:
        * ksvg2/bindings/idl/svg/SVGZoomEvent.idl:
        * ksvg2/svg/SVGAnimatedLength.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 15 Jun 2006 00:12:49 +0000 (00:12 +0000)]
LayoutTests:

        Reviewed by levi

        <rdar://problem/4439248>
        REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

        * editing/pasteboard/copy-paste-bidi-expected.checksum: Added.
        * editing/pasteboard/copy-paste-bidi-expected.png: Added.
        * editing/pasteboard/copy-paste-bidi-expected.txt: Added.
        * editing/pasteboard/copy-paste-bidi.html: Added.

WebCore:

        Reviewed by levi

        <rdar://problem/4439248>
        REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

        * editing/markup.cpp:
        (WebCore::renderedText): Use plainText so that we'll pull rendered text but in DOM order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Wed, 14 Jun 2006 23:23:50 +0000 (23:23 +0000)]
LayoutTests:

        Reviewed by justin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
        TinyMCE: Implement execCommand(formatBlock, ...)

        * editing/deleting/delete-ws-fixup-002-expected.checksum:
        * editing/deleting/delete-ws-fixup-002-expected.png:
        * editing/deleting/delete-ws-fixup-002-expected.txt:
        * editing/deleting/delete-ws-fixup-002.html:
        * editing/execCommand/format-block-expected.checksum: Added.
        * editing/execCommand/format-block-expected.png: Added.
        * editing/execCommand/format-block-expected.txt: Added.
        * editing/execCommand/format-block-from-range-selection-expected.checksum: Added.
        * editing/execCommand/format-block-from-range-selection-expected.png: Added.
        * editing/execCommand/format-block-from-range-selection-expected.txt: Added.
        * editing/execCommand/format-block-from-range-selection.html: Added.
        * editing/execCommand/format-block.html: Added.

WebCore:

        Reviewed by justin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
        TinyMCE: Implement execCommand(formatBlock, ...)

        * WebCore.xcodeproj/project.pbxproj: Added FormatBlock.{h,cpp} to the project.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
        * bridge/mac/WebCoreFrameBridge.h: Added WebUndoActions
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraph): Added a preserveStyle bool.
        (WebCore::CompositeEditCommand::moveParagraphs): Ditto.  downstream() the start
        or else we'll move collapsed whitespace and uncollapse it.
        * editing/CompositeEditCommand.h:
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData):
        (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Don't update m_endingPosition
        because that's removeNode's responsibility.
        (WebCore::updatePositionForNodeRemoval): Added.
        (WebCore::DeleteSelectionCommand::removeNode): Turned removeFullySelectedNode into a virtual
        overload of removeNode so that we can update positions as we remove nodes.
        (WebCore::updatePositionForTextRemoval): Added.
        (WebCore::DeleteSelectionCommand::deleteTextFromNode):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        (WebCore::DeleteSelectionCommand::fixupWhitespace): Got rid of m_trailingWhitespaceValid
        since m_trailingWhitespace is always valid (we update it as we remove nodes).
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        (WebCore::DeleteSelectionCommand::doApply): Leading and trailing spaces should
        be fixed if they have collapsed before merging paragraphs.
        * editing/DeleteSelectionCommand.h:
        * editing/EditAction.h:
        (WebCore::):
        * editing/FormatBlockCommand.cpp: Added.
        (WebCore::FormatBlockCommand::FormatBlockCommand):
        (WebCore::FormatBlockCommand::modifyRange): Similar to InsertListCommand::modifyRange().
        (WebCore::FormatBlockCommand::doApply):
        * editing/FormatBlockCommand.h: Added.
        (WebCore::FormatBlockCommand::editingAction):
        * editing/InsertListCommand.h:
        (WebCore::InsertListCommand::editingAction):
        * editing/JSEditor.cpp:
        * editing/MergeIdenticalElementsCommand.cpp:
        (WebCore::MergeIdenticalElementsCommand::doApply):
        * editing/htmlediting.cpp:
        (WebCore::validBlockTag):
        (WebCore::createElement):
        * editing/htmlediting.h:

WebKit:

        Reviewed by justin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
        TinyMCE: Implement execCommand(formatBlock, ...)

        * English.lproj/Localizable.strings:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge nameForUndoAction:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
tomernic [Wed, 14 Jun 2006 22:59:18 +0000 (22:59 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4577988> GC: WebPluginController uses inefficient resurrecting enumeration

        * Plugins/WebPluginController.m:
        (cancelOutstandingCheck):
        (-[WebPluginController _cancelOutstandingChecks]):
        Use CFSetApplyFunction() instead of an enumerator to guard against modifications to the set while enumerating.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Wed, 14 Jun 2006 22:21:34 +0000 (22:21 +0000)]
LayoutTests:

        Test case by Anders, reviewed and tweaked by Maciej.

        - fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work

        * fast/events/window-load-capture.html: Added.

WebCore:

        Reviewed by Anders.

        - fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchWindowEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth.
ggaren [Wed, 14 Jun 2006 21:45:06 +0000 (21:45 +0000)]
    Reviewed by Beth.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9438
        Someone broke ToT: cannot build

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/runtime_root.h: Changed "Interpreter.h" to "interpreter.h"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rename RenderSlider to DeprecatedSlider, so that I can start work on
hyatt [Wed, 14 Jun 2006 21:17:46 +0000 (21:17 +0000)]
    Rename RenderSlider to DeprecatedSlider, so that I can start work on
        the new NSView-less slider.

        Reviewed by john

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::createRenderer):
        * rendering/DeprecatedSlider.cpp: Added.
        (WebCore::DeprecatedSlider::DeprecatedSlider):
        (WebCore::DeprecatedSlider::calcMinMaxWidth):
        (WebCore::DeprecatedSlider::updateFromElement):
        (WebCore::DeprecatedSlider::valueChanged):
        * rendering/DeprecatedSlider.h: Added.
        (WebCore::DeprecatedSlider::renderName):
        * rendering/RenderSlider.cpp: Removed.
        * rendering/RenderSlider.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ggaren [Wed, 14 Jun 2006 05:54:06 +0000 (05:54 +0000)]
LayoutTests:

        Test for createHTMLDocument.

        * fast/dom/implementation-createHTMLDocument-expected.txt: Added.
        * fast/dom/implementation-createHTMLDocument.html: Added.

WebCore:

        Reviewed by Maciej.

        - Fixed <rdar://problem/4562192> Creating a new DOMHTMLDocument
        appears challenging.

        - Added createHTMLDocument to Objc bindings, fixed up implementation
        to comply with the DOM 2 Candidate Recommendation in which is was defined.
        (It never made the final spec.) Also removed use of deprecatedString,
        to avoid unnecessary killing of puppies.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (-[DOMImplementation createHTMLDocument:]):
        * bindings/objc/DOMPrivate.h:
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        (WebCore::DOMImplementation::createHTMLDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed up results of the layout test I committed for 4583892,
mjs [Wed, 14 Jun 2006 05:03:16 +0000 (05:03 +0000)]
    - fixed up results of the layout test I committed for 4583892,
        they were guaranteed to fail

        * fast/events/no-window-load-expected.txt:
        * fast/events/resources/greenbox.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago RS by MacDome. Added missing results for this test.
ggaren [Wed, 14 Jun 2006 05:01:56 +0000 (05:01 +0000)]
    RS by MacDome. Added missing results for this test.

        * fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
aliceli1 [Wed, 14 Jun 2006 01:35:01 +0000 (01:35 +0000)]
    Reviewed by Adele.

        fixed <rdar://problem/4457902> HTMLSelectElement.remove() can't handle an option obj being passed to it, results in hang on http://www.ibc-solar.de/www_ibc/fst_solarmonitoring.jsp

        * bindings/js/kjs_html.cpp:
        (KJS::HTMLElementFunction::callAsFunction):
        support this by converting the argument to an options object
        before passing to remove()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Wed, 14 Jun 2006 01:33:34 +0000 (01:33 +0000)]
LayoutTests:

        Reviewed by Geoff.

        - test for <rdar://problem/4585333> Changing location for weather on yahoo.com home page redirects to another page

        * fast/events/event-listener-html-non-html-confusion-expected.txt: Added.
        * fast/events/event-listener-html-non-html-confusion.html: Added.

WebCore:

        Reviewed by Geoff.

        - fix <rdar://problem/4585333> Changing location for weather on yahoo.com home page redirects to another page

        This patch fixes a bug where the event listener cache does not distinguish
        HTML and non-HTML listeners. Incorrect behavior where stopPropagation also
        prevented default masked a case of this bug on the yahoo.com home page until
        we fixed bug 5180 on 2005-10-03.

        Test: fast/events/event-listener-html-non-html-confusion.html

        * bindings/js/kjs_window.h: Add additional listener maps for HTML event listeners.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::~Window): Go through the additional maps when clearing the window object
        pointer in event listeners.
        (KJS::Window::getJSEventListener): Look in the HTML or non-HTML map depending on the
        argument passed.
        (KJS::Window::getJSUnprotectedEventListener): Ditto.

        * bindings/js/kjs_events.cpp:
        (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Add to either the HTML
        or non-HTML map depending on the argument passed.
        (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): Remove from either the
        HTML or non-HTML map depending on whether the HTML flag is set.
        (KJS::JSEventListener::JSEventListener): More of the same.
        (KJS::JSEventListener::~JSEventListener): Ditto.
        (KJS::JSLazyEventListener::parseCode): Same thing here. In a lazy event listener there
        is not a listener at construction time, thus the code here to put the listener into a
        map needs the HTML vs. non-HTML logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Wed, 14 Jun 2006 01:25:42 +0000 (01:25 +0000)]
LayoutTests:

        Reviewed by Geoff.

        - test case for <rdar://problem/4583892> 10.4.7 regression: Hang occurs when attempting to load
        search results at mapquest.com

        * fast/events/no-window-load-expected.txt: Added.
        * fast/events/no-window-load.html: Added.

WebCore:

        Reviewed by Darin.

        <rdar://problem/4583892> 10.4.7 regression: Hang occurs when attempting to load search results at mapquest.com

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchGenericEvent): Don't allow
        "load" events to propagate up to the window. We need this quirk to
        avoid site hangs, because they depend on an old Mozilla bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
antti [Tue, 13 Jun 2006 23:19:33 +0000 (23:19 +0000)]
LayoutTests:

        Reviewed by Hyatt

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9314

        * fast/block/positioning/relative-overflow-block-expected.checksum: Added.
        * fast/block/positioning/relative-overflow-block-expected.png: Added.
        * fast/block/positioning/relative-overflow-block-expected.txt: Added.
        * fast/block/positioning/relative-overflow-block.html: Added.
        * fast/block/positioning/relative-overflow-replaced-expected.checksum: Added.
        * fast/block/positioning/relative-overflow-replaced-expected.png: Added.
        * fast/block/positioning/relative-overflow-replaced-expected.txt: Added.
        * fast/block/positioning/relative-overflow-replaced-float-expected.checksum: Added.
        * fast/block/positioning/relative-overflow-replaced-float-expected.png: Added.
        * fast/block/positioning/relative-overflow-replaced-float-expected.txt: Added.
        * fast/block/positioning/relative-overflow-replaced-float.html: Added.
        * fast/block/positioning/relative-overflow-replaced.html: Added.

WebCore:

        Reviewed by Hyatt.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9314
        Relative positioned block size doesnt update root layer size

        - take relative positioning into account in leftmost/rightmost/lowestPosition()
        - ignore zero width/height boxes in leftmost/rightmost/lowestPosition()
        - split relativePositionOffset() to x and y functions

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absolutePosition):
        (WebCore::RenderBox::relativePositionOffsetX):
        (WebCore::RenderBox::relativePositionOffsetY):
        (WebCore::RenderBox::lowestPosition):
        (WebCore::RenderBox::rightmostPosition):
        (WebCore::RenderBox::leftmostPosition):
        * rendering/RenderBox.h:
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::lowestPosition):
        (WebCore::RenderFlow::rightmostPosition):
        (WebCore::RenderFlow::leftmostPosition):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::offsetLeft):
        (WebCore::RenderObject::offsetTop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Tue, 13 Jun 2006 22:20:00 +0000 (22:20 +0000)]
WebCore:

2006-06-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Dave Hyatt.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9427
        xml-stylesheet processing instructions outside of the prolog should have no effect.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet):
        Remove todo comment.

        * dom/xml_tokenizer.cpp:
        (WebCore::XMLTokenizer::processingInstruction):
        Only check for style sheet if the root element hasn't yet been encountered.

LayoutTests:

2006-06-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Dave Hyatt.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9427

        * fast/css/resources/xml-stylesheet-pi-not-in-prolog.css: Added.
        * fast/css/xml-stylesheet-pi-not-in-prolog.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim O.
sullivan [Tue, 13 Jun 2006 22:19:46 +0000 (22:19 +0000)]
    Reviewed by Tim O.

        - fixed <rdar://problem/4498606> REGRESSION (417.8-420+): 3 missing items (but extra separators) in context
        menu in Mail message body

        * WebView/WebView.m:
        (-[WebView _menuForElement:defaultItems:]):
        Add special-case hackery to recover from this SPI -> API mismatch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Clarified my previous ChangeLog entry.
tomernic [Tue, 13 Jun 2006 21:58:14 +0000 (21:58 +0000)]
    Clarified my previous ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
tomernic [Tue, 13 Jun 2006 21:56:30 +0000 (21:56 +0000)]
    Reviewed by Anders.

        Fixed a recently-introduced assertion failure when handling 404 errors.

        * WebView/WebDataSource.m:
        (-[WebDataSource _handleFallbackContent]):
        Use the -[WebFrame _bridge] instead of -[WebDataSource _bridge].  The former is not valid until the data
        source has been committed, as is the case when the resource fails to load.  The latter is safe to call at
        any time.  This broke last night with Maciej's change to WebFrameResourceLoader.  The old code used to call
        -[WebFrame _bridge].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Tue, 13 Jun 2006 13:37:18 +0000 (13:37 +0000)]
WebCore:

2006-06-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
        REGRESSION: fix for bug 9390 broke two layout tests

        * loader/PluginDocument.cpp:
        (WebCore::PluginTokenizer::writeRawData):
        Call finished() after setting up the document structure so we'll emit onload events.

WebKit:

2006-06-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
        REGRESSION: fix for bug 9390 broke two layout tests

        * Plugins/WebPluginDatabase.h:
        (-[WebPluginDatabase isMIMETypeRegistered:]):
        Add new function isMIMETypeRegistered which returns whether a given MIME type has a
        plugin registered.

        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase init]):
        Init set of registered MIME types.

        (-[WebPluginDatabase refresh]):
        Add and remove MIME types from the set of registered MIME types when registering and unregistering
        plugin MIME types.

        (-[WebPluginDatabase dealloc]):
        Release set of registered MIME types.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
        Use isMIMETypeRegistered here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago build fix -- forgot to svn add this file
ggaren [Tue, 13 Jun 2006 06:37:21 +0000 (06:37 +0000)]
    build fix -- forgot to svn add this file

        * ForwardingHeaders/kjs/SavedBuiltins.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago build fix
ggaren [Tue, 13 Jun 2006 06:27:30 +0000 (06:27 +0000)]
    build fix

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]): Restore assignment I accidentally
        deleted in previous commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
beidson [Tue, 13 Jun 2006 06:10:56 +0000 (06:10 +0000)]
    Reviewed by Maciej.

        Fixed a bug in append(char) and append(UChar) where our intended copy-on-write semantics was ignored!

        * platform/String.cpp:
        (WebCore::String::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren [Tue, 13 Jun 2006 06:08:52 +0000 (06:08 +0000)]
JavaScriptCore:

        Reviewed by TimO, Maciej.

        - Merged InterpreterImp code into Interpreter, which implements
        all interpreter functionality now. This is part of my continuing quest
        to create an external notion of JS "execution context" that is unified and simple --
        something to replace the mix of Context, ContextImp, ExecState, Interpreter,
        InterpreterImp, and JSRun.

        All tests pass. Leaks test has not regressed from its baseline ~207 leaks
        with ~3460 leaked nodes.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/NP_jsobject.cpp:
        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]):
        * bindings/runtime_root.cpp:
        * bindings/runtime_root.h:
        * kjs/Context.cpp:
        (KJS::Context::Context):
        * kjs/ExecState.cpp: Added.
        (KJS::ExecState::lexicalInterpreter):
        * kjs/ExecState.h: Added.
        (KJS::ExecState::dynamicInterpreter):
        * kjs/SavedBuiltins.h: Added.
        * kjs/bool_object.cpp:
        (BooleanPrototype::BooleanPrototype):
        * kjs/collector.cpp:
        (KJS::Collector::collect):
        (KJS::Collector::numInterpreters):
        * kjs/context.h:
        * kjs/debugger.cpp:
        (Debugger::attach):
        (Debugger::detach):
        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        (KJS::GlobalFuncImp::callAsFunction):
        * kjs/function_object.cpp:
        (FunctionObjectImp::construct):
        * kjs/internal.cpp:
        * kjs/internal.h:
        * kjs/interpreter.cpp:
        (KJS::interpreterMap):
        (KJS::Interpreter::Interpreter):
        (KJS::Interpreter::init):
        (KJS::Interpreter::~Interpreter):
        (KJS::Interpreter::globalObject):
        (KJS::Interpreter::initGlobalObject):
        (KJS::Interpreter::globalExec):
        (KJS::Interpreter::checkSyntax):
        (KJS::Interpreter::evaluate):
        (KJS::Interpreter::builtinObject):
        (KJS::Interpreter::builtinFunction):
        (KJS::Interpreter::builtinArray):
        (KJS::Interpreter::builtinBoolean):
        (KJS::Interpreter::builtinString):
        (KJS::Interpreter::builtinNumber):
        (KJS::Interpreter::builtinDate):
        (KJS::Interpreter::builtinRegExp):
        (KJS::Interpreter::builtinError):
        (KJS::Interpreter::builtinObjectPrototype):
        (KJS::Interpreter::builtinFunctionPrototype):
        (KJS::Interpreter::builtinArrayPrototype):
        (KJS::Interpreter::builtinBooleanPrototype):
        (KJS::Interpreter::builtinStringPrototype):
        (KJS::Interpreter::builtinNumberPrototype):
        (KJS::Interpreter::builtinDatePrototype):
        (KJS::Interpreter::builtinRegExpPrototype):
        (KJS::Interpreter::builtinErrorPrototype):
        (KJS::Interpreter::builtinEvalError):
        (KJS::Interpreter::builtinRangeError):
        (KJS::Interpreter::builtinReferenceError):
        (KJS::Interpreter::builtinSyntaxError):
        (KJS::Interpreter::builtinTypeError):
        (KJS::Interpreter::builtinURIError):
        (KJS::Interpreter::builtinEvalErrorPrototype):
        (KJS::Interpreter::builtinRangeErrorPrototype):
        (KJS::Interpreter::builtinReferenceErrorPrototype):
        (KJS::Interpreter::builtinSyntaxErrorPrototype):
        (KJS::Interpreter::builtinTypeErrorPrototype):
        (KJS::Interpreter::builtinURIErrorPrototype):
        (KJS::Interpreter::mark):
        (KJS::Interpreter::interpreterWithGlobalObject):
        (KJS::Interpreter::saveBuiltins):
        (KJS::Interpreter::restoreBuiltins):
        * kjs/interpreter.h:
        (KJS::Interpreter::setCompatMode):
        (KJS::Interpreter::compatMode):
        (KJS::Interpreter::firstInterpreter):
        (KJS::Interpreter::nextInterpreter):
        (KJS::Interpreter::prevInterpreter):
        (KJS::Interpreter::debugger):
        (KJS::Interpreter::setDebugger):
        (KJS::Interpreter::setContext):
        (KJS::Interpreter::context):
        * kjs/nodes.cpp:
        (StatementNode::hitStatement):
        (RegExpNode::evaluate):
        * kjs/protect.h:

JavaScriptGlue:

        Reviewed by TimO, Maciej.

        - JSGlue part of merging InterpreterImp into Interpreter.

        Since there's now a kjs forwarding header, I moved all forwarding
        headers into a "ForwardingHeaders" directory, like in WebCore.

        * ForwardingHeaders: Added.
        * ForwardingHeaders/kjs: Added.
        * ForwardingHeaders/kjs/ExecState.h: Added.
        * ForwardingHeaders/wtf: Added.
        * JavaScriptGlue.xcodeproj/project.pbxproj:
        * config.h:
        * wtf: Removed.
        * wtf/AlwaysInline.h: Removed.
        * wtf/Assertions.h: Removed.
        * wtf/FastMalloc.h: Removed.
        * wtf/Forward.h: Removed.
        * wtf/HashCountedSet.h: Removed.
        * wtf/HashSet.h: Removed.
        * wtf/Noncopyable.h: Removed.
        * wtf/OwnArrayPtr.h: Removed.
        * wtf/OwnPtr.h: Removed.
        * wtf/PassRefPtr.h: Removed.
        * wtf/Platform.h: Removed.
        * wtf/RefPtr.h: Removed.
        * wtf/Vector.h: Removed.

WebCore:

        Reviewed by TimO, Maciej.

        - WebCore part of merging InterpreterImp into Interpreter. No test
        because there's no behavior change.

        A substantive change here is that ScriptInterpreter::mark must now chain to
        Interpreter::mark, since Interpreter needs to mark the things that
        InterpreterImp used to mark.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_window.cpp:
        (KJS::Window::put):
        * bridge/mac/WebCoreFrameBridge.mm:
        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame evaluateWebScript:]):
        * kwq/KWQPageState.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix for cocoa exception (whoops)
mjs [Tue, 13 Jun 2006 05:09:15 +0000 (05:09 +0000)]
    - fix for cocoa exception (whoops)

        * WebView/WebView.m:
        (+[WebView _generatedMIMETypeForURLScheme:]): put this back
        * WebView/WebDataSource.m:
        (+[WebDataSource _generatedMIMETypeForURLScheme:]): call WebView

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
mjs [Tue, 13 Jun 2006 03:36:10 +0000 (03:36 +0000)]
    Reviewed by Darin.

        - remove use of WebView and related from WebMainResourceLoader

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m:
        (+[WebDataSource _generatedMIMETypeForURLScheme:]):
        (+[WebDataSource _representationExistsForURLScheme:]):
        (+[WebDataSource _canShowMIMEType:]):
        (-[WebDataSource _handleFallbackContent]):
        (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebFrame.m:
        (-[WebFrame _isMainFrame]):
        * WebView/WebFrameInternal.h:
        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
        (-[WebMainResourceLoader checkContentPolicyForResponse:]):
        (-[WebMainResourceLoader loadWithRequestNow:]):
        * WebView/WebView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
beidson [Tue, 13 Jun 2006 01:04:42 +0000 (01:04 +0000)]
    Reviewed by Maciej.

        Changed String::ascii() to return a Vector<char> instead of const char*
        This allows us to use it "regularly" as the returned vector will destruct
        and not leak memory like the previous approach.
        We can now do a String.ascii().data() to get a char* buffer instead of
        String.deprecatedString().ascii().  It doesn't improve the style much but
        dumping the memory-leak issue is a plus.

        * icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open):
        (WebCore::IconDatabase::clearDatabase):
        * icon/SQLDatabase.cpp:
        (SQLDatabase::open):
        * icon/SQLStatement.cpp:
        (WebCore::SQLStatement::prepare):
        (WebCore::SQLStatement::step):
        (WebCore::SQLStatement::returnTextResults):
        (WebCore::SQLStatement::returnTextResults16):
        (WebCore::SQLStatement::returnIntResults):
        (WebCore::SQLStatement::returnInt64Results):
        (WebCore::SQLStatement::returnDoubleResults):
        In addition to the changes to the string classes, changed my database code over to the new
        preferred method.

        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::ascii):
        * platform/StringImpl.cpp:
        (WebCore::StringImpl::ascii):
        * platform/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
tomernic [Tue, 13 Jun 2006 00:27:35 +0000 (00:27 +0000)]
    Reviewed by Maciej.

        <rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _initWithPath:]):
        Renamed from -initWithPath:.  Instead of releasing/deallocating self on error, return NO.
        (-[WebNetscapePluginPackage initWithPath:]):
        Call the new -_initWithPath:.  If it returns NO, unload the plugin package before deallocating it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd selection foreground color on Win32.
hyatt [Mon, 12 Jun 2006 23:03:56 +0000 (23:03 +0000)]
Add selection foreground color on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
sullivan [Mon, 12 Jun 2006 23:02:20 +0000 (23:02 +0000)]
    Reviewed by Darin Adler.

        * page/Frame.cpp:
        (WebCore::Frame::markAllMatchesForText):
        Do a "fake" paint here so that the rectangles for the text matches will have been
        computed by the time this method returns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Levi and Tim Omernick.
beidson [Mon, 12 Jun 2006 22:43:46 +0000 (22:43 +0000)]
    Reviewed by Levi and Tim Omernick.

        -Added a skeleton sqlite3 icon database file to IconDatabase
        -Added functionality to validate and recreate this icon.db file
        -Fixed some buggys in SQLDatabase.cpp

        * icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open):
        (WebCore::IconDatabase::isValidDatabase):
        (WebCore::IconDatabase::clearDatabase):
        (WebCore::IconDatabase::recreateDatabase):
        * icon/IconDatabase.h:

        * icon/SQLStatement.cpp:
        (WebCore::SQLStatement::columnCount):
        (WebCore::SQLStatement::getColumnName):
        (WebCore::SQLStatement::getColumnName16):
        (WebCore::SQLStatement::getColumnText):
        (WebCore::SQLStatement::getColumnText16):
        (WebCore::SQLStatement::getColumnDouble):
        (WebCore::SQLStatement::getColumnInt):
        (WebCore::SQLStatement::getColumnInt64):
        (WebCore::SQLStatement::getColumnBlob):
        -Added checks to make sure we had a valid working sqlite3_statement as the sqlite3_*
        function calls weren't as error-tolerant as documentation advertised
        (maybe differences between the 3.3 docs I looked at and the 3.1.3 version installed on OSX)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix Win32 build bustage.
hyatt [Mon, 12 Jun 2006 19:53:53 +0000 (19:53 +0000)]
Fix Win32 build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ggaren [Mon, 12 Jun 2006 19:02:59 +0000 (19:02 +0000)]
    Reviewed by Maciej.

        - Have *.lut.h files #include lookup.h to eliminate surprising header
        include order dependency.

        * DerivedSources.make:
        * kjs/array_object.cpp:
        * kjs/date_object.cpp:
        * kjs/date_object.h:
        (KJS::DateProtoFunc::):
        * kjs/lexer.cpp:
        * kjs/math_object.cpp:
        * kjs/number_object.cpp:
        * kjs/regexp_object.cpp:
        * kjs/string_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Levi.
beidson [Mon, 12 Jun 2006 18:07:59 +0000 (18:07 +0000)]
    Reviewed by Levi.

        -Added SQLite helper wrappers to ease use of SQLite in the IconDatabase.
        -Changed the base IconDatabase over to this new framework.

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
            -By popular request, removed an annoying log message I'd accidentally left in

        * icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase):
        (WebCore::IconDatabase::open):
        (WebCore::IconDatabase::close):
        (WebCore::IconDatabase::~IconDatabase):
        * icon/IconDatabase.h:
        (WebCore::IconDatabase::isOpen):
            -Changed over IconDatabase from direct sqlite3_* calls to the new SQLDatabase calls

        * icon/SQLDatabase.cpp: Added.
        (SQLDatabase::SQLDatabase):
        (SQLDatabase::open):
        (SQLDatabase::close):
        (SQLDatabase::executeCommand):
        (SQLDatabase::tableExists):
        * icon/SQLDatabase.h: Added.
        (WebCore::SQLDatabase::isOpen):
        (WebCore::SQLDatabase::getPath):
        (WebCore::SQLDatabase::lastError):
        (WebCore::SQLDatabase::lastErrorMsg):
        (WebCore::SQLStatement::isPrepared):
        (WebCore::SQLStatement::lastError):
        (WebCore::SQLStatement::lastErrorMsg):
        * icon/SQLStatement.cpp: Added.
        (WebCore::SQLStatement::SQLStatement):
        (WebCore::SQLStatement::~SQLStatement):
        (WebCore::SQLStatement::prepare):
        (WebCore::SQLStatement::step):
        (WebCore::SQLStatement::finalize):
        (WebCore::SQLStatement::reset):
        (WebCore::SQLStatement::executeCommand):
        (WebCore::SQLStatement::bindBlob):
        (WebCore::SQLStatement::bindText):
        (WebCore::SQLStatement::columnCount):
        (WebCore::SQLStatement::getColumnName):
        (WebCore::SQLStatement::getColumnName16):
        (WebCore::SQLStatement::getColumnText):
        (WebCore::SQLStatement::getColumnText16):
        (WebCore::SQLStatement::getColumnDouble):
        (WebCore::SQLStatement::getColumnInt):
        (WebCore::SQLStatement::getColumnInt64):
        (WebCore::SQLStatement::getColumnBlob):
        (WebCore::SQLStatement::returnTextResults):
        (WebCore::SQLStatement::returnTextResults16):
        (WebCore::SQLStatement::returnIntResults):
        (WebCore::SQLStatement::returnInt64Results):
        (WebCore::SQLStatement::returnDoubleResults):
            -Initial checking of SQLDatabase framework

        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::String):
            -Added an explicit UChar* constructor to our string class as much of sqlite3's UTF16 handling is based on
            null-terminated UTF16 which we didn't yet support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ddkilzer [Mon, 12 Jun 2006 04:10:38 +0000 (04:10 +0000)]
WebCore:

        Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9408
        Clean build fails with "make: *** No rule to make target `SVGElementFactory.cpp', needed by `all'. Stop"

        * DerivedSources.make: Fix clean builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - another try at fixing Windows
darin [Mon, 12 Jun 2006 02:03:00 +0000 (02:03 +0000)]
    - another try at fixing Windows

        * loader/CachedResource.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::setData):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoderPrivate::decode):
        (WebCore::GIFImageDecoder::setData):
        * platform/image-decoders/gif/GIFImageDecoder.h:
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageReader::decode):
        (WebCore::JPEGImageDecoder::setData):
        * platform/image-decoders/jpeg/JPEGImageDecoder.h:
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::decode):
        (WebCore::PNGImageDecoder::setData):
        * platform/image-decoders/png/PNGImageDecoder.h:
        s/DeprecatedByteArray/Vector<char>/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Mon, 12 Jun 2006 01:37:19 +0000 (01:37 +0000)]
WebCore:

        - try to fix Windows build

        * platform/cairo/ImageCairo.cpp: (WebCore::Image::loadResource):
        Use Vector<char> instead of DeprecatedByteArray.

        * platform/win/TemporaryLinkStubs.cpp: (KWQServeSynchronousRequest):
        Don't try to return 0 from a function that returns a Vector<char>.

WebKit:

        - try to fix Windows build

        * COM/WebKitDLL.cpp: (loadResourceIntoArray): Use Vector<char> instead of
        DeprecatedByteArray.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt, tweaked quite a bit and landed by Darin.
darin [Mon, 12 Jun 2006 01:10:17 +0000 (01:10 +0000)]
    Reviewed by Hyatt, tweaked quite a bit and landed by Darin.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8039
          Remove use of DeprecatedArray in favor of new Vector class

        This removes most of the uses of DeprecatedArray and
        DeprecatedByteArray, with the exception of DeprecatedCString.

        No test cases added because there is no change in
        functionality.

        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::data):
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::bufferData):
        (WebCore::CachedImage::data):
        (WebCore::CachedImage::checkNotify):
        (WebCore::CachedImage::shouldStopAnimation):
        * loader/CachedImage.h:
        * loader/CachedObject.cpp:
        (WebCore::CachedObject::bufferData):
        (WebCore::CachedObject::setExpireDate):
        * loader/CachedObject.h:
        (WebCore::CachedObject::setCharset):
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::data):
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        (WebCore::CachedXBLDocument::data):
        (WebCore::CachedXBLDocument::checkNotify):
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::data):
        * loader/CachedXSLStyleSheet.h:
        * loader/Request.cpp:
        (WebCore::Request::Request):
        (WebCore::Request::~Request):
        * loader/Request.h:
        (WebCore::Request::buffer):
        (WebCore::Request::cachedObject):
        (WebCore::Request::docLoader):
        (WebCore::Request::isIncremental):
        (WebCore::Request::setIsIncremental):
        (WebCore::Request::isMultipart):
        (WebCore::Request::setIsMultipart):
        * loader/loader.cpp:
        (WebCore::crossDomain):
        (WebCore::Loader::Loader):
        (WebCore::Loader::load):
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::receivedAllData):
        (WebCore::Loader::receivedResponse):
        (WebCore::Loader::receivedData):
        (WebCore::Loader::numRequests):
        (WebCore::Loader::cancelRequests):
        (WebCore::Loader::removeBackgroundDecodingRequest):
        (WebCore::Loader::jobForRequest):
        * platform/Image.cpp:
        (WebCore::Image::setData):
        * platform/Image.h:
        (WebCore::Image::dataBuffer):

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::init):
        (WebCore::CSSStyleSelector::matchRules):
        (WebCore::CSSStyleSelector::matchRulesForList):
        (WebCore::CSSStyleSelector::sortMatchedRules):
        (WebCore::CSSStyleSelector::initForStyleResolve):
        (WebCore::CSSStyleSelector::createStyleForElement):
        (WebCore::CSSStyleSelector::createPseudoStyleForElement):
        * css/cssstyleselector.h:
        (WebCore::CSSStyleSelector::addMatchedRule):
        (WebCore::CSSStyleSelector::addMatchedDeclaration):
        * dom/xml_tokenizer.cpp:
        (WebCore::OffsetBuffer::OffsetBuffer):
        (WebCore::openFunc):
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::index):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::selectedIndex):
        (WebCore::HTMLSelectElement::setSelectedIndex):
        (WebCore::HTMLSelectElement::length):
        (WebCore::HTMLSelectElement::remove):
        (WebCore::HTMLSelectElement::value):
        (WebCore::HTMLSelectElement::setValue):
        (WebCore::HTMLSelectElement::state):
        (WebCore::HTMLSelectElement::restoreState):
        (WebCore::HTMLSelectElement::appendFormData):
        (WebCore::HTMLSelectElement::optionToListIndex):
        (WebCore::HTMLSelectElement::listToOptionIndex):
        (WebCore::HTMLSelectElement::recalcListItems):
        (WebCore::HTMLSelectElement::reset):
        (WebCore::HTMLSelectElement::notifyOptionSelected):
        * html/HTMLSelectElement.h:
        (WebCore::HTMLSelectElement::listItems):
        * kwq/KWQLoader.h:
        * kwq/KWQLoader.mm:
        (KWQServeSynchronousRequest):
        * kwq/KWQTextStream.cpp:
        (QTextStream::operator<<):
        * kwq/KWQTextStream.h:
        * loader/FormData.cpp:
        (WebCore::FormData::flatten):
        (WebCore::FormData::flattenToString):
        * loader/FormData.h:
        (WebCore::FormDataElement::FormDataElement):
        * platform/DeprecatedString.cpp:
        * platform/DeprecatedString.h:
        * platform/IntPointArray.cpp: Removed.
        * platform/IntPointArray.h: Removed.
        * platform/TextEncoding.cpp:
        (WebCore::TextEncoding::toUnicode):
        * platform/TextEncoding.h:
        * platform/cairo/pixman/src/pixregion.c:
        * platform/cg/PathCG.cpp:
        (WebCore::Path::Path):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBorder):
        * rendering/RenderTable.h:
        (WebCore::RenderTable::colToEffCol):
        (WebCore::RenderTable::effColToCol):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::ensureRows):
        (WebCore::RenderTableSection::addCell):
        (WebCore::RenderTableSection::setCellWidths):
        * rendering/RenderTableSection.h:
        * rendering/bidi.cpp:
        (WebCore::addMidpoint):
        (WebCore::RenderBlock::layoutInlineChildren):
        * rendering/render_form.cpp:
        (WebCore::RenderSelect::updateFromElement):
        (WebCore::RenderSelect::layout):
        (WebCore::RenderSelect::valueChanged):
        (WebCore::RenderSelect::selectionChanged):
        (WebCore::RenderSelect::updateSelection):
        * rendering/table_layout.cpp:
        (WebCore::FixedTableLayout::layout):
        * rendering/table_layout.h:
        * xml/XSLTProcessor.cpp:
        (WebCore::docLoaderFunc):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::processSyncLoadResults):
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ddkilzer [Sun, 11 Jun 2006 23:58:53 +0000 (23:58 +0000)]
WebCore:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9394
        Fix no-SVG build

        * DerivedSources.make: Removed tabs. Create empty SVGElementFactory.cpp on no-svg build.
        * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Added #if SVG_SUPPORT/#endif.
        * ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Ditto.
        * ksvg2/bindings/idl/svg/SVGAElement.idl: Add "Conditional=SVG" to all interfaces.
        * ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimateElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedRect.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedString.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimationElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGCircleElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGClipPathElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGCursorElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGDOMImplementation.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGDefsElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGDescElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGElementInstance.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGElementInstanceList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGEllipseElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGEvent.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGException.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEBlendElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFECompositeElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEFloodElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEImageElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEMergeElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFETileElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFilterElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFitToViewBox.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGGElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGGradientElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGICCColor.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGImageElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGLangSpace.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGLengthList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGLineElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGLocatable.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGMarkerElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGNumberList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPaint.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSeg.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegArc.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegLineto.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPatternElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPointList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPolygonElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPolylineElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGRectElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGRenderingIntent.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGScriptElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGSetElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGStopElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGStringList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGStylable.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGStyleElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGSwitchElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGSymbolElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTSpanElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTests.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTextContentElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTextElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTitleElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTransformList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTransformable.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGURIReference.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGUnitTypes.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGUseElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGViewElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGZoomAndPan.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGZoomEvent.idl: Ditto.
        * ksvg2/svg/SVGAngle.idl: Ditto.
        * ksvg2/svg/SVGAnimatedLength.idl: Ditto.
        * ksvg2/svg/SVGColor.idl: Ditto.
        * ksvg2/svg/SVGDocument.idl: Ditto.
        * ksvg2/svg/SVGElement.idl: Ditto.
        * ksvg2/svg/SVGEvent.idl: Ditto.
        * ksvg2/svg/SVGLength.idl: Ditto.
        * ksvg2/svg/SVGMatrix.idl: Ditto.
        * ksvg2/svg/SVGNumber.idl: Ditto.
        * ksvg2/svg/SVGPoint.idl: Ditto.
        * ksvg2/svg/SVGRect.idl: Ditto.
        * ksvg2/svg/SVGSVGElement.idl: Ditto.
        * ksvg2/svg/SVGTransform.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKitTools:
ddkilzer [Sun, 11 Jun 2006 23:49:28 +0000 (23:49 +0000)]
WebKitTools:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9395
        Make prepare-ChangeLog faster

        * Scripts/prepare-ChangeLog: Use "svn diff" instead of "svn stat" to find changed files,
        then save the diff output for reuse.  Keep a status variable if changes are made to
        LayoutTests so "svn diff LayoutTests" doesn't have to be run to check for changes when
        WebCore is updated.  Added -h|--help command-line switch and help message.  Move test
        for no changed files closer to the beginning of the program.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemoves a hardcoded path I had added for testing.
thatcher [Sun, 11 Jun 2006 20:18:15 +0000 (20:18 +0000)]
Removes a hardcoded path I had added for testing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim H.
thatcher [Sun, 11 Jun 2006 20:10:35 +0000 (20:10 +0000)]
    Reviewed by Tim H.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8672
          Red outline from web inspector reappears after inspector is closed

        * WebInspector/WebInspector.m:
        (-[NSWindow windowWillClose:]): Added a call to setWebFrame to avoid further
        load progress notifications.
        (-[NSWindow setWebFrame:]): Changed to resign the WebView's hostWindow rather
        than its window for close notifications, to avoid resigning from all windows' close
        notifications (including the inspector window's) when the WebView is in a hidden tab.
        Also changed to prevent highlighting the initial focused node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Sun, 11 Jun 2006 19:49:17 +0000 (19:49 +0000)]
WebCore:

2006-06-11  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
        Move full-frame plugins to WebCore

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Add PluginDocument

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::redirectDataToPlugin):
        Call the bridge.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        Add redirectDataToPlugin which is used to redirect incoming data
        to a plugin.

        * bridge/mac/WebCoreViewFactory.h:
        Add pluginSupportsMIMEType which returns whether any plugins support a given MIME type.

        * dom/DOMImplementation.cpp:
        * dom/DOMImplementation.h:
        Get rid of createTextDocument and just create a text document explicitly when needed.

        * dom/Document.h:
        (WebCore::Document::isPluginDocument):
        * loader/PluginDocument.cpp: Added.
        (WebCore::PluginTokenizer::PluginTokenizer):
        (WebCore::PluginTokenizer::wantsRawData):
        (WebCore::PluginTokenizer::write):
        (WebCore::PluginTokenizer::createDocumentStructure):
        (WebCore::PluginTokenizer::writeRawData):
        (WebCore::PluginTokenizer::stopParsing):
        (WebCore::PluginTokenizer::finish):
        (WebCore::PluginTokenizer::isWaitingForScripts):
        (WebCore::PluginDocument::PluginDocument):
        (WebCore::PluginDocument::createTokenizer):
        * loader/PluginDocument.h: Added.
        (WebCore::PluginDocument::isPluginDocument):
        Add PluginDocument.

        * page/Frame.cpp:
        (WebCore::Frame::begin):
        Possibly create a plugin document.

        * page/Frame.h:
        (WebCore::Frame::redirectDataToPlugin):
        Add declaration.

        * platform/PlugInInfoStore.h:
        * platform/mac/PlugInInfoStoreMac.mm:
        (WebCore::PlugInInfoStore::supportsMIMEType):
        Ask WebCoreViewFactory if the MIME type is supported.

WebKit:

2006-06-11  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
        Move full-frame plugins to WebCore

        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream instance]):
        Add instance method which returns the plugin instance.

        * Plugins/WebBasePluginPackage.h:
        Add WebPluginManualLoader protocol

        * Plugins/WebNetscapePluginDocumentView.h: Removed.
        * Plugins/WebNetscapePluginDocumentView.m: Removed.

        * Plugins/WebNetscapePluginEmbeddedView.h:
        * Plugins/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:]):
        (-[WebNetscapePluginEmbeddedView dealloc]):
        (-[WebNetscapePluginEmbeddedView didStart]):
        (-[WebNetscapePluginEmbeddedView pluginView:receivedResponse:]):
        (-[WebNetscapePluginEmbeddedView pluginView:receivedData:]):
        (-[WebNetscapePluginEmbeddedView pluginView:receivedError:]):
        (-[WebNetscapePluginEmbeddedView pluginViewFinishedLoading:]):
        (-[WebNetscapePluginEmbeddedView redeliverStream]):
        Make WebNetscapePluginEmbeddedView support the WebPluginManualLoader protocol. It creates a plugin stream and feeds the
        data manually. Much of this code has been copied from WebNetscapePluginRepresentation.

        * Plugins/WebNetscapePluginRepresentation.h: Removed.
        * Plugins/WebNetscapePluginRepresentation.m: Removed.

        * Plugins/WebPluginController.h:
        * Plugins/WebPluginController.m:
        (-[WebPluginController pluginView:receivedResponse:]):
        (-[WebPluginController pluginView:receivedData:]):
        (-[WebPluginController pluginView:receivedError:]):
        (-[WebPluginController pluginViewFinishedLoading:]):
        Make WebPluginController support the WebPluginManualLoader protocol so it can feed data manually to WebKit plugins.

        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase refresh]):
        Use WebHTMLView and WebHTMLRepresentation when registering/unregistering plug-in MIME types.

        * Plugins/WebPluginDocumentView.h: Removed.
        * Plugins/WebPluginDocumentView.m: Removed.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
        (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
        Add loadManually argument.

        (-[WebFrameBridge redirectDataToPlugin:]):
        Call down to the HTML representation.

        (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
        Pass NO to loadManually.

        (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
        Explicitly check if the MIME type is supported by a plug-in instead of checking the view class.

        * WebCoreSupport/WebViewFactory.m:
        (-[WebViewFactory pluginSupportsMIMEType:]):
        New function which returns whether any plugins support a given MIME type.

        * WebKit.xcodeproj/project.pbxproj:
        Update for removed files.

        * WebView/WebFrame.m:
        (-[WebFrame _reloadForPluginChanges]):
        Remove view type checks.

        (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
        (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
        Remove FIXME comments.

        * WebView/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation _redirectDataToManualLoader:forPluginView:]):
        New function which redirects incoming data to a manual loader.

        (-[WebHTMLRepresentation receivedData:withDataSource:]):
        (-[WebHTMLRepresentation receivedError:withDataSource:]):
        (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
        Optionally redirect incoming data.

        * WebView/WebHTMLRepresentationPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ddkilzer [Sun, 11 Jun 2006 04:07:11 +0000 (04:07 +0000)]
LayoutTests:

        Patch by mitzpettel.  Reviewed by hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9334
          Incomplete repaint when changing block from non-positioned to positioned

        * fast/repaint/static-to-positioned-expected.checksum: Added.
        * fast/repaint/static-to-positioned-expected.png: Added.
        * fast/repaint/static-to-positioned-expected.txt: Added.
        * fast/repaint/static-to-positioned.html: Added.

WebCore:

        Patch by mitzpettel.  Reviewed by hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9334
          Incomplete repaint when changing block from non-positioned to positioned

        Test: fast/repaint/static-to-positioned.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle): If changing from static to positioned, repaint
        as static.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ddkilzer [Sun, 11 Jun 2006 03:46:22 +0000 (03:46 +0000)]
LayoutTests:

        Reviewed by hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9193
          REGRESSION: setting an opacity on an element with an outline causes the outline to disappear completely

        - test repainting of layer children's outlines that extend beyond the layer

        * fast/layers: Added.
        * fast/layers/opacity-outline-expected.checksum: Added.
        * fast/layers/opacity-outline-expected.png: Added.
        * fast/layers/opacity-outline-expected.txt: Added.
        * fast/layers/opacity-outline.html: Added.
        * fast/repaint/layer-child-outline-expected.checksum: Added.
        * fast/repaint/layer-child-outline-expected.png: Added.
        * fast/repaint/layer-child-outline-expected.txt: Added.
        * fast/repaint/layer-child-outline.html: Added.

WebCore:

        Reviewed by hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9193
          REGRESSION: setting an opacity on an element with an outline causes the outline to disappear completely

        Test: fast/layers/opacity-outline.html

        - fix repainting of layer children's outlines that extend beyond the layer

        Test: fast/repaint/layer-child-outline.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::intersectsDamageRect): Account for outlines.
        (WebCore::RenderLayer::absoluteBoundingBox): Ditto.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::maximalOutlineSize): Changed to return the view's maximal
        outline size rather than 0 for PaintPhaseChildOutlines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-06-10 Steve Falkenburg <sfalken@apple.com>
sfalken [Sun, 11 Jun 2006 02:34:24 +0000 (02:34 +0000)]
2006-06-10  Steve Falkenburg  <sfalken@apple.com>

        Fix build break

        * platform/cairo/GraphicsContextCairo.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        (GraphicsContext::scale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren [Sat, 10 Jun 2006 16:09:27 +0000 (16:09 +0000)]
JavaScriptCore:

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8515
        Linux porting compile bug

        Fix by Mike Emmel, Reviewed by Darin.

        * JavaScriptCoreSources.bkl:
        * jscore.bkl:
        * wtf/Platform.h:

WebCore:

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8515
        Linux porting compile bug

        Fix by Mike Emmel, Reviewed by Darin.

        * Projects/gdk/webcore-gdk.bkl:
        * WebCoreSources.bkl:
        * css/maketokenizer:
        * html/HTMLCanvasElement.cpp:
        * html/HTMLImageElement.h:
        * icon/IconDatabase.cpp:
        * make-generated-sources.sh:
        * page/Frame.h:
        * page/FramePrivate.h:
        * platform/Cursor.h:
        * platform/FontData.h:
        (WebCore::FontData::getGlyphIndex):
        * platform/GlyphBuffer.h:
        (WebCore::GlyphBuffer::glyphAt):
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        * platform/GraphicsContext.h:
        * platform/PlatformKeyboardEvent.h:
        * platform/PlatformMouseEvent.h:
        * platform/PlatformWheelEvent.h:
        * platform/ScrollView.h:
        * platform/TransferJob.h:
        (WebCore::TransferJob::getInternal):
        * platform/TransferJobInternal.h:
        (WebCore::TransferJobInternal::TransferJobInternal):
        * platform/Widget.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::roundToDevicePixels):
        * webcore-base.bkl:
        * xpath/impl/XPathValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Omernick and Dave Hyatt.
sullivan [Sat, 10 Jun 2006 13:42:45 +0000 (13:42 +0000)]
    Reviewed by Tim Omernick and Dave Hyatt.

        WebKit support for computing but not highlighting rects for text matches.

        * WebView/WebHTMLViewPrivate.h:
        added markedTextMatchesAreHighlighted/setMarkedTextMatchesAreHighlighted and
        rectsForTextMatches, and renamed related methods for clarity/consistency
        * WebView/WebHTMLView.m:
        (-[WebHTMLView markAllMatchesForText:caseSensitive:]):
        renamed, calls similarly-renamed method
        (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
        new method, calls through to bridge
        (-[WebHTMLView markedTextMatchesAreHighlighted]):
        ditto
        (-[WebHTMLView unmarkAllTextMatches]):
        renamed
        (-[WebHTMLView rectsForTextMatches]):
        new method, calls through to bridge

        * WebView/WebViewPrivate.h:
        added rectsForTextMatches, renamed other methods (and added highlight: parameter)
        * WebView/WebView.m:
        (-[WebView markAllMatchesForText:caseSensitive:highlight:]):
        renamed for clarity/consistency, and now has highlight: parameter, which is passed down
        (-[WebView unmarkAllTextMatches]):
        renamed for clarity/consistency, and calls similarly-renamed method lower down. diff got
        confused with the end of this and the end of the next method.
        (-[WebView rectsForTextMatches]):
        new method, calls through to WebHTMLView as related methods currently do

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Omernick and Dave Hyatt.
sullivan [Sat, 10 Jun 2006 13:42:23 +0000 (13:42 +0000)]
    Reviewed by Tim Omernick and Dave Hyatt.

        WebCore support for computing but not highlighting rects for text matches.

        * dom/Document.h:
        added setRenderedRectForMarker() and renderedRectsForMarkers(), and redefined
        MarkerMap to be a hashtable of node -> (pair of vectors), one vector of markers
        and one vector of rects

        * dom/Document.cpp:
        (placeholderRectForMarker()):
        new function, returns a recognizable degenerate rect used until a real rect has been set
        (WebCore::Document::addMarker):
        Reworked for new MarkerMap data structure; now adds parallel placeholder rect
        along with marker
        (WebCore::Document::copyMarkers):
        Reworked for new MarkerMap data structure
        (WebCore::Document::removeMarkers):
        Reworked for new MarkerMap data structure; now removed corresponding rect along
        with marker
        (WebCore::Document::markersForNode):
        Reworked for new MarkerMap data structure
        (WebCore::Document::renderedRectsForMarkers):
        New method, returns an array of all non-placeholder rects for the given marker type
        (WebCore::Document::repaintMarkers):
        Reworked for new MarkerMap data structure
        (WebCore::Document::setRenderedRectForMarker):
        New method, sets the rendered rect for a given marker
        (WebCore::Document::shiftMarkers):
        Reworked for new MarkerMap data structure; resets rendered rects to placeholders.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        removed markedTextMatchesAreHighlighted guard; we always want to call paintTextMatchMarker
        now, but sometimes we will end up only computing the rect, not actually highlighting it.
        (Maybe some names should be improved here?)
        (WebCore::InlineTextBox::paintTextMatchMarker):
        Reorganized to move all the code that actually draws into a block that's guarded by
        markedTextMatchesAreHighlighted. The rest of the code computes where the highlight will
        go, and now we always use that computation in order to call setRenderedRectForMarker.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge rectsForTextMatches]):
        New method, returns an array of NSValues representing NSRects. Gets them
        from Document::renderedRectsForMarkers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago <http://bugzilla.opendarwin.org/show_bug.cgi?id=9384>
sullivan [Sat, 10 Jun 2006 13:38:38 +0000 (13:38 +0000)]
    <bugzilla.opendarwin.org/show_bug.cgi?id=9384>
        WebView's initWithCoder: method does not set useBackForwardList
        correctly

        Reviewed by John Sullivan.

        * WebView/WebView.m:
        (-[WebView initWithCoder:]):
        Make sure that the function variable useBackForwardList is correctly
        set, so that the copy in the _private ivar is set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-06-10 Mitz Pettel <opendarwin.org@mitzpettel.com>
ap [Sat, 10 Jun 2006 10:24:10 +0000 (10:24 +0000)]
2006-06-10  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed and landed by ap.

        - make DumpRenderTree build

        * DumpRenderTree/DumpRenderTree.m:
        (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Changed _updateFocusState to _updateActiveState
        (-[WaitUntilDoneDelegate webViewFocus:]): Ditto.
        (-[LayoutTestController setWindowIsKey:]): Ditto.
        (-[LayoutTestController setMainFrameIsFirstResponder:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-06-10 Anders Carlsson <acarlsson@apple.com>
andersca [Sat, 10 Jun 2006 09:59:44 +0000 (09:59 +0000)]
2006-06-10  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Eric.

        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLElement::put):
        Call WebCore::JSHTMLElement::put so that autogenerated setters will work
        for HTMLElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix -- I think :).
ggaren [Sat, 10 Jun 2006 04:52:43 +0000 (04:52 +0000)]
    Build fix -- I think :).

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/context.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Build fix after last JSC check-in (oops!)
ggaren [Sat, 10 Jun 2006 04:34:00 +0000 (04:34 +0000)]
    - Build fix after last JSC check-in (oops!)

        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame scopeChain]):
        (-[WebCoreScriptCallFrame functionName]):
        (-[WebCoreScriptCallFrame evaluateWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric (yay!).
ggaren [Sat, 10 Jun 2006 03:57:13 +0000 (03:57 +0000)]
    Reviewed by Eric (yay!).

        - Removed Context wrapper for ContextImp, renamed ContextImp to Context,
        split Context into its own file -- Context.cpp -- renamed _var to m_var,
        change ' *' to '* '.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/Context.cpp: Added.
        (KJS::Context::Context):
        (KJS::Context::~Context):
        (KJS::Context::mark):
        * kjs/context.h:
        (KJS::Context::scopeChain):
        (KJS::Context::variableObject):
        (KJS::Context::setVariableObject):
        (KJS::Context::thisValue):
        (KJS::Context::callingContext):
        (KJS::Context::activationObject):
        (KJS::Context::currentBody):
        (KJS::Context::function):
        (KJS::Context::arguments):
        (KJS::Context::pushScope):
        (KJS::Context::seenLabels):
        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        (KJS::FunctionImp::processParameters):
        (KJS::FunctionImp::argumentsGetter):
        (KJS::GlobalFuncImp::callAsFunction):
        * kjs/internal.cpp:
        (KJS::InterpreterImp::evaluate):
        * kjs/internal.h:
        (KJS::InterpreterImp::setContext):
        (KJS::InterpreterImp::context):
        * kjs/interpreter.cpp:
        * kjs/interpreter.h:
        (KJS::ExecState::context):
        (KJS::ExecState::ExecState):
        * kjs/nodes.cpp:
        (currentSourceId):
        (currentSourceURL):
        (ThisNode::evaluate):
        (ResolveNode::evaluate):
        (FunctionCallResolveNode::evaluate):
        (PostfixResolveNode::evaluate):
        (DeleteResolveNode::evaluate):
        (TypeOfResolveNode::evaluate):
        (PrefixResolveNode::evaluate):
        (AssignResolveNode::evaluate):
        (VarDeclNode::evaluate):
        (VarDeclNode::processVarDecls):
        (DoWhileNode::execute):
        (WhileNode::execute):
        (ForNode::execute):
        (ForInNode::execute):
        (ContinueNode::execute):
        (BreakNode::execute):
        (ReturnNode::execute):
        (WithNode::execute):
        (SwitchNode::execute):
        (LabelNode::execute):
        (TryNode::execute):
        (FuncDeclNode::processFuncDecl):
        (FuncExprNode::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@14798 268f45cc-cd09-0410...
justing [Sat, 10 Jun 2006 03:09:09 +0000 (03:09 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix win32 build bustage.
hyatt [Sat, 10 Jun 2006 00:01:07 +0000 (00:01 +0000)]
Fix win32 build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rename updateFocusState to updateActiveState.
hyatt [Fri, 9 Jun 2006 23:37:58 +0000 (23:37 +0000)]
    Rename updateFocusState to updateActiveState.

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _updateActiveState]):
        (-[NSArray viewDidMoveToWindow]):
        (-[NSArray windowDidBecomeKey:]):
        (-[NSArray windowDidResignKey:]):
        (-[NSArray becomeFirstResponder]):
        (-[NSArray resignFirstResponder]):
        (-[WebHTMLView _formControlIsBecomingFirstResponder:]):
        (-[WebHTMLView _formControlIsResigningFirstResponder:]):
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rename m_isFocused on the frame to m_isActive, since it isn't really
hyatt [Fri, 9 Jun 2006 23:26:57 +0000 (23:26 +0000)]
    Rename m_isFocused on the frame to m_isActive, since it isn't really
        about focus but is instead about whether or not the top-level window is
        active.

        Pull code that was incorrectly factored into Mac-only code out of FrameMac
        and back up into Frame.

        Reviewed by andersca

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        * page/Frame.cpp:
        (WebCore::Frame::setFocusNodeIfNeeded):
        (WebCore::Frame::isActive):
        (WebCore::Frame::setIsActive):
        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix Win32 build bustage.
hyatt [Fri, 9 Jun 2006 23:07:42 +0000 (23:07 +0000)]
Fix Win32 build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemoves some control characters that snuck in.
thatcher [Fri, 9 Jun 2006 21:25:34 +0000 (21:25 +0000)]
Removes some control characters that snuck in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
hyatt [Fri, 9 Jun 2006 20:20:45 +0000 (20:20 +0000)]
WebCore:

        Rework selection coloring.  Rename displaysWithFocusAttributes
        to isActive.  Move the white-blending code onto the Color API to make
        it more convenient to mutate colors for selection blending.  Eliminate all
        the selection state from the GraphicsContext and move it to the RenderTheme.
        Implement both Win32 and Mac theme selection colors.

        Reviewed by sfalken

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::setIsActive):
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge drawRect:]):
        (-[WebCoreFrameBridge setIsActive:]):
        (-[WebCoreFrameBridge selectionColor]):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::checkOneSelector):
        * page/Frame.cpp:
        (WebCore::Frame::isActive):
        (WebCore::Frame::setIsActive):
        * page/Frame.h:
        * platform/Color.cpp:
        (WebCore::blend):
        (WebCore::Color::blendWithWhite):
        * platform/Color.h:
        (WebCore::Color::hasAlpha):
        * platform/GraphicsContext.cpp:
        (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
        * platform/GraphicsContext.h:
        * platform/mac/GraphicsContextMac.mm:
        * platform/win/TemporaryLinkStubs.cpp:
        (GraphicsContext::endTransparencyLayer):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintSelection):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::fillHorizontalSelectionGap):
        (WebCore::RenderBlock::fillVerticalSelectionGap):
        (WebCore::RenderBlock::fillLeftSelectionGap):
        (WebCore::RenderBlock::fillRightSelectionGap):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paint):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderListMarker.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::selectionColor):
        * rendering/RenderObject.h:
        * rendering/RenderReplaced.cpp:
        * rendering/RenderReplaced.h:
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::activeSelectionColor):
        (WebCore::RenderTheme::inactiveSelectionColor):
        (WebCore::RenderTheme::platformActiveSelectionColor):
        (WebCore::RenderTheme::platformInactiveSelectionColor):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::platformActiveSelectionColor):
        (WebCore::RenderThemeMac::platformInactiveSelectionColor):
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::platformActiveSelectionColor):
        (WebCore::RenderThemeWin::platformInactiveSelectionColor):
        * rendering/RenderThemeWin.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):

WebKit:

        Rename displaysWithFocusAttributes to isActive.

        Reviewed by sfalken

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.m:
        (-[WebHTMLView _updateFocusState]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Fri, 9 Jun 2006 19:14:21 +0000 (19:14 +0000)]
LayoutTests:

        Reviewed by levi

        <rdar://problem/4549980>
        REGRESSION: "Find Again" can get stuck when searching for string with a trailing space

        * editing/execCommand/findString-expected.checksum: Added.
        * editing/execCommand/findString-expected.png: Added.
        * editing/execCommand/findString-expected.txt: Added.
        * editing/execCommand/findString.html: Added.

WebCore:

        Reviewed by levi

        <rdar://problem/4549980>
        REGRESSION: "Find Again" can get stuck when searching for string with a trailing space

        * bridge/mac/FrameMac.h: Moved findString to Frame.
        * bridge/mac/FrameMac.mm: Ditto.
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:]):
        Convert the NSString to a String.
        * editing/JSEditor.cpp: Added execCommand(FindString, ...)
        * editing/Selection.cpp: Added a constructor for Ranges
        (WebCore::Selection::Selection):
        * editing/Selection.h:
        * page/Frame.cpp:
        (WebCore::Frame::findString): Moved from FrameMac.  Compare a selection created
        using the found range with the current selection in case the current selection is
        the found range minus some collapsed whitespace on the edges.
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin, landed by Geoff.
ggaren [Fri, 9 Jun 2006 19:06:06 +0000 (19:06 +0000)]
    Reviewed by Darin, landed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9350
        Use pathcmp() when sorting paths in svn-create-patch

        * Scripts/run-webkit-tests: Fixed splitpath() to use File::Basename subroutines instead of regex.
        * Scripts/svn-create-patch: Copied numericcmp(), pathcmp() and splitpath() from run-webkit-tests.
        Changed sort() functions to use pathcmp().  Added subroutine prototypes.  Added -h command-line
        switch and printUsage() subroutine.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-06-09 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 9 Jun 2006 18:40:55 +0000 (18:40 +0000)]
2006-06-09  Steve Falkenburg  <sfalken@apple.com>

        Fix build break

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * css/MediaQueryEvaluator.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        (GraphicsContext::addRoundedRectClip):
        (GraphicsContext::addInnerRoundedRectClip):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt. Tweaked by Maciej. Tweaks reviewed by Beth.
bdakin [Fri, 9 Jun 2006 17:09:08 +0000 (17:09 +0000)]
    Reviewed by Hyatt. Tweaked by Maciej. Tweaks reviewed by Beth.
        Landed by Beth.

        CSS3 Media Queries implementation.
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4127>

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_css.cpp:
        (KJS::DOMMediaList::put):
        (KJS::KJS::DOMMediaListProtoFunc::callAsFunction):
        * bindings/objc/DOMCSS.mm:
        (-[DOMMediaList setMediaText:]):
        (-[DOMMediaList deleteMedium:]):
        (-[DOMMediaList appendMedium:]):
        * css/CSSGrammar.y:
        * css/MediaFeatureNames.cpp: Added.
        (WebCore::MediaFeatureNames::init):
        * css/MediaFeatureNames.h: Added.
        * css/MediaList.cpp:
        (WebCore::MediaList::MediaList):
        (WebCore::MediaList::~MediaList):
        (WebCore::parseMediaDescriptor):
        (WebCore::MediaList::deleteMedium):
        (WebCore::MediaList::mediaText):
        (WebCore::MediaList::setMediaText):
        (WebCore::MediaList::item):
        (WebCore::MediaList::appendMedium):
        (WebCore::MediaList::appendMediaQuery):
        * css/MediaList.h:
        (WebCore::MediaList::MediaList):
        (WebCore::MediaList::length):
        (WebCore::MediaList::mediaQueries):
        * css/MediaQuery.cpp: Added.
        (WebCore::MediaQuery::MediaQuery):
        (WebCore::MediaQuery::~MediaQuery):
        (WebCore::MediaQuery::operator==):
        (WebCore::MediaQuery::cssText):
        * css/MediaQuery.h: Added.
        (WebCore::MediaQuery::):
        (WebCore::MediaQuery::restrictor):
        (WebCore::MediaQuery::expressions):
        (WebCore::MediaQuery::mediaType):
        (WebCore::MediaQuery::append):
        * css/MediaQueryEvaluator.cpp: Added.
        (WebCore::):
        (WebCore::MediaQueryEvaluator):
        (WebCore::MediaQueryEvaluator::~MediaQueryEvaluator):
        (WebCore::MediaQueryEvaluator::mediaTypeMatch):
        (WebCore::applyRestrictor):
        (WebCore::MediaQueryEvaluator::eval):
        (WebCore::parseAspectRatio):
        (WebCore::cmpvalue):
        (WebCore::numberValue):
        (WebCore::colorMediaFeatureEval):
        (WebCore::monochromeMediaFeatureEval):
        (WebCore::device_aspect_ratioMediaFeatureEval):
        (WebCore::gridMediaFeatureEval):
        (WebCore::device_heightMediaFeatureEval):
        (WebCore::device_widthMediaFeatureEval):
        (WebCore::heightMediaFeatureEval):
        (WebCore::widthMediaFeatureEval):
        (WebCore::min_colorMediaFeatureEval):
        (WebCore::max_colorMediaFeatureEval):
        (WebCore::min_monochromeMediaFeatureEval):
        (WebCore::max_monochromeMediaFeatureEval):
        (WebCore::min_device_aspect_ratioMediaFeatureEval):
        (WebCore::max_device_aspect_ratioMediaFeatureEval):
        (WebCore::min_heightMediaFeatureEval):
        (WebCore::max_heightMediaFeatureEval):
        (WebCore::min_widthMediaFeatureEval):
        (WebCore::max_widthMediaFeatureEval):
        (WebCore::min_device_heightMediaFeatureEval):
        (WebCore::max_device_heightMediaFeatureEval):
        (WebCore::min_device_widthMediaFeatureEval):
        (WebCore::max_device_widthMediaFeatureEval):
        (WebCore::createFunctionMap):
        * css/MediaQueryEvaluator.h: Added.
        * css/MediaQueryExp.cpp: Added.
        (WebCore::MediaQueryExp::MediaQueryExp):
        (WebCore::MediaQueryExp::~MediaQueryExp):
        * css/MediaQueryExp.h: Added.
        (WebCore::MediaQueryExp::mediaFeature):
        (WebCore::MediaQueryExp::value):
        (WebCore::MediaQueryExp::operator==):
        * css/StyleSheet.cpp:
        (WebCore::StyleSheet::setMedia):
        * css/cssparser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParser::setupParser):
        (WebCore::CSSParser::parseMediaQuery):
        (WebCore::CSSParser::createFloatingMediaQueryExp):
        (WebCore::CSSParser::sinkFloatingMediaQueryExp):
        (WebCore::CSSParser::createFloatingMediaQueryExpList):
        (WebCore::CSSParser::sinkFloatingMediaQueryExpList):
        (WebCore::CSSParser::createFloatingMediaQuery):
        (WebCore::CSSParser::sinkFloatingMediaQuery):
        * css/cssparser.h:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::init):
        (WebCore::CSSStyleSelector::~CSSStyleSelector):
        (WebCore::CSSStyleSelector::loadDefaultStyle):
        (WebCore::CSSStyleSelector::matchUARules):
        (WebCore::CSSStyleSelector::styleForElement):
        (WebCore::CSSStyleSelector::pseudoStyleForElement):
        (WebCore::CSSStyleSelector::updateFont):
        (WebCore::CSSStyleSelector::cacheBorderAndBackground):
        (WebCore::CSSStyleSelector::styleRulesForElement):
        (WebCore::CSSRuleSet::addRulesFromSheet):
        * css/cssstyleselector.h:
        * css/maketokenizer:
        * css/tokenizer.flex:
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createCSSStyleSheet):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        (WebCore::HTMLLinkElement::setStyleSheet):
        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::childrenChanged):
        * ksvg2/svg/SVGDOMImplementation.cpp:
        (SVGDOMImplementation::createCSSStyleSheet):
        * ksvg2/svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::childrenChanged):
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        * platform/Screen.h:
        * platform/mac/ScreenMac.mm:
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoTweaked ChangeLog
justing [Fri, 9 Jun 2006 06:14:29 +0000 (06:14 +0000)]
Tweaked ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Fri, 9 Jun 2006 04:57:51 +0000 (04:57 +0000)]
LayoutTests:

        Reviewed by levi

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
        Implement execCommand(Insert{Un}OrderedList)

        Added:
        * editing/execCommand/create-list-from-range-selection-expected.checksum: Added.
        * editing/execCommand/create-list-from-range-selection-expected.png: Added.
        * editing/execCommand/create-list-from-range-selection-expected.txt: Added.
        * editing/execCommand/create-list-from-range-selection.html: Added.
        * editing/execCommand/insert-list-and-stitch-expected.checksum: Added.
        * editing/execCommand/insert-list-and-stitch-expected.png: Added.
        * editing/execCommand/insert-list-and-stitch-expected.txt: Added.
        * editing/execCommand/insert-list-and-stitch.html: Added.
        * editing/execCommand/insert-list-with-id-expected.checksum: Added.
        * editing/execCommand/insert-list-with-id-expected.png: Added.
        * editing/execCommand/insert-list-with-id-expected.txt: Added.
        * editing/execCommand/insert-list-with-id.html: Added.
        * editing/execCommand/remove-list-from-range-selection-expected.checksum: Added.
        * editing/execCommand/remove-list-from-range-selection-expected.png: Added.
        * editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
        * editing/execCommand/remove-list-from-range-selection.html: Added.
        * editing/execCommand/remove-list-items-expected.checksum: Added.
        * editing/execCommand/remove-list-items-expected.png: Added.
        * editing/execCommand/remove-list-items-expected.txt: Added.
        * editing/execCommand/remove-list-items.html: Added.
        * editing/execCommand/switch-list-type-expected.checksum: Added.
        * editing/execCommand/switch-list-type-expected.png: Added.
        * editing/execCommand/switch-list-type-expected.txt: Added.
        * editing/execCommand/switch-list-type.html: Added.

        Fixes:
        * editing/pasteboard/drag-drop-modifies-page-expected.txt:
        * editing/pasteboard/paste-list-001-expected.txt:
        * editing/selection/drag-to-contenteditable-iframe-expected.checksum:
        * editing/selection/drag-to-contenteditable-iframe-expected.png:
        * editing/selection/drag-to-contenteditable-iframe-expected.txt:
        * editing/style/block-style-005-expected.txt:
        * fast/text/textIteratorNilRenderer-expected.checksum:
        * fast/text/textIteratorNilRenderer-expected.png:
        * fast/text/textIteratorNilRenderer-expected.txt:
        * editing/deleting/delete-line-016-expected.checksum:
        * editing/deleting/delete-line-016-expected.png:
        * editing/deleting/delete-line-016-expected.txt:

WebCore:

        Reviewed by levi

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
        Implement execCommand(Insert{Un}OrderedList)

        * WebCore.xcodeproj/project.pbxproj: Added InsertListCommand.{h,cpp} to the project.
        * dom/Position.cpp:
        (WebCore::hasRenderedNonAnonymousDescendantsWithHeight):
        Added. A block with height is only a candidate if this is false.  This should fix the problems
        getting carets into empty blocks.
        (WebCore::Position::inRenderedContent):
        * editing/AppendNodeCommand.cpp:
        (WebCore::AppendNodeCommand::doApply):
        * editing/CompositeEditCommand.cpp:
        (WebCore::hasARenderedDescendant):
        (WebCore::CompositeEditCommand::prune): A node can have DOM descendants that are rendered, yet
        have no rendered descendants.  Fixed the pruning rule to avoid removing a node like this.
        (WebCore::CompositeEditCommand::mergeIdenticalElements): Put the two elements next to
        each other if they aren't already, as a convenience.
        (WebCore::CompositeEditCommand::moveParagraph): Added code to preserve the current selection.
        (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
        * editing/CompositeEditCommand.h:
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializeStartEnd): Expansion for special elements should
        continue to happen until it is no longer possible.
        (WebCore::DeleteSelectionCommand::handleGeneralDelete): The code to adjust the start node
        wouldn't always avoid removing the start block.
        * editing/InsertListCommand.cpp: Added.
        (WebCore::InsertListCommand::fixOrphanedListChild): Puts a list item that isn't inside a list
        into a list.
        (WebCore::InsertListCommand::InsertListCommand):
        (WebCore::InsertListCommand::modifyRange):
        (WebCore::InsertListCommand::doApply):
        * editing/InsertListCommand.h: Added.
        (WebCore::InsertListCommand::):
        * editing/InsertNodeBeforeCommand.cpp:
        (WebCore::InsertNodeBeforeCommand::doApply):
        * editing/InsertParagraphSeparatorCommand.cpp:
        * editing/JSEditor.cpp:
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::advance): Don't handle a node if the end of the range used to create the
        iterator ends at the start of that node.
        used to create the iterator.
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::next):
        (WebCore::VisiblePosition::previous):
        * editing/VisiblePosition.h:
        Added a parameter to next/previous to prevent them from going outside the current editable region.
        * editing/htmlediting.cpp:
        (WebCore::highestAncestor):
        (WebCore::enclosingList):
        (WebCore::enclosingListChild):
        (WebCore::outermostEnclosingList):
        (WebCore::createListItemElement):
        * editing/htmlediting.h:
        * page/Frame.cpp:
        (WebCore::Frame::selectionListState): Added.
        * page/Frame.h:

WebKit:

        Reviewed by levi

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
        Implement execCommand(Insert{Un}OrderedList)

        * WebView/WebFrame.m:
        (-[WebFrame _findFrameWithSelection]): Removed an assertion
        that we only have one frame with a selection.
        * WebView/WebView.m:
        (-[WebView selectedFrame]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
thatcher [Fri, 9 Jun 2006 01:06:36 +0000 (01:06 +0000)]
    Reviewed by Darin.

        Include our own copies of the BSD and LGPL licenses.

        * coding/bsd-license.html: Added.
        * coding/lgpl-license.html: Added.
        * nav.inc: link to our copies of the licenses

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
harrison [Thu, 8 Jun 2006 22:10:47 +0000 (22:10 +0000)]
LayoutTests:

        Reviewed by Geoff and John.

        <rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12)

        * fast/dom/setPrimitiveValue-expected.checksum: Added.
        * fast/dom/setPrimitiveValue-expected.png: Added.
        * fast/dom/setPrimitiveValue-expected.txt: Added.
        * fast/dom/setPrimitiveValue.html: Added.

WebCore:

        Reviewed by Geoff and John.

        <rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12)

        Problem was the primitive value was getting reset to a generic state before the parameter
        check that relies on that state.

        Test: fast/dom/setPrimitiveValue.html

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::setFloatValue):
        (WebCore::CSSPrimitiveValue::setStringValue):
        Move parameter checks ahead of call to cleanup().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoadded tests for Range.isPointInRange and Range.comparePoint
aliceli1 [Thu, 8 Jun 2006 21:38:46 +0000 (21:38 +0000)]
added tests for Range.isPointInRange and Range.comparePoint

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Justin.
aliceli1 [Thu, 8 Jun 2006 21:35:11 +0000 (21:35 +0000)]
    Reviewed by Justin.

        - fixed <rdar://problem/4578115> support Range.isPointInRange
        - fixed <rdar://problem/4578123> support Range.comparePoint

        * dom/Range.cpp:
        (WebCore::Range::isPointInRange):
        added implementation
        (WebCore::Range::comparePoint):
        added implementation
        * dom/Range.h:
        added prototypes
        * dom/Range.idl:
        added bindings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix.
thatcher [Thu, 8 Jun 2006 21:20:34 +0000 (21:20 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin and John.
thatcher [Thu, 8 Jun 2006 21:05:16 +0000 (21:05 +0000)]
    Reviewed by Darin and John.

        <rdar://problem/3600734> API: please add a way to turn vertical scrollbar
        always on (for Mail, to avoid reflow when typing)

        Adds new methods to lock the scrolling mode on WebDynamicScrollBarsView.
        Locking the scroll mode prevents WebCore from changing it as needed.
        Also adds an SPI on WebView that will lock the "always on" mode
        for each scroller.

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDynamicScrollBarsView.h:
        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView setAllowsScrolling:]):
        (-[WebDynamicScrollBarsView allowsScrolling]):
        (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
        (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]):
        (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]):
        (-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
        (-[WebDynamicScrollBarsView setScrollingMode:]):
        (-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
        (-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
        (-[WebDynamicScrollBarsView setScrollingModesLocked:]):
        (-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
        (-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
        * WebView/WebView.m:
        (-[WebView setAlwaysShowVerticalScroller:]):
        (-[WebView alwaysShowVerticalScroller]):
        (-[WebView setAlwaysShowHorizontalScroller:]):
        (-[WebView alwaysShowHorizontalScroller]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Thu, 8 Jun 2006 16:43:24 +0000 (16:43 +0000)]
WebCore:

        Reviewed by Justin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8616
          REGRESSION: TinyMCE: Crash on Undo

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:allowShadowContent:]):
        Changed to call nodeInfoAtPoint directly.
        (-[WebCoreFrameBridge _visiblePositionForPoint:]): Changed to call nodeInfoAtPoint directly.
        Also added code to convert coordinates so it works for points that are in nodes in subframes.

        * page/Frame.cpp:
        (WebCore::Frame::setMark): Added assertions to catch if we attempt to set selection
        endpoints in another document.
        (WebCore::Frame::setSelection): Ditto.

WebKit:

        Reviewed by Justin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8616
          REGRESSION: TinyMCE: Crash on Undo

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _topHTMLView]): Added.
        (-[WebHTMLView _isTopHTMLView]): Added.
        (-[WebHTMLView _insideAnotherHTMLView]): Changed to use _topHTMLView.
        (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
        Forward to the top HTML view, so that only the top view ever starts a dragging operation.
        Change dragging code to not assume that the dragged node is in the current view's document.
        Added checks that the node is an element in a couple places and coordinate conversions.
        (-[WebHTMLView _mayStartDragAtEventLocation:]): Forward to the top HTML view.
        (-[NSArray addMouseMovedObserver]): Change to do nothing when the dataSource field is 0,
        since we now use the dataSource field to get to the WebView.
        (-[NSArray removeMouseMovedObserver]): Added a comment.
        (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]):
        Forward to the top HTML view.
        (-[NSArray draggingSourceOperationMaskForLocal:]): Assert that it's the top HTML view.
        (-[NSArray draggedImage:movedTo:]): Ditto.
        (-[NSArray draggedImage:endedAt:operation:]): Ditto.
        (-[NSArray namesOfPromisedFilesDroppedAtDestination:]): Ditto.
        (-[NSArray _canProcessDragWithDraggingInfo:]): Ditto.
        (-[NSArray _isMoveDrag]): Ditto.
        (-[NSArray draggingUpdatedWithDraggingInfo:actionMask:]): Ditto.
        (-[NSArray draggingCancelledWithDraggingInfo:]): Ditto.
        (-[NSArray concludeDragForDraggingInfo:actionMask:]): Ditto. Also added code to work
        with the appropriate bridge when receiving a drag. This fixes the problem where the
        top level frame got a selection intended for the inner frame; the source of the bug.
        (-[NSArray elementAtPoint:allowShadowContent:]): Added code to convert the coordinates
        so this works properly when returning an element from an inner frame.
        (-[NSArray setDataSource:]): Added a call to addMouseMovedObserver, needed now that
        addMouseMovedObserver won't do anything if called when dataSource is nil.
        (-[WebHTMLView _delegateDragSourceActionMask]): Forward to the top HTML view.

        * WebView/WebView.m:
        (-[WebViewPrivate dealloc]): Removed code to release dragCaretBridge since that field
        is now gone.
        (-[WebView moveDragCaretToPoint:]): Always call the main frame's bridge, since the
        drag caret is now a page-level item. Later we'll move it to the page bridge.
        (-[WebView removeDragCaret]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdded change log entry that I apparently forgot.
darin [Thu, 8 Jun 2006 16:36:35 +0000 (16:36 +0000)]
Added change log entry that I apparently forgot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 8 Jun 2006 04:04:38 +0000 (04:04 +0000)]
LayoutTests:

        Reviewed by levi

        * editing/deleting/delete-4038408-fix-expected.txt:
        * editing/input/attributed-substring-from-range-lines-expected.txt:
        * editing/inserting/insert-3654864-fix-expected.txt:
        * editing/inserting/insert-3659587-fix-expected.txt:
        * editing/inserting/insert-3775316-fix-expected.txt:
        * editing/inserting/insert-at-end-01-expected.txt:
        * editing/inserting/insert-at-end-02-expected.txt:
        * editing/inserting/insert-br-001-expected.txt:
        * editing/inserting/insert-br-005-expected.txt:

WebCore:

        Reviewed by levi

        Fixed some comments and removed an unused variable.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::removeBlockPlaceholder):
        Don't remove a br if it isn't at the start of a block, since
        it isn't really a "block placeholder".
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData):
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        (WebCore::DeleteSelectionCommand::doApply):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
        * editing/htmlediting.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add support for custom highlighting to WebKit.
hyatt [Thu, 8 Jun 2006 01:43:52 +0000 (01:43 +0000)]
    Add support for custom highlighting to WebKit.

        Reviewed by justin

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:]):
        * WebView/WebHTMLView.m:
        (-[WebHTMLView _highlighterForType:]):
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add support for custom highlighting. This is all ifdefed to be Mac-only.
hyatt [Thu, 8 Jun 2006 01:41:55 +0000 (01:41 +0000)]
    Add support for custom highlighting.  This is all ifdefed to be Mac-only.

        Reviewed by justin

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::paintCustomHighlight):
        * bridge/mac/WebCoreFrameBridge.h:
        * platform/mac/ClipboardMac.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintCustomHighlight):
        * rendering/InlineTextBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele [Thu, 8 Jun 2006 01:25:48 +0000 (01:25 +0000)]
WebCore:

        Reviewed by Hyatt

        Added support for cross-platform resize property.

        * platform/PlatformMouseEvent.h: Removed isMouseButtonDown, since we
        already cache this info when we handle mouse down and mouse up.
        * platform/mac/MouseEventMac.mm: ditto.
        * platform/win/TemporaryLinkStubs.cpp: ditto.

        * page/Frame.cpp:
        (WebCore::Frame::autoscrollTimerFired): Use d->m_bMousePressed instead of isMouseButtonDown.
        * page/FrameView.cpp:
        (WebCore::FrameView::handleMouseMoveEvent): Passes event to layer resize method.
        (WebCore::FrameView::mousePressed): Added.
        * page/FrameView.h: Added mousePressed.

        * rendering/RenderTheme.h: Removed paintResizeControl.
        Since its not dependent on the theme, the layer can just paint this.
        * rendering/RenderTheme.cpp: ditto.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer): Initializes m_resizeCornerImage.
        (WebCore::RenderLayer::~RenderLayer): Deletes m_resizeCornerImage.
        (WebCore::RenderLayer::resize): Uses passed in event instead of creating a new one.
        (WebCore::RenderLayer::paintResizeControl): Now loads and paints the resize image.
        * rendering/RenderLayer.h: Added m_resizeCornerImage.  Important to have one per-layer for when we allow
        more customization.

        * platform/cairo/ImageCairo.cpp:
        (WebCore::Image::loadResource): Loads image resources.

WebKit:

        Reviewed by Hyatt.

        Added resources for missingImage and textAreaResizeCorner.

        * COM/WebKitDLL.cpp:
        (loadResourceIntoArray): Added. Returns a DeprecatedByteArray with the resource's data.
        * WebKit.vcproj/WebKit.rc: Added missing image and resize pngs as resources.
        * WebKit.vcproj/WebKit.vcproj: Added pngs.
        * WebKit.vcproj/missingImage.png: Added.
        * WebKit.vcproj/resource.h: Added entries for pngs.
        * WebKit.vcproj/textAreaResizeCorner.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add SPI for setting and removing custom highlighters.
hyatt [Thu, 8 Jun 2006 00:18:42 +0000 (00:18 +0000)]
    Add SPI for setting and removing custom highlighters.

        Reviewed by Tim H

        * WebView/WebHTMLView.m:
        (-[WebTextCompleteController dealloc]):
        (-[WebHTMLView _setHighlighter:ofType:]):
        (-[WebHTMLView _removeHighlighterOfType:]):
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add support for a new property for custom highlighting. This patch just
hyatt [Wed, 7 Jun 2006 23:08:40 +0000 (23:08 +0000)]
    Add support for a new property for custom highlighting.  This patch just
        adds support for the parsing of the property.  It doesn't do anything yet.

        Reviewed by beth

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSPropertyNames.in:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/render_style.cpp:
        (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData):
        (WebCore::StyleCSS3InheritedData::operator==):
        (WebCore::RenderStyle::diff):
        * rendering/render_style.h:
        (WebCore::RenderStyle::highlight):
        (WebCore::RenderStyle::setHighlight):
        (WebCore::RenderStyle::initialHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Removed API directory I prematurely/accidentally added.
ggaren [Wed, 7 Jun 2006 22:59:45 +0000 (22:59 +0000)]
    Removed API directory I prematurely/accidentally added.

        * API: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix suggested by Rob Buis. Reviewed by Darin.
darin [Wed, 7 Jun 2006 16:33:49 +0000 (16:33 +0000)]
    Fix suggested by Rob Buis. Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9341
          REGRESSION: Repro crash caused by style="font:bold"

        Test: fast/css/font-shorthand-weight-only.html

        * css/cssparser.cpp: (WebCore::CSSParser::parseFont): Revert part of the change
        made to fix bug 5564.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Wed, 7 Jun 2006 16:29:33 +0000 (16:29 +0000)]
LayoutTests:

        Reviewed by Hyatt, tweaked by Mitz.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9122
          REGRESSION: Incorrect vertical position for text fields in a "display: table" block

        * fast/table/text-field-baseline-expected.checksum: Added.
        * fast/table/text-field-baseline-expected.png: Added.
        * fast/table/text-field-baseline-expected.txt: Added.
        * fast/table/text-field-baseline.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9122
          REGRESSION: Incorrect vertical position for text fields in a "display: table" block

        Test: fast/table/text-field-baseline.html

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::baselinePosition): Do not descend into replaced objects, just
        use their baseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Wed, 7 Jun 2006 16:26:49 +0000 (16:26 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - pixel test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4334
          REGRESSION: Flickering when css-hover should change opacity on floating elements

        * fast/block/float/nopaint-after-layer-destruction-expected.checksum: Added.
        * fast/block/float/nopaint-after-layer-destruction-expected.png: Added.
        * fast/block/float/nopaint-after-layer-destruction-expected.txt: Added.
        * fast/block/float/nopaint-after-layer-destruction.html: Added.

WebCore:

        Reviewed by Hyatt (concept) and Darin (some coding details).

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4334
          REGRESSION: Flickering when css-hover should change opacity on floating elements

        Pixel test: fast/block/float/nopaint-after-layer-destruction.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::setPaintsFloatingObject): Added. Changes the noPaint flag
        in the block's FloatingObject for the given float and calls setChildNeedsLayout.
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::blockThatPaintsFloat): Added this helper function.
        (WebCore::RenderBox::setStyle): Added. Calls to setPaintsFloatingObject when a float
        gains or loses its layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKitTools:
ddkilzer [Wed, 7 Jun 2006 03:14:35 +0000 (03:14 +0000)]
WebKitTools:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9322
        Teach svn-create-patch to sort its output

        * Scripts/svn-create-patch: Clean up perl code.  Sort patch output alphabetically
        by text files first, then by binary files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Wed, 7 Jun 2006 03:13:43 +0000 (03:13 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - repaint test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9121
          REGRESSION: [Incremental Repaint] DHTML movement test failures

        * fast/repaint/containing-block-position-change-expected.checksum: Added.
        * fast/repaint/containing-block-position-change-expected.png: Added.
        * fast/repaint/containing-block-position-change-expected.txt: Added.
        * fast/repaint/containing-block-position-change.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9121
          REGRESSION: [Incremental Repaint] DHTML movement test failures

        Test (repaint): fast/repaint/containing-block-position-change.html

        * manual-tests/containing-block-position-chage.html: Added.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock): Unrelated change: fixed typo from
        the RenderCanvas to RenderView rename.
        (WebCore::RenderBlock::removePositionedObject): Added a return immediately
        after removing the object.
        (WebCore::RenderBlock::removePositionedObjects): Added.
        * rendering/RenderBlock.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle): Added code to remove absolutely positioned
        descendants from the positioned objects list of their current containing block
        when they are going to have a new one as a result of this block's position
        property changing.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::removePositionedObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * fast/repaint/table-extra-bottom-grow.html: Removed unneeded line of code.
darin [Wed, 7 Jun 2006 03:12:53 +0000 (03:12 +0000)]
    * fast/repaint/table-extra-bottom-grow.html: Removed unneeded line of code.

        * fast/repaint/table-extra-bottom-grow-expected.png: Regenerated.
        * fast/repaint/table-extra-bottom-grow-expected.checksum: Regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Wed, 7 Jun 2006 00:09:37 +0000 (00:09 +0000)]
LayoutTests:

        Reviewed by levi

        Added to demonstrate fixes:
        * editing/pasteboard/merge-after-delete-expected.checksum: Added.
        * editing/pasteboard/merge-after-delete-expected.png: Added.
        * editing/pasteboard/merge-after-delete-expected.txt: Added.
        * editing/pasteboard/merge-after-delete.html: Added.
        * editing/inserting/line-break-expected.checksum: Added.
        * editing/inserting/line-break-expected.png: Added.
        * editing/inserting/line-break-expected.txt: Added.
        * editing/inserting/line-break.html: Added.
        * editing/inserting/multiple-lines-selected-expected.checksum: Added.
        * editing/inserting/multiple-lines-selected-expected.png: Added.
        * editing/inserting/multiple-lines-selected-expected.txt: Added.
        * editing/inserting/multiple-lines-selected.html: Added.

        Fixed:
        * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * editing/deleting/delete-3775172-fix-expected.txt:
        * editing/deleting/delete-3928305-fix-expected.txt:
        * editing/deleting/delete-3959464-fix-expected.checksum:
        * editing/deleting/delete-3959464-fix-expected.png:
        * editing/deleting/delete-3959464-fix-expected.txt:
        * editing/deleting/delete-4038408-fix-expected.checksum:
        * editing/deleting/delete-4038408-fix-expected.png:
        * editing/deleting/delete-4038408-fix-expected.txt:
        * editing/deleting/delete-4038408-fix.html:
        * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
        * editing/deleting/delete-block-contents-001-expected.txt:
        * editing/deleting/delete-block-contents-002-expected.txt:
        * editing/deleting/delete-block-contents-003-expected.txt:
        * editing/deleting/delete-br-011-expected.checksum:
        * editing/deleting/delete-br-011-expected.png:
        * editing/deleting/delete-br-011-expected.txt:
        * editing/deleting/delete-image-004-expected.txt:
        * editing/deleting/delete-line-010-expected.txt:
        * editing/deleting/delete-line-015-expected.txt:
        * editing/deleting/delete-select-all-001-expected.checksum:
        * editing/deleting/delete-select-all-001-expected.png:
        * editing/deleting/delete-select-all-001-expected.txt:
        * editing/deleting/delete-select-all-002-expected.txt:
        * editing/deleting/delete-select-all-003-expected.checksum:
        * editing/deleting/delete-select-all-003-expected.png:
        * editing/deleting/delete-select-all-003-expected.txt:
        * editing/execCommand/insertImage-expected.checksum:
        * editing/execCommand/insertImage-expected.png:
        * editing/input/attributed-substring-from-range-lines-expected.txt:
        * editing/input/text-input-controller-expected.txt:
        * editing/inserting/insert-3654864-fix-expected.txt:
        * editing/inserting/insert-3659587-fix-expected.txt:
        * editing/inserting/insert-3775316-fix-expected.txt:
        * editing/inserting/insert-after-delete-001-expected.txt:
        * editing/inserting/insert-at-end-01-expected.txt:
        * editing/inserting/insert-at-end-02-expected.txt:
        * editing/inserting/insert-br-001-expected.txt:
        * editing/inserting/insert-br-005-expected.txt:
        * editing/pasteboard/4076267-3-expected.txt:
        * editing/pasteboard/4076267-expected.txt:
        * editing/pasteboard/drag-drop-modifies-page-expected.txt:
        * editing/pasteboard/paste-4035648-fix-expected.txt:
        * editing/pasteboard/paste-4039777-fix-expected.checksum:
        * editing/pasteboard/paste-4039777-fix-expected.png:
        * editing/pasteboard/paste-4039777-fix-expected.txt:
        * editing/pasteboard/paste-match-style-001-expected.txt:
        * editing/pasteboard/paste-match-style-002-expected.txt:
        * editing/pasteboard/smart-paste-006-expected.txt:
        * editing/pasteboard/smart-paste-007-expected.txt:
        * editing/selection/drag-to-contenteditable-iframe-expected.txt:
        * editing/style/block-style-005-expected.txt:
        * editing/style/typing-style-002-expected.txt:
        * editing/unsupported-content/list-delete-001-expected.checksum:
        * editing/unsupported-content/list-delete-001-expected.png:
        * editing/unsupported-content/list-delete-001-expected.txt:
        * editing/unsupported-content/list-delete-002-expected.checksum:
        * editing/unsupported-content/list-delete-002-expected.png:
        * editing/unsupported-content/list-delete-002-expected.txt:
        * editing/unsupported-content/table-delete-001-expected.checksum:
        * editing/unsupported-content/table-delete-001-expected.png:
        * editing/unsupported-content/table-delete-001-expected.txt:
        * editing/unsupported-content/table-delete-003-expected.checksum:
        * editing/unsupported-content/table-delete-003-expected.png:
        * editing/unsupported-content/table-delete-003-expected.txt:
        * fast/text/attributed-substring-from-range.html:

WebCore:

        Reviewed by levi

        * dom/Node.cpp:
        (WebCore::Node::firstDescendant): Added.
        * dom/Node.h:
        * dom/Range.cpp: Added a constructor that takes in Positions.
        (WebCore::Range::Range):
        * dom/Range.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertNodeAt):
        Let this function insert children into empty containers.
        Calls canHaveChildrenForEditing.
        (WebCore::CompositeEditCommand::appendNode): Assert that the parent canHaveChildrenForEditing.
        (WebCore::CompositeEditCommand::moveParagraph): Tell ReplaceSelectionCommand to select the
        replacement so that moveParagraph's callers have a valid destination after the move.
        * editing/CompositeEditCommand.h: Moved removeFullySelectedNode to DeleteSelectionCommand,
        made deleteTextFromNode virtual so that DeleteSelectionCommand can update it's endingPosition.
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
        Removed m_startNode, used a local variable.
        (WebCore::DeleteSelectionCommand::initializeStartEnd): Fixed special element expansion.
        (WebCore::DeleteSelectionCommand::initializePositionData): Compute the endingPosition up
        front and keep track of it as nodes and text are removed.
        (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Removed use of m_startNode.
        (WebCore::DeleteSelectionCommand::removeFullySelectedNode): Moved from CompositeEditCommand.
        Update m_endingPosition as we remove nodes.
        (WebCore::DeleteSelectionCommand::deleteTextFromNode):
        Update m_endingPosition as we delete text.
        (WebCore::DeleteSelectionCommand::handleGeneralDelete): Retain the start block.  Cleaned up.
        (WebCore::DeleteSelectionCommand::mergeParagraphs): Recompute m_endingPosition since moveParagraph
        clobbers the old one.
        (WebCore::DeleteSelectionCommand::doApply): Fixed the logic for placeholder insertion after
        deletion. Make the placeholder decision before we do special element expansion.
        * editing/DeleteSelectionCommand.h:
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply): Fixed a bug where an extra br was inserted and cleaned
        up the code.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply): Deletion of the current selection should do
        a merge (added a testcase).
        * editing/RebalanceWhitespaceCommand.cpp:
        (WebCore::RebalanceWhitespaceCommand::doUnapply): Remove/insert in a way that will trigger a layout.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Ditto.
        Merge even when the incoming fragment has interchange newlines (added a testcase).
        Merge when the selection being pasted into starts at the start of a block because not
        doing so would leave one or more hanging empty blocks.
        (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
        Rebalance whitespace using rebalanceWhitespaceAt because rebalanceWhitespace requires
        a selection, and a selection can't be created until whitespace has been rebalanced.
        * editing/htmlediting.cpp:
        (WebCore::canHaveChildrenForEditing): Added.
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
bdakin [Wed, 7 Jun 2006 00:03:02 +0000 (00:03 +0000)]
    Reviewed by Maciej.

        Fix for <rdar://problem/4570475> Dashboard regions do not scale for
        non-1.0 scale factors.

        No test cases added since this only affects non-1.0 resolution
        scale factors.

        * platform/FloatRect.cpp:
        (WebCore::FloatRect::scale): Added new function that scales a
        rect's origin and size by a given factor.
        * platform/FloatRect.h:
        * platform/IntRect.cpp:
        (WebCore::IntRect::scale): Same as above.
        * platform/IntRect.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::addDashboardRegions): After the bounds and
        clip rects on the Dashboard region have been calculated, get the
        user space scale factor, and if it is not 1.0, scale the rects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
sullivan [Tue, 6 Jun 2006 22:58:33 +0000 (22:58 +0000)]
    Reviewed by Darin Adler.

        - fixed <rdar://problem/4566087> REGRESSION (420+): Crash occurs while completing a find again query at
        http://www.apple.com/ (RenderObject::repaint(bool))

        This wasn't a new problem in the code, but the recent use of DocumentMarkers for find results brought
        it to the surface.

        * dom/Document.h:
        Use a RefPtr<Node> instead of a Node* in MarkerMap, so the node will be retained

        * dom/Document.cpp:
        (WebCore::Document::removeMarkers):
        Add a .get() to compensate for using RefPtr. Also, only repaint if this node actually had a marker
        removed.
        (WebCore::Document::repaintMarkers):
        Add a .get() to compensate for using RefPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Justin.
adele [Tue, 6 Jun 2006 22:28:48 +0000 (22:28 +0000)]
    Reviewed by Justin.

        * COM/WebView.cpp:
        (WebView::keyPress): Added case for VK_RETURN.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Tue, 6 Jun 2006 18:26:12 +0000 (18:26 +0000)]
WebCore:

2006-06-06  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
        clientWidth/clientHeight on document element in strict mode should return visible frame size

        * dom/Element.cpp:
        (WebCore::Element::clientWidth):
        (WebCore::Element::clientHeight):
        If we're the document element, and in strict mode, return the visible size of the frame.

LayoutTests:

2006-06-06  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
        clientWidth/clientHeight on document element in strict mode should return visible frame size

        * fast/dom/client-width-height-expected.txt: Added.
        * fast/dom/client-width-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Tue, 6 Jun 2006 17:55:00 +0000 (17:55 +0000)]
WebCore:

2006-06-06  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by John.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge containsPlugins]):
        * page/Frame.cpp:
        (WebCore::Frame::containsPlugins):
        * page/Frame.h:
        Add containsPlugins function which returns whether a frame contains plugins
        or not.

WebKit:

2006-06-06  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by John.

        * WebView/WebFrame.m:
        (-[WebFrame _reloadForPluginChanges]):
        Don't traverse the view hierarchy looking for plugin views. Instead, just
        ask the frame whether it contains any plugins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14743 268f45cc-cd09-0410-ab3c-d52691b4dbfc