16 years ago2006-05-25 Mitz Pettel <opendarwin.org@mitzpettel.com>
eseidel [Thu, 25 May 2006 22:17:38 +0000 (22:17 +0000)]
2006-05-25  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed by hyatt.  Landed by eseidel.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8848
          TFOOT borders are copied to THEAD and TBODY

        Test: fast/table/border-collapsing/border-collapsing-head-foot.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::sectionAbove): Added.
        (WebCore::RenderTable::sectionBelow): Added.
        (WebCore::RenderTable::cellAbove): Changed to call sectionAbove.
        (WebCore::RenderTable::cellBelow): Changed to call sectionBelow.
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::collapsedTopBorder): Changed to call sectionAbove.
        (WebCore::RenderTableCell::collapsedBottomBorder): Changed to call sectionBelow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-05-25 Mitz Pettel <opendarwin.org@mitzpettel.com>
eseidel [Thu, 25 May 2006 22:11:36 +0000 (22:11 +0000)]
2006-05-25  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed by hyatt.  Landed by eseidel.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3297
          height property is not honored on table rows

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild): Assign the row renderer to the
        grid row.
        (WebCore::RenderTableSection::calcRowHeight): Fix off-by-one index bug
        and add vertical spacing only for grid rows that have a renderer.
        (WebCore::RenderTableSection::recalcCells): Assign row renderers to
        grid rows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoRemove bogus directory
eseidel [Thu, 25 May 2006 22:05:22 +0000 (22:05 +0000)]
Remove bogus directory

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-05-19 Rob Buis <buis@kde.org>
eseidel [Thu, 25 May 2006 22:00:06 +0000 (22:00 +0000)]
2006-05-19  Rob Buis  <buis@kde.org>

        Reviewed by darin.  Landed by eseidel.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5978
        WebKIt+SVG should use SVGDocumentImpl for image/svg+xml

        Make sure SVGDocument is created for standalone svg

        * ksvg2/svg/SVGDOMImplementation.cpp:
        * ksvg2/svg/SVGDOMImplementation.h:
        * ksvg2/svg/SVGDocument.cpp:
        * ksvg2/svg/SVGDocument.h:
        * ksvg2/svg/SVGTests.cpp:
        * ksvg2/svg/SVGTitleElement.cpp:
        * ksvg2/svg/SVGTitleElement.h:
        * page/Frame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-05-17 Rob Buis <buis@kde.org>
eseidel [Thu, 25 May 2006 21:55:45 +0000 (21:55 +0000)]
2006-05-17  Rob Buis  <buis@kde.org>

        Reviewed by darin.  Landed by eseidel.

        HTMLNames.* should be generated using make_names.pl

        Use a patched make_names.pl to autogenerate HTMLNames.*

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLNames.cpp: Removed.
        * html/HTMLNames.h: Removed.
        * html/HTMLTagNames.in: Added.
        * html/HTMLAttributeNames.in: Added.
        * ksvg2/scripts/make_names.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-05-23 Eric Seidel <eric@eseidel.com>
eseidel [Thu, 25 May 2006 21:41:29 +0000 (21:41 +0000)]
2006-05-23  Eric Seidel  <eric@eseidel.com>

        Reviewed by andersca.

        Add "HasIndexGetter" support to bindings autogen system.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLInputElementBase.cpp:
        * bindings/js/kjs_css.cpp:
        * bindings/js/kjs_css.h:
        * bindings/js/kjs_dom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/CSSValueList.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBuild fix
thatcher [Thu, 25 May 2006 20:15:22 +0000 (20:15 +0000)]
Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoVersioning
thatcher [Thu, 25 May 2006 19:06:37 +0000 (19:06 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim O.
thatcher [Thu, 25 May 2006 19:00:11 +0000 (19:00 +0000)]
    Reviewed by Tim O.

        <rdar://problem/4559808> WebKit fails to compile for ppc64
        <rdar://problem/4522085> 64-bit: WebKit uses FSSpec which is not available in 64-bit
        Gets WebKit building under 64-bit. Rename WebNSInt and WebNSUInt to WebNSInteger and WebNSUInteger.
        Start using WebNSInteger where we need to match AppKit API usage of NSInteger.

        HIWebView and a couple of helper functions are disabled until they can be moved off of QuickDraw.
        <rdar://problem/4561772> HIWebView needs to be reworked to not use QuickDraw, needed for 64-bit

        * Carbon/CarbonUtils.m: disabled this file in 64-bit <rdar://problem/4561772>
        * Carbon/CarbonWindowAdapter.m:
        (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
        * Carbon/CarbonWindowFrame.m:
        (+[CarbonWindowFrame frameRectForContentRect:styleMask:]):
        (+[CarbonWindowFrame contentRectForFrameRect:styleMask:]):
        (+[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]):
        (-[CarbonWindowFrame frameRectForContentRect:styleMask:]):
        (-[CarbonWindowFrame contentRectForFrameRect:styleMask:]):
        (-[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]):
        * Carbon/HIViewAdapter.m: disabled this file in 64-bit <rdar://problem/4561772>
        * Carbon/HIWebView.m: disabled this file in 64-bit <rdar://problem/4561772>
        * DefaultDelegates/WebDefaultResourceLoadDelegate.m:
        (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]):
        * History/WebBackForwardList.m:
        (-[WebBackForwardList removeItem:]):
        (-[WebBackForwardList goToItem:]):
        * Misc/WebDownload.m:
        (-[WebDownloadInternal download:didReceiveDataOfLength:]):
        * Misc/WebFileDatabase.m:
        * Misc/WebIconDatabase.m:
        (-[NSMutableDictionary retainIconForURL:]):
        (-[NSMutableDictionary releaseIconForURL:]):
        (-[WebIconDatabase _totalRetainCountForIconURLString:]):
        (-[WebIconDatabase _retainIconForIconURLString:]):
        (-[WebIconDatabase _releaseIconForIconURLString:]):
        * Misc/WebSearchableTextView.m:
        (-[NSString selectionRect]):
        * Misc/WebTypesInternal.h: Added.
        * Plugins/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream _destroyStream]):
        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView sendActivateEvent:]):
        (-[WebBaseNetscapePluginView sendUpdateEvent]):
        (-[WebBaseNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
        (-[WebBaseNetscapePluginView _printedPluginBitmap]):
        (-[NSData _web_locationAfterFirstBlankLine]):
        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage hash]):
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]):
        * WebInspector/WebInspector.m:
        (-[WebInspector _updateSystemColors]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m:
        (-[WebDataSource _didReceiveData:contentLength:forResource:]):
        * WebView/WebFrame.m:
        (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
        * WebView/WebHTMLView.m:
        (-[NSArray drawRect:]):
        (-[WebHTMLView characterIndexForPoint:]):
        (-[WebHTMLView conversationIdentifier]):
        * WebView/WebResourceLoadDelegate.h:
        * WebView/WebUIDelegate.h:
        * WebView/WebView.h:
        * WebView/WebView.m:
        (-[WebView _mouseDidMoveOverElement:modifierFlags:]):
        (-[WebView spellCheckerDocumentTag]):
        * WebView/WebViewInternal.h:
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoModify DumpRenderTree so it will be able to spit out expected-win.txt files for win32...
hyatt [Thu, 25 May 2006 08:08:21 +0000 (08:08 +0000)]
Modify DumpRenderTree so it will be able to spit out expected-win.txt files for win32 layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix DumpRenderTree so that it works again.
hyatt [Thu, 25 May 2006 07:35:21 +0000 (07:35 +0000)]
Fix DumpRenderTree so that it works again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Implement font aliasing of family names for Courier/Courier New,
hyatt [Thu, 25 May 2006 05:52:35 +0000 (05:52 +0000)]
    Implement font aliasing of family names for Courier/Courier New,
        Arial/Helvetica, and Times/Times New Roman.  This behavior matches
        WinIE and Firefox.

        Reviewed by maciej

        Test cases not really possible, since they would have to rely on people
        not having the fonts installed (so not having installed Office).

        * platform/FontCache.cpp:
        * platform/FontCache.h:
        * rendering/RenderContainer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
bdakin [Thu, 25 May 2006 00:43:35 +0000 (00:43 +0000)]
    Reviewed by Geoff.

        This layout test is now correct, so I moved it into the expected
        successes directory and generated new results.

        * tables/mozilla/bugs/bug222846-expected.checksum: Added.
        * tables/mozilla/bugs/bug222846-expected.png: Added.
        * tables/mozilla/bugs/bug222846-expected.txt: Added.
        * tables/mozilla/bugs/bug222846.html: Added.
        * tables/mozilla_expected_failures/bugs/bug222846-
        expected.checksum: Removed.
        * tables/mozilla_expected_failures/bugs/bug222846-expected.png:
        * tables/mozilla_expected_failures/bugs/bug222846-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug222846.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoVersioning
thatcher [Thu, 25 May 2006 00:34:30 +0000 (00:34 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
justing [Wed, 24 May 2006 23:49:48 +0000 (23:49 +0000)]

        Reviewed by levi

        * editing/selection/designmode-no-caret-expected.checksum: Added.
        * editing/selection/designmode-no-caret-expected.png: Added.
        * editing/selection/designmode-no-caret-expected.txt: Added.
        * editing/selection/designmode-no-caret.html: Added.


        Reviewed by levi

        <rdar://problem/4549610> REGRESSION: No initial cursor in Mail reply or Blot document
        <rdar://problem/4560698> Mail is very crashy in Leopard9A182, WebCore::Range::compareBoundaryPoints(WebCore::Node*, int, WebCore::Node*, int)

        * page/Frame.cpp:
        (WebCore::Frame::setSelectionFromNone): Find the body and stick a caret
        in it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
sullivan [Wed, 24 May 2006 23:41:17 +0000 (23:41 +0000)]
    Reviewed by John Sullivan.

        * quality/lifecycle.html: mentions case of PlatformOnly bugs
                                  and 'other' bug databases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdd support for IMLangFontLink2 to map to a similar font that has missing characters...
hyatt [Wed, 24 May 2006 23:33:09 +0000 (23:33 +0000)]
Add support for IMLangFontLink2 to map to a similar font that has missing characters on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rubber stamped by Anders.
ggaren [Wed, 24 May 2006 23:18:00 +0000 (23:18 +0000)]
    Rubber stamped by Anders.

        Removed meaningless 'dom::' prefix in IDL files.

        * dom/Range.idl:
        * html/CanvasRenderingContext2D.idl:
        * html/HTMLOptionElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
ggaren [Wed, 24 May 2006 23:13:51 +0000 (23:13 +0000)]

        - Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9095
        regression: can't select by setting option.selected to true

        * fast/dom/option-properties-expected.txt: Added.
        * fast/dom/option-properties.html: Added.


        Reviewed by andersca.

        - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9095
        regression: can't select by setting option.selected to true

        'text' and 'selected' were erroneously marked read-only for option elements.

        * html/HTMLOptionElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
ggaren [Wed, 24 May 2006 22:42:54 +0000 (22:42 +0000)]

        Reviewed by mjs.

        - JSC half of fix for <rdar://problem/4557926> TOT REGRESSSION: Crash
        occurs when attempting to view image in slideshow mode at
        http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute
        (KJS::ExecState*) + 312)

        On alternate threads, DOMObjects remain in the
        ScriptInterpreter's cache because they're not collected. So, they
        need an opportunity to mark their children.

        I'm not particularly happy with this solution because it fails to
        resolve many outstanding issues with the DOM object cache. Since none
        of those issues is a crasher or a serious compatibility concern,
        and since the behavior of other browsers is not much to go on in this
        case, I've filed <rdar://problem/4561439> about that, and I'm moving on
        with my life.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/collector.cpp:
        * kjs/internal.cpp:
        * kjs/internal.h:
        * kjs/interpreter.cpp:
        * kjs/interpreter.h:


        Layout tests for DOM object cache and garbage collection,
        <rdar://problem/4557926> TOT REGRESSION: Crash occurs when attempting
        to view image in slideshow mode at http://d.smugmug.com/gallery/581716
        ( KJS::IfNode::execute (KJS::ExecState*) + 312) if you use a PAC file

        * fast/dom/gc-8-expected.txt: Added.
        * fast/dom/gc-8.html: Added.
        * fast/dom/gc-9-expected.txt: Added.
        * fast/dom/gc-9.html: Added.


        Reviewed by mjs.

        - WebCore half of fix for <rdar://problem/4557926> TOT REGRESSION: Crash
        occurs when attempting to view image in slideshow mode at
        http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute
        (KJS::ExecState*) + 312)

        On alternate threads, DOMObjects remain in the
        ScriptInterpreter's cache because they're not collected. So, they
        need an opportunity to mark their children.

        I'm not particularly happy with this solution because it fails to
        resolve many outstanding issues with the DOM object cache. Since none
        of those issues is a crasher or a serious compatibility concern,
        and since the behavior of other browsers is not much to go on in this
        case, I've filed <rdar://problem/4561439> about that, and I'm moving
        on with my life.

        Also added functionality for testing garbage collection from inside

        Also removed XMLHttpRequest from the DOM object cache because XMLHttpRequest
        objects aren't accessed through the DOM.

        Also added JS locking around access to some shared data structures in
        WebCoreJavaScript, even though it probably doesn't matter in practice.

        * bindings/js/JSXMLHttpRequest.cpp:
        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_binding.h:
        * bridge/mac/WebCoreJavaScript.h:
        * bridge/mac/WebCoreJavaScript.mm:
        (+[WebCoreJavaScript objectCount]):
        (+[WebCoreJavaScript interpreterCount]):
        (+[WebCoreJavaScript protectedObjectCount]):
        (+[WebCoreJavaScript garbageCollect]):
        (+[WebCoreJavaScript garbageCollectOnAlternateThread:]):
        (+[WebCoreJavaScript shouldPrintExceptions]):
        (+[WebCoreJavaScript setShouldPrintExceptions:]):


        Reviewed by mjs.

        Added 'GCController' to DRT to support garbage collection layout tests.

        GCController.collect() and GCController.collectOnAlternateThread() do
        what you would expect. The latter takes a boolean argument sepcifying
        whether to wait for garbage collection to finish before continuing to
        execute script.

        * DumpRenderTree/DumpRenderTree.m:
        (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/GCController.h: Added.
        * DumpRenderTree/GCController.mm: Added.
        (+[GCController isSelectorExcludedFromWebScript:]):
        (+[GCController webScriptNameForSelector:]):
        (-[GCController collect]):
        (-[GCController collectOnAlternateThread:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdding Google Analytics code, to create visitor stats of our site.
jdevalk [Wed, 24 May 2006 22:32:28 +0000 (22:32 +0000)]
Adding Google Analytics code, to create visitor stats of our site.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoMove font destruction for HFONTs and cairo objects into FontData.
hyatt [Wed, 24 May 2006 21:54:30 +0000 (21:54 +0000)]
Move font destruction for HFONTs and cairo objects into FontData.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
andersca [Wed, 24 May 2006 19:26:09 +0000 (19:26 +0000)]

2006-05-24  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        Implement document.scripts

        * bindings/js/kjs_html.cpp:
        Return document.scripts() instead of a placeholder object.

        * dom/Document.cpp:
        * dom/Document.h:
        Add Document::scripts.

        * html/HTMLCollection.cpp:
        * html/HTMLCollection.h:
        Add scripts collection type which traverses all script elements.


2006-05-24  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        Add tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9093
        Implement document.scripts

        * fast/dom/document-scripts-expected.txt: Added.
        * fast/dom/document-scripts.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
andersca [Wed, 24 May 2006 18:51:22 +0000 (18:51 +0000)]

2006-05-24  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        innerText is empty for elements without renderers

        * dom/Node.cpp:
        * dom/Node.h:
        Add optional convertBRsToNewlines argument for textContent.

        * html/HTMLElement.cpp:
        If the element doesn't have a renderer, return textContent.


2006-05-24  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        Add test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9092
        innerText is empty for elements without renderers.

        * fast/dom/inner-text-with-no-renderer-expected.txt: Added.
        * fast/dom/inner-text-with-no-renderer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix the Win32 themed controls so that they honor Cairo transforms.
hyatt [Wed, 24 May 2006 09:25:21 +0000 (09:25 +0000)]
Fix the Win32 themed controls so that they honor Cairo transforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix a minor bug with the computation of glyph offsets in Cairo/Win32.
hyatt [Wed, 24 May 2006 08:33:32 +0000 (08:33 +0000)]
Fix a minor bug with the computation of glyph offsets in Cairo/Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoSwitch the cairo win32 create similar call over to createdib instead. Avoids wasted...
hyatt [Wed, 24 May 2006 08:28:10 +0000 (08:28 +0000)]
Switch the cairo win32 create similar call over to createdib instead.  Avoids wasted fills.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCheck in some temporary hacks to Cairo for speed.
hyatt [Wed, 24 May 2006 08:23:32 +0000 (08:23 +0000)]
Check in some temporary hacks to Cairo for speed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoMake sure the font options set on the context match what we draw.
hyatt [Wed, 24 May 2006 07:15:15 +0000 (07:15 +0000)]
Make sure the font options set on the context match what we draw.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCorrect reviewer from me to Tim.
mjs [Wed, 24 May 2006 01:08:30 +0000 (01:08 +0000)]
Correct reviewer from me to Tim.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
mjs [Wed, 24 May 2006 00:59:34 +0000 (00:59 +0000)]
    Reviewed by Maciej.

        - more loader refactoring to simplify things and remove knowledge of WebView from WebSubresourceLoader

        * WebCoreSupport/WebSubresourceLoader.m:
        (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
        (-[WebSubresourceLoader didReceiveResponse:]):
        * WebView/WebDataSource.m:
        (-[WebDataSource _loadIcon]):
        (-[WebDataSource _startLoading]):
        * WebView/WebFrame.m:
        (-[WebFrame _loadRequest:archive:]):
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
        (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
        * WebView/WebFrameInternal.h:
        * WebView/WebFramePrivate.h:
        * WebView/WebLoader.h:
        * WebView/WebLoader.m:
        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader initWithDataSource:]):
        (-[WebMainResourceLoader didReceiveResponse:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Timothy.
thatcher [Wed, 24 May 2006 00:24:52 +0000 (00:24 +0000)]
    Reviewed by Timothy.

        * index.html: Link to Nokia's S60 WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
thatcher [Tue, 23 May 2006 23:32:08 +0000 (23:32 +0000)]
    Reviewed by Eric.

        Remove the recent idl files from the WebCore target to prevent them
        from being copied into the framework resources.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Justin Garcia and Levi Weintraub.
sullivan [Tue, 23 May 2006 23:31:14 +0000 (23:31 +0000)]
    Reviewed by Justin Garcia and Levi Weintraub.

        - fixed Bug 9072: REGRESSION: Misspelling marker incorrect in editing/deleting/delete-and-undo.html

        * dom/Document.cpp:
        One more time to get this right, ugh. There is still one case where we don't want to advance the
        iterator, and that's when we remove a marker and do not insert a replacement marker. So I undid
        my previous patch, and added it++ to each of the two cases that insert a replacement marker. Now
        the layout tests pass even with the pixel tests enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoImplement CookieJar on Win32.
hyatt [Tue, 23 May 2006 22:11:56 +0000 (22:11 +0000)]
Implement CookieJar on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix post form submission on Win32.
hyatt [Tue, 23 May 2006 21:21:44 +0000 (21:21 +0000)]
Fix post form submission on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
sullivan [Tue, 23 May 2006 20:45:24 +0000 (20:45 +0000)]
    Reviewed by Maciej.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        Newer Xcode removed some obsolete cruft

        * DumpRenderTree/TextInputController.m:
        (-[TextInputController textInput]):
        added (id) cast to make newer compiler happy

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix glyph width access on win32 to not depend on the UChar.
hyatt [Tue, 23 May 2006 20:31:53 +0000 (20:31 +0000)]
Fix glyph width access on win32 to not depend on the UChar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
tomernic [Tue, 23 May 2006 19:27:58 +0000 (19:27 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4558301> REGRESSION (420+): After clearing history and closing bookmark view window,
        attempting to select Safari's menu bar results in a crash

        * Misc/WebNSWindowExtras.m:
        My fix yesterday for 4557117 was not quite good enough.  Now that we cancel the display timer for a
        window *before* it deallocates, we need to make sure that while a window deallocates, no new display
        timers are scheduled for that window.  This is actually possible, as 4558301 demonstrates.
        Luckily, NSWindow sets a handy "windowDying" flag when it deallocates, so we can just check that flag
        and bail out of the throttle hack if it is set.  This should fix the last of the crashes involving
        display timers scheduled for deallocated or deallocating windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Hyatt.
lweintraub [Tue, 23 May 2006 17:51:29 +0000 (17:51 +0000)]
    Reviewed by Hyatt.

        Cleaned up changes to markup by adding the non-virtual
        nodeNamePreservingCase accessor function.

        * dom/Element.cpp:
        * dom/Element.h:
        * editing/markup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Anders Carlsson.
sullivan [Tue, 23 May 2006 17:35:17 +0000 (17:35 +0000)]
    Reviewed by Anders Carlsson.

        * dom/Document.cpp:
        Fix to my previous checkin (which broke a layout test).
        Advance the iterator position every time through the loop; formerly it was not advanced in the
        case where a marker was actually removed, causing an infinite loop in certain cases. Also
        modified a comment that was confusing the situation by falsely claiming that iterating over a
        just-inserted node would always be OK.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
andersca [Tue, 23 May 2006 16:27:49 +0000 (16:27 +0000)]

2006-05-23  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        Weather2.css incorrectly treated as JavaScript file @ www.live.com

        * dom/Element.cpp:
        Use new getAttributeItem method.

        * dom/NamedAttrMap.cpp:
        Use new getAttributeItem method.

        * dom/NamedAttrMap.h:
        New method which returns the attribute based on the nodeName.


2006-05-23  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        Update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
        Weather2.css incorrectly treated as JavaScript file @ www.live.com

        * dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt:
        This fails in a different way now.

        * dom/xhtml/level3/core/nodelookupnamespaceuri17-expected.txt:
        * dom/xhtml/level3/core/nodelookupnamespaceuri20-expected.txt:
        * dom/xhtml/level3/core/nodelookupprefix17-expected.txt:
        * dom/xhtml/level3/core/nodelookupprefix20-expected.txt:
        * dom/xhtml/level3/core/noderemovechild28-expected.txt:
        * dom/xhtml/level3/core/noderemovechild29-expected.txt:
        These now pass.

        * fast/dom/attribute-namespaces-get-set-expected.txt: Added.
        * fast/dom/attribute-namespaces-get-set.html: Added.
        Add new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
mjs [Tue, 23 May 2006 15:40:14 +0000 (15:40 +0000)]
    Reviewed by Eric.

        - remove knowledge of WebView from WebLoader in preparation for moving the code down

        * WebView/WebDataSource.m:
        (-[WebDataSource _defersCallbacks]):
        (-[WebDataSource _identifierForInitialRequest:]):
        (-[WebDataSource _willSendRequest:forResource:redirectResponse:]):
        (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]):
        (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]):
        (-[WebDataSource _didReceiveResponse:forResource:]):
        (-[WebDataSource _didReceiveData:contentLength:forResource:]):
        (-[WebDataSource _didFinishLoadingForResource:]):
        (-[WebDataSource _didFailLoadingWithError:forResource:]):
        (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]):
        (-[WebDataSource _privateBrowsingEnabled]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebLoader.h:
        * WebView/WebLoader.m:
        (-[WebLoader releaseResources]):
        (-[WebLoader setDataSource:]):
        (-[WebLoader willSendRequest:redirectResponse:]):
        (-[WebLoader didReceiveAuthenticationChallenge:]):
        (-[WebLoader didCancelAuthenticationChallenge:]):
        (-[WebLoader didReceiveResponse:]):
        (-[WebLoader didReceiveData:lengthReceived:]):
        (-[WebLoader signalFinish]):
        (-[WebLoader didFinishLoading]):
        (-[WebLoader didFailWithError:]):
        (-[WebLoader willCacheResponse:]):
        (-[WebLoader cancelWithError:]):
        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
        * WebView/WebView.m:
        (-[WebView _incrementProgressForIdentifier:response:]):
        (-[WebView _incrementProgressForIdentifier:data:]):
        (-[WebView _completeProgressForIdentifier:]):
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-05-22 Eric Seidel <eric@eseidel.com>
eseidel [Tue, 23 May 2006 01:36:01 +0000 (01:36 +0000)]
2006-05-22  Eric Seidel  <eric@eseidel.com>

        Rubber-stamped by adele.

        * bindings/js/kjs_html.h: simple style cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoVersioning.
thatcher [Mon, 22 May 2006 23:46:58 +0000 (23:46 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBuild fix when doing 'xcodebuild install'.
thatcher [Mon, 22 May 2006 23:30:22 +0000 (23:30 +0000)]
Build fix when doing 'xcodebuild install'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBuild fix.
thatcher [Mon, 22 May 2006 22:18:04 +0000 (22:18 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by levi
justing [Mon, 22 May 2006 22:10:58 +0000 (22:10 +0000)]
    Reviewed by levi

        Fixed and reenabled this test.

        * editing/selection/drag-to-contenteditable-iframe-expected.checksum:
        * editing/selection/drag-to-contenteditable-iframe-expected.png:
        * editing/selection/drag-to-contenteditable-iframe-expected.txt:
        * editing/selection/drag-to-contenteditable-iframe.html: Added.
        * editing/selection/drag-to-contenteditable-iframe.html-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoRemoves svn:executable from MathExtras.h. Caused a build verification failure.
thatcher [Mon, 22 May 2006 21:39:44 +0000 (21:39 +0000)]
Removes svn:executable from MathExtras.h. Caused a build verification failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Anders Carlsson.
sullivan [Mon, 22 May 2006 21:20:43 +0000 (21:20 +0000)]
    Reviewed by Anders Carlsson.

        - fixed Bug 9038: Rework Document::TextMarker mechanism to not use deprecated data structures

        Changed Document::markersForNode and Document::MarkerMap to use Vector rather than
        DeprecatedValueList and DeprecatedValueListIterator.

        * dom/Document.h:
        * dom/Document.cpp:

        * rendering/InlineTextBox.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago64-bit build fix, and removes the workaround for <rdar://problem/4294625>.
thatcher [Mon, 22 May 2006 21:00:09 +0000 (21:00 +0000)]
64-bit build fix, and removes the workaround for <rdar://problem/4294625>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
tomernic [Mon, 22 May 2006 20:55:03 +0000 (20:55 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4557117> TOT REGRESSION: Repro crash in cancelPendingWindowDisplay --> _timerRelease when
        opening file from file open dialog

        Note that I could not reproduce this situation at all on any of my machines; I had to debug this on Geoff's

        * Misc/WebNSWindowExtras.m:
        Cancel display timer before dealloc, not after.  Cancelling the timer can cause a message to be sent to the
        window; best to do that before the window deallocates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-05-22 Steve Falkenburg <sfalken@apple.com>
sfalken [Mon, 22 May 2006 20:21:24 +0000 (20:21 +0000)]
2006-05-22  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by adele.

        Fix build.

        * Spinneret/Spinneret.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-05-22 Steve Falkenburg <sfalken@apple.com>
sfalken [Mon, 22 May 2006 20:16:17 +0000 (20:16 +0000)]
2006-05-22  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by adele.

        Fix build.

        * WebKitWin.vcproj/WebKitWin.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
lweintraub [Mon, 22 May 2006 18:34:24 +0000 (18:34 +0000)]

        Reviewed by eric.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8393
          <br>s created by createMarkup aren't valid xhtml
          Changes in case from innerHTML

        * editing/execCommand/createLink-expected.txt:
        * editing/execCommand/unlink-expected.txt:
        * editing/input/attributed-substring-from-range-lines-expected.txt:
        * fast/dom/Range/range-exceptions-expected.txt:
        * fast/dom/Range/resources/range-exceptions.js:
        * fast/innerHTML/005-expected.txt:
        * fast/innerHTML/innerHTML-custom-tag-expected.txt:
        * fast/innerHTML/innerHTML-cast.html: Added.
        * fast/innerHTML/innerHTML-cast-expected.txt: Added.
        * fast/xsl/xslt-processer-expected.txt:


        Reviewed by Eric.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8393
          <br>s created by createMarkup aren't valid xhtml
          Fixed uppered output from innerHTML

        * editing/markup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric, Kevin and Geoff.
thatcher [Mon, 22 May 2006 18:20:15 +0000 (18:20 +0000)]
    Reviewed by Eric, Kevin and Geoff.

        Merge open source build fixes. <rdar://problem/4555500>

        * kjs/collector.cpp: look at the rsp register in x86_64
        * wtf/Platform.h: add x86_64 to the platform list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix Mac bustage.
hyatt [Mon, 22 May 2006 08:04:56 +0000 (08:04 +0000)]
Fix Mac bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix win32 bustage.
hyatt [Mon, 22 May 2006 06:19:01 +0000 (06:19 +0000)]
Fix win32 bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix win32 bustage.
hyatt [Mon, 22 May 2006 06:18:32 +0000 (06:18 +0000)]
Fix win32 bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
adele [Sun, 21 May 2006 23:42:36 +0000 (23:42 +0000)]
    Reviewed by Maciej.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9016
        crash loading live.com in TreeShared::ref because accessing RenderTextField::text() can destroy the RenderTextField

        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::text):
        Reverting recent change to user innerText instead of textContent.  For textareas,
        we need a better solution than textContent that also takes newlines into account,
        but this should fix this crasher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-05-21 Anders Carlsson <acarlsson@apple.com>
andersca [Sun, 21 May 2006 07:51:14 +0000 (07:51 +0000)]
2006-05-21  Anders Carlsson  <acarlsson@apple.com>

        Fix build.

        * ForwardingHeaders/wtf/MathExtras.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdd mathextras to javascrtipcore project.
hyatt [Sun, 21 May 2006 07:18:49 +0000 (07:18 +0000)]
Add mathextras to javascrtipcore project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix mac bustage. Minor snafu in constructor.
hyatt [Sun, 21 May 2006 07:05:21 +0000 (07:05 +0000)]
Fix mac bustage.  Minor snafu in constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoSwitch on Cairo-based text rendering on win32.
hyatt [Sun, 21 May 2006 06:58:12 +0000 (06:58 +0000)]
Switch on Cairo-based text rendering on win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdd mathextras.h to wtf to give win32 roundf/lroundf support.
hyatt [Sun, 21 May 2006 06:55:40 +0000 (06:55 +0000)]
Add mathextras.h to wtf to give win32 roundf/lroundf support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Beth.
mjs [Sun, 21 May 2006 02:09:59 +0000 (02:09 +0000)]
    Reviewed by Beth.

        - fix assertion failure on layout tests

        * WebView/WebDataSource.m:
        (-[WebDataSource _mainReceivedError:complete:]): Don't do anything
        if this data source is no longer connected to a frame. Used to be
        this couldn't happen because the WebView would have been nil, but
        we no longer go through the WebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Anders.
thatcher [Sat, 20 May 2006 22:42:59 +0000 (22:42 +0000)]
    Reviewed by Anders.

        Bug 9018: REGRESSION: resizing the top area of the inspector does not grow as expected

        Use clientHeight now that offsetHeight includes the border and padding.
        clientHeight should have been used initially.

        * WebInspector/WebInspector.m:
        (-[WebInspector resizeTopArea]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix Cairo double buffering.
hyatt [Sat, 20 May 2006 21:22:06 +0000 (21:22 +0000)]
Fix Cairo double buffering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
andersca [Sat, 20 May 2006 20:19:22 +0000 (20:19 +0000)]

2006-05-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        Support function declaration in case statements

        * kjs/grammar.y: Get rid of StatementList and use SourceElements instead.

        * kjs/nodes.cpp:
        * kjs/nodes.h:
        Add processFuncDecl for the relevant nodes.

        * kjs/nodes2string.cpp:
        next got renamed to source.


2006-05-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        * fast/js/function-declarations-in-switch-statement-expected.txt: Added.
        * fast/js/function-declarations-in-switch-statement.html: Added.
        * fast/js/resources/function-declarations-in-switch-statement.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
ap [Sat, 20 May 2006 08:57:16 +0000 (08:57 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8991
          REGRESSION: missing or broken CSS custom cursors are displayed as
          a missing image icon

        * page/FrameView.cpp:
        (WebCore::selectCursor): Fallback to CURSOR_AUTO if the image is an error image.
        * manual-tests/custom-cursors.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-05-20 Mitz Pettel <opendarwin.org@mitzpettel.com>
ap [Sat, 20 May 2006 08:47:37 +0000 (08:47 +0000)]
2006-05-20  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed and landed by ap.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9009
          REGRESSION: ToT crash in WebCore at Zap2it

        Test: fast/table/empty-section-crash.html

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::paint): Return immediately if the section
        has 0 rows or 0 columns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix Win32 bustage caused by image document. supportsType is not implemented yet...
hyatt [Sat, 20 May 2006 05:52:02 +0000 (05:52 +0000)]
Fix Win32 bustage caused by image document.  supportsType is not implemented yet for ImageCairo, so we'll return false rather than true to keep every document from being an image document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
lweintraub [Sat, 20 May 2006 00:21:46 +0000 (00:21 +0000)]

        Reviewed by justin.

        Tests for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8931>
        Drag caret not painted for editable sub-frames

        * editing/resources/select-and-drag-iframe.html: Added.
        * editing/selection/drag-in-iframe-expected.checksum: Added.
        * editing/selection/drag-in-iframe-expected.png: Added.
        * editing/selection/drag-in-iframe-expected.txt: Added.
        * editing/selection/drag-in-iframe.html: Added.


        Reviewed by justin.

        Drag caret not painted for editable sub-frames

        Moved the drag caret out of Frame and into Page.
        Only the Frame that contains the drag caret will paint it.

        * editing/SelectionController.h:
        * page/Frame.cpp:
        * page/FramePrivate.h:
        * page/Page.cpp:
        * page/Page.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
aliceli1 [Fri, 19 May 2006 23:16:17 +0000 (23:16 +0000)]
    Reviewed by Adele.

        * html/HTMLButtonElement.idl:
        added support for HTMLButtonElement.click()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@14496 268f45cc-cd09-0410...
aliceli1 [Fri, 19 May 2006 21:18:58 +0000 (21:18 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
ggaren [Fri, 19 May 2006 19:35:41 +0000 (19:35 +0000)]

        - Test for overriding non-autogenerated global constructors.

        * fast/dom/constructors-overriding-expected.txt: Added.
        * fast/dom/constructors-overriding.html: Added.


        Reviewed by Eric.

        - Fixed non-autogenerated global constructors to match autogenerated
        ones and FF. (Found this bug while @ the GOOG.)

        (1) They're no longer read-only, so they can be overridden.
        (2) They now have the default object prototype, so they can do things
        like 'toString' and 'valueOf', necessary for general functionality,
        including my layout test.
        (3) Their prototype properties are now enumerable and not read-only.

        * bindings/js/JSDOMParser.cpp:
        * bindings/js/JSXMLHttpRequest.cpp:
        * bindings/js/JSXMLHttpRequest.h:
        * bindings/js/JSXMLSerializer.cpp:
        * bindings/js/JSXSLTProcessor.cpp:
        * bindings/js/kjs_html.cpp:
        * bindings/js/kjs_window.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-05-19 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 19 May 2006 10:53:07 +0000 (10:53 +0000)]
2006-05-19  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Eric.

        Autogenerate another 22 HTML classes

        Already covered by existing DOM tests.

        * DerivedSources.make:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Add new IDL files and generated sources.

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        Use JSHTMLImageElement::info in inherits.

        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        Add macros for the functions and the code to populate the hash set.

        * bindings/js/kjs_html.cpp:
        * bindings/js/kjs_html.h:
        Delete old cruft.

        * bindings/scripts/CodeGeneratorJS.pm:
        Add support for creating a JS object from a HTMLCollection.

        * html/HTMLAreaElement.idl: Added.
        * html/HTMLBRElement.idl: Added.
        * html/HTMLBaseFontElement.idl: Added.
        * html/HTMLBlockquoteElement.idl: Added.

        * html/HTMLBodyElement.cpp:
        * html/HTMLBodyElement.h:
        Add new functions that used to be implemented in kjs_html.cpp

        * html/HTMLBodyElement.idl: Added.
        * html/HTMLFieldSetElement.idl: Added.
        * html/HTMLFontElement.idl: Added.
        * html/HTMLHRElement.idl: Added.
        * html/HTMLHeadingElement.idl: Added.
        * html/HTMLImageElement.idl: Added.
        * html/HTMLIsIndexElement.idl: Added.
        * html/HTMLLIElement.idl: Added.
        * html/HTMLLabelElement.idl: Added.
        * html/HTMLLegendElement.idl: Added.
        * html/HTMLMapElement.idl: Added.
        * html/HTMLMenuElement.idl: Added.
        * html/HTMLModElement.idl: Added.
        * html/HTMLParagraphElement.idl: Added.
        * html/HTMLParamElement.idl: Added.
        * html/HTMLPreElement.idl: Added.
        * html/HTMLQuoteElement.idl: Added.
        * html/HTMLScriptElement.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoUpdate to the latest and greatest Cairo.
hyatt [Fri, 19 May 2006 01:25:48 +0000 (01:25 +0000)]
Update to the latest and greatest Cairo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
mjs [Thu, 18 May 2006 22:00:52 +0000 (22:00 +0000)]
    Reviewed by Eric.

        - remove loading-related code from WebView

        * Plugins/WebNetscapePluginStream.m:
        (-[WebNetscapePlugInStreamLoader didFinishLoading]):
        (-[WebNetscapePlugInStreamLoader didFailWithError:]):
        * WebCoreSupport/WebSubresourceLoader.m:
        (-[WebSubresourceLoader receivedError:]):
        (-[WebSubresourceLoader signalFinish]):
        * WebView/WebDataSource.m:
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _receivedMainResourceError:complete:]):
        (-[WebDataSource _finishedLoadingResource]):
        (-[WebDataSource _mainReceivedBytesSoFar:complete:]):
        (-[WebDataSource _receivedError:]):
        (-[WebDataSource _mainReceivedError:complete:]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebFrame.m:
        (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader didReceiveData:lengthReceived:]):
        (-[WebMainResourceLoader didFinishLoading]):
        * WebView/WebView.m:
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
tomernic [Thu, 18 May 2006 21:28:47 +0000 (21:28 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4551938> More options needed for window display throttle

        We decided to play it safe and leave our window flushing behavior unchanged from the previous
        public release.  By default, CoreGraphics deferred updates are once again OFF, and the window
        display throttle is OFF.

        Individual applications should set the WebKitThrottleWindowDisplayPreferenceKey and
        WebKitEnableDeferredUpdatesPreferenceKey defaults to suit their needs.

        Old behavior (like 10.4.6): WebKitThrottleWindowDisplayPreferenceKey=0 (or unset),
        WebKitEnableDeferredUpdatesPreferenceKey (or unset).

        Tear-free scrolling/animations: WebKitThrottleWindowDisplayPreferenceKey=0 (or unset),
        WebKitEnableDeferredUpdatesPreferenceKey=1.  While this configuration fixes the tearing issues
        caused by over-flushing, some applications will experience performance problems as over-flushing
        with CG deferred updates enabled will cause the app to block.

        Tear-free scrolling/animations, high performance: WebKitThrottleWindowDisplayPreferenceKey=1,
        WebKitEnableDeferredUpdatesPreferenceKey=1.  This is the riskiest configuration in that it
        enables the window display throttle "feature", potentially breaking applications' assumptions
        about when displays occur.  However, it provides the "best of both worlds", in that updates
        are tear-free, and performance impact should me minimal.

        * WebView/WebPreferenceKeysPrivate.h:
        Declared WebKitThrottleWindowDisplayPreferenceKey and WebKitEnableDeferredUpdatesPreferenceKey.

        * WebView/WebFrameView.m:
        (-[WebFrameView initWithFrame:]):
        Turn off CG deferred updates if WebKitEnableDeferredUpdatesPreferenceKey is NO or has no value.
        Added some comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoMake Win32 compile (finally). Add missing files to bindings/js directory in the...
hyatt [Thu, 18 May 2006 20:49:17 +0000 (20:49 +0000)]
Make Win32 compile (finally).  Add missing files to bindings/js directory in the vcproj.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoReduce link errors from 21 to 7 by adding more auto-generated JS bindings files to...
hyatt [Thu, 18 May 2006 20:40:52 +0000 (20:40 +0000)]
Reduce link errors from 21 to 7 by adding more auto-generated JS bindings files to the vcproj. (Win32 bustage still.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoKeep working on win32 bustage. Add KWQFileButton::setDisabled to TemporaryLinkStubs.
hyatt [Thu, 18 May 2006 20:36:16 +0000 (20:36 +0000)]
Keep working on win32 bustage.  Add KWQFileButton::setDisabled to TemporaryLinkStubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoKeep going trying to fix win32 bustage. Make ImageDocument compile.
hyatt [Thu, 18 May 2006 20:31:25 +0000 (20:31 +0000)]
Keep going trying to fix win32 bustage.  Make ImageDocument compile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin Adler.
sullivan [Thu, 18 May 2006 20:31:04 +0000 (20:31 +0000)]
    Reviewed by Darin Adler.

        - fixed <rdar://problem/4552713> REGRESSION: WebFrameView no longer responds to responder methods sent by Safari code

        * WebView/WebView.m:
        (-[WebView _responderForResponderOperations]):
        Treat sibling views of the main frameView the same as views outside of the webview for the purposes of this mechanism.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
tomernic [Thu, 18 May 2006 20:29:58 +0000 (20:29 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4553450> Make disabling window throttle safer

        * Misc/WebNSWindowExtras.m:
        (+[NSWindow _webkit_enableWindowDisplayThrottle]):
        Don't assume that +_webkit_disableWindowDisplayThrottle restored the NSWindow method implementations;
        now we'll only swizzle them once, and our replacement IMPs will call the old IMPs when the window
        throttle is disabled.  This is a safer approach when other components/"haxies" override the same methods
        that we are overriding, as it allows the overrides to "chain" properly.
        Moved the dictionary initialization code down a bit.  The order doesn't matter here.
        Noticed that this could have been written safer with respect to the timer having the last reference to
        the window.  I never experienced a crash here, but this code is definitely safer.
        (+[NSWindow _webkit_disableWindowDisplayThrottle]):
        Don't restore NSWindow method implementations; just clear the flag, flush pending displays, and destroy
        the dictionary.
        If throttling is disabled, just call the original IMP.
        Added an assert.
        Don't call clearWindowDisplayInfo() when throttling is disabled.
        Removed an unnecessary assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix build bustage caused by broken XPath feature support checking on win32.
hyatt [Thu, 18 May 2006 20:18:44 +0000 (20:18 +0000)]
Fix build bustage caused by broken XPath feature support checking on win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - try to fix no-SVG, no-XPATH build, again
darin [Thu, 18 May 2006 17:57:16 +0000 (17:57 +0000)]
    - try to fix no-SVG, no-XPATH build, again

        * Scripts/build-webkit: Use FEATURE_DEFINES= instead of FEATURE_DEFINES=''.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Turn off responding to font changes while running. It doesn't work
hyatt [Thu, 18 May 2006 17:52:30 +0000 (17:52 +0000)]
    Turn off responding to font changes while running.  It doesn't work
        right anyway.

        Reviewed by darin

        * platform/FontCache.cpp:
        * platform/FontCache.h:
        * platform/GlyphMap.h:
        * platform/GlyphWidthMap.h:
        * platform/mac/FontCacheMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - try to fix no-SVG, no-XPATH build
darin [Thu, 18 May 2006 17:04:51 +0000 (17:04 +0000)]
    - try to fix no-SVG, no-XPATH build

        * Scripts/build-webkit: Pass FEATURE_DEFINES rather than GCC_PREPROCESSOR_DEFINITIONS,
        since the former is what's used in the WebCore project now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - try to fix the Windows build
darin [Thu, 18 May 2006 16:56:24 +0000 (16:56 +0000)]
    - try to fix the Windows build

        * platform/TextEncoding.h: Changed a ";" to a ",".
        * WebCore.vcproj/WebCore/WebCore.vcproj: Removed
        JSCanvasRenderingContext2DBase.cpp and
        JSCanvasRenderingContext2DBase.h. Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Thu, 18 May 2006 16:53:35 +0000 (16:53 +0000)]

        Reviewed by Hyatt.

        Tests for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8896>
        Bug 8896: Absolutely positioned elements should use their parent's
        direction when left, right and width are auto in quirks mode.

        * fast/block/positioning/absolute-position-direction-quirk.html: Added.
        * fast/block/positioning/absolute-position-direction-quirk-expected.txt: Added.
        * fast/block/positioning/absolute-position-direction-quirk-expected.png: Added.
        * fast/block/positioning/absolute-position-direction-quirk-expected.checksum: Added.
        * fast/block/positioning/absolute-position-direction-strict.html: Added.
        * fast/block/positioning/absolute-position-direction-strict-expected.txt: Added.
        * fast/block/positioning/absolute-position-direction-strict-expected.png: Added.
        * fast/block/positioning/absolute-position-direction-strict-expected.checksum: Added.


        Reviewed by Hyatt.

        Fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8896>
        Bug 8896: Absolutely positioned elements should use their parent's
        direction when left, right and width are auto in quirks mode.

        Use the parent's direction instead of the containing
        block's in quirks mode for absolute positioning to match

        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and tweaked (way too much) by Darin.
darin [Thu, 18 May 2006 16:13:19 +0000 (16:13 +0000)]
    Reviewed and tweaked (way too much) by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8937
          EncodingMap uses 0 as its empty value but 0 is a valid TextEncodingID

        * platform/CharsetNames.cpp:
        (WebCore::TextEncodingIDHashTraits::emptyValue): Added a non-zero empty value,
        InvalidEncoding, and used InvalidEncoding2 for the deleted value.
        (WebCore::buildCharsetMaps): Added an assertion that the deleted and empty
        values are not valid encodings.
        * platform/TextEncoding.h: Defined InvalidEncoding2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Horrible glyph map regression fix. The initial page of the map was
hyatt [Thu, 18 May 2006 09:13:08 +0000 (09:13 +0000)]
    Horrible glyph map regression fix.  The initial page of the map was
        being rebuilt over and over again.

        Reviewed by andersca

        * platform/GlyphMap.cpp:
        * platform/GlyphWidthMap.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
andersca [Thu, 18 May 2006 08:20:57 +0000 (08:20 +0000)]

2006-05-18  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        Autogenerate more HTML classes

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        Add new files.

        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        Add wrappers.

        * bindings/js/kjs_html.cpp:
        * bindings/js/kjs_html.h:
        Delete the old implementations.

        * html/HTMLAnchorElement.cpp:
        * html/HTMLAnchorElement.h:
        Add some new accessor methods which used to be in kjs_html.cpp.

        * html/HTMLAnchorElement.idl: Added.
        * html/HTMLAppletElement.idl: Added.
        * html/HTMLDListElement.idl: Added.
        * html/HTMLDirectoryElement.idl: Added.
        * html/HTMLDivElement.idl: Added.
        * html/HTMLHtmlElement.idl: Added.
        * html/HTMLOListElement.idl: Added.
        * html/HTMLUListElement.idl: Added.


2006-05-18  Anders Carlsson  <acarlsson@apple.com>

        Autogenerate more HTML classes

        * fast/dom/prototype-chain-expected.txt:
        Update test result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Convert the width map for glyphs into the same new HashMap-style as the
hyatt [Thu, 18 May 2006 07:36:34 +0000 (07:36 +0000)]
    Convert the width map for glyphs into the same new HashMap-style as the
        glyph map for characters.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/FontData.cpp:
        * platform/FontData.h:
        * platform/GlyphWidthMap.cpp: Added.
        * platform/GlyphWidthMap.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rename FontData.mm to FontData.cpp, since it has no obj-c in it.
hyatt [Thu, 18 May 2006 06:21:53 +0000 (06:21 +0000)]
    Rename FontData.mm to FontData.cpp, since it has no obj-c in it.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/FontData.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Split FontData.mm into platform-specific and cross-platform pieces.
hyatt [Thu, 18 May 2006 06:09:30 +0000 (06:09 +0000)]
    Split FontData.mm into platform-specific and cross-platform pieces.

        Reviewed by andersca

        * WebCore.xcodeproj/project.pbxproj:
        * platform/FontData.h:
        * platform/mac/FontData.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * Scripts/do-webcore-rename: Some more future renames.
darin [Thu, 18 May 2006 05:02:36 +0000 (05:02 +0000)]
    * Scripts/do-webcore-rename: Some more future renames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
ap [Thu, 18 May 2006 04:35:06 +0000 (04:35 +0000)]
    Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6915
        fast/js/date-constructor.html testcase is timezone-dependent

        * fast/js/date-constructor-expected.txt:
        * fast/js/resources/date-constructor.js:
        Disable the offending tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14458 268f45cc-cd09-0410-ab3c-d52691b4dbfc