WebKit-https.git
9 years ago[Mac] Some ligatures are applied across different fronts
rniwa@webkit.org [Fri, 12 Apr 2013 16:54:01 +0000 (16:54 +0000)]
[Mac] Some ligatures are applied across different fronts
https://bugs.webkit.org/show_bug.cgi?id=113604

Reviewed by Darin Adler.

The bug was caused by applyFontTransforms applying ligatures without updating the font data in the glyph buffer.

Suppose we have characters AB and A uses font X and B uses font Y. Further suppose that we have ligatures for AB
in Y. The problem was that WithIterator::advanceInternal calls applyFontTransforms on AB to apply this ligature
even though A and B use different fonts. Since X doesn't contain the same ligature for A to be paired with that
of B in X, we get a blank A.

Fixed the bug by resetting lastGlyphCount after calling applyFontTransforms. This ensures that we don't call
applyFontTransforms across different fonts.

No new tests since this requires a variant of Osaka font that doesn't come with OS X.

The bug 114482 tracks the effort to add a test for this bug fix. I've already asked someone to create a custom
font for us so that we can test this bug fix but that's going to a while.

* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] Enable spellchecking tests added in r141471
rniwa@webkit.org [Fri, 12 Apr 2013 16:52:38 +0000 (16:52 +0000)]
[Mac] Enable spellchecking tests added in r141471
https://bugs.webkit.org/show_bug.cgi?id=108525

Reviewed by Darin Adler.

Source/WebCore:

Made automatic quote substitution, dash substitution, text replacement, and spelling correction
togglable via internals object. These functions are no-op when text replacement is not used.

This allows us to disable automatic spelling correction in spellcheck tests.

Enabled several tests added in r141471.

* WebCore.exp.in:
* testing/Internals.cpp:
(WebCore::Internals::setContinuousSpellCheckingEnabled): Don't null check editor() since it's not
null whenever frame() is not null.
(WebCore::Internals::setAutomaticQuoteSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticLinkDetectionEnabled): Added.
(WebCore::Internals::setAutomaticDashSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticTextReplacementEnabled): Added.
(WebCore::Internals::setAutomaticSpellingCorrectionEnabled): Added.
* testing/Internals.h:
* testing/Internals.idl:

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(resetDefaultsToConsistentValues):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Updated the tests not to assume spelling correction suggestions were listed in a context menu since
only Chromium port did this.

* editing/spelling/resources/util.js:
(initSpellTest): Disable automatic text replacements.

* editing/spelling/spelling-with-underscore-selection-expected.txt: Removed.
* editing/spelling/spelling-with-underscore-selection.html: Removed.

This test erroneously assumed a specific word breaking behavior that doesn't include the underscore
when selecting a word especially since Chromium was the only port that was running these tests.

* editing/spelling/spelling-double-clicked-word-with-underscores-expected.txt: Removed.
* editing/spelling/spelling-double-clicked-word-with-underscores.html: Removed.

Ditto.

* editing/spelling/spelling-should-select-single-word-expected.txt: Removed.
* editing/spelling/spelling-should-select-single-word.html: Removed.

Removed since this test doesn't do anything useful without the assertion for the context menu.

* editing/spelling/spelling-double-clicked-word-expected.txt:
* editing/spelling/spelling-double-clicked-word.html:
* editing/spelling/spelling-exactly-selected-word-expected.txt:
* editing/spelling/spelling-exactly-selected-word.html:
* editing/spelling/spelling-with-punctuation-selection-expected.txt:
* editing/spelling/spelling-with-punctuation-selection.html:
* editing/spelling/spelling-with-whitespace-selection-expected.txt:
* editing/spelling/spelling-with-whitespace-selection.html:

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][WK2] Add document-loaded signal to WebKitWebPage
commit-queue@webkit.org [Fri, 12 Apr 2013 16:33:48 +0000 (16:33 +0000)]
[GTK][WK2] Add document-loaded signal to WebKitWebPage
https://bugs.webkit.org/show_bug.cgi?id=110614

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-04-12
Reviewed by Carlos Garcia Campos.

Add a new signal document-loaded to WebKitWebPage that will be emitted
when the DOM document has been loaded for the main frame.

* UIProcess/API/gtk/tests/TestWebExtensions.cpp:
(documentLoadedCallback):
(testDocumentLoadedSignal):
(beforeAll): Add test for document-loaded signal.
* UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(documentLoadedCallback):
(pageCreatedCallback):
(methodCallCallback): Add new D-Bus signal DocumentLoaded in order to
test document-loaded signal.
* WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkit_web_page_class_init):
(webkitWebPageCreate): Add document-loaded signal and emit it when
didFinishDocumentLoadForFrame is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Win] r148257 broke the build
oliver@apple.com [Fri, 12 Apr 2013 16:19:00 +0000 (16:19 +0000)]
[Qt][Win] r148257 broke the build
https://bugs.webkit.org/show_bug.cgi?id=114512

Build fix.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Webkit fails to build webkit2gtk-tests-resources.gresource.
commit-queue@webkit.org [Fri, 12 Apr 2013 16:07:29 +0000 (16:07 +0000)]
[GTK] Webkit fails to build webkit2gtk-tests-resources.gresource.
https://bugs.webkit.org/show_bug.cgi?id=114485

Patch by Hanyee Kim <choco@company100.net> on 2013-04-12
Reviewed by Martin Robinson.

Generating webkit2gtk-tests-resources.gresource can be failed due to
the non-existing target directory.
We need to make target directory before generating it.

* UIProcess/API/gtk/tests/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r145869): Right-click on SWF contents displays the context menu at the...
akling@apple.com [Fri, 12 Apr 2013 15:13:49 +0000 (15:13 +0000)]
REGRESSION(r145869): Right-click on SWF contents displays the context menu at the wrong place.
<http://webkit.org/b/113836>
<rdar://problem/13587624>

Reviewed by Anders "Wesley Crusher" Carlsson.

Mac plugins expect flipped-Y screen coordinates, while DOM APIs speak in unflipped coordinates,
and we were mixing them up in the window frame caching optimization.

Solve this by having the UIProcess send both flipped and unflipped window frames to the WebProcess.
The flipped frame is passed on to plugins, and the unflipped frame is used for window.screenX/Y etc.

* UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowAndViewFrames]):

    No need to retrieve the window frame here as WebPageProxy::windowAndViewFramesChanged() will
    always override it anyway.

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowRect):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndViewFramesChanged):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::windowFrameInUnflippedScreenCoordinates):
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Crash running layout tests
commit-queue@webkit.org [Fri, 12 Apr 2013 14:05:19 +0000 (14:05 +0000)]
[BlackBerry] Crash running layout tests
https://bugs.webkit.org/show_bug.cgi?id=114503

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-12
Reviewed by Xan Lopez.

Hit an assertion in ~GuardedPointerBase when DRT is
deleted. DumpRenderTree class derives from
BlackBerry::Platform::LayoutTestClient that derives from
BlackBerry::Platform::GuardedPointerBase, so the DRT pointer
should no be released with delete but with
BlackBerry::Platform::deleteGuardedObject().

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Enable WebKit2 building on GTK EWSs
commit-queue@webkit.org [Fri, 12 Apr 2013 13:50:58 +0000 (13:50 +0000)]
[GTK] Enable WebKit2 building on GTK EWSs
https://bugs.webkit.org/show_bug.cgi?id=114500

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-04-12
Reviewed by Philippe Normand.

Add configuration in order to be able to setup GTK EWSs building
WebKit2. A new queue gtk-wk2-ews is added.

* QueueStatusServer/config/queues.py:
* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(GtkWK2Port):
(GtkWK2Port.build_webkit_command):
(GtkWK2Port.run_webkit_tests_command):
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest):
(DeprecatedPortTest.test_gtk_wk2_port):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(GtkWK2EWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream the filesystem code
commit-queue@webkit.org [Fri, 12 Apr 2013 13:22:16 +0000 (13:22 +0000)]
[BlackBerry] Upstream the filesystem code
https://bugs.webkit.org/show_bug.cgi?id=114437

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-12
Reviewed by Rob Buis.

These are the changes for AsyncFileSystemBlackBerry.

This patch contains contributions from many members of the
BlackBerry WebKit team.

* platform/blackberry/AsyncFileSystemBlackBerry.cpp:
(WebCore::AsyncFileSystem::isAvailable):
(WebCore):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystemBlackBerry::openFileSystem):
(WebCore::AsyncFileSystem::deleteFileSystem):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::~AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::move):
(WebCore::AsyncFileSystemBlackBerry::copy):
(WebCore::AsyncFileSystemBlackBerry::remove):
(WebCore::AsyncFileSystemBlackBerry::removeRecursively):
(WebCore::AsyncFileSystemBlackBerry::readMetadata):
(WebCore::AsyncFileSystemBlackBerry::createFile):
(WebCore::AsyncFileSystemBlackBerry::createDirectory):
(WebCore::AsyncFileSystemBlackBerry::fileExists):
(WebCore::AsyncFileSystemBlackBerry::directoryExists):
(WebCore::AsyncFileSystemBlackBerry::readDirectory):
(WebCore::AsyncFileSystemBlackBerry::createWriter):
(WebCore::AsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):
(WebCore::AsyncFileSystemBlackBerry::fileSystemURLToPath):
* platform/blackberry/AsyncFileSystemBlackBerry.h:
(WTF):
(WTF::BlackBerry::Platform::WebFileSystem):
(WebCore::AsyncFileSystemBlackBerry::create):
(AsyncFileSystemBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][EFL] WebView: Add callbacks to the WKViewClient to handle page viewport update
mikhail.pozdnyakov@intel.com [Fri, 12 Apr 2013 13:10:28 +0000 (13:10 +0000)]
[WK2][EFL] WebView: Add callbacks to the WKViewClient to handle page viewport update
https://bugs.webkit.org/show_bug.cgi?id=110463

Reviewed by Anders Carlsson.

* UIProcess/efl/ViewClientEfl.h:
(ViewClientEfl):
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::didChangeViewportProperties):
* UIProcess/efl/WebViewClient.cpp:
(WebKit::WebViewClient::didChangeViewportAttributes):
(WebKit):
* UIProcess/efl/WebViewClient.h:

    Added didChangeViewportAttributes callback to the WKViewClient to
    handle page viewport updates.

* CMakeLists.txt:
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* UIProcess/API/C/WKAPICast.h:
(WebKit):
* UIProcess/API/C/WKViewportAttributes.cpp: Added.
(WKViewportAttributesGetTypeID):
* UIProcess/API/C/WKViewportAttributes.h: Added.
* UIProcess/API/C/efl/WKView.h:
* UIProcess/WebViewportAttributes.cpp: Added.
(WebKit):
(WebKit::WebViewportAttributes::WebViewportAttributes):
(WebKit::WebViewportAttributes::~WebViewportAttributes):
* UIProcess/WebViewportAttributes.h: Added.
(WebKit):
(WebViewportAttributes):
(WebKit::WebViewportAttributes::create):
(WebKit::WebViewportAttributes::originalAttributes):
(WebKit::WebViewportAttributes::type):

    Added WKViewportAttributesRef - WK2 C API object that is wrapping
    WebCore::ViewportAttributes structure and is passed in didChangeViewportAttributes
    WKViewClient callback.

* UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeViewportAttributes):
(WebKit):

    Added implementaion of didChangeViewportAttributes WKViewClient
    callback so that existing EFL WK2 funtionality is kept.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoApply our MSVC 2012 optimizer bug workaround to all minor releases
jocelyn.turcotte@digia.com [Fri, 12 Apr 2013 10:54:21 +0000 (10:54 +0000)]
Apply our MSVC 2012 optimizer bug workaround to all minor releases
https://bugs.webkit.org/show_bug.cgi?id=114436

Reviewed by Alexey Proskuryakov.

The bug has only been partially fixed in Update 2 but our Update 1 workaround
still avoids the crash.

* platform/text/TextEncodingRegistry.cpp:
(WebCore::TextEncodingNameHash::equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnd again, with the correct case this time.
mrowe@apple.com [Fri, 12 Apr 2013 10:28:09 +0000 (10:28 +0000)]
And again, with the correct case this time.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mrowe@apple.com [Fri, 12 Apr 2013 10:22:05 +0000 (10:22 +0000)]
Build fix.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
Add missing #include and forward declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Crash running layout tests when WebPage is destroyed
commit-queue@webkit.org [Fri, 12 Apr 2013 09:03:09 +0000 (09:03 +0000)]
[BlackBerry] Crash running layout tests when WebPage is destroyed
https://bugs.webkit.org/show_bug.cgi?id=114497

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-12
Reviewed by Xan Lopez.

PR 324649
Internally reviewed by Konrad Piascik and Rob Buis.

Use a bool member to keep track of whether the inspector is
enabled or not instead of relaying on the enable developer extras
setting, that can be set in other places than enableWebInspector().

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
m_inspectorEnabled.
(BlackBerry::WebKit::WebPage::enableWebInspector): Return early if
inspector is already enabled and set m_inspectorEnabled to true.
(BlackBerry::WebKit::WebPage::disableWebInspector): Return early
if inspector is not enabled and set m_inspectorEnabled to false.
(BlackBerry::WebKit::WebPage::isWebInspectorEnabled): Check the
current value of m_inspectorEnabled instead of the developer
extras setting.
* Api/WebPage_p.h:
(WebPagePrivate): Add m_inspectorEnabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed functionality fix for ports enabling the MicroData feature.
zandobersek@gmail.com [Fri, 12 Apr 2013 08:55:23 +0000 (08:55 +0000)]
Unreviewed functionality fix for ports enabling the MicroData feature.

* html/DOMSettableTokenList.idl: Add the SkipVTableValidation IDL attribute to the DOMSettableTokenList interface.
This removes crashes in the MicroData layout tests that are occurring on EFL and GTK builders, the two ports being
the only ports that enable this feature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Fri, 12 Apr 2013 08:17:30 +0000 (08:17 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/TestExpectations:
* platform/qt/fast/js/global-constructors-expected.txt: Rebaselining after r148236.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] The style of visited links doesn't change in WebKit2
carlosgc@webkit.org [Fri, 12 Apr 2013 08:12:46 +0000 (08:12 +0000)]
[GTK] The style of visited links doesn't change in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112175

Reviewed by Benjamin Poulain.

The problem is that visited links were not tracked by the web
process. There's a web process initial parameter to set whether
web process should track visited links or not and it's disabled by
default.

* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess): Always set
shouldTrackVisitedLinks to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove Chromium scripts
rniwa@webkit.org [Fri, 12 Apr 2013 07:38:15 +0000 (07:38 +0000)]
Remove Chromium scripts
https://bugs.webkit.org/show_bug.cgi?id=114492

Reviewed by Benjamin Poulain.

* Scripts/run-chromium-webkit-unit-tests: Removed.
* Scripts/update-webkit-chromium: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Move CachedRawResourceClient into a separate file
ap@apple.com [Fri, 12 Apr 2013 07:15:57 +0000 (07:15 +0000)]
    Move CachedRawResourceClient into a separate file
        https://bugs.webkit.org/show_bug.cgi?id=114491

        Reviewed by Mark Rowe.

        * GNUmakefile.list.am:
        * Target.pri:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/DocumentLoader.cpp:
        * loader/DocumentLoader.h:
        * loader/DocumentThreadableLoader.h:
        * loader/archive/cf/LegacyWebArchive.cpp:
        * loader/cache/CachedRawResource.cpp:
        * loader/cache/CachedRawResource.h:
        * loader/cache/CachedRawResourceClient.h: Added.
        * loader/icon/IconLoader.h:
        * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r148262.
zandobersek@gmail.com [Fri, 12 Apr 2013 07:14:02 +0000 (07:14 +0000)]
Unreviewed, rolling out r148262.
http://trac.webkit.org/changeset/148262
https://bugs.webkit.org/show_bug.cgi?id=114493

Cairo dep should now build, rolling r148247 back in (Requested
by zdobersek on #webkit).

Patch by Commit Queue <rniwa@webkit.org> on 2013-04-12

.:

* Source/autotools/FindDependencies.m4:
* Source/autotools/PrintBuildConfiguration.m4:
* Source/autotools/SetupWebKitFeatures.m4:

Source/WebCore:

* platform/graphics/GraphicsContext.cpp:
(WebCore):
* platform/graphics/ImageBuffer.cpp:
(WebCore):
* platform/graphics/cairo/GLContext.h:
(GLContext):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore):
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore):
(WebCore::createCairoGLSurface):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::mapSurfaceToImage):
(WebCore::unmapSurfaceFromImage):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBufferData::paintToTextureMapper):
(WebCore::ImageBuffer::platformLayer):
* platform/graphics/cairo/ImageBufferDataCairo.h:
(ImageBufferData):
* platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::~GLContextEGL):
(WebCore::GLContextEGL::cairoDevice):
(WebCore):
* platform/graphics/egl/GLContextEGL.h:
* platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::GLContextGLX):
(WebCore::GLContextGLX::~GLContextGLX):
(WebCore::GLContextGLX::cairoDevice):
(WebCore):
* platform/graphics/glx/GLContextGLX.h:
(GLContextGLX):

Tools:

* Scripts/webkitdirs.pm:
(buildAutotoolsProject):
* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reduce includes of CachedSVGDocument.h
ap@apple.com [Fri, 12 Apr 2013 06:11:46 +0000 (06:11 +0000)]
    Reduce includes of CachedSVGDocument.h
        https://bugs.webkit.org/show_bug.cgi?id=114489

        Reviewed by Jon Honeycutt.

        * loader/cache/CachedSVGDocumentReference.cpp: Added.
        * loader/cache/CachedSVGDocumentReference.h:
        Moved function implementations to newly added .cpp file, and removed an include
        of CachedSVGDocument.h.

        * css/WebKitCSSSVGDocumentValue.h: Just removed an unnecessary include.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * Target.pri:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r148247.
zandobersek@gmail.com [Fri, 12 Apr 2013 06:04:40 +0000 (06:04 +0000)]
Unreviewed, rolling out r148247.
http://trac.webkit.org/changeset/148247
https://bugs.webkit.org/show_bug.cgi?id=114490

Cairo dep fails to build on builders due to missing EGL
headers (Requested by zdobersek on #webkit).

Patch by Commit Queue <rniwa@webkit.org> on 2013-04-11

.:

* Source/autotools/FindDependencies.m4:
* Source/autotools/PrintBuildConfiguration.m4:
* Source/autotools/SetupWebKitFeatures.m4:

Source/WebCore:

* platform/graphics/GraphicsContext.cpp:
(WebCore):
* platform/graphics/ImageBuffer.cpp:
(WebCore):
* platform/graphics/cairo/GLContext.h:
(GLContext):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore):
* platform/graphics/cairo/ImageBufferDataCairo.h:
(ImageBufferData):
* platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::~GLContextEGL):
* platform/graphics/egl/GLContextEGL.h:
* platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::GLContextGLX):
(WebCore::GLContextGLX::~GLContextGLX):
* platform/graphics/glx/GLContextGLX.h:
(GLContextGLX):

Tools:

* Scripts/webkitdirs.pm:
(buildAutotoolsProject):
* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove debugging code that is no longer used with current mac sdks.
thakis@chromium.org [Fri, 12 Apr 2013 05:03:18 +0000 (05:03 +0000)]
Remove debugging code that is no longer used with current mac sdks.
https://bugs.webkit.org/show_bug.cgi?id=114486

Reviewed by Dan Bernstein.

This code compared __MAC_OS_X_VERSION_MAX_ALLOWED and friends to
107 and 106 instead of the correct 1070 and 1060. Instead of fixing
this, rip the code out completely: Since WebKit now only targets
current systems, the ifdef is always false anyways.

No tests, as this only removes debugging code.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix windows build and land new binding test results
oliver@apple.com [Fri, 12 Apr 2013 04:21:45 +0000 (04:21 +0000)]
Fix windows build and land new binding test results

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMerge CharacterClassTable into CharacterClass
benjamin@webkit.org [Fri, 12 Apr 2013 03:42:46 +0000 (03:42 +0000)]
Merge CharacterClassTable into CharacterClass
https://bugs.webkit.org/show_bug.cgi?id=114409

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-11
Reviewed by Darin Adler.

CharacterClassTable is only a pointer and a boolean.
It is a little overkill to make a separate allocation
for that.

* create_regex_tables:
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::matchCharacterClass):
* yarr/YarrPattern.cpp:
(JSC::Yarr::CharacterClassConstructor::charClass):
* yarr/YarrPattern.h:
(CharacterClass):
(JSC::Yarr::CharacterClass::CharacterClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSelection gaps don't repaint correctly with transforms
commit-queue@webkit.org [Fri, 12 Apr 2013 02:38:32 +0000 (02:38 +0000)]
Selection gaps don't repaint correctly with transforms
https://bugs.webkit.org/show_bug.cgi?id=111000

Patch by Shezan Baig <sbaig1@bloomberg.net> on 2013-04-11
Reviewed by Simon Fraser.

Source/WebCore:

When computing offsetFromRepaintContainer, we need to add UseTransforms
to the MapCoordinateFlags argument. Note that ApplyContainerFlip is
the default value for the flag, so this change effectively only adds
the UseTransforms flag.

Tests: fast/repaint/selection-gap-absolute-child.html
       fast/repaint/selection-gap-fixed-child.html
       fast/repaint/selection-gap-flipped-absolute-child.html
       fast/repaint/selection-gap-flipped-fixed-child.html
       fast/repaint/selection-gap-transformed-absolute-child.html
       fast/repaint/selection-gap-transformed-fixed-child.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):

LayoutTests:

* fast/repaint/selection-gap-absolute-child-expected.txt: Added.
* fast/repaint/selection-gap-absolute-child.html: Added.
* fast/repaint/selection-gap-fixed-child-expected.txt: Added.
* fast/repaint/selection-gap-fixed-child.html: Added.
* fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
* fast/repaint/selection-gap-flipped-absolute-child.html: Added.
* fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
* fast/repaint/selection-gap-flipped-fixed-child.html: Added.
* fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
* fast/repaint/selection-gap-transformed-absolute-child.html: Added.
* fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
* fast/repaint/selection-gap-transformed-fixed-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd more type validation to debug builds
oliver@apple.com [Fri, 12 Apr 2013 01:43:23 +0000 (01:43 +0000)]
Add more type validation to debug builds
https://bugs.webkit.org/show_bug.cgi?id=114478

Reviewed by Mark Hahnenberg.

Source/WebCore:

Add a bunch more type checks to the JS DOM bindings.

* Modules/mediastream/MediaStream.idl:
* Modules/webaudio/AudioDestinationNode.idl:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.h:
(WebCore::getExistingWrapper):
(WebCore):
(WebCore::createNewWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
(GetNativeTypeForConversions):
(GetGnuVTableRefForInterface):
(GetGnuVTableNameForInterface):
(GetGnuMangledNameForInterface):
(GetGnuVTableOffsetForType):
(GetWinVTableRefForInterface):
(GetWinVTableNameForInterface):
(GetWinMangledNameForInterface):
(GetNamespaceForInterface):
(GetImplementationLacksVTableForInterface):
(GetSkipVTableValidationForInterface):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* dom/Clipboard.idl:
* dom/DOMStringMap.idl:
* dom/MutationRecord.idl:
* dom/NodeList.idl:
* html/DOMTokenList.idl:
* html/track/TextTrack.idl:
* inspector/ScriptProfileNode.idl:
* storage/Storage.idl:
* xml/XPathNSResolver.idl:

Source/WTF:

Add BINDING_VALIDATION flag and make RELEASE_ASSERT use UNLIKELY.

* wtf/Assertions.h:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove ResourceLoadInfo
rniwa@webkit.org [Fri, 12 Apr 2013 00:50:48 +0000 (00:50 +0000)]
Remove ResourceLoadInfo
https://bugs.webkit.org/show_bug.cgi?id=113302

Reviewed by Benjamin Poulain.

Co-authored by Christophe Dumez.

Removed ResourceLoadInfo since it had been only used by Chromium port.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForResourceResponse):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
* platform/network/ResourceLoadInfo.h: Removed.
* platform/network/ResourceResponseBase.cpp:
(WebCore):
(WebCore::ResourceResponseBase::reportMemoryUsage):
* platform/network/ResourceResponseBase.h:
(ResourceResponseBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove passing test expectations for ietestcenter/css3/grid/grid-items-003.htm since...
rniwa@webkit.org [Fri, 12 Apr 2013 00:50:24 +0000 (00:50 +0000)]
Remove passing test expectations for ietestcenter/css3/grid/grid-items-003.htm since it started failing on
Mountain Lion WebKit2 bots after a slave reboot as well.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSubmission Notes.
lforschler@apple.com [Fri, 12 Apr 2013 00:47:46 +0000 (00:47 +0000)]
Submission Notes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r146956): ASSERTion failure: WebKit::WebProcess::pageWillLeaveWindow
timothy_horton@apple.com [Fri, 12 Apr 2013 00:39:36 +0000 (00:39 +0000)]
REGRESSION (r146956): ASSERTion failure: WebKit::WebProcess::pageWillLeaveWindow
https://bugs.webkit.org/show_bug.cgi?id=114481
<rdar://problem/13534784>

Reviewed by Simon Fraser.

Inform the WebProcess of WebPages which are already in a window when created.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother Mac Lion build fix attempt after r148197.
rniwa@webkit.org [Fri, 12 Apr 2013 00:20:45 +0000 (00:20 +0000)]
Another Mac Lion build fix attempt after r148197.

* page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnable to paste twice in input field when specific CSS present
commit-queue@webkit.org [Fri, 12 Apr 2013 00:08:55 +0000 (00:08 +0000)]
Unable to paste twice in input field when specific CSS present
https://bugs.webkit.org/show_bug.cgi?id=108675

Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2013-04-11
Reviewed by Ryosuke Niwa.

Source/WebCore:

When we are pre-rendering text in ReplaceSelectionCommand, we shouldn't care
whether the content is clipped by its ancestors or not. This bug was caused
by the fact the plainText() method returned an empty string because the text
was fully clipped by its ancestors. Make plainText ignore style visibility.

Test: editing/inserting/insert-text-into-text-field.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):

LayoutTests:

* editing/inserting/insert-text-into-text-field-expected.txt: Added.
* editing/inserting/insert-text-into-text-field.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for clearing storage areas
andersca@apple.com [Thu, 11 Apr 2013 23:55:03 +0000 (23:55 +0000)]
Add support for clearing storage areas
https://bugs.webkit.org/show_bug.cgi?id=114479

Reviewed by Beth Dakin.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::StorageArea):
Store the quota size so we can recreate the underlying StorageMap when clearing.

(WebKit::StorageManager::StorageArea::clear):
Create a new storage map and dispatch events.

(WebKit::StorageManager::clear):
Find the right storage area and call clear.

* UIProcess/Storage/StorageManager.messages.in:
Add Clear message.

* WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::clear):
Call the storage map.

* WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::clear):
Reset the cached values and send a clear message.

(WebKit::StorageAreaMap::resetValues):
New helper function.

(WebKit::StorageAreaMap::didClear):
New stub.

* WebProcess/Storage/StorageAreaMap.messages.in:
Add DidClear message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit should set the header and footer layers' contentsScale when the device
bdakin@apple.com [Thu, 11 Apr 2013 23:51:51 +0000 (23:51 +0000)]
WebKit should set the header and footer layers' contentsScale when the device
scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=114471
-and corresponding-
<rdar://problem/13621288>

Reviewed by Simon Fraser.

Update the header and footer contentsScale when the device scale factor has
changed.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::updateHeaderAndFooterLayersForDeviceScaleChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Webkit fails to build with MinGW compiler after changeset 146468
commit-queue@webkit.org [Thu, 11 Apr 2013 23:46:33 +0000 (23:46 +0000)]
[GTK] Webkit fails to build with MinGW compiler after changeset 146468
https://bugs.webkit.org/show_bug.cgi?id=114473

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-04-11
Reviewed by Martin Robinson.

* Source/autotools/CheckSystemAndBasicDependencies.m4: Fix typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add accelerated 2D canvas support using cairo-gl
mrobinson@webkit.org [Thu, 11 Apr 2013 23:39:44 +0000 (23:39 +0000)]
[GTK] Add accelerated 2D canvas support using cairo-gl
https://bugs.webkit.org/show_bug.cgi?id=104672

Reviewed by Alejandro G. Castro.

.:

Detect that we can activate accelerated canvas when CairoGL is present and
TextureMapperGL is enabled.

* Source/autotools/FindDependencies.m4: Look for CairoGL.
* Source/autotools/PrintBuildConfiguration.m4: Print the status of accelerated canvas activation.
* Source/autotools/SetupWebKitFeatures.m4: Set the feature.

Source/WebCore:

No new tests. We do not yet have the ability to run tests against
accelerated content.

* platform/graphics/GraphicsContext.cpp:
(WebCore): We don't use the stub implementation of isAcceleratedContext any longer.
* platform/graphics/ImageBuffer.cpp:
(WebCore): Ditto for ImageBuffer::platformLayer.
* platform/graphics/cairo/GLContext.h:
(GLContext): Added method to get a cairo_device_t from the context.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::isAcceleratedContext): Return true when we are a CairoGL surface.
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData): Initialize the size and the texture to 0.
(WebCore::createCairoGLSurface): Added this helper.
(WebCore::ImageBuffer::ImageBuffer): When we are in accelerated rendering mode, create
a CairoGL surface.
(WebCore::ImageBuffer::platformTransformColorSpace): Do not implement this for accelerated
contexts yet.
(WebCore::mapSurfaceToImage): Added this helper, since we don't require Cairo 1.12 yet,
which provides an builtin implementation.
(WebCore::unmapSurfaceFromImage): Ditto.
(WebCore::getImageData): Map the surface to an image surface first.
(WebCore::ImageBuffer::putByteArray): Ditto.
(WebCore::ImageBufferData::paintToTextureMapper): Connect the accelerated canvas into the
TextureMapper infrastructure.
(WebCore::ImageBuffer::platformLayer): This lets the TextureMapper at the ImageBufferData.
* platform/graphics/cairo/ImageBufferDataCairo.h:
(ImageBufferData): Subclass TexturMapperPlatformLayer where appropriate.
* platform/graphics/egl/GLContextEGL.cpp: Added implementation of cairoDevice.
* platform/graphics/egl/GLContextEGL.h: Ditto.
* platform/graphics/glx/GLContextGLX.cpp: Ditto
* platform/graphics/glx/GLContextGLX.h: Ditto.

Tools:

Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
dependencies, don't override value of the setting determined by configure.
This will make it easier for people using build-webkit, but not the
WebKit JHBuild.

* Scripts/webkitdirs.pm:
(buildAutotoolsProject): Add a blacklist for settings to never override.
* gtk/jhbuild.modules: Build CairoGL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agobuild.webkit.org should link to webkit-queues instead of webkit-commit-queue
rniwa@webkit.org [Thu, 11 Apr 2013 23:31:20 +0000 (23:31 +0000)]
build.webkit.org should link to webkit-queues instead of webkit-commit-queue
https://bugs.webkit.org/show_bug.cgi?id=114477

Reviewed by Benjamin Poulain.

* BuildSlaveSupport/build.webkit.org-config/templates/root.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement removing storage area items
andersca@apple.com [Thu, 11 Apr 2013 23:26:58 +0000 (23:26 +0000)]
Implement removing storage area items
https://bugs.webkit.org/show_bug.cgi?id=114472

Reviewed by Beth Dakin.

Source/WebCore:

Export StorageMap::removeItem.

* WebCore.exp.in:

Source/WebKit2:

* UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::setItem):
Rename connection to sourceConnection.

(WebKit::StorageManager::StorageArea::removeItem):
Remove the item from the map and dispatch events if needed.

(WebKit::StorageManager::removeItem):
Find the right storage area, remove the item and send back a DidRemoveItem message.

* UIProcess/Storage/StorageManager.messages.in:
Add RemoveItem message.

* WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::removeItem):
Call StorageAreaMap::removeItem.

* WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::removeItem):
Send a RemoveItem message to the storage manager.

(WebKit::StorageAreaMap::didRemoveItem):
Add empty stub.

* WebProcess/Storage/StorageAreaMap.messages.in:
Add DidRemoveItem message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTextTrackList's .onremovetrack is missing from IDL
commit-queue@webkit.org [Thu, 11 Apr 2013 23:25:50 +0000 (23:25 +0000)]
TextTrackList's .onremovetrack is missing from IDL
https://bugs.webkit.org/show_bug.cgi?id=103421

Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-11
Reviewed by Eric Carlson.

Source/WebCore:

Fixed test media/track/opera/interfaces/TextTrackList/onremovetrack.html

* html/track/TextTrackList.cpp:
(TextTrackList::remove):
(TextTrackList::scheduleRemoveTrackEvent):
* html/track/TextTrackList.h:
(TextTrackList):
* html/track/TextTrackList.idl:

LayoutTests:

* media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLeaks builder should not be triggered upon new commits
rniwa@webkit.org [Thu, 11 Apr 2013 23:20:57 +0000 (23:20 +0000)]
Leaks builder should not be triggered upon new commits
https://bugs.webkit.org/show_bug.cgi?id=114475

Reviewed by Jessie Berlin.

Don't trigger them on new checkins wait for Mountaion Lion (Build), which already triggers
the leak builder when builds are done.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream the filesystem code
commit-queue@webkit.org [Thu, 11 Apr 2013 23:09:49 +0000 (23:09 +0000)]
[BlackBerry] Upstream the filesystem code
https://bugs.webkit.org/show_bug.cgi?id=114437

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-11
Reviewed by Rob Buis.

This patch contains contributions from many members of the
BlackBerry WebKit team.

* platform/blackberry/AsyncFileWriterBlackBerry.cpp: Added.
(WebCore):
(WebCore::AsyncFileWriterBlackBerry::write):
* platform/blackberry/AsyncFileWriterBlackBerry.h: Added.
(WTF):
(WTF::BlackBerry::Platform::WebFileWriter):
(WebCore):
* platform/blackberry/DOMFileSystemBlackBerry.cpp: Added.
(WebCore):
(WebCore::DOMFileSystemBase::createFileSystemURL):
(WebCore::DOMFileSystemBase::crackFileSystemURL):
(WebCore::DOMFileSystemBase::supportsToURL):
(WebCore::DOMFileSystemBase::isValidType):
* platform/blackberry/LocalFileSystemBlackBerry.cpp: Added.
(WebCore):
(WebCore::fileSystemTypeString):
(WebCore::openFileSystem):
(WebCore::LocalFileSystem::deleteFileSystem):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):
* platform/blackberry/PlatformAsyncFileSystemCallbacks.cpp: Added.
(WebCore):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyOpenFileSystem):
(WebCore::PlatformAsyncFileSystemCallbacks::notifySucceed):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyFail):
(WebCore::getFileMetadata):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyReadMetadata):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyCreateSnapshotFileAndReadMetadata):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyReadDirectory):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyCreateFileWriter):
(WebCore::PlatformAsyncFileSystemCallbacks::createAsyncFileSystem):
(WebCore::PlatformAsyncFileSystemCallbacks::createAsyncFileWriter):
(WebCore::PlatformAsyncFileSystemCallbacks::deleteMe):
* platform/blackberry/PlatformAsyncFileSystemCallbacks.h: Added.
(WebCore):
* platform/blackberry/PlatformBlob.cpp: Added.
(WebCore):
(WebCore::PlatformBlob::nextDataItem):
* platform/blackberry/PlatformBlob.h: Added.
(WebCore):
* platform/blackberry/PlatformFileWriterClient.cpp: Added.
(WebCore):
(WebCore::PlatformFileWriterClient::notifyWrite):
(WebCore::PlatformFileWriterClient::notifyTruncate):
(WebCore::PlatformFileWriterClient::notifyFail):
* platform/blackberry/PlatformFileWriterClient.h: Added.
(WebCore):
(WTF):
(WTF::WebCore::PlatformFileWriterClient):
* platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp: Added.
(WebCore):
(WebCore::WorkerAsyncFileSystemBlackBerry::WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::~WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::waitForOperationToComplete):
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystem):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystem):
(WebCore::WorkerAsyncFileSystemBlackBerry::move):
(WebCore::WorkerAsyncFileSystemBlackBerry::copy):
(WebCore::WorkerAsyncFileSystemBlackBerry::remove):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursively):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadata):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFile):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectory):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExists):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExists):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectory):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriter):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):
* platform/blackberry/WorkerAsyncFileSystemBlackBerry.h: Added.
(WebCore):
(WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::create):
* platform/blackberry/WorkerAsyncFileWriterBlackBerry.cpp: Added.
(WebCore):
(WebCore::WorkerAsyncFileWriterBlackBerry::writeOnMainThread):
(WebCore::WorkerAsyncFileWriterBlackBerry::truncateOnMainThread):
(WebCore::WorkerAsyncFileWriterBlackBerry::abortOnMainThread):
(WebCore::WorkerAsyncFileWriterBlackBerry::write):
(WebCore::WorkerAsyncFileWriterBlackBerry::truncate):
(WebCore::WorkerAsyncFileWriterBlackBerry::abort):
(WebCore::WorkerAsyncFileWriterBlackBerry::waitForOperationToComplete):
(WebCore::WorkerAsyncFileWriterBlackBerry::platformWriterClient):
* platform/blackberry/WorkerAsyncFileWriterBlackBerry.h: Added.
(WebCore):
* platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp: Added.
(WebCore):
(WebCore::performTaskOnMainThread):
(WebCore::postTaskToMainThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyStop):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyOpenFileSystem):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifySucceed):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyFail):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadMetadata):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadDirectory):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateFileWriter):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::createAsyncFileSystem):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::createAsyncFileWriter):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::deleteMe):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::postTaskToWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyOpenFileSystemOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifySucceedOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyFailOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadMetadataOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadDirectoryEntryOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateFileWriterOnWorkerThread):
* platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h: Added.
(WebCore):
* platform/blackberry/WorkerPlatformFileWriterClient.cpp: Added.
(WebCore):
(WebCore::WorkerPlatformFileWriterClient::notifyWriteOnWorkerThread):
(WebCore::WorkerPlatformFileWriterClient::notifyFailOnWorkerThread):
(WebCore::WorkerPlatformFileWriterClient::notifyTruncateOnWorkerThread):
(WebCore::WorkerPlatformFileWriterClient::notifyWrite):
(WebCore::WorkerPlatformFileWriterClient::notifyTruncate):
(WebCore::WorkerPlatformFileWriterClient::notifyFail):
(WebCore::WorkerPlatformFileWriterClient::postTaskToWorkerThreadIfNeeded):
* platform/blackberry/WorkerPlatformFileWriterClient.h: Added.
(WebCore):
(WTF):
(WTF::WebCore::WorkerPlatformFileWriterClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
roger_fong@apple.com [Thu, 11 Apr 2013 23:04:31 +0000 (23:04 +0000)]
Build fix.

* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago <rdar://problem/10416316> [Mac] WebSocket doesn't work with authenticating...
ap@apple.com [Thu, 11 Apr 2013 22:56:53 +0000 (22:56 +0000)]
    <rdar://problem/10416316> [Mac] WebSocket doesn't work with authenticating proxies
        https://bugs.webkit.org/show_bug.cgi?id=114464

        Update WebKitSystemInterface.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLion.a:
        * libWebKitSystemInterfaceMountainLion.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac Lion build fix attempt after r148197.
rniwa@webkit.org [Thu, 11 Apr 2013 22:17:57 +0000 (22:17 +0000)]
Mac Lion build fix attempt after r148197.

* page/scrolling/mac/ScrollingStateNodeMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInjectedBundleNodeHandle::imageForRect doesn't respect device scale factor or highlig...
timothy_horton@apple.com [Thu, 11 Apr 2013 21:50:03 +0000 (21:50 +0000)]
InjectedBundleNodeHandle::imageForRect doesn't respect device scale factor or highlighting option
https://bugs.webkit.org/show_bug.cgi?id=114466
<rdar://problem/13508513>

Reviewed by Simon Fraser.

Respect the device scale factor when creating the snapshot image.
Clear the snapshot image before drawing into it.
Respect SnapshotOptionsExcludeSelectionHighlighting.

* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::imageForRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago <rdar://problem/10416316> [Mac] WebSocket doesn't work with authenticating...
ap@apple.com [Thu, 11 Apr 2013 21:42:44 +0000 (21:42 +0000)]
    <rdar://problem/10416316> [Mac] WebSocket doesn't work with authenticating proxies
        https://bugs.webkit.org/show_bug.cgi?id=114464

        Reviewed by Brady Eidson.

        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
        Updated for new wkCopyCONNECTProxyResponse signature.

        * platform/network/cf/SocketStreamHandleCFNet.cpp:
        (WebCore::SocketStreamHandle::executePACFileURL): Fixed a typo in a comment.
        (WebCore::SocketStreamHandle::addCONNECTCredentials): Don't crash even if the rest
        of the fix didn't work (which would be the case on some OS versions).
        (WebCore::SocketStreamHandle::readStreamCallback): Replaced most breaks with returns,
        because breaks were confusing in such a huge switch. Changed null proxyResponse
        to not be treated as authentication success, because it's not. Merged two parts
        of WaitingForConnect state handling for clarity.
        (WebCore::SocketStreamHandle::writeStreamCallback): Don't blindly assume that we
        can start WebSocket handshake after kCFStreamEventCanAcceptBytes. Perhaps it's
        nothing but a failed CONNECT, and a read callback still needs to send authentication.
        Without this, establishing connections was flaky. Added a check for Closed state,
        matching read callback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMutationRecord is not exposed
commit-queue@webkit.org [Thu, 11 Apr 2013 21:41:28 +0000 (21:41 +0000)]
MutationRecord is not exposed
https://bugs.webkit.org/show_bug.cgi?id=114288

Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2013-04-11
Reviewed by Darin Adler.

Source/WebCore:

Expose MutationRecord on DOMWindow. This patch is copied from a patch
by Adam Klein. https://codereview.chromium.org/13861028

Test: fast/dom/MutationObserver/mutation-record-constructor.html

* page/DOMWindow.idl:

LayoutTests:

This test is copied from a patch by Adam Klein.
https://codereview.chromium.org/13861028
The test expectation of "typeof MutationRecord" is changed from
"function" to "object". (See bug 114457)

* fast/dom/MutationObserver/mutation-record-constructor-expected.txt: Added.
* fast/dom/MutationObserver/mutation-record-constructor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCannot scroll to footer on a page with overflow:hidden on the body
bdakin@apple.com [Thu, 11 Apr 2013 21:01:07 +0000 (21:01 +0000)]
Cannot scroll to footer on a page with overflow:hidden on the body
https://bugs.webkit.org/show_bug.cgi?id=114462
-and corresponding-
<rdar://problem/13530042>

Reviewed by Simon Fraser.

Add a new scenario in which we want to overrideHidden -- whenever we are the
mainFrame and there is a header or footer.

* page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r148034, r148052, r148097, and
rniwa@webkit.org [Thu, 11 Apr 2013 20:53:25 +0000 (20:53 +0000)]
Unreviewed, rolling out r148034, r148052, r148097, and
r148194.
http://trac.webkit.org/changeset/148034
http://trac.webkit.org/changeset/148052
http://trac.webkit.org/changeset/148097
http://trac.webkit.org/changeset/148194
https://bugs.webkit.org/show_bug.cgi?id=114463

broke mutiresolution favicons, among other things (Requested
by thorton on #webkit).

Source/WebCore:

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::setIconDataForIconURL):
* loader/icon/IconDatabase.h:
(IconDatabase):
* loader/icon/IconDatabaseBase.h:
* loader/icon/IconRecord.cpp:
* loader/icon/IconRecord.h:
(IconRecord):

Source/WebKit2:

* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::setIconDataForIconURL):
* UIProcess/WebIconDatabase.h:
(WebIconDatabase):
* UIProcess/WebIconDatabase.messages.in:
* WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][AC] Implement GraphicsLayerClutter::moveOrCopyAnimations
commit-queue@webkit.org [Thu, 11 Apr 2013 20:51:50 +0000 (20:51 +0000)]
[GTK][AC] Implement GraphicsLayerClutter::moveOrCopyAnimations
https://bugs.webkit.org/show_bug.cgi?id=114019

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-04-11
Reviewed by Gustavo Noronha Silva.

Fill moveOrCopyAnimations that is based on Mac port implementation.

Tests: animations/3d/change-transform-in-end-event.html
       animations/3d/transform-origin-vs-functions.html
       compositing/animation/state-at-end-event-transform-layer.html

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::moveOrCopyLayerAnimation):
(WebCore):
(WebCore::GraphicsLayerClutter::moveOrCopyAnimations):
* platform/graphics/clutter/GraphicsLayerClutter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement StorageManager::getValues
andersca@apple.com [Thu, 11 Apr 2013 20:34:00 +0000 (20:34 +0000)]
Implement StorageManager::getValues
https://bugs.webkit.org/show_bug.cgi?id=114461

Reviewed by Beth Dakin.

Source/WebCore:

Expose the item hash map.

* storage/StorageMap.h:
(WebCore::StorageMap::items):

Source/WebKit2:

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::items):
(WebKit::StorageManager::getValues):
Return the items from the right storage area.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Windows build failure after r136056
commit-queue@webkit.org [Thu, 11 Apr 2013 20:22:34 +0000 (20:22 +0000)]
[GTK] Windows build failure after r136056
https://bugs.webkit.org/show_bug.cgi?id=114121

Patch by Kalev Lember <kalevlember@gmail.com> on 2013-04-11
Reviewed by Martin Robinson.

* TestWebKitAPI/config.h: Make sure defines are correct for other
Windows ports than apple-win.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up related storage areas when a connection is destroyed
andersca@apple.com [Thu, 11 Apr 2013 20:14:45 +0000 (20:14 +0000)]
Clean up related storage areas when a connection is destroyed
https://bugs.webkit.org/show_bug.cgi?id=114459

Reviewed by Beth Dakin.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::processWillCloseConnection):
Dispatch invalidateConnectionInternal on the work queue.

(WebKit::StorageManager::createStorageMap):
(WebKit::StorageManager::destroyStorageMap):
Rename m_storageAreas to m_storageAreasByConnection.

(WebKit::StorageManager::invalidateConnectionInternal):
Go over all known storage areas and remove this connection as a listener.

(WebKit::StorageManager::findStorageArea):
Rename m_storageAreas to m_storageAreasByConnection.

* UIProcess/Storage/StorageManager.h:
Rename m_storageAreas to m_storageAreasByConnection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Use the platform list of languages with fonts instead of hardcoding
commit-queue@webkit.org [Thu, 11 Apr 2013 20:08:32 +0000 (20:08 +0000)]
[BlackBerry] Use the platform list of languages with fonts instead of hardcoding
https://bugs.webkit.org/show_bug.cgi?id=114452

Patch by Eli Fidler <efidler@blackberry.com> on 2013-04-11
Reviewed by Rob Buis.

BlackBerry PR 325244
Internally reviewed by Jeff Rogers

No functional change, but platform font changes won't need a WebKit change
going forward.

* page/blackberry/SettingsBlackBerry.cpp:
(WebCore::Settings::initializeDefaultFontFamilies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Shaders] Parse parameters descriptor
krit@webkit.org [Thu, 11 Apr 2013 20:05:17 +0000 (20:05 +0000)]
[CSS Shaders] Parse parameters descriptor
https://bugs.webkit.org/show_bug.cgi?id=114455

Reviewed by Dean Jackson.

Source/WebCore:

Add support for the 'parameters' descriptor in the filter at-rule to support
parameterization of CSS Shaders.

https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters

Tests: css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid.html
       css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp: Added 'parameters' property and fail parsing if not inside
    of an @filter rule.
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilterRuleParameters): New helper function to verify
    values.
(WebCore):
* css/CSSParser.h:
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in: Added new property name 'parameters'.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

LayoutTests:

Tests for the 'parameters' descriptor on @filter rule.

* css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid.html: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid.html: Added.
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js: Added.
(testInvalidParametersProperty):
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js: Added.
(testParametersProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of the 10ms delay between test executions
fpizlo@apple.com [Thu, 11 Apr 2013 20:01:55 +0000 (20:01 +0000)]
Get rid of the 10ms delay between test executions
https://bugs.webkit.org/show_bug.cgi?id=114458
<rdar://problem/13631112>

Reviewed by Darin Adler and Geoffrey Garen.

More details on this in the bug. Long story short, I don't know why the 10ms delay is
there, and it appears to be the root of some noisyness and unreliability in the results.
Removing it makes results more consistent, which is a good thing.

* resources/driver-TEMPLATE.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Initial scale changes depending on the order of page navigations
zhajiang@rim.com [Thu, 11 Apr 2013 19:56:36 +0000 (19:56 +0000)]
[BlackBerry] Initial scale changes depending on the order of page navigations
https://bugs.webkit.org/show_bug.cgi?id=114448

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.

PR: 323941
During page transitions, absoluteVisibleOverflowSize() and contentsSize()
in fixedLayoutSize() were based on the old page when we just started or
committed provisinal load. In that case, fixedLayoutSize() is very old
page dependent and can cause inconsistent behaviors. For example, if
the old page contents width is 4000, we will get DEFAULT_MAX_LAYOUT_WIDTH 1024
as the new page's fixedLayoutSize; however, we will get 768 if we
navigate to the new page directly.
To fix that, return default layout size if the page doesn't have
virtual viewport and m_loadState is Provisional.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDefault Implementation of toString for NPObject shouldn't return NPClass & NPObject...
commit-queue@webkit.org [Thu, 11 Apr 2013 19:37:22 +0000 (19:37 +0000)]
Default Implementation of toString for NPObject shouldn't return NPClass & NPObject address as String
https://bugs.webkit.org/show_bug.cgi?id=114450

Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-04-11
Reviewed by Anders Carlsson.

* bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::stringValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (142152): ensure we skip past out-of-flow objects when detecting whitespac...
robert@webkit.org [Thu, 11 Apr 2013 19:17:12 +0000 (19:17 +0000)]
REGRESSION (142152): ensure we skip past out-of-flow objects when detecting whitespace to ignore after leading empty inlines
https://bugs.webkit.org/show_bug.cgi?id=114311

Reviewed by Emil A Eklund.

Source/WebCore:

When we hit an empty inline in line layout and try to detect whether it has any whitespace after it that we ought to ignore, then
we need to skip past out-of-flow and floating objects when looking for that whitespace. Failure to do so will result in us
adding the width from the first space we encounter to our line width and over-estimating the real width of the line.

We're hitting this bug now because we have broadened the category of empty inlines that get lineboxes so we go into line layout
and have to deal with them and their subsequent whitespace there. Previously this sort of whitespace would have been simply
consumed by |skipLeadingWhitespace|.

Test: fast/inline/out-of-flow-objects-and-whitespace-after-empty-inline.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::shouldSkipWhitespaceAfterStartObject):

LayoutTests:

* fast/inline/out-of-flow-objects-and-whitespace-after-empty-inline-expected.txt: Added.
* fast/inline/out-of-flow-objects-and-whitespace-after-empty-inline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove myself from watchlists.
ojan@chromium.org [Thu, 11 Apr 2013 19:14:01 +0000 (19:14 +0000)]
Remove myself from watchlists.
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAutocorrected text doesn't have a marker of type autocorrected
rniwa@webkit.org [Thu, 11 Apr 2013 18:56:16 +0000 (18:56 +0000)]
Autocorrected text doesn't have a marker of type autocorrected
https://bugs.webkit.org/show_bug.cgi?id=114337

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by markAndReplaceFor's text replacement errornously assuming that there are
no other text checking result starting at the same offset. That resulted in us adjusting location
offsets of the subsequent results pointing at the replaced text, hit an assertion, and blow up.

Fixed the bug by skipping all remaining results for the replaced text since they're no longer
applicable.

Tests: Existing autocorection tests have been updated to assert new behavior.

* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):

LayoutTests:

Updated tests to assert the existence of "autocorrected" markers.

* platform/mac/editing/spelling/click-autocorrected-word-expected.png:
* platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/click-autocorrected-word.html:
* platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
* platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/delete-into-autocorrected-word.html:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Shaders] Parse the geometry descriptor
michelangelo@webkit.org [Thu, 11 Apr 2013 18:54:09 +0000 (18:54 +0000)]
[CSS Shaders] Parse the geometry descriptor
https://bugs.webkit.org/show_bug.cgi?id=110815

Source/WebCore:

Added initial parsing for the "geometry" descriptor, as per specification:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#geometry
This descriptor allows to specify the mesh geometry for custom filters.

Reviewed by Dirk Schulze.

Tests: css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid.html
       css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGeometry): New method that parses the geometry
descriptor (grid()).
(WebCore):
* css/CSSParser.h:
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in: Added conditional "geometry" property.
* css/CSSValueKeywords.in: Added conditional "attached" value keyword; detached
was already there.

LayoutTests:

Positive and negative parsing tests for the "geometry" descriptor as
per specification:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#geometry

Reviewed by Dirk Schulze.

* css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid-expected.txt: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid.html: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid-expected.txt: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid.html: Added.
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-geometry-property-invalid.js: Added.
(testInvalidGeometryProperty):
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-geometry-property-valid.js: Added.
(testGeometryProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake StorageAreaMap dispatch session storage events
andersca@apple.com [Thu, 11 Apr 2013 18:43:40 +0000 (18:43 +0000)]
Make StorageAreaMap dispatch session storage events
https://bugs.webkit.org/show_bug.cgi?id=114454

Reviewed by Beth Dakin.

Source/WebCore:

Export storage symbols and headers needed by WebKit2.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

* WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::dispatchStorageEvent):
Depending on the storage area type, call dispatchSessionStorageEvent or dispatchLocalStorageEvent.

(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
Enumerate all the frames in our page and dispatch the event to the relevant ones.

(WebKit::StorageAreaMap::dispatchLocalStorageEvent):
Add empty stub for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
zandobersek@gmail.com [Thu, 11 Apr 2013 18:39:06 +0000 (18:39 +0000)]
Unreviewed.

* Source/autotools/symbols.filter: Stop exporting redundant symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 11 Apr 2013 18:27:00 +0000 (18:27 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Removing expectations for a bunch of tests that are passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix. Don't hard-code queues.webkit.org at least during the transition.
rniwa@webkit.org [Thu, 11 Apr 2013 18:19:12 +0000 (18:19 +0000)]
Build fix. Don't hard-code queues.webkit.org at least during the transition.

* QueueStatusServer/templates/statusbubble.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement more logic in StorageAreaMap
andersca@apple.com [Thu, 11 Apr 2013 17:44:17 +0000 (17:44 +0000)]
Implement more logic in StorageAreaMap
https://bugs.webkit.org/show_bug.cgi?id=114451

Reviewed by Alexey Proskuryakov.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add new overload.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::addListener):
(WebKit::StorageManager::StorageArea::removeListener):
These take storage map IDs.

(WebKit::StorageManager::StorageArea::setItem):
Rename storageAreaID to sourceStorageAreaID.

(WebKit::StorageManager::StorageArea::dispatchEvents):
Remove the code that would not dispatch to the source connection, there may still be storage areas interested in those events.

(WebKit::StorageManager::setItem):
This now takes the source storage area ID.

(WebKit::StorageManager::findStorageArea):
This takes a storage map ID.

* UIProcess/Storage/StorageManager.messages.in:
SetItem now takes the source storage area ID as well.

* WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::setItem):
Pass the source frame to StorageAreaMap::setItem.

* WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::StorageAreaMap):
Send CreateStorageMap and add the object as a message receiver.

(WebKit::StorageAreaMap::~StorageAreaMap):
Send DestroyStorageMap and remove the object as a message receiver.

(WebKit::StorageAreaMap::length):
(WebKit::StorageAreaMap::key):
(WebKit::StorageAreaMap::item):
(WebKit::StorageAreaMap::contains):
Load values and forward calls to the storage map.

(WebKit::StorageAreaMap::setItem):
This now takes the source frame as well. Update the local storage map and send a SetItem message.

(WebKit::StorageAreaMap::loadValuesIfNeeded):
Get the values from the storage manager.

(WebKit::StorageAreaMap::dispatchStorageEvent):
This now takes the source storage area ID.

* WebProcess/Storage/StorageAreaMap.messages.in:
DispatchStorageEvent now takes the source storage area ID.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb/Plugin process deadlock initializing async plugins.
beidson@apple.com [Thu, 11 Apr 2013 17:18:07 +0000 (17:18 +0000)]
Web/Plugin process deadlock initializing async plugins.
<rdar://problem/13525232> and https://bugs.webkit.org/show_bug.cgi?id=114217

Rubberstamped by Anders Carlsson.

Rollout r147953 and r147968 as we identified other causes for this.

Source/WebKit2:

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPluginAsynchronously):
* WebProcess/Plugins/PluginProxy.messages.in:

LayoutTests:

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Run toString & valueOf LayoutTests for WebKit2 also
commit-queue@webkit.org [Thu, 11 Apr 2013 17:02:44 +0000 (17:02 +0000)]
[WK2] Run toString & valueOf LayoutTests for WebKit2 also
https://bugs.webkit.org/show_bug.cgi?id=114433

Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-04-11
Reviewed by Anders Carlsson.

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
rniwa@webkit.org [Thu, 11 Apr 2013 16:55:47 +0000 (16:55 +0000)]
Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114397

Reviewed by Benjamin Poulain.

Reland the patch since Alan appears to have finished the migration.

* Scripts/webkitpy/common/net/statusserver.py:
(StatusServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohandleMouseMoveEvent should let hit-testing hit-test scrollbars
allan.jensen@digia.com [Thu, 11 Apr 2013 16:52:29 +0000 (16:52 +0000)]
handleMouseMoveEvent should let hit-testing hit-test scrollbars
https://bugs.webkit.org/show_bug.cgi?id=114430

Reviewed by Antonio Gomes.

Allow hit-testing to hit-test frame scrollbars so handleMouseMoveEvent
does not have to do it itself.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsi...
commit-queue@webkit.org [Thu, 11 Apr 2013 16:38:32 +0000 (16:38 +0000)]
[Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
https://bugs.webkit.org/show_bug.cgi?id=76796

Patch by Brian Holt <brian.holt@samsung.com> on 2013-04-11
Reviewed by Chris Fleizach.

Source/WebCore:

When using caret-browsing with the right and left arrows, the
behaviour of menuLists should be the same as listBoxes. This means
not default-handling the event and passing it up the stack instead.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):

Tools:

Make the Gtk window for the DRT a toplevel so that it gets the
focus from the window manager when the test starts.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(main):

LayoutTests:

Adding a new test to verify that it is possible to arrow out of
combo boxes when caret browsing is enabled. Updated failing tests
to reflect changed accessibility events in the DRT.

* platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Updated.
* platform/gtk/accessibility/caret-browsing-select-focus-expected.txt: Added.
* platform/gtk/accessibility/caret-browsing-select-focus.html: Added.
* platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove some ResourceHandle.h includes
ap@apple.com [Thu, 11 Apr 2013 16:32:24 +0000 (16:32 +0000)]
Remove some ResourceHandle.h includes
https://bugs.webkit.org/show_bug.cgi?id=114416

Reviewed by Ryosuke Niwa.

Source/WebCore:

* loader/CrossOriginAccessControl.h:
* loader/CrossOriginPreflightResultCache.h:
These files don't need ResourceHandle.h, just ResourceHandleTypes.h.

* loader/TextTrackLoader.cpp:
* loader/ThreadableLoader.h:
* loader/appcache/ApplicationCacheGroup.h:
* loader/cache/MemoryCache.h:
* loader/mac/ResourceLoaderMac.mm:
* page/Settings.cpp:
* platform/network/AuthenticationChallengeBase.cpp:
* platform/network/cf/CookieJarCFNet.cpp:
* platform/network/cf/ResourceRequestCFNet.cpp:
* xml/XSLTProcessorLibxslt.cpp:
* xml/parser/XMLDocumentParser.cpp:
* xml/parser/XMLDocumentParserLibxml2.cpp:
Just straightforward removal of includes.

Source/WebKit2:

* WebProcess/Network/NetworkProcessConnection.cpp: Added an include that is now
necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse CSS4 image-rendering to determing image scaling quality
allan.jensen@digia.com [Thu, 11 Apr 2013 16:19:39 +0000 (16:19 +0000)]
Use CSS4 image-rendering to determing image scaling quality
https://bugs.webkit.org/show_bug.cgi?id=113405

Reviewed by Simon Fraser.

Source/WebCore:

Implement the new CSS4 image-rendering property values.

Image scaling now uses low-quality (pixelated) scaling for
crisp-edges, pixelated and optimizeSpeed values, and always
use high quality (smooth) scaling for -webkit-smooth and
optimizeQuality. The latter can be used to disable low quality
scaling during CSS animations or live resizing.

The new values are protected with a new CSS4_IMAGES feature, but
the crisp-edge value has been introduced before to displace the
deprecated -webkit-optimize-contrast value, and optimizeSpeed
and optimizeQuality values are supported for SVG compatibility.

* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
* css/CSSValueKeywords.in:
* rendering/RenderBoxModelObject.cpp:
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
* rendering/style/RenderStyleConstants.h:

Tools:

Introduce new flag to enable experimental support for CSS4 Images.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded UNLIKELY() suggested in https://bugs.webkit.org/show_bug.cgi?id=114366
msaboff@apple.com [Thu, 11 Apr 2013 16:19:35 +0000 (16:19 +0000)]
Added UNLIKELY() suggested in https://bugs.webkit.org/show_bug.cgi?id=114366
after checking in the original change.

Rubber-stamped by Jessie Berlin.

* dfg/DFGOperations.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix: use of uninitialized variable in ScrollingStateTree
commit-queue@webkit.org [Thu, 11 Apr 2013 16:02:20 +0000 (16:02 +0000)]
Build fix: use of uninitialized variable in ScrollingStateTree
https://bugs.webkit.org/show_bug.cgi?id=114443

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-04-11
Reviewed by Anders Carlsson.

Initialize pointer to zero before use, fixes build.
No new tests, no changes on behavior.

* page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Shaders] Parse mix descriptor
krit@webkit.org [Thu, 11 Apr 2013 15:55:25 +0000 (15:55 +0000)]
[CSS Shaders] Parse mix descriptor
https://bugs.webkit.org/show_bug.cgi?id=114414

Reviewed by Antti Koivisto.

Source/WebCore:

Add support for the 'mix' descriptor in the filter at-rule to support blend modes
and composite operators in CSS Shaders.
Each pixel in the fragment shader will be blended and composited with the
backdrop by taking these values into account.

https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-mix

Tests: css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid.html
       css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp: Added 'mix' property and fail parsing if not inside
    of an @filter rule.
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilterRuleMix): New helper function to verify
    values.
(WebCore):
* css/CSSParser.h:
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in: Added new property name 'mix'.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

LayoutTests:

Tests for the 'mix' descriptor on @filter rule.

* css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid-expected.txt: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid.html: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid-expected.txt: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid.html: Added.
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-mix-property-invalid.js: Added.
(testInvalidMixProperty):
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-mix-property-valid.js: Added.
(testMixProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Linking fails with Qt 5.1
abecsi@webkit.org [Thu, 11 Apr 2013 15:09:53 +0000 (15:09 +0000)]
[Qt][Mac] Linking fails with Qt 5.1
https://bugs.webkit.org/show_bug.cgi?id=114435

Reviewed by Tor Arne Vestbø.

Qt 5.1 enables C++11 by default when using clang on Mac
and links against the libc++ standard library. As a result
building the QtWebKit shared library fails when linking
agains the ANGLE intermediate static library because libc++
misses some symbols needed by ANGLE.
Disable C++11 for the ANGLE intermediate library to fix the build.

* ANGLE.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoParent box with background-size auto and gradient image does not get properly repaint...
commit-queue@webkit.org [Thu, 11 Apr 2013 14:51:08 +0000 (14:51 +0000)]
Parent box with background-size auto and gradient image does not get properly repainted when child box is resized.
https://bugs.webkit.org/show_bug.cgi?id=114424

Source/WebCore:

Patch by Zalan Bujtas <zalan@apple.com> on 2013-04-11
Reviewed by Antti Koivisto.

Initiate full repaint on fill layer, when the image is generated and the background
property defines auto size.
http://www.w3.org/TR/css3-background/#background-size
'If the image has neither an intrinsic width nor an intrinsic height, its size is determined as for 'contain'.'

Extended fast/repaint/background-shorthand-with-gradient-and-height-changes.html
to cover this case too.

* rendering/RenderObject.cpp:
(WebCore::mustRepaintFillLayers):

LayoutTests:

Patch by Zalan Bujtas <zalan@apple.com> on 2013-04-11
Reviewed by Antti Koivisto.

* fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt:
* fast/repaint/background-shorthand-with-gradient-and-height-changes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][AC] use a smart pointer for GList and ClutterCanvas
commit-queue@webkit.org [Thu, 11 Apr 2013 14:42:14 +0000 (14:42 +0000)]
[GTK][AC] use a smart pointer for GList and ClutterCanvas
https://bugs.webkit.org/show_bug.cgi?id=114057

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-04-11
Reviewed by Gustavo Noronha Silva.

We can make simple code & prevent possible memory leak by using a proper smart pointer.
Especially if we get children by clutter_actor_get_children, we should free it after using.

No functionality changed.

* platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):
(graphicsLayerActorRemoveAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry][CSS Filters] Blur filter fails to recompute blur size when layer size...
anilsson@rim.com [Thu, 11 Apr 2013 14:36:22 +0000 (14:36 +0000)]
[BlackBerry][CSS Filters] Blur filter fails to recompute blur size when layer size changes
https://bugs.webkit.org/show_bug.cgi?id=114272

Reviewed by Rob Buis.

Blur appeared blocky or pixelated when surface changed size after
creating the filter actions. The initial image size was used to
determine the blur size (expressed in texture coordinate system).
Fixed by recomputing the blur size when the surface size changes, using
a new Uniform1f subclass that can use a functor to compute the uniform
value per-frame.

This fixes css3/filters/effect-blur-hw.html. This can only be verified
by manual inspection because the BlackBerry port is not currently using
pixel tests.

PR 323730

* platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore):
(SurfaceFunctor):
(WebCore::SurfaceFunctor::SurfaceFunctor):
(InverseSurfaceWidth):
(WebCore::InverseSurfaceWidth::InverseSurfaceWidth):
(WebCore::InverseSurfaceWidth::operator()):
(InverseSurfaceHeight):
(WebCore::InverseSurfaceHeight::InverseSurfaceHeight):
(WebCore::LayerFilterRenderer::actionsForOperations):
* platform/graphics/blackberry/LayerFilterRenderer.h:
(Uniform1f):
(WebCore):
(Uniform1fWithFunctor):
(WebCore::Uniform1fWithFunctor::create):
(WebCore::Uniform1fWithFunctor::Uniform1fWithFunctor):
(WebCore::Uniform1fWithFunctor::apply):
(WebCore::Uniform1f::createWithFunctor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Accelerated compositing debug rectangle incorrectly drawn for layers...
anilsson@rim.com [Thu, 11 Apr 2013 14:28:00 +0000 (14:28 +0000)]
[BlackBerry] Accelerated compositing debug rectangle incorrectly drawn for layers with surfaces
https://bugs.webkit.org/show_bug.cgi?id=114275

Reviewed by Carlos Garcia Campos.

The drawDebugBorder method was updated to mirror the logic in
compositeLayersRecursive, i.e. if we're compositing a surface to the
screen, use the transformed bounds stored in the surface. The bounds
stored in the layer should only be used when drawing the layer to the
surface.

Speaking of which, also update the code to skip border drawing when
drawing a layer to a surface. Drawing the borders inside the surface
would only result in messing up the surface contents, especially when
CSS filters like blur were the reason for having a surface in the first
place - the border would be blurred and hard to discern.

Only manually testable, the debug border is disabled during layout
tests.

PR 323746

* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::drawDebugBorder):
* platform/graphics/blackberry/LayerRendererSurface.cpp:
(WebCore::LayerRendererSurface::drawRect):
(WebCore::LayerRendererSurface::transformedBounds): Added.
(WebCore):
* platform/graphics/blackberry/LayerRendererSurface.h:
(LayerRendererSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Compiler warning in LayerWebKitThread.cpp
anilsson@rim.com [Thu, 11 Apr 2013 14:27:14 +0000 (14:27 +0000)]
[BlackBerry] Compiler warning in LayerWebKitThread.cpp
https://bugs.webkit.org/show_bug.cgi?id=114277

Reviewed by Carlos Garcia Campos.

All the relevant WTF::Vector APIs use size_t, storing the position in
an int resulted in a compiler warning. Fixed by switching to size_t.

No change in behavior, no new tests.

PR 323753

* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::remove):
(WebCore::LayerWebKitThread::replaceSublayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CoordinatedGraphics] Use ScrollingStateTree to handle fixed elements positioning...
mikhail.pozdnyakov@intel.com [Thu, 11 Apr 2013 13:16:20 +0000 (13:16 +0000)]
[CoordinatedGraphics] Use ScrollingStateTree to handle fixed elements positioning while scrolling
https://bugs.webkit.org/show_bug.cgi?id=114353

Reviewed by Noam Rosenthal.

ScrollingCoordinatorCoordinatedGraphics should implement threaded scrolling interface and
re-use threaded scrolling approach (ScrollingStateTree and ViewportConstraints) to handle
fixed/sticky elements positioning while scrolling. The rationals are below.

Before the change ScrollingCoordinatorCoordinatedGraphics was implementing Chromium-specific
interface which is going to be removed eventually as there is no ScrollingCoordinatorChromium
existing.

Tested by existing manual tests (fixed-position.html for example.

* CMakeLists.txt:
* Target.pri:
    Included ScrollingStateTree files.

* page/scrolling/ScrollingStateFixedNode.cpp:
* page/scrolling/ScrollingStateFixedNode.h:
* page/scrolling/ScrollingStateNode.cpp:
* page/scrolling/ScrollingStateNode.h:
* page/scrolling/ScrollingStateScrollingNode.cpp:
* page/scrolling/ScrollingStateScrollingNode.h:
* page/scrolling/ScrollingStateStickyNode.cpp:
* page/scrolling/ScrollingStateStickyNode.h:
* page/scrolling/ScrollingStateTree.cpp:
* page/scrolling/ScrollingStateTree.h:
    Removed ENABLE(THREADED_SCROLLING) code guards.

* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::~ScrollingCoordinatorCoordinatedGraphics):
(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::attachToStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::detachFromStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::clearStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateViewportConstrainedNode):
* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
    ScrollingCoordinatorCoordinatedGraphics is using threaded scrolling approach to handle fixed
    elements positioning while scrolling.

(WebCore):
(ScrollingCoordinatorCoordinatedGraphics):
* page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp: Added.
(WebCore):
(WebCore::ScrollingStateNode::platformScrollLayer):
(WebCore::ScrollingStateNode::setScrollPlatformLayer):
(WebCore::ScrollingStateNode::setScrollLayer):
* page/scrolling/coordinatedgraphics/ScrollingStateScrollingNodeCoordinatedGraphics.cpp: Added.
(WebCore):
(WebCore::ScrollingStateScrollingNode::counterScrollingPlatformLayer):
(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Remove platform specific expected after r148195.
zarvai@inf.u-szeged.hu [Thu, 11 Apr 2013 12:49:34 +0000 (12:49 +0000)]
[Qt] Unreviewed gardening. Remove platform specific expected after r148195.

* platform/qt/fast/events/backspace-navigates-back-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] EventHandler should handle Space and BackSpace
allan.jensen@digia.com [Thu, 11 Apr 2013 11:46:18 +0000 (11:46 +0000)]
[Qt] EventHandler should handle Space and BackSpace
https://bugs.webkit.org/show_bug.cgi?id=114428

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Enable default space-handling for Qt.

* page/EventHandler.cpp:

Source/WebKit/qt:

Remove our own handling of space and backspace.

* WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::handleScrolling):
* WidgetApi/qwebpage.cpp:
(QWebPagePrivate::keyPressEvent):

Source/WebKit2:

Remove our own handling of space and backspace.

* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIconDatabase: Simplify boolean logic in assertion.
rakuco@webkit.org [Thu, 11 Apr 2013 11:37:53 +0000 (11:37 +0000)]
IconDatabase: Simplify boolean logic in assertion.
https://bugs.webkit.org/show_bug.cgi?id=114425

Reviewed by Andreas Kling.

Follow-up to r148097; drop the overzealous use of !! to turn a
PassRefPtr into a boolean.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::updateIconRecord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardending. Greening bots.
zarvai@inf.u-szeged.hu [Thu, 11 Apr 2013 11:28:13 +0000 (11:28 +0000)]
[Qt] Unreviewed gardending. Greening bots.

* platform/qt-5.0-wk1/loader/go-back-cached-main-resource-expected.txt: Rebaselining after r148182.
* platform/qt-5.0-wk2/loader/go-back-cached-main-resource-expected.txt: Rebaselining after r148182.
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] LayerTexture refactoring
anilsson@rim.com [Thu, 11 Apr 2013 11:11:44 +0000 (11:11 +0000)]
[BlackBerry] LayerTexture refactoring
https://bugs.webkit.org/show_bug.cgi?id=114276

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Remove the GpuHandle and HostType typedefs from LayerTexture, they
don't make any sense now that we removed the Skia code paths. With Skia
they used to be an OpenGL texture ID and an SkBitmap respectively, but
now it's just BlackBerry::Platform::Graphics::Buffer all around.

This allows us to rename textureId() into buffer() which is more to the
point. The texture ID concept is now up for grabs and can be used to
consolidate all the various code for extracting an OpenGL texture from
a BlackBerry::Platform::Graphics::Buffer. This opportunity is seized in
LayerTexture::platformTexture(), a name which makes more sense than
textureId() for anyone familiar with the GraphicsContext3D code. We can
also leverage the Platform3DObject typedef to avoid including gl2.h.

The vertex attribute state was getting trampled when interacting with
BlackBerry::Platform::Graphics in the LayerFilterRenderer. Some
additional GL state save/restore incantations when accessing the OpenGL
texture for a LayerTexture in the new LayerTexture::platformTexture()
method fixes various CSS Filters test cases.

Since we removed the Skia integration from LayerTiler, nobody cares
about the dirty rect, tile rect or opaqueness of the tile contents. So
remove those parameters from the updateContents code path.

No change in behavior except for fixing CSS Filters tests like
css3/filters/effect-blur-hw.html. This can only be verified by manually
looking at the tests, we don't have pixel test support to catch this
kind of regression.

PR 322882

* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawSurface):
* platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::ping):
(WebCore::LayerFilterRenderer::pong):
(WebCore::LayerFilterRenderer::pushSnapshot):
(WebCore::LayerFilterRenderer::popSnapshot):
(WebCore::LayerFilterRenderer::applyActions):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::useSurface):
* platform/graphics/blackberry/LayerTexture.cpp:
(WebCore::LayerTexture::LayerTexture):
(WebCore::LayerTexture::updateContents):
(WebCore::LayerTexture::setContentsToColor):
(WebCore::LayerTexture::protect):
(WebCore::LayerTexture::platformTexture):
(WebCore):
* platform/graphics/blackberry/LayerTexture.h:
(WebCore::LayerTexture::isDirty):
(WebCore::LayerTexture::buffer):
(LayerTexture):
(WebCore::LayerTexture::setBuffer):
* platform/graphics/blackberry/LayerTile.cpp:
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):
* platform/graphics/blackberry/LayerTile.h:
(WebCore::LayerTile::hasTexture):
(LayerTile):
* platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTile):
* platform/graphics/blackberry/LayerTiler.h:
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):
(LayerTiler):
* platform/graphics/blackberry/TextureCacheCompositingThread.cpp:
(WebCore::TextureCacheCompositingThread::createBuffer):
(WebCore::TextureCacheCompositingThread::collectGarbage):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::textureForContents):
(WebCore::TextureCacheCompositingThread::updateContents):
* platform/graphics/blackberry/TextureCacheCompositingThread.h:
(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):

Source/WebKit/blackberry:

Adapt to the LayerTexture refactoring down in WebCore.

PR 322882

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove code for Chromium from wkbuild.py
rniwa@webkit.org [Thu, 11 Apr 2013 10:00:33 +0000 (10:00 +0000)]
Remove code for Chromium from wkbuild.py
https://bugs.webkit.org/show_bug.cgi?id=114423

Reviewed by Benjamin Poulain.

* BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):
* BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
(ShouldBuildTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] RenderThemeBlackBerry: upstream missing code
commit-queue@webkit.org [Thu, 11 Apr 2013 09:49:05 +0000 (09:49 +0000)]
[BlackBerry] RenderThemeBlackBerry: upstream missing code
https://bugs.webkit.org/show_bug.cgi?id=114343

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-11
Reviewed by Xan Lopez.

Add implementations of sliderTickSize() and
sliderTickOffsetFromTrackCenter(), as well as a missing header.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::RenderThemeBlackBerry::sliderTickSize):
(WebCore::RenderThemeBlackBerry::sliderTickOffsetFromTrackCenter):
* platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHitTestRequest::AllowFrameScrollbars does not test main frame scrollbar
allan.jensen@digia.com [Thu, 11 Apr 2013 09:17:33 +0000 (09:17 +0000)]
HitTestRequest::AllowFrameScrollbars does not test main frame scrollbar
https://bugs.webkit.org/show_bug.cgi?id=112563

Reviewed by Antonio Gomes.

Move the frame scrollbar testing from RenderPart to RenderView, so that it is
tested by all frame and not just child frames. At the same time remove the
main frame test from the one current callsite using the option.

Tested by fast/events/touch/gesture/gesture-scrollbar.html.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* rendering/RenderPart.cpp:
(WebCore::RenderPart::nodeAtPoint):
* rendering/RenderView.cpp:
(WebCore::RenderView::hitTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update my IRC nickname.
philn@webkit.org [Thu, 11 Apr 2013 09:09:07 +0000 (09:09 +0000)]
Unreviewed, update my IRC nickname.

* Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncorrect evaluation of resolution media queries
commit-queue@webkit.org [Thu, 11 Apr 2013 09:00:22 +0000 (09:00 +0000)]
Incorrect evaluation of resolution media queries
https://bugs.webkit.org/show_bug.cgi?id=114029

Patch by Rune Lillesveen <rune@opera.com> on 2013-04-11
Reviewed by Kenneth Rohde Christiansen.

.:

Removed setResolutionOverride from exports.

* Source/autotools/symbols.filter:

Source/WebCore:

The implementation used the physical resolution to evaluate the
resolution media features. Changed to use the actual CSS resolution,
also known as the device-pixel-ratio, instead. Unified the code for
evaluating the resolution and device-pixel-ratio media features.

No new tests, covered by existing tests.

* WebCore.exp.in:
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isResolution):
* css/MediaQueryEvaluator.cpp:
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
* page/Screen.cpp:
* page/Screen.h:
* page/Settings.cpp:
(WebCore):
* page/Settings.h:
(Settings):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
(Backup):
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit:

Removed setResolutionOverride from exports.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

Removed setResolutionOverride from exports.

* WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

Modified tests to change CSS resolution instead of physical resolution.

* fast/media/mq-resolution.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the rest of Chromium code from webkitpy
rniwa@webkit.org [Thu, 11 Apr 2013 08:46:28 +0000 (08:46 +0000)]
Remove the rest of Chromium code from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=114420

Reviewed by Benjamin Poulain.

* Scripts/webkitpy/common/config/urls.py:
(view_revision_url):
* Scripts/webkitpy/common/host.py:
(Host._engage_awesome_locale_hacks):
(Host.initialize_scm):
(Host):
* Scripts/webkitpy/common/host_mock.py:
(MockHost.__init__):
(MockHost.checkout):
* Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase._insert_generic_metadata):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._tokenize_line):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(ExpectationSyntaxTests.test_bare_name_and_bugs):
(ExpectationSyntaxTests.test_warnings):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.skips_perf_test):
(Port.path_to_test_expectations_file):
(Port._port_flag_for_scripts):
* Scripts/webkitpy/style/checkers/cpp.py:
(check_function_definition):
(check_include_line):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(OrderOfIncludesTest.test_check_wtf_includes):
(WebKitStyleTest.test_webkit_export_check):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_valid_expectations):
* Scripts/webkitpy/tool/bot/irc_command.py:
(Rollout.execute):
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):
* Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):
* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
(SheriffBotTest.test_command_aliases):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoroll-chromium-deps doesn't roll DEPS
rniwa@webkit.org [Thu, 11 Apr 2013 08:29:35 +0000 (08:29 +0000)]
roll-chromium-deps doesn't roll DEPS
https://bugs.webkit.org/show_bug.cgi?id=114421

Reviewed by Antti Koivisto.

Roll DEPS. Rolling DEPS. Rolled DEPS.

* Scripts/webkitpy/tool/bot/irc_command.py:
(RollChromiumDEPS.execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
glenn@skynav.com [Thu, 11 Apr 2013 08:27:06 +0000 (08:27 +0000)]
[webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
https://bugs.webkit.org/show_bug.cgi?id=114418

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/common/checkout/scm/scm_mock.py:
(MockSCM.add): Remove optional remove_exit_code argument.
(MockSCM.add_list): Remove optional remove_exit_code argument and return value.
* Scripts/webkitpy/tool/servers/rebaselineserver.py:
(_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
(_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFrameLoaderClient::assignIdentifierToInitialRequest() not called for the main resourc...
carlosgc@webkit.org [Thu, 11 Apr 2013 08:25:51 +0000 (08:25 +0000)]
FrameLoaderClient::assignIdentifierToInitialRequest() not called for the main resource when loaded from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=112418

Source/WebCore:

Reviewed by Darin Adler.

When the main resource is loaded from the memory cache the
response is not added to the ResponseVector of the document
loader, so that when committing the provisional load the remaining
delegate messages are not called because the ResponseVector of the
document loader is empty. When the main resource is loaded from
the memory cache, there's no resource loader, and the client is
notified about the response received using
ResourceLoadNotifier::dispatchDidReceiveResponse() directly
instead of ResourceLoadNotifier::didReceiveResponse() which is the
one adding the response to the ResponseVector of the document
loader. So, the problem can be fixed by adding the response to the
ResponseVector before calling dispatchDidReceiveResponse() when
loading the main resource without a resource loade

Test: loader/go-back-cached-main-resource.html

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):

LayoutTests:

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-04-11
Reviewed by Darin Adler.

* loader/go-back-cached-main-resource-expected.txt: Added.
* loader/go-back-cached-main-resource.html: Added.
* loader/resources/first-page.html: Added.
* loader/resources/other-page.html: Added.
* platform/gtk-wk1/loader/go-back-cached-main-resource-expected.txt: Added.
* platform/wk2/loader/go-back-cached-main-resource-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix roll-chromium-deps and hi.
rniwa@webkit.org [Thu, 11 Apr 2013 07:45:34 +0000 (07:45 +0000)]
Fix roll-chromium-deps and hi.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Hi.execute):
(RollChromiumDEPS.execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148181 268f45cc-cd09-0410-ab3c-d52691b4dbfc