WebKit-https.git
9 years agoUnreviewed, rolling out r112489.
commit-queue@webkit.org [Fri, 30 Mar 2012 13:17:16 +0000 (13:17 +0000)]
Unreviewed, rolling out r112489.
http://trac.webkit.org/changeset/112489
https://bugs.webkit.org/show_bug.cgi?id=82725

Tentatively introduces a lot of webfont-related test flakiness
on Snow Leopard (Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-30

* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::getFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
keishi@webkit.org [Fri, 30 Mar 2012 13:15:27 +0000 (13:15 +0000)]
Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
https://bugs.webkit.org/show_bug.cgi?id=80972

Reviewed by Kent Tamura.

.:

* Source/cmake/OptionsBlackBerry.cmake:
* configure.ac:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* WebCore.exp.in:
* css/html.css:
* html/ColorInputType.cpp:
* html/ColorInputType.h:
* html/HTMLInputElement.cpp:
(WebCore):
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
(WebCore::createInputTypeFactoryMap):
(WebCore):
(InputTypeNames):
* html/InputType.h:
(InputType):
(InputTypeNames):
* loader/EmptyClients.h:
(EmptyChromeClient):
* page/Chrome.cpp:
(WebCore):
* page/Chrome.h:
(WebCore):
(Chrome):
* page/ChromeClient.h:
(WebCore):
(ChromeClient):
* platform/ColorChooser.h:
* platform/ColorChooserClient.h:
* testing/InternalSettings.cpp:
* testing/Internals.cpp:
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataEnableFeatures.in:
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isColorInputField):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertInputType):

Source/WebKit/chromium:

* features.gypi:
* src/ChromeClientImpl.cpp:
(WebKit):
* src/ChromeClientImpl.h:
(WebCore):
(ChromeClientImpl):
* src/ColorChooserProxy.cpp:
* src/ColorChooserProxy.h:
* src/WebColorChooserClientImpl.cpp:
* src/WebColorChooserClientImpl.h:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:
* qmake/mkspecs/features/features.prf:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

* platform/efl/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] EventLoop::platformInit() obsolete.
charles.wei@torchmobile.com.cn [Fri, 30 Mar 2012 13:12:21 +0000 (13:12 +0000)]
[BlackBerry] EventLoop::platformInit() obsolete.
https://bugs.webkit.org/show_bug.cgi?id=82709

Reviewed by Rob Buis.

No new tests, build fix for BlackBerry porting.

* platform/blackberry/EventLoopBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: ScriptsNavigator should open scripts with single click (not double...
vsevik@chromium.org [Fri, 30 Mar 2012 13:10:07 +0000 (13:10 +0000)]
Web Inspector: ScriptsNavigator should open scripts with single click (not double click).
https://bugs.webkit.org/show_bug.cgi?id=82723

Reviewed by Pavel Feldman.

This patch makes ScriptsNavigator open scripts with single click.

* inspector/front-end/ScriptsNavigator.js:
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, update expectations.
apavlov@chromium.org [Fri, 30 Mar 2012 12:50:31 +0000 (12:50 +0000)]
[Chromium] Unreviewed, update expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add more ENABLERS to cmakeconfig.h.cmake
charles.wei@torchmobile.com.cn [Fri, 30 Mar 2012 12:27:36 +0000 (12:27 +0000)]
[BlackBerry] Add more ENABLERS to cmakeconfig.h.cmake
https://bugs.webkit.org/show_bug.cgi?id=82594

Reviewed by Rob Buis.

Upstreaming feature enablers in cmakeconfig.h.cmake for BlackBerry porting,
and clean up obsolete MACROs in OptionsBlackBerry.cmake.

* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmakeconfig.h.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIDLParser.pm should be able to parse sequence<T> as method argument.
commit-queue@webkit.org [Fri, 30 Mar 2012 11:54:00 +0000 (11:54 +0000)]
IDLParser.pm should be able to parse sequence<T> as method argument.
https://bugs.webkit.org/show_bug.cgi?id=82599

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-30
Reviewed by Kentaro Hara.

With this patch IDL parser should support sequence<T> as method argument.
Current behaviour is argument name is not parsed hence shows empty spaces instead.

Tests: bindings/scripts/test/TestObj.idl

* bindings/scripts/CodeGeneratorCPP.pm:
(SkipFunction): Skip functions for specific type.
(SkipAttribute): Skip functions for specific type.
(AddIncludesForType): Skip header for sequence<T> type.
(GenerateHeader): Skip header and declaration for sequence<T> type.
(GenerateImplementation): Skip header and implementation for sequence<T> type.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skip functions for sequence<T> type.
* bindings/scripts/CodeGeneratorObjC.pm:
(SkipFunction): Skip functions for specific type.
(SkipAttribute): Skip functions for specific type.
(AddForwardDeclarationsForType): Skip header for sequence<T> type.
(AddIncludesForType): Skip header for sequence<T> type.
(GenerateHeader):Skip header and declaration for sequence<T> type.
(GenerateImplementation): Skip header and implementation for sequence<T> type.
* bindings/scripts/CodeGeneratorV8.pm:
(CreateCustomSignature): Add appropriate headers.
* bindings/scripts/IDLStructure.pm: Add support to parse sequence<T>.
* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Modified results from run-binding-tests.
(WebDOMTestObj::objMethodWithArgs):
* bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
(webkit_dom_test_obj_obj_method_with_args):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
* bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::TestObjInternal::methodWithSequenceArgCallback):
(WebCore::ConfigureV8TestObjTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: editing resets line-ending of the whole file
pfeldman@chromium.org [Fri, 30 Mar 2012 11:36:15 +0000 (11:36 +0000)]
Web Inspector: editing resets line-ending of the whole file
https://bugs.webkit.org/show_bug.cgi?id=82708

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change splits TextEditorModel's setText into setText (for initialization) and
editRange (for editing). Distinguishing between the two allowed properly detecting
the preferred line endings.

Test: inspector/editor/text-editor-line-breaks.html

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setContent):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorCommand):
(WebInspector.TextEditorModel):
(WebInspector.TextEditorModel.endsWithBracketRegex.):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._textChanged):
(WebInspector.TextEditorMainPanel.prototype._unindentLines.get var):
(WebInspector.TextEditorMainPanel.prototype._unindentLines):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._editRange):

LayoutTests:

* inspector/editor/highlighter-basics.html:
* inspector/editor/highlighter-long-line.html:
* inspector/editor/highlighter-paste-in-comment.html:
* inspector/editor/indentation.html:
* inspector/editor/text-editor-line-breaks-expected.txt: Added.
* inspector/editor/text-editor-line-breaks.html: Added.
* inspector/editor/text-editor-model.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
kkristof@inf.u-szeged.hu [Fri, 30 Mar 2012 11:00:01 +0000 (11:00 +0000)]
[Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
https://bugs.webkit.org/show_bug.cgi?id=82195

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-29
Reviewed by Simon Hausmann.

Source/WebKit/qt:

* declarative/experimental/plugin.cpp:
* declarative/plugin.cpp:
(WebKitQmlPlugin::initializeEngine):

Source/WebKit2:

* UIProcess/API/qt/qquicknetworkreply_p.h:
* UIProcess/API/qt/qquicknetworkrequest_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebiconimageprovider_p.h:
* UIProcess/API/qt/qwebnavigationhistory.cpp:
* UIProcess/API/qt/qwebnavigationhistory_p.h:
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
* UIProcess/qt/QtDialogRunner.cpp:
(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::initForAuthentication):
(QtDialogRunner::initForProxyAuthentication):
(QtDialogRunner::initForCertificateVerification):
(QtDialogRunner::initForFilePicker):
(QtDialogRunner::initForDatabaseQuotaDialog):
(QtDialogRunner::createDialog):
* UIProcess/qt/QtFlickProvider.cpp:
* UIProcess/qt/QtFlickProvider.h:
(QtFlickProvider):
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::createItem):
(WebKit::WebPopupMenuProxyQt::createContext):

Tools:

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
* MiniBrowser/qt/main.cpp:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Take IndexedDB support out of experiments.
vsevik@chromium.org [Fri, 30 Mar 2012 10:14:15 +0000 (10:14 +0000)]
Web Inspector: Take IndexedDB support out of experiments.
https://bugs.webkit.org/show_bug.cgi?id=82635

Reviewed by Pavel Feldman.

Source/WebCore:

This patch takes inspector IndexedDB support out of experiments and enables tests.

Test: http/tests/inspector/indexeddb/resources-panel.html

* inspector/front-end/ResourcesPanel.js:
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):

LayoutTests:

* http/tests/inspector/indexeddb/resources-panel.html: Renamed from LayoutTests/http/tests/inspector/indexeddb/resources-panel.html_disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, more CRASH expectations for BUGWK82505 added.
apavlov@chromium.org [Fri, 30 Mar 2012 10:06:49 +0000 (10:06 +0000)]
[Chromium] Unreviewed, more CRASH expectations for BUGWK82505 added.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix after r112482.
paroga@webkit.org [Fri, 30 Mar 2012 10:03:00 +0000 (10:03 +0000)]
Build fix after r112482.

* platform/network/cf/FormDataStreamCFNet.h: Added missing forward decleration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Implement LayoutTestController::setMinimumTimerInterval
commit-queue@webkit.org [Fri, 30 Mar 2012 09:46:03 +0000 (09:46 +0000)]
[EFL] Implement LayoutTestController::setMinimumTimerInterval
https://bugs.webkit.org/show_bug.cgi?id=81220

Tools:

Add missing implementation setMinimumTimerInterval to EFL's
LayoutTestController so that we can unskip related tests from the skip list.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-30
Reviewed by Philippe Normand.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setMinimumTimerInterval):

LayoutTests:

Unskip tests connected with setMinimumTimerInterval.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-30
Reviewed by Philippe Normand.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] WebAudio channelSize issue
philn@webkit.org [Fri, 30 Mar 2012 07:45:32 +0000 (07:45 +0000)]
[GTK] WebAudio channelSize issue
https://bugs.webkit.org/show_bug.cgi?id=81905

Reviewed by Martin Robinson.

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::handleBuffer): Calculate the audio
buffer duration and frames number from the buffer and caps instead
of relying on the buffer offets that are not always correctly set
depending on the audio file format.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r112582 and r112391.
philn@webkit.org [Fri, 30 Mar 2012 07:43:10 +0000 (07:43 +0000)]
Unreviewed, GTK rebaseline after r112582 and r112391.

* platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
* platform/gtk/svg/custom/preserve-aspect-ratio-syntax-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Filters] Trigger a repaint on elements with changed filter
achicu@adobe.com [Fri, 30 Mar 2012 05:07:06 +0000 (05:07 +0000)]
[CSS Filters] Trigger a repaint on elements with changed filter
https://bugs.webkit.org/show_bug.cgi?id=82521

Reviewed by Dean Jackson.

Source/WebCore:

I've added ContextSensitivePropertyFilter and changed RenderStyle::diff to use it when
the filter property is changed. In RenderObject::adjustStyleDifference the appropriate StyleDifferenceRepaintLayer
or StyleDifferenceRecompositeLayer is used depending on whether the layer is painting filters in software or in hardware
(composited).

Tests: css3/filters/filter-change-repaint-composited.html
       css3/filters/filter-change-repaint.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createFilterOperations): None was treated as an invalid value.
* platform/graphics/ca/mac/PlatformCALayerMac.mm: Shadows were remaining behind. Fixed that.
(PlatformCALayer::setFilters):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleWillChange): Repaint the layer when there is a layout change and a filter change.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged): Making sure that the backing store is repainted when filters fallback to hardware.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::adjustStyleDifference):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyleConstants.h:

LayoutTests:

Repaint was not triggered when the filter property was changed. I've added two
tests, one for software and one for composited mode. Both tests are triggering
all the possible scenarios of changing the filter property.

* css3/filters/filter-change-repaint-composited-expected.png: Added.
* css3/filters/filter-change-repaint-composited-expected.txt: Added.
* css3/filters/filter-change-repaint-composited.html: Added.
* css3/filters/filter-change-repaint-expected.png: Added.
* css3/filters/filter-change-repaint-expected.txt: Added.
* css3/filters/filter-change-repaint.html: Added.
* platform/chromium/test_expectations.txt: Disabled the new tests on Chromium. They need rebaselining.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVertical flow support for OpenType fonts with the least platform dependencies
commit-queue@webkit.org [Fri, 30 Mar 2012 03:44:14 +0000 (03:44 +0000)]
Vertical flow support for OpenType fonts with the least platform dependencies
https://bugs.webkit.org/show_bug.cgi?id=81326

Patch by Koji Ishii <kojiishi@gmail.com> on 2012-03-29
Reviewed by Dan Bernstein.

This patch introduces a new class OpenTypeVerticalData to read
vertical font metrics from OpenType fonts.

Currently, WebKit relies on platform APIs to do the work. However,
some platforms such as Windows lack support for all the capabilities
WebKit requires for vertical flow and the text-orientation property
to work correctly. Reading OpenType tables directly also gives
benefits in consistent behavior among the WebKit platforms.

This patch is for any platforms that want to parse OpenType tables
directly, but it's currently included only in CGWin and isn't on any
code path even on CGWin yet. Caller's side change for CGWin and
support for other platforms will be in separate bugs.

No new tests are required. No behavior changes.

* WebCore.vcproj/WebCore.vcproj: Added OpenTypeTypes.h and OpenTypeVerticalData.h/cpp.
* platform/SharedBuffer.cpp: Add create(size_t)
(WebCore::SharedBuffer::SharedBuffer):
(WebCore):
* platform/SharedBuffer.h: Add create(size_t)
(WebCore::SharedBuffer::create):
(SharedBuffer):
* platform/graphics/FontPlatformData.h: Added openTypeTable().
(WebCore):
(FontPlatformData):
* platform/graphics/SimpleFontData.h: Added sizePerUnit().
(WebCore::SimpleFontData::sizePerUnit): size() / unitsPerEm() for less multiplication.
* platform/graphics/opentype/OpenTypeTypes.h: Added OpenType basic type definitions.
(OpenType):
(WebCore::OpenType::BigEndianShort::operator short):
(WebCore::OpenType::BigEndianShort::BigEndianShort):
(BigEndianShort):
(WebCore::OpenType::BigEndianUShort::operator unsigned short):
(WebCore::OpenType::BigEndianUShort::BigEndianUShort):
(BigEndianUShort):
(WebCore::OpenType::BigEndianLong::operator int):
(WebCore::OpenType::BigEndianLong::BigEndianLong):
(BigEndianLong):
(WebCore::OpenType::BigEndianULong::operator unsigned):
(WebCore::OpenType::BigEndianULong::BigEndianULong):
(BigEndianULong):
* platform/graphics/opentype/OpenTypeVerticalData.cpp: Added.
(OpenType):
(HheaTable):
(VheaTable):
(Entry):
(VORGTable):
(VertOriginYMetrics):
(WebCore::OpenType::VORGTable::requiredSize):
(WebCore):
(WebCore::validatedPtr):
(WebCore::OpenTypeVerticalData::OpenTypeVerticalData):
(WebCore::OpenTypeVerticalData::advanceHeight): Advance height for a glyph.
(WebCore::OpenTypeVerticalData::getVerticalTranslationsForGlyphs): Vertical origin.
* platform/graphics/opentype/OpenTypeVerticalData.h: Added.
(WebCore):
(OpenTypeVerticalData): A new class to handle vertical flow data in OpenType.
(WebCore::OpenTypeVerticalData::isOpenType):
(WebCore::OpenTypeVerticalData::hasVerticalMetrics):
(WebCore::OpenTypeVerticalData::hasVORG):
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore):
(WebCore::FontPlatformData::openTypeTable): Implemented openTypeTable() for Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Sync up PlatformMouseEvent
leo.yang@torchmobile.com.cn [Fri, 30 Mar 2012 03:31:45 +0000 (03:31 +0000)]
[BlackBerry] Sync up PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=82567

Reviewed by Rob Buis.

This patch is adding blackberry specific members to PlatformMouseEvent.
Also re-base PlatformMouseEventBlackBerry to adapt to the re-factor
of PlatformMouseEvent.

* platform/PlatformMouseEvent.h:
(PlatformMouseEvent): BlackBerry specific constructor.
(WebCore::PlatformMouseEvent::inputMethod): Input source of mouse event
for blackberry platform.
* platform/blackberry/PlatformMouseEventBlackBerry.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent): Re-base the constructor
to adapt the re-factor of PlatformMouseEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Turn on STORE_FONT_CUSTOM_PLATFORM_DATA in CachedFont.cpp
leo.yang@torchmobile.com.cn [Fri, 30 Mar 2012 03:04:25 +0000 (03:04 +0000)]
[BlackBerry] Turn on STORE_FONT_CUSTOM_PLATFORM_DATA in CachedFont.cpp
https://bugs.webkit.org/show_bug.cgi?id=82573

Reviewed by Rob Buis.

Tests: covered by existing tests.

* loader/cache/CachedFont.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Attempt to fix the component build
abarth@webkit.org [Fri, 30 Mar 2012 03:02:04 +0000 (03:02 +0000)]
[Chromium] Attempt to fix the component build
https://bugs.webkit.org/show_bug.cgi?id=82676

Reviewed by Dirk Pranke.

Now that we're implementing some of the WEBKIT_EXPORT symbols in
WebCore/platform/chromium/support, we need to tell the build system
that we want to actually export these symbols.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved “Intel” from the Lion builders’ names.
mitz@apple.com [Fri, 30 Mar 2012 01:57:59 +0000 (01:57 +0000)]
Removed “Intel” from the Lion builders’ names.

Rubber-stamped by Mark Rowe.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer._displayURLPrompt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r112572.
abarth@webkit.org [Fri, 30 Mar 2012 01:37:07 +0000 (01:37 +0000)]
Unreviewed, rolling out r112572.
http://trac.webkit.org/changeset/112572
https://bugs.webkit.org/show_bug.cgi?id=82582

Does not compile in Windows component build

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

Source/WebKit/chromium:

* WebKit.gyp:
* src/WebData.cpp: Renamed from Source/WebCore/platform/chromium/support/WebData.cpp.
(WebKit):
(WebKit::WebData::reset):
(WebKit::WebData::assign):
(WebKit::WebData::size):
(WebKit::WebData::data):
(WebKit::WebData::WebData):
(WebKit::WebData::operator=):
(WebKit::WebData::operator PassRefPtr<SharedBuffer>):
* src/WebHTTPBody.cpp: Renamed from Source/WebCore/platform/chromium/support/WebHTTPBody.cpp.
(WebKit):
(WebKit::WebHTTPBody::initialize):
(WebKit::WebHTTPBody::reset):
(WebKit::WebHTTPBody::assign):
(WebKit::WebHTTPBody::elementCount):
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendData):
(WebKit::WebHTTPBody::appendFile):
(WebKit::WebHTTPBody::appendFileRange):
(WebKit::WebHTTPBody::appendBlob):
(WebKit::WebHTTPBody::identifier):
(WebKit::WebHTTPBody::setIdentifier):
(WebKit::WebHTTPBody::containsPasswordData):
(WebKit::WebHTTPBody::setContainsPasswordData):
(WebKit::WebHTTPBody::WebHTTPBody):
(WebKit::WebHTTPBody::operator=):
(WebKit::WebHTTPBody::operator PassRefPtr<FormData>):
(WebKit::WebHTTPBody::ensureMutable):
* src/WebHTTPLoadInfo.cpp: Renamed from Source/WebCore/platform/chromium/support/WebHTTPLoadInfo.cpp.
(WebKit):
(WebKit::WebHTTPLoadInfo::initialize):
(WebKit::WebHTTPLoadInfo::reset):
(WebKit::WebHTTPLoadInfo::assign):
(WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo):
(WebKit::WebHTTPLoadInfo::operator WTF::PassRefPtr<WebCore::ResourceLoadInfo>):
(WebKit::WebHTTPLoadInfo::httpStatusCode):
(WebKit::WebHTTPLoadInfo::setHTTPStatusCode):
(WebKit::WebHTTPLoadInfo::httpStatusText):
(WebKit::WebHTTPLoadInfo::setHTTPStatusText):
(WebKit::WebHTTPLoadInfo::encodedDataLength):
(WebKit::WebHTTPLoadInfo::setEncodedDataLength):
(WebKit::addHeader):
(WebKit::WebHTTPLoadInfo::addRequestHeader):
(WebKit::WebHTTPLoadInfo::addResponseHeader):
(WebKit::WebHTTPLoadInfo::requestHeadersText):
(WebKit::WebHTTPLoadInfo::setRequestHeadersText):
(WebKit::WebHTTPLoadInfo::responseHeadersText):
(WebKit::WebHTTPLoadInfo::setResponseHeadersText):
* src/WebURL.cpp: Renamed from Source/WebCore/platform/chromium/support/WebURL.cpp.
(WebKit):
(WebKit::WebURL::WebURL):
(WebKit::WebURL::operator=):
(WebKit::WebURL::operator WebCore::KURL):
* src/WebURLError.cpp: Renamed from Source/WebCore/platform/chromium/support/WebURLError.cpp.
(WebKit):
(WebKit::WebURLError::WebURLError):
(WebKit::WebURLError::operator=):
(WebKit::WebURLError::operator ResourceError):
* src/WebURLRequest.cpp: Renamed from Source/WebCore/platform/chromium/support/WebURLRequest.cpp.
(WebURLRequestPrivateImpl):
(WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl):
(WebKit::WebURLRequestPrivateImpl::dispose):
(WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
(WebKit):
(WebKit::WebURLRequest::initialize):
(WebKit::WebURLRequest::reset):
(WebKit::WebURLRequest::assign):
(WebKit::WebURLRequest::isNull):
(WebKit::WebURLRequest::url):
(WebKit::WebURLRequest::setURL):
(WebKit::WebURLRequest::firstPartyForCookies):
(WebKit::WebURLRequest::setFirstPartyForCookies):
(WebKit::WebURLRequest::allowCookies):
(WebKit::WebURLRequest::setAllowCookies):
(WebKit::WebURLRequest::allowStoredCredentials):
(WebKit::WebURLRequest::setAllowStoredCredentials):
(WebKit::WebURLRequest::cachePolicy):
(WebKit::WebURLRequest::setCachePolicy):
(WebKit::WebURLRequest::httpMethod):
(WebKit::WebURLRequest::setHTTPMethod):
(WebKit::WebURLRequest::httpHeaderField):
(WebKit::WebURLRequest::setHTTPHeaderField):
(WebKit::WebURLRequest::addHTTPHeaderField):
(WebKit::WebURLRequest::clearHTTPHeaderField):
(WebKit::WebURLRequest::visitHTTPHeaderFields):
(WebKit::WebURLRequest::httpBody):
(WebKit::WebURLRequest::setHTTPBody):
(WebKit::WebURLRequest::reportUploadProgress):
(WebKit::WebURLRequest::setReportUploadProgress):
(WebKit::WebURLRequest::reportLoadTiming):
(WebKit::WebURLRequest::setReportRawHeaders):
(WebKit::WebURLRequest::reportRawHeaders):
(WebKit::WebURLRequest::setReportLoadTiming):
(WebKit::WebURLRequest::targetType):
(WebKit::WebURLRequest::hasUserGesture):
(WebKit::WebURLRequest::setHasUserGesture):
(WebKit::WebURLRequest::setTargetType):
(WebKit::WebURLRequest::requestorID):
(WebKit::WebURLRequest::setRequestorID):
(WebKit::WebURLRequest::requestorProcessID):
(WebKit::WebURLRequest::setRequestorProcessID):
(WebKit::WebURLRequest::appCacheHostID):
(WebKit::WebURLRequest::setAppCacheHostID):
(WebKit::WebURLRequest::downloadToFile):
(WebKit::WebURLRequest::setDownloadToFile):
(WebKit::WebURLRequest::extraData):
(WebKit::WebURLRequest::setExtraData):
(WebKit::WebURLRequest::toMutableResourceRequest):
(WebKit::WebURLRequest::toResourceRequest):
* src/WebURLRequestPrivate.h: Renamed from Source/WebCore/platform/chromium/support/WebURLRequestPrivate.h.
(WebKit):
(WebURLRequestPrivate):
(WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
* src/WebURLResponse.cpp: Renamed from Source/WebCore/platform/chromium/support/WebURLResponse.cpp.
(WebURLResponsePrivateImpl):
(WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl):
(WebKit::WebURLResponsePrivateImpl::dispose):
(WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
(WebKit):
(WebKit::WebURLResponse::initialize):
(WebKit::WebURLResponse::reset):
(WebKit::WebURLResponse::assign):
(WebKit::WebURLResponse::isNull):
(WebKit::WebURLResponse::url):
(WebKit::WebURLResponse::setURL):
(WebKit::WebURLResponse::connectionID):
(WebKit::WebURLResponse::setConnectionID):
(WebKit::WebURLResponse::connectionReused):
(WebKit::WebURLResponse::setConnectionReused):
(WebKit::WebURLResponse::loadTiming):
(WebKit::WebURLResponse::setLoadTiming):
(WebKit::WebURLResponse::httpLoadInfo):
(WebKit::WebURLResponse::setHTTPLoadInfo):
(WebKit::WebURLResponse::responseTime):
(WebKit::WebURLResponse::setResponseTime):
(WebKit::WebURLResponse::mimeType):
(WebKit::WebURLResponse::setMIMEType):
(WebKit::WebURLResponse::expectedContentLength):
(WebKit::WebURLResponse::setExpectedContentLength):
(WebKit::WebURLResponse::textEncodingName):
(WebKit::WebURLResponse::setTextEncodingName):
(WebKit::WebURLResponse::suggestedFileName):
(WebKit::WebURLResponse::setSuggestedFileName):
(WebKit::WebURLResponse::httpStatusCode):
(WebKit::WebURLResponse::setHTTPStatusCode):
(WebKit::WebURLResponse::httpStatusText):
(WebKit::WebURLResponse::setHTTPStatusText):
(WebKit::WebURLResponse::httpHeaderField):
(WebKit::WebURLResponse::setHTTPHeaderField):
(WebKit::WebURLResponse::addHTTPHeaderField):
(WebKit::WebURLResponse::clearHTTPHeaderField):
(WebKit::WebURLResponse::visitHTTPHeaderFields):
(WebKit::WebURLResponse::lastModifiedDate):
(WebKit::WebURLResponse::setLastModifiedDate):
(WebKit::WebURLResponse::appCacheID):
(WebKit::WebURLResponse::setAppCacheID):
(WebKit::WebURLResponse::appCacheManifestURL):
(WebKit::WebURLResponse::setAppCacheManifestURL):
(WebKit::WebURLResponse::securityInfo):
(WebKit::WebURLResponse::setSecurityInfo):
(WebKit::WebURLResponse::toMutableResourceResponse):
(WebKit::WebURLResponse::toResourceResponse):
(WebKit::WebURLResponse::wasCached):
(WebKit::WebURLResponse::setWasCached):
(WebKit::WebURLResponse::wasFetchedViaSPDY):
(WebKit::WebURLResponse::setWasFetchedViaSPDY):
(WebKit::WebURLResponse::wasNpnNegotiated):
(WebKit::WebURLResponse::setWasNpnNegotiated):
(WebKit::WebURLResponse::wasAlternateProtocolAvailable):
(WebKit::WebURLResponse::setWasAlternateProtocolAvailable):
(WebKit::WebURLResponse::wasFetchedViaProxy):
(WebKit::WebURLResponse::setWasFetchedViaProxy):
(WebKit::WebURLResponse::isMultipartPayload):
(WebKit::WebURLResponse::setIsMultipartPayload):
(WebKit::WebURLResponse::downloadFilePath):
(WebKit::WebURLResponse::setDownloadFilePath):
(WebKit::WebURLResponse::remoteIPAddress):
(WebKit::WebURLResponse::setRemoteIPAddress):
(WebKit::WebURLResponse::remotePort):
(WebKit::WebURLResponse::setRemotePort):
(WebKit::WebURLResponse::extraData):
(WebKit::WebURLResponse::setExtraData):
* src/WebURLResponsePrivate.h: Renamed from Source/WebCore/platform/chromium/support/WebURLResponsePrivate.h.
(WebKit):
(WebURLResponsePrivate):
(WebKit::WebURLResponsePrivate::WebURLResponsePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r112579.
abarth@webkit.org [Fri, 30 Mar 2012 01:36:05 +0000 (01:36 +0000)]
Unreviewed, rolling out r112579.
http://trac.webkit.org/changeset/112579
https://bugs.webkit.org/show_bug.cgi?id=82657

Does not compile in Windows component build

Source/WebCore:

* WebCore.gypi:

Source/WebKit/chromium:

* WebKit.gyp:
* src/ResourceHandle.cpp: Renamed from Source/WebCore/platform/network/chromium/ResourceHandle.cpp.
(WebCore):
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandleInternal::start):
(WebCore::ResourceHandleInternal::cancel):
(WebCore::ResourceHandleInternal::setDefersLoading):
(WebCore::ResourceHandleInternal::allowStoredCredentials):
(WebCore::ResourceHandleInternal::willSendRequest):
(WebCore::ResourceHandleInternal::didSendData):
(WebCore::ResourceHandleInternal::didReceiveResponse):
(WebCore::ResourceHandleInternal::didDownloadData):
(WebCore::ResourceHandleInternal::didReceiveData):
(WebCore::ResourceHandleInternal::didReceiveCachedMetadata):
(WebCore::ResourceHandleInternal::didFinishLoading):
(WebCore::ResourceHandleInternal::didFail):
(WebCore::ResourceHandleInternal::FromResourceHandle):
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::firstRequest):
(WebCore::ResourceHandle::client):
(WebCore::ResourceHandle::setClient):
(WebCore::ResourceHandle::setDefersLoading):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::hasAuthenticationChallenge):
(WebCore::ResourceHandle::clearAuthentication):
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::~ResourceHandle):
(WebCore::ResourceHandle::loadsBlocked):
(WebCore::ResourceHandle::loadResourceSynchronously):
(WebCore::ResourceHandle::willLoadFromCache):
(WebCore::ResourceHandle::cacheMetadata):
* src/ResourceHandleInternal.h: Renamed from Source/WebCore/platform/network/chromium/ResourceHandleInternal.h.
(WebCore):
(ResourceHandleInternal):
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandleInternal::setOwner):
(WebCore::ResourceHandleInternal::request):
(WebCore::ResourceHandleInternal::client):
(WebCore::ResourceHandleInternal::setClient):
(WebCore::ResourceHandleInternal::loader):
* src/WrappedResourceRequest.h: Renamed from Source/WebCore/platform/chromium/support/WrappedResourceRequest.h.
(WebKit):
(WrappedResourceRequest):
(WebKit::WrappedResourceRequest::~WrappedResourceRequest):
(WebKit::WrappedResourceRequest::WrappedResourceRequest):
(WebKit::WrappedResourceRequest::bind):
(Handle):
(WebKit::WrappedResourceRequest::Handle::dispose):
* src/WrappedResourceResponse.h: Renamed from Source/WebCore/platform/chromium/support/WrappedResourceResponse.h.
(WebKit):
(WrappedResourceResponse):
(WebKit::WrappedResourceResponse::~WrappedResourceResponse):
(WebKit::WrappedResourceResponse::WrappedResourceResponse):
(WebKit::WrappedResourceResponse::bind):
(Handle):
(WebKit::WrappedResourceResponse::Handle::dispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r112611.
abarth@webkit.org [Fri, 30 Mar 2012 01:34:51 +0000 (01:34 +0000)]
Unreviewed, rolling out r112611.
http://trac.webkit.org/changeset/112611
https://bugs.webkit.org/show_bug.cgi?id=82676

Does not compile in Windows component build

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate shape-inside/shape-outside CSS Exclusion properties
commit-queue@webkit.org [Fri, 30 Mar 2012 01:17:38 +0000 (01:17 +0000)]
Update shape-inside/shape-outside CSS Exclusion properties
https://bugs.webkit.org/show_bug.cgi?id=82365

Patch by Bear Travis <betravis@adobe.com> on 2012-03-29
Reviewed by Ryosuke Niwa.

Source/WebCore:

Updating CSS property names for wrap-shape-inside and wrap-shape-outside
to shape-inside and shape-outside, per the current exclusions spec.
Renaming some parsing functions in CSSParser for clarity.
No new functionality.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseClipShape):
(WebCore::CSSParser::parseExclusionShapeRect):
(WebCore::CSSParser::parseExclusionShapeCircle):
(WebCore::CSSParser::parseExclusionShapeEllipse):
(WebCore::CSSParser::parseExclusionShapePolygon):
(WebCore::CSSParser::parseExclusionShape):
* css/CSSParser.h:
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

Renaming prefixed wrap-shape-inside and wrap-shape-outside
to prefixed shape-inside and shape-outside. Updating the
tests to reflect the change.

* fast/exclusions/parsing-wrap-shape-inside-expected.txt:
* fast/exclusions/parsing-wrap-shape-outside-expected.txt:
* fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
(testCSSText):
(testComputedStyle):
(testNotInherited):
* fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
(testCSSText):
(testComputedStyle):
(testNotInherited):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update paths in GYP files
commit-queue@webkit.org [Fri, 30 Mar 2012 01:15:57 +0000 (01:15 +0000)]
[chromium] Update paths in GYP files
https://bugs.webkit.org/show_bug.cgi?id=82663

Patch by Ryan Sleevi <rsleevi@chromium.org> on 2012-03-29
Reviewed by Adam Barth.

* WebCore.gypi:
Remove PluginDataGtk.cpp following r112401

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, expectations changes.
dpranke@chromium.org [Fri, 30 Mar 2012 00:44:10 +0000 (00:44 +0000)]
Unreviewed, expectations changes.

fast/block/lineboxcontain/glyphs.html and
fast/text/international/spaces-combined-in-vertical-text.html on
mac

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor recompileAllJSFunctions() to be less expensive
mhahnenberg@apple.com [Fri, 30 Mar 2012 00:36:37 +0000 (00:36 +0000)]
Refactor recompileAllJSFunctions() to be less expensive
https://bugs.webkit.org/show_bug.cgi?id=80330

Reviewed by Filip Pizlo.

This change is performance neutral on the JS benchmarks we track. It's mostly to improve page
load performance, which currently does at least a couple full GCs per navigation.

* heap/Heap.cpp:
(JSC::Heap::discardAllCompiledCode): Rename recompileAllJSFunctions to discardAllCompiledCode
because the function doesn't actually recompile anything (and never did); it simply throws code
away for it to be recompiled later if we determine we should do so.
(JSC):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::addFunctionExecutable): Adds a newly created FunctionExecutable to the Heap's list.
(JSC::Heap::removeFunctionExecutable): Removes the specified FunctionExecutable from the Heap's list.
* heap/Heap.h:
(JSC):
(Heap):
* runtime/Executable.cpp: Added next and prev fields to FunctionExecutables so that they can
be used in DoublyLinkedLists.
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::finalize): Removes the FunctionExecutable from the Heap's list.
* runtime/Executable.h:
(FunctionExecutable):
(JSC::FunctionExecutable::create): Adds the FunctionExecutable to the Heap's list.
* runtime/JSGlobalData.cpp: Remove recompileAllJSFunctions, as it's the Heap's job to own and manage
the list of FunctionExecutables.
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Use the new discardAllCompiledCode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in GenericEventQueue::~GenericEventQueue.
inferno@chromium.org [Fri, 30 Mar 2012 00:33:10 +0000 (00:33 +0000)]
Crash in GenericEventQueue::~GenericEventQueue.
https://bugs.webkit.org/show_bug.cgi?id=81976

Reviewed by Eric Carlson.

* dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::create):
(WebCore):
(WebCore::GenericEventQueue::GenericEventQueue):
(WebCore::GenericEventQueue::enqueueEvent):
(WebCore::GenericEventQueue::timerFired):
* dom/GenericEventQueue.h:
(GenericEventQueue):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::scheduleEvent):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks):
(WebCore::HTMLMediaElement::hasPendingActivity):
* html/HTMLMediaElement.h:
(HTMLMediaElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, expectations updates.
dpranke@chromium.org [Fri, 30 Mar 2012 00:31:32 +0000 (00:31 +0000)]
Unreviewed, expectations updates.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove to the WK1 skipped list (which WK2 picks up). The
simon.fraser@apple.com [Fri, 30 Mar 2012 00:26:27 +0000 (00:26 +0000)]
Move to the WK1 skipped list (which WK2 picks up). The
bug on the skipping is https://bugs.webkit.org/show_bug.cgi?id=82679.

* platform/mac-wk2/Skipped:
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add sharded ChromiumOS debug bots to builders.js
mihaip@chromium.org [Fri, 30 Mar 2012 00:25:26 +0000 (00:25 +0000)]
[Chromium] Add sharded ChromiumOS debug bots to builders.js
https://bugs.webkit.org/show_bug.cgi?id=82639

Reviewed by Eric Seidel.

The bots were sharded by http://crrev.com/129613, update builders.js
to reflect this.

* TestResultServer/static-dashboards/builders.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Direct composited image assignment doesn't work
noam.rosenthal@nokia.com [Fri, 30 Mar 2012 00:21:00 +0000 (00:21 +0000)]
[Qt][WK2] Direct composited image assignment doesn't work
https://bugs.webkit.org/show_bug.cgi?id=82525

Reviewed by Kenneth Rohde Christiansen.

We don't need to check whether the image or contentsRect are updated,
since assignImageToLayer is a cheap operation after the LayerBackingStore
refactor.

* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::setLayerChildren):
(WebKit::WebLayerTreeRenderer::setLayerState):
(WebKit::WebLayerTreeRenderer::renderNextFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip three flaky storage tests.
simon.fraser@apple.com [Fri, 30 Mar 2012 00:16:01 +0000 (00:16 +0000)]
Skip three flaky storage tests.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd new chrome.webkit GPU bot to flakiness dashboard.
commit-queue@webkit.org [Fri, 30 Mar 2012 00:16:01 +0000 (00:16 +0000)]
Add new chrome.webkit GPU bot to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=82562

Patch by Dave Tu <dtu@chromium.org> on 2012-03-29
Reviewed by Ojan Vafai.

* Tools/TestResultServer/static-dashboards/builders.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] DRT test case findString-markers is broken
commit-queue@webkit.org [Fri, 30 Mar 2012 00:09:56 +0000 (00:09 +0000)]
[BlackBerry] DRT test case findString-markers is broken
https://bugs.webkit.org/show_bug.cgi?id=82661

Patch by Andy Chen <andchen@rim.com> on 2012-03-29
Reviewed by Rob Buis.

Fixed wrong paths to js libs for this test case.

* platform/blackberry/editing/text-iterator/findString-markers.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Attempt to fix the component build
abarth@webkit.org [Fri, 30 Mar 2012 00:00:52 +0000 (00:00 +0000)]
[Chromium] Attempt to fix the component build
https://bugs.webkit.org/show_bug.cgi?id=82676

Unreviewed.

Now that we're implementing some of the WEBKIT_EXPORT symbols in
WebCore/platform/chromium/support, we need to tell the build system
that we want to actually export these symbols.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkipping a failing test on Lion.
enrica@apple.com [Thu, 29 Mar 2012 23:45:10 +0000 (23:45 +0000)]
Skipping a failing test on Lion.
I filed https://bugs.webkit.org/show_bug.cgi?id=82675 to
track this issue.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
lforschler@apple.com [Thu, 29 Mar 2012 23:38:32 +0000 (23:38 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, expectations and baselines updates.
dpranke@chromium.org [Thu, 29 Mar 2012 23:29:55 +0000 (23:29 +0000)]
Unreviewed, expectations and baselines updates.

* platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRestored change log entries that were accidentally deleted in r104276
mitz@apple.com [Thu, 29 Mar 2012 23:18:07 +0000 (23:18 +0000)]
Restored change log entries that were accidentally deleted in r104276

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify reporting a main resource error to DocumentLoader and
japhet@chromium.org [Thu, 29 Mar 2012 23:17:09 +0000 (23:17 +0000)]
Simplify reporting a main resource error to DocumentLoader and
FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=82649

Reviewed by Adam Barth.

No new tests, no functionality change intended.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainReceivedError): Remove isComplete parameter,
    since it was always true. Call FrameLoader::receivedMainResourceError,
    instead of the other way around.
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedMainResourceError): Remove isComplete parameter,
    since it was always true. Merge in most of mainReceivedCompleteError().
* loader/FrameLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::didCancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoremove support for junit-style xml output from test-webkitpy
dpranke@chromium.org [Thu, 29 Mar 2012 23:16:33 +0000 (23:16 +0000)]
remove support for junit-style xml output from test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=82279

Reviewed by Eric Seidel.

This was added when we were looking into integrating w/ Jenkins
rather than buildbot, but I believe that project got shelved, so
this is unused. We can always add it back in later as necessary.

* Scripts/webkitpy/test/main.py:
(Tester._parse_args):
(Tester._run_tests):
* Scritps/webkitpy/thirdparty/__init__.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHeap-use-after-free in WebCore::InlineFlowBox::deleteLine due to fullscreen issues.
jer.noble@apple.com [Thu, 29 Mar 2012 23:03:58 +0000 (23:03 +0000)]
Heap-use-after-free in WebCore::InlineFlowBox::deleteLine due to fullscreen issues.
https://bugs.webkit.org/show_bug.cgi?id=82055

Reviewed by David Hyatt.

No new tests; fixes fuzz test crasher which is not reproducible in DRT or WKTR.

When a RenderFullScreen object is inserted between a child and parent renderer, make sure the
parent renderer deletes its line boxes by calling setNeedsLayoutAndPrefWidthsRecalc().  This
forces its InlineBox renderers to be removed from the line boxes and their parents in the correct
order, fixing a double-delete crash.

The same is true when unwrapping the RenderFullScreen object, and when creating and inserting
the full screen placeholder.

* rendering/RenderFullScreen.cpp:
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
(RenderFullScreen::createPlaceholder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix for non-x86 platforms.
fpizlo@apple.com [Thu, 29 Mar 2012 23:01:46 +0000 (23:01 +0000)]
Unreviewed build fix for non-x86 platforms.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitSlow_op_mod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonew-run-webkit-tests: crashes when it fails to decode a stack trace
dpranke@chromium.org [Thu, 29 Mar 2012 22:53:28 +0000 (22:53 +0000)]
new-run-webkit-tests: crashes when it fails to decode a stack trace
https://bugs.webkit.org/show_bug.cgi?id=82673

Unreviewed, build fix.

We are assuming the stdout/stderr output from the driver is utf-8
encoded when we get stack traces; this may not be a valid
assumption generally, but if we do get strings that aren't valid
utf-8, we would crash. Now we will ignore any decoding errors.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port._get_crash_log):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_get_crash_log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkipping http/tests/xmlhttprequest/range-test.html for Mac platforms.
enrica@apple.com [Thu, 29 Mar 2012 22:50:34 +0000 (22:50 +0000)]
Skipping http/tests/xmlhttprequest/range-test.html for Mac platforms.
I filed https://bugs.webkit.org/show_bug.cgi?id=82672

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of Geolocation::positionChangedInternal(), use positionChanged() directly
benjamin@webkit.org [Thu, 29 Mar 2012 22:45:49 +0000 (22:45 +0000)]
Get rid of Geolocation::positionChangedInternal(), use positionChanged() directly
https://bugs.webkit.org/show_bug.cgi?id=82543

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-29
Reviewed by Andreas Kling.

After the change to client based geolocation, the method positionChangedInternal()
is called only by positionChanged(). This patch remove this extra indirection.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::positionChanged):
* Modules/geolocation/Geolocation.h:
(Geolocation):
* WebCore.order:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline fast/js tests for Chromium where the new results are
ojan@chromium.org [Thu, 29 Mar 2012 22:44:38 +0000 (22:44 +0000)]
Rebaseline fast/js tests for Chromium where the new results are
clearly more correct or the differences are just the error messages
V8 uses that are different from JSCs.

* platform/chromium-linux-x86/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-linux/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-mac-leopard/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-mac-snowleopard/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-mac/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-win-vista/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-win-xp/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-win/fast/js/large-expressions-expected.txt:
* platform/chromium/fast/js/JSON-parse-expected.txt:
* platform/chromium/fast/js/JSON-stringify-replacer-expected.txt: Added.
* platform/chromium/fast/js/Object-create-expected.txt: Added.
* platform/chromium/fast/js/Object-defineProperties-expected.txt: Added.
* platform/chromium/fast/js/exception-codegen-crash-expected.txt: Removed.
* platform/chromium/fast/js/function-apply-aliased-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/js/function-apply-aliased-expected.txt.
* platform/chromium/fast/js/function-bind-expected.txt: Added.
* platform/chromium/fast/js/kde/parse-expected.txt:
* platform/chromium/fast/js/object-literal-syntax-expected.txt: Added.
* platform/chromium/fast/js/object-prototype-properties-expected.txt: Added.
* platform/chromium/fast/js/regexp-caching-expected.txt: Removed.
* platform/chromium/fast/js/regexp-test-null-string-expected.txt: Removed.
* platform/chromium/fast/js/reserved-words-as-property-expected.txt: Added.
* platform/chromium/fast/js/reserved-words-strict-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkipping 3 inspector tests on Mac.
enrica@apple.com [Thu, 29 Mar 2012 22:42:21 +0000 (22:42 +0000)]
Skipping 3 inspector tests on Mac.
I filed https://bugs.webkit.org/show_bug.cgi?id=82671

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInputType attribute changed functions should happen after the attribute change
commit-queue@webkit.org [Thu, 29 Mar 2012 22:32:39 +0000 (22:32 +0000)]
InputType attribute changed functions should happen after the attribute change
https://bugs.webkit.org/show_bug.cgi?id=82644

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-29
Reviewed by Benjamin Poulain.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate expectations w/ crash information after r129689 has landed.
dpranke@chromium.org [Thu, 29 Mar 2012 22:32:08 +0000 (22:32 +0000)]
Update expectations w/ crash information after r129689 has landed.

Unreviewed, expectations change.

Also delete what appears to be a bad baseline for the fast/text test.

* platform/chromium/fast/text/international/spaces-combined-in-vertical-text-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate CSS Exclusion wrap-flow values left & right to start & end
commit-queue@webkit.org [Thu, 29 Mar 2012 22:21:01 +0000 (22:21 +0000)]
Update CSS Exclusion wrap-flow values left & right to start & end
https://bugs.webkit.org/show_bug.cgi?id=82366

Source/WebCore:

http://dev.w3.org/csswg/css3-exclusions/
-webkit-wrap-flow now takes the values start and end rather than
left and right. Updating the code to reflect this. Functionality
is covered by existing tests.

Patch by Bear Travis <betravis@adobe.com> on 2012-03-29
Reviewed by Andreas Kling.

* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator WrapFlow):
* rendering/style/RenderStyleConstants.h:

LayoutTests:

Updating test values for the wrap-flow and wrap shorthand property

Patch by Bear Travis <betravis@adobe.com> on 2012-03-29
Reviewed by Andreas Kling.

* fast/exclusions/script-tests/wrap-flow-parsing.js:
* fast/exclusions/script-tests/wrap-parsing.js:
* fast/exclusions/wrap-flow-parsing-expected.txt:
* fast/exclusions/wrap-parsing-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkipping plugin mouse events tests failing on Mac platforms.
enrica@apple.com [Thu, 29 Mar 2012 22:19:01 +0000 (22:19 +0000)]
Skipping plugin mouse events tests failing on Mac platforms.
The issue is tracked by https://bugs.webkit.org/show_bug.cgi?id=82668

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkipping 5 failing webarchive tests.
enrica@apple.com [Thu, 29 Mar 2012 22:11:57 +0000 (22:11 +0000)]
Skipping 5 failing webarchive tests.
I filed https://bugs.webkit.org/show_bug.cgi?id=82665

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: rollout r112484, r112545, r112574
dpranke@chromium.org [Thu, 29 Mar 2012 22:10:07 +0000 (22:10 +0000)]
Source/WebCore: rollout r112484, r112545, r112574
https://bugs.webkit.org/show_bug.cgi?id=82662

Unreviewed, build fix.

this appears to be producing some questionable differences on
the apple mac bots, and possibly one test on chromium linux.

* css/mediaControls.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
* css/mediaControlsChromium.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
* html/shadow/MediaControlElements.cpp:
(RenderMediaVolumeSliderContainer):
(WebCore):
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer):
* html/shadow/MediaControlElements.h:
(MediaControlVolumeSliderContainerElement):
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::create):

LayoutTests: rollout r112484, r112545, r112574, r112575
https://bugs.webkit.org/show_bug.cgi?id=82662

Unreviewed, build fix.

* media/video-controls-rendering-toggle-display-none-expected.txt: Removed.
* media/video-controls-rendering-toggle-display-none.html: Removed.
* platform/chromium/test_expectations.txt:
* platform/mac/Skipped.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkipping crashing workers tests.
enrica@apple.com [Thu, 29 Mar 2012 21:59:18 +0000 (21:59 +0000)]
Skipping crashing workers tests.
Filed https://bugs.webkit.org/show_bug.cgi?id=82660 to track the issue.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r110065-r110080): Content drawing outside overflow: hidden at ynet.co.il
jchaffraix@webkit.org [Thu, 29 Mar 2012 21:55:41 +0000 (21:55 +0000)]
REGRESSION (r110065-r110080): Content drawing outside overflow: hidden at ynet.co.il
https://bugs.webkit.org/show_bug.cgi?id=82129

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html
       fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html
       fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html
       fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html
       fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html
       fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html
       fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html
       fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html

This is a regression from r110072. I wrongly thought we should call ensureLayer if we create our RenderOverflow.
However the current overflow code removes the before and start overflows (like in horizontal writing mode with ltr direction,
we never have a top or a left overflow). Because of that we would not get a RenderLayer as expected and the overflow clip rects
would be wrong on our RenderLayer children.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::addLayoutOverflow):
Moved the ensureLayer() call after the check that we do have some overflow but before we remove the overflow in some directions.

LayoutTests:

* fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
* fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html: Added.
* fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
* fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html: Added.
* fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
* fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html: Added.
* fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
* fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html: Added.
Added 4 ref tests that should cover the 4 different values of (hasTopOverflow, hasLeftOverflow)
in RenderBox::addLayoutOverflow.

* platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt:
* platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt:
* platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt:
* platform/chromium-win/fast/block/lineboxcontain/font-expected.txt:
Rebaselined those tests on Chromium linux (new layers).

* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wk2/Skipped:
Skipped the previous tests on the other platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScripts fail to detect when a tool crashes
simon.fraser@apple.com [Thu, 29 Mar 2012 21:48:38 +0000 (21:48 +0000)]
Scripts fail to detect when a tool crashes
https://bugs.webkit.org/show_bug.cgi?id=82659

Reviewed by Mark Rowe.

Have exitStatus() detect when the process fail to exit cleanly
(possibly because of a crash), and return a non-zero exit code
in that case.

* Scripts/VCSUtils.pm:
(exitStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Move ResourceHandle to WebCore/platform/network/chromium
abarth@webkit.org [Thu, 29 Mar 2012 21:44:28 +0000 (21:44 +0000)]
[Chromium] Move ResourceHandle to WebCore/platform/network/chromium
https://bugs.webkit.org/show_bug.cgi?id=82657

Reviewed by James Robinson.

Source/WebCore:

We finally arive at our destination. This patch actually moves
WebCore::ResourceHandle from Source/WebKit/chromium/src to
Source/WebCore/network/chromium, matching its location in other ports.
To make this happen, we also need to move WrappedResourceRequest and
WrappedResourceResponse.

This patch is the last patch from
https://github.com/abarth/webkit/compare/master...webcore-platform

* WebCore.gypi:
* platform/chromium/support/WrappedResourceRequest.h: Copied from Source/WebKit/chromium/src/WrappedResourceRequest.h.
* platform/chromium/support/WrappedResourceResponse.h: Copied from Source/WebKit/chromium/src/WrappedResourceResponse.h.
* platform/network/chromium/ResourceHandle.cpp: Copied from Source/WebKit/chromium/src/ResourceHandle.cpp.
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandleInternal::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
(WebCore::ResourceHandle::cacheMetadata):
* platform/network/chromium/ResourceHandleInternal.h: Copied from Source/WebKit/chromium/src/ResourceHandleInternal.h.

Source/WebKit/chromium:

* WebKit.gyp:
* src/ResourceHandle.cpp: Removed.
* src/ResourceHandleInternal.h: Removed.
* src/WrappedResourceRequest.h: Removed.
* src/WrappedResourceResponse.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoremove ahem font from flexbox layout tests
tony@chromium.org [Thu, 29 Mar 2012 21:26:50 +0000 (21:26 +0000)]
remove ahem font from flexbox layout tests
https://bugs.webkit.org/show_bug.cgi?id=82633

Reviewed by Ojan Vafai.

These tests don't depend on the ahem font and after r112489, we seem
to be hitting a race condition on the Mac bots where we are checking
baselines while the font is still being loaded. Speculatively fix by
removing the webfont.

* css3/flexbox/flex-align-vertical-writing-mode.html:
* css3/flexbox/flex-align.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for WinCE after r112555.
paroga@webkit.org [Thu, 29 Mar 2012 21:24:24 +0000 (21:24 +0000)]
Build fix for WinCE after r112555.

* platform/text/wince/TextCodecWinCE.cpp:
(WebCore::LanguageManager::LanguageManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] WorkerFileSystemContextObserver can reference a deleted WorkerFileSystemCa...
dslomov@google.com [Thu, 29 Mar 2012 21:20:11 +0000 (21:20 +0000)]
[Chromium] WorkerFileSystemContextObserver can reference a deleted WorkerFileSystemCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=82565

WorkerFileSystemCallbacksBridge relies on a cleanUpAfterCallback being called
prior to the disposal of the bridge to ensure that WorkerFileSystemContextObserver
is unsubscribed and deleted. However cleanUpAfterCallback will only execute if the bridge's
callback has executed on the worker thread, and this might not be the case if the worker
terminates.

This patch fixes this by maintaining a RefPtr from WorkerFileSystemContextObserver to
WorkerFileSystemCallbacksBridge. This ensures that bridge is not deleted while observer is alive.

Reviewed by David Levin.

* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemContextObserver::create):
(WebKit::WorkerFileSystemContextObserver::WorkerFileSystemContextObserver):
(WorkerFileSystemContextObserver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMoving test to skip from test-expectations.txt to Skipped
enrica@apple.com [Thu, 29 Mar 2012 21:16:23 +0000 (21:16 +0000)]
Moving test to skip from test-expectations.txt to Skipped
for Mac platform.

* platform/mac/Skipped:
* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate expectations for media tests failing w/ slider change after r112484.
dpranke@chromium.org [Thu, 29 Mar 2012 21:02:13 +0000 (21:02 +0000)]
Update expectations for media tests failing w/ slider change after r112484.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImages that reload via media queries don't paint when device scale factor changes
andersca@apple.com [Thu, 29 Mar 2012 20:57:37 +0000 (20:57 +0000)]
Images that reload via media queries don't paint when device scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=82648
<rdar://problem/11143637>

Reviewed by Beth Dakin.

Commit scale factor changes before dirty rect changes, since setting the scale factor
can lead to more rects being dirtied when using the tile cache.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove CPP files related to ResourceHandle to WebCore/platform
abarth@webkit.org [Thu, 29 Mar 2012 20:52:48 +0000 (20:52 +0000)]
Move CPP files related to ResourceHandle to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=82582

Reviewed by James Robinson.

Source/WebCore:

This patch moves a number of files that implement parts of the platform
portion of the Chromium WebKit API from the WebKit layer to
WebCore/platform. These files are in the dependency cone of
ResourceHandle and have no dependencies on anything outside
WebCore/platform.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/support: Added.
* platform/chromium/support/WebData.cpp: Copied from Source/WebKit/chromium/src/WebData.cpp.
* platform/chromium/support/WebHTTPBody.cpp: Copied from Source/WebKit/chromium/src/WebHTTPBody.cpp.
* platform/chromium/support/WebHTTPLoadInfo.cpp: Copied from Source/WebKit/chromium/src/WebHTTPLoadInfo.cpp.
* platform/chromium/support/WebURL.cpp: Copied from Source/WebKit/chromium/src/WebURL.cpp.
* platform/chromium/support/WebURLError.cpp: Copied from Source/WebKit/chromium/src/WebURLError.cpp.
* platform/chromium/support/WebURLRequest.cpp: Copied from Source/WebKit/chromium/src/WebURLRequest.cpp.
* platform/chromium/support/WebURLRequestPrivate.h: Copied from Source/WebKit/chromium/src/WebURLRequestPrivate.h.
* platform/chromium/support/WebURLResponse.cpp: Copied from Source/WebKit/chromium/src/WebURLResponse.cpp.
* platform/chromium/support/WebURLResponsePrivate.h: Copied from Source/WebKit/chromium/src/WebURLResponsePrivate.h.

Source/WebKit/chromium:

* WebKit.gyp:
* src/WebData.cpp: Removed.
* src/WebHTTPBody.cpp: Removed.
* src/WebHTTPLoadInfo.cpp: Removed.
* src/WebURL.cpp: Removed.
* src/WebURLError.cpp: Removed.
* src/WebURLRequest.cpp: Removed.
* src/WebURLRequestPrivate.h: Removed.
* src/WebURLResponse.cpp: Removed.
* src/WebURLResponsePrivate.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago [Mac] REGRESSION: Removing translation of local paths in KURL constructor...
ap@apple.com [Thu, 29 Mar 2012 20:46:41 +0000 (20:46 +0000)]
    [Mac] REGRESSION: Removing translation of local paths in KURL constructor broke some applications
        https://bugs.webkit.org/show_bug.cgi?id=82548
        <rdar://problem/11125355>
        <rdar://problem/11142152>

        Reviewed by Brady Eidson.

        * WebView/WebFrame.mm:
        (-[WebFrame loadRequest:]): Fixed this bug.
        (-[WebFrame loadHTMLString:baseURL:]): Also added translation to another API, so that I don't
        have to come back again.
        (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.

        * WebView/WebView.mm: (-[WebView setMainFrameURL:]): Changed another place where clients used
        to pass file paths instead of URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r111259.
commit-queue@webkit.org [Thu, 29 Mar 2012 20:39:54 +0000 (20:39 +0000)]
Unreviewed, rolling out r111259.
http://trac.webkit.org/changeset/111259
https://bugs.webkit.org/show_bug.cgi?id=82650

Caused selection regression in calculations due to
misconstructed IntRectRegion. (Requested by mfenton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-29

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix p2.
barraclough@apple.com [Thu, 29 Mar 2012 20:37:38 +0000 (20:37 +0000)]
Windows build fix p2.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Ensure framebuffer exists at the start of beginDrawingFrame.
commit-queue@webkit.org [Thu, 29 Mar 2012 20:36:02 +0000 (20:36 +0000)]
[chromium] Ensure framebuffer exists at the start of beginDrawingFrame.
https://bugs.webkit.org/show_bug.cgi?id=82569

Patch by Michal Mocny <mmocny@google.com> on 2012-03-29
Reviewed by James Robinson.

Source/WebCore:

Updated LayerRendererChromiumTest unittests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::setVisible):
(WebCore::LayerRendererChromium::beginDrawingFrame):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):

Source/WebKit/chromium:

* tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromiumClient::FakeLayerRendererChromiumClient):
(FakeLayerRendererChromiumClient::rootLayer):
(FakeLayerRendererChromiumClient):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][EFL] run-javascriptcore-tests should be run through jhbuild
commit-queue@webkit.org [Thu, 29 Mar 2012 20:31:32 +0000 (20:31 +0000)]
[GTK][EFL] run-javascriptcore-tests should be run through jhbuild
https://bugs.webkit.org/show_bug.cgi?id=82581

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-29
Reviewed by Martin Robinson.

Running Javascriptcore tests through jhbuild
for consistency with run-webkit-tests and in order to
avoid confusing libraries when facing regressions.

* Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a compile assert for the size of RenderBlock
rniwa@webkit.org [Thu, 29 Mar 2012 20:20:13 +0000 (20:20 +0000)]
Add a compile assert for the size of RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=82586

Reviewed by Tony Chang.

Add compile asserts for the size of RenderBlock and RenderBlock::MarginValues.
We can't add asserts for FloatingObject and MarginInfo because they're private to RenderBlock.

* rendering/RenderBlock.cpp:
(SameSizeAsRenderBlock):
(WebCore):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::shouldPaint):
(WebCore::RenderBlock::FloatingObject::setShouldPaint):
(WebCore::RenderBlock::FloatingObject::isDescendant):
(WebCore::RenderBlock::FloatingObject::setIsDescendant):
(FloatingObject):
(RenderBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix p1.
barraclough@apple.com [Thu, 29 Mar 2012 20:16:41 +0000 (20:16 +0000)]
Windows build fix p1.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTemplate the Yarr::Interpreter on the character type
barraclough@apple.com [Thu, 29 Mar 2012 20:16:03 +0000 (20:16 +0000)]
Template the Yarr::Interpreter on the character type
https://bugs.webkit.org/show_bug.cgi?id=82637

Reviewed by Sam Weinig.

We should be able to call to the interpreter after having already checked the character type,
without having to re-package the character pointer back up into a string!

../JavaScriptCore:

* runtime/RegExp.cpp:
(JSC::RegExp::match):
(JSC::RegExp::matchCompareWithInterpreter):
    - Don't pass length.
* yarr/Yarr.h:
    - moved function declarations to YarrInterpreter.h.
* yarr/YarrInterpreter.cpp:
(Yarr):
(Interpreter):
(JSC::Yarr::Interpreter::InputStream::InputStream):
(InputStream):
(JSC::Yarr::Interpreter::Interpreter):
(JSC::Yarr::interpret):
    - templated Interpreter class on CharType.
* yarr/YarrInterpreter.h:
(Yarr):
    - added function declarations.

../WebCore:

* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::findMagicComment):
* platform/text/RegularExpression.cpp:
(WebCore::RegularExpression::match):
    - Don't pass length.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/Platform: [Chromium] Move createURLLoader() into Platform
abarth@webkit.org [Thu, 29 Mar 2012 19:48:21 +0000 (19:48 +0000)]
Source/Platform: [Chromium] Move createURLLoader() into Platform
https://bugs.webkit.org/show_bug.cgi?id=82587

Reviewed by James Robinson.

This patch introduces a base class for WebKitPlatformSupport that we
can use to incrementally more APIs from WebKit/chromium/public/platform
into Platform/chromium/public. Using this technique lets us avoid
making changes in the embedder during the transition.

This patch moves createURLLoader() because it's necessary for
ResourceHandle.  This is the third patch in this sequence:
https://github.com/abarth/webkit/compare/master...webcore-platform

* Platform.gypi:
* chromium/public/Platform.h: Added.
(WebKit):
(Platform):
(WebKit::Platform::createURLLoader):
(WebKit::Platform::~Platform):
* chromium/src/Platform.cpp: Added.
(WebKit):
(WebKit::Platform::initialize):
(WebKit::Platform::shutdown):
(WebKit::Platform::current):

Source/WebKit/chromium: Move createURLLoader() into Platform
https://bugs.webkit.org/show_bug.cgi?id=82587

Reviewed by James Robinson.

* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
* src/WebKit.cpp:
(WebKit::initializeWithoutV8):
(WebKit::shutdown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't use a flattened framework path when building on OS X
ddkilzer@apple.com [Thu, 29 Mar 2012 19:37:43 +0000 (19:37 +0000)]
Don't use a flattened framework path when building on OS X

Reviewed by Mark Rowe.

* Configurations/ToolExecutable.xcconfig: Use REAL_PLATFORM_NAME
to select different INSTALL_PATH values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotest-webkitpy: add --timing
dpranke@chromium.org [Thu, 29 Mar 2012 19:29:53 +0000 (19:29 +0000)]
test-webkitpy: add --timing
https://bugs.webkit.org/show_bug.cgi?id=82550

Reviewed by Eric Seidel.

This patch adds a --timing option that will display the time
each test takes. It also removes the --silent option, since
probably no one ever used it, and cleans up the logging
option parsing code to be easier to follow.

* Scripts/webkitpy/test/main.py:
(Tester._parse_args):
(Tester._configure):
* Scripts/webkitpy/test/runner.py:
(TestRunner.write_result):
* Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest):
(RunnerTest.test_timing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed. wxMSW build fixes.
kevino@webkit.org [Thu, 29 Mar 2012 19:25:48 +0000 (19:25 +0000)]
[wx] Unreviewed. wxMSW build fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r112553.
ossy@webkit.org [Thu, 29 Mar 2012 19:25:04 +0000 (19:25 +0000)]
Unreviewed, rolling out r112553.
http://trac.webkit.org/changeset/112553
https://bugs.webkit.org/show_bug.cgi?id=82638

It made all tests crash on Qt WK2 (Requested by Ossy_away on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-29

Source/WebCore:

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::stop):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
* Modules/geolocation/Geolocation.h:
(WebCore):
* Modules/geolocation/GeolocationController.cpp:
* Modules/geolocation/GeolocationController.h:
* WebCore.exp.in:
* page/GeolocationClient.h:
(WebCore):
(GeolocationClient):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):
* page/Page.h:
(WebCore):
(PageClients):
(Page):
(WebCore::Page::geolocationController):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
* WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
(GeolocationControllerClientBlackBerry::onLocationUpdate):
(GeolocationControllerClientBlackBerry::onLocationError):
* WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/GeolocationClientGtk.cpp:
(WebKit::GeolocationClient::updatePosition):
(WebKit::GeolocationClient::errorOccured):
* webkit/webkitwebview.cpp:
(webkit_web_view_init):

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidChangePosition:]):
(-[WebView _geolocationDidFailWithError:]):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/GeolocationClientQt.cpp:
(WebCore::GeolocationClientQt::positionUpdated):
(WebCore::GeolocationClientQt::startUpdating):

Source/WebKit/win:

* WebView.cpp:
(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):

Source/WebKit2:

* WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setGeoLocationPermission):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Add WTF_EXPORT_PRIVATE_NO_RTTI
kevino@webkit.org [Thu, 29 Mar 2012 19:22:02 +0000 (19:22 +0000)]
[wx] Unreviewed build fix. Add WTF_EXPORT_PRIVATE_NO_RTTI
so that ports not using RTTI can add symbol exports to
classes that RTTI ports export with WTF_EXPORT_PRIVATE_RTTI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove an unused variable that breaks the build with newer versions of clang.
aestes@apple.com [Thu, 29 Mar 2012 19:09:00 +0000 (19:09 +0000)]
Remove an unused variable that breaks the build with newer versions of clang.

Rubber stamped by Gavin Barraclough.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdating expected results. The output has an additional blank line.
enrica@apple.com [Thu, 29 Mar 2012 19:01:36 +0000 (19:01 +0000)]
Updating expected results. The output has an additional blank line.
No changes in the actual results.

* platform/mac/editing/input/firstrectforcharacterrange-plain-expected.txt:
* platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
* platform/mac/fast/text/attributed-substring-from-range-002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHashMap<>::add should return a more descriptive object
caio.oliveira@openbossa.org [Thu, 29 Mar 2012 18:48:23 +0000 (18:48 +0000)]
HashMap<>::add should return a more descriptive object
https://bugs.webkit.org/show_bug.cgi?id=71063

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

Update code to use AddResult instead of a pair. Note that since WeakGCMap wraps
the iterator type, there's a need for its own AddResult type -- instantiated from
HashTableAddResult template class.

* API/JSCallbackObject.h:
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
* API/JSClassRef.cpp:
(OpaqueJSClass::contextData):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitLazyNewFunction):
* bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
* debugger/Debugger.cpp:
* dfg/DFGAssemblyHelpers.cpp:
(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* jit/JITStubs.cpp:
(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):
* parser/Parser.cpp:
(JSC::::parseStrictObjectLiteral):
* parser/Parser.h:
(JSC::Scope::declareParameter):
* runtime/Identifier.cpp:
(JSC::Identifier::add):
(JSC::Identifier::add8):
(JSC::Identifier::addSlowCase):
* runtime/Identifier.h:
(JSC::Identifier::add):
(JSC::IdentifierTable::add):
* runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::add):
(JSC::SparseArrayValueMap::put):
(JSC::SparseArrayValueMap::putDirect):
(JSC::JSArray::enterDictionaryMode):
(JSC::JSArray::defineOwnNumericProperty):
* runtime/JSArray.h:
(SparseArrayValueMap):
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/StringRecursionChecker.h:
(JSC::StringRecursionChecker::performCheck):
* runtime/Structure.cpp:
(JSC::StructureTransitionTable::add):
* runtime/WeakGCMap.h:
(WeakGCMap):
(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):
* tools/ProfileTreeNode.h:
(JSC::ProfileTreeNode::sampleChild):

Source/WebCore:

Update code to use AddResult instead of a pair. No new tests, just a refactoring.

* Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::SQLTransactionCoordinator::acquireLock):
* Modules/webdatabase/chromium/QuotaTracker.cpp:
(WebCore::QuotaTracker::updateDatabaseSize):
* bindings/js/DOMObjectHashTableMap.h:
(WebCore::DOMObjectHashTableMap::get):
* bindings/js/JSDOMBinding.cpp:
(WebCore::cacheDOMStructure):
* bindings/js/JSDOMBinding.h:
(WebCore::cacheWrapper):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::getDOMConstructor):
* bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::addListener):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::startObjectInternal):
(WebCore::CloneSerializer::write):
* bindings/v8/NPV8Object.cpp:
(WebCore::npCreateV8ScriptObject):
* bridge/IdentifierRep.cpp:
(WebCore::IdentifierRep::get):
* bridge/NP_jsobject.cpp:
(ObjectMap::add):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::logUnimplementedPropertyID):
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::getFontData):
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createIdentifierValue):
(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createValue):
(WebCore::CSSValuePool::createFontFamilyValue):
(WebCore::CSSValuePool::createFontFaceValue):
* dom/CheckedRadioButtons.cpp:
(WebCore::RadioButtonGroup::add):
(WebCore::CheckedRadioButtons::addButton):
* dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationScope::MutationAccumulationRouter::incrementScopingLevel):
* dom/Document.cpp:
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::getCSSCanvasElement):
(WebCore::Document::getItems):
* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::enqueueEvent):
(WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent):
(WebCore::DocumentEventQueue::pendingEventTimerFired):
* dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::add):
* dom/EventListenerMap.cpp:
(WebCore::EventListenerMap::add):
* dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::Node::getElementsByTagName):
(WebCore::Node::getElementsByTagNameNS):
(WebCore::Node::getElementsByName):
(WebCore::Node::getElementsByClassName):
(WebCore::Node::collectMatchingObserversForMutation):
* dom/QualifiedName.cpp:
(WebCore::QualifiedName::init):
* dom/SpaceSplitString.cpp:
(WebCore::SpaceSplitStringData::create):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateAttributeStyle):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::append):
* inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::diff):
* inspector/InspectorCSSAgent.cpp:
(WebCore::SelectorProfile::commitSelector):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::performSearch):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
* inspector/InspectorValues.h:
(WebCore::InspectorObject::setValue):
(WebCore::InspectorObject::setObject):
(WebCore::InspectorObject::setArray):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::addEntry):
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
* page/PageGroup.cpp:
(WebCore::PageGroup::pageGroup):
(WebCore::PageGroup::addVisitedLink):
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
* page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
* page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::compileSubtargetList):
* platform/cf/BinaryPropertyList.cpp:
(WebCore::BinaryPropertyListPlan::writeInteger):
(WebCore::BinaryPropertyListPlan::writeString):
(WebCore::BinaryPropertyListPlan::writeIntegerArray):
* platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::addTileJob):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::findOrMakeClone):
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::revalidateTiles):
* platform/graphics/ca/win/LayerChangesFlusher.cpp:
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
* platform/graphics/chromium/FontUtilsChromiumWin.cpp:
(WebCore::getDerivedFontData):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::initializeATSUStyle):
* platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::SimpleFontData::getCFStringAttributes):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):
* platform/graphics/wince/FontPlatformData.cpp:
(WebCore::FixedSizeFontData::create):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::getStyleContext):
* platform/mac/ThreadCheck.mm:
(WebCoreReportThreadViolation):
* platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::add):
* platform/network/HTTPHeaderMap.h:
(HTTPHeaderMap):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::addHTTPHeaderField):
* plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::add):
(WebCore::PluginDatabase::loadPersistentMetadataCache):
* plugins/win/PluginDatabaseWin.cpp:
(WebCore::PluginDatabase::getPluginPathsInDirectories):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addPercentHeightDescendant):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::addDependencyOnFlowThread):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRenderBoxRegionInfo):
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
* storage/StorageMap.cpp:
(WebCore::StorageMap::setItem):
(WebCore::StorageMap::importItem):
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::addPendingResource):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::setRequestHeaderInternal):
* xml/XPathFunctions.cpp:
(WebCore::XPath::FunId::evaluate):
* xml/XPathPath.cpp:
(WebCore::XPath::LocationPath::evaluate):
* xml/XPathPredicate.cpp:
(WebCore::XPath::Union::evaluate):

Source/WebKit/chromium:

Update code to use AddResult instead of a pair.

* src/WebHTTPLoadInfo.cpp:
(WebKit::addHeader):
* src/WebURLResponse.cpp:
(WebKit::WebURLResponse::addHTTPHeaderField):

Source/WebKit/mac:

Update code to use AddResult instead of a pair.

* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::hostForPlugin):
* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):
* WebCoreSupport/WebNotificationClient.mm:
(WebNotificationClient::show):

Source/WebKit/win:

Update code to use AddResult instead of a pair.

* WebKitCOMAPI.cpp:
(classFactory):

Source/WebKit2:

Update code to use AddResult instead of a pair.

* Platform/CoreIPC/ArgumentCoders.h:
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::getOrCreate):
* Shared/MutableDictionary.cpp:
(WebKit::MutableDictionary::add):
(WebKit::MutableDictionary::set):
* Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
* Shared/mac/CommandLineMac.cpp:
(WebKit::CommandLine::parse):
* UIProcess/API/mac/WKPrintingView.mm:
(pageDidDrawToPDF):
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::getOrCreate):
* WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::getOrCreate):
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::webPageGroup):

Source/WTF:

Make HashTable<>::add() and derivate functions return an AddResult struct instead
of a pair. This struct contains contains 'iterator' and 'isNewEntry' members, that are
more readable at callsites than previous 'first' and 'second'.

* wtf/HashCountedSet.h:
(HashCountedSet):
(WTF::::add):
* wtf/HashMap.h:
(HashMap):
(WTF):
(WTF::::set):
* wtf/HashSet.h:
(HashSet):
(WTF::::add):
(WTF):
* wtf/HashTable.h:
(WTF::HashTableAddResult::HashTableAddResult):
(HashTableAddResult):
(WTF):
(HashTable):
(WTF::HashTable::add):
(WTF::::add):
(WTF::::addPassingHashCode):
* wtf/ListHashSet.h:
(ListHashSet):
(WTF::::add):
(WTF::::insertBefore):
* wtf/RefPtrHashMap.h:
(WTF):
(WTF::::set):
* wtf/Spectrum.h:
(WTF::Spectrum::add):
* wtf/WTFThreadData.cpp:
(JSC::IdentifierTable::add):
* wtf/WTFThreadData.h:
(IdentifierTable):
* wtf/text/AtomicString.cpp:
(WTF::addToStringTable):
(WTF::AtomicString::addSlowCase):

Tools:

Update code to use AddResult instead of a pair.

* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::evaluateScriptInIsolatedWorld):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::evaluateScriptInIsolatedWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: improve window selection accuracy in vertical overview of timeline...
caseq@chromium.org [Thu, 29 Mar 2012 18:35:02 +0000 (18:35 +0000)]
Web Inspector: improve window selection accuracy in vertical overview of timeline panel
https://bugs.webkit.org/show_bug.cgi?id=82625

Reviewed by Vsevolod Vlasov.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype._renderBars): preserve actual padding used while rendering bars.
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes): account for outer and inter-bars padding when calculating bar offsets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGEOLOCATION should be implemented as Page Supplement
commit-queue@webkit.org [Thu, 29 Mar 2012 18:32:32 +0000 (18:32 +0000)]
GEOLOCATION should be implemented as Page Supplement
https://bugs.webkit.org/show_bug.cgi?id=82228

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-29
Reviewed by Adam Barth.

Source/WebCore:

Geolocation now uses the Supplement interface instead of
keeping an instance variable on Page. This allows us to
remove all geolocation-related functions, variables, and
ifdefs out of Page and into Modules/geolocation/.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::stop):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
* Modules/geolocation/Geolocation.h:
(WebCore):
* Modules/geolocation/GeolocationController.cpp:
(WebCore::GeolocationController::supplementName):
(WebCore):
(WebCore::provideGeolocationTo):
* Modules/geolocation/GeolocationController.h:
(GeolocationController):
(WebCore::GeolocationController::from):
* WebCore.exp.in:
* page/GeolocationClient.h:
(WebCore):
(GeolocationClient):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):
* page/Page.h:
(WebCore):
(PageClients):
(Page):

Source/WebKit/blackberry:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
* WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
(GeolocationControllerClientBlackBerry::onLocationUpdate):
(GeolocationControllerClientBlackBerry::onLocationError):
* WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):

Source/WebKit/chromium:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/gtk:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/GeolocationClientGtk.cpp:
(WebKit::GeolocationClient::updatePosition):
(WebKit::GeolocationClient::errorOccured):
* webkit/webkitwebview.cpp:
(webkit_web_view_init):

Source/WebKit/mac:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidChangePosition:]):
(-[WebView _geolocationDidFailWithError:]):

Source/WebKit/qt:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/GeolocationClientQt.cpp:
(WebCore::GeolocationClientQt::positionUpdated):
(WebCore::GeolocationClientQt::startUpdating):

Source/WebKit/win:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

* WebView.cpp:
(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):

Source/WebKit2:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

* WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setGeoLocationPermission):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: chromium: DRT --no-timeout option doesn't work.
loislo@chromium.org [Thu, 29 Mar 2012 18:27:41 +0000 (18:27 +0000)]
Web Inspector: chromium: DRT --no-timeout option doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=82608

Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
This was broken by r112354 and the sequence became opposite.

Reviewed by Yury Semikhatsky.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSync up WebKit TraceEvent.h with chromium trace_event.h
commit-queue@webkit.org [Thu, 29 Mar 2012 18:24:45 +0000 (18:24 +0000)]
Sync up WebKit TraceEvent.h with chromium trace_event.h
https://bugs.webkit.org/show_bug.cgi?id=82527

Patch by John Bates <jbates@google.com> on 2012-03-29
Reviewed by James Robinson.

* platform/chromium/TraceEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Split off tiled layer constructs for unit tests into a common header
commit-queue@webkit.org [Thu, 29 Mar 2012 18:18:47 +0000 (18:18 +0000)]
[chromium] Split off tiled layer constructs for unit tests into a common header
https://bugs.webkit.org/show_bug.cgi?id=82425

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-29
Reviewed by Adrienne Walker.

* WebKit.gypi:
* tests/CCTiledLayerTestCommon.cpp: Added.
(WebKitTests):
(WebKitTests::FakeLayerTextureUpdater::Texture::Texture):
(WebKitTests::FakeLayerTextureUpdater::Texture::~Texture):
(WebKitTests::FakeLayerTextureUpdater::Texture::updateRect):
(WebKitTests::FakeLayerTextureUpdater::Texture::prepareRect):
(WebKitTests::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(WebKitTests::FakeLayerTextureUpdater::~FakeLayerTextureUpdater):
(WebKitTests::FakeLayerTextureUpdater::prepareToUpdate):
(WebKitTests::FakeLayerTextureUpdater::setRectToInvalidate):
(WebKitTests::FakeLayerTextureUpdater::createTexture):
(WebKitTests::FakeCCTiledLayerImpl::FakeCCTiledLayerImpl):
(WebKitTests::FakeCCTiledLayerImpl::~FakeCCTiledLayerImpl):
(WebKitTests::FakeTiledLayerChromium::FakeTiledLayerChromium):
(WebKitTests::FakeTiledLayerChromium::~FakeTiledLayerChromium):
(WebKitTests::FakeTiledLayerChromium::setNeedsDisplayRect):
(WebKitTests::FakeTiledLayerChromium::paintContentsIfDirty):
(WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
(WebKitTests::FakeCCTextureUpdater::FakeCCTextureUpdater):
* tests/CCTiledLayerTestCommon.h: Added.
(WebKitTests):
(FakeLayerTextureUpdater):
(Texture):
(WebKitTests::FakeLayerTextureUpdater::sampledTexelFormat):
(WebKitTests::FakeLayerTextureUpdater::lastUpdateRect):
(WebKitTests::FakeLayerTextureUpdater::prepareCount):
(WebKitTests::FakeLayerTextureUpdater::clearPrepareCount):
(WebKitTests::FakeLayerTextureUpdater::updateCount):
(WebKitTests::FakeLayerTextureUpdater::clearUpdateCount):
(WebKitTests::FakeLayerTextureUpdater::updateRect):
(WebKitTests::FakeLayerTextureUpdater::prepareRectCount):
(WebKitTests::FakeLayerTextureUpdater::clearPrepareRectCount):
(WebKitTests::FakeLayerTextureUpdater::prepareRect):
(WebKitTests::FakeLayerTextureUpdater::setOpaquePaintRect):
(FakeCCTiledLayerImpl):
(FakeTiledLayerChromium):
(WebKitTests::FakeTiledLayerChromium::tileSize):
(WebKitTests::FakeTiledLayerChromium::lastNeedsDisplayRect):
(WebKitTests::FakeTiledLayerChromium::textureManager):
(WebKitTests::FakeTiledLayerChromium::fakeLayerTextureUpdater):
(WebKitTests::FakeTiledLayerChromium::updateRect):
(WebKitTests::FakeTiledLayerChromium::textureUpdater):
(WebKitTests::FakeTiledLayerChromium::createTextureUpdaterIfNeeded):
(FakeTiledLayerWithScaledBounds):
(WebKitTests::FakeTiledLayerWithScaledBounds::setContentBounds):
(WebKitTests::FakeTiledLayerWithScaledBounds::contentBounds):
(FakeTextureAllocator):
(WebKitTests::FakeTextureAllocator::createTexture):
(WebKitTests::FakeTextureAllocator::deleteTexture):
(FakeTextureCopier):
(WebKitTests::FakeTextureCopier::copyTexture):
(FakeCCTextureUpdater):
(WebKitTests::FakeCCTextureUpdater::textureAllocator):
* tests/TextureManagerTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: subtree disapears from <iframe> after loading
pfeldman@chromium.org [Thu, 29 Mar 2012 18:17:57 +0000 (18:17 +0000)]
Web Inspector: subtree disapears from <iframe> after loading
https://bugs.webkit.org/show_bug.cgi?id=76552

Reviewed by Yury Semikhatsky.

Source/WebCore:

The problem was that content document subtree was not unbound upon iframe re-push.
Upon owner element refresh content document was not sent to the frontend
since backend assumed that front-end has already had the up-to-date version.

Test: inspector/elements/iframe-load-event.html

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::loadEventFired):

LayoutTests:

* inspector/elements/iframe-load-event-expected.txt: Added.
* inspector/elements/iframe-load-event.html: Added.
* inspector/elements/resources/iframe-load-event-iframe-1.html: Added.
* inspector/elements/resources/iframe-load-event-iframe-2.html: Added.
* inspector/elements/resources/iframe-load-event-iframe.js: Added.
(loadSecondIFrame):
(test.step1.nodeInserted):
(test.step1):
(test.step2):
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove unneeded code+fixmes from CCOcclusionTracker
commit-queue@webkit.org [Thu, 29 Mar 2012 18:14:01 +0000 (18:14 +0000)]
[chromium] Remove unneeded code+fixmes from CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=82380

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-29
Reviewed by Adrienne Walker.

Source/WebCore:

The current occlusion was exposed on the occlusion tracker for the
transition over to culling 2.0 which has landed, so we can remove
it now. It still had one use in unit tests which is moved to a
test subclass.

Above test subclass already existed in the occlusion tracker tests,
so pulled it out to a common file CCOcclusionTrackerTestCommon.h
so that other unit tests can use it to get at occlusion internals.

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestLayerChromium::paintContentsIfDirty):
* tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::TestCCOcclusionTrackerWithScissor::TestCCOcclusionTrackerWithScissor):
(WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
* tests/CCOcclusionTrackerTestCommon.h: Added.
(WebKitTests):
(TestCCOcclusionTrackerBase):
(WebKitTests::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebKitTests::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebKitTests::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebKitTests::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebKitTests::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/82558> Toggling <input type="range"> readonly or disabled state...
commit-queue@webkit.org [Thu, 29 Mar 2012 18:11:40 +0000 (18:11 +0000)]
<webkit.org/b/82558> Toggling <input type="range"> readonly or disabled state while active breaks all click events

Source/WebCore:

Test: fast/forms/range/range-drag-when-toggled-disabled.html

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-29
Reviewed by Kent Tamura.

* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler):
A slider can toggle its readonly or disabled state while in the middle
of dragging, in those cases we should cancel the drag and perform cleanup.

LayoutTests:

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-29
Reviewed by Kent Tamura.

* fast/forms/range/range-drag-when-toggled-disabled-expected.txt: Added.
* fast/forms/range/range-drag-when-toggled-disabled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFactor out common post-insertion logic in ContainerNode
adamk@chromium.org [Thu, 29 Mar 2012 18:03:59 +0000 (18:03 +0000)]
Factor out common post-insertion logic in ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=82544

Reviewed by Ryosuke Niwa.

appendChild, insertBefore, and replaceChild all share a great deal of logic.
This patch factors out the "post-insertion" logic that deals with
notifying parents that their children changed and notifying children
that they've been added to the tree.

Besides reducing code duplication, this is in preparation for moving
this post-insertion notification later in the insertion process.

No new tests, no change in behavior.

* dom/ContainerNode.cpp:
(WebCore):
(WebCore::ContainerNode::insertBefore): Factor out shared logic, remove unnecessary "prev" variable.
(WebCore::ContainerNode::replaceChild): ditto.
(WebCore::ContainerNode::appendChild): ditto.
(WebCore::updateTreeAfterInsertion): New helper method encapsulating shared logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdating test_expectations with new failures after r112484.
enrica@apple.com [Thu, 29 Mar 2012 17:52:03 +0000 (17:52 +0000)]
Updating test_expectations with new failures after r112484.
The failing tests need a new baseline.
This is tracked by https://bugs.webkit.org/show_bug.cgi?id=82626

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed to implement flex-line-pack
tony@chromium.org [Thu, 29 Mar 2012 17:16:39 +0000 (17:16 +0000)]
Need to implement flex-line-pack
https://bugs.webkit.org/show_bug.cgi?id=70794

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: css3/flexbox/multiline-line-pack-horizontal-column.html
       css3/flexbox/multiline-line-pack.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::initialLinePackingOffset): Similar to initialPackingOffset.
(WebCore):
(WebCore::linePackingSpaceBetweenChildren): Similar to packingSpaceBetweenChildren.
(WebCore::RenderFlexibleBox::packFlexLines): Move lines based on flex-line-pack.
    Note that we don't need to relayout on stretch because
    alignChildren will do that for us (only auto size needs stretching).
(WebCore::RenderFlexibleBox::flipForWrapReverse): Pull out the initial
    cross axis offset before calling packFlexLines because we can
    move the the line contexts.
* rendering/RenderFlexibleBox.h:

LayoutTests:

Updated the old multiline tests to have -webkit-flex-line-pack: start,
which was the previous default behavior. The correct default behavior
is stretch.

* css3/flexbox/multiline-align.html:
* css3/flexbox/multiline-column-auto.html:
* css3/flexbox/multiline-line-pack-expected.txt: Added.
* css3/flexbox/multiline-line-pack-horizontal-column-expected.txt: Added.
* css3/flexbox/multiline-line-pack-horizontal-column.html: Added.
* css3/flexbox/multiline-line-pack.html: Added.
* css3/flexbox/multiline-pack.html:
* css3/flexbox/multiline-reverse-wrap-overflow.html:
* css3/flexbox/multiline-shrink-to-fit.html:
* css3/flexbox/multiline.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoString: Subscript operator shouldn't force conversion to 16-bit characters.
kling@webkit.org [Thu, 29 Mar 2012 17:03:59 +0000 (17:03 +0000)]
String: Subscript operator shouldn't force conversion to 16-bit characters.
<http://webkit.org/b/82613>

Reviewed by Anders Carlsson.

Forward String::operator[] to StringImpl::operator[] instead of indexing into characters().
This avoid implicit conversion of 8-bit strings to 16-bit, and as an example, reduces memory
usage on http://www.allthingsd.com/ by 360kB.

* wtf/text/WTFString.h:
(WTF::String::operator[]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntroduce CSSParserMode in all classes
krit@webkit.org [Thu, 29 Mar 2012 16:54:39 +0000 (16:54 +0000)]
Introduce CSSParserMode in all classes
https://bugs.webkit.org/show_bug.cgi?id=82335

Unreviewed build fix.

* src/WebDocument.cpp:
(WebKit::WebDocument::insertUserStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: SnippetsScriptMapping should process existing snippets on load.
vsevik@chromium.org [Thu, 29 Mar 2012 16:45:55 +0000 (16:45 +0000)]
Web Inspector: SnippetsScriptMapping should process existing snippets on load.
https://bugs.webkit.org/show_bug.cgi?id=82619

Reviewed by Pavel Feldman.

SnippetsScriptMapping now loads existing snippets on creation.
Otherwise scripts panel shows snippets created during current session only.
Drive-by ScriptsNavigator closure compilation fix.

* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsModel.prototype.set get snippets):
(WebInspector.SnippetsScriptMapping):
(WebInspector.SnippetsScriptMapping.prototype._handleSnippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: check more likely condition first in HeapSnapshot._buildAggregates
yurys@chromium.org [Thu, 29 Mar 2012 16:25:24 +0000 (16:25 +0000)]
Web Inspector: check more likely condition first in HeapSnapshot._buildAggregates
https://bugs.webkit.org/show_bug.cgi?id=82621

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshot.js: selfSize === 0 is quite rare, moving this condition
to the first place saves 1 of 6 secs on the heap profiler perf test.
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes): root node is always the first
one and is the only one that doesn't have dominator, so we may start iterating nodes from
the second node and avoid additional check in the loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: "go to the previous panel" shortcut is painful to maintain
pfeldman@chromium.org [Thu, 29 Mar 2012 16:22:13 +0000 (16:22 +0000)]
Web Inspector: "go to the previous panel" shortcut is painful to maintain
https://bugs.webkit.org/show_bug.cgi?id=82602

Reviewed by Vsevolod Vlasov.

Present go to previous panel shortcut "Cmd - Left" is painful to support since we have
more and more free flow editing capabilities (where Cmd - Left is handled by the editor).
Remaping it to Cmd - Option - [ (]) /  (Ctrl - Alt - [ (]) ).

Drive-by: de-capitalize captions from the settings panel.
* English.lproj/localizedStrings.js:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerShortcuts):
* inspector/front-end/InspectorView.js:
(WebInspector.InspectorView.prototype._keyDown):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._registerShortcuts):
(WebInspector.TimelinePanel.prototype._contextMenu):
* inspector/front-end/inspector.js:
(WebInspector._registerShortcuts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112539 268f45cc-cd09-0410-ab3c-d52691b4dbfc