loislo@chromium.org [Fri, 4 Mar 2011 13:26:23 +0000 (13:26 +0000)]
2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Remove unnecessary domain and success flags from the response messages.
https://bugs.webkit.org/show_bug.cgi?id=55768
We have domain property in the response messages but it is not used because we dispatch
the responses on the callback associated with seq.
If we have property 'errors' in the response then success eq false and true in the other case.
* inspector/protocol/runtime-agent-expected.txt:
* inspector/report-protocol-errors-expected.txt:
2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Remove unnecessary domain and success flags from the response messages.
https://bugs.webkit.org/show_bug.cgi?id=55768
We have domain property in the response messages but it is not used because we dispatch
the responses on the callback associated with seq.
If we have property 'errors' in the response then success eq false and true in the other case.
* inspector/CodeGeneratorInspector.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
christian@webkit.org [Fri, 4 Mar 2011 13:18:23 +0000 (13:18 +0000)]
Enable Copy Image Address context menu item in the Gtk port
https://bugs.webkit.org/show_bug.cgi?id=55136
Reviewed by Gustavo Noronha Silva.
* page/ContextMenuController.cpp:
* platform/ContextMenuItem.h:
* platform/LocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
* platform/LocalizedStrings.h:
* platform/gtk/ContextMenuItemGtk.cpp:
* platform/gtk/LocalizedStringsGtk.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80344
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 4 Mar 2011 12:37:04 +0000 (12:37 +0000)]
Unreviewed.
[Qt] Two http auth tests fail with Qt 4.7.2
https://bugs.webkit.org/show_bug.cgi?id=55767
Add failing tests to the Skipped list to make buildbot happy.
* platform/qt/Skipped: Add http/tests/appcache/auth.html and http/tests/xmlhttprequest/basic-auth.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 4 Mar 2011 11:16:05 +0000 (11:16 +0000)]
2011-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement getCompletions via evaluate.
https://bugs.webkit.org/show_bug.cgi?id=55759
* inspector/InjectedScript.cpp:
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.idl:
* inspector/InspectorDebuggerAgent.cpp:
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions.evaluated):
(WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
(WebInspector.ConsoleView.prototype.completions):
(WebInspector.ConsoleView.prototype._reportCompletions):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._showPopup):
(WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 4 Mar 2011 11:11:58 +0000 (11:11 +0000)]
2011-03-03 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce a protocol test for RuntimeAgent API.
https://bugs.webkit.org/show_bug.cgi?id=55482
* http/tests/inspector/protocol-test.js: Added.
(initialize_ProtocolTest.InspectorTest.filterProps):
(initialize_ProtocolTest.InspectorTest._dumpStepResult):
(initialize_ProtocolTest.InspectorTest._runNextStep):
(initialize_ProtocolTest.InspectorTest.runProtocolTestSuite):
(initialize_ProtocolTest):
* inspector/protocol/runtime-agent-expected.txt: Added.
* inspector/protocol/runtime-agent.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 4 Mar 2011 10:06:30 +0000 (10:06 +0000)]
2011-03-02 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
https://bugs.webkit.org/show_bug.cgi?id=55434
Changed WebTask to be a subclass of webkit_support::TaskAdaptor
and passed the object webkit_support::PostDelayedTask directly.
Note that the change keeps postTask() as is because it has a
semantics taht webkit_support::PostDelayedTask() has; It jumps to
the main thread.
* DumpRenderTree/chromium/Task.cpp:
(postDelayedTask):
* DumpRenderTree/chromium/Task.h:
(WebTask::Run):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Fri, 4 Mar 2011 09:45:13 +0000 (09:45 +0000)]
2011-03-04 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
V8 version of JavaString should obtain string from JNI in UTF-16 encoding
https://bugs.webkit.org/show_bug.cgi?id=55566
We obtain the string from JNI in UTF-16 encoding and convert
to UTF-8 using our own routines as required. This matches the
behaviour of the JSC version of JavaString.
No new tests, no change in behaviour.
* bridge/jni/v8/JavaStringV8.h:
(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::utf8):
(JSC::Bindings::JavaStringImpl::impl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 4 Mar 2011 09:40:47 +0000 (09:40 +0000)]
2011-03-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not push document into front-end, make it request one.
https://bugs.webkit.org/show_bug.cgi?id=55664
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
* inspector/InspectorAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::setDocument):
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::boundNodeId):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
(WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
(WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMDocument):
(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype.requestDocument):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
(WebInspector.DOMAgent.prototype._attributesUpdated):
(WebInspector.DOMAgent.prototype._characterDataModified):
(WebInspector.DOMAgent.prototype._documentUpdated):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
(WebInspector.DOMAgent.prototype._setChildNodes):
(WebInspector.DOMAgent.prototype._childNodeInserted):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMDispatcher.prototype.documentUpdated):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.show):
(WebInspector.ElementsPanel.prototype.setDocument):
* inspector/front-end/MetricsSidebarPane.js:
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.pushNodeToFrontend):
2011-03-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not push document into front-end, make it request one.
https://bugs.webkit.org/show_bug.cgi?id=55664
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.):
(initialize_DebuggerTest):
* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.nodeWithId.documentRequested):
(initialize_ElementTest.InspectorTest.nodeWithId):
(initialize_ElementTest.InspectorTest.dumpDOMAgentTree):
(initialize_ElementTest):
* inspector/console/command-line-api-inspect.html:
* inspector/elements/dom-agent-query-selector.html:
* inspector/elements/mutate-unknown-node.html:
* inspector/styles/styles-new-API.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Fri, 4 Mar 2011 09:26:01 +0000 (09:26 +0000)]
2011-03-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: summary bar may overlap content of the network item view
https://bugs.webkit.org/show_bug.cgi?id=55656
- drop custom summary bar placement logic, do it with CSS instead.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.resize):
(WebInspector.NetworkPanel.prototype._createSummaryBar):
(WebInspector.NetworkPanel.prototype._updateSummaryBar):
(WebInspector.NetworkPanel.prototype._updateFilter):
(WebInspector.NetworkPanel.prototype.show):
(WebInspector.NetworkPanel.prototype.refresh):
(WebInspector.NetworkPanel.prototype._reset):
(WebInspector.NetworkPanel.prototype._setLargerResources):
(WebInspector.NetworkPanel.prototype._updateOffscreenRows):
* inspector/front-end/networkPanel.css:
(.network-sidebar .data-grid td):
(.network-sidebar tr.filler td):
(.network-summary-bar):
(.network-sidebar .data-grid .network-summary-bar td):
(.network-summary-bar img):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Mar 2011 09:04:43 +0000 (09:04 +0000)]
2011-03-04 James Su <suzhe@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] keycode is always 0 when using non-Latin keyboard layout.
https://bugs.webkit.org/show_bug.cgi?id=54939
Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.
No intended functionality change.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
2011-03-04 James Su <suzhe@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] keycode is always 0 when using non-Latin keyboard layout.
https://bugs.webkit.org/show_bug.cgi?id=54939
No intended functionality change.
* src/mac/WebInputEventFactory.mm:
(WebKit::windowsKeyCodeForKeyEvent): Use the same implementation
provided in WebCore/platform/mac/KeyEventMac.mm.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 4 Mar 2011 08:53:01 +0000 (08:53 +0000)]
2011-03-04 Patrick Gansterer <paroga@webkit.org>
Unreviewed EFL build fix for r80324.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 4 Mar 2011 08:44:05 +0000 (08:44 +0000)]
2011-03-04 Patrick Gansterer <paroga@webkit.org>
Unreviewed EFL build fix for r80324.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Mar 2011 08:38:12 +0000 (08:38 +0000)]
2011-03-04 Zelidrag Hornung <zelidrag@chromium.org>
Reviewed by David Levin
Expose ability to create instance of DOMFileSystem from Chromium side.
https://bugs.webkit.org/show_bug.cgi?id=55618
* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFileSystem):
* src/WebFrameImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 4 Mar 2011 08:28:36 +0000 (08:28 +0000)]
2011-03-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: AppCache agent should have same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=55673
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::createFrontendLifetimeAgents):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::setFrontend):
(WebCore::InspectorApplicationCacheAgent::clearFrontend):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::networkStateChangedImpl):
(WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
(WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 4 Mar 2011 07:20:56 +0000 (07:20 +0000)]
Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.
Reviewed by Adam Roben.
Source/WebCore:
Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
on all platforms, and stub the functions on platforms that don't implement them.
Add startObservingCookieChanges and stopObservingCookieChanges to TemporaryLinkStubs
for platforms that don't implement them.
* platform/android/TemporaryLinkStubs.cpp:
* platform/brew/TemporaryLinkStubs.cpp:
* platform/chromium/TemporaryLinkStubs.cpp:
* platform/efl/TemporaryLinkStubs.cpp:
* platform/gtk/TemporaryLinkStubs.cpp:
* platform/haiku/TemporaryLinkStubs.cpp:
* platform/qt/TemporaryLinkStubsQt.cpp:
* platform/win/TemporaryLinkStubs.cpp:
Source/WebKit2:
Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
on all platforms, and stub the functions on platforms that don't implement them.
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::stopObservingCookieChanges):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 4 Mar 2011 07:03:55 +0000 (07:03 +0000)]
2011-03-03 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Refactor createRendererIfNeeded to avoid premature nextRenderer calculation
https://bugs.webkit.org/show_bug.cgi?id=55720
There are two thing going on here:
1. Delaying nextRenderer calculation until we actually use it,
previously we would always compute nextRenderer (expensive!)
even if no renderer insertion was to occur.
2. Fix fullscreen elements to be inserted into the right place
in the rendering tree. Previously they would always be the last
child in their parent's list, even if that wasn't the right place.
I don't know of any way to trigger the fullscreen bug,
but I tested this with peacekeeper and saw no performance change.
Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
but I don't really trust the stability of peacekeeper to begin with.
This paves the way for further improvement in our nextRenderer calculation.
* dom/Node.cpp:
(WebCore::Node::attach):
(WebCore::Node::previousRenderer):
(WebCore::Node::nextRenderer):
(WebCore::Node::createRendererAndStyle):
(WebCore::wrapWithRenderFullScreen):
(WebCore::Node::createRendererIfNeeded):
* dom/Node.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Mar 2011 06:43:08 +0000 (06:43 +0000)]
2011-03-03 Adam Klein <adamk@chromium.org>
Reviewed by David Levin.
Correct EntrySync.toURI test expectations to get the test passing under Chromium.
https://bugs.webkit.org/show_bug.cgi?id=55724
* fast/filesystem/workers/file-entry-to-uri-sync-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 4 Mar 2011 06:25:48 +0000 (06:25 +0000)]
2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
https://bugs.webkit.org/show_bug.cgi?id=55554
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::copyGlobalsTo): Pass nullptr instead of 0.
(JSC::JSGlobalObject::resizeRegisters): Ditto; also use OwnArrayPtr instead of a raw pointer.
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::addStaticGlobals): Ditto.
* wtf/PassOwnArrayPtr.h: Removed #define LOOSE_PASS_OWN_ARRAY_PTR
(WTF::PassOwnArrayPtr::PassOwnArrayPtr): Added a constructor that takes nullptr_t.
2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
https://bugs.webkit.org/show_bug.cgi?id=55554
* platform/Length.cpp:
(WebCore::newLengthArray): Pass nullptr instead of 0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Mar 2011 06:22:42 +0000 (06:22 +0000)]
2011-03-03 Nat Duca <nduca@chromium.org>
Reviewed by James Robinson.
[chromium] Create a LayerChromium layerTreeAsText. Add HUD to
LayerRendererChromium that draws compositor FPS and, optionally,
the layer tree.
https://bugs.webkit.org/show_bug.cgi?id=54710
* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(WebCore::Canvas2DLayerChromium::drawsContent):
* platform/graphics/chromium/CanvasLayerChromium.h:
(WebCore::CanvasLayerChromium::layerTypeAsString):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::writeIndent):
(WebCore::ContentLayerChromium::dumpLayerProperties):
* platform/graphics/chromium/ContentLayerChromium.h:
(WebCore::ContentLayerChromium::drawsContent):
(WebCore::ContentLayerChromium::layerTypeAsString):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setName):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.h:
(WebCore::ImageLayerChromium::drawsContent):
(WebCore::ImageLayerChromium::layerTypeAsString):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setName):
(WebCore::LayerChromium::layerTreeAsText):
(WebCore::writeIndent):
(WebCore::LayerChromium::dumpLayer):
(WebCore::LayerChromium::dumpLayerProperties):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::name):
(WebCore::LayerChromium::drawsContent):
(WebCore::LayerChromium::debugID):
(WebCore::LayerChromium::layerTypeAsString):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::present):
(WebCore::LayerRendererChromium::layerTreeAsText):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::getHeadsUpDisplay):
(WebCore::LayerRendererChromium::rootVisibleRect):
* platform/graphics/chromium/PluginLayerChromium.h:
(WebCore::PluginLayerChromium::drawsContent):
(WebCore::PluginLayerChromium::layerTypeAsString):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::name):
(WebCore::writeIndent):
(WebCore::RenderSurfaceChromium::dumpSurface):
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/VideoLayerChromium.h:
(WebCore::VideoLayerChromium::drawsContent):
(WebCore::VideoLayerChromium::layerTypeAsString):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebCore::WebGLLayerChromium::drawsContent):
(WebCore::WebGLLayerChromium::layerTypeAsString):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added.
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::onPresent):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added.
(WebCore::CCHeadsUpDisplay::setShowFPSCounter):
(WebCore::CCHeadsUpDisplay::showFPSCounter):
(WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::writeIndent):
(WebCore::CCLayerImpl::dumpLayerProperties):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::debugID):
(WebCore::CCLayerImpl::setName):
(WebCore::CCLayerImpl::name):
2011-03-03 Nat Duca <nduca@chromium.org>
Reviewed by James Robinson.
[chromium] Create a LayerChromium layerTreeAsText. Add HUD to
LayerRendererChromium that draws compositor FPS and, optionally,
the layer tree.
https://bugs.webkit.org/show_bug.cgi?id=54710
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setShowFPSCounter):
(WebKit::WebSettingsImpl::setShowPlatformLayerTree):
* src/WebSettingsImpl.h:
(WebKit::WebSettingsImpl::showFPSCounter):
(WebKit::WebSettingsImpl::showPlatformLayerTree):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::doComposite):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 4 Mar 2011 06:20:57 +0000 (06:20 +0000)]
2011-03-02 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
crash in adoptNode with mutation events
https://bugs.webkit.org/show_bug.cgi?id=50046
* fast/dom/adopt-node-crash.html:
2011-03-02 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
crash in adoptNode with mutation events
https://bugs.webkit.org/show_bug.cgi?id=50046
If the DOM is modified during the removeChild call in adoptNode,
then the setDocument call that follows can leave the DOM in an
inconsistent state.
* dom/Document.cpp:
(WebCore::Document::adoptNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Mar 2011 06:02:10 +0000 (06:02 +0000)]
2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add audio tag tests to the media controls manual test suite.
https://bugs.webkit.org/show_bug.cgi?id=55722
* manual-tests/media-controls.html: Added 4 audio tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Fri, 4 Mar 2011 05:50:44 +0000 (05:50 +0000)]
2011-03-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
https://bugs.webkit.org/show_bug.cgi?id=54392
Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKit coding style.
WebCore's functions should adhere WebKit coding style.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::cacheThemePartReset):
(WebCore::RenderThemeEfl::cacheThemePartResizeAndReset):
(WebCore::RenderThemeEfl::cacheThemePartGet):
(WebCore::RenderThemeEfl::cacheThemePartFlush):
(WebCore::RenderThemeEfl::applyEdjeStateFromForm):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::renderThemeEflColorClassSelectionActive):
(WebCore::renderThemeEflColorClassSelectionInactive):
(WebCore::renderThemeEflColorClassFocusRing):
(WebCore::renderThemeEflColorClassButtonText):
(WebCore::renderThemeEflColorClassComboText):
(WebCore::renderThemeEflColorClassEntryText):
(WebCore::renderThemeEflColorClassSearchText):
(WebCore::RenderThemeEfl::applyPartDescription):
(WebCore::RenderThemeEfl::applyPartDescriptions):
(WebCore::RenderThemeEfl::controlSupportsTints):
(WebCore::RenderThemeEfl::baselinePosition):
(WebCore::RenderThemeEfl::paintSliderTrack):
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::paintSliderThumb):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::paintCheckbox):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::paintRadio):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::paintButton):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::paintMenuList):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::paintTextField):
(WebCore::RenderThemeEfl::adjustTextAreaStyle):
(WebCore::RenderThemeEfl::paintTextArea):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeEfl::paintSearchFieldDecoration):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::paintSearchFieldResultsButton):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::paintSearchFieldCancelButton):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
(WebCore::RenderThemeEfl::paintSearchField):
(WebCore::RenderThemeEfl::adjustProgressBarStyle):
(WebCore::RenderThemeEfl::paintProgressBar):
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
(WebCore::RenderThemeEfl::paintMediaMuteButton):
(WebCore::RenderThemeEfl::paintMediaPlayButton):
(WebCore::RenderThemeEfl::paintMediaSeekBackButton):
(WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
(WebCore::RenderThemeEfl::paintMediaSliderTrack):
(WebCore::RenderThemeEfl::paintMediaSliderThumb):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeEfl::paintMediaCurrentTime):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 4 Mar 2011 05:36:17 +0000 (05:36 +0000)]
2011-03-03 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add jsc to JavaScriptCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55711
* JavaScriptCore.gypi:
- Move jsc.cpp into jsc_files because it's really part of the jsc
target.
* JavaScriptCore.xcodeproj/project.pbxproj:
- Remove extraneous files from the normal jsc build. I probably
added these by mistake at some point.
* gyp/JavaScriptCore.gyp:
- Add the jsc target to the GYP file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Fri, 4 Mar 2011 05:36:03 +0000 (05:36 +0000)]
2011-03-03 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Refactor classes in GenericCallback.h
https://bugs.webkit.org/show_bug.cgi?id=55732
Since we're going to need to add additional callback classes, make a CallbackBase class that manages
the context and the callback ID. The existing callback classes (VoidCallback, GenericCallback, and
ComputedPagesCallback) now all derive from CallbackBase.
Fix bug in VoidCallback where we meant to implement the destructor, but we were implementing the default
constructor instead (we forgot the leading ~).
* UIProcess/GenericCallback.h:
(WebKit::CallbackBase::~CallbackBase):
(WebKit::CallbackBase::callbackID):
(WebKit::CallbackBase::CallbackBase):
(WebKit::CallbackBase::context):
(WebKit::CallbackBase::generateCallbackID):
(WebKit::VoidCallback::~VoidCallback):
(WebKit::VoidCallback::performCallback):
(WebKit::VoidCallback::invalidate):
(WebKit::VoidCallback::VoidCallback):
(WebKit::GenericCallback::create):
(WebKit::GenericCallback::~GenericCallback):
(WebKit::GenericCallback::performCallbackWithReturnValue):
(WebKit::GenericCallback::invalidate):
(WebKit::GenericCallback::GenericCallback):
(WebKit::ComputedPagesCallback::create):
(WebKit::ComputedPagesCallback::~ComputedPagesCallback):
(WebKit::ComputedPagesCallback::performCallbackWithReturnValue):
(WebKit::ComputedPagesCallback::invalidate):
(WebKit::ComputedPagesCallback::ComputedPagesCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 4 Mar 2011 05:24:57 +0000 (05:24 +0000)]
2011-03-03 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add testapi to JavaScriptCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55707
The new testapi target is slightly incomplete. There's a resource
copying step that we don't quite have yet.
This patch also cleans up some of the configuration issues in
JavaScriptCore.xcodeproj. It seems kind of wordy to repeat these for
each target. I suspect there's a more compact way of defining the
configurations, but this removes the "Default" configuration, which is
progress.
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 4 Mar 2011 05:15:04 +0000 (05:15 +0000)]
2011-03-03 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Assertion failure in toElement(WebCore::Node*)
https://bugs.webkit.org/show_bug.cgi?id=55697
* fast/parser/fragment-foreign-content-expected.txt: Added.
* fast/parser/fragment-foreign-content.html: Added.
2011-03-03 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Assertion failure in toElement(WebCore::Node*)
https://bugs.webkit.org/show_bug.cgi?id=55697
Test: fast/parser/fragment-foreign-content.html
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): The current
element in the HTMLElementStack might be a DocumentFragment if a
fragment is being parsed who's first node is foreign content.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Mar 2011 05:13:10 +0000 (05:13 +0000)]
2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[QT] Implement mock client-based geolocation for layout testing
https://bugs.webkit.org/show_bug.cgi?id=54334
Re-enable geolocation layout testing for qt port. Also enable a long pending
failure with geolocation as it works with client-based geolocation.
Skipped one last case related to multiple window which needs some code cleanup in qt DRT.
* platform/qt/Skipped:
2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[QT] Implement mock client-based geolocation for layout testing
https://bugs.webkit.org/show_bug.cgi?id=54334
Implements client() to GeolocationController to re-use geolocationClientMock class
for layout testing purpose.
* page/GeolocationController.h:
(WebCore::GeolocationController::client):
2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[QT] Implement mock client-based geolocation for layout testing
https://bugs.webkit.org/show_bug.cgi?id=54334
Implement layout testing for Client-Based geolocation. If drt_run is set
then create mock geolocationClient and update the same with controller.
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::mockGeolocationReset):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/GeolocationClientQt.cpp:
(WebCore::GeolocationClientQt::GeolocationClientQt):
* WebCoreSupport/GeolocationClientQt.h:
2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[QT] Implement mock client-based geolocation for layout testing
https://bugs.webkit.org/show_bug.cgi?id=54334
Implement testing for Client-Based geolocation for QtWebkit.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::setGeolocationPermission):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::setMockGeolocationPosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Fri, 4 Mar 2011 05:00:40 +0000 (05:00 +0000)]
Unreviewed, update chromium test expectations.
Update GPU media/media-document-audio-repaint.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20GPU%20Mesa%20-%20chromium.org&tests=media%2Fmedia-document-audio-repaint.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 4 Mar 2011 04:58:20 +0000 (04:58 +0000)]
2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Stop calling deprecatedNode and deprecatedEditingOffset in InsertTextCommand
https://bugs.webkit.org/show_bug.cgi?id=55352
Stopped calling deprecatedNode and deprecatedEditingOffset in the following functions:
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::positionOutsideTabSpan): Takes care of all types of positions and
no longer calls deprecated functions.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::positionInsideTextNode): Ditto; renamed from prepareForTextInsertion.
Check if the text node inside a tab span before checking if the container node is a text node
because the position before or after a text node can still be inside a tab span.
(WebCore::InsertTextCommand::input): No longer calls deprecated functions.
* editing/InsertTextCommand.h:
* editing/ModifySelectionListLevel.cpp:
(WebCore::getStartEndListChildren): Call anchorNode() instead of deprecatedNode() because the start
or the end of selection could be an immediate child of a list node (e.g. br inside ul)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeremy@chromium.org [Fri, 4 Mar 2011 04:55:23 +0000 (04:55 +0000)]
2011-03-03 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dimitri Glazkov.
Annotate bidi tests which we intentionally fail.
https://bugs.webkit.org/show_bug.cgi?id=48522
Add a readme file in fast/text/international detailing
a bunch of tests that we intentionally fail. This
mimics a similar file in fast/block/positioning/.
* fast/text/international/readme.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Fri, 4 Mar 2011 04:52:55 +0000 (04:52 +0000)]
2011-03-03 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Move last bits of SQL into IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=55668
After this, all SQL code for IndexedDB is in IDBBackingStore.cpp.
No new tests: refactoring only.
* storage/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::createTransaction):
* storage/IDBBackingStore.h:
* storage/IDBCursorBackendImpl.h:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::backingStore):
* storage/IDBDatabaseBackendImpl.h:
* storage/IDBIndexBackendImpl.h:
* storage/IDBKey.h:
* storage/IDBObjectStoreBackendImpl.h:
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
* storage/IDBTransactionBackendImpl.h:
* storage/IDBTransactionBackendInterface.h:
* storage/IDBTransactionCoordinator.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Mar 2011 04:50:13 +0000 (04:50 +0000)]
2011-03-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebFrame::setUrl works only from second time if url fragment is present
https://bugs.webkit.org/show_bug.cgi?id=32723
Create an auto-test for Qt based on the bug description.
* tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Mar 2011 04:25:39 +0000 (04:25 +0000)]
2011-03-03 Adam Klein <adamk@chromium.org>
Reviewed by David Levin.
[fileapi] Tighten up ResolveURICallbacks
https://bugs.webkit.org/show_bug.cgi?id=55638
Two changes:
- Retry only on TYPE_MISMATCH_ERR now that Chromium
properly sets that error code.
- Call DirectoryEntry instead of DOMFileSystem methods.
No change in behavior, so no new tests.
* fileapi/FileSystemCallbacks.cpp:
(WebCore::ResolveURICallbacks::didOpenFileSystem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 4 Mar 2011 04:09:36 +0000 (04:09 +0000)]
2011-03-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Teach JavaScriptCore GYP build about private headers
https://bugs.webkit.org/show_bug.cgi?id=55532
This patch distinguishes between public and private framework headers
so that public headers are copied into the Headers directory and
private headers are copied into the PrivateHeaders directory.
* gyp/JavaScriptCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 4 Mar 2011 03:41:32 +0000 (03:41 +0000)]
2011-03-03 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Need web worker referer layout test for xhr requests.
https://bugs.webkit.org/show_bug.cgi?id=55590
Verify that the referrer is set for sync and async XHR requests
from both workers and shared workers.
* http/tests/xmlhttprequest/workers/referer-expected.txt: Added.
* http/tests/xmlhttprequest/workers/referer.html: Added.
* http/tests/xmlhttprequest/workers/resources/referer-test.js: Added.
* http/tests/xmlhttprequest/workers/resources/referer.js: Added.
* http/tests/xmlhttprequest/workers/shared-worker-referer-expected.txt: Added.
* http/tests/xmlhttprequest/workers/shared-worker-referer.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 4 Mar 2011 03:21:07 +0000 (03:21 +0000)]
2011-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Get rid of Page::globalHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=55738
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistoryItemForPage):
Get the current history item and update it using WebView::setGlobalHistoryItem.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebView.cpp:
(WebView::globalHistoryItem):
(WebView::setGlobalHistoryItem):
* WebView.h:
2011-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Get rid of Page::globalHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=55738
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::updateGlobalHistoryItemForPage):
Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
* WebView/WebView.mm:
(-[WebView _globalHistoryItem]):
(-[WebView _setGlobalHistoryItem:]):
Set _globalHistoryItem ivar.
* WebView/WebViewData.h:
* WebView/WebViewData.mm:
Add _globalHistoryItem ivar.
2011-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Get rid of Page::globalHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=55738
The m_globalHistoryItem is only used by Mac and Windows WebKit1.
Instead of having WebCore updating this member variable, just call out
to a FrameLoaderClient member function and let WebKit keep it up to date.
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem):
(WebCore::EmptyFrameLoaderClient::updateGlobalHistoryItemForPage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::updateGlobalHistoryItemForPage):
* loader/HistoryController.cpp:
(WebCore::HistoryController::goToItem):
(WebCore::HistoryController::updateForStandardLoad):
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
* page/Page.cpp:
* page/Page.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Mar 2011 03:00:48 +0000 (03:00 +0000)]
Don't assume the web process has had a chance to paint before the view has to paint
Fixes <http://webkit.org/b/55739> REGRESSION (r80307): Lots of tests crashing in
BackingStore::paint
Reviewed by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::paint): Bail if the web process hasn't had a chance to paint
yet.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Mar 2011 02:18:45 +0000 (02:18 +0000)]
2011-03-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Cursor.continue with a key param should test less than, not equal to
https://bugs.webkit.org/show_bug.cgi?id=55640
* storage/indexeddb/cursor-continue-expected.txt: Added.
* storage/indexeddb/cursor-continue.html: Added.
2011-03-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Cursor.continue with a key param should test less than, not equal to
https://bugs.webkit.org/show_bug.cgi?id=55640
If you supply a param to cursor.continue, we sould guarantee that
the item we continue to is greater than or equal to the parameter.
Right now, we only test equality.
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-continue
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-iterating-a-cursor
Test: storage/indexeddb/cursor-continue.html
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
* storage/IDBKey.cpp:
(WebCore::IDBKey::isLessThan):
(WebCore::IDBKey::isEqual):
* storage/IDBKey.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Mar 2011 01:37:11 +0000 (01:37 +0000)]
Throw away DrawingAreaProxyImpl's backing store after not painting for 5 seconds
The intent is to save memory for views that aren't painting.
Fixes <http://webkit.org/b/51262> <rdar://problem/
8782537> WebPageProxy should delete its
backing store after not painting for a while
Reviewed by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize our timer.
(WebKit::DrawingAreaProxyImpl::paint): Don't bail if we don't have a backing store (but do
bail if we're in accelerated compositing mode); we might have thrown it away to save memory
but now are being asked to paint by the view. The existing code in this function will handle
getting a new backing store if possible by blocking for a little while to try to receive a
DidUpdateBackingStoreState message. Added an assertion that we do have a backing store if we
don't have any outstanding UpdateBackingStoreState requests. After painting, call
discardBackingStoreSoon to update our timer.
(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon): Set the timer for 5 seconds in the
future.
(WebKit::DrawingAreaProxyImpl::discardBackingStore): Throw away the backing store, and tell
the web process we'll need a full backing store update on the next paint.
* UIProcess/DrawingAreaProxyImpl.h: Added m_discardBackingStoreTimer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Mar 2011 01:36:29 +0000 (01:36 +0000)]
Add a way to tell the web process to perform a full backing store update on its next paint
Messages::DrawingArea::UpdateBackingStoreState now takes a boolean specifying whether the
full backing store update should happen immediately or should be deferred until the next
paint or compositing mode change occurs. The deferred update isn't used yet, but will be
used when we start throwing away backing stores to save memory.
Fixes <http://webkit.org/b/55730> UI process needs a way to tell the web process its backing
store needs a full update on the next paint
Reviewed by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::paint): If we have an outstanding backing store state change
request, tell the web process to perform the backing store update right away, in case we
previously told it it could defer the update.
(WebKit::DrawingAreaProxyImpl::sizeDidChange): Specify that we need an immediate backing
store update.
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): We can no longer assert that we
were waiting for a DidUpdateBackingStoreState message when we receive one, as it's possible
for the web process to decide to send us this message on its own (if we asked it to do a
deferred backing store update and then it needed to paint some part of the page). Specify
that we need an immediate backing store update if the web process hasn't updated to our
latest state, as we're about to draw potentially out-of-date bits to the screen and want to
get the right bits as soon as possible. Also added a FIXME about a potential optimization.
(WebKit::DrawingAreaProxyImpl::backingStoreStateDidChange): Added a RespondImmediatelyOrNot
parameter, which is just passed through to sendUpdateBackingStoreState.
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState): Added a RespondImmediatelyOrNot
parameter that is used to specify to the web process whether to perform the full backing
store update immediately. We now only wait for a DidUpdateBackingStoreState message (and
thus suppress any more UpdateBackingStoreState messages until one is received) when we ask
the web process for an immediate response; otherwise we could end up accidentally calling
waitForAndDispatchDidUpdateBackingStoreState when the web process hasn't been told to send
us such a message.
* UIProcess/DrawingAreaProxyImpl.h: Added RespondImmediatelyOrNot.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::updateBackingStoreState): Added respondImmediately argument.
* WebProcess/WebPage/DrawingArea.messages.in: Added respondImmediately argument to
UpdateBackingStoreState message.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize new member that's used to track
whether we should send a DidUpdateBackingStoreState message instead of an Update or
compositing mode change message. This will be set to true when a deferred backing store
update is pending.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers): If a deferred update is pending, send a
DidUpdateBackingStoreState message instead of a compositing mode change message.
(WebKit::DrawingAreaImpl::updateBackingStoreState): Added respondImmediately argument. If
we've already been told about this state ID (as can happen when the UI process decides it
needs an immediate update to a state that it previously requested a deferred update to),
don't bother updating the page's size, etc. In addition, if we've already sent a
DidUpdateBackingStoreState message for this state, we don't have to do anything at all.
Moved code to send the DidUpdateBackingStoreState message from here...
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): ...to here.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Always update our dirty region,
even if painting is suspended or we're in the process of updating the backing store state.
It causes no harm and simplifies the code. If a deferred update is pending, send a
DidUpdateBackingStoreState message instead of a compositing mode change message. Also
removed a redundant if.
(WebKit::DrawingAreaImpl::display): Added an assertion that this isn't called while updating
backing store state, as otherwise we might end up sending two DidUpdateBackingStoreState
messages. If a deferred update is pending, send a DidUpdateBackingStoreState message instead
of an Update message.
* WebProcess/WebPage/DrawingAreaImpl.h: Updated updateBackingStoreState to match the base
class. Added sendDidUpdateBackingStoreState and m_shouldSendDidUpdateBackingStoreState.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 4 Mar 2011 01:36:28 +0000 (01:36 +0000)]
Unreviewed build correction.
* WebFrame.cpp:
(scaleFactor): Update after 77286 to replace right/bottom
with new maxX/maxY terminology.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 4 Mar 2011 01:31:25 +0000 (01:31 +0000)]
Build fix. Need win/cURL DownloadBundle stub.
* platform/network/curl/DownloadBundle.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 4 Mar 2011 01:27:22 +0000 (01:27 +0000)]
2011-03-03 Geoffrey Garen <ggaren@apple.com>
Rolled out 80277 and 80280 because they caused event handler layout test
failures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 4 Mar 2011 00:58:07 +0000 (00:58 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Mar 2011 00:55:52 +0000 (00:55 +0000)]
2011-03-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80237.
http://trac.webkit.org/changeset/80237
https://bugs.webkit.org/show_bug.cgi?id=55714
Windows bots aren't ready to be core (Requested by aroben on
#webkit).
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 4 Mar 2011 00:52:52 +0000 (00:52 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55721
Global IconDatabase should be returned by reference, not as a pointer
Reviewed by Darin Adler.
../WebCore:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::icon):
(WebCore::HistoryItem::setURLString):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::commitIconURLToIconDatabase):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* loader/icon/IconDatabase.cpp:
(WebCore::iconDatabase):
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseNone.cpp:
(WebCore::iconDatabase):
* loader/icon/wince/IconDatabaseWinCE.cpp:
(WebCore::iconDatabase):
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::finishLoading):
../WebKit/efl:
* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_path_set):
(ewk_settings_icon_database_path_get):
(ewk_settings_icon_database_clear):
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):
../WebKit/gtk:
* webkit/webkitglobals.cpp:
(closeIconDatabaseOnExit):
(WebKit::setIconDatabaseEnabled):
* webkit/webkitwebview.cpp:
(webkit_web_view_get_icon_uri):
../WebKit/mac:
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics iconPageURLMappingCount]):
(+[WebCoreStatistics iconRetainedPageURLCount]):
(+[WebCoreStatistics iconRecordCount]):
(+[WebCoreStatistics iconsWithDataCount]):
* Misc/WebIconDatabase.mm:
(-[WebIconDatabase init]):
(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconURLForURL:]):
(-[WebIconDatabase defaultIconWithSize:]):
(-[WebIconDatabase retainIconForURL:]):
(-[WebIconDatabase releaseIconForURL:]):
(-[WebIconDatabase isEnabled]):
(-[WebIconDatabase setEnabled:]):
(-[WebIconDatabase removeAllIcons]):
(+[WebIconDatabase _checkIntegrityBeforeOpening]):
(-[WebIconDatabase _startUpIconDatabase]):
(-[WebIconDatabase _applicationWillTerminate:]):
(-[WebIconDatabase _resetCachedWebPreferences:]):
(importToWebCoreFormat):
* WebView/WebView.mm:
(-[WebView _dispatchDidReceiveIconFromWebFrame:]):
../WebKit/qt:
* Api/qwebsettings.cpp:
(QWebSettings::setIconDatabasePath):
(QWebSettings::iconDatabasePath):
(QWebSettings::clearIconDatabase):
(QWebSettings::iconForUrl):
../WebKit/win:
* WebCoreStatistics.cpp:
(WebCoreStatistics::iconPageURLMappingCount):
(WebCoreStatistics::iconRetainedPageURLCount):
(WebCoreStatistics::iconRecordCount):
(WebCoreStatistics::iconsWithDataCount):
* WebIconDatabase.cpp:
(WebIconDatabase::init):
(WebIconDatabase::startUpIconDatabase):
(WebIconDatabase::iconForURL):
(WebIconDatabase::retainIconForURL):
(WebIconDatabase::releaseIconForURL):
(WebIconDatabase::removeAllIcons):
(WebIconDatabase::iconURLForURL):
(WebIconDatabase::isEnabled):
(WebIconDatabase::setEnabled):
(WebIconDatabase::hasIconForURL):
(WebIconDatabase::getOrCreateDefaultIconBitmap):
* WebKitDLL.cpp:
(shutDownWebKit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 4 Mar 2011 00:49:21 +0000 (00:49 +0000)]
2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Martin Robinson.
Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
https://bugs.webkit.org/show_bug.cgi?id=52742
Use firstPositionInOrBeforeNode to instantiate appropriate position.
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusInDocumentOrder):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 4 Mar 2011 00:42:34 +0000 (00:42 +0000)]
When displaying the missing plug-in sheet, pass the 'pluginspage'
attribute to the UI process.
https://bugs.webkit.org/show_bug.cgi?id=55553
Reviewed by Darin Adler.
Source/WebCore:
* WebCore.exp.in: Export __ZN7WebCore9HTMLNames15pluginspageAttrE.
* html/HTMLAttributeNames.in: Add 'pluginspage' as a known content
attribute.
Source/WebKit2:
* UIProcess/API/C/WKPage.h: Add pluginsPageURL as the third argument to
missingPluginButtonClicked.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::missingPluginButtonClicked): Ditto.
* UIProcess/WebPageProxy.h: Ditto.
* UIProcess/WebPageProxy.messages.in: Ditto.
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::missingPluginButtonClicked): Ditto.
* UIProcess/WebUIClient.h: Ditto.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::missingPluginButtonClicked): Get the value of
pluginspageAttr.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 4 Mar 2011 00:32:42 +0000 (00:32 +0000)]
Suggested by Dan Bernstein.
Move "const" around "NSString *", so that it suddenly begins to make sense.
* WebProcess/mac/FullKeyboardAccessWatcher.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Fri, 4 Mar 2011 00:11:17 +0000 (00:11 +0000)]
2011-03-03 Jeff Miller <jeffm@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Add WKViewRef API for executing edit commands
https://bugs.webkit.org/show_bug.cgi?id=49829
Added WKViewExecuteCommand() and documented some of the WebCore EditorCommand strings.
* UIProcess/API/C/win/WKView.cpp:
(WKViewExecuteCommand): Added.
* UIProcess/API/C/win/WKView.h: Added WKViewExecuteCommand() and comment block with WebCore EditorCommand strings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 3 Mar 2011 23:43:07 +0000 (23:43 +0000)]
Source/WebCore: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435
Reviewed by Adam Roben.
Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
* WebCore.exp.in:
Support using WKCopyRequestWithStorageSession in WebCore.
* platform/mac/WebCoreSystemInterface.h:
Ditto.
* platform/mac/WebCoreSystemInterface.mm:
Ditto.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::makeFinalRequest):
If Private Browsing is enabled, set the Private Browsing Storage Session on the request.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
* platform/network/cf/ResourceRequest.h:
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::setStorageSession):
Call through to WKSI.
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::setStorageSession):
Ditto.
Source/WebKit/mac: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.
Reviewed by Adam Roben.
Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Support using WKCopyRequestWithStorageSession in WebCore.
Source/WebKit2: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435
Reviewed by Adam Roben.
Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Support using WKCopyRequestWithStorageSession in WebCore.
WebKitLibraries: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435
Reviewed by Adam Roben.
Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
Update WebKitSystemInterface headers and libraries with the new functions.
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 23:36:16 +0000 (23:36 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium Snow Leopard expectations update.
Fix a couple more media/ expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 3 Mar 2011 23:33:58 +0000 (23:33 +0000)]
Don't try to paint outside the page's bounds
When the page is resized smaller, we would allocate a ShareableBitmap at the old, larger
size, even though we only needed to paint at the new, smaller size.
The assertion added in this patch will fire during the WebKit2/ResizeViewWhileHidden API
test if this fix gets broken in the future.
Fixes <http://webkit.org/b/55715> DrawingAreaImpl allocates more memory than necessary when
the page is resized smaller
Reviewed by Anders Carlsson.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updateBackingStoreState): Update our dirty region even if painting
is suspended (but still refrain from updating it when in accelerated compositing mode).
Rather than unite our existing dirty region with the page's new bounds, overwrite our dirty
region with the page's new bounds. This prevents us from accumulating a dirty region that is
larger than the page in the case where the page is being resized smaller.
(WebKit::DrawingAreaImpl::display): Added an assertion that we're not trying to paint
outside of the page's bounds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 23:28:55 +0000 (23:28 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium Snow Leopard expectations update.
Add another media/ crash.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 23:24:33 +0000 (23:24 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium Snow Leopard rebaseline.
Rebaseline tables/mozilla/bugs/ tests for Snow Leopard. The current
expectations were just checksums, I also added their corresponding PNGs.
We can't use the mac/ baselines since we scale the images differently
(most likely due to CG i386 vs. x86_64 differences, see bug 52335).
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-1-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-1-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug12910-2-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1296-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1296-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1430-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1430-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug14929-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug14929-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2981-2-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4093-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4093-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4427-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4427-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4523-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug56563-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug56563-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug5797-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug5797-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug625-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug625-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug625-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug6404-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug6404-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug97383-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug97383-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png.
* platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug625-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Thu, 3 Mar 2011 23:15:37 +0000 (23:15 +0000)]
2011-03-03 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
REGRESSION: Accelerated transitions are jumpy
https://bugs.webkit.org/show_bug.cgi?id=55022
Changed the way default TimingFunction is stored according to Adam Roben's
suggestion.
* platform/animation/TimingFunction.h:
(WebCore::CubicBezierTimingFunction::defaultTimingFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 3 Mar 2011 23:09:11 +0000 (23:09 +0000)]
Rename -webkit-hyphenate-locale to -webkit-locale
https://bugs.webkit.org/show_bug.cgi?id=55709
Reviewed by Sam Weinig.
Source/WebCore:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::cssPropertyID):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::locale):
(WebCore::InheritedFlags::setLocale):
(WebCore::InheritedFlags::initialLocale):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
LayoutTests:
* fast/text/hyphenate-character.html:
* fast/text/hyphenate-first-word.html:
* fast/text/hyphenate-locale.html:
* fast/text/hyphens.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 3 Mar 2011 22:51:22 +0000 (22:51 +0000)]
[wx] Build fixes for Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 22:41:43 +0000 (22:41 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
Two tests crash on Snow Leopard on the GPU path.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 3 Mar 2011 22:30:59 +0000 (22:30 +0000)]
2011-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
JSVariableObject needs to use WriteBarrier for symboltable property storage
https://bugs.webkit.org/show_bug.cgi?id=55698
Replace the direct usage of Register in JSVariableObject (and descendents)
with WriteBarrier. This requires updating the Arguments object to use
WriteBarrier as well.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::initialize):
* runtime/Arguments.cpp:
(JSC::Arguments::markChildren):
(JSC::Arguments::copyToRegisters):
(JSC::Arguments::fillArgList):
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
* runtime/Arguments.h:
(JSC::Arguments::setActivation):
(JSC::Arguments::Arguments):
(JSC::Arguments::copyRegisters):
(JSC::JSActivation::copyRegisters):
* runtime/JSActivation.cpp:
(JSC::JSActivation::markChildren):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::symbolTablePutWithAttributes):
(JSC::JSActivation::put):
(JSC::JSActivation::putWithAttributes):
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putWithAttributes):
(JSC::JSGlobalObject::markChildren):
(JSC::JSGlobalObject::copyGlobalsFrom):
(JSC::JSGlobalObject::copyGlobalsTo):
(JSC::JSGlobalObject::resizeRegisters):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::setRegisters):
(JSC::JSGlobalObject::addStaticGlobals):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putWithAttributes):
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::symbolTableGet):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::registerAt):
(JSC::JSVariableObject::JSVariableObjectData::JSVariableObjectData):
(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::symbolTablePut):
(JSC::JSVariableObject::symbolTablePutWithAttributes):
(JSC::JSVariableObject::copyRegisterArray):
(JSC::JSVariableObject::setRegisters):
2011-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
JSVariableObject needs to use WriteBarrier for symboltable property storage
https://bugs.webkit.org/show_bug.cgi?id=55698
Update to pass JSGlobalData for the symbol table write used
to set the document property.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::updateDocument):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 22:18:54 +0000 (22:18 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
https://bugs.webkit.org/show_bug.cgi?id=55694
Fixes for interruptions in NRWT:
- Make TestRunInterruptedException be pickleable correctly (the base
Exception class defines a __reduce__ that does not include the reason)
- Fix ordering of returned arguments from TestRunner2._run_tests
(interrupted and keyboard_interrupted were reversed)
- Fix cancel_workers callsites (was using old name).
- In handle_exception re-raise actual exception instance that was thrown
* Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
* Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
* Scripts/webkitpy/layout_tests/layout_package/worker.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 3 Mar 2011 22:04:35 +0000 (22:04 +0000)]
More build fixing. Move WebCoreKeyboardUIMode.h to a cross-platform location.
* WebCore.xcodeproj/project.pbxproj:
* page/WebCoreKeyboardUIMode.h: Copied from WebCore/page/mac/WebCoreKeyboardUIMode.h.
* page/mac/WebCoreKeyboardUIMode.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 3 Mar 2011 21:55:03 +0000 (21:55 +0000)]
Build fix. Should include WebCoreKeyboardUIMode.h on all platforms now.
* page/ChromeClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 3 Mar 2011 21:42:44 +0000 (21:42 +0000)]
2011-03-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Brady Eidson.
WebProcess is calling CFURLCacheRemoveAllCachedResponses when loading, results in origin-load for all resources
https://bugs.webkit.org/show_bug.cgi?id=55701
<rdar://problem/
9074017>
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Initialize cache-clearing
flag parameters to false.
(WebKit::WebProcessCreationParameters::encode): Serialize them properly.
(WebKit::WebProcessCreationParameters::decode): And deserialize.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 3 Mar 2011 21:39:38 +0000 (21:39 +0000)]
Try to fix Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed obsolete symbol.
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::getOwnPropertySlot): Don't mark this function
inline -- it's virtual.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 3 Mar 2011 21:34:20 +0000 (21:34 +0000)]
Reviewed by Darin Adler.
REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
https://bugs.webkit.org/show_bug.cgi?id=55633
<rdar://problem/
8963023>
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/mac/FullKeyboardAccessWatcher.h: Added.
* WebProcess/mac/FullKeyboardAccessWatcher.mm: Added.
(-[FullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]):
(-[FullKeyboardAccessWatcher init]):
(+[FullKeyboardAccessWatcher fullKeyboardAccessEnabled]):
Get the current state of full keyboard access, listening for change notifications.
* WebProcess/WebProcess.h: Added fullKeyboardAccessEnabled().
* WebProcess/WebProcess.cpp: (WebKit::WebProcess::fullKeyboardAccessEnabled):
WebKit1 also doesn't implement this on platforms other than Mac.
* WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::fullKeyboardAccessEnabled):
Just ask FullKeyboardAccessWatcher.
* WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::keyboardUIMode):
* WebProcess/WebCoreSupport/WebChromeClient.h:
Added keyboardUIMode(), removed tabsToLinks().
* WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::keyboardUIMode):
* WebProcess/WebPage/WebPage.h:
Generate keyboard UI mode from tabToLinks preference and current state of FKA.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 3 Mar 2011 21:28:19 +0000 (21:28 +0000)]
2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
Fix Win compile break, caused by r80276.
* rendering/RenderThemeWin.h: Changed signature of volumeSliderOffsetFromMuteButton
to match RenderTheme.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 3 Mar 2011 21:24:14 +0000 (21:24 +0000)]
2011-03-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Moved all variable object storage inline -- upping the object size limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653
* JavaScriptCore.exp:
* bytecompiler/BytecodeGenerator.cpp:
* jit/JITOpcodes.cpp:
* runtime/Arguments.h:
* runtime/JSActivation.h: Removed out-of-line storage. Changed d-> to m_.
* runtime/JSCell.h:
(JSC::JSCell::MarkedSpace::sizeClassFor): Added an imprecise size class
to accomodate objects up to 1K.
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h: Removed out-of-line storage. Changed d-> to m_.
* runtime/JSObject.cpp: Don't ASSERT that JSFinalObject fills the maximum
object size, since it doesn't anymore.
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/JSVariableObject.h: Removed out-of-line storage. Changed d-> to m_.
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::reset):
* runtime/MarkedSpace.h: Added an imprecise size class to accomodate objects up to 1K.
2011-03-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Moved all variable object storage inline -- upping the object size limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653
* JSRun.cpp:
(JSGlueGlobalObject::JSGlueGlobalObject):
* JSRun.h:
(JSGlueGlobalObject::Flags):
(JSGlueGlobalObject::userObjectStructure): Removed out-of-line storage. Changed d-> to m_.
2011-03-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Moved all variable object storage inline -- upping the object size limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.h:
* bindings/js/JSWorkerContextBase.cpp: Removed out-of-line storage. Changed d-> to m_.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 3 Mar 2011 21:19:23 +0000 (21:19 +0000)]
2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
https://bugs.webkit.org/show_bug.cgi?id=55099
Cleanup, no behavior change.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::updateVolumeSliderContainer): Changed to pass RenderBox
instead of Node.
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Changed
to use RenderBox as argument.
* rendering/RenderMediaControls.h: Ditto.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): Ditto.
* rendering/RenderTheme.h: Ditto.
* rendering/RenderThemeChromiumMac.h: Ditto.
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton): Ditto.
* rendering/RenderThemeMac.h: Ditto.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Ditto.
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 3 Mar 2011 21:06:05 +0000 (21:06 +0000)]
2011-03-03 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Give the Bundle's policy client the option of deciding the policy
https://bugs.webkit.org/show_bug.cgi?id=55699
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Add WKBundlePagePolicyAction enum and make it the return value of
the WKBundlePagePolicyClient functions.
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForMIMEType):
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
Pass the return value back to the caller. For unimplemented functions, return WKBundlePagePolicyActionPassThrough.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
Call the policy function early if the bundle handles it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 3 Mar 2011 21:03:04 +0000 (21:03 +0000)]
2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
When building with DEFINES+=USE_GSTREAMER=1 we don't want to define ENABLE_QT_MULTIMEDIA to 1.
Also add the new files added after https://bugs.webkit.org/show_bug.cgi?id=54870 to support GRefPtr
for GstElement.
* WebCore.pro:
* features.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 3 Mar 2011 21:00:46 +0000 (21:00 +0000)]
2011-03-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80272.
http://trac.webkit.org/changeset/80272
https://bugs.webkit.org/show_bug.cgi?id=55700
the test are flaky (Requested by loislo_ on #webkit).
* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.addObject):
* http/tests/inspector/protocol-test.js: Removed.
* inspector/protocol/runtime-agent-expected.txt: Removed.
* inspector/protocol/runtime-agent.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 3 Mar 2011 20:22:54 +0000 (20:22 +0000)]
2011-03-03 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce a protocol test for RuntimeAgent API.
https://bugs.webkit.org/show_bug.cgi?id=55482
* http/tests/inspector/protocol-test.js: Added.
(initialize_ProtocolTest.InspectorTest.filterProps):
(initialize_ProtocolTest.InspectorTest._dumpStepResult):
(initialize_ProtocolTest.InspectorTest._runNextStep):
(initialize_ProtocolTest.InspectorTest.runProtocolTestSuite):
(initialize_ProtocolTest):
* inspector/protocol/runtime-agent-expected.txt: Added.
* inspector/protocol/runtime-agent.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 3 Mar 2011 19:58:55 +0000 (19:58 +0000)]
Try to fix the Windows build again.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 3 Mar 2011 19:58:08 +0000 (19:58 +0000)]
2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
https://bugs.webkit.org/show_bug.cgi?id=55568
We should use updateMicroFocus() from QGraphicsItem rather than the implementation
in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
in QGraphicsItem.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::setPage):
* Api/qgraphicswebview.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 19:54:24 +0000 (19:54 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
Add another CRASH() for CSSSelector double frees
https://bugs.webkit.org/show_bug.cgi?id=55693
To help track down bug 53045, add a CRASH call when the the array and/or
CSSSelector member in CSSSelectorList is disposed of more than once.
Just a check, no new tests necessary.
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::deleteSelectors):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 3 Mar 2011 19:51:57 +0000 (19:51 +0000)]
Yet another attempt at fixing the Windows build.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
qi.2.zhang@nokia.com [Thu, 3 Mar 2011 19:36:52 +0000 (19:36 +0000)]
Unreviewed.
Adding myself as a committer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Thu, 3 Mar 2011 19:33:09 +0000 (19:33 +0000)]
2011-03-02 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
REGRESSION: Accelerated transitions are jumpy
https://bugs.webkit.org/show_bug.cgi?id=55022
Got rid of default TimingFunction values from PlatformCAAnimation*. A TimingFunction
is now always passed in. The TimingFunction class now has a static method to get
a default object which has the 'ease' values in it. I now assert in both Mac and
Win implementations if a null TimingFunction pointer is seen.
* platform/animation/TimingFunction.h:
(WebCore::CubicBezierTimingFunction::create):
(WebCore::CubicBezierTimingFunction::defaultTimingFunction):
(WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(toCAMediaTimingFunction):
* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(toCACFTimingFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 3 Mar 2011 19:28:21 +0000 (19:28 +0000)]
2011-03-03 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix clang compile after r80220
https://bugs.webkit.org/show_bug.cgi?id=55692
* storage/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 3 Mar 2011 19:21:11 +0000 (19:21 +0000)]
Attempt to fix the Windows build.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Thu, 3 Mar 2011 19:16:18 +0000 (19:16 +0000)]
Source/WebCore: Rest of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/
9056027>
Reviewed by Adam Roben.
Add functions to be exported.
* WebCore.exp.in:
Source/WebKit2: Rest of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/
9056027>
Reviewed by Adam Roben.
This patch adds the communication from the WebProcess <-> UIProcess about starting/stopping
listening for cookies changing, and adds a mechanism for the WebProcess to notify the UIProcess
when the cookies have changed. The WebProcess sends a message to the UIProcess when the cookies
change, and the UIProcess passes this along to the WebCookieManagerProxyClient.
* UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerSetClient): Call through to WebCookieManagerProxy.
(WKCookieManagerStartObservingCookieChanges): Ditto.
(WKCookieManagerStopObservingCookieChanges): Ditto.
* UIProcess/API/C/WKCookieManager.h: Add new functions and a WKCookieManagerClient
which is responsible for cookiesDidChange.
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::initializeClient):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges): Send the message down to the web process.
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges): Ditto.
(WebKit::WebCookieManagerProxy::cookiesDidChange): Tell the WKCookieManagerClient the cookies were
modified.
* UIProcess/WebCookieManagerProxy.h:
* UIProcess/WebCookieManagerProxy.messages.in: Add new messages.
* UIProcess/WebCookieManagerProxyClient.cpp: Added.
(WebKit::WebCookieManagerProxyClient::cookiesDidChange): Calls through to the client saying that
cookies changed.
* UIProcess/WebCookieManagerProxyClient.h: Added.
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::startObservingCookieChanges): Call through to WebCore::startObservingCookieChanges
(on platforms that support it).
(WebKit::WebCookieManager::stopObservingCookieChanges): Ditto (for stopObservingCookieChanges).
(WebKit::WebCookieManager::dispatchDidModifyCookies): Send a message to the UI process that cookies changed.
* WebProcess/Cookies/WebCookieManager.h:
* WebProcess/Cookies/WebCookieManager.messages.in:
Add new files.
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* GNUmakefile.am:
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 3 Mar 2011 19:15:58 +0000 (19:15 +0000)]
2011-03-03 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Mihai Parparita.
Teach sheriffbot to answer whois commands
https://bugs.webkit.org/show_bug.cgi?id=55687
* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 3 Mar 2011 19:14:45 +0000 (19:14 +0000)]
2011-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Remove CanRunBeforeUnloadConfirmPanel sync message
https://bugs.webkit.org/show_bug.cgi?id=55689
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Encode and decode canRunBeforeUnloadConfirmPanel, as well as canRunModal, which wasn't
being encoded/decoded.
* Shared/WebPageCreationParameters.h:
Add canRunBeforeUnloadConfirmPanel.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeUIClient):
Send SetCanRunBeforeUnloadConfirmPanel and SetCanRunModal messages.
(WebKit::WebPageProxy::creationParameters):
Initialize parameters.canRunBeforeUnloadConfirmPanel.
* UIProcess/WebPageProxy.messages.in:
Remove CanRunBeforeUnloadConfirmPanel message.
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::canRunBeforeUnloadConfirmPanel):
* UIProcess/WebUIClient.h:
Make canRunBeforeUnloadConfirmPanel const.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::canRunBeforeUnloadConfirmPanel):
Ask the web page instead of sending a synchronous message.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Initialize m_canRunBeforeUnloadConfirmPanel.
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::canRunBeforeUnloadConfirmPanel):
(WebKit::WebPage::setCanRunBeforeUnloadConfirmPanel):
Add getter and setter for m_canRunBeforeUnloadConfirmPanel.
(WebKit::WebPage::setCanRunModal):
Add setter for m_canRunModal.
* WebProcess/WebPage/WebPage.messages.in:
Add SetCanRunBeforeUnloadConfirmPanel and SetCanRunModal messages.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 3 Mar 2011 19:01:54 +0000 (19:01 +0000)]
2011-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Improve WebCore build time by ~5%
https://bugs.webkit.org/show_bug.cgi?id=55688
Forward declare the CATransform3D and CGAffineTransform structs instead of including
large chunks of QuartzCore and Core Graphics.
On an 8 core Mac Pro, this sped up building WebCore by about 5%.
* platform/graphics/ca/GraphicsLayerCA.cpp:
* platform/graphics/ca/TransformationMatrixCA.cpp:
* platform/graphics/transforms/TransformationMatrix.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
imasaki@chromium.org [Thu, 3 Mar 2011 18:57:46 +0000 (18:57 +0000)]
2011-03-03 Kenji Imasaki <imasaki@chromium.org>
Reviewed by Mihai Parparita.
[Chromium] Snow Leopard rebaseline of media/video-layer-crash
http://code.google.com/p/chromium/issues/detail?id=60744
* platform/chromium-mac-leopard/media/video-layer-crash-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-layer-crash-expected.checksum.
* platform/chromium-mac-leopard/media/video-layer-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-layer-crash-expected.png.
* platform/chromium-mac/media/video-layer-crash-expected.checksum:
* platform/chromium-mac/media/video-layer-crash-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 3 Mar 2011 18:48:48 +0000 (18:48 +0000)]
2011-03-03 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Adjusted call to a method renamed in r80102.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._startEditing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 18:39:26 +0000 (18:39 +0000)]
2011-03-03 Victoria Kirst <vrk@google.com>
Reviewed by Eric Carlson.
Enable media tests in chromium-gpu/test_expectations
https://bugs.webkit.org/show_bug.cgi?id=53608
Suppressing the test failures until baselines are added.
* platform/chromium/test_expectations.txt:
2011-03-03 Victoria Kirst <vrk@google.com>
Reviewed by Eric Carlson.
Enable media tests in chromium-gpu/test_expectations
https://bugs.webkit.org/show_bug.cgi?id=53608
Add media folder to the list of GPU test paths.
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Thu, 3 Mar 2011 18:37:52 +0000 (18:37 +0000)]
Attempt to fix the Windows build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
imasaki@chromium.org [Thu, 3 Mar 2011 18:36:32 +0000 (18:36 +0000)]
2011-03-03 Kenji Imasaki <imasaki@chromium.org>
Reviewed by Tony Gentilcore.
[Chromium] Revert the change in http/tests/media/video-referer.html
in rev80227
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Thu, 3 Mar 2011 18:28:29 +0000 (18:28 +0000)]
Use APIEntryShim instead of JSLock in SerializedScriptValue.
Source/JavaScriptCore: Make APIShims usable from WebCore.
Reviewed by Oliver Hunt.
* ForwardingHeaders/JavaScriptCore/APIShims.h: Added.
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
* JavaScriptCore.xcodeproj/project.pbxproj:
Source/WebCore: Use APIEntryShim instead of JSLock in SerializedScriptValue to allow it to be used
by contexts not created by WebCore.
https://webkit.org/b/55642
Reviewed by Oliver Hunt.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create): Use APIEntryShim instead of JSLock.
(WebCore::SerializedScriptValue::deserialize): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 18:19:42 +0000 (18:19 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium Snow Leopard rebaseline.
Rebaseline tables/mozilla/marvin/ tests for Snow Leopard. The current
expectations were just checksums, I also added their corresponding PNGs.
We can't use the mac/ baselines since we scale the raptor image
differently (most likely due to CG i386 vs. x86_64 differences, see
bug 52335).
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 3 Mar 2011 18:10:37 +0000 (18:10 +0000)]
Reviewed by Darin Adler.
WebCore should check for "Upgrade" and "Connection" header fields in WebSockets handshake
https://bugs.webkit.org/show_bug.cgi?id=55498
<rdar://problem/
8752706>
Tests: http/tests/websocket/tests/handshake-fail-by-no-connection-header.html
http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html
* websockets/WebSocketHandshake.h: Removed unused and meaningless setters for response
header fields. Removed separate member variables for those, as they were duplicating data
available in response, and there is no reason to squeeze microsecods here.
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::reset): There are no longer member variables for header field
values to reset here.
(WebCore::WebSocketHandshake::readServerHandshake): Removed a call for processHeaders().
(WebCore::WebSocketHandshake::serverWebSocketOrigin): Changed to get the value from response.
(WebCore::WebSocketHandshake::serverWebSocketLocation): Ditto.
(WebCore::WebSocketHandshake::serverWebSocketProtocol): Ditto.
(WebCore::WebSocketHandshake::serverSetCookie): Ditto.
(WebCore::WebSocketHandshake::serverSetCookie2): Ditto.
(WebCore::WebSocketHandshake::serverUpgrade): Added.
(WebCore::WebSocketHandshake::serverConnection): Added.
(WebCore::WebSocketHandshake::checkResponseHeaders): Added checks for Upgrade and Connection
header field presence and values.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 17:48:43 +0000 (17:48 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium Snow Leopard rebaseline.
Rebaseline remaining editing/ tests for Snow Leopard. The current
expectations were just checksums, I also added their corresponding PNGs.
We can't use the mac/ baselines since we render selections differently.
* platform/chromium-mac-leopard/editing/selection/
4402375-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/
4402375-expected.checksum.
* platform/chromium-mac-leopard/editing/selection/
4402375-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/image-before-linebreak-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/image-before-linebreak-expected.checksum.
* platform/chromium-mac-leopard/editing/selection/image-before-linebreak-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/replaced-boundaries-1-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.checksum.
* platform/chromium-mac-leopard/editing/selection/replaced-boundaries-1-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/replaced-boundaries-2-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.checksum.
* platform/chromium-mac-leopard/editing/selection/replaced-boundaries-2-expected.png: Added.
* platform/chromium-mac/editing/selection/
4402375-expected.checksum:
* platform/chromium-mac/editing/selection/
4402375-expected.png: Added.
* platform/chromium-mac/editing/selection/image-before-linebreak-expected.checksum:
* platform/chromium-mac/editing/selection/image-before-linebreak-expected.png: Added.
* platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.checksum:
* platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.png: Added.
* platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.checksum:
* platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
helder@sencha.com [Thu, 3 Mar 2011 17:43:37 +0000 (17:43 +0000)]
[Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
https://bugs.webkit.org/show_bug.cgi?id=55651
Reviewed by Andreas Kling.
When relying on ContextShadow and using a gradient stroke for a path,
the alpha of the shadow is incorrect.
Source/WebCore:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::strokePath):
LayoutTests:
* platform/qt/Skipped: Remove test from skipped list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 3 Mar 2011 17:36:04 +0000 (17:36 +0000)]
Work around a bug in KURL's parsing of Windows-style absolute file: URLs
Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
incorrect parsing of absolute Windows-style file: URLs
Reviewed by Tim Hatcher.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
<http://webkit.org/b/55683>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 3 Mar 2011 17:34:47 +0000 (17:34 +0000)]
2011-03-03 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Run kill-old-processes on the chromium-win bot too
https://bugs.webkit.org/show_bug.cgi?id=55630
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 3 Mar 2011 17:18:51 +0000 (17:18 +0000)]
2011-03-03 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing test on GTK. See bug 55682.
* platform/gtk/Skipped: Skip fast/images/support-broken-image-delegate.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 3 Mar 2011 17:03:31 +0000 (17:03 +0000)]
2011-03-03 Martin Robinson <mrobinson@igalia.com>
XHTMLMP build broken after r78342
https://bugs.webkit.org/show_bug.cgi?id=55286
Fix XHTMLMP build now that the DocumentWriter is a member of DocumentLoader
instead of FrameLoader.
No new tests. This is a build fix.
* dom/Document.cpp:
(WebCore::Document::isXHTMLMPDocument):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 3 Mar 2011 16:59:11 +0000 (16:59 +0000)]
2011-03-03 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip svg test failing on 32-bits Release, likely due
to a rounding error, see bug 39022.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc