WebKit-https.git
11 years agoReviewed by Eric Seidel.
kevino@webkit.org [Wed, 25 May 2011 17:10:03 +0000 (17:10 +0000)]
Reviewed by Eric Seidel.

Add JS_EXPORT_PRIVATE macro for exported methods in bytecompiler headers.

https://bugs.webkit.org/show_bug.cgi?id=27551

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 25 May 2011 17:06:32 +0000 (17:06 +0000)]
2011-05-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Add IntPoint versions of IntRect::move and IntPoint::move
        https://bugs.webkit.org/show_bug.cgi?id=61390

        Adding move methods to IntRect and IntPoint that take an IntPoint
        that's acting as an offset. Since we also apply negative offsets,
        also adding a single parameter operator- for IntPoint.

        No new tests since this is refactoring.

        * page/FrameView.cpp:
        (WebCore::FrameView::invalidateScrollbarRect):
        (WebCore::FrameView::convertFromRenderer):
        (WebCore::FrameView::convertToRenderer):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::wheelEvent):
        * platform/ScrollView.h:
        (WebCore::ScrollView::convertChildToSelf):
        (WebCore::ScrollView::convertSelfToChild):
        * platform/ScrollbarThemeComposite.cpp:
        (WebCore::ScrollbarThemeComposite::invalidatePart):
        * platform/graphics/IntPoint.h:
        (WebCore::IntPoint::move):
        (WebCore::operator-):
        * platform/graphics/IntRect.h:
        (WebCore::IntRect::move):
        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::requestedRegionOfInputImageData):
        * platform/graphics/gpu/Texture.cpp:
        (WebCore::Texture::updateSubRect):
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::paint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::logicalRectToPhysicalRect):
        (WebCore::RenderBlock::selectionGaps):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::offsetFromContainer):
        (WebCore::RenderBox::computeRectForRepaint):
        (WebCore::RenderBox::localCaretRect):
        * rendering/RenderDetailsMarker.cpp:
        (WebCore::RenderDetailsMarker::paint):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
        * rendering/RenderInputSpeech.cpp:
        (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::paintScrollbar):
        (WebCore::RenderLayerBacking::paintContents):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::paintScrollbar):
        (WebCore::RenderLayerCompositor::paintContents):
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::positionListMarker):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::computeRectForRepaint):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::repaintViewRectangle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 25 May 2011 17:04:47 +0000 (17:04 +0000)]
2011-05-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch addFocusRingRects to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=60783

        Switching addFocusRingRects to use an IntPoint representing the offset being
        applied instead of a pair of ints.

        No new tests as this is only refactoring.

        * platform/graphics/FloatSize.h:
        (WebCore::flooredIntPoint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addFocusRingRects):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::addFocusRingRects):
        * rendering/RenderBox.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::addFocusRingRects):
        * rendering/RenderInline.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::addFocusRingRects):
        * rendering/RenderListBox.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintFocusRing):
        (WebCore::RenderObject::absoluteFocusRingQuads):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::addFocusRingRects):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::addFocusRingRects):
        * rendering/RenderTextControl.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::addFocusRingRects):
        * rendering/RenderTextControlSingleLine.h:
        * rendering/svg/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::addFocusRingRects):
        * rendering/svg/RenderSVGContainer.h:
        * rendering/svg/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::addFocusRingRects):
        * rendering/svg/RenderSVGImage.h:
        * rendering/svg/RenderSVGPath.cpp:
        (WebCore::RenderSVGPath::addFocusRingRects):
        * rendering/svg/RenderSVGPath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 25 May 2011 16:50:53 +0000 (16:50 +0000)]
2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87229.
        http://trac.webkit.org/changeset/87229
        https://bugs.webkit.org/show_bug.cgi?id=61445

        Lots of tests crashing in
        CFNetwork!URLResponse::createFilenameFromResponseHeaders on
        Windows XP (Requested by aroben on #webkit).

        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::suggestedFilename):
        (WebCore::ResourceResponseBase::setSuggestedFilename):
        (WebCore::ResourceResponseBase::httpStatusText):
        (WebCore::ResourceResponseBase::setHTTPStatusText):
        (WebCore::ResourceResponseBase::httpHeaderField):
        (WebCore::ResourceResponseBase::setHTTPHeaderField):
        (WebCore::ResourceResponseBase::httpHeaderFields):
        (WebCore::ResourceResponseBase::isAttachment):
        (WebCore::ResourceResponseBase::setLastModifiedDate):
        (WebCore::ResourceResponseBase::lastModifiedDate):
        (WebCore::ResourceResponseBase::wasCached):
        (WebCore::ResourceResponseBase::connectionReused):
        (WebCore::ResourceResponseBase::setConnectionReused):
        (WebCore::ResourceResponseBase::connectionID):
        (WebCore::ResourceResponseBase::setConnectionID):
        (WebCore::ResourceResponseBase::resourceLoadTiming):
        (WebCore::ResourceResponseBase::setResourceLoadTiming):
        (WebCore::ResourceResponseBase::resourceLoadInfo):
        (WebCore::ResourceResponseBase::setResourceLoadInfo):
        * platform/network/ResourceResponseBase.h:
        * platform/network/cf/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        * platform/network/cf/ResourceResponseCFNet.cpp:
        (WebCore::ResourceResponse::platformLazyInit):
        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::platformLazyInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Leon Scroggins <scroggo@google.com>
commit-queue@webkit.org [Wed, 25 May 2011 16:48:03 +0000 (16:48 +0000)]
2011-05-25  Leon Scroggins  <scroggo@google.com>

        Reviewed by Steve Block.

        Update chromium expectations for more canvas fixes.
        https://bugs.webkit.org/show_bug.cgi?id=61433

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoIdentify, rather than skip, builds where run-webkit-tests exited early due to too...
aroben@apple.com [Wed, 25 May 2011 16:38:29 +0000 (16:38 +0000)]
Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures

Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
started exiting early due to too many crashes, timeouts, or failures

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
run-webkit-tests exits early due to too many failures, pass that information in another
argument to the callback.
(Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
the new structure of the object passed to the callback.
(Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
getNumberOfFailingTests and to pass that along to our own callbacks.
(Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
from _getFailingTests and to store that value in the history object.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(.info): Added.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder): Updated for change in structure to the history
object and to add a note when run-webkit-tests exited early due to too many failures.
(ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
latestBuildInfos since each entry now contains more than just the tester and failure count.
Now displays a message for testers where the latest build exited early due to too many
failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
store that value in latestBuildInfos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Wed, 25 May 2011 16:33:57 +0000 (16:33 +0000)]
2011-05-25  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Antonio Gomes.

        [Qt] QtWebKit crashes when dragging not loaded images
        https://bugs.webkit.org/show_bug.cgi?id=61314

        Checks if WebKit crashes when dragging an image not yet loaded.

        * http/tests/misc/drag-not-loaded-image-expected.txt: Added.
        * http/tests/misc/drag-not-loaded-image.html: Added.
2011-05-25  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Antonio Gomes.

        [Qt] QtWebKit crashes when dragging not loaded images
        https://bugs.webkit.org/show_bug.cgi?id=61314

        Checks if nativeImageForCurrentFrame is a valid pointer.

        Test: http/tests/misc/drag-not-loaded-image.html

        * platform/qt/DragImageQt.cpp:
        (WebCore::createDragImageFromImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Wed, 25 May 2011 16:27:30 +0000 (16:27 +0000)]
2011-05-25  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Xan Lopez.

        [GTK] combobox and scrollbar are rendered small size at gtk+2.22.0
        https://bugs.webkit.org/show_bug.cgi?id=61436

        Fix arguments of gdk_drawable_get_size.

        No new tests, no behavior change.

        * platform/gtk/GtkVersioning.c:
        (getGdkDrawableSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 25 May 2011 14:58:32 +0000 (14:58 +0000)]
2011-05-25  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Skipped 3 new inspector tests that time out on gtk.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Gabor Loki <loki@webkit.org>
loki@webkit.org [Wed, 25 May 2011 14:20:23 +0000 (14:20 +0000)]
2011-05-25  Gabor Loki  <loki@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt] Skip failed tests after r87290 and r87292 on ARM

        * platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-23 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 25 May 2011 14:02:10 +0000 (14:02 +0000)]
2011-05-23  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extreme lagging when searching for "img[src*="
        https://bugs.webkit.org/show_bug.cgi?id=61282

        No new tests, as this is a refactoring: ElementsTreeElement DOM is manipulated directly
        when built and search-highlighted, rather than through innerHTML.

        * inspector/front-end/DOMSyntaxHighlighter.js:
        (WebInspector.DOMSyntaxHighlighter):
        (WebInspector.DOMSyntaxHighlighter.prototype.createSpan):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
        (WebInspector.ElementsTreeElement.prototype.hideSearchHighlights):
        (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryShow):
        (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryHide):
        (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight):
        (WebInspector.ElementsTreeElement.prototype._addNewAttribute):
        (WebInspector.ElementsTreeElement.prototype.updateTitle):
        (WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
        ():
        * inspector/front-end/utilities.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Leandro Gracia Gil <leandrogracia@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 12:34:04 +0000 (12:34 +0000)]
2011-05-25  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Tony Gentilcore.

        Introduce HTML5 track list objects.
        https://bugs.webkit.org/show_bug.cgi?id=60184

        Introduce the TrackList, MultipleTrackList and ExclusiveTrackList objects
        for their use in the MediaStream API and the HTML Media Element.
        Current spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#tracklist

        The Media Stream API will test this feature in the bug 56587.
        More tests related to the HTML Media Element may be added later.

        * CMakeLists.txt:
        * CodeGenerators.pri:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventTarget.cpp:
        (WebCore::toJS):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
        * dom/DOMAllInOne.cpp:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toTrackList):
        (WebCore::EventTarget::toMultipleTrackList):
        (WebCore::EventTarget::toExclusiveTrackList):
        * dom/EventTarget.h:
        * dom/ExclusiveTrackList.cpp: Added.
        (WebCore::ExclusiveTrackList::create):
        (WebCore::ExclusiveTrackList::ExclusiveTrackList):
        (WebCore::ExclusiveTrackList::~ExclusiveTrackList):
        (WebCore::ExclusiveTrackList::clear):
        (WebCore::ExclusiveTrackList::select):
        (WebCore::ExclusiveTrackList::toExclusiveTrackList):
        * dom/ExclusiveTrackList.h: Added.
        (WebCore::ExclusiveTrackList::selectedIndex):
        * dom/ExclusiveTrackList.idl: Added.
        * dom/MultipleTrackList.cpp: Added.
        (WebCore::MultipleTrackList::create):
        (WebCore::MultipleTrackList::MultipleTrackList):
        (WebCore::MultipleTrackList::~MultipleTrackList):
        (WebCore::MultipleTrackList::clear):
        (WebCore::MultipleTrackList::isEnabled):
        (WebCore::MultipleTrackList::enable):
        (WebCore::MultipleTrackList::disable):
        (WebCore::MultipleTrackList::toMultipleTrackList):
        * dom/MultipleTrackList.h: Added.
        * dom/MultipleTrackList.idl: Added.
        * dom/TrackList.cpp: Added.
        (WebCore::Track::create):
        (WebCore::Track::Track):
        (WebCore::TrackList::create):
        (WebCore::TrackList::TrackList):
        (WebCore::TrackList::~TrackList):
        (WebCore::TrackList::length):
        (WebCore::TrackList::checkIndex):
        (WebCore::TrackList::getID):
        (WebCore::TrackList::getKind):
        (WebCore::TrackList::getLabel):
        (WebCore::TrackList::getLanguage):
        (WebCore::TrackList::clear):
        (WebCore::TrackList::postChangeEvent):
        (WebCore::TrackList::dispatchChangeEvent):
        (WebCore::TrackList::toTrackList):
        (WebCore::TrackList::scriptExecutionContext):
        (WebCore::TrackList::eventTargetData):
        (WebCore::TrackList::ensureEventTargetData):
        * dom/TrackList.h: Added.
        (WebCore::Track::id):
        (WebCore::Track::kind):
        (WebCore::Track::label):
        (WebCore::Track::language):
        (WebCore::TrackList::DispatchTask::create):
        (WebCore::TrackList::DispatchTask::performTask):
        (WebCore::TrackList::DispatchTask::DispatchTask):
        (WebCore::TrackList::refEventTarget):
        (WebCore::TrackList::derefEventTarget):
        * dom/TrackList.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Keishi Hattori <keishi@webkit.org>
keishi@webkit.org [Wed, 25 May 2011 11:55:13 +0000 (11:55 +0000)]
2011-05-25  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Move ElementWithPseudoId to separate file
        https://bugs.webkit.org/show_bug.cgi?id=61430

        No new tests because no behavior changes.

        * CMakeLists.txt: Added ElementWithPseudoId.cpp
        * GNUmakefile.list.am: Added ElementWithPseudoId.{h,cpp}
        * WebCore.gypi: Added ElementWithPseudoId.{h,cpp}
        * WebCore.pro: Added ElementWithPseudoId.{h,cpp}
        * WebCore.vcproj/WebCore.vcproj: Added ElementWithPseudoId.{h,cpp}
        * WebCore.xcodeproj/project.pbxproj: Added ElementWithPseudoId.{h,cpp}
        * html/ValidationMessage.cpp: Removed ElementWithPseudoId definition.
        * html/shadow/ElementWithPseudoId.cpp: Added.
        (WebCore::ElementWithPseudoId::shadowPseudoId):
        * html/shadow/ElementWithPseudoId.h: Added.
        (WebCore::ElementWithPseudoId::create):
        (WebCore::ElementWithPseudoId::ElementWithPseudoId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Wed, 25 May 2011 11:43:46 +0000 (11:43 +0000)]
2011-05-25  Anton Muhin  <antonm@chromium.org>

        Unreviewed.

        Update test expectations after 3.3.6.1 v8 roll.

        * platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt:
        * platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt:
        * platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt:
        * platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt:
        * platform/chromium/ietestcenter: Added.
        * platform/chromium/ietestcenter/Javascript: Added.
        * platform/chromium/ietestcenter/Javascript/15.4.4.14-5-28-expected.txt: Added.
        * platform/chromium/ietestcenter/Javascript/15.4.4.15-5-28-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 25 May 2011 11:39:41 +0000 (11:39 +0000)]
2011-05-25  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Antonio Gomes.

        [Qt] When QWebView has a different style set on it then the scrollbars are not rendered correctly
        https://bugs.webkit.org/show_bug.cgi?id=34635

        Make sure the scrollbar is properly rendered on Mac with another style than the Mac style. The code had
        two paths, one for Mac and one for any other styles. The problem is that on Mac you can still run the
        application with -style plastique for example, therefore the code used for other styles should also be
        used whenever the current style is not the Mac style.

        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::ScrollbarThemeQt::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 11:21:29 +0000 (11:21 +0000)]
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt: svn/dynamic-updates failing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Gabor Loki <loki@webkit.org>
loki@webkit.org [Wed, 25 May 2011 11:19:39 +0000 (11:19 +0000)]
2011-05-25  Gabor Loki  <loki@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt] Skip a flakey timed out test on ARM

        * platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 11:08:55 +0000 (11:08 +0000)]
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt: mhtml tests pass

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 11:00:08 +0000 (11:00 +0000)]
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 10:41:39 +0000 (10:41 +0000)]
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu>
commit-queue@webkit.org [Wed, 25 May 2011 10:34:20 +0000 (10:34 +0000)]
2011-05-25  Felician Marton  <marton.felician.zoltan@stud.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added.
        https://bugs.webkit.org/show_bug.cgi?id=59677

        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
        * svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-dx-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-dy-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-rotate-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-x-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-y-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-dx-prop.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-dy-prop.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-x-prop.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html: Added.
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-dx-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-dy-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-rotate-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-x-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-y-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-dx-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-dy-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-x-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-y-prop.js: Added.
        (executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 25 May 2011 10:12:35 +0000 (10:12 +0000)]
2011-05-25  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Clean up WebSocket test expectations
        https://bugs.webkit.org/show_bug.cgi?id=61429

        * platform/chromium/test_expectations.txt:
        Remove two test expectations for tests that are no longer failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 25 May 2011 09:52:36 +0000 (09:52 +0000)]
2011-05-25  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Use fail() when WebSocketChannel has failed
        https://bugs.webkit.org/show_bug.cgi?id=61353

        * http/tests/websocket/tests/frame-length-overflow-expected.txt:
        Added a new console message.
2011-05-25  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Use fail() when WebSocketChannel has failed
        https://bugs.webkit.org/show_bug.cgi?id=61353

        An existing error message has been modified, but it is impossible
        to test this message in LayoutTests because it is only shown when
        memory allocation has failed, which is hard to reproduce reliably.

        One new message has been added. It is covered by an existing test
        http/tests/websocket/tests/frame-length-overflow.html.

        There is no other change in behavior. No new tests are added.

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::fail):
        Do not close if we know the socket stream is already closed. This does not
        change the behavior, because SocketStreamBase does nothing if it is already
        closed.
        (WebCore::WebSocketChannel::didOpen):
        (WebCore::WebSocketChannel::didReceiveData):
        We need to set m_shouldDiscardReceivedData to true before calling fail(),
        so I moved the error message from appendToBuffer() to here.
        The error message was rephrased in order to improve readability.
        (WebCore::WebSocketChannel::appendToBuffer):
        Unnested the code.
        (WebCore::WebSocketChannel::processBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 25 May 2011 09:35:43 +0000 (09:35 +0000)]
2011-05-16  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by David Levin.

        CSSParser: m_implicitShorthand should probably be RAII
        https://bugs.webkit.org/show_bug.cgi?id=51586

        It was impossible to entirely eliminate the m_implicitShorthand manual changes
        due to the parseFill*() method stateful call chains.

        No new tests, as this is a refactoring.

        * css/CSSParser.cpp:
        (ImplicitScope::ImplicitScope):
        (ImplicitScope::~ImplicitScope):
        (WebCore::CSSParser::parseShorthand):
        (WebCore::CSSParser::parse4Values):
        (WebCore::CSSParser::parseBorderRadius):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 25 May 2011 09:03:11 +0000 (09:03 +0000)]
2011-05-24  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: inspected page crashes when call stack is empty after live edit.
        https://bugs.webkit.org/show_bug.cgi?id=61364

        * inspector/debugger/live-edit-expected.txt:
        * inspector/debugger/live-edit.html:
        * platform/chromium/test_expectations.txt:
2011-05-24  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: inspected page crashes when call stack is empty after live edit.
        https://bugs.webkit.org/show_bug.cgi?id=61364

        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::currentCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Mads Ager <ager@chromium.org>
ager@chromium.org [Wed, 25 May 2011 07:48:53 +0000 (07:48 +0000)]
2011-05-25  Mads Ager  <ager@chromium.org>

        Reviewed by Adam Barth.

        Update chromium expectations after removal of execScript from V8
        https://bugs.webkit.org/show_bug.cgi?id=61267

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-23 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 25 May 2011 07:45:33 +0000 (07:45 +0000)]
2011-05-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
        https://bugs.webkit.org/show_bug.cgi?id=61194

        Test: inspector/console/console-eval-syntax-error.html

        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error

2011-05-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
        https://bugs.webkit.org/show_bug.cgi?id=61194

        * inspector/console/console-eval-syntax-error-expected.txt: Added.
        * inspector/console/console-eval-syntax-error.html: Added.
        * platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-25 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 25 May 2011 07:17:21 +0000 (07:17 +0000)]
2011-05-25  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Kent Tamura.

        Fix for Bug 61352 - Refactor RenderView::{enable,disable}LayoutState call sites to use RIIA
        https://bugs.webkit.org/show_bug.cgi?id=61352

        No new tests because no behavior changes.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::RenderMediaVolumeSliderContainer::layout):
        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::repaintOverhangingFloats):
        (WebCore::RenderBlock::updateFirstLetter):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::layout):
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::updateMarkerLocation):
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::layout):
        * rendering/RenderView.h:
        (WebCore::RenderView::disableLayoutState):
        (WebCore::RenderView::enableLayoutState):
        (WebCore::LayoutStateDisabler::LayoutStateDisabler):
        (WebCore::LayoutStateDisabler::~LayoutStateDisabler):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Unreviewed typo fix after r87228.
ossy@webkit.org [Wed, 25 May 2011 06:42:11 +0000 (06:42 +0000)]
[Qt] Unreviewed typo fix after r87228.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake the Web Inspector bring the right window to the front when docked.
timothy@apple.com [Wed, 25 May 2011 06:37:42 +0000 (06:37 +0000)]
Make the Web Inspector bring the right window to the front when docked.

rdar://problem/9464685
https://webkit.org/b/61420

Reviewed by Brian Weinstein.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformBringToFront): Order front the parent window of the Inspector's WKView.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformBringToFront): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Keishi Hattori <keishi@webkit.org>
tkent@chromium.org [Wed, 25 May 2011 06:03:09 +0000 (06:03 +0000)]
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * configure.ac: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * fast/forms/ValidityState-typeMismatch-color-expected.txt: Removed.
        * fast/forms/ValidityState-typeMismatch-color.html: Removed.
        * fast/forms/color/input-value-sanitization-color-expected.txt: Added.
        * fast/forms/color/input-value-sanitization-color.html: Added. Tests
        sanitization algorithm for input type=color.
        * fast/forms/input-type-change3-expected.txt:
        * fast/forms/input-widths-expected.txt:
        * fast/forms/input-widths.html: Removed type=color because it
        is no loger a text input type.
        * fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Changed to range input type.
        * fast/forms/script-tests/ValidityState-typeMismatch-color.js: Removed.
        * fast/forms/script-tests/input-type-change3.js:
        * platform/gtk/Skipped: Skip fast/forms/color.
        * platform/mac/Skipped: Skip fast/forms/color.
        * platform/qt/Skipped: Skip fast/forms/color.
        * platform/win/Skipped: Skip fast/forms/color.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        Test: fast/forms/color/input-value-sanitization-color.html

        * Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.
        * GNUmakefile.am: Added COLOR_INPUT feature flag.
        * features.pri: Added COLOR_INPUT feature flag.
        * html/ColorInputType.cpp: Wrapped with COLOR_INPUT feature flag.
        (WebCore::ColorInputType::isColorControl): Added.
        (WebCore::ColorInputType::fallbackValue): Added. Fallback value defined in spec.
        (WebCore::ColorInputType::sanitizeValue): Added. Sanitize value string as defined in spec.
        * html/ColorInputType.h: Wrapped with COLOR_INPUT feature flag.
        (WebCore::ColorInputType::ColorInputType): Changed to inherit BaseButtonInputType.
        * html/InputType.cpp:
        (WebCore::InputType::isColorControl): Added.
        * html/InputType.h:
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * features.gypi: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * Scripts/build-webkit: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * win/tools/vsprops/FeatureDefines.vsprops: Added INPUT_COLOR feature flag.
        * win/tools/vsprops/FeatureDefinesCairo.vsprops: Added INPUT_COLOR feature flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt][WK2] Skip new failing test.
ossy@webkit.org [Wed, 25 May 2011 05:56:58 +0000 (05:56 +0000)]
[Qt][WK2] Skip new failing test.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 25 May 2011 04:54:46 +0000 (04:54 +0000)]
2011-05-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Update the WebProcess sandbox exceptions to silence warnings for a file that is accessed uselessly
        https://bugs.webkit.org/show_bug.cgi?id=61349
        <rdar://problem/9476255>

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:38:26 +0000 (04:38 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/editing/selection/4895428-1 and -4 to dump-as-markup
        https://bugs.webkit.org/show_bug.cgi?id=61402

        Converts the two html files to dump-as-markup and adds doctype, html, and body tags.

        * editing/selection/4895428-1-expected.txt: Added.
        * editing/selection/4895428-1.html: Converted to dump-as-markup
        * editing/selection/4895428-4-expected.txt: Added.
        * editing/selection/4895428-4.html: Converted to dump-as-markup
        * platform/chromium-linux/editing/selection/4895428-1-expected.png: Removed.
        * platform/chromium-linux/editing/selection/4895428-4-expected.png: Removed.
        * platform/chromium-win/editing/selection/4895428-1-expected.png: Removed.
        * platform/chromium-win/editing/selection/4895428-1-expected.txt: Removed.
        * platform/chromium-win/editing/selection/4895428-4-expected.png: Removed.
        * platform/chromium-win/editing/selection/4895428-4-expected.txt: Removed.
        * platform/gtk/editing/selection/4895428-1-expected.png: Removed.
        * platform/gtk/editing/selection/4895428-1-expected.txt: Removed.
        * platform/gtk/editing/selection/4895428-4-expected.png: Removed.
        * platform/gtk/editing/selection/4895428-4-expected.txt: Removed.
        * platform/mac-leopard/editing/selection/4895428-1-expected.png: Removed.
        * platform/mac-leopard/editing/selection/4895428-4-expected.png: Removed.
        * platform/mac/editing/selection/4895428-1-expected.png: Removed.
        * platform/mac/editing/selection/4895428-1-expected.txt: Removed.
        * platform/mac/editing/selection/4895428-4-expected.png: Removed.
        * platform/mac/editing/selection/4895428-4-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Eric Seidel.
kevino@webkit.org [Wed, 25 May 2011 04:38:26 +0000 (04:38 +0000)]
Reviewed by Eric Seidel.

Add export macros to WTFString.h.

https://bugs.webkit.org/show_bug.cgi?id=27551

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:35:37 +0000 (04:35 +0000)]
2011-05-24  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Move chromium media controls timeline back to flexible rather than absolute
        layout.

        https://bugs.webkit.org/show_bug.cgi?id=61379

        * platform/chromium/test_expectations.txt: Added expected failures from this change.
2011-05-24  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Move chromium media controls timeline back to flexible rather than absolute
        layout.

        https://bugs.webkit.org/show_bug.cgi?id=61379

        * css/mediaControlsChromium.css:
        (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
        (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 25 May 2011 04:26:04 +0000 (04:26 +0000)]
2011-05-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        Convert fast/forms/input-type-change.html to a dumpAsText() test
        https://bugs.webkit.org/show_bug.cgi?id=61029

        Merge input-type-change2 to input-type-change.html, and convert it to
        a dumpAsText() test.

        * fast/forms/input-type-change-expected.txt:
        * fast/forms/input-type-change.html:
        * fast/forms/input-type-change2.html: Removed.
        * platform/chromium-linux/fast/forms/input-type-change-expected.png: Removed.
        * platform/chromium-linux/fast/forms/input-type-change2-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/forms/input-type-change-expected.png: Removed.
        * platform/chromium-mac/fast/forms/input-type-change-expected.png: Removed.
        * platform/chromium-win/fast/forms/input-type-change-expected.png: Removed.
        * platform/chromium-win/fast/forms/input-type-change-expected.txt: Removed.
        * platform/chromium-win/fast/forms/input-type-change2-expected.png: Removed.
        * platform/chromium-win/fast/forms/input-type-change2-expected.txt: Removed.
        * platform/gtk/fast/forms/input-type-change-expected.png: Removed.
        * platform/gtk/fast/forms/input-type-change-expected.txt: Removed.
        * platform/gtk/fast/forms/input-type-change2-expected.png: Removed.
        * platform/gtk/fast/forms/input-type-change2-expected.txt: Removed.
        * platform/mac-leopard/fast/forms/input-type-change-expected.png: Removed.
        * platform/mac-leopard/fast/forms/input-type-change2-expected.png: Removed.
        * platform/mac/fast/forms/input-type-change-expected.png: Removed.
        * platform/mac/fast/forms/input-type-change-expected.txt:
        * platform/mac/fast/forms/input-type-change-expected.txt: Removed.
        * platform/mac/fast/forms/input-type-change2-expected.png: Removed.
        * platform/mac/fast/forms/input-type-change2-expected.txt: Removed.
        * platform/qt-arm/Skipped: Remove input-type-change2.html.
        * platform/qt-mac/Skipped: ditto.
        * platform/qt/fast/forms/input-type-change-expected.txt: Removed.
        * platform/qt/fast/forms/input-type-change2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed. Fix clang error.
ukai@chromium.org [Wed, 25 May 2011 04:20:02 +0000 (04:20 +0000)]
Unreviewed. Fix clang error.

error: initialization of pointer of type 'WebCore::MHTMLArchive *' to
NULL from a constant boolean expression [-Werror,-Wbool-conversio

* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:17:03 +0000 (04:17 +0000)]
2011-05-24  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Hajime Morita.

        <legend> element is dropped on the floor
        https://bugs.webkit.org/show_bug.cgi?id=18691

        * html5lib/resources/webkit02.dat: Added a passing
        test for <legend> parsing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:14:51 +0000 (04:14 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Tony Chang.

        editing/deleting/5032066 should be a dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=61327

        Converts 5032066 to dump-as-markup and adds doctype, html, and body tags.

        * editing/deleting/5032066-expected.txt: Added.
        * editing/deleting/5032066.html:
        * platform/chromium-linux/editing/deleting/5032066-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5032066-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5032066-expected.txt: Removed.
        * platform/gtk/editing/deleting/5032066-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/5032066-expected.png: Removed.
        * platform/mac/editing/deleting/5032066-expected.png: Removed.
        * platform/mac/editing/deleting/5032066-expected.txt: Removed.
        * platform/qt/editing/deleting/5032066-expected.png: Removed.
        * platform/qt/editing/deleting/5032066-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:04:03 +0000 (04:04 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/editing/deleting/5115601.html to dump-as-markup.
        https://bugs.webkit.org/show_bug.cgi?id=61330

        Converted to dump-as-markup and added a little html cleanup.

        * editing/deleting/5115601-expected.txt: Added.
        * editing/deleting/5115601.html: Convert to dump-as-markup.
        * platform/chromium-linux/editing/deleting/5115601-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5115601-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5115601-expected.txt: Removed.
        * platform/gtk/editing/deleting/5115601-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/5115601-expected.png: Removed.
        * platform/mac/editing/deleting/5115601-expected.png: Removed.
        * platform/mac/editing/deleting/5115601-expected.txt: Removed.
        * platform/qt/editing/deleting/5115601-expected.png: Removed.
        * platform/qt/editing/deleting/5115601-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 03:50:54 +0000 (03:50 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/editing/deleting/5206311-2.html to dump-as-markup
        https://bugs.webkit.org/show_bug.cgi?id=61332

        Used dump-as-markup to improve readability of results.
        Also improved HTML and cleaned up descriptions.

        * editing/deleting/5206311-2-expected.txt: Added.
        * editing/deleting/5206311-2.html: Convert to dump-as-markup.
        * platform/chromium-linux/editing/deleting/5206311-2-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5206311-2-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5206311-2-expected.txt: Removed.
        * platform/gtk/editing/deleting/5206311-2-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/5206311-2-expected.png: Removed.
        * platform/mac/editing/deleting/5206311-2-expected.png: Removed.
        * platform/mac/editing/deleting/5206311-2-expected.txt: Removed.
        * platform/qt/editing/deleting/5206311-2-expected.png: Removed.
        * platform/qt/editing/deleting/5206311-2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 03:39:22 +0000 (03:39 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/editing/deleting/delete-block-table.html to dumpAsText test.
        https://bugs.webkit.org/show_bug.cgi?id=61333

        Converts delete-block-table.html to dumpAsText test by changing to use runDumpAsTextEditingTest.

        * editing/deleting/delete-block-table-expected.txt: Added.
        * editing/deleting/delete-block-table.html: Converted to dump-as-markup.
        * platform/chromium-linux/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/chromium-win/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/chromium-win/editing/deleting/delete-block-table-expected.txt: Removed.
        * platform/gtk/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/gtk/editing/deleting/delete-block-table-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/mac/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/mac/editing/deleting/delete-block-table-expected.txt: Removed.
        * platform/qt/editing/deleting/delete-block-table-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 May 2011 03:39:21 +0000 (03:39 +0000)]
2011-05-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add FIXME comments about removing FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=61395

        All the callers of the API are wrong.  They should call the more modern
        static member function of ScriptController instead.  I'll remove the
        FrameLoader function in a future patch.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::processingUserGesture):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::click):
2011-05-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add FIXME comments about removing FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=61395

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::isProcessingUserGesture):
2011-05-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add FIXME comments about removing FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=61395

        * WebView/WebView.mm:
        (-[WebView _isProcessingUserGesture]):
2011-05-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add FIXME comments about removing FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=61395

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (drtPrintFrameUserGestureStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Justin Novosad <junov@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 03:28:18 +0000 (03:28 +0000)]
2011-05-24  Justin Novosad  <junov@chromium.org>

        Reviewed by Stephen White.

        [Chromium] cleanup test expectations for drawImage that are no longer
        flaky
        https://bugs.webkit.org/show_bug.cgi?id=61389

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Wed, 25 May 2011 03:03:46 +0000 (03:03 +0000)]
2011-05-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed. Fix style error.

        * platform/efl/WidgetEfl.cpp:
        (WebCore::WidgetPrivate::WidgetPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Greg Simon <gregsimon@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 03:00:58 +0000 (03:00 +0000)]
2011-05-24  Greg Simon  <gregsimon@chromium.org>

        Reviewed by Dimitri Glazkov.

        Control Indexeddb backends from LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=61000

        LayoutTest for migration between SQLite and LevelDB
        in IndxededDB.

        * storage/indexeddb/migrate-basics-expected.txt: Added.
        * storage/indexeddb/migrate-basics.html: Added.
2011-05-24  Greg Simon  <gregsimon@chromium.org>

        Reviewed by Dimitri Glazkov.

        Control Indexeddb backends from LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=61000

        Test: storage/indexeddb/migrate-basics.html

        * storage/IDBBackingStore.h:
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
        (WebCore::IDBFactoryBackendImpl::open):
        (WebCore::IDBFactoryBackendImpl::setEnableMigration):
        (WebCore::IDBFactoryBackendImpl::migrate):
        * storage/IDBFactoryBackendImpl.h:
        * storage/IDBFactoryBackendInterface.h:
        * storage/IDBLevelDBBackingStore.cpp:
        (WebCore::IDBLevelDBBackingStore::backingStoreExists):
        * storage/IDBLevelDBBackingStore.h:
        (WebCore::IDBLevelDBBackingStore::backingStoreType):
        * storage/IDBSQLiteBackingStore.cpp:
        (WebCore::IDBSQLiteBackingStore::backingStoreExists):
        * storage/IDBSQLiteBackingStore.h:
        (WebCore::IDBSQLiteBackingStore::backingStoreType):
2011-05-24  Greg Simon  <gregsimon@chromium.org>

        Reviewed by Dimitri Glazkov.

        Control Indexeddb backends from LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=61000

        * public/WebIDBFactory.h:
        (WebKit::WebIDBFactory::setEnableMigration):
        * src/AssertMatchingEnums.cpp:
        * src/IDBFactoryBackendProxy.cpp:
        (WebKit::IDBFactoryBackendProxy::setEnableMigration):
        * src/IDBFactoryBackendProxy.h:
        * src/WebIDBFactoryImpl.cpp:
        (WebKit::WebIDBFactory::setOverrideBackingStoreType):
        (WebKit::WebIDBFactory::setTemporaryDatabaseFolder):
        (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
        (WebKit::WebIDBFactoryImpl::open):
        (WebKit::WebIDBFactoryImpl::setEnableMigration):
        * src/WebIDBFactoryImpl.h:
2011-05-24  Greg Simon  <gregsimon@chromium.org>

        Reviewed by Dimitri Glazkov.

        Control Indexeddb backends from LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=61000

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::setOverrideIndexedDBBackingStore):
        (LayoutTestController::clearAllDatabases):
        * DumpRenderTree/chromium/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 02:54:29 +0000 (02:54 +0000)]
Unreviewed.

Chromium expectations update. (mhtml)

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the 32-bit build.
mrowe@apple.com [Wed, 25 May 2011 02:52:31 +0000 (02:52 +0000)]
Fix the 32-bit build.

Explicitly use uint32_t when encoding / decoding a type that is a typedef of OSType,
as this is declared as different underlying types in 32- and 64-bit (unsigned long
vs unsigned int).

* Shared/mac/KeychainAttribute.cpp:
(CoreIPC::encode):
(CoreIPC::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Leon Scroggins <scroggo@google.com>
commit-queue@webkit.org [Wed, 25 May 2011 02:35:35 +0000 (02:35 +0000)]
2011-05-24  Leon Scroggins  <scroggo@google.com>

        Reviewed by Kenneth Russell.

        Update expectations for tests drawing a canvas into another canvas (or itself), which have been fixed in gpu.
        https://bugs.webkit.org/show_bug.cgi?id=61362

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoEnable coalesced wheel events
weinig@apple.com [Wed, 25 May 2011 02:22:23 +0000 (02:22 +0000)]
Enable coalesced wheel events
<rdar://problem/9444786>

Reviewed by Maciej Stachowiak.

* UIProcess/WebPageProxy.cpp:
Flip the switch for coalescing wheel events rather than dropping them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 25 May 2011 02:07:48 +0000 (02:07 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Final attempt to fix a test; if this fails, I'm just going to skip it.

        * fast/events/selectstart-by-double-triple-clicks.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Leo Yang <leo.yang@torchmobile.com.cn>
leo.yang@torchmobile.com.cn [Wed, 25 May 2011 01:26:53 +0000 (01:26 +0000)]
2011-05-24  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Ryosuke Niwa.

        [SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
        https://bugs.webkit.org/show_bug.cgi?id=60692

        Add NULL check of 'holder' in WebCore::ReplacementFragment::ReplacementFragment()
        before call VisibleSelection::selectionFromContentsOfNode() to prevent crashing.

        Test: editing/pasteboard/drag-drop-input-in-svg.svg

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
2011-05-24  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Ryosuke Niwa.

        [SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
        https://bugs.webkit.org/show_bug.cgi?id=60692

        Test case to verify dragging and dropping text between input fields
        inside SVG <foreignObject>s. Test passes if no crash occurs in debug mode.

        Drag and drop is not supported in Qt DRT, so skip this case on Qt platform.

        * editing/pasteboard/drag-drop-input-in-svg-expected.txt: Added.
        * editing/pasteboard/drag-drop-input-in-svg.svg: Added.
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 25 May 2011 01:05:21 +0000 (01:05 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Yet another attempt to make Chromium Windows test bots happy.

        * fast/events/selectstart-by-double-triple-clicks.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Andy Estes <aestes@apple.com>
aestes@apple.com [Wed, 25 May 2011 00:48:00 +0000 (00:48 +0000)]
2011-05-24  Andy Estes  <aestes@apple.com>

        Reviewed by Geoffrey Garen.

        REGRESSION (r70748): WebKit cannot play QuickTime movies on Mac OS X Wiki Server pages
        https://bugs.webkit.org/show_bug.cgi?id=61229

        This site-specific hack maintains compatibility with Mac OS X Wiki Server,
        which embeds QuickTime movies using an object tag containing QuickTime's
        ActiveX classid. Treat this classid as valid only if OS X Server's unique
        'generator' meta tag is present. Only apply this quirk if there is no
        fallback content, which ensures the quirk will disable itself if Wiki
        Server is updated to generate an alternate embed tag as fallback content.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Return
        true if site-specific quirks are enabled, the object element has no
        fallback content, the classid attribute matches QuickTime's classid and
        the document has a 'generator' meta tag matching Mac OS X Web Services
        Server's unique generator string.
        (WebCore::HTMLObjectElement::hasValidClassId): Call
        shouldAllowQuickTimeClassIdQuirk()
        * html/HTMLObjectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMaybe fix the Mac build now?
ggaren@apple.com [Wed, 25 May 2011 00:33:00 +0000 (00:33 +0000)]
Maybe fix the Mac build now?

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 25 May 2011 00:24:38 +0000 (00:24 +0000)]
2011-05-24  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Change CachedResources to take a ResourceRequest instead of
        a url in their constructors and provide a very minimal set of
        cases for avoiding reusing a CachedResource. The ResourceRequest
        part of this change requires pushing responsibility
        for calling Document::completeURL() to the caller, instead of
        CachedResourceLoader, since ResourceRequest ASSERTs if it
        is constructed with an invalid url.

        https://bugs.webkit.org/show_bug.cgi?id=61318

        Refactor, no new tests.

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule):
        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::cachedImage):
        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::insertedIntoParent):
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::requestScript):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        * loader/ImageLoader.cpp:
        (WebCore::ImageLoader::updateFromElement):
        * loader/cache/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
        (WebCore::CachedCSSStyleSheet::didAddClient):
        (WebCore::CachedCSSStyleSheet::checkNotify):
        * loader/cache/CachedCSSStyleSheet.h:
        * loader/cache/CachedFont.cpp:
        (WebCore::CachedFont::CachedFont):
        * loader/cache/CachedFont.h:
        * loader/cache/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage):
        (WebCore::CachedImage::checkShouldPaintBrokenImage):
        * loader/cache/CachedImage.h:
        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        (WebCore::reuseRequest):
        (WebCore::CachedResource::allowReuseOfRequest):
        (WebCore::CachedResource::removeClient):
        (WebCore::CachedResource::canUseCacheValidator):
        * loader/cache/CachedResource.h:
        (WebCore::CachedResource::resourceRequest):
        (WebCore::CachedResource::url):
        * loader/cache/CachedResourceLoader.cpp:
        * loader/cache/CachedResourceLoader.h:
        * loader/cache/CachedResourceRequest.cpp:
        (WebCore::CachedResourceRequest::load):
        * loader/cache/CachedScript.cpp:
        (WebCore::CachedScript::CachedScript):
        * loader/cache/CachedScript.h:
        * loader/cache/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
        (WebCore::CachedXSLStyleSheet::didAddClient):
        (WebCore::CachedXSLStyleSheet::checkNotify):
        * loader/cache/CachedXSLStyleSheet.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::requestImageResource):
        * svg/SVGFontFaceUriElement.cpp:
        (WebCore::SVGFontFaceUriElement::loadFont):
        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::loadSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 25 May 2011 00:23:04 +0000 (00:23 +0000)]
2011-05-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Additional sandbox extension required for quarantine database
        <rdar://problem/9397494>
        https://bugs.webkit.org/show_bug.cgi?id=61405

        * WebProcess/com.apple.WebProcess.sb:
        Add read-data access for ~/Library/Preferences.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 25 May 2011 00:18:31 +0000 (00:18 +0000)]
2011-05-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Use Element::shadowPseudoId() for text field decoration elements
        https://bugs.webkit.org/show_bug.cgi?id=61351

        No new tests. Covered by existing tests.

        * css/CSSSelector.cpp: Remove support for the following static pseudo selectors:
          - -webkit-inner-spin-button
          - -webkit-input-speech-button
          - -webkit-outer-spin-button
          - -webkit-search-cancel-button
          - -webkit-search-decoration
          - -webkit-search-results-button
          - -webkit-search-results-decoration
        (WebCore::CSSSelector::pseudoId):
        (WebCore::nameToPseudoTypeMap):
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h: ditto.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchRules):
          Store shadowPseudoId() result in a local variable because
          SearchFieldResultsButtonElement::shadowPseudoId() is a little expensive.
        * html/shadow/TextControlInnerElements.cpp:
         Override Element::shadowPseudoId() instead of Element::styleForRenderer().
        (WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
        (WebCore::SearchFieldCancelButtonElement::shadowPseudoId):
        (WebCore::SpinButtonElement::shadowPseudoId):
        (WebCore::InputFieldSpeechButtonElement::shadowPseudoId):
        * html/shadow/TextControlInnerElements.h: Update declarations.
        * rendering/RenderTextControlSingleLine.cpp: Remove createFooStyle() functions.
        * rendering/RenderTextControlSingleLine.h: ditto.
        * rendering/style/RenderStyleConstants.h: Remove unused pseudo IDs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMaybe fix the Mac build?
ggaren@apple.com [Wed, 25 May 2011 00:12:27 +0000 (00:12 +0000)]
Maybe fix the Mac build?

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 24 May 2011 23:49:30 +0000 (23:49 +0000)]
2011-05-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Sorted WebCore.xcodeproj again.

        * WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 24 May 2011 23:46:35 +0000 (23:46 +0000)]
2011-05-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Split HeapRootVisitor into its own class
        https://bugs.webkit.org/show_bug.cgi?id=61399

        * GNUmakefile.list.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * heap/HandleHeap.cpp:
        * heap/HandleStack.cpp:
        * heap/Heap.cpp:
        * heap/HeapRootVisitor.h: Copied from Source/JavaScriptCore/heap/MarkStack.h.
        * heap/MarkStack.h:
        * runtime/ArgList.cpp:
        * runtime/SmallStrings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=61345
slewis@apple.com [Tue, 24 May 2011 23:46:14 +0000 (23:46 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=61345
part of <rdar://problem/8675177>
Don't initialize ResourceResponse.m_suggestedFilename until we want to use it.  Initializing it requires reading in and parsing a plist.
Add new initialization state CommonAndUncommonFields to ResourceResponse.  This will be for all the header fields.
Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it.
Add "Content-Type" to common headers since it is looked for by every CSS sheet load.

Reviewed by Geoff Garen.

No new tests because functionality has not changed.

* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):
* platform/network/ResourceResponseBase.h:
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Tue, 24 May 2011 23:43:15 +0000 (23:43 +0000)]
2011-05-24  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Improve handling in WebCore of low memory situations
        https://bugs.webkit.org/show_bug.cgi?id=61222

        Added call to enable memory pressure handling.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        * WebView/WebViewInternal.h:
2011-05-24  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Improve handling in WebCore of low memory situations
        https://bugs.webkit.org/show_bug.cgi?id=61222

        Added new class, MemoryPressureHandler, to platform to respond to low
        system memory events. Added Mac specific implementation that reduces the
        page cache, NSURL cache, WebCore cache by half their current usage
        and then garbage collects.  This can allow Safari to continue operating
        in a low memory situation with minimal paging.
        Split up prune operations in MemoryCache to allow for pruning to a
        specific actual size to support this change.

        No tests added as the functionality of WebKit wasn't changed.

        * GNUmakefile.list.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/cache/MemoryCache.cpp:
        (WebCore::MemoryCache::pruneLiveResources):
        (WebCore::MemoryCache::forcePruneLiveResources):
        (WebCore::MemoryCache::pruneLiveResourcesToTarget):
        (WebCore::MemoryCache::pruneDeadResources):
        (WebCore::MemoryCache::forcePruneDeadResources):
        (WebCore::MemoryCache::pruneDeadResourcesToTarget):
        * loader/cache/MemoryCache.h:
        (WebCore::MemoryCache::forcePrune):
        * platform/MemoryPressureHandler.cpp: Added.
        (WebCore::memoryPressureHandler):
        (WebCore::MemoryPressureHandler::MemoryPressureHandler):
        (WebCore::MemoryPressureHandler::install):
        (WebCore::MemoryPressureHandler::respondToMemoryPressure):
        * platform/MemoryPressureHandler.h: Added.
        * platform/mac/MemoryPressureHandler.mm: Added.
        (WebCore::MemoryPressureHandler::install):
        (WebCore::MemoryPressureHandler::respondToMemoryPressure):
2011-05-24  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Improve handling in WebCore of low memory situations
        https://bugs.webkit.org/show_bug.cgi?id=61222

        Added call to enable memory pressure handling for Mac case.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::initializeWebProcess):
        * WebProcess/WebProcess.h:
        * WebProcess/mac/WebProcessMac.mm:
        (WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 24 May 2011 23:19:55 +0000 (23:19 +0000)]
2011-05-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Node::shadowAncestorNode() and shadowTreeRootNode() should be const.
        https://bugs.webkit.org/show_bug.cgi?id=61398

        shadowAncestorNode() and shadowTreeRootNode() should be const
        though they can return 'this' pointer.

        No new tests. This doesn't change any visible behavior.

        * dom/Node.cpp:
        (WebCore::Node::shadowAncestorNode): Make this const.
        (WebCore::Node::shadowTreeRootNode): ditto.
        * dom/Node.h: Update declarations.
        * html/shadow/TextControlInnerElements.h:
        (WebCore::SpinButtonElement::isEnabledFormControl): Need no const_cast<>.
        (WebCore::SpinButtonElement::isReadOnlyFormControl): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPart of <rdar://problem/9434311> and https://bugs.webkit.org/show_bug.cgi?id=61334
beidson@apple.com [Tue, 24 May 2011 22:52:21 +0000 (22:52 +0000)]
Part of <rdar://problem/9434311> and https://bugs.webkit.org/show_bug.cgi?id=61334
Should shim a few SecKeychainItem* methods on SnowLeopard

Reviewed by Darin Adler.

Initialize the KeychainItem shim on SnowLeopard:
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::initializeShim):

On SnowLeopard, shim the 4 SecKeychainItem methods:
* WebProcess/mac/WebProcessShim.h:
* WebProcess/mac/WebProcessShim.mm:
(WebKit::shimSecKeychainItemCopyContent):
(WebKit::shimSecKeychainItemCreateFromContent):
(WebKit::shimSecKeychainItemModifyContent):
(WebKit::shimSecKeychainItemFreeContent):
(WebKit::WebKitWebProcessKeychainItemShimInitialize):

* WebProcess/mac/KeychainItemShimMethods.h: Added.
* WebProcess/mac/KeychainItemShimMethods.mm: Added.
Manage a set of shim-controlled AttributeList data:
(WebKit::shimManagedAttributeLists):
(WebKit::freeAttributeListContents):
(WebKit::allocateAttributeListContents):

Manage a set of shim-controlled KeychainItem data:
(WebKit::shimManagedKeychainItemContents):
(WebKit::allocateKeychainItemContentData):

Free any shim-controlled AttributeList or KeychainItem data:
(WebKit::webFreeAttributeListContentOnMainThread):
(WebKit::webFreeAttributeListContent):
(WebKit::webFreeKeychainItemContentOnMainThread):
(WebKit::webFreeKeychainItemContent):

Marshall these 3 KeychainItem methods to the UIProcess:
(WebKit::webSecKeychainItemCopyContentOnMainThread):
(WebKit::webSecKeychainItemCopyContent):
(WebKit::webSecKeychainItemCreateFromContentOnMainThread):
(WebKit::webSecKeychainItemCreateFromContent):
(WebKit::webSecKeychainItemModifyContentOnMainThread):
(WebKit::webSecKeychainItemModifyContent):
(WebKit::initializeKeychainItemShim):

Container for an AttributeList entry that knows how to encode/decode:
* Shared/mac/KeychainAttribute.cpp: Added.
(WebKit::KeychainAttribute::KeychainAttribute):
(CoreIPC::encode):
(CoreIPC::decode):
* Shared/mac/KeychainAttribute.h: Added.

Container for the relevant arguments to the shimmed methods, to send to the UIProcess:
* Shared/mac/SecKeychainItemRequestData.cpp: Added.
(WebKit::SecKeychainItemRequestData::SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::initializeWithAttributeList):
(WebKit::SecKeychainItemRequestData::~SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::attributeList):
(WebKit::SecKeychainItemRequestData::encode):
(WebKit::SecKeychainItemRequestData::decode):
* Shared/mac/SecKeychainItemRequestData.h: Added.
(WebKit::SecKeychainItemRequestData::keychainItem):
(WebKit::SecKeychainItemRequestData::itemClass):
(WebKit::SecKeychainItemRequestData::length):
(WebKit::SecKeychainItemRequestData::data):

Container for the possible output from the shimmed methods, to send back to the WebProcess:
* Shared/mac/SecKeychainItemResponseData.cpp: Added.
(WebKit::SecKeychainItemResponseData::SecKeychainItemResponseData):
(WebKit::SecKeychainItemResponseData::encode):
(WebKit::SecKeychainItemResponseData::decode):
* Shared/mac/SecKeychainItemResponseData.h: Added.
(WebKit::SecKeychainItemResponseData::itemClass):
(WebKit::SecKeychainItemResponseData::data):
(WebKit::SecKeychainItemResponseData::resultCode):
(WebKit::SecKeychainItemResponseData::attributes):
(WebKit::SecKeychainItemResponseData::keychainItem):

Actually implement the calls to the SecKeychainItem* methods in the UIProcess:
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::secKeychainItemCopyContent):
(WebKit::WebProcessProxy::secKeychainItemCreateFromContent):
(WebKit::WebProcessProxy::secKeychainItemModifyContent):

* WebKit2.xcodeproj/project.pbxproj: Project file stuff
* Configurations/Shim.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 22:22:26 +0000 (22:22 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        [chromium] selectstart-by-drag.html and selectstart-by-double-triple-clicks.html
        fail on Windows and Linux
        https://bugs.webkit.org/show_bug.cgi?id=61377

        selectstart-by-drag.html pass on Chromium Windows and Chromium Linux so don't use
        the failing test expectation on Windows port.

        In selectstart-by-double-triple-clicks.html, /^\s|\s$/ isn't recognized by V8 so
        replace it by /^[ \t]|[ \t]$/.

        * platform/chromium/fast/events/selectstart-by-drag-expected.txt: Copied from
        LayoutTests/fast/events/selectstart-by-drag-expected.txt.
        * fast/events/selectstart-by-double-triple-clicks.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Tue, 24 May 2011 22:12:24 +0000 (22:12 +0000)]
2011-05-24  James Simonsen  <simonjam@chromium.org>

        Reviewed by Eric Seidel.

        ASSERT_NOT_REACHED reached with broken ideograph and system fallback
        https://bugs.webkit.org/show_bug.cgi?id=53528

        * platform/chromium/test_expectations.txt: Remove CRASH from fixed test.
2011-05-24  James Simonsen  <simonjam@chromium.org>

        Reviewed by Eric Seidel.

        ASSERT_NOT_REACHED reached with broken ideograph and system fallback
        https://bugs.webkit.org/show_bug.cgi?id=53528

        Test: fast/text/justify-ideograph-vertical.html (on chromium linux)

        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::glyphDataForCharacter): Identify and handle broken ideographs as any other variant.
        * platform/graphics/SimpleFontData.h:
        (WebCore::SimpleFontData::variantFontData): Added BrokenIdeographVariant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 22:10:03 +0000 (22:10 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html on Mac WebKit2
        since WebKitTestRunner doesn't implement eventSender.mouseScrollBy yet (bug 42194).

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Jay Civelli <jcivelli@chromium.org>
abarth@webkit.org [Tue, 24 May 2011 22:09:37 +0000 (22:09 +0000)]
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Rubberstamped by David Kilzer.

        Updated some files that I forgot in my previous MHTML CL.

        * Configurations/FeatureDefines.xcconfig:
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Rubberstamped by David Kilzer.

        Updated some files that I forgot in my previous MHTML CL.

        * Configurations/FeatureDefines.xcconfig:
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Rubberstamped by David Kilzer.

        Updated some files that I forgot in my previous MHTML CL.

       * Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Skip platform/mac/editing/input/maxlength.html - textInputController is not...
ap@apple.com [Tue, 24 May 2011 22:06:37 +0000 (22:06 +0000)]
    Skip platform/mac/editing/input/maxlength.html - textInputController is not implemented.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Robert Hogan <robert@webkit.org>
robert@webkit.org [Tue, 24 May 2011 21:59:54 +0000 (21:59 +0000)]
2011-05-24  Robert Hogan  <robert@webkit.org>

        Reviewed by Ryosuke Niwa.

        [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
        https://bugs.webkit.org/show_bug.cgi?id=61393

        * platform/qt/Skipped: Unskip fast/events/selectstart-by-single-click-with-shift.html
2011-05-24  Robert Hogan  <robert@webkit.org>

        Reviewed by Ryosuke Niwa.

        [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
        https://bugs.webkit.org/show_bug.cgi?id=61393

        * DumpRenderTree/qt/EventSenderQt.h:
        * DumpRenderTree/qt/EventSenderQt.cpp:
        (getModifiers): static function for interpreting modifiers
        (EventSender::mouseDown): Respect keyboard modifiers
        (EventSender::keyDown): use new static function
        (EventSender::sendOrQueueEvent): whitespace fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 21:56:45 +0000 (21:56 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Skip fast/events/selectstart-by-double-triple-clicks.html and selectstart-by-drag.html
        on Mac WebKit 2 per the bug 42194.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Syed Idris Shah <syed.idris-shah@nokia.com>
commit-queue@webkit.org [Tue, 24 May 2011 21:47:27 +0000 (21:47 +0000)]
2011-05-24  Syed Idris Shah  <syed.idris-shah@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
        https://bugs.webkit.org/show_bug.cgi?id=60377

        LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html

        We do not need assert for the useProgram as program can be null.

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::useProgram): Program can be null. Removing assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 21:36:06 +0000 (21:36 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html added by r87187 on GTK
        because GTK port doesn't implement eventSender.scalePageBy yet (bug 61396).

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 21:29:30 +0000 (21:29 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html added by r87187 on Windows
        because Windows port doesn't implement eventSender.scalePageBy yet (bug 59098).

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 21:22:27 +0000 (21:22 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Undo gets broken in contenteditable area when a text field's value is set by script
        https://bugs.webkit.org/show_bug.cgi?id=61340

        Added a test to ensure WebKit does not clear undo stack when setting the value of input or textarea.

        * editing/undo/undo-after-setting-value-expected.txt: Added.
        * editing/undo/undo-after-setting-value.html: Added.
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Undo gets broken in contenteditable area when a text field's value is set by script
        https://bugs.webkit.org/show_bug.cgi?id=61340

        The bug was caused by RenderTextControl::setInnerTextValue's clearing undo stack by
        calling clearUndoRedoOperations whenever script sets new value to input or textarea.

        Fixed the bug by removing the offending call to clearUndoRedoOperations. While this call
        was added by r15565 to fix a crash, SimpleEditCommands have since become much more robust
        and the test added by r15565 (fast/forms/text-field-setvalue-crash.html) still passes.

        Test: editing/undo/undo-after-setting-value.html

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::setInnerTextValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Tue, 24 May 2011 21:12:02 +0000 (21:12 +0000)]
2011-05-24  Adam Klein  <adamk@chromium.org>

        Unreviewed. Updating Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove code to discover if a CTFont has vertical glyphs out of SimpleFontData::platform...
mitz@apple.com [Tue, 24 May 2011 21:01:47 +0000 (21:01 +0000)]
Move code to discover if a CTFont has vertical glyphs out of SimpleFontData::platformInit()
https://bugs.webkit.org/show_bug.cgi?id=61392

Reviewed by Dave Hyatt.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::fontHasVerticalGlyphs): Moved code here...
(WebCore::SimpleFontData::platformInit): ...from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Mac build: Yes, please do remove these files, svn.
ggaren@apple.com [Tue, 24 May 2011 20:56:36 +0000 (20:56 +0000)]
Fix the Mac build: Yes, please do remove these files, svn.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 24 May 2011 20:51:52 +0000 (20:51 +0000)]
2011-05-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Let's just have one way to get the system page size, bokay?
        https://bugs.webkit.org/show_bug.cgi?id=61384

        * CMakeListsEfl.txt:
        * CMakeListsWinCE.txt:
        * GNUmakefile.list.am:
        * JavaScriptCore.exp:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: MarkStack[Platform].cpp
        is gone completely now, since it only existed to provide a duplicate way
        to access the system page size.

        * heap/MarkStack.cpp:
        (JSC::MarkStack::reset):
        * heap/MarkStack.h:
        (JSC::::MarkStackArray):
        (JSC::::shrinkAllocation): Use WTF::pageSize.

        * heap/MarkStackPosix.cpp:
        * heap/MarkStackSymbian.cpp:
        * heap/MarkStackWin.cpp: Removed now-empty files.

        * jit/ExecutableAllocator.cpp:
        (JSC::ExecutableAllocator::reprotectRegion):
        * jit/ExecutableAllocator.h:
        (JSC::ExecutableAllocator::ExecutableAllocator):
        (JSC::ExecutablePool::ExecutablePool):
        (JSC::ExecutablePool::poolAllocate):
        * jit/ExecutableAllocatorFixedVMPool.cpp: Use WTF::pageSize.

        * wscript: Removed now-empty files.

        * wtf/PageBlock.cpp:
        (WTF::systemPageSize): Integrated questionable Symbian page size rule
        from ExecutableAllocator, because that seems like what the original
        author should have done.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 24 May 2011 20:41:51 +0000 (20:41 +0000)]
2011-05-24  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Implement Float64Array
        https://bugs.webkit.org/show_bug.cgi?id=39144

        Implemented Float64Array based on the existing Float32Array sources.
        Built and tested in Chromium on Linux and Mac OS X and Safari on Mac OS X.

        * CMakeLists.txt:
        * CodeGenerators.pri:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.list.am:
        * UseJSC.cmake:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::float64Array):
        * bindings/js/JSFloat64ArrayCustom.cpp: Added.
        (WebCore::JSFloat64Array::indexSetter):
        (WebCore::toJS):
        (WebCore::JSFloat64Array::set):
        (WebCore::JSFloat64ArrayConstructor::constructJSFloat64Array):
        * bindings/v8/custom/V8Float64ArrayCustom.cpp: Added.
        (WebCore::V8Float64Array::constructorCallback):
        (WebCore::V8Float64Array::setCallback):
        (WebCore::toV8):
        * html/canvas/ArrayBufferView.h:
        (WebCore::ArrayBufferView::isDoubleArray):
        * html/canvas/Float64Array.cpp: Added.
        (WebCore::Float64Array::create):
        (WebCore::Float64Array::Float64Array):
        (WebCore::Float64Array::subarray):
        * html/canvas/Float64Array.h: Added.
        (WebCore::Float64Array::set):
        (WebCore::Float64Array::item):
        (WebCore::Float64Array::isDoubleArray):
        * html/canvas/Float64Array.idl: Added.
        * page/DOMWindow.idl:
        * workers/WorkerContext.idl:
2011-05-24  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Implement Float64Array
        https://bugs.webkit.org/show_bug.cgi?id=39144

        Added unit tests to existing typed array tests in Khronos repository and
        synced layout test with them. Updated other affected layout tests.

        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
        * fast/dom/Window/script-tests/window-property-descriptors.js:
        * fast/dom/Window/window-properties.html:
        * fast/dom/script-tests/constructed-objects-prototypes.js:
        (constructorPropertiesOnWindow):
        * fast/dom/script-tests/prototype-inheritance-2.js:
        (constructorNamesForWindow):
        * fast/dom/script-tests/prototype-inheritance.js:
        * fast/js/script-tests/global-constructors.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 24 May 2011 20:23:56 +0000 (20:23 +0000)]
2011-05-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        Add ability to set compositing layer bounds origin
        https://bugs.webkit.org/show_bug.cgi?id=61381

        On Core Animation layers, the origin of the bounds
        rectangle affects where layer content is rendered, as well
        as the offset of sublayers. Currently we always set the
        bounds offset to a zero point, but may need to make use
        of the bounds offset in future, so expose it via GraphicsLayer.

        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::boundsOrigin):
        (WebCore::GraphicsLayer::setBoundsOrigin):
        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::setSize):
        (WebCore::GraphicsLayerCA::setBoundsOrigin):
        (WebCore::GraphicsLayerCA::setAllowTiledLayer):
        (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
        (WebCore::GraphicsLayerCA::updateBounds):
        (WebCore::GraphicsLayerCA::ensureStructuralLayer):
        (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
        * platform/graphics/ca/GraphicsLayerCA.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoClean up after Geoff and fix the WebKit2 build.
weinig@apple.com [Tue, 24 May 2011 20:18:55 +0000 (20:18 +0000)]
Clean up after Geoff and fix the WebKit2 build.

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Tue, 24 May 2011 20:07:05 +0000 (20:07 +0000)]
2011-05-24  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Build fix.

        * CMakeLists.txt: Also build platform/network/ContentTypeParser.cpp,
        added by r86289.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Tue, 24 May 2011 20:03:50 +0000 (20:03 +0000)]
2011-05-24  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Build fix.

        * bridge/runtime_root.cpp: Include <heap/Weak.h> instead of
        <JavaScriptCore/Weak.h>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 19:51:54 +0000 (19:51 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Skip the tests added by r87096 and remove the failing test expectations on Qt.
        The failures are tracked by the bug 61322.

        * platform/qt/Skipped:
        * platform/qt/fast/events/selectstart-by-double-triple-clicks-expected.txt: Removed.
        * platform/qt/fast/events/selectstart-by-drag-expected.txt: Removed.
        * platform/qt/fast/events/selectstart-by-single-click-with-shift-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 24 May 2011 19:39:47 +0000 (19:39 +0000)]
2011-05-24  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Interpreter crashes with gc validation enabled due to failure to mark initial cache structure
        https://bugs.webkit.org/show_bug.cgi?id=61385

        The interpreter uses the structure slot of get_by_id and put_by_id to hold
        the initial structure it encountered so that it can identify whether a
        given access is stable.

        When marking though we only visit the slot when we've decided to cache, and
        so this value could die.  This was "safe" as the value was only used for a
        pointer compare, but it was incorrect.  We now just mark the slot like we
        should have been doing already.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::visitStructures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Tue, 24 May 2011 19:32:03 +0000 (19:32 +0000)]
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML reading support.
        https://bugs.webkit.org/show_bug.cgi?id=7168

        * configure.ac:
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML reading support to WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=7168

        * mhtml/frame_0.html_original: Added.
        * mhtml/frame_1.html_original: Added.
        * mhtml/frame_2.html_original: Added.
        * mhtml/frame_4.html_original: Added.
        * mhtml/multi_frames.html_original: Added.
        * mhtml/multi_frames_ie.mht: Added.
        * mhtml/multi_frames_unmht.mht: Added.
        * mhtml/page_with_css_and_js.html_original: Added.
        * mhtml/page_with_css_and_js_ie.mht: Added.
        * mhtml/page_with_css_and_js_unmht.mht: Added.
        * mhtml/page_with_image.html_original: Added.
        * mhtml/page_with_image_ie.mht: Added.
        * mhtml/page_with_image_unmht.mht: Added.
        * mhtml/resources/red_square.png: Added.
        * mhtml/simple_page.html_original: Added.
        * mhtml/simple_page_ie.mht: Added.
        * mhtml/simple_page_unmht.mht: Added.
        * platform/chromium/mhtml/multi_frames_ie-expected.txt: Added.
        * platform/chromium/mhtml/multi_frames_unmht-expected.txt: Added.
        * platform/chromium/mhtml/page_with_css_and_js_ie-expected.txt: Added.
        * platform/chromium/mhtml/page_with_css_and_js_unmht-expected.txt: Added.
        * platform/chromium/mhtml/page_with_image_ie-expected.txt: Added.
        * platform/chromium/mhtml/page_with_image_unmht-expected.txt: Added.
        * platform/chromium/mhtml/simple_page_ie-expected.txt: Added.
        * platform/chromium/mhtml/simple_page_unmht-expected.txt: Added.
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML reading support. That required some basic MIME header parsing.
        Modified DocumentLoader to keep a reference to the currently Archive loaded,
        so we can have different policies for loading subresources depending on the
        archive type.
        https://bugs.webkit.org/show_bug.cgi?id=7168

        * CMakeLists.txt:
        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * features.pri:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::commitLoad):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        (WebCore::DocumentLoader::popArchiveForSubframe):
        (WebCore::DocumentLoader::scheduleArchiveLoad):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadURLIntoChildFrame):
        (WebCore::FrameLoader::loadArchive):
        (WebCore::FrameLoader::stopAllLoaders):
        (WebCore::FrameLoader::finishedLoadingDocument):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::archive):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::start):
        * loader/archive/Archive.cpp: Added.
        * loader/archive/Archive.h:
        (WebCore::Archive::mainResource):
        * loader/archive/ArchiveFactory.cpp:
        (WebCore::archiveFactoryCreate):
        (WebCore::archiveMIMETypes):
        (WebCore::ArchiveFactory::create):
        (WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
        * loader/archive/ArchiveFactory.h:
        * loader/archive/ArchiveResourceCollection.cpp:
        (WebCore::ArchiveResourceCollection::addAllResources):
        (WebCore::ArchiveResourceCollection::popSubframeArchive):
        * loader/archive/ArchiveResourceCollection.h:
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::create):
        (WebCore::LegacyWebArchive::type):
        * loader/archive/cf/LegacyWebArchive.h:
        * loader/archive/mhtml/MHTMLArchive.cpp: Added.
        * loader/archive/mhtml/MHTMLArchive.h: Added.
        * loader/archive/mhtml/MHTMLParser.cpp: Added.
        * loader/archive/mhtml/MHTMLParser.h: Added.
        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedNonImageMimeTypes):
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::documentFragment):
        * platform/network/MIMEHeader.cpp: Added.
        * platform/network/MIMEHeader.h: Added.
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML reading support to WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=7168

       * features.gypi:
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML reading support.
        https://bugs.webkit.org/show_bug.cgi?id=7168

        * Scripts/build-webkit:
        * Scripts/old-run-webkit-tests:
        * Scripts/webkitperl/features.pm:
        * Scripts/webkitpy/layout_tests/port/test_files.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTry to fix some builds: #include Weak.h for Weak<T>.
ggaren@apple.com [Tue, 24 May 2011 19:24:33 +0000 (19:24 +0000)]
Try to fix some builds: #include Weak.h for Weak<T>.

* bridge/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 24 May 2011 19:23:17 +0000 (19:23 +0000)]
2011-05-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Beth Dakin.

        Can't scroll scaled page that has overflow:hidden on its root
        <rdar://problem/9029189>
        https://bugs.webkit.org/show_bug.cgi?id=61339

        Test: fast/events/scroll-in-scaled-page-with-overflow-hidden.html

        * page/FrameView.cpp:
        (WebCore::FrameView::applyOverflowToViewport):
        Scrollbars should be enabled for the viewport when scaled, even if overflow:hidden
        is specified.
2011-05-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Beth Dakin.

        Can't scroll scaled page that has overflow:hidden on its root
        <rdar://problem/9029189>
        https://bugs.webkit.org/show_bug.cgi?id=61339

        * fast/events/scroll-in-scaled-page-with-overflow-hidden-expected.txt: Added.
        * fast/events/scroll-in-scaled-page-with-overflow-hidden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix
aroben@apple.com [Tue, 24 May 2011 19:13:02 +0000 (19:13 +0000)]
Windows build fix

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed now-inline functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix: update the #if OS(WINDOWS) section to match my last patch.
ggaren@apple.com [Tue, 24 May 2011 19:07:46 +0000 (19:07 +0000)]
Windows build fix: update the #if OS(WINDOWS) section to match my last patch.

* heap/MarkStack.h:
(JSC::::shrinkAllocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLeopard build fix
aroben@apple.com [Tue, 24 May 2011 19:03:46 +0000 (19:03 +0000)]
Leopard build fix

* bridge/runtime_root.cpp: Added a missing #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake start parameter of Blob.slice optional.
jianli@chromium.org [Tue, 24 May 2011 18:57:27 +0000 (18:57 +0000)]
Make start parameter of Blob.slice optional.
https://bugs.webkit.org/show_bug.cgi?id=59628

Reviewed by Kenneth Russell.

Source/WebCore:

The start parameter should be optional per the latest FILE API
spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob.

* fileapi/Blob.h:
* fileapi/Blob.idl: Make start parameter optional.

LayoutTests:

* fast/files/blob-slice-test-expected.txt:
* fast/files/blob-slice-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSplit out function definitions and class definitions from class
ggaren@apple.com [Tue, 24 May 2011 18:55:10 +0000 (18:55 +0000)]
Split out function definitions and class definitions from class
declarations in MarkStack.h, for readability.

Rubber-stamped by Oliver Hunt.

* heap/MarkStack.h:
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::~MarkStack):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
(JSC::MarkSet::MarkSet):
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):
(JSC::MarkStack::pageSize):
(JSC::::MarkStackArray):
(JSC::::~MarkStackArray):
(JSC::::expand):
(JSC::::append):
(JSC::::removeLast):
(JSC::::last):
(JSC::::isEmpty):
(JSC::::size):
(JSC::::shrinkAllocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoInvalidate JS wrappers for NPObjects when they are finalized
aroben@apple.com [Tue, 24 May 2011 18:51:49 +0000 (18:51 +0000)]
Invalidate JS wrappers for NPObjects when they are finalized

This will cause the underlying NPObject to be released at finalization time, rather than at
destruction time (which is unpredictable and could occur after the plugin has been
unloaded).

Test: plugins/npobject-js-wrapper-destroyed-after-plugin-unload.html

Fixes <http://webkit.org/b/61316> <rdar://problem/9489824> Crash in deallocateNPObject when
reloading yahoo.com webarchive in WebKit2

and

<http://webkit.org/b/61317> <rdar://problem/9489829> Crash in _NPN_DeallocateObject when
reloading yahoo.com webarchive in WebKit1

Reviewed by Oliver Hunt.

Source/WebCore:

* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::~RuntimeObject): Assert that we've already been invalidated.

* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
Updated for m_runtimeObjects type change.

(JSC::Bindings::RootObject::finalize): Added. Invalidates the RuntimeObject and removes it
from the map.

* bridge/runtime_root.h: Now inherits from WeakHandleOwner.
Changed m_runtimeObjects from a WeakGCMap to a HashMap of JSC::Weak objects so that we will
be notified when the RuntimeObjects are finalized.

Source/WebKit2:

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::~JSNPObject): Assert that we've already been invalidated, rather than
trying to perform invalidation now (when the plugin might already be unloaded).

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):
(WebKit::NPRuntimeObjectMap::invalidate):
Updated for m_jsNPObjects type change.

(WebKit::NPRuntimeObjectMap::finalize): Added. Invalidates the JSNPObject and removes it
from the map.

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h: Now inherits from WeakHandleOwner.
Changed m_jsNPObjects from a WeakGCMap to a HashMap of JSC::Weak objects so that we will be
notified when the JSNPObjects are finalized.

LayoutTests:

Test that we don't crash when a JS wrapper for an NPObject is destroyed after its plugin is unloaded

* plugins/npobject-js-wrapper-destroyed-after-plugin-unload-expected.txt: Added.
* plugins/npobject-js-wrapper-destroyed-after-plugin-unload.html: Added.
(startTest): Gets a JS wrapper for an NPObject from the plugin, allocate a bunch of memory
so the JS wrapper will be finalized, then destroy the plugin and wait for a little bit
before calling finishTest.
(finishTest): Force a GC so the JS wrapper will be destroyed. If we didn't crash, we passed!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 24 May 2011 18:50:48 +0000 (18:50 +0000)]
2011-05-24  Stephen White  <senorblanco@chromium.org>

        Reviewed by Kenneth Russell.

        Remove most style checks on Source/ThirdParty/glu, since it doesn't
        follow WebKit style.
        https://bugs.webkit.org/show_bug.cgi?id=61365

        * Scripts/webkitpy/style/checker.py:
2011-05-24  Stephen White  <senorblanco@chromium.org>

        Reviewed by Kenneth Russell.

        Unfork glu sources as much as possible.
        https://bugs.webkit.org/show_bug.cgi?id=61365

        Restore the glu sources closer to the original version on oss.sgi.com
        by removing the WebKit-specific include paths, restoring the include
        order, and renaming the glu* functions via #defines rather than in
        the source.

        * glu/README.webkit:
        Update the README to reflect the changes from trunk.
        * glu/glu.gyp:
        Add Source/Thirdparty/glu as an include path, so we can remove the
        hardcoded paths from the source files.
        * glu/gluos.h:
        Add #defines to rename the glu entry points to internal_*.
        * glu/internal_glu.h:
        * glu/libtess/dict.c:
        * glu/libtess/geom.c:
        * glu/libtess/geom.h:
        * glu/libtess/memalloc.c:
        * glu/libtess/mesh.c:
        * glu/libtess/mesh.h:
        * glu/libtess/normal.c:
        * glu/libtess/normal.h:
        * glu/libtess/priorityq-heap.c:
        * glu/libtess/priorityq-sort.h:
        * glu/libtess/priorityq.c:
        * glu/libtess/priorityq.h:
        * glu/libtess/render.c:
        * glu/libtess/render.h:
        * glu/libtess/sweep.c:
        * glu/libtess/sweep.h:
        * glu/libtess/tess.c:
        * glu/libtess/tess.h:
        * glu/libtess/tessmono.c:
        Remove WebKit-specific include paths, and internal_ prefixes from glu
        entry points.  Restore include order to original source order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-24 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 24 May 2011 18:49:18 +0000 (18:49 +0000)]
2011-05-24  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Avoid creating unnecessary identifiers and strings in the syntax checker
        https://bugs.webkit.org/show_bug.cgi?id=61378

        Selectively tell the lexer that there are some places it does not need to
        do the real work of creating Identifiers for IDENT and STRING tokens.

        Make parseString and parseIdentifier templatized on whether they should
        do real work, or merely validate the tokens.

        SunSpider --parse-only reports ~5-8% win depending on hardware.

        * parser/ASTBuilder.h:
        (JSC::ASTBuilder::createDotAccess):
        * parser/JSParser.cpp:
        (JSC::JSParser::next):
        (JSC::JSParser::consume):
        (JSC::JSParser::parseVarDeclarationList):
        (JSC::JSParser::parseConstDeclarationList):
        (JSC::JSParser::parseExpression):
        (JSC::JSParser::parseAssignmentExpression):
        (JSC::JSParser::parseConditionalExpression):
        (JSC::JSParser::parseBinaryExpression):
        (JSC::JSParser::parseProperty):
        (JSC::JSParser::parseObjectLiteral):
        (JSC::JSParser::parseArrayLiteral):
        (JSC::JSParser::parseArguments):
        (JSC::JSParser::parseMemberExpression):
        * parser/Lexer.cpp:
        (JSC::Lexer::parseIdentifier):
        (JSC::Lexer::parseString):
        (JSC::Lexer::lex):
        * parser/Lexer.h:
        * parser/SyntaxChecker.h:
        (JSC::SyntaxChecker::createDotAccess):
        (JSC::SyntaxChecker::createProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't allow forcing builds through the build.webkit.org web interface
aroben@apple.com [Tue, 24 May 2011 18:46:55 +0000 (18:46 +0000)]
Don't allow forcing builds through the build.webkit.org web interface

Someone has been forcing bogus builds.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87176 268f45cc-cd09-0410-ab3c-d52691b4dbfc