beidson [Tue, 12 Sep 2006 03:53:45 +0000 (03:53 +0000)]
Despite the fact that some people built okay without this change, it sure was biting me,
probably because I just wiped my build directory for a fresh build -
Today's earlier removal of DOMList.h needed to occur in MigrateHeaders.make, as well
* MigrateHeaders.make: removed DOMList.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 12 Sep 2006 02:45:45 +0000 (02:45 +0000)]
Build fix - I think Tim's last checkin wasn't tested on Tiger, possibly. I simply
commented out the undefined constants until he can have a chance to make the right call
* bindings/objc/objc_utility.mm:
(KJS::Bindings::objcValueTypeForType): Commented out undefined symbols
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 12 Sep 2006 00:22:53 +0000 (00:22 +0000)]
Build fix. KeyScript is deprecated in Leopard, we need a new solution for this <rdar://problem/
4727607>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 11 Sep 2006 23:57:33 +0000 (23:57 +0000)]
Reviewed by Tim O. and Darin.
Add support for more method signatures affecting ObjC methods called from JavaScript:
- Added unsigned types and long long.
- Allow methods that use const, oneway, bycopy and byref type modifiers.
* bindings/objc/objc_instance.mm:
(ObjcInstance::invokeMethod):
* bindings/objc/objc_utility.h:
(KJS::Bindings::):
* bindings/objc/objc_utility.mm:
(KJS::Bindings::convertValueToObjcValue):
(KJS::Bindings::convertObjcValueToValue):
(KJS::Bindings::objcValueTypeForType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Mon, 11 Sep 2006 23:11:03 +0000 (23:11 +0000)]
Reviewed by Adele.
Fix Qt/Linux build.
* CMakeLists.txt: Add dom/RangeException.idl to build & fix feature defines.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 11 Sep 2006 21:42:22 +0000 (21:42 +0000)]
2006-09-11 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by eseidel. Landed by eseidel.
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10750
This finally fixes the SVGAnimated* classes JS bindings!
- Move all SVGAnimated*.idl files from ksvg2/bindings/idl/svg to ksvg2/svg
- Adjust XCode/Qt build files to generate the new idl files
- Remove all SVGAnimated* primitives cpp implementations (Angle/Boolean/Color/Enumeration/Integer/Length/
LengthList/Number/NumberList/PreserveAspectRatio/
Rect/String/TransformList)
- Remove unneeded methods from CodeGenerator.pm and add new helper function: IsSVGAnimatedType
- Adjust CodeGeneratorJS.pm to the new SVGAnimated* tear-off concept
- Add two new macros: ANIMATED_PROPERTY_EMPTY_DECLARATIONS / ANIMATED_PROPERTY_FORWARD_DECLARATIONS.
This is used to fix multiple-inheritance issues in SVG with properties,
similar like SVGTests::isValid() was fixed.
- Rewrote SVGList using WTF::Vector, instead of DeprecatedPtrList and killed DOMList.
(SVGAnimated*Lists work again now)
- Adjust macros in SVGElement to create the "*Animated" tear-off classes.
- Adjust all SVG classes which use the ANIMATED macros to include the ClassName as first param in the header.
* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* kcanvas/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::adjustRectsForAspectRatio):
(WebCore::RenderSVGImage::paint):
* kcanvas/RenderSVGText.cpp:
(WebCore::RenderSVGText::translationForAttributes):
* ksvg2/ksvg.h:
* ksvg2/misc/SVGDocumentExtensions.h:
(WebCore::FloatRect):
* ksvg2/svg/SVGAElement.h:
* ksvg2/svg/SVGAnimateColorElement.cpp:
* ksvg2/svg/SVGAnimateColorElement.h:
* ksvg2/svg/SVGAnimateTransformElement.h:
* ksvg2/svg/SVGAnimatedTemplate.h:
(WebCore::SVGAnimatedTemplate::~SVGAnimatedTemplate):
* ksvg2/svg/SVGAnimationElement.h:
* ksvg2/svg/SVGCircleElement.h:
* ksvg2/svg/SVGClipPathElement.h:
* ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
(SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
(SVGComponentTransferFunctionElement::transferFunction):
* ksvg2/svg/SVGComponentTransferFunctionElement.h:
* ksvg2/svg/SVGCursorElement.h:
* ksvg2/svg/SVGDefsElement.h:
* ksvg2/svg/SVGElement.h:
* ksvg2/svg/SVGElementInstanceList.cpp:
(WebCore::SVGElementInstanceList::SVGElementInstanceList):
* ksvg2/svg/SVGElementInstanceList.h:
* ksvg2/svg/SVGEllipseElement.h:
* ksvg2/svg/SVGExternalResourcesRequired.h:
* ksvg2/svg/SVGFEBlendElement.h:
* ksvg2/svg/SVGFEColorMatrixElement.cpp:
(SVGFEColorMatrixElement::SVGFEColorMatrixElement):
(SVGFEColorMatrixElement::parseMappedAttribute):
(SVGFEColorMatrixElement::filterEffect):
* ksvg2/svg/SVGFEColorMatrixElement.h:
* ksvg2/svg/SVGFEComponentTransferElement.h:
* ksvg2/svg/SVGFECompositeElement.h:
* ksvg2/svg/SVGFEDiffuseLightingElement.h:
* ksvg2/svg/SVGFEDisplacementMapElement.h:
* ksvg2/svg/SVGFEFloodElement.h:
* ksvg2/svg/SVGFEGaussianBlurElement.h:
* ksvg2/svg/SVGFEImageElement.h:
* ksvg2/svg/SVGFELightElement.h:
* ksvg2/svg/SVGFEMergeNodeElement.h:
* ksvg2/svg/SVGFEOffsetElement.h:
* ksvg2/svg/SVGFESpecularLightingElement.h:
* ksvg2/svg/SVGFETileElement.h:
* ksvg2/svg/SVGFETurbulenceElement.h:
* ksvg2/svg/SVGFilterElement.h:
* ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
* ksvg2/svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::SVGFitToViewBox):
(WebCore::SVGFitToViewBox::parseViewBox):
(WebCore::SVGFitToViewBox::viewBoxToViewTransform):
* ksvg2/svg/SVGFitToViewBox.h:
* ksvg2/svg/SVGForeignObjectElement.h:
* ksvg2/svg/SVGGElement.h:
* ksvg2/svg/SVGGradientElement.cpp:
(SVGGradientElement::SVGGradientElement):
* ksvg2/svg/SVGGradientElement.h:
* ksvg2/svg/SVGHelper.cpp:
(WebCore::SVGHelper::PercentageOfViewport):
* ksvg2/svg/SVGImageElement.h:
* ksvg2/svg/SVGLength.cpp:
* ksvg2/svg/SVGLengthList.cpp:
(WebCore::SVGLengthList::SVGLengthList):
(WebCore::SVGLengthList::parse):
* ksvg2/svg/SVGLengthList.h:
* ksvg2/svg/SVGLineElement.h:
* ksvg2/svg/SVGLinearGradientElement.h:
* ksvg2/svg/SVGList.h:
(WebCore::SVGListBase::SVGListBase):
(WebCore::SVGListBase::~SVGListBase):
(WebCore::SVGListBase::numberOfItems):
(WebCore::SVGListBase::clear):
(WebCore::SVGListBase::initialize):
(WebCore::SVGListBase::getFirst):
(WebCore::SVGListBase::getLast):
(WebCore::SVGListBase::getItem):
(WebCore::SVGListBase::insertItemBefore):
(WebCore::SVGListBase::replaceItem):
(WebCore::SVGListBase::removeItem):
(WebCore::SVGListBase::appendItem):
(WebCore::SVGList::nullItem):
(WebCore::):
* ksvg2/svg/SVGLocatable.cpp:
* ksvg2/svg/SVGMarkerElement.h:
* ksvg2/svg/SVGMaskElement.h:
* ksvg2/svg/SVGNumberList.cpp:
(SVGNumberList::SVGNumberList):
(SVGNumberList::parse):
* ksvg2/svg/SVGNumberList.h:
* ksvg2/svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::pathSegList):
* ksvg2/svg/SVGPathElement.h:
* ksvg2/svg/SVGPathSegList.cpp:
(WebCore::SVGPathSegList::SVGPathSegList):
* ksvg2/svg/SVGPathSegList.h:
* ksvg2/svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::SVGPatternElement):
* ksvg2/svg/SVGPatternElement.h:
* ksvg2/svg/SVGPointList.cpp:
(SVGPointList::SVGPointList):
* ksvg2/svg/SVGPointList.h:
* ksvg2/svg/SVGPolyElement.cpp:
(SVGPolyElement::points):
(SVGPolyElement::svgPolyTo):
(SVGPolyElement::notifyAttributeChange):
* ksvg2/svg/SVGPolyElement.h:
* ksvg2/svg/SVGPolygonElement.cpp:
(SVGPolygonElement::toPathData):
* ksvg2/svg/SVGPolylineElement.cpp:
(SVGPolylineElement::toPathData):
* ksvg2/svg/SVGPreserveAspectRatio.h:
(WebCore::SVGPreserveAspectRatio::):
* ksvg2/svg/SVGRadialGradientElement.h:
* ksvg2/svg/SVGRectElement.h:
* ksvg2/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::parseMappedAttribute):
(WebCore::SVGSVGElement::createRenderer):
* ksvg2/svg/SVGSVGElement.h:
* ksvg2/svg/SVGScriptElement.h:
* ksvg2/svg/SVGStopElement.h:
* ksvg2/svg/SVGStringList.cpp:
(WebCore::SVGStringList::SVGStringList):
(WebCore::SVGStringList::reset):
* ksvg2/svg/SVGStringList.h:
* ksvg2/svg/SVGStyledElement.h:
* ksvg2/svg/SVGStyledLocatableElement.cpp:
* ksvg2/svg/SVGStyledTransformableElement.cpp:
(SVGStyledTransformableElement::SVGStyledTransformableElement):
* ksvg2/svg/SVGStyledTransformableElement.h:
* ksvg2/svg/SVGSwitchElement.h:
* ksvg2/svg/SVGSymbolElement.h:
* ksvg2/svg/SVGTRefElement.h:
* ksvg2/svg/SVGTests.cpp:
(WebCore::SVGTests::isValid):
* ksvg2/svg/SVGTextContentElement.h:
* ksvg2/svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::SVGTextElement):
* ksvg2/svg/SVGTextElement.h:
* ksvg2/svg/SVGTextPositioningElement.cpp:
(SVGTextPositioningElement::SVGTextPositioningElement):
(SVGTextPositioningElement::parseMappedAttribute):
* ksvg2/svg/SVGTextPositioningElement.h:
* ksvg2/svg/SVGTransformList.cpp:
(SVGTransformList::SVGTransformList):
(SVGTransformList::createSVGTransformFromMatrix):
(SVGTransformList::consolidate):
(SVGTransformList::concatenate):
* ksvg2/svg/SVGTransformList.h:
* ksvg2/svg/SVGURIReference.h:
* ksvg2/svg/SVGUseElement.h:
* ksvg2/svg/SVGViewElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Mon, 11 Sep 2006 21:07:34 +0000 (21:07 +0000)]
Build fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 11 Sep 2006 20:58:09 +0000 (20:58 +0000)]
ChangeLog date fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 11 Sep 2006 20:48:40 +0000 (20:48 +0000)]
Rubberstamped by Adele.
Rename LocalGraphicsContext.{h,mm} to
LocalCurrentGraphicsContext.{h,mm} to match the class name.
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/LocalCurrentGraphicsContext.mm: Added.
* platform/mac/LocalCurrentGraphicsContext.h: Added.
* platform/mac/LocalGraphicsContext.h: Removed.
* platform/mac/LocalGraphicsContext.mm: Removed.
* rendering/RenderThemeMac.mm: Fix #include to match renamed file
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 11 Sep 2006 20:34:15 +0000 (20:34 +0000)]
Conflict marker removed
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 11 Sep 2006 20:29:20 +0000 (20:29 +0000)]
Build fix
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Mon, 11 Sep 2006 18:46:49 +0000 (18:46 +0000)]
LayoutTests:
Reviewed by Darin.
* ChangeLog:
* fast/dom/Range/range-compareNode-expected.txt: Added.
* fast/dom/Range/range-compareNode.html: Added.
* fast/dom/Range/range-comparePoint.html:
WebCore:
Reviewed by Darin.
- Implements comparePoint on the Range class
- Exposes RangeExceptions in JavaScript
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/kjs_binding.cpp:
* bindings/objc/DOMInternal.mm:
* dom/Range.cpp:
(WebCore::Range::comparePoint):
(WebCore::Range::compareNode):
* dom/Range.h:
(WebCore::Range::):
* dom/Range.idl:
* dom/RangeException.h: Added.
(WebCore::):
* dom/RangeException.idl: Added.
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 11 Sep 2006 18:41:54 +0000 (18:41 +0000)]
Reviewed by timo.
Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10812
Move LocalGraphicsContext out of RenderThemeMac
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/LocalGraphicsContext.h: Added.
* platform/mac/LocalGraphicsContext.mm: Added.
(WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
(WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
* rendering/RenderThemeMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 11 Sep 2006 17:38:39 +0000 (17:38 +0000)]
LayoutTests:
Reviewed by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10323
REGRESSION: javascript: URL containing '\\' gets passed as '//'
* fast/dom/javascript-backslash-expected.txt: Added.
* fast/dom/javascript-backslash.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10323
REGRESSION: javascript: URL containing '\\' gets passed as '//'
Test: fast/dom/javascript-backslash.html
* platform/KURL.cpp: (WebCore::KURL::init): Don't do backslash
substitution in JavaScript URLs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 11 Sep 2006 17:11:59 +0000 (17:11 +0000)]
Reviewed by Darin and Tim H.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10792
Remove the [Exclude=LANGUAGE] idiom from IDL's and code generators
for something better
- Replaces [Exclude=LANGUAGE] idiom with preprocessor #if defined(LANGUAGE)
idiom.
- Assorted whitespace changes to IDL files.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMEvents.h:
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* css/CSSRule.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSValue.idl:
* dom/DOMImplementation.idl:
* dom/Document.idl:
* dom/Element.idl:
* dom/Event.idl:
* dom/KeyboardEvent.idl:
* dom/MouseEvent.idl:
* dom/NamedNodeMap.idl:
* dom/NodeFilter.idl:
* dom/UIEvent.idl:
* dom/WheelEvent.idl:
* html/HTMLAnchorElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLLinkElement.idl:
* html/HTMLOptionsCollection.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 11 Sep 2006 14:49:40 +0000 (14:49 +0000)]
- converted a test to plain text (makes it platform independent; fixes a failure)
* fast/events/ondragenter-expected.checksum: Removed.
* fast/events/ondragenter-expected.png: Removed.
* fast/events/ondragenter-expected.txt:
* fast/events/ondragenter.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 11 Sep 2006 07:28:03 +0000 (07:28 +0000)]
Fix an unwitting victim of the kMin->min change. calcBlockMinMaxWidth
was accidentally renamed to calcBlominMaxWidth.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcMinMaxWidth):
(WebCore::RenderBlock::calcBlockMinMaxWidth):
* rendering/RenderBlock.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 11 Sep 2006 06:37:18 +0000 (06:37 +0000)]
Rework the printer font stuff a little bit so that the Font API doesn't
have to be changed.
Reviewed by eseidel
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/WebCoreStringTruncator.mm:
(truncateString):
(+[WebCoreStringTruncator widthOfString:font:]):
* platform/Font.cpp:
(WebCore::Font::drawSimpleText):
* platform/Font.h:
* platform/TextStyle.h:
(WebCore::TextStyle::TextStyle):
(WebCore::TextStyle::attemptFontSubstitution):
(WebCore::TextStyle::setRTL):
* platform/mac/FontMac.mm:
(WebCore::m_wordSpacing):
(WebCore::Font::drawGlyphs):
* platform/mac/ListBoxMac.mm:
(itemTextRenderer):
(groupLabelTextRenderer):
(-[WebCoreTableView drawRow:clipRect:]):
* platform/mac/PopUpButtonMac.mm:
(PopUpButton::sizeHint):
* platform/mac/TextFieldMac.mm:
(-[NSSearchFieldCell _addStringToRecentSearches:]):
* platform/mac/WebCoreTextRenderer.mm:
(WebCoreDrawTextAtPoint):
(WebCoreTextFloatWidth):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paint):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 11 Sep 2006 06:16:32 +0000 (06:16 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 11 Sep 2006 05:23:22 +0000 (05:23 +0000)]
Reviewed by Maciej
Added specialized HashTraits
* platform/IntSizeHash.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 11 Sep 2006 02:48:56 +0000 (02:48 +0000)]
- converted a text to plain text (makes it platform independent; fixes a failure)
* fast/text/plain-text-line-breaks-expected.checksum: Removed.
* fast/text/plain-text-line-breaks-expected.png: Removed.
* fast/text/plain-text-line-breaks-expected.txt: Regenerated.
* fast/text/plain-text-line-breaks.html: Added a call to dumpAsText().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 11 Sep 2006 02:26:10 +0000 (02:26 +0000)]
Forgetting header #define protection is
BAAAAAD
(and re-alphabatized the project file)
* WebCore.xcodeproj/project.pbxproj:
* platform/IntSizeHash.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 11 Sep 2006 02:13:05 +0000 (02:13 +0000)]
Reviewed by Maciej
Moved the custom IntSize hash out of IconDatabase into a more generally useful file
* WebCore.xcodeproj/project.pbxproj:
* loader/icon/IconDatabase.h:
* platform/IntSizeHash.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sun, 10 Sep 2006 23:33:22 +0000 (23:33 +0000)]
Land new results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sun, 10 Sep 2006 23:27:16 +0000 (23:27 +0000)]
Fix for bug 10801, form controls that get styled suddenly lose their
intrinsic margins. Move the intrinsic margin addition code into
adjustRenderStyle and get it out of the theme code and the old form control
code.
Reviewed by aroben
* css/cssstyleselector.cpp:
(WebCore::addIntrinsicMargins):
(WebCore::CSSStyleSelector::adjustRenderStyle):
* css/html4.css:
* rendering/DeprecatedRenderSelect.h:
(WebCore::DeprecatedRenderSelect::calcReplacedHeight):
* rendering/DeprecatedSlider.h:
* rendering/RenderFormElement.cpp:
(WebCore::RenderFormElement::setStyle):
* rendering/RenderFormElement.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustButtonStyle):
(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustButtonStyle):
(WebCore::RenderThemeWin::adjustTextFieldStyle):
(WebCore::RenderThemeWin::adjustTextAreaStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 10 Sep 2006 20:22:03 +0000 (20:22 +0000)]
Reviewed by Brady.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10547
REGRESSION: Links that should open in a new window open in the same window,
while opening another blank window
* WebView/WebFrame.m:
(-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
Changed a mistaken "self" to "frame", which was the cause of the bug. Also
fixed the method so that it won't crash if createWebViewWithRequest does
something that has a side effect of releasing this WebView or this frame
by retaining "self" and "frame" as needed. Also fixed a problem where the
code to set "opener" was backwards, and would set the opener of the old
frame to point to the new frame instead of vice versa.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 10 Sep 2006 20:21:42 +0000 (20:21 +0000)]
- test for bugzilla.opendarwin.org/show_bug.cgi?id=10547
* manual-tests/target-test.html: Added.
* manual-tests/targeted.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sun, 10 Sep 2006 19:53:41 +0000 (19:53 +0000)]
2006-09-10 Eric Seidel <eric@eseidel.com>
Reviewed by darin.
Remove a bunch more NSGraphicsContext related code.
Add a LocalCurrentGraphicsContext to simplify methods which need to call up into AppKit controls (and thus depend on the [NSGraphicsContext currentContext] being set correctly)
Add an "isPrinting" flag to many of the text drawing functions in order to avoid the need for a GraphicsContext::isPrinting() function.
No tests were harmed in the making of this patch.
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge drawRect:]):
* kcanvas/device/quartz/KRenderingDeviceQuartz.h:
(WebCore::KRenderingDeviceContextQuartz::cgContext):
(WebCore::KRenderingDeviceQuartz::isBuffered):
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
(WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz):
(WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz):
* kcanvas/device/quartz/QuartzSupport.mm:
* platform/Font.cpp:
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawText):
* platform/Font.h:
* platform/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawText):
* platform/GraphicsContext.h:
* platform/mac/FileButtonMac.mm:
(-[WebFileChooserButton drawRect:]):
* platform/mac/FontMac.mm:
(WebCore::ATSULayoutParameters::ATSULayoutParameters):
(WebCore::ATSULayoutParameters::initialize):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawGlyphs):
* platform/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForMisspelling):
* platform/mac/ListBoxMac.mm:
(-[WebCoreTableView drawRow:clipRect:]):
* platform/mac/WebCoreTextRenderer.mm:
(WebCoreDrawTextAtPoint):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paint):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/RenderThemeMac.mm:
(WebCore::WebCoreNSGraphicsContextBridge::WebCoreNSGraphicsContextBridge):
(WebCore::WebCoreNSGraphicsContextBridge::~WebCoreNSGraphicsContextBridge):
(WebCore::RenderThemeMac::paintButton):
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::paintTextArea):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sun, 10 Sep 2006 18:17:06 +0000 (18:17 +0000)]
Reviewed and landed by ap.
Fix QtLauncher - it is supposed to create a FrameView on its own nowadays.
* QtLauncher/main.cpp:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sun, 10 Sep 2006 07:41:44 +0000 (07:41 +0000)]
2006-09-09 Steve Falkenburg <sfalken@apple.com>
Reviewed by aroben.
Fixes to work with string API changes.
* platform/cf/ResourceLoaderCFNet.cpp:
(WebCore::arrayFromFormData):
(WebCore::ResourceLoader::start):
* platform/cf/StringCF.cpp:
* platform/cf/StringImplCF.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sun, 10 Sep 2006 07:40:09 +0000 (07:40 +0000)]
2006-09-09 Steve Falkenburg <sfalken@apple.com>
Reviewed by aroben.
Add missing copy command.
Support finding icu headers in multiple locations.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sun, 10 Sep 2006 05:52:52 +0000 (05:52 +0000)]
Add test for textarea scrollwidth and height.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sun, 10 Sep 2006 05:47:22 +0000 (05:47 +0000)]
Add layout test for bug 10719.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sun, 10 Sep 2006 05:37:32 +0000 (05:37 +0000)]
Fix for Bugzilla bug 5500, scrollLeft/Top/Width/Height properties not supported
on textarea. Refactored the DOM getters and setters to go through the renderer
instead of right to the layer. The renderer functions are virtual so that the
text control can subclass and forward to its anonymous div.
Fix for Bugzilla bug 10719, When positioned objects are sizing using their
containing block width as a guide, they should not ever use the line width like
non-positioned objects do.
Reviewed by aroben
* WebCore.xcodeproj/project.pbxproj:
* dom/Element.cpp:
(WebCore::Element::scrollLeft):
(WebCore::Element::scrollTop):
(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockWidthForPositioned):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::clientWidth):
(WebCore::RenderObject::clientHeight):
(WebCore::RenderObject::scrollWidth):
(WebCore::RenderObject::scrollHeight):
(WebCore::RenderObject::scrollLeft):
(WebCore::RenderObject::scrollTop):
(WebCore::RenderObject::setScrollLeft):
(WebCore::RenderObject::setScrollTop):
(WebCore::RenderObject::hasStaticX):
(WebCore::RenderObject::hasStaticY):
* rendering/RenderObject.h:
(WebCore::RenderObject::clientLeft):
(WebCore::RenderObject::clientTop):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::scrollWidth):
(WebCore::RenderTextControl::scrollHeight):
(WebCore::RenderTextControl::scrollLeft):
(WebCore::RenderTextControl::scrollTop):
(WebCore::RenderTextControl::setScrollLeft):
(WebCore::RenderTextControl::setScrollTop):
* rendering/RenderTextControl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sun, 10 Sep 2006 04:55:03 +0000 (04:55 +0000)]
Implement support for the WinIE clientLeft and clientTop extensions.
Reviewed by aroben
* dom/Element.cpp:
(WebCore::Element::clientLeft):
(WebCore::Element::clientTop):
* dom/Element.h:
* dom/Element.idl:
* rendering/RenderObject.h:
(WebCore::RenderObject::clientLeft):
(WebCore::RenderObject::clientTop):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sun, 10 Sep 2006 02:36:36 +0000 (02:36 +0000)]
WebCore:
Reviewed by Eric.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
Auto-generate the Objective-C DOM XPath bindings
- Auto-generates DOMXPathExpression, DOMXPathNSResolver and DOMXPathResult.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMPrivate.h:
* bindings/objc/DOMXPath.h:
* bindings/objc/DOMXPath.mm:
* bindings/objc/PublicDOMInterfaces.h:
* xml/XPathExpression.idl:
* xml/XPathNSResolver.idl:
* xml/XPathResult.idl:
WebKit:
Reviewed by Eric.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
Auto-generate the Objective-C DOM XPath bindings
* MigrateHeaders.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sat, 9 Sep 2006 22:05:58 +0000 (22:05 +0000)]
WebCore:
Reviewed by Eric.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup
- Auto-generate some remaining extension methods for DOMDocument
and DOMCSSStyleDeclaration.
- Split DOMHTMLEmbedElement into it's own files. It can't be
auto-generated yet because the Objective-C interface is significantly
different from the implementation interface. Since HTMLEmbedElement
is not in the W3C spec, this is somewhat of a gray area.
- Auto-generate DOMEventListener protocol.
- Clean up the IDL files by separating the extensions from the
specified methods and attributes.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
* bindings/objc/DOMCSS.mm:
* bindings/objc/DOMEventListener.h: Removed.
* bindings/objc/DOMExtensions.h:
* bindings/objc/DOMHTML.h:
* bindings/objc/DOMHTML.mm:
* bindings/objc/DOMHTMLEmbedElement.h: Added.
* bindings/objc/DOMHTMLEmbedElement.mm: Added.
(-[DOMHTMLEmbedElement align]):
(-[DOMHTMLEmbedElement setAlign:]):
(-[DOMHTMLEmbedElement height]):
(-[DOMHTMLEmbedElement setHeight:]):
(-[DOMHTMLEmbedElement name]):
(-[DOMHTMLEmbedElement setName:]):
(-[DOMHTMLEmbedElement src]):
(-[DOMHTMLEmbedElement setSrc:]):
(-[DOMHTMLEmbedElement type]):
(-[DOMHTMLEmbedElement setType:]):
(-[DOMHTMLEmbedElement width]):
(-[DOMHTMLEmbedElement setWidth:]):
* bindings/objc/DOMPrivate.h:
* bindings/objc/PublicDOMInterfaces.h:
* css/CSSStyleDeclaration.idl:
* dom/Document.idl:
* dom/KeyboardEvent.h:
* dom/KeyboardEvent.idl:
* dom/MouseEvent.idl:
* dom/MutationEvent.idl:
* dom/OverflowEvent.idl:
* dom/UIEvent.idl:
* dom/WheelEvent.idl:
* html/HTMLEmbedElement.idl: Added.
WebKit:
Reviewed by Eric.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup
* MigrateHeaders.make:
WebKitTools:
Reviewed by Eric.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup
- Change to use new, more Objectice-C'ish version of
DOMKeyboardEvent's initKeyboardEvent. Fixes an error with
regression test for fast/events/dblclick-addEventListener.html.
* DumpRenderTree/EventSendingController.m:
(-[EventSendingController fireKeyboardEventsToElement:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sat, 9 Sep 2006 20:29:41 +0000 (20:29 +0000)]
2006-09-09 Eric Seidel <eric@eseidel.com>
Reviewed by Tim H.
Remove DeprecatedString usage and fix style.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10787
No tests were harmed in the making of this patch.
* kcanvas/KCanvasFilters.cpp:
(WebCore::KCanvasFilterEffect::in):
(WebCore::KCanvasFilterEffect::setIn):
(WebCore::KCanvasFilterEffect::result):
(WebCore::KCanvasFilterEffect::setResult):
(WebCore::KCanvasFEMerge::externalRepresentation):
* kcanvas/KCanvasFilters.h:
(WebCore::KCanvasFEBlend::in2):
(WebCore::KCanvasFEBlend::setIn2):
(WebCore::KCanvasFEComposite::in2):
(WebCore::KCanvasFEComposite::setIn2):
(WebCore::KCanvasFEDisplacementMap::in2):
(WebCore::KCanvasFEDisplacementMap::setIn2):
(WebCore::KCanvasFEMerge::mergeInputs):
(WebCore::KCanvasFEMerge::setMergeInputs):
* kcanvas/KCanvasResources.cpp:
(WebCore::KCanvasResource::idInRegistry):
(WebCore::KCanvasResource::setIdInRegistry):
(WebCore::getResourceById):
* kcanvas/KCanvasResources.h:
* kcanvas/RenderPath.cpp:
(WebCore::RenderPath::getAbsoluteRepaintRect):
(WebCore::RenderPath::paint):
(WebCore::RenderPath::drawMarkersIfNeeded):
* kcanvas/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
(WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
* kcanvas/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
(WebCore::RenderSVGImage::getAbsoluteRepaintRect):
* kcanvas/RenderSVGText.cpp:
(WebCore::RenderSVGText::paint):
* kcanvas/device/KRenderingPaintServer.h:
(WebCore::KRenderingPaintServer::idInRegistry):
(WebCore::KRenderingPaintServer::setIdInRegistry):
* kcanvas/device/quartz/KCanvasFilterQuartz.h:
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(WebCore::KCanvasFilterQuartz::imageForName):
(WebCore::KCanvasFilterQuartz::setImageForName):
(WebCore::KCanvasFEMergeQuartz::getCIFilter):
* ksvg2/css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* ksvg2/css/SVGRenderStyle.cpp:
* ksvg2/css/SVGRenderStyle.h:
* ksvg2/css/SVGRenderStyleDefs.h:
* ksvg2/ecma/GlobalObject.cpp:
(GlobalObject::get):
* ksvg2/misc/KSVGTimeScheduler.cpp:
(WebCore::SVGTimer::notifyAll):
* ksvg2/svg/SVGDescElement.cpp:
(WebCore::SVGDescElement::SVGDescElement):
(WebCore::SVGDescElement::description):
* ksvg2/svg/SVGDescElement.h:
* ksvg2/svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::SVGFEBlendElement):
(WebCore::SVGFEBlendElement::filterEffect):
* ksvg2/svg/SVGFEColorMatrixElement.cpp:
(SVGFEColorMatrixElement::SVGFEColorMatrixElement):
(SVGFEColorMatrixElement::filterEffect):
* ksvg2/svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
(WebCore::SVGFEComponentTransferElement::filterEffect):
* ksvg2/svg/SVGFECompositeElement.cpp:
(SVGFECompositeElement::SVGFECompositeElement):
(SVGFECompositeElement::filterEffect):
* ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
(WebCore::SVGFEDiffuseLightingElement::filterEffect):
* ksvg2/svg/SVGFEDisplacementMapElement.cpp:
(SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
(SVGFEDisplacementMapElement::filterEffect):
* ksvg2/svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::SVGFEFloodElement):
(WebCore::SVGFEFloodElement::filterEffect):
* ksvg2/svg/SVGFEGaussianBlurElement.cpp:
(SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
(SVGFEGaussianBlurElement::filterEffect):
* ksvg2/svg/SVGFELightElement.cpp:
* ksvg2/svg/SVGFEMergeElement.cpp:
(SVGFEMergeElement::filterEffect):
* ksvg2/svg/SVGFEOffsetElement.cpp:
(SVGFEOffsetElement::SVGFEOffsetElement):
(SVGFEOffsetElement::filterEffect):
* ksvg2/svg/SVGFESpecularLightingElement.cpp:
(SVGFESpecularLightingElement::SVGFESpecularLightingElement):
(SVGFESpecularLightingElement::filterEffect):
* ksvg2/svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::SVGFETileElement):
(WebCore::SVGFETileElement::filterEffect):
* ksvg2/svg/SVGFETurbulenceElement.cpp:
(SVGFETurbulenceElement::SVGFETurbulenceElement):
* ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
(SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
* ksvg2/svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseViewBox):
(WebCore::SVGFitToViewBox::parseMappedAttribute):
* ksvg2/svg/SVGFitToViewBox.h:
* ksvg2/svg/SVGLinearGradientElement.cpp:
(SVGLinearGradientElement::buildGradient):
* ksvg2/svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
(WebCore::SVGPatternElement::notifyAttributeChange):
* ksvg2/svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
(WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
(WebCore::SVGPreserveAspectRatio::getCTM):
* ksvg2/svg/SVGPreserveAspectRatio.h:
* ksvg2/svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::buildGradient):
* ksvg2/svg/SVGStyleElement.cpp:
* ksvg2/svg/SVGStyledTransformableElement.cpp:
* ksvg2/svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::SVGViewElement):
(WebCore::SVGViewElement::parseMappedAttribute):
* ksvg2/svg/SVGZoomAndPan.cpp:
(WebCore::SVGZoomAndPan::SVGZoomAndPan):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 9 Sep 2006 15:35:26 +0000 (15:35 +0000)]
LayoutTests:
Adds a test for the CSS URL quoting logic.
* fast/inspector/cssURLQuotes-expected.txt: Added.
* fast/inspector/cssURLQuotes.html: Added.
WebCore:
Reviewed by Tim H.
<rdar://problem/
4699166> REGRESSION: Background images in Mail stationery do not load
Fixes the quoting logic. The previous logic did not account for the
CSS tokenizer's regex character range between * and ~ as valid in URL types.
* css/CSSPrimitiveValue.cpp:
(WebCore::isCSSTokenizerURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 9 Sep 2006 10:54:57 +0000 (10:54 +0000)]
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10759
fast/AppleScript/array.html test failing
WebCore:
* bridge/mac/WebCoreFrameBridge.mm:
(aeDescFromJSValue): Convert integer values to typeSInt32 AE descriptors.
LayoutTests:
* fast/AppleScript/001-expected.txt: Updated results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sat, 9 Sep 2006 01:56:22 +0000 (01:56 +0000)]
2006-09-08 Eric Seidel <eric@eseidel.com>
Reviewed by darin.
Replace incorrect fooBaseValue() calls with foo() calls instead.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10746
With the previously broken animation system, we had both base and anim values
but they were not automatically connected/disconnected when animation started and stopped.
So the animVals were basically never used (since they were always wrong).
Now, animVal and baseVal are handled correctly.
There are only 3 places in the code where we will ever need to use the BaseValue accessor variants.
1. SVGAnimated* DOM bindings
2. Animation Code
3. parseMappedAttribute implementations
* kcanvas/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::translationForAttributes):
* kcanvas/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
(WebCore::RenderSVGImage::relativeBBox):
(WebCore::RenderSVGImage::getAbsoluteRepaintRect):
(WebCore::RenderSVGImage::translationForAttributes):
* kcanvas/RenderSVGText.cpp:
(WebCore::RenderSVGText::translationForAttributes):
* ksvg2/misc/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::updateFromElement):
* ksvg2/svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
* ksvg2/svg/SVGCircleElement.cpp:
(SVGCircleElement::parseMappedAttribute):
(SVGCircleElement::toPathData):
(SVGCircleElement::pushAttributeContext):
(SVGCircleElement::hasPercentageValues):
* ksvg2/svg/SVGClipPathElement.cpp:
(SVGClipPathElement::canvasResource):
* ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
(SVGComponentTransferFunctionElement::transferFunction):
* ksvg2/svg/SVGCursorElement.cpp:
(SVGCursorElement::parseMappedAttribute):
* ksvg2/svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::parseMappedAttribute):
(WebCore::SVGEllipseElement::toPathData):
(WebCore::SVGEllipseElement::pushAttributeContext):
(WebCore::SVGEllipseElement::hasPercentageValues):
* ksvg2/svg/SVGFEBlendElement.cpp:
(SVGFEBlendElement::filterEffect):
* ksvg2/svg/SVGFEColorMatrixElement.cpp:
(SVGFEColorMatrixElement::filterEffect):
* ksvg2/svg/SVGFEComponentTransferElement.cpp:
(SVGFEComponentTransferElement::filterEffect):
* ksvg2/svg/SVGFECompositeElement.cpp:
(SVGFECompositeElement::filterEffect):
* ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::filterEffect):
* ksvg2/svg/SVGFEDisplacementMapElement.cpp:
(SVGFEDisplacementMapElement::filterEffect):
* ksvg2/svg/SVGFEDistantLightElement.cpp:
(WebCore::SVGFEDistantLightElement::lightSource):
* ksvg2/svg/SVGFEFloodElement.cpp:
(SVGFEFloodElement::filterEffect):
* ksvg2/svg/SVGFEGaussianBlurElement.cpp:
(SVGFEGaussianBlurElement::filterEffect):
* ksvg2/svg/SVGFEImageElement.cpp:
(SVGFEImageElement::parseMappedAttribute):
* ksvg2/svg/SVGFEMergeElement.cpp:
(SVGFEMergeElement::SVGFEMergeElement):
(SVGFEMergeElement::filterEffect):
* ksvg2/svg/SVGFEOffsetElement.cpp:
(SVGFEOffsetElement::filterEffect):
* ksvg2/svg/SVGFEPointLightElement.cpp:
(WebCore::SVGFEPointLightElement::SVGFEPointLightElement):
(WebCore::SVGFEPointLightElement::lightSource):
* ksvg2/svg/SVGFESpecularLightingElement.cpp:
(SVGFESpecularLightingElement::filterEffect):
* ksvg2/svg/SVGFESpotLightElement.cpp:
(WebCore::SVGFESpotLightElement::lightSource):
* ksvg2/svg/SVGFETileElement.cpp:
(SVGFETileElement::filterEffect):
* ksvg2/svg/SVGFETurbulenceElement.cpp:
(SVGFETurbulenceElement::filterEffect):
* ksvg2/svg/SVGFilterElement.cpp:
(SVGFilterElement::canvasResource):
* ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
(SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
* ksvg2/svg/SVGGradientElement.cpp:
(SVGGradientElement::rebuildStops):
* ksvg2/svg/SVGHelper.cpp:
(WebCore::SVGHelper::PercentageOfViewport):
* ksvg2/svg/SVGLineElement.cpp:
(SVGLineElement::toPathData):
(SVGLineElement::pushAttributeContext):
(SVGLineElement::hasPercentageValues):
* ksvg2/svg/SVGLinearGradientElement.cpp:
(SVGLinearGradientElement::buildGradient):
* ksvg2/svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::canvasResource):
* ksvg2/svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::attributeChanged):
(WebCore::SVGMaskElement::drawMaskerContent):
* ksvg2/svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::pushAttributeContext):
(WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
(WebCore::SVGPatternElement::drawPatternContentIntoTile):
(WebCore::SVGPatternElement::notifyAttributeChange):
(WebCore::SVGPatternElement::getCTM):
* ksvg2/svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::buildGradient):
* ksvg2/svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::toPathData):
(WebCore::SVGRectElement::pushAttributeContext):
(WebCore::SVGRectElement::hasPercentageValues):
* ksvg2/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::viewport):
(WebCore::SVGSVGElement::parseMappedAttribute):
(WebCore::SVGSVGElement::getCTM):
(WebCore::SVGSVGElement::getScreenCTM):
(WebCore::SVGSVGElement::createRenderer):
* ksvg2/svg/SVGTRefElement.cpp:
(SVGTRefElement::updateReferencedText):
* ksvg2/svg/SVGUseElement.cpp:
(SVGUseElement::closeRenderer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sat, 9 Sep 2006 01:46:18 +0000 (01:46 +0000)]
2006-09-08 Eric Seidel <eric@eseidel.com>
Reviewed by beth.
Remove the last vestiges of KDOM (KDOMCSSValue and KDOMCSSValueList)
http://bugzilla.opendarwin.org/show_bug.cgi?id=10778
* ksvg2/css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
(WebCore::CSSParser::parseSVGStrokeDasharray):
(WebCore::CSSParser::parseSVGPaint):
(WebCore::CSSParser::parseSVGColor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Sat, 9 Sep 2006 01:35:04 +0000 (01:35 +0000)]
Reviewed by Brady Eidson.
Rolled out Maciej's code cleanup from 8/22. It turns out that keeping the "loading" flag
is a useful optimization, as it avoids many Objective-C method calls while polling resources
for their load state.
This fixes a 3-4% PLT performance regression (as measured on my MacBook Pro).
* Loader/WebFrameLoader.m:
(-[WebFrameLoader addPlugInStreamLoader:]):
(-[WebFrameLoader removePlugInStreamLoader:]):
(-[WebFrameLoader addSubresourceLoader:]):
(-[WebFrameLoader removeSubresourceLoader:]):
* WebView/WebDataSource.m:
(-[WebDataSourcePrivate dealloc]):
(-[WebDataSource _prepareForLoadStart]):
(-[WebDataSource _setLoading:]):
(-[WebDataSource _updateLoading]):
(-[WebDataSource _startLoading]):
(-[WebDataSource _stopLoading]):
(-[WebDataSource _setPrimaryLoadComplete:]):
(-[WebDataSource isLoading]):
* WebView/WebDataSourceInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Sat, 9 Sep 2006 00:11:01 +0000 (00:11 +0000)]
Reviewed by Adel.
- this patch brought to you by the letter 'c'
* coding/coding-style.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Sep 2006 22:06:21 +0000 (22:06 +0000)]
WebCore:
Reviewed by Darin and Tim H.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10774
Auto-generate the Objective-C DOM Traversal bindings
- Auto-generates DOMNodeIterator and DOMTreeWalker.
- Splits out DOMNodeFilter into its own file.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
* bindings/objc/DOMNodeFilter.h: Added.
* bindings/objc/DOMTraversal.h:
* bindings/objc/PublicDOMInterfaces.h:
* bindings/scripts/CodeGeneratorObjC.pm:
* dom/NodeFilter.idl:
* dom/NodeIterator.idl:
* dom/Range.idl:
* dom/TreeWalker.idl:
WebKit:
Reviewed by Darin and Tim H.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10774
Auto-generate the Objective-C DOM Traversal bindings
* MigrateHeaders.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 7 Sep 2006 18:45:10 +0000 (18:45 +0000)]
2006-09-07 MorganL <morlmor@yahoo.com>
Reviewed by Darin, landed by Adam.
Fixes part of bug 10743: Windows build busted.
* platform/win/FontCacheWin.cpp: Add missing #include, set svn:eol-style to native
(WebCore::FontCache::getFontLinkInterface):
(WebCore::FontCache::getFontDataForCharacters):
* platform/win/FontDataWin.cpp: Ditto.
(WebCore::FontData::platformWidthForGlyph):
* platform/win/FontWin.cpp: Add missing #include, band-aid over const problem with GlyphBufferGlyph
(WebCore::Font::drawGlyphs):
* platform/win/ResourceLoaderWin.cpp: Add missing #include, change .ascii() to .latin1()
(WebCore::ResourceLoaderWndProc):
(WebCore::ResourceLoader::start):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 7 Sep 2006 17:37:13 +0000 (17:37 +0000)]
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10753
REGRESSION: The beginning of a CSS file is missing
Test: http/tests/incremental/slow-utf8-css.pl
* loader/Decoder.cpp:
(WebCore::Decoder::checkForCSSCharset): Use the same buffering logic as used for HTML.
(WebCore::Decoder::decode):
* loader/Decoder.h: Added a return value and a movedDataToBuffer parameter to
checkForCSSCharset().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Sep 2006 17:08:48 +0000 (17:08 +0000)]
WebCore:
Reviewed by Darin.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10766
Auto-generate the Objective-C DOM Events bindings
- Auto-generates DOMEvent, DOMKeyboardEvent, DOMMouseEvent, DOMMutationEvent,
DOMOverflowEvent, DOMUIEvent, and DOMWheelEvent.
- Splits out DOMEventListener and DOMEventTarget into their own files.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMEventListener.h: Added.
* bindings/objc/DOMEventTarget.h: Added.
* bindings/objc/DOMEvents.h:
* bindings/objc/DOMEvents.mm:
(-[DOMEvent WebCore::]):
(-[DOMEvent _initWithEvent:WebCore::]):
(+[DOMEvent _eventWith:WebCore::]):
* bindings/objc/DOMEventsNonstandard.mm: Removed.
* bindings/objc/DOMNode.h:
* bindings/objc/PublicDOMInterfaces.h:
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* dom/Event.idl:
* dom/EventListener.idl: Added.
* dom/EventTarget.idl: Added.
* dom/KeyboardEvent.idl:
* dom/MouseEvent.idl:
* dom/UIEvent.idl:
* dom/WheelEvent.idl:
WebKit:
Reviewed by Darin.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10766
Auto-generate the Objective-C DOM Events bindings
* MigrateHeaders.make:
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Thu, 7 Sep 2006 09:03:24 +0000 (09:03 +0000)]
WebCore:
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9753
SVG with width and height 100% leaves room for scrollbar on the right.
Relayout children of svg containers, except svg shapes that do not depend on percentages.
LayoutTests:
Reviewed by Maciej.
New test case for
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9753>
SVG with width and height 100% leaves room for scrollbar on the right.
Also Updated .txt files (all text blocks are wider) and some updated
pixel tests (some text is layouted differently because of wider text blocks).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Thu, 7 Sep 2006 01:00:11 +0000 (01:00 +0000)]
Updated usage of a constant that got renamed
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 6 Sep 2006 23:41:28 +0000 (23:41 +0000)]
Reviewed by Tim Hatcher.
- fix crashes affecting editing layout tests (regressions from my vector change)
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply): Added check for empty vector.
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 6 Sep 2006 21:39:07 +0000 (21:39 +0000)]
More renaming plans.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 6 Sep 2006 18:31:16 +0000 (18:31 +0000)]
Reviewed and tweaked by Tim H.
<rdar://problem/
4564955> WebKit doesn't trigger Auto Font Activation
If we don't find the font in the available fonts list, call [NSFont fontWithName:size:]
to trigger a search that will include auto activation. No PLT or iBench perf impact.
No layout tests affected. Not testable in an automated way that will work on all systems.
* platform/mac/WebFontCache.mm:
(+[WebFontCache fontWithFamily:traits:size:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 6 Sep 2006 17:17:42 +0000 (17:17 +0000)]
2006-09-06 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by ap.
Fix Qt/Linux build.
* CMakeLists.txt: Take out CharacterData.cpp from build / add new Text* files to build.
* platform/qt/BrowserExtensionQt.cpp: Add wtf/Platform.h include.
* platform/qt/FontCacheQt.cpp: Add FontData.h include.
* platform/qt/FontQt.cpp:
(WebCore::Font::drawGlyphs): Fix constness in reinterpret_cast.
* platform/qt/FrameQt.cpp:
(WebCore::FrameQt::markMisspellings): Change "SelectionController" param type to "Selection".
(WebCore::FrameQt::respondToChangedSelection): Ditto.
(WebCore::FrameQt::respondToChangedContents): Ditto.
(WebCore::FrameQt::shouldChangeSelection): Ditto.
* platform/qt/FrameQt.h: Ditto.
* platform/qt/ImageQt.cpp:
(WebCore::Image::supportsType): Fix String->QString conversion.
* platform/qt/ResourceLoaderManager.cpp:
(WebCore::ResourceLoaderManager::add): Fix String->DeprecatedString conversion.
* platform/qt/ScrollViewCanvasQt.cpp:
(WebCore::ScrollViewCanvasQt::handleKeyEvent): Adapt to SelectionController signature changes.
* platform/qt/qt-encodings.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 6 Sep 2006 16:23:32 +0000 (16:23 +0000)]
Reviewed by Tim Hatcher.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10675
tweak font-related headers and convert lists to vectors
One major change was to greatly reduce the number of files that include Font.h.
Another was to convert many uses of DeprecatedPtrList/DeprecatedValueList to Vector.
* WebCore.xcodeproj/project.pbxproj: Added TextStyle.h.
* bindings/objc/DOM.mm: (-[DOMElement _font]): Changed to not depend on
Font::getNSFont since a WebCore::Font represents more than one NSFont.
* bindings/objc/DOMNode.mm: (-[DOMNode lineBoxRects]): Updated to use Vector.
* bridge/mac/FormDataMac.mm: (WebCore::arrayFromFormData): Ditto.
* bridge/mac/FrameViewMac.mm: (WebCore::FrameView::updateDashboardRegions): Ditto.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
* dom/Document.cpp:
(WebCore::Document::dashboardRegions): Ditto.
(WebCore::Document::setDashboardRegions): Ditto.
* dom/Document.h: Ditto.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::removeUnrenderedNodes): Ditto.
* html/FormDataList.h: Ditto.
* html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isFocusable): Ditto.
* html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Ditto.
* kcanvas/RenderPath.cpp: (WebCore::RenderPath::absoluteRects): Ditto.
* kcanvas/RenderPath.h: Ditto.
* kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::absoluteRects): Ditto.
* kcanvas/RenderSVGImage.h: Ditto.
* kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): Ditto.
* kcanvas/RenderSVGText.h: Ditto.
* loader/FormData.cpp:
(WebCore::FormData::flatten): Ditto.
(WebCore::FormData::flattenToString): Ditto.
* loader/FormData.h: (WebCore::FormData::elements): Ditto.
* loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): Ditto.
* page/Frame.cpp: (WebCore::Frame::markedTextUnderlines): Ditto.
* page/Frame.h: Ditto.
* page/FramePrivate.h: Ditto.
* platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Ditto.
* rendering/InlineTextBox.h: Ditto.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Ditto.
(WebCore::InlineTextBox::paintMarkedTextUnderline): Ditto.
* rendering/RenderContainer.h: Ditto.
* rendering/RenderContainer.cpp: (WebCore::RenderContainer::lineBoxRects): Ditto.
* rendering/RenderInline.h: Ditto.
* rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): Ditto.
* rendering/RenderObject.h: Ditto.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::lineBoxRects): Ditto.
(WebCore::RenderObject::absoluteRects): Ditto.
(WebCore::RenderObject::absoluteBoundingBoxRect): Ditto.
(WebCore::RenderObject::addDashboardRegions): Ditto.
(WebCore::RenderObject::collectDashboardRegions): Ditto.
* rendering/RenderStyle.h: Ditto.
* rendering/RenderStyle.cpp:
(WebCore::RenderStyle::initialDashboardRegions): Ditto.
(WebCore::RenderStyle::noneDashboardRegions): Ditto.
* rendering/RenderText.h: Ditto.
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRects): Ditto.
(WebCore::RenderText::lineBoxRects): Ditto.
* rendering/RenderView.h: Ditto.
* rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects): Ditto.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::attributedString): Updated to use Vector and changed to not
depend on getNSFont on a Font.
(WebCore::FrameMac::fontForSelection): Changed to not depend on Font::getNSFont.
(WebCore::FrameMac::fontAttributesForSelectionStart): Ditto.
(WebCore::convertAttributesToUnderlines): Updated to use Vector.
(WebCore::FrameMac::setMarkedTextRange): Ditto.
(WebCore::FrameMac::dashboardRegionsDictionary): Ditto.
* bridge/mac/WebCoreAXObject.mm:
(boundingBoxRect): Updated to use Vector.
(AXAttributeStringSetStyle): Changed to not depend on Font::getNSFont.
* bridge/mac/WebCoreStringTruncator.mm: Updated includes.
* page/Settings.h: Ditto.
* platform/mac/WebCoreTextRenderer.mm: Ditto.
* rendering/EllipsisBox.cpp: Ditto.
* editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
Updated to use a Vector that we iterate in reverse order instead of a linked list
that we reverse by prepending elements instead of adding to the end.
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
* loader/DocLoader.h: Removed unneeded include of DeprecatedPtrList.h.
* platform/Font.h: Moved TextStyle to a separate header. Removed Font::getNSFont.
* platform/Font.cpp: Changed to use const instead of #define.
(WebCore::Font::width): Overloaded this so we don't have a default parameter, which
eliminates the need to have TextStyle defined to compiler the Font.h header.
* platform/TextStyle.h: Added.
* platform/FontData.h: Added a forward declaration of ATSUStyle so this header
can stand alone.
* platform/FontFallbackList.h: Tweaks.
* platform/FontFallbackList.cpp: Tweaks.
* platform/FontFamily.h: Removed unneeded NSString declaration. Simplified class by
using Shared and RefPtr, which resulted in removing many explicit functions.
* platform/FontFamily.cpp: More of the same.
* platform/GlyphBuffer.h: Removed unneeded MAX_GLYPH_EXPANSION and GLYPH_BUFFER_SIZE
macros.
* platform/GlyphMap.h: Removed unneeded include of GlyphBuffer.h, which was included
only for the typedef of Glyph; there's no reason to not just repeat that typedef here
since C++ allows multiple typedefs if they match. Renamed the cGlyphPageSize constant
to GlyphPage::size.
* platform/GlyphMap.cpp: Changed NO_BREAK_SPACE and ZERO_WIDTH_SPACE macros into
constants. Updated for cGlyphPageSize change.
* platform/mac/GlyphMapMac.cpp: Updated for cGlyphPageSize change.
* platform/GlyphWidthMap.h: Removed unneeded include of GlyphBuffer.h, which was included
only for the typedef of Glyph; there's no reason to not just repeat that typedef here
since C++ allows multiple typedefs if they match. Renamed the cGlyphWidthPageSize constant
to GlyphWidthPage::size.
* platform/GlyphWidthMap.cpp: Updated for cGlyphWidthPageSize change.
* platform/GraphicsContext.h: Removed unneeded include of Font.h. Changed drawText
function to use overloading instead of default parameters to allow TextStyle to be optional.
This cuts the dependency on TextStyle.
* platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): Added overload.
* platform/Image.h: Removed unneeded forward declaration of IntSize.
* platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters):
Changed to not depend on Font::getNSFont.
* platform/mac/ListBoxMac.mm: (-[WebCoreTableView fontChanged]): Ditto.
* platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
Ditto.
* rendering/RenderPopupMenuMac.mm:
(WebCore::RenderPopupMenuMac::showPopup): Ditto.
(WebCore::RenderPopupMenuMac::addGroupLabel): Ditto.
(WebCore::RenderPopupMenuMac::addOption): Ditto.
* platform/mac/FontDataMac.mm: Fixed includes. Converted a bunch of macros to be
constants and inline functions instead.
* platform/mac/FontMac.mm: Fixed includes.
* platform/mac/PopUpButtonMac.mm: Ditto.
* rendering/RenderMenuList.cpp: Ditto.
* rendering/RenderTextControl.cpp: Ditto.
* platform/mac/WebCoreSystemInterface.h: Fixes so this header stands alone and is
compatible with all 4 of C, ObjC, C++, ObjC++.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 6 Sep 2006 16:11:13 +0000 (16:11 +0000)]
* MigrateHeaders.make: Fixed a double slash in
"$(PRIVATE_HEADERS_DIR)//DOMCharacterDataPrivate.h" (this was reported
to cause a build failure under certain circumstances).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 6 Sep 2006 07:09:41 +0000 (07:09 +0000)]
2006-09-05 MorganL <morlmor@yahoocom>
Reviewed/landed by aroben.
Fixes bug 10743: Windows build is busted.
WebCore:
* WebCore.vcproj/WebCore/WebCore.vcproj:
* bridge/win/FrameWin.h:
* platform/ResourceLoaderInternal.h:
* platform/TextEncodingRegistry.cpp:
* platform/win/ResourceLoaderWin.cpp:
(WebCore::ResourceLoaderWndProc):
(WebCore::ResourceLoader::start):
* platform/win/TemporaryLinkStubs.cpp:
(FrameWin::markMisspellings):
(FrameWin::shouldChangeSelection):
(FrameWin::respondToChangedSelection):
(FrameWin::respondToChangedContents):
(RenderThemeWin::adjustMenuListStyle):
WebKit:
* COM/WebView.cpp:
(WebView::keyPress):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 6 Sep 2006 06:02:29 +0000 (06:02 +0000)]
- some quick build fixes
* bridge/mac/WebCoreAXObject.mm: Remove use of WebCore::UChar.
* bridge/mac/WebCoreFrameBridge.mm: Ditto. Also remove include
of CharsetNames.h.
* css/CSSGrammar.y: Remove use of WebCore::UChar.
* platform/UChar.h: Back out WebCore::UChar for now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 6 Sep 2006 05:23:11 +0000 (05:23 +0000)]
Reviewed by Darin.
Drastically simplified the makefile for migrating headers from
WebCore and JavaScriptCore. The old version was always copying the files.
* MigrateHeaders.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 6 Sep 2006 04:40:44 +0000 (04:40 +0000)]
LayoutTests:
Reviewed by Alexey.
- test for bug where the charset in a link element for a CSS stylesheet is ignored.
I noticed this while working on new text encoding machinery.
* fast/encoding/css-link-charset-expected.txt: Added.
* fast/encoding/css-link-charset.css: Added.
* fast/encoding/css-link-charset.html: Added.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10681
REGRESSION: Reproducible crash at Wikipedia
(Alexey wrote this one, I reviewed.)
* fast/forms/form-data-encoding-normalization-overrun-expected.txt: Added.
* fast/forms/form-data-encoding-normalization-overrun.html: Added.
- and a tweak to an existing test
* fast/forms/form-data-encoding.html: Changed to dump encoded URL so it's easier to
diagnose this when it fails.
WebCore:
Reviewed by Alexey.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10728
text encodings should work without a numeric ID
- includes a fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10681
REGRESSION: Reproducible crash at Wikipedia
- fixed a bug where link elements would not set the charset properly for
CSS stylesheets they loaded
- converted DeprecatedString code paths that are related to decoding web
pages to use String instead, to ensure that conversion back and forth won't
hurt performance
Test: fast/encoding/css-link-charset.html
Test: fast/forms/form-data-encoding-normalization-overrun.html
Coverage for encoding issues is pretty good, so we probably don't need more
tests to land this. Our existing tests did find issues with this patch while
it was under development. And I suppose it would be nice to have even more tests.
* platform/TextEncoding.h:
* platform/TextEncoding.cpp:
(WebCore::addEncodingName): Added. Used to build up the set used by isJapanese.
(WebCore::TextEncoding::TextEncoding): Removed boolean "eight bit only" parameter and
added an overload for String as well as const char*. Simplified because now the only
data member is m_name -- calls the registry's atomicCanonicalTextEncodingName function
to make the name canonical (resolve aliases) and atomic (use a single pointer for each
encoding name so we can compare and hash efficiently).
(WebCore::TextEncoding::decode): Renamed from toUnicode. Just a simple wrapper on top
of TextDecoder that can be used when the data to decode is all present at once.
(WebCore::TextEncoding::encode): Renamed from fromUnicode. Handles the normalization and
then uses the registry to get a codec to handle the rest.
(WebCore::TextEncoding::usesVisualOrdering): New implementation that compares with the
name of the only encoding that uses visual ordering. We blur the concepts a bit so that
we treat the visual ordering and logical ordering variations as two separate encodings.
(WebCore::TextEncoding::isJapanese): New implementation that uses a set to efficiently
determine if an encoding is Japanese.
(WebCore::TextEncoding::backslashAsCurrencySymbol): New implementation that compares
with the names of the two encodings that have the strange backslash.
(WebCore::TextEncoding::closest8BitEquivalent): Added. Replaces the old "eight bit only"
boolean parameter to the constructor.
(WebCore::ASCIIEncoding): Added.
(WebCore::Latin1Encoding): Added.
(WebCore::UTF16BigEndianEncoding): Added.
(WebCore::UTF16LittleEndianEncoding): Added.
(WebCore::UTF8Encoding): Added.
(WebCore::WindowsLatin1Encoding): Added.
* platform/TextEncodingRegistry.h: Added.
* platform/TextEncodingRegistry.cpp: Added. Keeps a table of all the character set
aliases and names and another of all the codecs and parameters for each name.
* platform/TextDecoder.h: Added.
* platform/TextDecoder.cpp: Added. Contains logic to look for a BOM and hand the data
to the proper codec, based on code that used to be in both the ICU and Mac codecs.
* platform/StreamingTextDecoder.h: Renamed class to TextCodec. We'll rename
the files in a later check-in. Moved creation functions into TextEncodingRegistry.h.
Added typedefs of the registrar function types so classes derived from this one
can use them without including the TextEncodingRegistry header. Renamed toUnicode
and fromUnicode to decode and encode. Changed the parameter and return types so that
the parameters are pointers to the data and the return types are String and CString.
* platform/StreamingTextDecoder.cpp:
(WebCore::TextCodec::appendOmittingBOM): Added. Helper function used by multiple
classes derived from this one.
* platform/TextCodecLatin1.h: Added.
* platform/TextCodecLatin1.cpp: Added. Contains logic to handle encoding and decoding
Windows Latin-1, based on code that used to be in both the ICU and Mac codecs.
* platform/TextCodecUTF16.h: Added.
* platform/TextCodecUTF16.cpp: Added. Contains logic to handle encoding and decoding
UTF-16, based on code that used to be in both the ICU and Mac codecs.
* platform/StreamingTextDecoderICU.h: Renamed class to TextCodecICU. We'll rename
the files in a later check-in. Removed all the functions having to do with handling
BOM, UTF-16, and Latin-1; those are now handled elsewhere. Removed textEncodingSupported
because that's superseded by the registry. Added registry hook functions.
* platform/StreamingTextDecoderICU.cpp:
(WebCore::TextCodecICU::registerEncodingNames): Added. Registers all encodings that
ICU can handle with the "IANA" standard. Also includes a special case for a particular
type of encoding for Hebrew that uses logical ordering. Also includes aliases that are
not in ICU but that were historically known to WebKit for encodings that ICU handles.
(WebCore::newTextCodecICU): Added. Used by registerCodecs.
(WebCore::TextCodecICU::registerCodecs): Added. Registers codecs for the same encodings
as above.
(WebCore::TextCodecICU::TextCodecICU): Much simplified since this now only handles the
actual ICU encoding and decoding.
(WebCore::TextCodecICU::~TextCodecICU): Renamed.
(WebCore::TextCodecICU::releaseICUConverter): Changed to be a const member function.
(WebCore::TextCodecICU::createICUConverter): Changed to be a const member function and
to check if the cached converter can be reused in a simpler way.
(WebCore::TextCodecICU::decode): Updated for changes to types.
(WebCore::TextCodecICU::encode): Updated for changes to types, and removed normalization
since this is now handled by the caller.
* platform/mac/StreamingTextDecoderMac.h: Renamed class to TextCodecMac. We'll rename
the files in a later check-in. Removed all the functions having to do with handling
BOM, UTF-16, and Latin-1; those are now handled elsewhere. Removed textEncodingSupported
because that's superseded by the registry. Added registry hook functions.
* platform/mac/StreamingTextDecoderMac.cpp:
(WebCore::TextCodecMac::registerEncodingNames): Added. Registers encodings based on
the charset table generated by the make-charset-table.pl perl script.
(WebCore::newTextCodecMac): Added. Used by registerCodecs.
(WebCore::TextCodecMac::registerCodecs): Added. Registers codecs for the same encodings
as above.
(WebCore::TextCodecMac::TextCodecMac): Much simplified since this now only handles the
actual TEC/CF encoding and decoding.
(WebCore::TextCodecMac::~TextCodecMac): Renamed.
(WebCore::TextCodecMac::releaseTECConverter): Changed to be a const member function.
(WebCore::TextCodecMac::createTECConverter): Changed to be a const member function.
(WebCore::TextCodecMac::decode): Updated for changes to types.
(WebCore::TextCodecMac::encode): Updated for changes to types, and removed normalization
since this is now handled by the caller.
* platform/mac/mac-encodings.txt: Removed most of the names in this file. This now
only includes encodings where we want to use Mac OS X Carbon Text Encoding Converter,
which is only encodings that are not supported by ICU.
* platform/make-charset-table.pl: Removed flags from output. We don't use them any more.
* platform/CharsetData.h: Changed from a platform-independent header into a
Macintosh-specific one. A later patch should move this and rename it. Also
subsumes ExtraCFEncodings.h.
* WebCore.xcodeproj/project.pbxproj: Added new files. Changed the prefix on the
"make character sets" rule to be kTextEncoding instead of kCFStringEncoding.
* loader/Decoder.h: Change the default encoding parameter to the constructor to be
a TextEncoding object. Renamed setEncodingName to setEncoding, and made it take a
TextEncoding for the encoding. Removed the encodingName and visuallyOrdered functions,
since TextEncoding supports both directly in a straightforward way. Changed both
decode and flush functions to return String instead of DeprecatedString. Added a
number of private functions to factor this class a bit more so it's easier to read.
Got rid of a number of redundant data members. Changed the buffer to a Vector<char>.
* loader/Decoder.cpp:
(WebCore::Decoder::determineContentType): Added. Used by constructor to determine
the content type based on the passed-in MIME type.
(WebCore::Decoder::defaultEncoding): Added. Used by constructor to determine the
default encoding based on the passed in default and the content type.
(WebCore::Decoder::Decoder): Changed to use the functions above. Also renamed
m_reachedBody to m_checkedForHeadCharset.
(WebCore::Decoder::setEncoding): Renamed and changed to take an encoding rather
than an encoding name.
(WebCore::Decoder::checkForBOM): Factored out of decode.
(WebCore::Decoder::checkForCSSCharset): Factored out of decode.
(WebCore::Decoder::checkForHeadCharset): Factored out of decode.
(WebCore::Decoder::detectJapaneseEncoding): Factored out of decode.
(WebCore::Decoder::decode): Refactored so it's no longer one huge function.
Changed to use the new Vector<char> and the new API for TextDecoder.
(WebCore::Decoder::flush): Added code to empty out the buffer. Not an issue in
practice since we don't re-use the decoder after flushing it.
* platform/UChar.h: Added. Has the type named WebCore::UChar that we'll be switching
to. We'll switch away from the ICU ::UChar type, because we don't want to be so
closely tied to ICU -- include this instead of <unicode/umachine.h>.
* platform/PlatformString.h:
* platform/String.cpp:
(WebCore::String::latin1): Updated for changes to TextEncoding.
(WebCore::String::utf8): Ditto.
(WebCore::String::newUninitialized): Added. Gives a way to create a String and
then write directly into its buffer.
* platform/StringImpl.h: Changed return value for charactersWithNullTermination to
be a const UChar*. While it's true that this function changes the underlying
StringImpl, the characters still shouldn't be modified with the returned pointer.
* platform/StringImpl.cpp:
(WebCore::StringImpl::charactersWithNullTermination): Updated for change above.
(WebCore::StringImpl::newUninitialized): Added. Gives a way to create a StringImpl
and then write directly into its buffer.
* platform/CString.h:
* platform/CString.cpp: (WebCore::CString::newUninitialized): Added. Gives a way
to create a CString and then write directly into its buffer.
* bridge/mac/WebCoreFrameBridge.h: Removed textEncoding method, and replaced
+[WebCoreFrameBridge stringWithData:textEncoding:] with
-[WebCoreFrameBridge stringWithData:] to avoid having to pass text encoding
IDs around.
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge setEncoding:userChosen:]): Removed now-unneeded conversion
to DeprecatedString.
(-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
Ditto.
(-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): Ditto.
(-[WebCoreFrameBridge referrer]): Removed now-unneeded call to getNSString.
(-[WebCoreFrameBridge stringWithData:]): Added. Asks the document's decoder
what its encoding is, and decodes using that.
(+[WebCoreFrameBridge stringWithData:textEncodingName:]): Simplified so it
no longer involved a text encoding ID number.
(-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):
Changed to use UChar instead of DeprecatedChar.
(-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]): Removed
now-unneeded conversion to DeprecatedString.
(-[WebCoreFrameBridge documentFragmentWithText:inContext:]): Ditto.
* html/HTMLFormElement.cpp:
(WebCore::encodeCString): Changed parameter to CString.
(WebCore::HTMLFormElement::formData): Updated code for improvements to TextEncoding.
* loader/CachedCSSStyleSheet.h:
* loader/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): Fixed mistake where the
decoder was created without passing in the character set. Also changed from
DeprecatedString to String.
(WebCore::CachedCSSStyleSheet::setCharset): More of the same.
* bindings/js/kjs_window.h: (KJS::ScheduledAction::ScheduledAction): Changed
to use String instead of DeprecatedString, UChar instead of DeprecatedChar,
CString instead of DeprecatedCString, etc.
* bridge/mac/FormDataMac.mm: (WebCore::arrayFromFormData): Ditto.
* bridge/mac/FrameMac.h: Ditto.
* bridge/mac/FrameMac.mm: (WebCore::FrameMac::isCharacterSmartReplaceExempt):
Ditto.
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject helpText]): Ditto.
(-[WebCoreAXObject value]): Ditto.
(-[WebCoreAXObject accessibilityDescription]): Ditto.
(-[WebCoreAXObject doAXStringForTextMarkerRange:]): Ditto.
* bridge/mac/WebCoreEncodings.mm: (+[WebCoreEncodings decodeData:]): Ditto.
Also fixed code that does a deref without a ref to use RefPtr instead.
* bridge/mac/WebCoreScriptDebugger.mm:
(-[WebCoreScriptCallFrame evaluateWebScript:]): Ditto.
* bridge/mac/WebCoreSettings.mm:
(-[WebCoreSettings setDefaultTextEncoding:]): Ditto.
* css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Ditto.
* css/cssparser.cpp: (WebCore::CSSParser::lex): Ditto.
* dom/Document.h:
* dom/Document.cpp:
(WebCore::Document::setCharset): Ditto.
(WebCore::Document::write): Ditto.
(WebCore::Document::determineParseMode): Ditto.
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet): Ditto.
* dom/XMLTokenizer.h:
* dom/XMLTokenizer.cpp:
(WebCore::shouldAllowExternalLoad): Ditto.
(WebCore::createStringParser): Ditto.
(WebCore::XMLTokenizer::write): Ditto.
(WebCore::toString): Ditto.
(WebCore::handleElementAttributes): Ditto.
(WebCore::XMLTokenizer::startElementNs): Ditto.
(WebCore::XMLTokenizer::endElementNs): Ditto.
(WebCore::XMLTokenizer::characters): Ditto.
(WebCore::XMLTokenizer::processingInstruction): Ditto.
(WebCore::XMLTokenizer::cdataBlock): Ditto.
(WebCore::XMLTokenizer::comment): Ditto.
(WebCore::XMLTokenizer::internalSubset): Ditto.
(WebCore::getXHTMLEntity): Ditto.
(WebCore::externalSubsetHandler): Ditto.
(WebCore::XMLTokenizer::initializeParserContext): Ditto.
(WebCore::XMLTokenizer::notifyFinished): Ditto.
(WebCore::xmlDocPtrForString): Ditto.
(WebCore::parseXMLDocumentFragment): Ditto.
(WebCore::attributesStartElementNsHandler): Ditto.
(WebCore::parseAttributes): Ditto.
* html/FormDataList.h:
* html/FormDataList.cpp:
(WebCore::FormDataList::appendString): Ditto. Also changed to call the
encoding function by its new name and with new parameters.
(WebCore::FormDataList::appendFile): Ditto.
* html/HTMLDocument.h:
* html/HTMLDocument.cpp:
(WebCore::parseDocTypePart): Ditto.
(WebCore::containsString): Ditto.
(WebCore::parseDocTypeDeclaration): Ditto.
(WebCore::HTMLDocument::determineParseMode): Ditto.
* html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Ditto.
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseMappedAttribute): Ditto.
* html/HTMLTokenizer.h:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::scriptHandler): Ditto.
(WebCore::HTMLTokenizer::parseTag): Ditto.
(WebCore::HTMLTokenizer::write): Ditto.
(WebCore::HTMLTokenizer::finish): Ditto.
(WebCore::parseHTMLDocumentFragment): Ditto.
* loader/Cache.h:
* loader/Cache.cpp:
(WebCore::Cache::requestStyleSheet): Ditto.
(WebCore::Cache::requestScript): Ditto.
* loader/CachedResource.h: Ditto.
* loader/CachedScript.h:
* loader/CachedScript.cpp:
(WebCore::CachedScript::CachedScript): Ditto.
(WebCore::CachedScript::ref): Ditto.
(WebCore::CachedScript::deref): Ditto.
(WebCore::CachedScript::setCharset): Ditto.
(WebCore::CachedScript::data): Ditto.
(WebCore::CachedScript::checkNotify): Ditto.
* loader/CachedXBLDocument.h:
* loader/CachedXBLDocument.cpp:
(WebCore::CachedXBLDocument::setCharset): Ditto.
* loader/CachedXSLStyleSheet.h:
* loader/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::setCharset): Ditto.
* loader/DocLoader.cpp:
(WebCore::DocLoader::requestStyleSheet): Ditto.
(WebCore::DocLoader::requestScript): Ditto.
* loader/DocLoader.h: Ditto.
* loader/FormData.h:
* loader/FormData.cpp:
(WebCore::FormData::FormData): Ditto.
(WebCore::FormData::appendFile): Ditto.
(WebCore::FormData::flattenToString): Ditto.
* page/Frame.h:
* page/FramePrivate.h:
* page/Frame.cpp:
(WebCore::UserStyleSheetLoader::setStyleSheet): Ditto.
(WebCore::getString): Ditto.
(WebCore::Frame::replaceContentsWithScriptResult): Ditto.
(WebCore::Frame::executeScript): Ditto.
(WebCore::Frame::clear): Ditto.
(WebCore::Frame::write): Ditto.
(WebCore::Frame::endIfNotLoading): Ditto.
(WebCore::Frame::baseTarget): Ditto.
(WebCore::Frame::scheduleRedirection): Ditto.
(WebCore::Frame::scheduleLocationChange): Ditto.
(WebCore::Frame::scheduleHistoryNavigation): Ditto.
(WebCore::Frame::changeLocation): Ditto.
(WebCore::Frame::redirectionTimerFired): Ditto.
(WebCore::Frame::encoding): Ditto.
(WebCore::Frame::submitForm): Ditto.
(WebCore::Frame::referrer): Ditto.
(WebCore::Frame::isCharacterSmartReplaceExempt): Ditto.
(WebCore::Frame::setEncoding): Ditto.
* page/Settings.h: Ditto.
* platform/SegmentedString.h: Ditto.
* platform/SegmentedString.cpp: Ditto.
* xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString): Ditto.
* xml/XSLTProcessor.cpp:
(WebCore::transformTextStringToXHTMLDocumentString): Ditto.
(WebCore::XSLTProcessor::createDocumentFromSource): Ditto.
* xml/xmlhttprequest.h:
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::open): Ditto.
(WebCore::XMLHttpRequest::send): Ditto.
(WebCore::XMLHttpRequest::receivedData): Ditto.
* platform/DeprecatedString.cpp:
(WebCore::DeprecatedString::fromUtf8): Updated for changes to TextEncoding.
(WebCore::DeprecatedString::utf8): Ditto.
* platform/KURL.h:
* platform/KURL.cpp:
(WebCore::KURL::KURL): Updated to overload based on presence or absence of
TextEncoding rather than having a default.
(WebCore::KURL::init): Moved body of constructor in here. Updated to use
the new TextEncoding interface.
(WebCore::KURL::decode_string): Updated to overload based on presence or
absence of TextEncoding rather than having a default. Updated to use
the new TextEncoding interface.
(WebCore::encodeRelativeString): Updated to use the new TextEncoding interface.
* platform/Font.cpp: (WebCore::WidthIterator::normalizeVoicingMarks): Fixed
code to use U_ZERO_ERROR instead of a typecast.
* bindings/js/kjs_proxy.h: Removed unneeded declaration of DeprecatedString.
* platform/GraphicsContext.h: Ditto.
* platform/GraphicsContext.cpp: Removed unneeded include of "DeprecatedString.h".
* rendering/break_lines.cpp: Ditto.
* xml/XMLSerializer.cpp: Ditto.
* platform/mac/FontDataMac.mm: Removed unneeded include of <unicode/unorm.h>.
* platform/CharsetNames.h: Emptied out this file. A later patch could remove it.
* platform/CharsetNames.cpp: Ditto.
* platform/mac/ExtraCFEncodings.h: Ditto.
WebKit:
Reviewed by Alexey.
- WebKit side of changes to encoding
* WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation documentSource]):
Changed to call new -[WebCoreFrameBridge stringWithData:] instead of the calling
the old methods that used a CFStringEncoding: -[WebCoreFrameBridge textEncoding]
and +[WebCoreFrameBridge stringWithData:textEncoding:].
* WebView/WebResource.m: (-[WebResource _stringValue]): Removed special case for
nil encoding name. The bridge itself now has the rule that "nil encoding name
means Latin-1", so we don't need to check for nil.
* WebView/WebFrame.m: (-[WebFrame _checkLoadComplete]): Retain the frame until
we get the parent frame while walking up parent frames, because it's possible
for _checkLoadCompleteForThisFrame to release the last reference to the frame.
(Not reviewed; needed to run performance tests successfully.)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 6 Sep 2006 03:36:10 +0000 (03:36 +0000)]
2006-09-05 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by eseidel. Landed by eseidel.
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10490
-> Remove all SVGAnimated* usage from ksvg2.
This is all done using a set of macros which live in svg/SVGElement.h
(ANIMATED_PROPERTY_DECLARATIONS / ANIMATED_PROPERTY_DEFINITIONS).
Transform all properties to this new concept using Eric ruby script.
-> Replace all usages of "property()->baseVal()" with "propertyBaseValue()".
-> Replace all usages of "property()->setBaseVal()" with "setPropertyBaseValue()".
-> Add "virtual const SVGElement* contextElement() const".
This concept allows to access the document (needed to access the SVGDocumentExtensions)
from lowest-base-classes like SVGURIReference / SVGExternalResourcesRequired etc.
These classes contain this contextElement() function as pure virtual functions.
The topmost classes (like SVGCircleElement) implement this function with "return this".
-> Move default value initialization to constructors.
As the lazy_create usage, which was involved in default property initialization,
has been removed, we need to do the initialization in the constructor.
This forces us to fix the SVGLength class, as calling viewportElement() from the
constructor does not work. This SVGLength cleanup is one of the next things to fix.
* bindings/scripts/CodeGeneratorJS.pm:
* kcanvas/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::translationForAttributes):
* kcanvas/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
(WebCore::RenderSVGImage::relativeBBox):
(WebCore::RenderSVGImage::getAbsoluteRepaintRect):
(WebCore::RenderSVGImage::translationForAttributes):
* kcanvas/RenderSVGText.cpp:
(WebCore::RenderSVGText::translationForAttributes):
* ksvg2/misc/KSVGTimeScheduler.cpp:
(WebCore::SVGTimer::notifyAll):
* ksvg2/misc/SVGDocumentExtensions.cpp:
* ksvg2/misc/SVGDocumentExtensions.h:
(WebCore::SVGDocumentExtensions::baseValueMap):
(WebCore::SVGDocumentExtensions::baseValue):
(WebCore::SVGDocumentExtensions::setBaseValue):
(WebCore::SVGDocumentExtensions::hasBaseValue):
(WebCore::String):
(WebCore::bool):
(WebCore::double):
* ksvg2/misc/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::updateFromElement):
* ksvg2/svg/SVGAElement.cpp:
(WebCore::SVGAElement::parseMappedAttribute):
(WebCore::SVGAElement::defaultEventHandler):
* ksvg2/svg/SVGAElement.h:
(WebCore::SVGAElement::contextElement):
* ksvg2/svg/SVGAnimateColorElement.h:
(WebCore::SVGAnimateColorElement::contextElement):
* ksvg2/svg/SVGAnimateElement.h:
(WebCore::SVGAnimateElement::contextElement):
* ksvg2/svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::handleTimerEvent):
(WebCore::SVGAnimateTransformElement::initialMatrix):
* ksvg2/svg/SVGAnimateTransformElement.h:
(WebCore::SVGAnimateTransformElement::contextElement):
* ksvg2/svg/SVGCircleElement.cpp:
(SVGCircleElement::SVGCircleElement):
(SVGCircleElement::parseMappedAttribute):
(SVGCircleElement::toPathData):
(SVGCircleElement::pushAttributeContext):
* ksvg2/svg/SVGCircleElement.h:
(WebCore::SVGCircleElement::contextElement):
* ksvg2/svg/SVGClipPathElement.cpp:
(SVGClipPathElement::SVGClipPathElement):
(SVGClipPathElement::parseMappedAttribute):
(SVGClipPathElement::canvasResource):
* ksvg2/svg/SVGClipPathElement.h:
(WebCore::SVGClipPathElement::contextElement):
* ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
(SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
(SVGComponentTransferFunctionElement::parseMappedAttribute):
(SVGComponentTransferFunctionElement::transferFunction):
* ksvg2/svg/SVGComponentTransferFunctionElement.h:
* ksvg2/svg/SVGCursorElement.cpp:
(SVGCursorElement::SVGCursorElement):
(SVGCursorElement::parseMappedAttribute):
* ksvg2/svg/SVGCursorElement.h:
(WebCore::SVGCursorElement::contextElement):
* ksvg2/svg/SVGDefsElement.h:
(WebCore::SVGDefsElement::contextElement):
* ksvg2/svg/SVGElement.h:
* ksvg2/svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::SVGEllipseElement):
(WebCore::SVGEllipseElement::parseMappedAttribute):
(WebCore::SVGEllipseElement::toPathData):
(WebCore::SVGEllipseElement::pushAttributeContext):
* ksvg2/svg/SVGEllipseElement.h:
(WebCore::SVGEllipseElement::contextElement):
* ksvg2/svg/SVGExternalResourcesRequired.cpp:
(WebCore::SVGExternalResourcesRequired::SVGExternalResourcesRequired):
(WebCore::SVGExternalResourcesRequired::parseMappedAttribute):
* ksvg2/svg/SVGExternalResourcesRequired.h:
* ksvg2/svg/SVGFEBlendElement.cpp:
(SVGFEBlendElement::SVGFEBlendElement):
(SVGFEBlendElement::parseMappedAttribute):
(SVGFEBlendElement::filterEffect):
* ksvg2/svg/SVGFEBlendElement.h:
(WebCore::SVGFEBlendElement::contextElement):
* ksvg2/svg/SVGFEColorMatrixElement.cpp:
(SVGFEColorMatrixElement::SVGFEColorMatrixElement):
(SVGFEColorMatrixElement::parseMappedAttribute):
(SVGFEColorMatrixElement::filterEffect):
* ksvg2/svg/SVGFEColorMatrixElement.h:
(WebCore::SVGFEColorMatrixElement::contextElement):
* ksvg2/svg/SVGFEComponentTransferElement.cpp:
(SVGFEComponentTransferElement::SVGFEComponentTransferElement):
(SVGFEComponentTransferElement::parseMappedAttribute):
(SVGFEComponentTransferElement::filterEffect):
* ksvg2/svg/SVGFEComponentTransferElement.h:
(WebCore::SVGFEComponentTransferElement::contextElement):
* ksvg2/svg/SVGFECompositeElement.cpp:
(SVGFECompositeElement::SVGFECompositeElement):
(SVGFECompositeElement::parseMappedAttribute):
(SVGFECompositeElement::filterEffect):
* ksvg2/svg/SVGFECompositeElement.h:
(WebCore::SVGFECompositeElement::contextElement):
* ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
(WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
(WebCore::SVGFEDiffuseLightingElement::filterEffect):
* ksvg2/svg/SVGFEDiffuseLightingElement.h:
(WebCore::SVGFEDiffuseLightingElement::contextElement):
* ksvg2/svg/SVGFEDisplacementMapElement.cpp:
(SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
(SVGFEDisplacementMapElement::parseMappedAttribute):
(SVGFEDisplacementMapElement::filterEffect):
* ksvg2/svg/SVGFEDisplacementMapElement.h:
(WebCore::SVGFEDisplacementMapElement::contextElement):
* ksvg2/svg/SVGFEDistantLightElement.cpp:
(WebCore::SVGFEDistantLightElement::lightSource):
* ksvg2/svg/SVGFEFloodElement.cpp:
(SVGFEFloodElement::parseMappedAttribute):
(SVGFEFloodElement::filterEffect):
* ksvg2/svg/SVGFEFloodElement.h:
(WebCore::SVGFEFloodElement::contextElement):
* ksvg2/svg/SVGFEGaussianBlurElement.cpp:
(SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
(SVGFEGaussianBlurElement::parseMappedAttribute):
(SVGFEGaussianBlurElement::filterEffect):
* ksvg2/svg/SVGFEGaussianBlurElement.h:
(WebCore::SVGFEGaussianBlurElement::contextElement):
* ksvg2/svg/SVGFEImageElement.cpp:
(SVGFEImageElement::SVGFEImageElement):
(SVGFEImageElement::parseMappedAttribute):
* ksvg2/svg/SVGFEImageElement.h:
(WebCore::SVGFEImageElement::contextElement):
* ksvg2/svg/SVGFELightElement.cpp:
(SVGFELightElement::SVGFELightElement):
(SVGFELightElement::parseMappedAttribute):
* ksvg2/svg/SVGFELightElement.h:
* ksvg2/svg/SVGFEMergeElement.cpp:
(SVGFEMergeElement::SVGFEMergeElement):
(SVGFEMergeElement::filterEffect):
* ksvg2/svg/SVGFEMergeElement.h:
(WebCore::SVGFEMergeElement::contextElement):
* ksvg2/svg/SVGFEMergeNodeElement.cpp:
(SVGFEMergeNodeElement::parseMappedAttribute):
* ksvg2/svg/SVGFEMergeNodeElement.h:
(WebCore::SVGFEMergeNodeElement::contextElement):
* ksvg2/svg/SVGFEOffsetElement.cpp:
(SVGFEOffsetElement::SVGFEOffsetElement):
(SVGFEOffsetElement::parseMappedAttribute):
(SVGFEOffsetElement::filterEffect):
* ksvg2/svg/SVGFEOffsetElement.h:
(WebCore::SVGFEOffsetElement::contextElement):
* ksvg2/svg/SVGFEPointLightElement.cpp:
(WebCore::SVGFEPointLightElement::lightSource):
* ksvg2/svg/SVGFESpecularLightingElement.cpp:
(SVGFESpecularLightingElement::SVGFESpecularLightingElement):
(SVGFESpecularLightingElement::parseMappedAttribute):
(SVGFESpecularLightingElement::filterEffect):
* ksvg2/svg/SVGFESpecularLightingElement.h:
(WebCore::SVGFESpecularLightingElement::contextElement):
* ksvg2/svg/SVGFESpotLightElement.cpp:
(WebCore::SVGFESpotLightElement::lightSource):
* ksvg2/svg/SVGFETileElement.cpp:
(SVGFETileElement::parseMappedAttribute):
(SVGFETileElement::filterEffect):
* ksvg2/svg/SVGFETileElement.h:
(WebCore::SVGFETileElement::contextElement):
* ksvg2/svg/SVGFETurbulenceElement.cpp:
(SVGFETurbulenceElement::SVGFETurbulenceElement):
(SVGFETurbulenceElement::parseMappedAttribute):
(SVGFETurbulenceElement::filterEffect):
* ksvg2/svg/SVGFETurbulenceElement.h:
(WebCore::SVGFETurbulenceElement::contextElement):
* ksvg2/svg/SVGFilterElement.cpp:
(SVGFilterElement::SVGFilterElement):
(SVGFilterElement::parseMappedAttribute):
(SVGFilterElement::canvasResource):
* ksvg2/svg/SVGFilterElement.h:
(WebCore::SVGFilterElement::contextElement):
* ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
(SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
(SVGFilterPrimitiveStandardAttributes::~SVGFilterPrimitiveStandardAttributes):
(SVGFilterPrimitiveStandardAttributes::parseMappedAttribute):
(SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
* ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::contextElement):
* ksvg2/svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::SVGFitToViewBox):
(WebCore::SVGFitToViewBox::parseViewBox):
(WebCore::SVGFitToViewBox::viewBoxToViewTransform):
(WebCore::SVGFitToViewBox::parseMappedAttribute):
* ksvg2/svg/SVGFitToViewBox.h:
* ksvg2/svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
(WebCore::SVGForeignObjectElement::parseMappedAttribute):
* ksvg2/svg/SVGForeignObjectElement.h:
(WebCore::SVGForeignObjectElement::isValid):
(WebCore::SVGForeignObjectElement::contextElement):
* ksvg2/svg/SVGGElement.h:
(WebCore::SVGGElement::contextElement):
* ksvg2/svg/SVGGradientElement.cpp:
(SVGGradientElement::SVGGradientElement):
(SVGGradientElement::parseMappedAttribute):
(SVGGradientElement::rebuildStops):
* ksvg2/svg/SVGGradientElement.h:
* ksvg2/svg/SVGHelper.cpp:
(WebCore::SVGHelper::PercentageOfViewport):
* ksvg2/svg/SVGImageElement.cpp:
(SVGImageElement::SVGImageElement):
(SVGImageElement::parseMappedAttribute):
(SVGImageElement::haveLoadedRequiredResources):
* ksvg2/svg/SVGImageElement.h:
(WebCore::SVGImageElement::contextElement):
* ksvg2/svg/SVGLangSpace.h:
* ksvg2/svg/SVGLength.cpp:
* ksvg2/svg/SVGLineElement.cpp:
(SVGLineElement::SVGLineElement):
(SVGLineElement::parseMappedAttribute):
(SVGLineElement::toPathData):
(SVGLineElement::pushAttributeContext):
* ksvg2/svg/SVGLineElement.h:
(WebCore::SVGLineElement::contextElement):
* ksvg2/svg/SVGLinearGradientElement.cpp:
(SVGLinearGradientElement::SVGLinearGradientElement):
(SVGLinearGradientElement::parseMappedAttribute):
(SVGLinearGradientElement::buildGradient):
* ksvg2/svg/SVGLinearGradientElement.h:
(WebCore::SVGLinearGradientElement::contextElement):
* ksvg2/svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::SVGMarkerElement):
(WebCore::SVGMarkerElement::parseMappedAttribute):
(WebCore::SVGMarkerElement::setOrientToAuto):
(WebCore::SVGMarkerElement::setOrientToAngle):
(WebCore::SVGMarkerElement::canvasResource):
* ksvg2/svg/SVGMarkerElement.h:
(WebCore::SVGMarkerElement::contextElement):
* ksvg2/svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::SVGMaskElement):
(WebCore::SVGMaskElement::attributeChanged):
(WebCore::SVGMaskElement::parseMappedAttribute):
(WebCore::SVGMaskElement::drawMaskerContent):
* ksvg2/svg/SVGMaskElement.h:
(WebCore::SVGMaskElement::contextElement):
* ksvg2/svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
* ksvg2/svg/SVGPathElement.h:
(WebCore::SVGPathElement::isValid):
(WebCore::SVGPathElement::contextElement):
* ksvg2/svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::SVGPatternElement):
(WebCore::SVGPatternElement::parseMappedAttribute):
(WebCore::SVGPatternElement::pushAttributeContext):
(WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
(WebCore::SVGPatternElement::drawPatternContentIntoTile):
(WebCore::SVGPatternElement::notifyAttributeChange):
(WebCore::SVGPatternElement::getCTM):
* ksvg2/svg/SVGPatternElement.h:
(WebCore::SVGPatternElement::contextElement):
* ksvg2/svg/SVGPolyElement.h:
(WebCore::SVGPolyElement::contextElement):
* ksvg2/svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
(WebCore::SVGRadialGradientElement::~SVGRadialGradientElement):
(WebCore::SVGRadialGradientElement::parseMappedAttribute):
(WebCore::SVGRadialGradientElement::buildGradient):
* ksvg2/svg/SVGRadialGradientElement.h:
(WebCore::SVGRadialGradientElement::contextElement):
* ksvg2/svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::SVGRectElement):
(WebCore::SVGRectElement::parseMappedAttribute):
(WebCore::SVGRectElement::toPathData):
(WebCore::SVGRectElement::pushAttributeContext):
* ksvg2/svg/SVGRectElement.h:
(WebCore::SVGRectElement::contextElement):
* ksvg2/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::~SVGSVGElement):
(WebCore::SVGSVGElement::viewport):
(WebCore::SVGSVGElement::parseMappedAttribute):
(WebCore::SVGSVGElement::getCTM):
(WebCore::SVGSVGElement::getScreenCTM):
(WebCore::SVGSVGElement::createRenderer):
* ksvg2/svg/SVGSVGElement.h:
(WebCore::SVGSVGElement::contextElement):
* ksvg2/svg/SVGScriptElement.h:
(WebCore::SVGScriptElement::contextElement):
* ksvg2/svg/SVGSetElement.h:
(WebCore::SVGSetElement::contextElement):
* ksvg2/svg/SVGStopElement.cpp:
(SVGStopElement::SVGStopElement):
(SVGStopElement::parseMappedAttribute):
* ksvg2/svg/SVGStopElement.h:
* ksvg2/svg/SVGStylable.h:
* ksvg2/svg/SVGStyledElement.cpp:
* ksvg2/svg/SVGStyledElement.h:
* ksvg2/svg/SVGStyledTransformableElement.cpp:
(SVGStyledTransformableElement::SVGStyledTransformableElement):
(SVGStyledTransformableElement::parseMappedAttribute):
* ksvg2/svg/SVGStyledTransformableElement.h:
* ksvg2/svg/SVGSwitchElement.cpp:
* ksvg2/svg/SVGSwitchElement.h:
(WebCore::SVGSwitchElement::contextElement):
* ksvg2/svg/SVGSymbolElement.h:
(WebCore::SVGSymbolElement::contextElement):
* ksvg2/svg/SVGTRefElement.cpp:
(SVGTRefElement::updateReferencedText):
* ksvg2/svg/SVGTRefElement.h:
(WebCore::SVGTRefElement::contextElement):
* ksvg2/svg/SVGTSpanElement.h:
(WebCore::SVGTSpanElement::contextElement):
* ksvg2/svg/SVGTextContentElement.cpp:
(SVGTextContentElement::SVGTextContentElement):
(SVGTextContentElement::parseMappedAttribute):
* ksvg2/svg/SVGTextContentElement.h:
* ksvg2/svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::SVGTextElement):
(WebCore::SVGTextElement::parseMappedAttribute):
* ksvg2/svg/SVGTextElement.h:
(WebCore::SVGTextElement::contextElement):
* ksvg2/svg/SVGTextPositioningElement.cpp:
(SVGTextPositioningElement::SVGTextPositioningElement):
(SVGTextPositioningElement::parseMappedAttribute):
* ksvg2/svg/SVGTextPositioningElement.h:
* ksvg2/svg/SVGTransformable.cpp:
* ksvg2/svg/SVGTransformable.h:
* ksvg2/svg/SVGURIReference.cpp:
(SVGURIReference::parseMappedAttribute):
* ksvg2/svg/SVGURIReference.h:
* ksvg2/svg/SVGUseElement.cpp:
(SVGUseElement::SVGUseElement):
(SVGUseElement::parseMappedAttribute):
(SVGUseElement::closeRenderer):
* ksvg2/svg/SVGUseElement.h:
(WebCore::SVGUseElement::contextElement):
* ksvg2/svg/SVGViewElement.h:
(WebCore::SVGViewElement::contextElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 6 Sep 2006 03:26:42 +0000 (03:26 +0000)]
2006-09-05 Eric Seidel <eric@eseidel.com>
Reviewed by aroben.
Speed up path parsing by removing string copies.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10722
Tests already cover path parsing.
* ksvg2/svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseViewBox):
* ksvg2/svg/svgpathparser.cpp:
(WebCore::skipOptionalSpaces): Added.
(WebCore::skipOptionalSpacesOrComma): Added.
(WebCore::parseCoord):
(WebCore::SVGPolyParser::parsePoints):
(WebCore::SVGPathParser::parseSVG):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 6 Sep 2006 02:59:41 +0000 (02:59 +0000)]
Reviewed by Tim H.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10742
More Objective-C DOM auto-generation cleanup
- Factor out implementation type-getters into their own function
and standardize naming as was done for type-makers (ie. HTML
and CSS prefixing for method names).
* bindings/objc/DOMCSS.mm:
(-[DOMCSSStyleDeclaration getPropertyShorthand:]):
(-[DOMCSSStyleDeclaration isPropertyImplicit:]):
(-[DOMCSSStyleDeclaration _CSSStyleDeclaration]):
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLTableCaptionElement _HTMLTableCaptionElement]):
(-[DOMHTMLTableSectionElement _HTMLTableSectionElement]):
(-[DOMHTMLTableElement _HTMLTableElement]):
(-[DOMHTMLTableCellElement _HTMLTableCellElement]):
(-[DOMHTMLEmbedElement _HTMLEmbedElement]):
(-[DOMHTMLEmbedElement align]):
(-[DOMHTMLEmbedElement setAlign:]):
(-[DOMHTMLEmbedElement height]):
(-[DOMHTMLEmbedElement setHeight:]):
(-[DOMHTMLEmbedElement name]):
(-[DOMHTMLEmbedElement setName:]):
(-[DOMHTMLEmbedElement src]):
(-[DOMHTMLEmbedElement setSrc:]):
(-[DOMHTMLEmbedElement type]):
(-[DOMHTMLEmbedElement setType:]):
(-[DOMHTMLEmbedElement width]):
(-[DOMHTMLEmbedElement setWidth:]):
* bindings/objc/DOMInternal.h:
* bindings/scripts/CodeGeneratorObjC.pm:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge setTypingStyle:withUndoAction:]):
(-[WebCoreFrameBridge applyStyle:withUndoAction:]):
(-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
(-[WebCoreFrameBridge selectionStartHasStyle:]):
(-[WebCoreFrameBridge selectionHasStyle:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 6 Sep 2006 02:30:25 +0000 (02:30 +0000)]
Rolling out my earlier change, which broke the build for Tiger.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 6 Sep 2006 00:48:23 +0000 (00:48 +0000)]
Reviewed by John.
Removing the DOMImplementationFront workaround for an older GCC bug.
This changes requires Xcode 2.3 or later.
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
(-[DOMImplementation _initWithDOMImplementation:WebCore::]):
(+[DOMImplementation _DOMImplementationWith:WebCore::]):
(-[DOMImplementation WebCore::]):
* bindings/objc/DOMImplementationFront.cpp: Removed.
* bindings/objc/DOMImplementationFront.h: Removed.
* bindings/objc/DOMInternal.h:
* bindings/scripts/CodeGeneratorObjC.pm: remove DOMImplementationFront
and some cleanup to under variables in WriteData
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 5 Sep 2006 23:55:28 +0000 (23:55 +0000)]
* Scripts/do-webcore-rename: More renaming plans.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 5 Sep 2006 23:38:05 +0000 (23:38 +0000)]
Reviewed by Adam.
Removed dead code for password field.
* platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
* platform/mac/WebCoreTextField.h:
* platform/mac/WebCoreTextField.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 5 Sep 2006 22:35:16 +0000 (22:35 +0000)]
LayoutTests:
Reviewed by thatcher
Setup for <rdar://problem/
4344550> Misspellings aren't marked after undo delete
Fixed:
* editing/pasteboard/
4641033-expected.checksum:
* editing/pasteboard/
4641033-expected.png:
* editing/execCommand/outdent-selection-expected.checksum:
* editing/execCommand/outdent-selection-expected.png:
Added a didChangeSelection notification that was absent before:
* editing/deleting/collapse-whitespace-
3587601-fix-expected.txt:
* editing/deleting/delete-
3608430-fix-expected.txt:
* editing/deleting/delete-
3608462-fix-expected.txt:
* editing/deleting/delete-
3775172-fix-expected.txt:
* editing/deleting/delete-
3800834-fix-expected.txt:
* editing/deleting/delete-
3857753-fix-expected.txt:
* editing/deleting/delete-
3865854-fix-expected.txt:
* editing/deleting/delete-
3928305-fix-expected.txt:
* editing/deleting/delete-
3959464-fix-expected.txt:
* editing/deleting/delete-
4038408-fix-expected.txt:
* editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
* editing/deleting/delete-block-contents-001-expected.txt:
* editing/deleting/delete-block-contents-002-expected.txt:
* editing/deleting/delete-block-contents-003-expected.txt:
* editing/deleting/delete-block-merge-contents-001-expected.txt:
* editing/deleting/delete-block-merge-contents-002-expected.txt:
* editing/deleting/delete-block-merge-contents-003-expected.txt:
* editing/deleting/delete-block-merge-contents-004-expected.txt:
* editing/deleting/delete-block-merge-contents-005-expected.txt:
* editing/deleting/delete-block-merge-contents-006-expected.txt:
* editing/deleting/delete-block-merge-contents-007-expected.txt:
* editing/deleting/delete-block-merge-contents-008-expected.txt:
* editing/deleting/delete-block-merge-contents-009-expected.txt:
* editing/deleting/delete-block-merge-contents-010-expected.txt:
* editing/deleting/delete-block-merge-contents-012-expected.txt:
* editing/deleting/delete-block-merge-contents-013-expected.txt:
* editing/deleting/delete-block-merge-contents-014-expected.txt:
* editing/deleting/delete-block-merge-contents-015-expected.txt:
* editing/deleting/delete-block-merge-contents-016-expected.txt:
* editing/deleting/delete-block-merge-contents-017-expected.txt:
* editing/deleting/delete-block-merge-contents-018-expected.txt:
* editing/deleting/delete-block-merge-contents-019-expected.txt:
* editing/deleting/delete-block-merge-contents-020-expected.txt:
* editing/deleting/delete-block-merge-contents-021-expected.txt:
* editing/deleting/delete-block-merge-contents-022-expected.txt:
* editing/deleting/delete-block-merge-contents-023-expected.txt:
* editing/deleting/delete-block-merge-contents-024-expected.txt:
* editing/deleting/delete-block-table-expected.txt:
* editing/deleting/delete-br-008-expected.txt:
* editing/deleting/delete-br-010-expected.txt:
* editing/deleting/delete-br-011-expected.txt:
* editing/deleting/delete-first-list-item-expected.txt:
* editing/deleting/delete-image-001-expected.txt:
* editing/deleting/delete-image-002-expected.txt:
* editing/deleting/delete-image-003-expected.txt:
* editing/deleting/delete-image-004-expected.txt:
* editing/deleting/delete-line-001-expected.txt:
* editing/deleting/delete-line-002-expected.txt:
* editing/deleting/delete-line-003-expected.txt:
* editing/deleting/delete-line-004-expected.txt:
* editing/deleting/delete-line-005-expected.txt:
* editing/deleting/delete-line-006-expected.txt:
* editing/deleting/delete-line-007-expected.txt:
* editing/deleting/delete-line-008-expected.txt:
* editing/deleting/delete-line-009-expected.txt:
* editing/deleting/delete-line-010-expected.txt:
* editing/deleting/delete-line-011-expected.txt:
* editing/deleting/delete-line-012-expected.txt:
* editing/deleting/delete-line-013-expected.txt:
* editing/deleting/delete-line-014-expected.txt:
* editing/deleting/delete-line-015-expected.txt:
* editing/deleting/delete-line-016-expected.txt:
* editing/deleting/delete-line-017-expected.txt:
* editing/deleting/delete-listitem-001-expected.txt:
* editing/deleting/delete-listitem-002-expected.txt:
* editing/deleting/delete-mixed-editable-content-001-expected.txt:
* editing/deleting/delete-select-all-001-expected.txt:
* editing/deleting/delete-select-all-002-expected.txt:
* editing/deleting/delete-select-all-003-expected.txt:
* editing/deleting/merge-different-styles-expected.txt:
* editing/deleting/merge-endOfParagraph-expected.txt:
* editing/deleting/merge-no-br-expected.txt:
* editing/deleting/pruning-after-merge-1-expected.txt:
* editing/deleting/pruning-after-merge-2-expected.txt:
* editing/deleting/table-cells-expected.txt:
* editing/execCommand/boldSelection-expected.txt:
* editing/execCommand/create-list-from-range-selection-expected.txt:
* editing/execCommand/createLink-expected.txt:
* editing/execCommand/format-block-expected.txt:
* editing/execCommand/format-block-from-range-selection-expected.txt:
* editing/execCommand/format-block-with-braces-expected.txt:
* editing/execCommand/format-block-with-trailing-br-expected.txt:
* editing/execCommand/hilitecolor-expected.txt:
* editing/execCommand/indent-list-item-expected.txt:
* editing/execCommand/indent-selection-expected.txt:
* editing/execCommand/insert-list-and-stitch-expected.txt:
* editing/execCommand/insert-list-with-id-expected.txt:
* editing/execCommand/insertHTML-expected.txt:
* editing/execCommand/insertHorizontalRule-expected.txt:
* editing/execCommand/remove-formatting-expected.txt:
* editing/execCommand/remove-list-from-range-selection-expected.txt:
* editing/execCommand/remove-list-items-expected.txt:
* editing/execCommand/strikethroughSelection-expected.txt:
* editing/execCommand/switch-list-type-expected.txt:
* editing/execCommand/unlink-expected.txt:
* editing/input/text-input-controller-expected.txt:
* editing/inserting/insert-
3654864-fix-expected.txt:
* editing/inserting/insert-
3659587-fix-expected.txt:
* editing/inserting/insert-
3775316-fix-expected.txt:
* editing/inserting/insert-
3851164-fix-expected.txt:
* editing/inserting/insert-
3907422-fix-expected.txt:
* editing/inserting/insert-after-delete-001-expected.txt:
* editing/inserting/insert-div-001-expected.txt:
* editing/inserting/insert-div-002-expected.txt:
* editing/inserting/insert-div-003-expected.txt:
* editing/inserting/insert-div-005-expected.txt:
* editing/inserting/insert-div-007-expected.txt:
* editing/inserting/insert-div-009-expected.txt:
* editing/inserting/insert-div-010-expected.txt:
* editing/inserting/insert-div-020-expected.txt:
* editing/inserting/insert-div-023-expected.txt:
* editing/inserting/insert-div-024-expected.txt:
* editing/inserting/insert-div-025-expected.txt:
* editing/inserting/insert-div-026-expected.txt:
* editing/inserting/multiple-lines-selected-expected.txt:
* editing/inserting/paragraph-separator-03-expected.txt:
* editing/inserting/paragraph-separator-in-table-2-expected.txt:
* editing/inserting/redo-expected.txt:
* editing/inserting/return-key-with-selection-001-expected.txt:
* editing/inserting/return-key-with-selection-002-expected.txt:
* editing/inserting/return-key-with-selection-003-expected.txt:
* editing/pasteboard/
3976872-expected.txt:
* editing/pasteboard/
4076267-3-expected.txt:
* editing/pasteboard/
4076267-expected.txt:
* editing/pasteboard/
4700297-expected.txt:
* editing/pasteboard/8145-3-expected.txt:
* editing/pasteboard/block-wrappers-necessary-expected.txt:
* editing/pasteboard/copy-paste-bidi-expected.txt:
* editing/pasteboard/displaced-generic-placeholder-expected.txt:
* editing/pasteboard/displaced-placeholder-expected.txt:
* editing/pasteboard/display-block-on-spans-expected.txt:
* editing/pasteboard/drag-drop-modifies-page-expected.txt:
* editing/pasteboard/interchange-newline-2-expected.txt:
* editing/pasteboard/merge-after-delete-1-expected.txt:
* editing/pasteboard/merge-after-delete-2-expected.txt:
* editing/pasteboard/merge-after-delete-expected.txt:
* editing/pasteboard/merge-end-3-expected.txt:
* editing/pasteboard/merge-end-5-expected.txt:
* editing/pasteboard/merge-end-blockquote-expected.txt:
* editing/pasteboard/merge-end-list-expected.txt:
* editing/pasteboard/merge-end-table-expected.txt:
* editing/pasteboard/paste-
4035648-fix-expected.txt:
* editing/pasteboard/paste-
4039777-fix-expected.txt:
* editing/pasteboard/paste-line-endings-001-expected.txt:
* editing/pasteboard/paste-line-endings-006-expected.txt:
* editing/pasteboard/paste-match-style-001-expected.txt:
* editing/pasteboard/paste-match-style-002-expected.txt:
* editing/pasteboard/paste-pre-001-expected.txt:
* editing/pasteboard/paste-pre-002-expected.txt:
* editing/pasteboard/paste-table-002-expected.txt:
* editing/pasteboard/paste-table-003-expected.txt:
* editing/pasteboard/paste-text-006-expected.txt:
* editing/pasteboard/paste-text-007-expected.txt:
* editing/pasteboard/paste-text-010-expected.txt:
* editing/pasteboard/paste-text-011-expected.txt:
* editing/pasteboard/paste-text-015-expected.txt:
* editing/pasteboard/paste-text-016-expected.txt:
* editing/pasteboard/paste-text-017-expected.txt:
* editing/pasteboard/paste-text-018-expected.txt:
* editing/pasteboard/prevent-block-nesting-01-expected.txt:
* editing/pasteboard/smart-paste-003-expected.txt:
* editing/pasteboard/smart-paste-004-expected.txt:
* editing/pasteboard/smart-paste-005-expected.txt:
* editing/pasteboard/smart-paste-006-expected.txt:
* editing/pasteboard/smart-paste-007-expected.txt:
* editing/pasteboard/smart-paste-008-expected.txt:
* editing/pasteboard/testcase-9507-expected.txt:
* editing/pasteboard/undoable-fragment-removes-expected.txt:
* editing/selection/expanding-selections-expected.txt:
* editing/selection/expanding-selections2-expected.txt:
* editing/selection/node-removal-1-expected.txt:
* editing/selection/node-removal-2-expected.txt:
* editing/selection/select-all-iframe-expected.txt:
* editing/selection/skip-non-editable-1-expected.txt:
* editing/selection/triple-click-in-pre-expected.txt:
* editing/style/apple-style-editable-mix-expected.txt:
* editing/style/block-style-004-expected.txt:
* editing/style/block-style-005-expected.txt:
* editing/style/block-style-006-expected.txt:
* editing/style/create-block-for-style-001-expected.txt:
* editing/style/create-block-for-style-002-expected.txt:
* editing/style/create-block-for-style-003-expected.txt:
* editing/style/create-block-for-style-004-expected.txt:
* editing/style/create-block-for-style-007-expected.txt:
* editing/style/create-block-for-style-009-expected.txt:
* editing/style/create-block-for-style-010-expected.txt:
* editing/style/create-block-for-style-011-expected.txt:
* editing/style/create-block-for-style-012-expected.txt:
* editing/style/create-block-for-style-013-expected.txt:
* editing/style/designmode-expected.txt:
* editing/style/relative-font-size-change-001-expected.txt:
* editing/style/relative-font-size-change-002-expected.txt:
* editing/style/remove-underline-across-paragraph-expected.txt:
* editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
* editing/style/remove-underline-after-paragraph-expected.txt:
* editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
* editing/style/remove-underline-from-stylesheet-expected.txt:
* editing/style/smoosh-styles-001-expected.txt:
* editing/style/smoosh-styles-002-expected.txt:
* editing/style/smoosh-styles-003-expected.txt:
* editing/style/style-
3681552-fix-001-expected.txt:
* editing/style/style-
3681552-fix-002-expected.txt:
* editing/style/style-
3690704-fix-expected.txt:
* editing/style/style-
3998892-fix-expected.txt:
* editing/style/style-boundary-001-expected.txt:
* editing/style/style-boundary-003-expected.txt:
* editing/style/style-boundary-004-expected.txt:
* editing/style/typing-style-001-expected.txt:
* editing/style/typing-style-003-expected.txt:
* editing/undo/undo-misspellings-expected.txt:
* editing/unsupported-content/list-delete-001-expected.txt:
* editing/unsupported-content/list-delete-002-expected.txt:
* editing/unsupported-content/list-delete-003-expected.txt:
* editing/unsupported-content/table-delete-001-expected.txt:
* editing/unsupported-content/table-delete-002-expected.txt:
* editing/unsupported-content/table-delete-003-expected.txt:
* fast/forms/attributed-strings-expected.txt:
* fast/forms/cursor-position-expected.txt:
* fast/forms/drag-into-textarea-expected.txt:
* fast/forms/input-appearance-maxlength-expected.txt:
* fast/forms/input-paste-undo-expected.txt:
* fast/forms/input-selection-restore-expected.txt:
* fast/forms/input-text-paste-maxlength-expected.txt:
* fast/forms/selection-functions-expected.txt:
* fast/forms/text-field-setvalue-crash-expected.txt:
* fast/forms/textarea-paste-newline-expected.txt:
WebCore:
Reviewed by thatcher
Setup for <rdar://problem/
4344550> Misspellings aren't marked after undo delete
Fixes:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6498>
SelectionController's setters should notify delegates of selection changes
Moved setSelection from Frame to SelectionController.
I haven't moved any of the work that's done as a result of a
Selection change to SelectionController yet.
Make fewer uses of SelectionControllers. They're now only used for
the Frame's selection, the Page's drag caret, and functions that
need to do Selection expansion.
* bindings/js/kjs_window.cpp:
(KJS::Selection::getValueProperty):
(KJS::Selection::toString):
(KJS::SelectionFunc::callAsFunction):
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::advanceToNextMisspelling):
(WebCore::FrameMac::dispatchCPPEvent):
(WebCore::FrameMac::fontForSelection):
(WebCore::FrameMac::baseWritingDirectionForSelectionStart):
(WebCore::FrameMac::markMisspellingsInAdjacentWords):
(WebCore::FrameMac::markMisspellings):
(WebCore::FrameMac::respondToChangedSelection):
(WebCore::FrameMac::shouldChangeSelection):
(WebCore::FrameMac::shouldDeleteSelection):
(WebCore::FrameMac::respondToChangedContents):
* bridge/mac/PageMac.mm:
(WebCore::Page::Page):
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityAttributeValue:]):
(-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
(-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
(-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
(-[WebCoreAXObject doSetAXSelectedTextMarkerRange:]):
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge isSelectionEditable]):
(-[WebCoreFrameBridge isSelectionRichlyEditable]):
(-[WebCoreFrameBridge selectionState]):
(-[WebCoreFrameBridge deselectText]):
(-[WebCoreFrameBridge selectedAttributedString]):
(-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
(-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
(-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
(-[WebCoreFrameBridge rangeByAlteringCurrentSelection:verticalDistance:]):
(-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
(-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]):
(-[WebCoreFrameBridge selectedDOMRange]):
(-[WebCoreFrameBridge selectNSRange:]):
(-[WebCoreFrameBridge selectedNSRange]):
(-[WebCoreFrameBridge selectionAffinity]):
(-[WebCoreFrameBridge replaceSelectionWithText:selectReplacement:smartReplace:]):
(-[WebCoreFrameBridge setSelectionToDragCaret]):
(-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
(-[WebCoreFrameBridge moveDragCaretToPoint:]):
(-[WebCoreFrameBridge removeDragCaret]):
(-[WebCoreFrameBridge dragCaretDOMRange]):
(-[WebCoreFrameBridge isDragCaretRichlyEditable]):
(-[WebCoreFrameBridge editableDOMRangeForPoint:]):
(-[WebCoreFrameBridge ensureSelectionVisible]):
(-[WebCoreFrameBridge rangeOfCharactersAroundCaret]):
* bridge/win/PageWin.cpp:
(WebCore::Page::Page):
* dom/Document.cpp:
(WebCore::Document::updateSelection):
(WebCore::Document::clearSelectionIfNeeded):
(WebCore::Document::notifyBeforeNodeRemoval):
* dom/Element.cpp:
(WebCore::Element::updateFocusAppearance):
* editing/EditCommand.cpp:
(WebCore::EditCommand::EditCommand):
* editing/JSEditor.cpp:
* editing/ModifySelectionListLevel.cpp:
(WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel):
(WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
* editing/Selection.cpp:
(WebCore::Selection::setBase):
(WebCore::Selection::setExtent):
* editing/Selection.h:
(WebCore::Selection::extent):
* editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController):
(WebCore::SelectionController::moveTo):
(WebCore::SelectionController::setSelection):
(WebCore::SelectionController::nodeWillBeRemoved):
(WebCore::SelectionController::modify):
(WebCore::SelectionController::clear):
(WebCore::SelectionController::setBase):
(WebCore::SelectionController::setExtent):
* editing/SelectionController.h:
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::caretRect):
* editing/VisiblePosition.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* page/Frame.cpp:
(WebCore::Frame::selectedText):
(WebCore::Frame::hasSelection):
(WebCore::Frame::selectionController):
(WebCore::Frame::dragCaretController):
(WebCore::Frame::notifyRendererOfSelectionChange):
(WebCore::Frame::invalidateSelection):
(WebCore::Frame::clearCaretRectIfNeeded):
(WebCore::Frame::setFocusNodeIfNeeded):
(WebCore::Frame::selectionLayoutChanged):
(WebCore::Frame::caretBlinkTimerFired):
(WebCore::Frame::paintCaret):
(WebCore::Frame::paintDragCaret):
(WebCore::Frame::isPointInsideSelection):
(WebCore::Frame::selectClosestWordFromMouseEvent):
(WebCore::Frame::handleMousePressEventDoubleClick):
(WebCore::Frame::handleMousePressEventTripleClick):
(WebCore::Frame::handleMousePressEventSingleClick):
(WebCore::Frame::handleMouseMoveEvent):
(WebCore::Frame::handleMouseReleaseEvent):
(WebCore::Frame::selectAll):
(WebCore::Frame::selectContentsOfNode):
(WebCore::Frame::shouldChangeSelection):
(WebCore::Frame::shouldDeleteSelection):
(WebCore::Frame::isSelectionInPasswordField):
(WebCore::Frame::appliedEditing):
(WebCore::Frame::unappliedEditing):
(WebCore::Frame::reappliedEditing):
(WebCore::Frame::computeAndSetTypingStyle):
(WebCore::Frame::applyStyle):
(WebCore::Frame::applyParagraphStyle):
(WebCore::Frame::selectionListState):
(WebCore::Frame::selectionHasStyle):
(WebCore::Frame::selectionComputedStyle):
(WebCore::Frame::selectFrameElementInParentIfFullySelected):
(WebCore::Frame::currentForm):
(WebCore::Frame::revealSelection):
(WebCore::Frame::centerSelectionInVisibleArea):
(WebCore::Frame::styleForSelectionStart):
(WebCore::Frame::setSelectionFromNone):
(WebCore::Frame::findString):
* page/Frame.h:
* page/FramePrivate.h:
(WebCore::FramePrivate::FramePrivate):
* page/FrameView.cpp:
(WebCore::FrameView::clear):
* page/Page.cpp:
(WebCore::Page::dragCaretController):
* page/Page.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintCaret):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::autoscroll):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::selectionStart):
(WebCore::RenderTextControl::selectionEnd):
(WebCore::RenderTextControl::setSelectionRange):
(WebCore::RenderTextControl::selectionChanged):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 5 Sep 2006 21:10:30 +0000 (21:10 +0000)]
Reviewed by Tim O.
<rdar://problem/
4682225> conflicting typedefs in Netscape plug-in headers
* Plugins/npfunctions.h: fix the return type for NPN_IntFromIdentifierProcPtr to be int32_t
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 5 Sep 2006 20:13:12 +0000 (20:13 +0000)]
Reviewed by Tim O.
<rdar://problem/
4715840> SEL is not char*
* bindings/objc/objc_class.mm:
(KJS::Bindings::ObjcClass::methodsNamed): use sel_getName instead of a char* cast.
* bindings/objc/objc_runtime.mm:
(ObjcFallbackObjectImp::callAsFunction): ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 5 Sep 2006 19:04:29 +0000 (19:04 +0000)]
Reviewed by Adam.
Let the engine draw the focus ring for styled menu lists.
* rendering/RenderTheme.cpp: (WebCore::RenderTheme::supportsFocusRing): Added case for MenulistButtonAppearance.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 5 Sep 2006 17:54:33 +0000 (17:54 +0000)]
Reviewed by Adam.
- Fix for <rdar://problem/
4706463> REGRESSION: Must click twice on <select> elements for menu to show
* rendering/RenderPopupMenuMac.h:
* rendering/RenderPopupMenuMac.mm:
(WebCore::RenderPopupMenuMac::showPopup): Moved call to dismiss popup into hidePopup method.
Now calls RenderMenuList::hidePopup which will update the m_popupIsVisible flag on the menu list before hiding the popup.
(WebCore::RenderPopupMenuMac::hidePopup): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 5 Sep 2006 17:26:36 +0000 (17:26 +0000)]
Build fix for when XPATH_SUPPORT is not defined.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 5 Sep 2006 16:57:43 +0000 (16:57 +0000)]
Reviewed by Tim H.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10738
Consolidate the Objective-C DOM Bindings Internal files into DOMInternal.h
- Consolidate DOMHTMLInternal.h, DOMCSSInternal.h, DOMEventsInternal.h,
DOMViewsInternal.h and DOMXPathInternal.h into DOMInternal.h.
- Rename the "type-makers" (used to make a binding from an implementation
type) so that all the HTML ones begin with the prefix HTML. Did the same
for the CSS.
- Auto-generate a couple more methods from DOMExtensions.h.
- Various cleanups of the Objective-C auto-generation code.
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
(-[DOMDocument createCSSStyleDeclaration]):
* bindings/objc/DOMCSS.mm:
(+[DOMCSSRuleList _CSSRuleListWith:]):
(+[DOMCSSRule _CSSRuleWith:]):
(+[DOMCSSStyleDeclaration _CSSStyleDeclarationWith:]):
(+[DOMCSSValue _CSSValueWith:]):
(+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:]):
(-[DOMDocument getComputedStyle::]):
(-[DOMDocument getMatchedCSSRules::]):
* bindings/objc/DOMCSSInternal.h: Removed.
* bindings/objc/DOMEvents.mm:
* bindings/objc/DOMEventsInternal.h: Removed.
* bindings/objc/DOMEventsNonstandard.mm:
* bindings/objc/DOMExtensions.h:
* bindings/objc/DOMHTML.mm:
(+[DOMHTMLCollection _HTMLCollectionWith:]):
(+[DOMHTMLOptionsCollection _HTMLOptionsCollectionWith:]):
(+[DOMHTMLElement _HTMLElementWith:]):
(+[DOMHTMLFormElement _HTMLFormElementWith:]):
(+[DOMHTMLTableCaptionElement _HTMLTableCaptionElementWith:]):
(+[DOMHTMLTableSectionElement _HTMLTableSectionElementWith:]):
(+[DOMHTMLTableElement _HTMLTableElementWith:]):
(+[DOMHTMLTableCellElement _HTMLTableCellElementWith:]):
* bindings/objc/DOMHTMLAppletElement.mm:
* bindings/objc/DOMHTMLDocument.mm:
(-[DOMHTMLDocument body]):
(-[DOMHTMLDocument images]):
(-[DOMHTMLDocument applets]):
(-[DOMHTMLDocument links]):
(-[DOMHTMLDocument forms]):
(-[DOMHTMLDocument anchors]):
* bindings/objc/DOMHTMLInternal.h: Removed.
* bindings/objc/DOMHTMLOptionElement.mm:
(-[DOMHTMLOptionElement form]):
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMRGBColor.mm:
(setWrapperForRGB):
(-[DOMRGBColor red]):
(-[DOMRGBColor green]):
(-[DOMRGBColor blue]):
(-[DOMRGBColor alpha]):
* bindings/objc/DOMUtility.mm:
(KJS::ScriptInterpreter::createObjcInstanceForValue):
* bindings/objc/DOMViews.mm:
(-[DOMAbstractView WebCore::]):
(-[DOMAbstractView _initWithAbstractView:WebCore::]):
(+[DOMAbstractView _abstractViewWith:WebCore::]):
* bindings/objc/DOMViewsInternal.h: Removed.
* bindings/objc/DOMXPath.mm:
* bindings/objc/DOMXPathInternal.h: Removed.
* bindings/objc/PublicDOMInterfaces.h:
* bindings/scripts/CodeGeneratorObjC.pm:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge typingStyle]):
* html/HTMLAnchorElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLLinkElement.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 5 Sep 2006 16:24:04 +0000 (16:24 +0000)]
Build fix. Remove the now duplicate OS check and add PublicDOMInterfaces.h to the dependancy list for ObjC DOM files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Tue, 5 Sep 2006 07:27:30 +0000 (07:27 +0000)]
2006-09-05 Steve Falkenburg <sfalken@apple.com>
Conditionalize new DOM headers for ObjC only
* DerivedSources.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 5 Sep 2006 05:05:17 +0000 (05:05 +0000)]
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10716
XMLHttpRequest.responseText is null if HTTP response is empty
Extended existing tests:
- http/tests/xmlhttrequest/zero-length-response.html
- http/tests/xmlhttrequest/zero-length-response-sync.html
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest): Initialize responseText to an empty string.
(WebCore::XMLHttpRequest::open): Reset responseText to an empty string.
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::JSXMLHttpRequest::getValueProperty): Return null rather than undefined
for nil responseXML.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 5 Sep 2006 02:45:57 +0000 (02:45 +0000)]
WebCore:
Reviewed by Darin.
Bug 10714: ObjC autogeneration needs safe-guards against easily modifying the public API
http://bugzilla.opendarwin.org/show_bug.cgi?id=10714
- New PublicDOMInterfaces.h file is consulted when generating
the ObjC DOM files. All public DOM class interfaces, properties
and methods need to be in this file. Anything not in the file will
be generated into the appropriate private header file. During
generation if something changed or is missing in the public API
a build error will occur. New interfaces added to the IDLs files
will now not automatically be reflected in the public ObjC API.
Methods commented out in PublicDOMInterfaces.h are pending public
and will be uncommented once approved.
- Removed most of the Exclude=ObjC uses from the IDL files. This
attribute was mostly used to prevent changes to the public headers.
- Make a new parameter name if the original conflicts with a property name.
- Simplified the generation code for dealing with exceptions.
- Moved file opens to WriteData. Files are unlinked before
being opened to work around a Leopard file truncation bug.
- Fixed #imports for DOMImplementation to be DOMDOMImplementation.h
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMCSS.h:
* bindings/objc/DOMCore.h:
* bindings/objc/DOMExtensions.h:
* bindings/objc/DOMHTMLInternal.h:
* bindings/objc/DOMPrivate.h:
* bindings/objc/PublicDOMInterfaces.h: Added.
* bindings/scripts/CodeGeneratorObjC.pm:
* dom/Document.idl:
* dom/Element.idl:
* dom/NamedNodeMap.idl:
* dom/ProcessingInstruction.idl:
* html/HTMLAnchorElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLBodyElement.idl:
* html/HTMLButtonElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLLabelElement.idl:
* html/HTMLLegendElement.idl:
* html/HTMLLinkElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLPreElement.idl:
* html/HTMLStyleElement.idl:
* html/HTMLTextAreaElement.idl:
WebKit:
Reviewed by Darin.
Bug 10714: ObjC autogeneration needs safe-guards against easily modifying the public API
http://bugzilla.opendarwin.org/show_bug.cgi?id=10714
- Added the new private DOM headers.
- Factored out the common commands into variables.
- Made WebDashboardRegion.h private again.
- Rename DOMDOMImplementation.h to DOMImplementation.h when files
are migrated. Also fixes up #imports.
* MigrateHeaders.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 4 Sep 2006 23:36:14 +0000 (23:36 +0000)]
* Scripts/do-webcore-rename: More renaming plans.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 4 Sep 2006 23:16:06 +0000 (23:16 +0000)]
Another build fix now that the old style ObjC methods are deprecated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 4 Sep 2006 23:10:04 +0000 (23:10 +0000)]
Build fixes now that the old style ObjC methods are deprecated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 4 Sep 2006 22:57:19 +0000 (22:57 +0000)]
Reviewed by Tim H.
Continue fixing the build, I forgot this in my previous patch!
* platform/qt/PathQt.cpp:
(WebCore::Path::apply):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 4 Sep 2006 22:43:24 +0000 (22:43 +0000)]
Reviewed by Tim H.
Fix build on Qt/Linux.
* CMakeLists.txt:
* platform/qt/PathQt.cpp:
(WebCore::Path::transform):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 4 Sep 2006 22:28:29 +0000 (22:28 +0000)]
WebKitQt:
Reviewed by Tim H.
Fixes last part of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Move QtLauncher down to WebKitQt.
* QtLauncher/CMakeLists.txt: Added.
* QtLauncher/main.cpp: Added.
(main):
WebKitTools:
Reviewed by Tim H.
Fixes last part of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Move QtLauncher down to WebKitQt.
* QtLauncher/CMakeLists.txt: Removed.
* QtLauncher/main.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 4 Sep 2006 19:49:57 +0000 (19:49 +0000)]
The project file didn't get committed with my last checking.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 4 Sep 2006 18:34:29 +0000 (18:34 +0000)]
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10676
@charset rules not accessible via DOM
Test: fast/encoding/css-charset-dom.html
* WebCore.xcodeproj/project.pbxproj: Added CSSCharsetRule.cpp
* bindings/js/kjs_css.cpp:
(KJS::DOMCSSStyleSheet::getValueProperty):
Separated Rules and CssRules, since now they behave differently.
* css/CSSCharsetRule.h: Make the constructor take an encoding.
* css/CSSCharsetRule.cpp: Added.
* css/CSSGrammar.y: Create CSSStylesheetRules as necessary.
* css/CSSRuleList.cpp:
(WebCore::CSSRuleList::CSSRuleList):
* css/CSSRuleList.h:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::cssRules):
* css/CSSStyleSheet.h:
Skip charset rules in IE compatibility mode.
* css/StyleBase.h:
(WebCore::StyleBase::isCharsetRule): Fixed a typo.
* css/cssparser.cpp:
(WebCore::CSSParser::createCharsetRule):
* css/cssparser.h:
Added createCharsetRule().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 4 Sep 2006 17:37:04 +0000 (17:37 +0000)]
Reviewed by Darin.
Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Let FrameQt operate on a FrameQtClient, just like Win/Mac handle it.
* CMakeLists.txt:
* platform/qt/FrameQt.cpp:
(WebCore::FrameQt::FrameQt):
(WebCore::FrameQt::~FrameQt):
(WebCore::FrameQt::openURL):
(WebCore::FrameQt::submitForm):
(WebCore::FrameQt::urlSelected):
* platform/qt/FrameQt.h:
* platform/qt/FrameQtClient.cpp: Added.
(WebCore::FrameQtClientDefault::FrameQtClientDefault):
(WebCore::FrameQtClientDefault::~FrameQtClientDefault):
(WebCore::FrameQtClientDefault::setFrame):
(WebCore::FrameQtClientDefault::openURL):
(WebCore::FrameQtClientDefault::submitForm):
(WebCore::FrameQtClientDefault::receivedResponse):
(WebCore::FrameQtClientDefault::receivedData):
(WebCore::FrameQtClientDefault::receivedAllData):
* platform/qt/FrameQtClient.h: Added.
(WebCore::FrameQtClient::~FrameQtClient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 4 Sep 2006 17:34:29 +0000 (17:34 +0000)]
Reviewed by Darin.
Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Adjust DumpRenderTree to the FrameQtClient changes.
* DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::~DumpRenderTree):
(WebCore::DumpRenderTree::frame):
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.cpp: Added.
(WebCore::DumpRenderTreeClient::DumpRenderTreeClient):
(WebCore::DumpRenderTreeClient::~DumpRenderTreeClient):
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 4 Sep 2006 17:11:44 +0000 (17:11 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 4 Sep 2006 09:31:22 +0000 (09:31 +0000)]
2006-09-04 Eric Seidel <eric@eseidel.com>
Reviewed by andersca.
Clean-up style and spacing.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10724
No tests needed, no functional changes.
* ksvg2/svg/svgpathparser.cpp:
(WebCore::parseCoord):
(WebCore::SVGPolyParser::parsePoints):
(WebCore::SVGPathParser::parseSVG):
(WebCore::SVGPathParser::calculateArc):
(WebCore::SVGPathParser::svgLineToHorizontal):
(WebCore::SVGPathParser::svgLineToVertical):
(WebCore::SVGPathParser::svgCurveToCubicSmooth):
(WebCore::SVGPathParser::svgCurveToQuadratic):
(WebCore::SVGPathParser::svgCurveToQuadraticSmooth):
(WebCore::SVGPathParser::svgArcTo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Mon, 4 Sep 2006 09:22:18 +0000 (09:22 +0000)]
Reviewed by Eric.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6546
clipPath data does not respect transforms
Get the transform from the dom element and adjust
the clip path with it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Mon, 4 Sep 2006 07:57:56 +0000 (07:57 +0000)]
Reviewed by Eric.
This code should have gone in as part of:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10696
It addresses the comments there, also we use double instead
of float now in calculations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 4 Sep 2006 02:11:32 +0000 (02:11 +0000)]
WebCore:
Reviewed by Darin and Tim H.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10711
Auto-generate the Objective-C DOM Stylesheet bindings
Auto-generates DOMMediaList, DOMStyleSheet, and DOMStyleSheetList.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMCSS.mm:
(+[DOMStyleSheet _styleSheetWith:]):
(+[DOMCSSStyleSheet _CSSStyleSheetWith:]):
* bindings/objc/DOMCSSInternal.h:
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMObject.mm:
(-[DOMObject sheet]):
* bindings/objc/DOMPrivate.h:
* bindings/objc/DOMStylesheets.h:
* bindings/objc/DOMUtility.mm:
(KJS::ScriptInterpreter::createObjcInstanceForValue):
* bindings/scripts/CodeGeneratorObjC.pm:
* css/StyleSheet.idl: Added.
* css/StyleSheetList.idl: Added.
WebKit:
Reviewed by Darin and Tim H.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10711
Auto-generate the Objective-C DOM Stylesheet bindings
* MigrateHeaders.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 4 Sep 2006 01:00:16 +0000 (01:00 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 3 Sep 2006 22:19:43 +0000 (22:19 +0000)]
* Scripts/do-webcore-rename: More renaming plans.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sun, 3 Sep 2006 21:46:39 +0000 (21:46 +0000)]
Build fix to avoid warning about property name conflict.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Sun, 3 Sep 2006 21:31:30 +0000 (21:31 +0000)]
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10696
RenderPathQuartz and RenderPathQt should not be needed
Cleanup of code related to RenderPath.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sun, 3 Sep 2006 21:20:15 +0000 (21:20 +0000)]
Fix a typo Darin called out, but I forgot to change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sun, 3 Sep 2006 21:11:09 +0000 (21:11 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sun, 3 Sep 2006 20:48:45 +0000 (20:48 +0000)]
Changing the ignore rule for *.perspective to *.perspective*. This ignores the new .perspectivev3 file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log