WebKit-https.git
9 years agoUnreviewed build fix after r105256.
loislo@chromium.org [Wed, 18 Jan 2012 13:00:45 +0000 (13:00 +0000)]
Unreviewed build fix after r105256.

There was a cyclic dependency between self._port and self._host assigments.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: track HTML revisions when editing DOM and / or upon free flow edits.
pfeldman@chromium.org [Wed, 18 Jan 2012 12:52:46 +0000 (12:52 +0000)]
Web Inspector: track HTML revisions when editing DOM and / or upon free flow edits.
https://bugs.webkit.org/show_bug.cgi?id=76457

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/set-html-via-resource.html

* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchNode):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.setNodeName):
(WebInspector.DOMNode.prototype.setNodeValue):
(WebInspector.DOMNode.prototype.setAttribute):
(WebInspector.DOMNode.prototype.setAttributeValue):
(WebInspector.DOMNode.prototype.removeAttribute):
(WebInspector.DOMNode.prototype.getChildNodes.mycallback):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype.setOuterHTML):
(WebInspector.DOMNode.prototype.removeNode):
(WebInspector.DOMNode.prototype.moveTo):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._buildHighlightConfig):
(WebInspector.DOMAgent.prototype._markRevision):
(WebInspector.DOMAgent.prototype._captureDOM.callback):
(WebInspector.DOMAgent.prototype._captureDOM):
(WebInspector.DOMModelResourceBinding.prototype.setContent):
(WebInspector.DOMModelResourceBinding.prototype.setContent.setOuterHTML):
(WebInspector.DOMModelResourceBinding.prototype.setContent.withDocument):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):

LayoutTests:

* inspector/elements/resources/set-outer-html-body-iframe.html:
* inspector/elements/set-html-via-resource-expected.txt: Added.
* inspector/elements/set-html-via-resource.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Popover does not disappear, causes debugger failure.
caseq@chromium.org [Wed, 18 Jan 2012 12:46:55 +0000 (12:46 +0000)]
Web Inspector: Popover does not disappear, causes debugger failure.
https://bugs.webkit.org/show_bug.cgi?id=71363

Reviewed by Pavel Feldman.

This is a work-around simple enough for a merge. The real fix would
be to get TextViewer to manage the highlight on its own, so it's not
accidently removed while re-building DOM for the text chunk.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd new watchlist rule for the Qt build system
vestbo@webkit.org [Wed, 18 Jan 2012 11:33:06 +0000 (11:33 +0000)]
Add new watchlist rule for the Qt build system

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
vestbo@webkit.org [Wed, 18 Jan 2012 11:32:48 +0000 (11:32 +0000)]
[Qt] Move OTHER_FILES from WebKit.pro to Tools.pro

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Allow building only a subset of the WebKit sub-projects
vestbo@webkit.org [Wed, 18 Jan 2012 11:32:33 +0000 (11:32 +0000)]
[Qt] Allow building only a subset of the WebKit sub-projects

Fixes build-jsc, broken in r104825.

We no longer need the intermediate buildQMakeQtProject(), as we're the
only port using qmake, and buildQMakeProject is now highly Qt specific.

<http://webkit.org/b/76179>

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r105247 and r105253.
philn@webkit.org [Wed, 18 Jan 2012 11:25:21 +0000 (11:25 +0000)]
Unreviewed, GTK rebaseline after r105247 and r105253.

* platform/gtk/css3/images/cross-fade-overflow-position-expected.txt:
* platform/gtk/fast/forms/implicit-submission-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
* platform/gtk/svg/custom/pointer-events-image-css-transform-expected.txt:
* platform/gtk/svg/custom/pointer-events-image-expected.txt:
* platform/gtk/svg/custom/pointer-events-text-css-transform-expected.txt:
* platform/gtk/svg/custom/pointer-events-text-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorun-perf-tests should generate a json file that summaries the result
rniwa@webkit.org [Wed, 18 Jan 2012 10:52:41 +0000 (10:52 +0000)]
run-perf-tests should generate a json file that summaries the result
https://bugs.webkit.org/show_bug.cgi?id=76504

Reviewed by Adam Barth.

Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
New option --outout-json-path specifies the json file's path, and --source-json-path specifies
another json file to be merged into the generated json file.

Also fixed a bug that --build wasn't set by default.

* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.webkit_base):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__):
(PerfTestsRunner):
(PerfTestsRunner._parse_args):
(PerfTestsRunner.run):
(PerfTestsRunner._generate_json_if_specified):
(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._process_parser_test_result):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest):
(create_runner):
(test_run_test_set):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_summary_json):
(test_collect_tests):
(test_parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
commit-queue@webkit.org [Wed, 18 Jan 2012 10:52:07 +0000 (10:52 +0000)]
Unreviewed build fix.
https://bugs.webkit.org/show_bug.cgi?id=76525

Removed missing build headers.

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-18

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, fix clashing svg/custom/linking-a-03-b-viewBox.svg expectation.
apavlov@chromium.org [Wed, 18 Jan 2012 10:40:43 +0000 (10:40 +0000)]
[Chromium] Unreviewed, fix clashing svg/custom/linking-a-03-b-viewBox.svg expectation.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse RenderTheme in HTMLSelectElement instead of #defines.
commit-queue@webkit.org [Wed, 18 Jan 2012 10:39:31 +0000 (10:39 +0000)]
Use RenderTheme in HTMLSelectElement instead of #defines.
<http://webkit.org/b/76519>

Patch by Jun Mukai <mukai@chromium.org> on 2012-01-18
Reviewed by Kent Tamura.

Tests: no new tests because of no behavioral changes.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
* platform/gtk/RenderThemeGtk.h:
(WebCore::RenderThemeGtk::popsMenuByArrowKeys):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::popsMenuByArrowKeys):
(WebCore::RenderTheme::popsMenuBySpaceOrReturn):
* rendering/RenderThemeChromiumLinux.h:
(WebCore::RenderThemeChromiumLinux::popsMenuBySpaceOrReturn):
* rendering/RenderThemeMac.h:
(WebCore::RenderThemeMac::popsMenuByArrowKeys):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed: Chromium test_expectations.txt update
rolandsteiner@chromium.org [Wed, 18 Jan 2012 10:08:22 +0000 (10:08 +0000)]
Unreviewed: Chromium test_expectations.txt update

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Crash in FrameView::forceLayoutParentViewIfNeeded.
inferno@chromium.org [Wed, 18 Jan 2012 10:00:20 +0000 (10:00 +0000)]
Source/WebCore: Crash in FrameView::forceLayoutParentViewIfNeeded.
https://bugs.webkit.org/show_bug.cgi?id=76309

Reviewed by Nikolas Zimmermann.

updateWidgetPositions can blow away the owning renderer
and its frameview, so need to protect it with refptr.

Test: svg/dom/parent-view-layout-crash.html

* page/FrameView.cpp:
(WebCore::FrameView::forceLayoutParentViewIfNeeded):

LayoutTests: Crash in FrameView::forceLayoutParentViewIfNeeded.
https://bugs.webkit.org/show_bug.cgi?id=76309

Reviewed by Nikolas Zimmermann.

* svg/dom/parent-view-layout-crash-expected.txt: Added.
* svg/dom/parent-view-layout-crash.html: Added.
* svg/dom/resources/svg-font-face.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove ShadowContentElement from dom/ to html/ and make ShadowContentElement subclass...
commit-queue@webkit.org [Wed, 18 Jan 2012 09:15:24 +0000 (09:15 +0000)]
Move ShadowContentElement from dom/ to html/ and make ShadowContentElement subclass of HTMLElement.
https://bugs.webkit.org/show_bug.cgi?id=76241

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-18
Reviewed by Dimitri Glazkov.

.:

* Source/autotools/symbols.filter: Exposed necessary symbols.

Source/WebCore:

Renamed ShadowContentElement to HTMLContentElement, and move it from dom/ to html/.
Also, ShadowInclusionSelector and ShadowContentSelectorQuery are renamed to
Content InclusionSelector and ContentSelectorQuery respectively.

No new tests, because no change in behavior.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/NodeRenderingContext.cpp:
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
* dom/NodeRenderingContext.h:
(WebCore::NodeRenderingContext::includer):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):
* dom/ShadowRoot.h:
* html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
* html/HTMLElementsAllInOne.cpp:
* html/HTMLSummaryElement.cpp:
(WebCore::SummaryContentElement::SummaryContentElement):
* html/shadow/ContentInclusionSelector.cpp: Renamed from Source/WebCore/dom/ShadowInclusionSelector.cpp.
(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ContentInclusionSelector::ContentInclusionSelector):
(WebCore::ContentInclusionSelector::~ContentInclusionSelector):
(WebCore::ContentInclusionSelector::select):
(WebCore::ContentInclusionSelector::unselect):
(WebCore::ContentInclusionSelector::findFor):
(WebCore::ContentInclusionSelector::didSelect):
(WebCore::ContentInclusionSelector::willSelectOver):
* html/shadow/ContentInclusionSelector.h: Renamed from Source/WebCore/dom/ShadowInclusionSelector.h.
(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):
(WebCore::ContentInclusionSelector::hasCandidates):
* html/shadow/ContentSelectorQuery.cpp: Renamed from Source/WebCore/dom/ShadowContentSelectorQuery.cpp.
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::matches):
* html/shadow/ContentSelectorQuery.h: Renamed from Source/WebCore/dom/ShadowContentSelectorQuery.h.
* html/shadow/HTMLContentElement.cpp: Renamed from Source/WebCore/dom/ShadowContentElement.cpp.
(WebCore::HTMLContentElement::create):
(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::~HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::select):
(WebCore::HTMLContentElement::setSelect):
* html/shadow/HTMLContentElement.h: Renamed from Source/WebCore/dom/ShadowContentElement.h.
(WebCore::HTMLContentElement::inclusions):
(WebCore::HTMLContentElement::isContentElement):
(WebCore::HTMLContentElement::rendererIsNeeded):
(WebCore::HTMLContentElement::createRenderer):
(WebCore::toHTMLContentElement):
* testing/Internals.cpp:
(WebCore::Internals::createContentElement):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def: Exposed necessary symbols.
* win/WebKit2CFLite.def: ditto.

LayoutTests:

Renamed internals.createShadowContentElement to internals.createContentElement.

* fast/dom/shadow/content-element-includer.html:
* fast/dom/shadow/content-element-renderers.html:
* fast/dom/shadow/create-content-element.html:
* fast/dom/shadow/shadow-contents-select.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix GTK+ build after r105245.
carlosgc@webkit.org [Wed, 18 Jan 2012 09:04:22 +0000 (09:04 +0000)]
Unreviewed. Fix GTK+ build after r105245.

* Source/autotools/symbols.filter: Fix symbol name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRenderSVGRoot should inherit from RenderReplaced
zimmermann@webkit.org [Wed, 18 Jan 2012 08:45:17 +0000 (08:45 +0000)]
RenderSVGRoot should inherit from RenderReplaced
https://bugs.webkit.org/show_bug.cgi?id=76446

Reviewed by Zoltan Herczeg.

Source/WebCore:

Let RenderSVGRoot inherit from RenderReplaced, instead of faking RenderReplaced, by inherting from RenderBox
and calling setReplaced(true) in the constructor. The outermost <svg> element is a replaced element in the
sense of CSS, and thus this is just a logical move. It fixes some issues where the <svg> root appeared
as selection leaf, covered by existing tests.

It allows us to simplify the painting, as outlines, etc. are painted by RenderReplaced now.
While I was it, speed up the local to border box computations by caching the result.

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::paintReplaced):
(WebCore::RenderSVGRoot::willBeDestroyed):
(WebCore::RenderSVGRoot::styleWillChange):
(WebCore::RenderSVGRoot::styleDidChange):
(WebCore::RenderSVGRoot::updateFromElement):
(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):
(WebCore::RenderSVGRoot::localToParentTransform):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
(WebCore::RenderSVGRoot::mapLocalToContainer):
(WebCore::RenderSVGRoot::nodeAtPoint):
* rendering/svg/RenderSVGRoot.h:
(WebCore::RenderSVGRoot::canHaveChildren):
(WebCore::RenderSVGRoot::canBeSelectionLeaf):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setupInitialView):

LayoutTests:

Update test results after making RenderSVGRoot inherit from RenderReplaced.

* platform/chromium/test_expectations.txt:
* platform/mac/svg/custom/linking-a-03-b-all-expected.png: Text layout changed, we didn't relayout the tree when entering a new view before.
* platform/mac/svg/custom/linking-a-03-b-all-expected.txt: Ditto.
* platform/mac/svg/custom/linking-a-03-b-viewBox-expected.png: Ditto.
* platform/mac/svg/custom/linking-a-03-b-viewBox-expected.txt: Ditto.
* platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png: Ditto.
* platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-container-expected.png: Moving the circle, triggered a selection before, where it shouldn't. It's gone now.
* platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-root-expected.png: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Ditto.
* platform/mac/svg/custom/pointer-events-image-css-transform-expected.png: Caret position which is reported changed, due the selection leaf changes.
* platform/mac/svg/custom/pointer-events-image-css-transform-expected.txt: Ditto.
* platform/mac/svg/custom/pointer-events-image-expected.png: Ditto.
* platform/mac/svg/custom/pointer-events-image-expected.txt: Ditto.
* platform/mac/svg/custom/pointer-events-text-css-transform-expected.png: Ditto.
* platform/mac/svg/custom/pointer-events-text-css-transform-expected.txt: Ditto.
* platform/mac/svg/custom/pointer-events-text-expected.png: Ditto.
* platform/mac/svg/custom/pointer-events-text-expected.txt: Ditto.
* platform/mac/svg/foreignObject/text-tref-02-b-expected.png: This now reports a valid size for the RenderSVGRoot in the <fO> subtree.
* svg/foreignObject/text-tref-02-b-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r105244.
rolandsteiner@chromium.org [Wed, 18 Jan 2012 07:36:49 +0000 (07:36 +0000)]
Unreviewed, rolling out r105244.
http://trac.webkit.org/changeset/105244
https://bugs.webkit.org/show_bug.cgi?id=76518

broke Chromium Mac (Requested by rolandsteiner on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-17

Source/WebCore:

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::checkboxOrRadioValue):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp:
* accessibility/AccessibilityScrollView.h:

Source/WebKit/chromium:

* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:

Tools:

* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::removeSelection):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::removeSelection):

LayoutTests:

* platform/chromium/accessibility/scroll-to-global-point-iframe-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html: Removed.
* platform/chromium/accessibility/scroll-to-global-point-iframe.html: Removed.
* platform/chromium/accessibility/scroll-to-global-point-main-window-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-global-point-main-window.html: Removed.
* platform/chromium/accessibility/scroll-to-global-point-nested-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-global-point-nested.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-iframe-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-iframe.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-main-window-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-main-window.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-nested-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-nested.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Internals] Should be able to access corresponding Document object.
commit-queue@webkit.org [Wed, 18 Jan 2012 06:55:01 +0000 (06:55 +0000)]
[Internals] Should be able to access corresponding Document object.
https://bugs.webkit.org/show_bug.cgi?id=76425

.:

Added exported symbols.

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Adam Barth.

* Source/autotools/symbols.filter:

Source/WebCore:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Adam Barth.

- Allow FrameDestructionObserver to re-setting the Frame reference.
- Make Internals a subclass of FrameDestructionObserver.

Since Internals::reset() is called for each test, we can access
the acive Frame object during the test. The frame reference will be
used by coming changes.

No new tests. Covered by existing tests.

* WebCore.exp.in:
* page/FrameDestructionObserver.cpp:
(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::observe):
* page/FrameDestructionObserver.h:
* testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::reset):
* testing/Internals.h:

Source/WebKit2:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Adam Barth.

* win/WebKit2.def: Added exporting symbols.
* win/WebKit2CFLite.def: Added exporting symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAccessibility: Chromium needs methods to scroll an object into view or to a specific...
dmazzoni@google.com [Wed, 18 Jan 2012 06:41:51 +0000 (06:41 +0000)]
Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
https://bugs.webkit.org/show_bug.cgi?id=73460

Reviewed by Chris Fleizach.

Source/WebCore:

Tests: platform/chromium/accessibility/scroll-to-global-point-main-window.html
       platform/chromium/accessibility/scroll-to-global-point-nested.html
       platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html
       platform/chromium/accessibility/scroll-to-make-visible-iframe.html
       platform/chromium/accessibility/scroll-to-make-visible-main-window.html
       platform/chromium/accessibility/scroll-to-make-visible-nested.html
       platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html

* accessibility/AccessibilityObject.cpp:
(WebCore::computeBestScrollOffset):
(WebCore::AccessibilityObject::scrollToMakeVisible):
(WebCore::AccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebCore::AccessibilityObject::scrollToGlobalPoint):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityObject::scrollTo):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityRenderObject::scrollTo):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable):
(WebCore::AccessibilityScrollView::scrollTo):
* accessibility/AccessibilityScrollView.h:

Source/WebKit/chromium:

* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::scrollToMakeVisible):
(WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebKit::WebAccessibilityObject::scrollToGlobalPoint):

Tools:

* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::scrollToMakeVisibleCallback):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
(AccessibilityUIElement::scrollToGlobalPointCallback):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):

LayoutTests:

* platform/chromium/accessibility/scroll-to-global-point-iframe-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-main-window-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-main-window.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-nested.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-iframe-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-iframe.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-main-window-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-main-window.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-nested.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixing broken build. Missed a file in r105234.
mdelaney@apple.com [Wed, 18 Jan 2012 06:39:17 +0000 (06:39 +0000)]
Fixing broken build. Missed a file in r105234.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=75089
commit-queue@webkit.org [Wed, 18 Jan 2012 06:06:09 +0000 (06:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75089
Access-Control-Request-Headers value should be lowercase

Source/WebCore:

Access-Control-Request-Headers is used when issuing a preflight request to let the server know
the HTTP headers that will be used when the actual request is made.
As per the W3C specification, Access-Control-Request-Headers value should be set in lowercase.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-17
Reviewed by Alexey Proskuryakov.

Test: http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase.html

* loader/CrossOriginAccessControl.cpp:
(WebCore::createAccessControlPreflightRequest): setting Access-Control-Request-Headers value to lowercase

LayoutTests:

Added test to verify that the Access-Control-Request-Headers value is sent in lowercase.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-17
Reviewed by Alexey Proskuryakov.

* http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase.html: Added.
* http/tests/xmlhttprequest/resources/access-control-preflight-request-header-lowercase.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean EventContext and move phase-tweaking logic to EventDispatcher.
hayato@chromium.org [Wed, 18 Jan 2012 05:49:52 +0000 (05:49 +0000)]
Clean EventContext and move phase-tweaking logic to EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=76414

Reviewed by Dimitri Glazkov.

No tests. No change in behavior.

* dom/EventContext.cpp:
(WebCore::EventContext::handleLocalEvents):
* dom/EventContext.h:
(WebCore::EventContext::currentTargetSameAsTarget):
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Use static const insted of #define macro.
gyuyoung.kim@samsung.com [Wed, 18 Jan 2012 04:28:36 +0000 (04:28 +0000)]
[EFL] Use static const insted of #define macro.
https://bugs.webkit.org/show_bug.cgi?id=76499

Reviewed by Hajime Morita.

WebKit coding style prefers const to #define. EFL port needs to use const insted of #define macro.
This patch replace global variables defined by #define with const.

* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_zoom_set_internal):
* ewk/ewk_tiled_backing_store.h:
* ewk/ewk_tiled_matrix.cpp:
(ewk_tile_matrix_new):
* ewk/ewk_view.cpp:
(_ewk_view_repaint_add):
(_ewk_view_repaints_flush):
(_ewk_view_scroll_add):
(_ewk_view_scrolls_flush):
(_ewk_view_priv_new):
(ewk_view_base_smart_set):
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_smart_pre_render_start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove public/WebWorker.h from the gyp projects
noel.gordon@gmail.com [Wed, 18 Jan 2012 04:15:02 +0000 (04:15 +0000)]
[chromium] Remove public/WebWorker.h from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=76512

Reviewed by David Levin.

public/WebWorker.h was removed in r105020, remove references from the gyp projects.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed to figure out which assert is firing when worker-read-blob-async.html fails.
levin@chromium.org [Wed, 18 Jan 2012 04:13:17 +0000 (04:13 +0000)]
Need to figure out which assert is firing when worker-read-blob-async.html fails.
https://bugs.webkit.org/show_bug.cgi?id=76503

Reviewed by Adam Barth.

No new functionality exposed so no new tests.

This is just a quick and dirty way to make these asserts unique
to expose which one of them is firing on a machine that doesn't have a
good stack trace.

* dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable tests on the mac-ews
abarth@webkit.org [Wed, 18 Jan 2012 04:01:27 +0000 (04:01 +0000)]
Enable tests on the mac-ews
https://bugs.webkit.org/show_bug.cgi?id=76502

Reviewed by Simon Fraser.

Apple now has five machines running the mac-ews.  Lucas Forschler has
asked that we try enabling tests to see if we have enough bandwidth.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOn post-Lion releases, preserve the Lion behavior where WebKit explicitly calls ...
mdelaney@apple.com [Wed, 18 Jan 2012 03:59:02 +0000 (03:59 +0000)]
On post-Lion releases, preserve the Lion behavior where WebKit explicitly calls -setGeometryFlipped on the hosting layer for applications that were linked on Lion or earlier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClear 'm_size' of DrawingBuffer in the 'clear' function
commit-queue@webkit.org [Wed, 18 Jan 2012 03:24:38 +0000 (03:24 +0000)]
Clear 'm_size' of DrawingBuffer in the 'clear' function
https://bugs.webkit.org/show_bug.cgi?id=76239

Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2012-01-17
Reviewed by Kenneth Russell.

Clear the resources of DrawingBuffer but don't clear 'm_size'. This makes
's_currentResourceUsePixels' is not calculated correctly.

* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a check-webkit-style exception for GDBInterface.cpp
commit-queue@webkit.org [Wed, 18 Jan 2012 03:19:09 +0000 (03:19 +0000)]
Add a check-webkit-style exception for GDBInterface.cpp
https://bugs.webkit.org/show_bug.cgi?id=76187

Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
that it does not fail the style check.

Patch by Sanjoy Das <sanjoy@playingwithpointers.com> on 2012-01-17
Reviewed by Martin Robinson.

* Scripts/webkitpy/style/checker.py: Tell the style checker to not run
readability/naming tests on
Source/JavaScriptCore/jit/GDBInterface.cpp.
* Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_path_rules_specifier): Add a test for
the above exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix getBBox for perpendicular paths
commit-queue@webkit.org [Wed, 18 Jan 2012 03:16:47 +0000 (03:16 +0000)]
Fix getBBox for perpendicular paths
https://bugs.webkit.org/show_bug.cgi?id=76177

Patch by Philip Rogers <pdr@google.com> on 2012-01-17
Reviewed by Darin Adler.

Source/WebCore:

Test: svg/custom/getBBox-perpendicular-path.svg

* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::unite):
(WebCore::FloatRect::uniteEvenIfEmpty):
(WebCore::FloatRect::uniteIfNonZero):
* platform/graphics/FloatRect.h:
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

LayoutTests:

* svg/custom/getBBox-perpendicular-path-expected.txt: Added.
* svg/custom/getBBox-perpendicular-path.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Apply color profiles in more cases
kbr@google.com [Wed, 18 Jan 2012 03:09:16 +0000 (03:09 +0000)]
[chromium] Apply color profiles in more cases
https://bugs.webkit.org/show_bug.cgi?id=76498

Reviewed by Stephen White.

Not adding new tests, as application of the color profile is not
guaranteed for images used as textures in WebGL. Ran existing
WebGL layout tests; all pass.

* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::setStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark some compositing tests as failing with an IMAGE diff due to video...
jamesr@google.com [Wed, 18 Jan 2012 02:48:00 +0000 (02:48 +0000)]
[chromium] Mark some compositing tests as failing with an IMAGE diff due to video playback problem

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix media handling in compositing tests after r105219.
simon.fraser@apple.com [Wed, 18 Jan 2012 02:43:13 +0000 (02:43 +0000)]
Fix media handling in compositing tests after r105219.

Reviewed by James Robinson.

Seeking seems to have issues on Chromium, and cause these tests to
timeout, so change the tests to play, then seek back to time 0.

New image results now show the first frame of the movie.

* compositing/resources/media-testing.js:
(ensureFrameVisible):
* platform/mac/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/mac/compositing/geometry/video-opacity-overlay-expected.png:
* platform/mac/compositing/layers-inside-overflow-scroll-expected.png:
* platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
* platform/mac/compositing/self-painting-layers-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename quickLookPreviewItemsAtWindowLocation: to quickLookWithEvent:
weinig@apple.com [Wed, 18 Jan 2012 02:18:28 +0000 (02:18 +0000)]
Rename quickLookPreviewItemsAtWindowLocation: to quickLookWithEvent:
<rdar://problem/10688913>

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView quickLookWithEvent:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnsure we don't cancel revalidation of a CachedResource
japhet@chromium.org [Wed, 18 Jan 2012 02:06:42 +0000 (02:06 +0000)]
Ensure we don't cancel revalidation of a CachedResource
in the middle of successful revalidation.
It's more reliable to enforce this in CachedResource than in
SubresourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=75713

Reviewed by Adam Barth.

No new test, the buggy case requires a non-stubbed window.print().

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didFinishLoading):
* loader/SubresourceLoader.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::clearResourceToRevalidate):
(WebCore::CachedResource::switchClientsToRevalidatedResource):
* loader/cache/CachedResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTweak results.html keyboard handling and flagging UI
ojan@chromium.org [Wed, 18 Jan 2012 02:06:19 +0000 (02:06 +0000)]
Tweak results.html keyboard handling and flagging UI
https://bugs.webkit.org/show_bug.cgi?id=76331

Reviewed by Simon Fraser.

-Make it so that hitting j/k at the start selects the first/last test
instead of the second/none'th test.
-Use the unicode black flag character instead of " (flagged)"
-Make the text color of the whole selected row red. This showed
which row was selected without being to garish I think.
-Allow for having the flagged tests be space-separated instead of
newline separated.

* fast/harness/resources/results-test.js:
* fast/harness/results-expected.txt:
* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNULL ptr in WebCore::RenderSVGInlineText::localCaretRect
commit-queue@webkit.org [Wed, 18 Jan 2012 02:03:30 +0000 (02:03 +0000)]
NULL ptr in WebCore::RenderSVGInlineText::localCaretRect
https://bugs.webkit.org/show_bug.cgi?id=75851

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-17
Reviewed by Ryosuke Niwa.

.:

Added a check for null box in localCaretRect, to match test in other
implementations. Adding a manual test because the crash is not
reproducible in DRT.

* ManualTests/svg-modify-deleted-selection.svg: Added.

Source/WebCore:

Added a check for null box in localCaretRect, to match test in other
implementations. Adding a manual test because the crash is not reproducible
in DRT.

Test: ManualTests/svg-modify-deleted-selection.svg

* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFactored out some code into a helper function.
ggaren@apple.com [Wed, 18 Jan 2012 02:00:44 +0000 (02:00 +0000)]
Factored out some code into a helper function.

I think this might help getting rid of omit-frame-pointer.

Reviewed by Sam Weinig.

No benchmark change.

* runtime/StringPrototype.cpp:
(JSC::removeUsingRegExpSearch): Moved to here...
(JSC::replaceUsingRegExpSearch): ...from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReduce the number of compositing test failures
simon.fraser@apple.com [Wed, 18 Jan 2012 01:18:20 +0000 (01:18 +0000)]
Reduce the number of compositing test failures
https://bugs.webkit.org/show_bug.cgi?id=76495

Reviewed by James Robinson.

General cleanup of compositing tests:
    * video tests now do a seek to guarantee that the pixel result will show a frame
    * video tests use a shared JS file (can't use media/video-test.js because it always
    calls dumpAsText(), which is not reversible).
    * ideo-with-invalid-source.html fixed to use a file extension so that the
    error event fires (bug 76494).
    * pixel results rebaselined.

* compositing/geometry/clipped-video-controller.html:
* compositing/geometry/video-fixed-scrolling.html:
* compositing/geometry/video-opacity-overlay.html:
* compositing/layers-inside-overflow-scroll.html:
* compositing/overflow/scroll-ancestor-update.html:
* compositing/reflections/load-video-in-reflection.html:
* compositing/resources/media-testing.js: Added.
(ensureFrameVisible):
* compositing/self-painting-layers.html:
* compositing/video/video-with-invalid-source.html:
* compositing/visibility/visibility-simple-video-layer.html:
* platform/mac/compositing/color-matching/image-color-matching-expected.png:
* platform/mac/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/mac/compositing/geometry/video-opacity-overlay-expected.png:
* platform/mac/compositing/layers-inside-overflow-scroll-expected.png:
* platform/mac/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/mac/compositing/overflow/scroll-ancestor-update-expected.txt:
* platform/mac/compositing/plugins/composited-plugin-expected.png:
* platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
* platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
* platform/mac/compositing/self-painting-layers-expected.png:
* platform/mac/compositing/video/video-background-color-expected.png:
* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=76245
commit-queue@webkit.org [Wed, 18 Jan 2012 01:16:30 +0000 (01:16 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=76245
[Mac][DRT] should allow query string for the file URL.

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Tony Chang.

Taught DRT about file:// as a url instead of a file path.
We are now able to use a path file:///foo/bar.html?baz as a url
with which DRT opens "/foo/bar.html" with "baz" as a query string.

* DumpRenderTree/mac/DumpRenderTree.mm:
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUint8ClampedArray support
caio.oliveira@openbossa.org [Wed, 18 Jan 2012 01:11:16 +0000 (01:11 +0000)]
Uint8ClampedArray support
https://bugs.webkit.org/show_bug.cgi?id=74455

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromClassInfo):
* bytecode/PredictedType.h:
(JSC::isUint8ClampedArrayPrediction):
(JSC::isActionableMutableArrayPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateUint8ClampedArray):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::clampDoubleToByte):
(JSC::DFG::compileClampIntegerToByte):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSCell.h:
* runtime/JSGlobalData.h:
* wtf/Forward.h:
* wtf/Uint8Array.h:
* wtf/Uint8ClampedArray.h: Added.
(WTF::Uint8ClampedArray::set):
(WTF::Uint8ClampedArray::create):
(WTF::Uint8ClampedArray::Uint8ClampedArray):
(WTF::Uint8ClampedArray::subarray):

Source/WebCore:

Test: fast/js/dfg-uint8clampedarray.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* ForwardingHeaders/wtf/Uint8ClampedArray.h: Added.
* GNUmakefile.list.am:
* Target.pri:
* UseJSC.cmake:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSUint8ClampedArrayCustom.cpp: Added.
(WebCore::JSUint8ClampedArray::indexSetter):
(WebCore::toJS):
(WebCore::JSUint8ClampedArray::set):
(WebCore::JSUint8ClampedArrayConstructor::constructJSUint8ClampedArray):
* bindings/scripts/CodeGeneratorJS.pm:
(IsTypedArrayType):
(GenerateHeader):
* html/canvas/Uint8ClampedArray.idl: Added.
* page/DOMWindow.idl:

Source/WTF:

* WTF.pro:

LayoutTests:

* fast/canvas/webgl/array-unit-tests-expected.txt:
* fast/canvas/webgl/array-unit-tests.html:
* fast/dom/Window/script-tests/window-property-descriptors.js:
* fast/dom/Window/window-properties.html:
* fast/dom/script-tests/constructed-objects-prototypes.js:
(constructorPropertiesOnWindow):
* fast/dom/script-tests/prototype-inheritance-2.js:
(constructorNamesForWindow):
* fast/js/dfg-uint8clampedarray-expected.txt: Added.
* fast/js/dfg-uint8clampedarray.html: Added.
* fast/js/script-tests/dfg-uint8clampedarray.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
* fast/js/script-tests/global-constructors.js:
* platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt: Copied from LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update baselines
jamesr@google.com [Wed, 18 Jan 2012 00:50:43 +0000 (00:50 +0000)]
[chromium] Update baselines

* platform/chromium-linux/animations/cross-fade-webkit-mask-box-image-expected.png:
* platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png:
* platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.png:
* platform/chromium-win/svg/carto.net/window-expected.png:
* platform/chromium-win/svg/carto.net/window-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck style on test_expectations.txt files before commit
ojan@chromium.org [Wed, 18 Jan 2012 00:41:07 +0000 (00:41 +0000)]
Check style on test_expectations.txt files before commit
https://bugs.webkit.org/show_bug.cgi?id=76484

Reviewed by Adam Barth.

Unlike other style rules, if you get the syntax of the test_expectations.txt
file wrong, the layout tests won't run. Also, this check is simple and only
slows down committing if you actually modify one of the test_expectations.txt files.

* Scripts/webkitpy/tool/steps/commit.py:
(Commit._check_test_expectations):
(Commit.run):
* Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
(CommitTest):
(CommitTest.test_check_test_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in in WebCore::EventHandler::mouseMoved.
inferno@chromium.org [Wed, 18 Jan 2012 00:33:10 +0000 (00:33 +0000)]
Crash in in WebCore::EventHandler::mouseMoved.
https://bugs.webkit.org/show_bug.cgi?id=76462

Reviewed by Ryosuke Niwa.

Source/WebCore:

handleMouseMoveEvent call in EventHandler::mouseMoved can
blow away the frame from underneath. Protect it with a frameview
refptr.

Test: fast/events/mouse-moved-remove-frame-crash.html

* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):

LayoutTests:

* fast/events/mouse-moved-remove-frame-crash-expected.txt: Added.
* fast/events/mouse-moved-remove-frame-crash.html: Added.
* fast/events/resources/mouse-move.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncrease test coverage for -webkit-border-image.
alexis.menard@openbossa.org [Wed, 18 Jan 2012 00:12:40 +0000 (00:12 +0000)]
Increase test coverage for -webkit-border-image.
https://bugs.webkit.org/show_bug.cgi?id=76473

Reviewed by Tony Chang.

Make sure we also set the width of the border in the shorthand. It will help
in the future to remove CSSBorderImageValue class without breaking this property.

* fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-border-image.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Debug build fails with debug qt5
ostapenko.viatcheslav@nokia.com [Wed, 18 Jan 2012 00:10:53 +0000 (00:10 +0000)]
[Qt] Debug build fails with debug qt5
https://bugs.webkit.org/show_bug.cgi?id=76463

Reviewed by Simon Hausmann.

Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.

Source/WebKit/qt:

* WebCoreSupport/FrameNetworkingContextQt.cpp:

Tools:

* QtTestBrowser/cookiejar.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update expectations for line-grid tests and one random svg thing
jamesr@google.com [Wed, 18 Jan 2012 00:06:37 +0000 (00:06 +0000)]
[chromium] Update expectations for line-grid tests and one random svg thing

* platform/chromium-linux/fast/line-grid/line-grid-floating-expected.png: Added.
* platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png: Added.
* platform/chromium-linux/fast/line-grid/line-grid-into-floats-expected.png: Added.
* platform/chromium-linux/fast/line-grid/line-grid-positioned-expected.png: Added.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-floating-expected.png: Added.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-inside-columns-expected.png: Added.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-into-floats-expected.png: Added.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-positioned-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-floating-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-inside-columns-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-into-floats-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-positioned-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-floating-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-floating-expected.txt: Added.
* platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
* platform/chromium-win/fast/line-grid/line-grid-into-floats-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-into-floats-expected.txt: Added.
* platform/chromium-win/fast/line-grid/line-grid-positioned-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-positioned-expected.txt: Added.
* platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.png:
* platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update expectations/baselines for cross-fade change
jamesr@google.com [Tue, 17 Jan 2012 23:57:45 +0000 (23:57 +0000)]
[chromium] Update expectations/baselines for cross-fade change

* css3/images/cross-fade-overflow-position-expected.txt: Renamed from LayoutTests/platform/mac/css3/images/cross-fade-overflow-position-expected.txt.
* platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png:
* platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png:
* platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png:
* platform/chromium/test_expectations.txt:
* platform/qt/css3/images/cross-fade-overflow-position-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd helper macro for forward declaring objective-c classes
weinig@apple.com [Tue, 17 Jan 2012 23:46:16 +0000 (23:46 +0000)]
Add helper macro for forward declaring objective-c classes
https://bugs.webkit.org/show_bug.cgi?id=76485

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

* wtf/Compiler.h:
Add OBJC_CLASS macro which helps reduce code when forward declaring an
objective-c class in a header which can be included from both Objective-C
and non-Objective-C files.

Source/WebCore:

* accessibility/AccessibilityObject.h:
* bindings/js/ScriptController.h:
* bridge/objc/objc_utility.h:
* page/DragClient.h:
* page/EditorClient.h:
* platform/AutodrainedPool.h:
* platform/ContextMenuItem.h:
* platform/Cursor.h:
* platform/DragData.h:
* platform/DragImage.h:
* platform/KURL.h:
* platform/Pasteboard.h:
* platform/PlatformKeyboardEvent.h:
* platform/PlatformMenuDescription.h:
* platform/PlatformScreen.h:
* platform/SharedBuffer.h:
* platform/Widget.h:
* platform/cf/SchedulePair.h:
* platform/graphics/BitmapImage.h:
* platform/graphics/FontPlatformData.h:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/GraphicsLayer.h:
* platform/graphics/Icon.h:
* platform/graphics/Image.h:
* platform/graphics/MediaPlayer.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/ca/PlatformCAAnimation.h:
* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/mac/ColorMac.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerProxy.h:
* platform/mac/ClipboardMac.h:
* platform/mac/LocalCurrentGraphicsContext.h:
* platform/mac/PasteboardHelper.h:
* platform/mac/PopupMenuMac.h:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/WebCoreSystemInterface.h:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/cf/AuthenticationChallenge.h:
* platform/network/cf/ResourceError.h:
* platform/network/cf/ResourceRequest.h:
* platform/network/cf/ResourceResponse.h:
* rendering/RenderThemeMac.h:
Deploy OBJC_CLASS for a little code reduction.

Source/WebKit2:

* WebProcess/WebCoreSupport/WebDragClient.h:
Deploy OBJC_CLASS for a little code reduction.

* config.h:
Remove duplicate copy of OBJC_CLASS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix duplicate expectations for canvas tests on mac
jamesr@google.com [Tue, 17 Jan 2012 23:31:57 +0000 (23:31 +0000)]
[chromium] Fix duplicate expectations for canvas tests on mac

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r101413): Correction panel overlaps misspelled text.
enrica@apple.com [Tue, 17 Jan 2012 23:26:12 +0000 (23:26 +0000)]
REGRESSION (r101413): Correction panel overlaps misspelled text.
https://bugs.webkit.org/show_bug.cgi?id=74589
<rdar://problem/10585115>

When converting the rectangle from the root view, we need
to take into account the height of the rectangle.

Reviewed by Anders Carlsson.

* WebView/WebView.mm:
(-[WebView _convertRectFromRootView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert some fast/regions pixel tests to reftests
commit-queue@webkit.org [Tue, 17 Jan 2012 23:25:53 +0000 (23:25 +0000)]
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=74133

Patch by Jacob Goldstein <jacobg@adobe.com> on 2012-01-17
Reviewed by Tony Chang.

* fast/regions/webkit-flow-inlines-dynamic-expected.html: Added.
* fast/regions/webkit-flow-inlines-dynamic.html:
* platform/efl/fast/regions/webkit-flow-inlines-dynamic-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Removed.
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png: Removed.
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: fix json import on linux
dpranke@chromium.org [Tue, 17 Jan 2012 23:10:46 +0000 (23:10 +0000)]
webkitpy: fix json import on linux
https://bugs.webkit.org/show_bug.cgi?id=76481

Reviewed by Adam Barth.

For some reason, the version of simplejson autoinstalled on my linux
box seems to be broken. We should really only be using
simplejson if json isn't available anyway, so this change looks
for json first.

* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
(JSONGeneratorTest.test_test_timings_trie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix failures in test-webkitpy caused by r105177.
dpranke@chromium.org [Tue, 17 Jan 2012 22:31:33 +0000 (22:31 +0000)]
Fix failures in test-webkitpy caused by r105177.

Unreviewed, build fix.

* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._static_build_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening after r105172.
ossy@webkit.org [Tue, 17 Jan 2012 22:14:49 +0000 (22:14 +0000)]
[Qt] Unreviewed gardening after r105172.

* platform/qt/css3/images/cross-fade-overflow-position-expected.png:
* platform/qt/css3/images/cross-fade-overflow-position-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd some canvas tests to test_expectations to prepare for changes to use sw-rasterize...
commit-queue@webkit.org [Tue, 17 Jan 2012 21:43:47 +0000 (21:43 +0000)]
Add some canvas tests to test_expectations to prepare for changes to use sw-rasterized paths in skia-gpu
https://bugs.webkit.org/show_bug.cgi?id=76469

Patch by Brian Salomon <bsalomon@google.com> on 2012-01-17
Reviewed by Stephen White.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpaceSplitString: Share equivalent string piece vectors.
kling@webkit.org [Tue, 17 Jan 2012 20:57:23 +0000 (20:57 +0000)]
SpaceSplitString: Share equivalent string piece vectors.
<http://webkit.org/b/76458>

Reviewed by Antti Koivisto.

Make SpaceSplitStringData ref-counted and cache them in a hashmap to reduce memory
usage and avoid redundant string splitting work.  This reduces memory consumption
by 618 kB (on 64-bit) when viewing the full HTML5 spec at <http://whatwg.org/c>

* dom/SpaceSplitString.h:

    Add the source string to SpaceSplitStringData so we have a key for uncaching
    in the destructor. Also bumped the vector's inline size from 2 to 4.

* dom/SpaceSplitString.cpp:
(WebCore::sharedDataMap):
(WebCore::SpaceSplitStringData::create):
(WebCore::SpaceSplitStringData::createUnique):
(WebCore::SpaceSplitStringData::SpaceSplitStringData):
(WebCore::SpaceSplitString::SpaceSplitString):
(WebCore::SpaceSplitString::set):
(WebCore::SpaceSplitStringData::createVector):

    Added create helpers for SpaceSplitStringData. Moved case folding from
    createVector() to create(AtomicString). Added a hash map for caching
    AtomicString -> SpaceSplitStringData.

(WebCore::SpaceSplitStringData::~SpaceSplitStringData):

    Remove the SpaceSplitStringData from the sharedDataMap().

* dom/SpaceSplitString.cpp:
(WebCore::SpaceSplitString::ensureUnique):

    Added, detaches from the shared SpaceSplitStringData if necessary.

(WebCore::SpaceSplitStringData::add):
(WebCore::SpaceSplitStringData::remove):

    Assert that add() and remove() are only used on unique SpaceSplitStringData.

(WebCore::SpaceSplitString::add):
(WebCore::SpaceSplitString::remove):

    Call ensureUnique() to potentially detach from a shared SpaceSplitStringData
    before making modifications.

* dom/SpaceSplitString.cpp:
(WebCore::SpaceSplitStringData::containsAll):

    Added gratuitous fast path for containsAll(*this).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: make PortFactory.get() be fully data-driven
dpranke@chromium.org [Tue, 17 Jan 2012 20:32:59 +0000 (20:32 +0000)]
webkitpy: make PortFactory.get() be fully data-driven
https://bugs.webkit.org/show_bug.cgi?id=76360

Reviewed by Eric Seidel.

Refactor PortFactory.get() to be fully data-driven.

* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory):
(PortFactory._default_port):
(PortFactory.get):
(PortFactory.get.in):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.assert_port):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: add determine_full_port_name(), clean up port.__init__()
dpranke@chromium.org [Tue, 17 Jan 2012 20:27:35 +0000 (20:27 +0000)]
webkitpy: add determine_full_port_name(), clean up port.__init__()
https://bugs.webkit.org/show_bug.cgi?id=76357

Reviewed by Adam Barth.

Each Port class is now required to implement a 'port_name' field
that will match the start of all ports constructed by this class and
a 'determine_full_port_name' field that will make the port
fully-qualified.

* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.__init__):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port):
(Port.determine_port_name):
(Port.__init__):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.for):
(ChromiumPort.__init__):
(ChromiumPort):
(ChromiumPort._chromium_base_dir):
(ChromiumPort.path_from_chromium_base):
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
(ChromiumGpuLinuxPort):
(ChromiumGpuLinuxPort.__init__):
(ChromiumGpuMacPort):
(ChromiumGpuMacPort.__init__):
(ChromiumGpuWinPort):
(ChromiumGpuWinPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort):
(ChromiumLinuxPort.determine_port_name):
(ChromiumLinuxPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort):
(ChromiumMacPort.determine_port_name):
(ChromiumMacPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort):
(ChromiumWinPort.determine_port_name):
(ChromiumWinPort.__init__):
* Scripts/webkitpy/layout_tests/port/dryrun.py:
(DryRunPort):
(DryRunPort.determine_port_name):
(DryRunPort.__init__):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort):
* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory):
(PortFactory._default_port):
(PortFactory.get):
(PortFactory.get.in):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.assert_port):
* Scripts/webkitpy/layout_tests/port/google_chrome.py:
(GoogleChromeLinux32Port):
(GoogleChromeLinux32Port.determine_port_name):
(GoogleChromeLinux64Port):
(GoogleChromeLinux64Port.determine_port_name):
(GoogleChromeMacPort):
(GoogleChromeMacPort.determine_port_name):
(GoogleChromeWinPort):
(GoogleChromeWinPort.determine_port_name):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort):
(MacPort.determine_port_name):
(MacPort.__init__):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_versions):
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRTPort):
(MockDRTPort.determine_port_name):
(MockDRTPort.__init__):
(MockDRT):
(MockDRT.determine_port_name):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.make_port):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort):
(QtPort.determine_port_name):
(QtPort.__init__):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort):
(TestPort.determine_port_name):
(TestPort.__init__):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort.__init__):
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort):
(WinPort.determine_port_name):
* Scripts/webkitpy/tool/servers/rebaselineserver.py:
(get_test_baselines.AllPlatformsPort.__init__):
* Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
(get_test_config.TestMacPort):
(get_test_config):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: clean up port code in preparation for static port names
dpranke@chromium.org [Tue, 17 Jan 2012 19:25:01 +0000 (19:25 +0000)]
webkitpy: clean up port code in preparation for static port names
https://bugs.webkit.org/show_bug.cgi?id=76356

Reviewed by Adam Barth.

To fix bug 76215 and be able to determine appropriate port names
in webkitpy without actually constructing Port objects, we need
to shuffle some logic in the chromium ports to be able to figure
out whether we built DRT in 32 or 64-bit mode.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
(ChromiumPort._chromium_base_dir):
(ChromiumPort.__init__):
(ChromiumPort.path_from_chromium_base):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort):
(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._static_build_path):
(ChromiumLinuxPort._determine_architecture):
(ChromiumLinuxPort.__init__):
(ChromiumLinuxPort._build_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=76197
hyatt@apple.com [Tue, 17 Jan 2012 19:16:24 +0000 (19:16 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=76197

Implementation of baseline grid alignment. This patch implements line grid tracking in the layout state,
and also implements the snapping of lines to baselines. It works with normal flow, positioning and floats and
with pagination, as long as the grid is inside the pagination context and not outside.

Reviewed by Simon Fraser.

Added a bunch of new tests in fast/line-grid.

* WebCore.xcodeproj/project.pbxproj:
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::setHasTextChildren):
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::propagateLineGridInfo):
(WebCore::LayoutState::establishLineGrid):
* rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::pageLogicalHeight):
(WebCore::LayoutState::currentLineGrid):
(WebCore::LayoutState::currentLineGridOffset):
(WebCore::LayoutState::layoutOffset):
(WebCore::LayoutState::needsBlockDirectionLocationSetBeforeLayout):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::pageLogicalTopForOffset):
(WebCore::RenderBlock::adjustLinePositionForPagination):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::lineGridBox):
(WebCore::RenderBlock::setLineGridBox):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::layoutLineGridBox):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionLogicalTopForLine):
* rendering/RenderFlowThread.h:
* rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineGridSnapAdjustment):
* rendering/RootInlineBox.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=76197

Add tests for baseline line grid alignment.

Reviewed by Simon Fraser.

* fast/line-grid/line-grid-floating.html: Added.
* fast/line-grid/line-grid-inside-columns.html: Added.
* fast/line-grid/line-grid-into-floats.html: Added.
* fast/line-grid/line-grid-positioned.html: Added.
* platform/mac/fast/line-grid: Added.
* platform/mac/fast/line-grid/line-grid-floating-expected.png: Added.
* platform/mac/fast/line-grid/line-grid-floating-expected.txt: Added.
* platform/mac/fast/line-grid/line-grid-inside-columns-expected.png: Added.
* platform/mac/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
* platform/mac/fast/line-grid/line-grid-into-floats-expected.png: Added.
* platform/mac/fast/line-grid/line-grid-into-floats-expected.txt: Added.
* platform/mac/fast/line-grid/line-grid-positioned-expected.png: Added.
* platform/mac/fast/line-grid/line-grid-positioned-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago-webkit-cross-fade doesn't respect background-size
timothy_horton@apple.com [Tue, 17 Jan 2012 19:02:39 +0000 (19:02 +0000)]
-webkit-cross-fade doesn't respect background-size
https://bugs.webkit.org/show_bug.cgi?id=74902
<rdar://problem/10605289>

Reviewed by Simon Fraser.

CrossfadeGeneratedImage should report its intrinsic size, instead of
improperly conforming to the size of its container.

Test: css3/images/cross-fade-background-size.html

* platform/graphics/CrossfadeGeneratedImage.h:
(WebCore::CrossfadeGeneratedImage::setContainerSize):
(WebCore::CrossfadeGeneratedImage::usesContainerSize):
(WebCore::CrossfadeGeneratedImage::hasRelativeWidth):
(WebCore::CrossfadeGeneratedImage::hasRelativeHeight):
(WebCore::CrossfadeGeneratedImage::size):

Add a test (cross-fade-background-size.html) which ensures that the
background-size CSS property interacts reasonably with -webkit-cross-fade.

Modify cross-fade-overflow-position to hit both the tiled and non-tiled codepaths.

* css3/images/cross-fade-background-size.html: Added.
* css3/images/cross-fade-overflow-position.html:
* css3/images/resources/stripes-large.png: Added.
* css3/images/resources/stripes-small.png: Added.
* platform/mac/css3/images/cross-fade-background-size-expected.png: Added.
* platform/mac/css3/images/cross-fade-background-size-expected.txt: Added.
* platform/mac/css3/images/cross-fade-overflow-position-expected.png:
* platform/mac/css3/images/cross-fade-overflow-position-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Refactor JavaScriptOutlineDialog: extract FilteredItemSelectionDialog...
vsevik@chromium.org [Tue, 17 Jan 2012 19:00:12 +0000 (19:00 +0000)]
Web Inspector: Refactor JavaScriptOutlineDialog: extract FilteredItemSelectionDialog and reuse DialogDelegate.
https://bugs.webkit.org/show_bug.cgi?id=76455

Reviewed by Yury Semikhatsky.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/Dialog.js:
(WebInspector.Dialog):
(WebInspector.Dialog.prototype._hide):
* inspector/front-end/FilteredItemSelectionDialog.js: Added.
(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype.position):
(WebInspector.FilteredItemSelectionDialog.prototype.focus):
(WebInspector.FilteredItemSelectionDialog.prototype.willHide):
(WebInspector.FilteredItemSelectionDialog.prototype.onEnter):
(WebInspector.FilteredItemSelectionDialog.prototype.get _itemsLoaded):
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._hideItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._itemElementVisible):
(WebInspector.FilteredItemSelectionDialog.prototype._showItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._checkItemAt):
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegExp):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):
(WebInspector.FilteredItemSelectionDialog.prototype._scheduleFilter):
(WebInspector.FilteredItemSelectionDialog.prototype._updateSelection):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
(WebInspector.FilteredItemSelectionDialog.prototype._onScroll):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItems):
(WebInspector.FilteredItemSelectionDialog.prototype._clearHighlight):
(WebInspector.FilteredItemSelectionDialog.prototype._clearElementHighlight.changes.this._elementHighlightChanges.get if):
(WebInspector.FilteredItemSelectionDialog.prototype._clearElementHighlight):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItem.get var):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItem):
(WebInspector.FilteredItemSelectionDialog.prototype._itemElementInViewport):
(WebInspector.SelectionDialogContentProvider):
(WebInspector.SelectionDialogContentProvider.prototype.itemTitleAt):
(WebInspector.SelectionDialogContentProvider.prototype.itemKeyAt):
(WebInspector.SelectionDialogContentProvider.prototype.itemsCount):
(WebInspector.SelectionDialogContentProvider.prototype.requestItems):
(WebInspector.SelectionDialogContentProvider.prototype.selectItem):
(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.didAddChunk):
(WebInspector.JavaScriptOutlineDialog.install):
(WebInspector.JavaScriptOutlineDialog._show):
(WebInspector.JavaScriptOutlineDialog.createShortcut):
(WebInspector.JavaScriptOutlineDialog.prototype.itemTitleAt):
(WebInspector.JavaScriptOutlineDialog.prototype.itemKeyAt):
(WebInspector.JavaScriptOutlineDialog.prototype.itemsCount):
(WebInspector.JavaScriptOutlineDialog.prototype.requestItems):
(WebInspector.JavaScriptOutlineDialog.prototype.selectItem):
(WebInspector.JavaScriptOutlineDialog.prototype._appendItemElements):
* inspector/front-end/JavaScriptOutlineDialog.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/filteredItemSelectionDialog.css: Renamed from Source/WebCore/inspector/front-end/javaScriptOutlineDialog.css.
(.js-outline-dialog > input):
(.js-outline-dialog > div.progress):
(.js-outline-dialog > div.container):
(.js-outline-dialog > .container > div.item):
(.js-outline-dialog > .container > div.item.selected):
(.js-outline-dialog > .container > div.item > span.highlight):
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDo not remove pixel failures for ref tests.
commit-queue@webkit.org [Tue, 17 Jan 2012 18:55:53 +0000 (18:55 +0000)]
Do not remove pixel failures for ref tests.
https://bugs.webkit.org/show_bug.cgi?id=76243

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-01-17
Reviewed by Tony Chang.

'NRWT --no-pixel-tests' complains when reftests are expected to
be image mismatch.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._update_summary_with_result):
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(is_reftest_failure):
(determine_result_type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImport some NodeIterator tests from mozilla
abarth@webkit.org [Tue, 17 Jan 2012 18:28:31 +0000 (18:28 +0000)]
Import some NodeIterator tests from mozilla
https://bugs.webkit.org/show_bug.cgi?id=76442

Reviewed by Daniel Bates.

These tests are imported from mozilla-central.  I tried to make the
minimal changes when importing them rather than rewire them into
script-tests.  They appear to have uncovered a bug, which I will
investigate in a followup patch.

* traversal/moz-bug559526-expected.txt: Added.
* traversal/moz-bug559526.html: Added.
* traversal/moz-bug590771-expected.txt: Added.
* traversal/moz-bug590771.html: Added.
* traversal/moz-mutations-3-expected.txt: Added.
* traversal/moz-mutations-3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10703228> ASSERTION FAILED: Uncaught exception - Cannot lock focus...
simon.fraser@apple.com [Tue, 17 Jan 2012 18:26:09 +0000 (18:26 +0000)]
<rdar://problem/10703228> ASSERTION FAILED: Uncaught exception - Cannot lock focus on image <NSImage 0x1206572a0 Size={0, 0} Reps=( )>, because it is size zero loading techcrunch.com

Reviewed by Anders Carlsson.

Avoid trying to create image snapshots for zero-sized plugins, because
it causes -[NSView lockFocus] to throw an exception.

* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView cacheSnapshot]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove tests out of WebCore/manual-tests to toplevel ManualTests.
commit-queue@webkit.org [Tue, 17 Jan 2012 18:11:24 +0000 (18:11 +0000)]
Move tests out of WebCore/manual-tests to toplevel ManualTests.
It looks like the manual-tests folder wasn't noticed by git (or me :).

Move some SVG manual tests from deprecated WebCore/manual-tests to toplevel ManualTests
https://bugs.webkit.org/show_bug.cgi?id=76437

Patch by Raul Hudea <rhudea@adobe.com> on 2012-01-17
Reviewed by Daniel Bates.

* ManualTests/svg-animation-css-transform.html: Renamed from Source/WebCore/manual-tests/svg-animation-css-transform.html.
* ManualTests/svg-css-animate-compound.html: Renamed from Source/WebCore/manual-tests/svg-css-animate-compound.html.
* ManualTests/svg-css-transition-compound.html: Renamed from Source/WebCore/manual-tests/svg-css-transition-compound.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, avoid webkit_tests aborts due to clashing SVG test expectations.
apavlov@chromium.org [Tue, 17 Jan 2012 17:35:03 +0000 (17:35 +0000)]
[Chromium] Unreviewed, avoid webkit_tests aborts due to clashing SVG test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Unskip now passing tests.
ossy@webkit.org [Tue, 17 Jan 2012 17:06:05 +0000 (17:06 +0000)]
[Qt][WK2] Unskip now passing tests.

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-01-17
Reviewed by Csaba Osztrogonác.

* platform/qt-wk2/Skipped:
    - Support layoutTestController.layerTreeAsText in WebKitTestRunner
      https://bugs.webkit.org/show_bug.cgi?id=42145
      It is fixed. These tests have been unskipped.

    - WebKitTestRunner needs an implementation of eventSender
      https://bugs.webkit.org/show_bug.cgi?id=42194
      Some passing tests have been unskipped.

    - WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
      https://bugs.webkit.org/show_bug.cgi?id=42327
      It is fixed. These tests have been unskipped.

    - WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
      https://bugs.webkit.org/show_bug.cgi?id=42690
      It is fixed. This test have been unskipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r81225): ORWT should ignore reftests
ossy@webkit.org [Tue, 17 Jan 2012 16:11:50 +0000 (16:11 +0000)]
REGRESSION(r81225): ORWT should ignore reftests
https://bugs.webkit.org/show_bug.cgi?id=67936

Patch by Balazs Ankes <Ankes.Balazs@stud.u-szeged.hu> on 2012-01-17
Reviewed by Csaba Osztrogonác.

* Scripts/old-run-webkit-tests:
(isUsedInReftest): $filename should be the first parameter
(findTestsToRun): run test if it isn't reftest

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Gtk] Input text field not repainted when value is changed
commit-queue@webkit.org [Tue, 17 Jan 2012 16:03:12 +0000 (16:03 +0000)]
[Gtk] Input text field not repainted when value is changed
https://bugs.webkit.org/show_bug.cgi?id=76279

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-17
Reviewed by Gustavo Noronha Silva.

Force pending relayouts before freezing the dirty region in a temporary.
This prevents the following code from throwing the dirty updates away
after the original paint is finished.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::paintWebView): Remove the relayout.
(WebKit::ChromeClient::paint): Move the relayout here, before the
dirty region is frozen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: CodeGeneratorInspector.py: start using typedefs
commit-queue@webkit.org [Tue, 17 Jan 2012 15:45:47 +0000 (15:45 +0000)]
Web Inspector: CodeGeneratorInspector.py: start using typedefs
https://bugs.webkit.org/show_bug.cgi?id=76382

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-17
Reviewed by Yury Semikhatsky.

Generator is patched accordingly.

* inspector/CodeGeneratorInspector.py:
(EnumConstants.get_enum_constant_code):
(TypeBuilderPass):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.get_generate_pass_id):
(TypeBindings.create_type_declaration_):
(TypeBindings.create_type_declaration_.PlainString):
(TypeBindings.create_type_declaration_.PlainString.get_code_generator):
(TypeBindings.create_type_declaration_.PlainString.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.PlainString.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.PlainString.get_in_c_type_text):
(TypeBindings.create_type_declaration_.TypedefString):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator.generate_type_builder.String):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator.register_use):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator.get_generate_pass_id):
(TypeBindings.create_type_declaration_.TypedefString.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.TypedefString.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.TypedefString.get_in_c_type_text):
(get_generate_pass_id):
(ArrayBinding.get_code_generator.CodeGenerator):
(ArrayBinding.get_code_generator.CodeGenerator.get_generate_pass_id):
(Generator.process_types.create_type_builder_caller):
(Generator.process_types.create_type_builder_caller.call_type_builder):
(Generator.process_types):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix python unit test I broke with r105142
kov@webkit.org [Tue, 17 Jan 2012 15:42:19 +0000 (15:42 +0000)]
Unreviewed. Fix python unit test I broke with r105142

* Scripts/webkitpy/common/config/ports_unittest.py:
(WebKitPortTest.test_gtk_port):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] [WK2] WebKitPrivate should include the entire WebKit2 C API
commit-queue@webkit.org [Tue, 17 Jan 2012 15:37:43 +0000 (15:37 +0000)]
[GTK] [WK2] WebKitPrivate should include the entire WebKit2 C API
https://bugs.webkit.org/show_bug.cgi?id=76345

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-17
Reviewed by Gustavo Noronha Silva.

Isolate all of the WebKit2 C API includes into WebKitPrivate.h and no longer
include anything other than WebKit2.h for the C API.

* UIProcess/API/gtk/WebKitBackForwardList.cpp: Use WebKitPrivate.h now.
* UIProcess/API/gtk/WebKitBackForwardListItem.cpp: Ditto.
* UIProcess/API/gtk/WebKitPrivate.h: Add WebKit2.h, WKAPICast.h and WKRetainPtr.h includes.
* UIProcess/API/gtk/WebKitSettings.cpp: Use WebKitPrivate.h.
* UIProcess/API/gtk/WebKitUIClient.cpp: Ditto.
* UIProcess/API/gtk/WebKitWebContext.cpp: Ditto.
* UIProcess/API/gtk/WebKitWebView.cpp: Ditto.
* UIProcess/API/gtk/WebKitWebViewBase.cpp: Ditto.
* UIProcess/API/gtk/WebKitWindowProperties.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: provide basic information about DOM character data size
yurys@chromium.org [Tue, 17 Jan 2012 15:37:06 +0000 (15:37 +0000)]
Web Inspector: provide basic information about DOM character data size
https://bugs.webkit.org/show_bug.cgi?id=76059

Memory agent allows to estimate size of DOM character data and size of WebCore
strings held by JavaScript objects.

Reviewed by Pavel Feldman.

* bindings/js/ScriptProfiler.h:
(WebCore::ScriptProfiler::visitExternalJSStrings):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::visitExternalJSStrings):
* bindings/v8/ScriptProfiler.h:
* bindings/v8/V8Binding.cpp:
(WebCore::WebCoreStringResource::visitStrings):
(WebCore::V8BindingPerIsolateData::visitJSExternalStrings):
* bindings/v8/V8Binding.h:
* inspector/DOMWrapperVisitor.h:
* inspector/Inspector.json:
* inspector/InspectorMemoryAgent.cpp:
(WebCore::CharacterDataStatistics::DOMTreeStatistics::DOMTreeStatistics):
(WebCore::CharacterDataStatistics::DOMTreeStatistics::collectNodeStatistics):
(WebCore::CharacterDataStatistics::CounterVisitor::CounterVisitor):
(WebCore::CharacterDataStatistics::CounterVisitor::domGroups):
(WebCore::CharacterDataStatistics::CounterVisitor::strings):
(WebCore::CharacterDataStatistics::CounterVisitor::visitNode):
(WebCore::CharacterDataStatistics::CounterVisitor::visitJSExternalString):
(WebCore::InspectorMemoryAgent::getDOMNodeCount):
* inspector/InspectorMemoryAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Dialogs style and DialogDelegate interface fixes.
vsevik@chromium.org [Tue, 17 Jan 2012 15:34:35 +0000 (15:34 +0000)]
Web Inspector: Dialogs style and DialogDelegate interface fixes.
https://bugs.webkit.org/show_bug.cgi?id=76449

Reviewed by Pavel Feldman.

* inspector/front-end/Dialog.js:
(WebInspector.Dialog):
(WebInspector.Dialog.currentInstance):
(WebInspector.Dialog.show):
(WebInspector.Dialog.hide):
(WebInspector.Dialog.prototype._hide):
(WebInspector.Dialog.prototype._onGlassPaneFocus):
(WebInspector.Dialog.prototype._onFocus):
(WebInspector.Dialog.prototype._position):
(WebInspector.Dialog.prototype._onKeyDown):
(WebInspector.DialogDelegate.prototype.wasShown):
(WebInspector.DialogDelegate.prototype.position):
(WebInspector.DialogDelegate.prototype.focus):
(WebInspector.DialogDelegate.prototype.onEnter):
(WebInspector.DialogDelegate.prototype.willHide):
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog):
(WebInspector.GoToLineDialog.prototype.focus):
(WebInspector.GoToLineDialog.prototype._onGoClick):
(WebInspector.GoToLineDialog.prototype._applyLineNumber):
(WebInspector.GoToLineDialog.prototype.onEnter):
* inspector/front-end/dialog.css:
(.dialog):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
vestbo@webkit.org [Tue, 17 Jan 2012 15:30:34 +0000 (15:30 +0000)]
[Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser

Qt 5 no longer has that flag.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: ConsoleMessage.cpp and InspectorResourceAgent.cpp doesn't conform...
yurys@chromium.org [Tue, 17 Jan 2012 15:29:37 +0000 (15:29 +0000)]
Web Inspector: ConsoleMessage.cpp and InspectorResourceAgent.cpp doesn't conform to Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=76403

A couple of protocol fixes.

Reviewed by Pavel Feldman.

* inspector/ConsoleMessage.cpp: return 'log' in case some unsupported value is passed.
We cannot omit that return statement as GCC would complain on missing return statement
despite all enum values are listed.
(WebCore::messageTypeValue):
* inspector/Inspector-0.1.json: fixed v0.1 protocol definition.
* inspector/Inspector.json: made CachedResource.response field optional.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Web Inspector: remove "Document DOM tree" class and "Detached DOM tree...
loislo@chromium.org [Tue, 17 Jan 2012 15:03:35 +0000 (15:03 +0000)]
[Chromium] Web Inspector: remove "Document DOM tree" class and "Detached DOM tree" from the Summary view.
https://bugs.webkit.org/show_bug.cgi?id=76450

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildAggregates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Emit "resource,request,willsend" from ewk_view.
kubo@profusion.mobi [Tue, 17 Jan 2012 15:02:37 +0000 (15:02 +0000)]
[EFL] Emit "resource,request,willsend" from ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=76292

Reviewed by Andreas Kling.

Make ewk_view dispatch the "resource,request,willsend" signal as well,
so that it is possible to know whether the request is for the main
frame itself or for anything else.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Crash in fast/text/regional-indicator-symobls.html
ossy@webkit.org [Tue, 17 Jan 2012 14:35:29 +0000 (14:35 +0000)]
[Qt][WK2] Crash in fast/text/regional-indicator-symobls.html
https://bugs.webkit.org/show_bug.cgi?id=69419

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-17
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0/Skipped: Removing it from skipped list as it is working now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] fast/canvas/2d.text.draw.fill.maxWidth.gradient.html fails with newer Qt5
ossy@webkit.org [Tue, 17 Jan 2012 14:34:05 +0000 (14:34 +0000)]
[Qt] fast/canvas/2d.text.draw.fill.maxWidth.gradient.html fails with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=74785

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-01-17
Reviewed by Csaba Osztrogonác.

Upstream bug in Qt 5 is fixed, so we can unskip the test now.

* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] editing/selection/regional-indicators.html fails
ossy@webkit.org [Tue, 17 Jan 2012 14:31:30 +0000 (14:31 +0000)]
[Qt] editing/selection/regional-indicators.html fails
https://bugs.webkit.org/show_bug.cgi?id=66500

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-17
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0/Skipped: This test is not failing anymore,
removing it from skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] fast/canvas/canvas-largedraws.html crashes with newer Qt5
ossy@webkit.org [Tue, 17 Jan 2012 14:28:52 +0000 (14:28 +0000)]
[Qt] fast/canvas/canvas-largedraws.html crashes with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=75167

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-01-17
Reviewed by Csaba Osztrogonác.

Bug is fixed upstream, so it should be safe to unskip it now.

* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-01-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 17 Jan 2012 13:22:05 +0000 (13:22 +0000)]
2012-01-17  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update Chromium dependency 117616:117882

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Implement HTTP authentication QML API
commit-queue@webkit.org [Tue, 17 Jan 2012 13:17:51 +0000 (13:17 +0000)]
[Qt] Implement HTTP authentication QML API
https://bugs.webkit.org/show_bug.cgi?id=75535

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-17
Reviewed by Kenneth Rohde Christiansen.

This patch implements the QML API for handling HTTP authentication.
The implementation uses a syncronous message between the WebProcess
and the UIProcess which is called when the authenticationRequired
signal is emitted from QNAM.

Based in part upon patch by Peter Hartmann.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleAuthenticationRequiredRequest):
(QQuickWebViewExperimental::authenticationDialog):
(QQuickWebViewExperimental::setAuthenticationDialog):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::authenticationRequiredRequest):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/QtDialogRunner.cpp:
(AuthenticationDialogContextObject::AuthenticationDialogContextObject):
(AuthenticationDialogContextObject::hostname):
(AuthenticationDialogContextObject::realm):
(AuthenticationDialogContextObject::prefilledUsername):
(AuthenticationDialogContextObject::accept):
(AuthenticationDialogContextObject::reject):
(QtDialogRunner::initForAuthentication):
* UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner::username):
(QtDialogRunner::password):
(QtDialogRunner::onAuthenticationAccepted):
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::handleAuthenticationRequiredRequest):
* UIProcess/qt/QtPageClient.h:
* WebProcess/qt/QtNetworkAccessManager.cpp:
(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::onAuthenticationRequired):
* WebProcess/qt/QtNetworkAccessManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-01-17 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 17 Jan 2012 13:09:02 +0000 (13:09 +0000)]
2012-01-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Update Qt results after r105143..

        * platform/qt/svg/carto.net/window-expected.txt:
        * platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
        * platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-01-17 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 17 Jan 2012 13:03:17 +0000 (13:03 +0000)]
2012-01-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Update Gtk results after r105143..

        * platform/gtk/svg/carto.net/window-expected.txt:
        * platform/gtk/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
        * platform/gtk/svg/custom/js-late-gradient-and-object-creation-expected.txt:
        * platform/gtk/svg/custom/js-late-pattern-and-object-creation-expected.txt:
        * platform/gtk/svg/custom/use-detach-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLarge SVG text layout performance regression in r81168
zimmermann@webkit.org [Tue, 17 Jan 2012 12:42:25 +0000 (12:42 +0000)]
Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Zoltan Herczeg.

Source/WebCore:

Final patch fixing the performance regression from r81168 plus giving us more performance we ever had.
The testcase attached to bug 65711 creates 200 tspans as <text> children, and modifies just the first <tspan>s
content periodically using a timer. It ran with <3 FPS in release builds before, and now at around 60 FPS,
where the most dominant code path remaining is CG painting text. Still theres room to optimize further, as
Intruments shows.

Historically we rebuilt all SVGTextLayoutAttributes stored in the RenderSVGInlineText, whenever any
children of the <text> subtree changed, in any way. This lead to a recomputation of the x/y/dx/dy/rotate
value lists, for the whole tree, a recreation of the line box tree and finally a measurement of all characters
in the subtree.

This patch, and its previous patches preparing this, introduces progressive relayout for the SVG text subtree.
DOM tree mutations, x/y/dx/dy/rotate value lists changes, and measuring-all-characters are now strictly decoupled.

#1) x/y/dx/dy/rotate list changes:
The x/y/dx/dy/rotate lists are only ever rebuilt, if they change or upon the initial RenderSVGText layout.
This information is now cached in the so-called SVGCharacterDataMap, in each of the SVGTextLayoutAttributes,
associated with a specific RenderSVGInlineText.

#2) DOM tree mutations:
If a new RenderSVGInlineText gets added to the tree, we have to create SVGTextLayoutAttributes for the new
renderer, measure its characters, and cache the information in the attributes. Adding a new renderer to
a SVG <text> subtree can affect the positioning of the previous and next sibling in the tree, due the
whitespace merging logic. Example:

<text y="50" x="50 100 150">A<tspan></tspan> C</text>:
RenderSVGText {text} at (50,36) size 111x18 contains 1 chunk(s)
  RenderSVGInlineText {#text} at (0,0) size 12x18
    chunk 1 text run 1 at (50.00,50.00) startOffset 0 endOffset 1 width 12.00: "A"
  RenderSVGTSpan {tspan} at (0,0) size 0x0
  RenderSVGInlineText {#text} at (50,0) size 61x18
    chunk 1 text run 1 at (100.00,50.00) startOffset 0 endOffset 1 width 4.00: " "
    chunk 1 text run 1 at (150.00,50.00) startOffset 0 endOffset 1 width 11.00: "C"

<text y="50" x="50 100 150">A<tspan>B</tspan> C</text>:
RenderSVGText {text} at (50,36) size 115x18 contains 1 chunk(s)
  RenderSVGInlineText {#text} at (0,0) size 12x18
    chunk 1 text run 1 at (50.00,50.00) startOffset 0 endOffset 1 width 12.00: "A"
  RenderSVGTSpan {tspan} at (0,0) size 11x18
    RenderSVGInlineText {#text} at (50,0) size 11x18
      chunk 1 text run 1 at (100.00,50.00) startOffset 0 endOffset 1 width 11.00: "B"
  RenderSVGInlineText {#text} at (100,0) size 15x18
    chunk 1 text run 1 at (150.00,50.00) startOffset 0 endOffset 2 width 15.00: " C"

Its obvious that adding a #text node as child to the <tspan> potentially affects the next & previous
siblings in the DOM tree. Take extra care of these possibilities, by properly remeasuring not only
the newly added renderer, but also the previous & next siblings layout attributes.

Mutation of text nodes, or removal of text/tspan elements from the tree is handled in the same way.

#3) Measuring the text subtree:
Don't cache the metrics information in the SVGRootInlineBox, as it doesn't survive relayouts (RenderSVGText::layout).
They're stored in the SVGTextLayoutAttributes, and will be updated if the underlying text content changes.

Tests: svg/text/append-text-node-to-tspan.html
       svg/text/modify-text-node-in-tspan.html
       svg/text/remove-text-node-from-tspan.html

* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::addChild):
* rendering/svg/RenderSVGInline.h:
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::willBeDestroyed):
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):
* rendering/svg/RenderSVGInlineText.h:
(WebCore::RenderSVGInlineText::layoutAttributes):
* rendering/svg/RenderSVGText.cpp:
(WebCore::recursiveUpdateLayoutAttributes):
(WebCore::RenderSVGText::layoutAttributesChanged):
(WebCore::findPreviousAndNextAttributes):
(WebCore::RenderSVGText::layoutAttributesWillBeDestroyed):
(WebCore::RenderSVGText::textDOMChanged):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):
* rendering/svg/RenderSVGText.h:
(WebCore::RenderSVGText::layoutAttributes):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::findFirstAndLastAttributesInVector):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
(WebCore::SVGRootInlineBox::reorderValueLists):
* rendering/svg/SVGRootInlineBox.h:
* rendering/svg/SVGTextLayoutAttributes.h:
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForWholeTree):
* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::SVGTextLayoutEngine):
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes):
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics):
(WebCore::SVGTextLayoutEngine::currentVisualCharacterMetrics):
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
* rendering/svg/SVGTextLayoutEngine.h:
(WebCore::SVGTextLayoutEngine::layoutAttributes):
* rendering/svg/SVGTextMetrics.h:
* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::childrenChanged):

LayoutTests:

Update some results, that changed again slightly. Land new tests covering partial SVG <text> subtree updating.

* platform/chromium/test_expectations.txt:
* platform/mac/svg/carto.net/window-expected.png:
* platform/mac/svg/carto.net/window-expected.txt:
* platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
* platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
* platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
* platform/mac/svg/custom/use-detach-expected.png:
* platform/mac/svg/custom/use-detach-expected.txt:
* platform/mac/svg/text/append-text-node-to-tspan-expected.png: Added.
* platform/mac/svg/text/append-text-node-to-tspan-expected.txt: Added.
* platform/mac/svg/text/modify-text-node-in-tspan-expected.png: Added.
* platform/mac/svg/text/modify-text-node-in-tspan-expected.txt: Added.
* platform/mac/svg/text/remove-text-node-from-tspan-expected.png: Added.
* platform/mac/svg/text/remove-text-node-from-tspan-expected.txt: Added.
* svg/text/append-text-node-to-tspan.html: Added.
* svg/text/modify-text-node-in-tspan.html: Added.
* svg/text/remove-text-node-from-tspan.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK+ EWS needs to run update-webkitgtk-libs after applying a patch
kov@webkit.org [Tue, 17 Jan 2012 12:29:38 +0000 (12:29 +0000)]
GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
https://bugs.webkit.org/show_bug.cgi?id=75857

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-01-16
Reviewed by Adam Barth.

* Scripts/webkitdirs.pm:
(buildAutotoolsProject): move cleaning the build to happen early,
and handle --update-gtk right after that
* Scripts/webkitpy/common/config/ports.py:
(GtkPort.build_webkit_command): pass --update-gtk as an option to
build-webkit, so that it is used in the EWS

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, fix Linux image expectations for two SVG tests.
apavlov@chromium.org [Tue, 17 Jan 2012 12:20:27 +0000 (12:20 +0000)]
[Chromium] Unreviewed, fix Linux image expectations for two SVG tests.

* platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
* platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [TextPrompt] Autocomplete adds unwanted text that's hard to remove
apavlov@chromium.org [Tue, 17 Jan 2012 12:13:51 +0000 (12:13 +0000)]
Web Inspector: [TextPrompt] Autocomplete adds unwanted text that's hard to remove
https://bugs.webkit.org/show_bug.cgi?id=76058

Reviewed by Pavel Feldman.

As per the results of a war room:
- Auto-suggest only after user typing (avoid showing suggestions when navigating through the user input.)
- Do not select the first item if the suggest box is shown at the end of prompt (to allow Enter to commit the input.)
- Only show grayed autocompletion at the end of prompt (otherwise show a suggest box with the first item selected.)
- Grayed autocompletion can only be accepted with the End or Right keys.
- Enter can accept a selected suggestion item from the list, without committing the input.
- Retain the CSS model editing behavior as close to the existing one as possible.
- Enable PageUp/PageDown to navigate the suggest box items.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
():
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeSuggestionAids):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype._onNextItem):
(WebInspector.TextPrompt.SuggestBox.prototype._onPreviousItem):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._canShowBox):
(WebInspector.TextPrompt.SuggestBox.prototype._rememberRowCountPerViewport):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: CSS backend doesn't conform to Inspector.json
apavlov@chromium.org [Tue, 17 Jan 2012 11:57:31 +0000 (11:57 +0000)]
Web Inspector: CSS backend doesn't conform to Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=76402

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaStream API: Add the mediaStream constructor
tommyw@google.com [Tue, 17 Jan 2012 11:13:00 +0000 (11:13 +0000)]
MediaStream API: Add the mediaStream constructor
https://bugs.webkit.org/show_bug.cgi?id=76436

Adding support for creating a MediaStream using a collection of MediaStreamTracks.

Reviewed by Adam Barth.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

* mediastream/MediaStream.cpp:
(WebCore::MediaStream::create):
* mediastream/MediaStream.h:
* mediastream/MediaStream.idl:
* mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::component):
* mediastream/MediaStreamTrack.h:
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::didConstructMediaStream):
* platform/mediastream/MediaStreamCenter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: IDBIndex.get/getKey should yield undefined, not an error
jsbell@chromium.org [Tue, 17 Jan 2012 10:51:55 +0000 (10:51 +0000)]
IndexedDB: IDBIndex.get/getKey should yield undefined, not an error
https://bugs.webkit.org/show_bug.cgi?id=76116

Source/WebCore:

Pass an undefined value (for IDBIndex.get()) or a null key
(for IDBIndex.getKey()) back as the result, rather than raising
an exception.

Reviewed by Adam Barth.

Tests: storage/indexeddb/index-basics.html
       storage/indexeddb/cursor-index-delete.html
       storage/indexeddb/duplicates.html

* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::getInternal):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):

LayoutTests:

Reviewed by Adam Barth.

* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/duplicates-expected.txt:
* storage/indexeddb/duplicates.html:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r105129.
philn@webkit.org [Tue, 17 Jan 2012 10:49:20 +0000 (10:49 +0000)]
Unreviewed, GTK rebaseline after r105129.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove references to CSSPrimitiveValue::primitiveType().
macpherson@chromium.org [Tue, 17 Jan 2012 10:26:49 +0000 (10:26 +0000)]
Remove references to CSSPrimitiveValue::primitiveType().
https://bugs.webkit.org/show_bug.cgi?id=76363

Reviewed by Hajime Morita.

No new tests / refactoring only.

Goal is to remove primitiveType() completely. Only code left using it after this patch is in SVG.
I've introduced some abstractions in CSSPrimitiveValue for time and angles to reduce duplicated code elsewhere.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseColor):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeDegrees):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isAngle):
(WebCore::CSSPrimitiveValue::isAttr):
(WebCore::CSSPrimitiveValue::isCounter):
(WebCore::CSSPrimitiveValue::isFontIndependentLength):
(WebCore::CSSPrimitiveValue::isLength):
(WebCore::CSSPrimitiveValue::isPx):
(WebCore::CSSPrimitiveValue::isRect):
(WebCore::CSSPrimitiveValue::isRGBColor):
(WebCore::CSSPrimitiveValue::isShape):
(WebCore::CSSPrimitiveValue::isTime):
(WebCore::CSSPrimitiveValue::computeTime):
* css/CSSStyleSelector.cpp:
(WebCore::convertToLength):
(WebCore::createGridTrackBreadth):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapFillSize):
(WebCore::CSSStyleSelector::mapFillXPosition):
(WebCore::CSSStyleSelector::mapFillYPosition):
(WebCore::CSSStyleSelector::mapAnimationDelay):
(WebCore::CSSStyleSelector::mapAnimationDuration):
(WebCore::CSSStyleSelector::mapNinePieceImageSlice):
(WebCore::CSSStyleSelector::mapNinePieceImageQuad):
(WebCore::CSSStyleSelector::colorFromPrimitiveValue):
(WebCore::CSSStyleSelector::createTransformOperations):
(WebCore::CSSStyleSelector::createCustomFilterOperation):
(WebCore::CSSStyleSelector::createFilterOperations):
* css/MediaQueryEvaluator.cpp:
(WebCore::parseAspectRatio):
(WebCore::numberValue):
(WebCore::computeLength):
* editing/EditingStyle.cpp:
(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::isCSSValueLength):
(WebCore::hasTransparentBackgroundColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssociatedURLLoader adds support for the HTTP response header Access-Control-Expose...
bbudge@chromium.org [Tue, 17 Jan 2012 10:26:31 +0000 (10:26 +0000)]
AssociatedURLLoader adds support for the HTTP response header Access-Control-Expose-Header.
https://bugs.webkit.org/show_bug.cgi?id=76419

Reviewed by Adam Barth.

* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse):
* tests/AssociatedURLLoaderTest.cpp:
(WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't add _debug postfix to targets when building debug only
vestbo@webkit.org [Tue, 17 Jan 2012 09:28:03 +0000 (09:28 +0000)]
[Qt] Don't add _debug postfix to targets when building debug only

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add more files to project-files for easier navigation in Qt Creator
vestbo@webkit.org [Tue, 17 Jan 2012 09:27:43 +0000 (09:27 +0000)]
[Qt] Add more files to project-files for easier navigation in Qt Creator

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105132 268f45cc-cd09-0410-ab3c-d52691b4dbfc