WebKit-https.git
8 years agoTeach buildbot how to compile 32-bit on Mac.
lforschler@apple.com [Wed, 8 May 2013 22:40:40 +0000 (22:40 +0000)]
Teach buildbot how to compile 32-bit on Mac.

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
(ExtractTestResultsAndLeaks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoApply remote changes to storage maps locally
andersca@apple.com [Wed, 8 May 2013 22:34:02 +0000 (22:34 +0000)]
Apply remote changes to storage maps locally
https://bugs.webkit.org/show_bug.cgi?id=115825

Reviewed by Beth Dakin.

* WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::resetValues):
Clear the pending values map.

(WebKit::StorageAreaMap::didSetItem):
If we failed to set the item, forget everything we know about this storage map.
Otherwise, remove the pending item.

(WebKit::StorageAreaMap::didRemoveItem):
Remove the pending item.

(WebKit::StorageAreaMap::shouldApplyChangeForKey):
Helper function that returns whether a change for a given key should be applied.

(WebKit::StorageAreaMap::applyChange):
Apply the change. Currently only adds and removes are handled.

(WebKit::StorageAreaMap::dispatchStorageEvent):
Apply the change locally as well if needed.

* WebProcess/Storage/StorageAreaMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate WebKitLibraries/win to handle different architectures properly.
roger_fong@apple.com [Wed, 8 May 2013 22:26:42 +0000 (22:26 +0000)]
Update WebKitLibraries/win to handle different architectures properly.

* win/lib32: Copied from win/lib.
* win/tools/WinTools.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSimplify RetainPtrObjectHashTraits
mikhail.pozdnyakov@intel.com [Wed, 8 May 2013 22:08:33 +0000 (22:08 +0000)]
Simplify RetainPtrObjectHashTraits
https://bugs.webkit.org/show_bug.cgi?id=115822

Reviewed by Benjamin Poulain.

RetainPtrObjectHashTraits is inherited from SimpleClassHashTraits
instead of GenericHashTraits re-using more shared functionality.

* wtf/RetainPtr.h:
(WTF::RetainPtrObjectHashTraits::emptyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Fix usage of BlackBerry::Platform::String
commit-queue@webkit.org [Wed, 8 May 2013 22:05:26 +0000 (22:05 +0000)]
[BlackBerry] Fix usage of BlackBerry::Platform::String
https://bugs.webkit.org/show_bug.cgi?id=115781

Patch by Eli Fidler <efidler@blackberry.com> on 2013-05-08
Reviewed by Rob Buis.

BlackBerry PRs 304193 and 327181
Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos

We currently have a problem where we're passing UTF-8 encoded data into
the char* constructors of BlackBerry::Platform::String. This means the string
thinks its data is not UTF-8.

Source/WebCore:

* platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::writeURL):
(WebCore::ClipboardBlackBerry::writePlainText):
* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::getBackingStoreCookies):
* platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::CookieParser):
(WebCore::CookieParser::parseOneCookie):
* platform/blackberry/CursorBlackBerry.cpp:
(WebCore::Cursor::Cursor):
* platform/blackberry/PlatformBlob.cpp:
(WebCore::PlatformBlob::nextDataItem):
* platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):
* platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::Image::loadPlatformResource):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
(WebCore::toWebMediaStreamSource):
(WebCore::toWebMediaStreamDescriptor):
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
* platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
* platform/network/blackberry/rss/RSSFilterStream.cpp:
(WebCore::RSSFilterStream::notifyStatusReceived):
(WebCore::RSSFilterStream::notifyHeadersReceived):
(WebCore::RSSFilterStream::convertContentToHtml):
(WebCore::RSSFilterStream::charset):
(WebCore::RSSFilterStream::removeHeader):
(WebCore::RSSFilterStream::updateHeader):
(WebCore::RSSFilterStream::updateRSSHeaders):
* platform/network/blackberry/rss/RSSFilterStream.h:
* platform/text/blackberry/StringBlackBerry.cpp:
(WTF::String::operator BlackBerry::Platform::String):

Source/WebKit/blackberry:

* Api/JavaScriptVariant.cpp:
(BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
* Api/WebKitTextCodec.cpp:
(BlackBerry::WebKit::base64Encode):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::textEncoding):
(BlackBerry::WebKit::WebPage::textHasAttribute):
(BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
* Api/WebPage.h:
* Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
* WebKitSupport/DefaultTapHighlight.cpp:
(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):

Tools:

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::dumpHistoryItem):
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::setUserStyleSheetLocation):
* DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
(LoadHTMLStringItem::invoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAssert at compile time that we don't pass Objective-C object pointers to adoptCF
andersca@apple.com [Wed, 8 May 2013 22:02:31 +0000 (22:02 +0000)]
Assert at compile time that we don't pass Objective-C object pointers to adoptCF
https://bugs.webkit.org/show_bug.cgi?id=115823

Reviewed by Geoffrey Garen.

Source/WebCore:

* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
Use adoptNS for CALayer.

Source/WebKit2:

Fix adoptNS/adoptCF mismatches. For the adopt(leakRef()) case we'd ideally want a static_pointer_cast overload for RetainPtr,
but this will do for now.

* Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::decode):

Source/WTF:

static_assert in adoptCF that the object passed in is not an Objective-C object.
* wtf/RetainPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTools: add new BlackBerry include dirs.
commit-queue@webkit.org [Wed, 8 May 2013 21:56:08 +0000 (21:56 +0000)]
Tools: add new BlackBerry include dirs.
https://bugs.webkit.org/show_bug.cgi?id=115514

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-08
Reviewed by Rob Buis.

iType include dirs are missing, and HarfBuzz needs to be fixed.

* Scripts/webkitdirs.pm:
(blackberryCMakeArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTextTrackCue should support empty content
eric.carlson@apple.com [Wed, 8 May 2013 20:53:28 +0000 (20:53 +0000)]
TextTrackCue should support empty content
https://bugs.webkit.org/show_bug.cgi?id=115821

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/track-cue-empty-text-crash.html

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Don't bother trying to render
    cues with no content.

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::getCueAsHTML): Return early if there isn't a node tree.
(WebCore::TextTrackCue::createCueRenderingTree): Ditto.
(WebCore::TextTrackCue::determineTextDirection): Ditto.
(WebCore::TextTrackCue::updateDisplayTree): Return early if there isn't a cue rendering tree.

LayoutTests:

* media/track/track-cue-empty-text-crash-expected.txt: Added.
* media/track/track-cue-empty-text-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd SPI to determine if a plugin is sandboxed
weinig@apple.com [Wed, 8 May 2013 20:48:58 +0000 (20:48 +0000)]
Add SPI to determine if a plugin is sandboxed
https://bugs.webkit.org/show_bug.cgi?id=115810

Reviewed by Anders Carlsson.

* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::initializeSandbox):
* Shared/Plugins/mac/PluginSandboxProfile.h: Added.
* Shared/Plugins/mac/PluginSandboxProfile.mm: Added.
(WebKit::pluginSandboxProfileDefaultDirectory):
(WebKit::pluginSandboxProfileDirectories):
(WebKit::pluginSandboxProfileName):
(WebKit::pluginSandboxCommonProfile):
(WebKit::pluginSandboxProfileForDirectory):
(WebKit::pluginSandboxProfile):
(WebKit::pluginHasSandboxProfileForDirectory):
(WebKit::pluginHasSandboxProfile):
Move sandbox code to its own file and refactor to use cocoa. Also adds pluginHasSandboxProfile function
which uses the newly refactored code.

* UIProcess/API/C/mac/WKContextPrivateMac.h:
* UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKPlugInInfoIsSandboxedKey):
(createInfoDictionary):
Add WKPlugInInfoIsSandboxedKey.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed AppleWin build fix.
roger_fong@apple.com [Wed, 8 May 2013 20:45:01 +0000 (20:45 +0000)]
Unreviewed AppleWin build fix.

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
(MediaPlayerPrivateAVFoundationCF):
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTrack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix some compiler warnings (miscellaneous)
rwlbuis@webkit.org [Wed, 8 May 2013 20:33:43 +0000 (20:33 +0000)]
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Rob Buis <rbuis@rim.com> on 2013-05-08
Reviewed by Philip Rogers.

Get rid of the following warning for BlackBerry:

BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]

by using ASSERT_UNUSED instead of ASSERT.

* WebKitSupport/BackingStoreClient.cpp:
(BlackBerry::WebKit::BackingStoreClient::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSafari unexpectedly quits with invalid message from the web process with message...
andersca@apple.com [Wed, 8 May 2013 20:06:31 +0000 (20:06 +0000)]
Safari unexpectedly quits with invalid message from the web process with message ID 0x323002f (WebPageProxy.DecidePolicyForNavigationAction)
https://bugs.webkit.org/show_bug.cgi?id=115814
<rdar://problem/12331258>

Reviewed by Andreas Kling.

To ensure that any asynchronous messages are delivered to the UI process before
synchronous messages (except when doing so would lead to a deadlock), Call
setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage on the UI process connections.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCoalesce WKView visibleRect changes
timothy_horton@apple.com [Wed, 8 May 2013 20:02:45 +0000 (20:02 +0000)]
Coalesce WKView visibleRect changes
https://bugs.webkit.org/show_bug.cgi?id=115792
<rdar://problem/13776842>

Reviewed by Simon Fraser.

The system can call renewGState much more often than we actually want
to update the WebProcess' notion of the exposed rect. Most importantly,
within an autolayout pass it is called many times, and often sees
[WKView visibleRect] be an intermediate value which will never be
flushed to the screen. We only care about the final value, so we should
wait until AppKit has finished - with a zero-delay timer - to inform the
WebProcess of exposed rect changes.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Add exposedRectChangedTimer.
(WebKit::WebPageProxy::close):
Cancel exposedRectChangedTimer when tearing down the WebPageProxy.
* UIProcess/WebPageProxy.h:
(WebPageProxy):
Add exposedRectChangedTimerFired, the timer itself, and two rects:
the most recent exposed rect from the WKView, and the last one we actually
sent across to the WebProcess.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged):
Instead of immediately sending exposed rect changes to the WebProcess,
start a zero-delay timer to do so.
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
Once the zero-delay timer fires, send the new exposed rect to the WebProcess.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove RetainPtr::adoptNS and RetainPtr::adoptCF
andersca@apple.com [Wed, 8 May 2013 19:47:30 +0000 (19:47 +0000)]
Remove RetainPtr::adoptNS and RetainPtr::adoptCF
https://bugs.webkit.org/show_bug.cgi?id=115817

Reviewed by Jessie Berlin.

These functions are now unused so remove them. The preferred way to create a RetainPtr with an
adopted reference is to use the adoptNS/adoptCF free functions.

Rewrite the move assignment operators to just call CFRelease explicitly.

* wtf/RetainPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Plumb the Automake build system for the Battery Status API feature
zandobersek@gmail.com [Wed, 8 May 2013 19:39:49 +0000 (19:39 +0000)]
[GTK] Plumb the Automake build system for the Battery Status API feature
https://bugs.webkit.org/show_bug.cgi?id=115718

Reviewed by Martin Robinson.

.:

* Source/autotools/FindDependencies.m4: Check for the upower-glib dependency if the feature is enabled.
* Source/autotools/PrintBuildConfiguration.m4: Print out the feature status.
* Source/autotools/ReadCommandLineArguments.m4: Check for the --enable-battery-status option. The deafult,
when the option is not given, is to disable the feature.
* Source/autotools/SetupWebKitFeatures.m4: Treat the ENABLE_BATTERY_STATUS define as configurable.
* Source/autotools/symbols.filter: Export a couple of symbols that are used in the WebCore internals library.

Source/WebCore:

No new tests - no new functionality. The feature is not enabled yet, though all the relevant tests
pass when it is.

* GNUmakefile.am: Add the Modules/battery directory to the list of search paths for header inclusions.
Include the same directory under the IDL_PATH variable so the IDL files it contains are processed.
List these IDL files using a wildcard under the EXTRA_DIST list.
* GNUmakefile.list.am: Add the build targets for the module source files, IDLs and resulting JS bindings.
* bindings/gobject/GNUmakefile.am: Add the build targets for the GObject DOM bindings.

Tools:

* Scripts/webkitdirs.pm:
(buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
through the --(enable|disable)-battery-status flag passed to configure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd layout test that lists all global constructors
ch.dumez@sisa.samsung.com [Wed, 8 May 2013 19:28:24 +0000 (19:28 +0000)]
Add layout test that lists all global constructors
https://bugs.webkit.org/show_bug.cgi?id=115724

Reviewed by Ryosuke Niwa.

Update fast/js/global-constructors-attributes.html so that it lists all
global constructors instead of just a few.

* fast/js/global-constructors-attributes-expected.txt:
* fast/js/script-tests/global-constructors-attributes.js:
(classNameForObject):
(constructorPropertiesOnWindow):
* platform/efl/fast/js/global-constructors-attributes-expected.txt: Added.
* platform/gtk/fast/js/global-constructors-attributes-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonew-run-webkit-websocketserver doesn't work after Chromium removal
rniwa@webkit.org [Wed, 8 May 2013 19:26:16 +0000 (19:26 +0000)]
new-run-webkit-websocketserver doesn't work after Chromium removal
https://bugs.webkit.org/show_bug.cgi?id=115816

Reviewed by Joseph Pecoraro.

Fix the bug by instantiating the correct port object.

* Scripts/new-run-webkit-websocketserver:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, mac port.
roger_fong@apple.com [Wed, 8 May 2013 19:19:32 +0000 (19:19 +0000)]
Unreviewed gardening, mac port.
These tests should use testRunner, not layoutTestController.

* fast/js/parse-error-external-script-in-eval.html:
* fast/js/parse-error-external-script-in-new-Function.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. AppleWin VS2010 build fix.
roger_fong@apple.com [Wed, 8 May 2013 19:11:17 +0000 (19:11 +0000)]
Unreviewed. AppleWin VS2010 build fix.

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r149700): fast/css-generated-content/close-quote-negative-depth.html
darin@apple.com [Wed, 8 May 2013 18:54:24 +0000 (18:54 +0000)]
REGRESSION(r149700): fast/css-generated-content/close-quote-negative-depth.html
https://bugs.webkit.org/show_bug.cgi?id=115776

Reviewed by Anders Carlsson.

Source/WebCore:

I changed depth to more closely match what is in the CSS3 specification.
There may be a more optimal way to make it work, but this seems the most straightforward.

* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::RenderQuote): Initialize m_depth to -1 because that depth
is consistent with the empty string that is the initial value of the text. The
real depth will be calculated when the node is attached.
(WebCore::RenderQuote::originalText): Removed the "depth - 1" logic that
used to be done for close quotes. Instead, the updateDepth function now correctly
subtracts one for the close quote itself, not just afterward. Also added an early
exit when the depth is negative; these changes together fix the bug.
(WebCore::RenderQuote::attachQuote): Added a call to updateDepth even for the render
quote head, we now need that to set the depth either to 0 or to -1.
(WebCore::RenderQuote::detachQuote): Removed code to set m_depth to 0;  if we are not
resetting the text then m_depth should be left matching the text, otherwise updateDepth
might not do its job correctly if the quote is later re-attached. What matters is that
m_depth and the text are in sync.
(WebCore::RenderQuote::updateDepth): Changed updating logic in two ways. First,
compute the depth in a local variable rather than computing it in a data member
after first saving off the old value of the data member. That's clearer style.
Second, add the code to change negative depths to zero when propagating to the
next quote in the chain, which matches how the standard is written, and decrement
the depth of the close quote itself, not the quote after the close quote.

LayoutTests:

* TestExpectations: Expect success again on this test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix duplicate builddir.
lforschler@apple.com [Wed, 8 May 2013 18:52:01 +0000 (18:52 +0000)]
Unreviewed.  Fix duplicate builddir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConfigure buildbot for 32bit builder.
lforschler@apple.com [Wed, 8 May 2013 18:46:40 +0000 (18:46 +0000)]
Configure buildbot for 32bit builder.
https://bugs.webkit.org/show_bug.cgi?id=115769

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago <rdar://problem/13776220> 13A451: PluginProcess(2225) deny file-read-data...
ap@apple.com [Wed, 8 May 2013 18:19:05 +0000 (18:19 +0000)]
    <rdar://problem/13776220> 13A451: PluginProcess(2225) deny file-read-data ~/Library/InputManagers
        <rdar://problem/13642510> PluginProcess logs sandbox violations initializing TextServices

        Reviewed by Anders Carlsson.

        * Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Allow more
        TextServices and NSInputManager directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add my apple.com e-mail address to contributors.
bfulgham@webkit.org [Wed, 8 May 2013 17:35:34 +0000 (17:35 +0000)]
Unreviewed. Add my apple.com e-mail address to contributors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPrevent crash when track is deleted during video element deletion.
eric.carlson@apple.com [Wed, 8 May 2013 17:16:21 +0000 (17:16 +0000)]
Prevent crash when track is deleted during video element deletion.
https://bugs.webkit.org/show_bug.cgi?id=106183

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/track/track-remove-crash.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removedFrom): Set m_inActiveDocument to false so we
    do not process text track cues or dispatch related events.

LayoutTests:

* media/track/track-remove-crash-expected.txt: Added.
* media/track/track-remove-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove BinarySemaphoreWin.cpp.
andersca@apple.com [Wed, 8 May 2013 17:03:25 +0000 (17:03 +0000)]
Remove BinarySemaphoreWin.cpp.

Rubber-stamped by Beth Dakin.

BinarySemaphoreWin has been moved to WTF, but the original was never removed.

* Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove ThreadingNone.cpp
andersca@apple.com [Wed, 8 May 2013 16:54:10 +0000 (16:54 +0000)]
Remove ThreadingNone.cpp

Rubber-stamped by Beth Dakin.

ThreadingNone.cpp is empty and not used anywhere.

* wtf/ThreadingNone.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove chromium test results added in r149743
ddkilzer@apple.com [Wed, 8 May 2013 16:52:08 +0000 (16:52 +0000)]
Remove chromium test results added in r149743

* platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Removed.
* platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
ddkilzer@apple.com [Wed, 8 May 2013 16:46:41 +0000 (16:46 +0000)]
BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()

* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(concatenateAttributeAndValue): Switch to appendVector().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Unreviewed buildfix after r149741.
eric.carlson@apple.com [Wed, 8 May 2013 16:41:14 +0000 (16:41 +0000)]
[Mac] Unreviewed buildfix after r149741.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd layout tests for test cases in Bug 5206
ddkilzer@apple.com [Wed, 8 May 2013 16:33:31 +0000 (16:33 +0000)]
Add layout tests for test cases in Bug 5206
<http://webkit.org/b/5206>

Reviewed by Eric Seidel.

These issues were likely fixed in r89257 for Bug 62613.

* fast/js/parse-error-external-script-in-eval-expected.txt: Added.
* fast/js/parse-error-external-script-in-eval.html: Added.
* fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.
Note that the line number in this result is relative to the line
number of the second argument to the new Function() method.
* fast/js/parse-error-external-script-in-new-Function.html: Added.
* fast/js/resources/parse-error-external-script-in-eval.js: Added.
* fast/js/resources/parse-error-external-script-in-new-Function.js: Added.

* platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Added.
* platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove HashMap::deleteAllKeys
andersca@apple.com [Wed, 8 May 2013 16:17:45 +0000 (16:17 +0000)]
Remove HashMap::deleteAllKeys
https://bugs.webkit.org/show_bug.cgi?id=115806

Reviewed by Brent Fulgham.

This function was not used anywhere so let's get rid of it.

* wtf/HashMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Inband text tracks are not in track menu on Lion
eric.carlson@apple.com [Wed, 8 May 2013 16:06:34 +0000 (16:06 +0000)]
[Mac] Inband text tracks are not in track menu on Lion
https://bugs.webkit.org/show_bug.cgi?id=115740

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, covered by existing tests.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_closedCaptionsVisible
    to false immediately, it will be reset to the appropriate value if necessary.
(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
* html/HTMLMediaElement.h:

* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Remove
    HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT) requirement. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
    AVFOUNDATION_MEDIA_SELECTION_GROUP
* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Ditto.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seek): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Ditto.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:  Ditto.

* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h:  Ditto.
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::kind): Don't look at media characteristics,
    a legacy CC track is always Captions.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isClosedCaptions): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::containsOnlyForcedSubtitles): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isMainProgramContent): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isEasyToRead): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label): Use different AVFoundation API on 10.7.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): AVFOUNDATION_TEXT_TRACK_SUPPORT ->
    AVFOUNDATION_MEDIA_SELECTION_GROUP.
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
    AVFOUNDATION_MEDIA_SELECTION_GROUP.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Support legacy CC tracks
    only on 10.8. AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): AVFOUNDATION_TEXT_TRACK_SUPPORT ->
    AVFOUNDATION_MEDIA_SELECTION_GROUP

Source/WTF:

* wtf/Platform.h: AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP

LayoutTests:

* platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow blank spaces before colon (:) on CSS variable definition
sergio@webkit.org [Wed, 8 May 2013 15:19:15 +0000 (15:19 +0000)]
Allow blank spaces before colon (:) on CSS variable definition
https://bugs.webkit.org/show_bug.cgi?id=115802

Reviewed by Darin Adler.

Source/WebCore:

Test: css3/css-variable-definition.html

Modified the grammar to allow blank spaces before the colon on CSS
variable definitions.

* css/CSSGrammar.y.in:

LayoutTests:

New test to check that spaces are allowed before the color on CSS
variable definitions.

* css3/css-variable-definition-expected.html: Added.
* css3/css-variable-definition.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHashTraits<RefPtr<P> >::peek should consider empty value
mikhail.pozdnyakov@intel.com [Wed, 8 May 2013 15:08:55 +0000 (15:08 +0000)]
HashTraits<RefPtr<P> >::peek should consider empty value
https://bugs.webkit.org/show_bug.cgi?id=115799

Reviewed by Darin Adler.

HashTraits<RefPtr<P> >::peek() should consider passing of empty value which is
raw pointer equal to '0', and return it right away instead of converting it to RefPtr
and invoking get().

* wtf/HashTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAvoid unnecessary arguments copying inside GenericHashTraits methods
mikhail.pozdnyakov@intel.com [Wed, 8 May 2013 15:07:56 +0000 (15:07 +0000)]
Avoid unnecessary arguments copying inside GenericHashTraits methods
https://bugs.webkit.org/show_bug.cgi?id=115733

Reviewed by Darin Adler.

Before the change both WTF::GenericHashTraits::passOut and WTF::GenericHashTraits::passOut
used to return the given argument always by value and that caused implicit extra
copying of the argument. It was OK as long as argument type T was POD, as compiler
could optimize it, but in case T was a class having non-trivial copy constructor the
extra copying of the argument could not have been obviated.

The proposed solution is to provide overloaded functions that accept non-temporary
values and return them by reference thus avoiding extra copying.

The proposed solution made an impact on the size of libjavascriptcore_efl.so (EFL
release build): the size decreased from 6554992 bytes to 6554560 bytes.

* wtf/HashTraits.h:
(WTF::GenericHashTraits::passOut):
(WTF::GenericHashTraits::peek):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening after r149292.
zarvai@inf.u-szeged.hu [Wed, 8 May 2013 14:36:48 +0000 (14:36 +0000)]
[Qt] Unreviewed gardening after r149292.
https://bugs.webkit.org/show_bug.cgi?id=115372

* platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: Added.
* platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: Added.
* platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: Added.
* platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/layer-full-repaint-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/overflow-flipped-writing-mode-table-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/reflection-table-layout-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/selection-gap-absolute-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/selection-gap-fixed-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/transform-table-layout-expected.txt: Added.
* platform/qt-5.0-wk2/svg/repaint/repaint-webkit-svg-shadow-container-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed EFL gardening
commit-queue@webkit.org [Wed, 8 May 2013 13:44:47 +0000 (13:44 +0000)]
[EFL] Unreviewed EFL gardening
https://bugs.webkit.org/show_bug.cgi?id=115791

Unreviewed EFL gardening

Skip fast/regions/ test cases which are failing after r149668.

Patch by Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> on 2013-05-08

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] Does memory buffering even with preload set to none
kov@webkit.org [Wed, 8 May 2013 13:41:13 +0000 (13:41 +0000)]
[GStreamer] Does memory buffering even with preload set to none
https://bugs.webkit.org/show_bug.cgi?id=115754

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-08
Reviewed by Philippe Normand.

Covered by existing tests.

Revision 148840 fixed on-disk buffering being done when preload is set to none,
but memory buffering is still being done. That is because setting the state to
paused causes GStreamer to start loading the media, to gather information. Only
doing that when committing the load avoids that while maintaining the tested
behaviour unchanged.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load): move setting pause state to commitLoad.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): see above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVGStyledElement::getPresentationAttribute() does not need to be virtual.
akling@apple.com [Wed, 8 May 2013 13:07:05 +0000 (13:07 +0000)]
SVGStyledElement::getPresentationAttribute() does not need to be virtual.

From Blink r149888 by <cevans@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=149888>

* svg/SVGStyledElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash when loading link to audio file
allan.jensen@digia.com [Wed, 8 May 2013 13:00:59 +0000 (13:00 +0000)]
Crash when loading link to audio file
https://bugs.webkit.org/show_bug.cgi?id=115794

Reviewed by Jocelyn Turcotte.

Do not access a null pointer frame.

* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Skipping some failing fast/region tests.
zarvai@inf.u-szeged.hu [Wed, 8 May 2013 12:56:45 +0000 (12:56 +0000)]
[Qt] Unreviewed gardening. Skipping some failing fast/region tests.
https://bugs.webkit.org/show_bug.cgi?id=115785

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WTR] Fix the build on Mac after r149692
abecsi@webkit.org [Wed, 8 May 2013 12:20:59 +0000 (12:20 +0000)]
[Qt][WTR] Fix the build on Mac after r149692

Unreviewed build fix.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed EFL gardening.
g.czajkowski@samsung.com [Wed, 8 May 2013 11:54:16 +0000 (11:54 +0000)]
Unreviewed EFL gardening.

Unskip two spelling tests as they started passing after r149366.

* platform/efl-wk2/TestExpectations:
Unskip spelling-exactly-selected-word.html and
spelling-with-punctuation-selection.html

* platform/efl/TestExpectations:
Remove spelling tests from efl/TestExpectations as the failing tests
are already skipped for both efl-wk1 and global wk2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused [TransferList] extended attribute
ch.dumez@sisa.samsung.com [Wed, 8 May 2013 10:59:50 +0000 (10:59 +0000)]
Remove unused [TransferList] extended attribute
https://bugs.webkit.org/show_bug.cgi?id=115788

Reviewed by Kentaro Hara.

Remove [TransferList] extended attribute and corresponding tests as it has no
effect on the generated JSC bindings.

No new tests, no behavior change.

* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
* bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
* bindings/scripts/test/CPP/WebDOMTestTypedefs.h:
(WebDOMTestTypedefs):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(JSTestSerializedScriptValueInterfacePrototype):
(JSTestSerializedScriptValueInterfaceConstructor):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore):
* bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
* bindings/scripts/test/ObjC/DOMTestTypedefs.h:
* bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
* bindings/scripts/test/TestSerializedScriptValueInterface.idl:
* bindings/scripts/test/TestTypedefs.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Added Anton Obzhirov to the list of contributors and myself
mario@webkit.org [Wed, 8 May 2013 10:38:30 +0000 (10:38 +0000)]
Unreviewed. Added Anton Obzhirov to the list of contributors and myself
to the watchlist for Accessibility.

* Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
* Scripts/webkitpy/common/config/watchlist: Added myself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed EFL gardening.
sudarsana.nagineni@linux.intel.com [Wed, 8 May 2013 10:16:50 +0000 (10:16 +0000)]
Unreviewed EFL gardening.

Skip remaining Shadow DOM tests on the EFL port.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Build fails with clang
abecsi@webkit.org [Wed, 8 May 2013 09:50:02 +0000 (09:50 +0000)]
[Qt] Build fails with clang
https://bugs.webkit.org/show_bug.cgi?id=115741

Reviewed by Benjamin Poulain.

Since r149112 std::move is used in AtomicString for compilers that
support rvalue references and this requires a standard library
implementing c++11 move semantics.
We only explicitely require c++11 for WebKit2, but since clang supports
rvalue references the build of subtargets using AtomicString fails because
of missing std::move.
It is safe to add CONFIG += c++11 for the whole project when using clang
since we explicitely disable c++11 for ANGLE that had probems with libc++.

* qmake/mkspecs/features/unix/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix one more place that needed to use adoptCF/NS
darin@apple.com [Wed, 8 May 2013 09:41:11 +0000 (09:41 +0000)]
Fix one more place that needed to use adoptCF/NS
https://bugs.webkit.org/show_bug.cgi?id=115778

Reviewed by Benjamin Poulain.

Not sure why I missed this code last time, but found a bit more code that needs
to switch to the newer style adoptCF/NS.

* WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
(convertWebResourceDataToString): Use adoptCF.
(convertWebResourceResponseToDictionary): Ditto.
(createXMLStringFromWebArchiveData): Ditto.
* WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
(createCFURLResponseFromResponseData): Use adoptNS and adoptCF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 8 May 2013 09:23:14 +0000 (09:23 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding failure expectations for CSS Regions tests
that regressed when converted into reftests in r149668.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake optional arguments in CanvasRenderingContext2D match the spec.
commit-queue@webkit.org [Wed, 8 May 2013 08:55:25 +0000 (08:55 +0000)]
Make optional arguments in CanvasRenderingContext2D match the spec.
https://bugs.webkit.org/show_bug.cgi?id=115723

Patch by Dongseong Hwang <dongseong.hwang@intel.com> on 2013-05-08
Reviewed by Dean Jackson.

Source/WebCore:

WebKit r98985 set many arguments optional although the canvas spec[1] does not
indicate. So this patch corrects CanvasRenderingContext2D.idl to match the spec.

[1] http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas/

Covered by existing tests:
  canvas/philip/tests/2d.missingargs.html
  fast/canvas/canvas-overloads-strokeRect.html
  inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html

* html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

When tests use <canvas> API with not enough arguments, TypeError
exception is fired now. So three tests are changed to match the canvas
spec.

* fast/canvas/canvas-overloads-strokeRect-expected.txt:
* fast/canvas/script-tests/canvas-overloads-strokeRect.js:
* platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r149271.
zandobersek@gmail.com [Wed, 8 May 2013 08:28:12 +0000 (08:28 +0000)]
Unreviewed, rolling out r149271.
http://trac.webkit.org/changeset/149271
https://bugs.webkit.org/show_bug.cgi?id=115780

The mangled symbols are now enforced through LDFLAGS
(Requested by zdobersek on #webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2013-05-08

* BuildSlaveSupport/gtk/daemontools-buildbot.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend...
zandobersek@gmail.com [Wed, 8 May 2013 08:14:49 +0000 (08:14 +0000)]
[Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
https://bugs.webkit.org/show_bug.cgi?id=115636

Reviewed by Ryosuke Niwa.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
while Chromium-specific, can't be removed just yet as there's more code that uses it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Make the WebNetworkInfoManager a supplement to the WebProcess
zandobersek@gmail.com [Wed, 8 May 2013 08:06:00 +0000 (08:06 +0000)]
[WK2] Make the WebNetworkInfoManager a supplement to the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=115716

Reviewed by Andreas Kling.

WebNetworkInfoManager should inherit from WebProcessSupplement and should be used
as such by the WebProcess. This removes the need for the m_networkInfoManager member
variable in the WebProcess class and brings the WebNetworkInfoManager in line with
other manager classes of which instances are controlled by the WebProcess class.

* WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:
(WebKit::WebNetworkInfoManager::supplementName): Specify the supplement's name.
(WebKit):
* WebProcess/NetworkInfo/WebNetworkInfoManager.h:
(WebKit): Alphabetically reorder the two forwarding declarations.
(WebNetworkInfoManager): Inherit from the WebProcessSupplement interface.
* WebProcess/WebCoreSupport/WebNetworkInfoClient.cpp:
(WebKit::WebNetworkInfoClient::bandwidth): Access the WebNetworkInfoManager as a supplement.
(WebKit::WebNetworkInfoClient::metered): Ditto.
(WebKit::WebNetworkInfoClient::startUpdating): Ditto.
(WebKit::WebNetworkInfoClient::stopUpdating): Ditto.
(WebKit::WebNetworkInfoClient::networkInfoControllerDestroyed): Ditto.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Add the WebNetworkInfoManager instance as a supplement.
* WebProcess/WebProcess.h:
(WebProcess): Remove the m_networkInfoManager member variable and its getter method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Correct documentation for ewk_settings APIs
commit-queue@webkit.org [Wed, 8 May 2013 08:02:28 +0000 (08:02 +0000)]
[EFL] Correct documentation for ewk_settings APIs
https://bugs.webkit.org/show_bug.cgi?id=115507

Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-05-08
Reviewed by Gyuyoung Kim.

Corrected documentation for ewk_settings APIs.

* ewk/ewk_settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused method and de-virtualize others in Element.h
rniwa@webkit.org [Wed, 8 May 2013 07:58:17 +0000 (07:58 +0000)]
Remove unused method and de-virtualize others in Element.h
https://bugs.webkit.org/show_bug.cgi?id=115770

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/c2c2ff9cb69f46f5cc9d289b2bfbdb8ab5bd3e49

The de-virtualization possibilities were noted whilst "FINALizing" the Node
hierarchy. If a method is successfully marked FINAL but then fails when marked
OVERRIDE as well, the method by definition does not need to be virtual.

* WebCore.exp.in:
* dom/Element.h:
(WebCore::Element::hasAuthorShadowRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Make the WebBatteryManager a supplement to the WebProcess
zandobersek@gmail.com [Wed, 8 May 2013 07:51:48 +0000 (07:51 +0000)]
[WK2] Make the WebBatteryManager a supplement to the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=115715

Reviewed by Andreas Kling.

WebBatteryManager should inherit from WebProcessSupplement and should be used as such
by the WebProcess. This removes the need for the m_batteryManager member variable in
the WebProcess class and brings the WebBatteryManager in line with other manager classes
of which instances are controlled by the WebProcess class.

* WebProcess/Battery/WebBatteryManager.cpp:
(WebKit::WebBatteryManager::supplementName): Specify the supplement's name.
(WebKit):
* WebProcess/Battery/WebBatteryManager.h:
(WebBatteryManager): Inherit from the WebProcessSupplement interface.
* WebProcess/WebCoreSupport/WebBatteryClient.cpp:
(WebKit::WebBatteryClient::startUpdating): Access the WebBatteryManager as a supplement.
(WebKit::WebBatteryClient::stopUpdating): Ditto.
(WebKit::WebBatteryClient::batteryControllerDestroyed): Ditto.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Add the WebBatteryManager instance as a supplement.
* WebProcess/WebProcess.h:
(WebProcess): Remove the m_batteryManager member variable and its getter method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Use adoptCF and adoptNS in more places
darin@apple.com [Wed, 8 May 2013 07:40:11 +0000 (07:40 +0000)]
Source/WebCore: Use adoptCF and adoptNS in more places
https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.

* platform/cf/win/CertificateCFWin.cpp:
(WebCore::copyCertificateToData):
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged):
(WebCore::AVFWrapper::createAssetForURL):
(WebCore::AVFWrapper::createPlayer):
(WebCore::AVFWrapper::createPlayerItem):
(WebCore::AVFWrapper::setAsset):
(WebCore::AVFWrapper::platformLayer):
(WebCore::AVFWrapper::createAVCFVideoLayer):
(WebCore::AVFWrapper::createImageGenerator):
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::language):
* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(toCACFTimingFunction):
(PlatformCAAnimation::PlatformCAAnimation):
(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
(PlatformCAAnimation::setKeyTimes):
(PlatformCAAnimation::setTimingFunctions):
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::setBackgroundColor):
(PlatformCALayer::setBorderColor):
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::PlatformCALayerWinInternal):
(PlatformCALayerWinInternal::addTile):
* platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost):
* platform/graphics/gstreamer/PlatformVideoWindowMac.mm:
(PlatformVideoWindow::PlatformVideoWindow):
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::getPostScriptName):
(WebCore::FontPlatformData::platformDataInit):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawWindowsBitmap):
* platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::create):
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::rfc2616DateStringFromTime):
(WebCore::QTCFDictionaryCreateWithDataCallback):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
* platform/graphics/win/WKCAImageQueue.cpp:
(WebCore::WKCAImageQueue::WKCAImageQueue):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::qcmsOutputDeviceProfile):
* platform/network/cf/AuthenticationCF.cpp:
(WebCore::core):
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::cookieDomain):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
(WebCore::filterCookies):
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::certificatePath):
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::urlFromPath):
(WebCore::getURL):
* platform/win/LocalizedStringsWin.cpp:
(WebCore::createWebKitBundle):
(WebCore::localizedString):
* platform/win/SearchPopupMenuWin.cpp:
(WebCore::SearchPopupMenuWin::saveRecentSearches):
(WebCore::SearchPopupMenuWin::loadRecentSearches):
* plugins/mac/PluginPackageMac.cpp:
(WebCore::stringListFromResourceId):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
* plugins/mac/PluginViewMac.mm:
(WebCore::PluginView::platformStart):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::platformFocusRingColor):
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):
Use adoptCF and adoptNS throughout.

Source/WebKit/win: Use adoptCF and adoptNS in more places
https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.

* CFDictionaryPropertyBag.cpp:
(CFDictionaryPropertyBag::Write):
* WebCache.cpp:
(WebCache::statistics):
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::localizedStringsURL):
* WebDatabaseManager.cpp:
(WebDatabaseManager::dispatchDidModifyDatabase):
* WebDownloadCFNet.cpp:
(WebDownload::init):
(WebDownload::initWithRequest):
(WebDownload::initToResumeWithBundle):
(WebDownload::cancelForResume):
(WebDownload::useCredential):
(WebDownload::didReceiveAuthenticationChallenge):
* WebError.cpp:
(WebError::sslPeerCertificate):
* WebHistory.cpp:
(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
(WebHistory::WebHistory):
(WebHistory::loadFromURL):
(WebHistory::loadHistoryGutsFromURL):
(WebHistory::saveToURL):
(WebHistory::saveHistoryGuts):
(WebHistory::removeAllItems):
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::itemForURL):
(WebHistory::addItemToDateCaches):
(getDayBoundaries):
* WebIconDatabase.cpp:
(postDidAddIconNotification):
* WebLocalizableStrings.cpp:
(cfBundleForStringsBundle):
* WebMutableURLRequest.cpp:
(WebMutableURLRequest::mutableCopy):
* WebPreferences.cpp:
(cfNumber):
(WebPreferences::initializeDefaultSettings):
(WebPreferences::valueForKey):
(WebPreferences::setStringValue):
(WebPreferences::load):
(WebPreferences::migrateWebKitPreferencesToCFPreferences):
(WebPreferences::setPreferenceForTest):
* WebView.cpp:
(WebView::setCacheModel):
(WebView::notifyPreferencesChanged):
Use adoptCF and adoptNS.

Source/WebKit2: Use adoptCF and adoptNS in more places
https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

* Shared/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::useCredential):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::didDecideDestination):
Use adoptCF and adoptNS.

Tools: Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.

* DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
(convertWebResourceDataToString):
(convertWebResourceResponseToDictionary):
(createXMLStringFromWebArchiveData):
* DumpRenderTree/cg/ImageDiffCG.cpp:
(createImageFromStdin):
(createDifferenceImage):
(main):
* DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(printPNG):
(dumpBitmap):
* DumpRenderTree/cg/PixelDumpSupportCG.h:
(BitmapContext::BitmapContext):
* DumpRenderTree/mac/MockWebNotificationProvider.mm:
(-[MockWebNotificationProvider init]):
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContext):
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::addDisallowedURL):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::localStorageDiskUsageForOrigin):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::copyDecodedHostName):
(TestRunner::copyEncodedHostName):
(TestRunner::queueLoad):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setValueForUser):
(TestRunner::overridePreference):
(TestRunner::setPersistentUserStyleSheetLocation):
(TestRunner::execCommand):
(TestRunner::findString):
(TestRunner::isCommandEnabled):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::evaluateInWebInspector):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
(TestRunner::authenticateSession):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):
* DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
(createCFURLResponseFromResponseData):
* DumpRenderTree/mac/WorkQueueItemMac.mm:
(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):
* DumpRenderTree/win/DumpRenderTree.cpp:
(substringFromIndex):
(urlSuitableForTestResult):
(lastPathComponent):
(sharedCFURLCache):
* DumpRenderTree/win/ImageDiffCairo.cpp:
(createImageFromStdin):
(main):
* DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView):
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setPersistentUserStyleSheetLocation):
* TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
* TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
(TestWebKitAPI::createWindow):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
(TestWebKitAPI::AcceptsFirstMouse::runTest):
* TestWebKitAPI/Tests/mac/AttributedString.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/BackForwardList.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
* TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
(TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
* TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/InspectorBar.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
* TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::MIMETypeForWKURLResponse):
* TestWebKitAPI/mac/WebKitAgnosticTest.mm:
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
* WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
(WTR::testPathFromURL):
* WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage):
(WTR::dumpBitmap):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollBy):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::windowSnapshotImage):
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeTestPluginDirectory):
Use adoptCF and adoptNS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd an image only failure expectation to fast/css-generated-content/close-quote-negat...
rniwa@webkit.org [Wed, 8 May 2013 07:05:27 +0000 (07:05 +0000)]
Add an image only failure expectation to fast/css-generated-content/close-quote-negative-depth.html per
bug 115776 after r149700. r149707 tried to fix its regression but this test is still failing.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Automake] Pass --no-demangle to the linker by default to get the mangled symbols
zandobersek@gmail.com [Wed, 8 May 2013 07:03:55 +0000 (07:03 +0000)]
[Automake] Pass --no-demangle to the linker by default to get the mangled symbols
https://bugs.webkit.org/show_bug.cgi?id=115732

Reviewed by Gustavo Noronha Silva.

* GNUmakefile.am: Pass the --no-demangle option to the linker by default. This is done by appending
the flag to the LDFLAGS variable. While the AM_LDFLAGS variable would be more appropriate, it's not
at all used when linking installable libraries like libwebkitgtk and libwebkit2gtk, so the LDFLAGS
variable is used instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/13633007> WebKit and others fail to build headers due to build root...
mrowe@apple.com [Wed, 8 May 2013 07:00:31 +0000 (07:00 +0000)]
<rdar://problem/13633007> WebKit and others fail to build headers due to build root dependency

Reviewed by Sam Weinig.

* Configurations/WebKit.xcconfig: Look for WebCore's headers within the SDK if we're building against one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Remove the ewk_settings_shadow_dom_enable_set/get APIs from unit test
commit-queue@webkit.org [Wed, 8 May 2013 06:24:33 +0000 (06:24 +0000)]
[EFL] Remove the ewk_settings_shadow_dom_enable_set/get APIs from unit test
https://bugs.webkit.org/show_bug.cgi?id=115771

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-05-07
Reviewed by Gyuyoung Kim.

Unit test is failing since r149702. Remove the test case related to shadow dom.

* tests/test_ewk_setting.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up load interface in WebPage
commit-queue@webkit.org [Wed, 8 May 2013 05:08:32 +0000 (05:08 +0000)]
Clean up load interface in WebPage
https://bugs.webkit.org/show_bug.cgi?id=115622
Patch by Xuefei Ren <xren@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.

Internal PR:315535
Internal reviewed by  Mary Wu

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::load):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::startDownload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake CanvasStyle's CMYKAValues allocated on the heap and move the pointer in the...
benjamin@webkit.org [Wed, 8 May 2013 03:18:12 +0000 (03:18 +0000)]
Make CanvasStyle's CMYKAValues allocated on the heap and move the pointer in the union.
https://bugs.webkit.org/show_bug.cgi?id=115764

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-07
Reviewed by Andreas Kling.

CMYKA input is uncommon enough that we should not pay the price for
every CanvasStyle.
Make those values heap allocated and put the pointer in the union. Since
the RGBA32 values are needed for CMYKA, a RGBA32 value is added to the structure.

* html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::~CanvasStyle):
(WebCore::CanvasStyle::isEquivalentColor):
(WebCore::CanvasStyle::isEquivalentCMYKA):
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
* html/canvas/CanvasStyle.h:
(CanvasStyle):
(CMYKAValues):
(WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
(WebCore::CanvasStyle::color):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse OwnPtr instead of deleteAllValues for requests in PluginView
darin@apple.com [Wed, 8 May 2013 02:41:08 +0000 (02:41 +0000)]
Use OwnPtr instead of deleteAllValues for requests in PluginView
https://bugs.webkit.org/show_bug.cgi?id=115731

Reviewed by Sam Weinig.

* plugins/PluginView.cpp:
(WebCore::PluginView::~PluginView): Removed the call to deleteAllValues.
(WebCore::PluginView::requestTimerFired): Use release to remove an OwnPtr
from m_requests rather than an explicit delete. Also use !isEmpty instead
of size > 0.
(WebCore::PluginView::scheduleRequest): Changed argument type to PassOwnPtr.
(WebCore::PluginView::load): Use adoptPtr to call scheduleRequest.

* plugins/PluginView.h: Changed argument type of scheduleRequest to
PassOwnPtr, and m_requests to a Vector<OwnPtr>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove SelectRuleFeatureSet
antti@apple.com [Wed, 8 May 2013 02:03:29 +0000 (02:03 +0000)]
Remove SelectRuleFeatureSet
https://bugs.webkit.org/show_bug.cgi?id=115757

Reviewed by Benjamin Poulain.

This is dead code.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore):
(WebCore::Element::didAffectSelector):
* dom/Element.h:
(Element):
* dom/ElementShadow.h:
(WebCore::ElementShadow::invalidateDistribution):
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::ContentDistributor):
(WebCore):
* html/shadow/ContentDistributor.h:
(ContentDistributor):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):
* html/shadow/InsertionPoint.h:
(InsertionPoint):
* html/shadow/SelectRuleFeatureSet.cpp: Removed.
* html/shadow/SelectRuleFeatureSet.h: Removed.
* testing/Internals.cpp:
(WebCore):
* testing/Internals.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStore the quotes in the same allocation as the QuotesData object
andersca@apple.com [Wed, 8 May 2013 01:47:57 +0000 (01:47 +0000)]
Store the quotes in the same allocation as the QuotesData object
https://bugs.webkit.org/show_bug.cgi?id=115768

Reviewed by Andreas Kling.

Since the QuotesData object is immutable we don't need a Vector to store the quote pairs,
they can just be stored after the class data.

* rendering/style/QuotesData.cpp:
(WebCore::sizeForQuotesDataWithQuoteCount):
Helper function for computing the allocation size.

(WebCore::QuotesData::create):
Use fastMalloc + placement new.

(WebCore::QuotesData::QuotesData):
Use placement new to allocate the quote pairs.

(WebCore::QuotesData::~QuotesData):
Destroy the quote pairs.

(WebCore::QuotesData::openQuote):
Stop using Vector.

(WebCore::QuotesData::closeQuote):
Ditto.

(WebCore::operator==):
Ditto.

* rendering/style/QuotesData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWe should not ref() the RefPtr twice in CanvasStyle
benjamin@webkit.org [Wed, 8 May 2013 01:42:59 +0000 (01:42 +0000)]
We should not ref() the RefPtr twice in CanvasStyle

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-07
Reviewed by Darin Adler.

* html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
We leak the ref of PassRefPtr, we should not ref() it a second time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDevirtualize Document class type checking
rniwa@webkit.org [Wed, 8 May 2013 01:41:16 +0000 (01:41 +0000)]
Devirtualize Document class type checking
https://bugs.webkit.org/show_bug.cgi?id=115755

Reviewed by Benjamin Poulain.

Merge https://chromium.googlesource.com/chromium/blink/+/dae5adc768d5ce6bff301df6515745da8ea24950

Document has a bunch of virtual bool is*Document() methods on it, but it also has
two bools for XHTML and HTML documents which is silly. We can merge them all
together into an enum of values and devirtualize the type checking methods.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::createElement):
* dom/Document.h:
(WebCore::Document::create):
(WebCore::Document::createXHTML):
(WebCore::Document::isHTMLDocument):
(WebCore::Document::isXHTMLDocument):
(WebCore::Document::isImageDocument):
(WebCore::Document::isSVGDocument):
(WebCore::Document::isPluginDocument):
(WebCore::Document::isMediaDocument):
(WebCore::Document):
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::HTMLDocument):
* html/HTMLDocument.h:
(WebCore::HTMLDocument):
* html/ImageDocument.cpp:
(WebCore::ImageDocument::ImageDocument):
* html/ImageDocument.h:
(WebCore::ImageDocument):
* html/MediaDocument.cpp:
(WebCore::MediaDocument::MediaDocument):
* html/MediaDocument.h:
(WebCore::MediaDocument):
* html/PluginDocument.cpp:
(WebCore::PluginDocument::PluginDocument):
* html/PluginDocument.h:
(WebCore::PluginDocument):
* loader/PlaceholderDocument.h:
(WebCore::PlaceholderDocument::PlaceholderDocument):
* svg/SVGDocument.cpp:
(WebCore::SVGDocument::SVGDocument):
* svg/SVGDocument.h:
(WebCore::SVGDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a memory leak introduced in r149692
commit-queue@webkit.org [Wed, 8 May 2013 01:35:51 +0000 (01:35 +0000)]
Fix a memory leak introduced in r149692
https://bugs.webkit.org/show_bug.cgi?id=115766

Patch by Alex Christensen <achristensen@apple.com> on 2013-05-07
Reviewed by Mark Rowe.

In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Fix the memory leak by switching to WKRetainPtr and adopting the returned object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Win] Fix storage leak in Windows DumpRenderTree
darin@apple.com [Wed, 8 May 2013 01:26:34 +0000 (01:26 +0000)]
[Win] Fix storage leak in Windows DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=115651

Reviewed by Sam Weinig.

* DumpRenderTree/win/DumpRenderTree.cpp:
(lastPathComponent): Added a missing call to adoptCF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMAKE] Remove SHADOW_DOM from cmakeconfig.h.cmake
gyuyoung.kim@samsung.com [Wed, 8 May 2013 01:13:34 +0000 (01:13 +0000)]
[CMAKE] Remove SHADOW_DOM from cmakeconfig.h.cmake
https://bugs.webkit.org/show_bug.cgi?id=115712

Reviewed by Andreas Kling.

Nobody uses SHADOW_DOM in cmake.

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd SPI to get an array of all the installed plug-ins
weinig@apple.com [Wed, 8 May 2013 00:11:19 +0000 (00:11 +0000)]
Add SPI to get an array of all the installed plug-ins
https://bugs.webkit.org/show_bug.cgi?id=115688

Reviewed by Anders Carlsson.

* UIProcess/API/C/mac/WKContextPrivateMac.h:
* UIProcess/API/C/mac/WKContextPrivateMac.mm:
(createInfoDictionary):
Extract creation of info dictionary into helper.
(WKContextCopyPlugInInfoForBundleIdentifier):
Modified to use the new helper.
(WKContextGetInfoForInstalledPlugIns):
Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBegin unraveling the mess that is QuotesData
andersca@apple.com [Tue, 7 May 2013 23:07:14 +0000 (23:07 +0000)]
Begin unraveling the mess that is QuotesData
https://bugs.webkit.org/show_bug.cgi?id=115765

Reviewed by Andreas Kling.

Change QuotesData to be an immutable object and fix other things that are broken.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
QuotesData::addPair is gone. Instead, create the Vector up front and pass it to QuotesData.

* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::originalText):
Update for renames.

* rendering/style/QuotesData.cpp:
(WebCore::QuotesData::create):
Remove the create overload that wasn't used. Add a new create overload that takes a Vector.

(WebCore::QuotesData::openQuote):
Rename this from getOpenQuote and clean it up.

(WebCore::QuotesData::closeQuote):
Rename this from getCloseQuote and clean it up.

(WebCore::operator==):
Replace the equals member function with a proper equality operator.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
Stop calling QuotesData::equals. Use the same idiom as used for other properties.

(WebCore::RenderStyle::setQuotes):
* rendering/style/StyleRareInheritedData.cpp:
Use operator==.

(WebCore::quotesDataEquivalent):
Add helper function.

(WebCore::StyleRareInheritedData::operator==):
Call quotesDataEquivalent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Exclusions] shape-inside, shape-padding, polygon test failing when subpixel...
hmuller@adobe.com [Tue, 7 May 2013 22:54:12 +0000 (22:54 +0000)]
[CSS Exclusions] shape-inside, shape-padding, polygon test failing when subpixel layout is disabled
https://bugs.webkit.org/show_bug.cgi?id=115649

Reviewed by Dirk Schulze.

Another correction of a padded shape test that failed when subpixel layout was disabled.
This test puts a cross pattern made of five Ahem characters on three lines, within a padded
diamond polygon. The left edges of each line depend on the intersection of the padded polygon's
edges with the top of each line, which makes predicting the exact values unreliable. So we
just verify that the left edges of each line are within a pixel of the ideal value. This
change is very similar to the one made for bug 115490.

* fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.html: Removed.
* fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.txt: Added.
* fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport -webkit-system-font on OS X.
enrica@apple.com [Tue, 7 May 2013 22:41:43 +0000 (22:41 +0000)]
Support -webkit-system-font on OS X.
https://bugs.webkit.org/show_bug.cgi?id=115758
<rdar://problem/13433854>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofixed a memory leak introduced by bug 42324 by using a RetainPtr
commit-queue@webkit.org [Tue, 7 May 2013 22:26:16 +0000 (22:26 +0000)]
fixed a memory leak introduced by bug 42324 by using a RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=115760

Patch by Alex Christensen <achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
fixed memory leak, added UNUSED_PARAM macros

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove CanvasGradient and CanvasPattern in the union of CanvasStyle
benjamin@webkit.org [Tue, 7 May 2013 22:14:04 +0000 (22:14 +0000)]
Move CanvasGradient and CanvasPattern in the union of CanvasStyle
https://bugs.webkit.org/show_bug.cgi?id=115759

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-07
Reviewed by Andreas Kling.

The Gradient and Pattern are exclusive with the other values, but they
were left out of the union because they are ref-counted.

This patch moves them in the union, and simply does the ref-counting manually.

* html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::~CanvasStyle):
* html/canvas/CanvasStyle.h:
(CanvasStyle):
(WebCore::CanvasStyle::canvasGradient):
(WebCore::CanvasStyle::canvasPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove custom allocator support from PODArena
andersca@apple.com [Tue, 7 May 2013 22:06:15 +0000 (22:06 +0000)]
Remove custom allocator support from PODArena
https://bugs.webkit.org/show_bug.cgi?id=115762

Reviewed by Andreas Kling.

Nobody uses PODArena with a custom allocator, so just get rid of it and always use fastMalloc/fastFree.

* platform/PODArena.h:
(WebCore::PODArena::PODArena):
(WebCore::PODArena::allocateBase):
(WebCore::PODArena::Chunk::Chunk):
(WebCore::PODArena::Chunk::~Chunk):
(Chunk):
* platform/PODFreeListArena.h:
(WebCore::PODFreeListArena::allocate):
(WebCore::PODFreeListArena::FreeListChunk::FreeListChunk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up KeyframeValueList and related classes
andersca@apple.com [Tue, 7 May 2013 22:04:01 +0000 (22:04 +0000)]
Clean up KeyframeValueList and related classes
https://bugs.webkit.org/show_bug.cgi?id=115738

Reviewed by Simon Fraser.

Source/WebCore:

Add static create() functions to the AnimationValue subclasses, and change a bunch of parameters
and return values that can never be null from pointer types to reference types to better indicate this.

* platform/graphics/GraphicsLayer.cpp:
(WebCore::filterOperationsAt):
(WebCore::GraphicsLayer::validateFilterOperations):
(WebCore::operationsAt):
(WebCore::GraphicsLayer::validateTransformOperations):
* platform/graphics/GraphicsLayer.h:
(AnimationValue):
(WebCore::AnimationValue::AnimationValue):
(WebCore::FloatAnimationValue::create):
(FloatAnimationValue):
(WebCore::FloatAnimationValue::FloatAnimationValue):
(WebCore::TransformAnimationValue::create):
(TransformAnimationValue):
(WebCore::TransformAnimationValue::value):
(WebCore::TransformAnimationValue::TransformAnimationValue):
(WebCore::FilterAnimationValue::create):
(WebCore::FilterAnimationValue::value):
(WebCore::FilterAnimationValue::FilterAnimationValue):
(FilterAnimationValue):
(WebCore::KeyframeValueList::~KeyframeValueList):
(KeyframeValueList):
(WebCore::KeyframeValueList::at):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerCA::setAnimationEndpoints):
(WebCore::GraphicsLayerCA::setAnimationKeyframes):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::setFilterAnimationEndpoints):
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

Source/WebKit2:

Update for WebCore changes.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd and remove databases and origins from the database tracker
andersca@apple.com [Tue, 7 May 2013 21:52:50 +0000 (21:52 +0000)]
Add and remove databases and origins from the database tracker
https://bugs.webkit.org/show_bug.cgi?id=115752

Reviewed by Andreas Kling.

Source/WebCore:

Add symbols needed by WebKit2.

* WebCore.exp.in:

Source/WebKit2:

* UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::LocalStorageDatabase):
Rename m_databaseFilename to m_databasePath.

(WebKit::LocalStorageDatabase::tryToOpenDatabase):
Rename m_databaseFilename to m_databasePath.

* UIProcess/Storage/LocalStorageDatabase.h:
Rename m_databaseFilename to m_databasePath.

* UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::databasePath):
Rename databaseFilename to databasePath.

(WebKit::LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin):
Call addDatabaseWithOriginIdentifier.

(WebKit::LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin):
Call removeDatabaseWithOriginIdentifier.

(WebKit::LocalStorageDatabaseTracker::trackerDatabasePath):
Call databasePath instead of databaseFile.

(WebKit::LocalStorageDatabaseTracker::openTrackerDatabase):
Bail if the database is already open.

(WebKit::LocalStorageDatabaseTracker::updateTrackerDatabaseFromLocalStorageDatabaseFiles):
Call addDatabaseWithOriginIdentifier if this is an origin we don't know about.

(WebKit::LocalStorageDatabaseTracker::addDatabaseWithOriginIdentifier):
Add the database to the Origins table.

(WebKit::LocalStorageDatabaseTracker::removeDatabaseWithOriginIdentifier):
remove the database from the Origins table and delete it.

(WebKit::LocalStorageDatabaseTracker::pathForDatabaseWithOriginIdentifier):
Helper function that looks up a database path given its identifier.

* UIProcess/Storage/LocalStorageDatabaseTracker.h:
Rename databaseFile to databasePath.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKitTestRunner needs testRunner.dumpDOMAsWebArchive
commit-queue@webkit.org [Tue, 7 May 2013 21:26:56 +0000 (21:26 +0000)]
WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
https://bugs.webkit.org/show_bug.cgi?id=42324
<rdar://problem/8193633>

Patch by Alex Christensen <achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.

* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Added dumpDOMAsWebArchive code that is called when dumping.
(WTR::InjectedBundlePage::dump):
Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
Added dumpDOMAsWebArchive declaration.
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::dumpDOMAsWebArchive):
Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
* Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
* Tools/WebKitTestRunner/cf: Added.
* Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
(convertMIMEType):
(convertWebResourceDataToString):
(normalizeHTTPResponseHeaderFields):
(normalizeWebResourceURL):
(convertWebResourceResponseToDictionary):
(compareResourceURLs):
(createXMLStringFromWebArchiveData):
* Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
Copied from Tools/DumpRenderTree/cf for used symbol declarations.
* Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
Copied from Tools/DumpRenderTree/mac for used functions.
(createCFURLResponseFromResponseData):
(supportedNonImageMIMETypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStill possible to fire paint-related LayoutMilestones before CA has committed the
bdakin@apple.com [Tue, 7 May 2013 21:12:58 +0000 (21:12 +0000)]
Still possible to fire paint-related LayoutMilestones before CA has committed the
changes
https://bugs.webkit.org/show_bug.cgi?id=115753
-and corresponding-
<rdar://problem/13822315>

Reviewed by Simon Fraser.

To ensure we wait for the CA commit, we should wait until the end of the runloop
with a zero-delay timer.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):
(WebCore):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug 115694 - Fix bad cast to RenderHTMLCanvas
cfleizach@apple.com [Tue, 7 May 2013 21:09:48 +0000 (21:09 +0000)]
Bug 115694 - Fix bad cast to RenderHTMLCanvas
https://bugs.webkit.org/show_bug.cgi?id=115694

Reviewed by Ryosuke Niwa.

Don't cast to RenderHTML until we check what kind of object it is.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Increase the padding size for caret based scrolling.
mifenton@rim.com [Tue, 7 May 2013 20:30:02 +0000 (20:30 +0000)]
[BlackBerry] Increase the padding size for caret based scrolling.
https://bugs.webkit.org/show_bug.cgi?id=115749

Reviewed by Rob Buis.

PR 322670.

Increasing the padding size for scrolling in order to optimize the
number of scrolls required during typing.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe storage database tracker should know when databases come and go
andersca@apple.com [Tue, 7 May 2013 19:42:03 +0000 (19:42 +0000)]
The storage database tracker should know when databases come and go
https://bugs.webkit.org/show_bug.cgi?id=115748

Reviewed by Andreas Kling.

Source/WebCore:

Export symbol needed by WebKit2.

* WebCore.exp.in:

Source/WebKit2:

* UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::openDatabase):
If we've opened the database successfully, call LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin.

(WebKit::LocalStorageDatabase::tryToOpenDatabase):
Remove a FIXME; we run all storage related things on the same thread.

(WebKit::LocalStorageDatabase::close):
Close the database. If it's empty, call LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin.

(WebKit::LocalStorageDatabase::databaseIsEmpty):
Helper function for determining whether a database is empty.

* UIProcess/Storage/LocalStorageDatabase.h:
* UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::databaseFilename):
Add ".localstorage" to the filename.

(WebKit::LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin):
(WebKit::LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin):
Add empty stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd JoinExistingSession to the Networking XPC.
beidson@apple.com [Tue, 7 May 2013 19:11:39 +0000 (19:11 +0000)]
Add JoinExistingSession to the Networking XPC.
<rdar://problem/12902288> and https://bugs.webkit.org/show_bug.cgi?id=114991

Reviewed by Sam Weinig.

* NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
commit-queue@webkit.org [Tue, 7 May 2013 19:08:32 +0000 (19:08 +0000)]
Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=115745

Patch by Alex Christensen <achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.

* DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
(compareResourceURLs):
Updated style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Maintain touch event state throughout processing
commit-queue@webkit.org [Tue, 7 May 2013 18:52:12 +0000 (18:52 +0000)]
[BlackBerry] Maintain touch event state throughout processing
https://bugs.webkit.org/show_bug.cgi?id=115663

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.

Internally reviewed by Otto Cheung and Genevieve Mak.

PR 297691
By maintaining our touch event state, we can get a better idea
of what triggered an update to selection and respond appropriately.
On touch press we set userTouchTriggered to give the UI thread
some context.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse OwnPtr instead of deleteAllValues in SVGResourcesCache
darin@apple.com [Tue, 7 May 2013 18:42:52 +0000 (18:42 +0000)]
Use OwnPtr instead of deleteAllValues in SVGResourcesCache
https://bugs.webkit.org/show_bug.cgi?id=115729

Reviewed by Benjamin Poulain.

* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::~SVGResourcesCache): Removed call to deleteAllValues.
(WebCore::SVGResourcesCache::addResourcesFromRenderObject): Use adoptPtr and release
to create new SVGResources object.
(WebCore::SVGResourcesCache::removeResourcesFromRenderObject): Use take to remove
the SVGResources from the map rather than a get combined with delete/take.
(WebCore::SVGResourcesCache::cachedResourcesForRenderObject): Removed unneeded
call to contains, since get already returns 0 if there is no item in the map.
(WebCore::SVGResourcesCache::resourceDestroyed): Use typedef for the map type so
we don't have to repeat the type.

* rendering/svg/SVGResourcesCache.h: Added typedef CacheMap, and changed value
type to OwnPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r149647): Assertion failure in LocalStorageDatabaseTracker::setLocalStorag...
andersca@apple.com [Tue, 7 May 2013 18:30:19 +0000 (18:30 +0000)]
REGRESSION(r149647): Assertion failure in LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal
https://bugs.webkit.org/show_bug.cgi?id=115711

Reviewed by Andreas Kling.

Source/WebCore:

Export SQLiteDatabase::close.

* WebCore.exp.in:

Source/WebKit2:

Handle setting the local storage directory more than once.

* UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal):
Close the database (if necessary) and clear the origins map before importing the origin identifiers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRe-establish autostart timeout extension on user interaction
graouts@apple.com [Tue, 7 May 2013 18:12:48 +0000 (18:12 +0000)]
Re-establish autostart timeout extension on user interaction
https://bugs.webkit.org/show_bug.cgi?id=113232

Change WebProcess::pluginDidReceiveUserInteraction to use a tuple of
(pluginOrigin, pageOrigin, mimeType) arguments like the other similar
WebProcess methods and gather these arguments from the PlugInView's
plug-in element.

Reviewed by Dean Jackson.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginDidReceiveUserInteraction):
Cast the m_pluginElement to a HTMLPlugInImageElement so we can obtain the
tuple of (pluginOrigin, pageOrigin, mimeType) to pass to pluginDidReceiveUserInteraction().

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::plugInDidReceiveUserInteraction):
* WebProcess/WebProcess.h:
(WebProcess):
Update method signature to a tuple of (pluginOrigin, pageOrigin, mimeType)
and obtain the plug-in origin hash from that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Combine html and js parts fast/url script-tests
ap@apple.com [Tue, 7 May 2013 17:58:45 +0000 (17:58 +0000)]
    Combine html and js parts fast/url script-tests
        https://bugs.webkit.org/show_bug.cgi?id=115739

        Rubber-stamped by Brady Eidson.

        * fast/url/anchor.html:
        * fast/url/file-http-base.html:
        * fast/url/file.html:
        * fast/url/host-lowercase-per-scheme.html:
        * fast/url/host.html:
        * fast/url/idna2003.html:
        * fast/url/idna2008.html:
        * fast/url/invalid-urls-utf8.html:
        * fast/url/ipv4.html:
        * fast/url/ipv6.html:
        * fast/url/mailto.html:
        * fast/url/path-url.html:
        * fast/url/path.html:
        * fast/url/port.html:
        * fast/url/query.html:
        * fast/url/relative-unix.html:
        * fast/url/relative-win.html:
        * fast/url/relative.html:
        * fast/url/safari-extension.html:
        * fast/url/scheme.html:
        * fast/url/script-tests: Removed.
        * fast/url/script-tests/TEMPLATE.html: Removed.
        * fast/url/script-tests/anchor.js: Removed.
        * fast/url/script-tests/file-http-base.js: Removed.
        * fast/url/script-tests/file.js: Removed.
        * fast/url/script-tests/host.js: Removed.
        * fast/url/script-tests/idna2003.js: Removed.
        * fast/url/script-tests/idna2008.js: Removed.
        * fast/url/script-tests/ipv4.js: Removed.
        * fast/url/script-tests/ipv6.js: Removed.
        * fast/url/script-tests/mailto.js: Removed.
        * fast/url/script-tests/path-url.js: Removed.
        * fast/url/script-tests/path.js: Removed.
        * fast/url/script-tests/port.js: Removed.
        * fast/url/script-tests/query.js: Removed.
        * fast/url/script-tests/relative-unix.js: Removed.
        * fast/url/script-tests/relative-win.js: Removed.
        * fast/url/script-tests/relative.js: Removed.
        * fast/url/script-tests/scheme.js: Removed.
        * fast/url/script-tests/segments-from-data-url.js: Removed.
        * fast/url/script-tests/segments.js: Removed.
        * fast/url/script-tests/standard-url.js: Removed.
        * fast/url/script-tests/trivial-segments.js: Removed.
        * fast/url/script-tests/trivial.js: Removed.
        * fast/url/segments-from-data-url.html:
        * fast/url/segments.html:
        * fast/url/standard-url.html:
        * fast/url/trivial-segments.html:
        * fast/url/trivial.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEach local storage database should know its origin
andersca@apple.com [Tue, 7 May 2013 17:45:02 +0000 (17:45 +0000)]
Each local storage database should know its origin
https://bugs.webkit.org/show_bug.cgi?id=115737

Reviewed by Andreas Kling.

Store the security origin in a member variable. It'll be used to communicate database state changes to the tracker.

* UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::create):
(WebKit::LocalStorageDatabase::LocalStorageDatabase):
* UIProcess/Storage/LocalStorageDatabase.h:
(LocalStorageDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd an 'isReadOnly' member to IDL parse tree structure
rniwa@webkit.org [Tue, 7 May 2013 17:42:17 +0000 (17:42 +0000)]
Add an 'isReadOnly' member to IDL parse tree structure
https://bugs.webkit.org/show_bug.cgi?id=115704

Reviewed by Kentaro Hara.

Source/WebCore:

Add an 'isReadOnly' member to IDL parse tree structure by merging
https://chromium.googlesource.com/chromium/blink/+/d6add80ecd08bcd88a6ae0e1698d929830b3bd8b
and update Objective-C, C++, and GObject binding generators to use isReadOnly.

* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorGObject.pm:
(GetWriteableProperties):
(GenerateProperty):
(GenerateFunctions):
* bindings/scripts/CodeGeneratorJS.pm:
(IsReadonly):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/IDLParser.pm:
(parseAttributeRest):
(parseExceptionField):
(parseAttributeRestOld):

Tools:

Use newly added isReadOnly attribute.

* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
(_generateHeaderFile):
(_generateImplementationFile):
(_staticValuesGetterImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove some unnecessary soft linking in NetworkProcess. (Take 2)
beidson@apple.com [Tue, 7 May 2013 17:10:26 +0000 (17:10 +0000)]
Remove some unnecessary soft linking in NetworkProcess. (Take 2)
<rdar://problem/13821779> and https://bugs.webkit.org/show_bug.cgi?id=115683

Reviewed by Dean Jackson and owned by Andreas Kling.

As a followup to r149651, include the private headers conditionally.
Also, fix a bug introduced with r149651 (bool vs CFBooleanRef).

* NetworkProcess/mac/DiskCacheMonitor.mm:
* NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse OwnPtr instead of deleteAllValues in SMILTimeContainer
darin@apple.com [Tue, 7 May 2013 16:54:52 +0000 (16:54 +0000)]
Use OwnPtr instead of deleteAllValues in SMILTimeContainer
https://bugs.webkit.org/show_bug.cgi?id=115730

Reviewed by Geoffrey Garen.

* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::~SMILTimeContainer): Removed call to deleteAllValues.
(WebCore::SMILTimeContainer::schedule): Use add instead of get/set to put a new
AnimationsVector into the map as needed.
(WebCore::SMILTimeContainer::setElapsed): Added get since values are OwnPtr now.
(WebCore::SMILTimeContainer::updateAnimations): Ditto.

* svg/animation/SMILTimeContainer.h: Changed value type of GroupedAnimationsMap
to OwnPtr instead of raw pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTake advantage of pre-decrement and post-increment opcodes for sh4 base JIT.
commit-queue@webkit.org [Tue, 7 May 2013 16:53:23 +0000 (16:53 +0000)]
Take advantage of pre-decrement and post-increment opcodes for sh4 base JIT.
https://bugs.webkit.org/show_bug.cgi?id=115722

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-07
Reviewed by Oliver Hunt.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load8PostInc):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::load16PostInc):
(JSC::MacroAssemblerSH4::storeDouble):
(JSC::MacroAssemblerSH4::load32WithUnalignedHalfWords):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::movwMemRegIn):
(SH4Assembler):
(JSC::SH4Assembler::movbMemRegIn):
(JSC::SH4Assembler::printInstr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Read-only fields should not get keyboard focus
commit-queue@webkit.org [Tue, 7 May 2013 16:24:19 +0000 (16:24 +0000)]
[BlackBerry] Read-only fields should not get keyboard focus
https://bugs.webkit.org/show_bug.cgi?id=115725

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR332887
Prevent keyboard focus and FCC from displaying when the user taps on a
read-only field. Further, ensure form controls skip over these fields
with the next/previous buttons.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementIsReadOnly):
(DOMSupport):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
(BlackBerry::WebKit::InputHandler::setInputModeEnabled):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::isActiveTextEdit):
(WebKit):
* WebKitSupport/InputHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Expand spellcheck logging
commit-queue@webkit.org [Tue, 7 May 2013 16:18:09 +0000 (16:18 +0000)]
[BlackBerry] Expand spellcheck logging
https://bugs.webkit.org/show_bug.cgi?id=115482

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

Fix some build errors when SpellingLog was turned on and expand on the debug
statements to be more verbose. Set up timers and print the duration of each
iteration as we traverse the text to create a range to send out for checking.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
* WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149674 268f45cc-cd09-0410-ab3c-d52691b4dbfc