WebKit-https.git
13 years agoWebCore:
bdakin@apple.com [Thu, 31 Jul 2008 00:01:52 +0000 (00:01 +0000)]
WebCore:

2008-07-30  Beth Dakin  <bdakin@apple.com>

        Reviewed by Anders Carlsson.

        Fixes <rdar://problem/6041390>

        Adds the ability to have a frame that is "disconnected" from the
        main frame from the perspective of top and parent in
        Javascript.

        * WebCore.base.exp:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::parent):
        (WebCore::DOMWindow::top):
        * page/Frame.cpp:
        (WebCore::Frame::isDisconnectedFrame):
        (WebCore::Frame::setIsDisconnectedFrame):
        (WebCore::FramePrivate::FramePrivate):
        * page/Frame.h:
        * page/FramePrivate.h:
        * page/FrameTree.cpp:
        (WebCore::FrameTree::parent):
        (WebCore::FrameTree::top):
        * page/FrameTree.h:

WebKit/mac:

2008-07-30  Beth Dakin  <bdakin@apple.com>

        Reviewed by Anders Carlsson.

        Fixes <rdar://problem/6041390>

        Adds the ability to have a frame that is "disconnected" from the
        main frame from the perspective of top and parent in
        Javascript.

        * WebView/WebFrame.mm:
        (-[WebFrame _setIsDisconnectedFrame]):
        * WebView/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
eric@webkit.org [Wed, 30 Jul 2008 23:14:37 +0000 (23:14 +0000)]
    Reviewed by Oliver.

        MSVC warns when structs are called classes or vice versa.
        Make all the source refer to JSGlobalData as a class.

        * kjs/CommonIdentifiers.h:
        * kjs/JSGlobalData.h:
        * kjs/Parser.h:
        * kjs/lexer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Justin.
eric@webkit.org [Wed, 30 Jul 2008 23:13:57 +0000 (23:13 +0000)]
    Reviewed by Justin.

        Crash Safari when dragging images into Google presentations
        https://bugs.webkit.org/show_bug.cgi?id=20161

        Test: manual-tests/remove-on-drop-crash.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * manual-tests/remove-on-drop-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-30 Jessica Kahn <jess@apple.com>
jess@apple.com [Wed, 30 Jul 2008 22:59:16 +0000 (22:59 +0000)]
2008-07-30  Jessica Kahn  <jess@apple.com>

        Reviewed by Adam Roben.

        Slightly stricter checking for previous change, suggested by Adam.

        * Scripts/extract-localizable-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Jul 2008 22:29:43 +0000 (22:29 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Add COMPropertyBag, a simple template class that implements the IPropertyBag interface. All
        property bag values must be of the same type.

        The COMVariantSetter helpers are now in COMVariantSetter.h

        * COMEnumVariant.h:
        * COMPropertyBag.h: Added.
        * COMVariantSetter.h: Added.
        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-30 Jessica Kahn <jess@apple.com>
jess@apple.com [Wed, 30 Jul 2008 22:22:04 +0000 (22:22 +0000)]
2008-07-30  Jessica Kahn  <jess@apple.com>

        Reviewed by Darin Adler.

        Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.

        * Scripts/extract-localizable-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix for Cairo < 1.6
christian@webkit.org [Wed, 30 Jul 2008 21:12:12 +0000 (21:12 +0000)]
Build fix for Cairo < 1.6

* platform/graphics/cairo/PathCairo.cpp:
  (WebCore::Path::boundingRect): use cairo_stroke_extends for < 1.6

Reviewed by Mark.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-30 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Wed, 30 Jul 2008 20:34:39 +0000 (20:34 +0000)]
2008-07-30  Alice Liu  <alice.liu@apple.com>

        Reviewed by Adam Roben.

        Adding logging of COM class names and counts to facilitate
        investigating memory issues.

        * Interfaces/IWebKitStatistics.idl:
        * WebKitDLL.cpp:
        * WebKitDLL.h:
        * WebKitStatistics.cpp:
        (WebKitStatistics::comClassNameCounts):
        * WebKitStatistics.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-29 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 30 Jul 2008 20:17:53 +0000 (20:17 +0000)]
2008-07-29  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        <rdar://problem/6110314> Crash in profiler dereferencing null frame or
        page (20214)
        - Null check.

        * page/Console.cpp:
        (WebCore::Console::finishedProfiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen.
ap@webkit.org [Wed, 30 Jul 2008 20:16:06 +0000 (20:16 +0000)]
    Reviewed by Geoff Garen.

        Add consistency checks to UString to document and enforce its design.

        * kjs/ustring.cpp:
        (KJS::UString::Rep::create):
        (KJS::UString::Rep::destroy):
        (KJS::UString::Rep::checkConsistency):
        (KJS::UString::expandCapacity):
        (KJS::UString::expandPreCapacity):
        (KJS::UString::UString):
        (KJS::UString::spliceSubstringsWithSeparators):
        (KJS::UString::append):
        * kjs/ustring.h:
        (KJS::UString::Rep::checkConsistency):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-30 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 30 Jul 2008 20:02:32 +0000 (20:02 +0000)]
2008-07-30  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=18070

        Full page zoom needs to work properly with JS mouse events.  Make sure to adjust the coordinates of the
        JS mouse event to account for zoom.

        Reviewed by olliej

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Wed, 30 Jul 2008 19:00:28 +0000 (19:00 +0000)]
WebCore:

2008-07-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Update Cross-site XMLHttpRequests using Access control to
        the latest spec. (Editor's Draft 8 July 2008)

        - This leaves us at about the same place as we previously were
          still needing preflight caching and better redirect support.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * xml/AccessControlList.cpp: Removed.
        * xml/AccessControlList.h: Removed.
        * xml/AccessItem.cpp: Removed.
        * xml/AccessItem.h: Removed.
        * xml/AccessItemRule.cpp: Removed.
        * xml/AccessItemRule.h: Removed.
        * xml/XMLHttpRequest.cpp:
        (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        (WebCore::XMLHttpRequest::isSimpleCrossSiteAccessRequest):
        (WebCore::XMLHttpRequest::makeCrossSiteAccessRequest):
        (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
        (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
        (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
        (WebCore::XMLHttpRequest::abort):
        (WebCore::XMLHttpRequest::clearRequest):
        (WebCore::XMLHttpRequest::didFinishLoading):
        (WebCore::XMLHttpRequest::didFinishLoadingPreflight):
        (WebCore::XMLHttpRequest::accessControlCheck):
        (WebCore::XMLHttpRequest::didReceiveResponse):
        (WebCore::parseAccessControlAllowList):
        (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
        * xml/XMLHttpRequest.h:

LayoutTests:

2008-07-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Update Cross-site XMLHttpRequests using Access control to
        the latest spec. (Editor's Draft 8 July 2008)

        - Update syntax in tests a remove tests for removed features.

        * http/tests/xmlhttprequest/access-control-basic-allow-async.html:
        * http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers-expected.txt: Removed.
        * http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers.html: Removed.
        * http/tests/xmlhttprequest/access-control-basic-exclude.html: Removed.
        * http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-async-expected.txt.
        * http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-async.html.
        * http/tests/xmlhttprequest/access-control-basic-non-simple-allow-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-expected.txt.
        * http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow.html.
        * http/tests/xmlhttprequest/access-control-basic-not-get-allow-async-expected.txt: Removed.
        * http/tests/xmlhttprequest/access-control-basic-not-get-allow-async.html: Removed.
        * http/tests/xmlhttprequest/access-control-basic-not-get-allow-expected.txt: Removed.
        * http/tests/xmlhttprequest/access-control-basic-not-get-allow.html: Removed.
        * http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-allow-print-headers.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-allow.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-exclude.cgi: Removed.
        * http/tests/xmlhttprequest/resources/access-control-basic-get-fail-non-simple.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-non-get-allow.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-whitelist-response-headers.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[GTK] Auto generate webkitmarshal.list
christian@webkit.org [Wed, 30 Jul 2008 18:17:24 +0000 (18:17 +0000)]
[GTK] Auto generate webkitmarshal.list

Auto generate webkitmarshal.list from source files to reduce the
number of conflicts when merging git branches or when applying
patches.
Also rename webkit-marshal.* to webkitmarshal.* for consistency.

Reviewed by Holger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-30 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 30 Jul 2008 17:38:35 +0000 (17:38 +0000)]
2008-07-30  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Fixes for Windows and non-AllInOne file build with SamplingTool, plus review fixes.

        * GNUmakefile.am:              Adding SamplingTool.cpp to build.
        * JavaScriptCore.exp:          Export hooks to init & control SamplingTool.
        * JavaScriptCore.pri:          Adding SamplingTool.cpp to build.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Adding SamplingTool.cpp to build.
        * JavaScriptCore.xcodeproj/project.pbxproj: Adding SamplingTool.cpp to build.
        * JavaScriptCoreSources.bkl:   Adding SamplingTool.cpp to build.
        * VM/Machine.cpp:              MACHINE_SAMPLING_callingNativeFunction renamed MACHINE_SAMPLING_callingHostFunction
        * VM/Machine.h:
        * VM/Opcode.cpp:               SamplingTool moved to SamplingTool.cpp/.h, opcodeNames generated from FOR_EACH_OPCODE_ID.
        * VM/Opcode.h:
        * VM/SamplingTool.cpp:         Added .cpp/.h for SamplingTool.
        * VM/SamplingTool.h:
        * kjs/Shell.cpp:               Switched SAMPLING_TOOL_ENABLED to ENABLE_SAMPLING_TOOL.
        * wtf/Platform.h:              Added ENABLE_SAMPLING_TOOL config option.
        * kjs/nodes.cpp:               Header include to fix non-AllInOne builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Jul 2008 17:09:17 +0000 (17:09 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Copy icu38* files instead of icu36* files.

        * DumpRenderTree/win/DumpRenderTree.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-30 Ariya Hidayat <ariya.hidayat@trolltech.com>
ap@webkit.org [Wed, 30 Jul 2008 16:58:21 +0000 (16:58 +0000)]
2008-07-30  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Alexey Proskuryakov.

        Fix compilation without multi-threading support.

        * kjs/collector.cpp:
        (KJS::Heap::Heap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Jul 2008 16:37:27 +0000 (16:37 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        Add WebKitAvailability.h forwarding header.

        * ForwardingHeaders/JavaScriptCore/WebKitAvailability.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Jul 2008 16:24:39 +0000 (16:24 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        Fix the else.

        * API/WebKitAvailability.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Jul 2008 16:22:39 +0000 (16:22 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        * API/WebKitAvailability.h:
        Fix Windows (and other non-Mac builds).

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        Add WebKitAvailability.h to the project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Jul 2008 16:17:50 +0000 (16:17 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        One step closer towards fixing the Windows build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
        Make sure to copy WebKitAvailability.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTypo in comment for bracer ending block
christian@webkit.org [Wed, 30 Jul 2008 15:24:56 +0000 (15:24 +0000)]
Typo in comment for bracer ending block

https://bugs.webkit.org/show_bug.cgi?id=20205

* webkit/webkitprivate.cpp: Typo fix in comment for the brace
         that ends the WebKit namespace; WebCore -> WebKit

Reviewed by Sam.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-29 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 30 Jul 2008 14:42:03 +0000 (14:42 +0000)]
2008-07-29  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Bug 20209: Atomize constant strings
        <https://bugs.webkit.org/show_bug.cgi?id=20209>

        Prevents significant performance degradation seen when a script contains multiple
        identical strings that are used as keys to identify properties on objects.

        No performance change on SunSpider.

        * kjs/nodes.cpp: Atomize constant strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/6111648> JavaScript exceptions fail if the scope chain includes the...
oliver@apple.com [Wed, 30 Jul 2008 08:00:19 +0000 (08:00 +0000)]
<rdar://problem/6111648> JavaScript exceptions fail if the scope chain includes the global object

Reviewed by Alexey Proskuryakov.

In an attempt to remove the branch I just added to KJS::depth I
used the existence of a Variable Object at a point in the scope
chain as an indicator of function or global scope activation.
However this assumption results in incorrect behaviour if the
global object is injected into the scope chain with 'with'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen.
ap@webkit.org [Wed, 30 Jul 2008 07:09:40 +0000 (07:09 +0000)]
    Reviewed by Geoff Garen.

        Don't call JSGarbageCollect() on a released context.

        * API/testapi.c: (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-29 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Wed, 30 Jul 2008 06:14:26 +0000 (06:14 +0000)]
2008-07-29  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/6060647> Adopt QTMovieOpenForPlaybackAttribute flag

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen.
ap@webkit.org [Wed, 30 Jul 2008 06:05:11 +0000 (06:05 +0000)]
    Reviewed by Geoff Garen.

        Implement JSContextGroup APIs to make concurrent execution possible for
        JavaScriptCore clients.

        This changes the behavior of JSGlobalContextCreate(), so that it now uses a private context
        group for each context, making JSlock implicit locking unnecessary.

        * API/JSContextRef.h:
        * API/JSContextRef.cpp:
        (JSContextGroupCreate):
        (JSContextGroupRetain):
        (JSContextGroupRelease):
        (JSGlobalContextCreate):
        (JSGlobalContextCreateInGroup):
        (JSGlobalContextRelease):
        (JSContextGetGroup):
        Added new methods. JSGlobalContextCreate() calls JSGlobalContextCreateInGroup() now.

        * API/APICast.h: (toJS): (toRef): Added converters for JSContextGroupRef.
        * API/JSBase.cpp: (JSGarbageCollect): JSGarbageCollect(0) is now a no-op, and the passed in
        context is actually used.

        * API/JSBase.h: Aded a typedef for JSContextGroupRef. Updated documentation for
        JSGarbageCollect().

        * JavaScriptCore.exp: Removed JSGlobalData::sharedInstance().

        * kjs/JSGlobalData.cpp:
        * kjs/JSGlobalData.h:
        Removed support for JSGlobalData shared instance. JSGlobalData::isSharedInstance member
        variable still remains, to be deleted in a followup patch.

        * kjs/JSLock.cpp: (KJS::JSLock::JSLock): Disabled JSLock, to be deleted in a follow-up patch.

        * kjs/collector.cpp:
        (KJS::Heap::markOtherThreadConservatively): Removed an assertion that referenced
        JSGlobalData::sharedInstance.

        * kjs/collector.h: Made Heap destructor public, so that JSContextRelease can use it.

JavaScriptGlue:
        * JSRun.cpp:
        (JSRun::JSRun):
        * JSUtils.cpp:
        (getThreadGlobalExecState):
        Changed JavaScriptGlue to use a JSGlobalData of its own, now that there is no shared
        instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-29 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Wed, 30 Jul 2008 06:02:39 +0000 (06:02 +0000)]
2008-07-29  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/6031021> Make standalone video render more like the quicktime plugin to improve performance

        For standalone video, use QTMovieView to draw.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovieView): Moved nil checks to setUpVideoRendering.
         Associate the QTMovieView with the WebCoreMovieObserver.
         If we're in a media document, allow QTMovieView to render in its default mode; otherwise tell it to draw synchronously.
        (WebCore::MediaPlayerPrivate::detachQTMovieView): Set the WebCoreMovieObserver's view to nil.
        (WebCore::MediaPlayerPrivate::createQTVideoRenderer): Nil check is now in setUpVideoRendering, which is the only caller of this.
        (WebCore::MediaPlayerPrivate::setUpVideoRendering): Added nil checks.  Call createQTMovieView for media documents.
        (WebCore::MediaPlayerPrivate::tearDownVideoRendering): Call detachQTMovieView if a QTMovieView exists.
        (WebCore::MediaPlayerPrivate::setRect): Call setFrame on the QTMovieView if necessary.
        (-[WebCoreMovieObserver menuForEventDelegate:]): Added. Returns the frame view's menu.
        (-[WebCoreMovieObserver setView:]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen.
ap@webkit.org [Wed, 30 Jul 2008 05:55:57 +0000 (05:55 +0000)]
    Reviewed by Geoff Garen.

        Fix a leak of ThreadRegistrar objects.

        As the heap is usually deleted when registered threads still exist, ThreadSpecific doesn't
        have a chance to clean up per-thread object. Switched to native pthread calls, storing a
        plain pointer that doesn't require cleanup.

        * kjs/collector.cpp:
        (KJS::PlatformThread::PlatformThread):
        (KJS::Heap::Thread::Thread):
        (KJS::Heap::Heap):
        (KJS::Heap::~Heap):
        (KJS::Heap::registerThread):
        (KJS::Heap::unregisterThread):
        * kjs/collector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam Weinig.
ap@webkit.org [Wed, 30 Jul 2008 05:52:37 +0000 (05:52 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=20169
        Memory allocated with fastMalloc is freed with delete

        * VM/JSPropertyNameIterator.cpp:
        (KJS::JSPropertyNameIterator::invalidate): Free the array properly.
        (KJS::JSPropertyNameIterator::~JSPropertyNameIterator): Delete the array by calling
        invalidate().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-29 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 30 Jul 2008 05:42:04 +0000 (05:42 +0000)]
2008-07-29  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/6073372> Move built-in controls below <video> element for standalone media documents

        * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added -webkit-full-page-media pseudo class.
        * css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoFullPageMedia.
        * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added case to
        apply PseudoFullPageMedia for elements in a full page media document.

        * css/html4.css: Added rule to shift control panel down for video in standalone media documents.

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::lowestPosition): Added implementation that takes the controls into account.
        This makes sure that scrollbars on the page will account for controls not directly contained in the RenderMedia.
        (WebCore::RenderMedia::rightmostPosition): ditto.
        (WebCore::RenderMedia::leftmostPosition): ditto.
        * rendering/RenderMedia.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Sam Weinig.
kevino@webkit.org [Wed, 30 Jul 2008 05:34:28 +0000 (05:34 +0000)]
Reviewed by Sam Weinig.

Add tooltip support to the wx port.

https://bugs.webkit.org/show_bug.cgi?id=20173

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-29 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Wed, 30 Jul 2008 05:00:32 +0000 (05:00 +0000)]
2008-07-29  Alice Liu  <alice.liu@apple.com>

        Reviewed by Geoff Garen.

        Fix WebDocumentLoader leak on Windows.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::createDocumentLoader):
        * WebDocumentLoader.cpp:
        (WebDocumentLoader::create):
        * WebDocumentLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Wed, 30 Jul 2008 02:39:48 +0000 (02:39 +0000)]
WebCore:

2008-07-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        <rdar://problem/6084585> Investigate upload progress events.

        - Add progress notifications for data being sent via a ResourceHandle.
        - Add XMLHttpRequestUpload support.

        Upload notifications only work on the Mac right now as the CFNetwork API
        on windows does not expose enough information.

        Tests: http/tests/xmlhttprequest/upload-onload-event.html
               http/tests/xmlhttprequest/upload-onloadstart-event.html
               http/tests/xmlhttprequest/upload-onprogress-event.html
               http/tests/xmlhttprequest/upload-progress-events.html

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSEventTargetBase.cpp:
        (WebCore::toJS):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::mark):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp: Added.
        (WebCore::JSXMLHttpRequestUpload::mark):
        (WebCore::JSXMLHttpRequestUpload::onabort):
        (WebCore::JSXMLHttpRequestUpload::setOnabort):
        (WebCore::JSXMLHttpRequestUpload::onerror):
        (WebCore::JSXMLHttpRequestUpload::setOnerror):
        (WebCore::JSXMLHttpRequestUpload::onload):
        (WebCore::JSXMLHttpRequestUpload::setOnload):
        (WebCore::JSXMLHttpRequestUpload::onloadstart):
        (WebCore::JSXMLHttpRequestUpload::setOnloadstart):
        (WebCore::JSXMLHttpRequestUpload::onprogress):
        (WebCore::JSXMLHttpRequestUpload::setOnprogress):
        (WebCore::JSXMLHttpRequestUpload::addEventListener):
        (WebCore::JSXMLHttpRequestUpload::removeEventListener):
        (WebCore::JSXMLHttpRequestUpload::dispatchEvent):
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toXMLHttpRequestUpload):
        * dom/EventTarget.h:
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::didSendData):
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::didSendData):
        * loader/SubresourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        (WebCore::SubresourceLoaderClient::didSendData):
        * page/DOMWindow.idl:
        * platform/network/FormData.cpp:
        (WebCore::FormData::FormData):
        * platform/network/FormData.h:
        (WebCore::FormData::alwaysStream):
        (WebCore::FormData::setAlwaysStream):
        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::didSendData):
        * platform/network/mac/FormDataStreamMac.h:
        * platform/network/mac/FormDataStreamMac.mm:
        (WebCore::getStreamFormDataMap):
        (WebCore::getStreamResourceHandleMap):
        (WebCore::associateStreamWithResourceHandle):
        (WebCore::disassociateStreamWithResourceHandle):
        (WebCore::DidSendDataCallbackData::DidSendDataCallbackData):
        (WebCore::performDidSendDataCallback):
        (WebCore::formCreate):
        (WebCore::formFinalize):
        (WebCore::formRead):
        (WebCore::setHTTPBody):
        (WebCore::httpBodyFromStream):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::cancel):
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
        (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
        (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        (WebCore::XMLHttpRequest::~XMLHttpRequest):
        (WebCore::XMLHttpRequest::upload):
        (WebCore::XMLHttpRequest::open):
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::createRequest):
        (WebCore::XMLHttpRequest::abort):
        (WebCore::XMLHttpRequest::networkError):
        (WebCore::XMLHttpRequest::abortError):
        (WebCore::XMLHttpRequest::didSendData):
        * xml/XMLHttpRequest.h:
        (WebCore::XMLHttpRequest::optionalUpload):
        * xml/XMLHttpRequest.idl:
        * xml/XMLHttpRequestUpload.cpp: Added.
        (WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
        (WebCore::XMLHttpRequestUpload::addEventListener):
        (WebCore::XMLHttpRequestUpload::removeEventListener):
        (WebCore::XMLHttpRequestUpload::dispatchEvent):
        (WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent):
        (WebCore::XMLHttpRequestUpload::dispatchAbortEvent):
        (WebCore::XMLHttpRequestUpload::dispatchErrorEvent):
        (WebCore::XMLHttpRequestUpload::dispatchLoadEvent):
        (WebCore::XMLHttpRequestUpload::dispatchLoadStartEvent):
        (WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
        * xml/XMLHttpRequestUpload.h: Added.
        (WebCore::XMLHttpRequestUpload::create):
        (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload):
        (WebCore::XMLHttpRequestUpload::associatedXMLHttpRequest):
        (WebCore::XMLHttpRequestUpload::disconnectXMLHttpRequest):
        (WebCore::XMLHttpRequestUpload::setOnAbortListener):
        (WebCore::XMLHttpRequestUpload::onAbortListener):
        (WebCore::XMLHttpRequestUpload::setOnErrorListener):
        (WebCore::XMLHttpRequestUpload::onErrorListener):
        (WebCore::XMLHttpRequestUpload::setOnLoadListener):
        (WebCore::XMLHttpRequestUpload::onLoadListener):
        (WebCore::XMLHttpRequestUpload::setOnLoadStartListener):
        (WebCore::XMLHttpRequestUpload::onLoadStartListener):
        (WebCore::XMLHttpRequestUpload::setOnProgressListener):
        (WebCore::XMLHttpRequestUpload::onProgressListener):
        (WebCore::XMLHttpRequestUpload::eventListeners):
        (WebCore::XMLHttpRequestUpload::refEventTarget):
        (WebCore::XMLHttpRequestUpload::derefEventTarget):
        * xml/XMLHttpRequestUpload.idl: Added.

LayoutTests:

2008-07-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        <rdar://problem/6084585> Investigate upload progress events

        * fast/dom/Window/window-properties-expected.txt:
        * http/tests/xmlhttprequest/upload-onload-event-expected.txt: Added.
        * http/tests/xmlhttprequest/upload-onload-event.html: Added.
        * http/tests/xmlhttprequest/upload-onloadstart-event-expected.txt: Added.
        * http/tests/xmlhttprequest/upload-onloadstart-event.html: Added.
        * http/tests/xmlhttprequest/upload-onprogress-event-expected.txt: Added.
        * http/tests/xmlhttprequest/upload-onprogress-event.html: Added.
        * http/tests/xmlhttprequest/upload-progress-events-expected.txt: Added.
        * http/tests/xmlhttprequest/upload-progress-events.html: Added.
        * platform/win/Skipped: Skip new tests on windows where the feature is not
        implemented yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-29 Maxime Britto <britto@apple.com>
britto@apple.com [Tue, 29 Jul 2008 23:33:49 +0000 (23:33 +0000)]
2008-07-29  Maxime Britto  <britto@apple.com>

        Reviewed by Darin.

        <rdar://problem/6095023> "When pan-scrolling, mouse click on hyperlink stop the pan-Scroll but follow the link after that."
        With this patch we now stop the pan scroll and swallow the event to prevent any following action.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent): If we were in pan scrolling mode we no longer just stop the pan scroll and continue with the function, we now stop and return true to attest that we swallowed the event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-29 Maxime Britto <britto@apple.com>
britto@apple.com [Tue, 29 Jul 2008 22:59:18 +0000 (22:59 +0000)]
2008-07-29  Maxime Britto  <britto@apple.com>

        Reviewed by adele.

        Test: fast/events/autoscroll-in-textfield.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::canBeProgramaticallyScrolled): reverted a bad change introduced in r35244
        nb:the test case introduced in r35244 is still working.

2008-07-29  Maxime Britto  <britto@apple.com>

        Reviewed by adele.
        This test verifies that the autoscroll works within textfields.

        * fast/events/autoscroll-in-textfield-expected.txt: Added.
        * fast/events/autoscroll-in-textfield.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAttempt to fix the Qt build.
mrowe@apple.com [Tue, 29 Jul 2008 22:47:42 +0000 (22:47 +0000)]
Attempt to fix the Qt build.

* wtf/ThreadingQt.cpp: Add the extra argument to createThread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Mark Rowe.
mitz@apple.com [Tue, 29 Jul 2008 22:38:53 +0000 (22:38 +0000)]
    Rubber-stamped by Mark Rowe.

        - update results for console.group and console.groupEnd

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTweak to the build fix to keep Dan happy.
mrowe@apple.com [Tue, 29 Jul 2008 20:58:51 +0000 (20:58 +0000)]
Tweak to the build fix to keep Dan happy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele@apple.com [Tue, 29 Jul 2008 20:28:19 +0000 (20:28 +0000)]
WebCore:

2008-07-29  Adele Peterson  <adele@apple.com>

        Reviewed by Sammy Weinig.

        Fix for <rdar://problem/6103024>
        When a QT movie is loaded directly in the browser, I can't pause it by single-clicking on the video

        Test: media/video-click-dlbclick-standalone.html

        * loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler): For standalone media documents,
        match the default Quicktime plugin behavior to allow clicking and double-clicking to pause and play the media.
        * loader/MediaDocument.h: Added defaultEventHandler.

        * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::defaultEventHandler): Return early if the event has been handled.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Correct what was probably a typo.  Instead of "event->defaultHandled()",
         it is supposed to be "event->setDefaultHandled()".
        (WebCore::MediaControlPlayButtonElement::defaultEventHandler): ditto.
        (WebCore::MediaControlSeekButtonElement::defaultEventHandler): ditto.
        (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): ditto.

LayoutTests:

2008-07-29  Adele Peterson  <adele@apple.com>

        Reviewed by Sammy Weinig.

        Test for <rdar://problem/6103024>
        When a QT movie is loaded directly in the browser, I can't pause it by single-clicking on the video

        * media/video-click-dlbclick-standalone-expected.txt: Added.
        * media/video-click-dlbclick-standalone.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
mrowe@apple.com [Tue, 29 Jul 2008 20:13:40 +0000 (20:13 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 29 Jul 2008 18:55:14 +0000 (18:55 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com

        Test: fast/overflow/float-in-relpositioned.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::lowestPosition): Add this block's relative offset
        to floats' and positioned objects' lowest position.
        (WebCore::RenderBlock::rightmostPosition): Ditto.
        (WebCore::RenderBlock::leftmostPosition): Ditto.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::lowestPosition): Removed redundant test.
        (WebCore::RenderBox::rightmostPosition): Ditto.
        (WebCore::RenderBox::leftmostPosition): Ditto.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test, updated test and results for <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com

        * fast/overflow/float-in-relpositioned.html: Added.
        * fast/repaint/containing-block-position-change.html: Changed to avoid
        a full repaint due to a scroll bar appearing.
        * platform/mac/fast/clip/015-expected.txt:
        * platform/mac/fast/overflow/float-in-relpositioned-expected.checksum: Added.
        * platform/mac/fast/overflow/float-in-relpositioned-expected.png: Added.
        * platform/mac/fast/overflow/float-in-relpositioned-expected.txt: Added.
        * platform/mac/fast/repaint/clipped-relative-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 29 Jul 2008 18:51:34 +0000 (18:51 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6048566> Repaint original element's position, not its offset position

        Test: fast/repaint/layout-state-relative.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absolutePosition): Changed the LayoutState-enabled
        code path to account for the object's relative offset.
        (WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.

LayoutTests:

        Reviewed by Dave Hyatt.

        - repaint test for <rdar://problem/6048566> Repaint original element's position, not its offset position

        * fast/repaint/layout-state-relative.html: Added.
        * platform/mac/fast/repaint/layout-state-relative-expected.checksum: Added.
        * platform/mac/fast/repaint/layout-state-relative-expected.png: Added.
        * platform/mac/fast/repaint/layout-state-relative-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change Vector::find to return an index instead of an iterator
aroben@apple.com [Tue, 29 Jul 2008 18:51:26 +0000 (18:51 +0000)]
    Change Vector::find to return an index instead of an iterator

        Indices are more natural than iterators when working with Vector.

        Reviewed by John Sullivan.

        * wtf/Vector.h:
        (WTF::Vector::find): Changed to iterate the Vector manually and return
        the index of the found item, rather than an iterator. When the item
        could not be found, we return WTF::notFound.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@35424 268f45cc-cd09-0410...
hyatt@apple.com [Tue, 29 Jul 2008 18:28:13 +0000 (18:28 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 29 Jul 2008 18:27:22 +0000 (18:27 +0000)]
2008-07-29  David Hyatt  <hyatt@apple.com>

        Add a layout test for using multiple variable declaration blocks in a single style rule.

        * fast/css/variables/alternate-syntax/multiple-blocks-test.html: Added.
        * fast/css/variables/multiple-blocks-test.html: Added.
        * platform/mac/fast/css/variables/multiple-blocks-test-expected.checksum: Added.
        * platform/mac/fast/css/variables/multiple-blocks-test-expected.png: Added.
        * platform/mac/fast/css/variables/multiple-blocks-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Export detachThread
aroben@apple.com [Tue, 29 Jul 2008 18:10:07 +0000 (18:10 +0000)]
    Export detachThread

        Reviewed by Geoff Garen.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixed Bug 19158: Inspector should support console.group/console.groupEnd
timothy@apple.com [Tue, 29 Jul 2008 18:04:29 +0000 (18:04 +0000)]
    Fixed Bug 19158: Inspector should support console.group/console.groupEnd

        <https://bugs.webkit.org/show_bug.cgi?id=19158>

        Reviewed by Tim Hatcher and Adam Roben.

        * bindings/js/JSConsoleCustom.cpp:
        (WebCore::JSConsole::group): Added.
        * page/Console.cpp:
        (WebCore::Console::group): Added.
        (WebCore::Console::groupEnd): Added.
        * page/Console.h:
        (WebCore::):
        * page/Console.idl: Added group/groupEnd.
        * page/InspectorController.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::InspectorController::InspectorController): Added m_groupLevel.
        (WebCore::InspectorController::addMessageToConsole): Added groupLevel argument.
        (WebCore::InspectorController::startGroup): Increments m_groupLevel by one and calls js function if needed.
        (WebCore::InspectorController::endGroup): Decrements m_groupLevel by one and calls js function if needed.
        (WebCore::InspectorController::addScriptConsoleMessage): Added groupLevel argument.
        (WebCore::InspectorController::didCommitLoad): Resets m_groupLevel.
        * page/InspectorController.h:
        * page/inspector/Console.js:
        (WebInspector.Console): Added groupLevel and currentGroup topGroup.
        (WebInspector.Console.addMessage): Calls addMessage method in the currentGroup.
        (WebInspector.Console.startGroup): Added.
        (WebInspector.Console.endGroup): Added.
        (WebInspector.Console.clearMessages): Resets groupLevel and currentGroup.
        (WebInspector.ConsoleMessage): Added groupLevel property.
        (WebInspector.ConsoleMessage.MessageLevel.GroupTitle): Added.
        (WebInspector.ConsoleGroup): Added.
        (WebInspector.ConsoleGroup.addMessage): Adds console message to group.
        (WebInspector.ConsoleGroup._titleClicked): Adds "collapsed" style class.
        * page/inspector/inspector.css:
        * page/inspector/inspector.js:
        (WebInspector.startGroupInConsole): Calls console.startGroup
        (WebInspector.endGroupInConsole): Calls console.endGroup

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix
aroben@apple.com [Tue, 29 Jul 2008 16:23:08 +0000 (16:23 +0000)]
    Windows build fix

        * wtf/ThreadingWin.cpp:
        (WTF::setThreadName): Move a misplaced assertion to here...
        (WTF::createThread): ...from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd support for setting thread names on Windows
aroben@apple.com [Tue, 29 Jul 2008 16:11:00 +0000 (16:11 +0000)]
Add support for setting thread names on Windows

JavaScriptCore:

        Add support for setting thread names on Windows

        These thread names make it much easier to identify particular threads
        in Visual Studio's Threads panel.

        WTF::createThread now takes a const char* representing the thread's
        name. On Windows, we throw a special exception to set this string as
        the thread's name. Other platforms do nothing with this name for now.

        Reviewed by Anders Carlsson.

        * JavaScriptCore.exp: Export the new version of createThread that
        takes 3 arguments (the old one continues to be exported for backward
        compatibility).
        * wtf/Threading.h: Add a threadName argument to createThread.

        * wtf/ThreadingGtk.cpp:
        (WTF::createThread):
        * wtf/ThreadingNone.cpp:
        (WTF::createThread):
        Updated for function signature change.

        * wtf/ThreadingPthreads.cpp:
        (WTF::createThread): Updated for function signature change. We keep
        around the old 2-argument version of createThread for backward
        compatibility.

        * wtf/ThreadingWin.cpp:
        (WTF::setThreadName): Added. This function's implementation came from
        MSDN.
        (WTF::initializeThreading): Set the name of the main thread.
        (WTF::createThread): Call setThreadName. We keep around the old
        2-argument version of createThread for backward compatibility.

WebCore:

        Add names for WebCore's threads

        Reviewed by Anders Carlsson.

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open):
        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::start):
        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::start):
        Pass in names to createThread.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::runLoaderThread):
        (WebCore::ResourceHandle::loaderRunLoop):
        Changed to use WTF::createThread.

WebKit/win:

        Export the new version of createThread

        Reviewed by Anders Carlsson.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:
        Also moved the old version of createThread into the deprecated
        section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
ap@webkit.org [Tue, 29 Jul 2008 08:16:17 +0000 (08:16 +0000)]
    Reviewed by Oliver Hunt.

        Store UString::Rep::isStatic bit in identifierTable pointer instead of reportedCost for
        slightly nicer code and a 0.5% SunSpider improvement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 29 Jul 2008 00:37:43 +0000 (00:37 +0000)]
2008-07-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Based on a patch from Dimcho Balev.

        Windows part of

        https://bugs.webkit.org/show_bug.cgi?id=18676
        <rdar://problem/6106578>
        Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::wantsAllStreams):
        * plugins/PluginStream.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson@apple.com [Mon, 28 Jul 2008 23:34:32 +0000 (23:34 +0000)]
WebCore:

2008-07-28  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Test: security/autocomplete-cleared-on-back.html

        <rdar://problem/6093281> - autocomplete="off" should work when going back

        Taken care of in two ways:
        1 - Listening for the page cache notification to clear the form, in cases where the page
            is being restored from the page cache
        2 - Not saving such form elements when doing the normal "save state" to a history item,
            for cases with no page cache

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::~HTMLFormElement):
        (WebCore::HTMLFormElement::parseMappedAttribute):
        (WebCore::HTMLFormElement::didRestoreFromCache):
        (WebCore::HTMLFormElement::willMoveToNewOwnerDocument):
        (WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
        * html/HTMLFormElement.h:

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::~HTMLInputElement):
        (WebCore::HTMLInputElement::setInputType):
        (WebCore::HTMLInputElement::saveState):
        (WebCore::HTMLInputElement::parseMappedAttribute):
        (WebCore::HTMLInputElement::needsCacheCallback):
        (WebCore::HTMLInputElement::registerForCacheCallbackIfNeeded): Only register if the type or attribute
          indicate we should.
        (WebCore::HTMLInputElement::unregisterForCacheCallbackIfNeeded): Only unregister if both the type
          and attribute are clear of needing registration.
        (WebCore::HTMLInputElement::didRestoreFromCache):
        (WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
        (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
        * html/HTMLInputElement.h:

LayoutTests:

2008-07-28  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        <rdar://problem/6093281> - autocomplete="off" should work when going back

        * security/autocomplete-cleared-on-back-expected.txt: Added.
        * security/autocomplete-cleared-on-back.html: Added.
        * security/resources: Added.
        * security/resources/autocomplete-cleared-on-back2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-28 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 28 Jul 2008 22:50:04 +0000 (22:50 +0000)]
2008-07-28  David Hyatt  <hyatt@apple.com>

        Add support for CSS variable declaration blocks.

        Reviewed by Sam

        Added tests in fast/css/variables.

        * css/CSSGrammar.y:
        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::isMutableStyleDeclaration):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::addVariableDeclarationBlock):
        * css/CSSParser.h:
        * css/CSSProperty.cpp:
        (WebCore::CSSProperty::cssText):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::addMatchedDeclaration):
        (WebCore::CSSStyleSelector::resolveVariablesForDeclaration):
        * css/CSSStyleSelector.h:
        * css/CSSValueList.h:
        (WebCore::CSSValueList::isValueList):
        * css/CSSVariablesDeclaration.cpp:
        (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration):
        (WebCore::CSSVariablesDeclaration::getVariableValue):
        (WebCore::CSSVariablesDeclaration::removeVariable):
        (WebCore::CSSVariablesDeclaration::addParsedVariable):
        (WebCore::CSSVariablesDeclaration::getParsedSimpleVariable):
        (WebCore::CSSVariablesDeclaration::getParsedComplexVariable):
        * css/CSSVariablesDeclaration.h:
        (WebCore::CSSVariablesDeclaration::create):
        * css/StyleBase.cpp:
        (WebCore::StyleBase::cssText):
        * css/StyleBase.h:
        (WebCore::StyleBase::isValueList):
        (WebCore::StyleBase::isMutableStyleDeclaration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago../../../../../../LayoutTests:
andersca@apple.com [Mon, 28 Jul 2008 22:46:14 +0000 (22:46 +0000)]
../../../../../../LayoutTests:

2008-07-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        <rdar://problem/6098335>
        https://bugs.webkit.org/show_bug.cgi?id=20150

        Add tests.

        * http/tests/xmlhttprequest/resources/forbidden.txt: Added.
        * http/tests/xmlhttprequest/resources/redirect.php: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html: Added.

../../../../../../WebCore:

2008-07-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        <rdar://problem/6098335>
        https://bugs.webkit.org/show_bug.cgi?id=20150

        Handle willSendRequest correctly.

        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::willSendRequest):
        Make sure to keep the previous URL around so we know when to call willSendRequest.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::processSyncLoadResults):
        Abort if we don't have access to the response URL.

        (WebCore::XMLHttpRequest::willSendRequest):
        Dispatch a network error if we can't access the new URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren@apple.com [Mon, 28 Jul 2008 20:04:48 +0000 (20:04 +0000)]
JavaScriptCore:

2008-07-28  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Renamed "ConstructTypeNative" => "ConstructTypeHost".

WebCore:

2008-07-28  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Renamed "ConstructTypeNative" => "ConstructTypeHost".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd radar number
andersca@apple.com [Mon, 28 Jul 2008 19:23:11 +0000 (19:23 +0000)]
Add radar number

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago../../../../../../WebCore:
andersca@apple.com [Mon, 28 Jul 2008 19:20:18 +0000 (19:20 +0000)]
../../../../../../WebCore:

2008-07-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Based on a patch by Dimcho Balev.

        https://bugs.webkit.org/show_bug.cgi?id=18676
        Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

        * bridge/npapi.h:
        Add new enum values.

        * loader/NetscapePlugInStreamLoader.cpp:
        (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
        When the plug-in indicates that it wants all streams to be delivered, don't cancel the stream
        if an error occurs.

        * loader/NetscapePlugInStreamLoader.h:
        (WebCore::NetscapePlugInStreamLoaderClient::wantsAllStreams):
        Add new client method.

../../../../../../WebKit/mac:

2008-07-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Based on a patch by Dimcho Balev.

        https://bugs.webkit.org/show_bug.cgi?id=18676
        Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

        * Plugins/WebBaseNetscapePluginStream.h:
        Add NPP_GetValue pointer.

        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream setPlugin:]):
        Initialize NPP_GetValue.

        (-[WebBaseNetscapePluginStream wantsAllStreams]):
        Call NPP_GetValue.

        * Plugins/WebPlugInStreamLoaderDelegate.h:
        * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h:
        * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm:
        (WebNetscapePlugInStreamLoaderClient::wantsAllStreams):
        Implement this and call down to the stream.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 28 Jul 2008 16:59:20 +0000 (16:59 +0000)]
2008-07-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        <rdar://problem/6105529>
        https://bugs.webkit.org/show_bug.cgi?id=19659
        Turning off plugins causes crash

        When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
        end up in a state where they don't have an event handler. Because of this, we need to
        check that the plug-in has been started before calling the event handler.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView sendActivateEvent:]):
        (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
        (-[WebBaseNetscapePluginView setHasFocus:]):
        (-[WebBaseNetscapePluginView mouseDown:]):
        (-[WebBaseNetscapePluginView mouseUp:]):
        (-[WebBaseNetscapePluginView mouseEntered:]):
        (-[WebBaseNetscapePluginView mouseExited:]):
        (-[WebBaseNetscapePluginView handleMouseMoved:]):
        (-[WebBaseNetscapePluginView mouseDragged:]):
        (-[WebBaseNetscapePluginView scrollWheel:]):
        (-[WebBaseNetscapePluginView keyUp:]):
        (-[WebBaseNetscapePluginView keyDown:]):
        (-[WebBaseNetscapePluginView flagsChanged:]):
        (-[WebBaseNetscapePluginView cut:]):
        (-[WebBaseNetscapePluginView copy:]):
        (-[WebBaseNetscapePluginView paste:]):
        (-[WebBaseNetscapePluginView selectAll:]):
        (-[WebBaseNetscapePluginView drawRect:]):
        (-[WebBaseNetscapePluginView inputContext]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-28 Robert Blaut <webkit@blaut.biz>
mrowe@apple.com [Mon, 28 Jul 2008 07:37:47 +0000 (07:37 +0000)]
2008-07-28  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Mark Rowe.

        Fix for bug: Website provides no guidance on debugging
        <https://bugs.webkit.org/show_bug.cgi?id=3643>

        * building/debug.html: added info about Xcode Debugging Guide.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Sun, 27 Jul 2008 22:03:41 +0000 (22:03 +0000)]
WebCore:

2008-07-27  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=20176
        querySelectorAll id optimization no longer working

        Turn the querySelector/querySelectorAll id optimization back on
        for only strict and almost strict mode.  In quirks mode, the optimiztion
        won't work as the id match is not case sensitive.

        Tests: fast/dom/SelectorAPI/caseID-almost-strict.html
               fast/dom/SelectorAPI/caseID-strict.html
               fast/dom/SelectorAPI/caseID.html

        * dom/Node.cpp:
        (WebCore::Node::querySelector):
        (WebCore::Node::querySelectorAll):
        * dom/SelectorNodeList.cpp:
        (WebCore::createSelectorNodeList):
        * dom/SelectorNodeList.h:

LayoutTests:

2008-07-27  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Tests for https://bugs.webkit.org/show_bug.cgi?id=20176
        querySelectorAll id optimization no longer working

        * fast/dom/SelectorAPI/caseID-almost-strict-expected.txt: Added.
        * fast/dom/SelectorAPI/caseID-almost-strict.html: Added.
        * fast/dom/SelectorAPI/caseID-expected.txt: Added.
        * fast/dom/SelectorAPI/caseID-strict-expected.txt: Added.
        * fast/dom/SelectorAPI/caseID-strict.html: Added.
        * fast/dom/SelectorAPI/caseID.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Qt build failure.
ddkilzer@apple.com [Sun, 27 Jul 2008 21:34:48 +0000 (21:34 +0000)]
    Fix Qt build failure.

        * Api/qwebframe.h:
        (QWebFrame::setScrollOffset): Make argument const.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSet svn:mime-type to image/png.
ddkilzer@apple.com [Sun, 27 Jul 2008 21:27:03 +0000 (21:27 +0000)]
Set svn:mime-type to image/png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ddkilzer@apple.com [Sun, 27 Jul 2008 21:08:29 +0000 (21:08 +0000)]
WebCore:

2008-07-21  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=14346
        Modified the css parser:
        - not to fail when closing braces are not found for
          a declaration at the end of the file
        - not to accept "!important fail" as valid
        - to keep accepting @import when it comes after invalid @ rules
        - not to drop the whole @media block when there's an error before the
          closing brace
        + some other minor css parsing revisions.

        CSSGrammar.y tweaked by David Kilzer to fix Tiger builds.

        * css/CSSGrammar.y:

LayoutTests:

2008-07-21  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dave Hyatt.

        Updated layout CSS2.1 test suite tests related to css parsing:
        https://bugs.webkit.org/show_bug.cgi?id=14346

        * platform/mac/css2.1/t040105-import-01-b-expected.checksum:
        * platform/mac/css2.1/t040105-import-01-b-expected.png:
        * platform/mac/css2.1/t040105-import-01-b-expected.txt:
        * platform/mac/css2.1/t0402-syntax-05-f-expected.checksum:
        * platform/mac/css2.1/t0402-syntax-05-f-expected.png:
        * platform/mac/css2.1/t0402-syntax-05-f-expected.txt:
        * platform/mac/css2.1/t0402-syntax-06-f-expected.checksum:
        * platform/mac/css2.1/t0402-syntax-06-f-expected.png:
        * platform/mac/css2.1/t0402-syntax-06-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-27 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 27 Jul 2008 10:43:35 +0000 (10:43 +0000)]
2008-07-27  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Eric Seidel.

        Use --outputDir instead of --output when invoking make_names.pl
        There's no option named "output" in make_names.pl

        * GNUmakefile.am:
        * WebCore.pro:
        * DerivedSources.make: Remove --output. Not necessary here.
        * bindings/scripts/generate-bindings.pl: Rename --outputdir to
          --outputDir for consistency with make_names.pl

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Sun, 27 Jul 2008 06:56:33 +0000 (06:56 +0000)]
2008-07-26  Mark Rowe  <mrowe@apple.com>

        Update some layout test results.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/domListEnumeration-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Sun, 27 Jul 2008 06:08:50 +0000 (06:08 +0000)]
2008-07-26  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Oliver Hunt.

        Update the Squirrelfish bytecode documentation.

        * specs/squirrelfish-bytecode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Dirk Schulze <vbs85@gmx.de>
mrowe@apple.com [Sun, 27 Jul 2008 06:02:19 +0000 (06:02 +0000)]
2008-07-26  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Eric Seidel.

        http://bugs.webkit.org/show_bug.cgi?id=18694
        [CAIRO] Problem with rotation in a given matrix in SVG

        Changed values given to AffineTransform.

        * platform/graphics/cairo/AffineTransformCairo.cpp:
        (WebCore::AffineTransform::AffineTransform):
        (WebCore::AffineTransform::setMatrix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-25 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 27 Jul 2008 06:00:36 +0000 (06:00 +0000)]
2008-07-25  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Mark Rowe.

        Copy the way Gtk detects jpeglib. Hinted by Wouter Bolsterlee.

        [Gtk] Improve detection jpeglib
        https://bugs.webkit.org/show_bug.cgi?id=17865

        * GNUmakefile.am:
        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>
mrowe@apple.com [Sun, 27 Jul 2008 05:59:20 +0000 (05:59 +0000)]
2008-07-26  Marc Ordinas i Llopis  <marc.ordinasillopis@collabora.co.uk>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=20010
        [Qt] Add API access to scrolling

        * Api/qwebframe.cpp: Added access to a frame scroll offset.
        (QWebFrame::scroll):
        (QWebFrame::scrollOffset):
        (QWebFrame::setScrollOffset):
        * Api/qwebframe.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Sam Weinig.
mitz@apple.com [Sun, 27 Jul 2008 05:58:37 +0000 (05:58 +0000)]
    Rubber-stamped by Sam Weinig.

        - update test and expected results for attributes added to
          HTMLFormElement and HTMLSelectElement.

        * fast/dom/domListEnumeration-expected.txt:
        * fast/dom/resources/domListEnumeration.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Robert Blaut <webkit@blaut.biz>
mrowe@apple.com [Sun, 27 Jul 2008 05:53:12 +0000 (05:53 +0000)]
2008-07-26  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Eric Seidel.

        Fix for <https://bugs.webkit.org/show_bug.cgi?id=19712>
        Corrected validation errors in main.css file.

        * css/main.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Jan Michael Alonzo <jmalonzo@webkit.org>
mrowe@apple.com [Sun, 27 Jul 2008 05:52:08 +0000 (05:52 +0000)]
2008-07-26  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Mark Rowe.

        Call curl_global_cleanup() to release resources acquired by curl_global_init()

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::~ResourceHandleManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>
mrowe@apple.com [Sun, 27 Jul 2008 05:49:10 +0000 (05:49 +0000)]
2008-07-26  Marc Ordinas i Llopis  <marc.ordinasillopis@collabora.co.uk>

        Reviewed by Simon Hausmann.

        Bug 18938: [GTK] Plugins not resized
        https://bugs.webkit.org/show_bug.cgi?id=18938

        * plugins/PluginView.cpp:
        (WebCore::PluginView::setFrameGeometry): When viewing a full-page
        plugin in unix, geometry changes have to be passed to the plugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Keishi Hattori <casey.hattori@gmail.com>
mrowe@apple.com [Sun, 27 Jul 2008 05:44:30 +0000 (05:44 +0000)]
2008-07-26  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Adam Roben.

        Add console.time/timeEnd.
        https://bugs.webkit.org/show_bug.cgi?id=19159

        * manual-tests/inspector/console-time.html: Added. Test cases for console.time/timeEnd.
        * page/Console.cpp:
        (WebCore::Console::time): Added.
        (WebCore::Console::timeEnd): Added.
        * page/Console.h:
        * page/Console.idl: Added console.time/timeEnd.
        * page/InspectorController.cpp:
        (WebCore::InspectorController::startTiming): Added.
        (WebCore::InspectorController::stopTiming): Added.
        * page/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Dirk Schulze <vbs85@gmx.de>
mrowe@apple.com [Sun, 27 Jul 2008 05:40:58 +0000 (05:40 +0000)]
2008-07-26  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Nikolas Zimmermann.

        Fixes rendering issues with gradients in SVG/Cairo.

        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::boundingRect):
        * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp:
        (WebCore::applyStrokeStyleToContext):
        (WebCore::SVGPaintServerGradient::setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Dirk Schulze <vbs85@gmx.de>
mrowe@apple.com [Sun, 27 Jul 2008 05:38:28 +0000 (05:38 +0000)]
2008-07-26  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Nikolas Zimmermann.

        Added pattern-support for SVG in Cairo.

        * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
        (WebCore::applyStrokeStyleToContext):
        (WebCore::SVGPaintServerPattern::setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Robert Blaut <webkit@blaut.biz>
mrowe@apple.com [Sun, 27 Jul 2008 05:32:47 +0000 (05:32 +0000)]
2008-07-26  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Alexey Proskuryakov.

        Fix for bug: <https://bugs.webkit.org/show_bug.cgi?id=18186>
        Added notes about unsupported Visual Studio versions.

        * building/tools.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Sun, 27 Jul 2008 05:29:00 +0000 (05:29 +0000)]
2008-07-26  Mark Rowe  <mrowe@apple.com>

        Speculative fix for the wx build.

        * JavaScriptCoreSources.bkl:  Add JSStaticScopeObject.cpp to the list of source files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Sun, 27 Jul 2008 05:27:08 +0000 (05:27 +0000)]
2008-07-26  Mark Rowe  <mrowe@apple.com>

        Build fix.  Changes to accommodate newly named/signatured loading methods in WebCore.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Daniel Jalkut <jalkut@red-sweater.com>
mrowe@apple.com [Sun, 27 Jul 2008 05:23:04 +0000 (05:23 +0000)]
2008-07-26  Daniel Jalkut  <jalkut@red-sweater.com>

        Build fix.  Adjust to updated WebCore FrameLoader method names & signatures.

        * Api/qwebpage.cpp:
        (QWebPage::triggerAction):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Robert Blaut <webkit@blaut.biz>
mrowe@apple.com [Sun, 27 Jul 2008 05:20:36 +0000 (05:20 +0000)]
2008-07-26  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Eric Seidel.

        Fix for <https://bugs.webkit.org/show_bug.cgi?id=16719>
        Removed basic requirements for undetected version of WebKit.

        * quality/reporting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Robert Blaut <webkit@blaut.biz>
mrowe@apple.com [Sun, 27 Jul 2008 05:18:08 +0000 (05:18 +0000)]
2008-07-26  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Adele Petersen.

        Fix for bug 7436: Truncated title on webkit DOM page.
        <https://bugs.webkit.org/show_bug.cgi?id=7436>

        * projects/dom/index.html: Added basic project informations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Keishi Hattori <casey.hattori@gmail.com>
mrowe@apple.com [Sun, 27 Jul 2008 05:14:19 +0000 (05:14 +0000)]
2008-07-26  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Adam Roben.

        Fixed bug 18540: console.log('multiple', 'strings') quotes all strings after the first
        <https://bugs.webkit.org/show_bug.cgi?id=18540>

        * page/inspector/Console.js:
        (WebInspector.ConsoleMessage.prototype._format): String arguments are appended without formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Anthony Ricaud <rik24d@gmail.com>
mrowe@apple.com [Sun, 27 Jul 2008 05:10:17 +0000 (05:10 +0000)]
2008-07-26  Anthony Ricaud  <rik24d@gmail.com>

        Reviewed by Tim Hatcher.

        <https://bugs.webkit.org/show_bug.cgi?id=17589> Line highlighting should last longer

        Restore the fade out effect after highlighting.

        * page/inspector/SourceFrame.js: Add a class for fade-out effects and sets it at the end of highlighting time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Michelangelo De Simone <michelangelo@me.com>
mrowe@apple.com [Sun, 27 Jul 2008 05:08:31 +0000 (05:08 +0000)]
2008-07-26  Michelangelo De Simone  <michelangelo@me.com>

        Reviewed by Adele Petersen.

        Added the simple willValidate attribute to form controls according to
        WebForms 2 spec.

        URL: http://www.w3.org/TR/web-forms-2/#willvalidate

        Tests: fast/forms/willvalidate-000.html
               fast/forms/willvalidate-001.html
               fast/forms/willvalidate-002.html
               fast/forms/willvalidate-003.html
               fast/forms/willvalidate-004.html
               fast/forms/willvalidate-005.html
               fast/forms/willvalidate-006.html
               fast/forms/willvalidate-007.html
               fast/forms/willvalidate-008.html
               fast/forms/willvalidate-009.html

        * html/HTMLButtonElement.h: Added willValidate(), always false.
        * html/HTMLButtonElement.idl: willValidate attribute exposed.
        * html/HTMLFieldSetElement.h: Added willValidate(), always false.
        * html/HTMLFieldSetElement.idl: willValidate attribute exposed.
        * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::willValidate):
        Added base willValidate() implementation.
        * html/HTMLFormControlElement.h: Added willValidate().
        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willValidate):
        Added willValidate(), checks for input type.
        * html/HTMLInputElement.h: Added willValidate()
        * html/HTMLInputElement.idl: willValidate attribute exposed.
        * html/HTMLSelectElement.idl: willValidate attribute exposed.
        * html/HTMLTextAreaElement.idl: willValidate attribute exposed.

2008-07-26  Michelangelo De Simone  <m.des@mac.com>

        Reviewed by Adele Petersen.

        Test suite for the willValidate form controls attribute.

        * fast/forms/willvalidate-000-expected.txt: Added.
        * fast/forms/willvalidate-000.html: Added.
        * fast/forms/willvalidate-001-expected.txt: Added.
        * fast/forms/willvalidate-001.html: Added.
        * fast/forms/willvalidate-002-expected.txt: Added.
        * fast/forms/willvalidate-002.html: Added.
        * fast/forms/willvalidate-003-expected.txt: Added.
        * fast/forms/willvalidate-003.html: Added.
        * fast/forms/willvalidate-004-expected.txt: Added.
        * fast/forms/willvalidate-004.html: Added.
        * fast/forms/willvalidate-005-expected.txt: Added.
        * fast/forms/willvalidate-005.html: Added.
        * fast/forms/willvalidate-006-expected.txt: Added.
        * fast/forms/willvalidate-006.html: Added.
        * fast/forms/willvalidate-007-expected.txt: Added.
        * fast/forms/willvalidate-007.html: Added.
        * fast/forms/willvalidate-008-expected.txt: Added.
        * fast/forms/willvalidate-008.html: Added.
        * fast/forms/willvalidate-009-expected.txt: Added.
        * fast/forms/willvalidate-009.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
mrowe@apple.com [Sun, 27 Jul 2008 04:21:18 +0000 (04:21 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Mark Rowe.
mitz@apple.com [Sun, 27 Jul 2008 04:10:25 +0000 (04:10 +0000)]
    Rubber-stamped by Mark Rowe.

        * platform/win/Skipped: Added fast/text/international/bidi-AN-after-empty-run.html
        (<rdar://problem/5075790>) and svg/custom/stroke-width-click.svg
        (<rdar://problem/5539822>).
        * platform/win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
        Updated results for the new way path data is dumped after
        <http://trac.webkit.org/changeset/34117>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
mrowe@apple.com [Sun, 27 Jul 2008 04:07:19 +0000 (04:07 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-26 Daniel Jalkut <jalkut@red-sweater.com>
mrowe@apple.com [Sun, 27 Jul 2008 03:49:29 +0000 (03:49 +0000)]
2008-07-26  Daniel Jalkut  <jalkut@red-sweater.com>

        Reviewed by Geoff Garen.

        Revised the FrameLoader class to clean up a variety of load methods, and hopefully
        move things closer to integrating into a smaller set of load methods. To this
        end, I renamed many of the overloaded load() methods to have more meaningful and
        easier to search names.  I added comments to the header file to provide clues as
        to how many of the load methods are being used, and how they fit into the loading
        process. I suspect that the renamed methods and comments indicating their present
        usage will facilitate easier cleanup by myself and others as inspiration strikes.

        Updated clients of FrameLoader where necessary to adapt to the new method names and signatures.

        Combined the 3 canLoad() methods into a single canLoad which expresses the
        intended logic of the 3 with a single method interface.

        Removed unnecessary "treatAsLocal" attribute of CachedResource. It was only called from
        one place in FrameLoader.cpp, and it derived at initialization time by calling back to FrameLoader.

        Removed unused userGesture parameter to one variant of the urlSelected method, and
        moved one of the urlSelected methods so that it lives nearer to its overloaded
        sibling.

        * WebCore.base.exp:
        * loader/Cache.cpp:
        (WebCore::Cache::requestResource):
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        * loader/CachedResource.h:
        (WebCore::CachedResource::errorOccurred):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createWindow):
        (WebCore::FrameLoader::urlSelected):
        (WebCore::FrameLoader::loadURLIntoChildFrame):
        (WebCore::FrameLoader::loadPlugin):
        (WebCore::FrameLoader::loadFrameRequestWithFormState):
        (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
        (WebCore::FrameLoader::loadURL):
        (WebCore::FrameLoader::loadWithNavigationAction):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::loadWithDocumentLoader):
        (WebCore::FrameLoader::canLoad):
        (WebCore::FrameLoader::reloadAllowingStaleData):
        (WebCore::FrameLoader::reload):
        (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
        (WebCore::FrameLoader::submitForm):
        (WebCore::FrameLoader::loadPostRequest):
        (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
        (WebCore::FrameLoader::loadItem):
        * loader/FrameLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):

2008-07-26  Daniel Jalkut  <jalkut@red-sweater.com>

        Reviewed by Geoff Garen.

        Changes to accommodate newly named/signatured loading methods in WebCore.

        * Plugins/WebNetscapePluginStream.mm:
        (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
        * Plugins/WebPluginContainerCheck.mm:
        (-[WebPluginContainerCheck _isForbiddenFileLoad]):
        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewWillClickOnLink:withURL:]):

2008-07-26  Matt Lilek  <webkit@mattlilek.com>

        Reviewed by Geoff Garen.

        Changes to accommodate newly named/signatured loading methods in WebCore.

        * WebCoreSupport/WebContextMenuClient.cpp:
        (WebContextMenuClient::searchWithGoogle):
        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::loadURLIntoChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd radar number to ChangeLog
weinig@apple.com [Sun, 27 Jul 2008 02:47:47 +0000 (02:47 +0000)]
Add radar number to ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Sun, 27 Jul 2008 02:45:06 +0000 (02:45 +0000)]
WebCore:

2008-07-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix https://bugs.webkit.org/show_bug.cgi?id=20122
        REGRESSION (r35075-r35110): Cannot enlarge images at Apple Store product page

        Use strict parsing when in AlmostStrict mode.

        Tests: fast/dom/SelectorAPI/dumpNodeList-almost-strict.html
               fast/dom/SelectorAPI/id-fastpath-almost-strict.html
               fast/dom/SelectorAPI/id-fastpath-strict.html

        * dom/Node.cpp:
        (WebCore::Node::querySelector):
        (WebCore::Node::querySelectorAll):

LayoutTests:

2008-07-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix https://bugs.webkit.org/show_bug.cgi?id=20122
        REGRESSION (r35075-r35110): Cannot enlarge images at Apple Store product page

        - Additionally, fix some errors introduced in old tests.

        * fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt: Added.
        * fast/dom/SelectorAPI/dumpNodeList-almost-strict.html: Added.
        * fast/dom/SelectorAPI/dumpNodeList-expected.txt:
        * fast/dom/SelectorAPI/dumpNodeList.html:
        * fast/dom/SelectorAPI/id-fastpath-almost-strict-expected.txt: Added.
        * fast/dom/SelectorAPI/id-fastpath-almost-strict.html: Added.
        * fast/dom/SelectorAPI/id-fastpath-strict-expected.txt: Added.
        * fast/dom/SelectorAPI/id-fastpath-strict.html: Added.
        * fast/dom/SelectorAPI/resources/id-fastpath-almost-strict.js: Added.
        * fast/dom/SelectorAPI/resources/id-fastpath-strict.js: Added.
        * fast/dom/SelectorAPI/resources/id-fastpath.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - move Leopard-only expected failure results back to mac-leopard; these
mitz@apple.com [Sat, 26 Jul 2008 23:59:11 +0000 (23:59 +0000)]
    - move Leopard-only expected failure results back to mac-leopard; these
          are covered by <rdar://problem/5539818> and <rdar://problem/5539820>.

        * platform/mac-leopard/http: Added.
        * platform/mac-leopard/http/tests: Added.
        * platform/mac-leopard/http/tests/security: Copied from platform/mac/http/tests/security.
        * platform/mac-leopard/security: Copied from platform/mac/security.
        * platform/mac/http/tests/security: Removed.
        * platform/mac/http/tests/security/dataURL: Removed.
        * platform/mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
        * platform/mac/security: Removed.
        * platform/mac/security/block-test-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
mitz@apple.com [Sat, 26 Jul 2008 23:37:43 +0000 (23:37 +0000)]
    Reviewed by Oliver Hunt.

        - clean up expected layout test results

        * fast/encoding/idn-security-expected.txt: Replaced with LayoutTests/platform/mac/fast/encoding/idn-security-expected.txt,
        which is the version of the results for platforms that have "newer ICU".
        * platform/mac-leopard/Skipped: Added svg/custom/stroke-width-click.svg.
        * platform/mac-tiger/fast/encoding: Added.
        * platform/mac-tiger/fast/encoding/idn-security-expected.txt: Copied from LayoutTests/fast/encoding/idn-security-expected.txt,
        as Tiger still needs the "older ICU" version of the results.
        * platform/mac/fast/encoding/idn-security-expected.txt: Removed.
        * platform/mac/svg/custom/stroke-width-click-expected.checksum: Removed
        pixel results for a text-only test.
        * platform/mac/svg/custom/stroke-width-click-expected.png: Ditto.
        * platform/mac/svg/custom/stroke-width-click-expected.txt: Removed
        platform-specific results for a text-only test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Nikolas Zimmermann.
mitz@apple.com [Sat, 26 Jul 2008 18:59:13 +0000 (18:59 +0000)]
    Rubber-stamped by Nikolas Zimmermann.

        - move platform-independent results back to the generic location

        * platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Removed.
        * svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Copied from LayoutTests/platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-25 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Sat, 26 Jul 2008 13:03:02 +0000 (13:03 +0000)]
2008-07-25  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Switch off QPainter's anti aliasing when painting the widgets using QStyle
        because otherwise the widgets will look blurry and not crisp.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::StylePainter::StylePainter):
        (WebCore::StylePainter::~StylePainter):
        * platform/qt/RenderThemeQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWhoops, forgot to save style correction.
oliver@apple.com [Sat, 26 Jul 2008 05:18:26 +0000 (05:18 +0000)]
Whoops, forgot to save style correction.

RS=Cameron Zwarich

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 19718: Named anonymous functions are slow accessing global variables
oliver@apple.com [Sat, 26 Jul 2008 03:52:24 +0000 (03:52 +0000)]
Bug 19718: Named anonymous functions are slow accessing global variables
<https://bugs.webkit.org/show_bug.cgi?id=19718>

Reviewed by Cameron Zwarich.

To fix this we switch over to an activation-like scope object for
on which we attach the function name property, and add logic to
prevent cross scope assignment to read only properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOn wx/Win, including windows.h in Threading.h causes multiply-defined symbol errors...
kevino@webkit.org [Sat, 26 Jul 2008 02:28:57 +0000 (02:28 +0000)]
On wx/Win, including windows.h in Threading.h causes multiply-defined symbol errors for libjpeg and wx, and also wx needs to include windows.h itself first for wx includes to work right. So until we can find a better solution to this problem on wx, we work around the need to include windows.h here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Sam Weinig.
mitz@apple.com [Sat, 26 Jul 2008 00:35:29 +0000 (00:35 +0000)]
    Rubber-stamped by Sam Weinig.

        - moved expected results from platform/mac-leopard to platform/mac.
        Where the mac baseline differed from the Leopard results, moved the
        results from mac to mac-tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-25 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 26 Jul 2008 00:34:01 +0000 (00:34 +0000)]
2008-07-25  Jan Michael Alonzo  <jmalonzo@webkit.org>

        DRT/Gtk build fix for r35362

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::elementDoesAutoCompleteForElementWithId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35365 268f45cc-cd09-0410-ab3c-d52691b4dbfc