WebKit-https.git
12 years ago Reviewed by Mark Rowe.
ap@apple.com [Sat, 17 Oct 2009 06:59:38 +0000 (06:59 +0000)]
    Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=30470
        Make marking a bug as duplicate easier

        * js/field.js: (setResolutionToDuplicate): Show edit field right away, don't make the user
        click again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=30456
sfalken@apple.com [Sat, 17 Oct 2009 06:29:49 +0000 (06:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30456
Fixes for new Debug_All Windows build configuration.

Reviewed by Dan Bernstein.

WebCore:

* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::findCFNetworkModule): Ask for the correct library instead of guessing.
* platform/win/ScrollbarThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.
* rendering/RenderMediaControls.cpp: Use new DEBUG_ALL preprocessor define for library naming.
* rendering/RenderThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.

WebKit/win:

* WebKitClassFactory.cpp: Use new DEBUG_ALL preprocessor define for library naming.

WebKitLibraries:

* win/tools/vsprops/debug_all.vsprops:
Define DEBUG_ALL in Debug_All configuration.
Continue to define USE_DEBUG_SAFARI_THEME for open source SafariTheme header usage.

WebKitTools:

* DumpRenderTree/win/DumpRenderTree.cpp:
(sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
* DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRolled back in r49717 with the build maybe working now?
ggaren@apple.com [Sat, 17 Oct 2009 05:52:20 +0000 (05:52 +0000)]
Rolled back in r49717 with the build maybe working now?

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Jon Honeycutt.
kdecker@apple.com [Sat, 17 Oct 2009 05:15:57 +0000 (05:15 +0000)]
    Reviewed by Jon Honeycutt.

        <rdar://problem/7304575>

        * Plugins/WebBaseNetscapePluginView.h: Added new boolean ivar and -hasBeenHalted instance method.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView halt]):Update _hasBeenHalted.
        (-[WebBaseNetscapePluginView hasBeenHalted]): Added.
        * WebView/WebView.mm:
        (+[WebView _hasPluginForNodeBeenHalted:]): Checks to see if a plug-in node's been halted.
        * WebView/WebViewPrivate.h: Added -_hasPluginForNodeBeenHalted method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd SPI to determine whether a plug-in has ever been halted.
jhoneycutt@apple.com [Sat, 17 Oct 2009 04:38:38 +0000 (04:38 +0000)]
Add SPI to determine whether a plug-in has ever been halted.

Part of <rdar://problem/7312158>.

Reviewed by Dan Bernstein.

WebCore:

* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
Initialize m_hasBeenHalted.

* plugins/PluginView.h:
(WebCore::PluginView::hasBeenHalted):
Return m_hasBeenHalted.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::halt):
Set m_hasBeenHalted.

WebKit/win:

* Interfaces/IWebViewPrivate.idl:
Add hasPluginForNodeBeenHalted().

* WebView.cpp:
(pluginViewForNode):
Code factored out of isNodeHaltedPlugin().
(WebView::isNodeHaltedPlugin):
Remove STDMETHODCALLTYPE, as it has no use at the definition. Use
pluginViewForNode().
(WebView::restartHaltedPluginForNode):
Ditto.
(WebView::hasPluginForNodeBeenHalted):
Get the PluginView for the given node. Return the result of
PluginView::hasBeenHalted().

* WebView.h:
Declare hasPluginForNodeBeenHalted().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 17 Oct 2009 04:23:57 +0000 (04:23 +0000)]
2009-10-16  Simon Fraser  <simon.fraser@apple.com>

        Skip this test:
            compositing/animation/animated-composited-inside-hidden.html
        because the fix for https://bugs.webkit.org/show_bug.cgi?id=26770 was backed out.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] QGLauncher leaks WebPage object
tonikitoo@webkit.org [Sat, 17 Oct 2009 03:54:56 +0000 (03:54 +0000)]
[Qt] QGLauncher leaks WebPage object
https://bugs.webkit.org/show_bug.cgi?id=30465

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.

Make 'SharedScene' to own 'WebPage' reference and delete it at its destructor.

* Api/qwebpage.cpp:
(QWebPage::view):
* Api/qwebpage_p.h:
* QGVLauncher/main.cpp:
(SharedScene::SharedScene):
(SharedScene::~SharedScene):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] "dangling" pointer to qwebpage's view object can leads QGLauncher to crash
tonikitoo@webkit.org [Sat, 17 Oct 2009 03:51:08 +0000 (03:51 +0000)]
[Qt] "dangling" pointer to qwebpage's view object can leads QGLauncher to crash
https://bugs.webkit.org/show_bug.cgi?id=30459

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.

Remove all setView(ev->widget()) calls in QWebPage and QGWV event handling methods,
since QWebPageClient would do the trick.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::hoverMoveEvent):
* Api/qwebpage.cpp:
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragLeaveEvent):
(QWebPagePrivate::dragMoveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdated expected results of tests that give CONSOLE messages for
bweinstein@apple.com [Sat, 17 Oct 2009 03:35:44 +0000 (03:35 +0000)]
Updated expected results of tests that give CONSOLE messages for
new verbose output.

* fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt:
* fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
* platform/mac/fast/dynamic/015-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 17 Oct 2009 03:10:59 +0000 (03:10 +0000)]
2009-10-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        @charset rule after the first byte causes the rest of css to be ignored
        https://bugs.webkit.org/show_bug.cgi?id=18265

        Apparently we're supposed to tolerate whitespace before the charset
        rule so folks can write code like this:

        <style>
        @charset "utf-8"
        ...
        </style>

        I'm told this is one of the top compatability problems in China.
        Tests: fast/css/comment-before-charset-external.html
               fast/css/comment-before-charset.html
               fast/css/many-spaces-before-charset.html
               fast/css/space-before-charset-external.html
               fast/css/space-before-charset.html

        * css/CSSGrammar.y:
2009-10-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        @charset rule after the first byte causes the rest of css to be ignored
        https://bugs.webkit.org/show_bug.cgi?id=18265

        Test that we allow whitespace and comments before the charset rule.
        These test results all match Firefox.

        * fast/css/comment-before-charset-expected.txt: Added.
        * fast/css/comment-before-charset-external-expected.txt: Added.
        * fast/css/comment-before-charset-external.html: Added.
        * fast/css/comment-before-charset.html: Added.
        * fast/css/many-spaces-before-charset-expected.txt: Added.
        * fast/css/many-spaces-before-charset.html: Added.
        * fast/css/resources/comment-before-charset.css: Added.
        * fast/css/resources/space-before-charset.css: Added.
        * fast/css/space-before-charset-expected.txt: Added.
        * fast/css/space-before-charset-external-expected.txt: Added.
        * fast/css/space-before-charset-external.html: Added.
        * fast/css/space-before-charset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r49717 as it broke the build.
mrowe@apple.com [Sat, 17 Oct 2009 02:31:42 +0000 (02:31 +0000)]
Roll out r49717 as it broke the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Adam Roben.
bweinstein@apple.com [Sat, 17 Oct 2009 01:23:43 +0000 (01:23 +0000)]
Rubber-stamped by Adam Roben.

Remove inspector tests from Windows Skipped list, because they pass locally
and the front-end changes are picked up by the bots.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix: apparently we shouldn't export those symbols?
ggaren@apple.com [Sat, 17 Oct 2009 01:20:12 +0000 (01:20 +0000)]
Build fix: apparently we shouldn't export those symbols?

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
* JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fixes part of <http://webkit.org/b/30412>.
bweinstein@apple.com [Sat, 17 Oct 2009 01:18:24 +0000 (01:18 +0000)]
WebCore: Fixes part of <webkit.org/b/30412>.
Web Inspector should get human readable DOM Exceptions.

Reviewed by Darin Adler.

Add a description field to ExceptionBase, and call it through
reportException which allows the user/developer to get a more detailed
and coherent error explanation through the Web Inspector.

This only applies to exceptions that come from a script on the page when
it is run. DOM Exceptions that come from the code run in the console, or DOM
exceptions that are caught and logged will come in a future patch.

Tests: inspector/uncaught-dom1-exception.html
       inspector/uncaught-dom3-exception.html
       inspector/uncaught-dom8-exception.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
* bindings/js/JSExceptionBase.cpp: Added.
(WebCore::toExceptionBase):
* bindings/js/JSExceptionBase.h: Added.
* dom/ExceptionBase.cpp:
(WebCore::ExceptionBase::ExceptionBase):
* dom/ExceptionBase.h:
(WebCore::ExceptionBase::description):
* dom/ExceptionCode.cpp:
(WebCore::):
(WebCore::getExceptionCodeDescription):
* dom/ExceptionCode.h:

LayoutTests: Fixes part of <http://webkit.org/b/30412>.
Web Inspector should get human readable DOM Exceptions.

Reviewed by Darin Adler.

Adds tests for output of uncaught exceptions to the Web Inspector
Console. Tests DOM exceptions 1, 3, and 8 (INDEX_SIZE_ERR, NOT_FOUND_ERR, and
HIERARCHY_REQUEST_ERR).

* inspector/uncaught-dom1-exception-expected.txt: Added.
* inspector/uncaught-dom1-exception.html: Added.
* inspector/uncaught-dom3-exception-expected.txt: Added.
* inspector/uncaught-dom3-exception.html: Added.
* inspector/uncaught-dom8-exception-expected.txt: Added.
* inspector/uncaught-dom8-exception.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix: export some symbols.
ggaren@apple.com [Sat, 17 Oct 2009 01:09:35 +0000 (01:09 +0000)]
Build fix: export some symbols.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
* JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agostructure typeinfo flags should be inherited.
oliver@apple.com [Sat, 17 Oct 2009 01:06:40 +0000 (01:06 +0000)]
structure typeinfo flags should be inherited.
https://bugs.webkit.org/show_bug.cgi?id=30468

Reviewed by Gavin Barraclough.

Add StructureFlag constant to the various JSC classes and use
it for the TypeInfo construction.  This allows us to simply
accumulate flags by basing each classes StructureInfo on its parents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix: forgot to check in this #include.
ggaren@apple.com [Sat, 17 Oct 2009 00:45:32 +0000 (00:45 +0000)]
Build fix: forgot to check in this #include.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
* bridge/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* coding/RefPtr.html: Minor revision, updating a link and tweaking
darin@apple.com [Sat, 17 Oct 2009 00:40:16 +0000 (00:40 +0000)]
* coding/RefPtr.html: Minor revision, updating a link and tweaking
wording a bit in few places.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFast for-in enumeration: Cache JSPropertyNameIterator; cache JSStrings
ggaren@apple.com [Sat, 17 Oct 2009 00:28:19 +0000 (00:28 +0000)]
Fast for-in enumeration: Cache JSPropertyNameIterator; cache JSStrings
in JSPropertyNameIterator; inline more code.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
Reviewed by Oliver Hunt.

1.024x as fast on SunSpider (fasta: 1.43x as fast).

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetPropertyNames):
(JSC::BytecodeGenerator::emitNextPropertyName):
* bytecompiler/BytecodeGenerator.h: Added a few extra operands to
op_get_pnames and op_next_pname so that we can track iteration state
in the register file instead of in the JSPropertyNameIterator. (To be
cacheable, the JSPropertyNameIterator must be stateless.)

* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".

(JSC::Interpreter::privateExecute): Updated for in-RegisterFile
iteration state tracking.

* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_pnames): Updated for in-RegisterFile
iteration state tracking.

(JSC::JIT::emit_op_next_pname): Inlined code generation for op_next_pname.

* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".

(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::): Added has_property and to_object stubs. Removed op_next_pname
stub, since has_property is all we need anymore.

* parser/Nodes.cpp:
(JSC::ForInNode::emitBytecode): Updated for in-RegisterFile
iteration state tracking.

* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames): Don't do caching at this layer
anymore, since we don't create a JSPropertyNameIterator at this layer.

* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create): Do do caching at this layer.
(JSC::JSPropertyNameIterator::get):  Updated for in-RegisterFile
iteration state tracking.
(JSC::JSPropertyNameIterator::markChildren): Mark our JSStrings.

* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::size):
(JSC::JSPropertyNameIterator::setCachedStructure):
(JSC::JSPropertyNameIterator::cachedStructure):
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
(JSC::JSPropertyNameIterator::cachedPrototypeChain):
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::Structure::setEnumerationCache): Don't store iteration state in
a JSPropertyNameIterator. Do cache a JSPropertyNameIterator in a
Structure.

* runtime/JSValue.h:
(JSC::asCell):
* runtime/MarkStack.h: Make those mischievous #include gods happy.

* runtime/ObjectConstructor.cpp:

* runtime/Operations.h:
(JSC::normalizePrototypeChain): Renamed countPrototypeChainEntriesAndCheckForProxies
to normalizePrototypeChain, since it changes dictionary prototypes to
non-dictionary objects.

* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/PropertyNameArray.h:
(JSC::PropertyNameArrayData::PropertyNameArrayData):
(JSC::PropertyNameArray::data):
(JSC::PropertyNameArray::size):
(JSC::PropertyNameArray::begin):
(JSC::PropertyNameArray::end): Simplified some code here to help with
current and future refactoring.

* runtime/Protect.h:
* runtime/Structure.cpp:
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition): No need to clear
the enumeration cache with adding / removing properties without
transition. It is an error to add / remove properties without transition
once an object has been observed, and we can ASSERT to catch that.

* runtime/Structure.h:
(JSC::Structure::enumerationCache): Changed the enumeration cache to
hold a JSPropertyNameIterator.

* runtime/StructureChain.cpp:
* runtime/StructureChain.h:
(JSC::StructureChain::head): Removed StructureChain::isCacheable because
it was wrong-headed in two ways: (1) It gave up when a prototype was a
dictionary, but instead we want un-dictionary heavily accessed
prototypes; (2) It folded a test for hasDefaultGetPropertyNames() into
a generic test for "cacheable-ness", but hasDefaultGetPropertyNames()
is only releavant to for-in caching.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 17 Oct 2009 00:20:45 +0000 (00:20 +0000)]
2009-10-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Transform layer gets stuck with the wrong transform after an animation ends
        <rdar://problem/7311662>

        Work around a CoreAnimation bug which causes an animated transform layer to
        end up with a stale transform.

        Test: compositing/animation/state-at-end-event-transform-layer.html

        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::bug7311367Workaround):
        (WebCore::GraphicsLayerCA::removeAnimationFromLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowxMSW non-precomp headers build fix.
kevino@webkit.org [Sat, 17 Oct 2009 00:20:16 +0000 (00:20 +0000)]
wxMSW non-precomp headers build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 17 Oct 2009 00:17:11 +0000 (00:17 +0000)]
2009-10-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        After running a transition with an end event listener, can't change the transform
        https://bugs.webkit.org/show_bug.cgi?id=30454

        Fix an issue where, if a document had any listener for webkitTransitionEnd or webkitAnimationEnd,
        the animations would not get cleaned up correctly, which broke subsequent changes of transform.

        Now, we always clean up the animations right after queuing up the end events.

        Tests: animations/state-at-end-event.html
               transitions/move-after-transition.html

        * page/animation/ImplicitAnimation.cpp:
        (WebCore::ImplicitAnimation::onAnimationEnd):
        * page/animation/KeyframeAnimation.cpp:
        (WebCore::KeyframeAnimation::onAnimationEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlson.
kdecker@apple.com [Sat, 17 Oct 2009 00:11:53 +0000 (00:11 +0000)]
    Reviewed by Anders Carlson.

        Small code cleanup

        * Plugins/WebBaseNetscapePluginView.mm:
        (WebHaltablePlugin::halt): Just call -[WebBaseNetscapePluginView halt].
        (WebHaltablePlugin::restart): Just call -[WebBaseNetscapePluginView resumeFromHalt]
        (-[WebBaseNetscapePluginView halt]):
        (-[WebBaseNetscapePluginView resumeFromHalt]):
        * WebView/WebView.mm:
        (_pluginViewForNode): Added a check if a render is a widget. This prevents a later assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 17 Oct 2009 00:08:50 +0000 (00:08 +0000)]
2009-10-15  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Handle the Enter Key in the Elements Tree Hierarchy
        https://bugs.webkit.org/show_bug.cgi?id=30428

        TextNode => Edit Text Node
        Has Attributes => Edit First Attribute
        No Attributes => Start Editing New Attribute

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): handle the "Enter" key
        (WebInspector.ElementsTreeElement.prototype.set hovered): only add new attribute button on nodes with attributes
        (WebInspector.ElementsTreeElement.prototype._addNewAttribute): prevent moving backwards where there are no attributes
        (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): renamed to be clearer
        (WebInspector.ElementsTreeElement.prototype._startEditing): transition to the appropriate edit state for a tree element

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 17 Oct 2009 00:04:41 +0000 (00:04 +0000)]
2009-10-16  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue status bot should list which buildbot is blocking the queue
        https://bugs.webkit.org/show_bug.cgi?id=30452

        Add new methods and testing.

        * Scripts/bugzilla-tool:
        * Scripts/modules/buildbot.py:
        * Scripts/modules/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 16 Oct 2009 23:57:15 +0000 (23:57 +0000)]
2009-10-16  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        run-webkit-tests fails when CWD is not inside a WebKit checkout
        https://bugs.webkit.org/show_bug.cgi?id=30451

        * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
        * Scripts/modules/scm_unittest.py:
          - Remove use of original_path (we don't need to restore the CWD).
          - Don't use '.' to find the webkit checkout, use __file__ instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 16 Oct 2009 23:44:48 +0000 (23:44 +0000)]
2009-10-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Fix header indent style for FrameLoader and friends
        https://bugs.webkit.org/show_bug.cgi?id=30430

        * loader/FrameLoader.h:
        (WebCore::FrameLoader::frame):
        (WebCore::FrameLoader::policyChecker):
        (WebCore::FrameLoader::history):
        (WebCore::FrameLoader::notifier):
        (WebCore::FrameLoader::isLoadingMainResource):
        (WebCore::FrameLoader::documentLoader):
        (WebCore::FrameLoader::policyDocumentLoader):
        (WebCore::FrameLoader::provisionalDocumentLoader):
        (WebCore::FrameLoader::state):
        (WebCore::FrameLoader::client):
        (WebCore::FrameLoader::url):
        (WebCore::FrameLoader::isLoadingFromCachedPage):
        (WebCore::FrameLoader::committingFirstRealLoad):
        (WebCore::FrameLoader::committedFirstRealDocumentLoad):
        (WebCore::FrameLoader::creatingInitialEmptyDocument):
        * loader/HistoryController.h:
        (WebCore::HistoryController::currentItem):
        (WebCore::HistoryController::provisionalItem):
        * loader/PolicyCallback.h:
        (WebCore::PolicyCallback::request):
        * loader/PolicyChecker.h:
        (WebCore::PolicyChecker::loadType):
        (WebCore::PolicyChecker::setLoadType):
        (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy):
        (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy):
        * loader/RedirectScheduler.h:
        * loader/ResourceLoadNotifier.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a Debug_All configuration to build entire stack as debug.
sfalken@apple.com [Fri, 16 Oct 2009 22:31:32 +0000 (22:31 +0000)]
Add a Debug_All configuration to build entire stack as debug.
Change Debug_Internal to:
- stop using _debug suffix for all WebKit/Safari binaries
- not use _debug as a DLL naming suffix
- use non-debug C runtime lib.

Reviewed by Adam Roben.

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore.make: Debug build in makefile should build Debug_All.
* JavaScriptCore.vcproj/JavaScriptCore.sln: Add Debug_All configuration.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add Debug_All configuration.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Add Debug_All configuration.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Add Debug_All configuration.
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_All configuration.
* JavaScriptCore.vcproj/testapi/testapi.vcproj: Add Debug_All configuration.

WebCore:

* WebCore.vcproj/QTMovieWin.vcproj: Add Debug_All configuration.
* WebCore.vcproj/WebCore.make: Debug build in makefile should build Debug_All.
* WebCore.vcproj/WebCore.sln: Add Debug_All configuration.
* WebCore.vcproj/WebCore.submit.sln: Add Debug_All configuration.
* WebCore.vcproj/WebCore.vcproj: Add Debug_All configuration.
* WebCore.vcproj/WebCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".

WebKit/win:

* WebKit.vcproj/InterfacesGenerated.vcproj: Renamed single configuration from "Release" to "all".
* WebKit.vcproj/WebKit.make: Debug build in makefile should build Debug_All.
* WebKit.vcproj/WebKit.sln: Add Debug_All configuration.
* WebKit.vcproj/WebKit.submit.sln: Add Debug_All configuration.
* WebKit.vcproj/WebKit.vcproj:
Remove extraneous OutputDirectory/IntermediateDirectory in Debug_Cairo.
Add Debug_All configuration.
* WebKit.vcproj/WebKitGUID.vcproj: Add Debug_All configuration.

WebKitLibraries:

* win/tools/vsprops/debug_all.vsprops: Added.
Use debug C runtime library in debug_all.
Specify USE_DEBUG_SAFARI_THEME to get "_debug" suffix for debug_all.
* win/tools/vsprops/debug_internal.vsprops:
Don't specify debug C runtime library in debug_internal.
Don't specify _debug suffix for standard debug_internal builds.

WebKitTools:

* DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
* DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
* DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
Add missing debug.vsprops inherited property sheet.
Add Debug_All configuration.
* FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
* WinLauncher/WinLauncher.vcproj:
Removed extraneous definitions inherited from vsprops.
Add Debug_All configuration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Rolling out r49661 since it makes tests fail on GTK+ and Mac with Xiph...
kov@webkit.org [Fri, 16 Oct 2009 22:28:08 +0000 (22:28 +0000)]
Unreviewed. Rolling out r49661 since it makes tests fail on GTK+ and Mac with Xiph plugin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 16 Oct 2009 22:07:56 +0000 (22:07 +0000)]
2009-10-16  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r49693, because it broke Chromium build.
        http://trac.webkit.org/changeset/49693

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Fri, 16 Oct 2009 22:03:40 +0000 (22:03 +0000)]
2009-10-16  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson.

        Updated media resource selection algorithm to reflect latest HTML 5 specification.

        https://bugs.webkit.org/show_bug.cgi?id=30407

        * media/video-play-pause-exception-expected.txt:
        * media/video-play-pause-exception.html:
        * media/video-src-empty-expected.txt: Added.
        * media/video-src-empty.html: Added.
        * media/video-src-none-expected.txt: Added.
        * media/video-src-none.html: Added.
2009-10-16  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson.

        Updated media resource selection algorithm to reflect latest HTML 5 specification.

        Noticable changes:
            -  Elements with no source should have their network state set to NETWORK_EMPTY as opposed to NETWORK_NO_SOURCE
            -  Empty string ("") is now considered a valid URL resolving to the current page and will be loaded

        Tests: media/video-src-empty.html
               media/video-src-none.html

        https://bugs.webkit.org/show_bug.cgi?id=30407

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::selectMediaResource): Updated code and comments to match spec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Fri, 16 Oct 2009 21:33:58 +0000 (21:33 +0000)]
2009-10-16  Daniel Bates  <dbates@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=30266

        Tests that the JavaScript array event.dataTransfer.types can be accessed
        within an ondrop handler without causing a crash.

        Although this issue has been resolved as of nightly r49550 we should add a
        test case so that we can prevent a regression of this issue.

        * fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Added.
        * fast/events/drag-and-drop-dataTransfer-types-nocrash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 16 Oct 2009 21:30:06 +0000 (21:30 +0000)]
2009-10-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Insecure plug-ins don't trigger mixed content
        https://bugs.webkit.org/show_bug.cgi?id=30431

        * http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt: Added.
        * http/tests/security/mixedContent/insecure-plugin-in-iframe.html: Added.
        * http/tests/security/mixedContent/resources/frame-with-insecure-plugin.html: Added.
2009-10-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Insecure plug-ins don't trigger mixed content
        https://bugs.webkit.org/show_bug.cgi?id=30431

        Added the missing check.

        Test: http/tests/security/mixedContent/insecure-plugin-in-iframe.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd SPI to restart a halted plug-in.
jhoneycutt@apple.com [Fri, 16 Oct 2009 21:26:33 +0000 (21:26 +0000)]
Add SPI to restart a halted plug-in.

Part of <rdar://problem/7273354> Halted plug-ins should restart on
mouseover

https://bugs.webkit.org/show_bug.cgi?id=30151

Reviewed by Kevin Decker.

* Interfaces/IWebViewPrivate.idl:
Add restartHaltedPluginForNode().

* WebView.cpp:
(WebView::restartHaltedPluginForNode):
From the IDOMNode, query for the DOMNode. From the DOMNode, get the
WebCore::Node. Get the node's renderer, and check whether it is a
RenderWidget. If so, get its Widget, and check whether it's a
PluginView. If so, call PluginView::restart().

* WebView.h:
Declare restartHaltedPluginForNode().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Fri, 16 Oct 2009 21:21:44 +0000 (21:21 +0000)]
2009-10-16  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson.

        Set autobuffer to true and schedule load in V8 audio element constructor.

        https://bugs.webkit.org/show_bug.cgi?id=30448

        Covered by existing tests.

        * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
        (WebCore::CALLBACK_FUNC_DECL): Set autobuffer to true and schedule load.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Fri, 16 Oct 2009 21:06:15 +0000 (21:06 +0000)]
2009-10-16  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Seidel.

        Remove FIXME in RenderMediaControlsChromium as bug was fixed upstream.

        https://bugs.webkit.org/show_bug.cgi?id=30422

        Covered by existing media layout tests.

        * rendering/RenderMediaControlsChromium.cpp:
        (WebCore::paintMediaSlider): Removed round() and FIXME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlson.
kdecker@apple.com [Fri, 16 Oct 2009 20:57:49 +0000 (20:57 +0000)]
    Reviewed by Anders Carlson.

        Last part of:
        <rdar://problem/7273354>

        * WebView/WebView.mm:
        (_pluginViewForNode): Added with code extracted from _isNodeHaltedPlugin
        (+[WebView _isNodeHaltedPlugin:]): Made this a class method.
        (+[WebView _restartHaltedPluginForNode:]): Added. Restarts a plug-in
        * WebView/WebViewPrivate.h: Added +_restartHaltedPluginForNode to header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Fri, 16 Oct 2009 20:56:51 +0000 (20:56 +0000)]
2009-10-16  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Seidel.

        Fix Chromium media controls to render a disabled play button when the element is unintialized.

        https://bugs.webkit.org/show_bug.cgi?id=30410

        Covered by existing layout tests.

        * rendering/RenderMediaControlsChromium.cpp:
        (WebCore::paintMediaPlayButton): Include check for NETWORK_EMPTY to render disabled play button.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake typeinfo flags default to false
oliver@apple.com [Fri, 16 Oct 2009 20:39:46 +0000 (20:39 +0000)]
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372

Reviewed by Gavin Barraclough.

Last part -- replace HasDefaultGetPropertyNames with OverridesGetPropertyNames
flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Steven Knight <sgk@chromium.org>
eric@webkit.org [Fri, 16 Oct 2009 20:37:41 +0000 (20:37 +0000)]
2009-10-16  Steven Knight  <sgk@chromium.org>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=30447
        Handle long link lines by building .idl-generated bindings in a
        separate webcore_bindings library target.  Avoid Visual Studio
        dependency issues by building additional generated .cpp and .h files
        in a separate webcore_bindings_sources target.

        Chrome should still build and test successfully.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 16 Oct 2009 20:28:08 +0000 (20:28 +0000)]
2009-10-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Carlson.

        Transform transitions that used to be accelerated are no longer so
        https://bugs.webkit.org/show_bug.cgi?id=30453

        The change in r49633, to not run accelerated animations/transitions on layers that
        are not attached, broke accelerated transitions/animations in many cases where they start
        as soon as the page loads. This change reverts the code that tests for the GraphicsLayer being
        attached.

        No test, because it's not possible from a test to know whether a transition is accelerated or not.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::startAnimation):
        (WebCore::RenderLayerBacking::startTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Fri, 16 Oct 2009 20:21:12 +0000 (20:21 +0000)]
2009-10-16  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        LayoutTests/fast/loader/local-JavaScript-from-local.html times out in case of error.
        https://bugs.webkit.org/show_bug.cgi?id=30434

        * fast/loader/local-JavaScript-from-local.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agocheck-webkit-style is wrong about indent checking in namespaces
levin@chromium.org [Fri, 16 Oct 2009 18:46:41 +0000 (18:46 +0000)]
check-webkit-style is wrong about indent checking in namespaces
in header files and a few other things
https://bugs.webkit.org/show_bug.cgi?id=30362

Patch by Carol Szabo <carol.szabo@nokia.com> on 2009-10-16
Reviewed by David Levin.

The few other things include:
+ check-webkit-style does not require spaces around the equal sign
  inside 'if' statements and around binary operators that take
  numeric literals.
+ check-webkit-style reports false errors for the / operator
  when part of a filename in the #include directive.

* Scripts/modules/cpp_style.py:
Improved indentation checking and space checking around
binary operators. While the checks are still not perfect,
they are clearly better than before.
* Scripts/modules/cpp_style_unittest.py:
Added test cases for the newly supported checks and modified old
test cases to match the new guidelines

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders.
kdecker@apple.com [Fri, 16 Oct 2009 18:33:49 +0000 (18:33 +0000)]
    Reviewed by Anders.

        <rdar://problem/7273354>

        * Plugins/WebBaseNetscapePluginView.h: Added _isHalted ivar and three new methods: -halt, -resumeFromHalt, and -isHalted
        * Plugins/WebBaseNetscapePluginView.mm:
        (WebHaltablePlugin::halt): Call -halt instead of -stop.
        (WebHaltablePlugin::restart):Call -resumeFromHalt instead of -start.
        (-[WebBaseNetscapePluginView halt]): Added. Stop the plug-in, update _isHalted.
        (-[WebBaseNetscapePluginView resumeFromHalt]): Added. Start the plug-in, update _isHalted.
        (-[WebBaseNetscapePluginView isHalted]): Added.
        * WebView/WebView.mm:
        (-[WebView _isNodeHaltedPlugin:]): Added. Queries a DOMNode to determine if it's a halted plug-in.
        * WebView/WebViewPrivate.h: Added _isNodeHaltedPlugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowxMSW build fix, we can't use the simple hash there because the PlatformModuleVersion
kevino@webkit.org [Fri, 16 Oct 2009 18:23:36 +0000 (18:23 +0000)]
wxMSW build fix, we can't use the simple hash there because the PlatformModuleVersion
structure differs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 16 Oct 2009 17:46:15 +0000 (17:46 +0000)]
2009-10-16  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix.  Add back MIMETypeRegistryChromium with the right
        casing.

        * platform/chromium/MIMETypeRegistryChromium.cpp: Added.
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
        (WebCore::MIMETypeRegistry::getMIMETypeForPath):
        (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
        (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType):
        (WebCore::MIMETypeRegistry::isJavaAppletMIMEType):
        (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):
        (WebCore::dummyHashSet):
        (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
        (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
        (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding):
        (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
        (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 16 Oct 2009 17:41:21 +0000 (17:41 +0000)]
2009-10-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        MimeTypeRegistryChromium is mis-casen
        https://bugs.webkit.org/show_bug.cgi?id=30441

        Change the case of MimeTypeRegistryChromium to match other platforms.

        * WebCore.gypi:
        * platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
        * platform/chromium/MimeTypeRegistryChromium.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Dimitri Glazkov <dglazkov@chromium.org>
eric@webkit.org [Fri, 16 Oct 2009 17:35:52 +0000 (17:35 +0000)]
2009-10-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Change EmptyPluginHalterClient in SVGImage to be non-static, to
        match changes made http://trac.webkit.org/changeset/49385.
        https://bugs.webkit.org/show_bug.cgi?id=30403

        Run the following layout test sequence:
          LayoutTests/svg/W3C-SVG-1.1/struct-image-01-t.svg
          LayoutTests/svg/W3C-SVG-1.1/struct-image-03-t.svg
          LayoutTests/svg/W3C-SVG-1.1/struct-image-04-t.svg
          LayoutTests/svg/W3C-SVG-1.1/struct-image-05-b.svg
          LayoutTests/svg/W3C-SVG-1.1/struct-image-06-t.svg
          LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
          LayoutTests/svg/W3C-SVG-1.1/struct-image-08-t.svg
          LayoutTests/svg/W3C-SVG-1.1/struct-image-09-t.svg
          LayoutTests/svg/W3C-SVG-1.1/struct-image-10-t.svg
          LayoutTests/svg/carto.net/scrollbar.svg
          LayoutTests/svg/carto.net/selectionlist.svg

        selectionlist.svg should not crash.

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged): Made EmptyPluginHalterClient non-static.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Victor Wang <victorw@chromium.org>
eric@webkit.org [Fri, 16 Oct 2009 17:27:34 +0000 (17:27 +0000)]
2009-10-16  Victor Wang  <victorw@chromium.org>

        Reviewed by David Levin.

        Add beforeload event support to V8DOMWrapper

        https://bugs.webkit.org/show_bug.cgi?id=30413

        LayoutTests/fast/dom/beforeload/frame-before-load.html

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventToV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 16 Oct 2009 16:41:47 +0000 (16:41 +0000)]
2009-10-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        MimeTypeRegistryChromium is mis-casen
        https://bugs.webkit.org/show_bug.cgi?id=30441

        Change the case of MimeTypeRegistryChromium to match other platforms.

        * WebCore.gypi:
        * platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
        * platform/chromium/MimeTypeRegistryChromium.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 16 Oct 2009 16:20:32 +0000 (16:20 +0000)]
2009-10-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Mark Rowe.

        Chrome doesn't set Content-Type for file upload when the file extension
        is not recognized
        https://bugs.webkit.org/show_bug.cgi?id=30433

        Apparently, getMIMETypeForPath is supposed to return
        application/octet-stream when it doesn't have a better MIME type.

        * platform/chromium/MimeTypeRegistryChromium.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPull out r49676 as it caused build breakges on Symbian
vestbo@webkit.org [Fri, 16 Oct 2009 15:58:18 +0000 (15:58 +0000)]
Pull out r49676 as it caused build breakges on Symbian

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Add empty skipped lists for the platform-specific results
vestbo@webkit.org [Fri, 16 Oct 2009 15:53:16 +0000 (15:53 +0000)]
[Qt] Add empty skipped lists for the platform-specific results

Reviewed by Ariya Hidayat.

* platform/qt-linux/Skipped:
* platform/qt-mac/Skipped:
* platform/qt-win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 16 Oct 2009 15:45:38 +0000 (15:45 +0000)]
2009-10-16  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement ExecutableAllocator for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=29946

        Tested with YARR JIT enabled for Symbian;
        This patch does not (yet) enable YARR JIT by default.

        * JavaScriptCore.pri:
        * jit/ExecutableAllocator.h:
        * jit/ExecutableAllocatorSymbian.cpp: Added.
        (JSC::ExecutableAllocator::intializePageSize):
        (JSC::ExecutablePool::systemAlloc):
        (JSC::ExecutablePool::systemRelease):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Update outdated platform dependent expected file.
vestbo@webkit.org [Fri, 16 Oct 2009 13:26:57 +0000 (13:26 +0000)]
[Qt] Update outdated platform dependent expected file.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-16
Reviewed by Tor Arne Vestbø.

* platform/qt/editing/execCommand/toggle-compound-styles-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCrash fix when loading NPAPI plugins on Qt/Mac
vestbo@webkit.org [Fri, 16 Oct 2009 13:26:44 +0000 (13:26 +0000)]
Crash fix when loading NPAPI plugins on Qt/Mac

Reviewed by Ariya Hidayat.

There's no guarantee that the plist will be valid even if we
ask the plugin to create it. Crash obverved with iGetter.

* plugins/mac/PluginPackageMac.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Fri, 16 Oct 2009 13:18:37 +0000 (13:18 +0000)]
2009-10-16  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Need a way to inform the application when a Netscape plugin is created or deleted
        https://bugs.webkit.org/show_bug.cgi?id=30179

        Inform the application when a plugin is created or destroyed, but only if the
        application registered for these notifications.

        * plugins/symbian/PluginViewSymbian.cpp:
        (WebCore::PluginView::platformStart):
        (WebCore::PluginView::platformDestroy):
2009-10-16  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Need a way to inform the application when a Netscape plugin is created or deleted
        https://bugs.webkit.org/show_bug.cgi?id=30179

        Added "c" style static methods for the application to hook up for
        receiving notifications when a plugin is created or destroyed.

        * Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-16 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Fri, 16 Oct 2009 12:47:17 +0000 (12:47 +0000)]
2009-10-16  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Eric Seidel.

        Added test case for testing navigator.language.
        https://bugs.webkit.org/show_bug.cgi?id=29653

        Different browsers may not return the exact same result.
        Some examples here:
        Safari 4 WinXP: "en-US"
        Safari 4 Mac: "en-us"
        Firefox 3 Mac/WinXP: "en-US"
        Opera 9.64: "en"
        Epiphany 2 GTK: "en"
        Chrome 3 WinXP: "en-US"

        The test case checks if the first two letters are "en"
        when system locale is set to "en_US.iso88591".

        * fast/js/navigator-language-expected.txt: Added.
        * fast/js/navigator-language.html: Added.
2009-10-16  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Eric Seidel.

        Default language translation should be determined by locale settings,
        e.g., "en-US".
        https://bugs.webkit.org/show_bug.cgi?id=29653

        Test: fast/js/navigator-language.html

        * platform/qt/Localizations.cpp:
        (WebCore::defaultLanguage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCrash fix when loading NPAPI plugins on Qt/Mac
vestbo@webkit.org [Fri, 16 Oct 2009 10:35:43 +0000 (10:35 +0000)]
Crash fix when loading NPAPI plugins on Qt/Mac

Reviewed by Ariya Hidayat.

There's no guarantee that the plist will be valid even if we
ask the plugin to create it. Crash obverved with iGetter.

* plugins/mac/PluginPackageMac.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix for Chromium/skia's implementation of canvas's isPointInPath().
senorblanco@chromium.org [Fri, 16 Oct 2009 06:46:27 +0000 (06:46 +0000)]
Fix for Chromium/skia's implementation of canvas's isPointInPath().
https://bugs.webkit.org/show_bug.cgi?id=30402

Reviewed by David Levin.

Covered by LayoutTests/fast/canvas/pointInPath.html.

* platform/graphics/skia/SkiaUtils.cpp:
(WebCore::SkPathContainsPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Fri, 16 Oct 2009 06:42:35 +0000 (06:42 +0000)]
2009-10-15  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Levin.

        Add mod_pywebsocket to test Web Sockets.
        http://code.google.com/p/pywebsocket/
        https://bugs.webkit.org/show_bug.cgi?id=27490

        * pywebsocket/COPYING: Added.
        * pywebsocket/MANIFEST.in: Added.
        * pywebsocket/README: Added.
        * pywebsocket/example/echo_client.py: Added.
        * pywebsocket/example/echo_wsh.py: Added.
        * pywebsocket/mod_pywebsocket/__init__.py: Added.
        * pywebsocket/mod_pywebsocket/dispatch.py: Added.
        * pywebsocket/mod_pywebsocket/handshake.py: Added.
        * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
        * pywebsocket/mod_pywebsocket/msgutil.py: Added.
        * pywebsocket/mod_pywebsocket/standalone.py: Added.
        * pywebsocket/mod_pywebsocket/util.py: Added.
        * pywebsocket/setup.py: Added.
        * pywebsocket/test/config.py: Added.
        * pywebsocket/test/mock.py: Added.
        * pywebsocket/test/run_all.py: Added.
        * pywebsocket/test/test_dispatch.py: Added.
        * pywebsocket/test/test_handshake.py: Added.
        * pywebsocket/test/test_mock.py: Added.
        * pywebsocket/test/test_msgutil.py: Added.
        * pywebsocket/test/test_util.py: Added.
        * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
        * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
        * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
        * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
        * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
        * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
        * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
        * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 16 Oct 2009 05:32:24 +0000 (05:32 +0000)]
2009-10-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Factor ResourceLoadNotifier out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30379

        These methods have virtually no interaction with the rest of
        FrameLoader.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * dom/Document.cpp:
        (WebCore::Document::resourceRetrievedByXMLHttpRequest):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
        (WebCore::ResourceLoadNotifier::ResourceLoadNotifier):
        (WebCore::ResourceLoadNotifier::activeDocumentLoader):
        (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
        (WebCore::ResourceLoadNotifier::willSendRequest):
        (WebCore::ResourceLoadNotifier::didReceiveResponse):
        (WebCore::ResourceLoadNotifier::didReceiveData):
        (WebCore::ResourceLoadNotifier::didFailToLoad):
        (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest):
        (WebCore::FrameLoader::sendRemainingDelegateMessages):
        (WebCore::FrameLoader::requestFromDelegate):
        (WebCore::ResourceLoadNotifier::didFinishLoad):
        (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
        (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
        (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest):
        (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
        (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::notifier):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::receivedError):
        * loader/ResourceLoadNotifier.cpp: Added.
        (WebCore::ResourceLoadNotifier::ResourceLoadNotifier):
        (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
        (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
        (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
        (WebCore::ResourceLoadNotifier::willSendRequest):
        (WebCore::ResourceLoadNotifier::didReceiveResponse):
        (WebCore::ResourceLoadNotifier::didReceiveData):
        (WebCore::ResourceLoadNotifier::didFinishLoad):
        (WebCore::ResourceLoadNotifier::didFailToLoad):
        (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest):
        (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest):
        (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
        (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
        (WebCore::ResourceLoadNotifier::activeDocumentLoader):
        * loader/ResourceLoadNotifier.h: Added.
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::willSendRequest):
        (WebCore::ResourceLoader::didReceiveResponse):
        (WebCore::ResourceLoader::didReceiveData):
        (WebCore::ResourceLoader::didFinishLoadingOnePart):
        (WebCore::ResourceLoader::didFail):
        (WebCore::ResourceLoader::didCancel):
        (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
        (WebCore::ResourceLoader::didCancelAuthenticationChallenge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Roland Steiner <rolandsteiner@google.com>
eric@webkit.org [Fri, 16 Oct 2009 05:19:42 +0000 (05:19 +0000)]
2009-10-15  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by Darin Fisher.

        Bug 30427 -  Remove unneeded methods in ChromiumDataObject
        (https://bugs.webkit.org/show_bug.cgi?id=30427)

        Remove no longer needed methods from ChromiumDataObject.

        No new tests (no functional change)

        * platform/chromium/ChromiumDataObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 James Robinson <jamesr@google.com>
eric@webkit.org [Fri, 16 Oct 2009 05:03:43 +0000 (05:03 +0000)]
2009-10-15  James Robinson  <jamesr@google.com>

        Reviewed by David Levin.

        Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.

        https://bugs.webkit.org/show_bug.cgi?id=30426

        * Scripts/modules/cpp_style.py:
        * Scripts/modules/cpp_style_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Fri, 16 Oct 2009 01:27:33 +0000 (01:27 +0000)]
2009-10-15  Daniel Bates  <dbates@webkit.org>

        No review, rolling out r49644.
        http://trac.webkit.org/changeset/49644

        We need to think about this change some more. See bug #30418
        for more details.

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canEvaluate):
        (WebCore::XSSAuditor::canEvaluateJavaScriptURL):
        (WebCore::XSSAuditor::canCreateInlineEventListener):
        (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
        (WebCore::XSSAuditor::canLoadObject):
        (WebCore::XSSAuditor::canSetBaseElementURL):
        (WebCore::XSSAuditor::findInRequest):
        * page/XSSAuditor.h:
2009-10-15  Daniel Bates  <dbates@webkit.org>

        No review, rolling out r49644.
        http://trac.webkit.org/changeset/49644

        * http/tests/security/xssAuditor/base-href-comment-expected.txt: Removed.
        * http/tests/security/xssAuditor/base-href-comment.html: Removed.
        * http/tests/security/xssAuditor/iframe-javascript-url-comment-expected.txt: Removed.
        * http/tests/security/xssAuditor/iframe-javascript-url-comment.html: Removed.
        * http/tests/security/xssAuditor/img-onerror-HTML-comment-expected.txt: Removed.
        * http/tests/security/xssAuditor/img-onerror-HTML-comment.html: Removed.
        * http/tests/security/xssAuditor/img-onerror-comment-expected.txt: Removed.
        * http/tests/security/xssAuditor/img-onerror-comment.html: Removed.
        * http/tests/security/xssAuditor/object-tag-comment-expected.txt: Removed.
        * http/tests/security/xssAuditor/object-tag-comment.html: Removed.
        * http/tests/security/xssAuditor/resources/echo-before-image.pl: Removed.
        * http/tests/security/xssAuditor/resources/echo-head-base-href-comment.pl: Removed.
        * http/tests/security/xssAuditor/script-tag-comment-HTML-entity-expected.txt: Removed.
        * http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html: Removed.
        * http/tests/security/xssAuditor/script-tag-comment-expected.txt: Removed.
        * http/tests/security/xssAuditor/script-tag-comment.html: Removed.
        * http/tests/security/xssAuditor/script-tag-with-source-comment-expected.txt: Removed.
        * http/tests/security/xssAuditor/script-tag-with-source-comment.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Adele Peterson.
bweinstein@apple.com [Thu, 15 Oct 2009 23:44:57 +0000 (23:44 +0000)]
Rubber-stamped by Adele Peterson.

Update Windows expected results after http://trac.webkit.org/changeset/49619.

* platform/win/fast/inline: Added.
* platform/win/fast/inline/dirtyLinesForInline-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd SPI to determine whether a node is a halted plug-in.
jhoneycutt@apple.com [Thu, 15 Oct 2009 23:22:52 +0000 (23:22 +0000)]
Add SPI to determine whether a node is a halted plug-in.

Part of <rdar://problem/7273354> Halted plug-ins should restart on
mouseover

https://bugs.webkit.org/show_bug.cgi?id=30151

Reviewed by Darin Adler.

WebCore:

* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
Initialize m_isHalted.

* plugins/PluginView.h:
(WebCore::PluginView::isHalted):
Return m_isHalted.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::halt):
Set m_isHalted to true.
(WebCore::PluginView::restart):
clear m_isHalted.

WebKit/win:

* Interfaces/IWebViewPrivate.idl:
Add isNodehaltedPlugin().

* WebView.cpp:
(WebView::isNodeHaltedPlugin):
From the IDOMNode, query for the DOMNode. From the DOMNode, get the
WebCore::Node. Get the node's renderer, and check whether it is a
RenderWidget. If so, get its Widget, and check whether it's a
PluginView. If so, return the result of PluginView::isHalted().

* WebView.h:
Declare isNodeHaltedPlugin().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Thu, 15 Oct 2009 23:17:59 +0000 (23:17 +0000)]
2009-10-15  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [GTK] marshal stamp files are not cleaned after a distclean
        https://bugs.webkit.org/show_bug.cgi?id=30156

        Add stamp-po to CLEANFILES.

        * GNUmakefile.am:

2009-10-15  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [GTK] marshal stamp files are not cleaned after a distclean
        https://bugs.webkit.org/show_bug.cgi?id=30156

        Add the stamp files directly to cleanfiles. Also rearrange the
        variable declarations so we don't miss any files that need to be
        cleaned up during the clean targets.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes <http://webkit.org/b/30411>.
bweinstein@apple.com [Thu, 15 Oct 2009 23:00:34 +0000 (23:00 +0000)]
Fixes <http://webkit.org/b/30411>.
REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.

Reviewed by Adam Roben.

Added a check for isChromium() in pdevenv, and pass /useenv if we are not
building Chromium.

* Scripts/pdevenv:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 21:55:36 +0000 (21:55 +0000)]
2009-10-15  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: skip inspector tests on windows until
        incremental build catches frontend files.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 15 Oct 2009 21:54:49 +0000 (21:54 +0000)]
2009-10-15  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Oliver Hunt.

        [Qt] Build fix for QtWebKit after r49649.

        Change JSC::HasNonDefaultMark to OverridesMarkChildren in createStructure function.

        * bridge/qt/qt_runtime.h:
        (JSC::Bindings::QtRuntimeMethod::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Thu, 15 Oct 2009 21:53:16 +0000 (21:53 +0000)]
2009-10-15  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Darin Adler.

        Fix media layout test file ordering so both branded and unbranded builds of Chromium will pass layout tests.

        https://bugs.webkit.org/show_bug.cgi?id=30369

        * media/media-file.js: Fixed file ordering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Thu, 15 Oct 2009 21:37:54 +0000 (21:37 +0000)]
Reviewed by Kevin Ollivier.

Update the wxPython simple.py sample to match current wxWebKit API.

https://bugs.webkit.org/show_bug.cgi?id=30406

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 21:31:06 +0000 (21:31 +0000)]
2009-10-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Prevent subsequent tests from failing upon inspector
        test timeout.

        https://bugs.webkit.org/show_bug.cgi?id=30404

        * inspector/evaluate-in-frontend.js:
        (onload.setTimeout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Thu, 15 Oct 2009 21:27:02 +0000 (21:27 +0000)]
Reviewed by Kevin Ollivier.

Add Mac package building scripts for wx.

https://bugs.webkit.org/show_bug.cgi?id=30405

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 15 Oct 2009 21:11:53 +0000 (21:11 +0000)]
2009-10-15  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/7306052> Fullscreen max/min volume buttons non-functional

        * WebView/WebVideoFullscreenHUDWindowController.mm:
        (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Set volume buttons target and action.
        (-[WebVideoFullscreenHUDWindowController decrementVolume:]): New, decrement the volume by 10%.
        (-[WebVideoFullscreenHUDWindowController incrementVolume:]): New, increment the volume by 10%.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Thu, 15 Oct 2009 21:01:54 +0000 (21:01 +0000)]
2009-10-15  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Eric Seidel.

        [Gtk][Layout tests] Generate results for dom tests
        https://bugs.webkit.org/show_bug.cgi?id=29893

        Add results for dom tests and enable these tests in the Skipped.

        * platform/gtk/Skipped:
        * platform/gtk/dom/xhtml/level3/core/canonicalform08-expected.txt: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.txt.
        * platform/gtk/dom/xhtml/level3/core/canonicalform09-expected.txt: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform09-expected.txt.
        * platform/gtk/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodelookupprefix19-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Thu, 15 Oct 2009 20:39:43 +0000 (20:39 +0000)]
2009-10-15  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=24731
        And
        rdar://problem/5015961

        Implements support for DHTML drag-and-drop operations (i.e. ondragstart, ondragend)
        in the Windows build so that it conforms to the Mac OS X build. Hence, dropEffect is
        correctly set.

        The WebView and WebDropSource drag-and-drop functions, as called by function
        DoDragDrop in its event loop, neither used the drop effect as specified by
        event.dataTransfer.dropEffect nor respected event.dataTransfer.effectsAllowed.
        Instead, these functions defaulted to some hardcoded drop effect and set of
        allowed drop effects, respectively.

        Tests: fast/events/drag-and-drop.html

        * WebCoreSupport/WebDragClient.cpp:
        (WebDragClient::startDrag):
        * WebDropSource.cpp:
        (WebDropSource::QueryContinueDrag): Moved call to EventHandler::dragSourceEndedAt
        into method WebDragClient::startDrag.
        * WebDropSource.h:
        * WebView.cpp:
        (WebView::keyStateToDragOperation): Fixes <rdar://problem/5015961>. Determines
        appropriate drop effect from state of keyboard and allowed effects
        m_page->dragController()->sourceDragOperation().
        (WebView::DragEnter):
        (WebView::DragOver):
        (WebView::Drop):
        * WebView.h:
2009-10-15  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=24731
        And
        rdar://problem/5015961

        Tests that DHTML drag-and-drop works correctly.

        Note, this test fails when effectAllowed == "uninitialized" because
        this effect has not been implemented yet (see bug #30291).

        * fast/events/drag-and-drop-expected.txt: Added.
        * fast/events/drag-and-drop.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 20:34:02 +0000 (20:34 +0000)]
2009-10-15  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed - build fix.

        Web Inspector: add file missing in r49648

        * inspector/front-end/TestController.js: Added.
        (WebInspector.TestController):
        (WebInspector.TestController.prototype.waitUntilDone):
        (WebInspector.TestController.prototype.notifyDone):
        (WebInspector.evaluateForTestInFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake typeinfo flags default to false
oliver@apple.com [Thu, 15 Oct 2009 19:55:09 +0000 (19:55 +0000)]
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372

Reviewed by Darin Adler

Part 2 -- Reverse the TypeInfo HasDefaultMark flag to OverridesMarkChildren, etc

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 19:51:46 +0000 (19:51 +0000)]
2009-10-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: introduce test controller with waitUntilDone
        on frontend side.

        https://bugs.webkit.org/show_bug.cgi?id=30400

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/TestController.js: Added.
        (WebInspector.TestController):
        (WebInspector.TestController.prototype.waitUntilDone):
        (WebInspector.TestController.prototype.notifyDone):
        (WebInspector.evaluateForTestInFrontend):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 15 Oct 2009 19:28:31 +0000 (19:28 +0000)]
2009-10-15  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Protect WebSocket calls in case the feature is not compiled in.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Zan Dobersek <zandobersek@gmail.com>
kov@webkit.org [Thu, 15 Oct 2009 19:28:06 +0000 (19:28 +0000)]
2009-10-15  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        Rebaseline tests after changes made in r49405.

        * platform/gtk/editing/execCommand/4916541-expected.txt: Rebaseline.
        * platform/gtk/editing/execCommand/5138441-expected.txt: Ditto.
        * platform/gtk/editing/execCommand/5481523-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 15 Oct 2009 19:11:31 +0000 (19:11 +0000)]
2009-10-15  Xan Lopez  <xlopez@igalia.com>

        Remove obsolete test from Skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Thu, 15 Oct 2009 19:04:57 +0000 (19:04 +0000)]
2009-10-15  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27895

        Fixes an issue in which injecting an inline event handler whose value ends in a single-line
        JavaScript comment can bypass the XSSAuditor. Similarly fixes this issue with respect to
        the HTML Base element, HTML Object element, inline and external script tags, and
        JavaScript multi-line variants of all of these attacks.

        Tests: http/tests/security/xssAuditor/base-href-comment.html
               http/tests/security/xssAuditor/iframe-javascript-url-comment.html
               http/tests/security/xssAuditor/img-onerror-HTML-comment.html
               http/tests/security/xssAuditor/img-onerror-comment.html
               http/tests/security/xssAuditor/object-tag-comment.html
               http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html
               http/tests/security/xssAuditor/script-tag-comment.html
               http/tests/security/xssAuditor/script-tag-with-source-comment.html

        * page/XSSAuditor.cpp: Added constant minAttackLength.
        (WebCore::XSSAuditor::canEvaluate):
        (WebCore::XSSAuditor::canEvaluateJavaScriptURL):
        (WebCore::XSSAuditor::canCreateInlineEventListener):
        (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
        (WebCore::XSSAuditor::canLoadObject):
        (WebCore::XSSAuditor::canSetBaseElementURL):
        (WebCore::XSSAuditor::findInRequest): Added parameter context. Only looks at up
        to minAttackLength of script code plus context (if any).
        * page/XSSAuditor.h:
2009-10-15  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27895

        Tests that inline event handlers whose value ends in a single-line JavaScript
        comment cannot bypass the XSSAuditor. Also tests that the XSSAuditor prevents
        similar attack vectors with respect to the HTML Base element, HTML Object
        element, and external JavaScripts.

        * http/tests/security/xssAuditor/base-href-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/base-href-comment.html: Added.
        * http/tests/security/xssAuditor/iframe-javascript-url-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/iframe-javascript-url-comment.html: Added.
        * http/tests/security/xssAuditor/img-onerror-HTML-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/img-onerror-HTML-comment.html: Added.
        * http/tests/security/xssAuditor/img-onerror-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/img-onerror-comment.html: Added.
        * http/tests/security/xssAuditor/object-tag-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/object-tag-comment.html: Added.
        * http/tests/security/xssAuditor/resources/echo-before-image.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-head-base-href-comment.pl: Added.
        * http/tests/security/xssAuditor/script-tag-comment-HTML-entity-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html: Added.
        * http/tests/security/xssAuditor/script-tag-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-comment.html: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-comment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/gtk
kov@webkit.org [Thu, 15 Oct 2009 18:42:11 +0000 (18:42 +0000)]
WebKit/gtk

2009-10-15  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        Add a settings to enable support for experimental Web Sockets.
        Currently this comes in handy in layout tests.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):

WebKitTools

2009-10-15  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        Enable Web Sockets support when running layout tests.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Make QGLauncher's WebPage class constructor to get a QObject* as parent (not...
tonikitoo@webkit.org [Thu, 15 Oct 2009 18:21:08 +0000 (18:21 +0000)]
[Qt] Make QGLauncher's WebPage class constructor to get a QObject* as parent (not QWidget*).

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-15
Rubberstamped by Tor Arne.

* QGVLauncher/main.cpp:
(WebPage::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-08 Adam Langley <agl@google.com>
agl@chromium.org [Thu, 15 Oct 2009 18:16:38 +0000 (18:16 +0000)]
2009-10-08  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Currently, Skia clip paths are 1-bit. This patch makes our path
        clipping anti-aliased for non-canvas drawing.

        http://code.google.com/p/chromium/issues/detail?id=5927
        https://bugs.webkit.org/show_bug.cgi?id=28820
        http://www.imperialviolet.org/2009/09/02/anti-aliased-clipping.html

        Already covered by layout tests. New baselines will be needed in the
        Chromium tree.

        (Reland. First landed in r49329, reverted in r49330 due to Windows
        build break)

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::clip):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::canvasClip):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::canvasClip):
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        (WebCore::GraphicsContext::canvasClip):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::canvasClip):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::addInnerRoundedRectClip):
        (WebCore::GraphicsContext::clip):
        (WebCore::GraphicsContext::canvasClip):
        (WebCore::GraphicsContext::clipPath):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::clipPathAntiAliased):
        (PlatformContextSkia::restore):
        (PlatformContextSkia::applyAntiAliasedClipPaths):
        * platform/graphics/skia/PlatformContextSkia.h:
        * platform/graphics/win/GraphicsContextWin.cpp:
        (WebCore::GraphicsContext::canvasClip):
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::canvasClip):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::canvasClip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Adele Peterson.
bweinstein@apple.com [Thu, 15 Oct 2009 17:55:10 +0000 (17:55 +0000)]
Rubber-stamped by Adele Peterson.

Add click-focus-anchor expected results on Windows, to make up for
the wonky way Windows finds its expected results.

* platform/win/fast/events/click-focus-anchor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 15 Oct 2009 17:53:02 +0000 (17:53 +0000)]
2009-10-15  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Help text fix - Web Sockets default is no, not yes.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 15 Oct 2009 17:42:15 +0000 (17:42 +0000)]
2009-10-15  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Need to initialize event.button.button, since in most cases a
        button number is not passed as an argument.

        * DumpRenderTree/gtk/EventSender.cpp:
        (mouseDownCallback):
        (mouseUpCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Andras Becsi <becsi.andras@stud.u-szeged.hu>
zoltan@webkit.org [Thu, 15 Oct 2009 17:33:17 +0000 (17:33 +0000)]
2009-10-15  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Adam Treat.

        [Qt] Add expected files for passing http tests.

        * platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt: Added.
        * platform/qt/http/tests/uri/css-href-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 15 Oct 2009 17:32:02 +0000 (17:32 +0000)]
2009-10-15  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7295738> No way to mute/unmute a movie in full screen video mode

        * WebCore.Video.exp: Export muted and setMute.

2009-10-15  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7295738> No way to mute/unmute a movie in full screen video mode

        * WebView/WebVideoFullscreenHUDWindowController.mm:
        (-[WebVideoFullscreenHUDWindowController setVolume:]): Unmute movie before changing volume.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Andras Becsi <becsi.andras@stud.u-szeged.hu>
zoltan@webkit.org [Thu, 15 Oct 2009 17:26:10 +0000 (17:26 +0000)]
2009-10-15  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Adam Treat.

        [Qt] Add expected files for passing svg tests.

        * platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Added.
        * platform/qt/svg/custom/mask-with-default-value-expected.txt: Added.
        * platform/qt/svg/filters/feComposite-expected.txt: Added.
        * platform/qt/svg/filters/feGaussianBlur-expected.txt: Added.
        * platform/qt/svg/filters/feMerge-wrong-input-expected.txt: Added.
        * platform/qt/svg/filters/sourceAlpha-expected.txt: Added.
        * platform/qt/svg/filters/subRegion-in-userSpace-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] QGLauncher crashes while closing a window
tonikitoo@webkit.org [Thu, 15 Oct 2009 17:14:13 +0000 (17:14 +0000)]
[Qt] QGLauncher crashes while closing a window
https://bugs.webkit.org/show_bug.cgi?id=30385

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-15
Reviewed by Tor Arne.

Set page's pageClient reference to '0' at QGWV deletion.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::~QGraphicsWebView):
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(WebPage::WebPage):
(WebPage::aborting):
(tst_QGraphicsWebView::crashOnViewlessWebPages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 15 Oct 2009 16:52:51 +0000 (16:52 +0000)]
2009-10-15  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Transitions fail to run sometimes
        https://bugs.webkit.org/show_bug.cgi?id=26770

        Fix an issue where we could attempt to start accelerated animations or transitions on
        GraphicsLayer that were not rooted (because of visibility:hidden), which would leave
        the AnimationController's m_waitingForResponse flag in a state that killed subsequent
        software transitions.

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
        (WebCore::AnimationControllerPrivate::endAnimationUpdate):
        (WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
        (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
        (WebCore::AnimationControllerPrivate::startTimeResponse):
        * page/animation/AnimationControllerPrivate.h:
        Make some methods non-inline for ease of debugging (these are not hot methods).
        Rename m_waitingForAResponse to m_waitingForResponse.

        * platform/graphics/GraphicsLayer.h:
        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::hasAncestor):
        New method to report whether the receiver has the given layer as an ancestor. Used for checking
        whether a layer is rooted.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::startAnimation):
        (WebCore::RenderLayerBacking::startTransition):
        Don't try to start accelerated animations or transitions on non-rooted GraphicsLayers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Thu, 15 Oct 2009 16:50:23 +0000 (16:50 +0000)]
2009-10-15  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Refactor ProfilesPanel to support multiple profile types

        Data describing different profile types are now stored in distinct objects.
        https://bugs.webkit.org/show_bug.cgi?id=30332

        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ProfileView.js:
        (WebInspector.CPUProfileView.profileCallback):
        (WebInspector.CPUProfileView):
        (WebInspector.CPUProfileView.prototype._sortData):
        (WebInspector.CPUProfileType):
        (WebInspector.CPUProfileType.prototype.get buttonTooltip):
        (WebInspector.CPUProfileType.prototype.get buttonStyle):
        (WebInspector.CPUProfileType.prototype.buttonClicked):
        (WebInspector.CPUProfileType.prototype.setRecordingProfile):
        (WebInspector.CPUProfile):
        (WebInspector.CPUProfile.prototype.get title):
        (WebInspector.CPUProfile.prototype.get uid):
        (WebInspector.CPUProfile.prototype.get head):
        (WebInspector.CPUProfile.prototype.createView):
        (WebInspector.CPUProfile.prototype.viewForProfile):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfileType):
        (WebInspector.ProfileType.prototype.get buttonTooltip):
        (WebInspector.ProfileType.prototype.get buttonStyle):
        (WebInspector.ProfileType.prototype.get buttonCaption):
        (WebInspector.ProfileType.prototype.get id):
        (WebInspector.ProfileType.prototype.get name):
        (WebInspector.ProfileType.prototype.buttonClicked):
        (WebInspector.ProfilesPanel):
        (WebInspector.ProfilesPanel.prototype.get statusBarItems.clickHandler):
        (WebInspector.ProfilesPanel.prototype.get statusBarItems):
        (WebInspector.ProfilesPanel.prototype.reset):
        (WebInspector.ProfilesPanel.prototype.registerProfileType):
        (WebInspector.ProfilesPanel.prototype._makeKey):
        (WebInspector.ProfilesPanel.prototype.addProfileHeader):
        (WebInspector.ProfilesPanel.prototype.showProfile):
        (WebInspector.ProfilesPanel.prototype.getProfileType):
        (WebInspector.ProfilesPanel.prototype.showProfileForURL):
        (WebInspector.ProfilesPanel.prototype.updateProfileTypeButtons):
        (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
        (WebInspector.ProfilesPanel.prototype.get searchableViews):
        (WebInspector.ProfilesPanel.prototype._updateInterface):
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):
        (WebInspector.documentClick.followLink):
        (WebInspector.documentClick):
        (WebInspector.addProfileHeader):
        (WebInspector.setRecordingProfile):
        (WebInspector.linkifyStringAsFragment):
        (WebInspector.showProfileForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 16:46:46 +0000 (16:46 +0000)]
2009-10-15  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: remove timer-related logs from the previously
        submitted test.

        * inspector/console-tests-expected.txt:
        * inspector/console-tests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
kevino@webkit.org [Thu, 15 Oct 2009 16:21:15 +0000 (16:21 +0000)]
wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
the OS if none was explicitly set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 16:16:22 +0000 (16:16 +0000)]
2009-10-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Enable inspector layout tests.

        https://bugs.webkit.org/show_bug.cgi?id=30014

WebCore:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::evaluateForTestInFrontend):

LayoutTests:
        * inspector/elements-panel-structure-expected.txt:
        * inspector/elements-panel-structure.html:
        * inspector/evaluate-in-frontend.js:
        (evaluateInWebInspector):
        (window.didEvaluateForTestInFrontend):
        * platform/mac-leopard/Skipped:
        * platform/mac-snowleopard/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49629 268f45cc-cd09-0410-ab3c-d52691b4dbfc