commit-queue@webkit.org [Fri, 20 Sep 2013 16:18:10 +0000 (16:18 +0000)]
AX: WebArea claims to have a subrole, but always returns nil.
https://bugs.webkit.org/show_bug.cgi?id=121658
Patch by Sam White <samuel_white@apple.com> on 2013-09-20
Reviewed by Chris Fleizach.
Source/WebCore:
No new tests, updated existing AXWebArea related test to reflect unused attribute removal.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
LayoutTests:
Updated test output to reflect removal of unused NSAccessibilitySubroleAttribute in AXWebArea.
* platform/mac/accessibility/document-attributes-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Sep 2013 15:47:24 +0000 (15:47 +0000)]
[GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
https://bugs.webkit.org/show_bug.cgi?id=121294
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-09-20
Reviewed by Martin Robinson.
Provide a new patch to deal with the issue in the GTK+ module from
the internal jhbuild environment. This issue has been reported
upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
* gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
* gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Fri, 20 Sep 2013 15:34:19 +0000 (15:34 +0000)]
Add valueForLength/minimumValueForLength wrappers to RenderElement.
<https://webkit.org/b/121676>
Reviewed by Antti Koivisto.
Add two inline wrappers for these functions so we don't have to pass
the RenderView everywhere.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Sep 2013 15:20:32 +0000 (15:20 +0000)]
[ATK][WTR] accessibility/aria-invalid.html times out
https://bugs.webkit.org/show_bug.cgi?id=121668
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.
Tools:
Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
false in case of aria-invalid event with empty value.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
case of aria-invalid event with empty value.
LayoutTests:
Updated the expectation of aria-invalid.html test, which was timing out
before bug 120421 and this fix.
* platform/gtk-wk2/TestExpectations: Removed aria-invalid.html because
it now passes with this fix and the patch from bug 120421.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Sep 2013 15:15:22 +0000 (15:15 +0000)]
[ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
https://bugs.webkit.org/show_bug.cgi?id=120421
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.
Implemented the notification listener for AccessibilityUIElement for
WebKitTestRunner. The signal is generated by
AXObjectCache::postPlatformNotification() and received by
axObjectEventListener(). axObjectEventListener() will then invoke
JSObjectCallAsFunction() with the respective callback function. The
notification handlers are stored in HashMap in
AccessibilityNotificationHandlerAtk.cpp.
Moved ATK signal handling (printAccessibilityEvent and
axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
* WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
include path.
* WebKitTestRunner/GNUmakefile.am:
Added AccessibilityNotificationHandlerAtk.cpp/h.
* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
listener IDs to AccessibilityNotificationHandlerAtk.cpp.
* WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
listener IDs to AccessibilityNotificationHandlerAtk.cpp.
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
notification handler for GTK+ and EFL.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
Moved printAccessibilityEvent and axObjectEventListener to
AccessibilityNotificationHandlerAtk.cpp.
(WTR::AccessibilityController::logAccessibilityEvents): Moved listener
IDs to AccessibilityNotificationHandlerAtk.cpp.
(WTR::AccessibilityController::resetToConsistentState): Moved listener
IDs to AccessibilityNotificationHandlerAtk.cpp.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
(WTR::printAccessibilityEvent): Prints accessibility events. This
function was moved from AccessibilityControllerAtk.cpp.
(WTR::axObjectEventListener): Callback for signals. This function was
moved from AccessibilityControllerAtk.cpp.
(WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
Initialize element and function callback.
(WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
Removes handler from HashMap and disconnects callbacks if necessary.
(WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
logging mode and connects callbacks.
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
Sets the notification callback and connects callback to signals.
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
Removes the notification callback from HashMap.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connects axObjectEventListener to ATK signals.
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Disconnects callback.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
(WTR::AccessibilityNotificationHandler::create): Creates a new instance
of AccessibilityNotificationHandler.
(WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
element.
(WTR::AccessibilityNotificationHandler::platformElement): Gets the
element.
(WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
Gets the notification callback.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::addNotificationListener): Creates
notification handler, set the platform element and the notification
callback.
(WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
notification handler.
* WebKitTestRunner/PlatformEfl.cmake:
Added AccessibilityNotificationHandlerAtk.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 20 Sep 2013 15:04:07 +0000 (15:04 +0000)]
[GTK] Fix some small style issues in the bindings
https://bugs.webkit.org/show_bug.cgi?id=121613
Reviewed by Carlos Garcia Campos.
* bindings/scripts/CodeGeneratorGObject.pm: When printing the license
header use the more common comment style within the WebKit project.
(GenerateProperty): Indent property definitions according to WebKit style, improve
the nick and blurb properties, and improve the various parameter spec argument layout.
(GenerateFunction): Remove the newline from function signatures to match WebKit style.
* bindings/scripts/test/GObject: Update bindings test results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zarvai@inf.u-szeged.hu [Fri, 20 Sep 2013 14:58:52 +0000 (14:58 +0000)]
[Qt] Unreviewed gardening. Rebase after Qt 5.1.1 and skip failing tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20
* platform/qt-wk1/TestExpectations:
* platform/qt-wk2/TestExpectations:
* platform/qt-wk2/fast/forms/submit-to-blank-multiple-times-expected.txt: Added.
* platform/qt/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Sep 2013 14:43:15 +0000 (14:43 +0000)]
Modified img src and srcset encoded URL tests
https://bugs.webkit.org/show_bug.cgi?id=121677
Previous tests have broken the Windows builds, since '?' is not a valid char.
Moved to using '@'
Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-20
Reviewed by Anders Carlsson.
* fast/hidpi/image-srcset-encoded-expected.txt: Renamed from LayoutTests/fast/hidpi/image-srcset-question-mark-expected.txt.
* fast/hidpi/image-srcset-encoded.html: Renamed from LayoutTests/fast/hidpi/image-srcset-question-mark.html.
* fast/hidpi/resources/image@test.png: Renamed from LayoutTests/fast/hidpi/resources/image?test.png.
* fast/loader/image-src-encoded-expected.txt: Renamed from LayoutTests/fast/loader/image-src-question-mark-expected.txt.
* fast/loader/resources/image@test.png: Renamed from LayoutTests/fast/loader/resources/image?test.png.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zarvai@inf.u-szeged.hu [Fri, 20 Sep 2013 14:12:02 +0000 (14:12 +0000)]
[Qt] Unreviewed gardening. Update tests after r156066 and r156083.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20
* platform/qt-wk1/fast/forms/HTMLOptionElement_label06-expected.png: Added r156083.
* platform/qt-wk1/fast/forms/HTMLOptionElement_label06-expected.txt: Added r156083.
* platform/qt-wk1/fast/forms/HTMLOptionElement_label07-expected.png: Added r156083.
* platform/qt-wk1/fast/forms/HTMLOptionElement_label07-expected.txt: Added r156083.
* platform/qt-wk1/fast/forms/form-element-geometry-expected.png: Added r156083.
* platform/qt-wk1/fast/forms/form-element-geometry-expected.txt: Added r156083.
* platform/qt-wk1/fast/forms/menulist-separator-painting-expected.txt: Added r156083.
* platform/qt-wk1/fast/forms/select-baseline-expected.png: Added r156083.
* platform/qt-wk1/fast/forms/select-baseline-expected.txt: Added r156083.
* platform/qt-wk1/fast/forms/selectlist-minsize-expected.txt: Added r156083.
* platform/qt-wk1/fast/replaced/three-selects-break-expected.txt: Added r156083.
* platform/qt-wk1/js/dom/switch-behaviour-expected.txt: Added r156066.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 20 Sep 2013 13:23:25 +0000 (13:23 +0000)]
[CMake] Use COMPILE_DEFINITIONS target property for setting BUILDING_* defines
https://bugs.webkit.org/show_bug.cgi?id=121672
Reviewed by Gyuyoung Kim.
Since the scope of add_definitions() is always a whole file, we need to use
target properties instead to set definitions only for specific targets.
Source/JavaScriptCore:
* CMakeLists.txt:
Source/WebCore:
* CMakeLists.txt:
Source/WebKit:
* CMakeLists.txt:
Source/WTF:
* wtf/CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 20 Sep 2013 13:17:07 +0000 (13:17 +0000)]
Source/WebCore: Make "autoscroll for drag'n drop" a setting
https://bugs.webkit.org/show_bug.cgi?id=121559
Reviewed by Ryosuke Niwa.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>
Currently, there is a ChromeClient hook to make the
feature opt'ed-in or out. That makes it harder to test the
feature on ports that do not enable it, e.g. Mac/WebKit2 port.
However, Mac/WebKit2 is the port that has the best drag'n drop
WTR implementation.
Patch changes the toggle on/off mechanism to be a setting,
and exposes it through InternalSetting interface for testing.
* page/AutoscrollController.cpp:
(WebCore::AutoscrollController::updateDragAndDrop):
* page/ChromeClient.h:
* page/Settings.in:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setAutoscrollForDragAndDropEnabled):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:
LayoutTests: Make "autoscroll" for drag'n drop a setting
https://bugs.webkit.org/show_bug.cgi?id=121559
* fast/events/drag-and-drop-autoscroll.html:
Adapts the test so that is toggles the feature on
via InternalSettings interface.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 20 Sep 2013 13:16:28 +0000 (13:16 +0000)]
StrictTypeChecking extended attribute fails for methods with sequence<T> https://bugs.webkit.org/show_bug.cgi?id=121305
Reviewed by Darin Adler.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>
The extended attribute StrictTypeChecking can not be set to methods if
one of the parameters is a "sequence".
Basically, since "sequence" is not considered a native type
(see function IsNativeType) the Perl code generator tries to
include its supposedly associated header, in this case "JSsequence.h"
Compilation then fails.
It is a problem for bindings including WebGL, where all methods
are supposed to be set as StrictTypeChecking (see bug 44202 [1]). Due to this restriction,
it relaxed, but I would like to bring it back.
Patch fixes the issue by hardening the way includes are auto-added
for methods where StrictTypeChecking extended attribute is present.
Now, only wrapper types (see IsWrapperType) trigger header inclusion,
excluding arrays, sequences, basic types, etc.
[1] https://bugs.webkit.org/show_bug.cgi?id=44202
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/TestObj.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zarvai@inf.u-szeged.hu [Fri, 20 Sep 2013 12:28:36 +0000 (12:28 +0000)]
[Qt] Unreviewed gardening. Update tests after change to Qt 5.1.1
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20
* platform/qt/css1/text_properties/letter_spacing-expected.png:
* platform/qt/css1/text_properties/letter_spacing-expected.txt:
* platform/qt/fast/css/first-line-text-decoration-expected.png:
* platform/qt/fast/css/first-line-text-decoration-expected.txt:
* platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.png:
* platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
* platform/qt/fast/css/word-space-extra-expected.png:
* platform/qt/fast/css/word-space-extra-expected.txt:
* platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:
* platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
* platform/qt/fast/text/basic/003-expected.png:
* platform/qt/fast/text/basic/003-expected.txt:
* platform/qt/fast/text/basic/013-expected.png:
* platform/qt/fast/text/basic/013-expected.txt:
* platform/qt/fast/text/text-letter-spacing-expected.png:
* platform/qt/fast/text/text-letter-spacing-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Fri, 20 Sep 2013 12:16:13 +0000 (12:16 +0000)]
Optimize fetching the Node for never-anonymous renderers.
<https://webkit.org/b/121627>
Reviewed by Antti Koivisto.
Add a RenderObject::nodeForNonAnonymous() that can be used instead
of node() when a renderer is guaranteed non-anonymous.
Use this to implement reference element getters for the various
renderers that are known at compile-time to correspond to a DOM node.
Also renamed existingElement() => element() since using an alternate
name for a reference overload isn't actually necessary.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 20 Sep 2013 11:56:30 +0000 (11:56 +0000)]
Remove duplicated secondsPerDay variables
https://bugs.webkit.org/show_bug.cgi?id=121601
Reviewed by Andreas Kling.
Source/WebCore:
Use secondsPerDay from DateMath.h instead of defining it again.
* history/HistoryItem.cpp:
(WebCore::timeToDay):
Source/WebKit/win:
Use secondsPerDay from DateMath.h instead of defining it again.
* MarshallingHelpers.cpp:
Source/WTF:
Move secondsPerDay from the source into the header file
to make it accessible by other code too.
* wtf/DateMath.cpp:
* wtf/DateMath.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 20 Sep 2013 11:54:46 +0000 (11:54 +0000)]
Fix duplicated loop variable names after r155743
https://bugs.webkit.org/show_bug.cgi?id=121667
Reviewed by Andreas Kling.
Do not use the same name for variables in nested loops to fix a compiler warning.
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
allan.jensen@digia.com [Fri, 20 Sep 2013 11:51:19 +0000 (11:51 +0000)]
Update features.pri
https://bugs.webkit.org/show_bug.cgi?id=121670
Reviewed by Jocelyn Turcotte.
Remove feature flags that no longer exists and new ones added to FeatureList.pm
* qmake/mkspecs/features/features.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 20 Sep 2013 11:44:17 +0000 (11:44 +0000)]
Make RenderObject::parent() return RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121671
Reviewed by Andreas Kling.
Make RenderObject::parent() return RenderElement and adopt everywhere.
Moved addChild/removeChild from RenderObject to RenderElement.
Uninlined a few big RenderObject functions.
Renamed RenderObject::remove() -> RenderObject::removeFromParent()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 20 Sep 2013 11:32:43 +0000 (11:32 +0000)]
Buildfix after r156133 for !ENABLE(WORKERS) platforms
https://bugs.webkit.org/show_bug.cgi?id=121669
Reviewed by Antti Koivisto.
* platform/ThreadGlobalData.cpp:
* platform/ThreadGlobalData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Sep 2013 11:18:05 +0000 (11:18 +0000)]
[GTK][WK2] accessibility/selection-states.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116972
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.
Tools:
isSelectable() was not exposed in Accessibility.
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
LayoutTests:
Unskipping accessibility/selection-states.html test.
* platform/gtk-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 20 Sep 2013 10:58:41 +0000 (10:58 +0000)]
Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638
Unreviewed buildfix after r156144.
* DOMCoreClasses.cpp:
(DOMElement::boundingBox):
(DOMElement::font):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 20 Sep 2013 09:59:37 +0000 (09:59 +0000)]
Make createRenderer() return RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121666
Rubber-stamped by Andreas Kling.
Tighter typing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156147
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 20 Sep 2013 09:52:13 +0000 (09:52 +0000)]
Buildfix for ENABLE(CSS_FILTERS) && !ENABLE(ACCELERATED_COMPOSITING) after r155131.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::enclosingFilterRepaintLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 20 Sep 2013 09:51:53 +0000 (09:51 +0000)]
[WIN] Fix build without precompiled header after r154146.
* platform/win/WebCoreBundleWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 20 Sep 2013 08:59:25 +0000 (08:59 +0000)]
Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638
Reviewed by Andreas Kling.
Also add isRenderElement() test and casting functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156144
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zarvai@inf.u-szeged.hu [Fri, 20 Sep 2013 07:34:56 +0000 (07:34 +0000)]
[Qt] Unreviewed gardening. Rebase tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20
* platform/qt-wk2/fast/css/word-space-extra-expected.png: Added r155957.
* platform/qt/fast/css/pseudo-first-line-border-width-expected.png: Rebase after r155957.
* platform/qt/fast/css/pseudo-first-line-border-width-expected.txt: Rebase after r155957.
* platform/qt/fast/css/word-space-extra-expected.txt: Rebase after r155957.
* platform/qt/fast/forms/select-empty-option-height-expected.txt: Rebase after rr156040.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156143
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 20 Sep 2013 06:08:24 +0000 (06:08 +0000)]
Handle null font families.
Reviewed by Darin Adler.
* platform/graphics/Font.cpp:
(WebCore::computeFontGlyphsCacheHash):
Don't crash when trying to hash null strings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156142
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 20 Sep 2013 05:57:56 +0000 (05:57 +0000)]
Fix a couple mistakes in my recent CSS grammar leak patch
https://bugs.webkit.org/show_bug.cgi?id=121659
Reviewed by Alexey Proskuryakov.
* css/CSSGrammar.y.in: Added initialization to nullptr for some error cases
that were otherwise leaving a bad value for the result of the production.
Also fixed a reversed logical expression.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156141
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Sep 2013 05:02:59 +0000 (05:02 +0000)]
Remove URL decoding in srcset handling
https://bugs.webkit.org/show_bug.cgi?id=121609
Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-19
Reviewed by Benjamin Poulain.
Source/WebCore:
Tests: fast/hidpi/image-srcset-question-mark.html
fast/loader/image-src-question-mark.html
Removed URL decoding from src and srcset's handling algorithm, since they break encoded URLS.
* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseImagesWithScaleFromSrcSetAttribute):
(WebCore::bestFitSourceForImageAttributes):
LayoutTests:
These tests make sure that encoded URLs are properly handled, and especially URLs
with a question mark in them.
* fast/hidpi/image-srcset-question-mark-expected.txt: Added.
* fast/hidpi/image-srcset-question-mark.html: Added.
* fast/hidpi/resources/image?test.png: Added.
* fast/loader/image-src-question-mark-expected.txt: Added.
* fast/loader/image-src-question-mark.html: Added.
* fast/loader/resources/image?test.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156140
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 20 Sep 2013 04:46:59 +0000 (04:46 +0000)]
Avoid calling AtomicString::lower() in makeFontGlyphsCacheKey
https://bugs.webkit.org/show_bug.cgi?id=121656
Reviewed by Darin Adler.
Instead of lower casing AtomicStrings, store the strings as is and use the case folding
hash and case insensitive compare to determine equality.
* platform/graphics/Font.cpp:
(WebCore::operator==):
(WebCore::makeFontGlyphsCacheKey):
(WebCore::computeFontGlyphsCacheHash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 20 Sep 2013 04:29:50 +0000 (04:29 +0000)]
Fix leaks in CSS parser caused by overwriting owned raw pointers with 0
https://bugs.webkit.org/show_bug.cgi?id=121655
Reviewed by Anders Carlsson.
* css/CSSGrammar.y.in: Use nullptr instead of 0. Use unique_ptr instead
of a raw pointer in cases where we might or might not actually keep
the allocated memory. This can still be cleaned up further, but this
should fix the memory leaks we have been seeing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
g.czajkowski@samsung.com [Fri, 20 Sep 2013 04:07:13 +0000 (04:07 +0000)]
Use shouldBecomeEqual in asynchronous spellchecking tests.
https://bugs.webkit.org/show_bug.cgi?id=121483
Reviewed by Darin Adler.
Every asynchronous spellchecking layout test waits for spelling or grammar
markers using setTimeout. It duplicates the code, moreover the implementation
differs in every test.
Use shouldBecomeEqual helper (introduced in r143860) to test spellchecking
asynchronously.
* editing/spelling/grammar-markers-expected.txt:
* editing/spelling/grammar-markers-hidpi-expected.txt:
* editing/spelling/grammar-markers-hidpi.html:
* editing/spelling/grammar-markers.html:
* editing/spelling/grammar-paste-expected.txt:
* editing/spelling/grammar-paste.html:
Dump text of destination element instead of source one to show what is
really tested. It stops outputting that the input and textarea elements
can store html tags, for example,
PASS INPUT has a marker on 'I have a<b>n ki</b>wi'.
* editing/spelling/script-tests/spellcheck-paste.js:
(verifyMarker):
(pasteAndVerify):
* editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
* editing/spelling/spellcheck-paste-continuous-disabled.html:
* editing/spelling/spellcheck-paste-disabled-expected.txt:
* editing/spelling/spellcheck-paste-disabled.html:
At the beginning, those tests check whether spelling marker appears
synchronously. Then, spell checking is disabled to check whether
the markers have disappeared properly.
There is no need to check spelling asynchronously in the second part
of the tests. Use synchronous spellchecking path instead.
* editing/spelling/spellcheck-paste-expected.txt:
* editing/spelling/spelling-marker-description-expected.txt:
* editing/spelling/spelling-marker-description.html:
* platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
* platform/mac/editing/spelling/grammar-markers-expected.png:
* platform/mac/editing/spelling/grammar-markers-hidpi-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@apple.com [Fri, 20 Sep 2013 02:05:21 +0000 (02:05 +0000)]
Unreviewed, rolling out r156120.
http://trac.webkit.org/changeset/156120
https://bugs.webkit.org/show_bug.cgi?id=121651
Broke windows runtime and all tests (Requested by bfulgham on
#webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2013-09-19
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dumpInContext):
* dfg/DFGAssemblyHelpers.cpp: Renamed from Source/JavaScriptCore/jit/AssemblyHelpers.cpp.
(JSC::DFG::AssemblyHelpers::executableFor):
(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
(JSC::DFG::AssemblyHelpers::setSamplingFlag):
(JSC::DFG::AssemblyHelpers::clearSamplingFlag):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
* dfg/DFGAssemblyHelpers.h: Renamed from Source/JavaScriptCore/jit/AssemblyHelpers.h.
(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::codeBlock):
(JSC::DFG::AssemblyHelpers::vm):
(JSC::DFG::AssemblyHelpers::assembler):
(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::emitGetFromCallFrameHeaderPtr):
(JSC::DFG::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::branchIfNotCell):
(JSC::DFG::AssemblyHelpers::addressFor):
(JSC::DFG::AssemblyHelpers::tagFor):
(JSC::DFG::AssemblyHelpers::payloadFor):
(JSC::DFG::AssemblyHelpers::branchIfNotObject):
(JSC::DFG::AssemblyHelpers::selectScratchGPR):
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
(JSC::DFG::AssemblyHelpers::boxInt52):
(JSC::DFG::AssemblyHelpers::emitExceptionCheck):
(JSC::DFG::AssemblyHelpers::emitCount):
(JSC::DFG::AssemblyHelpers::globalObjectFor):
(JSC::DFG::AssemblyHelpers::strictModeFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):
(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(JSC::DFG::AssemblyHelpers::symbolTableFor):
(JSC::DFG::AssemblyHelpers::offsetOfLocals):
(JSC::DFG::AssemblyHelpers::offsetOfArgumentsIncludingThis):
* dfg/DFGBinarySwitch.h:
* dfg/DFGByteCodeParser.cpp:
* dfg/DFGCCallHelpers.h: Renamed from Source/JavaScriptCore/jit/CCallHelpers.h.
(JSC::DFG::CCallHelpers::CCallHelpers):
(JSC::DFG::CCallHelpers::resetCallArguments):
(JSC::DFG::CCallHelpers::addCallArgument):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsExecState):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(JSC::DFG::CCallHelpers::setupTwoStubArgs):
(JSC::DFG::CCallHelpers::setupStubArguments):
(JSC::DFG::CCallHelpers::setupResults):
* dfg/DFGDisassembler.cpp:
* dfg/DFGFPRInfo.h: Renamed from Source/JavaScriptCore/jit/FPRInfo.h.
(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::toArgumentRegister):
(JSC::DFG::FPRInfo::debugName):
* dfg/DFGGPRInfo.h: Renamed from Source/JavaScriptCore/jit/GPRInfo.h.
(JSC::DFG::JSValueRegs::JSValueRegs):
(JSC::DFG::JSValueRegs::payloadOnly):
(JSC::DFG::JSValueRegs::operator!):
(JSC::DFG::JSValueRegs::gpr):
(JSC::DFG::JSValueRegs::payloadGPR):
(JSC::DFG::JSValueSource::JSValueSource):
(JSC::DFG::JSValueSource::unboxedCell):
(JSC::DFG::JSValueSource::operator!):
(JSC::DFG::JSValueSource::isAddress):
(JSC::DFG::JSValueSource::offset):
(JSC::DFG::JSValueSource::base):
(JSC::DFG::JSValueSource::gpr):
(JSC::DFG::JSValueSource::asAddress):
(JSC::DFG::JSValueSource::notAddress):
(JSC::DFG::JSValueRegs::tagGPR):
(JSC::DFG::JSValueSource::tagGPR):
(JSC::DFG::JSValueSource::payloadGPR):
(JSC::DFG::JSValueSource::hasKnownTag):
(JSC::DFG::JSValueSource::tag):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
(JSC::DFG::GPRInfo::toArgumentRegister):
* dfg/DFGGraph.cpp:
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.h:
* dfg/DFGOSRExit.cpp:
* dfg/DFGOSRExit.h:
* dfg/DFGOSRExitCompiler.h:
* dfg/DFGOSRExitCompilerCommon.h:
* dfg/DFGRegisterBank.h:
* dfg/DFGRegisterSet.h:
* dfg/DFGRepatch.cpp:
* dfg/DFGSilentRegisterSavePlan.h:
* dfg/DFGThunks.cpp:
* dfg/DFGVariableEvent.cpp:
* ftl/FTLCArgumentGetter.h:
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
* ftl/FTLCompile.cpp:
* ftl/FTLExitThunkGenerator.h:
* ftl/FTLLink.cpp:
* ftl/FTLThunks.cpp:
* jit/JIT.cpp:
(JSC::JIT::JIT):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::preserveReturnAddressAfterCall):
(JSC::JSInterfaceJIT::restoreReturnAddressBeforeReturn):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):
* llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
* runtime/JSCJSValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Fri, 20 Sep 2013 01:51:01 +0000 (01:51 +0000)]
MediaStream API: update MediaStreamTrackEvent object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121624
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/mediastream/MediaStreamTrackEvent-constructor.html
* Modules/mediastream/MediaStreamTrack.idl: Remove NoInterfaceObject.
* Modules/mediastream/MediaStreamTrackEvent.cpp:
(WebCore::MediaStreamTrackEventInit::MediaStreamTrackEventInit): New.
(WebCore::MediaStreamTrackEvent::create): New form that takes an initialize.
(WebCore::MediaStreamTrackEvent::MediaStreamTrackEvent): Ditto.
* Modules/mediastream/MediaStreamTrackEvent.h:
* Modules/mediastream/MediaStreamTrackEvent.idl:
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): New.
* bindings/js/JSDictionary.h:
LayoutTests:
* fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt: Added.
* fast/mediastream/MediaStreamTrackEvent-constructor.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Sep 2013 01:41:20 +0000 (01:41 +0000)]
ASSERTs in isMainThread after USE(WEB_THREAD) MainThread changes
https://bugs.webkit.org/show_bug.cgi?id=121650
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-09-19
Reviewed by Benjamin Poulain.
* wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 20 Sep 2013 01:10:03 +0000 (01:10 +0000)]
Remove #if !ENABLE(WORKERS) code in ThreadGlobalData
https://bugs.webkit.org/show_bug.cgi?id=121649
Reviewed by Sam Weinig.
This lets us remove a FIXME. Also, move threadGlobalData out of line; there's no need for it to be inline.
* WebCore.exp.in:
* platform/ThreadGlobalData.cpp:
(WebCore::threadGlobalData):
* platform/ThreadGlobalData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 20 Sep 2013 01:00:19 +0000 (01:00 +0000)]
Modernize Length setters/getters
https://bugs.webkit.org/show_bug.cgi?id=121647
Reviewed by Andreas Kling.
Add a move constructor and move assignment operator to Length and fixup some of the getters and setters.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::createHandler):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(WebCore::ApplyPropertyLineHeight::createHandler):
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::LengthPropertyWrapper::LengthPropertyWrapper):
(WebCore::LengthPropertyWrapper::blend):
(WebCore::FillLayerPropertyWrapper::FillLayerPropertyWrapper):
(WebCore::FillLayerPropertyWrapper::blend):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* platform/CalculationValue.h:
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
* platform/Length.cpp:
(WebCore::CalculationValueHandleMap::remove):
(WebCore::CalculationValueHandleMap::find):
(WebCore::Length::decrementCalculatedRef):
* platform/Length.h:
(WebCore::Length::Length):
(WebCore::Length::operator=):
(WebCore::Length::moveFromLength):
* platform/LengthBox.cpp:
(WebCore::LengthBox::logicalLeft):
(WebCore::LengthBox::logicalRight):
(WebCore::LengthBox::before):
(WebCore::LengthBox::after):
(WebCore::LengthBox::start):
(WebCore::LengthBox::end):
* platform/LengthBox.h:
(WebCore::LengthBox::LengthBox):
(WebCore::LengthBox::left):
(WebCore::LengthBox::right):
(WebCore::LengthBox::top):
(WebCore::LengthBox::bottom):
* platform/LengthSize.h:
(WebCore::LengthSize::LengthSize):
(WebCore::LengthSize::setWidth):
(WebCore::LengthSize::width):
(WebCore::LengthSize::setHeight):
(WebCore::LengthSize::height):
* platform/graphics/filters/FilterOperation.h:
(WebCore::FilterOperation::BlurFilterOperation::create):
(WebCore::FilterOperation::BlurFilterOperation::stdDeviation):
(WebCore::FilterOperation::BlurFilterOperation::BlurFilterOperation):
* rendering/style/BasicShapes.h:
(WebCore::BasicShapeRectangle::x):
(WebCore::BasicShapeRectangle::y):
(WebCore::BasicShapeRectangle::width):
(WebCore::BasicShapeRectangle::height):
(WebCore::BasicShapeRectangle::cornerRadiusX):
(WebCore::BasicShapeRectangle::cornerRadiusY):
(WebCore::BasicShapeRectangle::setX):
(WebCore::BasicShapeRectangle::setY):
(WebCore::BasicShapeRectangle::setWidth):
(WebCore::BasicShapeRectangle::setHeight):
(WebCore::BasicShapeRectangle::setCornerRadiusX):
(WebCore::BasicShapeRectangle::setCornerRadiusY):
(WebCore::BasicShapeCircle::centerX):
(WebCore::BasicShapeCircle::centerY):
(WebCore::BasicShapeCircle::radius):
(WebCore::BasicShapeCircle::setCenterX):
(WebCore::BasicShapeCircle::setCenterY):
(WebCore::BasicShapeCircle::setRadius):
(WebCore::BasicShapeEllipse::centerX):
(WebCore::BasicShapeEllipse::centerY):
(WebCore::BasicShapeEllipse::radiusX):
(WebCore::BasicShapeEllipse::radiusY):
(WebCore::BasicShapeEllipse::setCenterX):
(WebCore::BasicShapeEllipse::setCenterY):
(WebCore::BasicShapeEllipse::setRadiusX):
(WebCore::BasicShapeEllipse::setRadiusY):
(WebCore::BasicShapePolygon::getXAt):
(WebCore::BasicShapePolygon::getYAt):
(WebCore::BasicShapePolygon::appendPoint):
(WebCore::BasicShapeInsetRectangle::top):
(WebCore::BasicShapeInsetRectangle::right):
(WebCore::BasicShapeInsetRectangle::bottom):
(WebCore::BasicShapeInsetRectangle::left):
(WebCore::BasicShapeInsetRectangle::cornerRadiusX):
(WebCore::BasicShapeInsetRectangle::cornerRadiusY):
(WebCore::BasicShapeInsetRectangle::setTop):
(WebCore::BasicShapeInsetRectangle::setRight):
(WebCore::BasicShapeInsetRectangle::setBottom):
(WebCore::BasicShapeInsetRectangle::setLeft):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusY):
* rendering/style/FillLayer.h:
(WebCore::FillSize::FillSize):
(WebCore::FillLayer::xPosition):
(WebCore::FillLayer::yPosition):
(WebCore::FillLayer::sizeLength):
(WebCore::FillLayer::setXPosition):
(WebCore::FillLayer::setYPosition):
* rendering/style/NinePieceImage.cpp:
(WebCore::NinePieceImage::NinePieceImage):
* rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::computeOutset):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::specifiedLineHeight):
* rendering/style/RenderStyle.h:
* rendering/style/StyleBoxData.h:
(WebCore::StyleBoxData::width):
(WebCore::StyleBoxData::height):
(WebCore::StyleBoxData::minWidth):
(WebCore::StyleBoxData::minHeight):
(WebCore::StyleBoxData::maxWidth):
(WebCore::StyleBoxData::maxHeight):
(WebCore::StyleBoxData::verticalAlign):
* rendering/style/StyleReflection.h:
(WebCore::StyleReflection::offset):
(WebCore::StyleReflection::setOffset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Fri, 20 Sep 2013 00:22:53 +0000 (00:22 +0000)]
Out-of-line InspectorValues create() methods.
<https://webkit.org/b/121639>
Reviewed by Joseph Pecoraro.
These functions are hardly performance-critical and are taking up
quite a lot of space.
Shrinks the WebCore binary by 70500 bytes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 19 Sep 2013 23:19:56 +0000 (23:19 +0000)]
Layout Test http/tests/security/canvas-remote-read-remote-image-redirect.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=121458
Reviewed by Sam Weinig.
Source/WebCore:
The code to automagically produce line numbers is quite fragile. Added some FIXMEs,
and added an issue that was making reporting flaky for code is JS event handlers
executed while parsing was paused.
* page/PageConsole.cpp: (WebCore::PageConsole::addMessage): Use actual "script is
running" check instead of "parsing a script element" one.
LayoutTests:
* fast/frames/sandboxed-iframe-attribute-parsing-06-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-07-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-08-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-09-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-10-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-11-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-12-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-13-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-14-expected.txt:
* fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
* fast/frames/sandboxed-iframe-scripting-04-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
* http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
* media/video-controls-no-scripting-expected.txt:
We now get a line number for blocked inline scripts, which is a progression.
It is the line number for the closing </script>, which is not ideal, but better
than nothing.
* http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
* http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
Also a progression - we now get a line number for offending <script>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 19 Sep 2013 23:15:50 +0000 (23:15 +0000)]
[iOS] Define mainThreadEstablishedAsPthreadMain to be true in WTF::initializeMainThreadPlatform()
Reviewed by Joseph Pecoraro.
This change was inadvertently left out of <http://trac.webkit.org/changeset/155926>.
* wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 19 Sep 2013 23:03:44 +0000 (23:03 +0000)]
Remove OwnArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=121612
Reviewed by Anders Carlsson.
* GNUmakefile.list.am:
* WTF.pro:
* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:
* WTF.xcodeproj/project.pbxproj:
* wtf/Assertions.cpp:
* wtf/CMakeLists.txt:
* wtf/DateMath.h:
* wtf/FastBitVector.h:
* wtf/Forward.h:
* wtf/OwnArrayPtr.h: Removed.
* wtf/VectorTraits.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 19 Sep 2013 23:02:38 +0000 (23:02 +0000)]
Substitute return type void for bool in function declaration for WTF::initializeWebThread()
Reviewed by Joseph Pecoraro.
Make the declaration of WTF::initializeWebThread() match the function prototype
of its definition.
* wtf/MainThread.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 19 Sep 2013 22:42:35 +0000 (22:42 +0000)]
Unreviewed, fix Windows build part 2. m_jitCodeMap should always be there.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::jitCodeMap):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 19 Sep 2013 22:38:24 +0000 (22:38 +0000)]
Remove superfluous CSSLinearTimingFunctionValue and use switch on TimingFunction::type() in more places
https://bugs.webkit.org/show_bug.cgi?id=121589
Reviewed by Dean Jackson.
Replaced CSSLinearTimingFunctionValue by the identifier "linear" and used switch statements on
TimingFunction::type() in more places where we were branching on every type.
Merge https://chromium.googlesource.com/chromium/blink/+/
5454f20c71090c35bdd1053e5cc572d5c0bdede7
Merge https://chromium.googlesource.com/chromium/blink/+/
104ad42c523d32b67d108c6e59f4f27488fe38a5
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::createTimingFunctionValue):
* css/CSSTimingFunctionValue.cpp:
* css/CSSTimingFunctionValue.h:
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
* css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::isCubicBezierTimingFunctionValue):
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::progress):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 19 Sep 2013 22:27:50 +0000 (22:27 +0000)]
Remove some of the tautologies in DFGRepatch function naming.
Rubber stamped by Mark Hahnenberg.
For example change DFG::dfgLinkFor() to be DFG::linkFor().
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
* dfg/DFGOperations.cpp:
* dfg/DFGRepatch.cpp:
(JSC::DFG::repatchCall):
(JSC::DFG::repatchByIdSelfAccess):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::repatchGetByID):
(JSC::DFG::buildGetByIDList):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::repatchPutByID):
(JSC::DFG::buildPutByIdList):
(JSC::DFG::repatchIn):
(JSC::DFG::linkFor):
(JSC::DFG::linkSlowFor):
(JSC::DFG::linkClosureCall):
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):
* dfg/DFGRepatch.h:
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 19 Sep 2013 22:23:39 +0000 (22:23 +0000)]
Unreviewed, fix Windows build. ScratchBuffer should always be available regardless of
ENABLE_DFG_JIT.
* runtime/VM.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 19 Sep 2013 22:16:16 +0000 (22:16 +0000)]
[iOS] Add more iOS logic to the JavaScriptCore build configuration files
https://bugs.webkit.org/show_bug.cgi?id=121635
Reviewed by Geoffrey Garen.
Towards building JavaScriptCore for both OS X and iOS using the same
set of configuration files, add more iOS logic.
* Configurations/Base.xcconfig:
* Configurations/JSC.xcconfig:
* Configurations/JavaScriptCore.xcconfig:
* Configurations/ToolExecutable.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 19 Sep 2013 22:12:26 +0000 (22:12 +0000)]
Unreviewed, rolling out r156119.
http://trac.webkit.org/changeset/156119
https://bugs.webkit.org/show_bug.cgi?id=121640
broke builds in various ways (Requested by anttik on #webkit).
* accessibility/AccessibilitySpinButton.cpp:
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* css/SelectorChecker.cpp:
* dom/ContainerNode.h:
* dom/Element.h:
* dom/PseudoElement.cpp:
(WebCore::PseudoElement::didAttachRenderers):
* editing/SplitTextNodeContainingElementCommand.cpp:
(WebCore::SplitTextNodeContainingElementCommand::doApply):
* editing/TypingCommand.cpp:
* html/ImageDocument.cpp:
* page/PageSerializer.cpp:
* rendering/RenderElement.h:
* rendering/RenderObject.h:
* svg/SVGAnimatedColor.cpp:
(WebCore::adjustForCurrentColor):
* svg/SVGLocatable.cpp:
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::referencedRenderer):
* svg/graphics/filters/SVGFEImage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 19 Sep 2013 22:10:26 +0000 (22:10 +0000)]
Move CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them
https://bugs.webkit.org/show_bug.cgi?id=121637
Rubber stamped by Michael Saboff.
Also moved GPRInfo/FPRInfo into jit/.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dumpInContext):
* dfg/DFGAssemblyHelpers.cpp: Removed.
* dfg/DFGAssemblyHelpers.h: Removed.
* dfg/DFGBinarySwitch.h:
* dfg/DFGByteCodeParser.cpp:
* dfg/DFGCCallHelpers.h: Removed.
* dfg/DFGDisassembler.cpp:
* dfg/DFGFPRInfo.h: Removed.
* dfg/DFGGPRInfo.h: Removed.
* dfg/DFGGraph.cpp:
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.h:
* dfg/DFGOSRExit.cpp:
* dfg/DFGOSRExit.h:
* dfg/DFGOSRExitCompiler.h:
* dfg/DFGOSRExitCompilerCommon.h:
* dfg/DFGRegisterBank.h:
* dfg/DFGRegisterSet.h:
* dfg/DFGRepatch.cpp:
* dfg/DFGSilentRegisterSavePlan.h:
* dfg/DFGThunks.cpp:
* dfg/DFGVariableEvent.cpp:
* ftl/FTLCArgumentGetter.h:
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
* ftl/FTLCompile.cpp:
* ftl/FTLExitThunkGenerator.h:
* ftl/FTLLink.cpp:
* ftl/FTLThunks.cpp:
* jit/AssemblyHelpers.cpp: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.cpp.
* jit/AssemblyHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h.
(JSC::AssemblyHelpers::AssemblyHelpers):
(JSC::AssemblyHelpers::debugCall):
* jit/CCallHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGCCallHelpers.h.
* jit/FPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGFPRInfo.h.
(WTF::printInternal):
* jit/GPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGGPRInfo.h.
(WTF::printInternal):
* jit/JIT.cpp:
(JSC::JIT::JIT):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::JSInterfaceJIT):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):
* llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
* runtime/JSCJSValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 19 Sep 2013 22:03:01 +0000 (22:03 +0000)]
Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638
Reviewed by Andreas Kling.
Also add isRenderElement() test and casting functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Thu, 19 Sep 2013 21:42:44 +0000 (21:42 +0000)]
Streamline JSMainThreadNullState.
<https://webkit.org/b/121636>
Reviewed by Anders Carlsson.
JSMainThreadNullState is only used by non-JavaScript bindings and
thus won't ever call didLeaveScriptContext() on destruction.
Specialize the class for its use-case instead of sharing code
with JSMainThreadExecState.
Shrinks the WebCore binary by 82848 bytes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Thu, 19 Sep 2013 21:40:20 +0000 (21:40 +0000)]
Assume allocator success in Vector unless using try* functions.
<https://webkit.org/b/121629>
Reviewed by Anders Carlsson.
Turn some Vector::begin() null checking into assertions instead.
We have try* style functions for when an allocation request is so
large that it might actually fail. fastMalloc() will never return
null (it will just CRASH() instead.)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
betravis@adobe.com [Thu, 19 Sep 2013 21:27:32 +0000 (21:27 +0000)]
CSS_SHAPES not supported on AppleWin port
https://bugs.webkit.org/show_bug.cgi?id=118810
Enabling CSS Shapes on Windows port
Reviewed by Brent Fulgham.
* LayoutTests/Changelog
* LayoutTEsts/platform/win/TestExpectations
* Source/WebCore/ChangeLog
* Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
* Source/WebCore/WebCore.vcxproj/WebCoreCommon.props
* Source/WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd
* Source/WebCore/css/CSSPropertyNames.in
* Source/WebKit/ChangeLog
* Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in
* WebKitLibraries/ChangeLog
* WebKitLibraries/win/tools/vsprops/FeatureDefines.props
* WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.props
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 19 Sep 2013 21:06:13 +0000 (21:06 +0000)]
Attempted build fix after r156114.
* Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 19 Sep 2013 20:46:08 +0000 (20:46 +0000)]
Removed WebCoreSQLite3. It has been unused for years.
Rubber-stamped by Mark Rowe.
* WebCoreSQLite3: Removed.
* WebCoreSQLite3/sqlite3.h: Removed.
* WebCoreSQLite3/sqlite3ext.h: Removed.
* libWebCoreSQLite3.a: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 19 Sep 2013 20:29:33 +0000 (20:29 +0000)]
[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()
Rubber-stamped by Joseph Pecoraro.
Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
noreturn warning in Clang while simultaneously asserting unreachable code.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_mod):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 19 Sep 2013 20:27:30 +0000 (20:27 +0000)]
[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()
Rubber-stamped by Joseph Pecoraro.
Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
noreturn warning in Clang while simultaneously asserting unreachable code.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_mod):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Thu, 19 Sep 2013 20:07:25 +0000 (20:07 +0000)]
JSC: X86 disassembler shows 16, 32 and 64 bit displacements as unsigned
https://bugs.webkit.org/show_bug.cgi?id=121625
Rubber-stamped by Filip Pizlo.
Chenged 16, 32 and 64 bit offsets to be signed. Kept the original tab indented
spacing to match the rest of the file.
* disassembler/udis86/udis86_syn-att.c:
(gen_operand):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Thu, 19 Sep 2013 19:54:19 +0000 (19:54 +0000)]
Add SVGPropertyInfo.cpp
<https://webkit.org/b/121622>
Reviewed by Anders Carlsson.
Add a cpp file for this class to make it more hackable.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* svg/properties/SVGPropertyInfo.cpp: Added.
(WebCore::SVGPropertyInfo::SVGPropertyInfo):
* svg/properties/SVGPropertyInfo.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156110
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 19 Sep 2013 19:22:41 +0000 (19:22 +0000)]
REGRESSION (r129451): run-safari --no-saved-state is broken
https://bugs.webkit.org/show_bug.cgi?id=121566
Undo a last minute change that doesn't actually work.
* Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
via command line, <rdar://problem/
15032886>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Thu, 19 Sep 2013 19:06:54 +0000 (19:06 +0000)]
MediaStream API: update NavigatorUserMediaError object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121584
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, updated getusermedia.html.
* CMakeLists.txt: Add NavigatorUserMediaError.cpp.
* GNUmakefile.list.am: Ditto.
* Modules/mediastream/NavigatorUserMediaError.cpp: Added.
* Modules/mediastream/NavigatorUserMediaError.h: Derive from DOMError, get rid of "message" attribute.
* Modules/mediastream/NavigatorUserMediaError.idl: Ditto.
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::create): ASCIILiteral -> AtomicString. Rename constraint parameters.
(WebCore::UserMediaRequest::UserMediaRequest): Rename constraint parameters.
(WebCore::UserMediaRequest::audioConstraints): Return PassRefPtr<> instead of raw ptr.
(WebCore::UserMediaRequest::videoConstraints): Ditto.
(WebCore::UserMediaRequest::ownerDocument): Clean up style.
(WebCore::UserMediaRequest::succeed):
(WebCore::UserMediaRequest::permissionFailure): Renamed from fail.
(WebCore::UserMediaRequest::constraintFailure): Renamed from failConstraint.
(WebCore::UserMediaRequest::callSuccessHandler): New.
(WebCore::UserMediaRequest::callErrorHandler): New.
* Modules/mediastream/UserMediaRequest.h:
* WebCore.xcodeproj/project.pbxproj: Add NavigatorUserMediaError.cpp
* dom/DOMError.h: Make constructor protected.
* platform/mediastream/MediaStreamSourcesQueryClient.h: Make constraints available.
LayoutTests:
* fast/mediastream/getusermedia-expected.txt:
* fast/mediastream/getusermedia.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Thu, 19 Sep 2013 18:49:05 +0000 (18:49 +0000)]
[CSS Shapes] Fix starting html tag and doctype for shape-inside floats tests
https://bugs.webkit.org/show_bug.cgi?id=121621
Reviewed by Andreas Kling.
* fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bjonesbe@adobe.com [Thu, 19 Sep 2013 18:18:39 +0000 (18:18 +0000)]
Fix handling of top margin on float with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=121614
Reviewed by Alexandru Chiculita.
Source/WebCore:
When a float has shape outside, the top margin should be treated as if
there is no shape there, so inline content should be allowed to flow
into that space. This patch fixes two issues:
1) If the top margin is the same as the line height, a line should be
able to fit into the margin. Before this patch, that line was being
treated as if it intersected with the shape.
2) The shape should be positioned (x, y) relative to the box sizing
box of the float. While the x coordinate was being treated properly,
the y coordinate was relative to the top of the margin box. This patch
fixes this behavior.
This patch also includes a simple test for right and left margins, as
I wrote that test and then discovered the problems listed above.
This patch also removes an unused override of the
lineOverlapsShapeBounds method.
Tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html
* rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):
* rendering/LineWidth.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
* rendering/shapes/ShapeInfo.h:
* rendering/shapes/ShapeInsideInfo.h:
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::computeSegmentsForContainingBlockLine):
* rendering/shapes/ShapeOutsideInfo.h:
LayoutTests:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Added.
Test for a positive left/right margin.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Added.
Test for a positive top margin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 19 Sep 2013 18:13:19 +0000 (18:13 +0000)]
Add a style guideline regarding spacing in range-based for loops
https://bugs.webkit.org/show_bug.cgi?id=121620
Reviewed by Anders Carlsson.
Tools:
* Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing): Added checking that there are spaces around the colon in a range-based for
loop.
(CppChecker): Added whitespace/colon to the categories set.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_spacing): Added two tests for the new check.
Websites/webkit.org:
* coding/coding-style.html: Added the guideline that spaces should be placed
around the colon in a range-based for loop.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 19 Sep 2013 17:57:47 +0000 (17:57 +0000)]
DoYouEvenBench: Indentations in benchmark.js and benchmark.html are all messed up
https://bugs.webkit.org/show_bug.cgi?id=121597
Reviewed by Anders Carlsson.
Fixed indentations.
* DoYouEvenBench/benchmark.html:
* DoYouEvenBench/benchmark.js:
(SimplePromise.prototype.resolve.else):
(SimplePromise.prototype.resolve):
(BenchmarkRunner.waitForElement.resolveIfReady):
(BenchmarkRunner.waitForElement):
(BenchmarkRunner._waitAndWarmUp.Fibonacci):
(BenchmarkRunner._finalize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 19 Sep 2013 17:57:24 +0000 (17:57 +0000)]
Add XHR tests checking readyState transition when abort() is invoked in various states
https://bugs.webkit.org/show_bug.cgi?id=121585
Reviewed by Alexey Proskuryakov.
Merge https://chromium.googlesource.com/chromium/blink/+/
2d854757576db590745cfb78e11ca428a1aac342
* http/tests/xmlhttprequest/readystatechange-and-abort-expected.txt: Added.
* http/tests/xmlhttprequest/readystatechange-and-abort.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 19 Sep 2013 17:52:38 +0000 (17:52 +0000)]
Add RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121608
Reviewed by Dave Hyatt.
Add a common base class for all Element renderers. The class hierarchy will now look like this
RenderObject
RenderText
RenderElement
RenderLayerModelObject
...
RenderSVGModelObject
...
RenderSVGGradientStop
This will allow tighter typing in both render and DOM trees.
The patch also moves renderer factory function to RenderElement::createFor().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
allan.jensen@digia.com [Thu, 19 Sep 2013 17:36:03 +0000 (17:36 +0000)]
Keep chasing the definition of QAccessibleWidget
https://bugs.webkit.org/show_bug.cgi?id=121611
Reviewed by Jocelyn Turcotte.
* WidgetApi/qwebviewaccessible_p.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156101
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 19 Sep 2013 16:06:06 +0000 (16:06 +0000)]
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
https://bugs.webkit.org/show_bug.cgi?id=121588
Reviewed by Anders Carlsson.
* DumpRenderTree/TestRunner.cpp:
* ImageDiff/efl/ImageDiff.cpp:
* TestWebKitAPI/JavaScriptTest.cpp:
* TestWebKitAPI/PlatformUtilities.cpp:
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
* WebKitTestRunner/StringFunctions.h:
* WebKitTestRunner/TestInvocation.cpp:
* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156100
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 19 Sep 2013 16:00:36 +0000 (16:00 +0000)]
REGRESSION (r149928): CanvasStyle::operator= leaks everything
https://bugs.webkit.org/show_bug.cgi?id=121591
Reviewed by Andreas Kling.
* html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::operator=): Don't leak.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156099
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rego@igalia.com [Thu, 19 Sep 2013 15:11:52 +0000 (15:11 +0000)]
Unreviewed. Fix typo in layout test description introduced in r155974.
* fast/regions/selection-direction-expected.html:
* fast/regions/selection-direction.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 19 Sep 2013 14:41:36 +0000 (14:41 +0000)]
[CSS Masking/Background] Position property should be ignored when using repeat: space
https://bugs.webkit.org/show_bug.cgi?id=120623
Source/WebCore:
The background/mask-position should be ignored when using repeat: space,
unless there is not enough space for two copies of the image. In that case,
only one image is placed and background/mask-position determines its position.
Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
Reviewed by Dirk Schulze.
Test: css3/masking/mask-repeat-one-copy.html
* rendering/RenderBoxModelObject.cpp: Ignored position property if space value is positive, set no-repeat otherwise.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
LayoutTests:
Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
Reviewed by Dirk Schulze.
* css3/masking/mask-repeat-one-copy-expected.html:
* css3/masking/mask-repeat-one-copy.html: Only one copy of the mask should be drawn, and background position should determine its position.
* css3/masking/mask-repeat-space-padding.html: Added a mask-position which should be ignored.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
m.pakula@samsung.com [Thu, 19 Sep 2013 14:39:56 +0000 (14:39 +0000)]
Unreviewed EFL gardening.
Unskip tests added to platform/efl/Skipped, which now are passing.
* platform/efl/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Thu, 19 Sep 2013 13:51:31 +0000 (13:51 +0000)]
CTTE: EllipsisBox::renderer() should return RenderBlock&.
<https://webkit.org/b/121604>
Reviewed by Antti Koivisto.
I missed adding a renderer() overload when fixing up EllipsisBox.
Flushed out one unnecessary type check.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Thu, 19 Sep 2013 13:48:44 +0000 (13:48 +0000)]
CTTE: Tighten renderer types for InlineTextBox and SVGInlineTextBox.
<https://webkit.org/b/121605>
Reviewed by Antti Koivisto.
Codify the following:
- InlineTextBox always has a RenderText.
- SVGInlineTextBox always has a RenderSVGInlineText.
Removed InlineTextBox::textRenderer() and make renderer() simply
return a RenderText&/RenderSVGInlineText& instead.
This turns some node() accessors into textNode() and removes a host
of casts and assertions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 19 Sep 2013 13:36:02 +0000 (13:36 +0000)]
[CTTE] Hide nonPseudoNode and generatingNode, replace with Element versions
https://bugs.webkit.org/show_bug.cgi?id=121606
Reviewed by Andreas Kling.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Thu, 19 Sep 2013 12:33:42 +0000 (12:33 +0000)]
CTTE: Tighten renderer types for InlineFlowBox and SVGInlineFlowBox.
<https://webkit.org/b/121603>
Reviewed by Antti Koivisto.
Codify the following:
- InlineFlowBox always has a RenderBoxModelObject.
- SVGInlineFlowBox always has a RenderSVGInline.
This turns some node() accessors into element(). Neato!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 19 Sep 2013 11:03:32 +0000 (11:03 +0000)]
CSS Unit vmax and vmin in border-width not handled.
https://bugs.webkit.org/show_bug.cgi?id=121421
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-19
Reviewed by Darin Adler.
Source/WebCore:
Border properties were not applied incase its values
were given in vmax/vmin units.
Tests: fast/css/viewport-vmax-border.html
fast/css/viewport-vmin-border.html
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportPercentageMax):
(WebCore::CSSPrimitiveValue::isViewportPercentageMin):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):
Calculating the border values which has been specified in
vmax/vmin units. 1vmax: 1vw or 1vh, whatever is largest.
1vmin: 1vw or 1vh, whatever is smallest. The vh/vw units are
calcultated as percent of viewport height and viewport width respectively.
LayoutTests:
* fast/css/viewport-vmax-border-expected.txt: Added.
* fast/css/viewport-vmax-border.html: Added.
* fast/css/viewport-vmin-border-expected.txt: Added.
* fast/css/viewport-vmin-border.html: Added.
Added new tests for verifying that border properties are
applied when its values are given in vmax/vmin units.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 19 Sep 2013 10:37:49 +0000 (10:37 +0000)]
[CTTE] RenderText is always anonymous or associated with Text node
https://bugs.webkit.org/show_bug.cgi?id=121596
Source/WebCore:
Reviewed by Andreas Kling.
Tighten the node type of RenderText and its subclasses to Text.
Switch to createAnonymous pattern.
Switch a bunch of unnecessary StringImpl* use to Strings.
LayoutTests:
Reviewed by Andreas Kling.
Update some MathML render tree dumps. RenderTexts for these are now anonymous.
* platform/mac/mathml/presentation/mo-expected.txt:
* platform/mac/mathml/presentation/row-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zarvai@inf.u-szeged.hu [Thu, 19 Sep 2013 08:42:49 +0000 (08:42 +0000)]
[Qt] Unreviewed gardening. Rebase after r155957 and 155998.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-19
* platform/qt-wk1/compositing/contents-scale/animating-expected.txt: Added r155998.
* platform/qt-wk1/compositing/contents-scale/scaled-ancestor-expected.txt: Added r155998.
* platform/qt-wk1/compositing/contents-scale/simple-scale-expected.txt: Added r155998.
* platform/qt-wk1/compositing/contents-scale/z-translate-expected.txt: Added r155998.
* platform/qt-wk2/compositing/contents-scale/animating-expected.txt: Added r155998.
* platform/qt-wk2/compositing/contents-scale/scaled-ancestor-expected.txt: Added r155998.
* platform/qt-wk2/compositing/contents-scale/simple-scale-expected.txt: Added r155998.
* platform/qt-wk2/compositing/contents-scale/z-translate-expected.txt: Added r155998.
* platform/qt/css3/selectors3/html/css3-modsel-179a-expected.txt: Rebase after r155957.
* platform/qt/css3/selectors3/xhtml/css3-modsel-179a-expected.txt: Rebase after r155957.
* platform/qt/css3/selectors3/xml/css3-modsel-179a-expected.txt: Rebase after r155957.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 19 Sep 2013 08:07:48 +0000 (08:07 +0000)]
Add an AngularJS test to DoYouEvenBench
https://bugs.webkit.org/show_bug.cgi?id=121595
Reviewed by Antti Koivisto.
* DoYouEvenBench/benchmark.html:
* DoYouEvenBench/todomvc/architecture-examples/angularjs: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/bower.json: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks/angular-mocks.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular/angular.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/bg.png: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/index.html: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/js: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/js/app.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers/todoCtrl.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoBlur.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoEscape.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoFocus.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services/todoStorage.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/readme.md: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/test: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config/testacular.conf.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/test/package.json: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/test/readme.md: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/directivesSpec.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/todoCtrlSpec.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Thu, 19 Sep 2013 07:54:15 +0000 (07:54 +0000)]
Unreviewed GTK gardening.
* platform/gtk/TestExpectations: Adding failure expectations for failing HiDPI and a11y tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihnea@adobe.com [Thu, 19 Sep 2013 07:07:35 +0000 (07:07 +0000)]
Unreviewed build fix after 156082. Guard SVG code with defines.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 19 Sep 2013 07:07:32 +0000 (07:07 +0000)]
Remove names of unused arguments from the x86/x86-64 function prototype
for JIT::emitSlow_op_mod()
Rubber-stamped by Ryosuke Niwa.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_mod):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Thu, 19 Sep 2013 06:42:08 +0000 (06:42 +0000)]
Unreviewed GTK gardening. Rebaselining after r155957.
* platform/gtk/css3/selectors3/html/css3-modsel-179a-expected.txt:
* platform/gtk/css3/selectors3/xhtml/css3-modsel-179a-expected.txt:
* platform/gtk/css3/selectors3/xml/css3-modsel-179a-expected.txt:
* platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt:
* platform/gtk/fast/css/word-space-extra-expected.txt:
* platform/gtk/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Thu, 19 Sep 2013 06:32:18 +0000 (06:32 +0000)]
Unreviewed GTK gardening. Rebaselining after r156040.
* platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
* platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
* platform/gtk/fast/forms/form-element-geometry-expected.txt:
* platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
* platform/gtk/fast/forms/select-baseline-expected.txt:
* platform/gtk/fast/forms/select-empty-option-height-expected.txt:
* platform/gtk/fast/forms/selectlist-minsize-expected.txt:
* platform/gtk/fast/html/keygen-expected.txt:
* platform/gtk/fast/replaced/three-selects-break-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihnea@adobe.com [Thu, 19 Sep 2013 06:22:53 +0000 (06:22 +0000)]
[CSSRegions] Failed to retrieve named flow ranges for content with inline svg
https://bugs.webkit.org/show_bug.cgi?id=121489
Reviewed by David Hyatt.
Source/WebCore:
The inline SVG element behaves like a replaced element in HTML context. When computing the ranges
that are displayed inside a region for a named flow that contains an inline SVG element, we have
to treat the SVG as a replaced and run the checks only for the SVG root element, skipping the
other SVG elements inside.
Test: fast/regions/get-region-flow-ranges-inline-svg.html
* rendering/RenderNamedFlowThread.cpp:
(WebCore::nextNodeInsideContentNode): Add function to retrieve the next node in traversal
under the contentNode subtree that should be used for getRanges inspection.
(WebCore::RenderNamedFlowThread::getRanges): Replace NodeTravesal::next with nextNodeInsideContentNode.
LayoutTests:
* fast/regions/get-region-flow-ranges-inline-svg-expected.txt: Added.
* fast/regions/get-region-flow-ranges-inline-svg.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Thu, 19 Sep 2013 06:18:47 +0000 (06:18 +0000)]
Unreviewed GTK gardening. Moving GTK-specific baselines for some js/dom/* tests into the proper directory.
* platform/gtk/js/dom: Added.
* platform/gtk/js/dom-static-property-for-in-iteration-expected.txt: Removed.
* platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt: Copied from LayoutTests/platform/gtk/js/dom-static-property-for-in-iteration-expected.txt.
* platform/gtk/js/dom/function-length-expected.txt: Copied from LayoutTests/platform/gtk/js/function-length-expected.txt.
* platform/gtk/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Copied from LayoutTests/platform/gtk/js/global-constructors-attributes-dedicated-worker-expected.txt.
* platform/gtk/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/gtk/js/global-constructors-attributes-expected.txt.
* platform/gtk/js/dom/global-constructors-attributes-shared-worker-expected.txt: Copied from LayoutTests/platform/gtk/js/global-constructors-attributes-shared-worker-expected.txt.
* platform/gtk/js/function-length-expected.txt: Removed.
* platform/gtk/js/global-constructors-attributes-dedicated-worker-expected.txt: Removed.
* platform/gtk/js/global-constructors-attributes-expected.txt: Removed.
* platform/gtk/js/global-constructors-attributes-shared-worker-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 19 Sep 2013 04:03:45 +0000 (04:03 +0000)]
Redo r156078.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
* platform/mac-wk2/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Removed.
* platform/mac-wk2/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 19 Sep 2013 03:12:09 +0000 (03:12 +0000)]
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=121583
Reviewed by Anders Carlsson.
* API/JSStringRefCF.cpp:
(JSStringCreateWithCFString):
* API/JSStringRefQt.cpp:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::dumpDisassembly):
* runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
* runtime/Arguments.h:
(JSC::Arguments::isTornOff):
(JSC::Arguments::allocateSlowArguments):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
* runtime/JSPropertyNameIterator.h:
* runtime/JSSegmentedVariableObject.h:
* runtime/JSVariableObject.h:
* runtime/PropertyNameArray.h:
* runtime/RegExp.cpp:
* runtime/StructureChain.h:
(JSC::StructureChain::finishCreation):
* runtime/SymbolTable.h:
(JSC::SharedSymbolTable::setSlowArguments):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 19 Sep 2013 03:03:48 +0000 (03:03 +0000)]
Lion rebaseline after r155253.
* platform/mac-wk2/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
* platform/mac-wk2/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
* platform/qt-wk2/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Removed.
* platform/qt-wk2/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 19 Sep 2013 02:17:38 +0000 (02:17 +0000)]
Add test expectations for bugs 121581 and 121582.
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 19 Sep 2013 02:04:00 +0000 (02:04 +0000)]
Fix the expected result again after r156070.
* platform/mac-lion/js/dom: Added.
* platform/mac-lion/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt.
* platform/mac/js/dom/global-constructors-attributes-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bjonesbe@adobe.com [Thu, 19 Sep 2013 01:31:11 +0000 (01:31 +0000)]
REGRESSION (r155854 - r155967) block with margin-left adjacent to floated block causes text of subsequent blocks to overlap the floated block.
https://bugs.webkit.org/show_bug.cgi?id=121532
Reviewed by Andreas Kling.
Source/WebCore:
When refactoring the code, I ended up adding the margin in instead of
subtracting it in the case of an intruding float. This patch fixes
that so that the margin is properly handled.
Test: fast/block/float/intruding-float-sibling-with-margin.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addIntrudingFloats):
LayoutTests:
* fast/block/float/intruding-float-sibling-with-margin-expected.html: Added.
* fast/block/float/intruding-float-sibling-with-margin.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bjonesbe@adobe.com [Thu, 19 Sep 2013 00:55:50 +0000 (00:55 +0000)]
W3C Test Import script reformats test HTML
https://bugs.webkit.org/show_bug.cgi?id=119159
Reviewed by Dirk Pranke.
Completely rewrite the test conversion process to minimize
reformatting when adding prefixes, etc. This isn't 100% perfect, there
are still places where it will end up changing the formatting, but it
is much better than before. Most notably, the public interface to the
test converter has changed: now one calls a method instead of creating
an instance of the test converter class. This is because the test
converter class now has state, so one really needs a new instance for
each test.
Note that this also lays some simple groundwork for being able to use
a MockHost in the tests.
* Scripts/webkitpy/w3c/test_converter.py:
(convert_for_webkit):
(_W3CTestConverter):
(_W3CTestConverter.__init__):
(_W3CTestConverter.output):
(_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
(_W3CTestConverter.convert_style_data):
(_W3CTestConverter.convert_attributes_if_needed):
(_W3CTestConverter.handle_starttag):
(_W3CTestConverter.handle_endtag):
(_W3CTestConverter.handle_startendtag):
(_W3CTestConverter.handle_data):
(_W3CTestConverter.handle_entityref):
(_W3CTestConverter.handle_charref):
(_W3CTestConverter.handle_comment):
(_W3CTestConverter.handle_decl):
(_W3CTestConverter.handle_pi):
* Scripts/webkitpy/w3c/test_converter_unittest.py:
(W3CTestConverterTest):
(W3CTestConverterTest.fake_dir_path):
(W3CTestConverterTest.test_read_prefixed_property_list):
(verify_no_conversion_happened):
* Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.import_tests):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 19 Sep 2013 00:15:35 +0000 (00:15 +0000)]
Add a not completely unrealistic DOM Benchmark
https://bugs.webkit.org/show_bug.cgi?id=121361
Reviewed by Filip Pizlo.
Add a DOM benchmark based on TodoMVC for vanilla JS, Ember.js, Backbone.js, and jQuery.
We'll add more frameworks and demo apps as we go.
* DoYouEvenBench: Added.
* DoYouEvenBench/benchmark.html: Added.
* DoYouEvenBench/benchmark.js: Added.
(SimplePromise):
(SimplePromise.prototype.then):
(SimplePromise.prototype.resolve.else):
(SimplePromise.prototype.resolve):
(BenchmarkRunner.suite):
(BenchmarkRunner.waitForElement.resolveIfReady):
(BenchmarkRunner.waitForElement):
(BenchmarkRunner._removeFrame):
(BenchmarkRunner._appendFrame):
(BenchmarkRunner._waitAndWarmUp.Fibonacci):
(BenchmarkRunner._testName):
(BenchmarkRunner._testItemId):
(BenchmarkRunner.listSuites.button.onclick):
(BenchmarkRunner.listSuites.callNextStep):
(BenchmarkRunner.listSuites):
(BenchmarkState):
(BenchmarkState.prototype.currentSuite):
(BenchmarkState.prototype.currentTest):
(BenchmarkState.prototype.next):
(BenchmarkState.prototype.isFirstTest):
(BenchmarkState.prototype.prepareCurrentSuite.frame.onload):
(BenchmarkRunner.step):
(BenchmarkRunner._runTestAndRecordResults):
(BenchmarkRunner._finalize):
* DoYouEvenBench/todomvc: Added.
* DoYouEvenBench/todomvc/architecture-examples: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower.json: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage/backbone.localStorage.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone/backbone.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/jquery: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/jquery/jquery.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.css: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/bg.png: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/underscore: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/underscore/underscore.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/index.html: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/js: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/js/app.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/js/collections: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/js/collections/todos.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/js/models: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/js/models/todo.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/js/routers: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/js/routers/router.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/js/views: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/js/views/app-view.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/js/views/todo-view.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/backbone/readme.md: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower.json: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter/localstorage_adapter.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/handlebars: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/jquery: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/jquery/jquery.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/bg.png: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/index.html: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/js/app.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers/todo_controller.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers/todos_controller.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/js/libs: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/js/libs/ember-data.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models/store.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models/todo.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/js/views: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/js/views/edit_todo_view.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/readme.md: Added.
* DoYouEvenBench/todomvc/architecture-examples/emberjs/test.html: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/bower.json: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/handlebars: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/handlebars/handlebars.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/jquery: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/jquery/jquery.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.css: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/bg.png: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/css: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/css/app.css: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/index.html: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/js: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/js/app.js: Added.
* DoYouEvenBench/todomvc/architecture-examples/jquery/readme.md: Added.
* DoYouEvenBench/todomvc/license.md: Added.
* DoYouEvenBench/todomvc/readme.md: Added.
* DoYouEvenBench/todomvc/vanilla-examples: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower.json: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.css: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.js: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/bg.png: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/index.html: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/app.js: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/controller.js: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/helpers.js: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/model.js: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/store.js: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/view.js: Added.
* DoYouEvenBench/todomvc/vanilla-examples/vanillajs/readme.md: Added.
* Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 18 Sep 2013 23:58:54 +0000 (23:58 +0000)]
Merge HTMLBodyElement::didNotifySubtreeInsertions into HTMLBodyElement::insertedInto
https://bugs.webkit.org/show_bug.cgi?id=121576
Reviewed by Andreas Kling.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/
2a9cac908f4eceadfcf9d21bdf5b3e598075aa1f
The logic in didNotifySubtreeInsertions to set the marginwidth and marginheight attributes
on the <body> of elements inside <iframe> and <frame> doesn't need to run after inserting
all the children of the frame. In fact this means that when you have those attributes
and then the script in the iframe touches offsetLeft or any layout dependent property
we'll layout with the wrong values and then have to do another layout after these margin
attributes are set.
I also remove the scheduleRelayout() call that was inside didNotifySubtreeInsertions. This
call doesn't make any sense, inserting a <body> will always trigger a style recalc and
a subsequent layout. The code is 9 years old: https://trac.webkit.org/changeset/8122
and all tests run fine without it.
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto):
* html/HTMLBodyElement.h:
* html/HTMLFrameElementBase.h:
(WebCore::isHTMLFrameElementBase):
(WebCore::toHTMLFrameElementBase):
LayoutTests:
Rebaseline a test now that we don't do an extra layout.
* inspector/timeline/timeline-script-tag-1-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 18 Sep 2013 23:51:43 +0000 (23:51 +0000)]
Unreviewed check in a proper baseline.
* js/dom/global-constructors-attributes-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 18 Sep 2013 23:40:04 +0000 (23:40 +0000)]
Move expected results after r156066.
* platform/efl/js/dom: Added.
* platform/efl/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/efl/js/global-constructors-attributes-expected.txt.
* platform/efl/js/global-constructors-attributes-expected.txt: Removed.
* platform/mac-lion/js/global-constructors-attributes-expected.txt: Removed.
* platform/mac/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac-lion/js/global-constructors-attributes-expected.txt.
* platform/qt/js/dom: Added.
* platform/qt/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/qt/js/global-constructors-attributes-expected.txt.
* platform/qt/js/global-constructors-attributes-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 18 Sep 2013 22:45:06 +0000 (22:45 +0000)]
Remove the ENABLE_PLUGIN_PROCESS #define
https://bugs.webkit.org/show_bug.cgi?id=121569
Reviewed by Andreas Kling.
Fold the ENABLE_PLUGIN_PROCESS #define into the NETSCAPE_PLUGIN_API #define since
building plug-ins without the plug-in process is not supported.
* PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
* PluginProcess/PluginControllerProxy.cpp:
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/PluginControllerProxy.messages.in:
* PluginProcess/PluginCreationParameters.cpp:
* PluginProcess/PluginCreationParameters.h:
* PluginProcess/PluginProcess.cpp:
* PluginProcess/PluginProcess.h:
* PluginProcess/PluginProcess.messages.in:
* PluginProcess/WebProcessConnection.cpp:
* PluginProcess/WebProcessConnection.h:
* PluginProcess/WebProcessConnection.messages.in:
* PluginProcess/mac/PluginControllerProxyMac.mm:
* PluginProcess/mac/PluginProcessMac.mm:
* Shared/Plugins/NPIdentifierData.cpp:
* Shared/Plugins/NPIdentifierData.h:
* Shared/Plugins/NPObjectMessageReceiver.cpp:
* Shared/Plugins/NPObjectMessageReceiver.h:
* Shared/Plugins/NPObjectMessageReceiver.messages.in:
* Shared/Plugins/NPObjectProxy.cpp:
* Shared/Plugins/NPObjectProxy.h:
* Shared/Plugins/NPRemoteObjectMap.cpp:
* Shared/Plugins/NPRemoteObjectMap.h:
* Shared/Plugins/NPVariantData.cpp:
* Shared/Plugins/NPVariantData.h:
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getMIMETypesFromPluginBundle):
* Shared/Plugins/PluginProcessCreationParameters.cpp:
* Shared/Plugins/PluginProcessCreationParameters.h:
* UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::processTypeAsString):
(WebKit::ProcessLauncher::getProcessTypeFromString):
* UIProcess/Launcher/ProcessLauncher.h:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
(WebKit::serviceName):
(WebKit::createProcess):
* UIProcess/Plugins/PluginProcessManager.cpp:
* UIProcess/Plugins/PluginProcessManager.h:
* UIProcess/Plugins/PluginProcessProxy.cpp:
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.messages.in:
* UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::~WebPluginSiteDataManager):
(WebKit::WebPluginSiteDataManager::invalidate):
(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
* UIProcess/Plugins/WebPluginSiteDataManager.h:
* UIProcess/Plugins/mac/PluginProcessManagerMac.mm:
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setProcessModel):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginProcessConnection):
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
* UIProcess/mac/WebContextMac.mm:
(WebKit::updateProcessSuppressionStateOfGlobalChildProcesses):
* WebKit2Prefix.h:
* WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
* WebProcess/Plugins/PluginProcessConnection.cpp:
* WebProcess/Plugins/PluginProcessConnection.h:
* WebProcess/Plugins/PluginProcessConnection.messages.in:
* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
* WebProcess/Plugins/PluginProcessConnectionManager.h:
* WebProcess/Plugins/PluginProcessConnectionManager.messages.in:
* WebProcess/Plugins/PluginProxy.cpp:
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginProxy.messages.in:
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc