WebKit-https.git
18 years agoTests:
sullivan [Thu, 22 Jan 2004 19:42:28 +0000 (19:42 +0000)]
Tests:

        * Blot/blot-tasks.txt
        Added tasks for supporting preference panels

WebKit:

        Reviewed by Chris.

        * English.lproj/StringsNotToBeLocalized.txt:
        brought this file back up to date

WebBrowser:

        - fixed <rdar://problem/3522522>: Tooltip typo: "word of phrase" instead of "word or phrase"
        - removed hack that we added at the last minute to get the copyright string correct

        Reviewed by Chris.

        * BrowserApplication.m:
        (-[BrowserApplication orderFrontStandardAboutPanel:]):
        removed AppKit-string-snarfing hack; now we use a normal localizable string
        for the copyright string in the About box.

        * BrowserWindowController.m:
        (-[BrowserWindowController setUpSearchField]):
        fixed typo that was previously fixed only in the English localization

        * English.lproj/Localizable.strings:
        * English.lproj/StringsNotToBeLocalized.txt:
        brought these two files up to date

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed 3536624: Webkit 1.2 links against SecurityNssAsn1.framework
darin [Thu, 22 Jan 2004 16:45:01 +0000 (16:45 +0000)]
    - fixed 3536624: Webkit 1.2 links against SecurityNssAsn1.framework

        * WebKit.pbproj/project.pbxproj: Remove SecurityNssAsn1.framework from the list we link against.
        It's still included in the list for places to find headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoAdding even more margin collapsing tests... courtesy of Hixie.
hyatt [Thu, 22 Jan 2004 09:18:36 +0000 (09:18 +0000)]
Adding even more margin collapsing tests... courtesy of Hixie.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFix build bustage.
hyatt [Thu, 22 Jan 2004 03:10:43 +0000 (03:10 +0000)]
Fix build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFix build bustage with libxml include path.
hyatt [Thu, 22 Jan 2004 02:59:50 +0000 (02:59 +0000)]
Fix build bustage with libxml include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoAdd margin collapsing tests.
hyatt [Thu, 22 Jan 2004 02:52:51 +0000 (02:52 +0000)]
Add margin collapsing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for two margin collapsing edge cases.
hyatt [Thu, 22 Jan 2004 02:49:58 +0000 (02:49 +0000)]
Fix for two margin collapsing edge cases.

        Reviewed by darin

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::layoutBlockChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Switch from expat to libxml and implement namespace support in the simplereader.
hyatt [Thu, 22 Jan 2004 02:45:09 +0000 (02:45 +0000)]
Switch from expat to libxml and implement namespace support in the simplereader.

        Reviewed by darin

        * ChangeLog:
        * expat/Changes: Removed.
        * expat/MANIFEST: Removed.
        * expat/README: Removed.
        * expat/expat_config.h: Removed.
        * expat/lib/ascii.h: Removed.
        * expat/lib/asciitab.h: Removed.
        * expat/lib/expat.h: Removed.
        * expat/lib/iasciitab.h: Removed.
        * expat/lib/internal.h: Removed.
        * expat/lib/latin1tab.h: Removed.
        * expat/lib/nametab.h: Removed.
        * expat/lib/utf8tab.h: Removed.
        * expat/lib/xmlparse.c: Removed.
        * expat/lib/xmlrole.c: Removed.
        * expat/lib/xmlrole.h: Removed.
        * expat/lib/xmltok.c: Removed.
        * expat/lib/xmltok.h: Removed.
        * expat/lib/xmltok_impl.c: Removed.
        * expat/lib/xmltok_impl.h: Removed.
        * expat/lib/xmltok_ns.c: Removed.
        * kwq/KWQXmlAttributes.h:
        (QXmlAttributes::QXmlAttributes):
        (QXmlAttributes::qName):
        (QXmlAttributes::uri):
        * kwq/KWQXmlAttributes.mm:
        (QXmlAttributes::QXmlAttributes):
        (QXmlAttributes::~QXmlAttributes):
        (QXmlAttributes::operator=):
        (QXmlAttributes::localName):
        (QXmlAttributes::split):
        * kwq/KWQXmlSimpleReader.h:
        (KWQXmlNamespace::m_ref):
        (KWQXmlNamespace::uriForPrefix):
        (KWQXmlNamespace::ref):
        (KWQXmlNamespace::deref):
        (QXmlParseException::QXmlParseException):
        (QXmlParseException::message):
        (QXmlParseException::columnNumber):
        (QXmlParseException::lineNumber):
        (QXmlSimpleReader::errorHandler):
        (QXmlSimpleReader::xmlNamespace):
        (QXmlSimpleReader::parserStopped):
        * kwq/KWQXmlSimpleReader.mm:
        (startElementHandler):
        (endElementHandler):
        (charactersHandler):
        (processingInstructionHandler):
        (cdataBlockHandler):
        (commentHandler):
        (warningHandler):
        (fatalErrorHandler):
        (QXmlSimpleReader::pushNamespaces):
        (QXmlSimpleReader::popNamespaces):
        (QXmlSimpleReader::parse):
        (QXmlSimpleReader::stopParsing):
        (QXmlSimpleReader::lineNumber):
        (QXmlSimpleReader::columnNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Add some methods to dicts and stacks that exist in Qt.
hyatt [Thu, 22 Jan 2004 02:30:52 +0000 (02:30 +0000)]
Add some methods to dicts and stacks that exist in Qt.

        Reviewed by darin

        * kwq/KWQDict.h:
        (QDict::replace):
        * kwq/KWQPtrDict.h:
        (QPtrDict::replace):
        (QPtrDict::find):
        * kwq/KWQPtrStack.h:
        (QPtrStack::current):
        (QPtrStack::setAutoDelete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agochange version number to from '125' to '126u'
vicki [Wed, 21 Jan 2004 22:25:34 +0000 (22:25 +0000)]
change version number to from '125' to '126u'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-125 stamp
vicki [Wed, 21 Jan 2004 22:13:48 +0000 (22:13 +0000)]
Safari-125 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John, Ken, Dave.
mjs [Tue, 20 Jan 2004 00:58:24 +0000 (00:58 +0000)]
    Reviewed by John, Ken, Dave.

<rdar://problem/3533319>: Safari allows upload of arbitrary local files w/o user's knowledge or permission

* khtml/html/html_formimpl.cpp:
        (HTMLInputElementImpl::value): Don't fall back to the value
attribute for file inputs, since that way malicious HTML could
force the user to upload files unexpectedly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3532569, bugzilla patch viewer doesn't work. My previous fix for 3531983...
hyatt [Mon, 19 Jan 2004 02:10:15 +0000 (02:10 +0000)]
Fix for 3532569, bugzilla patch viewer doesn't work.  My previous fix for 3531983 caused moves to happen
when they should not have, due to childX and childY not being implemented at all on KWQScrollView.

        Reviewed by darin

        * kwq/KWQScrollView.mm:
        (QScrollView::childX):
        (QScrollView::childY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoset version number to '125u'. The tree is open for Safari-125.
vicki [Sat, 17 Jan 2004 02:45:16 +0000 (02:45 +0000)]
set version number to '125u'.  The tree is open for Safari-125.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-124 stamp
vicki [Sat, 17 Jan 2004 02:26:46 +0000 (02:26 +0000)]
Safari-124 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3531983, fixed positioning not working for widgets. Make sure to move widge...
hyatt [Fri, 16 Jan 2004 23:42:06 +0000 (23:42 +0000)]
Fix for 3531983, fixed positioning not working for widgets.  Make sure to move widgets at paint time
if necessary.

        Reviewed by darin

        * khtml/rendering/render_replaced.cpp:
        (RenderWidget::paintObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoJavaScriptCore:
rjw [Fri, 16 Jan 2004 23:23:04 +0000 (23:23 +0000)]
JavaScriptCore:
Fixed 3525853.  We weren't handling mapping to overloaded Java
methods very well.  Even though this is undefined the other
browsers support it.  Also fixed a bug with returning arrays
from Java functions.

        Reviewed by John.

        * bindings/jni/jni_class.cpp:
        (JavaClass::_commonInit):
        (JavaClass::methodsNamed):
        * bindings/jni/jni_class.h:
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        (JavaArray::convertJObjectToArray):
        (JavaField::valueFromInstance):
        (JavaMethod::signature):
        (JavaArray::valueAt):
        * bindings/jni/jni_runtime.h:
        * bindings/jni_jsobject.cpp:
        (JSObject::call):
        (JSObject::convertJObjectToValue):
        * bindings/runtime.cpp:
        (MethodList::addMethod):
        (MethodList::length):
        (MethodList::methodAt):
        (MethodList::~MethodList):
        * bindings/runtime.h:
        (KJS::Bindings::MethodList::MethodList):
        * bindings/runtime_method.cpp:
        (RuntimeMethodImp::RuntimeMethodImp):
        (RuntimeMethodImp::get):
        (RuntimeMethodImp::call):
        * bindings/runtime_method.h:
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::get):
        (RuntimeObjectImp::hasProperty):

Tests:
        Extending test to cover issues in 3525853.

        Reviewed by John.

        * ChangeLog:
        * LiveConnect/Blink/Blink.java:
        (Blink.init):
        (Blink.getStrings):
        (Blink):
        (Blink.getManyNumbers):
        (Blink.overloadedFunction):
        * LiveConnect/Blink/Blink.pbproj/project.pbxproj:
        * LiveConnect/Blink/test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3531229. Another place that needs the Push/PopLocalFrame
rjw [Fri, 16 Jan 2004 18:59:26 +0000 (18:59 +0000)]
Fixed 3531229.  Another place that needs the  Push/PopLocalFrame
protection implemented for 3530401.

        Reviewed by John.

        * bindings/runtime_method.cpp:
        (RuntimeMethodImp::call):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3530401. JNI doesn't cleanup local refs created on the
rjw [Fri, 16 Jan 2004 01:58:05 +0000 (01:58 +0000)]
Fixed 3530401.  JNI doesn't cleanup local refs created on the
main thread.   IMO this is a bad bug in our JMI implementation.

To work-around the problem I explicitly delete all local refs.
Further, I've added Push/PopLocalFrame calls to catch any refs
that I may have missed.  This will guarantee that we don't leak
any Java references.

        Reviewed by John.

        * bindings/jni/jni_class.cpp:
        (JavaClass::_commonInit):
        (JavaClass::JavaClass):
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::begin):
        (JavaInstance::end):
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        (JavaConstructor::JavaConstructor):
        (JavaMethod::JavaMethod):
        * bindings/jni_jsobject.cpp:
        (JSObject::listFromJArray):
        * bindings/runtime.h:
        (KJS::Bindings::Instance::begin):
        (KJS::Bindings::Instance::end):
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::get):
        (RuntimeObjectImp::put):
        (RuntimeObjectImp::canPut):
        (RuntimeObjectImp::hasProperty):
        (RuntimeObjectImp::defaultValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3530734, many java applets don't show up. Go ahead and just use the width...
hyatt [Fri, 16 Jan 2004 00:53:08 +0000 (00:53 +0000)]
Fix for 3530734, many java applets don't show up.  Go ahead and just use the width/height from the style
system as the initial size when the width/height are fixed.

        Reviewed by rjw

        * khtml/rendering/render_applet.cpp:
        (RenderApplet::createWidgetIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoI previously checked the fix for 3529426, but the fix was commented out. Oops.
rjw [Thu, 15 Jan 2004 23:44:57 +0000 (23:44 +0000)]
I previously checked the fix for 3529426, but the fix was commented out.  Oops.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3529426. Exclude pages that contain Java applets from
rjw [Thu, 15 Jan 2004 21:18:53 +0000 (21:18 +0000)]
Fixed 3529426.  Exclude pages that contain Java applets from
the page cache.  The means applets get the normal stop/destroy
messages that they expect when a user leaves a page.

        Reviewed by John.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::canCachePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoJavaScriptCore:
vicki [Thu, 15 Jan 2004 19:06:30 +0000 (19:06 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        * JavaScriptCore.pbproj/project.pbxproj: Update copyright date to 2004.

WebCore:

        Reviewed by Darin.

        * WebCore.pbproj/project.pbxproj: Update copyright date to 2004.

WebKit:

        Reviewed by Darin.

        * WebKit.pbproj/project.pbxproj: Update copyright date to 2004.
        * English.lproj/InfoPlist.strings: Update copyright date to 2004.

WebBrowser:

        Reviewed by Darin.

        * WebBrowser.pbproj/project.pbxproj: Update copyright date to 2004.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Ken.
darin [Thu, 15 Jan 2004 16:26:23 +0000 (16:26 +0000)]
    Reviewed by Ken.

        - fixed 3529943: REGRESSION (119-120): nil-deref in KHTMLPart::javaEnabled when hitting back button

        * khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance):
        Add missing nil check that the other call to javaEnabled has.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago- change version numbers to "124u", since I spun WebBrowser-123 for the Info.plist...
vicki [Thu, 15 Jan 2004 01:41:18 +0000 (01:41 +0000)]
- change version numbers to "124u", since I spun WebBrowser-123 for the Info.plist change in rdar://problem/3529511

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3529466. With recent changes to Java plugin we must no
rjw [Thu, 15 Jan 2004 01:10:08 +0000 (01:10 +0000)]
Fixed 3529466.  With recent changes to Java plugin we must no
longer call DeleteLocalRef().  Not a problem, it was an optimization anyway.

        Reviewed by John.

        * bindings/jni/jni_instance.cpp:
        (JObjectWrapper::JObjectWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago- change version number to "123u". The tree is open for Safari-123
vicki [Thu, 15 Jan 2004 01:04:20 +0000 (01:04 +0000)]
- change version number to "123u".  The tree is open for Safari-123

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-122 stamp (we'll have to change the release marker in WebBrowser after john...
vicki [Thu, 15 Jan 2004 00:47:51 +0000 (00:47 +0000)]
Safari-122 stamp (we'll have to change the release marker in WebBrowser after john's check in)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3527819, marquee makes page layout too wide. Make sure marquees have a...
hyatt [Thu, 15 Jan 2004 00:16:06 +0000 (00:16 +0000)]
Fix for 3527819, marquee makes page layout too wide.  Make sure marquees have a minimum width of 0.

        Reviewed by john

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::calcMinMaxWidth):
        (khtml::RenderBlock::calcInlineMinMaxWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3529010.
rjw [Wed, 14 Jan 2004 21:00:21 +0000 (21:00 +0000)]
Fixed 3529010.

Finalize may be called on an JSObject after we've already remove all our references.  The assert in this case is firing because we've received a finalize call from Java for an instance that we no longer know about.  The fix is to check in finalize that we're getting a call on an instance that we still care about.

        Reviewed by John.

        * bindings/jni_jsobject.cpp:
        (addJavaReference):
        (removeJavaReference):
        (RootObject::removeAllJavaReferencesForRoot):
        (JSObject::invoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3528324.
rjw [Wed, 14 Jan 2004 04:57:29 +0000 (04:57 +0000)]
Fixed 3528324.

The run loop that is used to execute JavaScript (in practice, always the main run loop) is held in a class variable.  It is set and retained once and should not be released.  Unfortunately is it being released when the 'root' object on a LiveConnect applet is released.  This has the symptom of eventually causing an deallocation of the main run loop!  Usually after about 5 instantiations/destructions of a LiveConnect applet.  The CFRelease of the run loop was removed.

        Reviewed by Hyatt.

        * bindings/jni_jsobject.h:
        (KJS::Bindings::RootObject::~RootObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3527707, crash on w3c css page. Make sure height isn't allowed to be negati...
hyatt [Wed, 14 Jan 2004 02:32:21 +0000 (02:32 +0000)]
Fix for 3527707, crash on w3c css page.  Make sure height isn't allowed to be negative when computing
positioned elements' heights.  Also bulletproof the crash in case there are other negative height code
paths.

        Reviewed by john

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::layoutBlock):
        (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats):
        * khtml/rendering/render_box.cpp:
        (RenderBox::calcAbsoluteVertical):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
mjs [Wed, 14 Jan 2004 01:12:45 +0000 (01:12 +0000)]
    Reviewed by Darin.

<rdar://problem/3527853>: REGRESSION (119-120): Peoplesoft menus do not work

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::scrollToAnchor): Right before calling checkCompleted(), set
m_bComplete to false, so it can get set right back to true if we're actually done
loading and fire all the right signals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3526710, applets need to have the correct initial size after a layout has...
hyatt [Tue, 13 Jan 2004 19:36:56 +0000 (19:36 +0000)]
Fix for 3526710, applets need to have the correct initial size after a layout has been done, since our
Java applets can't yet resize.

        Reviewed by john

        * khtml/rendering/render_applet.cpp:
        (RenderApplet::createWidgetIfNecessary):
        (RenderApplet::layout):
        (RenderEmptyApplet::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agochanged version number from '121' to '122u'
vicki [Mon, 12 Jan 2004 00:42:18 +0000 (00:42 +0000)]
changed version number from '121' to '122u'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-121 stamp
vicki [Mon, 12 Jan 2004 00:27:56 +0000 (00:27 +0000)]
Safari-121 stamp

(Ordinarily this checkin would show the version number change to project.pbxproj files, but I accidentally changed the version number to '121' instead of '121u' when I opened the tree after Safari-120.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed Dave's check-in so it compiles; I assume he forgot to land one source...
darin [Sun, 11 Jan 2004 20:09:38 +0000 (20:09 +0000)]
    - fixed Dave's check-in so it compiles; I assume he forgot to land one source file

        * khtml/khtmlview.h: Add RenderPart to the friends of KHTMLView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for frame repainting bugs (3510669, 3515442). This is a narrower fix than the...
hyatt [Sun, 11 Jan 2004 19:06:35 +0000 (19:06 +0000)]
Fix for frame repainting bugs (35106693515442).  This is a narrower fix than the previous attempt.

        Reviewed by darin

        * khtml/rendering/render_frames.cpp:
        (RenderPart::updateWidgetPositions):
        * khtml/rendering/render_frames.h:
        * khtml/rendering/render_replaced.cpp:
        (RenderWidget::updateWidgetPositions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Sun, 11 Jan 2004 00:08:32 +0000 (00:08 +0000)]
    Reviewed by John.

        - fixed 3524906: REGRESSION (114-115): page with plug-in content never stops loading (travelking.com.tw)

        Put the plug-in streams clients into their own separate set. Now a plug-in client is not considered part
        of "loading", but it does participate in the callback deferral mechanism, which was the real goal of the
        change I made that introduced this regression. Also remove the plug-in client in one case I had missed
        before (cancel).

        * WebView.subproj/WebDataSourcePrivate.h: Added a new set of plugInStreamClients.
        * WebView.subproj/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]): Release the set.
        (-[WebDataSource _addPlugInStreamClient:]): Added. Adds to the set.
        (-[WebDataSource _removePlugInStreamClient:]): Added. Removes from the set.
        (-[WebDataSource _defersCallbacksChanged]): Added code to loop through plugInStreamClients too.

        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream start]): Use _add/removePlugInStreamClient instead of _add/removeSubresourceClient.
        (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): Ditto.
        (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): Ditto.
        (-[WebNetscapePluginConnectionDelegate cancelWithError:]): Override to call _removePlugInStreamClient and
        then call super.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Sat, 10 Jan 2004 20:10:03 +0000 (20:10 +0000)]
    Reviewed by John.

        - fixed 3525468: REGRESSION (114-115): HOMEPAGE: after hitting textarea limit, backspace key is ignored

        * kwq/KWQEvent.mm:
        (keyIdentifierForKeyEvent): Treat 7F as 08; matches other browsers.
        (QKeyEvent::QKeyEvent): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - rolled out most of Dave's change for 3510669 and 3515442; it is not working yet
darin [Sat, 10 Jan 2004 00:44:54 +0000 (00:44 +0000)]
    - rolled out most of Dave's change for 3510669 and 3515442; it is not working yet

        * WebView.subproj/WebHTMLViewPrivate.h:
        * WebView.subproj/WebHTMLView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Chris.
mjs [Fri, 9 Jan 2004 23:31:02 +0000 (23:31 +0000)]
    Reviewed by Chris.

<rdar://problem/3514446>: cert downloaded from BofA or MIT is rejected (ACL issue on private key?)

* WebCoreSupport.subproj/WebKeyGeneration.cpp:
        (createPair): Cut & paste hunk of code from Security framework.
        (Safari_SecKeyCreatePair): Ditto.
        (signedPublicKeyAndChallengeString): Instead of creating a normal ACL,
use our hacked version of the SecKeyCreatePair call that doesn't put in
any kind of ACL. This works around a SecureTransport bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's use of a...
hyatt [Fri, 9 Jan 2004 22:47:11 +0000 (22:47 +0000)]
Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's use of a separate needsLayout boolean.

        Reviewed by darin

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge setNeedsLayout]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's resizing...
hyatt [Fri, 9 Jan 2004 22:43:31 +0000 (22:43 +0000)]
Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's resizing not scheduling actual
layouts via WebCore.

        Reviewed by darin

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]):
        (-[WebHTMLView initWithFrame:]):
        (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
        (-[WebHTMLView setNeedsLayout:]):
        * WebView.subproj/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Chris.
darin [Fri, 9 Jan 2004 20:11:49 +0000 (20:11 +0000)]
    Reviewed by Chris.

        - fixed 3510805: "PoolCleaner" in Carbon WebKit leads to overrelease and crash using color picker in BBEdit

        * Carbon.subproj/CarbonUtils.m: (PoolCleaner): Only do the autorelease
        pool stuff in the default run loop mode. If we're in another run loop
        mode that means we are in some Cocoa code that sets up its own autorelease
        pool; it's important that we don't release ours in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3524118, floats don't repaint when moved.
hyatt [Fri, 9 Jan 2004 01:49:24 +0000 (01:49 +0000)]
Fix for 3524118, floats don't repaint when moved.

        Reviewed by darin

         * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::positionNewFloats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
mjs [Thu, 8 Jan 2004 23:47:22 +0000 (23:47 +0000)]
    Reviewed by John.

<rdar://problem/3522298>: Error on MIT's x509 certificate site

        * WebCoreSupport.subproj/WebKeyGeneration.cpp:
        (addCertificatesToKeychainFromData): Sign the freshly minted public key
using RSA/MD5 instead of RSA/SHA-1, because MIT only supports MD5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3524430. This was a regression introduced when we added '-' and '?' to the...
rjw [Thu, 8 Jan 2004 23:36:45 +0000 (23:36 +0000)]
Fixed 3524430.  This was a regression introduced when we added '-' and '?' to the word boundary detection.

Also backed out workaround for 3521759 as it's no longer needed with correct argument passing to ATSUPositionToOffset.

        Reviewed by Hyatt.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):
        (widthForNextCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3519003, crash in mail because <dir> and <menu> don't allow the same childre...
hyatt [Thu, 8 Jan 2004 23:35:58 +0000 (23:35 +0000)]
Fix for 3519003, crash in mail because <dir> and <menu> don't allow the same children as <ul> and <ol>.

        Reviewed by darin

        * khtml/html/dtd.cpp:
        (DOM::checkChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3522900>: REGRESSION (100-117): Java plug-in description...
cblu [Thu, 8 Jan 2004 23:07:53 +0000 (23:07 +0000)]
Fixed: <rdar://problem/3522900>: REGRESSION (100-117): Java plug-in description is garbled when displaying Plug-ins.html

        Reviewed by darin.

        * Misc.subproj/WebKitNSStringExtras.h:
        * Misc.subproj/WebKitNSStringExtras.m:
        (+[NSString _web_encodingForResource:]): new method, returns the encoding for a resource handle given its file system path
        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): call _web_encodingForResource when creating the NSString

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed <rdar://problem/3524359>: REGRESSSION (119-120):
sullivan [Thu, 8 Jan 2004 22:23:27 +0000 (22:23 +0000)]
    - fixed <rdar://problem/3524359>: REGRESSSION (119-120):
        Double click to select text in form broken

        Reviewed by Dave and Darin.

        * khtml/khtmlview.cpp:
        (KHTMLView::dispatchMouseEvent):
        Don't blur the focused node if that's the one you clicked on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
rjw [Thu, 8 Jan 2004 00:45:31 +0000 (00:45 +0000)]
WebCore:
Fixed 3517550.  Named array lookup of applet failed, i.e.:
var appletobj = document.applets['myapplet']

        Reviewed by Chris.

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLCollection::getNamedItems):

Tests:
        Added lookup test for all three variants of applet access:
        named, indexed array, and named array.

        * LiveConnect/Blink/Blink.java:
        (Blink):
        (Blink.init):
        * LiveConnect/Blink/Blink.pbproj/project.pbxproj:
        * LiveConnect/Blink/test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agook, back to 121u now. tree is still closed.
vicki [Wed, 7 Jan 2004 18:58:19 +0000 (18:58 +0000)]
ok, back to 121u now.  tree is still closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agosilly me. i forgot to actually tag before updating the version number to 121u.
vicki [Wed, 7 Jan 2004 18:51:28 +0000 (18:51 +0000)]
silly me.  i forgot to actually tag before updating the version number to 121u.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoset version number to 121u -- the tree is still closed
vicki [Wed, 7 Jan 2004 18:35:37 +0000 (18:35 +0000)]
set version number to 121u -- the tree is still closed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-120 stamp
vicki [Wed, 7 Jan 2004 18:32:54 +0000 (18:32 +0000)]
Safari-120 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Possible fix for table bugs 3510005 and 3492945, repainting glitches that occurred...
hyatt [Wed, 7 Jan 2004 01:15:20 +0000 (01:15 +0000)]
Possible fix for table bugs 3510005 and 3492945, repainting glitches that occurred when table cells moved.

Fix for 33522497, empty AXElements appear in AXBrowser.

        Reviewed by darin

        * khtml/rendering/render_table.cpp:
        (RenderTableSection::layoutRows):
        (RenderTableCell::setWidth):
        * khtml/rendering/render_table.h:

        * kwq/KWQAccObject.mm:
        (-[KWQAccObject accessibilityIsIgnored]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed <rdar://problem/3484465>: REGRESSION (118): button click does
sullivan [Tue, 6 Jan 2004 23:39:26 +0000 (23:39 +0000)]
    - fixed <rdar://problem/3484465>: REGRESSION (118): button click does
        not take focus away from <textarea>; breaks Outlook Web Access

        Reviewed by Dave.

        * khtml/khtmlview.cpp:
        (KHTMLView::dispatchMouseEvent):
        Removed nodeimpl == nil test that was preventing button/link clicks
        from blurring previously-focused text field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3513660. Make ATSU layout and draw with integer glyph boundaries. This fix...
rjw [Tue, 6 Jan 2004 23:09:01 +0000 (23:09 +0000)]
Fixed 3513660.  Make ATSU layout and draw with integer glyph boundaries.  This fix should be removed if/when we convert WebCore to use floats for measuring/positioning (3521781).

        Reviewed by John.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _createATSUTextLayoutForRun:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoI meant kMax not kMin here.
hyatt [Tue, 6 Jan 2004 21:59:14 +0000 (21:59 +0000)]
I meant kMax not kMin here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3521814. Finalize messages weren't being dispatched!
rjw [Tue, 6 Jan 2004 21:55:38 +0000 (21:55 +0000)]
Fixed 3521814.  Finalize messages weren't being dispatched!

        Reviewed by John.

        * bindings/jni_jsobject.cpp:
        (JSObject::invoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3520636, infinite loop in page breaking code when printing.
hyatt [Tue, 6 Jan 2004 20:52:18 +0000 (20:52 +0000)]
Fix for 3520636, infinite loop in page breaking code when printing.

        Reviewed by darin

        * khtml/rendering/render_text.cpp:
        (RenderText::paintObject):
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge computePageRectsWithPrintWidth:printHeight:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3521466, generated image content should not try to calcWidth/height when...
hyatt [Mon, 5 Jan 2004 23:24:20 +0000 (23:24 +0000)]
Fix for 3521466, generated image content should not try to calcWidth/height when it isn't yet rooted in
the rendering tree.

        Reviewed by john

        * khtml/rendering/render_image.cpp:
        (RenderImage::setPixmap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3514454. Work-around added for 3521759.
rjw [Mon, 5 Jan 2004 22:52:28 +0000 (22:52 +0000)]
Fix for 3514454.  Work-around added for 3521759.

Filed 3521781 to cover deeper problem.

        Reviewed by Kocienda.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Added cache of JNI method IDs to minimize allocations. This mitigates the problem
rjw [Mon, 5 Jan 2004 17:44:58 +0000 (17:44 +0000)]
Added cache of JNI method IDs to minimize allocations.  This mitigates the problem
described by 3515579.

Also cleanup up logging of Java exceptions.

        Reviewed by John.

        * bindings/jni/jni_class.cpp:
        (JavaClass::classForInstance):
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::JavaInstance):
        (JavaInstance::getClass):
        (JavaInstance::invokeMethod):
        (JObjectWrapper::JObjectWrapper):
        (JObjectWrapper::~JObjectWrapper):
        * bindings/jni/jni_instance.h:
        (KJS::Bindings::JavaInstance::operator=):
        * bindings/jni/jni_runtime.cpp:
        (JavaMethod::JavaMethod):
        (JavaMethod::methodID):
        * bindings/jni/jni_runtime.h:
        (KJS::Bindings::JavaMethod::JavaMethod):
        * bindings/jni/jni_utility.cpp:
        (callJNIMethod):
        (callJNIMethodIDA):
        (callJNIMethodA):
        (KJS::Bindings::getMethodID):
        (KJS::Bindings::callJNIVoidMethodIDA):
        (KJS::Bindings::callJNIObjectMethodIDA):
        (KJS::Bindings::callJNIByteMethodIDA):
        (KJS::Bindings::callJNICharMethodIDA):
        (KJS::Bindings::callJNIShortMethodIDA):
        (KJS::Bindings::callJNIIntMethodIDA):
        (KJS::Bindings::callJNILongMethodIDA):
        (KJS::Bindings::callJNIFloatMethodIDA):
        (KJS::Bindings::callJNIDoubleMethodIDA):
        (KJS::Bindings::callJNIBooleanMethodIDA):
        (KJS::Bindings::getCharactersFromJStringInEnv):
        (KJS::Bindings::getUCharactersFromJStringInEnv):
        (KJS::Bindings::getJNIField):
        * bindings/jni/jni_utility.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoTweak some old ChangeLog entries (mostly removed "removed by me").
darin [Fri, 26 Dec 2003 22:21:51 +0000 (22:21 +0000)]
Tweak some old ChangeLog entries (mostly removed "removed by me").

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFix change log entry.
darin [Fri, 26 Dec 2003 16:56:25 +0000 (16:56 +0000)]
Fix change log entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - one more small step to make -[KWQPageState dealloc] safer
darin [Fri, 26 Dec 2003 15:57:57 +0000 (15:57 +0000)]
    - one more small step to make -[KWQPageState dealloc] safer

        * kwq/KWQPageState.mm: (-[KWQPageState dealloc]): Only do the real detach() if the
        document is already in the detached state; we don't want to detach twice.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoJavaScriptCore:
sullivan [Wed, 24 Dec 2003 01:50:24 +0000 (01:50 +0000)]
JavaScriptCore:

        * JavaScriptCore.pbproj/project.pbxproj:
        Xcode version wars, harmless

WebCore:

        - fixed <rdar://problem/3451306>: address book search fails at Airborne
        Express Corporate site (Apple Shipping wants to use it)

        Reviewed by Darin.

        * khtml/ecma/kjs_html.cpp:
        commented out definition of document.all; now sites like this one that
        set document.all to a value will work.
        * khtml/ecma/kjs_html.lut.h:
        (KJS::):
        regenerated this file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John (concept, not code, which is just the old code coming back).
darin [Wed, 24 Dec 2003 00:37:30 +0000 (00:37 +0000)]
    Reviewed by John (concept, not code, which is just the old code coming back).

        - fixed 3518092: REGRESSION (100-119): getting NaN instead of HH:MM times

        * kjs/date_object.cpp: Added back our CF-based implementations of gmtime, localtime,
        mktime, timegm, and time, because mktime, at least, won't handle a year of 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFix some old malformed log entries.
darin [Tue, 23 Dec 2003 23:52:44 +0000 (23:52 +0000)]
Fix some old malformed log entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Tue, 23 Dec 2003 23:52:15 +0000 (23:52 +0000)]
    Reviewed by John.

        - another try at fixing the -[KWQPageState dealloc] bug, even though we don't fully understand it

        This change saves the renderer inside the document rather than in the KWQPageState to
        try to eliminate the possibility that multiple KWQPageState objects could restore the
        same renderer multiple times, resulting in multiple detaches of the same renderer.

        * khtml/xml/dom_docimpl.h: Add a m_savedRenderer field.
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::DocumentImpl): Initialize m_savedRenderer to 0.
        (DocumentImpl::~DocumentImpl): Added some asserts to make sure we don't get destroyed
        while we are in the page cache.
        (DocumentImpl::attach): Added an assert.
        (DocumentImpl::setInPageCache): Save the renderer when setting the flag, and restore
        the renderer when clearing it.

        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Instead of doing a restoreRenderer
        call, just do setInPageCache(NO), which will restore the renderer as a side effect.

        * kwq/KWQPageState.h: Removed the renderer method and field.
        * kwq/KWQPageState.mm:
        (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]):
        Don't store a pointer to the renderer.
        (-[KWQPageState clear]): New method, shared by invalidate and dealloc.
        (-[KWQPageState invalidate]): Removed code relating to "relinquishing object ownership";
        just deallocate everything here without doing a detach().
        (-[KWQPageState dealloc]): Removed restoreRenderer now that setInPageCache(NO) handles that.
        Added some assertions. Share code with invalidate by calling clear.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed <rdar://problem/3508798>: ACCESSIBILITY: role/description/value strin...
sullivan [Mon, 22 Dec 2003 22:30:01 +0000 (22:30 +0000)]
    - fixed <rdar://problem/3508798>: ACCESSIBILITY: role/description/value strings not defined

        Reviewed by Darin.

        * kwq/KWQAccObject.mm:
        (-[KWQAccObject roleDescription]):
        provide not-yet-localized strings for all the role descriptions that this class uses.
        (-[KWQAccObject value]):
        return nil string rather than dummy string for the cases where we don't have a value attribute.
        (-[KWQAccObject accessibilityActionDescription:]):
        changed comment passed to UI_STRING bogus macro so it won't have to change if/when macro
        loses its bogosity

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
sullivan [Mon, 22 Dec 2003 19:32:49 +0000 (19:32 +0000)]
WebCore:

- WebCore part of fix for <rdar://problem/3515706>:
REGRESSION (100-118): Web Kit printing does not honor Page Setup scale factor

        Reviewed by Darin.

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge computePageRectsWithPrintWidth:printHeight:]):
renamed method for clarity; now iterates over pages horizontally as well
as vertically; assume x starts at 0 as we were already assuming that y
starts at 0; now returns autoreleased result

WebKit:

- WebKit part of fix for <rdar://problem/3515706>:
REGRESSION (100-118): Web Kit printing does not honor Page Setup scale factor

        Reviewed by Darin.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _userScaleFactorForPrintOperation:]):
new method, extracts the scale factor provided by the user in
the Page Setup dialog
        (-[WebHTMLView _scaleFactorForPrintOperation:]):
take user scale factor into account
        (-[WebHTMLView knowsPageRange:]):
renamed local var scaleFactor -> totalScaleFactor for clarity;
take user scale factor into account for print width; now assumes
        computePageRects returns autoreleased result.

        * WebKit.pbproj/project.pbxproj:
Xcode version wars; Darin says these don't affect the build.

WebBrowser:

        Reviewed by Darin.

        * WebBrowser.pbproj/project.pbxproj:
Xcode version wars; Darin says these don't affect the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Mon, 22 Dec 2003 19:26:16 +0000 (19:26 +0000)]
    Reviewed by John.

        - follow-on to my fix for 3467919: handle collapsed spaces at the starts of runs too, not just at the
          end, and make sure that a space inherits style from the run it was collapsed from rather than always
          from the run it precedes

        * khtml/khtml_part.cpp: (KHTMLPart::text): Add code to deal with collapsed spaces at the start of runs.
        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Change code to keep the style of a space that
        was collapsed at the end of the run, and use that styled space if necessary. Also add the code to deal
        with collapsed spaces at the start of runs. Also remove comment that refers to long-since-deleted code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Mon, 22 Dec 2003 17:42:56 +0000 (17:42 +0000)]
    Reviewed by John.

        - fixed 3467919: REGRESSION (91-92): space missing when copying text with link at start or end of line

        * khtml/khtml_part.cpp: (KHTMLPart::text):
        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
        Changed both "turn HTML into text" code paths to generate spaces in a different way.
        First, corrected the logic so it notices spaces left out at the end of a RenderText object.
        Second, don't emit the space until we are emitting more text, to prevent emitting trailing
        spaces. To get this completely right for the attributed string case, I had to add code to
        adjust the offset used to mark links.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Mon, 22 Dec 2003 17:40:38 +0000 (17:40 +0000)]
    Reviewed by John.

        - fixed 3477453: nowrap in a fixed-width TD is ignored on screen but not when printed (Williams-Sonoma)

        * khtml/rendering/render_table.cpp: (RenderTableCell::setStyle):
        Compute the proper whitespace mode before calling the base class setStyle,
        since the base class setStyle may create styles that inherit from our style,
        and we want them to inherit the computed whitespace mode.

        * WebCore.pbproj/project.pbxproj: Let Xcode be 1.1, as it was meant to be.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Sun, 21 Dec 2003 20:42:30 +0000 (20:42 +0000)]
    Reviewed by John.

        - fixed a storage leak

        * WebView.subproj/WebFrame.m:
        (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        Move the release of the request out of an if statement, since it's always needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Sun, 21 Dec 2003 20:40:23 +0000 (20:40 +0000)]
    Reviewed by Dave.

        - fixed a storage leak

        * khtml/rendering/render_style.h: Added a destructor and a private unimplemented assignment
        operator to StyleCSS3InheritedData, since the textShadow field that needs to be allocated
        and deallocated and the default destructor and assignment operator don't do that.
        * khtml/rendering/render_style.cpp: (StyleCSS3InheritedData::~StyleCSS3InheritedData):
        Added destructor that deletes the textShadow object.

        - fixed locking for JavaScript debugging tools in Caches window

        * kwq/WebCoreJavaScript.mm:
        (+[WebCoreJavaScript rootObjectClasses]): Lock and unlock around call to JavaScriptCore.
        (+[WebCoreJavaScript garbageCollect]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3483130, repaint doesn't occur when font is decreased dynamically when at...
hyatt [Sat, 20 Dec 2003 05:16:32 +0000 (05:16 +0000)]
Fix for 3483130, repaint doesn't occur when font is decreased dynamically when at the bottom of
amazon.com.

        Reviewed by john

        * khtml/khtml_part.cpp:
        (KHTMLPart::setZoomFactor):
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge setTextSizeMultiplier:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3515590. Return Undefined to JS for applet if
rjw [Fri, 19 Dec 2003 23:06:41 +0000 (23:06 +0000)]
Fixed 3515590.  Return Undefined to JS for applet if
Java is disabled.

        Reviewed by Chris.

        * khtml/html/html_objectimpl.cpp:
        (HTMLAppletElementImpl::getAppletInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3515597. When an error occurs we need
rjw [Fri, 19 Dec 2003 21:55:27 +0000 (21:55 +0000)]
Fixed 3515597.  When an error occurs we need
to make sure result values are zeroed.

Cleaned up logs by adding a newline.

        Reviewed by John.

        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::getJavaVM):
        (KJS::Bindings::getJNIEnv):
        (callJNIMethod):
        (callJNIMethodA):
        (KJS::Bindings::getJNIField):
        * bindings/jni_jsobject.cpp:
        (JSObject::convertValueToJObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Chris.
mjs [Fri, 19 Dec 2003 21:25:31 +0000 (21:25 +0000)]
    Reviewed by Chris.

<rdar://problem/3512545>: reproducible assertion failure in KWQKHTMLPart::addData scrolling to anchor while page loads

* kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::scrollToAnchor): Don't pretend we finished loading,
because we don't actually make anchor scrolling stop the current
page load.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3515255>: Standalone image drag makes ocassionally makes...
cblu [Fri, 19 Dec 2003 17:59:05 +0000 (17:59 +0000)]
Fixed: <rdar://problem/3515255>: Standalone image drag makes ocassionally makes 2 copies

        Reviewed by john.

* WebKit.pbproj/project.pbxproj: Xcode 1.1 file format change
        * WebView.subproj/WebImageView.h:
        * WebView.subproj/WebImageView.m: copied double-drag protection code from WebHTMLView
        (-[WebImageView mouseDown:]): set ignoringMouseDraggedEvents to NO
        (-[WebImageView mouseDragged:]): if ignoringMouseDraggedEvents, return
        (-[WebImageView draggedImage:endedAt:operation:]): set ignoringMouseDraggedEvents to YES

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago*** empty log message ***
vicki [Fri, 19 Dec 2003 17:46:35 +0000 (17:46 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agotop level:
vicki [Fri, 19 Dec 2003 17:37:48 +0000 (17:37 +0000)]
top level:

        Reviewed by me

        * Site/Internal/Design/html-editing-tasks.fp5: Added.

Tools:

- disallow installation on 10.3.2 and later; update strings with better error messages

* Install_resources/InstallationCheck:
        * Install_resources/InstallationCheck.strings:

JavaScriptCore:

Ensure that all the symbols we export are in the KJS
namespace (3512245).

Also renamed JavaString.characters() to JavaString.UTF8String()
for enhanced clarity.

Added some sanity checking to constructor of JObjectWrapper.

        Reviewed by Dave.

        * ChangeLog:
        * bindings/jni/jni_class.cpp:
        * bindings/jni/jni_class.h:
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        (JObjectWrapper::JObjectWrapper):
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        (JavaParameter::JavaParameter):
        (JavaField::JavaField):
        (JavaMethod::JavaMethod):
        (JavaMethod::signature):
        * bindings/jni/jni_runtime.h:
        (KJS::Bindings::JavaString::ascii):
        (KJS::Bindings::JavaString::UTF8String):
        (KJS::Bindings::JavaString::JavaString):
        (KJS::Bindings::JavaString::_commonInit):
        (KJS::Bindings::JavaString::uchars):
        (KJS::Bindings::JavaString::length):
        (KJS::Bindings::JavaString::ustring):
        (KJS::Bindings::JavaParameter::type):
        (KJS::Bindings::JavaField::name):
        (KJS::Bindings::JavaField::type):
        (KJS::Bindings::JavaMethod::name):
        (KJS::Bindings::JavaMethod::returnType):
        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::getJavaVM):
        (KJS::Bindings::getJNIEnv):
        (KJS::Bindings::callJNIVoidMethod):
        (KJS::Bindings::callJNIObjectMethod):
        (KJS::Bindings::callJNIBooleanMethod):
        (KJS::Bindings::callJNIByteMethod):
        (KJS::Bindings::callJNICharMethod):
        (KJS::Bindings::callJNIShortMethod):
        (KJS::Bindings::callJNIIntMethod):
        (KJS::Bindings::callJNILongMethod):
        (KJS::Bindings::callJNIFloatMethod):
        (KJS::Bindings::callJNIDoubleMethod):
        (KJS::Bindings::callJNIVoidMethodA):
        (KJS::Bindings::callJNIObjectMethodA):
        (KJS::Bindings::callJNIByteMethodA):
        (KJS::Bindings::callJNICharMethodA):
        (KJS::Bindings::callJNIShortMethodA):
        (KJS::Bindings::callJNIIntMethodA):
        (KJS::Bindings::callJNILongMethodA):
        (KJS::Bindings::callJNIFloatMethodA):
        (KJS::Bindings::callJNIDoubleMethodA):
        (KJS::Bindings::callJNIBooleanMethodA):
        (KJS::Bindings::getCharactersFromJString):
        (KJS::Bindings::releaseCharactersForJString):
        (KJS::Bindings::getCharactersFromJStringInEnv):
        (KJS::Bindings::releaseCharactersForJStringInEnv):
        (KJS::Bindings::getUCharactersFromJStringInEnv):
        (KJS::Bindings::releaseUCharactersForJStringInEnv):
        (KJS::Bindings::JNITypeFromClassName):
        (KJS::Bindings::signatureFromPrimitiveType):
        (KJS::Bindings::JNITypeFromPrimitiveType):
        (KJS::Bindings::getJNIField):
        (KJS::Bindings::convertValueToJValue):
        * bindings/jni/jni_utility.h:
        * bindings/jni_jsobject.cpp:
        (KJS::Bindings::JSObject::invoke):
        (KJS::Bindings::JSObject::JSObject):
        (KJS::Bindings::JSObject::call):
        (KJS::Bindings::JSObject::eval):
        (KJS::Bindings::JSObject::getMember):
        (KJS::Bindings::JSObject::setMember):
        (KJS::Bindings::JSObject::removeMember):
        (KJS::Bindings::JSObject::getSlot):
        (KJS::Bindings::JSObject::setSlot):
        (KJS::Bindings::JSObject::toString):
        (KJS::Bindings::JSObject::finalize):
        (KJS::Bindings::JSObject::createNative):
        (KJS::Bindings::JSObject::convertValueToJObject):
        (KJS::Bindings::JSObject::convertJObjectToValue):
        (KJS::Bindings::JSObject::listFromJArray):
        * bindings/jni_jsobject.h:
        * bindings/runtime.cpp:
        * bindings/runtime.h:
        * bindings/runtime_method.cpp:
        * bindings/runtime_method.h:

Tests:

        LiveConnect:  Added tests for JavaScript to Java
        array access.

        Reviewed by John.

        * LiveConnect/Blink/Blink.java:
        (Blink):
        (Blink.init):
        * LiveConnect/Blink/test.html:

WebCore:

Fixed 3511415.  We have to un-visually order visually ordered text
before passing to ATSU.

        Reviewed by John.

        * khtml/rendering/font.cpp:
        (Font::drawHighlightForText):
        (Font::drawText):
        * khtml/rendering/font.h:
        * khtml/rendering/render_text.cpp:
        (InlineTextBox::paintSelection):
        (RenderText::paintObject):
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        (QPainter::drawText):
        (QPainter::drawHighlightForText):
        * kwq/WebCoreTextRenderer.h:
        * kwq/WebCoreTextRendererFactory.m:
        (WebCoreInitializeEmptyTextStyle):

WebKit:

Fixed 3511415.  We have to un-visually order visually ordered text
before passing to ATSU.

        Reviewed by John.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (reverseCharactersInRun):
        (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

WebBrowser:

        Reviewed by Chris

        * BrowserNSDataExtras.m:
        (-[NSData certificateFromMultipartData]): Fix off-by-one error
in code to strip trailing CRLFs off certificate data.

WebKitExamples:

Fixed 3455347.  WEBVIEW: Dragging links from a Carbon HIWebView crash with NSException raise
Written be Ed.  This code is often copy/pasted by developers, so this problem propagates.

        Reviewed by Richard.

        * CarbonWeb/CarbonWeb.pbproj/project.pbxproj:
        * CarbonWeb/TWebWindow.cp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebKit:
rjw [Thu, 18 Dec 2003 23:14:44 +0000 (23:14 +0000)]
WebKit:
Fixed 3511415.  We have to un-visually order visually ordered text
before passing to ATSU.

        Reviewed by John.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (reverseCharactersInRun):
        (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

WebCore:
Fixed 3511415.  We have to un-visually order visually ordered text
before passing to ATSU.

        Reviewed by John.

        * khtml/rendering/font.cpp:
        (Font::drawHighlightForText):
        (Font::drawText):
        * khtml/rendering/font.h:
        * khtml/rendering/render_text.cpp:
        (InlineTextBox::paintSelection):
        (RenderText::paintObject):
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        (QPainter::drawText):
        (QPainter::drawHighlightForText):
        * kwq/WebCoreTextRenderer.h:
        * kwq/WebCoreTextRendererFactory.m:
        (WebCoreInitializeEmptyTextStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFixed build problem resulting from addition of KJS to Bindings namespace.
rjw [Thu, 18 Dec 2003 03:56:28 +0000 (03:56 +0000)]
Fixed build problem resulting from addition of KJS to Bindings namespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Ensure that all the symbols we export are in the KJS
rjw [Thu, 18 Dec 2003 02:49:17 +0000 (02:49 +0000)]
Ensure that all the symbols we export are in the KJS
namespace (3512245).

Also renamed JavaString.characters() to JavaString.UTF8String()
for enhanced clarity.

Added some sanity checking to constructor of JObjectWrapper.

        Reviewed by Dave.

        * ChangeLog:
        * bindings/jni/jni_class.cpp:
        * bindings/jni/jni_class.h:
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        (JObjectWrapper::JObjectWrapper):
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        (JavaParameter::JavaParameter):
        (JavaField::JavaField):
        (JavaMethod::JavaMethod):
        (JavaMethod::signature):
        * bindings/jni/jni_runtime.h:
        (KJS::Bindings::JavaString::ascii):
        (KJS::Bindings::JavaString::UTF8String):
        (KJS::Bindings::JavaString::JavaString):
        (KJS::Bindings::JavaString::_commonInit):
        (KJS::Bindings::JavaString::uchars):
        (KJS::Bindings::JavaString::length):
        (KJS::Bindings::JavaString::ustring):
        (KJS::Bindings::JavaParameter::type):
        (KJS::Bindings::JavaField::name):
        (KJS::Bindings::JavaField::type):
        (KJS::Bindings::JavaMethod::name):
        (KJS::Bindings::JavaMethod::returnType):
        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::getJavaVM):
        (KJS::Bindings::getJNIEnv):
        (KJS::Bindings::callJNIVoidMethod):
        (KJS::Bindings::callJNIObjectMethod):
        (KJS::Bindings::callJNIBooleanMethod):
        (KJS::Bindings::callJNIByteMethod):
        (KJS::Bindings::callJNICharMethod):
        (KJS::Bindings::callJNIShortMethod):
        (KJS::Bindings::callJNIIntMethod):
        (KJS::Bindings::callJNILongMethod):
        (KJS::Bindings::callJNIFloatMethod):
        (KJS::Bindings::callJNIDoubleMethod):
        (KJS::Bindings::callJNIVoidMethodA):
        (KJS::Bindings::callJNIObjectMethodA):
        (KJS::Bindings::callJNIByteMethodA):
        (KJS::Bindings::callJNICharMethodA):
        (KJS::Bindings::callJNIShortMethodA):
        (KJS::Bindings::callJNIIntMethodA):
        (KJS::Bindings::callJNILongMethodA):
        (KJS::Bindings::callJNIFloatMethodA):
        (KJS::Bindings::callJNIDoubleMethodA):
        (KJS::Bindings::callJNIBooleanMethodA):
        (KJS::Bindings::getCharactersFromJString):
        (KJS::Bindings::releaseCharactersForJString):
        (KJS::Bindings::getCharactersFromJStringInEnv):
        (KJS::Bindings::releaseCharactersForJStringInEnv):
        (KJS::Bindings::getUCharactersFromJStringInEnv):
        (KJS::Bindings::releaseUCharactersForJStringInEnv):
        (KJS::Bindings::JNITypeFromClassName):
        (KJS::Bindings::signatureFromPrimitiveType):
        (KJS::Bindings::JNITypeFromPrimitiveType):
        (KJS::Bindings::getJNIField):
        (KJS::Bindings::convertValueToJValue):
        * bindings/jni/jni_utility.h:
        * bindings/jni_jsobject.cpp:
        (KJS::Bindings::JSObject::invoke):
        (KJS::Bindings::JSObject::JSObject):
        (KJS::Bindings::JSObject::call):
        (KJS::Bindings::JSObject::eval):
        (KJS::Bindings::JSObject::getMember):
        (KJS::Bindings::JSObject::setMember):
        (KJS::Bindings::JSObject::removeMember):
        (KJS::Bindings::JSObject::getSlot):
        (KJS::Bindings::JSObject::setSlot):
        (KJS::Bindings::JSObject::toString):
        (KJS::Bindings::JSObject::finalize):
        (KJS::Bindings::JSObject::createNative):
        (KJS::Bindings::JSObject::convertValueToJObject):
        (KJS::Bindings::JSObject::convertJObjectToValue):
        (KJS::Bindings::JSObject::listFromJArray):
        * bindings/jni_jsobject.h:
        * bindings/runtime.cpp:
        * bindings/runtime.h:
        * bindings/runtime_method.cpp:
        * bindings/runtime_method.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3503011 (really, this time). Always use integer width for '-' and '?', as...
rjw [Thu, 18 Dec 2003 01:41:41 +0000 (01:41 +0000)]
Fixed 3503011 (really, this time).  Always use integer width for '-' and '?', as we do for spaces, to ensure that 'words' (as defined by out rounding hack) start on integer boundaries.

        Reviewed by John.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (widthForNextCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed:
cblu [Thu, 18 Dec 2003 00:44:19 +0000 (00:44 +0000)]
Fixed:
<rdar://problem/3393758>: REGRESSION (85-100): Flash onKeyUp event non-functional
<rdar://problem/3479020>: REGRESSION (85-100): Safari sends plug-in key events to wrong instance of plug-in

        Reviewed by darin.

        * Plugins.subproj/WebBaseNetscapePluginView.h:
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView sendEvent:]): set suspendKeyUpEvents to NO
        (-[WebBaseNetscapePluginView keyMessageForEvent:]): copied from CVS
        (-[WebBaseNetscapePluginView keyUp:]): if !suspendKeyUpEvents, send the keyUp event
        (-[WebBaseNetscapePluginView keyDown:]): set suspendKeyUpEvents to YES
        (-[WebBaseNetscapePluginView windowBecameKey:]): call SetUserFocusWindow

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Richard.
darin [Thu, 18 Dec 2003 00:38:32 +0000 (00:38 +0000)]
    Reviewed by Richard.

        - fixed 3513274: REGRESSION: anchor navigation within frames with "Back" is broken at tivofaq.com

        * WebView.subproj/WebDataSource.m: (-[WebDataSource _setURL:]):
        Since this method is only used when you do a fragment scroll, we need to update
        the original request as well as the request. This ensure that the fragment gets
        recorded in the history item (which goes in the back/forward history).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Wed, 17 Dec 2003 23:48:54 +0000 (23:48 +0000)]
    Reviewed by Dave.

        - fixed 3469085: can't tab to all links on aintitcool.com

        * khtml/html/html_inlineimpl.cpp:
        (HTMLAnchorElementImpl::isFocusable): Re-implemented this to check width and height of
        all continuations, not just the main render object. Also, check the absoluteRects after
        checking all the render objects to catch things like floats.
        (HTMLAnchorElementImpl::isMouseFocusable): Clean up the code here a bit.

        * khtml/rendering/render_inline.h:
        * khtml/rendering/render_inline.cpp: (RenderInline::absoluteRects):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_object.cpp: (RenderObject::absoluteRects):
        * khtml/rendering/render_text.h:
        * khtml/rendering/render_text.cpp: (RenderText::absoluteRects):
        * kwq/KWQAccObject.mm: (boundingBoxRect):
        Use QValueList instead of QPtrList for clarity and to fix storage leaks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoThe tree is open for Safari-119!
vicki [Wed, 17 Dec 2003 18:45:03 +0000 (18:45 +0000)]
The tree is open for Safari-119!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-118 stamp
vicki [Wed, 17 Dec 2003 18:25:13 +0000 (18:25 +0000)]
Safari-118 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed <rdar://problem/3512801>: REGRESSION (Safari 100-116):
sullivan [Wed, 17 Dec 2003 17:36:57 +0000 (17:36 +0000)]
    - fixed <rdar://problem/3512801>: REGRESSION (Safari 100-116):
        Mike Hay's Magic 8-ball game ignores slow clicks

        Reviewed by Darin.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _handleAutoscrollForMouseDragged:]):
        start the autoscroll timer here, so the timer only runs when KHTML is
        handling the event.
        (-[WebHTMLView mouseDown:]):
        don't start the autoscroll timer here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by me
kocienda [Wed, 17 Dec 2003 04:03:09 +0000 (04:03 +0000)]
    Reviewed by me

        * WebCoreSupport.subproj/WebBridge.m: ObjC runtime needs a declaration for new
_calculatedExpiration SPI in NSURLResponse in Foundation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3512348: Rewrote _CG_drawHighlightForRun:style:atPoint: to use width
rjw [Wed, 17 Dec 2003 03:21:37 +0000 (03:21 +0000)]
Fixed 3512348:  Rewrote _CG_drawHighlightForRun:style:atPoint: to use width
iterators.  Much faster, better cheaper, etc.

        Reviewed by Dave.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3510956, crash on mezzoblue.com. Relax the float-list searching code that...
hyatt [Wed, 17 Dec 2003 01:46:18 +0000 (01:46 +0000)]
Fix for 3510956, crash on mezzoblue.com.  Relax the float-list searching code that runs when
a float is removed.

        Reviewed by darin

        * khtml/rendering/render_object.cpp:
        (checkFloats):
        (RenderObject::removeFromObjectLists):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3503011. Added '-' and '?' to rounding hack.
rjw [Wed, 17 Dec 2003 01:33:45 +0000 (01:33 +0000)]
Fixed 3503011.  Added '-' and '?' to rounding hack.

        Reviewed by John.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (isRoundingHackCharacter):
        (widthForNextCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5809 268f45cc-cd09-0410-ab3c-d52691b4dbfc