WebKit-https.git
10 years ago[Qt][Wk2] Add an API test for scroll request from javascript
commit-queue@webkit.org [Fri, 18 Nov 2011 23:01:32 +0000 (23:01 +0000)]
[Qt][Wk2] Add an API test for scroll request from javascript
https://bugs.webkit.org/show_bug.cgi?id=72407

New API test added for QQuickWebView for javascript scroll request
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2011-11-18
Reviewed by Simon Hausmann.

* UIProcess/API/qt/tests/html/scroll.html: Added.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::scrollRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayout Test accessibility/anonymous-render-block-in-continuation-causes-crash.html...
adamk@chromium.org [Fri, 18 Nov 2011 22:52:56 +0000 (22:52 +0000)]
Layout Test accessibility/anonymous-render-block-in-continuation-causes-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72761

Mark test as PASS TIMEOUT as it occasionally times out on the bots.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] The exclusions tests are all passing. Remove the
tony@chromium.org [Fri, 18 Nov 2011 22:26:57 +0000 (22:26 +0000)]
[chromium] The exclusions tests are all passing. Remove the
test_expectations.txt entry for them.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Test fast/events/dropzone-002.html is failing on Leopard
adamk@chromium.org [Fri, 18 Nov 2011 22:24:52 +0000 (22:24 +0000)]
[chromium] Test fast/events/dropzone-002.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=61625

Test is no longer failing since the end of October.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDe-virtualize ExecutableBase::intrinsic
mhahnenberg@apple.com [Fri, 18 Nov 2011 22:13:37 +0000 (22:13 +0000)]
De-virtualize ExecutableBase::intrinsic
https://bugs.webkit.org/show_bug.cgi?id=72548

Reviewed by Oliver Hunt.

* runtime/Executable.cpp:
(JSC::ExecutableBase::intrinsic): Dynamic cast to NativeExecutable. If successful, call intrinsic, otherwise return default value.
* runtime/Executable.h:
* runtime/JSCell.h:
(JSC::jsDynamicCast): Add jsDynamicCast that duplicates the functionality of dynamic_cast in C++ but uses ClassInfo
rather than requiring C++ RTTI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline chromium expectations after r100800.
adamk@chromium.org [Fri, 18 Nov 2011 21:42:13 +0000 (21:42 +0000)]
Rebaseline chromium expectations after r100800.
Note that previous rebaseline was actually meant for r100786.

Unreviewed gardening.

* platform/chromium-win/animations/additive-transform-animations-expected.png: Added.
* platform/chromium-win/animations/additive-transform-animations-expected.txt: Added.
* platform/chromium/animations/additive-transform-animations-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline chromium expectations after r100800.
adamk@chromium.org [Fri, 18 Nov 2011 21:39:52 +0000 (21:39 +0000)]
Rebaseline chromium expectations after r100800.

Unreviewed gardening.

* platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png: Added.
* platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayout Test fast/writing-mode/japanese-rl-text-with-broken-font.html is flaky
adamk@chromium.org [Fri, 18 Nov 2011 21:26:23 +0000 (21:26 +0000)]
Layout Test fast/writing-mode/japanese-rl-text-with-broken-font.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=66900

Re-adding SNOWLEOPARD flakiness on CG bots that seems to have been
erroneously removed.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAccess key should work on all elements.
commit-queue@webkit.org [Fri, 18 Nov 2011 21:19:14 +0000 (21:19 +0000)]
Access key should work on all elements.
https://bugs.webkit.org/show_bug.cgi?id=71854

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-18
Reviewed by Ryosuke Niwa.

Source/WebCore:

All HTML elements can have the accesskey content attribute set.
Specification http://dev.w3.org/html5/spec/Overview.html#the-accesskey-attribute
Adding "accessKey" attribute to HTMLElement.idl file as [Reflect].

Test: fast/forms/access-key-for-all-elements.html

* bindings/objc/PublicDOMInterfaces.h: Moved properties form subclass to base class.
* html/BaseButtonInputType.cpp:
(WebCore::BaseButtonInputType::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
* html/BaseButtonInputType.h: Ditto
* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::accessKeyAction): Ditto
* html/BaseCheckableInputType.h: Ditto
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::accessKeyAction): Ditto
* html/HTMLAnchorElement.h: Ditto
* html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
* html/HTMLAreaElement.idl: Removed redundant IDL attribute entries.
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
* html/HTMLButtonElement.h: Ditto
* html/HTMLButtonElement.idl: Removed redundant IDL attribute entries.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
If the element does not have a defined activation behavior, fire a click event at the element.
* html/HTMLElement.h: Ditto
* html/HTMLElement.idl: Added accessKey IDL attribute.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
* html/HTMLInputElement.h: Ditto
* html/HTMLInputElement.idl: Removed redundant IDL attribute entries.
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
* html/HTMLLabelElement.h: Ditto
* html/HTMLLabelElement.idl: Removed redundant IDL attribute entries.
* html/HTMLLegendElement.cpp:
(WebCore::HTMLLegendElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
* html/HTMLLegendElement.h: Ditto
* html/HTMLLegendElement.idl: Removed redundant IDL attribute entries.
* html/HTMLOptGroupElement.h: Renamed variable sendToAnyElement to sendMouseEvents.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::accessKeyAction): Ditto
* html/HTMLSelectElement.h: Ditto
* html/HTMLTextAreaElement.h: Ditto
* html/HTMLTextAreaElement.idl: Removed redundant IDL attribute entries.
* html/HiddenInputType.h: Renamed variable sendToAnyElement to sendMouseEvents.
* html/InputType.h: Ditto
* html/RangeInputType.cpp:
(WebCore::RangeInputType::accessKeyAction): Ditto
* html/RangeInputType.h: Ditto

LayoutTests:

Added test case to check whether all elements can also have accessKey attribute.

* fast/forms/access-key-expected.txt:
* fast/forms/access-key-for-all-elements-expected.txt: Added.
* fast/forms/access-key-for-all-elements.html: Added.
* fast/forms/access-key.html: Added more test coverage for select and textarea elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayout Test accessibility/loading-iframe-sends-notification.html is slow on Win dbg
adamk@chromium.org [Fri, 18 Nov 2011 20:07:26 +0000 (20:07 +0000)]
Layout Test accessibility/loading-iframe-sends-notification.html is slow on Win dbg
https://bugs.webkit.org/show_bug.cgi?id=72747

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove expectation for fast/js/delete-syntax.html, which seems to have
adamk@chromium.org [Fri, 18 Nov 2011 19:57:02 +0000 (19:57 +0000)]
Remove expectation for fast/js/delete-syntax.html, which seems to have
been fixed by http://code.google.com/p/v8/source/detail?r=9993.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove IMAGE suppression for css3/images/cross-fade-overflow-position.html
adamk@chromium.org [Fri, 18 Nov 2011 19:32:58 +0000 (19:32 +0000)]
Remove IMAGE suppression for css3/images/cross-fade-overflow-position.html
to let me use garden-o-matic for rebaselining.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInfinite recursion in WebCore::RenderInline::computeRectForRepaint
jchaffraix@webkit.org [Fri, 18 Nov 2011 19:20:32 +0000 (19:20 +0000)]
Infinite recursion in WebCore::RenderInline::computeRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=52144

Reviewed by Tony Chang.

The bug got fixed, landing the test. As I could not test the old test case, it is
landed as-is (apart from making it dumpAsText which was deemed safe).

* editing/execCommand/infinite-recursion-computeRectForRepaint-expected.txt: Added.
* editing/execCommand/infinite-recursion-computeRectForRepaint.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Appearance of compound transform animations under apps linked on...
simon.fraser@apple.com [Fri, 18 Nov 2011 19:18:19 +0000 (19:18 +0000)]
Source/WebCore: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
https://bugs.webkit.org/show_bug.cgi?id=72641
and
<rdar://problem/10314267>

Reviewed by Dean Jackson.

GraphicsLayerCA contains a "linked on or after" check to account for a bug in
Core Animation on SnowLeopard and earlier, which is that CA would apply the list
of animations in reverse order.

Our previous fix was incorrect, because it only adjusted the 'additive' property
of the animation list based on ordering, rather than flipping the entire list.
This change reverses the list of animations before giving them to CA, which fixes
the bug.

Test: animations/additive-transform-animations.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
* platform/graphics/ca/GraphicsLayerCA.h:

LayoutTests: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
https://bugs.webkit.org/show_bug.cgi?id=72641

Reviewed by Dean Jackson.

Pixel test for a hardware-animated tranform, where order of operations matters.

* animations/additive-transform-animations-expected.png: Added.
* animations/additive-transform-animations.html: Added.
* platform/mac/animations/additive-transform-animations-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIgnore an ANGLE leak that is not WebKit's fault
aroben@apple.com [Fri, 18 Nov 2011 19:15:42 +0000 (19:15 +0000)]
Ignore an ANGLE leak that is not WebKit's fault

* Scripts/old-run-webkit-tests:
(countAndPrintLeaks):
* Scripts/webkitpy/layout_tests/port/leakdetector.py:
(LeakDetector._callstacks_to_exclude_from_leaks):
Added ScanFromString to the call stacks to exclude on all OS versions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSuppress IMAGE failures for css3/images/cross-fade-overflow-position.html
adamk@chromium.org [Fri, 18 Nov 2011 19:02:01 +0000 (19:02 +0000)]
Suppress IMAGE failures for css3/images/cross-fade-overflow-position.html
Needs rebaseline after r100786.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agobool WebChromeClient::shouldInterruptJavaScript casts pointer to bool and always...
adauria@apple.com [Fri, 18 Nov 2011 18:58:02 +0000 (18:58 +0000)]
bool WebChromeClient::shouldInterruptJavaScript casts pointer to bool and always returns true
https://bugs.webkit.org/show_bug.cgi?id=72568

Reviewed by David Kilzer.

WebChromeClient::shouldInterruptJavaScript called CallUIDelegate, which used an id
as the return value, which was then cast to a bool and always returned true. This
patch uses CallUIDelegateReturningBoolean instead of CallUIDelegate, with the default
return value of NO.

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldInterruptJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIgnore another Lion-specific leak that is not WebKit's fault
aroben@apple.com [Fri, 18 Nov 2011 18:39:56 +0000 (18:39 +0000)]
Ignore another Lion-specific leak that is not WebKit's fault

* Scripts/old-run-webkit-tests:
(countAndPrintLeaks):
* Scripts/webkitpy/layout_tests/port/leakdetector.py:
(LeakDetector._callstacks_to_exclude_from_leaks):
Added SecTransformExecute to the call stacks to exclude.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNo'am Rosenthal <noam.rosenthal@nokia.com>
igor.oliveira@openbossa.org [Fri, 18 Nov 2011 18:36:17 +0000 (18:36 +0000)]
No'am Rosenthal  <noam.rosenthal@nokia.com>

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add an ArgumentCoder for KeyframeValueList, and modify the TimingFunction ArgumentCoder to
allow encoding const TimingFunctions and not just RefPtr<TimingFunction>.

Reviewed by Simon Hausmann.

* Scripts/webkit2/messages.py:
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/WebCoreArgumentCoders.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit...
adamk@chromium.org [Fri, 18 Nov 2011 18:24:02 +0000 (18:24 +0000)]
ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Added CRASH to expectations for fast/encoding/parser-tests-50.html.
It's only crashing on Snow Leopard, but I didn't want to split the
existing line in two.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CMake] Remove duplicate dtoa files from CMakeLists.txt
paroga@webkit.org [Fri, 18 Nov 2011 18:11:27 +0000 (18:11 +0000)]
[CMake] Remove duplicate dtoa files from CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=72711

Reviewed by Brent Fulgham.

* wtf/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago-webkit-cross-fade rendered incorrectly in overflow divs
timothy_horton@apple.com [Fri, 18 Nov 2011 18:06:02 +0000 (18:06 +0000)]
-webkit-cross-fade rendered incorrectly in overflow divs
https://bugs.webkit.org/show_bug.cgi?id=72693
<rdar://problem/10468564>

Reviewed by Simon Fraser.

Respect the desired source rectangle when rendering the cross-fade.

Test: css3/images/cross-fade-overflow-position.html

* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
(WebCore::CrossfadeGeneratedImage::draw):
(WebCore::CrossfadeGeneratedImage::drawPattern):
* platform/graphics/CrossfadeGeneratedImage.h:

Add a test to make sure that -webkit-cross-fade renders correctly inside overflowed areas.

* css3/images/cross-fade-overflow-position.html: Added.
* css3/images/resources/half-circles.svg: Added.
* platform/mac/css3/images/cross-fade-overflow-position-expected.png: Added.
* platform/mac/css3/images/cross-fade-overflow-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CMake] Add possibility to overwrite WEBKIT_PORT_DIR in platform specific files
paroga@webkit.org [Fri, 18 Nov 2011 17:49:11 +0000 (17:49 +0000)]
[CMake] Add possibility to overwrite WEBKIT_PORT_DIR in platform specific files
https://bugs.webkit.org/show_bug.cgi?id=72710

Reviewed by Brent Fulgham.

.:

* Source/CMakeLists.txt:

Source/WebKit:

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit...
steveblock@google.com [Fri, 18 Nov 2011 17:33:22 +0000 (17:33 +0000)]
ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Add CRASH expectation for
fast/frames/sandboxed-iframe-parsing-space-characters.html on Mac 10.6
dbg.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Accessibility API tests not loading Gtk's accessibility implementation
mario@webkit.org [Fri, 18 Nov 2011 17:05:18 +0000 (17:05 +0000)]
[GTK] Accessibility API tests not loading Gtk's accessibility implementation
https://bugs.webkit.org/show_bug.cgi?id=72732

Reviewed by Philippe Normand.

Ensure that the GAIL module is being loaded by avoiding using
gtk_test_init() directly, but a modified version of it.

* tests/testatk.c:
(testWebkitAtkParentForRootObject): Use a normal GtkWidget (a
GtkWindow) as the parent container for the webView, instead of
using a dummy webView for that, which was hackish.
(testWebkitAtkSetParentForObject): Use normal GtkWidgets instead
of dummy webViews (a GtkWindow and a GtkButton).
(initializeTestingFramework): New function, identical to
gtk_test_init(), but loading GAIL as the only GTK module.
(main): Use initializeTestingFramework().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix; r100686 broke the EFL build when Geolocation
paroga@webkit.org [Fri, 18 Nov 2011 16:57:16 +0000 (16:57 +0000)]
Unreviewed build fix; r100686 broke the EFL build when Geolocation
support is enabled.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-18

* platform/efl/GeolocationServiceEfl.cpp: Only declare
s_factoryFunction if CLIENT_BASED_GEOLOCATION is off, otherwise it is
also declared in GeolocationService.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[TextureMapper] computePerspectiveTransformIfNeeded is called twice in TextureMapperN...
igor.oliveira@openbossa.org [Fri, 18 Nov 2011 16:43:45 +0000 (16:43 +0000)]
[TextureMapper] computePerspectiveTransformIfNeeded is called twice in TextureMapperNode::syncCompositingState
https://bugs.webkit.org/show_bug.cgi?id=72727

TextureMapperNode::computeAllTransforms already has a call to TextureMapperNode::computePerspectiveTransformIfNeeded,
so it does not need to be called again after TextureMapperNode::computeAllTransforms.

Reviewed by Noam Rosenthal.

* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::syncCompositingState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] fast/filesystem/file-writer-abort-depth.html crashes occasionally on Win dbg
steveblock@google.com [Fri, 18 Nov 2011 16:38:46 +0000 (16:38 +0000)]
[Chromium] fast/filesystem/file-writer-abort-depth.html crashes occasionally on Win dbg
https://bugs.webkit.org/show_bug.cgi?id=72631

Add CRASH expectation for fast/filesystem/file-writer-abort.html on Linux.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Guard for the viewportInteractionEngine as it doesn't always exist.
kenneth@webkit.org [Fri, 18 Nov 2011 16:18:53 +0000 (16:18 +0000)]
[Qt] Guard for the viewportInteractionEngine as it doesn't always exist.

Reviewed by Antonio Gomes.

The engine is non-existent when the view is configured to use desktop
behavior.

* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::handleWheelEvent):
(QtWebPageProxy::didFindZoomableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd test for strange scrollbars with non-integer scaled SVG image
commit-queue@webkit.org [Fri, 18 Nov 2011 16:03:00 +0000 (16:03 +0000)]
Add test for strange scrollbars with non-integer scaled SVG image
https://bugs.webkit.org/show_bug.cgi?id=43018

Patch by Philip Rogers <pdr@google.com> on 2011-11-18
Reviewed by Nikolas Zimmermann.

* svg/as-image/resources/green-non-integer-size-rect.svg: Added.
* svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
* svg/as-image/svg-non-integer-scaled-image-expected.txt: Added.
* svg/as-image/svg-non-integer-scaled-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother attempt at rebaselining fast/box-shadow for Chromium Mac 10.5.
steveblock@google.com [Fri, 18 Nov 2011 15:47:36 +0000 (15:47 +0000)]
Another attempt at rebaselining fast/box-shadow for Chromium Mac 10.5.
It seems the rebaseline tool made a mess of
http://trac.webkit.org/changeset/100742.

Unreviewed gardening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInspector tests flakily crashing on Linux dbg canary
steveblock@google.com [Fri, 18 Nov 2011 15:43:28 +0000 (15:43 +0000)]
Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add CRASH and TIMEOUT expectations for severla more tests.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] fast/canvas/canvas-alphaImageData-behavior.html has TEXT failure on Mac...
steveblock@google.com [Fri, 18 Nov 2011 15:27:25 +0000 (15:27 +0000)]
[Chromium] fast/canvas/canvas-alphaImageData-behavior.html has TEXT failure on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=72728

Add a TEXT expectation for canvas/philip/tests/2d.imageData.put.unchanged.html.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] fast/canvas/canvas-alphaImageData-behavior.html has TEXT failure on Mac...
steveblock@google.com [Fri, 18 Nov 2011 15:22:28 +0000 (15:22 +0000)]
[Chromium] fast/canvas/canvas-alphaImageData-behavior.html has TEXT failure on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=72728

Add a TEXT expectation.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skip another GTK crasher.
philn@webkit.org [Fri, 18 Nov 2011 14:58:59 +0000 (14:58 +0000)]
Unreviewed, skip another GTK crasher.

* platform/gtk/Skipped: Skip fast/borders/inline-mask-overlay-image-outset.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline remaining fast/ tests for Chromium Mac 10.5 CG after http://crrev.com...
steveblock@google.com [Fri, 18 Nov 2011 14:56:15 +0000 (14:56 +0000)]
Rebaseline remaining fast/ tests for Chromium Mac 10.5 CG after crrev.com/110543

Unreviewed gardening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Send DidCreateDestination to DownloadProxy when destination has been created
carlosgc@webkit.org [Fri, 18 Nov 2011 14:50:57 +0000 (14:50 +0000)]
[GTK] Send DidCreateDestination to DownloadProxy when destination has been created
https://bugs.webkit.org/show_bug.cgi?id=72724

Reviewed by Martin Robinson.

* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::didReceiveResponse): Call
didCreateDestination() when destination URI has been successfully
created.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Cancel current download operation before download object is deleted
carlosgc@webkit.org [Fri, 18 Nov 2011 14:48:40 +0000 (14:48 +0000)]
[GTK] Cancel current download operation before download object is deleted
https://bugs.webkit.org/show_bug.cgi?id=72721

Reviewed by Martin Robinson.

It fixes a crash in the web process when a download finishes early
due to a failure.

* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::cancel): Delete current ResourceHandle.
(WebKit::Download::platformInvalidate): If there's a
ResourceHandle active, cancel the download operation and delete
the handle.
(WebKit::Download::platformDidFinish): Delete current ResourceHandle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Downloads not started by WebView only fail for transport errors
carlosgc@webkit.org [Fri, 18 Nov 2011 14:45:57 +0000 (14:45 +0000)]
[GTK] Downloads not started by WebView only fail for transport errors
https://bugs.webkit.org/show_bug.cgi?id=72718

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Abort the download with an error if the response contains an
error code. It adds a new test case to the download unit tests.

* tests/testdownload.c:
(notifyDownloadStatusCallback):
(serverCallback):
(test_webkit_download_not_found):
(main):
* webkit/webkitdownload.cpp:
(DownloadClient::didReceiveResponse): Check whether http status of
the response is an error code and emit error signal in such case.

Source/WebKit2:

* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::didReceiveResponse): Check if the http
status of the response is an error code and finish the download
with an error in such case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline remaining svg/ tests for Chromium Mac 10.5 CG after http://crrev.com/110543
steveblock@google.com [Fri, 18 Nov 2011 14:43:10 +0000 (14:43 +0000)]
Rebaseline remaining svg/ tests for Chromium Mac 10.5 CG after crrev.com/110543

Unreviewed gardening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Support customizing JS alert/confirm/prompt dialogs using QML
caio.oliveira@openbossa.org [Fri, 18 Nov 2011 14:33:01 +0000 (14:33 +0000)]
[Qt] Support customizing JS alert/confirm/prompt dialogs using QML
https://bugs.webkit.org/show_bug.cgi?id=72319

Reviewed by Simon Hausmann.

Adds alertDialog, confirmDialog and promptDialog properties to QQuickWebView's
privateObject. These are QML components that are created by the webview when the
corresponding function is called in JS.

The dialogs are created in a context that contains a model object, similar to
ListView delegates. The "message" and "defaultValue" parameters are available
in the model object, as well as slots expected to be called by the dialog.

This commit removes the old code for supporting QWidget builtin dialogs. The code
wasn't working properly (closing any dialog was closing the app after QWindow
refactoring in Qt5).

* Target.pri:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewExperimental::alertDialog):
(QQuickWebViewExperimental::setAlertDialog):
(QQuickWebViewExperimental::confirmDialog):
(QQuickWebViewExperimental::setConfirmDialog):
(QQuickWebViewExperimental::promptDialog):
(QQuickWebViewExperimental::setPromptDialog):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/alert.html: Added.
* UIProcess/API/qt/tests/qmltests/common/confirm.html: Added.
* UIProcess/API/qt/tests/qmltests/common/prompt.html: Added.
* UIProcess/API/qt/tests/qmltests/qmltests.pro:
* UIProcess/qt/QtDialogRunner.cpp: Added.
(QtDialogRunner::QtDialogRunner):
(QtDialogRunner::~QtDialogRunner):
(DialogContextObject::DialogContextObject):
(DialogContextObject::message):
(DialogContextObject::defaultValue):
(DialogContextObject::dismiss):
(DialogContextObject::accept):
(DialogContextObject::reject):
(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::createDialog):
* UIProcess/qt/QtDialogRunner.h: Added.
(QtDialogRunner::wasAccepted):
(QtDialogRunner::result):
(QtDialogRunner::onAccepted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline fast/writing-mode for Chromium Mac 10.5 CG after http://crrev.com/110543
steveblock@google.com [Fri, 18 Nov 2011 14:23:01 +0000 (14:23 +0000)]
Rebaseline fast/writing-mode for Chromium Mac 10.5 CG after crrev.com/110543

Unreviewed gardening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix compilation warning in ComplexTextControllerCoreText.mm
mihnea@adobe.com [Fri, 18 Nov 2011 14:16:28 +0000 (14:16 +0000)]
Fix compilation warning in ComplexTextControllerCoreText.mm
https://bugs.webkit.org/show_bug.cgi?id=72702

Reviewed by Andreas Kling.

No functionality changed, so no new tests.

* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Support wheel event together with resizesToContents
kenneth@webkit.org [Fri, 18 Nov 2011 14:15:13 +0000 (14:15 +0000)]
[Qt] Support wheel event together with resizesToContents

Reviewed by Simon Hausmann.

* UIProcess/API/qt/qquickwebpage.cpp:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::wheelEvent):
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::handleWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Enable WebSocket hybi tests
yutak@chromium.org [Fri, 18 Nov 2011 14:00:33 +0000 (14:00 +0000)]
[Qt] Enable WebSocket hybi tests
https://bugs.webkit.org/show_bug.cgi?id=72687

Reviewed by Simon Hausmann.

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::defaultHixie76WebSocketProtocolEnabled):
(DumpRenderTreeSupportQt::setHixie76WebSocketProtocolEnabled):
Call WebCore::Settings::setUseHixie76WebSocketProtocol() to switch WebSocket protocols.
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference):

LayoutTests:

* platform/qt/Skipped:
Unskip WebSocket hybi tests. Skip some of them which are known to fail probably due to
a bug in SocketStreamHandleQt implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Layer violation: WebPopupMenuProxyQtDesktop.cpp uses files from WebKit...
hausmann@webkit.org [Fri, 18 Nov 2011 13:56:59 +0000 (13:56 +0000)]
[Qt][WK2] Layer violation: WebPopupMenuProxyQtDesktop.cpp uses files from WebKit/qt https://bugs.webkit.org/show_bug.cgi?id=72696

Reviewed by Kenneth Rohde Christiansen.

Implement the WK2 desktop popup by simply subclassing QComboBox and doing the
same thing as QtWebComboBox from WK1 (a few lines of code).

* UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:
(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::~WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::hidePopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::eventFilter):
(WebKit::WebPopupMenuProxyQtDesktop::setSelectedIndex):
(WebKit::WebPopupMenuProxyQtDesktop::populate):
* UIProcess/qt/WebPopupMenuProxyQtDesktop.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline fast/repaint for Chromium Mac 10.5 CG after http://crrev.com/110543
steveblock@google.com [Fri, 18 Nov 2011 13:52:04 +0000 (13:52 +0000)]
Rebaseline fast/repaint for Chromium Mac 10.5 CG after crrev.com/110543

Unreviewed gardening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] setViewportInteractionEngine must also set the InteractionEngine for the...
zeno.albisser@nokia.com [Fri, 18 Nov 2011 13:48:58 +0000 (13:48 +0000)]
[Qt][WK2] setViewportInteractionEngine must also set the InteractionEngine for the tap recognizer.
https://bugs.webkit.org/show_bug.cgi?id=72717

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::setViewportInteractionEngine):
* UIProcess/qt/QtTapGestureRecognizer.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::setViewportInteractionEngine):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed: restore front-end compilability via updating externs and JS generator.
pfeldman@chromium.org [Fri, 18 Nov 2011 13:45:42 +0000 (13:45 +0000)]
Not reviewed: restore front-end compilability via updating externs and JS generator.

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/externs.js:
(WebInspector.showPanelForAnchorNavigation):
* inspector/generate-protocol-externs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Fix popups for select elements.
hausmann@webkit.org [Fri, 18 Nov 2011 13:42:59 +0000 (13:42 +0000)]
[Qt][WK2] Fix popups for select elements.

Reviewed by Tor Arne Vestbø.

* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::createPopupMenuProxy): Fall back to the "desktop" implementation
for the moment. Better than nothing :)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed debug build fix
hausmann@webkit.org [Fri, 18 Nov 2011 13:42:09 +0000 (13:42 +0000)]
[Qt] Unreviewed debug build fix

* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy): Don't assert on a non-existant
variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: dispatch messages from the front-end to the backend asynchronously.
pfeldman@chromium.org [Fri, 18 Nov 2011 13:29:22 +0000 (13:29 +0000)]
Web Inspector: dispatch messages from the front-end to the backend asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=72621

Source/WebCore:

We should align the way we dispatch messages from the front-end to backend across the environments:
  - WebKit has it synchronoulsly
  - Chromium has it asynchronously
  - Remote debugging has it asynchronously
Making it asynchronous made a number of flaky Qt tests pass.

Tests uncovered console agent problem that was also fixed.

Reviewed by Yury Semikhatsky.

* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::clearFrontend):
* inspector/InspectorFrontendClient.h:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
(WebCore::InspectorBackendDispatchTask::dispatch):
(WebCore::InspectorBackendDispatchTask::reset):
(WebCore::InspectorBackendDispatchTask::onTimer):
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::windowObjectCleared):
(WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
* inspector/InspectorFrontendClientLocal.h:

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::performDisconnectFromBackend):
* src/InspectorFrontendClientImpl.h:

LayoutTests:

Now that dispatching is asynchronous, timeline test needed a fix.

Reviewed by Yury Semikhatsky.

* inspector/timeline/timeline-script-tag-1.html:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
sergio@webkit.org [Fri, 18 Nov 2011 13:28:21 +0000 (13:28 +0000)]
[GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=72707

Reviewed by Philippe Normand.

Tools:

Make new-run-webkit-tests use the right path to locate the test
plugin used by WebKitTestRunner.

* Scripts/webkitpy/layout_tests/port/gtk.py:

LayoutTests:

Unskipped a test that is passing now.

* platform/gtk-wk2/Skipped: unskipped plugins/get-url-notify-with-url-that-fails-to-load.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed build fix: Export QQuickWebPage/Preferences private API
hausmann@webkit.org [Fri, 18 Nov 2011 13:16:21 +0000 (13:16 +0000)]
[Qt] Unreviewed build fix: Export QQuickWebPage/Preferences private API
needed for the qml plugin.

* Source/qtwebkit-export.map:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline svg/custom for Chromium Mac 10.5 CG after http://crrev.com/110543
steveblock@google.com [Fri, 18 Nov 2011 13:15:07 +0000 (13:15 +0000)]
Rebaseline svg/custom for Chromium Mac 10.5 CG after crrev.com/110543

Unreviewed gardening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline svg/clip-path for Chromium Mac 10.5 CG after http://crrev.com/110543
steveblock@google.com [Fri, 18 Nov 2011 12:56:37 +0000 (12:56 +0000)]
Rebaseline svg/clip-path for Chromium Mac 10.5 CG after crrev.com/110543

Unreviewed gardening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Pass screen refresh rate into compositor.
commit-queue@webkit.org [Fri, 18 Nov 2011 12:43:44 +0000 (12:43 +0000)]
[chromium] Pass screen refresh rate into compositor.
https://bugs.webkit.org/show_bug.cgi?id=71040

Patch by Iain Merrick <husky@google.com> on 2011-11-18
Reviewed by Tony Gentilcore.

Source/WebCore:

Covered by CCLayerTreeHostTest.

* platform/PlatformScreen.h:
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenRefreshRate):
* platform/chromium/PlatformSupport.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

* public/WebScreenInfo.h:
(WebKit::WebScreenInfo::WebScreenInfo):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::screenRefreshRate):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CSSShaders] Implement the computed style for mesh parameters of the custom() filter
steveblock@google.com [Fri, 18 Nov 2011 12:30:45 +0000 (12:30 +0000)]
[CSSShaders] Implement the computed style for mesh parameters of the custom() filter
https://bugs.webkit.org/show_bug.cgi?id=72478

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-11-18
Reviewed by Dean Jackson.

* css3/filters/custom-filter-property-computed-style-expected.txt:
* css3/filters/custom-filter-property-parsing-invalid-expected.txt:
* css3/filters/script-tests/custom-filter-property-computed-style.js:
* css3/filters/script-tests/custom-filter-property-parsing-invalid.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CSSShaders] Implement the computed style for mesh parameters of the custom() filter
achicu@adobe.com [Fri, 18 Nov 2011 12:12:46 +0000 (12:12 +0000)]
[CSSShaders] Implement the computed style for mesh parameters of the custom() filter
https://bugs.webkit.org/show_bug.cgi?id=72478

Reviewed by Dean Jackson.

Source/WebCore:

Added parsing and computed style for the mesh rows, columns, mesh box type
(filter-box, border-box, content-box and padding-box) and the detached mode.

Also fixed a case where "custom(none, 10, 10 filter-box)" was incorrectly
treated as "custom(none, 10)".

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseCustomFilter): Fixed a case where invalid syntax was parsed as correct syntax.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CustomFilterOperation::MeshBoxType):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createCustomFilterOperation):
* css/CSSValueList.h:
(WebCore::CSSValueListIterator::isPrimitiveValue):
* platform/graphics/filters/CustomFilterOperation.h:

LayoutTests:

* css3/filters/custom-filter-property-computed-style-expected.txt:
* css3/filters/custom-filter-property-parsing-invalid-expected.txt:
* css3/filters/script-tests/custom-filter-property-computed-style.js:
* css3/filters/script-tests/custom-filter-property-parsing-invalid.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed build fix: Export QQuickWebViewExperimental private API
hausmann@webkit.org [Fri, 18 Nov 2011 11:50:02 +0000 (11:50 +0000)]
[Qt] Unreviewed build fix: Export QQuickWebViewExperimental private API
that was added since I made the export patch.

* Source/qtwebkit-export.map:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Accessibility API tests failing because of using non-WebKit GtkWidgets
mario@webkit.org [Fri, 18 Nov 2011 11:46:18 +0000 (11:46 +0000)]
[GTK] Accessibility API tests failing because of using non-WebKit GtkWidgets
https://bugs.webkit.org/show_bug.cgi?id=72708

Reviewed by Xan Lopez.

Do not use non-WebKit GtkWidget's in unit tests, to avoid problems
when GTK's accessibility implementation is not being loaded.

* tests/testatk.c:
(testWebkitAtkParentForRootObject): Use a dummy WebKitWebView
widget as the parent container needed for this unit test.
(testWebkitAtkSetParentForObject): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] WTR and InjectedBundle should not link statically against JSC/WTF https://bugs...
hausmann@webkit.org [Fri, 18 Nov 2011 11:41:10 +0000 (11:41 +0000)]
[Qt] WTR and InjectedBundle should not link statically against JSC/WTF https://bugs.webkit.org/show_bug.cgi?id=72697

Reviewed by Kenneth Rohde Christiansen.

.:

* Source/api.pri: On Linux, use a GNU LD version script to manage the
symbol exports, which includes the public WK1/WK2 API as well as a bunch
of private WTF symbols needed for WTR and the Injected Bundle.
* Source/qtwebkit-export.map: Added.

Tools:

* Tools.pro: Make WTR linux only for the moment.
* WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
* WebKitTestRunner/Target.pri: Ditto.
* qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
with ELF visibility on Linux. Instead we're temporarily using an LD version script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOops, fix ChangeLog text
hausmann@webkit.org [Fri, 18 Nov 2011 11:35:49 +0000 (11:35 +0000)]
Oops, fix ChangeLog text

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Removal of QtViewInterface part 3
hausmann@webkit.org [Fri, 18 Nov 2011 11:34:51 +0000 (11:34 +0000)]
[Qt] Removal of QtViewInterface part 3

Reviewed by Kenneth Rohde Christiansen.

Move the remaining forwarded calls from ClientImpl that went through
ViewInterface and then PageProxy or WebView to go straight to
QtWebPageProxy. QtViewInterface is empty now and therefore removed.

* Target.pri:
* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebpage_p_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::chooseFiles):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/qt/ClientImpl.cpp:
(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(qt_wk_runJavaScriptPrompt):
(qt_wk_setStatusText):
(qt_wk_runOpenPanel):
(qt_wk_mouseDidMoveOverElement):
(setupPageUiClient):
* UIProcess/qt/QtViewInterface.cpp: Removed.
* UIProcess/qt/QtViewInterface.h: Removed.
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didChangeStatusText):
(QtWebPageProxy::didMouseMoveOverElement):
(QtWebPageProxy::showContextMenu):
(QtWebPageProxy::hideContextMenu):
(QtWebPageProxy::runJavaScriptAlert):
(QtWebPageProxy::runJavaScriptConfirm):
(QtWebPageProxy::runJavaScriptPrompt):
(QtWebPageProxy::chooseFiles):
(QtWebPageProxy::createContextMenuProxy):
(QtWebPageProxy::didChangeLoadProgress):
* UIProcess/qt/QtWebPageProxy.h:
(QtWebPageProxy::contextMenuItemSelected):
* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt):
(WebKit::WebContextMenuProxyQt::create):
(WebKit::WebContextMenuProxyQt::hideContextMenu):
* UIProcess/qt/WebContextMenuProxyQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Change default size of the MiniBrowser
kenneth@webkit.org [Fri, 18 Nov 2011 11:33:07 +0000 (11:33 +0000)]
[Qt] Change default size of the MiniBrowser

Reviewed by Simon Hausmann.

As we lay out desktop pages using the width of 980, change our default
size to 980x735 so that we are not scaling down by default.

* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline fast/box-shadow for Chromium Mac 10.5 after http://crrev.com/110543
steveblock@google.com [Fri, 18 Nov 2011 11:27:53 +0000 (11:27 +0000)]
Rebaseline fast/box-shadow for Chromium Mac 10.5 after crrev.com/110543

Unreviewed gardening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] UI process segfaults, when visiblity properties are set while the WebProces...
commit-queue@webkit.org [Fri, 18 Nov 2011 11:16:40 +0000 (11:16 +0000)]
[Qt][WK2] UI process segfaults, when visiblity properties are set while the WebProcess is dead.
https://bugs.webkit.org/show_bug.cgi?id=72699

The drawing area may be null, if the web process has crashed, but not yet recovered.
Always null check against drawing area.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-11-18
Reviewed by Simon Hausmann.

* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::setDrawingAreaSize):
(QtWebPageProxy::setVisibleContentRectAndScale):
(QtWebPageProxy::setVisibleContentRectTrajectoryVector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unneeded include (and ifdef) from V8DOMWindowCustom.cpp
abarth@webkit.org [Fri, 18 Nov 2011 11:07:52 +0000 (11:07 +0000)]
Remove unneeded include (and ifdef) from V8DOMWindowCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=72705

Reviewed by Eric Seidel.

Death to ifdefs!

* bindings/v8/custom/V8DOMWindowCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Removal of QtViewInterface part 1
hausmann@webkit.org [Fri, 18 Nov 2011 11:01:28 +0000 (11:01 +0000)]
[Qt] Removal of QtViewInterface part 1

Reviewed by Kenneth Rohde Christiansen.

Move all functions that forwarded from QtWebPageProxy to QtViewInterface and then
to QQuickWebView straight into QtWebPageProxy.

* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/qt/QtViewInterface.cpp:
* UIProcess/qt/QtViewInterface.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::setCursor):
(QtWebPageProxy::isViewWindowActive):
(QtWebPageProxy::isViewVisible):
(QtWebPageProxy::pageDidRequestScroll):
(QtWebPageProxy::didFinishFirstNonEmptyLayout):
(QtWebPageProxy::didChangeContentsSize):
(QtWebPageProxy::didChangeViewportProperties):
(QtWebPageProxy::toolTipChanged):
(QtWebPageProxy::didChangeUrl):
(QtWebPageProxy::didChangeTitle):
(QtWebPageProxy::loadDidBegin):
(QtWebPageProxy::loadDidCommit):
(QtWebPageProxy::loadDidSucceed):
(QtWebPageProxy::loadDidFail):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::startDrag):
(QtWebPageProxy::didReceiveDownloadResponse):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline acid3.html for Chromium Mac 10.5
steveblock@google.com [Fri, 18 Nov 2011 10:54:04 +0000 (10:54 +0000)]
Rebaseline acid3.html for Chromium Mac 10.5

The image contains the text 'YOU SHOULD NOT SEE THIS AT ALL', but so do
all other Chromium expected results for this test, so I'm guessing this
is expected.

Unreviewed gardening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove some mediastream related files into the mediastream directory
abarth@webkit.org [Fri, 18 Nov 2011 10:37:16 +0000 (10:37 +0000)]
Move some mediastream related files into the mediastream directory
https://bugs.webkit.org/show_bug.cgi?id=72695

Reviewed by Eric Seidel.

Just moving the files to the proper directory.

* GNUmakefile.list.am:
* WebCore.gypi:
* mediastream/NavigatorUserMediaError.h: Renamed from Source/WebCore/page/NavigatorUserMediaError.h.
(WebCore::NavigatorUserMediaError::create):
(WebCore::NavigatorUserMediaError::~NavigatorUserMediaError):
(WebCore::NavigatorUserMediaError::code):
(WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
* mediastream/NavigatorUserMediaError.idl: Renamed from Source/WebCore/page/NavigatorUserMediaError.idl.
* mediastream/NavigatorUserMediaErrorCallback.h: Renamed from Source/WebCore/page/NavigatorUserMediaErrorCallback.h.
(WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback):
* mediastream/NavigatorUserMediaErrorCallback.idl: Renamed from Source/WebCore/page/NavigatorUserMediaErrorCallback.idl.
* mediastream/NavigatorUserMediaSuccessCallback.h: Renamed from Source/WebCore/page/NavigatorUserMediaSuccessCallback.h.
(WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback):
* mediastream/NavigatorUserMediaSuccessCallback.idl: Renamed from Source/WebCore/page/NavigatorUserMediaSuccessCallback.idl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Removal of QtViewInterface part 1
hausmann@webkit.org [Fri, 18 Nov 2011 10:27:25 +0000 (10:27 +0000)]
[Qt] Removal of QtViewInterface part 1

Reviewed by Kenneth Rohde Christiansen.

Replace functions of QtViewInterface that forward to QQuickWebPage with direct
usage of QQuickWebPage. Also removed some dead code.

* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::sceneGraphUpdateQueue):
* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/qt/QtViewInterface.cpp:
(WebKit::QtViewInterface::QtViewInterface):
(WebKit::QtViewInterface::isVisible):
* UIProcess/qt/QtViewInterface.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::setViewNeedsDisplay):
(QtWebPageProxy::viewSize):
(QtWebPageProxy::isViewFocused):
(QtWebPageProxy::isViewVisible):
(QtWebPageProxy::didRelaunchProcess):
* UIProcess/qt/QtWebPageProxy.h:
(QtWebPageProxy::qmlWebPage):
* UIProcess/qt/TiledDrawingAreaProxyQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [Extensions API] Provide a way for extension to create a status bar...
caseq@chromium.org [Fri, 18 Nov 2011 10:22:09 +0000 (10:22 +0000)]
Web Inspector: [Extensions API] Provide a way for extension to create a status bar icon
https://bugs.webkit.org/show_bug.cgi?id=45955

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.ExtensionPanelImpl.prototype.createStatusBarButton):
(injectedExtensionAPI):
(injectedExtensionAPI.ButtonImpl.prototype.update):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionPanel.prototype.get statusBarItems):
(WebInspector.ExtensionPanel.prototype.addStatusBarItem):
(WebInspector.ExtensionButton):
(WebInspector.ExtensionButton.prototype.update):
(WebInspector.ExtensionButton.prototype._onClicked):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype.notifyButtonClicked):
(WebInspector.ExtensionServer.prototype._onCreateStatusBarButton):
(WebInspector.ExtensionServer.prototype._onUpdateButton):
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
* inspector/front-end/inspector.css:
(button.status-bar-item.extension):

LayoutTests:

* inspector/extensions/extensions-panel-expected.txt:
* inspector/extensions/extensions-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMediaStream API: Merging the PeerConnectionHandler.h files
commit-queue@webkit.org [Fri, 18 Nov 2011 10:05:16 +0000 (10:05 +0000)]
MediaStream API: Merging the PeerConnectionHandler.h files
https://bugs.webkit.org/show_bug.cgi?id=72611

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-18
Reviewed by Adam Barth.

No actual code changes.

* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/mediastream/PeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/chromium/PeerConnectionHandler.h.
* platform/mediastream/gstreamer/PeerConnectionHandler.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, mark media/audio-garbage-collect.html flaky on GTK.
philn@webkit.org [Fri, 18 Nov 2011 09:04:59 +0000 (09:04 +0000)]
Unreviewed, mark media/audio-garbage-collect.html flaky on GTK.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] fast/canvas/canvas-lineWidth.html timeouts intermittently on 64 bit
ossy@webkit.org [Fri, 18 Nov 2011 08:36:04 +0000 (08:36 +0000)]
[Qt] fast/canvas/canvas-lineWidth.html timeouts intermittently on 64 bit
https://bugs.webkit.org/show_bug.cgi?id=72694

* platform/qt/Skipped: Skip fast/canvas/canvas-lineWidth.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Layer violation: ThirdPartyCookiesQt.cpp uses QWebSettings in two places https...
hausmann@webkit.org [Fri, 18 Nov 2011 08:21:55 +0000 (08:21 +0000)]
[Qt] Layer violation: ThirdPartyCookiesQt.cpp uses QWebSettings in two places https://bugs.webkit.org/show_bug.cgi?id=72597

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Moved code that queries the third party cookie policy from QWebSettings
out of WebCore. Instead NetworkingContext has now the interface that allows
delegating the functionality into WebKit/qt.

In order to do that we need to pass the NetworkingContext around, which is used to
retrieve the cookie jar and the originating frame object pointer.

* platform/network/NetworkingContext.h: Add interface.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler): Pass NetworkingContext to ResourceRequest::toNetworkRequest.
(WebCore::QNetworkReplyHandler::redirect): Ditto.
* platform/network/qt/ResourceRequest.h: Replaced originatingObject parameter with NetworkingContext, which can
also provide the same plus more (cookie jar, policy callback).
* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest): Ditto.
* platform/qt/CookieJarQt.cpp: Simplify to use NetworkingContext to get cookie jar and
call new thirdPartyCookiePolicyPermits API that takes the context as parameter.
(WebCore::networkingContext):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
* platform/qt/ThirdPartyCookiesQt.cpp: Replace up-casting to QWebFrame and use of QWebSettings
with useage of NetworkingContext.
(WebCore::thirdPartyCookiePolicyPermits):
* platform/qt/ThirdPartyCookiesQt.h:

Source/WebKit/qt:

Implemented NetworkingContext::thirdPartyCookiePolicyPermission, which queries
QWebSettings.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows): Adapt to the
changed thirdPartyCookiePolicyPermits WebCore API that operates on a networking context.
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): Pass networking
context to ResourceRequest::toNetworkRequest.
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): Ditto.
(WebCore::FrameLoaderClientQt::startDownload): Ditto.
* WebCoreSupport/FrameNetworkingContextQt.cpp:
(WebCore::FrameNetworkingContextQt::thirdPartyCookiePolicyPermission): Implement.
* WebCoreSupport/FrameNetworkingContextQt.h:
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::thirdPartyCookiePolicy): Adapt to QtDRTSupport API change.

Source/WebKit2:

Stub implementation of new NetworkingContext::thirdPartyCookiePolicyPermission
API.

* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
(WebCore::WebFrameNetworkingContext::thirdPartyCookiePolicyPermission):
* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
loki@webkit.org [Fri, 18 Nov 2011 07:42:03 +0000 (07:42 +0000)]
[Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=72602

Unskip tests after the fix on Qt.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
loki@webkit.org [Fri, 18 Nov 2011 07:41:48 +0000 (07:41 +0000)]
[Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=72602

Fixed StringImpl::foldCase by adding return in the case we need to handle
folding of 8 bit strings with Latin-1 characters.

Fixed case where StringImpl::replace was using a char temp instead of an
LChar temp.

Because of the second change, I changed other uses of char or
unsigned char to LChar.

Patch by Michael Saboff <msaboff@apple.com> on 2011-11-17
Reviewed by Zoltan Herczeg.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper):
(WTF::StringImpl::foldCase):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::replace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocrash: WebCore::FontPlatformData::roundsGlyphAdvances on Lion
bashi@chromium.org [Fri, 18 Nov 2011 07:27:00 +0000 (07:27 +0000)]
crash: WebCore::FontPlatformData::roundsGlyphAdvances on Lion
https://bugs.webkit.org/show_bug.cgi?id=71997

Reviewed by Dan Bernstein.

The cause is a null dereference of a fontData that is stored in
ComplexTextRun. The fontData is initialized by using the
fontCache, but it could be null when the font is in fallback
list. The reason a font from the fallback list might not be in the
font Cache is that it may be a web font. Before looking up the
fontCache, try to see whether the font is in the fallback list.

No new tests. We don't have webfonts that can produce the problem.

* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): See fallback list first, then lookup cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove initProgressEvent method
commit-queue@webkit.org [Fri, 18 Nov 2011 06:57:05 +0000 (06:57 +0000)]
Remove initProgressEvent method
https://bugs.webkit.org/show_bug.cgi?id=71340

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-17
Reviewed by Adam Barth.

This method has been removed from the spec draft.
http://www.w3.org/TR/progress-events/#interface-progressevent

Source/WebCore:

No new tests. Removed method.

* dom/ProgressEvent.cpp:
* dom/ProgressEvent.h:
* dom/ProgressEvent.idl:

LayoutTests:

No new tests. Removed method. Updated expected results.

* fast/dom/non-numeric-values-numeric-parameters-expected.txt:
* fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
* fast/events/init-events-expected.txt:
* fast/events/script-tests/init-events.js:
* fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Move keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() to the
commit-queue@webkit.org [Fri, 18 Nov 2011 06:14:11 +0000 (06:14 +0000)]
[EFL] Move keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() to the
EflKeyboardUtilities.cpp to use in the WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62451

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2011-11-17
Reviewed by Martin Robinson.

The keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() were static functions
in the PlatformKeyboardEventEfl.cpp. But they are also needed in the WebKit2 EFL port, so I
moved them to the separated file - EflKeyboardUtilities.cpp.

* PlatformEfl.cmake:
* platform/efl/EflKeyboardUtilities.cpp: Copied from Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp.
(WebCore::createKeyMap):
(WebCore::createWindowsKeyMap):
(WebCore::keyIdentifierForEvasKeyName):
(WebCore::windowsKeyCodeForEvasKeyName):
* platform/efl/EflKeyboardUtilities.h: Added.
* platform/efl/PlatformKeyboardEventEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] The process freezes when you right click on windowless Flash
mrobinson@webkit.org [Fri, 18 Nov 2011 06:09:25 +0000 (06:09 +0000)]
[GTK] The process freezes when you right click on windowless Flash
https://bugs.webkit.org/show_bug.cgi?id=69123

Reviewed by Xan Lopez.

Source/WebCore:

No new tests. I tried to create a layout test that exercised this
issue, but it appears that EventSender clicks do not trigger
it. This is covered by the manual tests containing Flash.

* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::determineQuirks): Always activate the
windowless Flash quirk if on x86_64 and X11.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::handleMouseEvent): Avoid sending right-click
events if we have the quirk.

Source/WebKit2:

Add a new plugin quirk for dealing with right-clicking on
windowless Flash on x86_64 machines. This already exists for
WebKit1.

* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::NetscapePluginModule::determineQuirks): If the plugin is
Flash and we are on x86_64, then disable sending right-clicking
events while in windowless mode.
* Shared/Plugins/PluginQuirks.h: Add the new quirk.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformHandleMouseEvent): If the quirk
is active  don't send right click events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Add matrix list to reuse tile matrix for each different zoom level.
commit-queue@webkit.org [Fri, 18 Nov 2011 05:52:34 +0000 (05:52 +0000)]
[EFL] Add matrix list to reuse tile matrix for each different zoom level.
https://bugs.webkit.org/show_bug.cgi?id=68595

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-11-17
Reviewed by Kenneth Rohde Christiansen.

Add matrix list to keep each tile matrix corresponding to each different zoom level when zoom level is changed.
Then backing store can reuse tile matrix by getting it from this matrix list.

* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_model_matrix_create):
(_ewk_tiled_backing_store_smart_calculate):
(_ewk_tiled_backing_store_zoom_set_internal):
* ewk/ewk_tiled_matrix.cpp:
(ewk_tile_matrix_entry_get):
(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_zoom_level_set):
(ewk_tile_matrix_invalidate):
(ewk_tile_matrix_free):
(ewk_tile_matrix_tile_new):
* ewk/ewk_tiled_matrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: clear fixme in generator script
loislo@chromium.org [Fri, 18 Nov 2011 05:47:57 +0000 (05:47 +0000)]
Web Inspector: clear fixme in generator script
https://bugs.webkit.org/show_bug.cgi?id=71372

Remove unnecessary field name map and update license year number.

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-11-17
Reviewed by Pavel Feldman.

* inspector/CodeGeneratorInspector.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Clean up the use of DATA_DIR in the buildsystem
commit-queue@webkit.org [Fri, 18 Nov 2011 05:43:02 +0000 (05:43 +0000)]
[EFL] Clean up the use of DATA_DIR in the buildsystem
https://bugs.webkit.org/show_bug.cgi?id=72681

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-17
Reviewed by Daniel Bates.

.:

* Source/cmake/OptionsEfl.cmake: Rename DATA_DIR to DATA_INSTALL_DIR
and add it to the cache; add a variable with the path of the generated
theme and remove the -DDATA_DIR definition, it was moved to
PlatformEFL.cmake in WebCore.

Source/WebCore:

Add the -DDATA_DIR definition here instead of defining it globally in
OptionsEfl.cmake, as WebCore is the only place which needs it.

No new tests, this is a buildsystem change.

* PlatformEfl.cmake:

Source/WebKit/efl:

Instead of messing with BUILD_DATA_DIR and PARENT_SCOPE, just use
THEME_BINARY_DIR as defined in OptionsEfl.cmake.

* CMakeListsEfl.txt:

Tools:

Instead of adding -DDATA_DIR in all scopes, only define it in
WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
it.

We can then define DATA_DIR to the generated theme directory for
EWebLauncher, since it's what we want here.

* CMakeListsEfl.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove JS recursion counter from V8Proxy to V8BindingPerIsolateData
adamk@chromium.org [Fri, 18 Nov 2011 05:41:33 +0000 (05:41 +0000)]
Move JS recursion counter from V8Proxy to V8BindingPerIsolateData
https://bugs.webkit.org/show_bug.cgi?id=72645

Reviewed by Adam Barth.

Source/WebCore:

With the JS recursion level stored as a member of V8Proxy, it's tied
to a frame. But this is incorrect, as there's no reason that a JS call
stack need be restricted to a single frame (see my new test case for
an example of code going across frames).

In order to get the correct accounting of JS recursion level, per-Isolate
is the right granularity (per dslomov), which is what this patch accomplishes.

Test: storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html

* bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::recursionLevel):
(WebCore::V8BindingPerIsolateData::incrementRecursionLevel):
(WebCore::V8BindingPerIsolateData::decrementRecursionLevel):
(WebCore::V8RecursionScope::V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):
* bindings/v8/V8Proxy.cpp:
(WebCore::incrementRecursionLevel):
(WebCore::decrementRecursionLevel):
(WebCore::recursionLevel):
(WebCore::V8Proxy::V8Proxy):
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::didLeaveScriptContext):
* bindings/v8/V8Proxy.h:

LayoutTests:

Added tests to exercise new timing of call to V8Proxy::didLeaveScriptContext().

* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt: Added.
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Move platform includes last in DRT's include directories.
commit-queue@webkit.org [Fri, 18 Nov 2011 05:38:57 +0000 (05:38 +0000)]
[EFL] Move platform includes last in DRT's include directories.
https://bugs.webkit.org/show_bug.cgi?id=72684

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-17
Reviewed by Daniel Bates.

This is the first step in fixing the build when a platform include (in
this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
is included instead of WebKit's.

* DumpRenderTree/efl/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] acid3.html didn't actually get rebaselined like I wanted.
pkasting@chromium.org [Fri, 18 Nov 2011 05:30:05 +0000 (05:30 +0000)]
[chromium] acid3.html didn't actually get rebaselined like I wanted.

Unreviewed, gardening.

* platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Font::drawComplexText can not draw a segment of text run
commit-queue@webkit.org [Fri, 18 Nov 2011 05:25:01 +0000 (05:25 +0000)]
[chromium] Font::drawComplexText can not draw a segment of text run
https://bugs.webkit.org/show_bug.cgi?id=72095

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2011-11-17
Reviewed by Adam Barth.

Source/WebCore:

drawComplexText() should respect the 'from' and 'to' arguments.
Drawing the whole text run may result in text overlapping.

Test: platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html

* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::glyphsForRange):
* platform/graphics/chromium/ComplexTextControllerLinux.h:
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::drawComplexText):

LayoutTests:

* platform/chromium-linux/fast/text/international/draw-complex-text-from-to-expected.png: Added.
* platform/chromium-linux/fast/text/international/draw-complex-text-from-to-expected.txt: Added.
* platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix broken expectation.
pkasting@chromium.org [Fri, 18 Nov 2011 05:02:58 +0000 (05:02 +0000)]
[chromium] Fix broken expectation.

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnique SecurityOrigins shouldn't remember their old schemes and hosts
abarth@webkit.org [Fri, 18 Nov 2011 04:58:44 +0000 (04:58 +0000)]
Unique SecurityOrigins shouldn't remember their old schemes and hosts
https://bugs.webkit.org/show_bug.cgi?id=71745

Reviewed by Darin Adler.

This is the final step in this series of patches.

This patch removes the forceUnique flag from SecurityOrigin::create.
Now, we create unique origins without passing in the document's URL,
preventing information from the document's URL from leaking into the
unique origin.

* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::setIsViewSource):
(WebCore::Document::initSecurityContext):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::getOriginsWithCache):
    - Update this callsite to use createFromString, which does exactly
      what this code is doing manually.
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::create):
* page/SecurityOrigin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPointer Lock: Page Settings unecessary
scheib@chromium.org [Fri, 18 Nov 2011 04:55:18 +0000 (04:55 +0000)]
Pointer Lock: Page Settings unecessary
https://bugs.webkit.org/show_bug.cgi?id=72662

Reviewed by Darin Fisher.

Source/WebCore:

No new tests.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
* src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Don't clamp minimumPageScaleFactor when doc width is zero
commit-queue@webkit.org [Fri, 18 Nov 2011 04:23:10 +0000 (04:23 +0000)]
[chromium] Don't clamp minimumPageScaleFactor when doc width is zero
https://bugs.webkit.org/show_bug.cgi?id=72679

Patch by Alexandre Elias <aelias@google.com> on 2011-11-17
Reviewed by James Robinson.

For a brief period during initialization, the document width can be
zero.  In that situation, don't try to limit minimumPageScaleFactor
to the document size.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPageScaleFactorLimits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Try to rebaseline more tests.
pkasting@chromium.org [Fri, 18 Nov 2011 04:13:39 +0000 (04:13 +0000)]
[chromium] Try to rebaseline more tests.

Unreviewed, gardening.

* platform/chromium-cg-mac-leopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/box-shadow/single-pixel-shadow-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/css/shadow-multiple-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/layers/layer-absolute-parent-opacity-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.txt: Added.
* platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.png: Removed.
* platform/chromium-linux-x86/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
* platform/chromium-linux-x86/fast/box-shadow/single-pixel-shadow-expected.png: Added.
* platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
* platform/chromium-linux/fast/box-shadow/single-pixel-shadow-expected.png: Added.
* platform/chromium-linux/fast/css/shadow-multiple-expected.png: Added.
* platform/chromium-mac-leopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
* platform/chromium-mac-leopard/fast/box-shadow/single-pixel-shadow-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png: Removed.
* platform/chromium-mac-leopard/fast/css/color-correction-on-text-shadow-expected.png: Removed.
* platform/chromium-mac-leopard/fast/css/shadow-multiple-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/single-pixel-shadow-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
* platform/chromium-mac-snowleopard/fast/layers/layer-absolute-parent-opacity-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png: Added.
* platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png: Removed.
* platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png: Removed.
* platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Removed.
* platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png: Removed.
* platform/chromium-win-xp/fast/css/shadow-multiple-expected.png: Added.
* platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
* platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png: Added.
* platform/chromium-win/fast/css/shadow-multiple-expected.png:
* platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Disable incremental uploading in threaded compositing path
commit-queue@webkit.org [Fri, 18 Nov 2011 04:09:06 +0000 (04:09 +0000)]
[chromium] Disable incremental uploading in threaded compositing path
https://bugs.webkit.org/show_bug.cgi?id=72669

Patch by James Robinson <jamesr@chromium.org> on 2011-11-17
Reviewed by Kenneth Russell.

Since we don't currently support atomic incremental uploads, incremental uploads in the threaded path result in
very strange-looking texture popping as tiles come in on pages that require more than 16 tile uploads per frame.
This disables that logic (by setting the upload limit per frame to 99999) until we handle the incremental
updates in an atomic fashion.

* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Attempt to rebaseline a test after http://crrev.com/110053 .
pkasting@chromium.org [Fri, 18 Nov 2011 02:51:09 +0000 (02:51 +0000)]
[chromium] Attempt to rebaseline a test after crrev.com/110053 .

Unreviewed, gardening.

* platform/chromium-linux-x86/fast/repaint/moving-shadow-on-path-expected.txt: Copied from platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.txt.
* platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix handling of setNeedsCommit and setNeedsAnimate in threaded mode
nduca@chromium.org [Fri, 18 Nov 2011 02:08:29 +0000 (02:08 +0000)]
[chromium] Fix handling of setNeedsCommit and setNeedsAnimate in threaded mode
https://bugs.webkit.org/show_bug.cgi?id=71638

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::setNeedsAnimate):
(WebCore::CCThreadProxy::beginFrameAndCommit):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(TestHooks::animateAndLayout):
(MockLayerTreeHostClient::animateAndLayout):
(CCLayerTreeHostTest::postSetNeedsAnimateToMainThread):
(CCLayerTreeHostTest::dispatchSetNeedsAnimate):
(CCLayerTreeHostTestSetNeedsAnimate::CCLayerTreeHostTestSetNeedsAnimate):
(CCLayerTreeHostTestSetNeedsAnimate::beginTest):
(CCLayerTreeHostTestSetNeedsAnimate::animateAndLayout):
(CCLayerTreeHostTestSetNeedsAnimate::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsAnimate::afterTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Mark some inspector tests as flakily crashing.
pkasting@chromium.org [Fri, 18 Nov 2011 01:46:47 +0000 (01:46 +0000)]
[chromium] Mark some inspector tests as flakily crashing.
https://bugs.webkit.org/show_bug.cgi?id=72651

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove bogus ASSERT.
abarth@webkit.org [Fri, 18 Nov 2011 01:46:39 +0000 (01:46 +0000)]
Remove bogus ASSERT.

* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100706 268f45cc-cd09-0410-ab3c-d52691b4dbfc