WebKit-https.git
10 years agoUnreviewed, Qt rebaseline after r96789.
zherczeg@webkit.org [Thu, 6 Oct 2011 09:30:24 +0000 (09:30 +0000)]
Unreviewed, Qt rebaseline after r96789.

* platform/qt/http/tests/navigation/postredirect-basic-expected.txt:
* platform/qt/http/tests/navigation/postredirect-frames-expected.txt: Added.
* platform/qt/http/tests/navigation/postredirect-goback1-expected.txt:
* platform/qt/http/tests/navigation/postredirect-goback2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpeculativeJIT::isKnownString() is wrong
fpizlo@apple.com [Thu, 6 Oct 2011 09:08:25 +0000 (09:08 +0000)]
SpeculativeJIT::isKnownString() is wrong
https://bugs.webkit.org/show_bug.cgi?id=69501

Reviewed by Oliver Hunt.

Removed the wrong case (GetLocal predicted String) and added a case that
works (StrCat).

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIndexedDB: Remove SQLite-LevelDB migration code
hans@chromium.org [Thu, 6 Oct 2011 09:00:08 +0000 (09:00 +0000)]
IndexedDB: Remove SQLite-LevelDB migration code
https://bugs.webkit.org/show_bug.cgi?id=69264

Reviewed by Tony Chang.

Source/WebCore:

Remove migration functionality.

Just removing code, so no new tests.

* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBFactoryBackendImpl.h:

Source/WebKit/chromium:

Remove setOverrideBackingStoreType. It was used in the layout test
for migration.

* public/WebIDBFactory.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):

Tools:

Remove setOverrideIndexedDBBackingStore. It was used in the layout
test for migration.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

Remove layout test covering migration.

* storage/indexeddb/migrate-basics-expected.txt: Removed.
* storage/indexeddb/migrate-basics.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK rebaseline after r96620.
philn@webkit.org [Thu, 6 Oct 2011 08:09:54 +0000 (08:09 +0000)]
Unreviewed, GTK rebaseline after r96620.

* platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove USE(THREADED_COMPOSITING) from the tree
commit-queue@webkit.org [Thu, 6 Oct 2011 07:12:09 +0000 (07:12 +0000)]
[chromium] Remove USE(THREADED_COMPOSITING) from the tree
https://bugs.webkit.org/show_bug.cgi?id=69489

Patch by James Robinson <jamesr@chromium.org> on 2011-10-06
Reviewed by Darin Fisher.

Source/WebCore:

This macro isn't needed any more since the logic it guarded is guarded by a runtime switch.

* platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

* features.gypi:
* src/WebViewImpl.h:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to...
commit-queue@webkit.org [Thu, 6 Oct 2011 06:34:02 +0000 (06:34 +0000)]
[chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=69498

Patch by James Robinson <jamesr@chromium.org> on 2011-10-05
Reviewed by Adam Barth.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setThreadedCompositingEnabled):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[QT] Fix DRT after r96779
arv@chromium.org [Thu, 6 Oct 2011 06:04:20 +0000 (06:04 +0000)]
[QT] Fix DRT after r96779

unreviewed.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::dumpHistoryItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor IDL attributes about constructor
haraken@chromium.org [Thu, 6 Oct 2011 06:00:41 +0000 (06:00 +0000)]
Refactor IDL attributes about constructor
https://bugs.webkit.org/show_bug.cgi?id=69074

Reviewed by Adam Barth.

Currently, IDL attributes about constructor are confusing:

- [CustomConstructFunction] means that there is a custom constructor for JSC.
- [V8CustomConstructor] means that there is a custom constructor for V8.
- [CustomConstructor] exists in CodeGenerator*.pm but is not used in any IDL files.
- For almost all IDL files, [CustomConstructFunction] and [V8CustomConstructor] are used at the same time.
- ObjC, CPP and GObject bindings do not support custom constructors.

This patch makes the following changes:

- Rename [CustomConstructFunction] to [JSCustomConstructor].
- [JSCustomConstructor] means that there is a custom constructor for JSC.
- [V8CustomConstructor] means that there is a custom constructor for V8.
- [CustomConstructor] means that there is a custom constructor for both JSC and V8.

No new tests. No change in behavior. Confirm that build succeeds.

* bindings/scripts/CodeGeneratorJS.pm: Removed [CustomConstructFunction] and added [JSCustomConstructor]
(GenerateHeader):
(GenerateAttributesHashTable):
(GenerateImplementation):
(GenerateConstructorDefinition):
* css/WebKitCSSMatrix.idl: Renamed [CustomConstructFunction] to [JSCustomConstructor]. If both [JSCustomConstructor] and [V8CustomConstructor] are specified, then we replaced them with [CustomConstructor].
* dom/CustomEvent.idl: Ditto.
* dom/ErrorEvent.idl: Ditto.
* dom/Event.idl: Ditto.
* dom/HashChangeEvent.idl: Ditto.
* dom/MessageChannel.idl: Ditto.
* dom/MessageEvent.idl: Ditto.
* dom/PageTransitionEvent.idl: Ditto.
* dom/PopStateEvent.idl: Ditto.
* dom/ProgressEvent.idl: Ditto.
* dom/WebKitAnimationEvent.idl: Ditto.
* html/DOMFormData.idl: Ditto.
* html/canvas/ArrayBuffer.idl: Ditto.
* html/canvas/DataView.idl: Ditto.
* html/canvas/Float32Array.idl: Ditto.
* html/canvas/Float64Array.idl: Ditto.
* html/canvas/Int16Array.idl: Ditto.
* html/canvas/Int32Array.idl: Ditto.
* html/canvas/Int8Array.idl: Ditto.
* html/canvas/Uint16Array.idl: Ditto.
* html/canvas/Uint32Array.idl: Ditto.
* html/canvas/Uint8Array.idl: Ditto.
* p2p/PeerConnection.idl: Ditto.
* page/EventSource.idl: Ditto.
* page/WebKitPoint.idl: Ditto.
* webaudio/AudioContext.idl: Ditto.
* websockets/CloseEvent.idl: Ditto.
* websockets/WebSocket.idl: Ditto.
* workers/SharedWorker.idl: Ditto.
* workers/Worker.idl: Ditto.
* xml/XMLHttpRequest.idl: Ditto.
* xml/XSLTProcessor.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] Unreviewed build fix.
bfulgham@webkit.org [Thu, 6 Oct 2011 05:37:43 +0000 (05:37 +0000)]
[WinCairo] Unreviewed build fix.

* platform/wincairo/Skipped: Skip css3 folder (for now).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Add the option to suppress rendering until the document's load event...
aestes@apple.com [Thu, 6 Oct 2011 04:18:03 +0000 (04:18 +0000)]
Source/WebCore: Add the option to suppress rendering until the document's load event fires.
https://bugs.webkit.org/show_bug.cgi?id=69298

Reviewed by Simon Fraser.

Add a WebCore setting that suppresses painting and compositing layer
updates until the document's load event fires. This masks the effects
of incremental rendering (for clients that opt in) by ensuring that all
sub-resources have loaded and a full layout has taken place before
painting the document for the first time.

No tests currently possible. Testing this would require the ability for
DRT to dump state while resources are loading, which it doesn't
currently do.

* dom/Document.cpp:
(WebCore::Document::implicitClose): If rendering was previously
suppressed, force a repaint and compositing layer update.
(WebCore::Document::visualUpdatesAllowed): Add a helper method to
determine if the document is in a state where rendering is allowed.
* dom/Document.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setSuppressIncrementalRendering):
(WebCore::Settings::suppressIncrementalRendering):
* rendering/RenderLayer.cpp:
(WebCore::shouldSuppressPaintingLayer): Encapsulate the FOUC and
painting suppression checks into a single helper function for
readability's sake.
(WebCore::RenderLayer::paintLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers): If we should
suppress compositing layer updates and the load event has yet to fire,
return early.

Source/WebKit/mac: Add an option to suppress rendering until the document's load event fires.
https://bugs.webkit.org/show_bug.cgi?id=69298

Reviewed by Simon Fraser.

Add a new private WebPreference.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setSuppressRenderingWhileInitiallyLoading:]):
(-[WebPreferences suppressRenderingWhileInitiallyLoading]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit2: Add an option to suppress rendering until the document's load event fires.
https://bugs.webkit.org/show_bug.cgi?id=69298

Reviewed by Simon Fraser.

Add a new WKPreference.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSuppressRenderingWhileInitiallyLoading):
(WKPreferencesGetSuppressRenderingWhileInitiallyLoading):
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebSocket: Add extensions attribute
yutak@chromium.org [Thu, 6 Oct 2011 03:37:38 +0000 (03:37 +0000)]
WebSocket: Add extensions attribute
https://bugs.webkit.org/show_bug.cgi?id=69408

Reviewed by Kent Tamura.

Source/WebCore:

Add WebSocket's "extensions" attribute as specified in the WebSocket API
<http://dev.w3.org/html5/websockets/#the-websocket-interface>.

WebSocket protocol extension is not implemented at all, thus this attribute
always returns an empty string.

Test: http/tests/websocket/tests/hybi/extensions.html
      http/tests/websocket/tests/hixie76/undefined-attributes.html (updated)

* websockets/WebSocket.cpp:
(WebCore::WebSocket::extensions):
If the hixie-76 protocol is chosen, we need to return "undefined" in order to
keep behavior of the ports which have not used the newer hybi protocol yet.
* websockets/WebSocket.h:
* websockets/WebSocket.idl:

LayoutTests:

* http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt:
* http/tests/websocket/tests/hixie76/undefined-attributes.html:
Added "extensions" attribute to the list because it shouldn't be defined
when hixie-76 protocol is used.
* http/tests/websocket/tests/hybi/extensions-expected.txt: Added.
* http/tests/websocket/tests/hybi/extensions.html:
Added. Test whether .extensions attribute always returns an empty string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agor96770 broke binary compatibility with Safari
simon.fraser@apple.com [Thu, 6 Oct 2011 03:04:49 +0000 (03:04 +0000)]
r96770 broke binary compatibility with Safari
https://bugs.webkit.org/show_bug.cgi?id=69496

Reviewed by Dan Bernstein.

Fix binary compatibility issue by declaring the deprecated methods inside a extern "C" block.

* UIProcess/API/C/WKContext.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix attempt after r96760.
rniwa@webkit.org [Thu, 6 Oct 2011 02:38:35 +0000 (02:38 +0000)]
Windows build fix attempt after r96760.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIsShadowRootFlag should not depend on whether a ShadowRoot is attached to a host.
dominicc@chromium.org [Thu, 6 Oct 2011 02:27:33 +0000 (02:27 +0000)]
IsShadowRootFlag should not depend on whether a ShadowRoot is attached to a host.
https://bugs.webkit.org/show_bug.cgi?id=69406

Reviewed by Hajime Morita.

No change in behavior => No new tests.

* dom/Node.cpp:
(WebCore::Node::setShadowHost): Don't twiddle the flag.
* dom/Node.h:
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot): Set the IsShadowRootFlag on creation.
* dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope): Let ShadowRoot set creation flags.
* dom/TreeScope.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Update test expectations for Web Audio on Windows.
simonjam@chromium.org [Thu, 6 Oct 2011 02:15:38 +0000 (02:15 +0000)]
[Chromium] Update test expectations for Web Audio on Windows.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDefine a log2f() function for Windows in wtf/MathExtras.h
crogers@google.com [Thu, 6 Oct 2011 02:04:19 +0000 (02:04 +0000)]
Define a log2f() function for Windows in wtf/MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=69491

Reviewed by Darin Adler.

Source/JavaScriptCore:

* wtf/MathExtras.h:
(log2f):

Source/WebCore:

No new tests. This change is tested in existing layout tests.

* webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowindow.location.href and others needlessly decodes URI-encoded characters
arv@chromium.org [Thu, 6 Oct 2011 01:40:05 +0000 (01:40 +0000)]
window.location.href and others needlessly decodes URI-encoded characters
https://bugs.webkit.org/show_bug.cgi?id=30225

Reviewed by Darin Adler.

Source/WebCore:

Don't decode KURL::path() and stop using KURL::deprecatedString() in Location methods.

This slightly changes how we parse data and javascript URLs (non hierarchical URLs) to
not encode so aggressively.

* fileapi/DOMFileSystemBase.cpp:
(WebCore::DOMFileSystemBase::crackFileSystemURL): Manually decode path()
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::defaultObjectContentType): Manually decode path()
* page/Location.cpp:
(WebCore::Location::href): Use string() instead of deprecatedString()
* page/Location.h:
(WebCore::Location::toString): Inline call to href()
* platform/KURL.cpp:
(WebCore::KURL::path): Don't decode.
(WebCore::escapeAndAppendNonHierarchicalPart): Rename escapeAndAppendFragment to escapeAndAppendNonHierarchicalPart
                                               since this is now used for more than just fragments.
(WebCore::KURL::parse): Don't decode
* platform/KURLGoogle.cpp:
(WebCore::KURL::path): Remove out of date comment
* platform/qt/KURLQt.cpp:
(WebCore::KURL::fileSystemPath): Manually decode path()
* platform/win/ClipboardWin.cpp:
(WebCore::createGlobalHDropContent): Manually decode path()
* workers/WorkerLocation.cpp:
(WebCore::WorkerLocation::href): Use string() instead of deprecatedString()
* workers/WorkerLocation.h:
(WebCore::WorkerLocation::toString): Inline call to href()

Tools:

* DumpRenderTree/chromium/TestShell.cpp:
(normalizeLayoutTestURLInternal): Remove extra encode.

LayoutTests:

The path part of location.href and location.pathname are now not decoded and we keep percent escape sequences.

data and javascript URLs only encodes non ascii characters.

* fast/dom/anchor-origin-expected.txt:
* fast/dom/anchor-origin.html: Change to not use document.write since we don't want to output HTML.
* fast/history/history-back-initial-vs-final-url-expected.txt:
* fast/loader/subframe-navigate-during-main-frame-load-expected.txt:
* fast/url/file-http-base-expected.txt:
* fast/url/mailto-expected.txt:
* fast/url/script-tests/file-http-base.js:
* fast/url/script-tests/segments.js:
* fast/url/script-tests/standard-url.js:
* fast/url/segments-expected.txt:
* fast/url/segments-from-data-url-expected.txt:
* fast/url/segments.html: Use UTF-8
* fast/url/standard-url-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
* platform/chromium-cg-mac/fast/url/standard-url-expected.txt:
* platform/chromium-linux/fast/url/standard-url-expected.txt:
* platform/chromium-mac/fast/url/standard-url-expected.txt:
* platform/chromium-win/fast/url/standard-url-expected.txt:
* platform/chromium/fast/dom/anchor-origin-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
darin@apple.com [Thu, 6 Oct 2011 01:14:15 +0000 (01:14 +0000)]
Fix build.

* TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
(TestWebKitAPI::TEST): Remove underscore prefix from call to
WKContextRegisterURLSchemeAsEmptyDocument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Mac] Use four more named cursors if present
darin@apple.com [Thu, 6 Oct 2011 00:56:43 +0000 (00:56 +0000)]
[Mac] Use four more named cursors if present
https://bugs.webkit.org/show_bug.cgi?id=69488

Reviewed by Dan Bernstein.

* platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor): Use the names "Help", "Cell",
"ZoomIn", and "ZoomOut" to get those cursors. Structure the code so it
falls back if the cursors are not present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoforce margin:auto to 0 in flex items
tony@chromium.org [Thu, 6 Oct 2011 00:51:56 +0000 (00:51 +0000)]
force margin:auto to 0 in flex items
https://bugs.webkit.org/show_bug.cgi?id=69475

Reviewed by Ojan Vafai.

Source/WebCore:

The spec used to say the margin had a value of flex(1 0 0), but changed to just be 0.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

LayoutTests:

* css3/flexbox/002.html:
* css3/flexbox/003.html:
* css3/flexbox/004.html:
* css3/flexbox/writing-modes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoComputed style for filter property
dino@apple.com [Thu, 6 Oct 2011 00:44:27 +0000 (00:44 +0000)]
Computed style for filter property
https://bugs.webkit.org/show_bug.cgi?id=68477

Reviewed by Simon Fraser.

Reports the computed style for the new -webkit-filter
property value.

Test: css3/filters/filter-property-computed-style.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedFilter):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

New test to exercise computed style for -webkit-filter. Note
that drop-shadow is not yet supported.

* css3/filters/filter-property-computed-style-expected.txt: Added.
* css3/filters/filter-property-computed-style.html: Added.
* css3/filters/script-tests/filter-property-computed-style.js: Added.
(testComputedFilterRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnable WEB_AUDIO by default in the WebKit/mac port.
jer.noble@apple.com [Thu, 6 Oct 2011 00:40:39 +0000 (00:40 +0000)]
Enable WEB_AUDIO by default in the WebKit/mac port.
https://bugs.webkit.org/show_bug.cgi?id=68587

Reviewed by Simon Fraser.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:

Source/WebCore:

No new tests; existing webaudio/ layout tests cover this.

* Configurations/FeatureDefines.xcconfig:
* WebCore.xcodeproj/project.pbxproj: Add a build step which copies audio resources to
    the WebCore.framework bundle.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

LayoutTests:

* fast/dom/script-tests/constructed-objects-prototypes.js:
(constructorPropertiesOnWindow):
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] Switch to building Release target, and activate tests.
bfulgham@webkit.org [Thu, 6 Oct 2011 00:35:43 +0000 (00:35 +0000)]
[WinCairo] Switch to building Release target, and activate tests.
https://bugs.webkit.org/show_bug.cgi?id=69272

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/config.json:
Change from debug to release target. Switch from "Build" to
"BuildAndTest"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake destructor of WebURLLoaderClient virtual.
commit-queue@webkit.org [Thu, 6 Oct 2011 00:34:14 +0000 (00:34 +0000)]
Make destructor of WebURLLoaderClient virtual.
https://bugs.webkit.org/show_bug.cgi?id=69457

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-10-05
Reviewed by Darin Fisher.

* public/WebURLLoaderClient.h:
(WebKit::WebURLLoaderClient::~WebURLLoaderClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] unreviewed build correction.
bfulgham@webkit.org [Thu, 6 Oct 2011 00:29:31 +0000 (00:29 +0000)]
[WinCairo] unreviewed build correction.

* platform/wincairo/Skipped: Update to get build green.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIn WebKitTestRunner, text has font smoothing in pixel snapshots
simon.fraser@apple.com [Thu, 6 Oct 2011 00:08:04 +0000 (00:08 +0000)]
In WebKitTestRunner, text has font smoothing in pixel snapshots
https://bugs.webkit.org/show_bug.cgi?id=69396

Source/WebKit2:

Reviewed by Darin Adler.

Plumb through a method on WKContext that controls whether font smoothing
is enabled. Since this is a global setting, such a method is more appropriate
than a preference.

Remove leading underscores on some WKContext functions, but keep
exported versions of same for binary compatibility.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/C/WKContext.cpp:
(WKContextSetAlwaysUsesComplexTextCodePath):
(WKContextSetShouldUseFontSmoothing):
(WKContextSetAdditionalPluginsDirectory):
(WKContextRegisterURLSchemeAsEmptyDocument):
(WKContextSetHTTPPipeliningEnabled):
(_WKContextSetAdditionalPluginsDirectory):
(_WKContextRegisterURLSchemeAsEmptyDocument):
(_WKContextSetAlwaysUsesComplexTextCodePath):
(_WKContextSetHTTPPipeliningEnabled):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::setShouldUseFontSmoothing):
(WebKit::WebContext::httpPipeliningEnabled):
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setShouldUseFontSmoothing):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

Tools:

Reviewed by Darin Adler.

Call the new WKContext method that disables font smoothing in
WebKitTestRunner, so that pixel snapshots don't have font smoothing
enabled. Remove leading underscore from a WKContext function call.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[flexbox] take marginBeforeForChild into account when positioning children
ojan@chromium.org [Thu, 6 Oct 2011 00:01:28 +0000 (00:01 +0000)]
[flexbox] take marginBeforeForChild into account when positioning children
https://bugs.webkit.org/show_bug.cgi?id=69313

Reviewed by Tony Chang.

Source/WebCore:

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

LayoutTests:

* css3/flexbox/002.html:
* css3/flexbox/writing-modes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImprove the watchlist for threading entries.
levin@chromium.org [Thu, 6 Oct 2011 00:00:30 +0000 (00:00 +0000)]
Improve the watchlist for threading entries.
https://bugs.webkit.org/show_bug.cgi?id=69463

Reviewed by Adam Barth.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Update test expectations after Skia roll.
simonjam@chromium.org [Wed, 5 Oct 2011 23:59:36 +0000 (23:59 +0000)]
[Chromium] Update test expectations after Skia roll.

Unreviewed.

* platform/chromium/test_expectations.txt: Added select-background-none.html on Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitching threaded compositor from a compile time option to a
vangelis@chromium.org [Wed, 5 Oct 2011 23:46:21 +0000 (23:46 +0000)]
Switching threaded compositor from a compile time option to a
run time one.
https://bugs.webkit.org/show_bug.cgi?id=69391

Reviewed by Darin Fisher.

Source/WebCore:

Mostly converted #if USE(THREADED_COMPOSITING) to a regular if statements.
In addition, CCLayerTreeHost::scheduleComposite() is removed as it wasn't being
called from anywhere,

No new tests as it doesn't add new functionality.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
(WebCore::CCSingleThreadProxy::compositeImmediately):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setMinimumAccelerated2dCanvasSize):
(WebKit::WebSettingsImpl::setUseThreadedCompositor):
* src/WebSettingsImpl.h:
(WebKit::WebSettingsImpl::useThreadedCompositor):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::scheduleComposite):
(WebKit::WebViewImpl::graphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFlash of white when unminimizing windows
andersca@apple.com [Wed, 5 Oct 2011 23:40:09 +0000 (23:40 +0000)]
Flash of white when unminimizing windows
https://bugs.webkit.org/show_bug.cgi?id=69476
<rdar://problem/10202680>

Reviewed by Simon Fraser.

Whenever the UI process requests an immediate backing store update, make sure to resume
painting if it's suspended.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updateBackingStoreState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoParse '-webkit-filter' property syntax
dino@apple.com [Wed, 5 Oct 2011 23:27:54 +0000 (23:27 +0000)]
Parse '-webkit-filter' property syntax
https://bugs.webkit.org/show_bug.cgi?id=68473

Reviewed by Nikolas Zimmermann.

Parse the new -webkit-filter property, looking for shorthand
functions then testing number, type and value of parameters.

Note that support for drop-shadow() was omitted from this
patch because parsing CSS shadow syntax was going to require some
refactoring of the box and text shadow code. The followup
bug is https://bugs.webkit.org/show_bug.cgi?id=69108.

Also, computed style will return null for filters at the moment.
That's https://bugs.webkit.org/show_bug.cgi?id=68477.

Tests: css3/filters/filter-property-parsing-invalid.html
       css3/filters/filter-property-parsing.html

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
    Build files updated for new WebKitCSSFilterValue classes.
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/objc/DOMCSS.mm:
    Test if value is WebKitCSSFilterValue.
* css/CSSParser.cpp:
(WebCore::filterInfoForName):
(WebCore::CSSParser::isValidFilterArgument):
(WebCore::CSSParser::parseFilter):
* css/CSSParser.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::filterOperationForType):
(WebCore::CSSStyleSelector::createFilterOperations):
* css/CSSStyleSelector.h:
    Handle the new shorthand functions in -webkit-filter.
* css/CSSValue.h:
(WebCore::CSSValue::isWebKitCSSFilterValue):
    Add virtual function that returns false here.
* css/WebKitCSSFilterValue.cpp: Added.
(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
(WebCore::WebKitCSSFilterValue::~WebKitCSSFilterValue):
(WebCore::WebKitCSSFilterValue::cssText):
* css/WebKitCSSFilterValue.h: Added.
(WebCore::WebKitCSSFilterValue::create):
(WebCore::WebKitCSSFilterValue::operationType):
(WebCore::WebKitCSSFilterValue::isWebKitCSSFilterValue):
* css/WebKitCSSFilterValue.idl: Added.
    WebKitCSSFilterValue modelled closely on WebKitCSSTransformValue,
    basically identifying the type of operation in a CSSValueList.
* page/DOMWindow.idl:
    New WebKitCSSFilterValue constructor.
* platform/graphics/filters/FilterOperation.h:
(WebCore::BlurFilterOperation::create):
(WebCore::BlurFilterOperation::stdDeviationX):
(WebCore::BlurFilterOperation::stdDeviationY):
(WebCore::BlurFilterOperation::BlurFilterOperation):
(WebCore::SharpenFilterOperation::create):
(WebCore::SharpenFilterOperation::radius):
(WebCore::SharpenFilterOperation::threshold):
(WebCore::SharpenFilterOperation::SharpenFilterOperation):
    Use Length rather than double for parameters that are CSS lengths.

New tests that exercise the -webkit-filter syntax, with
(nearly) all the function shorthands. Since this patch also
added a global WebKitCSSFilterValue interface, the window
tests needed update, but only on the platforms that have
ENABLE(CSS_FILTERS).

* css3/filters/filter-property-expected.txt:
* css3/filters/filter-property-parsing-expected.txt: Added.
* css3/filters/filter-property-parsing-invalid-expected.txt: Added.
* css3/filters/filter-property-parsing-invalid.html: Added.
* css3/filters/filter-property-parsing.html: Added.
* css3/filters/script-tests/filter-property-parsing-invalid.js: Added.
(testInvalidFilterRule):
* css3/filters/script-tests/filter-property-parsing.js: Added.
(jsWrapperClass):
(shouldBeType):
(testFilterRule):
* css3/filters/script-tests/filter-property.js:
    Updated old test which was missing quotes, plus new tests that
    exercise the shorthand feature.
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt: Added.
* platform/mac/fast/js/global-constructors-expected.txt:
* platform/win/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt.
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt: Added.
* platform/win/fast/js/global-constructors-expected.txt:
    Updated isAppleWebkit() platform files for the new WebKitCSSFilterValue
    API exposed on Window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline webaudio/audiobuffersource-playbackrate.html due to http://trac.webkit...
crogers@google.com [Wed, 5 Oct 2011 23:05:28 +0000 (23:05 +0000)]
Rebaseline webaudio/audiobuffersource-playbackrate.html due to trac.webkit.org/changeset/96745
https://bugs.webkit.org/show_bug.cgi?id=69470

Unreviewed.

* webaudio/audiobuffersource-playbackrate-expected.wav:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAssertion hit in JSC::DFG::SpeculativeJIT::compile on SL bots
fpizlo@apple.com [Wed, 5 Oct 2011 22:51:31 +0000 (22:51 +0000)]
Assertion hit in JSC::DFG::SpeculativeJIT::compile on SL bots
https://bugs.webkit.org/show_bug.cgi?id=69346

Reviewed by Oliver Hunt.

Removed the assertion, since it was completely wrong for op_post_inc.
Short of having specialized PostInc nodes in the DFG, there is no
robust way of asserting what this assertion was trying to assert while
also supporting op_post_inc.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows build - it doesn't have a log2f() function...
crogers@google.com [Wed, 5 Oct 2011 22:49:05 +0000 (22:49 +0000)]
Fix Windows build - it doesn't have a log2f() function...
https://bugs.webkit.org/show_bug.cgi?id=69473

Unreviewed build fix.

* webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded a simpler mechanism for registering one-off finalizers
ggaren@apple.com [Wed, 5 Oct 2011 22:44:36 +0000 (22:44 +0000)]
Added a simpler mechanism for registering one-off finalizers
https://bugs.webkit.org/show_bug.cgi?id=69466

Reviewed by Oliver Hunt.

* heap/Heap.cpp:
(JSC::Heap::addFinalizer):
(JSC::Heap::FinalizerOwner::finalize):
* heap/Heap.h: New function for adding an arbitrary finalizer for an
arbitrary cell without declaring any special classes or Handles yourself.

* JavaScriptCore.exp: Fix build.

* runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode):
(JSC::ExecutableBase::clearCodeVirtual):
(JSC::EvalExecutable::clearCodeVirtual):
(JSC::ProgramExecutable::clearCodeVirtual):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::clearCodeVirtual):
* runtime/Executable.h:
(JSC::ExecutableBase::finishCreation): Use the new mechanism for eager
finalization of executables.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::clearRareData):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::createRareDataIfNeeded):
(JSC::JSGlobalObject::registerWeakMap): Use the new mechanism for eager
finalization of weak maps.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] ASSERT triggered when gpu process lost in single-threaded compositing...
jamesr@google.com [Wed, 5 Oct 2011 22:42:28 +0000 (22:42 +0000)]
[chromium] ASSERT triggered when gpu process lost in single-threaded compositing path
https://bugs.webkit.org/show_bug.cgi?id=69467

Reviewed by Kenneth Russell.

Shuffles debug-only bookkeeping around to more closely match what we do in the threaded path and not trip a
false-positive ASSERT().

* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doComposite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r96756.
commit-queue@webkit.org [Wed, 5 Oct 2011 22:39:30 +0000 (22:39 +0000)]
Unreviewed, rolling out r96756.
http://trac.webkit.org/changeset/96756
https://bugs.webkit.org/show_bug.cgi?id=69472

Many builds broken due to WTFGetBacktrace not being exported
from JavaScriptCore (Requested by aroben on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-05

* dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):
* dom/ScriptElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnsure RetainPtr::hashTableDeletedValue returns a pointer, not a pointer to a pointer
aroben@apple.com [Wed, 5 Oct 2011 22:23:03 +0000 (22:23 +0000)]
Ensure RetainPtr::hashTableDeletedValue returns a pointer, not a pointer to a pointer

RetainPtr's behavior of allowing the template parameter to be either a pointer type or a
pointed-to type confused us when we implemented hashTableDeletedValue.

Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
in HashMap/HashSet fails to compile

Reviewed by John Sullivan.

Source/JavaScriptCore:

* wtf/RetainPtr.h:
(WTF::RetainPtr::hashTableDeletedValue): Changed to use the PtrType typedef rather than T*,
since T might itself be a pointer.

(WTF::PtrHash<RetainPtr<P> >): Updated this to use PtrType everywhere, even though T* didn't
seem to be causing a problem.

Tools:

Add tests for using RetainPtrs inside HashMap and HashSet

* TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
(TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
and value type of HashMap.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
Added new file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agosave resource zeroing stacks in ScriptElement for debugging
gavinp@chromium.org [Wed, 5 Oct 2011 22:03:35 +0000 (22:03 +0000)]
save resource zeroing stacks in ScriptElement for debugging
https://bugs.webkit.org/show_bug.cgi?id=69453

The state machine tracking how m_cachedScript gets zeroed shows that sometimes we get
two notifyFinished() events in a ScriptElement, which can crash chrome (see chrome bug
75604).  This patch will save a stack in the ScriptElement when this happens, so that if
we do later crash, we can see how we did the first zeroing.

See http://code.google.com/p/chromium/issues/detail?id=75604 for the chromium bug that
this change will help track down.

Reviewed by Nate Chapin.

No new tests, this shouldn't affect output at all, and isn't particularly testable.

* dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):
* dom/ScriptElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-10-05 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 5 Oct 2011 21:57:16 +0000 (21:57 +0000)]
2011-10-05  Oliver Hunt  <oliver@apple.com>

        Remove last vestiges of anonymous storage.

        Reviewed by Gavin Barraclough.

        One anonymous storage function escaped my prior purge of
        this feature, this patch removes it.

        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::finishCreation):
        * runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago More build fix.
ap@apple.com [Wed, 5 Oct 2011 21:48:36 +0000 (21:48 +0000)]
    More build fix.

        * WebCore.exp.in: Made a typo in a last minute change for my 32-bit build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMark as Expected in garden-o-matic is confusing
abarth@webkit.org [Wed, 5 Oct 2011 21:46:15 +0000 (21:46 +0000)]
Mark as Expected in garden-o-matic is confusing
https://bugs.webkit.org/show_bug.cgi?id=69452

Reviewed by David Levin.

krit didn't understand the difference between this button and the
Rebaseline button because both of them seem to indicate that the new
behavior is expected.  This patch renames "Mark as Expected" to "Expect
Failure" to make it clear that we're just expecting the test to fail
rather than accepting the new results as passing.  We might need to
iterate on these names a bit more if folks continue to find them
confusing.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] Create a Skipped file to support the new WinCairo test bot.
bfulgham@webkit.org [Wed, 5 Oct 2011 21:40:40 +0000 (21:40 +0000)]
[WinCairo] Create a Skipped file to support the new WinCairo test bot.
https://bugs.webkit.org/show_bug.cgi?id=69280
(Fix bad check-in).

Reviewed by Adam Roben.

* platform/wincairo: Added.
* platform/wincairo/Skipped: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix CueParser::didFinishLoading to match changes in ThreadableLoaderClient
annacc@chromium.org [Wed, 5 Oct 2011 21:40:11 +0000 (21:40 +0000)]
Fix CueParser::didFinishLoading to match changes in ThreadableLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=69456

Reviewed by David Levin.

No new tests. No new functionality.

* html/track/CueParser.cpp:
(WebCore::CueParser::didFinishLoading):
* html/track/CueParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG should be capable of a broader range of speculations on branch and not
fpizlo@apple.com [Wed, 5 Oct 2011 21:36:23 +0000 (21:36 +0000)]
DFG should be capable of a broader range of speculations on branch and not
https://bugs.webkit.org/show_bug.cgi?id=69322

Reviewed by Oliver Hunt.

* bytecode/PredictedType.h:
(JSC::isFinalObjectOrOtherPrediction):
(JSC::isArrayOrOtherPrediction):
* dfg/DFGJITCodeGenerator.cpp:
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::JITCodeGenerator):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObjectOrOther):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArrayOrOther):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] Create a Skipped file to support the new WinCairo test bot.
bfulgham@webkit.org [Wed, 5 Oct 2011 21:35:56 +0000 (21:35 +0000)]
[WinCairo] Create a Skipped file to support the new WinCairo test bot.
https://bugs.webkit.org/show_bug.cgi?id=69280

Reviewed by Adam Roben.

* platform/wincairo: Added.
* platform/wincairo/Skipped: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/69386> REGRESSION: Curious Location of StorageTracker.db
ddkilzer@apple.com [Wed, 5 Oct 2011 21:35:14 +0000 (21:35 +0000)]
<webkit.org/b/69386> REGRESSION: Curious Location of StorageTracker.db

Reviewed by Alexey Proskuryakov.

* Storage/WebStorageManager.mm:
(+[WebStorageManager _storageDirectoryPath]): Restore call to
-[NSString stringByStandardizingPath].  Also fix over-release of
sLocalStoragePath if the initial -objectForKey: call returned an
NSString object.  Use pthread_once to be thread-safe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago 32-bit build fix.
ap@apple.com [Wed, 5 Oct 2011 21:15:10 +0000 (21:15 +0000)]
    32-bit build fix.

        * WebCore.exp.in: In 32-bit, WebCore needs to export both NSSize and CGSize constructors.
        In 64-bit, NSSize is just a typedef for CGSize. Also fixed conversion operators, for good measure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd watchlist entries for abarth
abarth@webkit.org [Wed, 5 Oct 2011 21:01:17 +0000 (21:01 +0000)]
Add watchlist entries for abarth
https://bugs.webkit.org/show_bug.cgi?id=69461

Reviewed by David Levin.

I might have gone a bit overboard.  We'll see if this is too much spam
for me.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWEB_AUDIO does not compile on Leopard 32-bit.
jer.noble@apple.com [Wed, 5 Oct 2011 20:53:43 +0000 (20:53 +0000)]
WEB_AUDIO does not compile on Leopard 32-bit.
https://bugs.webkit.org/show_bug.cgi?id=69292

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; covered by all existing audio tests.

Use of float and double within the WEB_AUDIO implementation have been harmonized, with most
calculations done using floats, with narrowPrecisionToFloat() added when necessary to
narrow double results down to floats, and with float constants initialized with float values:
* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::createByMixingToMono):
* platform/audio/AudioBus.h:
(WebCore::AudioBus::sampleRate):
(WebCore::AudioBus::setSampleRate):
* platform/audio/AudioDSPKernel.h:
(WebCore::AudioDSPKernel::AudioDSPKernel):
(WebCore::AudioDSPKernel::sampleRate):
* platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):
* platform/audio/AudioDSPKernelProcessor.h:
* platform/audio/AudioDestination.h:
* platform/audio/AudioFileReader.h:
* platform/audio/AudioProcessor.h:
(WebCore::AudioProcessor::AudioProcessor):
(WebCore::AudioProcessor::sampleRate):
* platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::decibelsToLinear):
(WebCore::AudioUtilities::linearToDecibels):
(WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
* platform/audio/AudioUtilities.h:
* platform/audio/DynamicsCompressor.cpp:
(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::initializeParameters):
(WebCore::DynamicsCompressor::parameterValue):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):
* platform/audio/DynamicsCompressor.h:
(WebCore::DynamicsCompressor::sampleRate):
(WebCore::DynamicsCompressor::nyquist):
* platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::saturate):
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::process):
* platform/audio/DynamicsCompressorKernel.h:
* platform/audio/EqualPowerPanner.cpp:
(WebCore::EqualPowerPanner::EqualPowerPanner):
* platform/audio/EqualPowerPanner.h:
* platform/audio/HRTFDatabase.cpp:
(WebCore::HRTFDatabase::create):
(WebCore::HRTFDatabase::HRTFDatabase):
* platform/audio/HRTFDatabase.h:
(WebCore::HRTFDatabase::sampleRate):
* platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
(WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
* platform/audio/HRTFDatabaseLoader.h:
(WebCore::HRTFDatabaseLoader::databaseSampleRate):
* platform/audio/HRTFElevation.cpp:
(WebCore::HRTFElevation::calculateSymmetricKernelsForAzimuthElevation):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
(WebCore::HRTFElevation::createForSubject):
(WebCore::HRTFElevation::createByInterpolatingSlices):
* platform/audio/HRTFElevation.h:
(WebCore::HRTFElevation::sampleRate):
(WebCore::HRTFElevation::HRTFElevation):
* platform/audio/HRTFKernel.cpp:
(WebCore::extractAverageGroupDelay):
(WebCore::HRTFKernel::HRTFKernel):
(WebCore::HRTFKernel::createInterpolatedKernel):
* platform/audio/HRTFKernel.h:
(WebCore::HRTFKernel::create):
(WebCore::HRTFKernel::frameDelay):
(WebCore::HRTFKernel::sampleRate):
(WebCore::HRTFKernel::HRTFKernel):
* platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::HRTFPanner):
(WebCore::HRTFPanner::fftSizeForSampleRate):
* platform/audio/HRTFPanner.h:
(WebCore::HRTFPanner::sampleRate):
* platform/audio/Panner.cpp:
(WebCore::Panner::create):
* platform/audio/Panner.h:
* platform/audio/chromium/AudioBusChromium.cpp:
(WebCore::AudioBus::loadPlatformResource):
* platform/audio/mac/AudioBusMac.mm:
(WebCore::AudioBus::loadPlatformResource):
* platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::create):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationMac::AudioDestinationMac):
* platform/audio/mac/AudioDestinationMac.h:
(WebCore::AudioDestinationMac::sampleRate):
* platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
* platform/audio/mac/AudioFileReaderMac.h:
* webaudio/AsyncAudioDecoder.cpp:
(WebCore::AsyncAudioDecoder::decodeAsync):
(WebCore::AsyncAudioDecoder::DecodingTask::create):
(WebCore::AsyncAudioDecoder::DecodingTask::DecodingTask):
* webaudio/AsyncAudioDecoder.h:
(WebCore::AsyncAudioDecoder::DecodingTask::sampleRate):
* webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
* webaudio/AudioBasicProcessorNode.h:
* webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::create):
(WebCore::AudioBuffer::createFromAudioFileData):
(WebCore::AudioBuffer::AudioBuffer):
* webaudio/AudioBuffer.h:
(WebCore::AudioBuffer::sampleRate):
* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::create):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):
* webaudio/AudioBufferSourceNode.h:
* webaudio/AudioChannelMerger.cpp:
(WebCore::AudioChannelMerger::AudioChannelMerger):
* webaudio/AudioChannelMerger.h:
(WebCore::AudioChannelMerger::create):
* webaudio/AudioChannelSplitter.cpp:
(WebCore::AudioChannelSplitter::AudioChannelSplitter):
* webaudio/AudioChannelSplitter.h:
(WebCore::AudioChannelSplitter::create):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createOfflineContext):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::createBuffer):
* webaudio/AudioContext.h:
(WebCore::AudioContext::sampleRate):
* webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
* webaudio/AudioDestinationNode.h:
* webaudio/AudioGainNode.cpp:
(WebCore::AudioGainNode::AudioGainNode):
* webaudio/AudioGainNode.h:
(WebCore::AudioGainNode::create):
* webaudio/AudioListener.cpp:
(WebCore::AudioListener::AudioListener):
* webaudio/AudioListener.h:
(WebCore::AudioListener::setPosition):
(WebCore::AudioListener::setOrientation):
(WebCore::AudioListener::setVelocity):
* webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
* webaudio/AudioNode.h:
(WebCore::AudioNode::sampleRate):
* webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::AudioPannerNode):
(WebCore::AudioPannerNode::getAzimuthElevation):
* webaudio/AudioPannerNode.h:
(WebCore::AudioPannerNode::create):
* webaudio/AudioParam.cpp:
(WebCore::AudioParam::value):
(WebCore::AudioParam::smoothedValue):
(WebCore::AudioParam::smooth):
(WebCore::AudioParam::calculateSampleAccurateValues):
* webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::timeToSampleFrame):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
* webaudio/AudioSourceNode.h:
(WebCore::AudioSourceNode::AudioSourceNode):
* webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
* webaudio/BiquadFilterNode.h:
(WebCore::BiquadFilterNode::create):
* webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::BiquadProcessor):
* webaudio/BiquadProcessor.h:
* webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
* webaudio/ConvolverNode.h:
(WebCore::ConvolverNode::create):
* webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::initialize):
* webaudio/DefaultAudioDestinationNode.h:
(WebCore::DefaultAudioDestinationNode::sampleRate):
* webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::DelayDSPKernel):
(WebCore::DelayDSPKernel::process):
* webaudio/DelayDSPKernel.h:
* webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
* webaudio/DelayNode.h:
(WebCore::DelayNode::create):
* webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::DelayProcessor):
* webaudio/DelayProcessor.h:
* webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
* webaudio/DynamicsCompressorNode.h:
(WebCore::DynamicsCompressorNode::create):
* webaudio/HighPass2FilterNode.cpp:
(WebCore::HighPass2FilterNode::HighPass2FilterNode):
* webaudio/HighPass2FilterNode.h:
(WebCore::HighPass2FilterNode::create):
* webaudio/JavaScriptAudioNode.cpp:
(WebCore::JavaScriptAudioNode::create):
(WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
(WebCore::JavaScriptAudioNode::initialize):
* webaudio/JavaScriptAudioNode.h:
* webaudio/LowPass2FilterNode.cpp:
(WebCore::LowPass2FilterNode::LowPass2FilterNode):
* webaudio/LowPass2FilterNode.h:
(WebCore::LowPass2FilterNode::create):
* webaudio/OfflineAudioDestinationNode.h:
(WebCore::OfflineAudioDestinationNode::sampleRate):
* webaudio/RealtimeAnalyserNode.cpp:
(WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):
* webaudio/RealtimeAnalyserNode.h:
(WebCore::RealtimeAnalyserNode::create):
* webaudio/WaveShaperDSPKernel.cpp:
(WebCore::WaveShaperDSPKernel::process):
* webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::WaveShaperProcessor):
* webaudio/WaveShaperProcessor.h:

Source/WebKit/chromium:

Platform-independent portions of WEB_AUDIO have changed from double -> float, and
platform-specific subclasses must change as well.

* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestination::hardwareSampleRate):
* src/AudioDestinationChromium.h:
(WebCore::AudioDestinationChromium::sampleRate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] Teach old-run-webkit-tests about wincairo.
bfulgham@webkit.org [Wed, 5 Oct 2011 20:36:33 +0000 (20:36 +0000)]
[WinCairo] Teach old-run-webkit-tests about wincairo.
https://bugs.webkit.org/show_bug.cgi?id=69280

Reviewed by Adam Roben.

* Scripts/old-run-webkit-tests: Handle wincairo case.
(buildPlatformResultHierarchy):
(readSkippedFiles): Ditto
* Scripts/webkitdirs.pm: Deal with wincairo build case.
(determineConfiguration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] [WK2] Support JS alert/confirm/prompt in QDesktopWebView
caio.oliveira@openbossa.org [Wed, 5 Oct 2011 20:28:14 +0000 (20:28 +0000)]
[Qt] [WK2] Support JS alert/confirm/prompt in QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=69274

Reviewed by Andreas Kling.

Use currently existing QtWidgets to provide an implementation of
window.alert(), window.confirm() and window.prompt().

* Shared/WebString.h:
(WebKit::WebString::createNull):
(WebKit::WebString::WebString):
Add a way to create a Null WebString. RunJavaScriptPrompt will differentiate
between empty and null strings.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::enableMouseEvents):
(QDesktopWebViewPrivate::disableMouseEvents):
Create helper functions to enable and disable mouse events. This is useful for
disabling mouse events in the WebView when we show QtWidget dialogs to avoid
unwanted interaction with the page.

(QDesktopWebViewPrivate::runJavaScriptAlert):
(QDesktopWebViewPrivate::runJavaScriptConfirm):
(QDesktopWebViewPrivate::runJavaScriptPrompt):
(QDesktopWebView::init):
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/qt/ClientImpl.cpp:
(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(createNullWKString):
(qt_wk_runJavaScriptPrompt):
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::runJavaScriptAlert):
(WebKit::TouchViewInterface::runJavaScriptConfirm):
(WebKit::TouchViewInterface::runJavaScriptPrompt):
* UIProcess/qt/TouchViewInterface.h:
* UIProcess/qt/ViewInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r96733.
commit-queue@webkit.org [Wed, 5 Oct 2011 20:01:32 +0000 (20:01 +0000)]
Unreviewed, rolling out r96733.
http://trac.webkit.org/changeset/96733
https://bugs.webkit.org/show_bug.cgi?id=69454

Broke GCC for some reason (Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-05

* wtf/ListHashSet.h:
(WTF::ListHashSetReverseIterator::ListHashSetReverseIterator):
(WTF::ListHashSetReverseIterator::get):
(WTF::ListHashSetReverseIterator::operator*):
(WTF::ListHashSetReverseIterator::operator->):
(WTF::ListHashSetReverseIterator::operator++):
(WTF::ListHashSetReverseIterator::operator--):
(WTF::ListHashSetReverseIterator::operator==):
(WTF::ListHashSetReverseIterator::operator!=):
(WTF::ListHashSetReverseIterator::operator const_reverse_iterator):
(WTF::ListHashSetReverseIterator::node):
(WTF::ListHashSetConstReverseIterator::ListHashSetConstReverseIterator):
(WTF::ListHashSetConstReverseIterator::get):
(WTF::ListHashSetConstReverseIterator::operator*):
(WTF::ListHashSetConstReverseIterator::operator->):
(WTF::ListHashSetConstReverseIterator::operator++):
(WTF::ListHashSetConstReverseIterator::operator--):
(WTF::ListHashSetConstReverseIterator::operator==):
(WTF::ListHashSetConstReverseIterator::operator!=):
(WTF::ListHashSetConstReverseIterator::node):
(WTF::::rbegin):
(WTF::::rend):
(WTF::::makeReverseIterator):
(WTF::::makeConstReverseIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputCont...
commit-queue@webkit.org [Wed, 5 Oct 2011 19:46:39 +0000 (19:46 +0000)]
[WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
https://bugs.webkit.org/show_bug.cgi?id=68924

Source/WebKit2:

Implemented WKBundlePage private APIs to support the above functions.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetComposition):
(WKBundlePageHasComposition):
(WKBundlePageConfirmComposition):
(WKBundlePageConfirmCompositionWithText):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setCompositionForTesting):
(WebKit::WebPage::hasCompositionForTesting):
(WebKit::WebPage::confirmCompositionForTesting):
* WebProcess/WebPage/WebPage.h:

Tools:

Added TextInputController files and JS interfaces for the above functions.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

* WebKitTestRunner/DerivedSources.make:
* WebKitTestRunner/DerivedSources.pro:
* WebKitTestRunner/GNUmakefile.am:
* WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::textInputController):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didClearWindowForFrame):
* WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.
(WTR::TextInputController::create):
(WTR::TextInputController::TextInputController):
(WTR::TextInputController::~TextInputController):
(WTR::TextInputController::wrapperClass):
(WTR::TextInputController::makeWindowObject):
(WTR::TextInputController::setMarkedText):
(WTR::TextInputController::hasMarkedText):
(WTR::TextInputController::unmarkText):
(WTR::TextInputController::insertText):
* WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/win/InjectedBundle.vcproj:

LayoutTests:

Unskip passed tests.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Mac] Make built-in PDF description localizable
ap@apple.com [Wed, 5 Oct 2011 19:22:21 +0000 (19:22 +0000)]
[Mac] Make built-in PDF description localizable
https://bugs.webkit.org/show_bug.cgi?id=69442

Reviewed by Dan Bernstein.

Source/WebCore:

Added strings for plug-in's name and for its supported MIME type.

* English.lproj/Localizable.strings:
* WebCore.exp.in:
* platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::builtInPDFPluginName):
(WebCore::DefaultLocalizationStrategy::pdfDocumentTypeDescription):
* platform/DefaultLocalizationStrategy.h:
* platform/LocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
(WebCore::builtInPDFPluginName):
(WebCore::pdfDocumentTypeDescription):
* platform/LocalizedStrings.h:

Source/WebKit2:

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp: Use a localized string instead of a literal one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd rudimentary filtering to write barriers
oliver@apple.com [Wed, 5 Oct 2011 19:07:18 +0000 (19:07 +0000)]
Add rudimentary filtering to write barriers
https://bugs.webkit.org/show_bug.cgi?id=69392

Reviewed by Filip Pizlo.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Add approximate filtering for write barriers based on the
target's mark bit.  Also add some macros to support dumping
GC phase timings.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
* heap/Heap.cpp:
(JSC::GCTimer::GCTimerScope::GCTimerScope):
(JSC::GCTimer::GCTimerScope::~GCTimerScope):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
   Add phase timing information.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::offsetOfMarks):
(JSC::MarkedBlock::gatherDirtyCells):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):

../../../../Volumes/Data/git/WebKit/OpenSource/Tools:

When we're recording gc phase times Heap.o picks up
some exit time destructors, so we'll just ignore Heap.o
in this check.

* Scripts/check-for-exit-time-destructors:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAttempt to fix the bindings test (broken by r96727).
levin@chromium.org [Wed, 5 Oct 2011 19:04:42 +0000 (19:04 +0000)]
Attempt to fix the bindings test (broken by r96727).
Reviewed by Adam Barth.

* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Hook WebCompositor interface for input events up to the compositor proper
jamesr@google.com [Wed, 5 Oct 2011 18:46:10 +0000 (18:46 +0000)]
[chromium] Hook WebCompositor interface for input events up to the compositor proper
https://bugs.webkit.org/show_bug.cgi?id=69394

Reviewed by Darin Fisher.

Source/WebCore:

This wires up WebCompositorImpl to the compositor itself so we can handle input events as scrolls on the
compositor thread, although it doesn't actually wire up any input events to actual scrolling. The way this
works:

- CCThreadProxy owns an adapter that implements the CCScrollController interface
- CCThreadProxy owns a CCInputHandler, which is implemented by WebKit::WebCompositorImpl, that has a pointer to
the adapter
- CCLayerTreeHost has an identifier (an int) for its WebKit::WebCompositorImpl that's initialized in
initializeLayerRenderer. This identifier is exposed to its owner (WebKit::WebViewImpl) so the embedder can wire
up the threading logic behind the scenes.

This is just plumbing, no change in behavior.

* WebCore.gypi:
* platform/graphics/chromium/cc/CCInputHandler.h: Added.
(WebCore::CCInputHandler::~CCInputHandler):
(WebCore::CCInputHandler::CCInputHandler):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::compositorIdentifier):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCScrollController.h: Added.
(WebCore::CCScrollController::CCScrollController):
(WebCore::CCScrollController::~CCScrollController):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::CCSingleThreadProxy::compositorIdentifier):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxyScrollControllerAdapter::create):
(WebCore::CCThreadProxyScrollControllerAdapter::~CCThreadProxyScrollControllerAdapter):
(WebCore::CCThreadProxyScrollControllerAdapter::scrollRootLayer):
(WebCore::CCThreadProxyScrollControllerAdapter::CCThreadProxyScrollControllerAdapter):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::compositorIdentifier):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

This teaches WebCompositorImpl about WebCore::CCInputHandler, which WebCompositorImpl implements, and
CCScrollController, which WebCompositorImpl will use in the future to do actual scrolling. One thing that is a
bit unusual here is WebCore::CCInputHandler::create() which is defined in WebCompositorImpl.cpp.  This is
because we need a WebKit object (WebKit::WebCompositorImpl) to be owned by a WebCore object (WebCore::CCThreadProxy).
The WebCore side only needs to know about the interface, CCInputHandler, but the actual implementation has to
live in WebKit in order to know about the concrete type.

* src/WebCompositorImpl.cpp:
(WebCore::CCInputHandler::create):
(WebKit::WebCompositor::fromIdentifier):
(WebKit::WebCompositorImpl::fromIdentifier):
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::setClient):
(WebKit::WebCompositorImpl::handleInputEvent):
(WebKit::WebCompositorImpl::identifier):
* src/WebCompositorImpl.h:
(WebKit::WebCompositorImpl::create):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:
* tests/WebCompositorImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse std::reverse_iterator for ListHashSet reverse iterators
andersca@apple.com [Wed, 5 Oct 2011 18:29:58 +0000 (18:29 +0000)]
Use std::reverse_iterator for ListHashSet reverse iterators
https://bugs.webkit.org/show_bug.cgi?id=69446

Reviewed by Darin Adler.

* wtf/ListHashSet.h:
Use the std::reverse_iterator iterator adaptor for the ListHashSet reverse iterators
and get rid of the ListHashSetReverseIterator and ListHashSetConstReverseIterator classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShrink OutlineValue.
commit-queue@webkit.org [Wed, 5 Oct 2011 18:22:53 +0000 (18:22 +0000)]
Shrink OutlineValue.
https://bugs.webkit.org/show_bug.cgi?id=69436

Patch by Andreas Kling <kling@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

Move OutlineValue::m_isAuto up into the base class (BorderValue.)
This shrinks OutlineValue by 32 bit, which in turn shrinks
StyleBackgroundData by one CPU word.

This reduces memory consumption by 250 kB (on 64-bit) when loading
the full HTML5 spec.

* rendering/style/BorderValue.h:
(WebCore::BorderValue::BorderValue):
* rendering/style/OutlineValue.h:
(WebCore::OutlineValue::OutlineValue):
(WebCore::OutlineValue::isAuto):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
commit-queue@webkit.org [Wed, 5 Oct 2011 18:21:07 +0000 (18:21 +0000)]
[WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
https://bugs.webkit.org/show_bug.cgi?id=69365

Patch by Chang Shu <cshu@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

Source/WebCore:

Expose computeViewportAttributes for mac build.

* WebCore.exp.in:

Source/WebKit2:

Implement retrieving viewport configuration as text in WebProcess.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageViewportConfigurationAsText):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewportConfigurationAsText):
* WebProcess/WebPage/WebPage.h:

Tools:

Added js API in WTR LayoutTestController.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::dumpConfigurationForViewport):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests:

Unskip passed tests on Qt. The tests work on Mac, too. But they are skipped by
platform/mac/Skipped.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Add baselines for new SVG tests from r96712.
simonjam@chromium.org [Wed, 5 Oct 2011 18:18:42 +0000 (18:18 +0000)]
[Chromium] Add baselines for new SVG tests from r96712.

* platform/chromium-cg-mac/svg/clip-path/clip-path-transform-1-expected.png: Added.
* platform/chromium-cg-mac/svg/clip-path/clip-path-transform-2-expected.png: Added.
* platform/chromium-cg-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
* platform/chromium-linux/svg/clip-path/clip-path-transform-1-expected.png: Added.
* platform/chromium-linux/svg/clip-path/clip-path-transform-2-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
* platform/chromium-win/svg/clip-path/clip-path-transform-1-expected.png: Added.
* platform/chromium-win/svg/clip-path/clip-path-transform-2-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake Object.prototype getter/setter methods match ES5 behaviour
barraclough@apple.com [Wed, 5 Oct 2011 18:15:55 +0000 (18:15 +0000)]
Make Object.prototype getter/setter methods match ES5 behaviour
https://bugs.webkit.org/show_bug.cgi?id=69393

Reviewed by Sam Weinig.

Source/JavaScriptCore:

The rest of Object.prototype no longer substitute Null/Undefined with the global object,
this is old ES3 behaviour. Remove it here too.

* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):

LayoutTests:

Update tests to conform with ES5 style handling of 'this' in host functions.

* fast/dom/Window/Location/window-override-location-using-defineGetter.html:
* fast/dom/Window/Location/window-override-window-using-defineGetter.html:
* fast/js/exception-sequencing-binops.js:
* fast/js/exception-sequencing.html:
* fast/js/pic/delete-global-object.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-10-05 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Wed, 5 Oct 2011 18:09:05 +0000 (18:09 +0000)]
2011-10-05  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed. Skipping media layout tests for Mac Leopard GPU.

        They're a maintenance burden and we don't run the GPU compositor on Leopard.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Functions to make <track> enabled at runtime, including changes to
annacc@chromium.org [Wed, 5 Oct 2011 18:08:32 +0000 (18:08 +0000)]
Source/WebCore: Functions to make <track> enabled at runtime, including changes to
CodeGeneratorvV8 to allow entire interfaces (not just attributes) to
be runtime-enabled.
https://bugs.webkit.org/show_bug.cgi?id=69352

Reviewed by Adam Barth.

No new tests. No new functionality.

* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled):
* bindings/scripts/CodeGeneratorV8.pm:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTextTracks):
* html/HTMLTrackElement.idl:

Source/WebKit/chromium: Functions to make <track> enabled at runtime.
https://bugs.webkit.org/show_bug.cgi?id=69352

Reviewed by Adam Barth.

* public/WebRuntimeFeatures.h:
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableVideoTrack):
(WebKit::WebRuntimeFeatures::isVideoTrackEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMask underlying RENDERER and VENDOR strings
kbr@google.com [Wed, 5 Oct 2011 18:07:21 +0000 (18:07 +0000)]
Mask underlying RENDERER and VENDOR strings
https://bugs.webkit.org/show_bug.cgi?id=69389

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/canvas/webgl/renderer-and-vendor-strings.html

* html/canvas/WebGLGetInfo.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getParameter):

LayoutTests:

* fast/canvas/webgl/renderer-and-vendor-strings-expected.txt: Added.
* fast/canvas/webgl/renderer-and-vendor-strings.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; new baselines (Skia on Mac)
caryclark@google.com [Wed, 5 Oct 2011 18:02:32 +0000 (18:02 +0000)]
Unreviewed; new baselines (Skia on Mac)

Temporarily disable Skia on Mac on Leopard and Snow Leopard.

* LayoutTests/platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] ImageDiff: Do not clear the image before it is processed and compared
commit-queue@webkit.org [Wed, 5 Oct 2011 17:56:25 +0000 (17:56 +0000)]
[EFL] ImageDiff: Do not clear the image before it is processed and compared
https://bugs.webkit.org/show_bug.cgi?id=69378

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-05
Reviewed by Antonio Gomes.

Commit 61836 to Evas added a few cleanup calls to some
evas_object_image functions which effectively made ImageDiff consider
all images to be equal.

It turns out that now evas_object_image_colorspace_set clears any
data set, so the call to evas_object_image_data_set was not having any
effect.

* DumpRenderTree/efl/ImageDiff.cpp:
(readImageFromStdin): Call evas_object_image_data_set after
evas_object_image_colorspace_set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
commit-queue@webkit.org [Wed, 5 Oct 2011 17:51:24 +0000 (17:51 +0000)]
[EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
https://bugs.webkit.org/show_bug.cgi?id=68449

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-05
Reviewed by Antonio Gomes.

evas_render() must be called to close up temporary files and unmap unused
resources. evas_object_image_data_set() must be called after an
evas_object_image_data_get() to balance an internal reference count.

* DumpRenderTree/efl/ImageDiff.cpp:
(differenceImageFromDifferenceBuffer):
(calculateDifference):
(printImage):
(printImageDifferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGet rid of posixThread in MachineStackMarker::Thread
paroga@webkit.org [Wed, 5 Oct 2011 17:44:26 +0000 (17:44 +0000)]
Get rid of posixThread in MachineStackMarker::Thread
https://bugs.webkit.org/show_bug.cgi?id=54836

Reviewed by Oliver Hunt.

* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::Thread::Thread):
(JSC::getCurrentPlatformThread):
(JSC::equalThread):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherConservativeRoots):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpec change - option.label should be reflected like option.value
commit-queue@webkit.org [Wed, 5 Oct 2011 17:41:52 +0000 (17:41 +0000)]
Spec change - option.label should be reflected like option.value
https://bugs.webkit.org/show_bug.cgi?id=68684

Patch by Sachin Puranik <jcqt43@motorola.com> on 2011-10-05
Reviewed by Darin Adler.

Source/WebCore:

Incorporating the recent change in spec for label attribute of
option element. While retrieving the "Label" IDL attribute return
the "Label" content attribute if present , else return the
value of textContent attribute.

Tests: fast/forms/option-label-trim-html-spaces.html
       fast/forms/option-value-and-label-changed-by-js.html

* dom/OptionElement.cpp:
(WebCore::OptionElement::normalizeText):style fixes
* dom/OptionElement.h: make collectOptionInnerText() protected.
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::label): return innerText if label attribute un-available.
(WebCore::HTMLOptionElement::setLabel):setLabel() implementation.
* html/HTMLOptionElement.h: add setLabel declaration.
* html/HTMLOptionElement.idl: Change reflect to ConvertNullToNullString in idl

LayoutTests:

IDL "Label" attribute of option element should return textContent IDL attribute
if conetent attribute "Label" is unavailable. Changed the tests to match
above said behaviour. Added new tests.

* fast/forms/option-label-trim-html-spaces-expected.txt: Html space triming test.
* fast/forms/option-label-trim-html-spaces.html: Html space triming test.
* fast/forms/option-value-and-label-changed-by-js-expected.txt: Attribute change from JS.
* fast/forms/option-value-and-label-changed-by-js.html: Attribute change from JS.
* fast/forms/option-value-and-label-expected.txt: Changed  test case as per new spec.
* fast/forms/option-value-and-label.html: Changed test case as per new spec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Fix compilation with gtk v2.20.1
commit-queue@webkit.org [Wed, 5 Oct 2011 17:39:01 +0000 (17:39 +0000)]
[GTK] Fix compilation with gtk v2.20.1
https://bugs.webkit.org/show_bug.cgi?id=69418

Unreviewed build fix

Patch by RĂ©mi Duraffort <remi.duraffort@st.com> on 2011-10-05

* platform/gtk/GtkDragAndDropHelper.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Reduce test flakyness.
loislo@chromium.org [Wed, 5 Oct 2011 17:19:55 +0000 (17:19 +0000)]
Unreviewed. Reduce test flakyness.
There was a race between Inspector's internal page reloaded message and load event.

* inspector/timeline/timeline-load-event-expected.txt:
* inspector/timeline/timeline-load-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=68731
hyatt@apple.com [Wed, 5 Oct 2011 17:05:29 +0000 (17:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68731

Outline sides not painted for region. Fix the painting and hit testing code for regions to add in
the maximalOutlineSize on unclipped sides. Also fix some math errors with the computation of the
translation offset and clip rects when overflow or outlines spill out.

Reviewed by Darin Adler.

Source/WebCore:

Added new test in fast/regions.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintIntoRegion):
(WebCore::RenderFlowThread::hitTestRegion):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOverflowRect):

LayoutTests:

* fast/regions/outline-sides-in-region.html: Added.
* platform/mac/fast/regions/outline-sides-in-region-expected.png: Added.
* platform/mac/fast/regions/outline-sides-in-region-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved JSValue::toJSNumber
ggaren@apple.com [Wed, 5 Oct 2011 16:52:16 +0000 (16:52 +0000)]
Removed JSValue::toJSNumber
https://bugs.webkit.org/show_bug.cgi?id=69399

No perf. change.

toJSNumber() used to provide an implicit fast path for immediate numbers,
but those fast paths are all explicit now, so it's just cruft.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-10-05 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 5 Oct 2011 16:45:04 +0000 (16:45 +0000)]
2011-10-05  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Build fix: make InspectorStateClient.h Private in XCode project.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agolibsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed
mrobinson@webkit.org [Wed, 5 Oct 2011 16:39:10 +0000 (16:39 +0000)]
libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed
https://bugs.webkit.org/show_bug.cgi?id=64263

Reviewed by Xan Lopez.

No new tests. This is difficult to test because it relies on network
timing and to catch and parse stdout.

Instead of allowing messages to pause and unpause after receiving headers,
we wait until the completion of the sendRequestCallback. This will ensure
that the SoupSession is in the correct state to allow for pausing and unpausing.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::platformSetDefersLoading): Don't pause and unpause
until the sendRequestCallback is called. We detect this situation by
checking whether or not we have an input stream yet. Previously the code
was only pausing until after soupMessage->status_code was not equal to
SOUP_STATUS_NONE. This means that the message was pausable right after
headers are received. sendRequestCallback happens some time after that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Unreviewed gardening.
ossy@webkit.org [Wed, 5 Oct 2011 16:27:30 +0000 (16:27 +0000)]
[Qt][WK2] Unreviewed gardening.

* platform/qt-wk2/Skipped: Unskip sputnik tests, because they pass with newer Qt5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for Debug builders.
loislo@chromium.org [Wed, 5 Oct 2011 16:27:17 +0000 (16:27 +0000)]
Unreviewed build fix for Debug builders.

* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSVG 1.1: ineffectual transform attribute for ClipPath
krit@webkit.org [Wed, 5 Oct 2011 16:20:32 +0000 (16:20 +0000)]
SVG 1.1: ineffectual transform attribute for ClipPath
https://bugs.webkit.org/show_bug.cgi?id=55361

Source/WebCore:

Reviewed by Nikolas Zimmermann.

Respect 'transform' attribute/property for <clip-path>.
If the masking code path is used the mask context gets transformed, otherwise the path itself.

Tests: svg/clip-path/clip-path-transform-1.svg
       svg/clip-path/clip-path-transform-2.svg
       svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting.html

* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::pathOnlyClipping): Transform the clip path.
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): Transform the context of the mask image.
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): Repaint rect must get concatenated with the current animated transformation.
(WebCore::RenderSVGResourceClipper::hitTestClipContent): Point for hit testing must be transformed by the current animated transformation.
* rendering/svg/RenderSVGResourceClipper.h:

LayoutTests:

Reviewed by Nikolas Zimmermann.

Test that the clip path gets concatenated with the current animated transformation and
that hit testing is affected correctly.

* platform/mac/svg/clip-path/clip-path-transform-1-expected.png: Added.
* platform/mac/svg/clip-path/clip-path-transform-1-expected.txt: Added.
* platform/mac/svg/clip-path/clip-path-transform-2-expected.png: Added.
* platform/mac/svg/clip-path/clip-path-transform-2-expected.txt: Added.
* svg/clip-path/clip-path-transform-1.svg: Added. Test clipping to path with transform.
* svg/clip-path/clip-path-transform-2.svg: Added. Test masking with transform.
* svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
* svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.txt: Added.
* svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting.html: Added.
* svg/dynamic-updates/script-tests/SVGClipPathElement-transform-influences-hitTesting.js: Added.
(executeBackgroundTest):
(executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: move elements panel update semantics from ElementsPanel to ElementsTre...
pfeldman@chromium.org [Wed, 5 Oct 2011 16:14:25 +0000 (16:14 +0000)]
Web Inspector: move elements panel update semantics from ElementsPanel to ElementsTreeOutline.
https://bugs.webkit.org/show_bug.cgi?id=69431

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.show):
(WebInspector.ElementsPanel.prototype.hide):
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._reset):
(WebInspector.ElementsPanel.prototype._nodeRemoved):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype.wireToDomAgent):
(WebInspector.ElementsTreeOutline.prototype.setVisible):
(WebInspector.ElementsTreeOutline.prototype.addEventListener):
(WebInspector.ElementsTreeOutline.prototype.removeEventListener):
(WebInspector.ElementsTreeOutline.prototype.selectDOMNode):
(WebInspector.ElementsTreeOutline.prototype.update):
(WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged):
(WebInspector.ElementsTreeOutline.prototype.findTreeElement.parentNode):
(WebInspector.ElementsTreeOutline.prototype.findTreeElement):
(WebInspector.ElementsTreeOutline.prototype.createTreeElementFor):
(WebInspector.ElementsTreeOutline.prototype._ondrop.callback):
(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeOutline.prototype.adjustCollapsedRange):
(WebInspector.ElementsTreeOutline.prototype._updateModifiedNodes):
(WebInspector.ElementsTreeElement.prototype.insertChildElement):
(WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded):
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._editingCancelled):
():
* inspector/front-end/externs.js:
(WebInspector.ElementsTreeOutline):
* inspector/front-end/utilities.js:

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpElementsTree):
(initialize_ElementTest.InspectorTest.expandElementsTree.onAllNodesAvailable):
(initialize_ElementTest.InspectorTest.expandElementsTree):
* inspector/elements/edit-dom-actions.html:
* inspector/styles/styles-update-from-js.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: provide a way for persisting worker inspector state
yurys@chromium.org [Wed, 5 Oct 2011 16:10:31 +0000 (16:10 +0000)]
Web Inspector: provide a way for persisting worker inspector state
https://bugs.webkit.org/show_bug.cgi?id=69422

Source/WebCore:

Worker inspector can persist and restore its state. InspectorStateClient is
exctracted into a separate interface and has a custom implementation in case
of worker inspector.

Reviewed by Pavel Feldman.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorClient.h:
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
* inspector/InspectorStateClient.h: Copied from Source/WebCore/inspector/InspectorClient.h.
(WebCore::InspectorStateClient::~InspectorStateClient):
(WebCore::InspectorStateClient::updateInspectorStateCookie):
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
* inspector/WorkerInspectorController.h:
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postMessageToPageInspector):
(WebCore::SharedWorkerProxy::updateInspectorStateCookie):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::updateInspectorStateCookie):
* workers/WorkerMessagingProxy.h:
* workers/WorkerReportingProxy.h:

Source/WebKit/chromium:

Provided an API for saving/restoring worker inspector state.

Reviewed by Pavel Feldman.

* public/WebCommonWorkerClient.h:
(WebKit::WebCommonWorkerClient::saveDevToolsAgentState):
* public/WebSharedWorker.h:
(WebKit::WebSharedWorker::reattachDevTools):
* src/WebSharedWorkerImpl.cpp:
(WebKit::reconnectToWorkerContextInspectorTask):
(WebKit::WebSharedWorkerImpl::reattachDevTools):
* src/WebSharedWorkerImpl.h:
* src/WebWorkerBase.cpp:
(WebKit::WebWorkerBase::updateInspectorStateCookie):
(WebKit::WebWorkerBase::updateInspectorStateCookieTask):
* src/WebWorkerBase.h:
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::updateInspectorStateCookie):
* src/WebWorkerClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: debugger-activation-crash2.html are flaky.
loislo@chromium.org [Wed, 5 Oct 2011 16:09:52 +0000 (16:09 +0000)]
Web Inspector: debugger-activation-crash2.html are flaky.
https://bugs.webkit.org/show_bug.cgi?id=69428

Reviewed by Yury Semikhatsky.

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/debugger-activation-crash2-expected.txt:
* inspector/debugger/debugger-activation-crash2.html:
* platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r96595): WTFReportBacktrace listed as the top frame in all assertion...
gavinp@chromium.org [Wed, 5 Oct 2011 15:51:38 +0000 (15:51 +0000)]
REGRESSION (r96595): WTFReportBacktrace listed as the top frame in all assertion backtraces
https://bugs.webkit.org/show_bug.cgi?id=69424

Skip an extra frame in WTFReportBacktrace.  As well, I now don't count skipped frames in maxFrames,
so I've updated maxFrames to 31, as with one skipped frame the previous value was effectively
31 reported frames.

Reviewed by Adam Roben.

* wtf/Assertions.cpp:
* wtf/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in SVGTRefElement::updateReferencedText.
inferno@chromium.org [Wed, 5 Oct 2011 15:40:05 +0000 (15:40 +0000)]
Crash in SVGTRefElement::updateReferencedText.
https://bugs.webkit.org/show_bug.cgi?id=67555

Reviewed by Rob Buis.

Source/WebCore:

Test: svg/text/tref-event-listener-crash.svg

* svg/SVGTRefElement.cpp:
(WebCore::SubtreeModificationEventListener::clear): This fixes the
crash. there can be cases when our target is removed, but our event
listener is alive. when our tref is going away, we need to disable
those event listeners by nulling out our tref element.
(WebCore::SubtreeModificationEventListener::handleEvent): Adding
null check for tref element, which can happen in cases where
event listener's clear is called, but we could not remove it from
the target.
(WebCore::SVGTRefElement::~SVGTRefElement): There are always
cases when removedFromDocument is not called. So, important to
clear event listener in those cases.
(WebCore::SVGTRefElement::svgAttributeChanged): Use common
function buildPendingResource.
(WebCore::SVGTRefElement::buildPendingResource): Common function
to prevent triple duplication of same code. made it more readable.
(WebCore::SVGTRefElement::insertedIntoDocument): Use common
function buildPendingResource.
(WebCore::SVGTRefElement::removedFromDocument): Use new helper
removeEventListener.
(WebCore::SVGTRefElement::clearEventListener): Helper to clear
event listener. Name chosen to not collide with Node::removeEventListener.
* svg/SVGTRefElement.h: definition of new helpers.
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedIntoDocument): Copy same
logic as tref and use element. more asserts and easy bailouts.

LayoutTests:

* svg/text/tref-event-listener-crash-expected.txt: Added.
* svg/text/tref-event-listener-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-10-05 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 5 Oct 2011 15:18:57 +0000 (15:18 +0000)]
2011-10-05  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: restoring : shortcut in inspector.

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._createSidebarButtons):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShrink FontDescription.
andreas.kling@nokia.com [Wed, 5 Oct 2011 15:13:00 +0000 (15:13 +0000)]
Shrink FontDescription.
https://bugs.webkit.org/show_bug.cgi?id=69426

Reviewed by Nikolas Zimmermann.

Pack FontDescription's members in a bitfield, effectively shrinking
the class by two CPU-words. This reduces memory consumption by ~1 MB
on 64-bit when loading the full HTML5 spec.

* platform/graphics/FontDescription.h:
(WebCore::FontDescription::orientation):
(WebCore::FontDescription::textOrientation):
(WebCore::FontDescription::widthVariant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] First test always fails because of useless xcb dump
kbalazs@webkit.org [Wed, 5 Oct 2011 14:51:58 +0000 (14:51 +0000)]
[Qt][WK2] First test always fails because of useless xcb dump
https://bugs.webkit.org/show_bug.cgi?id=69132

Unskip the first test because the failure always affects the first test we run
so skipping makes no sense.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Add support for search in script content.
vsevik@chromium.org [Wed, 5 Oct 2011 14:30:29 +0000 (14:30 +0000)]
Web Inspector: Add support for search in script content.
https://bugs.webkit.org/show_bug.cgi?id=69015

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: http/tests/inspector/search/search-in-concatenated-script.html
       http/tests/inspector/search/search-in-script.html

* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/ContentProviders.js:
(WebInspector.ScriptContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._sortedScripts.var):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._sortedScripts):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.maybeCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.requestSource.didGetScriptSource):
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.searchInContent):

LayoutTests:

* http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest):
* http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.maybeCallback):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.addSniffer):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.resourceAddedToFrame):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.visit):
(initialize_ResourceTest):
* http/tests/inspector/search/resources/search-concatenated.html: Added.
* http/tests/inspector/search/search-in-concatenated-script-expected.txt: Added.
* http/tests/inspector/search/search-in-concatenated-script.html: Added.
* http/tests/inspector/search/search-in-resource.html:
* http/tests/inspector/search/search-in-script-expected.txt: Added.
* http/tests/inspector/search/search-in-script.html: Added.
* http/tests/inspector/search/search-test.js:
(initialize_SearchTest):
* inspector/debugger/content-providers.html:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Default directories and paths are missing for LocalStorage, Database and...
alexis.menard@openbossa.org [Wed, 5 Oct 2011 14:20:22 +0000 (14:20 +0000)]
[Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.
https://bugs.webkit.org/show_bug.cgi?id=69111

Reviewed by Kenneth Rohde Christiansen.

Provide default path for LocalStorage, Database and IconDatabase using QDesktopServices.

Source/WebCore:

No new tests : existing ones should cover.

* platform/qt/CookieJarQt.cpp:
(WebCore::SharedCookieJarQt::SharedCookieJarQt):

Source/WebKit2:

* UIProcess/qt/WebContextQt.cpp:
(WebKit::defaultDataLocation):
(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultIconDatabasePath):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Try to paint the bot green.
kbalazs@webkit.org [Wed, 5 Oct 2011 14:19:51 +0000 (14:19 +0000)]
[Qt][WK2] Try to paint the bot green.

Unreviewed gardening.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for !ENABLE(FILTERS) after r96203.
paroga@webkit.org [Wed, 5 Oct 2011 14:14:01 +0000 (14:14 +0000)]
Unreviewed build fix for !ENABLE(FILTERS) after r96203.

* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientUpdatedFromElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWTR needs an implementation for eventSender.continuousMouseScrollBy
kbalazs@webkit.org [Wed, 5 Oct 2011 13:53:49 +0000 (13:53 +0000)]
WTR needs an implementation for eventSender.continuousMouseScrollBy
https://bugs.webkit.org/show_bug.cgi?id=69417

Unreviewed gardening: skip dependent test.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Unreviewed build fix.
kbalazs@webkit.org [Wed, 5 Oct 2011 13:08:51 +0000 (13:08 +0000)]
[Qt][WK2] Unreviewed build fix.

Don't use WebCore directly in WTR.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for windows bots after r96679.
loislo@chromium.org [Wed, 5 Oct 2011 12:21:19 +0000 (12:21 +0000)]
Unreviewed build fix for windows bots after r96679.

* html/NumberInputType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed rebaseline for test.
loislo@chromium.org [Wed, 5 Oct 2011 12:03:03 +0000 (12:03 +0000)]
Unreviewed rebaseline for test.

* inspector/debugger/linkifier-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: make ResourceView(s) compile
pfeldman@chromium.org [Wed, 5 Oct 2011 11:55:41 +0000 (11:55 +0000)]
Web Inspector: make ResourceView(s) compile
https://bugs.webkit.org/show_bug.cgi?id=69351

Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable.prototype._sortCookies):
* inspector/front-end/DataGrid.js:
* inspector/front-end/EmptyView.js:
* inspector/front-end/FontView.js:
(WebInspector.FontView.prototype._createContentIfNeeded):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
(WebInspector.ImageView.prototype._createContentIfNeeded):
(WebInspector.ImageView.prototype._openInNewTab):
* inspector/front-end/NetworkItemView.js:
* inspector/front-end/ResourceCookiesView.js:
* inspector/front-end/ResourceHTMLView.js:
(WebInspector.ResourceHTMLView.prototype.hide):
* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView.prototype._refreshParms):
(WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle):
(WebInspector.ResourceHeadersView.prototype._refreshHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshHeadersText):
* inspector/front-end/ResourceJSONView.js:
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.parseJSONP):
* inspector/front-end/ResourcePreviewView.js:
* inspector/front-end/ResourceResponseView.js:
* inspector/front-end/ResourceTimingView.js:
(WebInspector.ResourceTimingView.createTimingTable):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame):
* inspector/front-end/SourceFrame.js:
* inspector/front-end/TabbedPane.js:
* inspector/front-end/UIUtils.js:
(Number.secondsToString):
(Number.bytesToString):
* inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure...
loislo@chromium.org [Wed, 5 Oct 2011 11:41:07 +0000 (11:41 +0000)]
Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances.
https://bugs.webkit.org/show_bug.cgi?id=69146

In many places we use linkifyLocation function to produce a link node which updates automatically when the source file is changed on the fly.
Such changes happen when we use pretty print or another operation that changes the source code somehow.
linkifyLocation associates a new instance of updateAnchor closure with the each link node and add the closure to the SourceMappingUpdated event's list.
As the result the node<->closure pairs wouldn't be collected until reset the UI and DebuggerPresentationModel.

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/linkifier.html

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.createLinkifier):
(WebInspector.DebuggerPresentationModel.Linkifier):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateSourceAnchors):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.createCell):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._linkifyLocation):
(WebInspector.TimelinePanel.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
* inspector/front-end/inspector.js:

LayoutTests:

* inspector/debugger/linkifier-expected.txt: Added.
* inspector/debugger/linkifier.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r82611) InlineBox has 33 bits of bitset, causing alignment issues and...
andreas.kling@nokia.com [Wed, 5 Oct 2011 11:38:51 +0000 (11:38 +0000)]
REGRESSION(r82611) InlineBox has 33 bits of bitset, causing alignment issues and extra memory use.
https://bugs.webkit.org/show_bug.cgi?id=64914

Reviewed by Antti Koivisto.

Remove InlineBox::prevOnLineExists() and its two accompanying bitfields
since nobody is using them anymore. nextOnLineExists() is still used by
GTK+ accessibility code.

Also added a compile-time assertion to guard against future bloating of
the InlineBox class.

* rendering/InlineBox.cpp:
(WebCore::SameSizeAsInlineBox::~SameSizeAsInlineBox):
* rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96693 268f45cc-cd09-0410-ab3c-d52691b4dbfc