20 years ago * THANKS: Demangled.
mjs [Thu, 30 May 2002 21:01:14 +0000 (21:01 +0000)]
* THANKS: Demangled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Use NSWorkspace methods instead of Launch Services and Finder functions.
cblu [Thu, 30 May 2002 18:55:51 +0000 (18:55 +0000)]
    Use NSWorkspace methods instead of Launch Services and Finder functions.

        * MIME.subproj/IFDownloadHandler.h:
        * MIME.subproj/IFDownloadHandler.mm:
        * WebView.subproj/IFWebFrame.mm:
        (-[IFWebFrame setProvisionalDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoAlex-7 version
sheridan [Thu, 30 May 2002 16:15:20 +0000 (16:15 +0000)]
Alex-7 version

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Added 'canDraw' check to ensure that we can render
rjw [Thu, 30 May 2002 15:38:57 +0000 (15:38 +0000)]
Added 'canDraw' check to ensure that we can render
    an image frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Changes to support animated image rendering.
rjw [Thu, 30 May 2002 05:13:03 +0000 (05:13 +0000)]
Changes to support animated image rendering.
    Moved image rendering into webkit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Changes to support animated image rendering.
rjw [Thu, 30 May 2002 05:12:53 +0000 (05:12 +0000)]
Changes to support animated image rendering.
    Moved image rendering into webkit.
    Still need to implement preferences stubs and
    start/stop stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Removed acceptsFirstMouse override, this fixes at least:
sullivan [Wed, 29 May 2002 20:26:00 +0000 (20:26 +0000)]
Removed acceptsFirstMouse override, this fixes at least:

2930713 -- clicking on an empty part of window to bring it to front
takes focus away from page address field

2938028 -- Link cursor doesn't appear when browser window not
frontmost, but clicks activate links

* WebView.subproj/IFWebView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Moved cancellation check before creation on job instance,
rjw [Wed, 29 May 2002 00:00:42 +0000 (00:00 +0000)]
Moved cancellation check before creation on job instance,
    preventing leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Made -[IFBookmark group] and -[IFBookmark parent] public
sullivan [Tue, 28 May 2002 23:55:07 +0000 (23:55 +0000)]
Made -[IFBookmark group] and -[IFBookmark parent] public
methods, and renamed them to not use leading underscores,
as part of support for revealing a particular bookmark in
the Bookmarks window.

* Bookmarks.subproj/IFBookmark_Private.h:
removed _group and _parent.

* Bookmarks.subproj/IFBookmark.h:
added group and parent.

- fixed 2923488 -- Silent failure when bookmark URL is invalid URL
- fixed 2935830 (urls in Bookmarks should be "canonicalized" like
urls in location field)
- fixed 2935388 (errors in Activity window shouldn't show numeric
error codes)

* IFBookmarkAdditions.h: Added.
* IFBookmarkAdditions.m: Added.
(-[IFBookmark goTo]):
New category, adds browser-specific behavior to IFBookmark. The first
and only method so far goes to the bookmark's address; if the address string
can't be turned into a valid URL, the user is told and given an opportunity
to fix the address.

* AppController.h:
* AppController.m:
(-[AppController showBookmarks:]):
Moved initialization of _bookmarksController ivar out of here.
(-[AppController _takeLocationFromBookmark:]):
Now calls -[IFBookmark goTo].
(-[AppController bookmarksController]):
New public method, initializes _bookmarksController ivar if necessary.

* BookmarksController.h:
* BookmarksController.m:
(-[BookmarksController _goToSelectedItem:]): Now calls -[IFBookmark goTo].
(-[BookmarksController _expandAncestorsOfBookmark:]): New method, ensures that
each ancestor folder of the specified bookmark is expanded in the outline view.
(-[BookmarksController revealBookmark:]): New method, expands the bookmark's
ancestors, then selects the bookmark and scrolls to reveal as necessary.
(-[BookmarksController _editSelectedColumnWithID:]): New helper method,
edits the contents of the specified column for the selected row.
(-[BookmarksController editSelectedAddress]),
(-[BookmarksController editSelectedName]): New methods, they call
_editSelectedColumnWithID: for different columns.
(-[BookmarksController _toggleEdit:]): Now calls editSelectedName.

* IFErrorAdditions.m:
(-[IFError errorSummary]): Removed error code from the string this method

* WebBrowser.pbproj/project.pbxproj: Updated for new files; also added new
WebKit Additions group and moved some existing files into it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed edge case cancellation problem (actually happens a lot).
rjw [Tue, 28 May 2002 23:17:36 +0000 (23:17 +0000)]
Fixed edge case cancellation problem (actually happens a lot).
    No new loads are allowed after a data source has been
    set as "stopping".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Backed out band-aid add to fixed malformed resources URLs.
rjw [Tue, 28 May 2002 22:11:32 +0000 (22:11 +0000)]
Backed out band-aid add to fixed malformed resources URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed reporting of malformed resources URLs. This fixed
rjw [Tue, 28 May 2002 22:10:34 +0000 (22:10 +0000)]
Fixed reporting of malformed resources URLs.  This fixed
    exceptions that were being thrown because nil handles were
    being added to datasource handle array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago*** empty log message ***
cblu [Tue, 28 May 2002 21:07:37 +0000 (21:07 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed double free of mapped file bytes (it's freed
rjw [Tue, 28 May 2002 20:18:21 +0000 (20:18 +0000)]
Fixed double free of mapped file bytes (it's freed
    by munmap).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoWebBrowser:
cblu [Tue, 28 May 2002 18:34:23 +0000 (18:34 +0000)]

Drag & Drop of file and URL support for the location field.

* LocationFieldEditor.m:
(-[LocationFieldEditor acceptableDragTypes]): Added URL and file drag types
(-[LocationFieldEditor draggingEntered:]): new
(-[LocationFieldEditor draggingUpdated:]): new
(-[LocationFieldEditor prepareForDragOperation:]): new
(-[LocationFieldEditor performDragOperation:]): new
(-[LocationFieldEditor concludeDragOperation:]): support for URL and file types


* Plugins.subproj/IFPluginDatabase.h:
* Plugins.subproj/IFPluginDatabase.m:
(-[IFPluginDatabase pluginForMimeType:]): renamed
(-[IFPluginDatabase pluginForExtension:]): renamed
(-[IFPluginDatabase pluginForFilename:]): renamed
* WebCoreSupport.subproj/IFWebCoreViewFactory.m: support for above renamed
(-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]):
(-[IFWebCoreViewFactory viewForJavaAppletWithArguments:]):
* WebView.subproj/IFWebDataSourcePrivate.mm:
(-[IFWebDataSource _addURLHandle:]): fix for a nil handle being added to an array


Added framework-header-stamp

* .cvsignore:


Fix for 2938040 - This flash movie at macboy.com doesn't load

* Misc.subproj/IFNSStringExtensions.m:
(-[NSString _IF_looksLikeAbsoluteURL]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * WebCoreSupport.subproj/IFTextRenderer.m:
darin [Tue, 28 May 2002 17:39:08 +0000 (17:39 +0000)]
* WebCoreSupport.subproj/IFTextRenderer.m:
(hasMissingGlyphs): Use recordSize instead of assuming records are sizeof(ATSLayoutRecord).
(-[IFTextRenderer convertCharacters:length:toGlyphs:]): Free buffer after calling
ATSUConvertCharToGlyphs; old code was using buffer after freeing it.
(-[IFTextRenderer widthForString:]): Handle case where string is longer than
(-[IFTextRenderer slowPackGlyphsForCharacters:numCharacters:glyphBuffer:numGlyphs:]):
(-[IFTextRenderer drawString:atPoint:withColor:]): Use recordSize instead of assuming records
are sizeof(ATSLayoutRecord).
(-[IFTextRenderer slowFloatWidthForCharacters:length:]): Use recordSize instead of assuming
records are sizeof(ATSLayoutRecord).
(-[IFTextRenderer floatWidthForCharacters:length:]): Remove extra rounding. The caller that
converts the width to an integer already does the rounding.
(-[IFTextRenderer extendCharacterToGlyphMapToInclude:]): Fix off by one error that caused us
to include one extra character in each glyph map block. Also use recordSize instead of assuming
records are sizeof(ATSLayoutRecord).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Part of fix for 2922772 -- page title & location field don't
sullivan [Mon, 27 May 2002 21:32:58 +0000 (21:32 +0000)]
Part of fix for 2922772 -- page title & location field don't
show redirected URLs.

* WebView.subproj/IFWebDataSource.mm:
(-[IFWebDataSource wasRedirected]): Fixed this method, now that
we have a client that relies on it. Its logic was backwards, and
it didn't handle the null _finalURL case.

WebBrowser part of fix for 2922772 -- page title & location field don't
show redirected URLs.

* BrowserDocument.h: added BrowserDocumentRedirectedNotification
* BrowserDocument.m:
(-[BrowserDocument currentURL]): Return redirectedURL if appropriate.

* BrowserWindow.m:
(-[BrowserWindow windowDidLoad]): register for BrowserDocumentRedirectedNotification
(-[BrowserWindow frameLoadRedirected:]): Update location field if appropriate.

* LocationChangeHandler.m:
(-[LocationChangeHandler serverRedirectTo:forDataSource:]):
Send BrowserDocumentRedirectedNotification and title-changed
messages if the frame is the top-level frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * Resources/linkCursor.tiff: Added. Maciej forgot to cvs add
sullivan [Mon, 27 May 2002 19:55:08 +0000 (19:55 +0000)]
* Resources/linkCursor.tiff: Added. Maciej forgot to cvs add
this new file. I stole the one from haircut.

Added FIXME.
* BrowserDocument.m:
(-[BrowserDocument displayName]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed the vexing and long-standing:
mjs [Mon, 27 May 2002 08:58:31 +0000 (08:58 +0000)]
Fixed the vexing and long-standing:

Radar 2894699 - Crash at: http://cb.apple.com/jsplugins.html

* khtml/ecma/kjs_navigator.cpp: This crash was caused by Plugin
and MimeType objects referring to data that was held and
refcounted by PluginBase, without holding a ref. I fixed it by
making these individual items participate in the refcounting as

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed Radar 936147 - debug output in console "keyUp: NSEvent: type=KeyUp"
mjs [Mon, 27 May 2002 05:59:57 +0000 (05:59 +0000)]
Fixed Radar 936147 - debug output in console "keyUp: NSEvent: type=KeyUp"

* WebView.subproj/IFWebView.mm:
(-[IFWebView keyDown:]): Turned NSLog into WEBKITDEBUGLEBEL.
(-[IFWebView keyUp:]): Likewise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoWebCore:
mjs [Mon, 27 May 2002 05:01:51 +0000 (05:01 +0000)]
Webcore part of fix for:

Radar 2884085 - add support for changing cursor over links

* Makefile.am: Install tiff of link cursor.
* kwq/qt/qcursor.h, kwq/KWQCursor.mm:
(QCursor::QCursor): Change QCursor to contain an NSCursor.
(QCursor::~QCursor): Likewise.
(QCursor::operator=): Likewise.
(QCursor::handle): Likewise.
* kwq/KWQKCursor.mm:
(+[NSCursor _WebCore_linkCursor]): NSCursor extension method that
provides the link cursor.
(KCursor::handCursor): Use the link cursor instead of the default
arrow cursor.
* kwq/KWQKHTMLSettings.mm:
(KHTMLSettings::changeCursor): Return TRUE; we always want cursor
* kwq/KWQView.h, kwq/KWQView.mm:
(-[KWQHTMLView setCursor:]): Remember the new cursor and
invalidate cursor rects.
(-[KWQHTMLView resetCursorRects]): Establish cursor rect for
currently set cursor, if not default.
* kwq/KWQWidget.mm:
(QWidget::setCursor): Call setCursor: on the underlying
NSView, if implemented.
(QWidget::cursor): Implemented.
(QWidget::unsetCursor): Implemented.

WebKit part of fix for:

Radar 2884085 - add support for changing cursor over links

Also, fix handling of mouseMoved events.

* WebView.subproj/IFWebView.mm:
(-[IFWebView mouseMovedNotification:]): Clip mouseMoved events to
the view rect, otherwise mouseover effects might happen for
elements past the edge of the window.
(-[IFWebView setCursor:]): Implement.
(-[IFWebView resetCursorRects]): Implement.
* WebView.subproj/IFWebViewPrivate.h:
* WebView.subproj/IFWebViewPrivate.mm:
(-[IFWebViewPrivate dealloc]): Added NSCursor *cursor field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoWebCore:
mjs [Sat, 25 May 2002 10:47:40 +0000 (10:47 +0000)]
Changed WebCore to build as a framework, not a dylib, so resources
can be added to it.

* Makefile.am: Actual changes to build WebCore.framework
* Resources/Info.plist: Added.
* English.lproj/InfoPlist.strings: Added.
* WebCore-tests.exp: Added.
* WebCore.exp: Added.
* libwebcore.exp: Removed.
* libwebcoretests.exp: Removed.
* .cvsignore: Updated.

* WebKit.pbproj/project.pbxproj: Link against WebCore.framework,
not libwebcore.dylib.

* WebBrowser.pbproj/project.pbxproj: Link against
WebCore.framework, not libwebcore.dylib.

Top level:
Link against WebCore.framework, not libwebcore.dylib.

* Tests/kde/Makefile.am:
* Tests/khtmlview/WebViewTest/WebViewTest.pbproj/project.pbxproj:
* Tests/qt/Makefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Added license and acknowledgements.
mjs [Fri, 24 May 2002 22:12:53 +0000 (22:12 +0000)]
Added license and acknowledgements.

* AUTHORS: Added.
* THANKS: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agomodified changelogs with 0.3 markers
sheridan [Fri, 24 May 2002 16:57:54 +0000 (16:57 +0000)]
modified changelogs with 0.3 markers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoAlexander-6 version
sheridan [Fri, 24 May 2002 15:45:35 +0000 (15:45 +0000)]
Alexander-6 version

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoWebCore:
mjs [Thu, 23 May 2002 22:44:52 +0000 (22:44 +0000)]
Fixes for the following (the first bug also requires WebKit and
WebBrowser changes):

Radar 2896391 - command-click should open link in new window
Radar 2935858 - two mails for each mailto:

* khtml/html/html_inlineimpl.cpp:
(HTMLAnchorElementImpl::defaultEventHandler): Set flag for Meta
key in addition to Control, Shift and Alt, since the Command key
is treated as Meta.
* kwq/KWQKHTMLPart.mm:
(KHTMLPart::urlSelected): Open a new window if the user
(KHTMLPart::khtmlMouseMoveEvent): Clean up use of braces and ifdefs to
make prepare-ChangeLog happy.
(KHTMLPart::khtmlMouseReleaseEvent): Remove code that tried to
process link click events here. This made link clicks get
processed twice, now that mouse events are hooked up for real.
* kwq/external.h: prototype openNewWindowWithURL: method.

WebKit part of the fix for:

Radar 2896391 - command-click should open link in new window

* WebView.subproj/IFBaseWebController.mm:
(-[IFBaseWebController openNewWindowWithURL:]): Default
implementation silently does nothing.
* WebView.subproj/IFWebController.h: Add openNewWindowWithURL:
* WebView.subproj/IFWebView.mm:
(-[IFWebView _addModifiers:toState:]): Split out modifier key
handling to here. Treat Command as Meta.
(-[IFWebView mouseUp:]): Use new method to set key modifiers for
mouse events.
(-[IFWebView mouseDown:]): Use new method to set key modifiers for
mouse events.
(-[IFWebView keyDown:]): Use new shared code for key modifiers.
(-[IFWebView keyUp:]): Use new shared code for key modifiers.

WebBrowser part of the fix for:

Radar 2896391 - command-click should open link in new window

* WebController.m:
(-[WebController openNewWindowWithURL:]): Implement this new
IFWebController method by opening a new browser window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago2002-05-23 Kenneth Kocienda <kocienda@apple.com>
kocienda [Thu, 23 May 2002 22:23:45 +0000 (22:23 +0000)]
2002-05-23  Kenneth Kocienda  <kocienda@apple.com>

        Reviewed by: Maciej Stachowiak

        Fix for this bug:

        Radar 2935882 (IFURLFileReader class has unbalanaced release count on an NSData ivar)

        IFURLFileReader can create an ivar that points to a data using an method that
        returns an autoreleased object. Then, without retaining the data anywhere
        internally, it releases the data in its dealloc method.

        This has been fixed. Now the retain/release count is guaranteed to be balanced

        * Database.subproj/IFURLFileDatabase.m:
        (-[IFURLFileReader initWithPath:])

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago2002-05-23 Kenneth Kocienda <kocienda@apple.com>
kocienda [Thu, 23 May 2002 22:11:50 +0000 (22:11 +0000)]
2002-05-23  Kenneth Kocienda  <kocienda@apple.com>

        More work to fix this bug:

        Radar 2883631 (need to implement support for META HTTP_EQUIV=REFRESH)

        There was yet two more cases where the refresh timers were getting clobbered.

        * khtml/ecma/kjs_window.cpp:
        * khtml/khtmlview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed crasher 2935757. I still need to investigate the root cause
rjw [Thu, 23 May 2002 22:01:54 +0000 (22:01 +0000)]
Fixed crasher 2935757.  I still need to investigate the root cause
    of this problem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago2002-05-23 Kenneth Kocienda <kocienda@apple.com>
kocienda [Thu, 23 May 2002 18:36:13 +0000 (18:36 +0000)]
2002-05-23  Kenneth Kocienda  <kocienda@apple.com>

        Fixes for these bugs:

        Radar 2883631 (need to implement support for META HTTP_EQUIV=REFRESH)
        Radar 2935472 (Non-standard html pages don't always get decoded)


        * khtml/khtml_part.cpp: Don't kill all timers. Just kill the ones for this object.
        * khtml/khtml_part.h: Modified interface to slotData to add a flag for when all data
          for a load has been received.
        * khtml/khtmlview.cpp:
        (KHTMLView::~KHTMLView): Don't kill all timers. Just kill the ones for this object.
        * kwq/KWQKHTMLPart.mm:
        (KHTMLPart::slotData): Senses when text encoding is not available, but all data has been received.
        (KHTMLPart::write): Ditto
        * libwebcore.exp: Changed symbol for slotData


        * WebView.subproj/IFMainURLHandleClient.h:
        * WebView.subproj/IFMainURLHandleClient.mm:
        (-[IFMainURLHandleClient setContentPolicy:]): Updated method to use new processData interface.
        (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Senses when all data has been received for a load.
        (-[IFMainURLHandleClient processData:isComplete:allDataReceived:]): Modified interface to add a flag
          for when all data for a load has been received.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agochanging version number back to "unofficial"
sheridan [Thu, 23 May 2002 16:38:09 +0000 (16:38 +0000)]
changing version number back to "unofficial"
tree is open

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoWebKit:
mjs [Thu, 23 May 2002 13:13:45 +0000 (13:13 +0000)]
Move authentication panel to WebKit and make it a sheet, fixing:

Radar 2876445 - Authentication panel should be a sheet
Radar 2876449 - The Alexander authentication panel should be moved
to WebKit for use as a standard one

* Panels.subproj/English.lproj/IFAuthenticationPanel.nib: Added.
* Panels.subproj/IFAuthenticationPanel.h: Added.
* Panels.subproj/IFAuthenticationPanel.m: Added.
* Panels.subproj/IFPanelAuthenticationHandler.h: Added.
* Panels.subproj/IFPanelAuthenticationHandler.m: Added.
* Panels.subproj/IFStandardPanels.h: Added.
* Panels.subproj/IFStandardPanels.m: Added.
* Panels.subproj/IFStandardPanelsPrivate.h: Added.
* WebKit.pbproj/project.pbxproj: Add new files to build.
* Plugins.subproj/IFPluginStream.mm:
(-[IFPluginStream IFURLHandleResourceDidBeginLoading:]): Notify of
load start.
(-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): Notify
of load end.
(-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): Likewise.
(-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): Likewise.
(-[IFPluginStream IFURLHandle:didRedirectToURL:]): Notify that old
URL is no longer loading, but new one is.
* WebView.subproj/IFBaseWebControllerPrivate.h:
* WebView.subproj/IFBaseWebControllerPrivate.mm:
(-[IFBaseWebController _didStartLoading:]): New private method
used to track what URLs are loading on behalf of this controller.
(-[IFBaseWebController _didStopLoading:]): Likewise.

* WebView.subproj/IFMainURLHandleClient.mm:
(-[IFMainURLHandleClient IFURLHandleResourceDidBeginLoading:]): Notify
of load start.
(-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): Notify
of load end.
(-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): Likewise.
(-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Likewise.
(-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Likewise.
(-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): Notify of
load end and start.

Notify when loads of sub-URLs start and stop, so panels for these
can be attached to the right windows.

* kwq/KWQKloader.mm:
(-[URLLoadClient IFURLHandleResourceDidBeginLoading:]):
(-[URLLoadClient IFURLHandleResourceDidCancelLoading:]):
(-[URLLoadClient IFURLHandleResourceDidFinishLoading:data:]):
(-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]):
(-[URLLoadClient IFURLHandle:didRedirectToURL:]):
* kwq/external.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed download data source leaks when downloads are cancelled.
cblu [Thu, 23 May 2002 05:18:15 +0000 (05:18 +0000)]
    Fixed download data source leaks when downloads are cancelled.

        * WebView.subproj/IFBaseWebControllerPrivate.mm:
        (-[IFBaseWebController _mainReceivedProgress:forResource:fromDataSource:]):
        * WebView.subproj/IFMainURLHandleClient.mm:
        (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]):
        (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoWebKit:
cblu [Thu, 23 May 2002 01:35:02 +0000 (01:35 +0000)]
        Removed activate events as this was causing problems
        for the QT plug-in.

        * Plugins.subproj/IFPluginView.mm:
        (-[IFPluginView windowBecameKey:]):
        (-[IFPluginView windowResignedKey:]):


        Added licensing code.

        * WebBrowser.pbproj/project.pbxproj:
        * ___CFA2UC.c: Added.
        * main.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago=== JavaScriptCore-5 ===
mjs [Thu, 23 May 2002 01:33:52 +0000 (01:33 +0000)]
=== JavaScriptCore-5 ===

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago2002-05-22 Kenneth Kocienda <kocienda@apple.com>
kocienda [Wed, 22 May 2002 23:10:39 +0000 (23:10 +0000)]
2002-05-22  Kenneth Kocienda  <kocienda@apple.com>

        Reviewed by: Richard Williamson

        Removed an assertion that was causing problems with cache object removals.

        * Database.subproj/IFURLFileDatabase.m:
        (-[IFURLFileDatabaseOp initWithCode:key:object:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Additional additional callback when resource is first loaded.
rjw [Wed, 22 May 2002 22:45:58 +0000 (22:45 +0000)]
Additional additional callback when resource is first loaded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoAdded retroactive review comments.
mjs [Wed, 22 May 2002 22:43:01 +0000 (22:43 +0000)]
Added retroactive review comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed crasher caused by not retaining.
cblu [Wed, 22 May 2002 20:31:44 +0000 (20:31 +0000)]
    Fixed crasher caused by not retaining.
        Fixed targeting bug.

        * Plugins.subproj/IFPluginView.mm:
        (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]):
        (-[IFPluginView getURLNotify:target:notifyData:]):
        (-[IFPluginView getURL:target:]):
        (-[IFPluginView postURLNotify:target:len:buf:file:notifyData:]):
        (-[IFPluginView postURL:target:len:buf:file:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Changed semantics of isLoading to only return YES if
rjw [Wed, 22 May 2002 18:34:12 +0000 (18:34 +0000)]
Changed semantics of isLoading to only return YES if
    the datasource is loading resources related to the intial
    load.  Other resources loaded later by JS will not be
    accounted for by isLoading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoWebBrowser:
cblu [Wed, 22 May 2002 07:39:27 +0000 (07:39 +0000)]

- Added an array to the defaults for MIME types for downloaded files
  that we open after download.
- Made sure we check for IFContentPolicySave when checking if
  a data source is a download data source.
- Set policy to IFContentPolicySave for types not in the defaults.

* Defaults.plist:
* DownloadMonitor.m:
(-[DownloadMonitor monitorDownload:withProgress:error:dataSource:]):
* LocationChangeHandler.m:
(-[LocationChangeHandler requestContentPolicyForMIMEType:]):
* WebController.m:
(-[WebController receivedProgress:forResource:fromDataSource:]):
(-[WebController receivedError:forResource:partialProgress:fromDataSource:]):


- Removed obsolete MIME/download related code.
- Minor clean-ups.
- Made WebKit support all text/* MIME types.
- Now send NPP_URLNotify when pages requested by plug-ins are loaded.
- Simplified NPP_Get/NPP_Post code.

* MIME.subproj/IFContentHandler.h:
* MIME.subproj/IFContentHandler.m:
* MIME.subproj/IFDownloadHandler.mm:
* MIME.subproj/IFMIMEDatabase.h: Removed.
* MIME.subproj/IFMIMEDatabase.m: Removed.
* MIME.subproj/IFMIMEHandler.h:
* MIME.subproj/IFMIMEHandler.m:
(+[IFMIMEHandler MIMEHandlerTypeForMIMEType:]):
(+[IFMIMEHandler canShowMIMEType:]):
* Plugins.subproj/IFPluginView.h:
* Plugins.subproj/IFPluginView.mm:
(-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]):
(-[IFPluginView dealloc]):
(-[IFPluginView frameStateChanged:]):
(-[IFPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]):
(-[IFPluginView getURLNotify:target:notifyData:]):
(-[IFPluginView getURL:target:]):
(-[IFPluginView postURLNotify:target:len:buf:file:notifyData:]):
(-[IFPluginView postURL:target:len:buf:file:]):
(-[IFPluginView invalidateRect:]):
(-[IFPluginView invalidateRegion:]):
(-[IFPluginView forceRedraw]):
* WebKit.pbproj/project.pbxproj:
* WebView.subproj/IFMainURLHandleClient.h:
* WebView.subproj/IFMainURLHandleClient.mm:
(-[IFMainURLHandleClient dealloc]):
(-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
(-[IFMainURLHandleClient processData:isComplete:]):
* WebView.subproj/IFWebFramePrivate.h:
* WebView.subproj/IFWebFramePrivate.mm:
(-[IFWebFrame _setState:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed Radar 2928775 - Sherlock crashes sitting in stocks channel
mjs [Wed, 22 May 2002 07:09:04 +0000 (07:09 +0000)]
Fixed Radar 2928775 - Sherlock crashes sitting in stocks channel

* kjs/internal.cpp:
(InterpreterImp::InterpreterImp): Set the interp pointer earlier,
in case garbage collection takes place while creating the global

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed baseline regression. Obvious of sites that have tables w/ backgrounds,
rjw [Wed, 22 May 2002 01:51:55 +0000 (01:51 +0000)]
Fixed baseline regression.  Obvious of sites that have tables w/ backgrounds,
    i.e. www.slashdot.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Lots of changes for DHTML.
rjw [Wed, 22 May 2002 00:36:34 +0000 (00:36 +0000)]
Lots of changes for DHTML.
    Bugs fixes, and fixes to regressions.

    Changes to support additional DHTML events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago2002-05-21 Kenneth Kocienda <kocienda@apple.com>
kocienda [Tue, 21 May 2002 21:54:09 +0000 (21:54 +0000)]
2002-05-21  Kenneth Kocienda  <kocienda@apple.com>

        Fix for this bug:

        Radar 2924728 (post form fails at pt.apple.com; succeeds at macosx.apple.com)

        Posted forms are now submitted with the IFURLHandleFlagLoadFromOrigin
        load flag set.  This prevents a potential bug which may cause a page
        with a form that uses itself as an action to be returned from the
        cache without submitting.

        * kwq/KWQKHTMLPart.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoWebFoundation:
cblu [Tue, 21 May 2002 20:48:47 +0000 (20:48 +0000)]

        Fix for 2925907 - [IFURLHandle resourceData] returns nil until load is complete

        * CacheLoader.subproj/IFURLHandle.m:
        (-[IFURLHandle resourceData]):


        Content policy can now be sent at a later time to avoid blocking.

        * WebView.subproj/IFMainURLHandleClient.h:
        * WebView.subproj/IFMainURLHandleClient.mm:
        (-[IFMainURLHandleClient initWithDataSource:part:]):
        (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Move the tracking rect after the view has moved.
cblu [Tue, 21 May 2002 17:25:23 +0000 (17:25 +0000)]
    Move the tracking rect after the view has moved.

        * Plugins.subproj/IFPluginView.mm:
        (-[IFPluginView viewHasMoved:]):

        Fixed logging.

        * Plugins.subproj/npapi.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago2002-05-21 Kenneth Kocienda <kocienda@apple.com>
kocienda [Tue, 21 May 2002 14:50:11 +0000 (14:50 +0000)]
2002-05-21  Kenneth Kocienda  <kocienda@apple.com>

        Merged these four include files into the precompiled header.
        These are used for the enhanced assertion/debuggin support I
        added yesterday.


        * WebCore/WebCorePrefix.h
        * WebFoundation/WebFoundationPrefix.h
        * WebKit/WebFoundationPrefix.h

        * WebFoundation/WebFoundation.pbproj/project.pbxproj: PB decided that this file
        changed in some cryptic way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Added support for plug-ins to send URL requests to certain targets.
cblu [Tue, 21 May 2002 01:19:44 +0000 (01:19 +0000)]
    Added support for plug-ins to send URL requests to certain targets.

        Added frameNamed to IFWebFrame.

        * Plugins.subproj/IFPluginView.mm:
        (-[IFPluginView getURLNotify:target:notifyData:]):
        (-[IFPluginView postURLNotify:target:len:buf:file:notifyData:]):
        * WebView.subproj/IFWebFrame.h:
        * WebView.subproj/IFWebFrame.mm:
        (-[IFWebFrame frameNamed:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Forgot one file.
darin [Tue, 21 May 2002 00:51:19 +0000 (00:51 +0000)]
Forgot one file.

* khtml/khtml_part.moc: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Use more of the original khtml_part.cpp; a step in the direction of factoring
darin [Tue, 21 May 2002 00:30:41 +0000 (00:30 +0000)]
Use more of the original khtml_part.cpp; a step in the direction of factoring
our code out so more of it can go in WebKit and we don't need external.h.

* khtml/Makefile.am:
* khtml/khtml_part.cpp:
* khtml/khtml_part.h:
* khtml/khtmlpart_p.h:
Start compiling khtml_part.cpp and using khtmlpart_p.h again.

* kwq/KWQKHTMLPart.mm:
Remove code that was identical to khtml_part.cpp. We aren't going to use the
"copy and hack our copy" approach on this class for the long termk, and this
is the first step in cleaning things up.

* khtml/khtml_ext.h: Removed.
* khtml/khtml_factory.h: Removed.

* khtml/misc/loader.h:
* khtml/xml/dom_docimpl.cpp:
Remove some APPLE_CHANGES ifdefs we don't need any more.

* kwq/KWQDateTime.mm:
Simplify things like copy constructors.

* kwq/kdeui/kcursor.h:
* kwq/KWQKCursor.mm:
Add handCursor.

* kwq/KWQKHTMLFactory.mm:
Put in real implementations, not just placeholders.

* kwq/KWQKHTMLPartBrowserExtension.mm:
* kwq/KWQKInstance.mm:
* kwq/KWQPart.mm:
* kwq/KWQbrowserextension.mm:
Empty these files out, nothing in them is needed any more.

* kwq/khtml/khtml_settings.h:
* kwq/KWQKHTMLSettings.mm:
Moved settings here from KWQKHTMLPart.mm

* kwq/kdecore/kurl.h:
* kwq/KWQKURL.mm:
Placeholders for these two, called in KHTMLPart, but maybe not really needed.

* kwq/KWQKloader.mm:
Empty functions for these, called in KHTMLPart but no implementation needed.

* kwq/qt/qtimer.h:
* kwq/KWQTimer.mm:
More timer functions.

* kwq/qt/qscrollview.h: Add one more function.

* kwq/kdecore/kinstance.h: Simplify.
* kwq/kdeui/kaction.h: Simplify.
* kwq/khtml/khtml_factory.h: Simplify.
* kwq/kparts/browserextension.h: Simplify.
* kwq/kparts/part.h: Simplify.
* kwq/qt/qdatetime.h: Simplify.

* kwq/kdecore/klibloader.h: Added.
* kwq/khtml/khtml_ext.h: Added.
* kwq/kparts/partmanager.h: Added.
Nearly-empty files with just simple placeholders so we can compile more.

* kwq/dcop/kdatastream.h: Added.
* kwq/kdecore/kmultipledrag.h: Added.
* kwq/kdecore/ktempfile.h: Added.
* kwq/kdecore/kurldrag.h: Added.
* kwq/kdeui/kstdaction.h: Added.
* kwq/kdeui/kxmlguifactory.h: Added.
* kwq/khtml/khtml_find.h: Added.
* kwq/khtml/khtml_iface.h: Added.
* kwq/khtml/khtml_pagecache.h: Added.
* kwq/khtml/khtml_run.h: Added.
* kwq/kio/kssl/ksslcertchain.h: Added.
* kwq/kio/kssl/ksslinfodlg.h: Added.
* kwq/kio/ktrader.h: Added.
* kwq/qt/private/qucomextra_p.h: Added.
* kwq/qt/qclipboard.h: Added.
* kwq/qt/qmetaobject.h: Added.
Empty files just so includes of these names will compile.

* libwebcoretests.exp: Remove one export that's no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Added support for onChange and window.location, i.e.:
rjw [Mon, 20 May 2002 23:43:02 +0000 (23:43 +0000)]
Added support for onChange and window.location, i.e.:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago2002-05-20 Kenneth Kocienda <kocienda@apple.com>
kocienda [Mon, 20 May 2002 23:27:17 +0000 (23:27 +0000)]
2002-05-20  Kenneth Kocienda  <kocienda@apple.com>

Now includes <sys/time.h> to prevent possible build breakage
in the inclusion of <sys/resource.h>

* WebCore/kwq/kwqdebug.h
* WebKit/Misc.subproj/WebKitDebug.h
* WebFoundation/Misc.subproj/WebFoundationDebug.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago2002-05-20 Kenneth Kocienda <kocienda@apple.com>
kocienda [Mon, 20 May 2002 22:42:31 +0000 (22:42 +0000)]
2002-05-20  Kenneth Kocienda  <kocienda@apple.com>

        Changed assertion failure code to send a SIGQUIT instead
        of raising an NSException.

        * kwq/kwqdebug.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago2002-05-20 Kenneth Kocienda <kocienda@apple.com>
kocienda [Mon, 20 May 2002 22:24:31 +0000 (22:24 +0000)]
2002-05-20  Kenneth Kocienda  <kocienda@apple.com>

        Changed assertion failure code to send a SIGQUIT instead
        of raising an NSException.

        * Misc.subproj/WebKitDebug.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago2002-05-20 Kenneth Kocienda <kocienda@apple.com>
kocienda [Mon, 20 May 2002 21:54:33 +0000 (21:54 +0000)]
2002-05-20  Kenneth Kocienda  <kocienda@apple.com>
        Reviewed by: John Sullivan

        Fix for this bug:

        Radar 2931078 (IFURLFileDatabase initialization is not threadsafe)

        In addition, I have added several assertion checks to the code. Note
        that each of these assertion checks is of the "failure should be impossible"

        * Database.subproj/IFURLFileDatabase.m:
        (-[IFURLFileReader initWithPath:]):
        (-[IFURLFileDatabaseOp initWithCode:key:object:]):
        (-[IFURLFileDatabaseOp perform:]):
        (-[IFURLFileDatabase initWithPath:]):
        (-[IFURLFileDatabase setObject:forKey:]):
        (-[IFURLFileDatabase removeObjectForKey:]):
        (-[IFURLFileDatabase objectForKey:]):
        (-[IFURLFileDatabase performSetObject:forKey:]):
        (-[IFURLFileDatabase performRemoveObjectForKey:]):
        (-[IFURLFileDatabase lazySync:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoWebFoundation:
cblu [Mon, 20 May 2002 20:56:24 +0000 (20:56 +0000)]

Added _IF_looksLikeAbsoluteURL.

* Misc.subproj/IFNSStringExtensions.h:
* Misc.subproj/IFNSStringExtensions.m:
(-[NSString _IF_looksLikeAbsoluteURL]):


- Drag & Drop support.
- A whole lot of plug-in clean-up and minor bug fixes.

Moved the following functions from npapi to IFPlugin.

* Plugins.subproj/IFPlugin.m:

Only supply mouse coords when active.

* Plugins.subproj/IFPluginNullEventSender.h:
* Plugins.subproj/IFPluginNullEventSender.m:
(-[IFPluginNullEventSender initializeWithNPP:functionPointer:window:]):
(-[IFPluginNullEventSender dealloc]):
(-[IFPluginNullEventSender sendNullEvents]):

Minor clean-ups

* Plugins.subproj/IFPluginStream.mm:
(-[IFPluginStream dealloc]):
(-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]):
(-[IFPluginStream IFURLHandleResourceDidCancelLoading:]):
(-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]):

Removed the isMouseDown flag from the following functions
as it was unnecessary.

Cleaned up logging.

* Plugins.subproj/IFPluginView.mm:
(-[IFPluginView modifiersForEvent:]):
(-[IFPluginView getCarbonEvent:withEvent:]):
(-[IFPluginView sendUpdateEvent]):
(-[IFPluginView becomeFirstResponder]):
(-[IFPluginView resignFirstResponder]):
(-[IFPluginView mouseDown:]):
(-[IFPluginView mouseUp:]):
(-[IFPluginView mouseExited:]):
(-[IFPluginView setWindow]):
(-[IFPluginView start]):
(-[IFPluginView stop]):

URLForString now uses _IF_looksLikeAbsoluteURL.

(-[IFPluginView URLForString:]):

Implemented the following:

(-[IFPluginView invalidateRect:]):
(-[IFPluginView invalidateRegion:]):
(-[IFPluginView forceRedraw]):

Put implementation of GetValue SetValue in npapi.

* Plugins.subproj/npapi.h:
* Plugins.subproj/npapi.m:

Added drag & drop support.

* WebView.subproj/IFWebView.mm:
(-[IFWebView initWithFrame:]):
(-[IFWebView setCanDragFrom:]):
(-[IFWebView canDragFrom]):
(-[IFWebView setCanDragTo:]):
(-[IFWebView canDragTo]):
(-[IFWebView draggingEntered:]):
(-[IFWebView prepareForDragOperation:]):
(-[IFWebView performDragOperation:]):
* WebView.subproj/IFWebViewPrivate.h:
* WebView.subproj/IFWebViewPrivate.mm:
(-[IFWebViewPrivate dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago - fixed 2923492 -- No way to put separators in Bookmarks menu
sullivan [Mon, 20 May 2002 19:15:11 +0000 (19:15 +0000)]
- fixed 2923492 -- No way to put separators in Bookmarks menu
- fixed 2927561 -- Added child of bookmarks folder should be first, not last
- fixed 2927575 -- New bookmark should have blank URL
- fixed 2927589 -- "Modify" and "Remove" should be "Edit" and "Delete"
- fixed 2923220 -- Bookmarks window should reopen at launch if it was open at quit
- fixed bug where bookmark window would sometimes start with a horiz scrollbar
- fixed bug where deleting nested bookmark would leave last row selected

* PreferenceKeys.h: define ShowBookmarksPreferenceKey

* AppController.m:
(-[AppController applicationDidFinishLaunching:]):
Open bookmarks window if preference says to.
(-[AppController _insertBookmark:intoMenu:atIndex:]):
Handle separators.

* BookmarksController.m:
(-[BookmarksController windowDidLoad]): Set self as delegate so we will receive
windowWillClose:; setAutoresizesOutlineColumn:NO so column widths won't change
at launch.
(-[BookmarksController removeSelectedBookmarks:]):
Reselect previously selected item if it's still valid
(-[BookmarksController _newItemWithTitle:image:URLString:type:]):
Change isLeaf parameter to bookmark type. Handle separators (don't edit title
of newly-created separator). If expanded folder is selected, make new item first.
(-[BookmarksController _newSeparator:]): Implemented.
(-[BookmarksController outlineView:objectValueForTableColumn:byItem:]):
Return "--" as string to represent separator, for now.
(-[BookmarksController _newFolder:]),
(-[BookmarksController _newBookmark:]):
(-[BookmarksController outlineView:isItemExpandable:]):
(-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]):
(-[BookmarksController outlineView:shouldEditTableColumn:item:]):
Replaced uses of isLeaf with bookmarkType.
(-[BookmarksController toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]):
Handle separator item.
(-[BookmarksController toolbarAllowedItemIdentifiers:]): Include "New Separator" item.
(-[BookmarksController showWindow:]): Set "bookmarks showing" preference to YES.
(-[BookmarksController windowWillClose:]): Set "bookmarks showing" preference to NO.

* BrowserDocument.m:
(-[BrowserDocument addBookmark:]):
Replaced use of isLeaf with bookmarkType.

* GlobalHistory.m:
(-[GlobalHistory addSelectedItemsToBookmarks:]):
Replaced use of isLeaf with bookmarkType.

* Resources/Images/new_separator.tiff: Added.

* WebBrowser.pbproj/project.pbxproj: Updated for new file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * khtml/rendering/render_object.cpp: (RenderObject::drawBorder):
darin [Sun, 19 May 2002 16:02:40 +0000 (16:02 +0000)]
* khtml/rendering/render_object.cpp: (RenderObject::drawBorder):
Add missing break statement so borders don't draw strangely.

* khtml/rendering/render_style.h: Remove unneeded QColor workaround,
now that we handle invalid colors properly.

* kwq/KWQColor.mm:
(createStaticConstructorAutoreleasePool): New solution to the problem
of autorelease at static constructor time.
(getNamedColors): Function that creates this dictionary when needed
rather than creating it inside an init function.
(QColor::QColor): Share code with setRgb, get rid of _initialize.
(hex2int): Return -1 for bad digit rather than 0.
(decodeColorFromHexColorString): Make more robust and simpler.
(QColor::setNamedColor): Set color to invalid rather than black when
the passed in name is empty or unrecognized.
(QColor::red), (QColor::green), (QColor::blue): Round instead of truncating.
(QColor::setRgb): Set color to invalid if r, g, or b is out of range.
(QColor::operator=): Simplify.
(QColor::operator==): Handle invalid colors correctly.
(QColor::getNSColor): Return black of invalid colors.

* kwq/KWQCursor.mm: Simplify cursor globals.

* kwq/KWQPainter.mm:
(QPainter::_setColorFromBrush): Use getNSColor() to handle invalid colors correctly.
(QPainter::_setColorFromPen): Use getNSColor() to handle invalid colors correctly.
(QPainter::drawLine): Add code to respect style and width and handle endpoints in a
way that will make the lines look like Qt users expect.
(QPainter::drawText): Use getNSColor() to handle invalid colors correctly.
(QPainter::drawUnderlineForText): Use getNSColor() to handle invalid colors correctly.
(QPainter::fillRect): Use getNSColor() to handle invalid colors correctly.

* kwq/KWQPen.mm: (QPen::QPen): (QPen::setStyle): Remove use of MPenStyle.

* kwq/KWQPixmap.mm: (QPixmap::QPixmap): Add comments.

* kwq/qt/qcolor.h: Simplify ifdefs, remove cname, _initialize, globals_init, and

* kwq/qt/qnamespace.h: Remove AlignTop, AlignBottom, SingleLine, ExpandTabs, DontPrint,
DashDotLine, DashDotDotLine, MPenStyle, WResizeNoRease, WRepaintNoErase, color0, color1,
darkRed, darkGreen, darkBlue, darkCyan, darkMagenta, darkYellow. Simplify the QColor
and QCursor globals.

* kwq/qt/qpen.h: QPainter is no longer a friend class. Remove linest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
darin [Sat, 18 May 2002 01:35:23 +0000 (01:35 +0000)]
* khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
OK. This time it's correct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
darin [Sat, 18 May 2002 01:22:54 +0000 (01:22 +0000)]
* khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
Roll the change out while I see why it causes a crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoReplacing IFPluginStream.m with IFPluginStream.mm.
cblu [Sat, 18 May 2002 00:59:25 +0000 (00:59 +0000)]
Replacing IFPluginStream.m with IFPluginStream.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoAdding this file.
cblu [Sat, 18 May 2002 00:55:09 +0000 (00:55 +0000)]
Adding this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoWebKit:
cblu [Sat, 18 May 2002 00:54:27 +0000 (00:54 +0000)]
  - Made IFPluginStream the URL handle client instead of IFPluginView.
        - Added support for NPP_PostURL and NPP_PostNotify.
        - Possible fix for 2928558.

        * Plugins.subproj/IFPluginStream.h:
        * Plugins.subproj/IFPluginView.h:
        * Plugins.subproj/IFPluginView.mm:
        (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]):NSURL for url
        instead of NSString
        (-[IFPluginView dealloc]):
        (-[IFPluginView setWindow]):
        (-[IFPluginView start]):
        (-[IFPluginView stop]):
        (-[IFPluginView webDataSource]):Accessor for IFPluginStream.
        (-[IFPluginView webController]):Accessor for IFPluginStream.
        (-[IFPluginView URLForString:]):
        (-[IFPluginView getURLNotify:target:notifyData:]):
        (-[IFPluginView postURLNotify:target:len:buf:file:notifyData:]):
        (-[IFPluginView postURL:target:len:buf:file:]):
        (-[IFPluginView destroyStream:reason:]):
        (-[IFPluginView status:]):
        (-[IFPluginView NPP_NewStream]): Accessor for IFPluginStream.
        (-[IFPluginView NPP_WriteReady]):Accessor for IFPluginStream.
        (-[IFPluginView NPP_Write]): Accessor for IFPluginStream.
        (-[IFPluginView NPP_StreamAsFile]): Accessor for IFPluginStream.
        (-[IFPluginView NPP_DestroyStream]): Accessor for IFPluginStream.
        (-[IFPluginView NPP_URLNotify]): Accessor for IFPluginStream.
        * WebCoreSupport.subproj/IFWebCoreViewFactory.m: Use new IFPluginView init method
        (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]):
        * WebKit.pbproj/project.pbxproj:


        Use rm -rf to remove Labyrinth.

        * Tools/jersey/bin/jersey.pl:
        * Tools/jersey/html/cgi-bin/j.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
darin [Fri, 17 May 2002 17:57:14 +0000 (17:57 +0000)]
* khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
Remove an old incorrect fix for a style leak in here and put in
a new correct fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed 2896350. Ignore DPI in images and render directly at pixel size.
rjw [Thu, 16 May 2002 22:43:11 +0000 (22:43 +0000)]
Fixed 2896350.  Ignore DPI in images and render directly at pixel size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed 2925638. Don't send last progress message from resourceDataDidBecomeAvailable,
rjw [Thu, 16 May 2002 19:47:47 +0000 (19:47 +0000)]
Fixed 2925638.  Don't send last progress message from resourceDataDidBecomeAvailable,
it is sent from IFURLHandleResourceDidFinishLoading, avoiding duplication.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago0. I was being overly aggressive about
rjw [Thu, 16 May 2002 18:10:45 +0000 (18:10 +0000)]
0.  I was being overly aggressive about
finding substitute glyphs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * Plugins.subproj/IFPluginView.mm:
darin [Thu, 16 May 2002 17:45:32 +0000 (17:45 +0000)]
* Plugins.subproj/IFPluginView.mm:
(-[IFPluginView IFURLHandleResourceDidFinishLoading:data:]):
Use this new getCarbonPath function rather than hardcoding assumptions
about "/tmp" being ":private:tmp".
(getCarbonPath): New.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * Plugins.subproj/IFPluginView.mm: (-[IFPluginView mouseUp:]):
darin [Thu, 16 May 2002 16:00:58 +0000 (16:00 +0000)]
* Plugins.subproj/IFPluginView.mm: (-[IFPluginView mouseUp:]):
Fixed log statement so development builds work again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * Plugins.subproj/IFPluginView.mm: (-[IFPluginView mouseUp:]):
darin [Thu, 16 May 2002 15:45:22 +0000 (15:45 +0000)]
* Plugins.subproj/IFPluginView.mm: (-[IFPluginView mouseUp:]):
Remove unused variable that breaks optimized builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Another quick events cleanup pass.
darin [Thu, 16 May 2002 06:23:54 +0000 (06:23 +0000)]
Another quick events cleanup pass.

* Plugins.subproj/IFPluginNullEventSender.m:
(-[IFPluginNullEventSender sendNullEvents]): Use [IFPluginView getCarbonEvent:].

* Plugins.subproj/IFPluginView.h: Make almost all methods private.
* Plugins.subproj/IFPluginView.mm:
(+[IFPluginView getCarbonEvent:]): New.
(-[IFPluginView getCarbonEvent:]): New, calls class method.
(-[IFPluginView modifiersForEvent:isMouseDown:]): Reversed sense of btnState.
This flag is set if the mouse is up, not if the mouse is down.
(-[IFPluginView getCarbonEvent:withEvent:isMouseDown:]): New.
(-[IFPluginView getCarbonEvent:withEvent:]): New.
(-[IFPluginView sendActivateEvent:]): Now takes parameter for activate vs.
deactivate and uses [getCarbonEvent:].
(-[IFPluginView sendUpdateEvent]): Uses [getCarbonEvent:].
(-[IFPluginView becomeFirstResponder]): Uses [getCarbonEvent:].
(-[IFPluginView resignFirstResponder]): Uses [getCarbonEvent:].
(-[IFPluginView mouseDown:]): Uses [getCarbonEvent:withEvent:isMouseDown:].
(-[IFPluginView mouseUp:]): Uses [getCarbonEvent:withEvent:isMouseDown:].
(-[IFPluginView mouseEntered:]): Uses [getCarbonEvent:withEvent:].
(-[IFPluginView mouseExited:]): Uses [getCarbonEvent:withEvent:].
(-[IFPluginView keyUp:]): Uses [getCarbonEvent:withEvent:].
(-[IFPluginView keyDown:]): Uses [getCarbonEvent:withEvent:].
(-[IFPluginView start]): Call [sendActivateEvent:YES].
(-[IFPluginView windowBecameKey:]): Call [sendActivateEvent:YES].
(-[IFPluginView windowResignedKey:]): Call [sendActivateEvent:NO].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed problem dealing w/ characters in range 0x7f - 0xa0.
rjw [Thu, 16 May 2002 00:22:30 +0000 (00:22 +0000)]
Fixed problem dealing w/ characters in range 0x7f - 0xa0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed Flash mouse-down, mouse-over Flash bug.
cblu [Wed, 15 May 2002 23:58:29 +0000 (23:58 +0000)]
    Fixed Flash mouse-down, mouse-over Flash bug.
        Added support for modifiers (control-click etc) (2884451).
        A lot of events clean-up.

        * Plugins.subproj/IFPluginNullEventSender.m:
        (-[IFPluginNullEventSender sendNullEvents]):
        * Plugins.subproj/IFPluginView.h:
        * Plugins.subproj/IFPluginView.mm:
        (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]):
        (-[IFPluginView start]):
        (-[IFPluginView drawRect:]):
        (-[IFPluginView isFlipped]):
        (-[IFPluginView currentModifiers]):
        (-[IFPluginView modifiersForEvent:isMouseDown:]):
        (-[IFPluginView sendActivateEvent]):
        (-[IFPluginView sendUpdateEvent]):
        (-[IFPluginView becomeFirstResponder]):
        (-[IFPluginView resignFirstResponder]):
        (-[IFPluginView mouseDown:]):
        (-[IFPluginView mouseUp:]):
        (-[IFPluginView mouseEntered:]):
        (-[IFPluginView mouseExited:]):
        (-[IFPluginView keyUp:]):
        (-[IFPluginView keyDown:]):
        (-[IFPluginView windowBecameKey:]):
        (-[IFPluginView windowResignedKey:]):

        Case-sensitivity issue with an include.

        * WebView.subproj/IFWebView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Alerts, useful for validating that js handlers work.
rjw [Wed, 15 May 2002 23:21:01 +0000 (23:21 +0000)]
Alerts, useful for validating that js handlers work.
    Validated that onsubmit is working.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoOops.
darin [Wed, 15 May 2002 21:00:12 +0000 (21:00 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * kwq/qt/qguardedptr.h: Fix reversed sense of check in isNull. Fixes
darin [Wed, 15 May 2002 20:59:22 +0000 (20:59 +0000)]
* kwq/qt/qguardedptr.h: Fix reversed sense of check in isNull. Fixes
a bug that was causing a lot of DHTML not to work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago2002-05-15 Kenneth Kocienda <kocienda@apple.com>
kocienda [Wed, 15 May 2002 19:45:33 +0000 (19:45 +0000)]
2002-05-15  Kenneth Kocienda  <kocienda@apple.com>

        * kwq/KWQInvisibleButton.h: Changed an #include of Cocoa.h to an #import

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * kwq/KWQListImpl.mm:
darin [Wed, 15 May 2002 19:03:10 +0000 (19:03 +0000)]
* kwq/KWQListImpl.mm:
(KWQListImpl::KWQListPrivate::copyList): Take out unnecessary line of code.
(KWQListImpl::KWQListPrivate::~KWQListPrivate): Delete the iterator nodes
also, not just the item nodes. Fixes a storage leak.
Change interface to take a list pointer so we don't rely on the undefined
behavior of &* on a null pointer.
(KWQListImpl::addIterator): Set up the prev pointer of the old head of
the list. This was causing the crash I was debugging.
(KWQListIteratorImpl::operator=): Simpler implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * Makefile.am:
darin [Wed, 15 May 2002 17:05:18 +0000 (17:05 +0000)]
* Makefile.am:
Use all-am and clean-am instead of all and clean because it's better and
to make "make check" at the top level work right.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Work to support copying bookmarks, needed for drag & drop
sullivan [Wed, 15 May 2002 03:35:00 +0000 (03:35 +0000)]
Work to support copying bookmarks, needed for drag & drop
in Bookmarks window.

* Bookmarks.subproj/IFBookmark.h: Make IFBookmark conform to NSCopying.

* Bookmarks.subproj/IFBookmark.m:
(-[IFBookmark copyWithZone:]): insist that subclasses implement this.

* Bookmarks.subproj/IFBookmarkGroup.h:
* Bookmarks.subproj/IFBookmarkGroup.m:
(-[IFBookmarkGroup insertBookmark:atIndex:ofBookmark:]):
Removed this unnecessary method.

* Bookmarks.subproj/IFBookmarkLeaf.m:
(-[IFBookmarkLeaf copyWithZone:]): New method.

* Bookmarks.subproj/IFBookmarkList.m:
(-[IFBookmarkList copyWithZone:]): New method.

Fixed 2921730 -- Can't rearrange bookmarks in Bookmarks window

You can now drag and drop willy-nilly in the Bookmarks window to
rearrange items. It's currently using a private pasteboard type,
so you can't drop items from elsewhere or drag the bookmarks out
of the list. I know of one bug (dropping an item inside itself
makes it poof into nothingness) which I'll write up in a moment.

* BookmarksController.m:
(-[BookmarksController windowDidLoad]): register for our dragged type.
(-[BookmarksController _anyAncestorOfRow:inArray:]): New helper method,
used to avoid copying a folder deep and some of its children at the
same time.
(-[BookmarksController outlineView:writeItems:toPasteboard:]):
Write list of rows to pasteboard, after eliminating items whose ancestors are
also in set.
(-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]):
Move a drop on a leaf bookmark to be after the leaf bookmark.
(-[BookmarksController outlineView:acceptDrop:item:childIndex:]):
Do the move, by inserting copies of the moved items and then removing
the originals.

* OutlineViewPlus.m:
(-[OutlineViewPlus setAcceptsFirstMouse:]):
(-[OutlineViewPlus acceptsFirstMouse:]):
Removed debugging messages I accidentally left in here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed exception in log code.
rjw [Wed, 15 May 2002 02:32:54 +0000 (02:32 +0000)]
Fixed exception in log code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed 2926153, not getting correct messages after cancel.
rjw [Wed, 15 May 2002 01:59:33 +0000 (01:59 +0000)]
Fixed 2926153, not getting correct messages after cancel.
    Fixed leak of mouse events (Darin wanted this ASAP).

    Added another symbol for stack based event constructor.
    Change to support onLoad.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoWebCore:
cblu [Wed, 15 May 2002 00:19:12 +0000 (00:19 +0000)]

        Changed slotData to slotData(NSString *encoding, const char *bytes, int length)

        * khtml/khtml_part.h:
        * kwq/KWQKHTMLPart.mm:
        * libwebcore.exp:


        Removed retain of the URL handle. This was causing everything to leak.

        * WebView.subproj/IFMainURLHandleClient.h:
        * WebView.subproj/IFMainURLHandleClient.mm:
        (-[IFMainURLHandleClient initWithDataSource:part:]):
        (-[IFMainURLHandleClient dealloc]):
        (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
        (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):
        (-[IFMainURLHandleClient processData:isComplete:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]):
darin [Wed, 15 May 2002 00:08:52 +0000 (00:08 +0000)]
* WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]):
Remove code that makes us the first responder. That's up to the higher levels,
not the web view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed 2925291 -- CSS2 test page causes infinite recursion, crash
darin [Tue, 14 May 2002 20:53:18 +0000 (20:53 +0000)]
Fixed 2925291 -- CSS2 test page causes infinite recursion, crash

* khtml/rendering/render_container.cpp: (RenderContainer::addChild):
Add code to detect the case of a render object that uses text cell
style but is not itself a text style, and make sure we don't try to
nest such an object inside an infinite number of tables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * History.subproj/IFURIEntry.h:
sullivan [Tue, 14 May 2002 19:16:01 +0000 (19:16 +0000)]
* History.subproj/IFURIEntry.h:
Oops, deleted the prototype for setLastVisitedDate
accidentally, which made Jersey sad.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed 2919027 -- Need to remove unused code in WebKit/History.subproj
sullivan [Tue, 14 May 2002 18:07:23 +0000 (18:07 +0000)]
Fixed 2919027 -- Need to remove unused code in WebKit/History.subproj

* History.subproj/IFAttributedURL.h: Removed.
* History.subproj/IFBackForwardList.h: Removed large #ifdef.
* History.subproj/IFURIEntry.h,
* History.subproj/IFURIEntry.m: Removed all mention of unused
fields comment, creationDate, modificationDate
* WebKit.pbproj/project.pbxproj: Updated for removed file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * kwq/KWQListImpl.mm: (KWQListIteratorImpl::KWQListIteratorImpl):
darin [Tue, 14 May 2002 13:52:18 +0000 (13:52 +0000)]
* kwq/KWQListImpl.mm: (KWQListIteratorImpl::KWQListIteratorImpl):
Add a missing check for a null pointer.

* kwq/KWQGuardedPtr.mm: (KWQGuardedPtrBase::KWQGuardedPtrBase):
Remove an unnecessary call to "toFirst", because new iterators
already default to pointing to the first element of the list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * kwq/KWQListImpl.mm: (KWQListImpl::~KWQListImpl): Detach all the iterators from
darin [Tue, 14 May 2002 06:16:03 +0000 (06:16 +0000)]
* kwq/KWQListImpl.mm: (KWQListImpl::~KWQListImpl): Detach all the iterators from
the list when the list is destroyed. I thought this was done before, but it seems not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Added support for setting the content policy on the location change handler
cblu [Tue, 14 May 2002 05:43:14 +0000 (05:43 +0000)]
    Added support for setting the content policy on the location change handler
        and data source at any time instead of depending on an immediate response.

        * WebView.subproj/IFBaseWebController.mm:
        (-[IFBaseWebController haveContentPolicy:andPath:forLocationChangeHandler:]):
        * WebView.subproj/IFMainURLHandleClient.h:
        * WebView.subproj/IFMainURLHandleClient.mm:
        (-[IFMainURLHandleClient initWithDataSource:part:]):
        (-[IFMainURLHandleClient dealloc]):
        (-[IFMainURLHandleClient setContentPolicy:]):
        (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]):
        (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
        (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):
        (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):
        (-[IFMainURLHandleClient processData:isComplete:]):
        * WebView.subproj/IFWebController.h:
        * WebView.subproj/IFWebDataSourcePrivate.mm:
        (-[IFWebDataSource _setContentPolicy:]):
        * WebView.subproj/IFWebFrame.mm:
        (-[IFWebFrame setProvisionalDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed bug 2922884 (JavaScript object leak creating Image object from JavaScript).
darin [Tue, 14 May 2002 02:57:28 +0000 (02:57 +0000)]
Fixed bug 2922884 (JavaScript object leak creating Image object from JavaScript).
There was a reference loop created when a document contained a variable that
referenced an image, because images held references to the document; the C++
kind that do not participate in the JavaScript garbage collection.

* khtml/ecma/kjs_html.h: Use a QGuardedPtr to the DocumentImpl instead of using
a Document object.
* khtml/ecma/kjs_html.cpp:
(Image::tryPut): Change because the "doc" pointer is now a pointer to the
DocumentImpl, not the Document. Also check for 0, since it's now a QGuardedPtr
that can become 0.
(Image::Image): Newly out of line. Changed because the "doc" pointer is now a
pointer to the DocumentImpl, not the Document.

Since the solution used QGuardedPtr, I had to implement it.

* kwq/qt/qguardedptr.h: Put the implementation in a new KWQGuardedPtrBase class,
with only the bare minimum in a template. This new implementation uses iterators
on a QPtrList, which means there's not much code needed.
* kwq/KWQGuardedPtr.mm: (KWQGuardedPtrBase::KWQGuardedPtrBase): Rewrite to use
a QPtrListIterator to a dummy list in the QObject. This reuses code nicely, but
a custom-coded solution would be a bit more efficient.

* kwq/qt/qobject.h:
* kwq/KWQObject.mm: (QObject::QObject): Create the one-element list that's used
by the QGuardedPtr instances.

Since the above code needed to copy a QPtrListIterator, I needed to support that.

* kwq/qt/qlist.h: Move the iterator's copy constructor out of the private part,
and implement it. This class was strange in that it has a public assignment
operator, but a private unimplemented copy constructor. Implementing it was trivial,
though, so this was no obstacle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * kjs/value.h: Fix comment typos.
darin [Tue, 14 May 2002 02:56:45 +0000 (02:56 +0000)]
* kjs/value.h: Fix comment typos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * Makefile.am: Make WebCore precompiled headers depend on config.h
mjs [Tue, 14 May 2002 02:30:55 +0000 (02:30 +0000)]
* Makefile.am: Make WebCore precompiled headers depend on config.h
to fix build breakage from last change.

* WebKitPrefix.h: Gratuitous change to make the prefix file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Removed libjpeg dependency. Turns out we don't need it.
mjs [Tue, 14 May 2002 00:27:50 +0000 (00:27 +0000)]
Removed libjpeg dependency. Turns out we don't need it.

* configure.in: Don't check for libjpeg.
* Updates/update: Don't bother with the libjpeg update.
* Updates/install-libjpeg.sh: Removed.

Removed libjpeg dependency. Turns out we don't need it.

* Makefile.am: Remove -ljpeg from link line.
* khtml/misc/loader_jpeg.cpp: Removed.
* khtml/misc/loader_jpeg.h: Removed.
* khtml/misc/Makefile.am: Remve loader_jpeg from build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago * WebView.subproj/IFBaseWebController.mm:
cblu [Mon, 13 May 2002 18:22:00 +0000 (18:22 +0000)]
    * WebView.subproj/IFBaseWebController.mm:
        (-[IFBaseWebController URLPolicyForURL:]):

        Use [IFURLHandle canInitWithURL] instead of hard-coded URL schemes.

        * WebView.subproj/IFBaseWebControllerPrivate.mm:
        (-[IFBaseWebController _mainReceivedProgress:forResource:fromDataSource:]):
        * WebView.subproj/IFMainURLHandleClient.mm:
        (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]):
        (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
        * WebView.subproj/IFWebDataSourcePrivate.h:
        * WebView.subproj/IFWebDataSourcePrivate.mm:
        (-[IFWebDataSourcePrivate init]):
        (-[IFWebDataSource _setDownloadPath:]):

        Removed _contentPolicy as contentPolicy is public.

        Initialize contentPolicy in [IFWebDataSourcePrivate init].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Made log output match webkit logging.
rjw [Fri, 10 May 2002 23:08:23 +0000 (23:08 +0000)]
Made log output match webkit logging.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Logging changes.
rjw [Fri, 10 May 2002 23:07:55 +0000 (23:07 +0000)]
Logging changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years agoWebKit:
cblu [Fri, 10 May 2002 22:28:21 +0000 (22:28 +0000)]

Added support for non-html non-file URL data sources.
        Added the init methods below. Removed initWithHandle.

        * WebView.subproj/IFWebDataSource.h:
        * WebView.subproj/IFWebDataSource.mm:
        (-[IFWebDataSource initWithURL:]):
        (-[IFWebDataSource initWithURL:attributes:]):
        (-[IFWebDataSource startLoading:]):


        Changed WCIFWebDataSourceMake to wrap around [IFWebDataSource initWithUR
L: attributes: flags:]
        instead of initWithHandle.

        * kwq/KWQKHTMLPart.mm:
        * kwq/WCWebDataSource.h:
        * libwebcore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20 years ago Fixed 2923728 (ellipsizing text method is taking a lot of CPU time) by writing a
darin [Fri, 10 May 2002 22:16:38 +0000 (22:16 +0000)]
Fixed 2923728 (ellipsizing text method is taking a lot of CPU time) by writing a
new string truncator that uses fast text measurement.

* AppController.m: (-[AppController awakeFromNib]): Remove _setUpStringTruncator.

* BrowserDocument.h: Remove _cachedPageName; it was not doing any good.
* BrowserDocument.m:
(-[BrowserDocument dealloc]): No need to release _cachedPageName.
(-[BrowserDocument pageName]): No need to use _cachedPageName.
(-[BrowserDocument _updateWindowTitles]): Name change.

* StringTruncator.h: Rewrite. Only the name is the same.
* StringTruncator.m:
(+[StringTruncator centerTruncateString:length:omitCount:toBuffer:]):
Does the work of removing the middle of a string.
(+[StringTruncator centerTruncateString:toWidth:]): Convenience cover version that
uses the menu font.
(+[StringTruncator centerTruncateString:toWidth:withFont:]): The code to do the

* TextCell.m: (-[TextCell drawInteriorWithFrame:inView:]): Use the new truncator
interface that takes a font, not the old one that took an attributes dictionary.

* WebBrowser.pbproj/project.pbxproj: Some little tweak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@1133 268f45cc-cd09-0410-ab3c-d52691b4dbfc