13 years ago Remove a test that doesn't fail for me - let's see what the bot thinks.
ap@webkit.org [Mon, 14 Jan 2008 12:33:11 +0000 (12:33 +0000)]
    Remove a test that doesn't fail for me - let's see what the bot thinks.

        * platform/win/Skipped: Removed http/tests/xmlhttprequest/XMLHttpRequestException.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by David Kilzer.
ap@webkit.org [Mon, 14 Jan 2008 09:12:18 +0000 (09:12 +0000)]
    Reviewed by David Kilzer.

        array.splice() with 1 element not working

        Test: fast/js/array-splice.html

        * kjs/array_object.cpp:
        (KJS::ArrayProtoFuncSplice::callAsFunction): Implement this Mozilla extension, and fix
        some other edge cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
sfalken@apple.com [Mon, 14 Jan 2008 06:05:38 +0000 (06:05 +0000)]

        Share common files across projects.

        Unify vsprops files
        Debug:          common.vsprops, debug.vsprops
        Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
        Release:        common.vsprops, release.vsprops

        Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
        debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

        Reviewed by Adam Roben.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/debug.vsprops: Removed.
        * JavaScriptCore.vcproj/debug_internal.vsprops: Removed.
        * JavaScriptCore.vcproj/release.vsprops: Removed.
        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:


        Share common files across projects.

        Unify vsprops files
        Debug:          common.vsprops, debug.vsprops
        Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
        Release:        common.vsprops, release.vsprops

        Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
        debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

        Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

        Reviewed by Adam Roben.

        * WebCore.vcproj/PRODUCTVERSION: Removed.
        * WebCore.vcproj/QTMovieWin.vcproj:
        * WebCore.vcproj/VERSION: Removed.
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/auto-version.sh: Removed.
        * WebCore.vcproj/debug.vsprops: Removed.
        * WebCore.vcproj/debug_internal.vsprops: Removed.
        * WebCore.vcproj/release.vsprops: Removed.


        Share common files across projects.

        Unify vsprops files
        Debug:          common.vsprops, debug.vsprops
        Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
        Release:        common.vsprops, release.vsprops

        Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
        debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

        Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

        Reviewed by Adam Roben.

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/PRODUCTVERSION: Removed.
        * WebKit.vcproj/VERSION: Removed.
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:
        * WebKit.vcproj/auto-version.sh: Removed.
        * WebKit.vcproj/debug.vsprops: Removed.
        * WebKit.vcproj/debug_internal.vsprops: Removed.
        * WebKit.vcproj/release.vsprops: Removed.


        Share common files across projects.

        Unify vsprops files
        Debug:          common.vsprops, debug.vsprops
        Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
        Release:        common.vsprops, release.vsprops

        Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
        debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

        Moved auto-version.sh, VERSION, PRODUCTVERSION to tools.

        Reviewed by Adam Roben.

        * win/tools/WinTools.make:
        * win/tools/scripts: Added.
        * win/tools/scripts/PRODUCTVERSION: Added.
        * win/tools/scripts/VERSION: Added.
        * win/tools/scripts/auto-version.sh: Copied from WebCore/WebCore.vcproj/auto-version.sh.
        * win/tools/vsprops/debug.vsprops:
        * win/tools/vsprops/debug_internal.vsprops: Added.
        * win/tools/vsprops/release.vsprops:


        Share common files across projects.

        Unify vsprops files
        Debug:          common.vsprops, debug.vsprops
        Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
        Release:        common.vsprops, release.vsprops

        Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
        debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

        Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

        Reviewed by Adam Roben.

        * Drosera/win/Drosera.vcproj/Drosera.vcproj:
        * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
        * Drosera/win/Drosera.vcproj/VERSION: Removed.
        * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
        * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
        * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
        * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
        * DumpRenderTree/win/debug.vsprops: Removed.
        * DumpRenderTree/win/debug_internal.vsprops: Removed.
        * DumpRenderTree/win/release.vsprops: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
mitz@apple.com [Mon, 14 Jan 2008 04:40:46 +0000 (04:40 +0000)]
    Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16865
          fast/layers/resize-layer-deletion-crash.html crashes under GuardMalloc

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::destroy): Removed the call to
        RenderLayer::destroy() from here, because ~RenderLayer() calls
        RenderObject() methods.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::destroy): Added the call to
        RenderLayer::destroy() here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by darin.
eric@webkit.org [Mon, 14 Jan 2008 01:35:00 +0000 (01:35 +0000)]
    Reviewed by darin.

        Range.insertNode does not update endContainer endIndex correctly
        in the case where it had to split a text node.

        Darin pointed out during review that we still don't handle the dynamic
        range case (where the dom tree changes not using range methods)
        Thus this code will get ripped out when we add that.  The test cases
        are still valid and useful however, so I'm landing this as-is.

        Tests: fast/dom/Range/range-insertNode-separate-endContainer.html

        * dom/Range.cpp:
        (WebCore::Range::insertNode): handle the splitText case correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
darin@apple.com [Sun, 13 Jan 2008 19:54:53 +0000 (19:54 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=16314
          Script to launch Drosera

        * Scripts/gdb-drosera: Added.
        * Scripts/run-drosera: Added.
        * Scripts/run-drosera-nightly.cmd: Added.
        * Scripts/webkitdirs.pm: Added runDrosera function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Contributions and review by Adriaan de Groot,
darin@apple.com [Sun, 13 Jan 2008 19:47:56 +0000 (19:47 +0000)]
    Contributions and review by Adriaan de Groot,
        Simon Hausmann, Eric Seidel, and Darin Adler.

        - http://bugs.webkit.org/show_bug.cgi?id=16590
          Compilation fixes for Solaris.

        * kjs/DateMath.h:
        (KJS::GregorianDateTime::GregorianDateTime): Use the WIN_OS code path
        for SOLARIS too, presumably because Solaris also lacks the tm_gtoff and tm_zone
        (KJS::GregorianDateTime::operator tm): Ditto.

        * kjs/collector.cpp:
        (KJS::currentThreadStackBase): Use thr_stksegment on Solaris.

        * wtf/MathExtras.h:
        (isfinite): Implement for Solaris.
        (isinf): Ditto.
        (signbit): Ditto. But this one is wrong, so I added a FIXME.

        * wtf/Platform.h: Define PLATFORM(SOLARIS) when "sun" or "__sun" is defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowxWebKit API changes in preparation for DRT implementation.
kevino@webkit.org [Sun, 13 Jan 2008 19:34:48 +0000 (19:34 +0000)]
wxWebKit API changes in preparation for DRT implementation.

Reviewed by Darin Adler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
darin@apple.com [Sun, 13 Jan 2008 19:19:41 +0000 (19:19 +0000)]
    Reviewed by Eric.

        - http://bugs.webkit.org/show_bug.cgi?id=16861
          get rid of unnecessary string copying

        * dom/Document.cpp:
        (WebCore::Document::setDomain): Removed unneeded call to copy.
        (WebCore::Document::parseQualifiedName): Removed unneeded call to copy, and
        unneeded length argument to substring, which stops at the end of the string
        if you don't specify a length.
        (WebCore::Document::createAttributeNS): Replaced code that was calling copy
        with more-efficient code using the substring function.
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::addCSSColor): Removed unneeded call to copy.
        * editing/InsertIntoTextNodeCommand.cpp:
        (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Removed
        unneeded copy and also initialized text instead of assigning to it.
        (WebCore::InsertIntoTextNodeCommand::doApply): Removed redundant assertions.
        (WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.

        * editing/htmlediting.cpp:
        (WebCore::stringWithRebalancedWhitespace): Removed unneeded call to copy.
        This one was particularly bad since we just turned around and copied it again!

        * editing/markup.cpp:
        (WebCore::stringValueForRange): Removed unneeded call to copy.

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::performOpenInitialization): Changed logging code to not
        get the path from the database object. This was the only reason the database
        had to keep its path around.

        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::open): Use a local variable instead of a data member to
        convert the string to a null-terminated one.
        (WebCore::SQLiteDatabase::close): Removed the code to clear out m_path.
        * platform/sql/SQLiteDatabase.h: Removed the m_path data member and the path
        functio member. Also tweaked formatting and comments a bit. Removed the unused
        escapeSQLString function.

        * platform/text/String.cpp: (WebCore::operator+): Removed uneeded calls to copy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - fix breakage due to last-minute change
mitz@apple.com [Sun, 13 Jan 2008 17:24:48 +0000 (17:24 +0000)]
    - fix breakage due to last-minute change

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (runTest): Declare the loop variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
mitz@apple.com [Sun, 13 Jan 2008 17:15:54 +0000 (17:15 +0000)]

        Reviewed by Adam Roben.

        - fix <rdar://problem/5132009> Windows DRT does not support multiple windows

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting): Factored out of
        (allWindows): Added. Returns a vector of all open windows.
        (windowToWebViewMap): Added. Returns a map from open windows to their
        (createWebViewAndOffscreenWindow): Factored out of main() to be
        reusable for creating extra windows.
        * DumpRenderTree/win/DumpRenderTreeWin.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::windowCount): Implemented.
        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::createWebViewWithRequest): Implemented.
        (UIDelegate::webViewClose): Implemented.
        * DumpRenderTree/win/UIDelegate.h:


        Reviewed by Adam Roben.

        - enable tests affected by <rdar://problem/5132009> Windows DRT does not support multiple windows

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAttempt to fix QT build
oliver@apple.com [Sun, 13 Jan 2008 13:20:42 +0000 (13:20 +0000)]
Attempt to fix QT build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAvoid repainting the entire canvas element when possible.
oliver@apple.com [Sun, 13 Jan 2008 13:09:12 +0000 (13:09 +0000)]
Avoid repainting the entire canvas element when possible.

Reviewed by Mark Rowe.

We now only register the dirty regions of a canvas for repainting, rather
than the entire element (though repaint coalescing may choose to combine
these regions).  This doesn't cause a measurable regression in the worst
case (clearing the canvas repeatedly), but is a moderate-large win if only
a minor update has occurred.  If there is any CSS scaling applied to the
canvas almost any update short of clearing the entire element is substantially

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-13 Michael Goddard <michael.goddard@trolltech.com>
mrowe@apple.com [Sun, 13 Jan 2008 11:08:39 +0000 (11:08 +0000)]
2008-01-13  Michael Goddard  <michael.goddard@trolltech.com>

        Reviewed by Anders Carlsson.

        Add binding language type to Instance.
        Allows runtime determination of the type of an
        Instance, to allow safe casting.  Doesn't actually
        add any safe casting yet, though.

        Add a helper function to get an Instance from a JSObject*.
        Given an object and the expected binding language, see if
        the JSObject actually wraps an Instance of the given type
        and return it.  Otherwise return 0.

        Move RuntimeObjectImp creations into Instance.
        Make the ctor protected, and Instance a friend class, so
        that all creation of RuntimeObjectImps goes through
        one place.

        Remove copy ctor/assignment operator for QtInstance.
        Instance itself is Noncopyable, so QtInstance doesn't
        need to have these.

        Add caching for QtInstance and associated RuntimeObjectImps.
        Push any dealings with QtLanguage bindings into QtInstance,
        and cache them there, rather than in the Instance layer.  Add
        a QtRuntimeObjectImp to help with caching.

        * JavaScriptCore.exp:
        * bindings/c/c_instance.h:
        * bindings/jni/jni_instance.h:
        * bindings/objc/objc_instance.h:
        * bindings/qt/qt_instance.cpp:
        * bindings/qt/qt_instance.h:
        * bindings/runtime.cpp:
        * bindings/runtime.h:
        * bindings/runtime_object.h:

2008-01-13  Michael Goddard  <michael.goddard@trolltech.com>

        Reviewed by Anders Carlsson.

        Move RuntimeObjectImp creations into Instance.
        Make the ctor protected, and Instance a friend class, so
        that all creation of RuntimeObjectImps goes through
        one place.

        * bindings/js/kjs_dom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change test to match the results landed in r29424. The test changes were
mitz@apple.com [Sun, 13 Jan 2008 08:51:50 +0000 (08:51 +0000)]
    Change test to match the results landed in r29424. The test changes were
        omitted in that check-in.

        * editing/pasteboard/paste-RTFD.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-12 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 13 Jan 2008 07:33:53 +0000 (07:33 +0000)]
2008-01-12  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Hide non-public symbols in GTK+/autotools release builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fix. Add WebCore/icu/include for Mac builds using only stock ICU.
kevino@webkit.org [Sun, 13 Jan 2008 06:54:57 +0000 (06:54 +0000)]
wx build fix. Add WebCore/icu/include for Mac builds using only stock ICU.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
mrowe@apple.com [Sun, 13 Jan 2008 04:52:01 +0000 (04:52 +0000)]
2008-01-12  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Mark Rowe.

        Fix http://bugs.webkit.org/show_bug.cgi?id=16852
        Fixes leaking of ActivationStackNode objects.

        * kjs/JSGlobalObject.cpp:
        * kjs/JSGlobalObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-12 Rodney Dawes <dobey@wayofthemonkey.com>
mrowe@apple.com [Sat, 12 Jan 2008 19:25:23 +0000 (19:25 +0000)]
2008-01-12  Rodney Dawes  <dobey@wayofthemonkey.com>

        Gtk debug build fix.  Reviewed by Mark Rowe.

        Add plugin logging channel, and use it rather than Win32-specific debugging methods _RPTF1 _RPTF2 and _CRT_WARN.

        * WebCore.pro: Add plugins directory to DEPENDPATH so dependencies are correctly tracked.
        * platform/Logging.cpp:
        * platform/Logging.h:
        * plugins/PluginDebug.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Update expected results for fast/replaced/image-map-expected after
mitz@apple.com [Sat, 12 Jan 2008 18:35:27 +0000 (18:35 +0000)]
    Update expected results for fast/replaced/image-map-expected after
        r29432 disabled document replacement by the JavaScript result in this

        * fast/replaced/image-map-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - try to fix Qt Windows build
darin@apple.com [Sat, 12 Jan 2008 18:19:57 +0000 (18:19 +0000)]
    - try to fix Qt Windows build

        * pcre/dftables: Remove reliance on the list form of Perl pipes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - try to fix Qt build
darin@apple.com [Sat, 12 Jan 2008 18:05:44 +0000 (18:05 +0000)]
    - try to fix Qt build

        * kjs/function.cpp: Added include of scope_chain_mark.h.
        * kjs/scope_chain_mark.h: Added multiple-include guards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRoll out r29435 as it introduces many, many crashes.
mrowe@apple.com [Sat, 12 Jan 2008 15:43:03 +0000 (15:43 +0000)]
Roll out r29435 as it introduces many, many crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-12 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Sat, 12 Jan 2008 14:25:03 +0000 (14:25 +0000)]
2008-01-12  Mark Rowe  <mrowe@apple.com>

        Another Windows build fix.

        * kjs/Activation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-12 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Sat, 12 Jan 2008 14:12:55 +0000 (14:12 +0000)]
2008-01-12  Mark Rowe  <mrowe@apple.com>

        Attempted Windows build fix.  Use struct consistently when forward-declaring
        ActivationStackNode and StackActivation.

        * kjs/Activation.h:
        * kjs/JSGlobalObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
mrowe@apple.com [Sat, 12 Jan 2008 14:06:33 +0000 (14:06 +0000)]
2008-01-12  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Mark Rowe.

        Fixes leaking of ActivationStackNode objects.

        * kjs/JSGlobalObject.cpp:
        * kjs/JSGlobalObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago* Make launching of the WebKit httpd work on GNU/Debian/Linux
zecke@webkit.org [Sat, 12 Jan 2008 13:48:09 +0000 (13:48 +0000)]
* Make launching of the WebKit httpd work on GNU/Debian/Linux

The configuration of Apache2 and installation does not depend on
the kernel but on the distribution policy. Make launching of httpd
work for Debian derived distributions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
mrowe@apple.com [Sat, 12 Jan 2008 13:19:22 +0000 (13:19 +0000)]
Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.

Reviewed by Maciej Stachowiak.

* DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
match the callers expectations that it can take ownership of the string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej (and also tweaked a little bit).
mjs@apple.com [Sat, 12 Jan 2008 12:03:28 +0000 (12:03 +0000)]
    Reviewed by Maciej (and also tweaked a little bit).

        - more thorough fix for some crashing tests

        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
mjs@apple.com [Sat, 12 Jan 2008 11:03:30 +0000 (11:03 +0000)]
    Reviewed by Maciej.

        Fixes a problem with the ActivationImp tear-off patch (r29425) where
        some of the calls to JSGlobalObject::tearOffActivation() were using
        the wrong test to determine whether it should leave a relic behind.

        * kjs/function.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
mjs@apple.com [Sat, 12 Jan 2008 08:37:20 +0000 (08:37 +0000)]
    Reviewed by Sam.

        - fixed <rdar://problem/5556374> REGRESSION: cross-domain error when one URL uses an explicit port number and another doesn't

        * platform/SecurityOrigin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-11 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 12 Jan 2008 07:40:52 +0000 (07:40 +0000)]
2008-01-11  Alp Toker  <alp@atoker.com>

        Reviewed by Oliver Hunt.

        Enable FastMalloc by default in GTK+/autotools and add a configure

        * GNUmakefile.am:
        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren@apple.com [Sat, 12 Jan 2008 07:19:27 +0000 (07:19 +0000)]

        Reviewed by Oliver Hunt.

        Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
        variable access (16644)

        This bug was caused by var declarations shadowing built-in properties of
        the global object.

        To match Firefox, we've decided that var declarations will never shadow
        built-in properties of the global object or its prototypes. We used to
        behave more like IE, which allows shadowing, but walking that line got
        us into trouble with websites that sent us down the Firefox codepath.

        * kjs/JSVariableObject.h:
        (KJS::JSVariableObject::symbolTableGet): New code to support calling
        hasProperty before the variable object is fully initialized (so you
        can call it during initialization).

        * kjs/nodes.cpp:.
        (KJS::ProgramNode::initializeSymbolTable): Always do a full hasProperty
        check when looking for duplicates, not getDirect, since it only checks
        the property map, and not hasOwnProperty, since it doesn't check
        (KJS::EvalNode::processDeclarations): ditto

        * kjs/property_slot.h:
        (KJS::PropertySlot::ungettableGetter): Best function name evar.


        Reviewed by Oliver Hunt.

        Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
        variable access (16644)

        Removed the ReadOnly bit from some properties, to match Firefox. Also
        removed status-related setters, to allow using their names as variable

        * bindings/scripts/CodeGeneratorJS.pm: Added support for properties that
        are one-way across domain boundaries, to match Firefox.

        * bindings/js/kjs_window.cpp: Changed ReadOnly declarations to match FF.

        * bindings/scripts/CodeGeneratorJS.pm: Don't use JSObject:: because
        we don't know that JSObject is our base class.

        * page/DOMWindow.idl: Replaced lots of readonly declarations with
        [Replaceable] declarations.

        * page/DOMWindow.h: Removed interfaces for setting status text via the
        DOM. (They were getting in the way of, e.g., "var status"
        declarations.) By default, IE 7 and FF disable these interfaces in order
        to defend against phishing attacks that try to spoof domain names in the
        * page/DOMWindow.cpp:


        Reviewed by Oliver Hunt.

        Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
        variable access (16644)

        Added a test. Updated other tests to match new behavior.

        * fast/js/var-declarations-shadowing-expected.txt: Added.
        * fast/js/var-declarations-shadowing.html: Added.

        * fast/dom/HTMLScriptElement/script-load-events.html: Changed this test
        a bit because the original design made it hard to understand why it was failing.
        * fast/dom/HTMLScriptElement/script-load-events-expected.txt:

        * fast/dom/Window/get-set-properties.html: Changed this test to expect
        our new behavior, which matches Firefox.
        * fast/dom/Window/get-set-properties-expected.txt:

        * fast/dom/Window/window-property-shadowing.html: Removed some cases
        that differed from Firefox.
        * fast/dom/Window/window-property-shadowing-expected.txt:

        * http/tests/security/cross-frame-access-put-expected.txt: This test emits
        more "Unsafe JavaScript attempt" messages now because property sets that
        used to be prohibited (somewhat accidentally) by the ReadOnly attribute
        are now prohibited by security checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Sat, 12 Jan 2008 05:50:36 +0000 (05:50 +0000)]

2008-01-11  Anyang Ren  <anyang.ren@gmail.com>

        Reviewed by Darin Adler.

        The view source mode should skip an empty attribute value only if
        the attribute name is not followed by an equal sign (=).

        Test: fast/frames/viewsource-empty-attribute-value.html

        * html/HTMLViewSourceDocument.cpp:


2008-01-11  Anyang Ren  <anyang.ren@gmail.com>

        Reviewed by Darin Adler.

        Add a new regression test for
        The view source mode should skip an empty attribute value only if
        the attribute name is not followed by an equal sign (=).

        * fast/frames/resources/viewsource-frame-1.html: Added.
        * fast/frames/viewsource-empty-attribute-value-expected.txt: Added.
        * fast/frames/viewsource-empty-attribute-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-11 Sylvain Pasche <sylvain.pasche@gmail.com>
alp@webkit.org [Sat, 12 Jan 2008 02:22:48 +0000 (02:22 +0000)]
2008-01-11  Sylvain Pasche  <sylvain.pasche@gmail.com>

        Reviewed by Alp Toker.

        [Gtk] Uneven glyph spacing with subpixel antialiasing

        Use cairo font options from the default GDK screen when creating a
        scaled font.

        * platform/graphics/gtk/FontPlatformDataGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
mjs@apple.com [Sat, 12 Jan 2008 02:08:50 +0000 (02:08 +0000)]

        Reviewed by Maciej.

        Optimized ActivationImp allocation, so that activation records are now
        first allocated on an explicitly managed stack and only heap allocated
        when necessary. Roughly a 5% improvement on SunSpider, and a larger
        improvement on benchmarks that use more function calls.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/Activation.h: Added.
        * kjs/ExecState.cpp:
        * kjs/ExecState.h:
        * kjs/JSGlobalObject.cpp:
        * kjs/JSGlobalObject.h:
        * kjs/JSVariableObject.h:
        * kjs/function.cpp:
        * kjs/function.h:
        * kjs/nodes.cpp:
        * kjs/object.h:
        * kjs/scope_chain.h:
        * kjs/scope_chain_mark.h: Added.


        Reviewed by Maciej.

        Added a new forwarding header, because Activation.h has been separated
        from function.h

        * ForwardingHeaders/kjs/Activation.h: Added.


        Reviewed by Maciej.

        Added a test case that came up when developing the ActivationImp tear-off.

        * fast/js/resources/vardecl-preserve-arguments.js:
        * fast/js/vardecl-preserve-arguments-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago <rdar://problem/5541054> editing/pasteboard/paste-RTFD.html failing on Tiger
justin.garcia@apple.com [Sat, 12 Jan 2008 01:52:54 +0000 (01:52 +0000)]
    <rdar://problem/5541054> editing/pasteboard/paste-RTFD.html failing on Tiger

        * editing/pasteboard/paste-RTFD.html: Mention the Tiger bug that this demonstrates.
        * platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.checksum: Added.
        * platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
        * platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt: Updated expected results
        to reflect the new info included in the test.
        * platform/mac/editing/pasteboard/paste-RTFD-expected.checksum: Ditto.
        * platform/mac/editing/pasteboard/paste-RTFD-expected.png:
        * platform/mac/editing/pasteboard/paste-RTFD-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-11 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Sat, 12 Jan 2008 01:36:02 +0000 (01:36 +0000)]
2008-01-11  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        [cURL] Allow multiple files for upload

        * platform/network/ResourceHandleInternal.h:
        * platform/network/curl/ResourceHandleCurl.cpp:
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::readCallback): added
        (WebCore::ResourceHandleManager::setupPOST): setup for streaming the POST
        (WebCore::ResourceHandleManager::cancel): revert the previous patch for regression
        * platform/network/curl/ResourceHandleManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-11 Christian Dywan <christian@imendio.com>
alp@webkit.org [Sat, 12 Jan 2008 00:25:41 +0000 (00:25 +0000)]
2008-01-11  Christian Dywan  <christian@imendio.com>

        Reviewed by Alp Toker.

        [Gtk] Menu items need underscores

        Add underscores to appropriate menu labels.
        Also adjust strings slightly.

        * platform/gtk/ContextMenuItemGtk.cpp:
        * platform/gtk/LocalizedStringsGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago <rdar://problem/5681557> On Windows Safari, mouse events are ignored after...
adachan@apple.com [Fri, 11 Jan 2008 23:56:40 +0000 (23:56 +0000)]
    <rdar://problem/5681557> On Windows Safari, mouse events are ignored after clicking on link that triggers download
        Moved the call to cache page from provisionalLoadStarted() to commitProvisionalLoad(), since
        provisionalLoadStarted() can be called for cases that do not result in a page navigation, for example,
        when a link to download a file has been clicked.

        Reviewed by John and Anders.

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-11 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Fri, 11 Jan 2008 22:42:12 +0000 (22:42 +0000)]
2008-01-11  Jon Honeycutt  <jhoneycutt@apple.com>

        * platform/win/Skipped: Remove a test that was fixed in r29419.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-11 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Fri, 11 Jan 2008 22:38:31 +0000 (22:38 +0000)]
2008-01-11  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Anders.

        <rdar://problem/5683529> plugins/embed-inside-object.html is timing

        Revert to using FrameTree::find() so that frame aliases like "_self" and
        "_current" are interpreted properly

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-11 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 11 Jan 2008 21:58:11 +0000 (21:58 +0000)]
2008-01-11  Alp Toker  <alp@atoker.com>

        Reviewed by Dave Hyatt and Mark Rowe.

        [GTK] Support custom fonts, CachedFont::platformDataFromCustomData()

        Add support for CSS2 @font-face custom/downloadable fonts to the GTK+

        * GNUmakefile.am:
        * WebCore.pro:
        * loader/CachedFont.cpp:
        * platform/graphics/gtk/FontCustomPlatformData.cpp: Added.
        * platform/graphics/gtk/FontCustomPlatformData.h: Added.
        * platform/graphics/gtk/FontPlatformData.h:
        * platform/graphics/gtk/FontPlatformDataGtk.cpp:
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
ap@webkit.org [Fri, 11 Jan 2008 21:04:36 +0000 (21:04 +0000)]
    Reviewed by Adam Roben.

        <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing

        * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
        as these are only posted because the test window is not a normal visible one, and
        they confuse drag&drop machinery.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove FrameLoader::committedFirstRealDocumentLoad
aroben@apple.com [Fri, 11 Jan 2008 20:51:19 +0000 (20:51 +0000)]
     Remove FrameLoader::committedFirstRealDocumentLoad

         This method no longer has any callers.

         Reviewed by Hyatt.

         * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 16828: WebView never paints if first page load is canceled after...
aroben@apple.com [Fri, 11 Jan 2008 20:50:52 +0000 (20:50 +0000)]
     Fix Bug 16828: WebView never paints if first page load is canceled after being committed but before layout


         Now that we have 1) a real loader and 2) multiple FrameViews per
         Frame, we no longer need the hackery we had in our WM_PAINT handler
         that decided whether or not to paint. We now always want to paint,
         letting the swapping of FrameViews that happens in
         transitionToCommittedForNewPage handle which document gets painted.

         Reviewed by Hyatt.

         * WebView.cpp:
         (WebViewWndProc): Removed hackery that decided sometimes not to paint.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add a standalone version of the blog post video player as a manual test.
antti@apple.com [Fri, 11 Jan 2008 20:19:13 +0000 (20:19 +0000)]
    Add a standalone version of the blog post video player as a manual test.

        * manual-tests/resources/touch-poster.png: Added.
        * manual-tests/video-player.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agotest is failing on trunk-win-release, so putting it back to make it green
alice.liu@apple.com [Fri, 11 Jan 2008 20:07:54 +0000 (20:07 +0000)]
test is failing on trunk-win-release, so putting it back to make it green

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add shared vsprops to help unify our Windows tools settings.
sfalken@apple.com [Fri, 11 Jan 2008 19:47:02 +0000 (19:47 +0000)]
    Add shared vsprops to help unify our Windows tools settings.

        Reviewed by Hyatt.

        * win/tools: Added.
        * win/tools/WinTools.make: Added.
        * win/tools/vsprops: Added.
        * win/tools/vsprops/common.vsprops: Added.
        * win/tools/vsprops/debug.vsprops: Added.
        * win/tools/vsprops/release.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoremoving test that doesn't fail
alice.liu@apple.com [Fri, 11 Jan 2008 19:29:29 +0000 (19:29 +0000)]
removing test that doesn't fail

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
antti@apple.com [Fri, 11 Jan 2008 19:19:57 +0000 (19:19 +0000)]
    Reviewed by Adam.

        Fix <rdar://problem/5682767>
        Video does not show up in http://webkit.org/blog/140/html5-media-support/ on Windows

        Take care that GWorld is created and deletes when needed as size or visibility changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 11188, setting hspace on a table overrides align=center. Fix...
hyatt@apple.com [Fri, 11 Jan 2008 18:27:18 +0000 (18:27 +0000)]
    Fix for bug 11188, setting hspace on a table overrides align=center.  Fix align=center to be done using
        mapped attributes so that it does not get overridden by hspace all the time.

        Reviewed by mitz

        Added fast/table/table-hspace-align-center.html

        * css/html4.css:
        * html/HTMLTableElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout test for table bug.
hyatt@apple.com [Fri, 11 Jan 2008 18:25:44 +0000 (18:25 +0000)]
Add layout test for table bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agomoved couple of tests to a better category
alice.liu@apple.com [Fri, 11 Jan 2008 18:15:32 +0000 (18:15 +0000)]
moved couple of tests to a better category

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix a crash when pathToLocalResource fails and a leak
aroben@apple.com [Fri, 11 Jan 2008 18:14:34 +0000 (18:14 +0000)]
     Fix a crash when pathToLocalResource fails and a leak

         Reviewed by Darin.

         * DumpRenderTree/LayoutTestController.cpp:
         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
         sure not to pass null to JSValueMakeString.
         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
         (LayoutTestController::pathToLocalResource): Print an error message if
         the conversion fails so it's clear what happened.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * platform/win/Skipped: Added some new failures.
aroben@apple.com [Fri, 11 Jan 2008 16:32:29 +0000 (16:32 +0000)]
    * platform/win/Skipped: Added some new failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-11 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Fri, 11 Jan 2008 16:31:34 +0000 (16:31 +0000)]
2008-01-11  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        [GTK] Bad autotools debug and video options

        Fix some configure options.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoQt build fix.
mrowe@apple.com [Fri, 11 Jan 2008 12:40:32 +0000 (12:40 +0000)]
Qt build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Mark Rowe.
hausmann@webkit.org [Fri, 11 Jan 2008 12:26:21 +0000 (12:26 +0000)]
Reviewed by Mark Rowe.

Fix the (clean) qmake build. For generating chartables.c we don't
depend on a separate input source file anymore, the dftables perl
script is enough. So use that instead as value for the .input
variable, to ensure that qmake also generates a rule to call dftables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWindows build fix. Update to match method name in WebCore.
mrowe@apple.com [Fri, 11 Jan 2008 11:56:58 +0000 (11:56 +0000)]
Windows build fix.  Update to match method name in WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoQt build fix. Add link stubs for the new FileSystem.h functions introduced in r29399.
mrowe@apple.com [Fri, 11 Jan 2008 11:53:48 +0000 (11:53 +0000)]
Qt build fix.  Add link stubs for the new FileSystem.h functions introduced in r29399.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-11 Rodney Dawes <dobey@wayofthemonkey.com>
mrowe@apple.com [Fri, 11 Jan 2008 11:32:46 +0000 (11:32 +0000)]
2008-01-11  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Anders Carlsson.

        Bug 16779: Make the PluginStream implementation be shared across platforms

        Add the new shared PluginStream files to the GTK+ and Win32 builds.
        Add PluginStreamClient class for the streamDidFinishLoading method.
        Add open/close/write methods to FileSystem for temporary file handling.
        Add PluginDebug.h and npfunctions.h for shared PluginStream.
        Add shared PluginStream.
        Remove PluginStreamWin.
        Update PluginViewWin to use shared PluginStream and PluginStreamClass.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * platform/FileSystem.h:
        * platform/gtk/FileSystemGtk.cpp:
        * platform/win/FileSystemWin.cpp:
        * plugins/PluginDebug.h:
        * plugins/PluginStream.cpp:
        * plugins/PluginStream.h:
        * plugins/npfunctions.h:
        * plugins/win/PluginDebug: Moved to PluginDebug.h.
        * plugins/win/PluginStreamWin.cpp: Moved to PluginStream.cpp.
        * plugins/win/PluginStreamWin.h: Moved to PluginStream.h
        * plugins/win/PluginViewWin.cpp:
        * plugins/win/PluginViewWin.h:
        * plugins/win/npfunctions.h: Moved to npfunctions.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Try to fix Mac build: Edit the right .exp file.
ggaren@apple.com [Fri, 11 Jan 2008 10:09:51 +0000 (10:09 +0000)]
    Try to fix Mac build: Edit the right .exp file.

        * WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Try to fix Qt build: don't use pthreads if they're not available.
ggaren@apple.com [Fri, 11 Jan 2008 10:03:38 +0000 (10:03 +0000)]
    Try to fix Qt build: don't use pthreads if they're not available.

        * bindings/js/GCController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren@apple.com [Fri, 11 Jan 2008 09:52:27 +0000 (09:52 +0000)]

        Reviewed by John Sullivan.

        Fixed some world leak reports:
        * <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript
        Interpreter after running cvs-base suite

        * <rdar://problem/5669423> PLT complains about world leak if browser
        window is open when PLT starts

        * kjs/collector.h: Added the ability to distinguish between global
        objects and GC-protected global objects, since we only consider the
        latter to be world leaks.
        * kjs/collector.cpp:


        Reviewed by John Sullivan.

        Fixed some world leak reports:
        * <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript
        Interpreter after running cvs-base suite

        * <rdar://problem/5669423> PLT complains about world leak if browser
        window is open when PLT starts

        These were both bugs in the reporting mechanism, so I took the
        opportunity to do some house cleaning there.

        Stupid class, I kill you:
        * bridge/JavaScriptStatistics.cpp: Removed.
        * bridge/JavaScriptStatistics.h: Removed.

        * bindings/js/GCController.h: Adopted the only useful features of
        JavaScriptStatistics, since they were GC-related.
        * bindings/js/GCController.cpp:


        Reviewed by John Sullivan.

        Fixed some world leak reports:
        * <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript
        Interpreter after running cvs-base suite

        * <rdar://problem/5669423> PLT complains about world leak if browser
        window is open when PLT starts

        These were both bugs in the reporting mechanism, so I took the
        opportunity to do some house cleaning there.

        * Misc/WebCoreStatistics.h: Did a little renaming, to match
        JavaScriptCore better. I kept the methods with the old names around,
        though, because old versions of Safari need them.

        * Misc/WebCoreStatistics.mm: Removed dependence on
        WebCore::JavaScriptStatistics, which is gone now.

        These two methods are now distinct, for the sake of world leak reporting:
        (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
        (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):


        Reviewed by John Sullivan.

        Updated for transition away from JavaScriptStatistics, which is gone now.

        * WebJavaScriptCollector.cpp:


        Reviewed by John Sullivan.

        * DumpRenderTree/mac/GCControllerMac.mm:
        (GCController::collectOnAlternateThread): Updated for name change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSilence qmake warning about ctgen lacking input. Rubber-stamped by Alp Toker.
mrowe@apple.com [Fri, 11 Jan 2008 08:22:47 +0000 (08:22 +0000)]
Silence qmake warning about ctgen lacking input.  Rubber-stamped by Alp Toker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAttempt to fix the GTK+ and Qt builds.
mrowe@apple.com [Fri, 11 Jan 2008 08:04:21 +0000 (08:04 +0000)]
Attempt to fix the GTK+ and Qt builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed, build fix.
mjs@apple.com [Fri, 11 Jan 2008 07:50:44 +0000 (07:50 +0000)]
    Not reviewed, build fix.

        - more build fixing

        * WebDatabaseManager.cpp:
        * WebSecurityOrigin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed, build fix.
mjs@apple.com [Fri, 11 Jan 2008 07:30:41 +0000 (07:30 +0000)]
    Not reviewed, build fix.

        - try to fix build

        * WebDatabaseManager.cpp:
        * WebSecurityOrigin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fix. Don't build dftables any longer since it's now a Perl script.
kevino@webkit.org [Fri, 11 Jan 2008 05:29:08 +0000 (05:29 +0000)]
wx build fix. Don't build dftables any longer since it's now a Perl script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd FIXME for replacing YYPARSE_PARAM with %parse-param to CSSGrammar.y
eric@webkit.org [Fri, 11 Jan 2008 05:12:34 +0000 (05:12 +0000)]
Add FIXME for replacing YYPARSE_PARAM with %parse-param to CSSGrammar.y

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
eric@webkit.org [Fri, 11 Jan 2008 04:42:35 +0000 (04:42 +0000)]
    Reviewed by Adele.

        No functional changes, only code cleanup.

        * css/MediaQueryEvaluator.cpp:
        (WebCore::compareValue): renamed from cmpvalue

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Fri, 11 Jan 2008 04:19:48 +0000 (04:19 +0000)]
    Reviewed by Anders Carlsson.

        - fix a crash when calling alert() from a repeating timer

        On non-Mac platforms, the PageGroupLoadDeferrer pauses DOM timers during
        alert() and other similar functions, which deletes the actual
        DOMWindowTimer objects and replaces them with new objects when resuming.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::timerFired): Re-fetch the timer object from the map in
        case it has been deleted or replaced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed. Build fix.
mjs@apple.com [Fri, 11 Jan 2008 03:51:00 +0000 (03:51 +0000)]
    Not reviewed. Build fix.

        - Attempt to fix mac build.

        * Storage/WebDatabaseManager.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mjs@apple.com [Fri, 11 Jan 2008 03:36:14 +0000 (03:36 +0000)]

        Reviewed by Sam.

        - remove SecurityOriginData and fold its functionality into SecurityOrigin

        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSDOMWindowCustom.cpp:
        * dom/Document.cpp:
        * page/Chrome.cpp:
        * page/Chrome.h:
        * page/ChromeClient.h:
        * platform/SecurityOrigin.cpp:
        * platform/SecurityOrigin.h:
        * platform/SecurityOriginData.cpp: Removed.
        * platform/SecurityOriginData.h: Removed.
        * storage/Database.cpp:
        * storage/Database.h:
        * storage/DatabaseTracker.cpp:
        * storage/DatabaseTracker.h:
        * storage/DatabaseTrackerClient.h:
        * storage/SQLTransaction.cpp:
        * svg/graphics/SVGImageEmptyClients.h:


        Reviewed by Sam.

        - remove SecurityOriginData and fold its functionality into SecurityOrigin

        * WebCoreSupport/ChromeClientGtk.cpp:
        * WebCoreSupport/ChromeClientGtk.h:


        Reviewed by Sam.

        - remove SecurityOriginData and fold its functionality into SecurityOrigin

        * Storage/WebDatabaseManager.mm:
        (-[WebDatabaseManager origins]):
        (-[WebDatabaseManager databasesWithOrigin:]):
        (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
        (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
        (-[WebDatabaseManager deleteDatabase:withOrigin:]):
        * Storage/WebDatabaseTrackerClient.h:
        * Storage/WebDatabaseTrackerClient.mm:
        * Storage/WebSecurityOrigin.mm:
        (-[WebSecurityOrigin initWithProtocol:domain:port:]):
        (-[WebSecurityOrigin protocol]):
        (-[WebSecurityOrigin domain]):
        (-[WebSecurityOrigin port]):
        (-[WebSecurityOrigin usage]):
        (-[WebSecurityOrigin quota]):
        (-[WebSecurityOrigin setQuota:]):
        (-[WebSecurityOrigin isEqual:]):
        (-[WebSecurityOrigin dealloc]):
        (-[WebSecurityOrigin finalize]):
        (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
        (-[WebSecurityOrigin _core]):
        * Storage/WebSecurityOriginInternal.h:
        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:


        Reviewed by Sam.

        - remove SecurityOriginData and fold its functionality into SecurityOrigin

        * WebCoreSupport/ChromeClientQt.cpp:
        * WebCoreSupport/ChromeClientQt.h:


        Reviewed by Sam.

        - remove SecurityOriginData and fold its functionality into SecurityOrigin

        * WebChromeClient.cpp:
        * WebChromeClient.h:
        * WebDatabaseManager.cpp:
        * WebDatabaseManager.h:
        * WebSecurityOrigin.cpp:
        * WebSecurityOrigin.h:


        Reviewed by Sam.

        - remove SecurityOriginData and fold its functionality into SecurityOrigin

        * WebKitSupport/ChromeClientWx.cpp:
        * WebKitSupport/ChromeClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-10 Stephanie <slewis@apple.com>
slewis@apple.com [Fri, 11 Jan 2008 02:48:06 +0000 (02:48 +0000)]
2008-01-10  Stephanie  <slewis@apple.com>


        Move svg/batik/text/smallfonts.svg to the right skip list.

        * platform/mac-tiger/Skipped:
        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Fri, 11 Jan 2008 02:09:55 +0000 (02:09 +0000)]
    Reviewed by Sam.

        Use the correct frame loader load method. Using the old method would not cause a
        new window to be open if the frame navigation was not allowed.

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-10 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 11 Jan 2008 00:55:03 +0000 (00:55 +0000)]
2008-01-10  Alp Toker  <alp@atoker.com>

        SVG font build fix for GTK+/autotools.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBUILD FIX: Make dftables executable.
ddkilzer@apple.com [Fri, 11 Jan 2008 00:41:44 +0000 (00:41 +0000)]
BUILD FIX: Make dftables executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ddkilzer@apple.com [Fri, 11 Jan 2008 00:35:14 +0000 (00:35 +0000)]

        dftables should be rewritten as a script


        Reviewed by Darin.

        Rewrote the dftables utility in Perl.  Attempted to switch all
        build systems to call the script directly instead of building
        a binary first.  Only the Xcode build was able to be tested.

        * DerivedSources.make: Added pcre directory to VPATH and changed
        to invoke dftables directly.
        * GNUmakefile.am: Removed build information and changed to invoke
        dftables directly.
        * JavaScriptCore.vcproj/JavaScriptCore.sln: Removed reference to
        dftables project.
        * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Ditto.
        * JavaScriptCore.vcproj/dftables: Removed.
        * JavaScriptCore.vcproj/dftables/dftables.vcproj: Removed.
        * JavaScriptCore.xcodeproj/project.pbxproj: Removed dftables target.
        * jscore.bkl: Removed dftables executable definition.
        * pcre/dftables: Copied from JavaScriptCore/pcre/dftables.cpp.
        * pcre/dftables.cpp: Removed.
        * pcre/dftables.pro: Removed.
        * pcre/pcre.pri: Removed references to dftables.cpp and changed to
        invoke dftables directly.


        dftables should be rewritten as a script


        Reviewed by Darin.

        * WebKit.vcproj/WebKit.sln: Removed reference to dftables project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Fri, 11 Jan 2008 00:23:13 +0000 (00:23 +0000)]

        Reviewed by Sam Weinig and Anders Carlsson.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522

        This patch makes two changes:

        1) Java calls FrameLoader::load in a slightly different way than
           JavaScript, which previously let a malicious web site bypass the
           shouldAllowNavigation check.  This patch adds that check to that
           code path.

        2) FrameLoader now wraps calls to m_frame->tree()->find(name) with
           findFrameForNavigation, which calls shouldAllowNavigation.  This
           treats disallowed frame navigations as if the named frame did not
           exist, resulting in a popup window when appropriate.

        Tests: http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html

        * WebCore.base.exp:
        * bindings/js/kjs_window.cpp:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:


        Reviewed by Anders Carlsson.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation
        to ensure the shouldAllowNavigation check is made.


        Reviewed by Anders Carlsson.

        Make DRT track open windows instead of allocated windows so that
        we can avoid ASSERTION due to late deallocs out of our control.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/DumpRenderTreeMac.h:
        * DumpRenderTree/mac/DumpRenderTreeWindow.h:
        * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
        (+[DumpRenderTreeWindow openWindows]):
        (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
        (-[DumpRenderTreeWindow close]):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:


        Reviewed by Anders Carlsson.

        Tests for http://bugs.webkit.org/show_bug.cgi?id=16522

        * http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Added.
        * http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Added.
        * http/tests/security/frameNavigation/resources/navigation-happened.html: Added.
        * http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Added.
        * http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Added.
        * http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Added.
        * http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Added.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Written by Hyatt, reviewed by me
sullivan@apple.com [Fri, 11 Jan 2008 00:10:05 +0000 (00:10 +0000)]
    Written by Hyatt, reviewed by me

        - fixed <rdar://problem/5654297> Mail crashes occurs at WebCore::FontFallbackList::fontDataAt() when attempting to display
          a <video> element that uses controls attribute

        * rendering/MediaControlElements.cpp:
        force the render style to inherit from the media element's style; Hyatt filed 5682383 to cover cleaning
        up this architecture, but this one-line fix will prevent the crash in the meantime

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWhoops, did not mean to commit that.
andersca@apple.com [Fri, 11 Jan 2008 00:02:16 +0000 (00:02 +0000)]
Whoops, did not mean to commit that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix fast/forms/input-radio-checked-tab.html
andersca@apple.com [Fri, 11 Jan 2008 00:00:57 +0000 (00:00 +0000)]
    Fix fast/forms/input-radio-checked-tab.html
        Meta key is not the same as Alt key on windows.

        Reviewed by Darin.

        * platform/win/KeyEventWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Meta key is not the same as Alt key on windows.
adachan@apple.com [Thu, 10 Jan 2008 23:11:54 +0000 (23:11 +0000)]
    Meta key is not the same as Alt key on windows.

        Reviewed by Darin.

        * DumpRenderTree/win/EventSender.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix fast/forms/input-radio-checked-tab.html
adachan@apple.com [Thu, 10 Jan 2008 23:11:27 +0000 (23:11 +0000)]
    Fix fast/forms/input-radio-checked-tab.html
        Meta key is not the same as Alt key on windows.

        Reviewed by Darin.

        * platform/win/KeyEventWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * platform/win/Skipped: Removed a test that was fixed in r26826.
aroben@apple.com [Thu, 10 Jan 2008 22:17:26 +0000 (22:17 +0000)]
    * platform/win/Skipped: Removed a test that was fixed in r26826.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * platform/win/Skipped: Removed a test that was fixed in r28372.
aroben@apple.com [Thu, 10 Jan 2008 22:14:14 +0000 (22:14 +0000)]
    * platform/win/Skipped: Removed a test that was fixed in r28372.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan.
andersca@apple.com [Thu, 10 Jan 2008 21:51:40 +0000 (21:51 +0000)]
    Reviewed by John Sullivan.

        REGRESSION: BumperCar crashes when attempting to load a long invalid URL

        Make sure to call FrameLoader::receivedMainResourceError before calling
        FrameLoader::didFailToLoad. The call to receivedMainResourceError takes care of
        clearing out the provisional document loader so that we won't call the didFail
        ResourceLoadDelegate method twice. This also makes us call the FrameLoadDelegate method
        didFailPrivisionalLoad before calling the ResourceLoadDelegate method, which Safari 2.0 does.

        * loader/MainResourceLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
antti@apple.com [Thu, 10 Jan 2008 21:48:18 +0000 (21:48 +0000)]
    Reviewed by Adele.

        Fix <rdar://problem/5658048>
        After <video> has finished playing, dragging the scroller on different location of controller starts to play movie

        - Move to paused state if the playback had ended and the controller is used to seek to earlier time
        - Pause video playback during drag so the knob does not constantly try to escape from the mouse pointer

        * html/HTMLMediaElement.cpp:
        * html/HTMLMediaElement.h:
        * rendering/MediaControlElements.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
ap@webkit.org [Thu, 10 Jan 2008 21:33:19 +0000 (21:33 +0000)]
    Reviewed by Adam Roben.

        <rdar://problem/5667003> fast/dom/xmlhttprequest-html-response-encoding.html is failing

        * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Do not disable sniffing for file://
        requests, as CFNetwork doesn't perform extension to MIME type mapping then.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix many bugs by giving Windows one FrameView per page load
aroben@apple.com [Thu, 10 Jan 2008 21:23:34 +0000 (21:23 +0000)]
Fix many bugs by giving Windows one FrameView per page load


        Fixes to allow multiple FrameViews on Windows

        Reviewed by Hyatt.

        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView): Added a new constructor that takes an
        IntSize to specify the FrameView's initial size.
        (WebCore::FrameView::scheduleRelayout): Added an assertion that our
        Document is not in the page cache.
        * page/FrameView.h:
        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::~Widget): Add a warm, fuzzy ASSERT.
        * platform/qt/WidgetQt.cpp:
        (WebCore::Widget::~Widget): Ditto.
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::setWidget): Make sure to remove any existing
        Widget from the Widget hierarchy before deleting it. One instance
        where this is needed is when setWidget is called during FrameView
        creation on Windows.


        Fix many bugs by giving Windows one FrameView per page load

        Bugs include:
                Windows back/forward cache causes crashes in the layout tests
                REGRESSION: PLT broken on Windows due to back/forward cache
                Random crashes in FrameView::scheduleRelayout while surfing

        On Windows until now we've only had one FrameView per Frame. Once the
        back/forward cache was turned on this started causing assertions to
        fail and crashes to occur due to a single FrameView being both in the
        back/forward cache (possibly multiple times!) and used by a live
        document. We now create a new FrameView for each page load, just as
        Mac does.

        This has the side-effect of plugging some of the world leaks seen at
        the end of the PLT.

        Reviewed by Hyatt.

        * WebFrame.cpp:
        (WebFrame::initWithWebFrameView): Don't create the FrameView right
        away -- it'll be created when the load is committed.
        (WebFrame::transitionToCommittedFromCachedPage): Match the Mac by no
        longer calling resetMultipleFormSubmissionProtection here.
        (WebFrame::transitionToCommittedForNewPage): Ported code from
        -[WebCoreFrameBridge installInFrame:], and moved code here from
        WebFrame::initWithWebFrameView and WebView::initWithFrame. WebCore
        takes care of resetMultipleFormSubmissionProtection, just like it does
        on the Mac.
        * WebView.cpp:
        (WebView::initWithFrame): Moved FrameView initialization code to

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-10 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 10 Jan 2008 21:10:31 +0000 (21:10 +0000)]
2008-01-10  Alp Toker  <alp@atoker.com>

        Include math.h to get ceilf(). Part of the SVG font GTK+ build fix.

        * svg/SVGFontFaceElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Alice Liu.
justin.garcia@apple.com [Thu, 10 Jan 2008 20:40:34 +0000 (20:40 +0000)]
    Reviewed by Alice Liu.

        <rdar://problem/5658603> Crash in InsertNodeBefore::doUnapply() on Undo in Yahoo Mail
        <rdar://problem/5658709> Crash in RenderView::setSelection on Undo in Yahoo Mail

        Make sure we have an updated layout before we perform any editing work.

        * editing/EditCommand.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-10 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Thu, 10 Jan 2008 20:29:39 +0000 (20:29 +0000)]
2008-01-10  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        Back out r29206 which was causing regressions in curl http job

        * platform/network/curl/ResourceHandleManager.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
kmccullough@apple.com [Thu, 10 Jan 2008 19:33:44 +0000 (19:33 +0000)]

        Reviewed by Darin, Sam, and Adam.

        - <rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
        - link in gmail message displays JavaScript alert falsely complaining
        about pop-up blocking
        - When trying to open a new window, we now see if the user gesture
        occurred in the global dynamic object instead of the frame since that is
        the only place an event can occur.

        * bindings/js/kjs_window.cpp: - Check the dynamic global object instead
        of the frame.


        Reviewed by Darin, Sam and Adam.

        -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
        link in gmail message displays JavaScript alert falsely complaining
        about pop-up blocking.
        - Added the ability to enable the pop-up blocker via the

        * DumpRenderTree/LayoutTestController.cpp:
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:


        Reviewed by Darin, Sam, and Adam.

        -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
        link in gmail message displays JavaScript alert falsely complaining
        about pop-up blocking
        - When trying to open a new window, we now see if the user gesture
        occurred in the global dynamic object instead of the frame since that is
        the only place an event can occur.

        * fast/events/open-window-from-another-frame-expected.txt: Added.
        * fast/events/open-window-from-another-frame.html: Added.
        * fast/events/resources/open-window-from-another-frame-otherFrame.html: Added.
        * fast/events/resources/window-opened.html: Added.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 16247, visibility:hidden not honored when hit testing inline...
hyatt@apple.com [Thu, 10 Jan 2008 19:29:32 +0000 (19:29 +0000)]
    Fix for bug 16247, visibility:hidden not honored when hit testing inline replaced elements.

        Reviewed by adele

        Added fast/css/visibility-hit-test.html test case.

        * rendering/RenderBox.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd new layout test for visibility bug.
hyatt@apple.com [Thu, 10 Jan 2008 19:28:14 +0000 (19:28 +0000)]
Add new layout test for visibility bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
mitz@apple.com [Thu, 10 Jan 2008 17:39:03 +0000 (17:39 +0000)]

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16782
          <rdar://problem/5675331> REGRESSION(r29266): Reproducible crash in fast/replaced/image-map.html

        The crash resulted from a native object (DumpRenderTree's
        EventSender) causing its wrapper to be invalidated (by clicking a
        link that replaced the document in the window) and consequently
        deallocated. The fix is to use RefPtrs to protect the native object
        from deletion by self-invalidation.

        * bindings/runtime_method.cpp:
        * bindings/runtime_object.cpp:


        Reviewed by Darin Adler.

        - re-enable crashing test after fixing http://bugs.webkit.org/show_bug.cgi?id=16782
          <rdar://problem/5675331> REGRESSION(r29266): Reproducible crash in fast/replaced/image-map.html

        * fast/replaced/image-map-expected.txt: Updated results for the new
        behavior, which is to replace the document with the success message.
        * fast/replaced/image-map.html: Copied from LayoutTests/fast/replaced/image-map.html-disabled.
        * fast/replaced/image-map.html-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agodocument QWebHistory
hausmann@webkit.org [Thu, 10 Jan 2008 16:47:59 +0000 (16:47 +0000)]
document QWebHistory

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29361 268f45cc-cd09-0410-ab3c-d52691b4dbfc