WebKit-https.git
9 years agoPrettyPatch should handle "delta" patch mechanism in git binary patches
commit-queue@webkit.org [Tue, 6 Sep 2011 07:26:13 +0000 (07:26 +0000)]
PrettyPatch should handle "delta" patch mechanism in git binary patches
https://bugs.webkit.org/show_bug.cgi?id=67628

Git patches are encoded using two mechanisms - "literal" and "delta".
See this email from the git mailing list archive for info
http://marc.info/?l=git&m=114682417113315&w=2

When determining if a binary file patch is an image or not we should accept
both literal and delta patch encodings.

Patch by Ben Wells <benwells@chromium.org> on 2011-09-06
Reviewed by Shinichiro Hamaji.

* PrettyPatch/PrettyPatch.rb:
* PrettyPatch/PrettyPatch_test.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r94545.
philn@webkit.org [Tue, 6 Sep 2011 07:13:28 +0000 (07:13 +0000)]
Unreviewed, GTK rebaseline after r94545.

* platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, fullscreen tests rebaseline after r94545.
philn@webkit.org [Tue, 6 Sep 2011 07:05:10 +0000 (07:05 +0000)]
Unreviewed, fullscreen tests rebaseline after r94545.

* fullscreen/full-screen-cancel-expected.txt:
* fullscreen/full-screen-css-expected.txt:
* fullscreen/full-screen-remove-ancestor-expected.txt:
* fullscreen/full-screen-remove-children-expected.txt:
* fullscreen/full-screen-remove-expected.txt:
* fullscreen/full-screen-twice-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Update expecteds after r94545.
reni@webkit.org [Tue, 6 Sep 2011 06:58:07 +0000 (06:58 +0000)]
[Qt] Update expecteds after r94545.

Unreviewed gardening.

* platform/qt/fast/dom/Window/window-properties-expected.png:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/js/global-constructors-expected.png:
* platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. GTK rebaselines for r94541, r94543.
inferno@chromium.org [Tue, 6 Sep 2011 04:52:25 +0000 (04:52 +0000)]
Unreviewed. GTK rebaselines for r94541, r94543.

* platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.txt:
* platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
* platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
* platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
* platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/gtk/fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
* platform/gtk/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
* platform/gtk/fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
* platform/gtk/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
* platform/gtk/fast/table/table-after-child-in-table-expected.txt:
* platform/gtk/fast/table/table-before-child-in-table-expected.txt:
* platform/gtk/fast/table/table-cell-after-child-in-table-expected.txt:
* platform/gtk/fast/table/table-cell-before-child-in-table-expected.txt:
* platform/gtk/fast/table/table-row-after-child-in-table-expected.txt:
* platform/gtk/fast/table/table-row-before-child-in-table-expected.txt:
* platform/gtk/fast/table/table-row-style-not-updated-expected.txt: Added.
* platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
* platform/gtk/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
* platform/gtk/fast/table/table-style-not-updated-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove unnecessary expectation, results match the fallback path.
jamesr@google.com [Tue, 6 Sep 2011 03:45:15 +0000 (03:45 +0000)]
[chromium] Remove unnecessary expectation, results match the fallback path.

* platform/chromium-cg-mac/fast/dom/wrapper-classes-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Chromium rebaselines for r94541, r94543.
inferno@chromium.org [Tue, 6 Sep 2011 03:06:29 +0000 (03:06 +0000)]
Unreviewed. Chromium rebaselines for r94541, r94543.

* platform/chromium-cg-mac-leopard/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/chromium-cg-mac-leopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/chromium-cg-mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/chromium-cg-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/chromium-cg-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
* platform/chromium-linux/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/chromium-linux/fast/ruby/ruby-block-style-not-updated-expected.png: Added.
* platform/chromium-linux/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
* platform/chromium-linux/fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
* platform/chromium-linux/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-style-not-updated-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
* platform/chromium-linux/fast/table/table-style-not-updated-expected.png: Added.
* platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.txt:
* platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
* platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
* platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
* platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/chromium-win/fast/ruby/ruby-block-style-not-updated-expected.png: Added.
* platform/chromium-win/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
* platform/chromium-win/fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
* platform/chromium-win/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
* platform/chromium-win/fast/table/table-after-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-before-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-row-style-not-updated-expected.png: Added.
* platform/chromium-win/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
* platform/chromium-win/fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
* platform/chromium-win/fast/table/table-style-not-updated-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Qt rebaselines for r94543.
inferno@chromium.org [Tue, 6 Sep 2011 02:38:34 +0000 (02:38 +0000)]
Unreviewed. Qt rebaselines for r94543.

* platform/qt/fast/css-generated-content/table-before-after-child-add-expected.txt:
* platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
* platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
* platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
* platform/qt/fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
* platform/qt/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
* platform/qt/fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
* platform/qt/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
* platform/qt/fast/table/table-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-before-child-in-table-expected.txt:
* platform/qt/fast/table/table-cell-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-cell-before-child-in-table-expected.txt:
* platform/qt/fast/table/table-row-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-row-before-child-in-table-expected.txt:
* platform/qt/fast/table/table-row-style-not-updated-expected.txt: Added.
* platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
* platform/qt/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
* platform/qt/fast/table/table-style-not-updated-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rebaselines for r94541.
inferno@chromium.org [Tue, 6 Sep 2011 02:13:09 +0000 (02:13 +0000)]
Unreviewed. Rebaselines for r94541.

* platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowindow.HTMLSpanElement does not exist
abarth@webkit.org [Tue, 6 Sep 2011 01:52:46 +0000 (01:52 +0000)]
window.HTMLSpanElement does not exist
https://bugs.webkit.org/show_bug.cgi?id=67571

Reviewed by Sam Weinig.

Source/WebCore:

We have these objects for most other elements and HTMLSpanElement
exists in Firefox and in the HTML5 spec.  This patch adds it.

Test: fast/dom/wrapper-classes.html

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLSpanElement.cpp: Added.
(WebCore::HTMLSpanElement::HTMLSpanElement):
(WebCore::HTMLSpanElement::create):
* html/HTMLSpanElement.h: Added.
* html/HTMLSpanElement.idl: Added.
* html/HTMLTagNames.in:
* page/DOMWindow.idl:

LayoutTests:

Update tests to account for HTMLSpanElement existing.  I also took the
liberty of changing fast/tokenizer/external-script-document-write.html
into a text test and cleaning up the platform-specific results.

* editing/selection/extend-after-mouse-selection-expected.txt:
* fast/dom/gc-6-expected.txt:
* fast/dom/gc-7-expected.txt:
* fast/dom/wrapper-classes-expected.txt:
* fast/dom/wrapper-classes.html:
* fast/events/mouseclick-target-and-positioning-expected.txt:
* fast/js/toString-and-valueOf-override-expected.txt:
* fast/tokenizer/external-script-document-write-expected.txt: Added.
* fast/tokenizer/resources/external-script-document-write.js:
* platform/chromium-linux/fast/tokenizer/external-script-document-write-expected.png: Removed.
* platform/chromium-win/fast/tokenizer/external-script-document-write-expected.png: Removed.
* platform/chromium-win/fast/tokenizer/external-script-document-write-expected.txt: Removed.
* platform/gtk/fast/tokenizer/external-script-document-write-expected.png: Removed.
* platform/gtk/fast/tokenizer/external-script-document-write-expected.txt: Removed.
* platform/mac-leopard/fast/tokenizer/external-script-document-write-expected.png: Removed.
* platform/mac/fast/tokenizer/external-script-document-write-expected.png: Removed.
* platform/mac/fast/tokenizer/external-script-document-write-expected.txt: Removed.
* platform/qt/fast/tokenizer/external-script-document-write-expected.png: Removed.
* platform/qt/fast/tokenizer/external-script-document-write-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStyle not propagated to anonymous boxes and anonymous
inferno@chromium.org [Tue, 6 Sep 2011 01:45:39 +0000 (01:45 +0000)]
Style not propagated to anonymous boxes and anonymous
inline-blocks.
https://bugs.webkit.org/show_bug.cgi?id=67364

Reviewed by James Robinson.

Source/WebCore:

Tests: fast/ruby/ruby-block-style-not-updated-with-before-after-content.html
       fast/ruby/ruby-block-style-not-updated.html
       fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html
       fast/ruby/ruby-inline-style-not-updated.html
       fast/table/table-row-style-not-updated-with-after-content.html
       fast/table/table-row-style-not-updated-with-before-content.html
       fast/table/table-row-style-not-updated.html
       fast/table/table-style-not-updated.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren):
* rendering/RenderObject.h:
(WebCore::RenderObject::isBeforeAfterContent):
* rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::styleDidChange):
(WebCore::RenderRubyAsBlock::styleDidChange):
* rendering/RenderRuby.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::styleDidChange):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::styleDidChange):
(WebCore::RenderTableSection::addChild):
* rendering/RenderTableSection.h:

LayoutTests:

None of the different color boxes should overlap. If they overlap, test fails.

* fast/ruby/ruby-block-style-not-updated-expected.png: Added.
* fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
* fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
* fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
* fast/ruby/ruby-block-style-not-updated-with-before-after-content.html: Added.
* fast/ruby/ruby-block-style-not-updated.html: Added.
* fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
* fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
* fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
* fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
* fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html: Added.
* fast/ruby/ruby-inline-style-not-updated.html: Added.
* fast/table/table-row-style-not-updated-expected.png: Added.
* fast/table/table-row-style-not-updated-expected.txt: Added.
* fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
* fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
* fast/table/table-row-style-not-updated-with-after-content.html: Added.
* fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
* fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
* fast/table/table-row-style-not-updated-with-before-content.html: Added.
* fast/table/table-row-style-not-updated.html: Added.
* fast/table/table-style-not-updated-expected.png: Added.
* fast/table/table-style-not-updated-expected.txt: Added.
* fast/table/table-style-not-updated.html: Added.
* platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt:
* platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
* platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
* platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
* platform/mac/fast/table/table-after-child-in-table-expected.txt:
* platform/mac/fast/table/table-before-child-in-table-expected.txt:
* platform/mac/fast/table/table-cell-after-child-in-table-expected.txt:
* platform/mac/fast/table/table-cell-before-child-in-table-expected.txt:
* platform/mac/fast/table/table-row-after-child-in-table-expected.txt:
* platform/mac/fast/table/table-row-before-child-in-table-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in RenderObjectChildList::destroyLeftOverChildren()
inferno@chromium.org [Tue, 6 Sep 2011 01:16:57 +0000 (01:16 +0000)]
Crash in RenderObjectChildList::destroyLeftOverChildren()
https://bugs.webkit.org/show_bug.cgi?id=64753

Reviewed by James Robinson.

Source/WebCore:

If any of the ancestors between column span element and containing
column's block is a continuation, then don't attempt to render the
column span by splitting the block into continuations.

Test: fast/multicol/column-span-parent-continuation-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

anonymous-split-block-crash rendering was already wrong. The fix prevents
the tree to go bad and hence does not do the column-span rendering. same issue
with clone-anonymous-block-non-inline-child-crash test.

* fast/multicol/column-span-parent-continuation-crash-expected.txt: Added.
* fast/multicol/column-span-parent-continuation-crash.html: Added.
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a tab to garden-o-matic for viewing expected failures
abarth@webkit.org [Mon, 5 Sep 2011 23:18:00 +0000 (23:18 +0000)]
Add a tab to garden-o-matic for viewing expected failures
https://bugs.webkit.org/show_bug.cgi?id=67619

Reviewed by Dimitri Glazkov.

This patch adds a basic tab to garden-o-matic that shows all the tests
failing on the bots, including the expected failures.  This patch
mostly involves refactoring existing classes to allow new subclasses.

This view is useful for when gardeners mark tests as expected to fail
and then rebaseline them later.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix global variable leak in garden-o-matic
abarth@webkit.org [Mon, 5 Sep 2011 22:58:10 +0000 (22:58 +0000)]
Fix global variable leak in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=67617

Reviewed by Dimitri Glazkov.

Caught by running the unit tests with noglobals turned on.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94537.
commit-queue@webkit.org [Mon, 5 Sep 2011 21:07:50 +0000 (21:07 +0000)]
Unreviewed, rolling out r94537.
http://trac.webkit.org/changeset/94537
https://bugs.webkit.org/show_bug.cgi?id=67618

Does not compile on Chromium Mac (Requested by abarth_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::preMultipliedBGRAtoRGB):
(WebCore::RGBAtoRGB):
(WebCore::encodePixels):
(WebCore::JPEGImageEncoder::encode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium skia] JPEGImageEncoder: hoist contants out of the encoding loop
noel.gordon@gmail.com [Mon, 5 Sep 2011 19:56:03 +0000 (19:56 +0000)]
[chromium skia] JPEGImageEncoder: hoist contants out of the encoding loop
https://bugs.webkit.org/show_bug.cgi?id=67589

Reviewed by Adam Barth.

Change the row converter function signatures to be the same.  Call them via a function
pointer during the encoding loop.  Minor webkit stlye cleanup, remove unused include.

No new tests.  Covered by existing canvas 2d and 3d tests.
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

* platform/image-encoders/skia/JPEGImageEncoder.cpp:  Remove SkUnPreMultiply.h (not used).
(WebCore::preMultipliedBGRAtoRGB):  Use unsigned char* instead of void* for pixels.
(WebCore::RGBAtoRGB):  pixels & pixelCount to match the preMultipliedBGRAtoRGB() signature.
(WebCore::encodePixels):  Move contants out of the encoding loop: use a function pointer to
call preMultipliedBGRAtoRGB or RGBAtoRGB (now they have identical signatures) during the
image row encoding loop.  Add/use pixelRowStride constant.
(WebCore::JPEGImageEncoder::encode):  webkit style: no need to split lines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTake pageScaleFactor into account for MouseRelatedEvents.
jknotten@chromium.org [Mon, 5 Sep 2011 16:55:52 +0000 (16:55 +0000)]
Take pageScaleFactor into account for MouseRelatedEvents.
https://bugs.webkit.org/show_bug.cgi?id=67592

Source/WebCore:

Reviewed by Dimitri Glazkov.

Test: fast/events/page-scaled-mouse-click.html

* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):

LayoutTests:

Mouse-related events currently take account of the zoom factor, but they
also need to take account of the page scale factor so that pageX and pageY
event coordinates are properly determined.

Reviewed by Dimitri Glazkov.

* fast/events/page-scaled-mouse-click-expected.txt: Added.
* fast/events/page-scaled-mouse-click.html: Added.
* fast/events/script-tests/page-scaled-mouse-click.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoD'oh! Missed the name of the test in the previous gardening.
kbalazs@webkit.org [Mon, 5 Sep 2011 16:51:29 +0000 (16:51 +0000)]
D'oh! Missed the name of the test in the previous gardening.
Unreviewed regardening.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] fast/inline/absolute-positioned-inline-in-centred-block.html is flaky
kbalazs@webkit.org [Mon, 5 Sep 2011 16:47:30 +0000 (16:47 +0000)]
[Qt][WK2] fast/inline/absolute-positioned-inline-in-centred-block.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=67607

Unreviewed gardening.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening - move expectation to the correct place.
kbalazs@webkit.org [Mon, 5 Sep 2011 15:42:44 +0000 (15:42 +0000)]
[Qt] Unreviewed gardening - move expectation to the correct place.

* platform/qt/fast/borders/border-image-repeat-expected.txt: Renamed from LayoutTests/platform/qt/border-image-repeat-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: rename RawSourceCode.reload to contentEdited.
podivilov@chromium.org [Mon, 5 Sep 2011 15:35:05 +0000 (15:35 +0000)]
Web Inspector: rename RawSourceCode.reload to contentEdited.
https://bugs.webkit.org/show_bug.cgi?id=67504

Make RawSourceCode.reload private and remove RawSourceCode.content getter and setter
(RawSourceCode isn't supposed to have any content).

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._reload):
(WebInspector.RawSourceCode.prototype._didRequestContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the regression of bug 65333 introduced by 60170.
leandrogracia@chromium.org [Mon, 5 Sep 2011 15:01:59 +0000 (15:01 +0000)]
Fix the regression of bug 65333 introduced by 60170.
This caused the speech input bubble to appear in the wrong side for RTL text inputs.
https://bugs.webkit.org/show_bug.cgi?id=67597

Reviewed by Tony Gentilcore.

No new tests. Fixing regression.

* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: cleanup scripts-panel.html test.
podivilov@chromium.org [Mon, 5 Sep 2011 14:46:03 +0000 (14:46 +0000)]
Web Inspector: cleanup scripts-panel.html test.
https://bugs.webkit.org/show_bug.cgi?id=67497

ScriptsPanel test should not depend on presentation model internals.

Reviewed by Yury Semikhatsky.

* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: F5 results in a Web Inspector frontend reload on non-Macs
apavlov@chromium.org [Mon, 5 Sep 2011 14:40:00 +0000 (14:40 +0000)]
Web Inspector: F5 results in a Web Inspector frontend reload on non-Macs
https://bugs.webkit.org/show_bug.cgi?id=67602

Reviewed by Yury Semikhatsky.

* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
kbalazs@webkit.org [Mon, 5 Sep 2011 14:20:10 +0000 (14:20 +0000)]
[Qt] Unreviewed gardening.

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-05

* platform/qt/border-image-repeat-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94525.
loislo@chromium.org [Mon, 5 Sep 2011 12:57:50 +0000 (12:57 +0000)]
Unreviewed, rolling out r94525.
http://trac.webkit.org/changeset/94525
https://bugs.webkit.org/show_bug.cgi?id=67599

WinCE compilation failed. (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

* platform/text/TextBoundaries.cpp:
* platform/text/TextBreakIteratorICU.cpp:
* platform/text/qt/TextBoundariesQt.cpp:
* platform/text/qt/TextBreakIteratorQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-05 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Mon, 5 Sep 2011 12:55:38 +0000 (12:55 +0000)]
2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>

        [Qt] Update expectations.

        Unreviewed gardening.

        * platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
        * platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
        * platform/qt/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
        * platform/qt/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
        * platform/qt/fast/dom/Window/window-properties-expected.png:
        * platform/qt/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
        * platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/qt/fast/js/global-constructors-expected.png:
        * platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Compiling using system ICU uses QTextBreakIterator in some cases.
commit-queue@webkit.org [Mon, 5 Sep 2011 12:08:12 +0000 (12:08 +0000)]
[Qt] Compiling using system ICU uses QTextBreakIterator in some cases.
https://bugs.webkit.org/show_bug.cgi?id=67391

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-09-05
Reviewed by Kenneth Rohde Christiansen.

* platform/text/TextBoundaries.cpp:
* platform/text/TextBreakIteratorICU.cpp:
* platform/text/qt/TextBoundariesQt.cpp:
* platform/text/qt/TextBreakIteratorQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Add pixel test support
kbalazs@webkit.org [Mon, 5 Sep 2011 10:53:32 +0000 (10:53 +0000)]
[Qt][WK2] Add pixel test support
https://bugs.webkit.org/show_bug.cgi?id=66283

Reviewed by Andreas Kling.

Source/WebKit2:

* Shared/API/c/qt/WKImageQt.cpp: Added.
(WKImageCreateQImage):  C style (private) API to get the contents of the backing
store as an image.
* Shared/API/c/qt/WKImageQt.h: Added.
* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createImage): Typo. Remove useless ifdef.
* WebKit2API.pri:

Tools:

Implemented pixel result generation by reusing the logic
that we have in DumpRenderTree.
* WebKitTestRunner/qt/TestInvocationQt.cpp:
(WTR::dumpImage):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Update expected result after r94425
zoltan@webkit.org [Mon, 5 Sep 2011 10:50:51 +0000 (10:50 +0000)]
[Qt] Update expected result after r94425
https://bugs.webkit.org/show_bug.cgi?id=66467

Patch by Kristof Kosztyo <kkristof@inf.u-szeged.hu> on 2011-09-05

* platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
* platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94445 and r94448.
commit-queue@webkit.org [Mon, 5 Sep 2011 10:43:34 +0000 (10:43 +0000)]
Unreviewed, rolling out r94445 and r94448.
http://trac.webkit.org/changeset/94445
http://trac.webkit.org/changeset/94448
https://bugs.webkit.org/show_bug.cgi?id=67595

It broke everything (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* heap/Heap.cpp:
(JSC::Heap::collect):
* heap/Heap.h:
* heap/NewSpace.cpp:
(JSC::NewSpace::NewSpace):
* heap/NewSpace.h:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::allocatePropertyStorage):
* runtime/JSObject.h:
(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 5 Sep 2011 10:22:11 +0000 (10:22 +0000)]
2011-09-05  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed update expected image for chromium MAC.
        The test was introduced at r94492.

        * platform/chromium-cg-mac-leopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
        * platform/chromium-cg-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix for r94452.
paroga@webkit.org [Mon, 5 Sep 2011 09:41:26 +0000 (09:41 +0000)]
Unreviewed build fix for r94452.

Add config.h as the first header to the cc files as required by the coding style.
Reuse macros from Assertions.h instead of adding addional #ifdefs.

* wtf/dtoa/bignum-dtoa.cc:
* wtf/dtoa/bignum.cc:
* wtf/dtoa/cached-powers.cc:
* wtf/dtoa/diy-fp.cc:
* wtf/dtoa/double-conversion.cc:
* wtf/dtoa/fast-dtoa.cc:
* wtf/dtoa/fixed-dtoa.cc:
* wtf/dtoa/strtod.cc:
* wtf/dtoa/utils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Fix the build
abecsi@webkit.org [Mon, 5 Sep 2011 08:49:57 +0000 (08:49 +0000)]
[Qt][WK2] Fix the build

Rubber-stamped by Csaba Osztrogonác.

Source/JavaScriptCore:

* wtf/dtoa/double-conversion.cc: Remove dead variable in file added in r94452.
The variable fractional_part is only set but never used.

Source/WebKit2:

* DerivedSources.pro: Add missing PluginProcessConnection.messages.in after r94456.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 5 Sep 2011 08:36:25 +0000 (08:36 +0000)]
2011-09-05  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed update expected image for chromium Linux.
        The test was introduced at r94492.

        * platform/chromium-linux/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 5 Sep 2011 07:52:17 +0000 (07:52 +0000)]
2011-09-05  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed rebaseline for chromium: fast/repaint/block-layout-inline-children-float-positioned.html

        * platform/chromium-cg-mac-leopard/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
        * platform/chromium-cg-mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
        * platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Removed.
        * platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLogic from HTMLElement::deprecatedCreateContextualFragment moved into
commit-queue@webkit.org [Mon, 5 Sep 2011 07:46:55 +0000 (07:46 +0000)]
Logic from HTMLElement::deprecatedCreateContextualFragment moved into
Range::createContextualFragment function.
https://bugs.webkit.org/show_bug.cgi?id=67056

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-09-05
Reviewed by Ryosuke Niwa.

Code Refactoring for deprecatedCreateContextualFragment.

Source/WebCore:

No new tests. Code Re-factoring.

* dom/Element.cpp:
* dom/Element.h:
* dom/Range.cpp:
(WebCore::insertIntoFragment):
(WebCore::Range::createDocumentFragmentForElement):
(WebCore::Range::createContextualFragment):
* dom/Range.h:
* editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
* html/HTMLElement.cpp:
* html/HTMLElement.h:

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::appendInside):
(QWebElement::prependInside):
(QWebElement::prependOutside):
(QWebElement::appendOutside):
(QWebElement::encloseContentsWith):
(QWebElement::encloseWith):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 5 Sep 2011 07:38:20 +0000 (07:38 +0000)]
2011-09-05  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed rebaseline for fast/inline/absolute-positioned-inline-in-centred-block

        * platform/chromium-cg-mac-leopard/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/chromium-cg-mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
        * platform/chromium-cg-mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/chromium-linux-x86/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/chromium-linux/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/chromium-win-vista/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/chromium-win-xp/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
        * platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r94452): 20 http/tests tests failing on Qt Linux Release
commit-queue@webkit.org [Mon, 5 Sep 2011 06:48:18 +0000 (06:48 +0000)]
REGRESSION (r94452): 20 http/tests tests failing on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=67562

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-04
Reviewed by Darin Adler.

Fixing the build (again which was broken by the dtoa patch.  Needed
to make sure WTF::double_conversion::initialize() is called for Qt
as well as adding a check for WinCE in dtoa/utils.h

* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* wtf/dtoa/cached-powers.cc:
* wtf/dtoa/utils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94510.
koz@chromium.org [Mon, 5 Sep 2011 06:43:32 +0000 (06:43 +0000)]
Unreviewed, rolling out r94510.
http://trac.webkit.org/changeset/94510
https://bugs.webkit.org/show_bug.cgi?id=66531

Causes layout test crashes.

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
* dom/NodeRenderingContext.cpp:
(WebCore::wrapWithRenderFullScreen):
(WebCore::NodeRendererFactory::createRendererIfNeeded):
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::createFullScreenStyle):
* rendering/RenderFullScreen.h:

LayoutTests:

* plugins/fullscreen-plugins-dont-reload-expected.txt: Removed.
* plugins/fullscreen-plugins-dont-reload.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Compile fix for r94511.
inferno@chromium.org [Mon, 5 Sep 2011 05:59:03 +0000 (05:59 +0000)]
Unreviewed. Compile fix for r94511.

* dom/Range.cpp:
(WebCore::Range::processContents):
(WebCore::Range::processAncestorsAndTheirSiblings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in Range::processAncestorsAndTheirSiblings.
inferno@chromium.org [Mon, 5 Sep 2011 05:22:36 +0000 (05:22 +0000)]
Crash in Range::processAncestorsAndTheirSiblings.
https://bugs.webkit.org/show_bug.cgi?id=67556

Reviewed by Ryosuke Niwa.

Source/WebCore:

Create a temporary RefPtr Node vector to keep all the ancestor's
childs so that we don't access removed child nodes.

Test: fast/dom/Range/range-delete-contents-event-fire-crash.html

* dom/Range.cpp:
(WebCore::Range::processContents):
(WebCore::Range::processAncestorsAndTheirSiblings):

LayoutTests:

Tests that we do not crash when removing contents of
a range from the document.

* fast/dom/Range/range-delete-contents-event-fire-crash-expected.txt: Added.
* fast/dom/Range/range-delete-contents-event-fire-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't detach elements from the render tree when entering fullscreen mode
commit-queue@webkit.org [Mon, 5 Sep 2011 04:46:22 +0000 (04:46 +0000)]
Don't detach elements from the render tree when entering fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=66531

Source/WebCore:

This prevents plugin instances from being destroyed and reinstantiated
when entering fullscreen mode.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-04
Reviewed by Darin Fisher.

Test: plugins/fullscreen-plugins-dont-reload.html

* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRendererFactory::createRendererIfNeeded):
* rendering/RenderFullScreen.cpp:
(createFullScreenStyle):
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
* rendering/RenderFullScreen.h:

LayoutTests:

Test that the plugin is not reloaded when entering fullscreen.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-04
Reviewed by Darin Fisher.

* plugins/fullscreen-plugins-dont-reload-expected.txt: Added.
* plugins/fullscreen-plugins-dont-reload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Rename ewk_view_(single|tiled).c to ewk_view_(single|tiled).cpp
ryuan.choi@samsung.com [Mon, 5 Sep 2011 04:18:04 +0000 (04:18 +0000)]
[EFL] Rename ewk_view_(single|tiled).c to ewk_view_(single|tiled).cpp
https://bugs.webkit.org/show_bug.cgi?id=66542

Use a C++ compiler for these files, so that they can include the C++-using
ewk_private.h.

Reviewed by Daniel Bates.

* CMakeListsEfl.txt:
* ewk/ewk_view_single.cpp: Renamed from Source/WebKit/efl/ewk/ewk_view_single.c.
(_ewk_view_single_on_del):
(_ewk_view_single_smart_add):
(_ewk_view_single_smart_backing_store_add):
(_ewk_view_single_smart_resize):
(_ewk_view_4b_move_region_up):
(_ewk_view_4b_move_region_down):
(_ewk_view_4b_move_line_left):
(_ewk_view_4b_move_line_right):
(_ewk_view_4b_move_region_left):
(_ewk_view_4b_move_region_right):
(_ewk_view_4b_move_region):
(_ewk_view_single_scroll_process_single):
(_ewk_view_single_smart_scrolls_process):
(_ewk_view_single_smart_repaints_process):
(_ewk_view_single_smart_zoom_weak_set):
(_ewk_view_single_smart_zoom_weak_smooth_scale_set):
(_ewk_view_single_smart_bg_color_set):
(ewk_view_single_smart_set):
(_ewk_view_single_smart_class_new):
(ewk_view_single_add):
* ewk/ewk_view_tiled.cpp: Renamed from Source/WebKit/efl/ewk/ewk_view_tiled.c.
(_ewk_view_tiled_render_cb):
(_ewk_view_tiled_updates_process_pre):
(_ewk_view_tiled_smart_backing_store_add):
(_ewk_view_tiled_contents_size_changed_cb):
(_ewk_view_tiled_smart_add):
(_ewk_view_tiled_smart_scrolls_process):
(_ewk_view_tiled_smart_repaints_process):
(_ewk_view_tiled_smart_contents_resize):
(_ewk_view_tiled_smart_zoom_set):
(_ewk_view_tiled_smart_zoom_weak_set):
(_ewk_view_tiled_smart_zoom_weak_smooth_scale_set):
(_ewk_view_tiled_smart_flush):
(_ewk_view_tiled_smart_pre_render_region):
(_ewk_view_tiled_smart_pre_render_relative_radius):
(_ewk_view_tiled_smart_pre_render_cancel):
(_ewk_view_tiled_smart_disable_render):
(_ewk_view_tiled_smart_enable_render):
(ewk_view_tiled_smart_set):
(_ewk_view_tiled_smart_class_new):
(ewk_view_tiled_add):
(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10071256> Retain retired custom fonts until the next style recalc
mitz@apple.com [Mon, 5 Sep 2011 00:01:40 +0000 (00:01 +0000)]
<rdar://problem/10071256> Retain retired custom fonts until the next style recalc

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-used-after-retired.html

During style recalc, existing renderers may reference their old style, including font data.
Allow them to do so safely by keeping retired custom font data around until after style recalc.

* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::retireCustomFont): Added. Calls through to CSSFontSelector, if the font
face is still part of any segmented font face. Otherwise, deletes the custom font data.
* css/CSSFontFace.h:
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::pruneTable): Changed to call retireCustomFont() instead of deleting
retired font data.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::retireCustomFont): Added. Calls through to the Document, if this is
still the active font selector for a document. Otherwise, deletes the custom font data.
* css/CSSFontSelector.h:
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::pruneTable): Changed to call retireCustomFont() instead of
deleting retired font data.
* dom/Document.cpp:
(WebCore::Document::~Document): Added a call to deleteRetiredCustomFonts(), in case the Document
is destroyed before getting a chance to recalc style after custom fonts have been retired.
(WebCore::Document::recalcStyle): Added a call to deleteRetiredCustomFonts() after style recalc.
(WebCore::Document::deleteRetiredCustomFonts): Added. Deletes all previously-retired custom font
data.
* dom/Document.h:
(WebCore::Document::retireCustomFont): Added.

LayoutTests:

* fast/css/font-face-used-after-retired-expected.txt: Added.
* fast/css/font-face-used-after-retired.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add mutliple to WebPopupMenuInfo for Android
abarth@webkit.org [Sun, 4 Sep 2011 21:24:22 +0000 (21:24 +0000)]
[Chromium] Add mutliple to WebPopupMenuInfo for Android
https://bugs.webkit.org/show_bug.cgi?id=67576

Reviewed by Darin Fisher.

This flag requests that the embedder allow multiple selection for the
popup menu.  (See also https://bugs.webkit.org/show_bug.cgi?id=67574.)

* public/WebPopupMenuInfo.h:
* src/ExternalPopupMenu.cpp:
(WebKit::ExternalPopupMenu::getPopupMenuInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoForgot to check in new results for fast/events/event-creation.html
weinig@apple.com [Sun, 4 Sep 2011 21:19:40 +0000 (21:19 +0000)]
Forgot to check in new results for fast/events/event-creation.html

* fast/events/event-creation-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDocument.createEvent should support all the interfaces of Event we got
weinig@apple.com [Sun, 4 Sep 2011 21:04:14 +0000 (21:04 +0000)]
Document.createEvent should support all the interfaces of Event we got
https://bugs.webkit.org/show_bug.cgi?id=67568

Reviewed by Anders Carlsson.

Source/WebCore:

Updated fast/events/event-creation.html

* dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):
Added empty create.

* dom/Document.cpp:
(WebCore::Document::createEvent):
Add missing interfaces.

* dom/HashChangeEvent.h:
(WebCore::HashChangeEvent::create):
(WebCore::HashChangeEvent::HashChangeEvent):
Added empty create.

* page/SpeechInputEvent.cpp:
(WebCore::SpeechInputEvent::create):
(WebCore::SpeechInputEvent::SpeechInputEvent):
(WebCore::SpeechInputEvent::~SpeechInputEvent):
* page/SpeechInputEvent.h:
Added empty create.

LayoutTests:

* fast/events/event-creation.html:
Converted to shouldBe style test, changed prototype check to us instanceof and constructor check,
added enumeration based catchall.

* fast/events/event-instanceof-expected.txt: Removed.
* fast/events/event-instanceof.html: Removed.
* fast/events/script-tests/event-instanceof.js: Removed.
Moved contents to fast/events/event-creation.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add memory threshold values to WebKitPlatformSupport.h
abarth@webkit.org [Sun, 4 Sep 2011 18:10:26 +0000 (18:10 +0000)]
[Chromium] Add memory threshold values to WebKitPlatformSupport.h
https://bugs.webkit.org/show_bug.cgi?id=67575

Reviewed by Darin Fisher.

Source/WebCore:

Grab these memory thresholds from PlatformSupport rather than hard-coding them.

* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
* platform/chromium/PlatformSupport.h:
* platform/qt/PlatformSupport.h:
(WebCore::PlatformSupport::lowMemoryUsageMB):
(WebCore::PlatformSupport::highMemoryUsageMB):
(WebCore::PlatformSupport::highUsageDeltaMB):

Source/WebKit/chromium:

Instead of hard-coding these values, we now grab them from
WebKitPlatformSupport because Android wishes to configure them on a
per-device basis.

One could view grabing these values from PlatformSupport as a bit of a
layering violation (because they feel like policy), but another view is
that the alternative implementation is to query the OS for various
memory parameters.  In either case, getting these values via
PlatformSupport is much easier and consistent with the other memory
related queries in PlatformSupport already.

* public/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::lowMemoryUsageMB):
(WebKit::WebKitPlatformSupport::highMemoryUsageMB):
(WebKit::WebKitPlatformSupport::highUsageDeltaMB):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::lowMemoryUsageMB):
(WebCore::PlatformSupport::highMemoryUsageMB):
(WebCore::PlatformSupport::highUsageDeltaMB):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-04 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sun, 4 Sep 2011 18:04:45 +0000 (18:04 +0000)]
2011-09-04  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed fix for chromium expectations.
        The expectations for http/tests/security/xssAuditor/dom-write-innerHTML.html
        were in conflict. The first was for LINUX the second was for DEBUG. I just added RELEASE flag for LINUX one.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Add new / moved files missing from last commit.
kevino@webkit.org [Sun, 4 Sep 2011 17:51:35 +0000 (17:51 +0000)]
[wx] Unreviewed build fix. Add new / moved files missing from last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than...
kevino@webkit.org [Sun, 4 Sep 2011 16:49:10 +0000 (16:49 +0000)]
[wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
https://bugs.webkit.org/show_bug.cgi?id=67577

Reviewed by Kevin Ollivier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThunkGenerators does not convert positive double zero into integer zero
fpizlo@apple.com [Sun, 4 Sep 2011 05:43:47 +0000 (05:43 +0000)]
ThunkGenerators does not convert positive double zero into integer zero
https://bugs.webkit.org/show_bug.cgi?id=67553

Reviewed by Gavin Barraclough.

This is an 0.5% speed-up on V8 and neutral elsewhere.

* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r86268): Fix for qt_networkAccessAllowed()
laszlo.1.gombos@nokia.com [Sun, 4 Sep 2011 02:58:46 +0000 (02:58 +0000)]
REGRESSION (r86268): Fix for qt_networkAccessAllowed()
https://bugs.webkit.org/show_bug.cgi?id=67570

Reviewed by Noam Rosenthal.

Source/WebCore:

No new tests as this change only removes dead code.
Support for Qt 4.6 has  been removed a while back.

* WebCore.pri:
* WebCore.pro:
* features.pri:
* platform/network/NetworkStateNotifier.h:
* platform/network/qt/NetworkStateNotifierQt.cpp:

Source/WebKit/qt:

Replace the ENABLE(QT_BEARER) guard with
!defined(QT_NO_BEARERMANAGEMENT) which is true by
default in Qt 4.7 or later versions.

* Api/qwebsettings.cpp:
(qt_networkAccessAllowed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the corresponding entry from the skipped list.
rniwa@webkit.org [Sat, 3 Sep 2011 23:31:58 +0000 (23:31 +0000)]
Remove the corresponding entry from the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r94274): selection-change-closes-typing.html fails
rniwa@webkit.org [Sat, 3 Sep 2011 23:30:08 +0000 (23:30 +0000)]
REGRESSION(r94274): selection-change-closes-typing.html fails
https://bugs.webkit.org/show_bug.cgi?id=67377

Reviewed by Kent Tamura.

Source/WebCore:

The problem was that when the shadow DOM is updated by setInnerTextValue, WebKit layer detects the selection
change and calls confirmCompositionWithoutDisturbingSelection, which in turn modifies the shadow DOM by
inserting text.

Fixed the bug by not inserting text in confirmCompositionWithoutDisturbingSelection. It turned out that this
function is only used to cancel composition but never to confirming composition and restoring selection.

Test: platform/mac/editing/input/selection-change-closes-typing-2.html

* editing/Editor.cpp:
(WebCore::Editor::confirmCompositionWithoutDisturbingSelection):
(WebCore::Editor::confirmComposition):

LayoutTests:

Add a regression test to ensure the same bug doesn't exist in textarea element.

* platform/mac/editing/input/selection-change-closes-typing-2-expected.txt: Copied from
LayoutTests/platform/mac/editing/input/selection-change-closes-typing-expected.txt.
* platform/mac/editing/input/selection-change-closes-typing-2.html: Copied from
LayoutTests/platform/mac/editing/input/selection-change-closes-typing.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTest that document.all.tags() matches IE behavior with too few arguments
commit-queue@webkit.org [Sat, 3 Sep 2011 22:43:00 +0000 (22:43 +0000)]
Test that document.all.tags() matches IE behavior with too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66535

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-09-03
Reviewed by Darin Adler.

* fast/dom/document-all-tags-expected.txt: Added.
* fast/dom/document-all-tags.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd platform-specific results for r94492
robert@webkit.org [Sat, 3 Sep 2011 21:00:17 +0000 (21:00 +0000)]
Add platform-specific results for r94492

Unreviewed.

* platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
* platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
* platform/gtk/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
* platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
* platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
* platform/mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
* platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Add wtf/dtoa directory to build.
kevino@webkit.org [Sat, 3 Sep 2011 20:08:17 +0000 (20:08 +0000)]
[wx] Unreviewed build fix. Add wtf/dtoa directory to build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd missing Event constructors to DOMWindow.idl
weinig@apple.com [Sat, 3 Sep 2011 19:26:54 +0000 (19:26 +0000)]
Add missing Event constructors to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=67449

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by existing tests.

* page/DOMWindow.idl:

LayoutTests:

* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:
Update results for new constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agodiv align="center" rendering problem
robert@webkit.org [Sat, 3 Sep 2011 18:28:57 +0000 (18:28 +0000)]
div align="center" rendering problem
https://bugs.webkit.org/show_bug.cgi?id=4860

Reviewed by David Hyatt.

Source/WebCore:

When an inline element with absolute position was the sole or first child of a render block with
centred alignment, it wasn't obeying its parent's alignment. However it would obey the
alignment if it was preceded by some text. The problem was that the element's render object
was getting skipped as leading white space, so it was not included in a normal line block in
a bidi run. Instead, its position was getting set by RenderBlockLineLayout::setStaticPositions()
which does not pay attention to alignment. Preceding the element with some text allowed the object
to get included in a Bidi run and so get a linebox which would get properly aligned.

The fix is to get RenderBlockLineLayout::setStaticPositions() to obey the alignment specified by
the object's container. This allows WebKit to get the same result on the test as Firefox and IE.
Opera has the same bug as unpatched WebKit.

Tests: fast/css/bug4860-absolute-block-child-does-not-inherit-alignment.html
       - Ensure positioned block elements inherit alignment.
       fast/css/bug4860-absolute-inline-child-inherits-alignment.html
       - Ensure positioned inline elements inherit alignment.
       fast/inline/absolute-positioned-inline-in-centred-block.html
       - Ensure positioned inline element that's the sole or first child of a rendered block
         obeys parents alignment.
       fast/inline/absolute-positioned-block-in-centred-block.html
       - As above, but a positioned block should not inherit alignment.

* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine and use startAlignedOffsetForBlock
(WebCore::RenderBlock::startAlignedOffsetForLine): New function, find the aligned offset using updateLogicalWidthForAlignment

LayoutTests:

* fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.png: Added.
* fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Added.
* fast/css/bug4860-absolute-block-child-does-not-inherit-alignment.html: Added.
* fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
* fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
* fast/css/bug4860-absolute-inline-child-inherits-alignment.html: Added.
* fast/inline/absolute-positioned-block-in-centred-block-expected.png: Added.
* fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Added.
* fast/inline/absolute-positioned-block-in-centred-block.html: Added.
* fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
* fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
* fast/inline/absolute-positioned-inline-in-centred-block.html: Added.
* platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
* platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  Both of these two tests were based on the incorrect behaviour of ignoring the alignment specified
  by the container of an element absolute position when there was no text preceding the element.
  The updated results agree with Firefox and IE.
* fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
* platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  This test expected the wrong alignment of the red block - it should be centred, not aligned to the left.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove two unused functions from Element.
andreas.kling@nokia.com [Sat, 3 Sep 2011 18:18:04 +0000 (18:18 +0000)]
Remove two unused functions from Element.
https://bugs.webkit.org/show_bug.cgi?id=67492

Reviewed by Benjamin Poulain.

Removed openTagStartToString() and setCStringAttribute() as they are
not called from anywhere.

* dom/Element.cpp:
* dom/Element.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago32-bit build fix.
mitz@apple.com [Sat, 3 Sep 2011 17:13:58 +0000 (17:13 +0000)]
32-bit build fix.

* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::toSTD):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Enable support for WebGL OES_standard_derivatives for Qt
commit-queue@webkit.org [Sat, 3 Sep 2011 16:13:57 +0000 (16:13 +0000)]
[Qt] Enable support for WebGL OES_standard_derivatives for Qt
https://bugs.webkit.org/show_bug.cgi?id=67430

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-09-03
Reviewed by Noam Rosenthal.

Tested using https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/extensions/oes-standard-derivatives.html

Enable existing support for OES_standard_derivatives for Qt.

* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
mitz@apple.com [Sat, 3 Sep 2011 15:57:04 +0000 (15:57 +0000)]
Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=67559

Reviewed by Darin Adler.

* DumpRenderTree/mac/DumpRenderTree.mm:
(dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
the call to it.
* TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
* TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
(TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::toSTD): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic results view should have a better results selector
abarth@webkit.org [Sat, 3 Sep 2011 08:29:32 +0000 (08:29 +0000)]
garden-o-matic results view should have a better results selector
https://bugs.webkit.org/show_bug.cgi?id=67542

Reviewed by Dimitri Glazkov.

This patch adds a basic grid-based results selector to the results
view.  Currently, this grid just shows how the tests fail on the
various bots.  A future patch will let you select which failure to view
and to mark the failures for rebaselining.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  - Add some more basic functions for manipulating dictionaries.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic results view should show Actual and Expected results for text failures
abarth@webkit.org [Sat, 3 Sep 2011 08:27:38 +0000 (08:27 +0000)]
garden-o-matic results view should show Actual and Expected results for text failures
https://bugs.webkit.org/show_bug.cgi?id=67536

Reviewed by Eric Seidel.

In the past, we didn't show actual and expected text results (we just
showed the diff) because we didn't have the awesome six-by-two results
grid.  Now that we do, we can move show these results.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  - Fixed some typos that were preventing these unit tests from running.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
  - Report -actual.txt and -expected.txt as possible results URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic shows "ghost" failures that are already fixed
abarth@webkit.org [Sat, 3 Sep 2011 08:25:33 +0000 (08:25 +0000)]
garden-o-matic shows "ghost" failures that are already fixed
https://bugs.webkit.org/show_bug.cgi?id=67535

Reviewed by Eric Seidel.

About 10% of writes fail to stick on test-results.appspot.com.  This
patch causes us to fetch the full_results.json blob directly from
build.chromium.org rather than relying upon AppEngine.

Unforuntately, we still need to get historical information from
AppEngine.  That will take several patches to fix becuase I need to
change the bots to write the full_results.json file to the
build-specific directory in addition to the zip file.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG variable predictions only work for local variables, not temporaries
fpizlo@apple.com [Sat, 3 Sep 2011 07:49:15 +0000 (07:49 +0000)]
DFG variable predictions only work for local variables, not temporaries
https://bugs.webkit.org/show_bug.cgi?id=67554

Reviewed by Gavin Barraclough.

This appears to be a slight speed-up in Kraken (0.3% but significant)
and neutral elsewhere.

* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94458.
rniwa@webkit.org [Sat, 3 Sep 2011 07:45:30 +0000 (07:45 +0000)]
Unreviewed, rolling out r94458.
http://trac.webkit.org/changeset/94458
https://bugs.webkit.org/show_bug.cgi?id=67558

Caused appcache test to fail on various bots (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-03

* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebSocket: Send ArrayBuffer as WebSocket binary message
yutak@chromium.org [Sat, 3 Sep 2011 07:45:22 +0000 (07:45 +0000)]
WebSocket: Send ArrayBuffer as WebSocket binary message
https://bugs.webkit.org/show_bug.cgi?id=67477

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/send-arraybuffer.html
       http/tests/websocket/tests/hybi/workers/send-arraybuffer.html
       http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::send):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback):
* websockets/ThreadableWebSocketChannel.h:
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::sendRequestResult):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSendRequestResult):
* websockets/ThreadableWebSocketChannelClientWrapper.h:
Rename "sent" to "sendRequestResult" to clarify the meaning. Messages from the script may not
be sent immediately, thus the return value of WebSocketChannel::send() indicates whether the
message has been queued successfully, rather than whether the message has been sent or not.
* websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
Case of sending "[object ArrayBuffer]" is covered by an existing test
http/tests/websocket/tests/{hybi,hixie76}/send-object.html.
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::workerContextDidSend):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendArrayBuffer):
Construct an ArrayBuffer from the data on Vector<char>.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
Copy the content into temporary buffer of Vector<char>, and send it to the main thread.
* websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

* http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
* http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
Add tests to send ArrayBuffers.
* http/tests/websocket/tests/hybi/check-binary-messages_wsh.py:
Renamed from LayoutTests/http/tests/websocket/tests/hybi/send-blob_wsh.py, because this handler
is used from send-blob.html and send-arraybuffer.html.
* http/tests/websocket/tests/hybi/send-arraybuffer-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-arraybuffer.html:
Added. Send three small binary messages as ArrayBuffers.
* http/tests/websocket/tests/hybi/send-blob.html:
* http/tests/websocket/tests/hybi/workers/resources/check-binary-messages_wsh.py:
Renamed from LayoutTests/http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py.
* http/tests/websocket/tests/hybi/workers/resources/send-arraybuffer.js:
Added. Same as send-arraybuffer.html, except that this test is run on the worker.
* http/tests/websocket/tests/hybi/workers/resources/send-blob.js:
Removed the definition of unnecessary function startsWith().
* http/tests/websocket/tests/hybi/workers/send-arraybuffer-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/send-arraybuffer.html: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94453.
rniwa@webkit.org [Sat, 3 Sep 2011 07:29:34 +0000 (07:29 +0000)]
Unreviewed, rolling out r94453.
http://trac.webkit.org/changeset/94453
https://bugs.webkit.org/show_bug.cgi?id=67557

Caused appcache test to fail on various bots (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-03

* Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement a CustomEvent constructor for V8
commit-queue@webkit.org [Sat, 3 Sep 2011 06:04:21 +0000 (06:04 +0000)]
Implement a CustomEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67527

Patch by Kentaro Hara <haraken@google.com> on 2011-09-02
Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/events/constructors/custom-event-constructor.html

* bindings/v8/OptionsObject.h:
(WebCore::OptionsObject::getKeyValue): Returns ScriptValue corresponding to a given key.
* bindings/v8/custom/V8EventConstructors.cpp: Added the CustomEvent constructor.
* dom/CustomEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

* platform/chromium/fast/events/constructors/custom-event-constructor-expected.txt: Updated the result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove WebKitClient.h
abarth@webkit.org [Sat, 3 Sep 2011 05:45:08 +0000 (05:45 +0000)]
Remove WebKitClient.h
https://bugs.webkit.org/show_bug.cgi?id=67539

Reviewed by Sam Weinig.

This API no longer has any callers.

* WebKit.gyp:
* public/WebKit.h:
* public/WebKitClient.h: Removed.
* src/WebKit.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT speculation failure does recovery of additions in reverse and
fpizlo@apple.com [Sat, 3 Sep 2011 05:23:35 +0000 (05:23 +0000)]
DFG JIT speculation failure does recovery of additions in reverse and
doesn't rebox
https://bugs.webkit.org/show_bug.cgi?id=67551

Reviewed by Sam Weinig.

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoValueProfile does not make it safe to introspect cell values
fpizlo@apple.com [Sat, 3 Sep 2011 05:14:04 +0000 (05:14 +0000)]
ValueProfile does not make it safe to introspect cell values
after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=67354

Reviewed by Gavin Barraclough.

ValueProfile buckets are now weak references, implemented using a
light-weight weak reference mechanism that this patch also adds (the
WeakReferenceHarvester).  If a cell stored in a ValueProfile bucket
is not marked, then the bucket is transformed into a Structure
pointer.  If the Structure is not marked either, then it is turned
into a ClassInfo pointer.

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::visitWeakReferences):
* bytecode/CodeBlock.h:
* bytecode/ValueProfile.h:
(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::numberOfArrays):
(JSC::ValueProfile::probabilityOfArray):
(JSC::ValueProfile::WeakBucket::WeakBucket):
(JSC::ValueProfile::WeakBucket::operator!):
(JSC::ValueProfile::WeakBucket::isEmpty):
(JSC::ValueProfile::WeakBucket::isClassInfo):
(JSC::ValueProfile::WeakBucket::isStructure):
(JSC::ValueProfile::WeakBucket::asStructure):
(JSC::ValueProfile::WeakBucket::asClassInfo):
(JSC::ValueProfile::WeakBucket::getClassInfo):
* heap/Heap.cpp:
(JSC::Heap::harvestWeakReferences):
(JSC::Heap::markRoots):
* heap/Heap.h:
* heap/MarkStack.cpp:
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::harvestWeakReferences):
* heap/MarkStack.h:
(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::appendUnbarrieredPointer):
* heap/SlotVisitor.h:
* heap/WeakReferenceHarvester.h: Added.
(JSC::WeakReferenceHarvester::WeakReferenceHarvester):
(JSC::WeakReferenceHarvester::~WeakReferenceHarvester):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94473.
commit-queue@webkit.org [Sat, 3 Sep 2011 01:20:49 +0000 (01:20 +0000)]
Unreviewed, rolling out r94473.
http://trac.webkit.org/changeset/94473
https://bugs.webkit.org/show_bug.cgi?id=67547

Putting http://trac.webkit.org/changeset/94454 back in as
http://trac.webkit.org/changeset/94472 fixed the problem
(Requested by msaboff on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

* UIProcess/API/C/WKContext.cpp:
(WKContextGarbageCollectJavaScriptObjects):
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::garbageCollectJavaScriptObjects):
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::garbageCollectJavaScriptObjects):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace local implementation of string equals() methods with UString versions
msaboff@apple.com [Sat, 3 Sep 2011 01:08:10 +0000 (01:08 +0000)]
Replace local implementation of string equals() methods with UString versions
https://bugs.webkit.org/show_bug.cgi?id=67342

In preparation to allowing StringImpl to be backed by 8 bit
characters when appropriate, we need to eliminate or change the
usage of StringImpl::characters(). Change the uses of characters()
that are used to implement redundant equals() methods.

Reviewed by Gavin Barraclough.

* runtime/Identifier.cpp:
(JSC::Identifier::equal):
* runtime/Identifier.h:
(JSC::Identifier::equal):
* wtf/text/AtomicString.cpp:
(WTF::CStringTranslator::equal): Moved an optimized method to here.
(WTF::operator==):
* wtf/text/StringImpl.cpp:
(WTF::equal):
* wtf/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Move updateLayers from LayerRendererChromium to CCLayerTreeHost
enne@google.com [Sat, 3 Sep 2011 01:06:27 +0000 (01:06 +0000)]
[chromium] Move updateLayers from LayerRendererChromium to CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=67438

Reviewed by James Robinson.

Covered by existing tests.

Move functionality used by both CCLayerTreeHost and
LayerRendererChromium into CCLayerTreeHostCommon. Move update, paint,
and updateCompositorResource functions into CClayerTreeHost.

* WebCore.gypi:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::sortLayers):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::textureMemoryReclaimLimit):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::sortLayers):
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: Added.
(WebCore::CCLayerTreeHostCommon::isScaleOrTranslation):
(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h: Added.
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::commitIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94454.
commit-queue@webkit.org [Sat, 3 Sep 2011 01:02:36 +0000 (01:02 +0000)]
Unreviewed, rolling out r94454.
http://trac.webkit.org/changeset/94454
https://bugs.webkit.org/show_bug.cgi?id=67546

"Broke Windows and SnowLeopard, also no reply on the bug."
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

* UIProcess/API/C/WKContext.cpp:
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-02 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Sat, 3 Sep 2011 01:01:35 +0000 (01:01 +0000)]
2011-09-02  Michael Saboff  <msaboff@apple.com>

        Fixed release build by removing #ifndef NDEBUG to
        allow definition of gcController().

        Rubber-stamp by Sam Weinig.

        * WebProcess/WebProcess.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-02 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Sat, 3 Sep 2011 00:42:36 +0000 (00:42 +0000)]
2011-09-02  Chris Marrin  <cmarrin@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=67510
        Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction

        Reviewed by Simon Fraser.

        Do a null check in two places to avoid sending nulls to CACF ValueFunction API.

        Test: animations/pause-crash.html

        * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
        (PlatformCAAnimation::valueFunction):
        (PlatformCAAnimation::setValueFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd JSC:RegExp functional tests
msaboff@apple.com [Sat, 3 Sep 2011 00:41:32 +0000 (00:41 +0000)]
Add JSC:RegExp functional tests
https://bugs.webkit.org/show_bug.cgi?id=67339

Source/JavaScriptCore:

Added new test driver program (testRegExp) and corresponding data file
along with build scripts changes.

Reviewed by Gavin Barraclough.

* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* testRegExp.cpp: Added.
(Options::Options):
(StopWatch::start):
(StopWatch::stop):
(StopWatch::getElapsedMS):
(RegExpTest::RegExpTest):
(GlobalObject::create):
(GlobalObject::className):
(GlobalObject::GlobalObject):
(main):
(cleanupGlobalData):
(testOneRegExp):
(scanString):
(parseRegExpLine):
(parseTestLine):
(runFromFiles):
(printUsageStatement):
(parseArguments):
(realMain):
* tests/regexp: Added.
* tests/regexp/RegExpTest.data: Added.

Tools:

New perl script to build JavaScriptCore and run the RegExp tests.

Reviewed by Gavin Barraclough.

* Scripts/run-regexp-tests: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update baselines and expectations.
jamesr@google.com [Sat, 3 Sep 2011 00:31:08 +0000 (00:31 +0000)]
[chromium] Update baselines and expectations.

* platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd JSC:RegExp functional test data generator
msaboff@apple.com [Sat, 3 Sep 2011 00:20:43 +0000 (00:20 +0000)]
Add JSC:RegExp functional test data generator
https://bugs.webkit.org/show_bug.cgi?id=67519

Add a data generator for regular expressions.  To enable, change the
#undef REGEXP_FUNC_TEST_DATA_GEN to #define.  Then compile and use
regular expressions.  The resulting data will be in /tmp/RegExpTestsData.

Reviewed by Gavin Barraclough.

* runtime/RegExp.cpp:
(JSC::regExpFlags):
(JSC::RegExpFunctionalTestCollector::clearRegExp):
(JSC::RegExpFunctionalTestCollector::get):
(JSC::RegExpFunctionalTestCollector::outputOneTest):
(JSC::RegExpFunctionalTestCollector::RegExpFunctionalTestCollector):
(JSC::RegExpFunctionalTestCollector::~RegExpFunctionalTestCollector):
(JSC::RegExpFunctionalTestCollector::outputEscapedUString):
(JSC::RegExp::~RegExp):
(JSC::RegExp::compile):
(JSC::RegExp::match):
(JSC::RegExp::matchCompareWithInterpreter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Add a 'didDownloadData' method to ResourceLoader, SubresourceLoader,
commit-queue@webkit.org [Sat, 3 Sep 2011 00:17:39 +0000 (00:17 +0000)]
Source/WebCore: Add a 'didDownloadData' method to ResourceLoader, SubresourceLoader,
SubresourceLoaderClient, DocumentThreadableLoader, ResourceHandleClient,
and ThreadableLoaderClient for the Chromium port only, so we can pass
these notifications from our ResourceHandle implementation through the
WebCore loader framework.
https://bugs.webkit.org/show_bug.cgi?id=67229

Patch by Bill Budge <bbudge@chromium.org> on 2011-09-02
Reviewed by Darin Fisher.

No new tests. Exposes no new functionality.

* WebCore.gypi:
* loader/DocumentThreadableLoader.h:
* loader/ResourceLoader.h:
* loader/SubresourceLoader.h:
* loader/SubresourceLoaderClient.h:
(WebCore::SubresourceLoaderClient::didDownloadData):
* loader/ThreadableLoaderClient.h:
(WebCore::ThreadableLoaderClient::didDownloadData):
* loader/ThreadableLoaderClientWrapper.h:
(WebCore::ThreadableLoaderClientWrapper::didDownloadData):
* loader/chromium: Added.
* loader/chromium/DocumentThreadableLoaderChromium.cpp: Added.
(WebCore::DocumentThreadableLoader::didDownloadData):
* loader/chromium/ResourceLoaderChromium.cpp: Added.
(WebCore::ResourceLoader::didDownloadData):
* loader/chromium/SubresourceLoaderChromium.cpp: Added.
(WebCore::SubresourceLoader::didDownloadData):
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didDownloadData):

Source/WebKit/chromium: Add a 'didDownloadData' method to ResourceHandleInternal and pass these
notifications to WebURLLoaderClients.
https://bugs.webkit.org/show_bug.cgi?id=67229

Patch by Bill Budge <bbudge@chromium.org> on 2011-09-02
Reviewed by Darin Fisher.

* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didDownloadData):
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
(WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading):
* src/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::didDownloadData):
* src/ResourceHandleInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssert that PlatformCALayerWinInternal::displayCallback() is only called on the main...
jeffm@apple.com [Sat, 3 Sep 2011 00:16:09 +0000 (00:16 +0000)]
Assert that PlatformCALayerWinInternal::displayCallback() is only called on the main thread
https://bugs.webkit.org/show_bug.cgi?id=67541

Reviewed by Simon Fraser.

No new tests, covered by existing media tests.

* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::displayCallback): Assert that is function is only called on the main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable RenderLayer::updateLayerPosition's cachedOffset optimization for more cases
jchaffraix@webkit.org [Sat, 3 Sep 2011 00:07:44 +0000 (00:07 +0000)]
Enable RenderLayer::updateLayerPosition's cachedOffset optimization for more cases
https://bugs.webkit.org/show_bug.cgi?id=66901

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/layers/assert-RenderLayer-update-positions.html
      Also covered by existing tests under the new ASSERT.

This change extends the range of callers making use of the cachedOffset optimization.

Most callers did not make use of cachedOffset as it did not work when called on a subtree.
This limitation is now gone thus we can enable it more widely.

The semantics of the optimization are changed a bit as we now return if it is enabled whereas
the old code would check if it was *disabled*. Also there were some renames done to match more
closely what was going on (s/cachedOffset/offsetFromRoot/ and s/cachedOffsetDisabled/hasLayerOffset/).

Note that this is an optimistic optimization: if cachedOffset is not used, then we have
done at least an extra traversal up to the root. I have found it to be a wash on file
cycler (alexa) but to be a nice improvement (~20%) on some table benchmarks (modifying
a cell, scrolling).

* page/FrameView.cpp:
(WebCore::FrameView::layout): Extended the use of cachedOffset to subtree layouts.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleDidChange): Forbid the use cachedOffset in this
case as we have only a single layer to update.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeOffsetFromRoot): Added this function to get the offset from the root
layer at a certain point in the RenderLayer's tree. It gets the root layer's checking if no layer
in between would prevent convertToLayerCoords to work and return the position relative to
this layer.

(WebCore::RenderLayer::updateLayerPositions): Added a new ASSERT to make sure our cachedOffset
is always fine. Also added a comment about calling convertToLayerCoords.

(WebCore::RenderLayer::removeOnlyThisLayer): Added cachedOffset here too as we may have to
update several layers. We save the offset prior to being removed from the hierarchy for
correctness.

(WebCore::RenderLayer::paintChildLayerIntoColumns): Added a comment here about calling convertToLayerCoords.

* rendering/RenderLayer.h: Swapped the argument in updateLayerPositions to make
cachedOffset a mandatory field. Patched all the callers.

(WebCore::RenderLayer::canUseConvertToLayerCoords): Added this helper method to know when a
renderer prevents convertToLayerCoords from working. Added some FIXME around suspicious use
of convertToLayerCoords.

LayoutTests:

* fast/layers/crash-RenderLayer-update-positions-expected.txt: Added.
* fast/layers/crash-RenderLayer-update-positions.html: Added.
Test that some changes in the layers does not cause an ASSERT failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the broken build due to dtoa patch
commit-queue@webkit.org [Fri, 2 Sep 2011 23:58:05 +0000 (23:58 +0000)]
Fix the broken build due to dtoa patch
https://bugs.webkit.org/show_bug.cgi?id=67534

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-02
Reviewed by Oliver Hunt.

Fixing the build.

* GNUmakefile.list.am:
* wtf/dtoa/bignum.cc:
* wtf/dtoa/fast-dtoa.cc:
* wtf/dtoa/utils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Symbian] REGRESSION(93235) Missing .def update
commit-queue@webkit.org [Fri, 2 Sep 2011 23:39:16 +0000 (23:39 +0000)]
[Qt][Symbian] REGRESSION(93235) Missing .def update
https://bugs.webkit.org/show_bug.cgi?id=67307

Patch by Jade Han <jade.han@nokia.com> on 2011-09-02
Reviewed by Laszlo Gombos.

* symbian/eabi/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove OldSpace classes
oliver@apple.com [Fri, 2 Sep 2011 23:33:28 +0000 (23:33 +0000)]
Remove OldSpace classes
https://bugs.webkit.org/show_bug.cgi?id=67533

Reviewed by Gavin Barraclough.

Remove the unused OldSpace classes

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.cpp:
(JSC::Heap::writeBarrierSlowCase):
* heap/MarkedBlock.h:
* heap/OldSpace.cpp: Removed.
* heap/OldSpace.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCompile fix for mac build.
jamesr@google.com [Fri, 2 Sep 2011 23:25:15 +0000 (23:25 +0000)]
Compile fix for mac build.

* wtf/CheckedArithmetic.h:
(WTF::operator+):
(WTF::operator-):
(WTF::operator*):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed API for getting surrounding text from webkit in chromium
commit-queue@webkit.org [Fri, 2 Sep 2011 23:07:29 +0000 (23:07 +0000)]
Need API for getting surrounding text from webkit in chromium
https://bugs.webkit.org/show_bug.cgi?id=66681

Patch by Peng Huang <penghuang@chromium.org> on 2011-09-02
Reviewed by Ryosuke Niwa.

Add getSelectionOffsetsAndTextInEditableContent() to Chromium's
WebViewImpl. This function is for supporting some input methods which
need input context around the edit caret.

* public/WebWidget.h:
(WebKit::WebWidget::getSelectionOffsetsAndTextInEditableContent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::getSelectionOffsetsAndTextInEditableContent):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReshuffle some code in WebKitDriver._read_block in preparation for reading stderr...
eric@webkit.org [Fri, 2 Sep 2011 22:33:59 +0000 (22:33 +0000)]
Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
https://bugs.webkit.org/show_bug.cgi?id=67530

Unreviewed.  Fixing typo from previous commit.

Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
which exercises the code I previously made a typo in.

* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRead out of bounds in sUnpremultiplyData_RGBA8888 / ImageBufferData::getData
mdelaney@apple.com [Fri, 2 Sep 2011 22:32:44 +0000 (22:32 +0000)]
Read out of bounds in sUnpremultiplyData_RGBA8888 / ImageBufferData::getData
https://bugs.webkit.org/show_bug.cgi?id=65352

Reviewed by Simon Fraser.

New test: fast/canvas/canvas-getImageData-large-crash.html

Source/JavaScriptCore:

This patch prevents overflows from happening in getImageData, createImageData, and canvas creation
calls that specify widths and heights that end up overflowing the ints that we store those values in
as well as derived values such as area and maxX / maxY of the bounding rects involved. Overflow of integer
arithmetic is detected via the use of the new Checked type that was introduced in r94207. The change to JSC
is just to add a new helper method described below.

* wtf/MathExtras.h:
(isWithinIntRange): Reports if a float's value is within the range expressible by an int.

Source/WebCore:

This patch prevents overflows from happening in getImageData, createImageData, and canvas creation
calls that specify widths and heights that end up overflowing the ints that we store those values in
as well as derived values such as area and maxX / maxY of the bounding rects involved. Overflow of integer
arithmetic is detected via the use of the new Checked type that was introduced in r94207.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::convertLogicalToDevice): Removed dependency on ints, using FloatRects/Sizes instead.
(WebCore::HTMLCanvasElement::createImageBuffer): Moved the check for max canvas area and dimensions here.
  Added in check that prevents us from having canvases of sizes that will cause overflows.
(WebCore::HTMLCanvasElement::baseTransform): Updated use of convertLogicalToDevice.
* html/HTMLCanvasElement.h: Updated method signatures.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::createEmptyImageData): Added in check to prevent creating ImageData objects that will cause overflow when computing their size.
(WebCore::CanvasRenderingContext2D::createImageData): Avoid creating ImageData objects of size that will overflow later.
(WebCore::CanvasRenderingContext2D::getImageData): Added in check to prevent trying to get ImageData objects that will cause overflow when computing their size.
* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::isExpressibleAsIntRect): New method that tests whether a FloatRect can become an IntRect without overflow or having to be clamped.
* platform/graphics/FloatRect.h:
* platform/graphics/FloatSize.cpp:
(WebCore::FloatSize::isExpressibleAsIntSize): Same as FloatRect, but for FloatSize->IntSize.
* platform/graphics/FloatSize.h:
* platform/graphics/cg/ImageBufferCG.cpp: Added check for overflow.
(WebCore::ImageBuffer::ImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNPN_SetException doesn't work with OOP plug-ins
andersca@apple.com [Fri, 2 Sep 2011 22:22:39 +0000 (22:22 +0000)]
NPN_SetException doesn't work with OOP plug-ins
https://bugs.webkit.org/show_bug.cgi?id=67524

Reviewed by Sam Weinig.

* DerivedSources.make:
Add PluginProcessConnection.messages.in.

* GNUmakefile.am:
Add generated files.

* Platform/CoreIPC/MessageID.h:
Add MessageClassPluginProcessConnection.

* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::initialize):
Set the set exception function.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::ConnectionStack::current):
(WebKit::ConnectionStack::CurrentConnectionPusher::CurrentConnectionPusher):
(WebKit::ConnectionStack::CurrentConnectionPusher::~CurrentConnectionPusher):
Add a helper class for managing a stack of CoreIPC connections, along with a RAII
object to push/pop connections onto it.

(WebKit::connectionStack):
Add getter.

(WebKit::WebProcessConnection::setGlobalException):
Get the current connection and send a PluginProcessConnection::SetException message to it.

(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
Create connection pushers.

* PluginProcess/WebProcessConnection.h:
Add setGlobalException.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
Add new files.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::setSetExceptionFunction):
New function for setting the 'setException' function.

(WebKit::NetscapePlugin::setException):
Call the 'setException' function.

* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
Call the message receiver function.

(WebKit::PluginProcessConnection::setException):
Call the NPRuntimeObjectMap.

* WebProcess/Plugins/PluginProcessConnection.messages.in:
Add new messages file.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
When not using the plug-in process, make sure to call NetscapePlugin::setSetExceptionFunction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9755843> anonymous RenderMathMLOperator sets itself as the renderer...
mitz@apple.com [Fri, 2 Sep 2011 22:22:16 +0000 (22:22 +0000)]
<rdar://problem/9755843> anonymous RenderMathMLOperator sets itself as the renderer of its parent mfenced node

Reviewed by Darin Adler.

Source/WebCore:

Test: mathml/operator-hijacks-fenced-node.xhtml

* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement): Rather than unconditionally setting the
node’s renderer to this, just restore it to whatever it was before calling destroyLeftoverChildren().

LayoutTests:

* mathml/operator-hijacks-fenced-node-expected.txt: Added.
* mathml/operator-hijacks-fenced-node.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WKContextGarbageCollectJavaScriptObjects() which does a garbage collection in...
adachan@apple.com [Fri, 2 Sep 2011 22:21:07 +0000 (22:21 +0000)]
Add WKContextGarbageCollectJavaScriptObjects() which does a garbage collection in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=67526

Reviewed by Darin Adler.

* UIProcess/API/C/WKContext.cpp:
(WKContextGarbageCollectJavaScriptObjects):
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::garbageCollectJavaScriptObjects): Send a message to WebProcess to garbage collect JS objects.
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::garbageCollectJavaScriptObjects): Call GCController::garbageCollectNow().
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in: Add GarbageCollectJavaScriptObjects message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReshuffle some code in WebKitDriver._read_block in preparation for reading stderr...
eric@webkit.org [Fri, 2 Sep 2011 22:19:59 +0000 (22:19 +0000)]
Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
https://bugs.webkit.org/show_bug.cgi?id=67530

Reviewed by Adam Barth.

No functional change, just reshuffling code.

* Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncorporate newer, faster dtoa library
commit-queue@webkit.org [Fri, 2 Sep 2011 22:09:34 +0000 (22:09 +0000)]
Incorporate newer, faster dtoa library
https://bugs.webkit.org/show_bug.cgi?id=66346

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-02
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Added new dtoa library at http://code.google.com/p/double-conversion/.
Replaced old call to dtoa.  The new library is much faster than the old one.
We still use the old dtoa for some stuff in WebCore as well as the old strtod,
but we can phase these out eventually as well.

* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/InitializeThreading.cpp:
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
* runtime/UString.cpp:
(JSC::UString::number):
* wtf/CMakeLists.txt:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
* wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
* wtf/dtoa.cpp:
(WTF::dtoa):
* wtf/dtoa.h:
* wtf/dtoa/COPYING: Added.
* wtf/dtoa/LICENSE: Added.
* wtf/dtoa/README: Added.
* wtf/dtoa/bignum-dtoa.cc: Added.
* wtf/dtoa/bignum-dtoa.h: Added.
* wtf/dtoa/bignum.cc: Added.
* wtf/dtoa/bignum.h: Added.
(WTF::double_conversion::Bignum::Times10):
(WTF::double_conversion::Bignum::Equal):
(WTF::double_conversion::Bignum::LessEqual):
(WTF::double_conversion::Bignum::Less):
(WTF::double_conversion::Bignum::PlusEqual):
(WTF::double_conversion::Bignum::PlusLessEqual):
(WTF::double_conversion::Bignum::PlusLess):
(WTF::double_conversion::Bignum::EnsureCapacity):
(WTF::double_conversion::Bignum::BigitLength):
* wtf/dtoa/cached-powers.cc: Added.
* wtf/dtoa/cached-powers.h: Added.
* wtf/dtoa/diy-fp.cc: Added.
* wtf/dtoa/diy-fp.h: Added.
(WTF::double_conversion::DiyFp::DiyFp):
(WTF::double_conversion::DiyFp::Subtract):
(WTF::double_conversion::DiyFp::Minus):
(WTF::double_conversion::DiyFp::Times):
(WTF::double_conversion::DiyFp::Normalize):
(WTF::double_conversion::DiyFp::f):
(WTF::double_conversion::DiyFp::e):
(WTF::double_conversion::DiyFp::set_f):
(WTF::double_conversion::DiyFp::set_e):
* wtf/dtoa/double-conversion.cc: Added.
* wtf/dtoa/double-conversion.h: Added.
(WTF::double_conversion::DoubleToStringConverter::DoubleToStringConverter):
(WTF::double_conversion::StringToDoubleConverter::StringToDoubleConverter):
* wtf/dtoa/double.h: Added.
(WTF::double_conversion::double_to_uint64):
(WTF::double_conversion::uint64_to_double):
(WTF::double_conversion::Double::Double):
(WTF::double_conversion::Double::AsDiyFp):
(WTF::double_conversion::Double::AsNormalizedDiyFp):
(WTF::double_conversion::Double::AsUint64):
(WTF::double_conversion::Double::NextDouble):
(WTF::double_conversion::Double::Exponent):
(WTF::double_conversion::Double::Significand):
(WTF::double_conversion::Double::IsDenormal):
(WTF::double_conversion::Double::IsSpecial):
(WTF::double_conversion::Double::IsNan):
(WTF::double_conversion::Double::IsInfinite):
(WTF::double_conversion::Double::Sign):
(WTF::double_conversion::Double::UpperBoundary):
(WTF::double_conversion::Double::NormalizedBoundaries):
(WTF::double_conversion::Double::value):
(WTF::double_conversion::Double::SignificandSizeForOrderOfMagnitude):
(WTF::double_conversion::Double::Infinity):
(WTF::double_conversion::Double::NaN):
(WTF::double_conversion::Double::DiyFpToUint64):
* wtf/dtoa/fast-dtoa.cc: Added.
* wtf/dtoa/fast-dtoa.h: Added.
* wtf/dtoa/fixed-dtoa.cc: Added.
* wtf/dtoa/fixed-dtoa.h: Added.
* wtf/dtoa/strtod.cc: Added.
* wtf/dtoa/strtod.h: Added.
* wtf/dtoa/utils.h: Added.
(WTF::double_conversion::Max):
(WTF::double_conversion::Min):
(WTF::double_conversion::StrLength):
(WTF::double_conversion::Vector::Vector):
(WTF::double_conversion::Vector::SubVector):
(WTF::double_conversion::Vector::length):
(WTF::double_conversion::Vector::is_empty):
(WTF::double_conversion::Vector::start):
(WTF::double_conversion::Vector::operator[]):
(WTF::double_conversion::Vector::first):
(WTF::double_conversion::Vector::last):
(WTF::double_conversion::StringBuilder::StringBuilder):
(WTF::double_conversion::StringBuilder::~StringBuilder):
(WTF::double_conversion::StringBuilder::size):
(WTF::double_conversion::StringBuilder::position):
(WTF::double_conversion::StringBuilder::Reset):
(WTF::double_conversion::StringBuilder::AddCharacter):
(WTF::double_conversion::StringBuilder::AddString):
(WTF::double_conversion::StringBuilder::AddSubstring):
(WTF::double_conversion::StringBuilder::AddPadding):
(WTF::double_conversion::StringBuilder::Finalize):
(WTF::double_conversion::StringBuilder::is_finalized):
(WTF::double_conversion::BitCast):
* wtf/wtf.pri:

Source/WebCore:

No new tests.

Added new dtoa library at http://code.google.com/p/double-conversion/.
Replaced old call to dtoa.  The new library is much faster than the old one.
We still use the old dtoa for some stuff in WebCore as well as the old strtod,
but we can phase these out eventually as well.

* ForwardingHeaders/wtf/dtoa/double-conversion.h: Added.
* WebCore.vcproj/copyForwardingHeaders.cmd:
* css/CSSPrimitiveValue.cpp:
(WebCore::formatNumber):
* html/parser/HTMLParserIdioms.cpp:
(WebCore::serializeForNumberType):
* inspector/InspectorValues.cpp:
(WebCore::InspectorBasicValue::writeJSON):
* platform/graphics/Color.cpp:
(WebCore::Color::serialized):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94452 268f45cc-cd09-0410-ab3c-d52691b4dbfc