commit-queue@webkit.org [Mon, 30 Aug 2010 12:40:17 +0000 (12:40 +0000)]
2010-08-30 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix with Blob Support
[EFL] Build break with Blob support
https://bugs.webkit.org/show_bug.cgi?id=44858
No new features added, so no new tests.
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Mon, 30 Aug 2010 11:57:13 +0000 (11:57 +0000)]
2010-08-30 Andras Becsi <abecsi@webkit.org>
Unreviewed trivial fix.
[Qt] Let qmake know about HTML parser headers.
No new tests needed.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Mon, 30 Aug 2010 11:38:24 +0000 (11:38 +0000)]
2010-08-30 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt] Fix fileapi header paths to fix warnings after r66365.
No new tests needed.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Mon, 30 Aug 2010 10:34:27 +0000 (10:34 +0000)]
Unreviewed, updating Chromium expectations.
* platform/chromium-win/fast/lists/li-values-expected.checksum: Removed.
* platform/chromium-win/fast/lists/li-values-expected.png: Removed.
* platform/chromium-win/fast/lists/li-values-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 30 Aug 2010 10:06:50 +0000 (10:06 +0000)]
2010-08-30 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
* platform/chromium-linux/fast/lists/li-values-expected.txt: Added.
* platform/chromium-win/fast/lists/li-values-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 30 Aug 2010 09:53:17 +0000 (09:53 +0000)]
2010-08-30 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change for r66359.
* platform/chromium-linux/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Added.
* platform/chromium-mac/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
* platform/chromium-win/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 30 Aug 2010 09:48:02 +0000 (09:48 +0000)]
2010-08-30 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Kent Tamura.
REGRESSION(r66355): Fix warnings in html/DateComponents.cpp
https://bugs.webkit.org/show_bug.cgi?id=44855
* html/DateComponents.cpp:
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek): Suggested parentheses added around && within ||
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 30 Aug 2010 09:42:35 +0000 (09:42 +0000)]
REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp
https://bugs.webkit.org/show_bug.cgi?id=44843
Reviewed by Darin Adler.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Suggested parentheses added around && within ||
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 30 Aug 2010 09:13:27 +0000 (09:13 +0000)]
2010-08-30 Mikołaj Małecki <m.malecki@samsung.com>
Reviewed by Kenneth Rohde Christiansen
[EFL] Added initial setting to turn on offline pages.
https://bugs.webkit.org/show_bug.cgi?id=44239
* ewk/ewk_main.cpp: Torn off non-EFL init to _ewk_init_body
(ewk_init): Changed non-EFL init to call _ewk_init_body
(_ewk_init_body): Moved internal init here and added cache directory path setting.
* ewk/ewk_view.cpp: Added new config items: offline_app_cache and cache_directory
(_ewk_view_priv_new): creating cache_directory string
(_ewk_view_priv_del): deleting cache_directory string
(ewk_view_setting_offline_app_cache_get):
(ewk_view_setting_offline_app_cache_set):
(ewk_view_setting_cache_directory_get):
(ewk_view_setting_cache_directory_set):
* ewk/ewk_view.h: added offline_app_cache and cache_directory props to ewk API
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 30 Aug 2010 08:48:02 +0000 (08:48 +0000)]
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::close):
* inspector/InspectorFrontendClient.h:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/inspector.js:
(WebInspector.inspectedPageDestroyed):
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
* src/InspectorFrontendClientImpl.cpp:
* src/InspectorFrontendClientImpl.h:
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::notifyWebViewDestroyed):
(WebKit::InspectorFrontendClient::destroyInspectorWindow):
(WebKit::InspectorFrontendClient::closeWindow):
* WebCoreSupport/InspectorClientGtk.h:
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::closeWindow):
(-[WebInspectorWindowController windowShouldClose:]):
(-[WebInspectorWindowController destroyInspectorView]):
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorClientQt::openInspectorFrontend):
(WebCore::InspectorClientQt::releaseFrontendPage):
(WebCore::InspectorFrontendClientQt::closeWindow):
* WebCoreSupport/InspectorClientQt.h:
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::~WebInspectorFrontendClient):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::closeWindowWithoutNotifications):
(WebInspectorFrontendClient::destroyInspectorView):
* WebCoreSupport/WebInspectorClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Mon, 30 Aug 2010 08:24:40 +0000 (08:24 +0000)]
Refactor number parsing in the lexer
https://bugs.webkit.org/show_bug.cgi?id=44104
Reviewed by Darin Adler.
Number parsing was full of gotos, and needed a complete
redesign to remove them (Only one remained). Furthermore
integer arithmetic is empolyed for fast cases (= small
integer numbers).
* parser/Lexer.cpp:
(JSC::Lexer::parseHex):
(JSC::Lexer::parseOctal):
(JSC::Lexer::parseDecimal):
(JSC::Lexer::parseNumberAfterDecimalPoint):
(JSC::Lexer::parseNumberAfterExponentIndicator):
(JSC::Lexer::lex):
* parser/Lexer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 30 Aug 2010 08:03:19 +0000 (08:03 +0000)]
Renamed Trolltech Labs to Qt Labs.
Reviewed by Tor Arne Vestbø.
* config.ini:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 30 Aug 2010 07:45:39 +0000 (07:45 +0000)]
2010-08-30 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Kent Tamura.
Split webcore_svg off webcore_remaining. webcore_svg contains all svg
sources files.
https://bugs.webkit.org/show_bug.cgi?id=44840
* WebCore.gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 30 Aug 2010 07:44:46 +0000 (07:44 +0000)]
2010-08-13 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
https://bugs.webkit.org/show_bug.cgi?id=43960
[Chromium] styled scroll bar on the window is painted badly.
* platform/chromium/test_expectations.txt: Skips at this time and will rebaseline shortly.
* platform/mac/Skipped: Mac doesn't suffer from the problem.
* scrollbars/custom-scrollbar-with-incomplete-style.html: Added.
2010-08-13 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
https://bugs.webkit.org/show_bug.cgi?id=43960
[Chromium] styled scroll bar on the window is painted badly.
WebKit assumes outermost scrollbar always painted.
So force their style to have the background color if it isn't
given by the stylesheet.
Test: scrollbars/custom-scrollbar-with-incomplete-style.html
* rendering/RenderObject.h:
(WebCore::RenderObject::hasBackground): Extracted body to RenderStyle for sharing.
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::getScrollbarPseudoStyle): Added the workaround as mentioned above.
* rendering/RenderScrollbar.h:
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasBackground): Extracted from RenderObject.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 30 Aug 2010 07:35:30 +0000 (07:35 +0000)]
2010-08-30 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
WebCore::RenderBlock::addChild* NULL ptrs
https://bugs.webkit.org/show_bug.cgi?id=43722
* fast/ruby/before-doesnt-crash-expected.txt: Added.
* fast/ruby/before-doesnt-crash.html: Added.
2010-08-30 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
WebCore::RenderBlock::addChild* NULL ptrs
https://bugs.webkit.org/show_bug.cgi?id=43722
Also includes some cleanup of comments and ASSERTs.
Test: fast/ruby/before-doesnt-crash.html
* rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::addChild):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 30 Aug 2010 07:28:20 +0000 (07:28 +0000)]
2010-08-30 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Kent Tamura
Move most dependencies to webcore_prerequisites
https://bugs.webkit.org/show_bug.cgi?id=44814
* WebCore.gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 30 Aug 2010 07:15:43 +0000 (07:15 +0000)]
2010-08-30 Adam Barth <abarth@webkit.org>
Move AsyncImageResizer back to html to fix Chromium build.
* WebCore.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 30 Aug 2010 07:13:45 +0000 (07:13 +0000)]
2010-08-30 Adam Barth <abarth@webkit.org>
Fix silly typo that breaks the build.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 30 Aug 2010 07:07:32 +0000 (07:07 +0000)]
2010-08-30 Adam Barth <abarth@webkit.org>
Attempt to fix the Qt build.
* WebCore.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 30 Aug 2010 07:04:01 +0000 (07:04 +0000)]
2010-08-30 Adam Barth <abarth@webkit.org>
Attempt to fix Chromium build.
* WebCore.gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 30 Aug 2010 07:00:22 +0000 (07:00 +0000)]
2010-08-29 Adam Barth <abarth@webkit.org>
Rubber-stamped by Maciej Stachowiak.
Move File and Blob related files from WebCore/html to WebCore/fileapi.
* Android.mk:
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.xcodeproj/project.pbxproj:
* fileapi: Added.
* fileapi/AsyncFileWriter.h: Copied from WebCore/html/AsyncFileWriter.h.
* fileapi/Blob.cpp: Copied from WebCore/html/Blob.cpp.
* fileapi/Blob.h: Copied from WebCore/html/Blob.h.
* fileapi/Blob.idl: Copied from WebCore/html/Blob.idl.
* fileapi/BlobBuilder.cpp: Copied from WebCore/html/BlobBuilder.cpp.
* fileapi/BlobBuilder.h: Copied from WebCore/html/BlobBuilder.h.
* fileapi/BlobBuilder.idl: Copied from WebCore/html/BlobBuilder.idl.
* fileapi/BlobURL.cpp: Copied from WebCore/html/BlobURL.cpp.
* fileapi/BlobURL.h: Copied from WebCore/html/BlobURL.h.
* fileapi/File.cpp: Copied from WebCore/html/File.cpp.
* fileapi/File.h: Copied from WebCore/html/File.h.
* fileapi/File.idl: Copied from WebCore/html/File.idl.
* fileapi/FileError.h: Copied from WebCore/html/FileError.h.
* fileapi/FileError.idl: Copied from WebCore/html/FileError.idl.
* fileapi/FileList.cpp: Copied from WebCore/html/FileList.cpp.
* fileapi/FileList.h: Copied from WebCore/html/FileList.h.
* fileapi/FileList.idl: Copied from WebCore/html/FileList.idl.
* fileapi/FileReader.cpp: Copied from WebCore/html/FileReader.cpp.
* fileapi/FileReader.h: Copied from WebCore/html/FileReader.h.
* fileapi/FileReader.idl: Copied from WebCore/html/FileReader.idl.
* fileapi/FileStreamProxy.cpp: Copied from WebCore/html/FileStreamProxy.cpp.
* fileapi/FileStreamProxy.h: Copied from WebCore/html/FileStreamProxy.h.
* fileapi/FileThread.cpp: Copied from WebCore/html/FileThread.cpp.
* fileapi/FileThread.h: Copied from WebCore/html/FileThread.h.
* fileapi/FileThreadTask.h: Copied from WebCore/html/FileThreadTask.h.
* fileapi/FileWriter.cpp: Copied from WebCore/html/FileWriter.cpp.
* fileapi/FileWriter.h: Copied from WebCore/html/FileWriter.h.
* fileapi/FileWriter.idl: Copied from WebCore/html/FileWriter.idl.
* fileapi/FileWriterClient.h: Copied from WebCore/html/FileWriterClient.h.
* fileapi/ThreadableBlobRegistry.cpp: Copied from WebCore/html/ThreadableBlobRegistry.cpp.
* fileapi/ThreadableBlobRegistry.h: Copied from WebCore/html/ThreadableBlobRegistry.h.
* html/AsyncFileWriter.h: Removed.
* html/Blob.cpp: Removed.
* html/Blob.h: Removed.
* html/Blob.idl: Removed.
* html/BlobBuilder.cpp: Removed.
* html/BlobBuilder.h: Removed.
* html/BlobBuilder.idl: Removed.
* html/BlobURL.cpp: Removed.
* html/BlobURL.h: Removed.
* html/File.cpp: Removed.
* html/File.h: Removed.
* html/File.idl: Removed.
* html/FileError.h: Removed.
* html/FileError.idl: Removed.
* html/FileList.cpp: Removed.
* html/FileList.h: Removed.
* html/FileList.idl: Removed.
* html/FileReader.cpp: Removed.
* html/FileReader.h: Removed.
* html/FileReader.idl: Removed.
* html/FileStreamProxy.cpp: Removed.
* html/FileStreamProxy.h: Removed.
* html/FileThread.cpp: Removed.
* html/FileThread.h: Removed.
* html/FileThreadTask.h: Removed.
* html/FileWriter.cpp: Removed.
* html/FileWriter.h: Removed.
* html/FileWriter.idl: Removed.
* html/FileWriterClient.h: Removed.
* html/ThreadableBlobRegistry.cpp: Removed.
* html/ThreadableBlobRegistry.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 30 Aug 2010 06:56:17 +0000 (06:56 +0000)]
2010-08-29 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Kent Tamura.
Move more common settings to webcore_prerequisites
https://bugs.webkit.org/show_bug.cgi?id=44812
* WebCore.gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 30 Aug 2010 06:54:40 +0000 (06:54 +0000)]
Fix Qt build.
* wtf/unicode/glib/UnicodeMacrosFromICU.h: Added U_IS_BMP.
* wtf/unicode/qt4/UnicodeQt4.h: Ditto.
* wtf/unicode/wince/UnicodeWince.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 30 Aug 2010 06:51:56 +0000 (06:51 +0000)]
2010-08-29 Darin Adler <darin@apple.com>
Reviewed by Maciej Stachowiak.
Create SVG and WML elements with create functions instead of direct invocations of new
https://bugs.webkit.org/show_bug.cgi?id=44851
Added the create functions, made some existing constructors protected and private,
made some other member functions protected and and private, added some missing virtual
keywords for clarity to functions that already were overriding virtual functions,
fixed some inconsistent indentation, and removed some unneeded empty destructors.
In the future, it will be good to have the constructors all be private so we don't
use them by accident. Then we'll change the reference count rule globally and add
all the necessary calls to adoptRef.
The SVG changes are compiled and tested. The WML changes are speculative and untested.
* dom/make_names.pl: Removed supportfor the createWithNew keyword.
* svg/svgtags.in: Removed all the createWithNew keywords.
* wml/WMLTagNames.in: Ditto.
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::create): Added.
* svg/SVGAElement.h:
* svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::create): Added.
* svg/SVGAltGlyphElement.h:
* svg/SVGAnimateColorElement.cpp:
(WebCore::SVGAnimateColorElement::create): Added.
* svg/SVGAnimateColorElement.h:
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::create): Added.
* svg/SVGAnimateElement.h:
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::create): Added.
* svg/SVGAnimateMotionElement.h:
* svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::create): Added.
* svg/SVGAnimateTransformElement.h:
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::create): Added.
* svg/SVGCircleElement.h:
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::create): Added.
* svg/SVGClipPathElement.h:
* svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::create): Added.
* svg/SVGCursorElement.h:
* svg/SVGDefsElement.cpp:
(WebCore::SVGDefsElement::create): Added.
* svg/SVGDefsElement.h:
* svg/SVGDescElement.cpp:
(WebCore::SVGDescElement::create): Added.
* svg/SVGDescElement.h:
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::create): Added.
* svg/SVGEllipseElement.h:
* svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::create): Added.
* svg/SVGFEBlendElement.h:
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::create): Added.
* svg/SVGFEColorMatrixElement.h:
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::create): Added.
* svg/SVGFEComponentTransferElement.h:
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::create): Added.
* svg/SVGFECompositeElement.h:
* svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::create): Added.
* svg/SVGFEConvolveMatrixElement.h:
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::create): Added.
* svg/SVGFEDiffuseLightingElement.h:
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::create): Added.
* svg/SVGFEDisplacementMapElement.h:
* svg/SVGFEDistantLightElement.cpp:
(WebCore::SVGFEDistantLightElement::create): Added.
* svg/SVGFEDistantLightElement.h:
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::create): Added.
* svg/SVGFEFloodElement.h:
* svg/SVGFEFuncAElement.cpp:
(WebCore::SVGFEFuncAElement::create): Added.
* svg/SVGFEFuncAElement.h:
* svg/SVGFEFuncBElement.cpp:
(WebCore::SVGFEFuncBElement::create): Added.
* svg/SVGFEFuncBElement.h:
* svg/SVGFEFuncGElement.cpp:
(WebCore::SVGFEFuncGElement::create): Added.
* svg/SVGFEFuncGElement.h:
* svg/SVGFEFuncRElement.cpp:
(WebCore::SVGFEFuncRElement::create): Added.
* svg/SVGFEFuncRElement.h:
* svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::create): Added.
* svg/SVGFEGaussianBlurElement.h:
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::create): Added.
* svg/SVGFEImageElement.h:
* svg/SVGFEMergeElement.cpp:
(WebCore::SVGFEMergeElement::create): Added.
* svg/SVGFEMergeElement.h:
* svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::create): Added.
* svg/SVGFEMergeNodeElement.h:
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::create): Added.
* svg/SVGFEMorphologyElement.h:
* svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::create): Added.
* svg/SVGFEOffsetElement.h:
* svg/SVGFEPointLightElement.cpp:
(WebCore::SVGFEPointLightElement::create): Added.
* svg/SVGFEPointLightElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::create): Added.
* svg/SVGFESpecularLightingElement.h:
* svg/SVGFESpotLightElement.cpp:
(WebCore::SVGFESpotLightElement::create): Added.
* svg/SVGFESpotLightElement.h:
* svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::create): Added.
* svg/SVGFETileElement.h:
* svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::create): Added.
* svg/SVGFETurbulenceElement.h:
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::create): Added.
* svg/SVGFilterElement.h:
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::create): Added.
* svg/SVGFontElement.h:
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::create): Added.
* svg/SVGFontFaceElement.h:
* svg/SVGFontFaceFormatElement.cpp:
(WebCore::SVGFontFaceFormatElement::create): Added.
* svg/SVGFontFaceFormatElement.h:
* svg/SVGFontFaceNameElement.cpp:
(WebCore::SVGFontFaceNameElement::create): Added.
* svg/SVGFontFaceNameElement.h:
* svg/SVGFontFaceSrcElement.cpp:
(WebCore::SVGFontFaceSrcElement::create): Added.
* svg/SVGFontFaceSrcElement.h:
* svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::create): Added.
* svg/SVGFontFaceUriElement.h:
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::create): Added.
* svg/SVGForeignObjectElement.h:
* svg/SVGGElement.cpp:
(WebCore::SVGGElement::create): Added.
* svg/SVGGElement.h:
* svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::create): Added.
* svg/SVGGlyphElement.h:
* svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::create): Added.
* svg/SVGHKernElement.h:
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::create): Added.
* svg/SVGImageElement.h:
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::create): Added.
* svg/SVGLineElement.h:
* svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::create): Added.
* svg/SVGLinearGradientElement.h:
* svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::create): Added.
* svg/SVGMPathElement.h:
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::create): Added.
* svg/SVGMarkerElement.h:
* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::create): Added.
* svg/SVGMaskElement.h:
* svg/SVGMetadataElement.cpp:
(SVGMetadataElement::create): Added.
* svg/SVGMetadataElement.h:
* svg/SVGMissingGlyphElement.cpp:
(WebCore::SVGMissingGlyphElement::create): Added.
* svg/SVGMissingGlyphElement.h:
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::create): Added.
* svg/SVGPathElement.h:
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::create): Added.
* svg/SVGPatternElement.h:
* svg/SVGPolygonElement.cpp:
(WebCore::SVGPolygonElement::create): Added.
* svg/SVGPolygonElement.h:
* svg/SVGPolylineElement.cpp:
(WebCore::SVGPolylineElement::create): Added.
* svg/SVGPolylineElement.h:
* svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::create): Added.
* svg/SVGRadialGradientElement.h:
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::create): Added.
* svg/SVGRectElement.h:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::create): Added.
* svg/SVGSVGElement.h:
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::create): Added.
* svg/SVGScriptElement.h:
* svg/SVGSetElement.cpp:
(WebCore::SVGSetElement::create): Added.
* svg/SVGSetElement.h:
* svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::create): Added.
* svg/SVGStopElement.h:
(WebCore::SVGStyleElement::create): Added.
* svg/SVGStyleElement.h:
* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::create): Added.
* svg/SVGSwitchElement.h:
* svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::create): Added.
* svg/SVGSymbolElement.h:
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::create): Added.
* svg/SVGTRefElement.h:
* svg/SVGTSpanElement.cpp:
(WebCore::SVGTSpanElement::create): Added.
* svg/SVGTSpanElement.h:
* svg/SVGTextContentElement.h:
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::create): Added.
* svg/SVGTextElement.h:
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::create): Added.
* svg/SVGTextPathElement.h:
* svg/SVGTextPositioningElement.h:
* svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::create): Added.
* svg/SVGTitleElement.h:
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::create): Added.
* svg/SVGUseElement.h:
* svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::create): Added.
* svg/SVGVKernElement.h:
* svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::create): Added.
* svg/SVGViewElement.h:
* wml/WMLAElement.cpp:
(WebCore::WMLAElement::create): Added.
* wml/WMLAElement.h:
* wml/WMLAccessElement.cpp:
(WebCore::WMLAccessElement::create): Added.
* wml/WMLAccessElement.h:
* wml/WMLAnchorElement.cpp:
(WebCore::WMLAnchorElement::create): Added.
* wml/WMLAnchorElement.h:
* wml/WMLBRElement.cpp:
(WebCore::WMLBRElement::create): Added.
* wml/WMLBRElement.h:
* wml/WMLCardElement.cpp:
(WebCore::WMLCardElement::create): Added.
* wml/WMLCardElement.h:
* wml/WMLDoElement.cpp:
(WebCore::WMLDoElement::create): Added.
* wml/WMLDoElement.h:
* wml/WMLFieldSetElement.cpp:
(WebCore::WMLFieldSetElement::create): Added.
* wml/WMLFieldSetElement.h:
* wml/WMLFormControlElement.cpp:
(WebCore::WMLFormControlElement::create): Added.
* wml/WMLGoElement.cpp:
(WebCore::WMLGoElement::create): Added.
* wml/WMLGoElement.h:
* wml/WMLImageElement.cpp:
(WebCore::WMLImageElement::create): Added.
* wml/WMLImageElement.h:
* wml/WMLInputElement.cpp:
(WebCore::WMLInputElement::create): Added.
* wml/WMLInputElement.h:
* wml/WMLInsertedLegendElement.cpp:
(WebCore::WMLInsertedLegendElement::create): Added.
* wml/WMLInsertedLegendElement.h:
* wml/WMLIntrinsicEvent.cpp:
(WebCore::WMLIntrinsicEvent::create): Added.
* wml/WMLMetaElement.cpp:
(WebCore::WMLMetaElement::create): Added.
* wml/WMLMetaElement.h:
* wml/WMLNoopElement.cpp:
(WebCore::WMLNoopElement::create): Added.
* wml/WMLNoopElement.h:
* wml/WMLOnEventElement.cpp:
(WebCore::WMLOnEventElement::create): Added.
* wml/WMLOnEventElement.h:
* wml/WMLOptGroupElement.cpp:
(WebCore::WMLOptGroupElement::create): Added.
* wml/WMLOptGroupElement.h:
* wml/WMLOptionElement.cpp:
(WebCore::WMLOptionElement::create): Added.
* wml/WMLOptionElement.h:
* wml/WMLPElement.cpp:
(WebCore::WMLPElement::create): Added.
* wml/WMLPElement.h:
* wml/WMLPostfieldElement.cpp:
(WebCore::WMLPostfieldElement::create): Added.
* wml/WMLPostfieldElement.h:
* wml/WMLPrevElement.cpp:
(WebCore::WMLPrevElement::create): Added.
* wml/WMLPrevElement.h:
* wml/WMLRefreshElement.cpp:
(WebCore::WMLRefreshElement::create): Added.
* wml/WMLRefreshElement.h:
* wml/WMLSelectElement.cpp:
(WebCore::WMLSelectElement::create): Added.
* wml/WMLSelectElement.h:
* wml/WMLSetvarElement.cpp:
(WebCore::WMLSetvarElement::create): Added.
* wml/WMLSetvarElement.h:
* wml/WMLTableElement.cpp:
(WebCore::WMLTableElement::create): Added.
* wml/WMLTableElement.h:
* wml/WMLTaskElement.cpp:
(WebCore::WMLTaskElement::create): Added.
* wml/WMLTaskElement.h:
* wml/WMLTemplateElement.cpp:
(WebCore::WMLTemplateElement::create): Added.
* wml/WMLTemplateElement.h:
* wml/WMLTimerElement.cpp:
(WebCore::WMLTimerElement::create): Added.
* wml/WMLTimerElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 30 Aug 2010 06:37:25 +0000 (06:37 +0000)]
Unreviewed, add missing bug URL for the last my commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 30 Aug 2010 06:31:20 +0000 (06:31 +0000)]
2010-08-29 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Kent Tamura.
Rename webcore to 'webcore_remaining'.
Create a meta-target webcore that inherits from every webcore_XXX targets. (Currently 1)
Move direct_dependent_settings and export_dependent_settings from webcore_remaining to webcore
Obviously, there will be other webcore_XXX targets. Keeping the change as small as possible.
* WebCore.gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 30 Aug 2010 06:31:08 +0000 (06:31 +0000)]
2010-08-29 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Move UTF16 LEAD/TRAIL logic into the HTMLEntityParser
https://bugs.webkit.org/show_bug.cgi?id=44790
We now block this attack.
* http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeremy@chromium.org [Mon, 30 Aug 2010 06:12:38 +0000 (06:12 +0000)]
2010-08-29 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dimitri Glazkov.
First step in unforking Chrome's FontPlatformDataMac.mm.
Move files from platform/graphics/mac to platform/graphics/cocoa
https://bugs.webkit.org/show_bug.cgi?id=41398
Just moving files around so no new tests.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/chromium/FontPlatformDataChromiumMac.mm:
* platform/graphics/cocoa/FontPlatformData.h: Copied from WebCore/platform/graphics/mac/FontPlatformData.h.
* platform/graphics/cocoa/FontPlatformDataCocoa.mm: Copied from WebCore/platform/graphics/mac/FontPlatformDataMac.mm.
* platform/graphics/mac/FontPlatformData.h: Removed.
* platform/graphics/mac/FontPlatformDataMac.mm: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 30 Aug 2010 05:11:35 +0000 (05:11 +0000)]
Introduce isValidValue(const String&) of HTMLInputElement and HTMLTextAreaElement
https://bugs.webkit.org/show_bug.cgi?id=43537
Reviewed by Darin Adler.
WebCore:
isValidValue() is useful for browser implementations to propose
form field values without breaking form validity.
No new tests because these functions are not exposed to JavaScript.
* html/HTMLFormControlElement.h:
(WebCore::HTMLTextFormControlElement::):
Remove virtual valueMissing(), patternMismatch(), and tooLong().
* html/HTMLInputElement.cpp:
(WebCore::isValidColorString): Moved from ValidityState.
(WebCore::isValidEmailAddress): ditto.
(WebCore::HTMLInputElement::isValidValue): Added.
(WebCore::HTMLInputElement::typeMismatch): Add a String parameter.
(WebCore::HTMLInputElement::valueMissing): Add a String parameter.
(WebCore::HTMLInputElement::patternMismatch): Add a String parameter.
(WebCore::HTMLInputElement::tooLong): Add String and NeedsToCheckDirtyFlag parameters.
(WebCore::HTMLInputElement::rangeUnderflow): Add a String parameter.
(WebCore::HTMLInputElement::rangeOverflow): Add a String parameter.
(WebCore::HTMLInputElement::stepMismatch): Add a String parameter.
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::tooLong): Add String and NeedsToCheckDirtyFlag parameters.
(WebCore::HTMLTextAreaElement::isValidValue): Added.
* html/HTMLTextAreaElement.h:
(WebCore::HTMLTextAreaElement::valueMissing):
* html/ValidityState.cpp:
(WebCore::ValidityState::valueMissing): Calls valueMissing() of HTMLInputElement or HTMLTextAreaElement.
(WebCore::ValidityState::typeMismatch): Passes value() to HTMLInputElement::typeMismatch().
(WebCore::ValidityState::patternMismatch): Calls patternMismatch() of HTMLInputElement.
(WebCore::ValidityState::tooLong): Calls valueMissing() of HTMLInputElement or HTMLTextAreaElement.
(WebCore::ValidityState::rangeUnderflow): Passes value() to HTMLInputElement::rangeUnderflow().
(WebCore::ValidityState::rangeOverflow): Passes value() to HTMLInputElement::rangeUnderflow().
(WebCore::ValidityState::stepMismatch): Passes value() to HTMLInputElement::stepMismatch().
* html/ValidityState.h:
WebKit/chromium:
* public/WebInputElement.h:
* src/WebInputElement.cpp:
(WebKit::WebInputElement::isValidValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 30 Aug 2010 04:55:04 +0000 (04:55 +0000)]
2010-08-29 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change for r66282.
* platform/chromium-win/inspector/console-format-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 30 Aug 2010 04:47:24 +0000 (04:47 +0000)]
Change lower and higher limits of date/datetime/datetime-local/month/week types
https://bugs.webkit.org/show_bug.cgi?id=39737
Reviewed by Darin Adler.
WebCore:
According to the latest draft of HTML5, ISO-8601 dates in HTML5
should support A.D.0001 in Gregorian calendar though Gregorian
calendar started in 1582. So, we change the lower limits of
date&time types to 0001-01-01T00:00.
We also introduce the common higher limit, 275760-09-13T00:00. It
is the higher limit of Date type of ECMAScript.
* html/DateComponents.cpp:
(WebCore::DateComponents::parseYear):
Rejects years less than A.D.1 and years greater than 275760.
(WebCore::withinHTMLDateLimits):
Helper functions to check lower and higher limits.
(WebCore::DateComponents::addDay):
- Remove an overflow check. 'year' can't be so large number because
parseYear() rejects such numbers.
- Add withinHTMLDateLimits() calls.
(WebCore::DateComponents::addMinute):
- Add an assertion for the base date.
- Add withinHTMLDateLimits() calls.
(WebCore::DateComponents::parseMonth):
Add withinHTMLDateLimits() call.
(WebCore::DateComponents::parseDate): ditto.
(WebCore::DateComponents::parseWeek): ditto.
(WebCore::DateComponents::parseDateTimeLocal): ditto.
(WebCore::DateComponents::parseDateTime): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForDate): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTime): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForMonth): ditto.
(WebCore::DateComponents::setMonthsSinceEpoch):
Add year range check and withinHTMLDateLimits() call.
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):
Add year range check and week range check.
* html/DateComponents.h:
Update minimum/maximum constant values.
(WebCore::DateComponents::minimumDate):
(WebCore::DateComponents::minimumDateTime):
(WebCore::DateComponents::minimumMonth):
(WebCore::DateComponents::minimumWeek):
(WebCore::DateComponents::maximumDate):
(WebCore::DateComponents::maximumDateTime):
(WebCore::DateComponents::maximumMonth):
(WebCore::DateComponents::maximumWeek):
LayoutTests:
Update tests and test results for the new DateComponents behavior.
* fast/forms/ValidityState-rangeOverflow-expected.txt:
* fast/forms/ValidityState-stepMismatch-expected.txt:
* fast/forms/ValidityState-typeMismatch-date-expected.txt:
* fast/forms/ValidityState-typeMismatch-datetime-expected.txt:
* fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt:
* fast/forms/ValidityState-typeMismatch-month-expected.txt:
* fast/forms/ValidityState-typeMismatch-week-expected.txt:
* fast/forms/input-valueasdate-date-expected.txt:
* fast/forms/input-valueasdate-datetime-expected.txt:
* fast/forms/input-valueasdate-month-expected.txt:
* fast/forms/input-valueasdate-week-expected.txt:
* fast/forms/input-valueasnumber-date-expected.txt:
* fast/forms/input-valueasnumber-datetime-expected.txt:
* fast/forms/input-valueasnumber-datetimelocal-expected.txt:
* fast/forms/input-valueasnumber-month-expected.txt:
* fast/forms/input-valueasnumber-week-expected.txt:
* fast/forms/script-tests/ValidityState-rangeOverflow.js:
* fast/forms/script-tests/ValidityState-stepMismatch.js:
* fast/forms/script-tests/ValidityState-typeMismatch-date.js:
* fast/forms/script-tests/ValidityState-typeMismatch-datetime.js:
* fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js:
* fast/forms/script-tests/ValidityState-typeMismatch-month.js:
* fast/forms/script-tests/ValidityState-typeMismatch-week.js:
* fast/forms/script-tests/input-valueasdate-date.js:
* fast/forms/script-tests/input-valueasdate-datetime.js:
* fast/forms/script-tests/input-valueasdate-month.js:
* fast/forms/script-tests/input-valueasdate-week.js:
* fast/forms/script-tests/input-valueasnumber-date.js:
* fast/forms/script-tests/input-valueasnumber-datetime.js:
* fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
* fast/forms/script-tests/input-valueasnumber-month.js:
* fast/forms/script-tests/input-valueasnumber-week.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 30 Aug 2010 04:38:17 +0000 (04:38 +0000)]
2010-08-29 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change for r66296.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 30 Aug 2010 04:25:57 +0000 (04:25 +0000)]
2010-08-29 James Robinson <jamesr@chromium.org>
Reviewed by David Levin.
Make failing the download step fail the build
https://bugs.webkit.org/show_bug.cgi?id=44298
If the download step fails on a test bot, this ensures that
the build goes red instead of only the download step going red
and the overall build staying green.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 30 Aug 2010 04:16:42 +0000 (04:16 +0000)]
2010-08-29 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 30 Aug 2010 04:07:39 +0000 (04:07 +0000)]
2010-08-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove dependency to base/keyboard_codes.h
https://bugs.webkit.org/show_bug.cgi?id=44847
* DEPS: Roll Chromium revision to 57823 to have a webkit_support change.
2010-08-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove dependency to base/keyboard_codes.h
https://bugs.webkit.org/show_bug.cgi?id=44847
* DumpRenderTree/chromium/EventSender.cpp:
Use webkit_support::VKEY_* instead of base::VKEY_*.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 30 Aug 2010 03:26:19 +0000 (03:26 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=40589
* Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
function names.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 30 Aug 2010 02:41:51 +0000 (02:41 +0000)]
2010-08-29 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change for r66306.
* platform/chromium-linux/fast/forms/form-added-to-table-expected.txt: Added.
* platform/chromium-linux/fast/forms/formmove3-expected.checksum:
* platform/chromium-linux/fast/forms/formmove3-expected.png:
* platform/chromium-linux/fast/forms/formmove3-expected.txt:
* platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.checksum:
* platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.png: Removed.
* platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
* platform/chromium-linux/fast/table/fixed-table-non-cell-in-row-expected.txt: Added.
* platform/chromium-linux/fast/table/inline-form-assert-expected.txt: Added.
* platform/chromium-linux/fast/table/insert-cell-before-form-expected.txt: Added.
* platform/chromium-linux/fast/table/insert-row-before-form-expected.txt: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.txt: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.txt: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.txt: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.txt: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.txt: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug78162-expected.txt: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.txt: Added.
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
* platform/chromium-mac/fast/forms/formmove3-expected.checksum: Removed.
* platform/chromium-mac/fast/forms/formmove3-expected.png: Removed.
* platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Removed.
* platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug2516-expected.checksum: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug2516-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.checksum: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug32447-expected.checksum: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug32447-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug34538-expected.checksum: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug34538-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum: Removed.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Removed.
* platform/chromium-win/fast/forms/form-added-to-table-expected.txt:
* platform/chromium-win/fast/forms/formmove3-expected.checksum:
* platform/chromium-win/fast/forms/formmove3-expected.png:
* platform/chromium-win/fast/forms/formmove3-expected.txt:
* platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.checksum:
* platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.png:
* platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
* platform/chromium-win/fast/table/fixed-table-non-cell-in-row-expected.txt:
* platform/chromium-win/fast/table/inline-form-assert-expected.txt:
* platform/chromium-win/fast/table/insert-cell-before-form-expected.txt:
* platform/chromium-win/fast/table/insert-row-before-form-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug1318-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug2516-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug2516-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2516-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug30559-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug30559-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug30559-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug32447-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug32447-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug32447-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug34538-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug34538-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug34538-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug4527-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug78162-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug96334-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug96334-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug96343-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug96343-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug96343-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 30 Aug 2010 02:06:39 +0000 (02:06 +0000)]
2010-08-29 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Port SharedBuffer::createWithContentsOfFile
https://bugs.webkit.org/show_bug.cgi?id=34412
Implement SharedBuffer::createWithContentsOfFile with IFile.
* platform/brew/SharedBufferBrew.cpp: Added.
(WebCore::SharedBuffer::createWithContentsOfFile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Mon, 30 Aug 2010 01:54:10 +0000 (01:54 +0000)]
[iExploder] Add new CSS Properties and HTML Attributes
https://bugs.webkit.org/show_bug.cgi?id=44746
Updated the files with the update-iexploder-cssproperties script
and manually readded the -webkit-binding CSS Property to the list.
* iExploder/htdocs/cssproperties.in:
* iExploder/htdocs/htmlattrs.in:
* iExploder/htdocs/htmltags.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Mon, 30 Aug 2010 01:53:32 +0000 (01:53 +0000)]
Fix Coverage build after the addition of ANGLE
https://bugs.webkit.org/show_bug.cgi?id=44744
ANGLE is using libtool to build a static library and the version of
libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
parameters. The easiest way to handle this is to not build ANGLE with
coverage information.
This is achieved by applying the XCode options for each project
separately and exclude ANGLE.
* Scripts/build-webkit: Remove -framework AppKit due link errors.
* Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 30 Aug 2010 01:46:43 +0000 (01:46 +0000)]
2010-08-29 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Port vprintf_stderr_common
https://bugs.webkit.org/show_bug.cgi?id=33568
Use BREW's DBGPRINTF to output debug messages.
* wtf/Assertions.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Mon, 30 Aug 2010 01:31:38 +0000 (01:31 +0000)]
WebCore: Crash when dragging text in Google Docs
https://bugs.webkit.org/show_bug.cgi?id=20471
<rdar://problem/
7783629>
Reviewed by Adele Peterson.
This fixes the crash but also fixes the generated markup when
performing a replacement at the border with an inline, to avoid the
new content being merged into the inline.
The crash is happening when doApply detects the need of merging
the start and the end of the new paragraph and the destination position
is moved inside an inline.
I've added new test cases to an existing layout test.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): When the situation described above is detected,
we insert a placeholder to avoid merging into the inline.
LayoutTests: Crash when dragging text in Google Docs
https://bugs.webkit.org/show_bug.cgi?id=20471
<rdar://problem/
7783629>
Reviewed by Adele Peterson.
Added new test cases to an exisisting file and updated the result to reflect
the correct behavior.
* editing/selection/replace-selection-crash-expected.txt:
* editing/selection/replace-selection-crash.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66344
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 30 Aug 2010 01:16:15 +0000 (01:16 +0000)]
2010-08-29 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Implement HTML5's fakepath
https://bugs.webkit.org/show_bug.cgi?id=29000
Update expectations for this pasteboard test to include our new friend
fakepath.
* editing/pasteboard/file-input-files-access-expected.txt:
2010-08-29 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Implement HTML5's fakepath
https://bugs.webkit.org/show_bug.cgi?id=29000
The HTML 5 spec says to prepend C:\fakepath\ to the value of an
<input type="file"> control, so that's what we do now.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::value):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 30 Aug 2010 00:36:35 +0000 (00:36 +0000)]
2010-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66329.
http://trac.webkit.org/changeset/66329
https://bugs.webkit.org/show_bug.cgi?id=44845
broke chromium mac (Requested by jamesr on #webkit).
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/mac/FontPlatformData.h: Renamed from WebCore/platform/graphics/cocoa/FontPlatformData.h.
(WebCore::toCTFontRef):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::size):
(WebCore::FontPlatformData::syntheticBold):
(WebCore::FontPlatformData::syntheticOblique):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::isColorBitmapFont):
(WebCore::FontPlatformData::cgFont):
(WebCore::FontPlatformData::hashTableDeletedFontValue):
* platform/graphics/mac/FontPlatformDataMac.mm: Renamed from WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::~FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::roundsGlyphAdvances):
(WebCore::FontPlatformData::allowsLigatures):
(WebCore::FontPlatformData::ctFont):
(WebCore::FontPlatformData::description):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 30 Aug 2010 00:10:14 +0000 (00:10 +0000)]
2010-08-29 Adam Barth <abarth@webkit.org>
Attempt to make Sam's life easier by not opening a comment text field
if there's a selection. This should make it easier to copy/paste text
out of the diff without accidentally opening comment boxes.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 29 Aug 2010 23:56:40 +0000 (23:56 +0000)]
2010-08-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
fast/loader/input-element-page-cache-crash.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=44811
Make test not rely on page cache behavior (window.finishTest being
persisted), instead use sessionStorage.
* fast/loader/input-element-page-cache-crash.html:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sun, 29 Aug 2010 23:16:21 +0000 (23:16 +0000)]
2010-08-29 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
When properties are missing from animation keyframes, interpolate between those keyframes that specify them
https://bugs.webkit.org/show_bug.cgi?id=40794
When a property does not appear in all keyframes of a keyframe animation, we currently use the
value of that property from the unanimated style. That forces the author to use additional
keyframes for properties that need to "skip a keyframe", which is laborious.
With this change, properties are interpolated between the keyframes in which they appear.
This is equivalent to splitting each property out into its own set of keyframes.
Tests: animations/missing-keyframe-properties-repeating.html
animations/missing-keyframe-properties-timing-function.html
animations/missing-keyframe-properties.html
* css/CSSStyleSelector.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForKeyframe): Pass a KeyframeValue in so that we can
collect which properties are represented per keyframe.
(WebCore::CSSStyleSelector::keyframeStylesForAnimation): Keyframes are inserted into a
KeyframeList by object now, rather than by key and style.
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::progress): Use AnimationDirectionAlternate for readability.
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty): Renamed from getKeyframeAnimationInterval.
Use fractionalTime etc to match AnimationBase::progress(), and do lookups per-property.
Simplify the code that finds the relevant keyframe to do less work.
(WebCore::KeyframeAnimation::animate): Call fetchIntervalEndpointsForProperty() for each property, rather than just once for the
entire keyframe.
(WebCore::KeyframeAnimation::getAnimatedStyle): Ditto.
(WebCore::KeyframeAnimation::hasAnimationForProperty): FIXME comment.
* page/animation/KeyframeAnimation.h: Rename getKeyframeAnimationInterval() to fetchIntervalEndpointsForProperty().
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation): For hardware animations, only insert values
for keyframes which contain the property.
(WebCore::KeyframeList::KeyframeList): insert() takes a KeyframeValue now.
* rendering/style/KeyframeList.cpp:
(WebCore::KeyframeList::operator==):
(WebCore::KeyframeList::insert): Fix insert/replace logic, and ensure we maintain the
m_properties hash.
* rendering/style/KeyframeList.h:
(WebCore::KeyframeValue::KeyframeValue): Make members private, with accessors.
Add a m_properties HashSet for the properties animated in this keyframe.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sun, 29 Aug 2010 22:09:01 +0000 (22:09 +0000)]
2010-08-29 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp
https://bugs.webkit.org/show_bug.cgi?id=44843
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Suggested parentheses added around && within ||
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 29 Aug 2010 21:28:21 +0000 (21:28 +0000)]
Try to fix Mac build.
* WebCore.xcodeproj/project.pbxproj: Mark CounterContent.h Private instead of Project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 29 Aug 2010 20:46:08 +0000 (20:46 +0000)]
2010-08-29 Pawel Hajdan <phajdan.jr@chromium.org>
Reviewed by Darin Adler.
Fix libxml workarounds to work with recent versions of libxml.
I was testing locally with libxml2-2.7.6.
https://bugs.webkit.org/show_bug.cgi?id=30508
Based on patch by Philippe Normand <pnormand@igalia.com>.
This also fixes a Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=29333
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::switchToUTF16):
(WebCore::XMLParserContext::createStringParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::startDocumentHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 29 Aug 2010 20:41:46 +0000 (20:41 +0000)]
Try to fix Windows build.
* rendering/style/ContentData.h: Added include of CounterContent.h.
* css/CSSStyleSelector.cpp: Removed include of CounterContent.h.
* rendering/style/ContentData.cpp: Ditto.
* rendering/style/RenderStyle.cpp: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 29 Aug 2010 19:56:50 +0000 (19:56 +0000)]
2010-08-29 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Deploy OwnPtr, PassOwnPtr, and adoptPtr in some CSS-related files
https://bugs.webkit.org/show_bug.cgi?id=44834
* css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::CSSFunctionValue): Updated since
CSSParserFunction::args is an OwnPtr.
(WebCore::CSSFunctionValue::parserValue): Ditto.
* css/CSSGrammar.y: Added leakPtr calls for putting MediaQueryExp*
into the media query expression list, which is a vector of raw pointers
that are deleted explicitly.
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::setCSSStyleSheet): Updated to use document instead of doc.
(WebCore::CSSImportRule::insertedIntoParent): Ditto.
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc): Ditto.
* css/CSSNamespace.h: Took the "m_" off the names of the data members of
this structure. Used OwnPtr for the parent data member. Rewrote the
namespaceForPrefix function so it's iterative instead of recursive.
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser): Update since m_mediaQuery, m_floatingMediaQuery,
m_floatingMediaQueryExp, and m_floatingMediaQueryExpList are now all OwnPtr and
thus don't need to be initialized.
(WebCore::CSSParser::~CSSParser): Update to not delete the above OwnPtr.
(WebCore::CSSParser::parseMediaQuery): Replaced the code that sets m_mediaQuery
to 0 with an assertion. Also use release when passing the media query to
appendMediaQuery.
(WebCore::CSSParser::document): Updated to use document instead of doc and to
use early return instead of a nested if.
(WebCore::CSSParser::parseContent): Added a get() call needed since
CSSParserFunction::args is an OwnPtr.
(WebCore::CSSParser::parseAnimationTimingFunction): Ditto.
(WebCore::CSSParser::parseDashboardRegions): Ditto.
(WebCore::CSSParser::parseShape): Ditto.
(WebCore::isValidFormatFunction): Ditto.
(WebCore::CSSParser::parseFontFaceSrc): Ditto.
(WebCore::CSSParser::parseColorParameters): Ditto.
(WebCore::CSSParser::parseHSLParameters): Ditto.
(WebCore::parseGradientColorStop): Ditto.
(WebCore::CSSParser::parseGradient): Ditto.
(WebCore::CSSParser::parseCanvas): Ditto.
(WebCore::CSSParser::parseTransform): Ditto.
(WebCore::CSSParser::createFloatingMediaQueryExp): Updated to use adoptPtr and
remove the explicit deletion.
(WebCore::CSSParser::sinkFloatingMediaQueryExp): Updated to use release.
(WebCore::CSSParser::createFloatingMediaQueryExpList): Ditto.
(WebCore::CSSParser::sinkFloatingMediaQueryExpList): Ditto.
(WebCore::CSSParser::createFloatingMediaQuery): Ditto.
(WebCore::CSSParser::sinkFloatingMediaQuery): Ditto.
(WebCore::CSSParser::checkForVariables): Use get for CSSParserFunction::args.
* css/CSSParser.h: Made return values for sinkFloatingMediaQueryExp,
sinkFloatingMediaQueryExpList, and sinkFloatingMediaQuery be PassOwnPtr.
Made createFloatingMediaQuery take a PassOwnPtr. Made m_mediaQuery,
m_floatingMediaQuery, m_floatingMediaQueryExp, and m_floatingMediaQueryExpList
be OwnPtr.
* css/CSSParserValues.h: Made args be an OwnPtr.
* css/CSSStyleSelector.cpp: Made CSSRuleSet m_universalRules and m_pageRules
be OwnPtr.
(WebCore::CSSStyleSelector::CSSStyleSelector): Use document instead of doc.
Got rid of the init function, only called here, because it did nothing that
wasn't already done. Eliminated unneeded code to set m_userStyle to 0, since
it's now an OwnPtr and will be 0 automatically. Use adoptPtr when initializing
m_medium, m_authorStyle, and m_useStyle.
(WebCore::CSSStyleSelector::~CSSStyleSelector): Got rid of unneeded delete of
m_medium, m_authorStyle, and m_userStyle, and unneded clear of m_keyframesRuleMap.
(WebCore::CSSStyleSelector::styleForElement): Use get with m_userStyle and
m_authorStyle.
(WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto.
(WebCore::CSSStyleSelector::styleForPage): Ditto.
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto.
(WebCore::CSSRuleSet::CSSRuleSet): Got rid of unneeded initialization of
m_universalRules and m_pageRules.
(WebCore::CSSRuleSet::~CSSRuleSet): Got rid of unneeed deletion of same.
(WebCore::CSSRuleSet::addRule): Use adoptPtr to initialize m_universalRules.
(WebCore::CSSRuleSet::addPageRule): Use adoptPtr to initialize m_pageRules.
(WebCore::CSSStyleSelector::applyProperty): Use adopPtr to create counter
context object.
* css/CSSStyleSelector.h: Made m_authorStyle, m_userStyle, and m_medium use
OwnPtr. Got rid of init function.
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::CSSStyleSheet): Updatd for name change from m_doc
and doc to m_document and document. Eliminated unneeded initialization of
m_namespaces now that it is an OwnPtr.
(WebCore::CSSStyleSheet::~CSSStyleSheet): Got rid of unneeded deletion of same.
(WebCore::CSSStyleSheet::cssRules): Updated doc to document.
(WebCore::CSSStyleSheet::addNamespace): Added adopPtr when setting m_namespaces.
(WebCore::CSSStyleSheet::determineNamespace): Updated for changes to the
CSSNamespace class, using uri data member instead of function.
(WebCore::CSSStyleSheet::styleSheetChanged): Use document instead of doc.
* css/CSSStyleSheet.h: Renamed doc and m_doc to document and m_document.
Made m_namespaces an OwnPtr.
* css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList): Clean up logic a bit.
(WebCore::CSSValueList::createParserValueList): Clean up logic a bit and
return a PassOwnPtr.
* css/CSSValueList.h: Changed createParserValueList to return a PassOwnPtr.
* css/CSSVariablesDeclaration.cpp:
(WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc): Updated to use
document instead of doc.
* css/MediaList.cpp:
(WebCore::MediaList::deleteMedium): Use OwnPtr instead of a boolean to
make sure the newly-created query here is deleted.
(WebCore::MediaList::appendMediaQuery): Updated to take PassOwnPtr.
* css/MediaList.h: Changed appendMediaQuery to take a PassOwnPtr.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getStyleSheet): Use document instead of doc.
(WebCore::InspectorDOMAgent::getRuleRanges): Ditto.
(WebCore::InspectorDOMAgent::buildObjectForStyleSheet): Ditto.
* rendering/style/ContentData.cpp:
(WebCore::ContentData::clear): Update since data members are OwnPtr.
Also, fixed iterative deletion algorithm to be much simpler.
(WebCore::ContentData::dataEquivalent): Added FIXMEs and tweaked formatting.
(WebCore::ContentData::deleteContent): Tweaked formatting.
* rendering/style/ContentData.h: Changed m_next to an OwnPtr.
Added assertions to getters to check that we get the correct type.
Use leakRef instead of releaseRef. Changed setCounter and setNext functions
to take PassOwnPtr arguments.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::prepareToSetContent): Refactored common part of the
into a shared function so the three setContent functions don't have to repeat
the logic. Used an OwnPtr to avoid confusing logic and leakPtr.
(WebCore::RenderStyle::setContent): Changed argument to PassOwnPtr.
* rendering/style/RenderStyle.h: Changed setContent argument to a PassOwnPtr.
Added declaration of prepareToSetContent helper function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 29 Aug 2010 18:04:14 +0000 (18:04 +0000)]
2010-08-29 Adam Barth <abarth@webkit.org>
Turns out we're supposed to use find instead of children here.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 29 Aug 2010 17:59:54 +0000 (17:59 +0000)]
2010-08-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Awesomify pretty-diff based review tool
https://bugs.webkit.org/show_bug.cgi?id=44835
This patch replaces the existing inline comment feature with a new
implementation. Hopefully the new implementation is more awesome.
It's not 100% done yet, but I'd like to get this version out there to
see how it works.
Unlike the previous version this version works with the "Formatted
Diff" link instead of the "Review Patch" link. Hopefully that will
avoid interfering with folks who like the old style review.
* PrettyPatch/PrettyPatch.rb:
* code-review.js: Added.
* prototype.js: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 29 Aug 2010 14:12:34 +0000 (14:12 +0000)]
2010-08-29 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Port ScrollbarThemeWin to WinCE
https://bugs.webkit.org/show_bug.cgi?id=44818
Add a #ifdef around usage of unsupported DFCS_FLAT.
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::paintButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 29 Aug 2010 13:55:56 +0000 (13:55 +0000)]
2010-08-29 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Port SystemInfo to WinCE
https://bugs.webkit.org/show_bug.cgi?id=44817
* platform/win/SystemInfo.cpp:
(WebCore::isRunningOnVistaOrLater):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeremy@chromium.org [Sun, 29 Aug 2010 06:45:51 +0000 (06:45 +0000)]
2010-08-28 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dimitri Glazkov.
First step in unforking Chrome's FontPlatformDataMac.mm.
Move files from platform/graphics/mac to platform/graphics/cocoa
https://bugs.webkit.org/show_bug.cgi?id=41398
Just moving files around so no new tests.
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/cocoa: Added.
* platform/graphics/cocoa/FontPlatformData.h: Copied from WebCore/platform/graphics/mac/FontPlatformData.h.
* platform/graphics/cocoa/FontPlatformDataCocoa.mm: Copied from WebCore/platform/graphics/mac/FontPlatformDataMac.mm.
* platform/graphics/mac/FontPlatformData.h: Removed.
* platform/graphics/mac/FontPlatformDataMac.mm: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 29 Aug 2010 05:52:00 +0000 (05:52 +0000)]
Checked in a file missed when I landed just now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 29 Aug 2010 05:48:44 +0000 (05:48 +0000)]
Some IDL attributes don't reflect URL content attributes properly
https://bugs.webkit.org/show_bug.cgi?id=43650
Reviewed by Sam Weinig.
WebCore:
* dom/Document.cpp:
(WebCore::Document::processBaseElement): Added. Implements the rules for base elements
from the HTML5 specification. Handles multiple base elements in the same document.
* dom/Document.h: Removed setBaseElementURL and setBaseElementTarget, replacing them
with processBaseElement.
* html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::parseMappedAttribute): Call the new processBaseElement
function.
(WebCore::HTMLBaseElement::insertedIntoDocument): Ditto.
(WebCore::HTMLBaseElement::removedFromDocument): Ditto.
(WebCore::HTMLBaseElement::isURLAttribute): Added.
(WebCore::HTMLBaseElement::target): Moved here from the .h file and changed to not
realy on an m_target local variable.
* html/HTMLBaseElement.h: Added an override of the isURLAttribute function. Removed
unneeded process function. Removed declaration of nonexistent setHref and setTarget
functions. Removed unneeded m_hrefAttrValue, m_href, and m_target. Moved
implementation of target function into the .cpp file.
* html/HTMLBaseElement.idl: Marked the href attribute as URL.
* html/HTMLBlockquoteElement.cpp:
(WebCore::HTMLBlockquoteElement::isURLAttribute): Added.
* html/HTMLBlockquoteElement.h: Added isURLAttribute.
* html/HTMLBlockquoteElement.idl: Marked the cite attribute as URL.
* html/HTMLEmbedElement.idl: Marked the src attribute as URL.
* html/HTMLFormElement.cpp: Added a comment about the action function, which should
be removed.
* html/HTMLFormElement.idl: Marked the action attribute as URL.
* html/HTMLHtmlElement.cpp:
(WebCore::HTMLHtmlElement::isURLAttribute): Added.
(WebCore::HTMLHtmlElement::insertedIntoDocument): Tweaked a bit.
* html/HTMLHtmlElement.h: Added isURLAttribute.
* html/HTMLHtmlElement.idl: Marked the manifest attribute as URL.
* html/HTMLIFrameElement.idl: Marked the src attribute a URL.
* html/HTMLModElement.cpp:
(WebCore::HTMLModElement::isURLAttribute): Added.
* html/HTMLModElement.h: Added isURLAttribute.
* html/HTMLModElement.idl: Marked the cite attribute as URL.
* html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::isURLAttribute): Added.
* html/HTMLQuoteElement.h: Added isURLAttribute.
* html/HTMLQuoteElement.idl: Marked the cite attribute as URL.
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::processTagToken): Changed code to create a base
element instead of calling setBaseElementURL directly.
(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Use AtomicString instead of String.
(WebCore::HTMLViewSourceDocument::addLine): Ditto.
(WebCore::HTMLViewSourceDocument::addText): Ditto.
(WebCore::HTMLViewSourceDocument::addBase): Added. Creates a base element and inserts it.
(WebCore::HTMLViewSourceDocument::addLink): Use AtomicString instead of String.
* html/HTMLViewSourceDocument.h: Updated function declarations as above.
* bindings/scripts/test/CPP/WebDOMTestCallback.h:
* bindings/scripts/test/CPP/WebDOMTestInterface.h:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
Updated results, which changed due to the fixes for at
least these bugs, and perhaps a few more:
https://bugs.webkit.org/show_bug.cgi?id=42115
https://bugs.webkit.org/show_bug.cgi?id=44597
https://bugs.webkit.org/show_bug.cgi?id=44738
* bindings/scripts/test/TestObj.idl:
* html/HTMLAnchorElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLFormElement.cpp:
* html/HTMLFormElement.idl:
* html/HTMLFrameElement.idl:
* html/HTMLIFrameElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLLinkElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLScriptElement.idl:
* html/HTMLSourceElement.idl:
* html/HTMLVideoElement.idl:
Tweaked formatting.
LayoutTests:
* dom/html/level2/html/button03.js: Added a "WebKit modification" section so this
correctly expects the action attribute to return a completed URL.
* dom/xhtml/level2/html/button03.js: Ditto.
* fast/dom/URL-attribute-reflection-expected.txt: Updaed expected results to expecte
more successes.
* fast/dom/script-tests/URL-attribute-reflection.js:
(testURLReflection): Fixed wrong variable name in the test script.
* http/tests/security/xssAuditor/full-block-iframe-no-inherit.php: Removed a call
to encodeURI that was needed to work around our incorrect implementation of
HTMLIFrameElement's src attribute.
* fast/dom/HTMLBaseElement: Added.
* fast/dom/HTMLBaseElement/multiple-base-elements-expected.txt: Added.
* fast/dom/HTMLBaseElement/multiple-base-elements.html: Added.
* fast/dom/HTMLBaseElement/script-tests: Added.
* fast/dom/HTMLBaseElement/script-tests/TEMPLATE.html:
Copied from fast/dom/HTMLAnchorElement/script-tests/TEMPLATE.html.
* fast/dom/HTMLBaseElement/script-tests/multiple-base-elements.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sun, 29 Aug 2010 05:11:44 +0000 (05:11 +0000)]
2010-08-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
The logic to escape entities in appendEscapedContent and appendAttributeValue should be merged
https://bugs.webkit.org/show_bug.cgi?id=44831
Added appendCharactersReplacingEntities to escape &, <, >, ", and nbsp based on the mask.
Removed escapeContentText because it was only used in appendText, which now directly calls
appendCharactersReplacingEntities. Replaced appendEscapedContent, ucharRange, and appendUCharRange
by appendNodeValue.
No new tests are added since this is a cleanup.
* editing/markup.cpp:
(WebCore::):
(WebCore::appendCharactersReplacingEntities): Added.
(WebCore::MarkupAccumulator::appendAttributeValue): Calls appendCharactersReplacingEntities.
(WebCore::MarkupAccumulator::appendNodeValue): Added.
(WebCore::MarkupAccumulator::appendText): Calls appendNodeValue and appendCharactersReplacingEntities.
(WebCore::urlToMarkup): Calls escapeEntities.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 29 Aug 2010 04:50:12 +0000 (04:50 +0000)]
Update WebKit2 skipped list.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sun, 29 Aug 2010 04:38:58 +0000 (04:38 +0000)]
2010-08-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
cannot remove text-decoration when style is added by u or s
https://bugs.webkit.org/show_bug.cgi?id=44560
The bug was caused by WebKit not pushing down implicitly added styles to descendent nodes.
Fixed the bug by pushing down all elements that implicitly add style.
extractInlineStyleToPushDown now calls removeImplicitlyStyledElement, which was modified to extract
the style implicitly added by the element to extractStyle.
This revealed a bug in applyInlineStyleToPushDown where applyInlineStyleIfNeeded could add
an implicitly styled element inside an element with a conflicting style, thereby overriding the style of the element.
Fixed this by extending the logic to honor the existing inline style declaration used in
the case of rewriting inline style declaration to all cases including the one calling addInlineStyleIfNeeded.
Also fixed a bug in removeInlineStyle where pushDownInlineStyleAroundNode was called on a text node
outside of selection if start was at the end of the text node.
Test: editing/style/push-down-implicit-styles.html
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Added extractedStyle, which receives
the style implicitly added by the element being removed.
(WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Calls removeImplicitlyStyledElement
to remove the implicitly styled element and extract the inline style added by the element.
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Fixed a bug that addInlineStyleIfNeeded
could override the inline style declaration style of the node.
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Uses extractInlineStyleToPushDown
(WebCore::ApplyStyleCommand::removeInlineStyle): See above.
* editing/ApplyStyleCommand.h: Prototype changes.
2010-08-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
cannot remove text-decoration when style is added by u or s
https://bugs.webkit.org/show_bug.cgi?id=44560
Added a test to ensure WebKit removes text-decorations added by u or s
and pushes down implicit styles properly into descendent nodes.
* editing/style/push-down-implicit-styles-expected.txt: Added.
* editing/style/push-down-implicit-styles.html: Added.
* editing/style/script-tests/push-down-implicit-styles.js: Added.
(testSingleToggle):
(selectAll):
(selectTest):
(selectSecondWord):
(selectLastTwoWords):
* editing/style/typing-style-003-expected.txt: Negation of inline
styles are now done by pushing down implicitly styled elements rather than
canceling them by inline style declarations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 29 Aug 2010 03:45:01 +0000 (03:45 +0000)]
Make an internal method used by Apple Mail into SPI
https://bugs.webkit.org/show_bug.cgi?id=44832
rdar://problem/
5748951
Reviewed by Sam Weinig.
* WebView/WebFrame.mm:
(-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Moved this method
from the internal section to the private section.
* WebView/WebFrameInternal.h: Moved the method declaration out of here.
* WebView/WebFramePrivate.h: Moved the method declaration in here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Sun, 29 Aug 2010 03:31:57 +0000 (03:31 +0000)]
[chromium] Add webkit_support.gyp:blob to WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=44829
Reviewed by Darin Fisher.
Also bump up chromium revision in DEPS in order to pick up
the revision that contains blob change.
* DEPS:
* WebKit.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 29 Aug 2010 02:34:47 +0000 (02:34 +0000)]
<webkit.org/b/44802> REGRESSION (r65351): WebCore build fails due to attempting to directly access WebKitTools/Scripts
Reviewed by Adam Barth.
Move create-html-entity-table in to WebCore so that the build is again self-contained.
The script is also updated to take input as a CSV file rather than JSON as the former
can be parsed without requiring a third-party Python module be installed.
.:
* cmake/WebKitMacros.cmake:
WebCore:
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.pri:
* WebCore.xcodeproj/project.pbxproj: Stop copying the input file in to the WebCore framework wrapper.
* html/parser/HTMLEntityNames.in: Added.
* html/parser/HTMLEntityNames.json: Removed.
* html/parser/create-html-entity-table: Renamed from WebKitTools/Scripts/create-html-entity-table.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sun, 29 Aug 2010 01:57:06 +0000 (01:57 +0000)]
Bug 44830 - In Array's prototype functyions we're incorrectly handing large index values
Reviewed by Oliver Hunt.
We are in places casting doubles to unsigneds, and unsigneds to ints, without always check
that the result is within bounds. This is problematic in the case of double-to-unsigned
conversion because we should be saturating to array length.
Also, the error return value from Array.splice should be [], not undefined.
I don't see any security concerns here. These methods are spec'ed in such a way that they
can be applied to non Array objects, so in all cases the (potentially bogus) indices are
being passed to functions that will safely check accesses are within bounds.
JavaScriptCore:
* runtime/ArrayPrototype.cpp:
(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
* runtime/JSValue.h:
(JSC::JSValue::toUInt32):
LayoutTests:
* fast/js/array-splice-expected.txt:
* fast/js/script-tests/array-splice.js:
* fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.10_Array_prototype_slice/S15.4.4.10_A3_T3-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.12_Array_prototype_splice/S15.4.4.12_A2.2_T3-expected.txt:
* fast/js/sputnik/Implementation_Diagnostics/S15.4.4.12_D1.5_T1-expected.txt:
* ietestcenter/Javascript/15.4.4.15-3-26-expected.txt:
* ietestcenter/Javascript/15.4.4.15-3-27-expected.txt:
* ietestcenter/Javascript/15.4.4.15-5-1-expected.txt:
* ietestcenter/Javascript/15.4.4.15-5-12-expected.txt:
* ietestcenter/Javascript/15.4.4.15-5-14-expected.txt:
* ietestcenter/Javascript/15.4.4.15-5-16-expected.txt:
* ietestcenter/Javascript/15.4.4.15-8-9-expected.txt:
* platform/mac-snowleopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 29 Aug 2010 00:30:55 +0000 (00:30 +0000)]
2010-08-28 Daniel Bates <dbates@rim.com>
Attempt to fix Chromium Mac Release bot after changeset 66305 <http://trac.webkit.org/changeset/66305>.
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Added case statements for missing enum values.
These case statements simply fall through to a "break" statement.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sat, 28 Aug 2010 23:06:33 +0000 (23:06 +0000)]
Reviewed by Nikolas Zimmermann.
Add explicit destructor for C++ DOM bindings to avoid memory leaks when using SWIG.
https://bugs.webkit.org/attachment.cgi?bugid=44738
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sat, 28 Aug 2010 23:01:24 +0000 (23:01 +0000)]
Reviewed by Kevin Ollivier.
[BREWMP] Add build system
https://bugs.webkit.org/show_bug.cgi?id=44645
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sat, 28 Aug 2010 22:11:53 +0000 (22:11 +0000)]
[wx] Build fix after parseMode -> compatibilityMode rename.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Sat, 28 Aug 2010 20:10:38 +0000 (20:10 +0000)]
2010-08-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Add WebM MIME types to type registry
https://bugs.webkit.org/show_bug.cgi?id=44826
* platform/MIMETypeRegistry.cpp:
(WebCore::TypeExtensionPair::): Add "video/webm" and "audio/webm" types.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 19:34:00 +0000 (19:34 +0000)]
2010-08-28 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
fast/frames/frame-crash-with-page-cache.html does not pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=44813
Update test to not rely on intervals resuming when going back to a page
in the page cache. Based on the original bug for which this test was
added (34773), intervals were not part of the triggering condition.
* fast/frames/resources/cached-page-1.html:
* fast/frames/resources/cached-page-2.html:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Sat, 28 Aug 2010 18:48:49 +0000 (18:48 +0000)]
2010-08-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Crash reloading fast/events/tabindex-focus-blur-all.html test
https://bugs.webkit.org/show_bug.cgi?id=44743
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::asyncEventTimerFired): If m_isWaitingToDecrementLoadEventDelayCount
is true, call setShouldDelayLoadEvent(false) and set the timer to fire the pending events
on the next idle.
(WebCore::HTMLMediaElement::setShouldDelayLoadEvent): Don't clear the delay from within a
media engine callback because document 'load' event handlers that cause the page to become
inactive will delete the media engine.
* html/HTMLMediaElement.h: Add m_isWaitingToDecrementLoadEventDelayCount.
2010-08-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Crash reloading fast/events/tabindex-focus-blur-all.html test
https://bugs.webkit.org/show_bug.cgi?id=44743
* platform/mac/Skipped: Remove tabindex-focus-blur-all.html from the skip list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sat, 28 Aug 2010 17:38:59 +0000 (17:38 +0000)]
2010-08-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
When properties are missing from animation keyframes, interpolate between those keyframes that specify them
https://bugs.webkit.org/show_bug.cgi?id=40794
Some preliminary cleanup; for vectors, prefer indexed access rather than using iterators.
No behavior changes.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::keyframeStylesForAnimation):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::getKeyframeAnimationInterval):
(WebCore::KeyframeAnimation::validateTransformFunctionList):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
* rendering/style/KeyframeList.h:
(WebCore::KeyframeList::at):
(WebCore::KeyframeList::keyframes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 28 Aug 2010 17:02:06 +0000 (17:02 +0000)]
Speculative fix for <rdar://problem/
7275077> Crash in InlineBox::root() under RenderTextControl::textWithHardLineBreaks()
https://bugs.webkit.org/show_bug.cgi?id=44816
Reviewed by Simon Fraser.
No test because I could not reproduce the crash.
In a common variant of the crash, InlineBox::root() is called with this == 12. This suggests that
a RenderInline* was cast into a RenderBox*, so RenderBox::inlineBoxWrapper() interpreted the
m_lineHeight and m_verticalPosition members of a RenderInline as a pointer to an InlineBox.
The cast into RenderBox* in textWithHardLineBreaks() was introduced in r40881 with no exaplanation.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textWithHardLineBreaks): Fetch the first line directly from the inner
text block instead of relying on the first child being a text node.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 16:56:38 +0000 (16:56 +0000)]
2010-08-28 Moritz Lipp <mlq@pwmt.org>
Reviewed by Xan Lopez.
[GTK] Improper webkit_dom_document_evaluate implementation.
https://bugs.webkit.org/show_bug.cgi?id=42115
The generated webkit_dom_document_evaluate() function does not meet the
evaluate interface described in the W3 Documentation
http://www.w3.org/TR/DOM-Level-3-XPath/xpath.html#XPathEvaluator-evaluate
"If this is specified as nullor the implementation does not reuse the
specified result,...". The current implementation did not accept the
result parameter to be NULL.
* bindings/scripts/CodeGeneratorGObject.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sat, 28 Aug 2010 16:14:19 +0000 (16:14 +0000)]
2010-08-28 Daniel Bates <dbates@rim.com>
Attempt to fix the Qt Windows and Qt Linux Release minimal builds
after changeset 66297 <http://trac.webkit.org/changeset/66297>.
* Api/qwebplugindatabase.cpp:
(QWebPluginDatabase::plugins): Wrap the call to PluginPackage::ensurePluginLoaded
in #if ENABLE(NETSCAPE_PLUGIN_METADATA_CACHE).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 28 Aug 2010 09:43:48 +0000 (09:43 +0000)]
2010-08-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLTreeBuilder needs to call HTMLFormElement::setDemoted
https://bugs.webkit.org/show_bug.cgi?id=44781
This patch teaches the HTMLTreeBuilder about demoted form elements.
Demoting a form element magically stops the form element from
rendering. Demoted form elements are a concept from the
LegacyHTMLTreeBuilder, but they are somewhat of a hack because
rendering should be DOM-based. We'll likely look for a better solution
in a future patch.
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
* html/parser/HTMLConstructionSite.h:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
2010-08-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLTreeBuilder needs to call HTMLFormElement::setDemoted
https://bugs.webkit.org/show_bug.cgi?id=44781
Update test expectations to account for demoted form elements. I spot
checked a bunch of these and this change is the reverse of the change
to these expectations in http://trac.webkit.org/changeset/64712. At
the time, we thought these rendering changes were correct because the
DOM was correct. However, demoted form elements have magical
non-DOM-based rendering.
* platform/mac/fast/forms/form-added-to-table-expected.txt:
* platform/mac/fast/forms/formmove3-expected.txt:
* platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
* platform/mac/fast/table/fixed-table-non-cell-in-row-expected.txt:
* platform/mac/fast/table/inline-form-assert-expected.txt:
* platform/mac/fast/table/insert-cell-before-form-expected.txt:
* platform/mac/fast/table/insert-row-before-form-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2516-expected.txt:
* platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
* platform/mac/tables/mozilla/bugs/bug32447-expected.txt:
* platform/mac/tables/mozilla/bugs/bug34538-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
* platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
* platform/mac/tables/mozilla/bugs/bug96343-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 09:30:38 +0000 (09:30 +0000)]
2010-08-28 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472
Test by running platform/chromium/accessibility/children-changed-notification.html within chromium's DRT
* platform/chromium/accessibility: Added.
* platform/chromium/accessibility/children-changed-notification-expected.txt: Added.
* platform/chromium/accessibility/children-changed-notification.html: Added.
* platform/chromium/drt_expectations.txt:
* platform/chromium/test_expectations.txt:
2010-08-28 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472
Test by running platform/chromium/accessibility/children-changed-notification.html within chromium's DRT
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::childrenChanged):
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
* page/chromium/ChromeClientChromium.h:
2010-08-28 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472
* public/WebViewClient.h:
(WebKit::WebViewClient::didChangeAccessibilityObjectChildren):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::didChangeAccessibilityObjectChildren):
* src/ChromeClientImpl.h:
2010-08-28 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472
* DumpRenderTree/chromium/AccessibilityController.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::reset):
(AccessibilityController::getRootElement):
(AccessibilityController::dumpAccessibilityNotifications):
* DumpRenderTree/chromium/AccessibilityController.h:
(AccessibilityController::shouldDumpAccessibilityNotifications):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didChangeAccessibilityObjectChildren):
* DumpRenderTree/chromium/WebViewHost.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 28 Aug 2010 09:09:14 +0000 (09:09 +0000)]
2010-08-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Update commit-queue failure message
https://bugs.webkit.org/show_bug.cgi?id=44798
The commit-queue auto-restarts itself and has for a very long time.
No need for people to email me to request a restart anymore.
* Scripts/webkitpy/common/net/bugzilla.py:
* Scripts/webkitpy/common/net/bugzilla_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 08:49:02 +0000 (08:49 +0000)]
2010-08-28 Eric Uhrhane <ericu@chromium.org>
Reviewed by Darin Fisher.
Implement the DOM FileWriter class
https://bugs.webkit.org/show_bug.cgi?id=44362
No new tests until the delegate class has an implementation; bug logged.
Build file additions.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
The AsyncFileWriter is an abstract interface to which FileWriter delegates all the hard work.
* html/AsyncFileWriter.h: Added.
The FileWriterClient is the interface for communications back from the AsyncFileWriter [success/failure, progress events].
* html/FileWriterClient.h: Added.
(WebCore::FileWriterClient::~FileWriterClient):
Added all delegation, state tracking, and progress event processing.
* html/FileWriter.cpp:
(WebCore::FileWriter::FileWriter):
(WebCore::FileWriter::initialize):
(WebCore::FileWriter::~FileWriter):
ActiveDomObject stuff
(WebCore::FileWriter::hasPendingActivity):
(WebCore::FileWriter::stop):
(WebCore::FileWriter::write):
FileWriter public interface
(WebCore::FileWriter::seek):
(WebCore::FileWriter::truncate):
(WebCore::FileWriter::abort):
FileWriterClient interface
(WebCore::FileWriter::didWrite):
(WebCore::FileWriter::didTruncate):
(WebCore::FileWriter::didFail):
Progress events
(WebCore::FileWriter::fireEvent):
* html/FileWriter.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 08:31:10 +0000 (08:31 +0000)]
2010-08-28 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Dimitri Glazkov.
Preparatory patch to split libwebcore in multiple libraries.
Start with a webcore_prerequisites pseudo-target what will be the common
target for all the other ones.
* WebCore.gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 07:58:54 +0000 (07:58 +0000)]
2010-08-28 Pratik Solanki <psolanki@apple.com>
Reviewed by Dan Bernstein.
Add an ENABLE define for purgeable memory support
https://bugs.webkit.org/show_bug.cgi?id=44777
* wtf/Platform.h:
2010-08-28 Pratik Solanki <psolanki@apple.com>
Reviewed by Dan Bernstein.
Add an ENABLE define for purgeable memory support
https://bugs.webkit.org/show_bug.cgi?id=44777
* platform/PurgeableBuffer.h:
* platform/mac/PurgeableBufferMac.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 07:26:25 +0000 (07:26 +0000)]
2010-08-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Fix error message when theme loading fails
https://bugs.webkit.org/show_bug.cgi?id=44775
Parameters for logging were in the wrong order.
No new functionality so no new tests.
* platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::setParent): exchange argument order in log function
call
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 28 Aug 2010 06:56:27 +0000 (06:56 +0000)]
2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
REGRESSION: some tests no longer painting
https://bugs.webkit.org/show_bug.cgi?id=44773
Fix regression from the RenderImageResource introduction, fast/canvas/canvas-as-image.html
and fast/canvas/canvas-as-image-incremental-repaint.html pixel tests did not work anymore.
* rendering/RenderImageResource.h:
(WebCore::RenderImageResource::hasImage): Make hasImage virtual.
* rendering/RenderImageResourceStyleImage.h:
(WebCore::RenderImageResourceStyleImage::hasImage): Always return true, just like RenderImageGeneratedContent did.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Sat, 28 Aug 2010 05:18:29 +0000 (05:18 +0000)]
2010-08-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Antonio Gomes.
[Qt] tst_QWebView::focusInputTypes() fails on MeeGo Handset with WebKit 2.1
https://bugs.webkit.org/show_bug.cgi?id=44761
Make the test more robust to changes in the execution environment. The click
are now correctly simulated, and the position are determined from the content.
The test also create the view and page on the stack to avoid the leak when the
test is failing.
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::focusInputTypes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 04:32:17 +0000 (04:32 +0000)]
2010-08-27 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] NPAPI Plugin metadata should be cached, and loading a plugin should not require loading every plugin
https://bugs.webkit.org/show_bug.cgi?id=43179
Add ENABLE_NETSCAPE_PLUGIN_METADATA_CACHE flag to enable persistent
NPAPI Plugin Cache. The flag is enabled by default.
* wtf/Platform.h: Add ENABLE_NETSCAPE_PLUGIN_METADATA_CACHE
2010-08-27 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Cache plugin info to a persistent database
https://bugs.webkit.org/show_bug.cgi?id=43179
Implement a cache of NPAPI plugin metadata. Write the metadata to aa
file that gets rewritten if any plugin is added / removed. Compilation
of the feature is controlled by #if ENABLE(NETSCAPE_PLUGIN_METADATA_CACHE)
Currently only enabled for Qt UNIX flavors.
* WebCore.pro: Enable NETSCAPE_PLUGIN_METADATA_CACHE for UNIX builds
* platform/qt/FileSystemQt.cpp:
(WebCore::openFile): Added.
(WebCore::readFromFile): Added.
* plugins/PluginDatabase.cpp:
(WebCore::persistentPluginMetadataCachePath): Static accessor for the path
(WebCore::PluginDatabase::PluginDatabase): Add instance variable.
(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::pluginForMIMEType): Ensure returned plugin is loaded.
(WebCore::PluginDatabase::MIMETypeForExtension): Ensure returned plugin is loaded.
(WebCore::PluginDatabase::clear):
(WebCore::fillBufferWithContentsOfFile): Static helper function.
(WebCore::readUTF8String): Static helper function.
(WebCore::readTime): Static helper function.
(WebCore::PluginDatabase::loadPersistentMetadataCache):
(WebCore::writeUTF8String): Static helper function.
(WebCore::writeTime): Static helper function.
(WebCore::PluginDatabase::updatePersistentMetadataCache): Added.
(WebCore::PluginDatabase::isPersistentMetadataCacheEnabled): Added.
(WebCore::PluginDatabase::setPersistentMetadataCacheEnabled):Added.
(WebCore::PluginDatabase::persistentMetadataCachePath): Added.
(WebCore::PluginDatabase::setPersistentMetadataCachePath): Added.
* plugins/PluginDatabase.h:
* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::PluginPackage): Add instance variable.
(WebCore::PluginPackage::createPackageFromCache): Added.
(WebCore::PluginPackage::ensurePluginLoaded): Added.
* plugins/PluginPackage.h:
(WebCore::PluginPackage::fullMIMEDescription): Added.
* plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::fetchInfo): Split mime parsing.
(WebCore::PluginPackage::setMIMEDescription): Added. Mime parsing.
2010-08-27 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Cache plugin info to a persistent database
https://bugs.webkit.org/show_bug.cgi?id=43179
Implement a cache of NPAPI plugin metadata. Write the metadata to aa
file that gets rewritten if any plugin is added / removed. Compilation
of the feature is controlled by #if ENABLE(NETSCAPE_PLUGIN_METADATA_CACHE)
Currently only enabled for Qt UNIX flavors.
* Api/qwebplugindatabase.cpp:
(QWebPluginDatabase::plugins): Match previous behavior: ensure all returned plugins are loaded.
* Api/qwebsettings.cpp:
(QWebSettings::enablePersistentStorage): Set plugin cache path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sat, 28 Aug 2010 03:06:14 +0000 (03:06 +0000)]
2010-08-27 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Implement symbolic CSS3 list-style-types
https://bugs.webkit.org/show_bug.cgi?id=36734
Implements all of the symbolic CSS3 list-style-types as per
section 4.5 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#symbolic>.
Test: fast/lists/w3-css3-list-styles-symbolic.html
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added list style types Asterisks and Footnotes.
* css/CSSValueKeywords.in: Ditto.
* inspector/front-end/SourceCSSTokenizer.re2js: Ditto.
* rendering/RenderListMarker.cpp:
(WebCore::toAlphabeticOrNumeric): Changed type of parameter sequenceSize from int to unsigned.
(WebCore::toSymbolic): Added.
(WebCore::toAlphabetic): Changed type of parameter alphabetSize from int to unsigned.
(WebCore::toNumeric): Changed type of parameter numeralsSize from int to unsigned.
(WebCore::effectiveListMarkerType): Added.
(WebCore::listMarkerSuffix): Added list style types Asterisks and Footnotes.
(WebCore::listMarkerText): Ditto.
(WebCore::RenderListMarker::paint): Ditto.
(WebCore::RenderListMarker::calcPrefWidths): Ditto.
(WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
* rendering/style/RenderStyleConstants.h: Ditto.
(WebCore::):
2010-08-27 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Implement symbolic CSS3 list-style-types
https://bugs.webkit.org/show_bug.cgi?id=36734
Tests that all of the symbolic CSS3 list-style-types are supported.
* fast/lists/w3-css3-list-styles-symbolic-expected.txt: Added.
* fast/lists/w3-css3-list-styles-symbolic.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 03:01:32 +0000 (03:01 +0000)]
2010-08-27 Vincent Scheib <scheib@chromium.org>
Reviewed by Darin Fisher.
CanvasRenderingContext2D::willDraw changed to didDraw
Solves issue with canvas to canvas draw calls, and simplifies
mixed software and GPU acceleration of GraphicsContext implementations
which must track dirty rects for backing stores.
https://bugs.webkit.org/show_bug.cgi?id=44741
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::didDraw):
* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::clearRect):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::strokeRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
(WebCore::CanvasRenderingContext2D::didDraw):
(WebCore::CanvasRenderingContext2D::putImageData):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::markContextChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 02:41:42 +0000 (02:41 +0000)]
2010-08-27 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
Canvas test 2d.composite.operation.clear failing
https://bugs.webkit.org/show_bug.cgi?id=43226
* canvas/philip/tests/2d.composite.operation.foobar.html: Added.
Tests if bogus composite ops are ignored.
* platform/mac/Skipped: Added comment about why original clear
test should remain on the skip list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 02:25:11 +0000 (02:25 +0000)]
2010-08-27 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Add new WebClipboard method for setting generic data in copy/cut handlers.
https://bugs.webkit.org/show_bug.cgi?id=42121
No new tests.
* platform/chromium/ChromiumBridge.h:
2010-08-27 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Add new WebClipboard method for setting generic data in copy/cut handlers.
https://bugs.webkit.org/show_bug.cgi?id=42121
* public/WebClipboard.h:
(WebKit::WebClipboard::writeData):
(WebKit::WebClipboard::readFilenames):
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::clipboardWriteData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 28 Aug 2010 02:16:40 +0000 (02:16 +0000)]
Add UserContent API to WebKit2 InjectedBundle
<rdar://problem/
8367587>
https://bugs.webkit.org/show_bug.cgi?id=44810
Reviewed by Dan Bernstein.
The new API differs from the version in WebKit1 in that the function do not take
a group name since we currently do not expose a way to make multiple PageGroups in
the API.
* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
(toUserScriptInjectionTime):
(toUserContentInjectedFrames):
Add conversion functions for enums.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleAddUserScript):
(WKBundleAddUserStyleSheet):
(WKBundleRemoveUserScript):
(WKBundleRemoveUserStyleSheet):
(WKBundleRemoveUserScripts):
(WKBundleRemoveUserStyleSheets):
(WKBundleRemoveAllUserContent):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::toStringVector):
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):
* WebProcess/InjectedBundle/InjectedBundle.h:
Forward API to PageGroup.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::sharedPageGroup):
(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
* WebProcess/WebProcess.h: Ad accessor for global PageGroup.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 01:58:15 +0000 (01:58 +0000)]
2010-08-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Remove unnecessary AlphaBlend in PasteboardWin.
https://bugs.webkit.org/show_bug.cgi?id=44720
Replacing AlphaBlend with BitBlt is safe because testing showed that alpha
never survives copy-and-paste on Windows in any browser, and StretchBlt
was a overkill since the source and destination size are always equal.
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Sat, 28 Aug 2010 01:46:15 +0000 (01:46 +0000)]
2010-08-27 Tony Chang <tony@chromium.org>
Not reviewed, adding two more files to chromium's test_expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Sat, 28 Aug 2010 01:21:46 +0000 (01:21 +0000)]
Add tests to the WebKit2 skipped list.
Rubber-stamped by Brady Eidson.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Sat, 28 Aug 2010 01:05:46 +0000 (01:05 +0000)]
2010-08-26 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
https://bugs.webkit.org/show_bug.cgi?id=38282
* platform/graphics/skia/GraphicsContext3DSkia.cpp: Dealing with the case of texImage2D with HTMLCanvasElement input.
(WebCore::GraphicsContext3D::getImageData):
2010-08-26 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
https://bugs.webkit.org/show_bug.cgi?id=38282
* fast/canvas/webgl/gl-teximage-expected.txt: Adding back the tests using canvas as texImage2D input.
* fast/canvas/webgl/gl-teximage.html: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vangelis@chromium.org [Sat, 28 Aug 2010 00:57:00 +0000 (00:57 +0000)]
2010-08-26 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
[chromium] Working around compile issue in LayerRendererChromium.cpp
when DEBUG_GL_CALLS=1
https://bugs.webkit.org/show_bug.cgi?id=44739
No new functionality, no new tests.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayerIntoStencilBuffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 28 Aug 2010 00:54:22 +0000 (00:54 +0000)]
2010-08-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Port SoftLinking to WinCE
https://bugs.webkit.org/show_bug.cgi?id=44693
WinCE provides GetProcAddressW and GetProcAddressA for softlinking.
Unfortunately WinNT provides only GetProcAddress (without A or W).
Add a platform dependent macro for GetProcAddress.
* platform/win/SoftLinking.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 28 Aug 2010 00:44:48 +0000 (00:44 +0000)]
2010-08-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] ScrollbarThemeGtk should account for the trough_under_steppers property
https://bugs.webkit.org/show_bug.cgi?id=44742
No new tests until this code is activated, at which point pixel tests will
test the scrollbar rendering.
* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::paintTrackBackground): Only inflate the track background
if the style specifies trough_under_steppers.
(WebCore::ScrollbarThemeGtk::paint): If the theme specifies trough_under_steppers,
a dirty stepper also triggers a repaint of the trough region.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Sat, 28 Aug 2010 00:23:27 +0000 (00:23 +0000)]
2010-08-27 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Alexey Proskuryakov.
LayoutTests:
2010-08-27 Joseph Pecoraro <joepeck@webkit.org>
Extra Events triggered by <input> on focus
https://bugs.webkit.org/show_bug.cgi?id=44731
* fast/events/input-focus-no-duplicate-events-expected.txt: Added.
* fast/events/input-focus-no-duplicate-events.html: Added.
* fast/events/input-tab-focus-no-duplicate-events-expected.txt: Added.
* fast/events/input-tab-focus-no-duplicate-events.html: Added.
WebCore:
2010-08-27 Joseph Pecoraro <joepeck@webkit.org>
Extra Events triggered by <input> on focus
https://bugs.webkit.org/show_bug.cgi?id=44731
Tests: fast/events/input-focus-no-duplicate-events.html
fast/events/input-tab-focus-no-duplicate-events.html
* dom/Element.cpp:
(WebCore::Element::focus): do not continue and update the appearance of the element if it was not focused.
* page/FocusController.cpp:
(WebCore::FocusController::setFocusedNode): respect the return value of Document::setFocusedNode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log