loislo@chromium.org [Sat, 12 Mar 2011 11:26:16 +0000 (11:26 +0000)]
2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix.
Almost all inspector tests are crashing after r80928.
* inspector/front-end/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Sat, 12 Mar 2011 09:10:38 +0000 (09:10 +0000)]
2011-03-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up to error reporting, fixing multiple regressions.
https://bugs.webkit.org/show_bug.cgi?id=56243
* inspector/elements/elements-panel-search.html:
2011-03-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up to error reporting, fixing multiple regressions.
https://bugs.webkit.org/show_bug.cgi?id=56243
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::setPropertyValue):
* inspector/InjectedScript.h:
* inspector/Inspector.idl:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getChildNodes):
(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::setPropertyValue):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.setNodeName):
(WebInspector.DOMNode.prototype.setNodeValue):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype.getOuterHTML):
(WebInspector.DOMNode.prototype.setOuterHTML):
(WebInspector.DOMNode.prototype.removeNode):
(WebInspector.DOMNode.prototype.copyNode):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
(WebInspector.EventListeners.getEventListenersForNode):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage.prototype.getEntries):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype.update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
(WebInspector.ElementsTreeElement.prototype.updateChildren):
():
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.evaluate):
* inspector/front-end/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 08:24:53 +0000 (08:24 +0000)]
Unreviewed build fix.
Fix GTK+ builds by wrapping sections of full screen code in USE(ACCELERATED_COMPOSITING)
checks.
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 12 Mar 2011 08:07:16 +0000 (08:07 +0000)]
2011-03-12 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix.
[EFL] Fix build break because of several reason.
https://bugs.webkit.org/show_bug.cgi?id=56244
* CMakeLists.txt: Add missing files.
* platform/posix/FileSystemPOSIX.cpp: Add PLATFORM(EFL).
2011-03-12 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix.
[EFL] Fix build break because of several reason.
https://bugs.webkit.org/show_bug.cgi?id=56244
* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_path_set):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Sat, 12 Mar 2011 07:21:34 +0000 (07:21 +0000)]
2011-03-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move profiler related methods from inspector agent to profiler agent
https://bugs.webkit.org/show_bug.cgi?id=56204
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::populateScriptObjects):
(WebCore::InspectorAgent::showProfilesPanel):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::enableProfiler):
(WebCore::InspectorController::disableProfiler):
(WebCore::InspectorController::profilerEnabled):
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
(WebCore::InspectorController::isRecordingUserInitiatedProfile):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::profilerEnabledImpl):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::setFrontend):
(WebCore::InspectorProfilerAgent::clearFrontend):
(WebCore::InspectorProfilerAgent::restore):
(WebCore::InspectorProfilerAgent::restoreEnablement):
(WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
(WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
* inspector/InspectorProfilerAgent.h:
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileType.prototype.buttonClicked):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._toggleProfiling):
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 12 Mar 2011 05:38:13 +0000 (05:38 +0000)]
2011-03-11 Anton D'Auria <adauria@apple.com>
Reviewed by Brady Eidson.
Adding StorageTracker tests to skip lists of platforms that don't support it.
https://bugs.webkit.org/show_bug.cgi?id=51878
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 05:28:40 +0000 (05:28 +0000)]
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
https://bugs.webkit.org/show_bug.cgi?id=56226
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer().
(WebCore::Document::webkitDidEnterFullScreenForElement): Ditto.
(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 05:16:36 +0000 (05:16 +0000)]
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220
* WebProcess/FullScreen/WebFullScreenManager.cpp: .
(WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
(WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
(WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
(WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
(WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
(WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
* WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
concrete subclass.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
(-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
(-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
(-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
(-[WebFullScreenManagerAnimationListener invalidate]): Added.
(WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
(WebKit::WebFullScreenManagerMac::create): Added.
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
which will animate the full screen renderer from its initial position to its final one.
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 04:52:29 +0000 (04:52 +0000)]
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220
* WebProcess/FullScreen/WebFullScreenManager.cpp: .
(WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
(WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
(WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
(WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
(WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
(WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
* WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
concrete subclass.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
(-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
(-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
(-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
(-[WebFullScreenManagerAnimationListener invalidate]): Added.
(WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
(WebKit::WebFullScreenManagerMac::create): Added.
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
which will animate the full screen renderer from its initial position to its final one.
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 04:19:39 +0000 (04:19 +0000)]
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220
* WebProcess/FullScreen/WebFullScreenManager.cpp: .
(WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
(WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
(WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
(WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
(WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
(WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
* WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
concrete subclass.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
(-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
(-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
(-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
(-[WebFullScreenManagerAnimationListener invalidate]): Added.
(WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
(WebKit::WebFullScreenManagerMac::create): Added.
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
which will animate the full screen renderer from its initial position to its final one.
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 04:01:56 +0000 (04:01 +0000)]
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
https://bugs.webkit.org/show_bug.cgi?id=56226
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer().
(WebCore::Document::webkitDidEnterFullScreenForElement): Ditto.
(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220
* WebProcess/FullScreen/WebFullScreenManager.cpp: .
(WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
(WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
(WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
(WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
(WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
(WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
* WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
concrete subclass.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
(-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
(-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
(-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
(-[WebFullScreenManagerAnimationListener invalidate]): Added.
(WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
(WebKit::WebFullScreenManagerMac::create): Added.
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
which will animate the full screen renderer from its initial position to its final one.
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Sat, 12 Mar 2011 03:35:22 +0000 (03:35 +0000)]
Support encoding /decoding WebData in usermessages
https://bugs.webkit.org/show_bug.cgi?id=56158
Reviewed by Sam Weinig.
Added encoding/decoding for APIObject::TypeData
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Sat, 12 Mar 2011 03:32:33 +0000 (03:32 +0000)]
Add api for "remove" to WKMutableDictionary
https://bugs.webkit.org/show_bug.cgi?id=56157
Reviewed by Sam Weinig.
* Shared/API/c/WKMutableDictionary.cpp:
(WKDictionaryRemoveItem): Added; call remove on MutableDictionary impl.
* Shared/API/c/WKMutableDictionary.h:
* Shared/MutableDictionary.cpp:
(WebKit::MutableDictionary::remove): Added; call remove on the underlying hashmap.
* Shared/MutableDictionary.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 12 Mar 2011 03:12:05 +0000 (03:12 +0000)]
2011-03-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214
This patch makes sure that all JSCell pointers written to
the registerfile are correctly tagged as JSCells, and replaces
raw int usage with the immediate representation.
For performance, register pressure, and general saneness reasons
I've added abstractions for reading and writing the tag
and payload of integer registers directly for the JSVALUE64
encoding.
* interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::withCallee):
(JSC::Register::operator=):
(JSC::Register::i):
(JSC::Register::activation):
(JSC::Register::function):
(JSC::Register::propertyNameIterator):
(JSC::Register::scopeChain):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutToCallFrameHeader):
(JSC::JIT::emitPutCellToCallFrameHeader):
(JSC::JIT::emitPutIntToCallFrameHeader):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_load_varargs):
(JSC::JIT::emitSlow_op_load_varargs):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::intPayloadFor):
(JSC::JSInterfaceJIT::intTagFor):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):
2011-03-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214
Make sure everything builds still.
* bridge/c/c_class.cpp:
* bridge/c/c_runtime.cpp:
* bridge/jni/JavaMethod.cpp:
* plugins/PluginViewNone.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Mar 2011 02:38:32 +0000 (02:38 +0000)]
Fix the 32-bit build.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sat, 12 Mar 2011 02:24:18 +0000 (02:24 +0000)]
2011-03-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80899 and r80912.
http://trac.webkit.org/changeset/80899
http://trac.webkit.org/changeset/80912
https://bugs.webkit.org/show_bug.cgi?id=56236
Caused animation tests to crash on Snow Leopard WebKit2
(Requested by rniwa on #webkit).
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::resize):
* Shared/ShareableBitmap.h:
(WebKit::ShareableBitmap::numBytesForSize):
(WebKit::ShareableBitmap::sizeInBytes):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::update):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::didUpdate):
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::didUpdate):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/SharedMemoryCache.cpp: Removed.
* WebProcess/WebPage/SharedMemoryCache.h: Removed.
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Mar 2011 02:13:14 +0000 (02:13 +0000)]
<rdar://problem/
9124537> Crashes during layout tests due to overrelease of AVFoundation objects.
Rubber-stamped by Eric Carlsson.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAsset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Mar 2011 02:13:09 +0000 (02:13 +0000)]
Adopt the LLVM Compiler for debug builds.
Rubber-stamped by Adam Roben and Sam Weinig.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sat, 12 Mar 2011 01:49:28 +0000 (01:49 +0000)]
Rollout the chromium deps roll as it adds a dependency on a header
that the bots building for WebKit don't seem to have.
Specifically gfx\gl\gl_context_egl.cc depends on d3dcompiler.h
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Sat, 12 Mar 2011 01:46:20 +0000 (01:46 +0000)]
2011-03-11 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Fixes an error with the checkin for https://bugs.webkit.org/show_bug.cgi?id=52468
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Sat, 12 Mar 2011 01:45:41 +0000 (01:45 +0000)]
Windows build fix. Add SharedMemoryCache to the vcproj.
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sat, 12 Mar 2011 01:41:04 +0000 (01:41 +0000)]
Fix prototype-inheritance-expected result due to two changes:
http://src.chromium.org/viewvc/chrome?view=rev&revision=77888 removed "google"
http://trac.webkit.org/changeset/80846 added WebKitAnimation/WebKitAnimationList
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 01:35:56 +0000 (01:35 +0000)]
Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
* loader/icon/IconDatabase.h: Make this guy public.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 01:23:43 +0000 (01:23 +0000)]
Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
* loader/icon/IconDatabase.h:
(WebCore::IconDatabase::delayDatabaseCleanup): Maybe Qt has Icon Database disabled, so we need to define this here?
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 01:21:30 +0000 (01:21 +0000)]
More Windows build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
* WebCoreStatistics.cpp:
* WebIconDatabase.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Sat, 12 Mar 2011 01:07:40 +0000 (01:07 +0000)]
2011-03-11 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Correct return type of WebClipboard::readImage.
https://bugs.webkit.org/show_bug.cgi?id=56234
Update the return type to reflect that we are returning a blob of PNG
data, not a bitmap.
* public/WebClipboard.h:
(WebKit::WebClipboard::readImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sat, 12 Mar 2011 01:05:44 +0000 (01:05 +0000)]
2011-03-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Introduce project_dir variable and make paths a whole lot saner. Ok, a little bit saner.
https://bugs.webkit.org/show_bug.cgi?id=56231
* JavaScriptCore.gypi: Added project_dir variable.
* gyp/JavaScriptCore.gyp: Changed to use project_dir, rather than DEPTH/JavaScriptCore.
* gyp/generate-dtrace-header.sh: Changed to use project_dir.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 00:45:12 +0000 (00:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56216
Fix the Qt build following the same pattern of the patch.
../WebCore:
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseBase.cpp:
(WebCore::IconDatabaseBase::databasePath): Added to the virtual base.
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::isOpen): Ditto.
../WebKit/qt:
Reviewed by attempt at build fix!
* Api/qwebsettings.cpp:
(QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sat, 12 Mar 2011 00:39:09 +0000 (00:39 +0000)]
Source/WebKit/chromium: Update chromium deps to pick up the skia roll.
* DEPS:
LayoutTests: Update some baselines due to Skia update in Chromium.
Filed http://crbug.com/75820 about the odd look of the results (but
the odd look previously existed).
* platform/chromium-linux/svg/css/composite-shadow-text-expected.checksum:
* platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
* platform/chromium-win/svg/css/composite-shadow-text-expected.checksum:
* platform/chromium-win/svg/css/composite-shadow-text-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 12 Mar 2011 00:34:00 +0000 (00:34 +0000)]
2011-03-11 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=56198
Fix conditional which had an int for one case and a pointer for another.
No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 00:29:14 +0000 (00:29 +0000)]
Windows build fix.
* history/HistoryItem.cpp:
* loader/icon/IconDatabaseBase.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sat, 12 Mar 2011 00:25:22 +0000 (00:25 +0000)]
2011-03-11 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=56222
A window remains frozen if web process crashes during printing
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setComplexTextInputEnabled):
* UIProcess/WebPageProxy.h:
Moved setAutodisplay code into WKPrintingView.
* UIProcess/API/mac/WKPrintingView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView printOperationWithPrintInfo:forFrame:]):
Keep a reference to the actual WKView, so that we can manipulate how it displays, even if
page goes away.
* UIProcess/API/mac/WKPrintingView.mm:
(-[WKPrintingView initWithFrameProxy:WebKit::view:]):
(-[WKPrintingView _setAutodisplay:]):
(-[WKPrintingView _suspendAutodisplay]):
(-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
Move setAutodisplay here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 00:17:32 +0000 (00:17 +0000)]
<rdar://problem/
8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
../WebCore:
Reviewed by Sam Weinig.
Project file stuff:
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcproj/WebCore.vcproj:
* loader/icon/IconDatabase.cpp:
* loader/icon/IconDatabase.h: Inherit from IconDatabaseBase.
* loader/icon/IconDatabaseBase.cpp: Added.
(WebCore::IconDatabaseBase::iconURLForPageURL):
(WebCore::iconDatabase):
(WebCore::setGlobalIconDatabase):
* loader/icon/IconDatabaseBase.h: Added.
(WebCore::IconDatabaseBase::IconDatabaseBase):
(WebCore::IconDatabaseBase::~IconDatabaseBase):
(WebCore::IconDatabaseBase::setEnabled):
(WebCore::IconDatabaseBase::isEnabled):
(WebCore::IconDatabaseBase::defaultIcon):
(WebCore::IconDatabaseBase::retainIconForPageURL):
(WebCore::IconDatabaseBase::releaseIconForPageURL):
(WebCore::IconDatabaseBase::iconForPageURL):
(WebCore::IconDatabaseBase::setIconURLForPageURL):
(WebCore::IconDatabaseBase::setIconDataForIconURL):
(WebCore::IconDatabaseBase::iconDataKnownForIconURL):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::pageURLMappingCount):
(WebCore::IconDatabaseBase::retainedPageURLCount):
(WebCore::IconDatabaseBase::iconRecordCount):
(WebCore::IconDatabaseBase::iconRecordCountWithData):
(WebCore::IconDatabaseBase::importIconURLForPageURL):
(WebCore::IconDatabaseBase::importIconDataForIconURL):
(WebCore::IconDatabaseBase::shouldStopThreadActivity):
(WebCore::IconDatabaseBase::open):
(WebCore::IconDatabaseBase::close):
(WebCore::IconDatabaseBase::removeAllIcons):
(WebCore::IconDatabaseBase::setPrivateBrowsingEnabled):
(WebCore::IconDatabaseBase::setClient):
* loader/icon/IconDatabaseNone.cpp: Removed.
../WebKit/mac:
Reviewed by Anders Carlsson
* Misc/WebIconDatabase.mm:
(+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
(-[WebIconDatabase _startUpIconDatabase]): Ditto.
(importToWebCoreFormat):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 12 Mar 2011 00:12:27 +0000 (00:12 +0000)]
2011-03-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a shared memory cache to the web process
https://bugs.webkit.org/show_bug.cgi?id=56232
Add a very simple shared memory cache to the web process, so that we don't have to allocate and
free memory over and over when painting.
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::resize):
* Shared/ShareableBitmap.h:
(WebKit::ShareableBitmap::numBytesNeededForBitmapSize):
(WebKit::ShareableBitmap::sizeInBytes):
Rename numBytesForSize to numBytesNeededForBitmapSize.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::update):
Always send back a DidUpdate message, even if we didn't use the update info.
This is needed so that the web process knows when the UI process is done with the shared memory inside
the update info struct.
* WebKit2.xcodeproj/project.pbxproj:
Add new files.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::didUpdate):
* WebProcess/WebPage/DrawingArea.messages.in:
DidUpdate now takes a boolean.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::sharedMemoryCache):
Add shared memory cache.
(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
Return the shared memory to the cache.
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
display now takes an extra boolean.
(WebKit::DrawingAreaImpl::didUpdate):
Return the shared memory to the cache.
(WebKit::DrawingAreaImpl::display):
If useSharedMemoryCache is true, get shared memory from the cache.
* WebProcess/WebPage/SharedMemoryCache.cpp: Added.
(WebKit::SharedMemoryCache::acquireSharedMemory):
If the memory we currently hold on to is big enough, return it.
(WebKit::SharedMemoryCache::releaseSharedMemory):
If we're already holding on to shared memory, evict it if the returned
shared memory object is bigger than the one we currently hold.
(WebKit::SharedMemoryCache::clearCacheTimerFired):
Null out the shared memory object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 00:07:08 +0000 (00:07 +0000)]
Attempt at a build-fix for https://bugs.webkit.org/show_bug.cgi?id=51878
* page/PageGroup.h: Declare this method, even if the definition will end up being empty.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michaeln@google.com [Fri, 11 Mar 2011 23:57:05 +0000 (23:57 +0000)]
2011-03-11 Michael Nordman <michaeln@google.com>
Reviewed by Dmitry Titov.
Adding the '~' to the dtor (duh).
No new tests.
* storage/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::~SQLCallbackWrapper):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ericu@chromium.org [Fri, 11 Mar 2011 23:44:26 +0000 (23:44 +0000)]
2010-3-11 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Add tests for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44363
Fix small bugs in the utility functions and add setFileContents().
* fast/filesystem/resources/file-writer-utils.js:
Port the GC Blob test over to the new FileWriter utilities.
* fast/filesystem/file-writer-gc-blob-expected.txt:
* fast/filesystem/file-writer-gc-blob.html:
* fast/filesystem/resources/file-writer-gc-blob.js: Copied from LayoutTests/fast/filesystem/file-writer-gc-blob.html.
Add tests for progress events and overlapping writes [via seek].
* fast/filesystem/file-writer-events-expected.txt: Added.
* fast/filesystem/file-writer-events.html: Added.
* fast/filesystem/resources/file-writer-events.js: Added.
* fast/filesystem/file-writer-write-overlapped-expected.txt: Added.
* fast/filesystem/file-writer-write-overlapped.html: Added.
* fast/filesystem/resources/file-writer-write-overlapped.js: Added.
Worker versions of the above tests.
* fast/filesystem/workers/file-writer-events-expected.txt: Added.
* fast/filesystem/workers/file-writer-events.html: Added.
* fast/filesystem/workers/file-writer-gc-blob-expected.html: Added.
* fast/filesystem/workers/file-writer-gc-blob.html: Added.
* fast/filesystem/workers/file-writer-write-overlapped-expected.html: Added.
* fast/filesystem/workers/file-writer-write-overlapped.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carol.szabo@nokia.com [Fri, 11 Mar 2011 23:41:23 +0000 (23:41 +0000)]
2011-03-11 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
Introduced double linkage between a CounterNode and its display renderer.
use of freed pointer in WebCore::RenderCounter::originalText()
https://bugs.webkit.org/show_bug.cgi?id=56065
No new tests. This bug could only be reproduced manually by
refreshing the page during load at a critical point.
See bug attachment for testing.
* rendering/CounterNode.cpp:
Introduced new member "m_owner" to store the renderer that has the
style directives that produce the CounterNode.
Repurposed m_renderer to reffer to the RenderCounter that shows the
CounterNode.
(WebCore::CounterNode::CounterNode):
Updated member initialization.
(WebCore::CounterNode::create):
(WebCore::CounterNode::resetRenderer):
(WebCore::CounterNode::resetRenderers):
(WebCore::CounterNode::recount):
(WebCore::CounterNode::removeChild):
(WebCore::CounterNode::insertAfter):
No functional changes.
(WebCore::showTreeAndMark):
Added flushing to ensure that the output is complete.
* rendering/CounterNode.h:
(WebCore::CounterNode::owner):
Renamed from renderer()
(WebCore::CounterNode::renderer):
(WebCore::CounterNode::setRenderer):
Added new accessors for the display renderer.
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
Fixed comments. No functional changes.
(WebCore::RenderCounter::~RenderCounter):
Made sure that the CounterNode that this renderers displays is
detached from this.
(WebCore::RenderCounter::originalText):
(WebCore::RenderCounter::invalidate):
Added code to update m_renderer on the displayed CounterNode.
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
No change, just kept code in line with the changes above.
(showCounterRendererTree):
Added fflush to ensure complete display.
* rendering/RenderCounter.h:
* rendering/RenderObjectChildList.cpp:
* rendering/RenderObjectChildList.h:
Removed unneeded invalidateCounters related functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Fri, 11 Mar 2011 23:39:14 +0000 (23:39 +0000)]
2011-03-11 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Add missing unit tests to TilingData.
https://bugs.webkit.org/show_bug.cgi?id=54143
* tests/TilingDataTest.cpp:
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 11 Mar 2011 23:34:26 +0000 (23:34 +0000)]
2011-03-11 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Introduce lookup-table based approach for applying CSS properties.
The aim is to be a starting point for refactoring
CSSStyleSelector::applyProperty() into more readable, maintainable code.
https://bugs.webkit.org/show_bug.cgi?id=54707
No new behavior / covered by existing tests.
* css/CSSStyleApplyProperty.cpp: Added.
(WebCore::ApplyPropertyNull):
Class that provides empty implementations of inherit, initial, value.
(WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
Class that calls the appropriate RenderStyle setters directly.
(WebCore::ApplyPropertyColorBase::ApplyPropertyColorBase):
Class for handling CSSProperty*Color.
(WebCore::ApplyPropertyColor::ApplyPropertyColor):
Class for handling CSSPropertyColor.
(WebCore::CSSStyleApplyProperty::sharedCSSStyleApplyProperty):
Singleton initializer.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Constructor that bulds up the map from property id to apply-er objects.
* css/CSSStyleApplyProperty.h: Added.
(WebCore::CSSStyleApplyProperty::inherit):
Handle the inherit case for a given property.
(WebCore::CSSStyleApplyProperty::initial):
Handle the initial case for a given property.
(WebCore::CSSStyleApplyProperty::value):
Apply a value to a given property.
(WebCore::CSSStyleApplyProperty::implements):
Returns true if the provided property id is implemented.
(WebCore::CSSStyleApplyProperty::index):
Private function to determine the index of a property the property map.
(WebCore::CSSStyleApplyProperty::valid):
Function to determine that a given property id is valid.
(WebCore::CSSStyleApplyProperty::setPropertyValue):
(WebCore::CSSStyleApplyProperty::propertyValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
Get reference to the CSSStyleApplyProperty singleton.
(WebCore::CSSStyleSelector::applyProperty):
Now calls into CSSStyleApplyProperty for implemented property ids.
Deleted color-related methods from the property id switch.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::style):
Made public to allow access from CSSStyleApplyProperty.
(WebCore::CSSStyleSelector::parentStyle):
Made public to allow access from CSSStyleApplyProperty.
* rendering/style/RenderStyle.h:
Made CSSStyleApplyProperty a friend class. Necessary because it needs
to access the private getters and setters on this clsass.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 11 Mar 2011 23:24:54 +0000 (23:24 +0000)]
Reviewed and landed by Brady Eidson.
Source/WebCore:
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878
Created StorageTracker as a central point for tracking and deleting LocalStorage per origin.
StorageTracker maintains its own database of origin identifiers and backing db paths,
and this allows it to contain more relational data in the future, like variable quotas per origin.
On initialization, StorageTracker syncs its database with LocalStorage files on disk. It adds
an origin entry when StorageAreaSync performs a first sync for an origin.
All StorageTracker file operations are performed on one background thread with a task queue.
Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html
storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html
storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html
storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html
storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/PageGroup.cpp:
(WebCore::PageGroup::clearLocalStorageForAllOrigins):
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore::PageGroup::syncLocalStorage):
(WebCore::PageGroup::numberOfPageGroups):
* page/PageGroup.h:
* platform/chromium/FileSystemChromium.cpp:
(WebCore::listDirectory):
* platform/posix/FileSystemPOSIX.cpp:
(WebCore::listDirectory):
* storage/LocalStorageTask.cpp:
(WebCore::LocalStorageTask::LocalStorageTask):
(WebCore::LocalStorageTask::performTask):
* storage/LocalStorageTask.h:
(WebCore::LocalStorageTask::createOriginIdentifiersImport):
(WebCore::LocalStorageTask::createSetOriginDetails):
(WebCore::LocalStorageTask::createDeleteOrigin):
(WebCore::LocalStorageTask::createDeleteAllOrigins):
* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::clearForOriginDeletion):
(WebCore::StorageAreaImpl::sync):
* storage/StorageAreaImpl.h:
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::scheduleCloseDatabase):
(WebCore::StorageAreaSync::openDatabase):
(WebCore::StorageAreaSync::sync):
(WebCore::StorageAreaSync::deleteEmptyDatabase):
(WebCore::StorageAreaSync::scheduleSync):
* storage/StorageAreaSync.h:
* storage/StorageNamespace.h:
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::clearOriginForDeletion):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):
* storage/StorageNamespaceImpl.h:
* storage/StorageTracker.cpp: Added.
(WebCore::StorageTracker::initializeTracker):
(WebCore::StorageTracker::tracker):
(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::setStorageDirectoryPath):
(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::openTrackerDatabase):
(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask):
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::willDeleteAllOrigins):
(WebCore::StorageTracker::willDeleteOrigin):
(WebCore::StorageTracker::canDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin):
(WebCore::StorageTracker::setClient):
(WebCore::StorageTracker::syncLocalStorage):
* storage/StorageTracker.h: Added.
* storage/StorageTrackerClient.h: Added.
(WebCore::StorageTrackerClient::~StorageTrackerClient):
Source/WebKit:
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878
* WebKit.xcodeproj/project.pbxproj:
Source/WebKit/chromium:
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878
* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespaceProxy::clearOriginForDeletion):
(WebCore::StorageNamespaceProxy::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceProxy::sync):
* src/StorageNamespaceProxy.h:
Source/WebKit/mac:
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
https://bugs.webkit.org/show_bug.cgi?id=51878
Add WebKit1 API to view and delete local storage
* Storage/WebStorageManager.mm: Added.
(+[WebStorageManager sharedWebStorageManager]):
(-[WebStorageManager origins]):
(-[WebStorageManager deleteAllOrigins]):
(-[WebStorageManager deleteOrigin:]):
(-[WebStorageManager syncLocalStorage]):
(-[WebStorageManager syncFileSystemAndTrackerDatabase]):
(storageDirectoryPath):
(WebKitInitializeStorageIfNecessary):
* Storage/WebStorageManagerInternal.h: Added.
* Storage/WebStorageManagerPrivate.h: Added.
* Storage/WebStorageTrackerClient.h: Added.
* Storage/WebStorageTrackerClient.mm: Added.
(WebStorageTrackerClient::sharedWebStorageTrackerClient):
(WebStorageTrackerClient::WebStorageTrackerClient):
(WebStorageTrackerClient::~WebStorageTrackerClient):
(WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
(WebStorageTrackerClient::dispatchDidModifyOrigin):
* WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin host]):
(-[WebSecurityOrigin databaseIdentifier]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
* WebCoreSupport/WebSecurityOriginPrivate.h:
* WebKit.exp:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
Tools:
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
https://bugs.webkit.org/show_bug.cgi?id=51878
Add WebKit1 API to view and delete local storage
Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/LayoutTestController.cpp:
(syncLocalStorageCallback):
(observeStorageTrackerNotificationsCallback):
(deleteAllLocalStorageCallback):
(deleteLocalStorageForOriginCallback):
(originsWithLocalStorageCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/StorageTrackerDelegate.h: Added.
* DumpRenderTree/StorageTrackerDelegate.mm: Added.
(-[StorageTrackerDelegate init]):
(-[StorageTrackerDelegate logNotifications:controller:]):
(-[StorageTrackerDelegate originModified:]):
(-[StorageTrackerDelegate dealloc]):
(-[StorageTrackerDelegate setControllerToNotifyDone:]):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(observeStorageTrackerNotifications):
(syncLocalStorage):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::syncLocalStorage):
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
(allocateGlobalControllers):
(releaseGlobalControllers):
* DumpRenderTree/mac/DumpRenderTreeMac.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::syncLocalStorage):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::clearAllDatabases):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::clearAllDatabases):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
LayoutTests:
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878
* platform/chromium/test_expectations.txt:
* storage/domstorage/localstorage/storagetracker: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-2-create-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-4-create-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 11 Mar 2011 23:19:00 +0000 (23:19 +0000)]
http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
https://bugs.webkit.org/show_bug.cgi?id=56185
url-parsing.html appears to be causing the crashes in later tests.
Skipping the url-parsing.html test and unskipping the url-with-credential.html test.
Unreviewed.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 11 Mar 2011 23:15:51 +0000 (23:15 +0000)]
2011-03-11 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Dimitri Glazkov.
Add an accessibilityIsIgnored method to WebAccessibilityObject.
https://bugs.webkit.org/show_bug.cgi?id=50969
* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::accessibilityIsIgnored):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 11 Mar 2011 22:55:35 +0000 (22:55 +0000)]
2011-03-11 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
drag-text-delay.html should be a dump as text test
https://bugs.webkit.org/show_bug.cgi?id=56223
Converted the test to a dump as text. Also reorganized the test code and added more descriptions.
* editing/selection/drag-text-delay-expected.txt:
* editing/selection/drag-text-delay.html:
* platform/chromium-linux/editing/selection/drag-text-delay-expected.checksum: Removed.
* platform/chromium-linux/editing/selection/drag-text-delay-expected.png: Removed.
* platform/chromium-win/editing/selection/drag-text-delay-expected.checksum: Removed.
* platform/chromium-win/editing/selection/drag-text-delay-expected.png: Removed.
* platform/chromium-win/editing/selection/drag-text-delay-expected.txt: Removed.
* platform/gtk/editing/selection/drag-text-delay-expected.checksum: Removed.
* platform/gtk/editing/selection/drag-text-delay-expected.png: Removed.
* platform/gtk/editing/selection/drag-text-delay-expected.txt: Removed.
* platform/mac/editing/selection/drag-text-delay-expected.checksum: Removed.
* platform/mac/editing/selection/drag-text-delay-expected.png: Removed.
* platform/mac/editing/selection/drag-text-delay-expected.txt:
* platform/win/editing/selection/drag-text-delay-expected.checksum: Removed.
* platform/win/editing/selection/drag-text-delay-expected.png: Removed.
* platform/win/editing/selection/drag-text-delay-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Fri, 11 Mar 2011 22:53:31 +0000 (22:53 +0000)]
2011-03-11 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JavaMethod does not correctly check for a null jstring for the method name
https://bugs.webkit.org/show_bug.cgi?id=56187
No new tests, simple typo fix.
* bridge/jni/JavaMethod.cpp:
(JavaMethod::JavaMethod):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Fri, 11 Mar 2011 22:50:38 +0000 (22:50 +0000)]
2011-03-11 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Compositor uses too much texture memory for scrollbars
https://bugs.webkit.org/show_bug.cgi?id=56212
Compositor invalidations can be off the page (and very large), but
scrollbars only need to care about the invalidation that's visible.
The large invalidation was causing the tiler layer size to grow
needlessly larger than the scrollbar.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 11 Mar 2011 22:44:00 +0000 (22:44 +0000)]
2011-03-11 Mihai Parparita <mihaip@chromium.org>
Chromium Mac expectations update. Rebaseline some more tests after
r80582.
* fast/repaint/text-emphasis-h-expected.checksum:
* fast/repaint/text-emphasis-h-expected.png:
* platform/chromium-mac/fast/repaint/text-emphasis-h-expected.txt: Removed.
* platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.checksum:
* platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png:
* platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum:
* platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 11 Mar 2011 22:20:36 +0000 (22:20 +0000)]
2011-03-11 Mihai Parparita <mihaip@chromium.org>
Chromium Mac expectations update. Rebaseline some tests after r80582
(those that already had chromium-mac-leopard baselines).
* platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Removed.
* platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Removed.
* platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png:
* platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum:
* platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.png:
* platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum:
* platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png:
* platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
* platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
* platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum:
* platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png:
* platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.txt:
* platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png: Removed.
* platform/chromium/test_expectations.txt:
* platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum:
* platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 11 Mar 2011 22:10:35 +0000 (22:10 +0000)]
Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
Process has finished launching.
https://bugs.webkit.org/show_bug.cgi?id=56208
Reviewed by Adam Roben.
Source/WebKit2:
Only send the message if the Web Process is valid.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::clearResourceCaches):
Tools:
* TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
(TestWebKitAPI::TEST):
Test that calling WKContextClearResourceCaches works with both options when called before
the Web Process is valid.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add the new test.
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 11 Mar 2011 22:08:16 +0000 (22:08 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=52987
Reviewed by Simon Fraser.
REGRESSION: Overflowing columns not repainted correctly
Make sure to add in column overflow as visual overflow as well. It was only propagating layout overflow, which is obviously not
sufficient, since blocks paint their own columns.
Added fast/multicol/scrolling-overflow.html
Source/WebCore:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromChildren):
LayoutTests:
* fast/multicol/scrolling-overflow.html: Added.
* platform/mac/fast/multicol/scrolling-overflow-expected.checksum: Added.
* platform/mac/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/mac/fast/multicol/scrolling-overflow-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 11 Mar 2011 21:59:45 +0000 (21:59 +0000)]
2011-03-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
Start using derived sources correctly and link minidom with JavaScriptCore gyp project.
https://bugs.webkit.org/show_bug.cgi?id=56217
* gyp/JavaScriptCore.gyp: Added derived source files and passing of shared directory
to the scripts.
* gyp/generate-derived-sources.sh: Changed to use passed directory.
* gyp/generate-dtrace-header.sh: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 11 Mar 2011 21:34:41 +0000 (21:34 +0000)]
2011-03-11 Mihai Parparita <mihaip@chromium.org>
Mac and Chromium expectations update. Remove failing expectations for
tests that no longer fail. Rebaseline fast/overflow/
overflow-rtl-vertical.html and fast/lists/008-vertical.html after
r80755.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/lists/008-vertical-expected.checksum:
* platform/mac/fast/lists/008-vertical-expected.png:
* platform/mac/fast/overflow/overflow-rtl-vertical-expected.checksum:
* platform/mac/fast/overflow/overflow-rtl-vertical-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Fri, 11 Mar 2011 21:25:17 +0000 (21:25 +0000)]
2011-03-11 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Set canvasUsesAcceleratedDrawing setting to be off(false) by default
https://bugs.webkit.org/show_bug.cgi?id=56215
No new tests. Does not affect behavior. Just keeping the setting off by default.
* page/Settings.cpp:
(WebCore::Settings::Settings):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 11 Mar 2011 21:22:47 +0000 (21:22 +0000)]
2011-03-11 Mihai Parparita <mihaip@chromium.org>
Update Chromium expectations. Remove some commented out lines and
promote some expectatiosn from chromium-mac to mac-leopard, so that
those tests pass on chromium Snow Leopard (and mac Leopard).
* platform/chromium/test_expectations.txt:
* platform/mac-leopard/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum.
* platform/mac-leopard/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.png.
* platform/mac-leopard/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum.
* platform/mac-leopard/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 11 Mar 2011 21:21:22 +0000 (21:21 +0000)]
2011-03-11 Andy Estes <aestes@apple.com>
Reviewed by David Hyatt.
Table cells with dynamically added percentage height descendants do not
grow in size if the table has already been laid out.
https://bugs.webkit.org/show_bug.cgi?id=56174
Table cells ignore their specified size and collapse to fit their
children. When a descendent with percentage height is present before
the table is first laid out, the descendent is sized based on the
specified size of the table cell. However, when the child isn't present
when the table is first laid out, the table cell ignores its specified
size and collapses down to 0. Then, when the child div is added in a
separate run loop iteration, it is sized to be 100% of the collapsed
cell height instead of 100% of the cell's specified height. We should
not get different layouts depending on the timing of tree construction.
Fix this by clearing intrinsic padding before calculating the table
cell's override height when we detect a child that should flex the
table cell.
Test: fast/table/dynamic-descendant-percentage-height.html
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::setOverrideSizeFromRowHeight): clear
intrinsic padding before setting the override size.
* rendering/RenderTableCell.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows): Call
setOverrideSizeFromRowHeight() instead of setOverrideSize().
2011-03-11 Andy Estes <aestes@apple.com>
Reviewed by David Hyatt.
Table cells with dynamically added percentage height descendants do not
grow in size if the table has already been laid out.
https://bugs.webkit.org/show_bug.cgi?id=56174
* fast/table/dynamic-descendant-percentage-height.html: Added.
* platform/mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
* platform/mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
* platform/mac/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 11 Mar 2011 21:15:08 +0000 (21:15 +0000)]
Fix Windows build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michaeln@google.com [Fri, 11 Mar 2011 21:09:24 +0000 (21:09 +0000)]
2011-03-11 Michael Nordman <michaeln@google.com>
Reviewed by David Levin.
Add SQLCallbackWrapper
Instead of directly holding RefPtrs to the Callback objects in SQLStatement and SQLTransaction, hold a wrapper objects
which holds those references whose dtors will schedule the release of those references on the ScriptExecution thread.
https://bugs.webkit.org/show_bug.cgi?id=55919
No new tests, existing tests apply.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* storage/SQLCallbackWrapper.h: Added.
(WebCore::SQLCallbackWrapper::SQLCallbackWrapper):
(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::unwrap):
(WebCore::SQLCallbackWrapper::hasCallback):
(WebCore::SQLCallbackWrapper::safeRelease):
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::create):
(WebCore::SQLStatement::SQLStatement):
(WebCore::SQLStatement::performCallback):
* storage/SQLStatement.h:
(WebCore::SQLStatement::hasStatementCallback):
(WebCore::SQLStatement::hasStatementErrorCallback):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::postflightAndCommit):
(WebCore::SQLTransaction::deliverSuccessCallback):
(WebCore::SQLTransaction::handleTransactionError):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):
* storage/SQLTransaction.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 11 Mar 2011 20:52:14 +0000 (20:52 +0000)]
2011-03-11 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Don't paint more than 60 times per second
https://bugs.webkit.org/show_bug.cgi?id=56206
<rdar://problem/
9085989>
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
Initialize m_lastDisplayTime to 0. Change the display timer to call displayTimerFired.
(WebKit::DrawingAreaImpl::didUpdate):
Call displayTimerFired instead of display.
(WebKit::DrawingAreaImpl::displayTimerFired):
If we're asked to paint again less than 1/60th of a second after we've already painted,
defer painting.
(WebKit::DrawingAreaImpl::display):
Update m_lastDisplayTime.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Fri, 11 Mar 2011 20:48:51 +0000 (20:48 +0000)]
2011-03-11 Eric Carlson <eric.carlson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/
8955589> Adopt AVFoundation media back end on Lion.
No new tests, existing media tests cover this.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Register MediaPlayerPrivateAVFoundationObjC.
(WebCore::bestMediaEngineForTypeAndCodecs): Kill some whitespace.
(WebCore::MediaPlayer::loadWithNextMediaEngine): Ditto.
(WebCore::MediaPlayer::inMediaDocument): Ditto.
* platform/graphics/MediaPlayer.h:
* platform/graphics/avfoundation: Added.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: Added.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Added.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Added.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Added.
2011-03-11 Eric Carlson <eric.carlson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/
8955589> Adopt AVFoundation media back end on Lion.
No new tests, existing media tests cover this.
* JavaScriptCore.exp: Export cancelCallOnMainThread
* wtf/Platform.h: Define WTF_USE_AVFOUNDATION.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 11 Mar 2011 20:27:57 +0000 (20:27 +0000)]
2011-03-11 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=56205
m_restrictions needs to allow multiple values (a bitfield)
HTMLMediaElement::m_restrictions needs to hold multiple values, so
change BehaviorRestrictions to an unsigned typedef and rename the
existing enum BehaviorRestrictionFlags.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::setBehaviorRestrictions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 11 Mar 2011 20:23:00 +0000 (20:23 +0000)]
2011-03-11 Dimitri Glazkov <dglazkov@chromium.org>
[GTK] Update expectations after r80857.
https://bugs.webkit.org/show_bug.cgi?id=55972
* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/audio-repaint-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-expected.txt:
* platform/gtk/media/controls-without-preload-expected.txt:
* platform/gtk/media/media-document-audio-repaint-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-volume-slider-expected.txt:
* platform/gtk/media/video-zoom-controls-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 11 Mar 2011 20:13:09 +0000 (20:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=47206
Reviewed by Dan Bernstein.
Table rows don't support ::before/::after. Add support to RenderTableRow::styleDidChange so that ::before/::after content gets
properly constructed.
Added fast/css-generated-content/table-row-before-after.html
Source/WebCore:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
* rendering/RenderTableRow.h:
LayoutTests:
* fast/css-generated-content/table-row-before-after.html: Added.
* platform/mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
* platform/mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
* platform/mac/fast/css-generated-content/table-row-before-after-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 11 Mar 2011 19:59:19 +0000 (19:59 +0000)]
2011-03-11 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Avoid updating a composited layer's contents if the layer has nonpositive dimensions
https://bugs.webkit.org/show_bug.cgi?id=56209
This matches the behavior prior to r80482. No test since the only changes in
behavior are avoiding work on invisible layers, which is unobservable,
and fixing a crash due to bug 56153.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateContentsRecursive):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 11 Mar 2011 19:56:42 +0000 (19:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=47159
Reviewed by Simon Fraser.
CSS2.1 failures in background position parsing.
Rewrite background position component parsing to match the spec. Our old parsing would allow "100% left" to be valid
when it should not have. Rename parseFillPositionXY to parseFillPositionComponent and pass in enough information for
it to understand what the first component was.
For individual property parsing using background-position-x/y, I added new functions that just handle that without
worrying about the other component.
In order to pass the CSS2.1 test, I also had to fix multiple background parsing. The number of layers in multiple
backgrounds is determined solely by the background-image property and not by any of the other properties. cullEmptyLayers
has been changed to always consider a layer empty if it has no image set, even if other properties are set.
A number of layout tests had to be patched as they were invalid. A couple of them relied on incorrect background-position
parsing (e.g., "50 left") and another relied on incorrect multiple background parsing. It's not clear if the computed style
should actually include the additional values when no image is set though, so that should perhaps be the subject of a
follow-up bug.
Added fast/backgrounds/background-position-parsing.html
Source/WebCore:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parsePerspectiveOrigin):
* css/CSSParser.h:
* rendering/style/FillLayer.cpp:
(WebCore::FillLayer::fillUnsetProperties):
(WebCore::FillLayer::cullEmptyLayers):
LayoutTests:
* fast/backgrounds/background-position-1.html:
* fast/backgrounds/background-position-parsing.html: Added.
* fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
* fast/backgrounds/repeat/parsing-background-repeat-expected.txt:
* fast/backgrounds/repeat/script-tests/parsing-background-repeat.js:
* fast/backgrounds/resources/diamond.png: Added.
* fast/backgrounds/resources/ring.png: Added.
* fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:
* platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
* platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
* platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
* platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
* platform/mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
* platform/mac/fast/backgrounds/background-position-parsing-expected.png: Added.
* platform/mac/fast/backgrounds/background-position-parsing-expected.txt: Added.
* platform/mac/fast/backgrounds/bgCompositeCopy-expected.png:
* platform/mac/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize01-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize03-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize06-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize07-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize08-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize09-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize10-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize11-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize12-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
* platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum:
* platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vangelis@chromium.org [Fri, 11 Mar 2011 19:50:33 +0000 (19:50 +0000)]
2011-03-11 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Adding a test for rotated large layers.
https://bugs.webkit.org/show_bug.cgi?id=55984
* platform/chromium/compositing/huge-layer-rotated-expected.checksum: Added.
* platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
* platform/chromium/compositing/huge-layer-rotated-expected.txt: Added.
* platform/chromium/compositing/huge-layer-rotated.html: Added.
2011-03-11 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Allow large layers with non-identity transforms to be drawn
as long as their visible portion is smaller than the largest supported
texture size. This code will soon be replaced by tiled layers.
https://bugs.webkit.org/show_bug.cgi?id=55984
Test: platform/chromium/compositing/huge-layer-rotated.html
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::updateContentsIfDirty):
(WebCore::ContentLayerChromium::draw):
* platform/graphics/chromium/ContentLayerChromium.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Fri, 11 Mar 2011 19:18:28 +0000 (19:18 +0000)]
2011-03-09 Chris Marrin <cmarrin@apple.com>
Reviewed by Adam Roben.
REGRESSION (5.0.3-ToT): Scrolling text doesn't scroll in Star Wars intro animation
https://bugs.webkit.org/show_bug.cgi?id=52468
Added WIN32 to the ifdef controlling whether animations are applied in normal or
reverse order. On Mac, animations used to be applied in reverse, but
<rdar://problem/
7095638> fixed this in the release after Snow Leopard.
But that patch has not be applied to the Safari Windows SDK yet. For now
I've made Windows use the reverse order logig. <rdar://problem/
9112233> is
tracking the inclusion of the patch on Windows.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 11 Mar 2011 19:11:29 +0000 (19:11 +0000)]
2011-03-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
Tweak dylib paths and add dtrace header generation action to JavaScriptCore gyp project.
https://bugs.webkit.org/show_bug.cgi?id=56207
* JavaScriptCore.gypi: Added Tracing.d to the sources.
* gyp/generate-dtrace-header.sh: Added.
* gyp/JavaScriptCore.gyp: Updated dylib paths (now the project can see them),
and added DTrace header generating step.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 11 Mar 2011 18:58:57 +0000 (18:58 +0000)]
Make it possible to view all leaks from a build at once in Leaks Viewer
You can now give Leaks Viewer the URL of a build results page (e.g.,
<http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
will load all the leaks files from that build.
Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
files from a particular build at once, rather than one at a time
Reviewed by David Kilzer.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
(LeaksLoader): Initialize our properties.
(LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
load it. Otherwise assume it's a build results page URL and start fetching the leaks files
from that page.
(LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
so it can provide feedback. Then load each one and pass it to the client.
(LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
it into a DOM, pull out all the links to leaks files, and load each one.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
(LeaksParser): Initialize our worker.
(LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
This code mostly came from Worker.js.
(LeaksParserWorker): Initialize our profile.
(LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
profile.
(LeaksParserWorker.prototype._parseLeaks):
(LeaksParserWorker.prototype._createNode):
(LeaksParserWorker.prototype._incorporateLeaks):
Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
version of createProfile which adds to this.profile instead of making a new profile each
time.
(onmessage): Parse the file and send back the new profile.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
(#loading-indicator):
(#spinner):
(#loading-indicator-label):
Tweaked styles to accomodate a longer label.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer.loaded): Set up a loader and parser.
(LeaksViewer.get filesLeftToParse):
(LeaksViewer.set filesLeftToParse):
Added these simple accessors.
(LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
(LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
the parser.
(LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
tell the ProfilerAgent and mark that we're done loading. (Code came from the old
_loadLeaksFromURL function).
(LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
(LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
loading indicator, including the number of files being loaded.
(LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
(LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
(LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
_loadingIndicatorText.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
(getResource): Moved here from LeaksViewer.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
LeaksParserWorker.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
files, added a #loading-indicator-label element, and tweaked the prompt wording.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 11 Mar 2011 18:57:29 +0000 (18:57 +0000)]
Don't trigger a build when build.webkit.org's HTML files are modified
Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
Reviewed by Dan Bernstein.
* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
directories that shouldn't trigger builds. Re-sorted the list.
* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Added a test to cover the above change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 11 Mar 2011 18:47:50 +0000 (18:47 +0000)]
2011-03-11 Avi Drissman <avi@google.com>
Reviewed by Tony Chang.
Fix missing initialization of new member variables.
https://bugs.webkit.org/show_bug.cgi?id=50969
* public/WebMenuItemInfo.h:
(WebKit::WebMenuItemInfo::WebMenuItemInfo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Fri, 11 Mar 2011 18:29:31 +0000 (18:29 +0000)]
2011-03-11 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Let the parser yield for layout before running scripts
https://bugs.webkit.org/show_bug.cgi?id=54355
Prior to this patch, the parser would yield to perform a layout/paint before running a
script only if the script or a stylesheet blocking the script is not loaded yet. Since we
don't preload scan into the body while parsing the head, typically we'll block on a script
early in the body that causes us to yield to do the first paint within a reasonable time.
However, I'm planning to change the PreloadScanner to scan into the body from the head.
That significantly improves overall load time, but would hurt first paint time because
fewer scripts would be blocked during parsing and thus wouldn't yield.
This change causes us to yield before running scripts if we haven't painted yet (regardless
of whether or not the script is loaded). In addition to allowing the above mentioned
PreloadScanner change to be implemented without regressing first paint time, this also
improves first paint time by itself.
I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
signifcant change in page load time.
Within the pages tested, 33 had no statistically significant change in time to first paint,
12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point.
(WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused
means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does
the right thing whether we are just before a token or waiting for a script. Now that we may
yield before a token or before a script, this may be called while paused.
* html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
* page/FrameView.h:
(WebCore::FrameView::hasEverPainted): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 11 Mar 2011 18:24:34 +0000 (18:24 +0000)]
2011-03-11 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Ariya Hidayat.
[Qt] Entering fullscreen and leaving it may hide the cursor of the application.
https://bugs.webkit.org/show_bug.cgi?id=56181
We need to stop the auto hide cursor timer when closing the widget otherwise the timer
might get fired and therefore hide the cursor even when the fullscreen widget is closed.
* WebCoreSupport/FullScreenVideoWidget.cpp:
(WebCore::FullScreenVideoWidget::closeEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 11 Mar 2011 18:12:03 +0000 (18:12 +0000)]
2011-03-11 Dimitri Glazkov <dglazkov@chromium.org>
Fix crashes in dom/html/level2/html/HTMLInputElement*.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle): Added a null-check for e,
because e can certainly be a null.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 11 Mar 2011 17:59:31 +0000 (17:59 +0000)]
2011-03-09 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by David Hyatt.
Choke text-decoration when entering shadow DOM subtree.
https://bugs.webkit.org/show_bug.cgi?id=56044
No new tests, because the functionality can't be tested yet.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle): Added a check for shadow DOM root.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 11 Mar 2011 17:55:54 +0000 (17:55 +0000)]
2011-03-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
https://bugs.webkit.org/show_bug.cgi?id=55972
Update test results, because they are now laying out timeline consistently.
* media/audio-repaint-expected.txt: Updated.
* platform/mac/media/audio-controls-rendering-expected.checksum: Ditto.
* platform/mac/media/audio-controls-rendering-expected.png: Ditto.
* platform/mac/media/audio-controls-rendering-expected.txt: Ditto.
* platform/mac/media/audio-repaint-expected.checksum: Ditto.
* platform/mac/media/audio-repaint-expected.png: Ditto.
2011-03-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
https://bugs.webkit.org/show_bug.cgi?id=55972
Instead of poking at the time display elements all the way from RenderMedia,
let the standard layout cycle take care of things. Move the logic of calculating
when to collapse the time display elements into a custom renderer, since
this is not something that can be accomplished with CSS.
Also, the logic of keeping the timeline slider at least 100px needed refreshing,
since it didn't actually keep it at 100px.
* html/shadow/MediaControls.cpp: Moved the logic of determining visibility
of time display elements to RenderMediaControlTimeDisplay, eliminating
updateTimeDisplayVisibility method.
* html/shadow/MediaControls.h: Removed decl.
* rendering/MediaControlElements.cpp:
(WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
Added new renderer class.
(WebCore::RenderMediaControlTimeDisplay::layout): Simplified (and corrected)
size-sensing logic, still using hard-coded values.
(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
Removed m_isVisible member, which is no longer necessary.
(WebCore::MediaControlTimeDisplayElement::createRenderer): Added to
return the new renderer.
* rendering/MediaControlElements.h: Adjusted decls.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout): Remove the now-unnecessary poking at
media controls in layout.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 11 Mar 2011 17:28:04 +0000 (17:28 +0000)]
2011-03-11 Marco Peereboom <marco@peereboom.us>
Reviewed by Gustavo Noronha Silva.
Provide a knob to enable/disable DNS prefetching.
DNS prefetching is enabled by default.
https://bugs.webkit.org/show_bug.cgi?id=55973
* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
(webkit_web_settings_copy):
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 11 Mar 2011 17:19:59 +0000 (17:19 +0000)]
2011-03-09 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
Start focusing updates to media controls, away from always updating everything.
https://bugs.webkit.org/show_bug.cgi?id=56038
For now, the new methods just call generic MediaControls::update.
Covered by existing tests.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged): Changed to use MediaControls::reset.
(WebCore::HTMLMediaElement::setMuted): Changed to use MediaControls::changedMute.
(WebCore::HTMLMediaElement::updateVolume): Changed to use MediaControls::changedVolume.
(WebCore::HTMLMediaElement::defaultEventHandler): Changed to use the new mediaControls
accessor.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Changed to use
MediaControls::changedClosedCaptionsVisibility.
(WebCore::HTMLMediaElement::mediaControls): Added.
(WebCore::HTMLMediaElement::hasMediaControls): Added.
* html/HTMLMediaElement.h: Added decls.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset): Added.
(WebCore::MediaControls::changedMute): Added.
(WebCore::MediaControls::changedVolume): Added.
(WebCore::MediaControls::changedClosedCaptionsVisibility): Added.
* html/shadow/MediaControls.h: Added decls.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 11 Mar 2011 17:09:37 +0000 (17:09 +0000)]
2011-03-11 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Martin Robinson.
[GStreamer] When seeking webKitWebSrcStop release the frame but should not.
https://bugs.webkit.org/show_bug.cgi?id=55703
When calling webKitWebSrcStop in case of a seeking, the frame should not
be reset (the source hasn't change). The frame may be used to get the network
context. Some network stack (like Qt) are relaying on the network context
to work.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStop):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 11 Mar 2011 15:08:10 +0000 (15:08 +0000)]
2011-03-11 Dean Jackson <dino@apple.com>
Unreviewed.
Build fixes for GTK and Leopard.
* bindings/gobject/GNUmakefile.am:
- add missing WebKitAnimation* generated bindings
* page/WebKitAnimation.idl:
- use double in place of float (the core values are double anyway)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 11 Mar 2011 15:05:44 +0000 (15:05 +0000)]
Update Windows results after r80846
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 11 Mar 2011 14:56:02 +0000 (14:56 +0000)]
Roll out r80848
It was accidentally committed.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer._loadLeaksFromURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 11 Mar 2011 14:51:51 +0000 (14:51 +0000)]
Skip a crashing test on Windows
The crash is tracked by <http://webkit.org/b/56185>.
* platform/win/Skipped: Added http/tests/websocket/tests/url-with-credential.html. Grouped
possibly-related websocket crashes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 11 Mar 2011 14:51:08 +0000 (14:51 +0000)]
Disable fast/text/large-text-composed-char-dos.html
It is failing on multiple bots. The failure is tracked by <http://webkit.org/b/56140>.
* fast/text/large-text-composed-char-dos.html-disabled: Renamed from LayoutTests/fast/text/large-text-composed-char-dos.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 11 Mar 2011 14:49:25 +0000 (14:49 +0000)]
Work on fetching all leaks for a build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 11 Mar 2011 14:19:30 +0000 (14:19 +0000)]
2011-03-11 Dean Jackson <dino@apple.com>
Unreviewed build fix for QT.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 11 Mar 2011 14:05:12 +0000 (14:05 +0000)]
2011-03-11 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser and Chris Marrin.
https://bugs.webkit.org/show_bug.cgi?id=54151
Implement an API to play/pause/scrub animations
This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
APIs, exposed via Element.getWebKitAnimations(). This first pass
is a read-only API - a subsequent commit will add the ability
to scrub animations.
Test: animations/animation-api-1.html
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.mk:
* Android.v8bindings.mk:
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
- All build settings updated for new files
* bindings/js/JSBindingsAllInOne.cpp:
- Include new custom files
* bindings/js/JSWebKitAnimationCustom.cpp: Added.
(WebCore::JSWebKitAnimation::iterationCount):
- Custom property getter so that we can return INFINITY
* bindings/js/JSWebKitAnimationListCustom.cpp: Added.
(WebCore::JSWebKitAnimationList::markChildren):
- Make sure WebKitAnimations are marked
* bindings/v8/custom/V8WebKitAnimationCustom.cpp: Added.
(WebCore::V8WebkitAnimation::iterationCountAccessorGetter):
- Custom property getter so that we can return INFINITY
* dom/Element.cpp:
(WebCore::Element::webkitGetAnimations):
* dom/Element.h:
* dom/Element.idl:
- New API entry point
* page/DOMWindow.idl:
- Constructor definitions for WebKitAnimation and WebKitAnimationList
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::~AnimationBase):
- Since AnimationBase can now live longer (if a WebKitAnimation is
held in Javascript) we need to guard for the renderer having disappeared.
(WebCore::AnimationBase::setElapsedTime):
(WebCore::AnimationBase::play):
(WebCore::AnimationBase::pause):
- Stub implementations at present
* page/animation/AnimationBase.h:
(WebCore::AnimationBase::animation):
- Expose the Animation properties
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::animationsForRenderer):
(WebCore::AnimationController::animationsForRenderer):
- Builds the list of WebKitAnimations
* page/animation/AnimationController.h:
* page/animation/AnimationControllerPrivate.h:
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateKeyframeAnimations):
- Make sure we clear the renderer if we are removing the animation
(WebCore::CompositeAnimation::animations):
* page/animation/CompositeAnimation.h:
* page/animation/WebKitAnimation.cpp: Added.
(WebCore::WebKitAnimation::WebKitAnimation):
(WebCore::WebKitAnimation::name):
(WebCore::WebKitAnimation::duration):
(WebCore::WebKitAnimation::elapsedTime):
(WebCore::WebKitAnimation::setElapsedTime):
(WebCore::WebKitAnimation::delay):
(WebCore::WebKitAnimation::iterationCount):
(WebCore::WebKitAnimation::paused):
(WebCore::WebKitAnimation::ended):
(WebCore::WebKitAnimation::direction):
(WebCore::WebKitAnimation::fillMode):
(WebCore::WebKitAnimation::pause):
(WebCore::WebKitAnimation::play):
- The implementation of the new API. All the read-only parts are
done, but elapsedTime, play() and pause() are stubs.
* page/animation/WebKitAnimation.h: Added.
(WebCore::WebKitAnimation::create):
(WebCore::WebKitAnimation::~WebKitAnimation):
* page/animation/WebKitAnimation.idl: Added.
* page/animation/WebKitAnimationList.cpp: Added.
* page/animation/WebKitAnimationList.h: Added.
* page/animation/WebKitAnimationList.idl: Added.
- Copies NodeList implementation
2011-03-11 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser and Chris Marrin.
https://bugs.webkit.org/show_bug.cgi?id=54151
Implement an API to play/pause/scrub animations
This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
APIs, exposed via Element.getWebKitAnimations(). This first pass
is read-only. One new layout test that examines animation
properties. Update existing layout tests for the new interfaces
on Window.
* animations/animation-api-1-expected.txt: Added.
* animations/animation-api-1.html: Added.
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-property-descriptors-expected.txt:
* fast/dom/prototype-inheritance-2-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* fast/js/global-constructors-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 11 Mar 2011 13:38:07 +0000 (13:38 +0000)]
2011-03-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce error argument for all the callbacks on frontend.
https://bugs.webkit.org/show_bug.cgi?id=56100
* inspector/CodeGeneratorInspector.pm:
* inspector/front-end: number of files
2011-03-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce error argument for all the callbacks on frontend.
https://bugs.webkit.org/show_bug.cgi?id=56100
* http/tests/inspector/extensions-test.js:
(initialize_ExtensionsTest.InspectorTest.runExtensionTests):
* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback):
(initialize_InspectorTest.InspectorTest.evaluateInPage):
* inspector/console/console-dir-global.html:
* inspector/elements/dom-agent-query-selector.html:
* inspector/protocol/console-agent-expected.txt:
* inspector/protocol/console-agent.html:
* inspector/protocol/runtime-agent-expected.txt:
* inspector/protocol/runtime-agent.html:
* inspector/report-protocol-errors-expected.txt:
* inspector/report-protocol-errors.html:
* inspector/styles/styles-new-API.html:
* inspector/styles/styles-source-offsets.html:
* inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.stopTimeline):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 11 Mar 2011 13:26:56 +0000 (13:26 +0000)]
2011-03-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173
* inspector/protocol/console-agent-expected.txt:
* inspector/protocol/console-agent.html:
2011-03-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173
Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
* bindings/js/JSInjectedScriptManager.cpp: Added.
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
* inspector/ConsoleMessage.h:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::canAccessInspectedWindow):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::~InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
(WebCore::InjectedScriptHost::inspectImpl):
(WebCore::InjectedScriptHost::clearConsoleMessages):
(WebCore::InjectedScriptHost::databaseIdImpl):
(WebCore::InjectedScriptHost::storageIdImpl):
* inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::init):
(WebCore::InjectedScriptHost::setFrontend):
(WebCore::InjectedScriptHost::clearFrontend):
* inspector/InjectedScriptManager.cpp: Added.
(WebCore::InjectedScriptManager::create):
(WebCore::InjectedScriptManager::InjectedScriptManager):
(WebCore::InjectedScriptManager::~InjectedScriptManager):
(WebCore::InjectedScriptManager::disconnect):
(WebCore::InjectedScriptManager::injectedScriptHost):
(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptForObjectId):
(WebCore::InjectedScriptManager::discardInjectedScripts):
(WebCore::InjectedScriptManager::releaseObjectGroup):
(WebCore::InjectedScriptManager::injectedScriptSource):
(WebCore::InjectedScriptManager::injectScript):
* inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::inspectedPageDestroyed):
(WebCore::InspectorAgent::focusNode):
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
(WebCore::InspectorAgent::createFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
* inspector/InspectorAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
(WebCore::InspectorConsoleAgent::addInspectedNode):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::pushNodeToFrontend):
(WebCore::InspectorDOMAgent::resolveNode):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::create):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::create):
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::evaluateOn):
(WebCore::InspectorRuntimeAgent::getProperties):
(WebCore::InspectorRuntimeAgent::setPropertyValue):
(WebCore::InspectorRuntimeAgent::releaseObject):
(WebCore::InspectorRuntimeAgent::releaseObjectGroup):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
(WebInspector.ElementsPanel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Fri, 11 Mar 2011 12:50:07 +0000 (12:50 +0000)]
2011-03-11 Sergio Villar Senin <svillar@igalia.com>
[GTK] JSC crashes in 32bit Release bots after r80743
https://bugs.webkit.org/show_bug.cgi?id=56180
Skipping a couple of tests until the original issue is fixed.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 11 Mar 2011 12:10:55 +0000 (12:10 +0000)]
2011-03-11 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Change the way group id for CSS objects is calculated
https://bugs.webkit.org/show_bug.cgi?id=56117
Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
as they should not be reachable in JavaScript.
Covered by existing layout tests. Fact of absence of retention is not trivial to prove.
* bindings/v8/V8GCController.cpp:
(WebCore::calculateGroupId):
(WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Fri, 11 Mar 2011 11:56:52 +0000 (11:56 +0000)]
2011-03-11 Sergio Villar Senin <svillar@igalia.com>
Added new GTK+ test expectations.
* platform/gtk/fast/backgrounds/positioned-root-expected.checksum: Added.
* platform/gtk/fast/backgrounds/positioned-root-expected.png: Added.
* platform/gtk/fast/backgrounds/positioned-root-expected.txt: Added.
* platform/gtk/fast/backgrounds/table-root-expected.checksum: Added.
* platform/gtk/fast/backgrounds/table-root-expected.png: Added.
* platform/gtk/fast/backgrounds/table-root-expected.txt: Added.
* platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
* platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
* platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added.
* platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
* platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
* platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added.
* platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
* platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
* platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 11 Mar 2011 11:23:02 +0000 (11:23 +0000)]
2011-03-11 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: hover over elements in Elements panel does not highlight nodes
https://bugs.webkit.org/show_bug.cgi?id=56121
In DOM trees with a comment and/or doctype preceding the HTML tag, the tree container right boundary
is 16px apart from the OL right boundary, and we miss the relevant LI by 4px. The fix is to compensate
for these 16px when computing the test point coordinates.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 11 Mar 2011 10:53:04 +0000 (10:53 +0000)]
2011-03-11 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Roll out r80837.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Fri, 11 Mar 2011 10:47:44 +0000 (10:47 +0000)]
2011-03-11 Andrey Kosyakov <caseq@chromium.org>
Unreviewied trivial fix. Leave default state of setMonitoringXHREnabled intact so it doesn't affect other tests.
* inspector/report-API-errors.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 11 Mar 2011 10:37:53 +0000 (10:37 +0000)]
2011-03-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173
* inspector/protocol/console-agent-expected.txt:
* inspector/protocol/console-agent.html:
2011-03-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173
Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
* bindings/js/JSInjectedScriptManager.cpp: Added.
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
* inspector/ConsoleMessage.h:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::canAccessInspectedWindow):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::~InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
(WebCore::InjectedScriptHost::inspectImpl):
(WebCore::InjectedScriptHost::clearConsoleMessages):
(WebCore::InjectedScriptHost::databaseIdImpl):
(WebCore::InjectedScriptHost::storageIdImpl):
* inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::init):
(WebCore::InjectedScriptHost::setFrontend):
(WebCore::InjectedScriptHost::clearFrontend):
* inspector/InjectedScriptManager.cpp: Added.
(WebCore::InjectedScriptManager::create):
(WebCore::InjectedScriptManager::InjectedScriptManager):
(WebCore::InjectedScriptManager::~InjectedScriptManager):
(WebCore::InjectedScriptManager::disconnect):
(WebCore::InjectedScriptManager::injectedScriptHost):
(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptForObjectId):
(WebCore::InjectedScriptManager::discardInjectedScripts):
(WebCore::InjectedScriptManager::releaseObjectGroup):
(WebCore::InjectedScriptManager::injectedScriptSource):
(WebCore::InjectedScriptManager::injectScript):
* inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::inspectedPageDestroyed):
(WebCore::InspectorAgent::focusNode):
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
(WebCore::InspectorAgent::createFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
* inspector/InspectorAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
(WebCore::InspectorConsoleAgent::addInspectedNode):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::pushNodeToFrontend):
(WebCore::InspectorDOMAgent::resolveNode):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::create):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::create):
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::evaluateOn):
(WebCore::InspectorRuntimeAgent::getProperties):
(WebCore::InspectorRuntimeAgent::setPropertyValue):
(WebCore::InspectorRuntimeAgent::releaseObject):
(WebCore::InspectorRuntimeAgent::releaseObjectGroup):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
(WebInspector.ElementsPanel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 11 Mar 2011 10:26:50 +0000 (10:26 +0000)]
2011-03-08 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] close-web-view emitted on disposed WebView
https://bugs.webkit.org/show_bug.cgi?id=55932
* WebCoreSupport/ChromeClientGtk.cpp:
(ChromeClient::chromeDestroyed): Remove the closeSoonTimer glib
source before destruction of the ChromeClient.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Fri, 11 Mar 2011 10:26:03 +0000 (10:26 +0000)]
2011-03-11 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Skipping two test cases that are failing on GTK debug bots.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Fri, 11 Mar 2011 10:04:35 +0000 (10:04 +0000)]
2011-03-09 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Make IDBBackingStore abstract
https://bugs.webkit.org/show_bug.cgi?id=56013
Make IDBBackingStore abstract to allow for multiple implementations.
Move the SQLite implementation to IDBSQLiteBackingStore.
No new tests: refactoring only.
* WebCore.gypi:
* storage/IDBBackingStore.h:
(WebCore::IDBBackingStore::~IDBBackingStore):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
(WebCore::IDBSQLiteBackingStore::~IDBSQLiteBackingStore):
(WebCore::runCommands):
(WebCore::createTables):
(WebCore::createMetaDataTable):
(WebCore::getDatabaseSchemaVersion):
(WebCore::migrateDatabase):
(WebCore::IDBSQLiteBackingStore::open):
(WebCore::IDBSQLiteBackingStore::extractIDBDatabaseMetaData):
(WebCore::IDBSQLiteBackingStore::setIDBDatabaseMetaData):
(WebCore::IDBSQLiteBackingStore::getObjectStores):
(WebCore::IDBSQLiteBackingStore::createObjectStore):
(WebCore::doDelete):
(WebCore::IDBSQLiteBackingStore::deleteObjectStore):
(WebCore::whereSyntaxForKey):
(WebCore::bindKeyToQuery):
(WebCore::lowerCursorWhereFragment):
(WebCore::upperCursorWhereFragment):
(WebCore::IDBSQLiteBackingStore::getObjectStoreRecord):
(WebCore::bindKeyToQueryWithNulls):
(WebCore::IDBSQLiteBackingStore::putObjectStoreRecord):
(WebCore::IDBSQLiteBackingStore::clearObjectStore):
(WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord):
(WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber):
(WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore):
(WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord):
(WebCore::IDBSQLiteBackingStore::getIndexes):
(WebCore::IDBSQLiteBackingStore::createIndex):
(WebCore::IDBSQLiteBackingStore::deleteIndex):
(WebCore::IDBSQLiteBackingStore::putIndexDataForRecord):
(WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord):
(WebCore::IDBSQLiteBackingStore::getObjectViaIndex):
(WebCore::keyFromQuery):
(WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
(WebCore::IDBSQLiteBackingStore::openObjectStoreCursor):
(WebCore::IDBSQLiteBackingStore::openIndexKeyCursor):
(WebCore::IDBSQLiteBackingStore::openIndexCursor):
(WebCore::IDBSQLiteBackingStore::createTransaction):
* storage/IDBSQLiteBackingStore.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Fri, 11 Mar 2011 09:44:58 +0000 (09:44 +0000)]
2011-03-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed build error fix.
[EFL] Fix build break when SHARED_CORE is ON
https://bugs.webkit.org/show_bug.cgi?id=56155
* platform/efl/ContextMenuEfl.cpp:
(WebCore::ContextMenu::ContextMenu):
* platform/efl/ContextMenuItemEfl.cpp:
(WebCore::ContextMenuItem::nativeMenuItem):
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Fri, 11 Mar 2011 09:28:38 +0000 (09:28 +0000)]
2011-03-11 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: resource load cancellation is reported to console as an error
https://bugs.webkit.org/show_bug.cgi?id=55764
- mark interruptionForPolicyChangeError as cancellation
- do not log resource cancelation as an error
- always push resource to front-end before console message, so front-end can use resource info while formatting message.
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::didFailLoading):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::stopLoadingForPolicyChange):
2011-03-11 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: resource load cancellation is reported to console as an error
https://bugs.webkit.org/show_bug.cgi?id=55764
* http/tests/inspector/console-resource-errors-expected.txt:
* http/tests/inspector/console-resource-errors.html: Added test for lack of console messages during policy change (at download)
* http/tests/inspector/console-xhr-logging-expected.txt:
* http/tests/inspector/console-xhr-logging.html: Added test for reporting of cross-origin XHR errors.
* http/tests/inspector/resources/empty.zip: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc