akling@apple.com [Tue, 25 Feb 2014 23:17:08 +0000 (23:17 +0000)]
Remove unused ThreadSpecificInspectorCounters.
<https://webkit.org/b/129337>
We were keeping count of all the JS event listeners in every thread
to support an old Chromium feature that's no longer relevant.
Removing this gets rid of expensive thread-local storage lookups.
Reviewed by Anders Carlsson.
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
* inspector/InspectorCounters.cpp:
* inspector/InspectorCounters.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::setDOMCounters):
* inspector/protocol/Timeline.json:
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):
* platform/ThreadGlobalData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lvidacs.u-szeged@partner.samsung.com [Tue, 25 Feb 2014 22:31:14 +0000 (22:31 +0000)]
display:table with padding and/or borders in border-box calculates height incorrectly
https://bugs.webkit.org/show_bug.cgi?id=126576
Reviewed by David Hyatt.
Based on blink issue https://codereview.chromium.org/
25206002/
Source/WebCore:
Tests: fast/box-sizing/css-table-collapse.html
fast/box-sizing/css-table-no-collapse.html
fast/box-sizing/table-collapse.html
fast/box-sizing/table-no-collapse.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
LayoutTests:
* fast/box-sizing/css-table-collapse-expected.txt: Added.
* fast/box-sizing/css-table-collapse.html: Added.
* fast/box-sizing/css-table-no-collapse-expected.txt: Added.
* fast/box-sizing/css-table-no-collapse.html: Added.
* fast/box-sizing/table-collapse-expected.txt: Added.
* fast/box-sizing/table-collapse.html: Added.
* fast/box-sizing/table-no-collapse-expected.txt: Added.
* fast/box-sizing/table-no-collapse.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 25 Feb 2014 22:18:21 +0000 (22:18 +0000)]
Inline caching in the FTL on ARM64 should "work"
https://bugs.webkit.org/show_bug.cgi?id=129334
Reviewed by Mark Hahnenberg.
Gets us to the point where simple tests that use inline caching are passing.
* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):
(JSC::LinkBuffer::shrink):
* ftl/FTLInlineCacheSize.cpp:
(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):
(JSC::FTL::sizeOfCall):
* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileFTLOSRExit):
* ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationThunkGenerator):
* jit/GPRInfo.h:
* offlineasm/arm64.rb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Feb 2014 21:42:43 +0000 (21:42 +0000)]
Fix build.
Remove VisitedLinkStrategy.
* NetworkProcess/NetworkProcessPlatformStrategies.cpp:
* NetworkProcess/NetworkProcessPlatformStrategies.h:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 25 Feb 2014 21:37:49 +0000 (21:37 +0000)]
inspector-protocol/page/deny-X-FrameOption.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=129331
* TestExpectations: Marking as such.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Feb 2014 21:35:27 +0000 (21:35 +0000)]
Get rid of VisitedLinkStrategy
https://bugs.webkit.org/show_bug.cgi?id=129324
Reviewed by Dan Bernstein.
Source/WebCore:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::PlatformStrategies):
* platform/VisitedLinkStrategy.h: Removed.
Source/WebKit/efl:
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::getPluginInfo):
* WebCoreSupport/PlatformStrategiesEfl.h:
Source/WebKit/gtk:
* WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::getPluginInfo):
* WebCoreSupport/PlatformStrategiesGtk.h:
Source/WebKit/mac:
* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
Source/WebKit/win:
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::getPluginInfo):
* WebCoreSupport/WebPlatformStrategies.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 25 Feb 2014 21:29:14 +0000 (21:29 +0000)]
Rolling out trac.webkit.org/changeset/164611, because it broke
WebKit2.PrivateBrowsingPushStateNoHistoryCallback API test
The change was for:
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=129141
Create SessionID class
Source/WebKit2:
https://bugs.webkit.org/show_bug.cgi?id=129141
Create SessionID class
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 25 Feb 2014 21:24:24 +0000 (21:24 +0000)]
REGRESSION: All inspector-protocol/model very frequently assert in IDBRequest::~IDBRequest
https://bugs.webkit.org/show_bug.cgi?id=129328
inspector-protocol/indexeddb/basics.html fails
https://bugs.webkit.org/show_bug.cgi?id=129327
* TestExpectations: Updating test expectations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Feb 2014 21:18:39 +0000 (21:18 +0000)]
Unreviewed, rolling out r164627.
http://trac.webkit.org/changeset/164627
https://bugs.webkit.org/show_bug.cgi?id=129325
Broke SubtleCrypto tests (Requested by ap on #webkit).
Source/JavaScriptCore:
* API/APIShims.h:
(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::shouldDropAllLocks):
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::addCurrentThread):
* runtime/JSLock.cpp:
(JSC::JSLockHolder::JSLockHolder):
(JSC::JSLockHolder::init):
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::currentThreadIsHoldingLock):
(JSC::JSLock::dropAllLocks):
(JSC::JSLock::grabAllLocks):
* runtime/JSLock.h:
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
(JSC::VM::currentThreadIsHoldingAPILock):
Source/WebCore:
* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonVM):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 25 Feb 2014 21:10:14 +0000 (21:10 +0000)]
[Cocoa] Add delegate method for customizing actions on activated elements
https://bugs.webkit.org/show_bug.cgi?id=129290
Reviewed by Anders Carlsson.
* UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Added. Declared new delegate method.
* UIProcess/API/Cocoa/_WKActivatedElementInfo.h:
(_WKActivatedElementType): Defined enum of element types.
* UIProcess/API/Cocoa/_WKActivatedElementInfo.mm:
(-[_WKActivatedElementInfo _initWithType:URL:location:title:rect:]): Added type parameter
to the initializer, used to set the new type property.
* UIProcess/API/Cocoa/_WKActivatedElementInfoInternal.h:
* UIProcess/Cocoa/UIClient.h:
* UIProcess/Cocoa/UIClient.mm:
(WebKit::UIClient::setDelegate): Initialize webViewActionsForElementDefaultActions member
of m_delegateMethods.
(WebKit::UIClient::actionsForElement): Added. Calls out to the new delegate method if
implemented. Otherwise returns the default actions.
* UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant actionSheet:clickedButtonAtIndex:]): Use new _elementInfo ivar
instead of creating element info here.
(-[WKActionSheetAssistant showImageSheet]): Create element info here and assign it to
_elementInfo ivar if presenting a sheet. Call the UI client to get custom actions.
(-[WKActionSheetAssistant showLinkSheet]): Ditto.
(-[WKActionSheetAssistant cleanupSheet]): Clear _elementInfo ivar.
* WebKit2.xcodeproj/project.pbxproj: Added reference to WKUIDelegatePrivate.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Feb 2014 20:56:27 +0000 (20:56 +0000)]
DefaultVisitedLinkProvider can just call into the page group directly
https://bugs.webkit.org/show_bug.cgi?id=129320
Reviewed by Andreas Kling.
* page/DefaultVisitedLinkProvider.cpp:
(WebCore::DefaultVisitedLinkProvider::isLinkVisited):
(WebCore::DefaultVisitedLinkProvider::addVisitedLink):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
m.pakula@samsung.com [Tue, 25 Feb 2014 20:55:15 +0000 (20:55 +0000)]
Unreviewed EFL build fix attempt after r164562
* CMakeLists.txt: Added WebVisitedLinkProvider.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 25 Feb 2014 20:48:24 +0000 (20:48 +0000)]
ARM64 rshift64 should be an arithmetic shift
https://bugs.webkit.org/show_bug.cgi?id=129323
Reviewed by Mark Hahnenberg.
* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::rshift64):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Feb 2014 20:42:44 +0000 (20:42 +0000)]
Unreviewed, rolling out r164638.
http://trac.webkit.org/changeset/164638
https://bugs.webkit.org/show_bug.cgi?id=129321
Broke Windows build. (Requested by bfulgham on #webkit).
* dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::takeSnapshot):
(WebCore::ChildNodesLazySnapshot::hasSnapshot):
* dom/Element.cpp:
(WebCore::ensureAttrNodeListForElement):
(WebCore::Element::attributes):
* dom/ElementIteratorAssertions.h:
(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):
* dom/ElementRareData.h:
(WebCore::ElementRareData::create):
(WebCore::ElementRareData::setAttributeMap):
* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::create):
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
(WebCore::MutationObserverRegistration::addRegistrationNodesToSet):
* dom/MutationObserverRegistration.h:
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::create):
(WebCore::NamedNodeMap::NamedNodeMap):
* dom/Node.cpp:
(WebCore::Node::ensureRareData):
(WebCore::Node::didMoveToNewDocument):
(WebCore::Node::ensureEventTargetData):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::notifyMutationObserversNodeWillDetach):
* dom/Node.h:
* dom/NodeRareData.h:
(WebCore::NodeListsNodeData::create):
(WebCore::NodeListsNodeData::NodeListsNodeData):
(WebCore::NodeMutationObserverData::create):
(WebCore::NodeMutationObserverData::NodeMutationObserverData):
(WebCore::NodeRareData::create):
(WebCore::NodeRareData::clearNodeLists):
(WebCore::NodeRareData::ensureNodeLists):
(WebCore::NodeRareData::ensureMutationObserverData):
(WebCore::NodeRareData::NodeRareData):
* dom/StyledElement.cpp:
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Tue, 25 Feb 2014 20:29:58 +0000 (20:29 +0000)]
[iOS] Show status image when playing video to external device
https://bugs.webkit.org/show_bug.cgi?id=129277
Reviewed by Jer Noble.
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleEvent): Restructure the code so it is possible to handle events
that target the video element which aren't in the HandledVideoEvents array.
* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.currentPlaybackTargetIsWireless): webkitCurrentPlaybackTargetIsWireless
is an attribute, not a function.
(ControllerIOS.prototype.updateWirelessPlaybackStatus): Fix style.
(ControllerIOS.prototype.updateWirelessTargetAvailable): Ditto.
(ControllerIOS.prototype.updateProgress): Ditto.
(ControllerIOS.prototype.handleWrapperTouchStart): Show the controls if the wireless status
display is touched.
(ControllerIOS.prototype.handleFullscreenButtonClicked): Fix style
(ControllerIOS.prototype.handleWirelessPlaybackChange): Ditto.
(ControllerIOS.prototype.handleWirelessTargetAvailableChange):
(ControllerIOS.prototype.handleWirelessPickerButtonClicked): Ditto. Stop even propagation.
Move "playback target" logic into HTMLMediaSession.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Call media session.
(WebCore::HTMLMediaElement::loadResource): Tell media session to apply media player
restrictions now that it has a url.
(WebCore::HTMLMediaElement::invalidateCachedTime): Only log when cached time is not
already invalie.
(WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker): Call media session.
(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsWireless): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged): Ditto.
(WebCore::HTMLMediaElement::addEventListener): Ditto.
(WebCore::HTMLMediaElement::removeEventListen): Ditto.
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent): Ditto.
(WebCore::HTMLMediaElement::createMediaPlayer): Ditto.
* html/HTMLMediaSession.cpp:
(WebCore::restrictionName): Log new WirelessVideoPlaybackDisabled restriction.
(WebCore::HTMLMediaSession::showingPlaybackTargetPickerPermitted): Return false if there
is no page, or if wireless playback is disabled.
(WebCore::HTMLMediaSession::currentPlaybackTargetIsWireless): New, logic from HTMLMediaElement.
(WebCore::HTMLMediaSession::showPlaybackTargetPicker): Ditto.
(WebCore::HTMLMediaSession::hasWirelessPlaybackTargets): Ditto.
(WebCore::HTMLMediaSession::wirelessVideoPlaybackDisabled): Ditto.
(WebCore::HTMLMediaSession::setWirelessVideoPlaybackDisabled): Ditto.
(WebCore::HTMLMediaSession::setHasPlaybackTargetAvailabilityListeners): Ditto.
(WebCore::HTMLMediaSession::applyMediaPlayerRestrictions): New, apply media player specific
restriction.
* html/HTMLMediaSession.h:
Move "playback target" logic into HTMLMediaSession.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::parseAttribute): Call media session.
(WebCore::HTMLVideoElement::webkitWirelessVideoPlaybackDisabled): Call media session.
* platform/audio/MediaSessionManager.h:
(WebCore::MediaSessionManager::showPlaybackTargetPicker): New method, does nothing in base class.
* platform/audio/ios/MediaSessionManagerIOS.h:
* platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::showPlaybackTargetPicker): Add non-functional stub.
Implement wireless playback control and status API.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Dispatch TargetIsWirelessChanged.
(WebCore::MediaPlayerPrivateAVFoundation::playbackTargetIsWirelessChanged): Pass through to
media element.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
m_allowsWirelessVideoPlayback.
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Remove "externalPlaybackActive" observer.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): Fix broken logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Add "externalPlaybackActive" observer,
set initial wireless playback.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer): Fix broken logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::isCurrentPlaybackTargetWireless): New.
(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessVideoPlaybackDisabled): New.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessVideoPlaybackDisabled): New.
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackTargetIsWirelessDidChange): New.
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Deal with
externalPlaybackActive.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@apple.com [Tue, 25 Feb 2014 19:47:37 +0000 (19:47 +0000)]
[Win] Gracefully recover from missing 'naturalSize' parameter for media
https://bugs.webkit.org/show_bug.cgi?id=129278
Reviewed by Eric Carlson.
* platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Add declaration for
missing function call.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::assetStatus): Don't treat missing 'naturalSize'
as a fatal error.
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged): Handle case of asset track
not being available yet.
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged): If the 'naturalSize' is empty,
use the Player Item's 'presentationSize' instead.
(WebCore::AVFWrapper::processNotification): Add missing handler for duration changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
svillar@igalia.com [Tue, 25 Feb 2014 19:10:26 +0000 (19:10 +0000)]
[CSS Grid Layout] Add ENABLE flag
https://bugs.webkit.org/show_bug.cgi?id=129153
Reviewed by Simon Fraser.
.:
Added the ENABLE_CSS_GRID_LAYOUT feature flag to the cmake and
autotools build systems. The feature is disabled by default for
production builds.
* Source/autotools/SetupWebKitFeatures.m4:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig: added ENABLE_CSS_GRID_LAYOUT feature flag.
Source/WebCore:
Added ENABLE_CSS_GRID_LAYOUT feature flag.
* Configurations/FeatureDefines.xcconfig:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSGridTemplateAreasValue.cpp:
* css/CSSGridTemplateAreasValue.h:
* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSParser.h:
* css/CSSParserMode.h:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSPropertyNames.in:
* css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
* css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue):
* css/StylePropertyShorthand.cpp:
(WebCore::shorthandForProperty):
(WebCore::matchingShorthandsForLonghand):
* css/StyleResolver.cpp:
(WebCore::equivalentBlockDisplay):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::applyProperty):
* css/StyleResolver.h:
* dom/Document.cpp:
* dom/Document.h:
* rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
* rendering/RenderGrid.cpp:
* rendering/RenderGrid.h:
* rendering/style/GridCoordinate.h:
* rendering/style/GridLength.h:
* rendering/style/GridPosition.h:
* rendering/style/GridTrackSize.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleAllInOne.cpp:
* rendering/style/StyleGridData.cpp:
* rendering/style/StyleGridData.h:
* rendering/style/StyleGridItemData.cpp:
* rendering/style/StyleGridItemData.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
Source/WebKit/mac:
Added ENABLE_CSS_GRID_LAYOUT feature flag.
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Added ENABLE_CSS_GRID_LAYOUT feature flag.
* Configurations/FeatureDefines.xcconfig:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
all ports for developer builds.
* Scripts/webkitperl/FeatureList.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Tue, 25 Feb 2014 18:53:44 +0000 (18:53 +0000)]
Unreviewed GTK build fix after r164652.
* GNUmakefile.list.am: Add WebVisitedLinkProvider build targets.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbatyai.u-szeged@partner.samsung.com [Tue, 25 Feb 2014 18:33:38 +0000 (18:33 +0000)]
Added myself as a committer.
Unreviewed.
* Scripts/webkitpy/common/config/contributors.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 25 Feb 2014 18:24:13 +0000 (18:24 +0000)]
[EME][Mac] Fix a few issues in CDMSessionMediaSourceAVFObjC.
https://bugs.webkit.org/show_bug.cgi?id=129310
Reviewed by Eric Carlson.
Only send a 'keyerror' event if an actual error code was returned, not just
when no key was added:
* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::addKeyTimerFired):
The 'length' parameter to a typed ArrayBufferView is the number of entries
in the array, not the byte length:
* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest):
The return value of streamingContentKeyRequestDataForApp:contentIdentifier:trackId:options:error
is autoreleased; do not wrap it in an adoptNS:
* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::update):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thiago.lacerda@openbossa.org [Tue, 25 Feb 2014 18:18:28 +0000 (18:18 +0000)]
[MediaStream] Adding mock implementation of UserMediaClient
https://bugs.webkit.org/show_bug.cgi?id=129274
Reviewed by Eric Carlson.
* platform/mock/UserMediaClientMock.h: Added.
(WebCore::UserMediaClientRequestNotifier::UserMediaClientRequestNotifier):
* testing/Internals.cpp:
(WebCore::Internals::Internals):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 25 Feb 2014 17:57:31 +0000 (17:57 +0000)]
Tighten bitfields in live NodeLists and HTMLCollections
https://bugs.webkit.org/show_bug.cgi?id=129300
Reviewed by Geoffrey Garen.
Reduce the number of bits used for m_rootType and m_type in LiveNodeList.
Also use enum class for LiveNodeList types. We keep "Type" suffix not to
confuse old-ish compilers.
* dom/ClassNodeList.cpp:
(WebCore::ClassNodeList::ClassNodeList):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByName):
(WebCore::ContainerNode::getElementsByClassName):
(WebCore::ContainerNode::radioNodeList):
* dom/LiveNodeList.cpp:
(WebCore::LiveNodeList::collectionFirst):
(WebCore::LiveNodeList::collectionTraverseForward):
* dom/LiveNodeList.h:
(WebCore::LiveNodeList::LiveNodeList):
* dom/NameNodeList.cpp:
(WebCore::NameNodeList::NameNodeList):
* dom/NameNodeList.h:
(WebCore::NameNodeList::create):
* dom/NodeRareData.h:
(WebCore::NodeListsNodeData::namedNodeListKey):
* dom/TagNodeList.cpp:
(WebCore::HTMLTagNodeList::HTMLTagNodeList):
* dom/TagNodeList.h:
(WebCore::TagNodeList::create):
(WebCore::HTMLTagNodeList::create):
* html/HTMLCollection.h:
* html/LabelableElement.cpp:
(WebCore::LabelableElement::labels):
* html/LabelsNodeList.cpp:
(WebCore::LabelsNodeList::LabelsNodeList):
* html/LabelsNodeList.h:
* html/RadioNodeList.cpp:
(WebCore::RadioNodeList::RadioNodeList):
* html/RadioNodeList.h:
(WebCore::RadioNodeList::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Tue, 25 Feb 2014 17:53:33 +0000 (17:53 +0000)]
JIT Engines use the wrong stack limit for stack checks
https://bugs.webkit.org/show_bug.cgi?id=129314
Reviewed by Filip Pizlo.
Change the Baseline and DFG code to use VM::m_stackLimit for stack limit checks.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
* runtime/VM.h:
(JSC::VM::addressOfStackLimit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Feb 2014 17:48:03 +0000 (17:48 +0000)]
Make it possible to set the visited link provider on a per page basis
https://bugs.webkit.org/show_bug.cgi?id=129288
Reviewed by Andreas Kling.
Source/WebCore:
* WebCore.exp.in:
Export symbols needed by WebKit2.
* WebCore.xcodeproj/project.pbxproj:
Make VisitedLinkProvider a private header.
* page/Page.cpp:
(WebCore::Page::Page):
Take the visited link provider from the PageClients object.
(WebCore::Page::visitedLinkProvider):
If the page has a visited link provider set, return it.
* page/Page.h:
Add VisitedLinkProvider to Page and PageClients.
Source/WebKit2:
Add WebVisitedLinkProvider which just calls the web process.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebPage/WebVisitedLinkProvider.cpp: Added.
(WebKit::WebVisitedLinkProvider::create):
(WebKit::WebVisitedLinkProvider::WebVisitedLinkProvider):
(WebKit::WebVisitedLinkProvider::~WebVisitedLinkProvider):
(WebKit::WebVisitedLinkProvider::isLinkVisited):
(WebKit::WebVisitedLinkProvider::addVisitedLink):
* WebProcess/WebPage/WebVisitedLinkProvider.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 25 Feb 2014 17:47:29 +0000 (17:47 +0000)]
Unreviewed, roll out trac.webkit.org/changeset/164493.
It causes crashes, apparently because it's removing too many barriers. I will investigate
later.
* bytecode/SpeculatedType.cpp:
(JSC::speculationToAbbreviatedString):
* bytecode/SpeculatedType.h:
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::insertStoreBarrier):
* dfg/DFGNode.h:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compareEqObjectOrOtherToObject):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::LowerDFGToLLVM::isNotNully):
(JSC::FTL::LowerDFGToLLVM::isNully):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateObjectOrOther):
(JSC::FTL::LowerDFGToLLVM::speculateNotCell):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Feb 2014 16:10:08 +0000 (16:10 +0000)]
[New Multicolumn] -webkit-column-break-inside:avoid doesn't work
https://bugs.webkit.org/show_bug.cgi?id=129299
Patch by Morten Stenshorne <mstensho@opera.com> on 2014-02-25
Reviewed by Andrei Bucur.
Source/WebCore:
adjustForUnsplittableChild() simply forgot to check whether we
were inside flow thread based multicol.
Test: fast/multicol/newmulticol/avoid-column-break-inside.html
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustForUnsplittableChild):
LayoutTests:
* fast/multicol/newmulticol/avoid-column-break-inside-expected.html: Added.
* fast/multicol/newmulticol/avoid-column-break-inside.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tgergely.u-szeged@partner.samsung.com [Tue, 25 Feb 2014 15:08:18 +0000 (15:08 +0000)]
Unreviewed. Moved myself to the list of committers.
* Scripts/webkitpy/common/config/contributors.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pmolnar.u-szeged@partner.samsung.com [Tue, 25 Feb 2014 14:53:42 +0000 (14:53 +0000)]
Move myself to the committers list.
Unreviewed.
* Scripts/webkitpy/common/config/contributors.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihnea@adobe.com [Tue, 25 Feb 2014 14:51:37 +0000 (14:51 +0000)]
[CSSRegions] Remove unused function RenderFlowThread::regionForCompositedLayer
https://bugs.webkit.org/show_bug.cgi?id=129303
Reviewed by Andrei Bucur.
Cleanup, no funtionality change, no new tests.
* rendering/RenderFlowThread.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
llango.u-szeged@partner.samsung.com [Tue, 25 Feb 2014 14:48:03 +0000 (14:48 +0000)]
Unreviewed. Add myself as a committer.
* Scripts/webkitpy/common/config/contributors.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rego@igalia.com [Tue, 25 Feb 2014 14:07:40 +0000 (14:07 +0000)]
Unreviewed, rolling out r164639.
http://trac.webkit.org/changeset/164639
https://bugs.webkit.org/show_bug.cgi?id=129302
gtk-doc still have problems in EWS (Requested by rego on
#webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2014-02-25
* Scripts/webkitpy/common/config/ports.py:
(GtkPort.build_webkit_command):
(GtkWK2Port.build_webkit_command):
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest.test_gtk_wk2_port):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
g.czajkowski@samsung.com [Tue, 25 Feb 2014 13:31:45 +0000 (13:31 +0000)]
Refactoring inline_spelling_markers.html to use asynchronous spellchecking
https://bugs.webkit.org/show_bug.cgi?id=127284
Reviewed by Ryosuke Niwa.
Use asynchronous text checking in inline-spelling-markers.html and
inline-spelling-markers-hidpi.html
Rename the test to inline-spelling-markers.html to match the naming convention.
* editing/spelling/inline-spelling-markers-expected.txt: Added.
Make cross platform text expectation by dumping spelling/grammar markers
instead of whole tree which in terms of spellchecking says nothing.
* editing/spelling/inline-spelling-markers.html: Added.
Remove unnecessary new lines from div elements so position of markers can be given from 0.
Activate text checking by adding a word separator so WebKit starts performing spell and grammar
checking. Selection change does not invoke grammar checking unless we start editing the input
element's content.
* platform/efl/editing/spelling/inline_spelling_markers-expected.png: Removed.
* platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Removed.
* platform/gtk/editing/spelling/inline_spelling_markers-expected.png: Removed.
* platform/gtk/editing/spelling/inline_spelling_markers-expected.txt: Removed.
* platform/mac/editing/spelling/inline_spelling_markers-expected.png: Removed.
* platform/mac/editing/spelling/inline_spelling_markers-expected.txt: Removed.
Those are not needed as pixel tests don't introduce anything special here.
Let's keep them in hidpi test only.
* editing/spelling/inline-spelling-markers-hidpi-expected.txt:
* editing/spelling/inline-spelling-markers-hidpi.html:
Apply changes from inline-spelling-markers.html
* platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png: Added.
* platform/efl/editing/spelling/inline-spelling-markers-hidpi-expected.png: Removed.
* platform/gtk/editing/spelling/inline-spelling-markers-hidpi-expected.png: Removed.
Remove wrong baselines due to missing grammar markers.
* platform/efl-wk2/TestExpectations:
* platform/gtk/TestExpectations:
Mark inline-spelling-markers.html and its hidpi version as failures
since EFL and GTK do not implement grammar checking.
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
Mark inline-spelling-markers.html and its hidpi version as failures
due to missing TextChecker::requestCheckingOfString() implementation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Feb 2014 12:44:42 +0000 (12:44 +0000)]
PrettyPatch.rb should be more descriptive for "git diff -M" styled patches
https://bugs.webkit.org/show_bug.cgi?id=125514
Patch by Jozsef Berta <jberta.u-szeged@partner.samsung.com> on 2014-02-25
Reviewed by Csaba Osztrogonác.
* PrettyPatch/PrettyPatch.rb: PrettyPatch.rb is modified to show which file was renamed or moved.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
stavila@adobe.com [Tue, 25 Feb 2014 10:33:26 +0000 (10:33 +0000)]
[CSS Regions] scrollIntoView for elements flowed into regions
https://bugs.webkit.org/show_bug.cgi?id=129151
Reviewed by Mihnea Ovidenie.
Added tests for scrollIntoView on elements flowed inside regions.
* fast/regions/scroll-into-view-expected.html: Added.
* fast/regions/scroll-into-view-relative-expected.html: Added.
* fast/regions/scroll-into-view-relative.html: Added.
* fast/regions/scroll-into-view.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Feb 2014 10:16:04 +0000 (10:16 +0000)]
[CSS Blending] -webkit-mix-blend-mode should force transform-style: flat.
https://bugs.webkit.org/show_bug.cgi?id=126158
Patch by Mihai Tica <mitica@adobe.com> on 2014-02-25
Reviewed by Mihnea Ovidenie.
Source/WebCore:
As stated in the http://www.w3.org/TR/css3-transforms/#propdef-transform-style, an element with blending
should force transform-style: flat.
Test: css3/compositing/blend-mode-transform-style.html
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle): If blending is detected, set transform-style to flat.
LayoutTests:
For an element with -webkit-mix-blend-mode, test that the value of -webkit-transform-style computes to flat.
* css3/compositing/blend-mode-transform-style-expected.txt: Added.
* css3/compositing/blend-mode-transform-style.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rego@igalia.com [Tue, 25 Feb 2014 10:05:38 +0000 (10:05 +0000)]
[GTK] Re-enable gtk-doc in EWS
https://bugs.webkit.org/show_bug.cgi?id=128369
Reviewed by Carlos Garcia Campos.
Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
* Scripts/webkitpy/common/config/ports.py:
(GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
(GtkWK2Port.build_webkit_command): Ditto.
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_gtk_port): Ditto.
(DeprecatedPortTest.test_gtk_wk2_port): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Tue, 25 Feb 2014 08:47:50 +0000 (08:47 +0000)]
Move to using std::unique_ptr for Element, Node and related classes
https://bugs.webkit.org/show_bug.cgi?id=129058
Reviewed by Anders Carlsson.
Replace uses of OwnPtr and PassOwnPtr in Element, Node and the related
classes with std::unique_ptr and move semantics.
* dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::takeSnapshot):
(WebCore::ChildNodesLazySnapshot::hasSnapshot):
* dom/Element.cpp:
(WebCore::ensureAttrNodeListForElement):
(WebCore::Element::attributes):
* dom/ElementIteratorAssertions.h:
(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):
* dom/ElementRareData.h:
(WebCore::ElementRareData::setAttributeMap):
* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
(WebCore::MutationObserverRegistration::addRegistrationNodesToSet):
* dom/MutationObserverRegistration.h:
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::NamedNodeMap):
* dom/Node.cpp:
(WebCore::Node::ensureRareData):
(WebCore::Node::didMoveToNewDocument):
(WebCore::Node::ensureEventTargetData):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::notifyMutationObserversNodeWillDetach):
* dom/Node.h:
* dom/NodeRareData.h:
(WebCore::NodeListsNodeData::NodeListsNodeData):
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::clearNodeLists):
(WebCore::NodeRareData::ensureNodeLists):
(WebCore::NodeRareData::ensureMutationObserverData):
* dom/StyledElement.cpp:
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Tue, 25 Feb 2014 08:19:25 +0000 (08:19 +0000)]
Prune dead code for Web Inspector memory instrumentation.
<https://webkit.org/b/129286>
Source/WebCore:
This was leftover code from Chromium's inspector. It's not used by
today's WebKit inspector.
Reviewed by Sam Weinig.
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorController.h:
* inspector/InspectorMemoryAgent.cpp: Removed.
* inspector/InspectorMemoryAgent.h: Removed.
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
* inspector/InspectorTimelineAgent.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
* inspector/protocol/Memory.json: Removed.
Source/WebInspectorUI:
Reviewed by Sam Weinig.
* UserInterface/Protocol/InspectorWebBackendCommands.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 25 Feb 2014 08:09:33 +0000 (08:09 +0000)]
Build fix for case-sensitive filesystems.
* WebProcess/ios/WebVideoFullscreenManager.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Tue, 25 Feb 2014 08:08:17 +0000 (08:08 +0000)]
AX: Support abbr, acronym
https://bugs.webkit.org/show_bug.cgi?id=128860
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Expose the data in <abbr>, <acronym> and <th abbr=""> as an
alternateTextValue() parameter.
Test: platform/mac/accessibility/abbr-acronym-tags.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasTagName):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::alternateTextValue):
(WebCore::AccessibilityObject::supportsAlternateTextValue):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::alternateTextValue):
(WebCore::AccessibilityRenderObject::supportsAlternateTextValue):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::alternateTextValue):
(WebCore::AccessibilityTableCell::supportsAlternateTextValue):
* accessibility/AccessibilityTableCell.h:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXAttributeStringSetAlternateTextValue):
(AXAttributedStringAppendText):
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
* platform/mac/accessibility/abbr-acronym-tags-expected.txt: Added.
* platform/mac/accessibility/abbr-acronym-tags.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 25 Feb 2014 07:51:14 +0000 (07:51 +0000)]
[GTK] Mark view source mode methods as deprecated
https://bugs.webkit.org/show_bug.cgi?id=128920
Reviewed by Martin Robinson.
Source/WebKit/gtk:
* webkit/webkitwebview.cpp: Mark set/get_view_source_mode as
deprecated in the documentation.
* webkit/webkitwebview.h: Add deprecation guards.
Source/WebKit2:
Mark WEBKIT_VIEW_MODE_SOURCE as deprecated in documentation and
only show warnings when set_view_mode is used with WEBKIT_VIEW_MODE_SOURCE.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_set_view_mode):
(webkit_web_view_get_view_mode):
* UIProcess/API/gtk/WebKitWebView.h:
Tools:
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(beforeAll): Remove view mode test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 25 Feb 2014 07:49:46 +0000 (07:49 +0000)]
[Mac] Stop looking for plug-in profiles in /S/L/Sandbox/Profiles
https://bugs.webkit.org/show_bug.cgi?id=129262
<rdar://problem/
16149420>
Reviewed by Sam Weinig.
Remove unused code.
* Shared/Plugins/mac/PluginSandboxProfile.mm:
(WebKit::pluginSandboxProfileDirectory):
(WebKit::pluginSandboxCommonProfile):
(WebKit::pluginSandboxProfile):
(WebKit::pluginHasSandboxProfile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 25 Feb 2014 07:30:21 +0000 (07:30 +0000)]
[GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
https://bugs.webkit.org/show_bug.cgi?id=128417
Reviewed by Carlos Garcia Campos.
.:
* Source/cmake/OptionsGTK.cmake: Define the paths to the pkgconfig files here, so that they
may one day be used in the webkitdom config file generation.
Source/WebCore:
* bindings/gobject/GNUmakefile.am: Generate a config file for webkitdom documentation generation.
Source/WebKit:
* PlatformGTK.cmake: Correct the definition of WebKitGTK_ENUM_GENERATION_HEADERS and generate
a gtkdoc-webkitgtk.cfg file to be used by generate-gtkdoc.
Source/WebKit/gtk:
* GNUmakefile.am: Generate a config file for generate-gtkdoc.
Source/WebKit2:
* GNUmakefile.am: Generate a config file for generate-gtkdoc.
* PlatformGTK.cmake: Ditto.
Tools:
* gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
* gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
a makefile. This allows accepting a header list from the build system, which can be used
to dynamically build a list of ignored files. We can ignore any source file that doesn't
have a corresponding header file on the header list.
* gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
source directories to gtkdoc-scan.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 25 Feb 2014 07:13:23 +0000 (07:13 +0000)]
Fix build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 25 Feb 2014 06:59:38 +0000 (06:59 +0000)]
Spread operator has a bad time when applied to call function
https://bugs.webkit.org/show_bug.cgi?id=128853
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Follow on from the previous patch the added an extra slot to
op_call_varargs (and _call, _call_eval, _construct). We now
use the slot as an offset to in effect act as a 'slice' on
the spread subject. This allows us to automatically retain
all our existing argument and array optimisatons. Most of
this patch is simply threading the offset around.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::getArgumentByVal):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::sizeFrameForVarargs):
(JSC::loadVarargs):
* interpreter/Interpreter.h:
* jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
* jit/JITInlines.h:
(JSC::JIT::callOperation):
* jit/JITOperations.cpp:
* jit/JITOperations.h:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/Arguments.cpp:
(JSC::Arguments::copyToArguments):
* runtime/Arguments.h:
* runtime/JSArray.cpp:
(JSC::JSArray::copyToArguments):
* runtime/JSArray.h:
LayoutTests:
Test case all the things!
* js/regress/call-spread-call-expected.txt: Added.
* js/regress/call-spread-call.html: Added.
* js/regress/script-tests/call-spread-call.js: Added.
(testFunction):
(test2):
(test3):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 25 Feb 2014 06:46:12 +0000 (06:46 +0000)]
Switch from prefixed CSS gradient to unprefixed.
https://bugs.webkit.org/show_bug.cgi?id=129279
Reviewed by Andreas Kling.
* UserInterface/Views/BreakpointActionView.css:
(.breakpoint-action-append-button):
(.breakpoint-action-remove-button):
* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch):
* UserInterface/Views/CompletionSuggestionsView.css:
(.completion-suggestions-container > .item:active):
* UserInterface/Views/DashboardView.css:
(.toolbar .dashboard):
* UserInterface/Views/DataGrid.css:
(.data-grid th):
(.data-grid table.data):
(.data-grid th.sortable:not(.mouse-over-collapser):active):
(.data-grid th.sort-ascending, .data-grid th.sort-descending):
(.data-grid th.sortable.sort-ascending:not(.mouse-over-collapser):active, .data-grid th.sortable.sort-descending:not(.mouse-over-collapser):active):
(body.window-inactive .data-grid th.sort-descending):
* UserInterface/Views/DetailsSection.css:
(.details-section > .header):
(.details-section .details-section > .header):
* UserInterface/Views/DividerNavigationItem.css:
(.navigation-bar .item.divider):
* UserInterface/Views/FindBanner.css:
(.find-banner > button:active:not(:disabled)):
* UserInterface/Views/Main.css:
(#split-content-browser > .navigation-bar):
* UserInterface/Views/NavigationSidebarPanel.css:
(.sidebar > .panel.navigation > .overflow-shadow):
(.navigation-sidebar-panel-content-tree-outline .item.selected):
(.navigation-sidebar-panel-content-tree-outline:focus .item.selected):
(body.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected):
* UserInterface/Views/ProbeSetDataGrid.css:
(.details-section.probe-set .data-grid > .data-container td.unknown-value):
(.details-section.probe-set .data-grid th):
* UserInterface/Views/RadioButtonNavigationItem.css:
(.navigation-bar .item.radio.button.text-only.selected):
* UserInterface/Views/TextEditor.css:
(.text-editor .bouncy-highlight):
* UserInterface/Views/TimelineContentView.css:
(.content-view.timeline > .view-container > .timeline-view > .data-grid table.data):
* UserInterface/Views/TimelineDataGrid.css:
(.timeline-data-grid-tree-outline .item:hover):
* UserInterface/Views/TimelineRuler.css:
(.timeline-ruler > .header > .divider):
* UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.timeline > .title-bar):
(.sidebar > .panel.timeline > .content > .stripe-background):
* UserInterface/Views/Toolbar.css:
(body:not(.mac-platform) .toolbar):
(body.docked.mac-platform.mavericks .toolbar):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 25 Feb 2014 05:45:35 +0000 (05:45 +0000)]
32-bit build fix.
* UIProcess/API/Cocoa/_WKElementAction.mm:
(+[_WKElementAction elementActionWithType:customTitle:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mark.lam@apple.com [Tue, 25 Feb 2014 04:44:09 +0000 (04:44 +0000)]
Need to initialize VM stack data even when the VM is on an exclusive thread.
<https://webkit.org/b/129265>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
We check VM::exclusiveThread as an optimization to forego the need to do
JSLock locking. However, we recently started piggy backing on JSLock's
lock() and unlock() to initialize VM stack data (stackPointerAtVMEntry
and lastStackTop) to appropriate values for the current thread. This is
needed because we may be acquiring the lock to enter the VM on a different
thread.
As a result, we ended up not initializing the VM stack data when
VM::exclusiveThread causes us to bypass the locking activity. Even though
the VM::exclusiveThread will not have to deal with the VM being entered
on a different thread, it still needs to initialize the VM stack data.
The VM relies on that data being initialized properly once it has been
entered.
With this fix, we push the check for exclusiveThread down into the JSLock,
and handle the bypassing of unneeded locking activity there while still
executing the necessary the VM stack data initialization.
* API/APIShims.h:
(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::shouldDropAllLocks):
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::addCurrentThread):
* runtime/JSLock.cpp:
(JSC::JSLockHolder::JSLockHolder):
(JSC::JSLockHolder::init):
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::setExclusiveThread):
(JSC::JSLock::lock):
(JSLock::unlock):
(JSLock::currentThreadIsHoldingLock):
(JSLock::dropAllLocks):
(JSLock::grabAllLocks):
* runtime/JSLock.h:
(JSC::JSLock::exclusiveThread):
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
(JSC::VM::exclusiveThread):
(JSC::VM::setExclusiveThread):
(JSC::VM::currentThreadIsHoldingAPILock):
Source/WebCore:
No new tests.
* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
- Added an assertion to ensure that we are holding the JSLock.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonVM):
- Updated to use the new VM::setExclusiveThread().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 25 Feb 2014 04:00:13 +0000 (04:00 +0000)]
[Cocoa] Start adding API for customizing actions on activated elements
https://bugs.webkit.org/show_bug.cgi?id=129284
Reviewed by Anders Carlsson.
* UIProcess/API/Cocoa/_WKActivatedElementInfo.h: Added. Includes the public interface of what
was WKElementActionInfo.
* UIProcess/API/Cocoa/_WKActivatedElementInfo.m: Added.
(-[_WKActivatedElementInfo _initWithURL:location:title:rect:]): Moved and renamed internal
initializer from WKElementActionInfo.
(-[_WKActivatedElementInfo dealloc]): Moved from WKElementActionInfo.
(-[_WKActivatedElementInfo _boundingRect]): Added private accessor.
(-[_WKActivatedElementInfo _interactionLocation]): Ditto.
* UIProcess/API/Cocoa/_WKActivatedElementInfoInternal.h: Added.
* UIProcess/API/Cocoa/_WKElementAction.h: Added.
(_WKElementActionType): Moved from WKActionSheet.h and turned into a proper NS_ENUM.
* UIProcess/API/Cocoa/_WKElementAction.mm: Added.
(-[_WKElementAction _initWithTitle:actionHandler:type:]): Moved and renamed internal
initializer from WKActionSheet.mm.
(-[_WKElementAction dealloc]): Moved from WKActionSheet.mm.
(+[_WKElementAction elementActionWithTitle:actionHandler:]): Moved and renamed.
(copyElement): Moved from WKActionSheet.mm.
(saveImage): Ditto.
(addToReadingList): Ditto.
(+[_WKElementAction elementActionWithType:customTitle:]): Moved and renamed.
(+[_WKElementAction elementActionWithType:]): Ditto.
(-[_WKElementAction _runActionWithElementInfo:view:]): Moved from WKActionSheet.mm.
* UIProcess/API/Cocoa/WKElementActionInternal.h: Added.
* UIProcess/ios/WKActionSheet.h: Removed declarations that were moved elsewhere.
* UIProcess/ios/WKActionSheet.mm: Removed code that was moved elsewhere.
* UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant actionSheet:clickedButtonAtIndex:]):
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant showDataDetectorsSheet]):
* WebKit2.xcodeproj/project.pbxproj: Added references to new files. Changed the Objective-C
class name check to allow _WK as a class name prefix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Tue, 25 Feb 2014 03:34:44 +0000 (03:34 +0000)]
Unreviewed. This file should not be marked as executable (copied in from ANGLE).
* include/KHR/khrplatform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Feb 2014 03:33:27 +0000 (03:33 +0000)]
Add a DefaultVisitedLinkProvider and route visited link actions through it
https://bugs.webkit.org/show_bug.cgi?id=129285
Reviewed by Dan Bernstein.
Source/WebCore:
DefaultVisitedLinkProvider currently just forwards everything to the visited link strategy,
but will soon take over the responsibilities of visited link handling from PageGroup.
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* dom/VisitedLinkState.cpp:
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
* loader/HistoryController.cpp:
(WebCore::addVisitedLink):
(WebCore::HistoryController::updateForStandardLoad):
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
(WebCore::HistoryController::updateForClientRedirect):
(WebCore::HistoryController::updateForSameDocumentNavigation):
(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):
* page/DefaultVisitedLinkProvider.cpp: Copied from Source/WebCore/page/VisitedLinkProvider.h.
(WebCore::DefaultVisitedLinkProvider::create):
(WebCore::DefaultVisitedLinkProvider::DefaultVisitedLinkProvider):
(WebCore::DefaultVisitedLinkProvider::~DefaultVisitedLinkProvider):
(WebCore::DefaultVisitedLinkProvider::isLinkVisited):
(WebCore::DefaultVisitedLinkProvider::addVisitedLink):
* page/DefaultVisitedLinkProvider.h: Copied from Source/WebCore/page/VisitedLinkProvider.h.
* page/Page.cpp:
(WebCore::Page::visitedLinkProvider):
* page/Page.h:
* page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
(WebCore::PageGroup::visitedLinkProvider):
* page/PageGroup.h:
* page/VisitedLinkProvider.h:
Tools:
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate applicationDidFinishLaunching:]):
Set a shared history so we'll get visited link tracking.
* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController awakeFromNib]):
Set a group name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 25 Feb 2014 03:00:59 +0000 (03:00 +0000)]
Fix the missing navigation bar in the Debugger sidebar panel.
Sorting the CSS resources caused specificity issue.
https://bugs.webkit.org/show_bug.cgi?id=129251
Reviewed by Joseph Pecoraro.
* UserInterface/Views/DebuggerSidebarPanel.css:
(.sidebar > .panel.navigation.debugger > .content):
(.sidebar > .panel.navigation.debugger > .navigation-bar):
* UserInterface/Views/LayoutTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.layout .item .subtitle):
* UserInterface/Views/NetworkTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.network .item .subtitle):
* UserInterface/Views/ResourceSidebarPanel.css:
(.sidebar > .panel.navigation.resource > .empty-content-placeholder):
(.sidebar > .panel.navigation.resource > .search-bar):
(.sidebar > .panel.navigation.resource > .search-bar > input[type="search"]):
* UserInterface/Views/ScriptTimelineView.css:
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.script .item .subtitle):
* UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline > .status-bar):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:hover):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording:hover):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.forced):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording.forced):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-status):
(.sidebar > .panel.navigation.timeline > .title-bar):
(.sidebar > .panel.navigation.timeline > .title-bar.timelines):
(.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
(.sidebar > .panel.navigation.timeline > .timelines-content):
(.sidebar > .panel.navigation.timeline > .timelines-content .close-button):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item .icon):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected .close-button):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item:not(.selected):nth-child(even)):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item:not(.selected):not(:first-child)):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item):
(.sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item):
(.sidebar > .panel.navigation.timeline > .timelines-content .close-button:active):
(.sidebar > .panel.navigation.timeline > .empty-content-placeholder):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content):
(.sidebar > .panel.navigation.timeline > .content > .stripe-background):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content > .stripe-background):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 25 Feb 2014 02:59:18 +0000 (02:59 +0000)]
Use RetainPtrs for two WKContentView data members
https://bugs.webkit.org/show_bug.cgi?id=129276
Reviewed by Benjamin Poulain.
The UITextInputTraits were leaked. Fix with RetainPtr goodness.
Rename the obscure _accessory to _formAccessoryView and
make it a RetainPtr.
Rearrange the data members of the WKContentView class extension
for better packing and readability.
* UIProcess/ios/WKContentView.h:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
(-[WKContentView inputAccessoryView]):
(-[WKContentView _updateAccessory]):
(-[WKContentView textInputTraits]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 25 Feb 2014 02:40:28 +0000 (02:40 +0000)]
Remove WKInteractionView, move code into WKContentView
https://bugs.webkit.org/show_bug.cgi?id=129275
Reviewed by Benjamin Poulain.
WKInteractionView as an interim solution as WebKit2 on iOS was being
brought up, and should be removed.
Move its code into a category on WKContentView, mostly unchanged. The
WKContentView (WKInteraction) categroy now implements the various protocols
that WKInteractionView implemented.
WKContentView is not an API class, so no longer has WK_API_CLASS, and can
have implementation-related data members. WKContentViewInternal.h is removed.
WKContentView now exposes a WebPageProxy* rather than a WKPageRef.
Other changes: WKActionSheetAssistant no longer stores a WebPageProxy,
getting it from the WKContentView instead.
WKAutoCorrectionData and InteractionInformationAtPosition are stored via unique_ptr
to reduce class size, and avoid having to expose their details in the header.
* Configurations/WebKit2.xcconfig:
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/API/ios/WKViewIOS.mm:
(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView pageRef]):
(-[WKView _pageExtendedBackgroundColor]):
(-[WKView _setBackgroundExtendsBeyondPage:]):
(-[WKView _backgroundExtendsBeyondPage]):
* UIProcess/ios/PageClientImplIOS.mm:
* UIProcess/ios/WKActionSheet.h:
* UIProcess/ios/WKActionSheet.mm:
(-[WKActionSheet initWithView:]):
(+[WKElementAction customElementActionWithTitle:actionHandler:]):
(copyElement):
(saveImage):
(+[WKElementAction standardElementActionWithType:customTitle:]):
(-[WKElementAction runActionWithElementInfo:view:]):
* UIProcess/ios/WKActionSheetAssistant.h:
* UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant initWithView:]):
(-[WKActionSheetAssistant dealloc]):
(-[WKActionSheetAssistant initialPresentationRectInHostViewForSheet]):
(-[WKActionSheetAssistant presentationRectInHostViewForSheet]):
(-[WKActionSheetAssistant actionSheet:clickedButtonAtIndex:]):
(-[WKActionSheetAssistant _createSheetWithElementActions:showLinkTitle:]):
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant showDataDetectorsSheet]):
(-[WKActionSheetAssistant cleanupSheet]):
* UIProcess/ios/WKContentView.h:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView initWithFrame:context:WebKit::configuration:WebKit::]):
(-[WKContentView dealloc]):
(-[WKContentView page]):
(-[WKContentView isAssistingNode]):
(-[WKContentView didFinishScrolling]):
(-[WKContentView willStartZoomOrScroll]):
(-[WKContentView willStartUserTriggeredScroll]):
(-[WKContentView willStartUserTriggeredZoom]):
(-[WKContentView didZoomToScale:]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _didCommitLayerTree:WebKit::]):
* UIProcess/ios/WKContentViewInteraction.h: Renamed from Source/WebKit2/UIProcess/ios/WKInteractionView.h.
* UIProcess/ios/WKContentViewInteraction.mm: Renamed from Source/WebKit2/UIProcess/ios/WKInteractionView.mm.
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView positionInformation]):
(-[WKContentView setInputDelegate:]):
(-[WKContentView inputDelegate]):
(-[WKContentView isEditable]):
(-[WKContentView canBecomeFirstResponder]):
(-[WKContentView resignFirstResponder]):
(-[WKContentView _webTouchEventsRecognized:]):
(inflateQuad):
(-[WKContentView _webTouchEvent:WebKit::preventsNativeGestures:]):
(-[WKContentView _didGetTapHighlightForRequest:color:WebCore::quads:WebCore::topLeftRadius:WebCore::topRightRadius:WebCore::bottomLeftRadius:WebCore::bottomRightRadius:WebCore::]):
(-[WKContentView _cancelLongPressGestureRecognizer]):
(-[WKContentView _didScroll]):
(-[WKContentView _requiresKeyboardResetOnReload]):
(-[WKContentView gestureRecognizer:canPreventGestureRecognizer:]):
(-[WKContentView gestureRecognizer:canBePreventedByGestureRecognizer:]):
(isSamePair):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView _showImageSheet]):
(-[WKContentView _showLinkSheet]):
(-[WKContentView _showDataDetectorsSheet]):
(-[WKContentView _actionForLongPress]):
(-[WKContentView ensurePositionInformationIsUpToDate:]):
(-[WKContentView _updatePositionInformation]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _cancelInteraction]):
(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView pointIsInAssistedNode:]):
(-[WKContentView webSelectionRects]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _longPressRecognized:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _doubleTapRecognized:]):
(-[WKContentView _twoFingerDoubleTapRecognized:]):
(-[WKContentView _twoFingerPanRecognized:]):
(-[WKContentView _attemptClickAtLocation:]):
(-[WKContentView useSelectionAssistantWithMode:]):
(-[WKContentView clearSelection]):
(-[WKContentView _positionInformationDidChange:]):
(-[WKContentView _willStartScrollingOrZooming]):
(-[WKContentView _willStartUserTriggeredScrollingOrZooming]):
(-[WKContentView _didEndScrollingOrZooming]):
(-[WKContentView inputAccessoryView]):
(-[WKContentView supportedPasteboardTypesForCurrentSelection]):
(-[WKContentView _addShortcut:]):
(-[WKContentView _promptForReplace:]):
(-[WKContentView replace:]):
(-[WKContentView canPerformAction:withSender:]):
(-[WKContentView _resetShowingTextStyle:]):
(-[WKContentView _performAction:]):
(-[WKContentView copy:]):
(-[WKContentView cut:]):
(-[WKContentView paste:]):
(-[WKContentView select:]):
(-[WKContentView selectAll:]):
(-[WKContentView toggleBoldface:]):
(-[WKContentView toggleItalics:]):
(-[WKContentView toggleUnderline:]):
(-[WKContentView _showTextStyleOptions:]):
(-[WKContentView _showDictionary:]):
(-[WKContentView _define:]):
(toWKGestureType):
(toUIWKGestureType):
(toWKSelectionTouch):
(toUIWKSelectionTouch):
(toWKGestureRecognizerState):
(toUIGestureRecognizerState):
(toUIWKSelectionFlags):
(toWKHandlePosition):
(selectionChangedWithGesture):
(selectionChangedWithTouch):
(-[WKContentView _didUpdateBlockSelectionWithTouch:WebKit::withFlags:WebKit::growThreshold:shrinkThreshold:]):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]):
(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):
(-[WKContentView changeBlockSelectionWithTouchAt:withSelectionTouch:forHandle:]):
(-[WKContentView autocorrectionData]):
(-[WKContentView requestAutocorrectionRectsForString:withCompletionHandler:]):
(-[WKContentView textFirstRect]):
(-[WKContentView textLastRect]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):
(-[WKContentView accessoryDone]):
(-[WKContentView accessoryTab:]):
(-[WKContentView accessoryAutoFill]):
(-[WKContentView accessoryClear]):
(-[WKContentView _updateAccessory]):
(-[WKContentView textInRange:]):
(-[WKContentView replaceRange:withText:]):
(-[WKContentView selectedTextRange]):
(-[WKContentView caretRectForPosition:]):
(-[WKContentView selectionRectsForRange:]):
(-[WKContentView setSelectedTextRange:]):
(-[WKContentView hasMarkedText]):
(-[WKContentView markedText]):
(-[WKContentView markedTextRange]):
(-[WKContentView markedTextStyle]):
(-[WKContentView setMarkedTextStyle:]):
(-[WKContentView setMarkedText:selectedRange:]):
(-[WKContentView unmarkText]):
(-[WKContentView beginningOfDocument]):
(-[WKContentView endOfDocument]):
(-[WKContentView textRangeFromPosition:toPosition:]):
(-[WKContentView positionFromPosition:offset:]):
(-[WKContentView positionFromPosition:inDirection:offset:]):
(-[WKContentView comparePosition:toPosition:]):
(-[WKContentView offsetFromPosition:toPosition:]):
(-[WKContentView tokenizer]):
(-[WKContentView positionWithinRange:farthestInDirection:]):
(-[WKContentView characterRangeByExtendingPosition:inDirection:]):
(-[WKContentView baseWritingDirectionForPosition:inDirection:]):
(-[WKContentView setBaseWritingDirection:forRange:]):
(-[WKContentView firstRectForRange:]):
(-[WKContentView closestPositionToPoint:]):
(-[WKContentView closestPositionToPoint:withinRange:]):
(-[WKContentView characterRangeAtPoint:]):
(-[WKContentView deleteBackward]):
(-[WKContentView insertText:]):
(-[WKContentView hasText]):
(-[WKContentView textInputTraits]):
(-[WKContentView interactionAssistant]):
(-[WKContentView webSelectionAssistant]):
(-[WKContentView selectionRange]):
(-[WKContentView rectForNSRange:]):
(-[WKContentView _markedTextNSRange]):
(-[WKContentView selectedDOMRange]):
(-[WKContentView setSelectedDOMRange:affinityDownstream:]):
(-[WKContentView replaceRangeWithTextWithoutClosingTyping:replacementText:]):
(-[WKContentView rectContainingCaretSelection]):
(-[WKContentView requiresKeyEvents]):
(-[WKContentView handleKeyWebEvent:]):
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
(-[WKContentView setBottomBufferHeight:]):
(-[WKContentView automaticallySelectedOverlay]):
(-[WKContentView selectionGranularity]):
(-[WKContentView insertDictationResult:withCorrectionIdentifier:]):
(-[WKContentView metadataDictionariesForDictationResults]):
(-[WKContentView previousUnperturbedDictationResultBoundaryFromPosition:]):
(-[WKContentView nextUnperturbedDictationResultBoundaryFromPosition:]):
(-[WKContentView moveBackward:]):
(-[WKContentView moveForward:]):
(-[WKContentView characterBeforeCaretSelection]):
(-[WKContentView wordContainingCaretSelection]):
(-[WKContentView wordRangeContainingCaretSelection]):
(-[WKContentView setMarkedText:]):
(-[WKContentView hasContent]):
(-[WKContentView selectAll]):
(-[WKContentView textColorForCaretSelection]):
(-[WKContentView fontForCaretSelection]):
(-[WKContentView hasSelection]):
(-[WKContentView isPosition:atBoundary:inDirection:]):
(-[WKContentView positionFromPosition:toBoundary:inDirection:]):
(-[WKContentView isPosition:withinTextUnit:inDirection:]):
(-[WKContentView rangeEnclosingPosition:withGranularity:inDirection:]):
(-[WKContentView takeTraitsFrom:]):
(-[WKContentView _startAssistingKeyboard]):
(-[WKContentView _stopAssistingKeyboard]):
(-[WKContentView _startAssistingNode]):
(-[WKContentView _stopAssistingNode]):
(-[WKContentView _selectionChanged]):
(-[WKContentView shouldIgnoreWebTouch]):
(-[WKContentView isAnyTouchOverActiveArea:]):
(-[WKTextRange _isCaret]):
(-[WKTextRange _isRanged]):
(+[WKTextRange textRangeWithState:isRange:isEditable:startRect:endRect:selectionRects:selectedTextLength:]):
(-[WKTextRange dealloc]):
(-[WKTextRange description]):
(-[WKTextRange start]):
(-[WKTextRange end]):
(-[WKTextRange isEmpty]):
(-[WKTextRange isEqual:]):
(+[WKTextPosition textPositionWithRect:]):
(-[WKTextPosition isEqual:]):
(-[WKTextPosition description]):
(-[WKTextSelectionRect initWithWebRect:]):
(-[WKTextSelectionRect dealloc]):
(+[WKTextSelectionRect textSelectionRectsWithWebRects:]):
(-[WKTextSelectionRect rect]):
(-[WKTextSelectionRect writingDirection]):
(-[WKTextSelectionRect range]):
(-[WKTextSelectionRect containsStart]):
(-[WKTextSelectionRect containsEnd]):
(-[WKTextSelectionRect isVertical]):
(+[WKAutocorrectionRects autocorrectionRectsWithRects:lastRect:]):
(+[WKAutocorrectionContext autocorrectionContextWithData:markedText:selectedText:afterText:selectedRangeInMarkedText:]):
(-[WKAutocorrectionContext dealloc]):
* UIProcess/ios/WKContentViewInternal.h: Removed.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 25 Feb 2014 02:02:50 +0000 (02:02 +0000)]
FTL should do polymorphic PutById inlining
https://bugs.webkit.org/show_bug.cgi?id=129210
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg and Oliver Hunt.
This makes PutByIdStatus inform us about polymorphic cases by returning an array of
PutByIdVariants. The DFG now has a node called MultiPutByOffset that indicates a
selection of multiple inlined PutByIdVariants.
MultiPutByOffset is almost identical to MultiGetByOffset, which we added in
http://trac.webkit.org/changeset/164207.
This also does some FTL refactoring to make MultiPutByOffset share code with some nodes
that generate similar code.
1% speed-up on V8v7 due to splay improving by 6.8%. Splay does the thing where it
sometimes swaps field insertion order, creating fake polymorphism.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):
(JSC::PutByIdStatus::dump):
* bytecode/PutByIdStatus.h:
(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::isSimple):
(JSC::PutByIdStatus::numVariants):
(JSC::PutByIdStatus::variants):
(JSC::PutByIdStatus::at):
(JSC::PutByIdStatus::operator[]):
* bytecode/PutByIdVariant.cpp: Added.
(JSC::PutByIdVariant::dump):
(JSC::PutByIdVariant::dumpInContext):
* bytecode/PutByIdVariant.h: Added.
(JSC::PutByIdVariant::PutByIdVariant):
(JSC::PutByIdVariant::replace):
(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::kind):
(JSC::PutByIdVariant::isSet):
(JSC::PutByIdVariant::operator!):
(JSC::PutByIdVariant::structure):
(JSC::PutByIdVariant::oldStructure):
(JSC::PutByIdVariant::newStructure):
(JSC::PutByIdVariant::structureChain):
(JSC::PutByIdVariant::offset):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::emitPrototypeChecks):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::emitPutById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
* dfg/DFGNode.cpp:
(JSC::DFG::MultiPutByOffsetData::writesStructures):
(JSC::DFG::MultiPutByOffsetData::reallocatesStorage):
* dfg/DFGNode.h:
(JSC::DFG::Node::convertToPutByOffset):
(JSC::DFG::Node::hasMultiPutByOffsetData):
(JSC::DFG::Node::multiPutByOffsetData):
* dfg/DFGNodeType.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compileAllocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compileReallocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compilePutByOffset):
(JSC::FTL::LowerDFGToLLVM::compileMultiPutByOffset):
(JSC::FTL::LowerDFGToLLVM::loadProperty):
(JSC::FTL::LowerDFGToLLVM::storeProperty):
(JSC::FTL::LowerDFGToLLVM::addressOfProperty):
(JSC::FTL::LowerDFGToLLVM::storageForTransition):
(JSC::FTL::LowerDFGToLLVM::allocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::reallocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::emitStoreBarrier):
* tests/stress/fold-multi-put-by-offset-to-put-by-offset.js: Added.
* tests/stress/multi-put-by-offset-reallocation-butterfly-cse.js: Added.
* tests/stress/multi-put-by-offset-reallocation-cases.js: Added.
LayoutTests:
Reviewed by Mark Hahnenberg and Oliver Hunt.
Add a microbenchmark for polymorphic PutById.
* js/regress/polymorphic-put-by-id-expected.txt: Added.
* js/regress/polymorphic-put-by-id.html: Added.
* js/regress/script-tests/polymorphic-put-by-id.js: Added.
(foo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Feb 2014 01:59:17 +0000 (01:59 +0000)]
WKProcessPool should use secondary processes + network process
https://bugs.webkit.org/show_bug.cgi?id=129282
Reviewed by Simon Fraser.
* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool initWithConfiguration:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Feb 2014 01:41:39 +0000 (01:41 +0000)]
Add WebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=129280
Reviewed by Dan Bernstein.
Source/WebKit:
Add new files.
* WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
This is a first step towards getting rid of page groups in WebCore. The idea is that
everything that is per page group in WebCore will be per page. In order to retain WebKit1 compatibility
WebViewGroup is going to take over more and more responsibility from WebCore::PageGroup.
* WebCoreSupport/WebViewGroup.h: Added.
* WebCoreSupport/WebViewGroup.mm: Added.
(webViewGroups):
(WebViewGroup::getOrCreate):
(WebViewGroup::WebViewGroup):
(WebViewGroup::~WebViewGroup):
(WebViewGroup::addWebView):
(WebViewGroup::removeWebView):
* WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView _close]):
(-[WebView setGroupName:]):
* WebView/WebViewData.h:
* WebView/WebViewData.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Feb 2014 00:40:06 +0000 (00:40 +0000)]
WK2 AVKit fullscreen doesn't display video.
https://bugs.webkit.org/show_bug.cgi?id=128564
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-02-24
Reviewed by Simon Fraser.
Source/WebCore:
* WebCore.exp.in:
Export WebCore::PlatformCALayer::platformCALayer()
* platform/ios/WebVideoFullscreenInterface.h:
* platform/ios/WebVideoFullscreenInterfaceAVKit.h:
Remove SetVideoLayerID().
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setVideoLayer):
Wrap make video layer look like an AVAVPlayerLayer with WebAVPlayerLayer
* platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::setMediaElement):
Pass along the videoLayer before borrowing it so the interface will be ready to
catch the transaction that removes it.
Source/WebKit2:
* Shared/mac/RemoteLayerTreeTransaction.h:
Add a property to track video layer pending fullscreen.
(WebKit::RemoteLayerTreeTransaction::isVideoLayerIDPendingFullscreen):
(WebKit::RemoteLayerTreeTransaction::addVideoLayerIDPendingFullscreen):
Add a property to track video layer pending fullscreen.
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
Encode and decode m_videoLayerIDsPendingFullscreen.
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didCommitLayerTree):
Let WebVideoFullscreenManagerProxy see the RemoteLayerTreeTransaction.
* UIProcess/ios/WebVideoFullscreenManagerProxy.cpp:
(WebKit::WebVideoFullscreenManagerProxy::didCommitLayerTree):
Look for video layer pending fullscreen on the transaction to initiate
fullscreen.
(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerID):
Start looking for the video layer pending fullscreen in the transaction.
(WebKit::WebVideoFullscreenManagerProxy::enterFullscreen):
Override to prevent fullscreen from happening before the layer
is pending fullscreen.
* UIProcess/ios/WebVideoFullscreenManagerProxy.h:
* UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:
Pass a more specific videoLayerID in SetVideoLayerID,
i.e. WebCore::GraphicsLayer::PlatformLayerID.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::willCommitLayerTree):
Move webPage specific transaction building here, including,
giving WebVideoFullscreenManager a chance to modify the transaction.
* WebProcess/WebPage/WebPage.h:
Add willCommitLayerTree();
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::~PlatformCALayerRemoteCustom):
Make and break the connection from CALayer to PlatformCALayerRemoteCustom,
the same way it is done for PlatformCALayerMac.
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Move WebPage specific transaction building into WebPage::willCommitLayerTree.
* WebProcess/ios/WebVideoFullscreenManager.cpp:
(WebKit::WebVideoFullscreenManager::willCommitLayerTree):
addVideoLayerIDPendingFullscreen on RemoteLayerTreeTransaction when needed.
(WebKit::WebVideoFullscreenManager::setVideoLayer):
Pass along the video layerID.
* WebProcess/ios/WebVideoFullscreenManager.h:
Add willCommitLayerTree() and remove setVideoLayerID().
Add a member to retain the unparented PlatformCALayer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
samuel_white@apple.com [Tue, 25 Feb 2014 00:29:28 +0000 (00:29 +0000)]
AX: AccessibilityObject::findMatchingObjects should never include 'this' in results.
https://bugs.webkit.org/show_bug.cgi?id=129243
Reviewed by Chris Fleizach.
Source/WebCore:
Fix removes the container object from the search results when searching backwards. This
makes backwards & forwards search results consistent with each other.
Test: platform/mac/accessibility/search-predicate-container-not-included.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::findMatchingObjects):
LayoutTests:
Added test to ensure that the container you are searching in can never be a search result.
* platform/mac/accessibility/search-predicate-container-not-included-expected.txt: Added.
* platform/mac/accessibility/search-predicate-container-not-included.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
samuel_white@apple.com [Tue, 25 Feb 2014 00:08:50 +0000 (00:08 +0000)]
AX: findMatchingObjects backwards start position inconsistent with forwards start position when startObject == nullptr.
https://bugs.webkit.org/show_bug.cgi?id=129266
Reviewed by Chris Fleizach.
Source/WebCore:
When searching forward with no start object, the first thing considered is the first child of
the container. However, when searching backwards with no start object nothing in the container
is considered; this basically negates the search. This patch makes backwards searching without
a start object start from the last child of the container to match forward search expectations.
Test: platform/mac/accessibility/search-predicate-start-not-specified.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::findMatchingObjects):
LayoutTests:
Added test to ensure that searching backward & forward without a start object produces similar
results. Backward will begin from the end of the container and forward will begin from the start.
* platform/mac/accessibility/search-predicate-start-not-specified-expected.txt: Added.
* platform/mac/accessibility/search-predicate-start-not-specified.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Mon, 24 Feb 2014 23:25:25 +0000 (23:25 +0000)]
Prune dead code for Web Inspector canvas instrumentation.
<https://webkit.org/b/129269>
This was leftover code from Chromium's inspector. It's not used by
today's WebKit inspector.
Reviewed by Timothy Hatcher.
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* inspector/InjectedScriptCanvasModule.cpp: Removed.
* inspector/InjectedScriptCanvasModule.h: Removed.
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorCanvasAgent.cpp: Removed.
* inspector/InspectorCanvasAgent.h: Removed.
* inspector/InspectorCanvasInstrumentation.h: Removed.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::didBeginFrame):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
* inspector/InspectorInstrumentation.h:
* inspector/InstrumentingAgents.cpp:
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::reset):
* inspector/InstrumentingAgents.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Mon, 24 Feb 2014 23:10:32 +0000 (23:10 +0000)]
[CSS Shapes] Adjust lineTop position to the next available wrapping location at shape-outsides
https://bugs.webkit.org/show_bug.cgi?id=128693
Reviewed by David Hyatt.
Source/WebCore:
When we don't have space next to the floating container, but we have space inside the floating-container next
to the defined shape-outside, we should wrap around the shape-outside. This patch fixes the behavior both for
cases when there is no space to fit at the first line, and for the additional lines cases.
Test: fast/shapes/shape-outside-floats/shape-outside-floats-linetop-adjustment.html
* rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
* rendering/line/LineWidth.cpp:
(WebCore::availableWidthAtOffset):
(WebCore::LineWidth::updateLineDimension): Added new helper.
(WebCore::isWholeLineFit): Added new helper.
(WebCore::LineWidth::wrapNextToShapeOutside): Added new helper.
(WebCore::LineWidth::fitBelowFloats): Add optional parameter for the function.
* rendering/line/LineWidth.h:
LayoutTests:
* fast/shapes/shape-outside-floats/shape-outside-floats-linetop-adjustment-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-linetop-adjustment.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Feb 2014 22:57:33 +0000 (22:57 +0000)]
JSC regressions after r164494
https://bugs.webkit.org/show_bug.cgi?id=129272
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-02-24
Reviewed by Mark Lam.
* offlineasm/x86.rb: Only avoid reverse opcode (fdivr) for Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Feb 2014 22:48:56 +0000 (22:48 +0000)]
Create SessionID value-style class for session IDs.
https://bugs.webkit.org/show_bug.cgi?id=129141
Source/WebCore:
Patch by Martin Hock <mhock@apple.com> on 2014-02-24
Reviewed by Brady Eidson.
* GNUmakefile.list.am:
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* page/Page.cpp: Add SessionID member.
(WebCore::Page::Page):
(WebCore::Page::sessionID): Retrieve sessionID or use settings if not set.
* page/Page.h:
(WebCore::Page::setSessionID):
* page/SessionID.h: Session ID class consisting solely of its uint64_t session ID.
(WebCore::SessionID::SessionID):
(WebCore::SessionID::isValid): Not empty.
(WebCore::SessionID::isEphemeral):
(WebCore::SessionID::sessionID):
(WebCore::SessionID::operator==): Value-based equality.
(WebCore::SessionID::operator!=):
(WebCore::SessionID::emptySessionID): Zero value also used for HashTraits emptyValue.
(WebCore::SessionID::defaultSessionID):
(WebCore::SessionID::legacyPrivateSessionID):
* page/SessionIDHash.h:
(WTF::SessionIDHash::hash): Just the casted session ID (low order bytes)
(WTF::SessionIDHash::equal):
(WTF::HashTraits<WebCore::SessionID>::emptyValue): Equal to emptySessionID.
(WTF::HashTraits<WebCore::SessionID>::constructDeletedValue): -1 value.
(WTF::HashTraits<WebCore::SessionID>::isDeletedValue):
Source/WebKit2:
The below changes deal solely with mechanical changes to use the SessionID value class instead of uint64_t except where noted.
Patch by Martin Hock <mhock@apple.com> on 2014-02-24
Reviewed by Brady Eidson.
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/RemoteNetworkingContext.h:
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
* NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
* Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
* Shared/Network/NetworkResourceLoadParameters.h:
* Shared/SessionTracker.cpp:
(WebKit::staticSessionMap):
(WebKit::storageSessionToID):
(WebKit::SessionTracker::sessionMap):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::sessionID):
(WebKit::SessionTracker::setSession):
(WebKit::SessionTracker::destroySession):
* Shared/SessionTracker.h: Move code to SessionID class.
* Shared/WebCoreArgumentCoders.cpp: Add encode and decode for SessionID.
(IPC::ArgumentCoder<SessionID>::encode):
(IPC::ArgumentCoder<SessionID>::decode):
* Shared/WebCoreArgumentCoders.h:
* Shared/mac/CookieStorageShim.mm:
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):
* UIProcess/APISession.cpp:
(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
(API::Session::Session):
(API::Session::isEphemeral):
(API::Session::getID):
* UIProcess/APISession.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
* UIProcess/WebContext.h:
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::sessionID):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::loadResourceSynchronously):
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
* WebProcess/WebPage/WebPage.cpp: Move sessionID to Page to allow WebCore to access it.
(WebKit::WebPage::WebPage):
(WebKit::WebPage::sessionID):
(WebKit::WebPage::isUsingEphemeralSession):
(WebKit::WebPage::setSessionID):
(WebKit::WebPage::updatePreferences):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Mon, 24 Feb 2014 22:48:54 +0000 (22:48 +0000)]
[WinCairo] Disable ANGLE build on WinCairo port.
* WebKit.vcxproj/WebKit.sln:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Feb 2014 22:29:20 +0000 (22:29 +0000)]
[CSS Grid Layout] handle undefined RemainingSpace in computeUsedBreadthOfGridTracks algorithm
https://bugs.webkit.org/show_bug.cgi?id=128372
Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-02-24
Reviewed by David Hyatt.
From Blink r165692 by <svillar@igalia.com>
Source/WebCore:
The spec defines a different code path for the computeUsedBreadthOfGridTracks algorithm
http://dev.w3.org/csswg/css-grid/#function-ComputeUsedBreadthOfGridTracks.
Basically the track breadth is different when the available size is undefined and thus,
cannot be taken into account during the computations.
The available size is undefined whenever the height is auto or the grid element has a
shrink-to-fit behavior.
It was also renamed the function to match the specs so the function name starts with
'compute' instead of 'computed'.
No new tests, but added new cases to some of them.
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::gridElementIsShrinkToFit):
(WebCore::RenderGrid::computeNormalizedFractionBreadth):
(WebCore::RenderGrid::layoutGridItems):
* rendering/RenderGrid.h:
LayoutTests:
Adapt tests to consider also cases for undefined RemainingSpace.
* fast/css-grid-layout/flex-and-minmax-content-resolution-rows-expected.txt:
* fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
* fast/css-grid-layout/flex-content-resolution-rows-expected.txt:
* fast/css-grid-layout/flex-content-resolution-rows.html:
* fast/css-grid-layout/grid-auto-columns-rows-update-expected.txt:
* fast/css-grid-layout/grid-auto-columns-rows-update.html:
* fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt:
* fast/css-grid-layout/grid-dynamic-updates-relayout.html:
* fast/css-grid-layout/grid-item-addition-track-breadth-update-expected.txt:
* fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
* fast/css-grid-layout/grid-item-multiple-minmax-content-resolution-expected.txt:
* fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html:
* fast/css-grid-layout/grid-item-removal-track-breadth-update-expected.txt:
* fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
* fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution-expected.txt:
* fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
* fast/css-grid-layout/implicit-position-dynamic-change-expected.txt:
* fast/css-grid-layout/implicit-position-dynamic-change.html:
* fast/css-grid-layout/minmax-max-content-resolution-rows-expected.txt:
* fast/css-grid-layout/minmax-max-content-resolution-rows.html:
* fast/css-grid-layout/minmax-min-content-column-resolution-rows-expected.txt:
* fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
* fast/css-grid-layout/minmax-spanning-resolution-rows-expected.txt:
* fast/css-grid-layout/minmax-spanning-resolution-rows.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Mon, 24 Feb 2014 22:21:35 +0000 (22:21 +0000)]
[Windows] Unreviewed pre-emptive build fix.
* WebCore.vcxproj/WebCoreCommon.props: Add replay directory to include path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex.christensen@flexsim.com [Mon, 24 Feb 2014 22:14:39 +0000 (22:14 +0000)]
Disabled WebGL on WinCairo.
Unreviewed.
* wtf/FeatureDefines.h:
Removed ENABLE_WEBGL definition for WinCairo port.
WebGL has not worked on WinCairo since r163079
and it was not compiling with a recent ANGLE update.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 24 Feb 2014 21:59:03 +0000 (21:59 +0000)]
Break out ImageControls style into an external stylesheet
https://bugs.webkit.org/show_bug.cgi?id=129273
Reviewed by Jer Noble.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSDefaultStyleSheets.cpp:
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
* css/CSSDefaultStyleSheets.h:
* html/shadow/mac/ImageControlsRootElementMac.cpp:
(WebCore::ImageControlsRootElementMac::maybeCreate):
* html/shadow/mac/imageControlsMac.css:
(.x-webkit-imagemenu):
(.x-webkit-imagemenu:hover):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::mediaControlsScript):
(WebCore::RenderTheme::imageControlsStyleSheet):
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::imageControlsStyleSheet):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 24 Feb 2014 21:35:52 +0000 (21:35 +0000)]
Remove PDFViewController.*, which is unused
https://bugs.webkit.org/show_bug.cgi?id=129270
Reviewed by Tim Horton.
* UIProcess/mac/PDFViewController.h: Removed.
* UIProcess/mac/PDFViewController.mm: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Mon, 24 Feb 2014 21:15:56 +0000 (21:15 +0000)]
Give non-Mac platforms a default toolbar background so it isn't just white.
https://bugs.webkit.org/show_bug.cgi?id=129260
Reviewed by Joseph Pecoraro.
* UserInterface/Base/Main.js:
(WebInspector.contentLoaded): Style the boby with platform classes.
* UserInterface/Base/Utilities.js:
(String.prototype.contains): Added.
* UserInterface/Views/Toolbar.css:
(body.docked .toolbar, body:not(.mac-platform) .toolbar): Added. Default toolbar background.
(body.docked.mac-platform.mavericks .toolbar, body.docked.mac-platform.mountain-lion): Added.
(body.mac-platform:not(.docked) .toolbar .item.button > .label): Only apply to Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 24 Feb 2014 21:10:50 +0000 (21:10 +0000)]
Rename WKProcessClass to WKProcessPool
https://bugs.webkit.org/show_bug.cgi?id=129268
Reviewed by Dan Bernstein.
Stage this rename by adding back WKProcessClass and WKProcessClassConfiguration as subclasses of the renamed classes.
* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
* UIProcess/API/Cocoa/WKProcessClass.h:
* UIProcess/API/Cocoa/WKProcessClass.mm:
* UIProcess/API/Cocoa/WKProcessClassConfiguration.h:
* UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:
* UIProcess/API/Cocoa/WKProcessClassConfigurationPrivate.h:
* UIProcess/API/Cocoa/WKProcessClassPrivate.h:
* UIProcess/API/Cocoa/WKProcessPool.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.h.
* UIProcess/API/Cocoa/WKProcessPool.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm.
(-[WKProcessPool init]):
(-[WKProcessPool initWithConfiguration:]):
(-[WKProcessPool dealloc]):
(-[WKProcessPool description]):
(-[WKProcessPool configuration]):
(-[WKProcessPool API::]):
(-[WKProcessPool _setAllowsSpecificHTTPSCertificate:forHost:]):
* UIProcess/API/Cocoa/WKProcessPoolConfiguration.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfiguration.h.
* UIProcess/API/Cocoa/WKProcessPoolConfiguration.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfiguration.mm.
(-[WKProcessPoolConfiguration _injectedBundleURL]):
(-[WKProcessPoolConfiguration _setInjectedBundleURL:]):
(-[WKProcessPoolConfiguration description]):
(-[WKProcessPoolConfiguration copyWithZone:]):
* UIProcess/API/Cocoa/WKProcessPoolConfigurationPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfigurationPrivate.h.
* UIProcess/API/Cocoa/WKProcessPoolInternal.h: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassInternal.h.
(WebKit::wrapper):
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassPrivate.h.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.h:
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration description]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration processPool]):
(-[WKWebViewConfiguration setProcessPool:]):
* UIProcess/API/Cocoa/WKWebViewConfigurationToBeRemoved.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassPrivate.h.
(-[WKWebViewConfiguration setProcessClass:]):
(-[WKWebViewConfiguration processClass]):
* UIProcess/API/mac/WKView.mm:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thiago.lacerda@openbossa.org [Mon, 24 Feb 2014 21:00:36 +0000 (21:00 +0000)]
[WebRTC] Validating RTCConfiguration according to the spec
https://bugs.webkit.org/show_bug.cgi?id=129182
Reviewed by Eric Carlson.
Spec states that:
- iceServers should not be an empty list
- the entry in the configuration dictionary is "urls", instead of "url"
- urls can be either a list or a string
Fixing all that in RTCConfiguration validation when creating a RTCPeerConnection
Source/WebCore:
Existing tests were updated.
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::appendIceServer): Added.
(WebCore::processIceServer): Added.
(WebCore::RTCPeerConnection::parseConfiguration):
LayoutTests:
* fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
* fast/mediastream/RTCPeerConnection-createAnswer.html:
* fast/mediastream/RTCPeerConnection-createOffer.html:
* fast/mediastream/RTCPeerConnection-datachannel.html:
* fast/mediastream/RTCPeerConnection-dtmf.html:
* fast/mediastream/RTCPeerConnection-events.html:
* fast/mediastream/RTCPeerConnection-expected.txt:
* fast/mediastream/RTCPeerConnection-have-local-answer.html:
* fast/mediastream/RTCPeerConnection-have-local-offer.html:
* fast/mediastream/RTCPeerConnection-have-local-pranswer.html:
* fast/mediastream/RTCPeerConnection-have-remote-offer.html:
* fast/mediastream/RTCPeerConnection-have-remote-pranswer.html:
* fast/mediastream/RTCPeerConnection-ice-expected.txt:
* fast/mediastream/RTCPeerConnection-ice.html:
* fast/mediastream/RTCPeerConnection-localDescription.html:
* fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
* fast/mediastream/RTCPeerConnection-remoteDescription.html:
* fast/mediastream/RTCPeerConnection-stable.html:
* fast/mediastream/RTCPeerConnection-state-expected.txt:
* fast/mediastream/RTCPeerConnection-state.html:
* fast/mediastream/RTCPeerConnection-stats-expected.txt:
* fast/mediastream/RTCPeerConnection-stats.html:
* fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
* fast/mediastream/RTCPeerConnection-statsSelector.html:
* fast/mediastream/RTCPeerConnection.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 24 Feb 2014 20:53:02 +0000 (20:53 +0000)]
Move non-API files out of WebKit2/UIProcess/API/mac
https://bugs.webkit.org/show_bug.cgi?id=129267
Reviewed by Anders Carlsson.
* UIProcess/mac/FindIndicatorWindow.h: Renamed from Source/WebKit2/UIProcess/API/mac/FindIndicatorWindow.h.
* UIProcess/mac/FindIndicatorWindow.mm: Renamed from Source/WebKit2/UIProcess/API/mac/FindIndicatorWindow.mm.
* UIProcess/mac/PDFViewController.h: Renamed from Source/WebKit2/UIProcess/API/mac/PDFViewController.h.
* UIProcess/mac/PDFViewController.mm: Renamed from Source/WebKit2/UIProcess/API/mac/PDFViewController.mm.
* UIProcess/mac/WKPrintingView.h: Renamed from Source/WebKit2/UIProcess/API/mac/WKPrintingView.h.
* UIProcess/mac/WKPrintingView.mm: Renamed from Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm.
* UIProcess/mac/WKTextInputWindowController.h: Renamed from Source/WebKit2/UIProcess/API/mac/WKTextInputWindowController.h.
* UIProcess/mac/WKTextInputWindowController.mm: Renamed from Source/WebKit2/UIProcess/API/mac/WKTextInputWindowController.mm.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
stavila@adobe.com [Mon, 24 Feb 2014 20:51:05 +0000 (20:51 +0000)]
[CSS Regions] Relative positioned elements overflowing the region do not get painted into the next tile
https://bugs.webkit.org/show_bug.cgi?id=129254
Reviewed by Antti Koivisto.
Source/WebCore:
The painting of the region's layer should not be aborted so early if the region's fragment shouldn't be painted
because that would prevent all the layer's children from being painted.
Another problem this patch addresses is that clipping should also be performed when the clip rect is empty,
which is what happens when painting in a tile in which the flowed element would normally be painted
if it wasn't clipped by the region.
Test: fast/regions/content-relative-next-tile.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFlowThreadIfRegionForFragments):
LayoutTests:
Added test for the painting across tiles of relative positioned elements flowed into regions.
* fast/regions/content-relative-next-tile-expected.html: Added.
* fast/regions/content-relative-next-tile.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 24 Feb 2014 20:31:04 +0000 (20:31 +0000)]
Move non-API files in the API/ios directory out to UIProcess/ios
https://bugs.webkit.org/show_bug.cgi?id=129264
Reviewed by Anders Carlsson.
* UIProcess/ios/PageClientImplIOS.h: Renamed from Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h.
* UIProcess/ios/PageClientImplIOS.mm: Renamed from Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm.
* UIProcess/ios/WKActionSheet.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKActionSheet.h.
* UIProcess/ios/WKActionSheet.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKActionSheet.mm.
* UIProcess/ios/WKContentViewInternal.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKContentViewInternal.h.
* UIProcess/ios/WKGeolocationProviderIOS.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKGeolocationProviderIOS.h.
* UIProcess/ios/WKGeolocationProviderIOS.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKGeolocationProviderIOS.mm.
* UIProcess/ios/WKInteractionView.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKInteractionView.h.
* UIProcess/ios/WKInteractionView.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm.
* UIProcess/ios/WKScrollView.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKScrollView.h.
* UIProcess/ios/WKScrollView.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKScrollView.mm.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 24 Feb 2014 20:18:10 +0000 (20:18 +0000)]
Rename PageClientImplIOS::m_view to m_contentView
https://bugs.webkit.org/show_bug.cgi?id=129124
Reviewed by Benjamin Poulain.
Simple rename of m_view to m_contentView in preparation for
also holding onto the WKView.
* UIProcess/API/ios/PageClientImplIOS.h:
* UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::createDrawingAreaProxy):
(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::isViewInWindow):
(WebKit::PageClientImpl::processDidExit):
(WebKit::PageClientImpl::didRelaunchProcess):
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::interpretKeyEvent):
(WebKit::PageClientImpl::positionInformationDidChange):
(WebKit::PageClientImpl::selectionDidChange):
(WebKit::PageClientImpl::screenToRootView):
(WebKit::PageClientImpl::rootViewToScreen):
(WebKit::PageClientImpl::setAcceleratedCompositingRootLayer):
(WebKit::PageClientImpl::takeViewSnapshot):
(WebKit::PageClientImpl::didGetTapHighlightGeometries):
(WebKit::PageClientImpl::didCommitLayerTree):
(WebKit::PageClientImpl::startAssistingNode):
(WebKit::PageClientImpl::stopAssistingNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Feb 2014 19:43:19 +0000 (19:43 +0000)]
REGRESSION(r164438): [GTK] Tests /webkit2/WebKitWebView/tls-errors-policy and /webkit2/WebKitWebContext/uri-scheme fail
https://bugs.webkit.org/show_bug.cgi?id=129252
Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-02-24
Reviewed by Carlos Garcia Campos.
* UIProcess/API/gtk/WebKitPrivate.cpp: Manage error values generated by the user application and not present in WebCore
(toWebKitError):
(toWebCoreError):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Feb 2014 19:23:08 +0000 (19:23 +0000)]
REGRESSION(r164438): [GTK] Tests /WebKitGtk/testcontextmenu, /WebKitGtk/testmimehandling, /WebKitGtk/testloading assert in Debug build
https://bugs.webkit.org/show_bug.cgi?id=129256
Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-02-24
Reviewed by Carlos Garcia Campos.
* WebCoreSupport/FrameLoaderClientGtk.cpp: Manage error values not present in WebCore
(WebKit::toWebKitNetworkError):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 24 Feb 2014 19:13:16 +0000 (19:13 +0000)]
iOS build fix after r164577.
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::selectedChildAtIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Feb 2014 19:05:21 +0000 (19:05 +0000)]
Get rid of the unused 'immediate' parameters from repaint related functions
https://bugs.webkit.org/show_bug.cgi?id=129111
Patch by Renata Hodovan <rhodovan.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Simon Fraser.
Removing the 'immediate' parameters from repaint related functions - accoring
to the FIXME in RenderView::repaintViewRectangle() - since they have no effect.
Source/WebCore:
No new tests are necessary because there is no behavior change
* dom/Element.cpp:
(WebCore::Element::setActive):
* loader/EmptyClients.h:
* page/Chrome.cpp:
(WebCore::Chrome::invalidateRootView):
(WebCore::Chrome::invalidateContentsAndRootView):
(WebCore::Chrome::invalidateContentsForSlowScroll):
* page/Chrome.h:
* page/ChromeClient.h:
* page/Frame.cpp:
(WebCore::Frame::tiledBackingStorePaintEnd):
* page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::shouldUpdate):
* page/FrameView.h:
* platform/HostWindow.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::scrollContentsSlowPath):
(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::updateOverhangAreas):
(WebCore::ScrollView::addPanScrollIcon):
(WebCore::ScrollView::removePanScrollIcon):
(WebCore::ScrollView::platformRepaintContentRectangle):
* platform/ScrollView.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintLayerRectsForImage):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
* rendering/RenderLayer.h:
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
* rendering/RenderMultiColumnSet.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintSlowRepaintObject):
* rendering/RenderObject.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::repaintFlowThreadContent):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::flushAccumulatedRepaintRegion):
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
* rendering/RenderView.h:
* svg/graphics/SVGImageChromeClient.h:
Source/WebKit/efl:
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::invalidateContents):
(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore::ChromeClientEfl::invalidateContentsAndRootView):
(WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):
* WebCoreSupport/ChromeClientEfl.h:
Source/WebKit/gtk:
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::invalidateRootView):
(WebKit::ChromeClient::invalidateContentsAndRootView):
(WebKit::ChromeClient::invalidateContentsForSlowScroll):
* WebCoreSupport/ChromeClientGtk.h:
Source/WebKit/win:
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):
(WebChromeClient::invalidateContentsForSlowScroll):
* WebCoreSupport/WebChromeClient.h:
Source/WebKit/wince:
* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::invalidateRootView):
(WebKit::ChromeClientWinCE::invalidateContentsAndRootView):
(WebKit::ChromeClientWinCE::invalidateContentsForSlowScroll):
(WebKit::ChromeClientWinCE::scroll):
* WebCoreSupport/ChromeClientWinCE.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 24 Feb 2014 18:49:01 +0000 (18:49 +0000)]
<rdar://problem/
16059894> Update AppleConnect sandbox profile for XPC process names.
Patch by Ivan KrstiÄ
\87, reviewed and landed by me.
* Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Mon, 24 Feb 2014 18:34:51 +0000 (18:34 +0000)]
Transform more clip-path pixel tests to reference tests
https://bugs.webkit.org/show_bug.cgi?id=129230
Reviewed by Andreas Kling.
* svg/clip-path/clip-path-content-use-007-expected.svg: Added.
* svg/clip-path/clip-path-content-use-007.svg: Added.
* svg/clip-path/clip-path-css-transform-003-expected.svg: Added.
* svg/clip-path/clip-path-css-transform-003.svg: Added.
* svg/clip-path/clip-path-css-transform-004-expected.svg: Added.
* svg/clip-path/clip-path-css-transform-004.svg: Added.
* svg/clip-path/clip-path-document-change-assert-expected.txt: Renamed from LayoutTests/svg/custom/clip-path-document-change-assert-expected.txt.
* svg/clip-path/clip-path-document-change-assert.html: Renamed from LayoutTests/svg/custom/clip-path-document-change-assert.html.
* svg/clip-path/clip-path-dom-child-changes-expected.svg: Added.
* svg/clip-path/clip-path-dom-child-changes.svg: Added.
* svg/clip-path/clip-path-dom-clippathunits-expected.svg: Added.
* svg/clip-path/clip-path-dom-clippathunits.svg: Added.
* svg/clip-path/clip-path-dom-href-expected.svg: Added.
* svg/clip-path/clip-path-dom-href.svg: Added.
* svg/clip-path/clip-path-dom-id-expected.svg: Added.
* svg/clip-path/clip-path-dom-id.svg: Added.
* svg/clip-path/clip-path-negative-scale-expected.svg: Added.
* svg/clip-path/clip-path-negative-scale.svg: Added.
* svg/clip-path/clip-path-no-content-004-expected.svg: Added.
* svg/clip-path/clip-path-no-content-004.svg: Added.
* svg/clip-path/clip-path-on-marker-001-expected.svg: Added.
* svg/clip-path/clip-path-on-marker-001.svg: Added.
* svg/clip-path/clip-path-on-marker-002-expected.svg: Added.
* svg/clip-path/clip-path-on-marker-002.svg: Added.
* svg/clip-path/clip-path-on-marker-003-expected.svg: Added.
* svg/clip-path/clip-path-on-marker-003.svg: Added.
* svg/clip-path/clip-path-recursion-001-expected.svg: Renamed from LayoutTests/svg/custom/circular-clip-path-references-crash-expected.svg.
* svg/clip-path/clip-path-recursion-001.svg: Renamed from LayoutTests/svg/custom/circular-clip-path-references-crash.svg.
* svg/clip-path/clip-path-recursion-002-expected.svg: Added.
* svg/clip-path/clip-path-recursion-002.svg: Added.
* svg/clip-path/clip-path-shape-stroke-expected.svg:
* svg/clip-path/clip-path-with-transform-expected.svg: Added.
* svg/clip-path/clip-path-with-transform.svg: Added.
* svg/clip-path/mask-nested-clip-path-010-expected.svg: Renamed from LayoutTests/svg/custom/clamped-masking-clipping-expected.svg.
* svg/clip-path/mask-nested-clip-path-010.svg: Renamed from LayoutTests/svg/custom/clamped-masking-clipping.svg.
* svg/custom/clip-mask-negative-scale-expected.txt: Removed.
* svg/custom/clip-mask-negative-scale.svg: Removed.
* svg/custom/clip-path-child-changes-expected.txt: Removed.
* svg/custom/clip-path-child-changes.svg: Removed.
* svg/custom/clip-path-href-changes-expected.txt: Removed.
* svg/custom/clip-path-href-changes.svg: Removed.
* svg/custom/clip-path-id-changes-expected.txt: Removed.
* svg/custom/clip-path-id-changes.svg: Removed.
* svg/custom/clip-path-referencing-use.svg: Removed.
* svg/custom/clip-path-referencing-use2.svg: Removed.
* svg/custom/clip-path-units-changes-expected.txt: Removed.
* svg/custom/clip-path-units-changes.svg: Removed.
* svg/custom/clip-path-with-css-transform-1-expected.txt: Removed.
* svg/custom/clip-path-with-css-transform-1.svg: Removed.
* svg/custom/clip-path-with-css-transform-2-expected.txt: Removed.
* svg/custom/clip-path-with-css-transform-2.svg: Removed.
* svg/custom/clip-path-with-transform-expected.txt: Removed.
* svg/custom/clip-path-with-transform.svg: Removed.
* svg/custom/empty-clip-path.svg: Removed.
* svg/custom/recursive-clippath.svg: Removed.
* svg/masking/mask-negative-scale.svg: Added.
* svg/masking/mast-negative-scale-expected.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Mon, 24 Feb 2014 18:32:52 +0000 (18:32 +0000)]
Transform more clip-path pixel tests to reference tests
https://bugs.webkit.org/show_bug.cgi?id=129230
Reviewed by Andreas Kling.
Remove unnecessary pixel test results.
* platform/efl/svg/custom/clip-mask-negative-scale-expected.png: Removed.
* platform/gtk/svg/custom/clip-mask-negative-scale-expected.png: Removed.
* platform/gtk/svg/custom/clip-mask-negative-scale-expected.txt: Removed.
* platform/gtk/svg/custom/clip-path-child-changes-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-href-changes-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-id-changes-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-referencing-use-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-referencing-use-expected.txt: Removed.
* platform/gtk/svg/custom/clip-path-referencing-use2-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-referencing-use2-expected.txt: Removed.
* platform/gtk/svg/custom/clip-path-units-changes-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-with-css-transform-1-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-with-css-transform-2-expected.png: Removed.
* platform/gtk/svg/custom/clip-path-with-transform-expected.png: Removed.
* platform/gtk/svg/custom/empty-clip-path-expected.png: Removed.
* platform/gtk/svg/custom/empty-clip-path-expected.txt: Removed.
* platform/gtk/svg/custom/recursive-clippath-expected.png: Removed.
* platform/gtk/svg/custom/recursive-clippath-expected.txt: Removed.
* platform/mac/svg/custom/clip-mask-negative-scale-expected.png: Removed.
* platform/mac/svg/custom/clip-path-child-changes-expected.png: Removed.
* platform/mac/svg/custom/clip-path-display-none-child-expected.png: Removed.
* platform/mac/svg/custom/clip-path-display-none-child-expected.txt: Removed.
* platform/mac/svg/custom/clip-path-href-changes-expected.png: Removed.
* platform/mac/svg/custom/clip-path-id-changes-expected.png: Removed.
* platform/mac/svg/custom/clip-path-referencing-use-expected.png: Removed.
* platform/mac/svg/custom/clip-path-referencing-use-expected.txt: Removed.
* platform/mac/svg/custom/clip-path-referencing-use2-expected.png: Removed.
* platform/mac/svg/custom/clip-path-referencing-use2-expected.txt: Removed.
* platform/mac/svg/custom/clip-path-units-changes-expected.png: Removed.
* platform/mac/svg/custom/clip-path-with-css-transform-1-expected.png: Removed.
* platform/mac/svg/custom/clip-path-with-css-transform-2-expected.png: Removed.
* platform/mac/svg/custom/clip-path-with-transform-expected.png: Removed.
* platform/mac/svg/custom/empty-clip-path-expected.png: Removed.
* platform/mac/svg/custom/empty-clip-path-expected.txt: Removed.
* platform/mac/svg/custom/recursive-clippath-expected.png: Removed.
* platform/mac/svg/custom/recursive-clippath-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Mon, 24 Feb 2014 18:15:47 +0000 (18:15 +0000)]
Turn GenGC on for 32-bit systems
https://bugs.webkit.org/show_bug.cgi?id=128824
Reviewed by Geoffrey Garen.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Mon, 24 Feb 2014 17:07:22 +0000 (17:07 +0000)]
[ASan] Remove methods from ignore list that no longer cause crashes
<http://webkit.org/b/129257>
Reviewed by Anders Carlsson.
* asan/webkit-asan-ignore.txt: Remove old methods.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Feb 2014 17:05:33 +0000 (17:05 +0000)]
Web Inspector: Remove single quote characters from Web Inspector JavaScript files
https://bugs.webkit.org/show_bug.cgi?id=129253
Patch by Diego Pino Garcia <dpino@igalia.com> on 2014-02-24
Reviewed by Timothy Hatcher.
* UserInterface/Base/Main.js:
(WebInspector.openURL):
* UserInterface/Views/CookieStorageContentView.js:
(WebInspector.cookieDomainMatchesResourceDomain):
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
(WebInspector.DOMTreeElement.prototype._startEditingTagName.editingComitted):
(WebInspector.DOMTreeElement.prototype._startEditingTagName.editingCancelled):
(WebInspector.DOMTreeElement.prototype._startEditingTagName):
* UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype._ondragover):
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.addPlaceholderNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Feb 2014 15:52:42 +0000 (15:52 +0000)]
Code cleanup: remove leftover ENABLE(WORKERS) macros and support.
https://bugs.webkit.org/show_bug.cgi?id=129255
Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Csaba Osztrogonác.
Source/JavaScriptCore:
ENABLE_WORKERS macro was removed in r159679.
Support is now also removed from xcconfig files.
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
ENABLE_WORKERS macro was removed in r159679, but r161589 added back some occurrences.
Support is now also removed from xcconfig files.
No new tests needed.
* Configurations/FeatureDefines.xcconfig:
* platform/ThreadGlobalData.cpp:
* platform/ThreadGlobalData.h:
* platform/Timer.h:
(WebCore::TimerBase::isActive):
* platform/ios/wak/WebCoreThread.mm:
(RunWebThread):
(StartWebThread):
Source/WebKit/mac:
ENABLE_WORKERS macro was removed in r159679.
Support is now also removed from xcconfig files.
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
ENABLE_WORKERS macro was removed in r159679.
Support is now also removed from xcconfig files.
* Configurations/FeatureDefines.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Feb 2014 15:47:16 +0000 (15:47 +0000)]
[CMake] Get rid of "FIXME: The Blackberry port ..." from WebCore/CmakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=129152
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Gyuyoung Kim.
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Feb 2014 15:45:27 +0000 (15:45 +0000)]
Extract common parts from jhbuildrc files.
https://bugs.webkit.org/show_bug.cgi?id=125986
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Csaba Osztrogonác.
Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
* Scripts/run-gtk-tests:
(TestRunner._setup_testing_environment):
* efl/common.py: Removed.
* efl/jhbuildrc:
* gtk/check-gdom-symbols:
* gtk/common.py:
(binary_build_path):
(get_build_path):
* gtk/find-make-dist-errors:
(get_missing_headers):
* gtk/generate-gtkdoc:
(get_webkit2_options):
(get_webkit1_options.src_path):
(get_webkit1_options):
(get_webkitdom_options.src_path):
(get_webkitdom_options):
* gtk/generate-inspector-gresource-manifest.py:
* gtk/jhbuildrc:
* jhbuild/jhbuildrc_common.py: Added.
(script_path):
(top_level_path):
(init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Feb 2014 15:24:42 +0000 (15:24 +0000)]
[GTK] Wrong active context when destroying GL objects.
https://bugs.webkit.org/show_bug.cgi?id=129244
Patch by Iago Toral Quiroga <itoral@igalia.com> on 2014-02-24
Reviewed by Martin Robinson.
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::invalidate): make context current before destroying GL objects.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
berto@igalia.com [Mon, 24 Feb 2014 15:06:13 +0000 (15:06 +0000)]
Remove unused error.h header.
https://bugs.webkit.org/show_bug.cgi?id=126774
Patch by Koop Mast <kwm@FreeBSD.org> on 2014-02-24
Reviewed by Anders Carlsson.
This header doesn't exists on FreeBSD. According to
https://www.gnu.org/software/gnulib/manual/html_node/error_002eh.html
the function that this header implements are not present in the file.
So there isn't any need for this header.
* NetworkProcess/unix/NetworkProcessMainUnix.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rego@igalia.com [Mon, 24 Feb 2014 12:19:19 +0000 (12:19 +0000)]
Unreviewed. Fix code indentation and spacing.
Patch by Diego Pino Garcia <dpino@igalia.com> on 2014-02-24
* Scripts/webkitpy/style/checkers/js.py:
(SingleQuoteChecker.check):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Mon, 24 Feb 2014 11:24:34 +0000 (11:24 +0000)]
Remove redundant setting in FeatureDefines.xcconfig
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Mon, 24 Feb 2014 11:14:29 +0000 (11:14 +0000)]
ANGLE: Stop using unsafe strcpy method
<http://webkit.org/b/129237>
<rdar://problem/
11077580>
Reviewed by Dean Jackson.
* include/GLSLANG/ShaderLang.h:
- Drive-by fix for header documentation.
* src/compiler/translator/ShaderLang.cpp:
(ShGetInfoLog):
(ShGetObjectCode):
* src/libGLESv2/Program.cpp:
(gl::InfoLog::append):
- Switch to use strncpy(), and explicitly set NULL terminator at
the end of the buffer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Feb 2014 10:02:10 +0000 (10:02 +0000)]
[CSS Blending] An element having -webkit-mix-blend-mode should only blend with the contents of the parent stacking context
https://bugs.webkit.org/show_bug.cgi?id=129154
Patch by Mihai Tica <mitica@adobe.com> on 2014-02-24
Reviewed by Dean Jackson.
Source/WebCore:
The blending operation of an element having -webkit-mix-blend-mode should be restricted to the parent stacking context.
This change isolates blending, preventing it from blending with other underlying elements besides the parent stacking context.
Tests: css3/compositing/blend-mode-isolated-group-1.html
css3/compositing/blend-mode-isolated-group-2.html
css3/compositing/blend-mode-isolated-group-3.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer): Initialize added members to false.
(WebCore::RenderLayer::updateBlendMode): Check if a blend mode was set or unset. If so, set the m_updateParentStackingContextShouldIsolateBlendingDirty to true.
(WebCore::RenderLayer::updateParentStackingContextShouldIsolateBlending): Traverse to the parent stacking context and update the
m_isolatesBlending member accordingly.
* rendering/RenderLayer.h:
- Add isolatesBlending() as a condition for creating a transparency layer in the paintsWithTransparency method.
- Add m_updateParentStackingContextShouldIsolateBlendingDirty member.
- Add m_isolatesBlending member and getter.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Call updateParentStackingContextShouldIsolateBlending.
LayoutTests:
Test that isolation is performed for blending, in other words, an element having -webkit-mix-blend-mode is blending with the
contents of the parent stacking context, but not with any of the underlying content.
* css3/compositing/blend-mode-isolated-group-1.html: Added.
* css3/compositing/blend-mode-isolated-group-2.html: Added.
* css3/compositing/blend-mode-isolated-group-3.html: Added.
* platform/mac/css3/compositing/blend-mode-isolated-group-1-expected.png: Added.
* platform/mac/css3/compositing/blend-mode-isolated-group-1-expected.txt: Added.
* platform/mac/css3/compositing/blend-mode-isolated-group-2-expected.png: Added.
* platform/mac/css3/compositing/blend-mode-isolated-group-2-expected.txt: Added.
* platform/mac/css3/compositing/blend-mode-isolated-group-3-expected.png: Added.
* platform/mac/css3/compositing/blend-mode-isolated-group-3-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 24 Feb 2014 09:31:16 +0000 (09:31 +0000)]
[GTK] Remove unneeded method webkitWebViewBaseRequestExitFullScreen
https://bugs.webkit.org/show_bug.cgi?id=129245
Reviewed by Sergio Villar Senin.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseKeyPressEvent): Call FullscreenManager::requestExitFullScreen() directly.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
k.czech@samsung.com [Mon, 24 Feb 2014 09:31:12 +0000 (09:31 +0000)]
[ATK] Wrong selected element at a given index in a list box.
https://bugs.webkit.org/show_bug.cgi?id=129039
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/select-element-at-index.html
The selected element at a given index was wrong. One should be considered among the
all children of a list box, not only selected ones.
* accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:
(core):
(listObjectForSelection):
(optionFromList):
(optionFromSelection):
(webkitAccessibleSelectionRefSelection):
Tools:
Added missing implementation and proposed some new function for testing selection
in a list boxes.
* DumpRenderTree/AccessibilityUIElement.cpp:
(setSelectedChildAtIndexCallback):
(removeSelectionAtIndexCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::selectedChildAtIndex):
(AccessibilityUIElement::setSelectedChildAtIndex):
(AccessibilityUIElement::removeSelectionAtIndex):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::selectedChildAtIndex):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::setSelectedChildAtIndex):
(WTR::AccessibilityUIElement::removeSelectionAtIndex):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::setSelectedChildAtIndex):
(WTR::AccessibilityUIElement::removeSelectionAtIndex):
LayoutTests:
Proposed test that checks whether correct element at a given index is retrieved.
Also testing some other scenarios such as removing selection from rows, counting all
selected rows and setting selection.
* accessibility/select-element-at-index-expected.txt: Added.
* accessibility/select-element-at-index.html: Added.
* platform/mac/TestExpectations: Skipping test in Mac, missing implementation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 24 Feb 2014 05:29:33 +0000 (05:29 +0000)]
<rdar://problem/
16144508> [iOS] Some definitions of INSTALL_PATH don’t account for INSTALL_PATH_PREFIX
https://bugs.webkit.org/show_bug.cgi?id=129241
Reviewed by Mark Rowe.
* Configurations/Base.xcconfig: Define INSTALL_PATH here in terms of INSTALL_PATH_ACTUAL.
* Configurations/BaseLegacyProcess.xcconfig: Define only INSTALL_PATH_ACTUAL.
* Configurations/BaseTarget.xcconfig: Simplify the definition of
NORMAL_WEBKIT2_FRAMEWORKS_DIR, now that it shouldn’t include SDKROOT for the Simulator.
* Configurations/BaseXPCService.xcconfig: Define only INSTALL_PATH_ACTUAL.
* Configurations/WebKit2.xcconfig: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@apple.com [Mon, 24 Feb 2014 02:24:36 +0000 (02:24 +0000)]
[WinCairo] Unreviewed build fix after r164565.
* ANGLE.vcxproj/libEGL.vcxproj: Use correct path to files.
* ANGLE.vcxproj/libGLESv2.vcxproj: Ditto.
* ANGLE.vcxproj/libGLESv2.vcxproj.filters: Ditto.
* ANGLE.vcxproj/preprocessor.vcxproj: Ditto.
* ANGLE.vcxproj/translator_common.vcxproj: Ditto.
* ANGLE.vcxproj/translator_common.vcxproj.filters: Ditto.
* ANGLE.vcxproj/translator_glsl.vcxproj: Ditto.
* ANGLE.vcxproj/translator_glsl.vcxproj.filters: Ditto.
* ANGLE.vcxproj/translator_hlsl.vcxproj: Ditto.
* ANGLE.vcxproj/translator_hlsl.vcxproj.filters: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc