WebKit-https.git
11 years agoAdded Windows expected results to the test added in r94352.
mitz@apple.com [Thu, 1 Sep 2011 23:32:20 +0000 (23:32 +0000)]
Added Windows expected results to the test added in r94352.

* platform/win/fast/text/fallback-traits-fixup-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't include unnecessary headers in V8 bindings
paroga@webkit.org [Thu, 1 Sep 2011 23:29:06 +0000 (23:29 +0000)]
Don't include unnecessary headers in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=67435

Reviewed by Darin Adler.

When an IDL attribue is Conditonal the corresponding headers
need to be surrounded with the correct #if ENABLE().

* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Chromium, Skia] Add virtual to WebGraphicsContext3D to create a new GrGLInterface...
commit-queue@webkit.org [Thu, 1 Sep 2011 23:25:04 +0000 (23:25 +0000)]
[Chromium, Skia] Add virtual to WebGraphicsContext3D to create a new GrGLInterface per context. Insert per-skia-GL-function callback to set correct GL context.
https://bugs.webkit.org/show_bug.cgi?id=67395

Patch by Brian Salomon <bsalomon@google.com> on 2011-09-01
Reviewed by Kenneth Russell.

* WebKit.gyp:
* public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::grContext):
* src/WebGraphicsContext3D.cpp: Added.
(WebKit::WebGraphicsContext3D::createGrGLInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRename CFNETWORK_DATA_ARRAY_CALLBACK to NETWORK_CFDATA_ARRAY_CALLBACK
psolanki@apple.com [Thu, 1 Sep 2011 23:22:03 +0000 (23:22 +0000)]
Rename CFNETWORK_DATA_ARRAY_CALLBACK to NETWORK_CFDATA_ARRAY_CALLBACK
https://bugs.webkit.org/show_bug.cgi?id=67348

Reviewed by Alexey Proskuryakov.

* loader/ResourceLoader.h:
* loader/SubresourceLoader.h:
* loader/cf/SubresourceLoaderCF.cpp:
* loader/mac/ResourceLoaderMac.mm:
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::clear):
(WebCore::SharedBuffer::buffer):
* platform/SharedBuffer.h:
* platform/cf/SharedBufferCF.cpp:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
* platform/network/mac/ResourceHandleMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTypeError should be thrown when a constructor is called as a normal function.
commit-queue@webkit.org [Thu, 1 Sep 2011 23:06:49 +0000 (23:06 +0000)]
TypeError should be thrown when a constructor is called as a normal function.
https://bugs.webkit.org/show_bug.cgi?id=67381

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Darin Adler.

The spec is here: http://www.w3.org/TR/WebIDL/#es-interface-call
For example, "Image()" or "XMLHttpRequest()" should throw TypeError.

Source/WebCore:

Test: fast/dom/call-a-constructor-as-a-function.html

* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback): Throws TypeError if args.IsConstructCall() is false.
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray): Ditto.
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback): Ditto.
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallback): Ditto.
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
(WebCore::v8HTMLAudioElementConstructorCallback): Ditto.
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback): Ditto.
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
(WebCore::v8HTMLOptionElementConstructorCallback): Ditto.
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback): Ditto.
* bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::V8SharedWorker::constructorCallback): Ditto.
* bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
(WebCore::V8WebKitCSSMatrix::constructorCallback): Ditto.
* bindings/v8/custom/V8WebKitPointConstructor.cpp:
(WebCore::V8WebKitPoint::constructorCallback): Ditto.
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback): Ditto.
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::constructorCallback): Ditto.

LayoutTests:

* fast/dom/call-a-constructor-as-a-function-expected.txt: Added. The test result for JSC.
* fast/dom/call-a-constructor-as-a-function.html: Added. Checks if TypeError is thrown.
* platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt: Added. The test result for V8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] TextureManager overestimates the size of non-RGBA texture formats
enne@google.com [Thu, 1 Sep 2011 23:03:58 +0000 (23:03 +0000)]
[chromium] TextureManager overestimates the size of non-RGBA texture formats
https://bugs.webkit.org/show_bug.cgi?id=66917

Reviewed by James Robinson.

Use GraphicsContext3D to determine the size of a given texture format.
Also, make TextureManager use more GraphicsContext3D types.

* platform/graphics/GraphicsContext3D.h:
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::memoryUseBytes):
* platform/graphics/chromium/TextureManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd missing Event constructors to DOMWindow.idl
weinig@apple.com [Thu, 1 Sep 2011 22:48:46 +0000 (22:48 +0000)]
Add missing Event constructors to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=67449

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by existing tests.

* page/DOMWindow.idl:

LayoutTests:

* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:
Update results for new constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoConsider Conditional attribute in CodeGenerator for methods
paroga@webkit.org [Thu, 1 Sep 2011 22:42:20 +0000 (22:42 +0000)]
Consider Conditional attribute in CodeGenerator for methods
https://bugs.webkit.org/show_bug.cgi?id=67409

Reviewed by Darin Adler.

This change adds appropriate #if ENABLE() lines for the preprocessor around the
generated functions depending on the Conditional attribute in the IDL file.

* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Introduce CCSingleThreadProxy in order to move LayerRenderer to CCLayerTre...
nduca@chromium.org [Thu, 1 Sep 2011 22:40:08 +0000 (22:40 +0000)]
[chromium] Introduce CCSingleThreadProxy in order to move LayerRenderer to CCLayerTreeHostImpl
https://bugs.webkit.org/show_bug.cgi?id=66807

Reviewed by James Robinson.

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setLayerRendererRecursive):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::close):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::isContextLost):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::capabilities):
(WebCore::LayerRendererChromium::rootLayerImpl):
(WebCore::LayerRendererChromium::contextSupportsMapSub):
(WebCore::LayerRendererChromium::viewportSize):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::reserveTextures):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::animateAndLayout):
(WebCore::CCLayerTreeHost::preCommit):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::createCompositorThread):
(WebCore::CCLayerTreeHost::createLayerTreeHostContext3D):
(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::scheduleComposite):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::layerRendererCapabilities):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::skiaContext):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::loseCompositorContext):
(WebCore::CCLayerTreeHost::contentsTextureManager):
(WebCore::CCLayerTreeHost::composite):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
* platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::create):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::context):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::finishAllRendering):
(WebCore::CCLayerTreeHostImpl::isContextLost):
(WebCore::CCLayerTreeHostImpl::layerRendererCapabilities):
(WebCore::CCLayerTreeHostImpl::present):
(WebCore::CCLayerTreeHostImpl::readback):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::updateLayers):
(WebCore::CCLayerTreeHostImpl::setViewport):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::layerRenderer):
(WebCore::CCLayerTreeHostImpl::rootLayer):
(WebCore::CCLayerTreeHostImpl::viewportSize):
* platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Removed.
* platform/graphics/chromium/cc/CCMainThreadTask.h:
(WebCore::MainThreadTask4::create):
(WebCore::MainThreadTask4::MainThreadTask4):
(WebCore::MainThreadTask4::performTask):
(WebCore::MainThreadTask5::create):
(WebCore::MainThreadTask5::MainThreadTask5):
(WebCore::MainThreadTask5::performTask):
(WebCore::createMainThreadTask):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCProxy.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp.
(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setImplThread):
* platform/graphics/chromium/cc/CCProxy.h: Added.
(WebCore::CCProxy::~CCProxy):
(WebCore::CCProxy::CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: Added.
(WebCore::ScopedSetImplThread::ScopedSetImplThread):
(WebCore::ScopedSetImplThread::~ScopedSetImplThread):
(WebCore::CCSingleThreadProxy::create):
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::start):
(WebCore::CCSingleThreadProxy::~CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::isStarted):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::layerRendererCapabilities):
(WebCore::CCSingleThreadProxy::loseCompositorContext):
(WebCore::CCSingleThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::skiaContext):
(WebCore::CCSingleThreadProxy::contentsTextureManager):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::compositeIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h.
* platform/graphics/chromium/cc/CCThreadProxy.cpp: Added.
(WebCore::CCThreadProxy::create):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::layerRendererCapabilities):
(WebCore::CCThreadProxy::loseCompositorContext):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::skiaContext):
(WebCore::CCThreadProxy::contentsTextureManager):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
(WebCore::CCThreadProxy::initializeImplOnCCThread):
(WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h.
* platform/graphics/chromium/cc/CCThreadTask.h:
(WebCore::CCThreadTask5::create):
(WebCore::CCThreadTask5::CCThreadTask5):
(WebCore::CCThreadTask5::performTask):
(WebCore::createCCThreadTask):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
* tests/CCThreadTaskTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/9528843> STIX glyphs not rendered on this stackoverflow answer
mitz@apple.com [Thu, 1 Sep 2011 22:32:43 +0000 (22:32 +0000)]
<rdar://problem/9528843> STIX glyphs not rendered on this stackoverflow answer
https://bugs.webkit.org/show_bug.cgi?id=67444

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/text/fallback-traits-fixup.html

After obtaining STIX Regular as a fallback font for some characters, getFontDataForCharacters()
proceeded to ask for a font from the same family having the desired traits and weight (because
wkGetFontInLanguageForRange() does not preserve traits and weight). The returned font was different
and happened to not contain the desired character.

* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters): Only ask for a family member with the desired
traits and weight if the substitute font does not already have them, and only use the returned
member if it actually contains the desired character.

LayoutTests:

* fast/text/fallback-traits-fixup.html: Added.
* platform/mac/fast/text/fallback-traits-fixup-expected.png: Added.
* platform/mac/fast/text/fallback-traits-fixup-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Update more SVG baselines
jamesr@google.com [Thu, 1 Sep 2011 22:27:53 +0000 (22:27 +0000)]
[chromium] Update more SVG baselines

* platform/chromium-cg-mac/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-cg-mac/svg/custom/pattern-skew-transformed-expected.png:
* platform/chromium-cg-mac/svg/custom/pattern-with-transformation-expected.png:
* platform/mac/svg/custom/non-scaling-stroke-expected.txt: Removed.
* platform/mac/svg/custom/pattern-skew-transformed-expected.txt: Removed.
* platform/qt/svg/custom/non-scaling-stroke-expected.txt: Removed.
* platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Removed.
* svg/custom/non-scaling-stroke-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/non-scaling-stroke-expected.txt.
* svg/custom/pattern-skew-transformed-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/pattern-skew-transformed-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoGenerate an XSLTProcessor constructor of V8 using the IDL 'Constructor' extended...
commit-queue@webkit.org [Thu, 1 Sep 2011 22:16:23 +0000 (22:16 +0000)]
Generate an XSLTProcessor constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67414

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/dom/Window/custom-constructors.html
      fast/xsl/default-html.html

* bindings/v8/custom/V8XSLTProcessorCustom.cpp: Removed constructorCallback().
* xml/XSLTProcessor.idl: Added the 'Constructor' extended attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Mark test that renders differently in 32 vs 64 bit mode as failing (WTF?)
jamesr@google.com [Thu, 1 Sep 2011 22:02:42 +0000 (22:02 +0000)]
[chromium] Mark test that renders differently in 32 vs 64 bit mode as failing (WTF?)

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Update chromium baselines for 94338 for windows/mac
jamesr@google.com [Thu, 1 Sep 2011 21:40:59 +0000 (21:40 +0000)]
[chromium] Update chromium baselines for 94338 for windows/mac

* platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
* platform/chromium-cg-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
* platform/chromium-cg-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdding control rendering at various sizes.
jonlee@apple.com [Thu, 1 Sep 2011 21:30:42 +0000 (21:30 +0000)]
Adding control rendering at various sizes.

* projects/forms/survey.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Update chromium baselines for 94338
jamesr@google.com [Thu, 1 Sep 2011 21:30:23 +0000 (21:30 +0000)]
[chromium] Update chromium baselines for 94338

* platform/chromium-linux/svg/custom/pattern-rotate-expected.png:
* platform/chromium-win/svg/custom/pattern-rotate-expected.png:
* platform/chromium/test_expectations.txt:
* platform/qt/svg/custom/pattern-rotate-expected.txt: Removed.
* svg/custom/pattern-rotate-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/pattern-rotate-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
eric@webkit.org [Thu, 1 Sep 2011 21:29:51 +0000 (21:29 +0000)]
REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
https://bugs.webkit.org/show_bug.cgi?id=66228

Reviewed by Dirk Pranke.

ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
The LeaksViewer tool globs for all *-leaks.txt files.
This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.

In order to test this I had to fix a limitation in our MockFileSystem.glob
method.  However, doing so uncovered a typo and bug in the integration tests.
I've disabled the offending integration tests.

* Scripts/webkitpy/common/system/filesystem_mock.py:
* Scripts/webkitpy/layout_tests/port/leakdetector.py:
* Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoHTMLMediaElement should use fastHasAttribute instead of hasAttribute
eric.carlson@apple.com [Thu, 1 Sep 2011 21:22:24 +0000 (21:22 +0000)]
HTMLMediaElement should use fastHasAttribute instead of hasAttribute
https://bugs.webkit.org/show_bug.cgi?id=67421

Reviewed by Simon Fraser.

Use fastHasAttribute instead of hasAttribute because it is faster, and HTMLMediaElement
doesn't ever need to check style or SVG animated attributes.

No new tests required, this is just an optimization.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectMediaResource): hasAttribute -> fastHasAttribute.
(WebCore::HTMLMediaElement::loadResource): Ditto.
(WebCore::HTMLMediaElement::autoplay): Ditto.
(WebCore::HTMLMediaElement::loop): Ditto.
(WebCore::HTMLMediaElement::controls): Ditto.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::sourceWasAdded): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSource/WebCore: Add API functions to enable starting and stopping speech input,
commit-queue@webkit.org [Thu, 1 Sep 2011 21:14:56 +0000 (21:14 +0000)]
Source/WebCore: Add API functions to enable starting and stopping speech input,
and checking the current speech input state.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/speech/input-text-speechstart.html

* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
(WebCore::InputFieldSpeechButtonElement::stopSpeechInput):
* html/shadow/TextControlInnerElements.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::speechButtonElement):
* rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium: Add API functions to enable starting and stopping speech input,
and checking the current speech input state.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

* public/WebInputElement.h:
* src/AssertMatchingEnums.cpp:
* src/WebInputElement.cpp:
(WebKit::WebInputElement::isSpeechInputEnabled):
(WebKit::WebInputElement::getSpeechInputState):
(WebKit::WebInputElement::startSpeechInput):
(WebKit::WebInputElement::stopSpeechInput):

Tools: Adds a LayoutTestController method to make it possible to test
starting speech input via an API call.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::startSpeechInput):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::startSpeechInput):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::startSpeechInput):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::startSpeechInput):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::startSpeechInput):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::startSpeechInput):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::startSpeechInput):

LayoutTests: Adds a new test that checks triggering speech input via an API call.
https://bugs.webkit.org/show_bug.cgi?id=60170

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

* fast/speech/input-text-speechtrigger-expected.txt: Added.
* fast/speech/input-text-speechtrigger.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoQNX GCC distribution doesn't support vasprintf()
dbates@webkit.org [Thu, 1 Sep 2011 21:06:26 +0000 (21:06 +0000)]
QNX GCC distribution doesn't support vasprintf()
https://bugs.webkit.org/show_bug.cgi?id=67423

Reviewed by Antonio Gomes.

* wtf/Platform.h: Don't enable HAVE_VASPRINTF when building with GCC on QNX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed; new baselines (Skia on Mac, next chunk of files)
caryclark@google.com [Thu, 1 Sep 2011 20:46:32 +0000 (20:46 +0000)]
Unreviewed; new baselines (Skia on Mac, next chunk of files)
Some images incorrectly created with LCD text replaced with gray-scale.
Updated newer tests with reference images.
Deleted images with correct fallbacks.

* platform/chromium-mac/http/tests/navigation/error404-basic-expected.png: Removed.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoGather memory cache statistics in WebProcess::getWebCoreStatistics().
adachan@apple.com [Thu, 1 Sep 2011 20:39:46 +0000 (20:39 +0000)]
Gather memory cache statistics in WebProcess::getWebCoreStatistics().
https://bugs.webkit.org/show_bug.cgi?id=67160

Reviewed by Darin Adler.

Encode and decode webCoreCacheStatistics data member in StatisticsData.
* Shared/StatisticsData.cpp:
(WebKit::StatisticsData::encode):
(WebKit::StatisticsData::decode):
* Shared/StatisticsData.h:

Convert the cache statistics data into an ImmutableArray and return it in WebContext::didGetWebCoreStatistics().
* UIProcess/WebContext.cpp:
(WebKit::WebContext::didGetWebCoreStatistics):

Store memory cache statistics into the StatisticsData object.
* WebProcess/WebProcess.cpp:
(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::getWebCoreStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Land chromium baselines for fast/css/focus-ring-multiline-writingmode...
jamesr@google.com [Thu, 1 Sep 2011 20:38:22 +0000 (20:38 +0000)]
[chromium] Land chromium baselines for fast/css/focus-ring-multiline-writingmode-vertical.html

* platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
* platform/chromium-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/chromium-win/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/chromium-win/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION: Rendering artifacts on a rotated, pattern filled SVG shape
timothy_horton@apple.com [Thu, 1 Sep 2011 20:27:29 +0000 (20:27 +0000)]
REGRESSION: Rendering artifacts on a rotated, pattern filled SVG shape
https://bugs.webkit.org/show_bug.cgi?id=53055
<rdar://problem/8910917>

Reviewed by Simon Fraser.

Make use of wkCGPatternCreateWithImageAndTransform
when tiling patterns in both directions. This helps to avoid
pixel-cracking along pattern tiling boundaries.

Ignore 2D rotation when computing the size of a pattern's tile image,
as it artificially inflates the size of the tile, which can cause
pixel-cracking.

Test: svg/custom/pattern-rotate-gaps.svg

* platform/graphics/cg/PatternCG.cpp:
(WebCore::Pattern::createPlatformPattern):
* rendering/svg/RenderSVGResourcePattern.cpp:
* rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::roundedImageBufferSize):
* rendering/svg/SVGImageBufferTools.h:

Add a test that makes pixel cracking in transformed SVG patterns quite blatant,
and rebaseline some other tests affected by the change.

* platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/mac/svg/custom/pattern-rotate-expected.png:
* platform/mac/svg/custom/pattern-rotate-gaps-expected.png: Added.
* platform/mac/svg/custom/pattern-rotate-gaps-expected.txt: Added.
* platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* svg/custom/pattern-rotate-gaps.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Update expectations and baselines
jamesr@google.com [Thu, 1 Sep 2011 20:09:39 +0000 (20:09 +0000)]
[chromium] Update expectations and baselines

* platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove simple usage of UString::characters() from JavaScriptCore
msaboff@apple.com [Thu, 1 Sep 2011 20:04:34 +0000 (20:04 +0000)]
Remove simple usage of UString::characters() from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=67340

In preparation to allowing StringImpl to be backed by 8 bit
characters when appropriate, we need to eliminate or change the
usage of StringImpl::characters().  Most of the changes below
change s->characters()[0] to s[0].

Reviewed by Geoffrey Garen.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::keyForCharacterSwitch):
* bytecompiler/NodesCodegen.cpp:
(JSC::processClauseList):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Identifier.cpp:
(JSC::Identifier::addSlowCase):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::jsToNumber):
(JSC::parseFloat):
* runtime/JSString.cpp:
(JSC::JSString::substringFromRope):
* runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString):
* runtime/RegExp.cpp:
(JSC::regExpFlags):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::operator[]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix TestWebKitAPI build on clang-2.0
timothy_horton@apple.com [Thu, 1 Sep 2011 19:56:45 +0000 (19:56 +0000)]
Fix TestWebKitAPI build on clang-2.0

* TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, rolling out r94284.
paroga@webkit.org [Thu, 1 Sep 2011 19:51:52 +0000 (19:51 +0000)]
Unreviewed, rolling out r94284.
http://trac.webkit.org/changeset/94284
https://bugs.webkit.org/show_bug.cgi?id=65050

Broke building without SVG enabled on Chromium.

* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (r93247): 2 http/tests/misc tests failing on SnowLeopard Intel Release...
ap@apple.com [Thu, 1 Sep 2011 19:50:22 +0000 (19:50 +0000)]
REGRESSION (r93247): 2 http/tests/misc tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=67374

Reviewed by Simon Fraser.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::applyBasicAuthorizationHeader):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::applyBasicAuthorizationHeader):
Some versions of CFNetwork carry along an Authorization header, some don't. We shouldn't
repeat its value twice, this is not one of those headers that allow comma separated lists
of values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Move ImageBuffer::platformLayer()
noel.gordon@gmail.com [Thu, 1 Sep 2011 19:40:17 +0000 (19:40 +0000)]
[chromium] Move ImageBuffer::platformLayer()
https://bugs.webkit.org/show_bug.cgi?id=67372

Reviewed by Kenneth Russell.

No new tests: refactoring only, covered by existting tests.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::platformLayer):  Move it away from the toDataURL code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFocus ring is rendered incorrectly for a block with -webkit-writing-mode
commit-queue@webkit.org [Thu, 1 Sep 2011 19:38:53 +0000 (19:38 +0000)]
Focus ring is rendered incorrectly for a block with -webkit-writing-mode
https://bugs.webkit.org/show_bug.cgi?id=62915

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-09-01
Reviewed by Simon Fraser.

Source/WebCore:

RenderBlock::addFocusRingRects() should consider physical box position and
dimension instead of logical values for focus ring rects calculation.

Test: fast/css/focus-ring-multiline-writingmode-vertical.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRects):

LayoutTests:

* fast/css/focus-ring-multiline-writingmode-vertical.html: Added.
* platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Unreviewed, GTK build fix after r94299.
philn@webkit.org [Thu, 1 Sep 2011 19:33:04 +0000 (19:33 +0000)]
    Unreviewed, GTK build fix after r94299.

        * GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Chromium/Skia] Use GraphicsContext3D::grContext() to create GrContext for accelerate...
commit-queue@webkit.org [Thu, 1 Sep 2011 19:28:50 +0000 (19:28 +0000)]
[Chromium/Skia] Use GraphicsContext3D::grContext() to create GrContext for accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=67419

Patch by Brian Salomon <bsalomon@google.com> on 2011-09-01
Reviewed by James Robinson.

Accelerated drawing is not enabled in layout tests. However, once it is this change will be tested by every test.

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::contextSupportsAcceleratedPainting):
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRename GraphicsContext3DInternal to GraphicsContext3DPrivate and add a dummy version...
commit-queue@webkit.org [Thu, 1 Sep 2011 19:27:03 +0000 (19:27 +0000)]
Rename GraphicsContext3DInternal to GraphicsContext3DPrivate and add a dummy version of this class for Mac
https://bugs.webkit.org/show_bug.cgi?id=67172

Build fix, completing rename for GTK file.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2011-09-01
Reviewed by Chris Marrin.

* platform/graphics/gtk/GraphicsContext3DPrivate.cpp: Renamed from Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp.
(sharedDisplay):
(WebCore::activeGraphicsContexts):
(WebCore::GraphicsContext3DPrivate::addActiveGraphicsContext):
(WebCore::GraphicsContext3DPrivate::removeActiveGraphicsContext):
(WebCore::GraphicsContext3DPrivate::cleanupActiveContextsAtExit):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::createPbufferContext):
(WebCore::GraphicsContext3DPrivate::createPixmapContext):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agor93794 results in ruby tests causing assertion failure in RenderBlock.cpp
simon.fraser@apple.com [Thu, 1 Sep 2011 19:12:01 +0000 (19:12 +0000)]
r93794 results in ruby tests causing assertion failure in RenderBlock.cpp
https://bugs.webkit.org/show_bug.cgi?id=67007

Reviewed by Beth Dakin.

Disable these asserting ruby tests until the underlying issue can be fixed.

* fast/ruby/after-block-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/after-block-doesnt-crash.html.
* fast/ruby/after-table-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/after-table-doesnt-crash.html.
* fast/ruby/generated-after-counter-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/generated-after-counter-doesnt-crash.html.
* fast/ruby/generated-before-and-after-counter-doesnt-crash.html-disabled: Renamed from LayoutTests/fast/ruby/generated-before-and-after-counter-doesnt-crash.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Update baselines for vertical-text-glyph-test.html
jamesr@google.com [Thu, 1 Sep 2011 19:01:16 +0000 (19:01 +0000)]
[chromium] Update baselines for vertical-text-glyph-test.html

* platform/chromium-cg-mac/fast/text/international/vertical-text-glyph-test-expected.png: Added.
* platform/chromium-cg-mac/fast/text/international/vertical-text-glyph-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove unused "extension" parameter from rebaseline gardeningserver handler
jamesr@google.com [Thu, 1 Sep 2011 18:57:09 +0000 (18:57 +0000)]
Remove unused "extension" parameter from rebaseline gardeningserver handler
https://bugs.webkit.org/show_bug.cgi?id=67384

Patch by Adam Barth <abarth@webkit.org> on 2011-09-01
Reviewed by James Robinson.

This parameter hasn't done anything in a while.

* Scripts/webkitpy/tool/commands/rebaseline.py:
* Scripts/webkitpy/tool/servers/gardeningserver.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (r94259): Two tests doing hit testing were broken by this change.
simon.fraser@apple.com [Thu, 1 Sep 2011 18:44:26 +0000 (18:44 +0000)]
REGRESSION (r94259): Two tests doing hit testing were broken by this change.
https://bugs.webkit.org/show_bug.cgi?id=67353

Reviewed by Chris Marrin.

Fix a regression from r94259; that change missed a fix in RenderView,
which affects coordinate transforms in position:fixed elements.

This fixes these tests:
    fast/events/document-elementFromPoint.html
    fast/events/offsetX-offsetY.html
    plugins/mouse-events-fixedpos.html

* rendering/RenderView.cpp:
(WebCore::RenderView::mapAbsoluteToLocalPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
tonyg@chromium.org [Thu, 1 Sep 2011 18:41:37 +0000 (18:41 +0000)]
[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=66673

Reviewed by James Robinson.

This was fixed for other ports in http://trac.webkit.org/changeset/88260.
However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().

No new tests because no directly observable change in behavior.

* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWeb Inspector: [Chromium] Perform a more effective JS GC
mnaganov@chromium.org [Thu, 1 Sep 2011 18:39:51 +0000 (18:39 +0000)]
Web Inspector: [Chromium] Perform a more effective JS GC
https://bugs.webkit.org/show_bug.cgi?id=67304

Reviewed by Pavel Feldman.

* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectGarbage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Transform QtFallbackWebPopupCombo into QtWebComboBox
caio.oliveira@openbossa.org [Thu, 1 Sep 2011 18:39:12 +0000 (18:39 +0000)]
[Qt] Transform QtFallbackWebPopupCombo into QtWebComboBox
https://bugs.webkit.org/show_bug.cgi?id=67344

Reviewed by Andreas Kling.

Renamed QtFallbackWebPopup to QtWebComboBox and decoupled it from
QtFallbackWebPopup. The new class is a QComboBox with the features that
we need for QtWebKit: tracking when the popup is hidden (via the didHide()
signal) and a convenience method to show its popup in the cursor position.

An important change was made to the combobox: instead of hooking our actions in
showPopup() and hidePopup(), as well as watching for popup visibility events, we
now just watch for the visibility events. This allowed us to get rid of
m_popupVisible and tracking the Show event.

This commit also removed a workaround for input focus added in r40970 after
reviewers request. See bug report for details.

* QtWebKit.pro:
* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
(WebCore::QtFallbackWebPopup::~QtFallbackWebPopup):
(WebCore::QtFallbackWebPopup::show):
(WebCore::QtFallbackWebPopup::deleteComboBox):
* WebCoreSupport/QtFallbackWebPopup.h:
* WebCoreSupport/QtWebComboBox.cpp: Added.
(WebCore::QtWebComboBox::QtWebComboBox):
(WebCore::QtWebComboBox::showPopupAtCursorPosition):
(WebCore::QtWebComboBox::eventFilter):
* WebCoreSupport/QtWebComboBox.h: Added.

* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::popupFocus):
Change the test to use QObject::findChild(). The old method couldn't find our
new class because we defined a new metaclass for it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttp/tests/loading/empty-urls.html shouldn't
japhet@chromium.org [Thu, 1 Sep 2011 18:37:07 +0000 (18:37 +0000)]
http/tests/loading/empty-urls.html shouldn't
fail if the load event fires before we finish.
https://bugs.webkit.org/show_bug.cgi?id=67359

Reviewed by Adam Barth.

* http/tests/loading/empty-urls-expected.txt:
* http/tests/loading/empty-urls.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebGLContextEvent should have its own JS wrapper
weinig@apple.com [Thu, 1 Sep 2011 18:20:45 +0000 (18:20 +0000)]
WebGLContextEvent should have its own JS wrapper
https://bugs.webkit.org/show_bug.cgi?id=67352

Reviewed by Anders Carlsson.

Source/WebCore:

The WebGLContextEvent was missing a proper JS wrapper, and thus
anyone using one in an EventListener was actually just getting
a plain old Event. Rectify this by generating the wrapper and
wrapping it on creating.

Test: fast/canvas/webgl/WebGLContextEvent.html

* CodeGenerators.pri:
Add WebGLContextEvent.idl

* DerivedSources.make:
Add WebGLContextEvent and sort.

* WebCore.xcodeproj/project.pbxproj:
Add generated JSWebGLContextEvent.h/cpp.

* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
Wrap WebGLContextEvents as JSWebGLContextEvents.

* dom/Event.cpp:
(WebCore::Event::isWebGLContextEvent):
* dom/Event.h:
* html/canvas/WebGLContextEvent.cpp:
(WebCore::WebGLContextEvent::isWebGLContextEvent):
* html/canvas/WebGLContextEvent.h:
Add predicate for WebGLContextEvent.

LayoutTests:

* fast/canvas/webgl/WebGLContextEvent-expected.txt: Added.
* fast/canvas/webgl/WebGLContextEvent.html: Added.
Add a test that shows that WebGLContextEvents are not just base Events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd 'muted' content attribute to HTMLMediaElement
eric.carlson@apple.com [Thu, 1 Sep 2011 18:10:51 +0000 (18:10 +0000)]
Add 'muted' content attribute to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=58369

Source/WebCore:

Reviewed by Darin Adler.

Test: media/video-defaultmuted.html

* html/HTMLAttributeNames.in: Add muted.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource): Deal with the 'muted' attribute.
* html/HTMLMediaElement.idl: Add defaultMuted.

LayoutTests:

Reviewed by Darin Adler.

* media/video-defaultmuted-expected.txt: Added.
* media/video-defaultmuted.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION: Rendering artifacts on a rotated, pattern filled shape
timothy_horton@apple.com [Thu, 1 Sep 2011 18:03:39 +0000 (18:03 +0000)]
REGRESSION: Rendering artifacts on a rotated, pattern filled shape
https://bugs.webkit.org/show_bug.cgi?id=53055
<rdar://problem/8910917>

Reviewed by Simon Fraser.

Introduce wkCGPatternCreateWithImageAndTransform.

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
eric@webkit.org [Thu, 1 Sep 2011 18:01:25 +0000 (18:01 +0000)]
Unreviewed.

Fix a typo in unittests.  Unfortunately fixing it
caused several assertions.  Just disabling the test
instead, since it was providing no value before due to the typo.

* Scripts/webkitpy/layout_tests/port/test.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Fix scissor rects on clipped nested iframes
enne@google.com [Thu, 1 Sep 2011 17:58:41 +0000 (17:58 +0000)]
[chromium] Fix scissor rects on clipped nested iframes
https://bugs.webkit.org/show_bug.cgi?id=67221

Reviewed by James Robinson.

Source/WebCore:

Layers that mask to bounds (like iframes) weren't being properly
clipped if their parent scissor rect was empty. This case happens
when a parent iframe is clipped. Fixed by propagating the empty
scissor rect to child layers rather than ignoring it.

Test: compositing/iframes/nested-composited-iframe.html

* platform/graphics/chromium/LayerRendererChromium.cpp:

LayoutTests:

* compositing/iframes/nested-composited-iframe-expected.png: Added.
* compositing/iframes/nested-composited-iframe-expected.txt: Added.
* compositing/iframes/nested-composited-iframe.html: Added.
* compositing/iframes/resources/composited-red.html: Added.
* compositing/iframes/resources/has-composited-iframe-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a "rebaseline" button to the garden-o-matic summary page
abarth@webkit.org [Thu, 1 Sep 2011 17:57:09 +0000 (17:57 +0000)]
Add a "rebaseline" button to the garden-o-matic summary page
https://bugs.webkit.org/show_bug.cgi?id=67382

Reviewed by Dimitri Glazkov.

As much as we might wish folks to not rebaseline entire test groups at
once, the truth is that doing so is a common operation.  Adding a
button for this operation is likely to make folks happy.

This patch also cleans up a bunch of plumbing surrounding failureInfo
objects.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] TouchWebView crashes with segmentation fault
commit-queue@webkit.org [Thu, 1 Sep 2011 17:56:19 +0000 (17:56 +0000)]
[Qt] TouchWebView crashes with segmentation fault
https://bugs.webkit.org/show_bug.cgi?id=67308

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-01
Reviewed by Benjamin Poulain.

If you instantiate TouchWebView element with height and width in a qml file and
load a url it crashes.
The functions setWidth() and setHeight() are called sequentially therefore it can happen
that computeViewportAttributes was called with a size like (width, 0) breaking the
assumption of the function that the size is valid. The patch makes sure we compute the
viewport when both height and width are valid.

* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportConstraints):
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml: Added.
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml: Added.
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml: Added.
* UIProcess/API/qt/tests/qmltests/qmltests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agogarden-o-matic should let the gardener assign blame for a group of test failures
abarth@webkit.org [Thu, 1 Sep 2011 17:54:58 +0000 (17:54 +0000)]
garden-o-matic should let the gardener assign blame for a group of test failures
https://bugs.webkit.org/show_bug.cgi?id=67379

Reviewed by Dimitri Glazkov.

If a group of test failures has a large revision range, the gardener
might wish to blame a specific revision for the failure.  Currently,
this only effect of assigning blame in this way is to hide the other
suspect commits.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoHide garden-o-matic failure table until hover
abarth@webkit.org [Thu, 1 Sep 2011 17:53:06 +0000 (17:53 +0000)]
Hide garden-o-matic failure table until hover
https://bugs.webkit.org/show_bug.cgi?id=67376

Reviewed by Dimitri Glazkov.

This patch removes the failure table for build failures (because it
does not make sense) and hides the failure table for test groups until
the user hovers over the test failure block, reducing visual noise.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSwitch garden-o-matic from commitData.title to commitData.summary
abarth@webkit.org [Thu, 1 Sep 2011 17:51:12 +0000 (17:51 +0000)]
Switch garden-o-matic from commitData.title to commitData.summary
https://bugs.webkit.org/show_bug.cgi?id=67375

Reviewed by Dimitri Glazkov.

commitData.title is a string provided by Trac, which isn't great in all
cases.  commitData.summary is my attempt to find the most important
one-line summary of the commit.  This patch switches garden-o-matic
over to summary.

Also, this patch tweaks a bunch of CSS to tighten up the summary page
and reduce visual noise.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoGroup failing tests in garden-o-matic if there are more than three in a folder
abarth@webkit.org [Thu, 1 Sep 2011 17:48:59 +0000 (17:48 +0000)]
Group failing tests in garden-o-matic if there are more than three in a folder
https://bugs.webkit.org/show_bug.cgi?id=67373

Reviewed by Dimitri Glazkov.

Sometimes a failure will cause many tests in a given directory to fail.
When that happens, it's better to list the directory as a single item
(with a count) rather than spamming all the test names.

(This patch also updates a bunch of unit test expected results after my last commit.)

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLower the visual noise from the failing builders display
abarth@webkit.org [Thu, 1 Sep 2011 17:47:00 +0000 (17:47 +0000)]
Lower the visual noise from the failing builders display
https://bugs.webkit.org/show_bug.cgi?id=67369

Reviewed by Dimitri Glazkov.

This patch ensures that the "Building" row in the failing builders
display is always last and dims it by 50% to reduce visual noise.  This
lets the gardener focus on the actual failures.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWeb Inspector: close dedicated worker inspectors when page inspector is closing
yurys@chromium.org [Thu, 1 Sep 2011 17:39:17 +0000 (17:39 +0000)]
Web Inspector: close dedicated worker inspectors when page inspector is closing
https://bugs.webkit.org/show_bug.cgi?id=67366

Close all dedicated worker inspector windows when page inspector is closing.

Reviewed by Pavel Feldman.

* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype._openInspectorWindow):
(WebInspector.WorkerManager.prototype._pageInspectorClosing):
(WebInspector.WorkerManager.prototype._workerInspectorClosing):
* inspector/front-end/inspector.js:
(WebInspector.close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Chromium] Web Inspector: dedicated worker inspection is broken
yurys@chromium.org [Thu, 1 Sep 2011 17:36:12 +0000 (17:36 +0000)]
[Chromium] Web Inspector: dedicated worker inspection is broken
https://bugs.webkit.org/show_bug.cgi?id=67279

Provide transport for inspector messages between Page and DedicatedWorker inspectors
in case of in-process workers.

Reviewed by Pavel Feldman.

* inspector/CodeGeneratorInspector.pm: sendMessageObjectToBackend should accept message
object which is ready for sending to backend. This method is overriden in WorkerManager
for dedicated workers and we don't want to replicate request id assignment there.
* workers/WorkerMessagingProxy.cpp:
(WebCore::PostMessageToPageInspectorTask::create):
(WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask):
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::connectToWorkerContextInspectorTask):
(WebCore::WorkerMessagingProxy::connectToInspector):
(WebCore::disconnectFromWorkerContextInspectorTask):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::dispatchOnInspectorBackendTask):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
* workers/WorkerMessagingProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Chromium] Unreviewed, rebaseline tests after r94299.
apavlov@chromium.org [Thu, 1 Sep 2011 17:25:41 +0000 (17:25 +0000)]
[Chromium] Unreviewed, rebaseline tests after r94299.

* platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
* platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
* platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
* platform/chromium-win/fast/borders/border-image-slices-expected.png: Added.
* platform/chromium-win/fast/borders/border-image-slices-expected.txt: Added.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[CSS3 Backgrounds and Borders] Implement border-image-slice
ossy@webkit.org [Thu, 1 Sep 2011 17:22:45 +0000 (17:22 +0000)]
[CSS3 Backgrounds and Borders] Implement border-image-slice
https://bugs.webkit.org/show_bug.cgi?id=67321

* WebCore.pro: Unreviewed buildfix after Dave "scattered" Hyatt (r94299).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTypesetting features need not force complex for single-character runs
commit-queue@webkit.org [Thu, 1 Sep 2011 17:20:29 +0000 (17:20 +0000)]
Typesetting features need not force complex for single-character runs
https://bugs.webkit.org/show_bug.cgi?id=66498

Typesetting features have no effect on a solitary character, so they shouldn't enable complex layout
unless multiple characters are present.

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-09-01
Reviewed by Dan Bernstein.

No new tests, this is merely a performance optimization.

* platform/graphics/Font.cpp:
(WebCore::Font::codePath): typesettingFeatures() only forces Complex for multiple-character runs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDefer creating AVPlayer and AVPlayerItem in MediaPlayerPrivateAVFoundation::setPreload()
jeffm@apple.com [Thu, 1 Sep 2011 17:15:46 +0000 (17:15 +0000)]
Defer creating AVPlayer and AVPlayerItem in MediaPlayerPrivateAVFoundation::setPreload()
https://bugs.webkit.org/show_bug.cgi?id=66253

Reviewed by Jon Honeycutt.

No new tests, should be covered by existing media tests.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Use the same code on Mac and Windows to only create the AVPlayer and AVPlayerItem when needed.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Assign any existing AVPlayerItem to the new AVPlayer.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Allow creation of the AVPlayerItem before the AVPlayer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNew baselines needed after changes in r94185
commit-queue@webkit.org [Thu, 1 Sep 2011 16:10:46 +0000 (16:10 +0000)]
New baselines needed after changes in r94185
https://bugs.webkit.org/show_bug.cgi?id=67350

Patch by Anna Cavender <annacc@chromium.org> on 2011-09-01
Reviewed by Eric Carlson.

* platform/chromium-linux/media/audio-repaint-expected.png:
* platform/chromium-linux/media/video-zoom-controls-expected.png:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium-win/media/video-zoom-controls-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, rolling out r94194.
commit-queue@webkit.org [Thu, 1 Sep 2011 16:03:41 +0000 (16:03 +0000)]
Unreviewed, rolling out r94194.
http://trac.webkit.org/changeset/94194
https://bugs.webkit.org/show_bug.cgi?id=67410

Broke a test on the GTK+ bots. (Requested by mrobinson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-01

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=67321
hyatt@apple.com [Thu, 1 Sep 2011 16:01:33 +0000 (16:01 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=67321

Implement border-image-slice. This will eventually be a component of the new border-image shorthand
property. It holds the cuts that you make into the border image along with a new optional "fill"
keyword that indicates whether or not the center should be filled with the middle slice of the image.

By default -webkit-border-image has always filled, but this does not match the specification. To preserve
backwards compatibility, -webkit-border-image will continue to fill by default, but this does slightly affect
computed style results, since the "fill" keyword will now be included in property dumps.

Reviewed by Beth Dakin.

Added fast/borders/border-image-slices.html.

* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSBorderImageSliceValue.cpp: Added.
(WebCore::CSSBorderImageSliceValue::CSSBorderImageSliceValue):
(WebCore::CSSBorderImageSliceValue::~CSSBorderImageSliceValue):
(WebCore::CSSBorderImageSliceValue::cssText):
* css/CSSBorderImageSliceValue.h: Added.
(WebCore::CSSBorderImageSliceValue::create):
(WebCore::CSSBorderImageSliceValue::isBorderImageSliceValue):
Add a new CSSBorderImageSliceValue that holds both the four slices (as a CSS rect) and the
fill keyword (as a boolean). Note that the cssText() dumping of the slices has been refined
to be smarter, and it will no longer dump repeating values.

* css/CSSBorderImageValue.cpp:
(WebCore::CSSBorderImageValue::CSSBorderImageValue):
(WebCore::CSSBorderImageValue::cssText):
* css/CSSBorderImageValue.h:
(WebCore::CSSBorderImageValue::create):
CSSBorderImageValue now owns a CSSBorderImageSliceValue instead of just a CSS rect.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImage):
Add a new method, valueForNinePieceImageSlice, for getting the slices plus the fill value
from the NinePieceImage and putting it into a CSSBorderImageSliceValue. This method is now used by
valueForNinePieceImage to get the CSSBorderImageSliceValue that is part of the overall
CSSBorderImageValue.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Adding support for the new properties: border-image-slice and -webkit-mask-box-image-slice.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::allowBreak):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
Modify parseBorderImage to no longer parse the slices itself. Instead it farms out the parsing
to parseBorderImageSlice.

(WebCore::BorderImageSliceParseContext::BorderImageSliceParseContext):
(WebCore::BorderImageSliceParseContext::allowNumber):
(WebCore::BorderImageSliceParseContext::allowFill):
(WebCore::BorderImageSliceParseContext::allowFinalCommit):
(WebCore::BorderImageSliceParseContext::top):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageSliceParseContext::commitFill):
(WebCore::BorderImageSliceParseContext::setAllowFinalCommit):
(WebCore::BorderImageSliceParseContext::setTop):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::CSSParser::parseBorderImageSlice):
Slice parsing has now been broken out so that it can be parsed as a single property. In addition
support for the "fill" keyword has been added to control image filling.

* css/CSSParser.h:
Modified to add the new parseBorderImageSlice method.

* css/CSSPropertyNames.in:
Add the new properties: border-image-slice and -webkit-mask-box-image-slice.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
Rework mapNinePieceImage to call mapNinePieceImageSlice so that the mapping can be done just for
the slices.

(WebCore::CSSStyleSelector::mapNinePieceImageSlice):
A new method that handles mapping just the slices into the front-end NinePieceImage.

(WebCore::CSSStyleSelector::loadPendingImages):
Modified to ensure the fill value is preserved when box-reflect makes a new NinePieceImage.

* css/CSSStyleSelector.h:
Added the new mapNinePieceImageSlice method.

* css/CSSValue.h:
(WebCore::CSSValue::isBorderImageSliceValue):
Virtual function for identifying border image slice values.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage):
The painting of the nine piece image has been modified to match the specification. The "fill"
keyword controls whether or not the middle is painted.

* rendering/style/NinePieceImage.cpp:
(WebCore::NinePieceImage::operator==):
The fill keyword has to be checked now for equality.

* rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImage::fill):
(WebCore::NinePieceImage::setFill):
Added the fill keyword to the front end NinePieceImage.

(WebCore::NinePieceImage::copySlicesFrom):
Added a helper to copy only the slices over from another NinePieceImage. Used when inheriting
the border-image-slice property from a parent style.

LayoutTests: Implement border-image-slice. This will eventually be a component of the new border-image shorthand
property. It holds the cuts that you make into the border image along with a new optional "fill"
keyword that indicates whether or not the center should be filled with the middle slice of the image.

By default -webkit-border-image has always filled, but this does not match the specification. To preserve
backwards compatibility, -webkit-border-image will continue to fill by default, but this does slightly affect
computed style results, since the "fill" keyword will now be included in property dumps.

Reviewed by Beth Dakin.

Added fast/borders/border-image-slices.html.

* fast/borders/border-image-slices.html: Added.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-with-zoom-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
* fast/css/uri-token-parsing-expected.txt:
* fast/css/uri-token-parsing.html:
* platform/mac/fast/borders/border-image-slices-expected.png: Added.
* platform/mac/fast/borders/border-image-slices-expected.txt: Added.
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSource/JavaScriptCore: Export fastMallocStatistics and Heap::objectTypeCounts for...
adachan@apple.com [Thu, 1 Sep 2011 15:09:50 +0000 (15:09 +0000)]
Source/JavaScriptCore: Export fastMallocStatistics and Heap::objectTypeCounts for https://bugs.webkit.org/show_bug.cgi?id=67160.

Reviewed by Darin Adler.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Source/WebKit2: Gather JavaScript, FastMalloc, icon, font, and glyph page statistics in WebProcess::getWebCoreStatistics().
https://bugs.webkit.org/show_bug.cgi?id=67160

Reviewed by Darin Adler.

Encode and decode the data members in StatisticsData.
* Shared/StatisticsData.cpp:
(WebKit::StatisticsData::encode):
(WebKit::StatisticsData::decode):
(WebKit::StatisticsData::StatisticsData):

Add three data members to StatisticsData:
- statisticsNumbers: Map containing statistics values that are numbers, mapped by their names, such as
JavaScriptObjectsCount, CachedFontDataCount, etc.
- javaScriptProtectedObjectTypeCounts
- javaScriptObjectTypeCounts
* Shared/StatisticsData.h:

Create a WK::Dictionary containing statistics values mapped by their names and return that dictionary
in WebContext::didGetWebCoreStatistics().
* UIProcess/WebContext.cpp:
(WebKit::createDictionaryFromHashMap):
(WebKit::WebContext::didGetWebCoreStatistics):

Package JavaScript, FastMalloc, icon, font, and glyph page statistics into a StatisticsData object
and send it to the UIProcess.
* WebProcess/WebProcess.cpp:
(WebKit::fromCountedSetToHashMap):
(WebKit::WebProcess::getWebCoreStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed Qt gardening.
loki@webkit.org [Thu, 1 Sep 2011 14:41:47 +0000 (14:41 +0000)]
Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=67392

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-01

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWeb Inspector: Decode query/form parameters names as well as values.
vsevik@chromium.org [Thu, 1 Sep 2011 14:22:56 +0000 (14:22 +0000)]
Web Inspector: Decode query/form parameters names as well as values.
https://bugs.webkit.org/show_bug.cgi?id=67393

Reviewed by Yury Semikhatsky.

* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView.prototype._decodeURIComponent):
(WebInspector.ResourceHeadersView.prototype._refreshParms):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Unreviewed, skip 2 GTK a11y failing tests.
philn@webkit.org [Thu, 1 Sep 2011 14:22:03 +0000 (14:22 +0000)]
    Unreviewed, skip 2 GTK a11y failing tests.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWeb Inspector: remove PresentationBreakpoint class.
podivilov@chromium.org [Thu, 1 Sep 2011 14:20:03 +0000 (14:20 +0000)]
Web Inspector: remove PresentationBreakpoint class.
https://bugs.webkit.org/show_bug.cgi?id=67275

Reviewed by Yury Semikhatsky.

* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didRequestContent):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Unreviewed, GTK baselines for new tests.
philn@webkit.org [Thu, 1 Sep 2011 14:09:41 +0000 (14:09 +0000)]
    Unreviewed, GTK baselines for new tests.

        * platform/gtk/fast/borders/border-fit-2-expected.png: Added.
        * platform/gtk/fast/borders/border-fit-2-expected.txt: Added.
        * platform/gtk/fast/borders/border-image-source-expected.png: Added.
        * platform/gtk/fast/borders/border-image-source-expected.txt: Added.
        * platform/gtk/fast/multicol/overflow-across-columns-expected.png: Added.
        * platform/gtk/fast/multicol/overflow-across-columns-expected.txt: Added.
        * platform/gtk/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
        * platform/gtk/fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.
        * platform/gtk/fast/multicol/overflow-unsplittable-expected.png: Added.
        * platform/gtk/fast/multicol/overflow-unsplittable-expected.txt: Added.
        * platform/gtk/fast/multicol/positive-leading-expected.png: Added.
        * platform/gtk/fast/multicol/positive-leading-expected.txt: Added.
        * platform/gtk/fast/table/table-after-child-in-table-expected.png: Added.
        * platform/gtk/fast/table/table-after-child-in-table-expected.txt: Added.
        * platform/gtk/fast/text/complex-preferred-logical-widths-expected.png: Added.
        * platform/gtk/fast/text/complex-preferred-logical-widths-expected.txt: Added.
        * platform/gtk/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
        * platform/gtk/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, rebaseline Qt-specific tests.
loki@webkit.org [Thu, 1 Sep 2011 13:06:59 +0000 (13:06 +0000)]
Unreviewed, rebaseline Qt-specific tests.

* platform/qt/fast/borders/border-image-source-expected.png: Added.
* platform/qt/fast/borders/border-image-source-expected.txt: Added.
* platform/qt/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
* platform/qt/fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed; new baselines (Skia on Mac, next chunk of 800 files)
caryclark@google.com [Thu, 1 Sep 2011 12:46:34 +0000 (12:46 +0000)]
Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
tables/mozilla/bugs/bug8361 through transitions/svg-text-shadow-transition

* platform/chromium-mac/transforms: Added.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoClean up all mentions of Android in comments
steveblock@google.com [Thu, 1 Sep 2011 12:37:04 +0000 (12:37 +0000)]
Clean up all mentions of Android in comments
https://bugs.webkit.org/show_bug.cgi?id=67303

Also removes some superfluous guards and methods added for Android.

Reviewed by Darin Adler.

No new tests, removing dead code only.

* WebCorePrefix.h:
  Chromium uses this file only on Mac, so these Android guards are no
  longer required.
* bindings/v8/NPV8Object.cpp:
* bindings/v8/NPV8Object.h:
  Including npruntime.h for non-Chromium ports was added in
  http://trac.webkit.org/changeset/53634 for Android. However, this
  file is included in WebCore.pro, so leaving the guard in place.
* bindings/v8/ScriptCachedFrameData.h:
  This code was added for Android in
  http://trac.webkit.org/changeset/56716 but is now also used by QT. The
  comment should have been removed in
  http://trac.webkit.org/changeset/93573.
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::isLayoutTimerActive):
(WebCore::Document::minimumLayoutDelay):
* dom/Document.h:
  This method was added for Android in
  http://trac.webkit.org/changeset/52919 and modified in
  http://trac.webkit.org/changeset/79775. It is no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed Qt gardening.
loki@webkit.org [Thu, 1 Sep 2011 12:36:34 +0000 (12:36 +0000)]
Unreviewed Qt gardening.

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-01

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Build dependency problems
ossy@webkit.org [Thu, 1 Sep 2011 12:24:41 +0000 (12:24 +0000)]
[Qt] Build dependency problems
https://bugs.webkit.org/show_bug.cgi?id=38054

Make clean build after the defines are changed.

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-01
Reviewed by Csaba Osztrogonác.

Source/WebCore:

* features.pri:

Tools:

* Scripts/webkitdirs.pm:
(buildQMakeProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWeb Inspector: Network error messages in console should link to the respective reques...
vsevik@chromium.org [Thu, 1 Sep 2011 12:16:10 +0000 (12:16 +0000)]
Web Inspector: Network error messages in console should link to the respective request in network panel if there is one.
https://bugs.webkit.org/show_bug.cgi?id=65550

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage.prototype._formatMessage):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype.searchCanceled):
(WebInspector.NetworkLogView.prototype.revealAndHighlightResource):
(WebInspector.NetworkLogView.prototype._removeAllNodeHighlights):
(WebInspector.NetworkLogView.prototype._highlightNode):
(WebInspector.NetworkPanel.prototype._resourceByAnchor):
(WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
(WebInspector.NetworkPanel.prototype.showAnchorLocation):
* inspector/front-end/networkLogView.css:
(.network-log-grid tr.highlighted-row):
(from):
(to):

LayoutTests:

* http/tests/inspector/console-resource-errors-expected.txt:
* http/tests/inspector/console-xhr-logging-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed; new baselines (Skia on Mac, next chunk of 800 files)
caryclark@google.com [Thu, 1 Sep 2011 12:06:25 +0000 (12:06 +0000)]
Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
svg/svg/text/scaled-font through tables/mozilla/bugs/bug82946-1

* platform/chromium-mac/svg/zoom: Added.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-09-01 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 1 Sep 2011 11:18:43 +0000 (11:18 +0000)]
2011-09-01  Xan Lopez  <xlopez@igalia.com>

        [GTK] Add XRender lib dependencies explicitly

        Reviewed by Philippe Normand.

        This is needed when using the GNU/Gold linker, since we use
        XRender directly.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReplace preprocessor statements in DOMWindow.idl with Conditional attribute
paroga@webkit.org [Thu, 1 Sep 2011 10:24:09 +0000 (10:24 +0000)]
Replace preprocessor statements in DOMWindow.idl with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=65050

Reviewed by Brent Fulgham.

Many attributes use the [Conditional=XXX] syntax already.
Unify the declaration of conditional attributes of DOMWindow
with the corresponding Conditional attribute.
This reduces the need of the preprocessor which is the
the source of much pain on native windows.

* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, skipping failing tests after r94259.
zherczeg@webkit.org [Thu, 1 Sep 2011 10:22:47 +0000 (10:22 +0000)]
Unreviewed, skipping failing tests after r94259.

r94259 fails on Qt and Gtk
https://bugs.webkit.org/show_bug.cgi?id=67383

* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebSocket: Fix bufferedAmount after WebSocket is closed
yutak@chromium.org [Thu, 1 Sep 2011 09:58:52 +0000 (09:58 +0000)]
WebSocket: Fix bufferedAmount after WebSocket is closed
https://bugs.webkit.org/show_bug.cgi?id=67363

Reviewed by Kent Tamura.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

* websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
(WebCore::WebSocket::getFramingOverhead):
* websockets/WebSocket.h:

LayoutTests:

* http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
* http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
Try to send messages having various lengths to make sure we correctly calculate
the framing overhead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDefine PTHREAD_KEYS_MAX to fix Android port build.
commit-queue@webkit.org [Thu, 1 Sep 2011 09:40:47 +0000 (09:40 +0000)]
Define PTHREAD_KEYS_MAX to fix Android port build.
https://bugs.webkit.org/show_bug.cgi?id=67362

Patch by Hao Zheng <zhenghao@chromium.org> on 2011-09-01
Reviewed by Adam Barth.

PTHREAD_KEYS_MAX is not defined in bionic, so explicitly define it.

* wtf/ThreadIdentifierDataPthreads.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTemporarily skip a test that started failing after r94274.
rniwa@webkit.org [Thu, 1 Sep 2011 08:44:55 +0000 (08:44 +0000)]
Temporarily skip a test that started failing after r94274.
The failure is tracked by the bug 67377.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRename colorSelected to didChooseColor
keishi@webkit.org [Thu, 1 Sep 2011 07:40:02 +0000 (07:40 +0000)]
Rename colorSelected to didChooseColor
https://bugs.webkit.org/show_bug.cgi?id=67271

Reviewed by Kent Tamura.

* WebCore.exp.in:
* html/ColorInputType.cpp:
(WebCore::ColorInputType::didChooseColor): Renamed colorSelected to didChooseColor so it follows common naming practice.
* html/ColorInputType.h:
* platform/ColorChooser.cpp:
(WebCore::ColorChooser::didChooseColor): Renamed.
* platform/ColorChooser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAttempt to fix Windows build.
abarth@webkit.org [Thu, 1 Sep 2011 07:27:22 +0000 (07:27 +0000)]
Attempt to fix Windows build.

* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd pass-throughs for NPObject/v8::Value marshalling to WebBindings
commit-queue@webkit.org [Thu, 1 Sep 2011 07:00:02 +0000 (07:00 +0000)]
Add pass-throughs for NPObject/v8::Value marshalling to WebBindings
https://bugs.webkit.org/show_bug.cgi?id=67302

Patch by Greg Billock <gbillock@google.com> on 2011-08-31
Reviewed by Darin Fisher.

* public/WebBindings.h:
* src/WebBindings.cpp:
(WebKit::WebBindings::toNPVariant):
(WebKit::WebBindings::toV8Value):
* src/WebSerializedScriptValue.cpp:
(WebKit::WebSerializedScriptValue::serialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Add baseline due to r94258.
levin@chromium.org [Thu, 1 Sep 2011 06:29:37 +0000 (06:29 +0000)]
[chromium] Add baseline due to r94258.

* platform/chromium-linux/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Chromium] Rename PlatformBridge to PlatformSupport
abarth@webkit.org [Thu, 1 Sep 2011 06:23:40 +0000 (06:23 +0000)]
[Chromium] Rename PlatformBridge to PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=67349

Reviewed by Darin Fisher.

This matches the WebKitPlatformSupport embedder API.

Source/WebCore:

* WebCore.gypi:
* WebCore.pro:
* bindings/v8/NPV8Object.cpp:
(_NPN_Evaluate):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportFatalErrorInV8):
* bindings/v8/V8GCController.cpp:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::V8Proxy::evaluate):
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::histogramEnumeration):
* page/PageGroup.cpp:
(WebCore::PageGroup::isLinkVisited):
* platform/audio/chromium/AudioBusChromium.cpp:
(WebCore::AudioBus::loadPlatformResource):
(WebCore::createBusFromInMemoryAudioFile):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::getSequenceNumber):
(WebCore::ChromiumDataObject::containsFilenames):
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
* platform/chromium/FileSystemChromium.cpp:
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::revealFolderInOS):
(WebCore::directoryName):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::fileExists):
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):
* platform/chromium/LanguageChromium.cpp:
(WebCore::platformDefaultLanguage):
* platform/chromium/LinkHashChromium.cpp:
(WebCore::visitedLinkHash):
* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):
* platform/chromium/PlatformBridge.h: Removed.
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/chromium/PlatformSupport.h: Copied from Source/WebCore/platform/chromium/PlatformBridge.h.
* platform/chromium/SSLKeyGeneratorChromium.cpp:
(WebCore::signedPublicKeyAndChallengeString):
* platform/chromium/ScrollbarThemeChromium.cpp:
* platform/chromium/ScrollbarThemeChromiumLinux.cpp:
(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
(WebCore::ScrollbarThemeChromiumWin::paintThumb):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
* platform/chromium/SharedTimerChromium.cpp:
(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):
* platform/chromium/SuddenTerminationChromium.cpp:
(WebCore::disableSuddenTermination):
(WebCore::enableSuddenTermination):
* platform/chromium/TraceEvent.h:
(WebCore::internal::ScopeTracer::ScopeTracer):
(WebCore::internal::ScopeTracer::~ScopeTracer):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::paint):
* platform/graphics/chromium/CrossProcessFontLoading.mm:
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::fontContainsCharacter):
(WebCore::FillLogFont):
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::drawGlyphsWin):
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::scriptFontProperties):
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::querySystemForRenderStyle):
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
* platform/graphics/chromium/ImageChromium.cpp:
(WebCore::Image::loadPlatformResource):
* platform/graphics/chromium/ImageChromiumMac.mm:
(WebCore::Image::loadPlatformResource):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/chromium/UniscribeHelperTextRun.cpp:
(WebCore::UniscribeHelperTextRun::tryToPreloadFont):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/network/chromium/CookieJarChromium.cpp:
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
* platform/network/chromium/DNSChromium.cpp:
(WebCore::prefetchDNS):
* platform/qt/PlatformBridge.h: Removed.
* platform/qt/PlatformBridgeQt.cpp: Removed.
* platform/qt/PlatformSupport.h: Copied from Source/WebCore/platform/qt/PlatformBridge.h.
* platform/qt/PlatformSupportQt.cpp: Copied from Source/WebCore/platform/qt/PlatformBridgeQt.cpp.
(WebCore::PlatformSupport::popupsAllowed):
(WebCore::PlatformSupport::pluginScriptableObject):
* platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::deleteDatabaseFile):
(WebCore::SQLiteFileSystem::getDatabaseFileSize):
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
* platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
* plugins/chromium/PluginDataChromium.cpp:
(WebCore::PluginCache::plugins):
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::getWebThemeState):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumWin::systemColor):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::menuListButtonWidth):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):
* storage/chromium/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create):
* storage/chromium/IDBKeyPathBackendImpl.cpp:
(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):
* storage/chromium/QuotaTracker.cpp:
(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):

Source/WebKit/chromium:

* WebKit.gyp:
* src/AssertMatchingEnums.cpp:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):
* src/PlatformBridge.cpp: Removed.
* src/ResourceHandle.cpp:
(WebCore::ResourceHandle::cacheMetadata):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::WebFrameImpl):
(WebKit::WebFrameImpl::~WebFrameImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCrash when inserting text with a trailing newline into a textarea via JS
rniwa@webkit.org [Thu, 1 Sep 2011 06:11:07 +0000 (06:11 +0000)]
Crash when inserting text with a trailing newline into a textarea via JS
https://bugs.webkit.org/show_bug.cgi?id=66241

Reviewed by Darin Adler and Kent Tamura.

Source/WebCore:

The crash was caused by updateFromElement biting on the editing code.

When there is a style rule that applies on text nodes inside the shadow DOM, DOM modifications made
by the editing code may trigger style recalculation on input or textarea elements in the midst of editing
commands. In response to this style recalculation, HTMLInputElement::updateFromElement and
HTMLTextAreaElement::updateFromElement call setInnerTextValue to re-create the text nodes in the
shadow DOM. The editing code blows up because setInnerTextValue detaches old text nodes referenced by
Positions and VisiblePositions held by the editing commands in progress.

Fixed the crash by stop calling setInnerTextValue in updateFromElement. Instead, WebKit now creates
the text nodes when attributes, descendent nodes, etc... of input or textarea element changes.

Tests: fast/forms/update-from-element-during-editing-crash-1.html
       fast/forms/update-from-element-during-editing-crash-2.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType): Force calling setInnerTextValue when input type changes.
(WebCore::HTMLInputElement::updateInnerTextValue): Extracted from RenderTextControlSingleLine's
updateElement.
(WebCore::HTMLInputElement::parseMappedAttribute): Calls updateInnerTextValue; force calling
setInnerTextValue when -webkit-speech attribute changes. In the theory, we should be able to call it less
frequently but there are too many cases to consider at the moment.
(WebCore::HTMLInputElement::setValue): Calls updateInnerTextValue when the value actually changed.
Note we need to call it before we set or restore selection.
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::childrenChanged): Calls updateInnerTextValue when textarea's descendants
nodes are changed by parser or scripts.
(WebCore::HTMLTextAreaElement::setValueCommon): Calls updateInnerTextValue when the value changes.
* html/HTMLTextFormControlElement.h:
* html/NumberInputType.cpp:
(WebCore::NumberInputType::willBlur): Calls updateInnerTextValue because input[type=number] forces
the value to be valid on blur.
* rendering/RenderTextControlMultiLine.cpp: Removed RenderTextControlMultiLine::updateFromElement.
* rendering/RenderTextControlMultiLine.h: Ditto.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::updateFromElement):

LayoutTests:

Add regressions tests to ensure WebKit doesn't crash even when style recalc happens
in the midst of editing commands.

* fast/forms/update-from-element-during-editing-crash-1-expected.txt: Added.
* fast/forms/update-from-element-during-editing-crash-1.html: Added.
* fast/forms/update-from-element-during-editing-crash-2-expected.txt: Added.
* fast/forms/update-from-element-during-editing-crash-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix snow-leopard regression caused by r93982
commit-queue@webkit.org [Thu, 1 Sep 2011 06:07:32 +0000 (06:07 +0000)]
Fix snow-leopard regression caused by r93982
https://bugs.webkit.org/show_bug.cgi?id=67301

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-31
Reviewed by Kenneth Russell.

Test: canvas/philip/tests/2d.path.stroke.prune.arc.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::arc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Add baselines due to r94253 and r94258.
levin@chromium.org [Thu, 1 Sep 2011 05:56:41 +0000 (05:56 +0000)]
[chromium] Add baselines due to r94253 and r94258.

* platform/chromium-cg-mac-leopard/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
* platform/chromium-win/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRename closeColorChooser to cleanupColorChooser
keishi@webkit.org [Thu, 1 Sep 2011 05:33:34 +0000 (05:33 +0000)]
Rename closeColorChooser to cleanupColorChooser
https://bugs.webkit.org/show_bug.cgi?id=67270

Reviewed by Kent Tamura.

* html/ColorInputType.cpp:
(WebCore::ColorInputType::~ColorInputType):
(WebCore::ColorInputType::detach):
(WebCore::ColorInputType::cleanupColorChooserIfCurrentClient): NSColorPanel shouldn't be closed but the color
chooser listeners need to be taken care of. Therefore closeColorChooser will be renamed to cleanupColorChooser.
This will close the color chooser on platforms where appropriate.
* html/ColorInputType.h:
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::cleanupColorChooser): Rename.
* page/Chrome.cpp:
(WebCore::Chrome::cleanupColorChooser): Rename.
* page/Chrome.h:
* page/ChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Add baselines for test added by r94253.
levin@chromium.org [Thu, 1 Sep 2011 03:23:12 +0000 (03:23 +0000)]
[chromium] Add baselines for test added by r94253.

* platform/chromium-cg-mac/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
* platform/chromium-linux/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
* platform/chromium-win/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
* platform/chromium-win/fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION(r88115): "Choose File" button doesn't respect font-size property for the...
tkent@chromium.org [Thu, 1 Sep 2011 02:40:01 +0000 (02:40 +0000)]
REGRESSION(r88115): "Choose File" button doesn't respect font-size property for the <input>
https://bugs.webkit.org/show_bug.cgi?id=67181

Reviewed by Dimitri Glazkov.

Source/WebCore:

r88115 removed the code to make inherited style of the owner input
element, and html.css contains "font: -webkit-small-control" for
input element. So -webkit-file-upload-button always had
-webkit-small-control font.

Test: fast/forms/file/file-style-inheritance.html

* css/html.css:
(input[type="file"]::-webkit-file-upload-button):
Specify font-size:inherit explicitly.

LayoutTests:

* fast/forms/file/file-style-inheritance-expected.txt: Added.
* fast/forms/file/file-style-inheritance.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDo more rigorous bounds checking in AudioBufferSourceNode::renderFromBuffer()
crogers@google.com [Thu, 1 Sep 2011 02:08:19 +0000 (02:08 +0000)]
Do more rigorous bounds checking in AudioBufferSourceNode::renderFromBuffer()
https://bugs.webkit.org/show_bug.cgi?id=67351

Reviewed by Dirk Pranke.

No new tests since this does not change JavaScript API.

* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::renderFromBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove closeColorChooser call from FrameLoader::transitionToCommitted
keishi@webkit.org [Thu, 1 Sep 2011 01:56:36 +0000 (01:56 +0000)]
Remove closeColorChooser call from FrameLoader::transitionToCommitted
https://bugs.webkit.org/show_bug.cgi?id=67267

Reviewed by Darin Adler.

* html/ColorInputType.cpp:
(WebCore::ColorInputType::closeColorChooserIfCurrentClient): Moved order to match header.
* html/ColorInputType.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted): Remove ColorInputType::closeColorChooserIfCurrentClient call.
It wasn't the right place to directly manipulate the UI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove DumpRenderTree to WebKitPlatformSupport
abarth@webkit.org [Thu, 1 Sep 2011 01:46:24 +0000 (01:46 +0000)]
Move DumpRenderTree to WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=67331

Reviewed by Darin Fisher.

This patch update DumpRenderTree to account for the WebKitClient =>
WebKitPlatformSupport rename.

* DumpRenderTree/chromium/NotificationPresenter.cpp:
(NotificationPresenter::show):
* DumpRenderTree/chromium/Task.cpp:
(postTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd defensive bounds checking for AudioNode methods
crogers@google.com [Thu, 1 Sep 2011 01:43:10 +0000 (01:43 +0000)]
Add defensive bounds checking for AudioNode methods
https://bugs.webkit.org/show_bug.cgi?id=67346

Reviewed by Anders Carlsson.

No new tests since this does not change JavaScript API.

* webaudio/AudioNode.cpp:
(WebCore::AudioNode::input):
(WebCore::AudioNode::output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChromium Mac: PDF: Scrollsbars should be visible when scrolling using the two finger...
commit-queue@webkit.org [Thu, 1 Sep 2011 01:31:50 +0000 (01:31 +0000)]
Chromium Mac: PDF: Scrollsbars should be visible when scrolling using the two finger gesture on Lion
https://bugs.webkit.org/show_bug.cgi?id=66599

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-31
Reviewed by Darin Fisher.

Overlay scrollbars over a pdf wouldn't stay visible if a gesture was in progress. Normally we use a beginScrollGesture and endScrollGesture to keep the scrollbars visible. Unfortunately PDFs didn't handle gesture events so we didn't get the begin/end gesture events.

This change pipes gesture events to WebPluginContainerImpl if possible. This fixes this bug.

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleGestureEvent):
* src/WebPluginContainerImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoshouldBeEqualToString should encode special characters
arv@chromium.org [Thu, 1 Sep 2011 01:22:22 +0000 (01:22 +0000)]
shouldBeEqualToString should encode special characters
https://bugs.webkit.org/show_bug.cgi?id=67223

Reviewed by Darin Adler.

* fast/js/resources/standalone-pre.js:
(shouldBeEqualToString): Encode \, ", \n, \r
* http/tests/cookies/resources/cookies-test-pre.js:
(shouldBeEqualToString): Encode \, ", \n, \r

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTransformState.move() should be negated in the unapply code path
simon.fraser@apple.com [Thu, 1 Sep 2011 01:20:23 +0000 (01:20 +0000)]
TransformState.move() should be negated in the unapply code path
https://bugs.webkit.org/show_bug.cgi?id=66246

Reviewed by Chris Marrin.

Code using TransformState was confused about when to negate the arguments
to move() in the "UnapplyInverseTransform" direction (used by mapAbsoluteToLocal).

Made the move() path equivalent to the applyTransform() path by not requiring
the caller to negate, and instead negating inside move().

Fixed the erroneous negation in TransformState::move() when accumulating;
that negation will happen later via matrix inversion.

No behavior change.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
* platform/graphics/transforms/TransformState.cpp:
(WebCore::TransformState::move):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::mapAbsoluteToLocalPoint):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::mapAbsoluteToLocalPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94259 268f45cc-cd09-0410-ab3c-d52691b4dbfc