adachan@apple.com [Thu, 6 Dec 2007 19:33:04 +0000 (19:33 +0000)]
Build fix.
Reviewed by Geoff.
* WebScriptCallFrame.cpp:
(WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 6 Dec 2007 18:46:23 +0000 (18:46 +0000)]
Reviewed by Oliver.
Rename
Movie -> MediaPlayer
MoviePrivate -> MediaPlayerPrivate
Movie is QuickTime terminology and clashes with its C API.
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::initAndDispatchProgressEvent):
(WebCore::HTMLMediaElement::bufferingRate):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
(WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::currentTime):
(WebCore::HTMLMediaElement::duration):
(WebCore::HTMLMediaElement::playbackRate):
(WebCore::HTMLMediaElement::setPlaybackRate):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::pickMedia):
(WebCore::HTMLMediaElement::checkIfSeekNeeded):
(WebCore::HTMLMediaElement::mediaPlayerVolumeChanged):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::mediaPlayerCuePointReached):
(WebCore::HTMLMediaElement::addCuePoint):
(WebCore::HTMLMediaElement::buffered):
(WebCore::HTMLMediaElement::seekable):
(WebCore::HTMLMediaElement::effectiveStart):
(WebCore::HTMLMediaElement::effectiveEnd):
(WebCore::HTMLMediaElement::effectiveLoopStart):
(WebCore::HTMLMediaElement::effectiveLoopEnd):
(WebCore::HTMLMediaElement::updateMediaPlayer):
(WebCore::HTMLMediaElement::willSaveToCache):
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::player):
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::videoWidth):
(WebCore::HTMLVideoElement::videoHeight):
* platform/MIMETypeRegistry.cpp:
(WebCore::initialiseSupportedMediaMIMETypes):
(WebCore::MIMETypeRegistry::isSupportedMediaMIMEType):
(WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
* platform/MIMETypeRegistry.h:
* platform/graphics/MediaPlayer.cpp: Copied from WebCore/platform/graphics/Movie.cpp.
(WebCore::MediaPlayer::MediaPlayer):
(WebCore::MediaPlayer::~MediaPlayer):
(WebCore::MediaPlayer::load):
(WebCore::MediaPlayer::cancelLoad):
(WebCore::MediaPlayer::play):
(WebCore::MediaPlayer::pause):
(WebCore::MediaPlayer::duration):
(WebCore::MediaPlayer::currentTime):
(WebCore::MediaPlayer::seek):
(WebCore::MediaPlayer::paused):
(WebCore::MediaPlayer::seeking):
(WebCore::MediaPlayer::naturalSize):
(WebCore::MediaPlayer::hasVideo):
(WebCore::MediaPlayer::networkState):
(WebCore::MediaPlayer::readyState):
(WebCore::MediaPlayer::volume):
(WebCore::MediaPlayer::setVolume):
(WebCore::MediaPlayer::rate):
(WebCore::MediaPlayer::setRate):
(WebCore::MediaPlayer::muted):
(WebCore::MediaPlayer::setMuted):
(WebCore::MediaPlayer::dataRate):
(WebCore::MediaPlayer::setEndTime):
(WebCore::MediaPlayer::addCuePoint):
(WebCore::MediaPlayer::removeCuePoint):
(WebCore::MediaPlayer::clearCuePoints):
(WebCore::MediaPlayer::maxTimeBuffered):
(WebCore::MediaPlayer::maxTimeSeekable):
(WebCore::MediaPlayer::bytesLoaded):
(WebCore::MediaPlayer::totalBytesKnown):
(WebCore::MediaPlayer::totalBytes):
(WebCore::MediaPlayer::setRect):
(WebCore::MediaPlayer::visible):
(WebCore::MediaPlayer::setVisible):
(WebCore::MediaPlayer::paint):
(WebCore::MediaPlayer::getSupportedTypes):
(WebCore::MediaPlayer::networkStateChanged):
(WebCore::MediaPlayer::readyStateChanged):
(WebCore::MediaPlayer::volumeChanged):
(WebCore::MediaPlayer::timeChanged):
(WebCore::MediaPlayer::cuePointReached):
* platform/graphics/MediaPlayer.h: Copied from WebCore/platform/graphics/Movie.h.
(WebCore::MediaPlayerClient::~MediaPlayerClient):
(WebCore::MediaPlayerClient::mediaPlayerNetworkStateChanged):
(WebCore::MediaPlayerClient::mediaPlayerReadyStateChanged):
(WebCore::MediaPlayerClient::mediaPlayerVolumeChanged):
(WebCore::MediaPlayerClient::mediaPlayerTimeChanged):
(WebCore::MediaPlayerClient::mediaPlayerCuePointReached):
* platform/graphics/Movie.cpp: Removed.
* platform/graphics/Movie.h: Removed.
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Copied from WebCore/platform/graphics/gtk/MoviePrivateGStreamer.cpp.
(WebCore::mediaPlayerPrivateErrorCallback):
(WebCore::mediaPlayerPrivateEOSCallback):
(WebCore::mediaPlayerPrivateStateCallback):
(WebCore::mediaPlayerPrivateBufferingCallback):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::setEndTime):
(WebCore::MediaPlayerPrivate::addCuePoint):
(WebCore::MediaPlayerPrivate::removeCuePoint):
(WebCore::MediaPlayerPrivate::clearCuePoints):
(WebCore::MediaPlayerPrivate::startCuePointTimerIfNeeded):
(WebCore::MediaPlayerPrivate::cancelSeek):
(WebCore::MediaPlayerPrivate::cuePointTimerFired):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::dataRate):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::maxTimeBuffered):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::maxTimeLoaded):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::totalBytesKnown):
(WebCore::MediaPlayerPrivate::totalBytes):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::loadStateChanged):
(WebCore::MediaPlayerPrivate::rateChanged):
(WebCore::MediaPlayerPrivate::sizeChanged):
(WebCore::MediaPlayerPrivate::timeChanged):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::didEnd):
(WebCore::MediaPlayerPrivate::loadingFailed):
(WebCore::MediaPlayerPrivate::setRect):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::createGSTPlayBin):
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: Copied from WebCore/platform/graphics/gtk/MoviePrivateGStreamer.h.
* platform/graphics/gtk/MoviePrivateGStreamer.cpp: Removed.
* platform/graphics/gtk/MoviePrivateGStreamer.h: Removed.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h: Copied from WebCore/platform/graphics/mac/MoviePrivateQTKit.h.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Copied from WebCore/platform/graphics/mac/MoviePrivateQTKit.mm.
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::createQTMovie):
(WebCore::MediaPlayerPrivate::createQTMovieView):
(WebCore::MediaPlayerPrivate::createQTTime):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::doSeek):
(WebCore::MediaPlayerPrivate::cancelSeek):
(WebCore::MediaPlayerPrivate::seekTimerFired):
(WebCore::MediaPlayerPrivate::setEndTime):
(WebCore::MediaPlayerPrivate::addCuePoint):
(WebCore::MediaPlayerPrivate::removeCuePoint):
(WebCore::MediaPlayerPrivate::clearCuePoints):
(WebCore::MediaPlayerPrivate::startCuePointTimerIfNeeded):
(WebCore::MediaPlayerPrivate::cuePointTimerFired):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::dataRate):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::maxTimeBuffered):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::maxTimeLoaded):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::totalBytesKnown):
(WebCore::MediaPlayerPrivate::totalBytes):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::loadStateChanged):
(WebCore::MediaPlayerPrivate::rateChanged):
(WebCore::MediaPlayerPrivate::sizeChanged):
(WebCore::MediaPlayerPrivate::timeChanged):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::didEnd):
(WebCore::MediaPlayerPrivate::setRect):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(-[WebCoreMovieObserver initWithCallback:WebCore::]):
* platform/graphics/mac/MoviePrivateQTKit.h: Removed.
* platform/graphics/mac/MoviePrivateQTKit.mm: Removed.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::player):
* rendering/RenderMedia.h:
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::RenderVideo):
(WebCore::RenderVideo::~RenderVideo):
(WebCore::RenderVideo::videoSizeChanged):
(WebCore::RenderVideo::paintReplaced):
(WebCore::RenderVideo::layout):
(WebCore::RenderVideo::updateFromElement):
(WebCore::RenderVideo::updatePlayer):
* rendering/RenderVideo.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 18:01:20 +0000 (18:01 +0000)]
Build fix: access global object directly.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::bindingInstance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 6 Dec 2007 12:20:55 +0000 (12:20 +0000)]
Fix bug spotted by GCC 4.2. Remove extraneous semicolon that completely changed the meaning of allowPopUp.
Reviewed by Eric.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 6 Dec 2007 09:26:50 +0000 (09:26 +0000)]
2007-12-06 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16173
Licensing change
Change license from BSD to LGPL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Thu, 6 Dec 2007 07:40:57 +0000 (07:40 +0000)]
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=15289
WebKit does not respect clip paths of a 0x0 rect
Make empty clip paths clip the whole referencing graphic.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 6 Dec 2007 06:25:24 +0000 (06:25 +0000)]
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=16266
<rdar://problem/
5625279> REGRESSION: crash loading CNN.com at
Interpreter::createObjectsForGlobalObjectProperties()
I don't know how to reproduce this in a test.
* bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark):
Call JSEventTargetNode::mark instead of DOMObject::mark. There's no difference
right now, but it's best to call your base class, not your base's base.
* bindings/js/kjs_events.h: Removed unneeded virtual from the
JSUnprotectedEventListener::mark() function; it neither derives from or is
derived from anyone else with a mark() function so there's no need for virtual.
* bindings/js/kjs_window.cpp: (KJS::Window::mark): Call JSGlobalObject::mark,
not JSObject::mark. This is the actual bug fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 6 Dec 2007 05:42:15 +0000 (05:42 +0000)]
2007-12-05 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
http://bugs.webkit.org/show_bug.cgi?id=16145
[gtk] Implement media support in GTK backend
Reviewed by Alp Toker.
Remove old comments, fix variable names, match WebKit coding style.
* platform/graphics/gtk/MoviePrivateGStreamer.cpp:
(WebCore::moviePrivateEOSCallback):
(WebCore::MoviePrivate::MoviePrivate):
(WebCore::MoviePrivate::load):
(WebCore::MoviePrivate::play):
(WebCore::MoviePrivate::pause):
(WebCore::MoviePrivate::currentTime):
(WebCore::MoviePrivate::seek):
(WebCore::MoviePrivate::cancelSeek):
(WebCore::MoviePrivate::seeking):
(WebCore::MoviePrivate::naturalSize):
(WebCore::MoviePrivate::setVolume):
(WebCore::MoviePrivate::setMuted):
(WebCore::MoviePrivate::maxTimeBuffered):
(WebCore::MoviePrivate::bytesLoaded):
(WebCore::MoviePrivate::totalBytesKnown):
(WebCore::MoviePrivate::totalBytes):
(WebCore::MoviePrivate::updateStates):
(WebCore::MoviePrivate::didEnd):
(WebCore::MoviePrivate::paint):
(WebCore::MoviePrivate::createGSTPlayBin):
* platform/graphics/gtk/MoviePrivateGStreamer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 6 Dec 2007 05:37:36 +0000 (05:37 +0000)]
Speculative wx build fix. Add PlugInInfoStore::pluginNameForMIMEType to the temporary link stubs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 6 Dec 2007 05:25:45 +0000 (05:25 +0000)]
Qt Windows build fix. Include the time-related headers in the correct place.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 6 Dec 2007 05:22:38 +0000 (05:22 +0000)]
Not reviewed; just undoing a previous commit.
- remove earlier incorrect fix for http://bugs.webkit.org/show_bug.cgi?id=16220
<rdar://problem/
5625221> Crash opening www.news.com (CNet)
The real bug was the backwards ?: in the compile function, which Geoff just
fixed. Rolling out the incorrect earlier fix.
* pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): Take out
the unneeded preflight change. The regression test proves this is still working
fine, so the bug remains fixed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 6 Dec 2007 05:13:01 +0000 (05:13 +0000)]
2007-12-05 Alp Toker <alp@atoker.com>
Rubber stamped by Mark Rowe.
Remove DEPENDPATH on the generated sources directory. This causes
trouble and is no longer necessary following the glib-genmarshal
generator split.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 6 Dec 2007 04:14:59 +0000 (04:14 +0000)]
Build fix. Include headers before trying to use the things that they declare.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 03:11:50 +0000 (03:11 +0000)]
Build fix: added some #includes.
* kjs/JSImmediate.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 03:07:43 +0000 (03:07 +0000)]
Build fix: added some #includes.
* kjs/JSGlobalObject.cpp:
* kjs/JSImmediate.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 03:02:11 +0000 (03:02 +0000)]
Build fix: Fixed #include spelling.
* kjs/debugger.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 02:57:03 +0000 (02:57 +0000)]
Build fix: added #include.
* kjs/debugger.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 02:51:46 +0000 (02:51 +0000)]
Build fix: added a forward declaration.
* kjs/debugger.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 02:47:57 +0000 (02:47 +0000)]
Build fix: added an #include.
* kjs/error_object.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 02:41:09 +0000 (02:41 +0000)]
Build fix: added an #include.
* kjs/bool_object.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 02:31:41 +0000 (02:31 +0000)]
JavaScriptCore:
Reviewed by Darin Adler.
Third step in refactoring JSGlobalObject: Moved data members and
functions accessing data members from Interpreter to JSGlobalObject.
Changed Interpreter member functions to static functions.
This resolves a bug in global object bootstrapping, where the global
ExecState could be used when uninitialized.
This is a big change, but it's mostly code motion and renaming.
Layout and JS tests, and testjsglue and testapi, pass. SunSpider reports
a .7% regression, but Shark sees no difference related to this patch,
and SunSpider reported a .7% speedup from an earlier step in this
refactoring, so I think it's fair to call that a wash.
JavaScriptGlue:
Reviewed by Darin Adler.
Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject. Replaced JSInterpreter
subclass with JSGlobalObject subclass.
* JSRun.cpp:
(JSRun::JSRun):
(JSRun::Evaluate):
(JSRun::CheckSyntax):
* JSRun.h:
(JSGlueGlobalObject::JSGlueGlobalObject):
* JSUtils.cpp:
(KJSValueToCFTypeInternal):
* JSValueWrapper.cpp:
(getThreadGlobalExecState):
WebCore:
Reviewed by Darin Adler.
Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject. Changed Interpreter
member functions to static functions. Same for the subclass,
ScriptInterpreter.
This is a big change, but it's mostly code motion and renaming.
WebKit/mac:
Reviewed by Darin Adler.
Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.
* WebView/WebFrame.mm:
(-[WebFrame _attachScriptDebugger]):
WebKit/win:
Reviewed by Darin Adler.
Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.
* WebFrame.cpp:
(WebFrame::globalContext):
(WebFrame::attachScriptDebugger):
(WebFrame::windowObjectCleared):
* WebScriptDebugger.cpp:
(WebScriptDebugger::WebScriptDebugger):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Thu, 6 Dec 2007 01:37:14 +0000 (01:37 +0000)]
Reviewed by Antti.
Addressed <rdar://problem/
5137284> fast/events/mouseout-dead-node.html fails on boomer
* fast/events/mouseout-dead-node.html:
Changed the questionable calls to mouseUp() to mouseMoveTo() to better simulate mouseovers
* platform/win/Skipped:
removed this test from skipped file
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 6 Dec 2007 01:36:35 +0000 (01:36 +0000)]
<rdar://problem/
5625327> Crash toggling check grammar w/ spelling when no spell checker exists.
Reviewed by Adam.
* WebView.cpp:
(WebView::setGrammarCheckingEnabled): Add null check
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 6 Dec 2007 00:56:17 +0000 (00:56 +0000)]
* platform/win/Skipped: Add a crashing test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 6 Dec 2007 00:33:23 +0000 (00:33 +0000)]
"Reviewed" by Geoff.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Removed assertion.
(WebCore::FrameLoader::dispatchDidCommitLoad): This one too.
The assertions are firing like crazy. Not sure why yet.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 00:03:19 +0000 (00:03 +0000)]
Reviewed by Darin Adler. (Or vice versa.)
Fixed ASSERT during run-javascriptcore-tests. (Darin just added the
ASSERT, but the bug wasn't new.)
* pcre/pcre_compile.cpp:
(compile_branch): The ?: operator here was backwards, causing us to
execute the loop too many times, adding stray KET opcodes to the
compiled regular expression.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 5 Dec 2007 23:34:19 +0000 (23:34 +0000)]
Make the entry points extern "C".
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 5 Dec 2007 22:58:41 +0000 (22:58 +0000)]
Reviewed by Adam Roben.
- fix http://bugs.webkit.org/show_bug.cgi?id=16306
Assertion failed in WebCore/loader/FrameLoader.cpp:4642
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidCommitLoad): Check m_creatingInitialEmptyDocument
and don't deliver the client call in that case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 5 Dec 2007 22:57:32 +0000 (22:57 +0000)]
C++ warning fixes.
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(NPP_Destroy):
(NPP_SetWindow):
(NPP_NewStream):
(NPP_HandleEvent):
(NPP_URLNotify):
(NPP_GetValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 5 Dec 2007 22:54:46 +0000 (22:54 +0000)]
Add the .cpp files to the TestNetscapePlugIn target.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Wed, 5 Dec 2007 22:48:48 +0000 (22:48 +0000)]
Reviewed by Geoff.
- Wait until local variable data is fully constructed before notifying the debugger of entering
or leaving a call frame.
* kjs/function.cpp:
(KJS::FunctionImp::callAsFunction):
* kjs/nodes.cpp:
(KJS::FunctionBodyNode::execute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 5 Dec 2007 22:42:51 +0000 (22:42 +0000)]
Reviewed by Geoff.
Rename the TestNetscapePlugIn .c files to be .cpp.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
* DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
* DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
* DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 5 Dec 2007 22:30:08 +0000 (22:30 +0000)]
Fix 64-bit debug build.
Reviewed by Kevin Decker.
* platform/text/mac/TextCodecMac.cpp:
(WebCore::TextCodecMac::decode): OSStatus is a long for 32-bit but int on 64-bit,
so we need to cast it to be able to use a single format specifier on both.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 5 Dec 2007 22:29:05 +0000 (22:29 +0000)]
Build fix for GCC 4.2. Cast via a union to avoid strict-aliasing issues.
Reviewed by Oliver.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 5 Dec 2007 22:27:25 +0000 (22:27 +0000)]
* platform/win/Skipped: Add another test failing due to fonts.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 5 Dec 2007 22:24:19 +0000 (22:24 +0000)]
Fix case of keypresses from the Windows implementation of eventSender.keyDown
This fixes several regression tests.
Reviewed by Alice.
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback): Virtual keycodes for ASCII characters are always
uppercase, so we need to check the case of the original character
passed in to eventSender.keyDown.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker@apple.com [Wed, 5 Dec 2007 22:08:45 +0000 (22:08 +0000)]
Corrected a Radar number in my previous ChangeLog entry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker@apple.com [Wed, 5 Dec 2007 21:51:09 +0000 (21:51 +0000)]
Reviewed by Hyatt.
<rdar://problem/
5602071> Safari displays each pixel of 300 dpi US Patent TIFF Images, making them extremely large
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldUsePlugin): Allow plug-ins (with the exception of QuickTime) to
takeover TIFF once again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 5 Dec 2007 21:48:39 +0000 (21:48 +0000)]
Add another Inspector screenshot for an upcoming blog post.
* blog-files/InspectorDatabaseBrowser.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 5 Dec 2007 21:16:19 +0000 (21:16 +0000)]
Fix testkjs in 64-bit.
When built for 64-bit the TCMalloc spin lock uses pthread mutexes rather than a custom spin lock
implemented in assembly. If we fail to initialize the pthread mutex, attempts to lock or unlock
it will fail and trigger a call to abort.
Reviewed by Darin.
* wtf/FastMalloc.cpp: Initialize the spin lock so that we can later lock and unlock it.
* wtf/TCSpinLock.h: Add an Init method to the optimised spin lock.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 20:26:42 +0000 (20:26 +0000)]
2007-12-05 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16290
[GTK] Pasting clipboard in rich text.
* platform/gtk/PasteboardGtk.cpp:
(Pasteboard::documentFragment): Implement rich text paste support.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Wed, 5 Dec 2007 20:10:18 +0000 (20:10 +0000)]
Reviewed by Hyatt.
Reverting fix for <rdar://problem/
5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
We need to just fix the underlying focus ring repaint problem.
* rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Wed, 5 Dec 2007 20:01:02 +0000 (20:01 +0000)]
WebCore:
Reviewed by Darin.
- <rdar://
5621435>
- Security Fix. Instead of having it off by default, WebKit now must
explicitly turn off local-resource restriction when needed for backwards
compatibility reasons.
* loader/FrameLoader.cpp:
WebKit/mac:
Reviewed by Darin.
- <rdar://
5621435>
- Security Fix. Instead of having it off by default, WebKit now must
explicitly turn off local-resource restriction when needed for backwards
coimpatibility reasons.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 5 Dec 2007 19:38:02 +0000 (19:38 +0000)]
Expose WebView::setProhibitsMainFrameScrolling through IWebViewPrivate
Reviewed by Steve.
* Interfaces/IWebViewPrivate.idl: Added declaration.
* WebInspectorClient.cpp:
(WebInspectorClient::createPage): Updated for change to
setProhibitsMainFrameScrolling signature.
* WebView.cpp:
(WebView::setProhibitsMainFrameScrolling): Updated and robustified.
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 5 Dec 2007 19:36:56 +0000 (19:36 +0000)]
Set the menu item identifier for all menu items
This allows WebKit clients to distinguish between submenus in the
context menu.
Reviewed by Darin.
No test possible.
* platform/win/ContextMenuItemWin.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 5 Dec 2007 18:51:39 +0000 (18:51 +0000)]
Learn from Tim's mistakes
* DumpRenderTree/win/DumpRenderTree.cpp:
(runTest): Reset the authorAndUserStylesEnabled preference for each
test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 5 Dec 2007 18:46:45 +0000 (18:46 +0000)]
WebCore:
Reviewed by Darin Adler.
- WebCore part of fixing <rdar://problem/
5111082> Flash popup video ad doesn't close when clicked at http://www.firestonecompleteautocare.com/
* manual-tests/nested-plug-ins.html: Added.
* manual-tests/resources/nested-plug-ins-inner-frame.html: Added.
* manual-tests/resources/nested-plug-ins-outer-frame.html: Added.
* platform/ScrollView.h:
* platform/Widget.h:
(WebCore::Widget::attachToWindow): Added. Tells the widget that it is connected
via visible ScrollViews to the root ScrollView of the WebView.
(WebCore::Widget::detachFromWindow): Added. Tells the widget that it is no longer
connected via visible ScrollViews to the root ScrollView of the WebView.
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): Added
m_visible and m_attachedToWindow members.
(WebCore::ScrollView::attachToWindow): Added. Attaches all children if this
view is visible.
(WebCore::ScrollView::detachFromWindow): Added. Detaches all children if this
view is visible (otherwise they would be detached already).
(WebCore::ScrollView::show): Added. Attaches all children if this view
is attached.
(WebCore::ScrollView::hide): Added. Detaches all children if this view
is attached (otherwise they would be detached already).
(WebCore::ScrollView::isAttachedToWindow): Added.
* platform/win/WidgetWin.cpp:
(WebCore::Widget::setParent): Added calls to attachToWindow() and detachFromWindow()
depending on whether the parent is set and attached or not.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::setFocus):
(WebCore::PluginViewWin::show): Changed to show the plug-in only if
this view is attached.
(WebCore::PluginViewWin::hide): Changed to hide the plug-in only if this
view is attached (otherwise it would be hidden already).
(WebCore::PluginViewWin::attachToWindow): Added. Shows the plug-in if this view
is visible.
(WebCore::PluginViewWin::detachFromWindow): Added. Hides the plug-in if this view
is visible (otherwise it would be hidden already).
(WebCore::PluginViewWin::PluginViewWin):
* plugins/win/PluginViewWin.h: Added m_attachedToWindow member.
WebKit/win:
Reviewed by Darin Adler.
- WebKit/win part of fixing <rdar://problem/
5111082> Flash popup video ad doesn't close when clicked at http://www.firestonecompleteautocare.com/
* WebView.cpp:
(WebView::initWithFrame): Attach the main frame's view.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 5 Dec 2007 18:15:30 +0000 (18:15 +0000)]
Reviewed by Kevin Deckers rubberstamp
Disclose and export the Databases Directory defaults key
* Storage/WebDatabaseManager.mm:
* Storage/WebDatabaseManagerPrivate.h:
* WebKit.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 16:42:14 +0000 (16:42 +0000)]
2007-12-05 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Initialize GTK+ and WebKit so the tests can run.
Reorganize the headers a little.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 15:53:54 +0000 (15:53 +0000)]
2007-12-05 Michael Natterer <mitch@imendio.com>
Reviewed by Alp Toker.
* WebView/webkitwebview.cpp: split key and button event handlers
into separate press and release functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 15:16:47 +0000 (15:16 +0000)]
2007-12-05 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Handle events for Home and End keys.
* WebView/webkitwebview.cpp:
(webkit_web_view_key_event):
* WebCoreSupport/EditorClientGtk.cpp:
(EditorClient::handleKeypress):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 12:35:47 +0000 (12:35 +0000)]
2007-12-05 Michael Natterer <mitch@imendio.com>
Reviewed by Alp Toker.
* WebView/webkitwebview.cpp
* WebCoreSupport/ChromeClientGtk.cpp
* WebCoreSupport/FrameLoaderClientGtk.cpp: canonicalize signal names.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 5 Dec 2007 08:26:21 +0000 (08:26 +0000)]
Reviewed by Adam Roben.
- adding a test for http://bugs.webkit.org/show_bug.cgi?id=16097
* fast/dom/ImageDocument-image-deletion-expected.txt: Added.
* fast/dom/ImageDocument-image-deletion.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 5 Dec 2007 04:47:32 +0000 (04:47 +0000)]
Fix gtk build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28435
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 5 Dec 2007 03:58:41 +0000 (03:58 +0000)]
Merge TCMalloc r38
Reviewed by Mark Rowe and Geoff Garen.
It also result in a performance progression between 0.5% and
0.9% depending on the test, however most if not all of this
gain will be consumed by the overhead involved in the later
change to release memory to the system.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 02:48:16 +0000 (02:48 +0000)]
2007-12-04 Alp Toker <alp@atoker.com>
Potential GTK+ build fix for the glib-genmarshal issue.
Split the glib-genmarshal qmake generator in two; one for the source
file, another for the header.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 5 Dec 2007 02:34:45 +0000 (02:34 +0000)]
Remove IWebScriptScope include.
* Drosera/win/DebuggerDocumentPlatform.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 02:08:15 +0000 (02:08 +0000)]
2007-12-04 Alp Toker <alp@atoker.com>
GTK+ build fix.
* platform/PlugInInfoStore.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28431
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker@apple.com [Wed, 5 Dec 2007 01:46:33 +0000 (01:46 +0000)]
Reviewed by Anders.
<rdar://problem/
5629125> PluginInfoStore needs the ability to return the name of a plug-in for a given MIME type
* page/mac/WebCoreViewFactory.h: Added pluginNameForMIMEType: method.
* platform/PlugInInfoStore.h:
* platform/gtk/TemporaryLinkStubs.cpp: Added stub version of pluginNameForMIMEType.
(PlugInInfoStore::pluginNameForMIMEType):
* platform/mac/PlugInInfoStoreMac.mm:
(WebCore::PlugInInfoStore::pluginNameForMIMEType): Added.
* platform/qt/PlugInInfoStoreQt.cpp:
(WebCore::PlugInInfoStore::pluginNameForMIMEType): Added stub version of pluginNameForMIMEType.
* plugins/win/PlugInInfoStoreWin.cpp:
(WebCore::PlugInInfoStore::pluginNameForMIMEType): Added stub version of pluginNameForMIMEType.
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory pluginNameForMIMEType:]): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Wed, 5 Dec 2007 01:08:54 +0000 (01:08 +0000)]
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/
5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
* rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle):
Adjust outline-offset so it doesn't extend beyond the border to interfere with typing
LayoutTests:
Reviewed by Darin.
Test for <rdar://problem/
5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
* fast/forms/textfield-outline.html: Added.
* platform/mac/fast/forms/textfield-outline-expected.checksum: Added.
* platform/mac/fast/forms/textfield-outline-expected.png: Added.
* platform/mac/fast/forms/textfield-outline-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Wed, 5 Dec 2007 01:05:00 +0000 (01:05 +0000)]
Provide API for setting the default storage quota per database origin
Reviewed by Jon.
* Interfaces/IWebPreferencesPrivate.idl: added SPI to get/set default database quota
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): default database quota is 5MB
(WebPreferences::longlongValueForKey):
(WebPreferences::setLongLongValue):
(WebPreferences::defaultDatabaseQuota):
(WebPreferences::setDefaultDatabaseQuota):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): propagate default database quota change to WebCore settings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 5 Dec 2007 00:46:38 +0000 (00:46 +0000)]
Reviewed by Jon.
Always call NPP_NewStream, NPP_DestroyStream and NPP_URLNotify for JavaScript
result streams, even if the JavaScript expression threw an exception or returned undefined.
This matches what Firefox does.
* plugins/win/PluginStreamWin.cpp:
(WebCore::PluginStreamWin::sendJavaScriptStream):
Handle the result string being null, and set the correct NPReason if it is.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::performRequest):
Always send the JavaScript stream, regardless of the result could be converted to a string or not.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 5 Dec 2007 00:30:12 +0000 (00:30 +0000)]
Reviewed by Mark Rowe
Tweaked the way we typedef and cast these objc_msgSend calls
* WebView/WebView.mm:
(CallDelegateReturningUnsignedLongLong):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 5 Dec 2007 00:23:55 +0000 (00:23 +0000)]
Rubber stamped by Mark Rowe.
Define CF as platform for mac and revert r28409
* DumpRenderTree/DumpRenderTree.h:
* DumpRenderTree/mac/DumpRenderTreeMac.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 5 Dec 2007 00:14:11 +0000 (00:14 +0000)]
Reviewed by Adam Roben.
Remove http/tests/incremental/frame-focus-before-load.html from the skipped list
as it is no longer crashing. <rdar://problem/
5507278>
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Wed, 5 Dec 2007 00:08:37 +0000 (00:08 +0000)]
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/
5622464> controls should show up for audio element
* css/html4.css: Added styles for audio controls. This will need to be refined, since we may want a different look for audio controls.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged): When the controls attribute changes detach and reattach if necessary.
(WebCore::HTMLMediaElement::rendererIsNeeded): Added.
(WebCore::HTMLMediaElement::createRenderer): Added. Uses RenderMedia.
* html/HTMLMediaElement.h:
* rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Added constructor that doesn't take intrinsic size.
* rendering/RenderMedia.h:
LayoutTests:
Reviewed by Hyatt.
Test for <rdar://problem/
5622464> controls should show up for audio element
* media/audio-controls-rendering.html: Added.
* platform/mac/media/audio-controls-rendering-expected.checksum: Added.
* platform/mac/media/audio-controls-rendering-expected.png: Added.
* platform/mac/media/audio-controls-rendering-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Wed, 5 Dec 2007 00:01:35 +0000 (00:01 +0000)]
Reviewed by Brady Eidson (with help from Mark Rowe)
Fixed return values for unsigned-long-long delegate methods
* WebView/WebView.mm:
(CallDelegateReturningUnsignedLongLong):
redid the change that Brady did at home over the weekend but forgot to check in
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 4 Dec 2007 23:53:04 +0000 (23:53 +0000)]
JavaScriptCore:
Reviewed by Sam.
Make isSafeScript const.
* kjs/JSGlobalObject.h:
(KJS::JSGlobalObject::isSafeScript):
WebCore:
Reviewed by Sam.
Add isSafeScript(const JSGlobalObject*) so we won't get the JSGlobalObject
implementation, which always returns true(!).
* bindings/js/kjs_window.cpp:
(KJS::Window::isSafeScript):
Make the static isSafeScript method take two JSGlobalObjects.
* bindings/js/kjs_window.h:
(KJS::Window::isSafeScript):
Implement isSafeScript and have it call the static method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 4 Dec 2007 23:40:59 +0000 (23:40 +0000)]
Define CF as platform for windows.
Reviewed by Adam Roben.
* DumpRenderTree/win/DumpRenderTreeWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Tue, 4 Dec 2007 23:19:16 +0000 (23:19 +0000)]
WebKit/win:
Reviewed by Adam and Darin.
- Fixed a crasher where the top of the stack was not updated correctly.
And set the eol style on IWebScriptCallFrame.idl file.
* Interfaces/IWebScriptCallFrame.idl:
* WebScriptDebugger.cpp:
(WebScriptDebugger::atStatement):
(WebScriptDebugger::leaveFrame):
WebKitTools:
Reviewed by Adam and Darin.
- Removed a needless BSTR cleanup.
* Drosera/win/DebuggerDocumentPlatform.cpp:
(DebuggerDocument::getPlatformCurrentFunctionStack):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 4 Dec 2007 22:54:37 +0000 (22:54 +0000)]
Hook up the authorAndUserStylesEnabled preference on Windows
WebKit/win:
Hook up the authorAndUserStylesEnabled preference
This is the Windows counterpart of r28071.
Reviewed by Maciej.
* Interfaces/IWebPreferencesPrivate.idl: Added new method
declarations.
* WebPreferenceKeysPrivate.h: Added a new preference key.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Set the default for the
new preference.
(WebPreferences::setAuthorAndUserStylesEnabled): Added.
(WebPreferences::authorAndUserStylesEnabled): Added.
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): Communicate the new preference
down to WebCore::Settings.
WebKitTools:
Fix <rdar://
5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
Reviewed by Maciej.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
LayoutTests:
Remove a now-passing test from the Windows Skipped file
Reviewed by Maciej.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 4 Dec 2007 22:52:47 +0000 (22:52 +0000)]
Make the implementation of Frame::setNeedsReapplyStyles cross-platform
WebCore:
Make the implementation of Frame::setNeedsReapplyStyles cross-platform
Reviewed by Hyatt.
No change in functionality.
* page/Frame.cpp:
(WebCore::Frame::setNeedsReapplyStyles): Added. Invalidates the
FrameView so that FrameView::layout will be called, which ends up
calling reapplyStyles.
(WebCore::Frame::needsReapplyStyles): Added.
(WebCore::Frame::reapplyStyles): Renamed from reparseConfiguration.
(WebCore::FramePrivate::FramePrivate):
* page/Frame.h:
* page/FramePrivate.h: Added new boolean member.
* page/FrameView.cpp:
(WebCore::FrameView::layout): Call Frame::reapplyStyles if needed.
(WebCore::FrameView::needsLayout): Say that we need layout if the
Frame needs styles reapplied.
* page/mac/WebCoreFrameBridge.h: Removed setNeedsReapplyStyles.
* page/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge reapplyStylesForDeviceType:]): Updated for
rename.
* bridge/win/FrameWin.cpp: Removed Frame::setNeedsReapplyStyles.
* page/gtk/FrameGtk.cpp: Ditto.
* page/mac/FrameMac.mm: Ditto.
* page/qt/FrameQt.cpp: Ditto.
* platform/wx/TemporaryLinkStubs.cpp: Ditto.
WebKit/mac:
Remove -[WebFrameBridge setNeedsReapplyStyles]
This functionality is now WebCore's responsibility.
Reviewed by Hyatt.
* WebCoreSupport/WebFrameBridge.mm:
* WebKit.order:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 4 Dec 2007 22:28:06 +0000 (22:28 +0000)]
2007-12-04 Alp Toker <alp@atoker.com>
Prospective Win DRT build fix.
* DumpRenderTree/DumpRenderTree.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Tue, 4 Dec 2007 21:46:26 +0000 (21:46 +0000)]
Reviewed by Adele.
Pass intrinsic size to the base class.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::RenderMedia):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Tue, 4 Dec 2007 21:12:34 +0000 (21:12 +0000)]
2007-12-04 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Ollie.
Don't crash if our JavaPlugin DLL can't be found
* WebFrame.cpp:
(WebFrame::createJavaAppletWidget): Added null check
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Tue, 4 Dec 2007 21:11:38 +0000 (21:11 +0000)]
Reviewed by Darin
Added deleteOrigin: SPI, which isn't fully implemented
* Storage/WebDatabaseManagerPrivate.h:
* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager deleteOrigin:]):
just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Tue, 4 Dec 2007 21:11:21 +0000 (21:11 +0000)]
Reviewed by Darin.
Fix for <rdar://problem/
5578209> REGRESSION: Crash in WebCore::DeprecatedValueListImpl::Private::copyList when going back on zoomerang.com/survey
* loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation):
When the new url is exactly the same as the old url, don't treat it like a fragment navigation, since its going to cause a reload.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 4 Dec 2007 20:26:39 +0000 (20:26 +0000)]
Reviewed by Mark Rowe.
Remove a check for early versions of Leopard CFNetwork now that
Leopard has shipped.
* Misc/WebKitVersionChecks.h: Remove WEBKIT_FIRST_CFNETWORK_VERSION_WITH_LARGE_DISK_CACHE_FIX.
* WebView/WebView.mm:
(+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker@apple.com [Tue, 4 Dec 2007 19:56:50 +0000 (19:56 +0000)]
2007-12-04 Kevin Decker <kdecker@apple.com>
Reviewed by Darin.
Revised fix for: <rdar://problem/
5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang
This fix is exactly the same as chageset 28359 with the exception of an added early return in
updateAndSetWindow to cover the additional case of when a plug-in isn't drawable.
The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would
only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with
Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context
regardless of whether or not it actually needs to draw.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned
down an ASSERT that was too strict.
(-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins
which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow()
function. Also tweaked a comment and added an early return if the plug-in can't draw.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 4 Dec 2007 19:47:13 +0000 (19:47 +0000)]
WebCore:
Reviewed by Kevin Decker.
- added an assertion for a situation that leads to a Safari assertion:
a commit that is not followed by a load completion
- removed some unneeded FrameLoader stuff -- maybe some day we'll get this
class cut down to size
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader): Added boolean for assertion.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Added code to assert
that we already sent a commit before sending a complete.
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Call
client directly instead of indirecting through a function.
(WebCore::FrameLoader::loadItem): Ditto.
(WebCore::FrameLoader::goToItem): Ditto.
(WebCore::FrameLoader::addHistoryForCurrentLocation): Get the private browsing
state from Settings instead of FrameLoaderClient. Also call client directly
instead of indirecting through a function.
(WebCore::FrameLoader::updateHistoryForReload): Call client directly instead
of indirecting through a function.
(WebCore::FrameLoader::dispatchDidCommitLoad): Added code to assert
that we did not yet send a commit and set the flag that will be used to check
that we don't do this twice in a row without an intervening completion call.
* loader/FrameLoader.h: Added a boolean for the assertion. Removed six
now-unneeded functions.
* loader/FrameLoaderClient.h: Removed now-unneeded privateBrowsingEnabled function.
* loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willCacheResponse): Get
the private browsing state from Settings instead of FrameLoaderClient.
* svg/graphics/SVGImageEmptyClients.h: Removed obsolete privateBrowsingEnabled.
WebKit/gtk:
Reviewed by Kevin Decker.
* WebCoreSupport/FrameLoaderClientGtk.cpp: Removed obsolete privateBrowsingEnabled.
* WebCoreSupport/FrameLoaderClientGtk.h: Ditto.
WebKit/mac:
Reviewed by Kevin Decker.
* WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
* WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
* WebKit.order: Ditto.
WebKit/qt:
Reviewed by Kevin Decker.
* WebCoreSupport/FrameLoaderClientQt.cpp: Removed obsolete privateBrowsingEnabled.
* WebCoreSupport/FrameLoaderClientQt.h: Ditto.
WebKit/win:
Reviewed by Kevin Decker.
* WebFrame.cpp: Removed obsolete privateBrowsingEnabled.
* WebFrame.h: Ditto.
WebKit/wx:
Reviewed by Kevin Decker.
* WebKitSupport/FrameLoaderClientWx.cpp: Removed obsolete privateBrowsingEnabled.
* WebKitSupport/FrameLoaderClientWx.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 4 Dec 2007 19:46:45 +0000 (19:46 +0000)]
Update StringsNotToBeLocalized.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Tue, 4 Dec 2007 19:21:09 +0000 (19:21 +0000)]
WebCore:
Reviewed by Adele.
Fix <rdar://problem/
5624802>
Controller displays outside of <video> element when width and height aren't specified
- Explicitly adjust size of the controls tree root.
- Switch RenderMedia base class back to RenderReplaced. It is easier to manage the shadow tree
by hand. This also allows better code sharing with other replaced element classes.
- Move duplicated layout and painting code from subclasses up to RenderReplaced.
Test: media/video-controls-rendering.html
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
* rendering/RenderHTMLCanvas.h:
Share code.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::minimumReplacedHeight):
* rendering/RenderImage.h:
Share code.
* rendering/RenderMedia.cpp:
(WebCore::RenderMediaControlShadowRoot::RenderMediaControlShadowRoot):
(WebCore::RenderMediaControlShadowRoot::setParent):
Add a subclass just to get through encapsulation to use setParent().
(WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
Move initialization to the constructor.
(WebCore::RenderMedia::RenderMedia):
(WebCore::RenderMedia::~RenderMedia):
(WebCore::RenderMedia::layout):
Resize and layout the controller root by hand.
(WebCore::RenderMedia::firstChild):
(WebCore::RenderMedia::lastChild):
(WebCore::RenderMedia::removeChild):
Support one child renderer for controls.
(WebCore::RenderMedia::createControlsShadowRoot):
* rendering/RenderMedia.h:
(WebCore::RenderMedia::isMedia):
Switch base class to RenderReplaced, delete the now unnecessary stuff.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout):
(WebCore::RenderReplaced::paint):
* rendering/RenderReplaced.h:
(WebCore::RenderReplaced::minimumReplacedHeight):
(WebCore::RenderReplaced::paintReplaced):
Share code.
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::videoSizeChanged):
Simplify, just request relayout.
(WebCore::RenderVideo::paintReplaced):
(WebCore::RenderVideo::layout):
* rendering/RenderVideo.h:
Share code.
LayoutTests:
Reviewed by Adele.
Test for <rdar://problem/
5624802>
Controller displays outside of <video> element when width and height aren't specified
* media/remove-from-document.html: Improve coverage by doing relayout before finishing.
* media/video-controls-rendering.html: Added.
* platform/mac/media/video-controls-rendering-expected.checksum: Added.
* platform/mac/media/video-controls-rendering-expected.png: Added.
* platform/mac/media/video-controls-rendering-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 4 Dec 2007 19:10:19 +0000 (19:10 +0000)]
2007-12-04 Michael Natterer <mitch@imendio.com>
Reviewed by Alp Toker.
* WebCore.pro: fix build of webkit-marshal by building the
functions into a separate .cpp file instead of including them in
the header. This way we can use the marshallers from more than one
file without using bad hacks.
Add the generated sources directory to DEPENDPATH.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 4 Dec 2007 19:08:28 +0000 (19:08 +0000)]
JavaScriptCore:
Reviewed by Geoff.
- fix first part of http://bugs.webkit.org/show_bug.cgi?id=16220
<rdar://problem/
5625221> Crash opening www.news.com (CNet)
Test: fast/js/regexp-overflow.html
* pcre/pcre_compile.cpp:
(calculateCompiledPatternLengthAndFlags): Add room for the additional BRA/KET that
was generated in the compile code but not taken into account here.
LayoutTests:
Reviewed by Geoff.
- test for first part of http://bugs.webkit.org/show_bug.cgi?id=16220
<rdar://problem/
5625221> Crash opening www.news.com (CNet)
* fast/js/regexp-overflow-expected.txt: Updated.
* fast/js/resources/regexp-overflow.js: Added test cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 4 Dec 2007 18:28:30 +0000 (18:28 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 4 Dec 2007 18:27:48 +0000 (18:27 +0000)]
Windows build fix
* WebScriptCallFrame.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 4 Dec 2007 17:58:18 +0000 (17:58 +0000)]
2007-12-04 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Link to Planet WebKit.
* nav.inc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 4 Dec 2007 16:50:38 +0000 (16:50 +0000)]
2007-12-04 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16145
[gtk] Implement media support in GTK backend
This implements the media tags of HTML5 on the GTK+ port based on the
Mac port. Media tests pass although some tests required a small modifications:
As per the HTML5 spec, the loading of the clip should start only after
all script are done. But in the case of the tests, the loading starts
before some callbacks get registered. This has been discussed with
Antti Koivisto, and the tests should be updated.
There is only one known issue: one time in 10 tries, loading a buffered
clip will never end buffering. The buffering will stall at 97% for no
apparent reasons. Reloading the page usually works around the problem.
On the GStreamer side, some codecs don't return correct values, therefore
they make the tests fail. For instance H.264 will make the video-end
test fail. This should be fixed in GStreamer 0.10.15.
This version displays video in a pop up window. A place holder is drawn
on the page where the video should appear.
By default, it is turned off in WebCore.pro until GStreamer/X
detection issues are sorted out.
* WebCore.pro:
Disable video for now
* platform/Logging.cpp:
(WebCore::):
* platform/Logging.h:
Added a logging level for Media stuff
* platform/graphics/Movie.cpp:
* platform/graphics/gtk/MoviePrivateGStreamer.cpp: Added.
(WebCore::moviePrivateErrorCallback):
(WebCore::moviePrivateEOSCallback):
(WebCore::moviePrivateStateCallback):
(WebCore::moviePrivateBufferingCallback):
(WebCore::moviePrivateWindowIDCallback):
(WebCore::MoviePrivate::MoviePrivate):
(WebCore::MoviePrivate::~MoviePrivate):
(WebCore::MoviePrivate::load):
(WebCore::MoviePrivate::play):
(WebCore::MoviePrivate::pause):
(WebCore::MoviePrivate::duration):
(WebCore::MoviePrivate::currentTime):
(WebCore::MoviePrivate::seek):
(WebCore::MoviePrivate::setEndTime):
(WebCore::MoviePrivate::addCuePoint):
(WebCore::MoviePrivate::removeCuePoint):
(WebCore::MoviePrivate::clearCuePoints):
(WebCore::MoviePrivate::startCuePointTimerIfNeeded):
(WebCore::MoviePrivate::cancelSeek):
(WebCore::MoviePrivate::cuePointTimerFired):
(WebCore::MoviePrivate::paused):
(WebCore::MoviePrivate::seeking):
(WebCore::MoviePrivate::naturalSize):
(WebCore::MoviePrivate::hasVideo):
(WebCore::MoviePrivate::setVolume):
(WebCore::MoviePrivate::setMuted):
(WebCore::MoviePrivate::setRate):
(WebCore::MoviePrivate::dataRate):
(WebCore::MoviePrivate::networkState):
(WebCore::MoviePrivate::readyState):
(WebCore::MoviePrivate::maxTimeBuffered):
(WebCore::MoviePrivate::maxTimeSeekable):
(WebCore::MoviePrivate::maxTimeLoaded):
(WebCore::MoviePrivate::bytesLoaded):
(WebCore::MoviePrivate::totalBytesKnown):
(WebCore::MoviePrivate::totalBytes):
(WebCore::MoviePrivate::cancelLoad):
(WebCore::MoviePrivate::updateStates):
(WebCore::MoviePrivate::loadStateChanged):
(WebCore::MoviePrivate::rateChanged):
(WebCore::MoviePrivate::sizeChanged):
(WebCore::MoviePrivate::timeChanged):
(WebCore::MoviePrivate::volumeChanged):
(WebCore::MoviePrivate::didEnd):
(WebCore::MoviePrivate::loadingFailed):
(WebCore::MoviePrivate::setRect):
(WebCore::MoviePrivate::setVisible):
(WebCore::MoviePrivate::paint):
(WebCore::MoviePrivate::getSupportedTypes):
(WebCore::MoviePrivate::createGSTPlayBin):
* platform/graphics/gtk/MoviePrivateGStreamer.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 4 Dec 2007 14:12:16 +0000 (14:12 +0000)]
2007-12-04 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Fix a regression in key press propagation in r28386.
Fix indentation (was off by two spaces).
* WebView/webkitwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Tue, 4 Dec 2007 13:19:05 +0000 (13:19 +0000)]
Add the missing ChangeLog entries for r28349.
WebCore/ChangeLog:
2007-12-04 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
* Implement the InspectorClient for the Qt port
* It does not support highlighting of nodes yet
* Use QRC to open the internal page. The important thing is the
'/' in the URL to make WebCore::Document::completeURL behave the
way we want.
* To make the InspectorClient work we will have to mark qrc as secure.
* WebCore.pro:
* loader/FrameLoader.cpp:
(WebCore::localSchemes):
* page/inspector/WebKit.qrc: Added.
WebKit/qt:
2007-12-04 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
* Implement the InspectorClient for the Qt port
* It does not support highlighting of nodes yet
* Use QRC to open the internal page. The important thing is the
'/' in the URL to make WebCore::Document::completeURL behave the
way we want.
* To make the InspectorClient work we will have to mark qrc as secure.
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
* Api/qwebpage.h:
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientWebPage::hideEvent):
(WebCore::InspectorClientQt::InspectorClientQt):
(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorClientQt::createPage):
(WebCore::InspectorClientQt::localizedStringsURL):
(WebCore::InspectorClientQt::showWindow):
(WebCore::InspectorClientQt::closeWindow):
(WebCore::InspectorClientQt::attachWindow):
(WebCore::InspectorClientQt::detachWindow):
* WebCoreSupport/InspectorClientQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 4 Dec 2007 13:14:40 +0000 (13:14 +0000)]
2007-12-04 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15911
[GTK] Use GtkBindingSet to make key bindings user-configurable
This patch doesn't cover the full range of bindings, only the ones
that seem obviously correct and have clear public API.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::handleKeypress): do not handle clipboard operations and select-all
* WebView/webkitwebview.cpp: add cut, copy, paste and select-all signals and allow binding sets (issue #15911 and #16144)
* WebView/webkitwebview.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 4 Dec 2007 12:34:44 +0000 (12:34 +0000)]
2007-12-04 Alp Toker <alp@atoker.com>
Fix a clobbered copyright header.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 4 Dec 2007 12:16:38 +0000 (12:16 +0000)]
2007-12-04 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15561
GTK port needs DumpRenderTree implementation
Start work on the GTK+ DRT.
This does not work yet, and there are a few lingering style issues
(nothing major) but this patch has been stuck in the bug tracker for
too long already.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 4 Dec 2007 08:40:47 +0000 (08:40 +0000)]
Roll out r28359 as it causes serious problems with tabbed browsing in Safari when viewing pages containing plugins (<rdar://problem/
5627529>).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 4 Dec 2007 08:31:07 +0000 (08:31 +0000)]
2007-12-04 Alp Toker <alp@atoker.com>
Rubber stamped by Mark Rowe.
Remove two unused variables to silence warnings.
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Tue, 4 Dec 2007 07:35:18 +0000 (07:35 +0000)]
Rubberstamped by Tim.
Make the bullets lickable.
* wwwroot/planetwebkit.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Tue, 4 Dec 2007 07:19:32 +0000 (07:19 +0000)]
Reviewed by Adam.
Make it sexy with awesome icon and tweaks from Tim.
* templates/index.html.tmpl:
* wwwroot/ie.css: Added.
* wwwroot/images/ie-nav-blue.png: Added.
* wwwroot/planetwebkit.css: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Tue, 4 Dec 2007 06:59:50 +0000 (06:59 +0000)]
Added bug reference.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 4 Dec 2007 05:17:09 +0000 (05:17 +0000)]
Move JavaScriptCore thread testing code to pthread specific directory
and remove the dependance on CoreFoundation by using WTF::HashSet.
Reviewed by Geoff and Oliver.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
* DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
* DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
* DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
* DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
* DumpRenderTree/mac/JavaScriptThreading.h: Removed.
* DumpRenderTree/pthreads: Added.
* DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
(javaScriptThreads):
(runJavaScriptThread):
(startJavaScriptThreads):
(stopJavaScriptThreads):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 4 Dec 2007 04:57:32 +0000 (04:57 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc