bashi@chromium.org [Fri, 9 Dec 2011 04:12:55 +0000 (04:12 +0000)]
Unreviewed, chromium test rebaseline tests added in r102388. Updates expectations.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
* platform/chromium-cg-mac-leopard/transitions/cross-fade-background-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/animations/cross-fade-background-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/animations/cross-fade-border-image-source-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/animations/cross-fade-border-image-source-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/animations/cross-fade-list-style-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/transitions/cross-fade-background-image-expected.png: Added.
* platform/chromium-linux/animations/cross-fade-background-image-expected.png: Added.
* platform/chromium-linux/animations/cross-fade-border-image-source-expected.png: Added.
* platform/chromium-linux/animations/cross-fade-list-style-image-expected.png: Added.
* platform/chromium-linux/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/chromium-linux/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/chromium-linux/transitions/cross-fade-background-image-expected.png: Added.
* platform/chromium-linux/transitions/cross-fade-border-image-expected.png: Added.
* platform/chromium-mac-leopard/animations/cross-fade-background-image-expected.png: Added.
* platform/chromium-mac-leopard/animations/cross-fade-border-image-source-expected.png: Added.
* platform/chromium-mac-leopard/animations/cross-fade-list-style-image-expected.png: Added.
* platform/chromium-mac-leopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/chromium-mac-leopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/chromium-mac-leopard/transitions/cross-fade-background-image-expected.png: Added.
* platform/chromium-mac-leopard/transitions/cross-fade-border-image-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/cross-fade-background-image-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/cross-fade-list-style-image-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/chromium-mac-snowleopard/transitions/cross-fade-background-image-expected.png: Added.
* platform/chromium-win/animations/cross-fade-background-image-expected.png: Added.
* platform/chromium-win/animations/cross-fade-background-image-expected.txt: Added.
* platform/chromium-win/animations/cross-fade-border-image-source-expected.png: Added.
* platform/chromium-win/animations/cross-fade-border-image-source-expected.txt: Added.
* platform/chromium-win/animations/cross-fade-list-style-image-expected.png: Added.
* platform/chromium-win/animations/cross-fade-list-style-image-expected.txt: Added.
* platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
* platform/chromium-win/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/chromium-win/animations/cross-fade-webkit-mask-image-expected.txt: Added.
* platform/chromium-win/transitions/cross-fade-background-image-expected.png: Added.
* platform/chromium-win/transitions/cross-fade-background-image-expected.txt: Added.
* platform/chromium-win/transitions/cross-fade-border-image-expected.png: Added.
* platform/chromium-win/transitions/cross-fade-border-image-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Dec 2011 03:28:25 +0000 (03:28 +0000)]
Accessibility object searching layout tests are incomplete.
https://bugs.webkit.org/show_bug.cgi?id=74130
Patch by Sam White <samuel.white@rochester.edu> on 2011-12-08
Reviewed by Chris Fleizach.
Added a layout test to support visited link searching and removed frame searching
(which was unimplemented) as it's fully covered by the tests in:
platform/mac/accessibility/search-with-frames.html
* platform/mac/accessibility/search-predicate-expected.txt:
* platform/mac/accessibility/search-predicate.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Fri, 9 Dec 2011 03:24:30 +0000 (03:24 +0000)]
[gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
https://bugs.webkit.org/show_bug.cgi?id=73980
Reviewed by Tony Chang.
* gdb/webkit.py:
(guess_string_length):
(ustring_to_string):
(lstring_to_string):
(LCharStringPrinter):
(LCharStringPrinter.to_string):
(WTFStringImplPrinter.get_length):
(WTFStringImplPrinter.to_string):
(WTFStringImplPrinter.is_8bit):
(WTFStringPrinter.stringimpl_ptr):
(WTFStringPrinter.get_length):
(WTFStringPrinter.to_string):
(add_pretty_printers.lookup_function):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pierre.rossi@gmail.com [Fri, 9 Dec 2011 03:22:18 +0000 (03:22 +0000)]
Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
https://bugs.webkit.org/show_bug.cgi?id=73916
Source/WebCore:
This was needed for Qt since the mobile theme, which can be picked
up at runtime, delegates the rendering of list boxes.
Reviewed by Kent Tamura.
No new tests, there's no functional change.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::usesMenuList):
* html/HTMLSelectElement.h:
* platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::listBoxSelectItem):
(WebCore::PopupMenuClient::multiple):
* platform/qt/RenderThemeQtMobile.h:
(WebCore::RenderThemeQtMobile::delegatesMenuListRendering):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::multiple):
* rendering/RenderMenuList.h:
* rendering/RenderTheme.h:
(WebCore::RenderTheme::delegatesMenuListRendering):
Source/WebKit/chromium:
Reviewed by Kent Tamura.
* src/ExternalPopupMenu.cpp:
(WebKit::ExternalPopupMenu::didAcceptIndices):
(WebKit::ExternalPopupMenu::getPopupMenuInfo):
Source/WebKit/qt:
Reviewed by Kent Tamura.
* WebCoreSupport/PopupMenuQt.cpp:
(SelectData::multiple):
(WebCore::PopupMenuQt::selectItem):
Tools:
Reviewed by Kent Tamura.
* qmake/mkspecs/features/features.prf:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 9 Dec 2011 03:07:14 +0000 (03:07 +0000)]
Rename WEBKIT_lose_context to WEBKIT_WEBGL_lose_context
https://bugs.webkit.org/show_bug.cgi?id=71870
Source/WebCore:
Reviewed by James Robinson.
Rename largely done with do-webcore-rename with a couple of
necessary manual fixups. Ran WebGL layout tests.
* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLLoseContext.cpp: Copied from Source/WebCore/html/canvas/WebKitLoseContext.cpp.
(WebCore::WebGLLoseContext::WebGLLoseContext):
(WebCore::WebGLLoseContext::~WebGLLoseContext):
(WebCore::WebGLLoseContext::getName):
(WebCore::WebGLLoseContext::create):
(WebCore::WebGLLoseContext::loseContext):
(WebCore::WebGLLoseContext::restoreContext):
* html/canvas/WebGLLoseContext.h: Copied from Source/WebCore/html/canvas/WebKitLoseContext.h.
* html/canvas/WebGLLoseContext.idl: Copied from Source/WebCore/html/canvas/WebKitLoseContext.idl.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebKitLoseContext.cpp: Removed.
* html/canvas/WebKitLoseContext.h: Removed.
* html/canvas/WebKitLoseContext.idl: Removed.
LayoutTests:
Synchronized context-lost-restored.html and context-lost.html with
Khronos repository; upstream tests must check for multiple vendor
prefixes.
Reviewed by James Robinson.
* fast/canvas/webgl/WebGLContextEvent.html:
* fast/canvas/webgl/context-destroyed-crash.html:
* fast/canvas/webgl/context-lost-expected.txt:
* fast/canvas/webgl/context-lost-restored.html:
* fast/canvas/webgl/context-lost.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Fri, 9 Dec 2011 02:59:02 +0000 (02:59 +0000)]
Unreviewed chromium rebaseline fast/repaint/textarea-set-disabled.html.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
* platform/chromium-win/fast/repaint/textarea-set-disabled-expected.png: Added.
* platform/chromium/fast/repaint/textarea-set-disabled-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 9 Dec 2011 02:49:28 +0000 (02:49 +0000)]
Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394
Reviewed by Adam Barth.
- Overview: Using the [Supplemental] IDL, this patch moves the attribute
declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).
- This patch changes the build flow of WebCore.gyp as follows:
Previous build flow:
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;
}
New build flow (See the discussions in bug 72138 for more details):
resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;
}
- This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL
will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:
In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.
This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:
- DerivedSources.make
- DerivedSources.pri
- GNUmakefile.am
- PlatformBlackBerry.cmake
- UseJSC.cmake
- UseV8.cmake
- WebCore.vcproj/MigrateScripts
- WebCore.vcproj/WebCore.vcproj
- bindings/gobject/GNUmakefile.am
- WebCore.gyp/WebCore.gyp
Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:
DOMWindowWebAudio.idl:
interface [
Supplemental=DOMWindow
] DOMWindowWebAudio {
attribute attr1;
attribute attr2;
};
DOMWindow.idl:
interface [
] DOMWindow {
attribute [Supplemented] attr1; // This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2; // This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;
};
Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:
- If a given build script supports the [Supplemental] IDL,
generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
- Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL
as normal attributes and instead ignores all attributes with the [Supplemental] IDL
(i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).
Tests: webaudio/*
* WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command.
* WebCore.gypi: Added DOMWindowWebAudio.idl.
* bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
* page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
* webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Dec 2011 02:38:37 +0000 (02:38 +0000)]
Add test for inline style block in HTML tag
https://bugs.webkit.org/show_bug.cgi?id=72360
Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2011-12-08
Reviewed by Darin Adler.
* fast/css/parsing-css-block-expected.txt: Added.
* fast/css/parsing-css-block.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Dec 2011 02:32:14 +0000 (02:32 +0000)]
Unreviewed, rolling out r102396.
http://trac.webkit.org/changeset/102396
https://bugs.webkit.org/show_bug.cgi?id=74153
over-active-drag test still failing. (Requested by macpherson
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08
* fast/css/hover-active-drag.html:
* platform/chromium/fast/css/hover-active-drag-expected.txt: Added.
* platform/mac/fast/css/hover-active-drag-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Dec 2011 02:28:27 +0000 (02:28 +0000)]
Caret keeps blinking during forward-delete
https://bugs.webkit.org/show_bug.cgi?id=38564
Patch by Van Lam <vanlam@google.com> on 2011-12-08
Reviewed by Darin Adler.
Currently updateAppearance determines if the caret should stop blinking
based on whether or not the editing operation changed the position of
the caret; so the caret stops blinking in case of typing text and
backwards delete (which always displace the caret) but does not stop
blinking in the case of forward delete (which does not displace the
caret).
Added a boolean member function shouldStopCaretBlinking in EditCommand
which will return true if the object is a TypingCommand (my
understanding here is that all TypingCommands should stop the caret
from blinking for a cycle, currently 0.5 seconds). Then used this
function to stop the caret from blinking if the last editing command
is a TypingCommand.
* editing/EditCommand.h:
(WebCore::EditCommand::shouldStopCaretBlinking):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::updateAppearance):
* editing/TypingCommand.h:
(WebCore::TypingCommand::shouldStopCaretBlinking):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Fri, 9 Dec 2011 02:00:57 +0000 (02:00 +0000)]
Unreviewed contributor additions to committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 9 Dec 2011 01:59:18 +0000 (01:59 +0000)]
[Chromium] Rebaseline for r102320.
* platform/chromium-cg-mac-leopard/fast/forms/basic-inputs-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/forms/file/file-input-disabled-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/forms/file/file-input-disabled-expected.txt: Added.
* platform/chromium-cg-mac-leopard/fast/forms/input-disabled-color-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/forms/basic-inputs-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/file/file-input-disabled-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
* platform/chromium-cg-mac/fast/forms/file/file-input-disabled-expected.png: Removed.
* platform/chromium-linux-x86/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt.
* platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png:
* platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt:
* platform/chromium-linux/fast/forms/input-disabled-color-expected.png:
* platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/file/file-input-disabled-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/file/file-input-disabled-expected.txt: Added.
* platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/basic-textareas-quirks-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
* platform/chromium-win-vista/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt.
* platform/chromium-win-xp/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt.
* platform/chromium-win/fast/forms/basic-inputs-expected.txt:
* platform/chromium-win/fast/forms/basic-textareas-expected.txt:
* platform/chromium-win/fast/forms/basic-textareas-quirks-expected.txt:
* platform/chromium-win/fast/forms/file/file-input-disabled-expected.png:
* platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
* platform/chromium-win/fast/forms/input-disabled-color-expected.png:
* platform/chromium-win/fast/forms/input-disabled-color-expected.txt:
* platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/chromium/fast/forms/basic-inputs-expected.txt: Added.
* platform/chromium/fast/forms/basic-textareas-expected.txt: Added.
* platform/chromium/fast/forms/basic-textareas-quirks-expected.txt: Added.
* platform/chromium/fast/forms/input-appearance-disabled-expected.txt: Added.
* platform/chromium/fast/forms/input-disabled-color-expected.txt: Added.
* platform/chromium/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
* platform/chromium/fast/forms/placeholder-pseudo-style-expected.txt: Added.
* platform/chromium/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 9 Dec 2011 01:56:59 +0000 (01:56 +0000)]
Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=73964
Reviewed by Darin Adler.
Source/JavaScriptCore:
* wtf/HashTraits.h: Add passOut(std::nullptr_t) to allow callers to use HashMap::take on a HashMap of OwnPtrs.
Source/WebCore:
Re-landing r102267 with a fix for the clang build.
No new tests, refactoring only.
* dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 9 Dec 2011 01:54:06 +0000 (01:54 +0000)]
WebScrollbarPainterDelegate should have a pointer to its Scrollbar
https://bugs.webkit.org/show_bug.cgi?id=74149
Reviewed by Darin Adler.
This is another step towards making the scroll animation code more robust.
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate initWithScrollbar:WebCore::]):
(-[WebScrollbarPainterDelegate scrollAnimator]):
(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Dec 2011 01:46:49 +0000 (01:46 +0000)]
keyboard event doesn't fire while moving mouse with button pressed
https://bugs.webkit.org/show_bug.cgi?id=73821
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-12-08
Reviewed by Alexey Proskuryakov.
Autoscroll should not stop on key press.
Source/WebCore:
Test: fast/events/autoscroll-should-not-stop-on-keypress.html
* page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
Removed the check for autoscroll so that autoscroll is not stopped on
key press and key event is processed.
LayoutTests:
* fast/events/autoscroll-should-not-stop-on-keypress-expected.txt: Added.
* fast/events/autoscroll-should-not-stop-on-keypress.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 9 Dec 2011 01:46:30 +0000 (01:46 +0000)]
Forced compositing mode breaks display of full-page PDFs in WK2
https://bugs.webkit.org/show_bug.cgi?id=74122
<rdar://problem/
9550059>
Reviewed by Dan Bernstein.
Full page PDFs are displayed in WK2 in a subview of the WKView. However,
when the WKView is forced to use accelerated compositing, the layer obscures
the PDF subview.
To fix this we have to drop out of compositing mode when the WKView is showing
a custom representation.
* UIProcess/API/mac/WKView.mm:
(-[WKView _setPageHasCustomRepresentation:]): Tell the drawing area that the view
gained or lost a custom representation.
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::pageCustomRepresentationChanged):
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::pageCustomRepresentationChanged): Send a messgae to the web process
to indicate that the custom representation changed.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::pageCustomRepresentationChanged):
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::pageCustomRepresentationChanged): Enter or exit compositing mode
as appropriate when we gain or lost a custom represenetation.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
* WebProcess/WebPage/DrawingAreaImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102407
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 9 Dec 2011 01:35:25 +0000 (01:35 +0000)]
Add scrollAnimator getter method to WebScrollbarPainterDelegate
https://bugs.webkit.org/show_bug.cgi?id=74146
Reviewed by Beth Dakin.
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate scrollAnimator]):
(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102406
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 9 Dec 2011 01:33:41 +0000 (01:33 +0000)]
Source/WebCore: Improve handling of frame removal during requestAnimationFrame callback invocation
https://bugs.webkit.org/show_bug.cgi?id=74036
Reviewed by Adam Barth.
See bug for details.
Test: fast/animation/request-animation-frame-detach-element.html
* dom/Document.cpp:
(WebCore::Document::removedLastRef):
(WebCore::Document::detach):
* dom/Document.h:
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::~ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::scheduleAnimation):
* dom/ScriptedAnimationController.h:
(WebCore::ScriptedAnimationController::create):
(WebCore::ScriptedAnimationController::clearDocumentPointer):
* page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
LayoutTests: Add some tests for removing frames from the document while servicing requestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=74036
Reviewed by Adam Barth.
* fast/animation/request-animation-frame-detach-element-expected.txt: Added.
* fast/animation/request-animation-frame-detach-element.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Dec 2011 01:31:12 +0000 (01:31 +0000)]
Use bitfield for bool data members in BitmapImage.
https://bugs.webkit.org/show_bug.cgi?id=74102
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2011-12-08
Reviewed by Darin Adler.
Class BitmapImage and FrameData has bool data members, we can use bitfield for those data
members to reduce the BitmapImage's memory footprint.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage):
* platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::BitmapImage):
* platform/graphics/openvg/ImageOpenVG.cpp:
(WebCore::BitmapImage::BitmapImage):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::BitmapImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 9 Dec 2011 01:16:22 +0000 (01:16 +0000)]
Fix a paste-o in ScrollAnimatorMac::updateScrollerStyle
https://bugs.webkit.org/show_bug.cgi?id=74145
Reviewed by Sam Weinig.
Call setHorizontalScrollerImp to set the horizontal scrollbar painter.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Dec 2011 01:13:29 +0000 (01:13 +0000)]
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=74116
Patch by Jacob Goldstein <jacobg@adobe.com> on 2011-12-08
Reviewed by Darin Adler.
* fast/regions/webkit-flow-renderer-expected.html: Added.
* fast/regions/webkit-flow-renderer-layer-expected.html: Added.
* fast/regions/webkit-flow-renderer-nested-expected.html: Added.
* platform/efl/fast/regions/webkit-flow-renderer-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-renderer-expected.txt: Removed.
* platform/efl/fast/regions/webkit-flow-renderer-layer-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
* platform/efl/fast/regions/webkit-flow-renderer-nested-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
* platform/mac/fast/regions/webkit-flow-renderer-expected.png: Removed.
* platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Removed.
* platform/mac/fast/regions/webkit-flow-renderer-layer-expected.png: Removed.
* platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
* platform/mac/fast/regions/webkit-flow-renderer-nested-expected.png: Removed.
* platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 9 Dec 2011 01:11:02 +0000 (01:11 +0000)]
Create one WebScrollbarPainterDelegate for each scrollbar
https://bugs.webkit.org/show_bug.cgi?id=74142
Reviewed by Sam Weinig.
Create and destroy WebScrollbarPainterDelegate objects as scrollbars come and go.
This is a step towards simplifying the WebScrollbarPainterDelegate object.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Dec 2011 01:04:51 +0000 (01:04 +0000)]
[Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
https://bugs.webkit.org/show_bug.cgi?id=74017
Source/WebCore:
Patch by David Reveman <reveman@chromium.org> on 2011-12-08
Reviewed by James Robinson.
Add per-tile drawing to page settings.
No new tests.
* page/Settings.h:
(WebCore::Settings::setPerTileDrawingEnabled):
(WebCore::Settings::perTileDrawingEnabled):
* testing/Internals.cpp:
(WebCore::Internals::setPerTileDrawingEnabled):
* testing/Internals.h:
Source/WebKit/chromium:
Patch by David Reveman <reveman@chromium.org> on 2011-12-08
Reviewed by James Robinson.
Add WebSettings::setAcceleratedPaintingEnabled to public API.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setAcceleratedPaintingEnabled):
(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):
* src/WebSettingsImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
Tools:
Patch by David Reveman <reveman@chromium.org> on 2011-12-08
Reviewed by James Robinson.
Add support for command line flag enable-per-tile-painting in DumpRenderTree.
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setAcceleratedPaintingEnabled):
(TestShell::setPerTilePaintingEnabled):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver._wrapper_options):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Fri, 9 Dec 2011 00:58:48 +0000 (00:58 +0000)]
REGRESSION: Changing disabled state of a textarea does not do a repaint
https://bugs.webkit.org/show_bug.cgi?id=23789
Reviewed by Darin Adler.
The bug got fixed (I did not bisect to find out when) thus landing
the test case converted to a repaint test and made cross-platform.
* fast/repaint/textarea-set-disabled-expected.png: Added.
* fast/repaint/textarea-set-disabled-expected.txt: Added.
* fast/repaint/textarea-set-disabled.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 9 Dec 2011 00:52:01 +0000 (00:52 +0000)]
Add a scrollbarPainterForScrollbar helper function
https://bugs.webkit.org/show_bug.cgi?id=74139
Reviewed by Sam Weinig.
* platform/mac/ScrollAnimatorMac.mm:
(macScrollbarTheme):
(scrollbarPainterForScrollbar):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Dec 2011 00:42:00 +0000 (00:42 +0000)]
[chromium] Move NonCompositedContentHost to WebKit
https://bugs.webkit.org/show_bug.cgi?id=74047
Patch by James Robinson <jamesr@chromium.org> on 2011-12-08
Reviewed by Kenneth Russell.
Source/WebCore:
Updates WebCore.gypi to remove files no longer within WebCore and removes unused forward declaration and include
from LayerRendererChromium.
* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
Source/WebKit/chromium:
Moves NonCompositedContentHost into WebKit/chromium/src. This class is a helper class designed to make it easier
for WebViewImpl to interface with the compositor. The compositor proper should not depend on this class, and
other clients of the compositor do not need this functionality.
Follow-up patches will transition this code from using compositor-internal interfaces directly to using
higher-level interfaces like the WebKit platform APIs. This patch simply does a file mv and updates namespaces
to keep things simpler.
Refactor only and covered by several unit tests.
* WebKit.gyp:
* src/NonCompositedContentHost.cpp: Renamed from Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.cpp.
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::~NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setBackgroundColor):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
(WebKit::NonCompositedContentHost::protectVisibleTileTextures):
(WebKit::NonCompositedContentHost::invalidateRect):
(WebKit::NonCompositedContentHost::notifyAnimationStarted):
(WebKit::NonCompositedContentHost::notifySyncRequired):
(WebKit::NonCompositedContentHost::paintContents):
(WebKit::NonCompositedContentHost::showDebugBorders):
(WebKit::NonCompositedContentHost::showRepaintCounter):
* src/NonCompositedContentHost.h: Renamed from Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.h.
(WebKit::NonCompositedContentHost::create):
(WebKit::NonCompositedContentHost::topLevelRootLayer):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::nonCompositedContentHost):
* src/WebViewImpl.h:
* tests/LayerChromiumTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Dec 2011 00:41:55 +0000 (00:41 +0000)]
Fix fast/css/hover-active-drag.html on Mac
https://bugs.webkit.org/show_bug.cgi?id=74046
Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-12-08
Reviewed by Darin Adler.
* fast/css/hover-active-drag.html:
* platform/chromium/fast/css/hover-active-drag-expected.txt: Removed.
* platform/mac/fast/css/hover-active-drag-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Dec 2011 00:37:47 +0000 (00:37 +0000)]
[chromium] Layer contents scale change should trigger invalidation
https://bugs.webkit.org/show_bug.cgi?id=74086
When the contents scale of a layer is changed, the entire contents of
the layer should be marked dirty.
Patch by Sami Kyostila <skyostil@google.com> on 2011-12-08
Reviewed by James Robinson.
Source/WebCore:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setContentsScale):
Source/WebKit/chromium:
* tests/LayerChromiumTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Fri, 9 Dec 2011 00:22:08 +0000 (00:22 +0000)]
[chromium] Add CSS_FILTERS custom binding file to WebCore.gypi.
https://bugs.webkit.org/show_bug.cgi?id=74091
Reviewed by Adam Barth.
If it builds, you're happy.
* WebCore.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 9 Dec 2011 00:20:39 +0000 (00:20 +0000)]
create a "SystemHost" object for webkitpy to slim down the Host object
https://bugs.webkit.org/show_bug.cgi?id=72680
Reviewed by Eric Siedel.
This creates a SystemHost object that other objects that should
only have dependencies on functionality in webkitpy.common.system
can use; this will allow them to not require a full Host.
* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/common/host_mock.py:
* Scripts/webkitpy/common/system/systemhost.py: Added.
* Scripts/webkitpy/common/system/systemhost_mock.py: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 9 Dec 2011 00:15:26 +0000 (00:15 +0000)]
Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden
https://bugs.webkit.org/show_bug.cgi?id=74126
Reviewed by Tony Chang.
The bug was caused by the code that generated text out of pre-rendered text was generating div's inside the fragment
pasted into textarea even though serialization algorithm in textarea doesn't handle block elements.
Fixed the bug by special-casing this in createFragmentFromText. In the long run, we should really get rid of this
whole pre-rendering trick.
* editing/markup.cpp:
(WebCore::createFragmentFromText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 9 Dec 2011 00:07:10 +0000 (00:07 +0000)]
Moving SVG elements on the page doesn't always erase element at the old position
https://bugs.webkit.org/show_bug.cgi?id=74002
Patch by Florin Malita <fmalita@google.com> on 2011-12-08
Reviewed by Darin Adler.
Source/WebCore:
Test: svg/repaint/container-repaint.svg
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
Save the old repaint bounds before updating the viewport.
LayoutTests:
* svg/repaint/container-repaint-expected.png: Added.
* svg/repaint/container-repaint-expected.txt: Added.
* svg/repaint/container-repaint.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 8 Dec 2011 23:38:27 +0000 (23:38 +0000)]
Mark tests added in r102388 as failing on Chromium. Fix the cross platform
expected results for transitions/svg-transitions.html (the line number changed).
* platform/chromium/test_expectations.txt:
* transitions/svg-transitions-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 23:16:54 +0000 (23:16 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=74005
fix unaligned access memory in generatePatternCharacterOnce function
for SH4 platforms.
Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-12-08
Reviewed by Gavin Barraclough.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load16Unaligned):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16Unaligned):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load16Unaligned):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::lshift32):
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::load16):
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::branch8):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load16Unaligned):
* jit/JIT.h:
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Thu, 8 Dec 2011 23:06:15 +0000 (23:06 +0000)]
Enable animations of CSS images using -webkit-cross-fade
https://bugs.webkit.org/show_bug.cgi?id=74049
<rdar://problem/
10209303>
Reviewed by Simon Fraser.
Add support for animating CSS images in the following properties:
- background(-image)
- border-image(-source)
- list-style(-image)
- -webkit-mask-box-image(-source)
- -webkit-mask-image(-source)
This patch only adds support for transitioning between NinePieceImages
where all of the properties except the image itself are equal, and the
size of the images are equal. Other cases will not animate.
Add animation blend functions for StyleImage and NinePieceImage.
Apply the proper compositing operation to -webkit-cross-fade, and
fix handling of the destination and source areas to support scaling.
Tests: animations/cross-fade-background-image.html
animations/cross-fade-border-image-source.html
animations/cross-fade-list-style-image.html
animations/cross-fade-webkit-mask-box-image.html
animations/cross-fade-webkit-mask-image.html
* css/CSSCrossfadeValue.cpp:
(WebCore::cachedImageForCSSValue):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::image):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::CSSImageValue):
* css/CSSImageValue.h:
(WebCore::CSSImageValue::create):
* page/animation/AnimationBase.cpp:
(WebCore::crossfadeBlend):
(WebCore::blendFunc):
(WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper):
(WebCore::RefCountedPropertyWrapper::blend):
(WebCore::FillLayerRefCountedPropertyWrapper::FillLayerRefCountedPropertyWrapper):
(WebCore::FillLayerRefCountedPropertyWrapper::blend):
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::AnimationBase::ensurePropertyMap):
(WebCore::addShorthandProperties):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
(WebCore::CrossfadeGeneratedImage::draw):
(WebCore::CrossfadeGeneratedImage::drawPattern):
* platform/graphics/CrossfadeGeneratedImage.h:
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setMaskImage):
Add tests of -webkit-animation (using -webkit-cross-fade) between:
- background-image
- border-image
- list-style-image
- -webkit-mask-box-image
- -webkit-mask-image
Add the ability for animation tests to compare an animated element to a static element.
Add tests of -webkit-transition (using -webkit-cross-fade) between:
- background-image
- border-image
* animations/cross-fade-background-image-expected.txt: Added.
* animations/cross-fade-background-image.html: Added.
* animations/cross-fade-border-image-source-expected.txt: Added.
* animations/cross-fade-border-image-source.html: Added.
* animations/cross-fade-list-style-image-expected.txt: Added.
* animations/cross-fade-list-style-image.html: Added.
* animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
* animations/cross-fade-webkit-mask-box-image.html: Added.
* animations/cross-fade-webkit-mask-image-expected.txt: Added.
* animations/cross-fade-webkit-mask-image.html: Added.
* animations/resources/animation-test-helpers.js:
(parseCrossFade):
(checkExpectedValue):
* animations/resources/blue-100.png: Added.
* animations/resources/green-100.png: Added.
* animations/resources/stripes-100.png: Added.
* platform/mac/animations/cross-fade-background-image-expected.png: Added.
* platform/mac/animations/cross-fade-border-image-source-expected.png: Added.
* platform/mac/animations/cross-fade-list-style-image-expected.png: Added.
* platform/mac/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/mac/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/mac/transitions/cross-fade-background-image-expected.png: Added.
* platform/mac/transitions/cross-fade-border-image-expected.png: Added.
* transitions/cross-fade-background-image-expected.txt: Added.
* transitions/cross-fade-background-image.html: Added.
* transitions/cross-fade-border-image-expected.txt: Added.
* transitions/cross-fade-border-image.html: Added.
* transitions/resources/transition-test-helpers.js:
(expected):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 23:00:56 +0000 (23:00 +0000)]
[chromium] Set opaque() for VideoLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=73858
Patch by Dana Jansens <danakj@chromium.org> on 2011-12-08
Reviewed by James Robinson.
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::isVideoFrameFormatOpaque):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Thu, 8 Dec 2011 22:29:39 +0000 (22:29 +0000)]
Use Skia's implementation of Gaussian blur when accelerated filters
are enabled.
https://bugs.webkit.org/show_bug.cgi?id=73949
Reviewed by Zoltan Herczeg.
In the future, this will be covered by the SVG tests run in GPU mode.
* WebCore.gypi:
Add FEGaussianBlurSkia.cpp to the build.
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplySoftware):
Call out to platformApplySkia() when USE_SKIA is enabled.
* platform/graphics/filters/FEGaussianBlur.h:
platformApplySkia() declaration.
* platform/graphics/filters/skia: Added.
* platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Added.
(WebCore::FEGaussianBlur::platformApplySkia):
On the Skia port, use SkBlurImageFilter for drawing
Gaussian blurs in accelerated mode.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyImage):
Implement ImageBuffer::copyImage() with DontCopyBackingStore semantics.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Thu, 8 Dec 2011 22:11:50 +0000 (22:11 +0000)]
Tools: AX: platform/mac/accessibility/search-with-frames.html crashes
https://bugs.webkit.org/show_bug.cgi?id=74093
Reviewed by Darin Adler.
Take care of the case when an incoming element is null.
* DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementForSearchPredicateCallback):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementForSearchPredicate):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
LayoutTests: platform/mac/accessibility/search-with-frames.html crashes
https://bugs.webkit.org/show_bug.cgi?id=74093
Reviewed by Darin Adler.
Unskip the crashing test.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 22:08:51 +0000 (22:08 +0000)]
[Qt] Visualize mock point ID's in the MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=74098
Patch by Alexander Færøy <ahf@0x90.dk> on 2011-12-08
Reviewed by Tor Arne Vestbø.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
* MiniBrowser/qt/qml/MockTouchPoint.qml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Thu, 8 Dec 2011 21:47:42 +0000 (21:47 +0000)]
Add 8 bit paths for StringTypeAdapter classes
https://bugs.webkit.org/show_bug.cgi?id=73882
Reviewed by Darin Adler.
Added is8Bit() method and writeTo(LChar*) methods
to StringTypeAdapter<> classes. The writeTo(LChar*)
method can be used if is8Bit() returns true. The
non-native 8 bit classes contain ASSERT(is8Bit())
in their writeTo(LChar*).
Updated all of the various versions of tryMakeString() to
use 8 bit processing in the updated StringTypeAdapter<>
classes.
This has slight if any performance improvement on kraken.
* runtime/UStringConcatenate.h:
* wtf/text/StringConcatenate.h:
(WTF::tryMakeString):
* wtf/text/StringOperators.h:
(WTF::StringAppend::is8Bit):
(WTF::StringAppend::writeTo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Thu, 8 Dec 2011 21:29:31 +0000 (21:29 +0000)]
CodeGeneratorV8: Fix issue with overloaded static conditional methods
https://bugs.webkit.org/show_bug.cgi?id=74114
Reviewed by Adam Barth.
The code generator was missing checks for Conditional for overloaded methods.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateOverloadedFunctionCallback): Generate needed #ifdefs.
(GenerateFunctionCallback): Ditto.
* bindings/scripts/test/V8/V8TestObj.cpp: Wrap conditional methods with #ifdefs.
(WebCore::ConfigureV8TestObjTemplate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dmazzoni@google.com [Thu, 8 Dec 2011 21:27:16 +0000 (21:27 +0000)]
Source/WebCore: AccessibilityController should support listening to notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866
Changes accessibilitySetShouldRepostNotifications from an instance method
into a class method so that it can be used for global notification listeners,
not just for listeners on a particular object.
Reviewed by Chris Fleizach.
Test: accessibility/notification-listeners.html
* accessibility/mac/WebAccessibilityObjectWrapper.h:
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(+[WebAccessibilityObjectWrapper accessibilitySetShouldRepostNotifications:]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
Tools: Accessibility: AccessibilityController should support listening to notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866
Adds addNotificationListener and removeNotificationListener methods
to AccessibilityController, to listen to notifications on any element
rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
implementations are all contained in this change.
On Mac, refactors AccessibilityNotificationHandler into its own
source file that can be used by both AccessibilityController and
AccessibilityUIElement. (Both DRT and WKTR.)
Reviewed by Chris Fleizach.
* DumpRenderTree/AccessibilityController.cpp:
(addNotificationListenerCallback):
(removeNotificationListenerCallback):
(AccessibilityController::getJSClass):
* DumpRenderTree/AccessibilityController.h:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/chromium/AccessibilityController.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::notificationReceived):
(AccessibilityController::addNotificationListenerCallback):
(AccessibilityController::removeNotificationListenerCallback):
* DumpRenderTree/chromium/AccessibilityController.h:
* DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
* DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::~AccessibilityController):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
* DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
* DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
(-[NSString createJSStringRef]):
(-[AccessibilityNotificationHandler init]):
(-[AccessibilityNotificationHandler setPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler setCallback:]):
(-[AccessibilityNotificationHandler startObserving]):
(-[AccessibilityNotificationHandler _notificationReceived:]):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::addNotificationListener):
* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(notificationListenerProc):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
(AccessibilityController::winNotificationReceived):
(AccessibilityController::winAddNotificationListener):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::addNotificationListener):
* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):
* WebKitTestRunner/InjectedBundle/AccessibilityController.h:
(WTR::AccessibilityController::logAccessibilityEvents):
* WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
(WTR::AccessibilityTextMarker::AccessibilityTextMarker):
* WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
(WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
* WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
* WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
(-[NSString createJSStringRef]):
(-[AccessibilityNotificationHandler init]):
(-[AccessibilityNotificationHandler setPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler setCallback:]):
(-[AccessibilityNotificationHandler startObserving]):
(-[AccessibilityNotificationHandler _notificationReceived:]):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::addNotificationListener):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
LayoutTests: Accessibility: AccessibilityController should support listening to notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866
Previously, the Mac implementation of AccessibilityUIElement.addNotificationListener
incorrectly triggered on notifications from all elements. Now it only triggers on
notifications from the correct element, and a new addNotificationListener method
in AccessibilityController can be used to trigger on notifications from all elements.
Updates 2 tests that depended on the old incorrect behavior.
Reviewed by Chris Fleizach.
* accessibility/notification-listeners.html: Added.
* platform/chromium/accessibility/notification-listeners-expected.txt: Added.
* platform/gtk/Skipped:
* platform/mac/accessibility/aria-expanded-notifications.html:
* platform/mac/accessibility/aria-listbox-selectedchildren-change.html:
* platform/mac/accessibility/notification-listeners-expected.txt: Added.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Thu, 8 Dec 2011 21:23:16 +0000 (21:23 +0000)]
HiDPI: Switching a video element to full screen in HiDPI mode doesn't fit the screen correctly
https://bugs.webkit.org/show_bug.cgi?id=74119
rdar://problem/
10356869
Reviewed by Darin Adler.
Use the Lion-only -[NSWindow convertRectToScreen:] function to convert between window
coordinates and screen coordinates.
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 8 Dec 2011 21:15:29 +0000 (21:15 +0000)]
Web Inspector: Rename createScriptCallStack() without parameters to createScriptCallStackForInspector().
https://bugs.webkit.org/show_bug.cgi?id=74120
Reviewed by Pavel Feldman.
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForInspector):
* bindings/js/ScriptCallStackFactory.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
* bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForInspector):
* bindings/v8/ScriptCallStackFactory.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 8 Dec 2011 21:07:57 +0000 (21:07 +0000)]
[chromium] Remove dead code in compositor
https://bugs.webkit.org/show_bug.cgi?id=74103
Reviewed by James Robinson.
Tested via the compiler.
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 21:05:38 +0000 (21:05 +0000)]
[chromium] Need to adjust memory limit and viewport multipliers.
https://bugs.webkit.org/show_bug.cgi?id=74022
Patch by Eric Penner <epenner@google.com> on 2011-12-08
Reviewed by James Robinson.
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes): Changing constants
(WebCore::TextureManager::reclaimLimitBytes): ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 8 Dec 2011 20:59:19 +0000 (20:59 +0000)]
Chromium DEPS roll 112974 -> 113603
https://bugs.webkit.org/show_bug.cgi?id=74105
Patch by Elliot Poger <epoger@google.com> on 2011-12-08
Reviewed by Adam Barth.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Thu, 8 Dec 2011 20:53:05 +0000 (20:53 +0000)]
Add a platform EventLoop for iOS
https://bugs.webkit.org/show_bug.cgi?id=74043
Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-08
Reviewed by David Kilzer.
* WebCore.xcodeproj/project.pbxproj:
* platform/ios/EventLoopIOS.mm: Added.
(WebCore::EventLoop::cycle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 8 Dec 2011 20:41:30 +0000 (20:41 +0000)]
Web Inspector: return node counts on the document / detached root basis
https://bugs.webkit.org/show_bug.cgi?id=74104
Reviewed by Yury Semikhatsky.
* bindings/js/ScriptProfiler.h:
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::domNodeCount):
* bindings/v8/ScriptProfiler.h:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getDOMNodeCount):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
* inspector/InspectorMemoryAgent.h:
(WebCore::InspectorMemoryAgent::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 8 Dec 2011 20:34:05 +0000 (20:34 +0000)]
[chromium] remove headers from WebKit.gyp that moved into WebKit/chromium/public/platform
https://bugs.webkit.org/show_bug.cgi?id=74106
Reviewed by Darin Fisher.
* WebKit.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 8 Dec 2011 20:29:52 +0000 (20:29 +0000)]
RenderObject: Rename styleSlowCase() to styleInRegion().
Rubber-stamped by David Hyatt.
* WebCore.exp.in:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleInRegion):
* rendering/RenderObject.h:
(WebCore::RenderObject::style):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 8 Dec 2011 20:21:18 +0000 (20:21 +0000)]
[Qt][WK2] Unreviewed buildfix after r102352.
Source/WebKit2:
* DerivedSources.pri:
Tools:
* qmake/mkspecs/features/webkit2.prf:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
peter@chromium.org [Thu, 8 Dec 2011 20:16:29 +0000 (20:16 +0000)]
[Chromium] Exclude the four RenderTableCellDeathTest death tests for Android
https://bugs.webkit.org/show_bug.cgi?id=73997
The ASSERT_DEATH macro is not yet available in Google Test when
building for Android, which causes compilation errors. This code
will be removed once support lands in the GTest version Chromium
uses. See https://bugs.webkit.org/show_bug.cgi?id=74089.
Reviewed by Julien Chaffraix.
* tests/RenderTableCellTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 20:11:57 +0000 (20:11 +0000)]
IndexedDB: WebKit API addition of IDBObjectStore.count() and IDBIndex.count()
https://bugs.webkit.org/show_bug.cgi?id=73685
Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-08
Reviewed by Darin Fisher.
Implementation to follow - this just extends the WebKit API.
* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::count):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::count):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 8 Dec 2011 20:01:12 +0000 (20:01 +0000)]
Optimize RenderObject::containingBlock().
<http://webkit.org/b/74109>
Reviewed by David Hyatt.
When climbing the parent chain to locate the containing block-level element,
use !isRenderBlock() to reject renderers rather than checking against an arbitrary
list of non-block renderers and then rejecting anything that isn't a block anyway.
RenderObject::containingBlock() was very hot (2.0%) when scrolling on youtube.com.
This change takes it down to 1.0% (60% of which is RenderObject::isRenderBlock().)
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nayankk@motorola.com [Thu, 8 Dec 2011 19:39:57 +0000 (19:39 +0000)]
Define DEBUG_GL_COMMANDS only in debug builds.
https://bugs.webkit.org/show_bug.cgi?id=74083
Reviewed by Noam Rosenthal.
No tests added as this change does not affect functionality.
* platform/graphics/opengl/TextureMapperGL.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 8 Dec 2011 19:35:29 +0000 (19:35 +0000)]
Unreviewed. Removed suppressions for inspector extensions tests following a fix in r10231.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 8 Dec 2011 19:32:17 +0000 (19:32 +0000)]
CompositeEditCommand should not be kept alive for undo and redo
https://bugs.webkit.org/show_bug.cgi?id=64414
Reviewed by Enrica Casucci.
This patch introduces EditCommandComposition that replaces CompositeEditCommand for
undo and redo purposes. Furthermore, we now keep a list of commands instead of a tree of commands
to unapply and reapply edit commands that composes an undoable action.
Each top-level CompositeEditCommand holds a ref-pointer to EditCommandComposition,
and applyCommandToComposite adds new SimpleEditCommands to the list.
* editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::create):
(WebCore::EditCommandComposition::doApply): Never used.
(WebCore::EditCommandComposition::doUnapply):
(WebCore::EditCommandComposition::doReapply):
(WebCore::EditCommandComposition::append):
(WebCore::CompositeEditCommand::~CompositeEditCommand): Add an assertion to ensure we didn't create
a composition for CompositeEditCommands that have parents.
(WebCore::CompositeEditCommand::doUnapply): Never used.
(WebCore::CompositeEditCommand::doReapply): Never used.
(WebCore::CompositeEditCommand::ensureComposition): Creates and attaches a EditCommandComposition.
(WebCore::CompositeEditCommand::applyCommandToComposite): Append a SimpleEditCommand to the composition.
* editing/CompositeEditCommand.h:
(WebCore::EditCommandComposition::EditCommandComposition):
(WebCore::CompositeEditCommand::composition):
(WebCore::toEditCommandComposition):
(WebCore::toCompositeEditCommand):
* editing/DeleteButtonController.cpp: Wrap RemoveNodeCommand in RemoveTargetCommand since top level
commands are now required to be a CompositeEditCommand.
(WebCore::RemoveTargetCommand::create):
(WebCore::RemoveTargetCommand::RemoveTargetCommand):
(WebCore::RemoveTargetCommand::doApply):
(WebCore::DeleteButtonController::deleteTarget):
* editing/EditCommand.cpp:
(WebCore::EditCommand::EditCommand): New constructor; used by EditCommandComposition.
(WebCore::EditCommand::apply): Create a composition for a top-level command.
(WebCore::EditCommand::unapply): Since we clear m_parent of SimpleEditCommand as soon as they are
added to EditCommandComposition, we can't use isTopLevelCommand() to differentiate EditCommandComposition
from SimpleEditCommand. Use isEditCommandComposition() instead.
(WebCore::EditCommand::reapply): Ditto.
(WebCore::compositionIfPossible):
(WebCore::EditCommand::setStartingSelection): Update the starting selection of EditCommandComposition.
(WebCore::EditCommand::setEndingSelection): Ditto.
(WebCore::EditCommand::setParent): Accepts a null pointer in order to avoid keeping a stale pointer in
m_parent inside SimpleEditCommand when CompositeEditCommand goes away.
* editing/EditCommand.h:
(WebCore::EditCommand::isSimpleEditCommand):
(WebCore::EditCommand::isCompositeEditCommand):
(WebCore::EditCommand::isEditCommandComposition):
(WebCore::EditCommand::parent):
(WebCore::toSimpleEditCommand):
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing): Register a EditCommandComposition, instead of a CompositeEditCommand
to the undo stack.
(WebCore::Editor::unappliedEditing): Unapplied or reapplied commands are now always EditCommandComposition.
(WebCore::Editor::reappliedEditing):
* editing/Editor.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Thu, 8 Dec 2011 19:25:47 +0000 (19:25 +0000)]
Add missing V8 bindings to get CSS_FILTERS to compile in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=74091
Reviewed by Kenneth Russell.
Will be covered by tests in css3/filters (when enabled).
* bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added.
(WebCore::V8WebKitCSSFilterValue::indexedPropertyGetter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 8 Dec 2011 19:19:05 +0000 (19:19 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=73348
REGRESSION: Assertion when loading a page with a scrollable RenderLayer
-and corresponding-
<rdar://problem/
10518918>
Reviewed by Darin Adler.
The main problem here is that certain delegate calls into AppKit for overlay
scrollbars can cause AppKit to call back into WebKit looking for more information.
The assertion happens when WebKit tells AppKit that the scroll position has
changed during a layout, and AppKit immediately asks WebKit to convert some
coordinates, and WebKit asserts that you shouldn't do that while a layout is still
happening. It's still possible for AppKit to call this delegate method while a
layout is happening, and we should guard against that. This patch, however, does
not do that.
This change instead addresses the reason this assertion started happening much
more frequently recently, which is that it recently became true that
notifyPositionChanged() can be called when the position has not changed. To fix
the assertion AND the bug that that change was intended to fix, we can just make
sure that either the position OR the scroll origin has changed before calling
notifyPositionChanged().
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Call resetScrollOriginChanged() after the scroll instead of before so that we know
whether or not to call notifyPositionChanged().
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 8 Dec 2011 19:16:14 +0000 (19:16 +0000)]
Make finding crash logs by PID work on Snow Leopard
Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
read the first line of the crash log and pull the PID out of there.
Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
Snow Leopard
Reviewed by Darin Adler.
* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
name and PID for the log, rather than checking the Lion-only app_description extended
attribute. We now also reject the log if the process name doesn't match what we expect.
* Scripts/webkitpy/common/system/crashlogs_unittest.py:
(make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
PID.
(CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
(CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
the new make_mock_crash_report_darwin function. Also added tests for files that can't be
read, files that actually contain a crash log for some other process, and files that are
misformatted.
* Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
unused.
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.__init__): Removed xattr support, which is now unused.
(MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
ReadableTextFileObject. This function was completely broken before!
(ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
bugs like the above.
(ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
things like readline() and seek().
(ReadableTextFileObject.close):
(ReadableTextFileObject.read):
Added. We override the superclass implementation to account for using a StringIO object.
(ReadableTextFileObject.readline):
(ReadableTextFileObject.seek):
Added. These just call through to StringIO.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
Changed to use make_mock_crash_report_darwin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 19:12:34 +0000 (19:12 +0000)]
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=73866
Patch by Jacob Goldstein <jacobg@adobe.com> on 2011-12-08
Reviewed by Darin Adler.
* fast/regions/positioned-objects-block-static-in-regions-expected.html: Added.
* fast/regions/positioned-objects-block-static-in-rtl-regions-expected.html: Added.
* fast/regions/positioned-objects-block-static-spanning-regions-expected.html: Added.
* fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.html: Added.
* platform/efl/fast/regions/positioned-objects-block-static-in-regions-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Removed.
* platform/efl/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Removed.
* platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt: Removed.
* platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Thu, 8 Dec 2011 19:06:59 +0000 (19:06 +0000)]
[WK2] Add permissions support (73960)
https://bugs.webkit.org/show_bug.cgi?id=73960
<rdar://problem/
10357008>
Reviewed by Darin Adler.
Source/WebKit2:
* DerivedSources.make: Moved notification files to its own directory. Need to add that path.
* WebKit2.xcodeproj/project.pbxproj: New header and impl files.
* Target.pri: Ditto.
* GNUmakefile.am: Ditto.
* win/WebKit2.vcproj: Ditto.
* win/WebKit2Common.vsprops: Add path to Notifications directory.
Implement permission functions, which go through permission request manager.
* WebProcess/WebCoreSupport/WebNotificationClient.cpp:
(WebKit::WebNotificationClient::requestPermission):
(WebKit::WebNotificationClient::cancelRequestsForPermission):
(WebKit::WebNotificationClient::checkPermission):
New NotificationPermissionRequestManager to make and cancel permission requests, and to retrieve current
policy.
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp: Added.
(WebKit::generateRequestID):
(WebKit::NotificationPermissionRequestManager::create):
(WebKit::NotificationPermissionRequestManager::NotificationPermissionRequestManager):
(WebKit::NotificationPermissionRequestManager::startRequest): Keep track of the provided callback once
policy decision is made.
(WebKit::NotificationPermissionRequestManager::cancelRequest):
(WebKit::NotificationPermissionRequestManager::permissionLevel): Retrieve level through a synchronous
message to the proxy.
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision): Invoke the callback.
* WebProcess/Notifications/NotificationPermissionRequestManager.h: Added.
(WebKit::isRequestIDValid): Make sure any provided request IDs are valid.
Added new NotificationPermissionRequest class.
* UIProcess/Notifications/NotificationPermissionRequest.cpp: Added.
(WebKit::NotificationPermissionRequest::create):
(WebKit::NotificationPermissionRequest::NotificationPermissionRequest):
(WebKit::NotificationPermissionRequest::allow): Notify manager of decision.
(WebKit::NotificationPermissionRequest::deny): Ditto.
(WebKit::NotificationPermissionRequest::invalidate): Disassociate with manager.
(WebKit::NotificationPermissionRequest::type):
* UIProcess/Notifications/NotificationPermissionRequest.h: Added.
WKAPI support for NotificationPermissionRequest:
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKNotificationPermissionRequest.cpp: Added.
(WKNotificationPermissionRequestGetTypeID):
(WKNotificationPermissionRequestAllow):
(WKNotificationPermissionRequestDeny):
* UIProcess/API/C/WKNotificationPermissionRequest.h: Added.
Other additions to WK API:
* UIProcess/API/C/WKNotificationProvider.h: Added new callback for WKNotificationProviders, to return policy
for a given security origin.
* UIProcess/API/C/WKPage.h: Added new callback to WKPageUIClient to ask user to decide on policy.
New NotificationPermissionRequestManagerProxy to create requests.
* UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp: Added.
(WebKit::NotificationPermissionRequestManagerProxy::NotificationPermissionRequestManagerProxy):
(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::NotificationPermissionRequestManagerProxy::createRequest):
(WebKit::NotificationPermissionRequestManagerProxy::didReceiveNotificationPermissionDecision):
* UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h: Added.
Added new message to notification manager: NotificationPermissionLevel, to retrieve policy. The current
JS API retrieves the permission synchronously, so the message needs to be sent synchronously also.
* UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Moved from Source/WebKit2/UIProcess/WebNotificationManagerProxy.messages.in.
* UIProcess/Notifications/WebNotificationProvider.cpp: Moved from Source/WebKit2/UIProcess/WebNotificationProvider.cpp.
(WebKit::WebNotificationProvider::policyForNotificationPermissionAtOrigin): Added.
* UIProcess/Notifications/WebNotificationProvider.h: Moved from Source/WebKit2/UIProcess/WebNotificationProvider.h.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage): Boilerplate to forward messages to notification manager.
* UIProcess/Notifications/WebNotificationManagerProxy.cpp: Moved from Source/WebKit2/UIProcess/WebNotificationManagerProxy.cpp.
(WebKit::WebNotificationManagerProxy::create):
(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):
(WebKit::WebNotificationManagerProxy::invalidate):
(WebKit::WebNotificationManagerProxy::initializeProvider):
(WebKit::WebNotificationManagerProxy::didReceiveMessage):
(WebKit::WebNotificationManagerProxy::didReceiveSyncMessage):
(WebKit::WebNotificationManagerProxy::show):
(WebKit::WebNotificationManagerProxy::cancel):
(WebKit::WebNotificationManagerProxy::didDestroyNotification):
(WebKit::WebNotificationManagerProxy::notificationPermissionLevel): Retrieve the policy from the provider.
(WebKit::WebNotificationManagerProxy::providerDidShowNotification):
(WebKit::WebNotificationManagerProxy::providerDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
* UIProcess/Notifications/WebNotificationManagerProxy.h: Moved from Source/WebKit2/UIProcess/WebNotificationManagerProxy.h.
(WebKit::WebNotificationManagerProxy::clearContext):
(WebKit::WebNotificationManagerProxy::type):
Added NotificationPermissionRequestManagerProxy to WebPageProxy, to allow a request for permission to
go through to the UI client. Added new message to WebPageProxy, RequestNotificationPermission.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close): Invalidate pending requests.
(WebKit::WebPageProxy::processDidCrash): Ditto.
(WebKit::WebPageProxy::requestNotificationPermission): Forward request to UI client.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::decidePolicyForNotificationPermissionRequest):
* UIProcess/WebUIClient.h:
Added new message DidReceiveNotificationPermissionDecision. The WebPage forwards the message to the
permission request manager.
* WebProcess/WebPage/WebPage.messages.in: Added new message DidReceiveNotificationPermissionDecision
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::notificationPermissionRequestManager): Create manager on request.
(WebKit::WebPage::didReceiveNotificationPermissionDecision):
* WebProcess/WebPage/WebPage.h:
Moving files to Notifications/ subdirectory.
* UIProcess/Notifications/WebNotification.cpp: Moved from Source/WebKit2/UIProcess/WebNotification.cpp.
* UIProcess/Notifications/WebNotification.h: Moved from Source/WebKit2/UIProcess/WebNotification.h.
Tools:
Add null function item to comply with added callback to WKPageUIClient.
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 18:55:05 +0000 (18:55 +0000)]
Fixing support for static conditional overloaded functions.
https://bugs.webkit.org/show_bug.cgi?id=74068
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-12-08
Reviewed by Adam Barth.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Pushing "static" keyword after condition "#if".
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::overloadedMethod1): Added newly generated bindings.
* bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
(webkit_dom_test_obj_overloaded_method1):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
* bindings/scripts/test/JS/JSTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
(-[DOMTestObj overloadedMethod1:]):
* bindings/scripts/test/TestObj.idl: Ditto.
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::ConfigureV8TestObjTemplate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 18:53:11 +0000 (18:53 +0000)]
Added a test for css number types problem.
It's testing the css number types parser, where 'px' defined like escape sequences (\70\78) or uppercase / lowercase.
https://bugs.webkit.org/show_bug.cgi?id=72007
Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2011-12-08
Reviewed by Darin Adler.
* fast/css/parsing-css-number-types-expected.txt: Added.
* fast/css/parsing-css-number-types.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 8 Dec 2011 18:50:41 +0000 (18:50 +0000)]
Remove EventListenerMap destructor.
<http://webkit.org/b/74096>
Reviewed by Darin Adler.
Let the compiler generate ~EventListenerMap(). We only needed it when the hash map
was managing raw pointers.
We're losing the no-iterators assertion from clear() by doing this, but that was
superfluous to begin with - we were just using it to avoid duplicating code.
* dom/EventListenerMap.cpp:
* dom/EventListenerMap.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 18:38:53 +0000 (18:38 +0000)]
[Qt] Visualize mock points in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=74074
Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-08
Reviewed by Tor Arne Vestbø.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):
* MiniBrowser/qt/MiniBrowserApplication.h:
* MiniBrowser/qt/icons/touchpoint.png: Added.
* MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 8 Dec 2011 18:23:08 +0000 (18:23 +0000)]
[chromium] Rebaseline printing/width-overflow.html on Chromium Mac Leopard.
* platform/chromium-cg-mac-snowleopard/printing/width-overflow-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/printing/width-overflow-expected.png.
* platform/chromium-linux/printing/width-overflow-expected.txt: Removed.
* platform/chromium-mac-leopard/printing/width-overflow-expected.png: Added.
* platform/chromium-mac-snowleopard/printing/width-overflow-expected.txt: Removed.
* platform/chromium/printing/width-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/printing/width-overflow-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nayankk@motorola.com [Thu, 8 Dec 2011 17:57:30 +0000 (17:57 +0000)]
[WebKit2] Initialize threading in UI process.
https://bugs.webkit.org/show_bug.cgi?id=70127
Reviewed by Anders Carlsson.
* CMakeLists.txt:
* GNUmakefile.am:
* Shared/APIObject.cpp: Added.
(WebKit::APIObject::APIObject):
* Shared/APIObject.h:
* Target.pri:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dmazzoni@google.com [Thu, 8 Dec 2011 16:36:39 +0000 (16:36 +0000)]
Unreviewed, skipping failing test platform/mac/accessibility/search-with-frames.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 16:16:55 +0000 (16:16 +0000)]
[Qt] [WK2] Directly composited images doesn't render
https://bugs.webkit.org/show_bug.cgi?id=74058
Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-08
Reviewed by Noam Rosenthal.
Attach image to WebGraphicsLayer even if layerTreeTileClient is not set
and create/assign remote image tiles later during sync.
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 8 Dec 2011 16:06:52 +0000 (16:06 +0000)]
REGRESSION(r102334): Various Qt WK2 layout tests crash
Reviewed by Tor Arne Vestbø.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState): Add missing null pointer check for the editable
element (scope) before calling innerText.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 8 Dec 2011 15:46:47 +0000 (15:46 +0000)]
[Qt] WebKitTestRunner crashes with debug builds https://bugs.webkit.org/show_bug.cgi?id=74090
Reviewed by Tor Arne Vestbø.
Source/WebKit2:
Export private C++ API style platformInitialize function needed
by low-level WTR.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::platformInitialize):
* UIProcess/API/qt/qquickwebview_p.h:
Tools:
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
to ensure WTF/JSC threading is initialized.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 15:45:39 +0000 (15:45 +0000)]
Provide more specific error description for SocketStreamError.
https://bugs.webkit.org/show_bug.cgi?id=74066
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-08
Reviewed by Martin Robinson.
No new tests because this change just improve error messages for unexpected failures.
* platform/network/soup/SocketStreamError.h: Add an argument for passing error description.
(WebCore::SocketStreamError::SocketStreamError):
* platform/network/soup/SocketStreamHandleSoup.cpp: Add error description for SocketStreamError.
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Thu, 8 Dec 2011 15:32:37 +0000 (15:32 +0000)]
[Qt] Fix non-animated pinch-zoom scale commit.
https://bugs.webkit.org/show_bug.cgi?id=74007
Reviewed by Kenneth Rohde Christiansen.
The update deferrer object was only destroyed at the end of the animation
and wouldn't be if the pinch-zoom was ended within legal bounds.
This patch also makes sure that the deferrer isn't destroyed and re-created
once the animation is started if it was already there.
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
* UIProcess/qt/QtViewportInteractionEngine.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 8 Dec 2011 15:30:29 +0000 (15:30 +0000)]
REGRESSION(r101683): QQuickWebView doesn't work with OpenGL/ES 2.0
https://bugs.webkit.org/show_bug.cgi?id=74077
Reviewed by Kenneth Rohde Christiansen.
Replace Desktop OpenGL idiom of using gl_Vertex with a simple vertex attribute
that's tied to the same register 0 (by being the first in the array).
* UIProcess/API/qt/qquickwebpage.cpp:
(PageProxyMaterialShader::attributeNames): Define "vertex" attribute, which is
bound to register 0, which is the current vertex.
(PageProxyMaterialShader::vertexShader): Use the vertex attribute instead of the
built-in gl_Vertex, which is only present in Desktop GL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Thu, 8 Dec 2011 15:29:13 +0000 (15:29 +0000)]
[Qt] Fix the memory leak of AC layer update message contents on the UI process.
https://bugs.webkit.org/show_bug.cgi?id=74012
Reviewed by Noam Rosenthal.
Since the messages didn't have a virtual destructor, the destructor
of child class members wouldn't be called and would cause the all tile
update buffers, contained in a QImage, to be leaked as well.
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeMessageToRenderer::~LayerTreeMessageToRenderer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 8 Dec 2011 14:50:55 +0000 (14:50 +0000)]
fix build-webkit --chromium after breakage in r102201
https://bugs.webkit.org/show_bug.cgi?id=74031
Reviewed by Tony Chang.
* Scripts/webkitdirs.pm:
(buildChromium):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Thu, 8 Dec 2011 14:27:14 +0000 (14:27 +0000)]
Upsteam the Qt changes to the EditorState https://bugs.webkit.org/show_bug.cgi?id=74080
Reviewed by Simon Hausmann.
We are not doing the serialization manually due to it not being a POD
structure anymore in the case of Qt.
* GNUmakefile.am:
* Shared/EditorState.h:
(WebKit::EditorState::EditorState):
* Target.pri:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihnea@adobe.com [Thu, 8 Dec 2011 14:23:10 +0000 (14:23 +0000)]
[CSSRegions][CSSOM] Implement NamedFlow interface
https://bugs.webkit.org/show_bug.cgi?id=66642
Reviewed by David Hyatt.
Add WebKitNamedFlow to support the NamedFlow interface. No methods are
yet implemented on this interface. The NamedFlow object is a live object.
The first time user asks for it, it gets a valid JS object whose properties
will reflect the changes to the flow thread.
Source/WebCore:
Tests: fast/regions/webkit-named-flow-existing-flow.html
fast/regions/webkit-named-flow-flow-added.html
fast/regions/webkit-named-flow-modified-flow.html
fast/regions/webkit-named-flow-non-existing-flow.html
fast/regions/webkit-named-flow-removed-flow.html
fast/regions/webkit-named-flow-same-object.html
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/gobject/GNUmakefile.am:
* dom/DOMAllInOne.cpp:
* dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
* dom/Document.h:
* dom/Document.idl:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
* dom/WebKitNamedFlow.cpp: Added.
(WebCore::WebKitNamedFlow::WebKitNamedFlow):
(WebCore::WebKitNamedFlow::~WebKitNamedFlow):
* dom/WebKitNamedFlow.h: Added.
(WebCore::WebKitNamedFlow::create):
* dom/WebKitNamedFlow.idl: Added.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::ensureNamedFlow):
* rendering/RenderFlowThread.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/RenderView.cpp:
(WebCore::RenderView::ensureRenderFlowThreadWithName):
* rendering/RenderView.h:
LayoutTests:
* fast/dom/Window/window-properties-expected.txt:
* fast/regions/webkit-named-flow-existing-flow-expected.txt: Added.
* fast/regions/webkit-named-flow-existing-flow.html: Added.
* fast/regions/webkit-named-flow-flow-added-expected.txt: Added.
* fast/regions/webkit-named-flow-flow-added.html: Added.
* fast/regions/webkit-named-flow-modified-flow-expected.txt: Added.
* fast/regions/webkit-named-flow-modified-flow.html: Added.
* fast/regions/webkit-named-flow-non-existing-flow-expected.txt: Added.
* fast/regions/webkit-named-flow-non-existing-flow.html: Added.
* fast/regions/webkit-named-flow-removed-flow-expected.txt: Added.
* fast/regions/webkit-named-flow-removed-flow.html: Added.
* fast/regions/webkit-named-flow-same-object-expected.txt: Added.
* fast/regions/webkit-named-flow-same-object.html: Added.
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/win/fast/dom/Window/window-properties-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 8 Dec 2011 13:04:41 +0000 (13:04 +0000)]
Unreviewed, rolling out r102280.
http://trac.webkit.org/changeset/102280
https://bugs.webkit.org/show_bug.cgi?id=74031
Chromium/Windows build is broken
* Scripts/webkitdirs.pm:
(buildChromium):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 8 Dec 2011 11:52:47 +0000 (11:52 +0000)]
2011-12-08 Gopal Raghavan <gopal.1.raghavan@nokia.com>
[Qt] cleanup qmlplugin
https://bugs.webkit.org/show_bug.cgi?id=73834
Reviewed by Tor Arne Vestbø.
Removed empty folder qmlplugin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 11:24:31 +0000 (11:24 +0000)]
Unreviewed, rolling out r102321.
http://trac.webkit.org/changeset/102321
https://bugs.webkit.org/show_bug.cgi?id=74072
"Breaks all Chromium clobbered builds" (Requested by apavlov_
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main):
* WebCore.gypi:
* bindings/scripts/generate-bindings.pl:
* page/DOMWindow.idl:
* webaudio/DOMWindowWebAudio.idl: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nayankk@motorola.com [Thu, 8 Dec 2011 11:09:24 +0000 (11:09 +0000)]
Adding myself to committers list.
Unreviewed.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 10:46:32 +0000 (10:46 +0000)]
Refactoring: Editor::requestCheckingFor should take SpellCheckRequest object.
https://bugs.webkit.org/show_bug.cgi?id=74033
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-08
Reviewed by Hajime Morita.
SpellChecker::requestCheckingFor takes SpellCheckRequest object in order to make it easy to
pass necessary information to requestCheckingFor.
No new tests. Covered by existing tests.
* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
Uses the new interface.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
* editing/SpellChecker.cpp:
(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::~SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
Creates a new SpellCheckRequest object.
(WebCore::SpellChecker::requestCheckingFor):
Uses the new interface.
(WebCore::SpellChecker::didCheck):
* editing/SpellChecker.h:
(WebCore::SpellCheckRequest::setSequence):
(WebCore::SpellCheckRequest::sequence):
(WebCore::SpellCheckRequest::checkingRange):
(WebCore::SpellCheckRequest::paragraphRange):
(WebCore::SpellCheckRequest::text):
(WebCore::SpellCheckRequest::mask):
(WebCore::SpellCheckRequest::rootEditableElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 10:44:51 +0000 (10:44 +0000)]
Fix failed layout test, bufferedAmount-after-close-in-busy.html
https://bugs.webkit.org/show_bug.cgi?id=73666
Originally the failed layout test use simple_wsh server side WebSocket
handler. But this handler starts closing handshake after a while and
it bring flakiness on the test.
Now the test use echo_wsh instead of simple_wsh. It never perform
server initiated closing handshake.
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-08
Reviewed by Kent Tamura.
* http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Thu, 8 Dec 2011 10:37:07 +0000 (10:37 +0000)]
Unreviewed gardening.
Remove duplicated entries from skipped list.
* platform/qt-5.0/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 8 Dec 2011 10:26:37 +0000 (10:26 +0000)]
[WK2] Unreviewed gardening.
WebKitTestRunner needs layoutTestController.setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=42689
* platform/wk2/Skipped: Skip new failing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 10:12:22 +0000 (10:12 +0000)]
Unreviewed, rolling out r102323.
http://trac.webkit.org/changeset/102323
https://bugs.webkit.org/show_bug.cgi?id=74069
Caused Chromium and GTK build failure (Requested by bashi on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08
.:
* Source/autotools/symbols.filter:
Source/WebCore:
* testing/Internals.cpp:
(WebCore::Internals::getPageScaleFactor):
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
* compositing/geometry/fixed-position-composited-page-scale-down.html:
* compositing/geometry/fixed-position-composited-page-scale.html:
* compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
* compositing/geometry/fixed-position-iframe-composited-page-scale.html:
* compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
* compositing/geometry/fixed-position-transform-composited-page-scale.html:
* compositing/scaling/tiled-layer-recursion.html:
* fast/dom/Element/scale-page-bounding-client-rect.html:
* fast/dom/Element/scale-page-client-rects.html:
* fast/dom/Range/scale-page-bounding-client-rect.html:
* fast/dom/Range/scale-page-client-rects.html:
* fast/events/scale-and-scroll-body.html:
* fast/events/scale-and-scroll-iframe-body.html:
* fast/events/scale-and-scroll-iframe-window.html:
* fast/events/scale-and-scroll-window.html:
* fast/events/script-tests/page-scaled-mouse-click-iframe.js:
(iframeLoaded):
* fast/events/script-tests/page-scaled-mouse-click.js:
* fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
* fast/events/touch/page-scaled-touch-gesture-click.html:
* fast/frames/frame-set-rotation-hit.html:
* fast/frames/frame-set-scaling-hit.html:
* fast/frames/iframe-double-scale-contents.html:
* fast/repaint/background-scaling.html:
* fast/repaint/scale-page-shrink.html:
* fast/transforms/selection-bounds-in-transformed-view.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fsamuel@chromium.org [Thu, 8 Dec 2011 09:18:01 +0000 (09:18 +0000)]
Move scalePageBy from eventSender to window.internals
https://bugs.webkit.org/show_bug.cgi?id=64512
Reviewed by Simon Fraser.
.:
* Source/autotools/symbols.filter:
Source/WebCore:
Added setPageScaleFactor to window.internals.
Renamed window.internals.getPageScaleFactor to window.internals.pageScaleFactor
to match the webkit style.
* testing/Internals.cpp:
(WebCore::Internals::pageScaleFactor):
(WebCore::Internals::setPageScaleFactor):
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
Updated layout tests to use window.internals.setPageScaleFactor.
* compositing/geometry/fixed-position-composited-page-scale-down.html:
* compositing/geometry/fixed-position-composited-page-scale.html:
* compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
* compositing/geometry/fixed-position-iframe-composited-page-scale.html:
* compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
* compositing/geometry/fixed-position-transform-composited-page-scale.html:
* compositing/scaling/tiled-layer-recursion.html:
* fast/dom/Element/scale-page-bounding-client-rect.html:
* fast/dom/Element/scale-page-client-rects.html:
* fast/dom/Range/scale-page-bounding-client-rect.html:
* fast/dom/Range/scale-page-client-rects.html:
* fast/events/scale-and-scroll-body.html:
* fast/events/scale-and-scroll-iframe-body.html:
* fast/events/scale-and-scroll-iframe-window.html:
* fast/events/scale-and-scroll-window.html:
* fast/events/script-tests/page-scaled-mouse-click-iframe.js:
(iframeLoaded):
* fast/events/script-tests/page-scaled-mouse-click.js:
* fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
* fast/events/touch/page-scaled-touch-gesture-click.html:
* fast/frames/frame-set-rotation-hit.html:
* fast/frames/frame-set-scaling-hit.html:
* fast/frames/iframe-double-scale-contents.html:
* fast/repaint/background-scaling.html:
* fast/repaint/scale-page-shrink.html:
* fast/transforms/selection-bounds-in-transformed-view.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Thu, 8 Dec 2011 08:48:36 +0000 (08:48 +0000)]
Unreviewed, remove duplicate test expectations.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 8 Dec 2011 08:20:25 +0000 (08:20 +0000)]
Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394
Reviewed by Adam Barth.
- Overview: Using the [Supplemental] IDL, this patch moves the attribute
declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).
- This patch changes the build flow of WebCore.gyp as follows:
Previous build flow:
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;
}
New build flow (See the discussions in bug 72138 for more details):
resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;
}
- This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL
will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:
In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.
This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:
- DerivedSources.make
- DerivedSources.pri
- GNUmakefile.am
- PlatformBlackBerry.cmake
- UseJSC.cmake
- UseV8.cmake
- WebCore.vcproj/MigrateScripts
- WebCore.vcproj/WebCore.vcproj
- bindings/gobject/GNUmakefile.am
- WebCore.gyp/WebCore.gyp
Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:
DOMWindowWebAudio.idl:
interface [
Supplemental=DOMWindow
] DOMWindowWebAudio {
attribute attr1;
attribute attr2;
};
DOMWindow.idl:
interface [
] DOMWindow {
attribute [Supplemented] attr1; // This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2; // This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;
};
Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:
- If a given build script supports the [Supplemental] IDL,
generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
- Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL
as normal attributes and instead ignores all attributes with the [Supplemental] IDL
(i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).
Tests: webaudio/*
* WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command.
* WebCore.gypi: Added DOMWindowWebAudio.idl.
* bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
* page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
* webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 07:53:01 +0000 (07:53 +0000)]
CSS color gets adjusted for disabled input elements
https://bugs.webkit.org/show_bug.cgi?id=54643
Patch by Yosifumi Inoue <yosin@chromium.org> on 2011-12-07
Reviewed by Kent Tamura.
Source/WebCore:
No new tests. covered by existing tests. Need rebasing some existing tests for Chromimum.
Remove automatic color adjustment for disabled text control for Chromimum.
* css/themeChromium.css: Add CSS entries for default style for disabled input and textarea elements.
* WebCore/rendering/RenderTextControl.cpp:
(disabledTextColor): Removed for PLATFORM(CHROMIUM)
(RenderTextControl::adjustInnerTextStyle): Don't call disabledTextColor for Chromium.
LayoutTests:
* platform/chromium/test_expectations.txt: Add files need to be updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 8 Dec 2011 07:33:51 +0000 (07:33 +0000)]
Fix the 32-bit build.
Ignore some warnings that only occur in 32-bit.
Source/WebKit/mac:
* Plugins/WebNetscapePluginPackage.mm:
Source/WebKit2:
* PluginProcess/mac/PluginProcessShim.mm:
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 8 Dec 2011 07:31:08 +0000 (07:31 +0000)]
[Qt] Unreviewed buildfix after r102262.
* Api/qwebelement.cpp:
(QWebElement::setStyleProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dslomov@google.com [Thu, 8 Dec 2011 06:59:10 +0000 (06:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=74038
[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.
Reviewed by David Levin.
Source/WebCore:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::isLegacyTargetOriginDesignation):
(WebCore::handlePostMessageCallback):
LayoutTests:
* fast/dom/Window/window-postmessage-args-expected.txt:
* fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Thu, 8 Dec 2011 06:50:01 +0000 (06:50 +0000)]
Unreviewed, rebaseline media/controls-layout-direction.html
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-07
* platform/chromium-cg-mac-snowleopard/media/controls-layout-direction-expected.png: Added.
* platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png: Added.
* platform/chromium-win/media/controls-layout-direction-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Thu, 8 Dec 2011 06:29:05 +0000 (06:29 +0000)]
Unreviewed chromium test expectation update.
Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-07
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Dec 2011 06:01:08 +0000 (06:01 +0000)]
Upstream 4 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=73541
Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-07
Reviewed by Antonio Gomes.
Initial upstream of BlackBerry porting of PlatformScreen/
SSLKeyGenerator/Sound/Widget, no new tests.
* PlatformBlackBerry.cmake: Modified to remove empty file "WheelEventBlackBerry.cpp"
* platform/blackberry/PlatformScreenBlackBerry.cpp: Added.
(WebCore::screenIsMonochrome):
(WebCore::screenDepthPerComponent):
(WebCore::screenDepth):
(WebCore::screenAvailableRect):
(WebCore::screenRect):
* platform/blackberry/SSLKeyGeneratorBlackBerry.cpp: Added.
(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):
* platform/blackberry/SoundBlackBerry.cpp: Added.
(WebCore::systemBeep):
* platform/blackberry/WidgetBlackBerry.cpp: Added.
(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::hide):
(WebCore::Widget::paint):
(WebCore::Widget::setCursor):
(WebCore::Widget::setFocus):
(WebCore::Widget::setFrameRect):
(WebCore::Widget::setIsSelected):
(WebCore::Widget::show):
(WebCore::Widget::frameRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Thu, 8 Dec 2011 05:38:26 +0000 (05:38 +0000)]
Refactor CSSParser::parseFontFaceSrc()
https://bugs.webkit.org/show_bug.cgi?id=73989
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/css/font-face-src-parsing.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceSrcURI): Added.
(WebCore::CSSParser::parseFontFaceSrcLocal): Added.
(WebCore::CSSParser::parseFontFaceSrc): Rewrote.
* css/CSSParser.h:
LayoutTests:
Added a test that checks parsing result of the src descriptor of @font-face.
* fast/css/font-face-src-parsing-expected.txt: Added.
* fast/css/font-face-src-parsing.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc