Fix non-Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-06  Ariya Hidayat  <ariya.hidayat@trolltech.com>

       Fix non-Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-06  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Darin. Landed by Cameron.

        Bug 20272: typo in JavaScriptCore
        <https://bugs.webkit.org/show_bug.cgi?id=20272>

        Correct the documentation for op_not. (typo)
        Fix #undef. (typo)

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-06  Cameron Zwarich  <cwzwarich@webkit.org>

        Reviewed by Maciej.

        Bug 20286: Load constants all at once instead of using op_load
        <https://bugs.webkit.org/show_bug.cgi?id=20286>

        Load constants all at once into temporary registers instead of using
        individual instances of op_load.

        This is a 2.6% speedup on SunSpider.

        JavaScriptCore:

        * JavaScriptCore.exp:
        * VM/CodeBlock.cpp:
        (KJS::CodeBlock::dump):
        (KJS::CodeBlock::mark):
        * VM/CodeBlock.h:
        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::CodeGenerator):
        (KJS::CodeGenerator::newTemporary):
        (KJS::CodeGenerator::addConstant):
        (KJS::CodeGenerator::addUnexpectedConstant):
        (KJS::CodeGenerator::emitLoad):
        (KJS::CodeGenerator::emitUnexpectedLoad):
        (KJS::CodeGenerator::emitNewError):
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (KJS::slideRegisterWindowForCall):
        (KJS::Machine::unwindCallFrame):
        (KJS::Machine::throwException):
        (KJS::Machine::execute):
        (KJS::Machine::privateExecute):
        * VM/Machine.h:
        * VM/Opcode.h:
        * VM/RegisterID.h:
        (KJS::RegisterID::RegisterID):
        (KJS::RegisterID::makeConstant):
        (KJS::RegisterID::isTemporary):
        * kjs/NodeInfo.h:
        * kjs/Parser.cpp:
        (KJS::Parser::didFinishParsing):
        * kjs/Parser.h:
        (KJS::Parser::parse):
        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (KJS::NullNode::emitCode):
        (KJS::BooleanNode::emitCode):
        (KJS::NumberNode::emitCode):
        (KJS::StringNode::emitCode):
        (KJS::ArrayNode::emitCode):
        (KJS::DeleteResolveNode::emitCode):
        (KJS::DeleteValueNode::emitCode):
        (KJS::VoidNode::emitCode):
        (KJS::ConstDeclNode::emitCodeSingle):
        (KJS::ReturnNode::emitCode):
        (KJS::ScopeNode::ScopeNode):
        (KJS::ProgramNode::ProgramNode):
        (KJS::ProgramNode::create):
        (KJS::EvalNode::EvalNode):
        (KJS::EvalNode::create):
        (KJS::FunctionBodyNode::FunctionBodyNode):
        (KJS::FunctionBodyNode::create):
        (KJS::FunctionBodyNode::emitCode):
        * kjs/nodes.h:
        (KJS::ScopeNode::neededConstants):

        LayoutTests:

        * fast/js/constant-count-expected.txt: Added.
        * fast/js/constant-count.html: Added.
        * fast/js/deep-recursion-test.html:
        * fast/js/resources/constant-count.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Build fix only, no review.

        Attempt to fix the Windows and Qt builds.

        * bindings/js/ScriptControllerWin.cpp: add runtime.h include
        * bindings/js/ScriptControllerQt.cpp: add QWidget include
        * page/win/FrameWin.cpp: remove bogus using namespace
        * plugins/PluginView.cpp:
        (WebCore::PluginView::bindingInstance): use script()
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::getValue): use script()
        (WebCore::PluginView::~PluginView): use script()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Build fix only, no review.

        Attempt to fix the Linux and --no-svg builds.

        * bindings/js/ScriptController.h: wrap RetainPtr include in PLATFORM(MAC)
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): add missing CSSProperties to switch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Cameron Zwarich.

        Move more methods from Frame into ScriptController
        https://bugs.webkit.org/show_bug.cgi?id=20294

        Finally finish more of the work which Darin started long ago
        Move a few more Frame methods into ScriptController.
        I also took this opportunity to clean up some of the plugin
        code as well, and moved some of that into ScriptController.

        I removed Frame::clearScriptController() and ScriptController::clear() is now clearWindowShell()

        No functional changes, thus no test cases.

        * GNUmakefile.am:
        * WebCore.NPAPI.exp:
        * WebCore.base.exp:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::~ScriptController):
        (WebCore::ScriptController::bindingRootObject):
        (WebCore::ScriptController::createRootObject):
        (WebCore::ScriptController::windowScriptNPObject):
        (WebCore::ScriptController::createScriptObjectForPluginElement): New method.
        (WebCore::ScriptController::clearPlatformScriptObjects):
        (WebCore::ScriptController::disconnectPlatformScriptObjects):
        (WebCore::ScriptController::cleanupScriptObjectsForPlugin):
        (WebCore::ScriptController::clearScriptObjects):
        * bindings/js/ScriptController.h:
        (WebCore::ScriptController::sourceURL):
        (WebCore::ScriptController::clearFormerWindow):
        * bindings/js/ScriptControllerGtk.cpp: Copied from WebCore/page/gtk/FrameGtk.cpp.
        (WebCore::Frame::createScriptInstanceForWidget):
        * bindings/js/ScriptControllerMac.mm: Added.
        (WebCore::ScriptController::createScriptInstanceForWidget):
        (WebCore::ScriptController::windowScriptObject):
        (WebCore::ScriptController::clearPlatformScriptObjects):
        (WebCore::ScriptController::disconnectPlatformScriptObjects):
        (WebCore::updateRenderingForBindings):
        (WebCore::ScriptController::initJavaJSBindings):
        * bindings/js/ScriptControllerQt.cpp: Copied from WebCore/page/gtk/FrameGtk.cpp.
        (WebCore::ScriptController::createScriptInstanceForWidget):
        * bindings/js/ScriptControllerWin.cpp: Copied from WebCore/svg/graphics/cg/SVGResourceMaskerCg.cpp.
        (WebCore::ScriptController::createScriptInstanceForWidget):
        * bindings/objc/DOM.mm:
        (-[DOMNode KJS::Bindings::]):
        * bindings/objc/DOMInternal.mm:
        (-[WebScriptObject _initializeScriptDOMNodeImp]):
        * bridge/jni/jni_jsobject.mm:
        (createRootObject):
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
        * html/HTMLAppletElement.h:
        * html/HTMLEmbedElement.cpp:
        (WebCore::findWidgetRenderer):
        (WebCore::HTMLEmbedElement::renderWidgetForJSBindings):
        * html/HTMLEmbedElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::~HTMLObjectElement):
        (WebCore::HTMLObjectElement::renderWidgetForJSBindings):
        (WebCore::HTMLObjectElement::detach):
        * html/HTMLObjectElement.h:
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
        (WebCore::HTMLPlugInElement::detach):
        (WebCore::HTMLPlugInElement::getInstance):
        (WebCore::HTMLPlugInElement::parseMappedAttribute):
        (WebCore::HTMLPlugInElement::getNPObject):
        * html/HTMLPlugInElement.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::clear):
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        (WebCore::Frame::~Frame):
        (WebCore::Frame::pageDestroyed):
        (WebCore::FramePrivate::FramePrivate):
        * page/Frame.h:
        * page/FramePrivate.h:
        * page/gtk/FrameGtk.cpp:
        * page/mac/FrameMac.mm:
        * page/qt/FrameQt.cpp:
        * page/win/FrameWin.cpp:
        (WebCore::computePageRectsForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Cameron Zwarich.

        Speculative fix for an error I keep seeing in my Cygwin build

        * Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Mark Rowe.

        - fix an assertion failure in Cache::setCapacities()

        * Misc/WebKitSystemBits.h: Changed the return type of WebMemorySize()
        to uint64_t.
        * Misc/WebKitSystemBits.m:
        (WebMemorySize):
        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Steve Falkenburg  <sfalken@apple.com>

        Fix last timer fix.
        Add null check, clear timer using InterlockedExchange.

        Reviewed by Alice Liu.

        * platform/win/SharedTimerWin.cpp:
        (WebCore::clearTimer):
        (WebCore::queueTimerProc):
        (WebCore::stopSharedTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron.

        - add fast path for immediates to % operator, as we have for many other math ops

        This fixes handling for a 0 divisor relative to the last patch. Only an 0.2% speedup on SunSpider but
        still a 1.4x win on Oliver's prime test.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Steve Falkenburg  <sfalken@apple.com>

        Fix timer leak, flag.

        Timers need to be deleted explicitly, even if they fire.
        Also added WT_EXECUTEONLYONCE flag, since this is not a repeating timer.

        Reviewed by Ada Chan.

        * platform/win/SharedTimerWin.cpp:
        (WebCore::queueTimerProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 20293: Crash in JavaScript codegen for eval("const a;")
        <https://bugs.webkit.org/show_bug.cgi?id=20293>

        Correctly handle constant declarations in eval code with no initializer.

        JavaScriptCore:

        * kjs/nodes.cpp:
        (KJS::ConstDeclNode::emitCodeSingle):

        LayoutTests:

        * fast/js/const-expected.txt:
        * fast/js/resources/const.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Anders Carlsson  <andersca@apple.com>

        Pass in the correct class here.

        * WebView/WebResource.mm:
        (-[WebResourcePrivate dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

2008-08-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        <rdar://problem/6037398>
        ER: Deallocate WebKit objects on the main thread, even if released on secondary thread

        Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.

        * bindings/objc/DOMRGBColor.mm:
        (-[DOMRGBColor dealloc]):
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject dealloc]):
        * platform/mac/SharedBufferMac.mm:
        (-[WebCoreSharedBufferData dealloc]):

WebKit/mac:

2008-08-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        <rdar://problem/6037398>
        ER: Deallocate WebKit objects on the main thread, even if released on secondary thread

        Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.

        * Carbon/CarbonWindowAdapter.m:
        (-[CarbonWindowAdapter dealloc]):
        * History/WebBackForwardList.mm:
        (-[WebBackForwardList dealloc]):
        * History/WebHistoryItem.mm:
        (-[WebHistoryItem dealloc]):
        * Misc/WebElementDictionary.mm:
        (+[WebElementDictionary initialize]):
        (-[WebElementDictionary dealloc]):
        * WebCoreSupport/WebEditorClient.mm:
        (-[WebEditCommand dealloc]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebArchive.mm:
        (-[WebArchivePrivate dealloc]):
        * WebView/WebDataSource.mm:
        (-[WebDataSourcePrivate dealloc]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLView dealloc]):
        * WebView/WebResource.mm:
        (-[WebResourcePrivate dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

../../../../../../WebCore:

2008-08-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Move the main thread deallocator here from WebKit.

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/mac/WebCoreObjCExtras.c:
        (method_getImplementation):
        (deallocCallback):
        (WebCoreObjCScheduleDeallocateOnMainThread):
        * platform/mac/WebCoreObjCExtras.h:

../../../../../../WebKit:

2008-08-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Remove MainThreadObjectDeallocator.{h|mm}.

        * WebKit.xcodeproj/project.pbxproj:

../../../../../../WebKit/mac:

2008-08-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Remove MainThreadObjectDeallocator.{h|mm}.

        * WebView/MainThreadObjectDeallocator.h: Removed.
        * WebView/MainThreadObjectDeallocator.mm: Removed.

        * WebView/WebView.mm:
        (-[WebView dealloc]):
        Call WebCoreObjCScheduleDeallocateOnMainThread instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Parse CSS Animations, including the new
-webkit-animation properties and the @-webkit-keyframes rule.
Adds some new interfaces for the style rules.

https://bugs.webkit.org/show_bug.cgi?id=20088

Reviewed by David Hyatt.

* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
    build config for new files
* css/tokenizer.flex:
* css/CSSGrammar.y:
* css/CSSParser.cpp:
* css/CSSParser.h:
    new @-webkit-keyframes parsing
* css/CSSPropertyNames.in:
    -webkit-animation properties
* css/CSSRule.h:
* css/CSSStyleSelector.cpp:
* css/CSSStyleSelector.h:
* css/CSSValueKeywords.in:
* css/StyleBase.h:
* css/WebKitCSSKeyframeRule.cpp: Added.
* css/WebKitCSSKeyframeRule.h: Added.
* css/WebKitCSSKeyframesRule.cpp: Added.
* css/WebKitCSSKeyframesRule.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Make the main thread object deallocator work with subclasses.

        * WebView/MainThreadObjectDeallocator.h:
        * WebView/MainThreadObjectDeallocator.mm:
        (deallocCallback):
        Call the correct dealloc method.

        (scheduleDeallocateOnMainThread):
        Store both the class and the instance, so we know which dealloc method to call.

        * WebView/WebView.mm:
        (-[WebViewPrivate dealloc]):
        Schedule deallocation on the main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Add a getter for CFURLRequestRef in WebMutableURLRequest.

        Reviewed by Anders Carlsson.

        * Interfaces/IWebMutableURLRequestPrivate.idl:
        * WebMutableURLRequest.cpp:
        (WebMutableURLRequest::cfRequest):
        * WebMutableURLRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        - LayoutTests fix.  Log only to the Inspector because other listeners may not want
        XHR notifications, including DRT and the numerous tests that don't expect them.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didFinishLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Makes DOM attribute editing start on double-click to match the styles
        pane. Links in attributes are now triggered with a single click again.

        https://bugs.webkit.org/show_bug.cgi?id=20281

        Reviewed by Adam Roben.

        * English.lproj/localizedStrings.js: Removed some strings.
        * page/inspector/ElementsPanel.js:
        (WebInspector.DOMNodeTreeElement.prototype.onattach): Call
        _preventFollowingLinksOnDoubleClick.
        (WebInspector.DOMNodeTreeElement.prototype._preventFollowingLinksOnDoubleClick):
        Renamed from _makeURLsActivateOnModifiedClick. Simply sets the
        preventFollowOnDoubleClick property on all links.
        (WebInspector.DOMNodeTreeElement.prototype.onselect): Removed
        _selectedByCurrentMouseDown.
        (WebInspector.DOMNodeTreeElement.prototype.onmousedown): Moved
        editing code to ondblclick.
        (WebInspector.DOMNodeTreeElement.prototype.ondblclick): Calls
        _startEditing. Removed URL check.
        (WebInspector.DOMNodeTreeElement.prototype._updateTitle): Calls
        _preventFollowingLinksOnDoubleClick.
        * page/inspector/inspector.css:
        (.editing): Removed the text-decoration property.
        (.editing, .editing *): Added the text-decoration property here
        so it removes underlines on child elements.
        * page/inspector/inspector.js:
        (WebInspector.documentClick): Removed the followOnAltClick code.
        Added support for preventFollowOnDoubleClick, which sets a timeout
        on the first click where future clicks will cancel it (double click).
        If the timeout isn't canceled, the link is followed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6112219> Video in standalone media document flashes when navigating away

        When navigating out from a page, MediaPlayer was set invisible and then immediately
        made visible again causing flicker in some cases.

        The document is not yet marked being in page cache when willSaveToCache() is called.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::willSaveToCache):
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::updatePlayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    - fix typo

        * page/mac/FrameMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Mark Rowe and Anders Carlsson.

        - fix WebMemorySize() reporting a value capped at 2GB

        * misc/WebKitSystemBits.m:
        (WebMemorySize): Changed to return the max_mem field, which, unlike
        memory_size, is not capped at 2GB.
        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]): Made the cache sizes for over 2GB RAM the
        same as for 2GB, so that behavior on machines that have more than 2GB
        RAM is not affected by the fix to WebMemorySize().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    - try to fix the 64-bit build

        * page/mac/FrameMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Alp Toker  <alp@nuanti.com>

        Remove leftover mark pragma from r35568 to fix compiler warning spew.

        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=19045
        [gtk] ./configure doesn't check for x toolkit availability

        Check for the .pc file for Xt instead of hard coding -lXt in the
        GNUmakefile.am.

        Thanks to Dominik Röttsches for the initial patch.

        * GNUmakefile.am:
        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Kevin McCullough  <kmccullough@apple.com>

        - Added a test that checks for several edge cases (see description in
        test.

        * manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Dave Hyatt

Add support for CSS Animation properties to RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=20068

(also fix some minor whitespace issues and remove debugging code)

* css/CSSComputedStyleDeclaration.cpp:
* css/CSSStyleSelector.cpp:
* page/AnimationController.cpp:
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Kevin McCullough  <kmccullough@apple.com>

        - Updated a manual test to be an accurate description of what it is
        actually testing.

        * manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Steve Falkenburg  <sfalken@apple.com>

        Don't invalidate a WebView in the process of being closed when prefs change.

        Reviewed by Ada Chan.

        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/5732836> XMLHttpRequest: Inspector should show network
        activity/XHR in Console (17233)

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didFinishLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix the ChangeLog that was corrupted by r34545.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Makes the selection surround just the name or value that was
        double clicked when editing CSS properties. This regressed when
        the Inspector started using focus/blur events, since a focus on
        a content editable region changes the selection.

        https://bugs.webkit.org/show_bug.cgi?id=20280

        Reviewed by Adam Roben.

        * page/inspector/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.startEditing):
        Change the selection after calling WebInspector.startEditing,
        since WebInspector.startEditing will set an initial selection
        due to a focus event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Changes the editing behavior in the Inspector to commit changes
        when focus is lost, instead of reverting the changes.

        https://bugs.webkit.org/show_bug.cgi?id=20279

        Reviewed by Adam Roben.

        * page/inspector/inspector.js:
        (WebInspector.startEditing): Call editingCommitted in blurEventListener
        instead of editingCancelled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Adds the ability to increment/decrement numbers in editable style
        properties with the arrow and page keys.

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=20273

        * page/inspector/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.updateAll):
        Updates all properties in the current section, or all sections
        depending in the argument passed.
        (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
        Call updateAll instead of having duplicate code.
        (WebInspector.StylePropertyTreeElement.prototype.startEditing):
        Assign the list element's handleKeyEvent to editingKeyDown.
        (WebInspector.StylePropertyTreeElement.prototype.editingKeyDown):
        Handles the Up and Down arrows keys. Finds the word based on the
        selection and extracts the number, prefix and suffix. Increments
        or decrements the number based on the key and modifiers. Replaces
        the original word with the new value and selects it. Also applies
        the style so the page reflects the changes live.
        (WebInspector.StylePropertyTreeElement.prototype.editingEnded):
        Delete the handleKeyEvent and originalCSSText properties.
        (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
        If originalCSSText exists, set the cssText to that value and call
        updateAll. Otherwise just call updateTitle like before.
        (WebInspector.StylePropertyTreeElement.prototype.editingCommitted):
        Factored out the style applying code to applyStyleText.
        (WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
        Factored out from editingCommitted. Takes an argument that specifies
        if the interface should be updated when the style is applied.
        * page/inspector/inspector.js:
        (WebInspector.startEditing): Call the original key handler, if one
        existed before interrupting key events.
        * page/inspector/utilities.js:
        (getStyleTextWithShorthands): Helper to return CSS text that preserves
        shorthand values, since the cssText property only outputs longhands.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Factors out the TextPrompt.scanBackwards function into a generic
        helper function on the Node prototype, named rangeOfWord.

        Reviewed by Adam Roben.

        * page/inspector/Console.js:
        (WebInspector.Console.prototype.completions): Use rangeOfWord.
        * page/inspector/TextPrompt.js:
        (WebInspector.TextPrompt.prototype.complete): Ditto.
        (WebInspector.TextPrompt.prototype.scanBackwards): Removed.
        * page/inspector/utilities.js:
        (Node.prototype.rangeOfWord): Added. Copied from TextPrompt.scanBackwards,
        and added a direction argument allowing scanning forward, backward or
        both directions from the offset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Fixes a bug where the property toggle button would not be hidden
        during editing.

        Reviewed by Adam Roben.

        * page/inspector/inspector.css:
        (li.editing .swatch, li.editing .enabled-button):
        Make the display !important, since a more specific rule for
        .enabledbutton overrides display.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Move event handling of the return-key from EditorClientQt to QWebPage.

        https://bugs.webkit.org/show_bug.cgi?id=20191

        This is a first step in refactoring the big switch block
        in EditorClientQt::handleKeyboardEvent to using WebActions
        instead.

        The new logic uses two new StandardKeys from QKeySequence:

        - InsertParagraphSeparator
        - InsertLineSeparator

        Which translate to the commands InsertNewline and InsertLineBreak
        respectivly. On Windows/X11 pressing the shift modifier will invoke
        the latter action. For Mac this is triggered by pressing the meta
        modifier (Ctrl).

        Initial patch by: Erik Bunce

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Roll out r35555 because of correctness issues.

        JavaScriptCore:

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):

        LayoutTests:

        * fast/js/mod-crash-expected.txt: Added.
        * fast/js/mod-crash.html: Added.
        * fast/js/resources/mod-crash.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Geoffrey Garen.

        - remove redundant #imports from FrameMac.mm

        * page/mac/FrameMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Geoff.

        - add fast path for immediates to % operator, as we have for many other math ops

        0.6% speedup on SunSpider. 1.4x speedup on a prime testing torture test that Oliver whipped up.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-04  Alice Liu  <alice.liu@apple.com>

        Reviewed by Steve Falkenburg.

        Fix CFDictionary leak

        * CFDictionaryPropertyBag.cpp:
        (CFDictionaryPropertyBag::Write):
        m_dictionary is a RetainPtr and should adopt the CF type created

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

2008-08-04  Bernhard Kruepl  <kruepl@dbai.tuwien.ac.at>

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
        Corrected offsetTop for table cells by subtracting borderTopExtra

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::offsetTop):

LayoutTests:

2008-08-04  Bernhard Kruepl  <kruepl@dbai.tuwien.ac.at>

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
        Tests for offsetTop of table cells updated so that they don't include borderExtraTop

        * fast/dom/Element/offsetTop-table-cell-expected.txt:
        * fast/dom/Element/offsetTop-table-cell.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-04  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Dan Bernstein.

        Fix typo in Skipped lists.

        * platform/mac-tiger/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Adopt the formal protocols where necessary.
Final part of fix for <rdar://problem/5853147>.

Reviewed by Kevin Decker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Declare empty protocols when using versions of AppKit that do not use formal protocols for delegates and data sources.
Part one of fix for <rdar://problem/5853147>.

Reviewed by Darin Adler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-04  Dean Jackson  <dino@apple.com>

        Reviewed by Dave Hyatt.

        Improve AnimationController
        https://bugs.webkit.org/show_bug.cgi?id=19938

        - Transition class is now called Animation
        - new state-based AnimationController that can support CSS Animations
        - add support for -webkit-transition-delay
        - remove -webkit-transition-repeat-count (since it never existed officially)
        - updates the -webkit-transition shorthand to reflect removing repeat count
        - updates the Transition class so that properties can be shared with animations
        - adds a "now" keyword for -webkit-transition-delay
        - adds a new change type for style (changed by animation)
        - adds new event names (although they are not dispatched yet)
        - makes text stroke and text fill colors returned by RenderStyle const

        Tests:
        - manual-tests/transition-left.html
        - manual-tests/transition-delay.html
        - manual-tests/transition-timing-functions.html

        * css/CSSComputedStyleDeclaration.cpp:
        * css/CSSParser.cpp:
        * css/CSSParser.h:
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        * css/CSSStyleSelector.h:
        * css/CSSTimingFunctionValue.h:
        * css/CSSValue.h:
        * css/CSSValueKeywords.in:
        * css/WebKitCSSTransformValue.cpp:
        * dom/Document.cpp:
        * dom/Document.h:
        * dom/Element.cpp:
        * dom/EventNames.h:
        * dom/Node.cpp:
        * dom/Node.h:
        * history/CachedPage.cpp:
        * page/AnimationController.cpp:
        * page/AnimationController.h:
        * page/Frame.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderWidget.cpp:
        * rendering/style/RenderStyle.cpp:
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Antti.

        Currently we create two copies of script in the HTMLTokenizer.
        One copy gets passed into the javascript engine, the other gets
        stored in the DOM.  Modify the HTMLParser so that it does not
        chunk the string into it's normal 64K chunks for script code,
        and modify the HTMLTokenizer to pass that same string into the
        JS engine.  On some sites (e.g. GMail), which have hundreds of
        KB of inline JS, this saves more than a MB of RAM to run the page.
        (Strings use 16bit strings, so 600KB of JS code == 1.2MB of memory)

        * html\HTMLParser.cpp
        * html\HTMLTokenizer.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Adam Roben.

        Fix warning seen in MSVC converting ints to floats.

        * rendering/Length.h:
        (WebCore::Length::calcFloatValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove extra braces left in from JSLock removal.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::dropProtection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Update skipped lists for renamed tests.

        * platform/mac-tiger/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

2008-08-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Implement the Access-control for Cross Site requests
        preflight cache.

        Tests: http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html
               http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html
               http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html
               http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/KURL.h:
        (WTF::):
        * platform/KURLHash.h: Added.
        (WebCore::KURLHash::hash):
        (WebCore::KURLHash::equal):
        (WTF::):
        * xml/XMLHttpRequest.cpp:
        (WebCore::PreflightResultCacheItem::PreflightResultCacheItem):
        (WebCore::preflightResultCache):
        (WebCore::appendPreflightResultCacheEntry):
        (WebCore::canSkipPrelight):
        (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
        (WebCore::parseAccessControlAllowList):
        (WebCore::parseAccessControlMaxAge):
        (WebCore::XMLHttpRequest::didReceiveResponsePreflight):

LayoutTests:

2008-08-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Tests for the Access-control for Cross Site requests
        preflight cache.

        * ChangeLog:
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html: Added.
        * http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php: Added.
        * http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php: Added.
        * http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php: Added.
        * http/tests/xmlhttprequest/resources/portabilityLayer.php: Added.
        * http/tests/xmlhttprequest/resources/reset-temp-file.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by hyatt.

        Clean up Gradient constructors, make sure all members are initialized.

        * platform/graphics/Gradient.cpp:
        (WebCore::Gradient::Gradient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-04  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel

        Fix <rdar://problem/5820157> - Saving WebArchives of Mail attachments broken.

        This broke in r31355 when we stopped returning nil WebResources when there was nil
        resource data.

        * WebView/WebResource.mm:
        (-[WebResource _initWithCoreResource:]): Restore previous behavior of returning nil
          when the resource data is null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-04  Erik Bunce  <elbunce@thehive.com>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=20221

        Add updateAction() support to ToggleBold, ToggleItalic, and ToggleUnderline.
        Add lookup table for mapping web actions to editor commands.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-03  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        A bunch of improvements to the QtLauncher.

        Among others:
        - Unify and unclutter the toolbar, use menu for addition actions
        - Simplify URL edit, just use QLineEdit (no fancy close button etc)
        - Guess the URL from the command line so now we can run ./QtLauncher www.google.com
        - Shortcut keys for most actions
        - Simple autocomplete for the URL edit
        - Actions for zooming, New Window and Close Window
        - Show Format menu only when the content is set to editable

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-04  Erik Bunce  <elbunce@thehive.com>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=20198

        Allow Copy key sequence to work in non-editable areas.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Future-proof fast/cookies/local-file-can-set-cookies.html

        Reviewed by Anders Carlsson.

        * fast/cookies/local-file-can-set-cookies.html: Set cookie
        expiration date 60 seconds into the future instead of a
        hard-coded date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Bug 19359: JavaScriptCore behaves differently from FF2/3 and IE when handling context in catch statement
<https://bugs.webkit.org/show_bug.cgi?id=19359>

Reviewed by Cameron Zwarich

Make our catch behave like Firefox and IE, we do this by using a StaticScopeObject
instead of a generic JSObject for the scope node.  We still don't make use of the
fact that we have a static scope inside the catch block, so the internal performance
of the catch block is not improved, even though technically it would be possible to
do so.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-02  Maxime Britto  <britto@apple.com>

        Reviewed by Eric Seidel.

        <rdar://problem/6118969>
        https://bugs.webkit.org/show_bug.cgi?id=19971
        Modifiy the cursor interactively when on panning mode (middle click auto scroll)
        When the panning is in progress the cursor is an arrow representing the direction of the current scroll

        * page/EventHandler.cpp:
        (WebCore::EventHandler::autoscrollTimerFired): Before each scroll we actualize the cursor to match the current direction
        (WebCore::EventHandler::setPanScrollCursor): determines the direction of the upcoming scroll.
        (WebCore::EventHandler::handleMouseMoveEvent):
        * page/EventHandler.h:
        * platform/Cursor.h: Add propotypes for the new cursor functions
        * platform/gtk/CursorGtk.cpp: to avoid build break
        (WebCore::middlePanningCursor):
        (WebCore::eastPanningCursor):
        (WebCore::northPanningCursor):
        (WebCore::northEastPanningCursor):
        (WebCore::northWestPanningCursor):
        (WebCore::southPanningCursor):
        (WebCore::southEastPanningCursor):
        (WebCore::southWestPanningCursor):
        (WebCore::westPanningCursor):
        * platform/mac/CursorMac.mm: to avoid build break
        (WebCore::middlePanningCursor):
        (WebCore::eastPanningCursor):
        (WebCore::northPanningCursor):
        (WebCore::northEastPanningCursor):
        (WebCore::northWestPanningCursor):
        (WebCore::southPanningCursor):
        (WebCore::southEastPanningCursor):
        (WebCore::southWestPanningCursor):
        (WebCore::westPanningCursor):
        * platform/qt/CursorQt.cpp: to avoid build break
        (WebCore::middlePanningCursor):
        (WebCore::eastPanningCursor):
        (WebCore::northPanningCursor):
        (WebCore::northEastPanningCursor):
        (WebCore::northWestPanningCursor):
        (WebCore::southPanningCursor):
        (WebCore::southEastPanningCursor):
        (WebCore::southWestPanningCursor):
        (WebCore::westPanningCursor):
        * platform/win/CursorWin.cpp: Add specific icons for the panning as windows resizing icons are both sides arrows
        (WebCore::middlePanningCursor):
        (WebCore::eastPanningCursor):
        (WebCore::northPanningCursor):
        (WebCore::northEastPanningCursor):
        (WebCore::northWestPanningCursor):
        (WebCore::southPanningCursor):
        (WebCore::southEastPanningCursor):
        (WebCore::southWestPanningCursor):
        (WebCore::westPanningCursor):
        * platform/wx/CursorWx.cpp: to avoid build break
        (WebCore::middlePanningCursor):
        (WebCore::eastPanningCursor):
        (WebCore::northPanningCursor):
        (WebCore::northEastPanningCursor):
        (WebCore::northWestPanningCursor):
        (WebCore::southPanningCursor):
        (WebCore::southEastPanningCursor):
        (WebCore::southWestPanningCursor):
        (WebCore::westPanningCursor):

2008-08-02  Maxime Britto  <britto@apple.com>

        Reviewed by Eric Seidel.

        These icons are copies from the resizers in WebCore/Ressources

        * ChangeLog:
        * WebKit.vcproj/WebKit.rc:
        * WebKit.vcproj/panEastCursor.png: Added.
        * WebKit.vcproj/panNorthCursor.png: Added.
        * WebKit.vcproj/panNorthEastCursor.png: Added.
        * WebKit.vcproj/panNorthWestCursor.png: Added.
        * WebKit.vcproj/panSouthCursor.png: Added.
        * WebKit.vcproj/panSouthEastCursor.png: Added.
        * WebKit.vcproj/panSouthWestCursor.png: Added.
        * WebKit.vcproj/panWestCursor.png: Added.
        * WebKit.vcproj/resource.h:
        * WebKitDLL.cpp:
        (loadResourceIntoBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-02  Rob Gowin  <robg@gowin.net>

        Reviewed by Eric Seidel.

        Added JavaScriptCore/API/WebKitAvailability to list of files in
        javascriptcore_h_api.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-02  Matt Lilek  <webkit@mattlilek.com>

        Reviewed by Tim Hatcher.

        Update the window gradient offset to match the inspector toolbar's new height.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController window]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Forgot to commit licensing correction in last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Eric Seidel.

Scripts for building a wxWebKit installer for wxPython on Win, eventually will
be used for nightlies.

https://bugs.webkit.org/show_bug.cgi?id=20036

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Move to using constants in accordance with discussions about wx renderer commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-02  Wouter Bolsterlee  <wbolster@svn.gnome.org>

        Reviewed by Eric Seidel.

        * plugins/gtk/gtk2xtbin.h:

        https://bugs.webkit.org/show_bug.cgi?id=20034
        Fix malformed Vim modeline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-02  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Eric Seidel.

        Remove webkit-marshal.list, which was made obsolete in #19742

        * webkit/webkit-marshal.list: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Dave Hyatt.

        - tweak a comment

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Forgot to add the reviewer of r35522.

* WebKit/gtk/ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-01  Wouter Bolsterlee  <uws@xs4all.nl>

        https://bugs.webkit.org/show_bug.cgi?id=20035
        [GTK] Fix return value for webkit_web_view_go_to_back_forward_item()

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-01  Jan Michael Alonzo  <jmalonzo@webkit.org>

        * ChangeLog: Fix date of previous commit (r35520)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-17  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=19603
        [SOUP] segfault when closing a file using gio

        Call client->didFinishLoading() only after releasing all the gio
        resources.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::closeCallback):
        (WebCore::readCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

../../../../../../WebCore:

2008-08-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        <rdar://problem/6120206>
        Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.

        Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.

        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::wantsAllStreams):

../../../../../../WebKit/mac:

2008-08-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        <rdar://problem/6120206>
        Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.

        Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.

        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream wantsAllStreams]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Eric Seidel.

Native rendering implementations for form elements in the wx port.

https://bugs.webkit.org/show_bug.cgi?id=19069

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-08-01  Beth Dakin  <bdakin@apple.com>

        Reviewed by Adam Roben.

        Fix for <rdar://problem/6119382> Need to hook up WebFrame's
        disconnected frame API on Windows.

        * Interfaces/IWebFrame.idl:
        * WebFrame.cpp:
        (WebFrame::setIsDisconnected):
        * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Fix <rdar://6118733> REGRESSION (r35502): Crash when submitting any form

        Reviewed by Darin Adler.

        * COMPropertyBag.h:
        (COMPropertyBag::QueryInterface): Cast to an appropriate type before
        assigning into ppvObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-07-30  David Hyatt  <hyatt@apple.com>

        Improvements to selection drawing.

        Clip out floating and positioned objects when drawing selection so
        that there is no "double painting" of selection when the selection spans both the space behind the positioned/floating
        object and the positioned/floating object itself.  Improves most Web pages.

        Do not paint left/right selection gaps if the object's edge is already outside the boundary (at a negative
        position).  Significantly improves the look of selections on digg.com, since it uses giant negative text-indent.

        Reviewed by Dan

        Covered by existing selection pixel tests.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isSelectionRoot):
        (WebCore::RenderBlock::paintSelection):
        (WebCore::clipOutPositionedObjects):
        (WebCore::RenderBlock::fillSelectionGaps):
        (WebCore::RenderBlock::fillLeftSelectionGap):
        (WebCore::RenderBlock::fillRightSelectionGap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Adds the ability to disable individual properties of a CSS rule.
        When hovering over a rule, checkboxes show up to the right of all
        properties and toggling a checkbox disables/enables the property.
        Behind the scenes the property is removed from the rule when disabled,
        but still remains in the list and in the computed style. When disabled
        the property has a line through it, and is faded in computed style.

        <rdar://problem/5712828> Support disabling individual CSS properties
        https://bugs.webkit.org/show_bug.cgi?id=14377

        Reviewed by Adam Roben.

        * page/inspector/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.update): Include the
        inline style when it also has disabled properties. Call
        deleteDisabledProperty for any property that is in the style,
        since it might have been added back by the page. Remember all
        disabled properties so they show up in computed style.
        (deleteDisabledProperty): Helper function to delete all the
        right properties that track disabled properties.
        (WebInspector.StylePropertiesSection): Add the computed-style
        class when  the section is Computed Style.
        (WebInspector.StylePropertiesSection.prototype.onpopulate):
        Include disabled properties.
        (WebInspector.StylePropertyTreeElement): Added a disabled argument.
        (WebInspector.StylePropertyTreeElement.prototype.get/set disabled):
        Sets the _disabled property and calls updateState.
        (WebInspector.StylePropertyTreeElement.prototype.get priority):
        Return the priority of enabled or disabled properties.
        (WebInspector.StylePropertyTreeElement.prototype.get value):
        Return the value of enabled or disabled properties.
        (WebInspector.StylePropertyTreeElement.prototype.updateTitle): Use the
        priority and value getter. Append the checkbox for root elements of
        an editable section.
        (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
        Add or remove properties from the rule and remember removed ones
        by adding three objects to the style: __disabledProperties,
        __disabledPropertyValues and __disabledPropertyPriorities.
        The __disabledProperties object will include all longhand
        properties of a shorthand for use by Computed Style.
        (WebInspector.StylePropertyTreeElement.prototype.updateState):
        Use the value getter. Update the disabled state.
        * page/inspector/inspector.css:
        * page/inspector/utilities.js:
        (Object.hasProperties): Added. Helper to test if an object
        has any properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

../../../../../../WebCore:

2008-07-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        <rdar://problem/5949410>
        Add the ability to transfer a given application cache to a new database.

        * WebCore.base.exp:
        Export ApplicationCacheStorage::storeCopyOfCache.

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::~ApplicationCache):
        Don't call cacheDestroyed for our special "copy" groups.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
        (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
        Add a "copy" flag to the ApplicationCacheGroup constructor. A "copied" group is special
        and can only be stored to disk.

        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::isCopy):
        New getter.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::store):
        Make sure to set the storageID when storing an application resource.

        (WebCore::ApplicationCacheStorage::storeNewestCache):
        Change this to return true/false depending on whether storing the cache succeeded or not.

        (WebCore::ApplicationCacheStorage::storeCopyOfCache):
        New method which stores a given cache in a new storage (database file).

        * loader/appcache/ApplicationCacheStorage.h:
        Add new methods.

../../../../../../WebKit/mac:

2008-07-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        <rdar://problem/5949410>
        Add the ability to transfer a given application cache to a new database.

        * Misc/WebKitNSStringExtras.h:
        * Misc/WebKitNSStringExtras.m:
        (+[NSString _webkit_applicationCacheDirectoryWithBundleIdentifier:]):
        New method which returns the appopriate cache directory for a given bundle identifier.

        * WebView/WebDataSource.mm:
        (-[WebDataSource _transferApplicationCache:]):
        Transfer the application cache.

        * WebView/WebDataSourcePrivate.h:
        * WebView/WebView.mm:
        (WebKitInitializeApplicationCachePathIfNecessary):
        Change this to use _webkit_applicationCacheDirectoryWithBundleIdentifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Add a link to the instructions to use Apple's Safari for Windows symbol server

        Reviewed by Eric Seidel.

        * building/debug.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Rubber-stamped by Maciej.

        Remove JSGlobalData::DataInstance. It was only needed when we had per-thread JSGlobalData
        instances.

        * kjs/JSGlobalData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Updated test results for DumpRenderTree fix in r35497

        * svg/custom/image-with-prefix-in-webarchive-expected.webarchive:
        Contents of the main resource are now displayed instead of encoded
        data.
        * svg/webarchive/svg-cursor-subresources-expected.webarchive: Ditto.
        * svg/webarchive/svg-feimage-subresources-expected.webarchive: Ditto.
        * svg/webarchive/svg-script-subresouces-expected.webarchive: Ditto.
        Also updated MIME types for JavaScript source now that we don't
        mangle application/x-javascript into text/javascript.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-07-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Get rid of FormValuesPropertyBag and use COMPropertyBag instead.

        * COMPropertyBag.h:
        Implement parts of IPropertyBag2.
        Currently just one method (CountProperties) is implemented.

        * WebCoreSupport/FormValuesPropertyBag.cpp: Removed.
        * WebCoreSupport/FormValuesPropertyBag.h: Removed.

        * WebFrame.cpp:
        (WebFrame::dispatchWillSubmitForm):
        Create a COMPropertyBag instead.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Follow-up to r35500

        * WinLauncher/WinLauncher.vcproj: Set the manifest properties for the
        Release configuration, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-07-31  Stefan Landvogt <stefan.landvogt@gmail.com>

        Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
        the box

        <https://bugs.webkit.org/show_bug.cgi?id=20245>

        Reviewed by Adam Roben.

        * WinLauncher/WinLauncher.vcproj: adding the following properties to
        WinLauncher > Properties > Manifest Tool > Isolated COM
        Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb
        Component File Name: WebKit$(WebKitDLLConfigSuffix)
        Doing the change on "All Configurations"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

2008-07-31  John Sullivan  <sullivan@apple.com>

        WebCore part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs

        Reviewed by Hyatt

        * WebCore.base.exp:
        export symbol for WebCoreSettings::setZoomsTextOnly()

        * page/Frame.cpp:
        (WebCore::Frame::isZoomFactorTextOnly):
        use value from Settings instead of data member
        (WebCore::Frame::shouldApplyTextZoom):
        call isZoomFactorTextOnly() to get value instead of accessing now-removed data member
        (WebCore::Frame::shouldApplyPageZoom):
        ditto
        (WebCore::Frame::setZoomFactor):
        set value into Settings rather than into data member
        (WebCore::FramePrivate::FramePrivate):
        don't set initial value of now-removed data member; this is managed by Settings now

        * page/FramePrivate.h:
        removed m_zoomFactorIsTextOnly

        * page/Settings.cpp:
        (WebCore::Settings::setZoomsTextOnly):
        new function, sets values and reapplies styles in all frames

        * page/Settings.h:
        (WebCore::Settings::zoomsTextOnly):
        new function, returns value of new data member

WebKit/mac:

2008-07-31  John Sullivan  <sullivan@apple.com>

        WebKit part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs

        Reviewed by Hyatt

        * WebView/WebPreferenceKeysPrivate.h:
        added WebKitZoomsTextOnlyPreferenceKey

        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        default value of YES for WebKitZoomsTextOnlyPreferenceKey
        (-[WebPreferences zoomsTextOnly]):
        getter for WebKitZoomsTextOnlyPreferenceKey
        (-[WebPreferences setZoomsTextOnly:]):
        setter for WebKitZoomsTextOnlyPreferenceKey

        * WebView/WebPreferencesPrivate.h:
        declare zoomsTextOnly/setZoomsTextOnly:

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):
        update WebCore::Settings value for zoomsTextOnly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Windows build bot fix

        * DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only
        exist for people at Apple can't be found. Also updated the ICU version
        to 3.8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Fix layout test results for webarchive/test-xml-stylesheet.xml

WebKit:

        Fix layout test results for webarchive/test-xml-stylesheet.xml

        Reviewed by Darin.

        * WebKit.xcodeproj/project.pbxproj: Added WebHTMLRepresentationInternal.h.
        Changed WebHTMLRepresentationInternal.h and WebHTMLRepresentationPrivate.h
        to private so they're copied into PrivateHeaders.

WebKit/mac:

        Fix layout test results for webarchive/test-xml-stylesheet.xml

        Reviewed by Darin.

        Needed to expose -[WebHTMLRepresentation supportedNonImageMIMETypes]
        for DumpRenderTree.

        * WebView/WebHTMLRepresentationInternal.h: Added.

WebKitTools:

        Fix layout test results for webarchive/test-xml-stylesheet.xml

        Reviewed by Darin.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (convertMIMEType): Work around the "text/xml" local file type
        regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
        stop mangling "application/x-javascript" into "text/javascript".
        (convertWebResourceDataToString): When checking whether to dump a
        resource as text, also check to see if the MIME type is in the
        -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
        * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
        macro.

LayoutTests:

        Fix layout test results for webarchive/test-xml-stylesheet.xml

        Reviewed by Darin.

        * platform/mac/webarchive/test-xml-stylesheet-expected.txt:
        Removed unused test results.

        * webarchive/test-duplicate-resources-expected.webarchive: Updated
        results now that we don't mangle application/x-javascript into
        text/javascript.
        * webarchive/test-script-src-expected.webarchive: Ditto.

        * webarchive/test-xml-stylesheet-expected.webarchive: Updated
        results now that we handle application/xml correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-07-31  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        Null-check parent clip rects, because they may not have been
        set up yet.
        https://bugs.webkit.org/show_bug.cgi?id=20243

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateClipRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Did not mean to remove these files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-07-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        Tweak the names.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-07-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        <rdar://problem/5826110>

        Add a way for WebKit clients to embed custom content in web pages.

        * Interfaces/IWebEmbeddedView.idl: Added.
        New interface which an embedded view must implement.

        * Interfaces/IWebUIDelegatePrivate.idl:
        Add new UI delegate method for creating an embedded view.

        * Interfaces/WebKit.idl:
        Include IWebEmbeddedView.idl.

        * WebCoreSupport/EmbeddedWidget.cpp: Added.
        * WebCoreSupport/EmbeddedWidget.h: Added.
        Add EmbeddedWidget, a widget subclass which can hold an IWebEmbeddedView.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::createPlugin):
        Check if the UI delegate wants to create an embedded view.

        * WebKit.vcproj/WebKit.vcproj:
        Add EmbeddedWidget.{cpp|h}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Dave Hyatt.

        - fix <rdar://problem/6058958> REGRESSION (r34210): Seams are visible in border-image

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw): To work around a Core Graphics
        interpolation issue, reverted to using a temporary subimage for drawing
        a portion of the image with scaling and high-quality interpolation in
        effect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<rdar://problem/3563671> VO doesn't highlight characters when interacting when static text in web areas

Add ability to get bounds for individual characters through accessibility

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Removed da BOM from the ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Release build fix.

        * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setWindowIfNecessary]):
        Don't define to npErr in release builds, as it is only used for logging.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-07-31  John Sullivan  <sullivan@apple.com>

        Fixed <https://bugs.webkit.org/show_bug.cgi?id=5195>
        drawing with cacheDisplayInRect:toBitmapImageRep: doesn't trigger layout on Leopard

        Reviewed by Dan

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
        include Leopard in the #ifdef that forces a layout if needed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35488 268f45cc-cd09-0410-ab3c-d52691b4dbfc