inferno@chromium.org [Fri, 6 May 2011 22:16:37 +0000 (22:16 +0000)]
2011-05-06 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Rebaselines for r85926.
https://bugs.webkit.org/show_bug.cgi?id=60356
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* platform/chromium-linux/svg/batik/filters/feTile-expected.png:
* platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-linux/svg/filters/filter-on-tspan-expected.png:
* platform/chromium-linux/svg/filters/filterRes-expected.png: Added.
* platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
* platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* platform/chromium-mac-leopard/svg/batik/filters: Added.
* platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png: Added.
* platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.png: Added.
* platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac-leopard/svg/filters/feGaussianBlur-expected.png: Added.
* platform/chromium-mac-leopard/svg/filters/feOffset-expected.png:
* platform/chromium-mac-leopard/svg/filters/feTile-expected.png: Added.
* platform/chromium-mac-leopard/svg/filters/filter-on-tspan-expected.png: Added.
* platform/chromium-mac-leopard/svg/filters/filter-rounding-issues-expected.png: Added.
* platform/chromium-mac-leopard/svg/filters/filterRes-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* platform/chromium-mac/svg/batik/filters/feTile-expected.png: Added.
* platform/chromium-mac/svg/batik/filters/filterRegions-expected.png: Added.
* platform/chromium-mac/svg/batik/text/textFeatures-expected.png: Added.
* platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac/svg/filters/feGaussianBlur-expected.png: Added.
* platform/chromium-mac/svg/filters/feOffset-expected.png: Added.
* platform/chromium-mac/svg/filters/feTile-expected.png: Added.
* platform/chromium-mac/svg/filters/filter-on-tspan-expected.png: Added.
* platform/chromium-mac/svg/filters/filter-rounding-issues-expected.png: Added.
* platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
* platform/chromium-mac/svg/filters/filterRes1-expected.png: Added.
* platform/chromium-mac/svg/filters/filterRes3-expected.png: Added.
* platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png: Added.
* platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png: Added.
* platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png: Added.
* platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* platform/chromium-win/svg/batik/filters/feTile-expected.png:
* platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-win/svg/batik/text/textFeatures-expected.png:
* platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
* platform/chromium-win/svg/filters/feOffset-expected.png:
* platform/chromium-win/svg/filters/feTile-expected.png:
* platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
* platform/chromium-win/svg/filters/filter-rounding-issues-expected.png:
* platform/chromium-win/svg/filters/filterRes-expected.png: Added.
* platform/chromium-win/svg/filters/filterRes1-expected.png:
* platform/chromium-win/svg/filters/filterRes3-expected.png:
* platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png:
* platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
* platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 6 May 2011 22:08:33 +0000 (22:08 +0000)]
Windows build fix.
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::shouldUsePlugin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 6 May 2011 21:52:12 +0000 (21:52 +0000)]
2011-05-06 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Chromium Rebaselines for r85964, r85971 and r85967.
* platform/chromium-linux/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
* platform/chromium-linux/fast/forms/date-input-visible-strings-expected.png: Added.
* platform/chromium-linux/fast/inline/nested-top-alignment-expected.png: Added.
* platform/chromium-mac-leopard/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/date-input-visible-strings-expected.png: Added.
* platform/chromium-mac-leopard/fast/inline/nested-top-alignment-expected.png: Added.
* platform/chromium-win/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
* platform/chromium-win/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
* platform/chromium-win/fast/forms/date-input-visible-strings-expected.png: Added.
* platform/chromium-win/fast/forms/date-input-visible-strings-expected.txt: Added.
* platform/chromium-win/fast/inline/nested-top-alignment-expected.png: Added.
* platform/chromium-win/fast/inline/nested-top-alignment-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 6 May 2011 21:17:42 +0000 (21:17 +0000)]
2011-05-06 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Make more PluginInfoStore member functions static
https://bugs.webkit.org/show_bug.cgi?id=60401
This is a first step towards making PluginInfoStore thread safe.
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
(WebKit::PluginInfoStore::loadPlugin):
* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
* UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::shouldUsePlugin):
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::shouldUsePlugin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Fri, 6 May 2011 21:12:58 +0000 (21:12 +0000)]
2011-05-06 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
[Chromium] Whitelist input events interpreted as user gestures
https://bugs.webkit.org/show_bug.cgi?id=60213
* fast/events/popup-blocked-from-mousemove-expected.txt: Added.
* fast/events/popup-blocked-from-mousemove.html: Added.
2011-05-06 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
[Chromium] Whitelist input events interpreted as user gestures
https://bugs.webkit.org/show_bug.cgi?id=60213
* public/WebInputEvent.h:
(WebKit::WebInputEvent::isUserGestureEventType):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 6 May 2011 21:06:32 +0000 (21:06 +0000)]
2011-05-06 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Fix error due to duplicate entry.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 6 May 2011 21:03:57 +0000 (21:03 +0000)]
2011-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add disable-javascript-urls CSP directive
https://bugs.webkit.org/show_bug.cgi?id=60301
* http/tests/security/contentSecurityPolicy/javascript-urls-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html: Added.
2011-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add disable-javascript-urls CSP directive
https://bugs.webkit.org/show_bug.cgi?id=60301
This CSP directive is not in the CSP spec. This patch is somewhat of
an experiment to see whether this feature is useful. Based on our
implementation experience, we will coordinate with folks via the W3C to
see if this makes sense to add to the spec.
Test: http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
brettw@chromium.org [Fri, 6 May 2011 20:52:53 +0000 (20:52 +0000)]
2011-05-06 Brett Wilson <brettw@chromium.org>
Reviewed by Adam Barth.
Use a File object to store the downloaded file reference rather than
just the path. This keeps the file and permissions in scope (using the
already-existing blob system) so the browser won't delete the file
when the load is complete. Instead, the file will be cleaned up when
the request objects are deleted.
https://bugs.webkit.org/show_bug.cgi?id=60281
* platform/network/chromium/ResourceResponse.cpp:
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
* platform/network/chromium/ResourceResponse.h:
(WebCore::ResourceResponse::downloadedFile):
(WebCore::ResourceResponse::setDownloadedFile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Fri, 6 May 2011 20:29:58 +0000 (20:29 +0000)]
2011-05-06 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Darin Adler.
Fix two warnings of unused variables.
https://bugs.webkit.org/show_bug.cgi?id=60370
Remove two unused local variable from the code.
No new tests, the existing ones should cover.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateNextProgressTime):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 6 May 2011 20:13:43 +0000 (20:13 +0000)]
2011-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Wire up CSP's eval blocking to V8's new API
https://bugs.webkit.org/show_bug.cgi?id=60384
* platform/chromium/http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt: Added.
- Boo different error messages.
* platform/chromium/test_expectations.txt:
- Test progression.
2011-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Wire up CSP's eval blocking to V8's new API
https://bugs.webkit.org/show_bug.cgi?id=60384
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::disableEval):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 6 May 2011 20:07:38 +0000 (20:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/
9307696>)
REGRESSION (r81684?): cox.com sign in button is missing
Reviewed by Dan Bernstein.
Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.
Source/WebCore:
Added fast/inline/nested-top-alignment.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
LayoutTests:
* fast/inline/nested-top-alignment.html: Added.
* platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
* platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Fri, 6 May 2011 19:22:25 +0000 (19:22 +0000)]
2011-05-06 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, rebaseline changes after r85959
https://bugs.webkit.org/show_bug.cgi?id=59020
* platform/chromium-gpu-mac/compositing/flat-with-transformed-child-expected.png: Added.
* platform/chromium-gpu-win/compositing/flat-with-transformed-child-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 6 May 2011 19:17:01 +0000 (19:17 +0000)]
2011-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a --skip-integrationtests mode to test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=60354
These two test suites account for 2/3 of test-webkitpy's running time
because they're not actually unit tests. They're integration tests.
This patch adds the ability to skip integration tests by passing a
command line argument to test-webkitpy. The buildbots will continue to
run these integration tests to make sure they don't regress. This
option is for use by developers when working on parts of the code that
are well-covered by unit tests.
* Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
* Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
* Scripts/webkitpy/test/main.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 6 May 2011 19:14:43 +0000 (19:14 +0000)]
2011-05-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
[results.html] label the zoomed pixel containers (expected, actual, diff)
https://bugs.webkit.org/show_bug.cgi?id=60383
* fast/harness/results.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Fri, 6 May 2011 19:10:53 +0000 (19:10 +0000)]
2011-05-06 Joseph Pecoraro <joepeck@webkit.org>
Unreviewed. Add pixel results for mac.
* platform/mac/fast/forms/date-input-visible-strings-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jam@chromium.org [Fri, 6 May 2011 19:09:31 +0000 (19:09 +0000)]
2011-05-06 John Abd-El-Malek <jam@chromium.org>
Reviewed by James Robinson.
[chromium]: Reland using WebPermissionClient for checking indexed db usage
https://bugs.webkit.org/show_bug.cgi?id=60386
* public/WebPermissionClient.h:
(WebKit::WebPermissionClient::allowIndexedDB):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::open):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 May 2011 19:05:58 +0000 (19:05 +0000)]
2011-05-06 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Add baselines to chromium for video-source-error that reflect the fact that
chromium does not support mp4.
[chromium] Rebaseline needed for video-source-error
https://bugs.webkit.org/show_bug.cgi?id=60292
* platform/chromium/media/video-source-error-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 6 May 2011 18:50:08 +0000 (18:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60390 (<rdar://problem/
9364449>)
REGRESSION (r81992): portions of ticketmaster site render blank
Reviewed by Dan Bernstein.
Make simplified layout skip from a positioned object out to its containing block. There is no
need to dirty the intermediate inlines, and in this case it's actively harmful, since the
block responsible for the layout of the positioned object doesn't get m_posChildNeedsLayout set.
Source/WebCore:
Added fast/block/positioning/hiding-inside-relpositioned-inline.html
* rendering/RenderObject.h:
(WebCore::RenderObject::markContainingBlocksForLayout):
LayoutTests:
* fast/block/positioning/hiding-inside-relpositioned-inline.html: Added.
* platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
* platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 6 May 2011 18:49:17 +0000 (18:49 +0000)]
2011-05-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: move selection test into the text area branch.
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._contextMenu):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 6 May 2011 18:48:03 +0000 (18:48 +0000)]
Mac build fix
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Added a
missing #import.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 6 May 2011 18:41:32 +0000 (18:41 +0000)]
Show/hide windowed plugins according to the plugin element's visibility CSS property
Fixes <http://webkit.org/b/60285> <rdar://problem/
9152400> REGRESSION (WebKit2): A white
rectangle covers up important UI elements when composing a new message at mail.yahoo.com
with BrowserPlus! plug-in installed
Reviewed by Anders Carlsson.
Source/WebKit2:
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::isPluginVisible):
* PluginProcess/PluginControllerProxy.h:
Stubbed out.
* Shared/win/WindowGeometry.cpp:
(WebKit::WindowGeometry::WindowGeometry):
(WebKit::WindowGeometry::encode):
(WebKit::WindowGeometry::decode):
* Shared/win/WindowGeometry.h:
Added visible member.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::updateChildWindowGeometries): Show or hide the window as specified in the
geometry.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::visibilityDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Added. Calls through to platform-specific code.
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformVisibilityDidChange):
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformVisibilityDidChange):
Stubbed out.
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange): Moved most logic from here to
scheduleWindowedGeometryUpdate.
(WebKit::NetscapePlugin::platformVisibilityDidChange): Added. Calls through to
scheduleWindowedGeometryUpdate.
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate): Added. Code came from
platformGeometryDidChange. Now also records whether the plugin element is visible.
* WebProcess/Plugins/Plugin.h: Added visibilityDidChange.
* WebProcess/Plugins/PluginController.h: Added isPluginVisible.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::visibilityDidChange):
* WebProcess/Plugins/PluginProxy.h:
Stubbed out.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::show):
(WebKit::PluginView::hide):
Added. These Widget overrides were based on WebCore's PluginView class.
(WebKit::PluginView::viewVisibilityDidChange): Added. Similar to viewGeometryDidChange.
Calls down to the plugin if it's been initialized.
(WebKit::PluginView::isPluginVisible): Added. Just calls up to the Widget base class.
* WebProcess/Plugins/PluginView.h: Updated for PluginController changes.
LayoutTests:
Add a test that shows that windowed plugins with visibility:hidden do not appear on screen
I could only figure out how to make this a pixel test. Note that the pixel test doesn't pass
in WebKit2 due to <http://webkit.org/b/58050>, but I verified it works correctly in
MiniBrowser.
* platform/win/plugins/visibility-hidden-expected.png: Added.
* platform/win/plugins/visibility-hidden-expected.txt: Added.
* platform/win/plugins/visibility-hidden.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 6 May 2011 18:35:21 +0000 (18:35 +0000)]
2011-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The results.zip generated by the Chromium EWS are too big
https://bugs.webkit.org/show_bug.cgi?id=60352
Currently results.zip created by the Chromium EWS bot contain roughly
1000 tests that we expect to fail. These test results are not helpful
to contributors.
There are several approaches to solving this problem:
1) We could be more selective about which files to include in the zip.
2) We could ask new-run-webkit-tests not to generate results for
expected failures.
3) We could ask new-run-webkit-tests not to run tests that we expect to
fail.
This patch takes approach (3). Currently, we're ignoring the outcome
of failing tests anyway, so there's not much point in actually running
them. As a side benefit, this will speed up the test run by about 6%.
In the future, we might revisit this decision and choose another
approach.
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/common/config/ports_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Fri, 6 May 2011 17:41:46 +0000 (17:41 +0000)]
2011-05-04 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
https://bugs.webkit.org/show_bug.cgi?id=59020
* compositing/flat-with-transformed-child-expected.txt: Added.
* compositing/flat-with-transformed-child.html: Added.
* platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Added.
* platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
* platform/chromium/test_expectations.txt:
2011-05-04 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
https://bugs.webkit.org/show_bug.cgi?id=59020
Allow for empty scissor rects, which implies scissoring to the render
surface. The previous code and previous patch on this bug both didn't
take into account that the scissor rect should be the render surface
and not the projection of the layer itself, because child layers
aren't necessarily contained within the bounds of their superlayer.
Test: compositing/flat-with-transformed-child.html
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::setScissorToRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 6 May 2011 17:30:10 +0000 (17:30 +0000)]
Add a WindowGeometry struct for use in the ScheduleChildWindowGeometryUpdate message
This will make it easier to add more info to this message in the future (like whether the
window is visible).
Fixes <http://webkit.org/b/60374> Adding parameters to ScheduleChildWindowGeometryUpdate
message is tedious
Reviewed by Anders Carlsson.
* Scripts/webkit2/messages.py:
(struct_or_class): Added WindowGeometry to the list of structs.
* Shared/win/WindowGeometry.cpp: Added.
* Shared/win/WindowGeometry.h: Added.
* win/WebKit2.vcproj: Added new files.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::scheduleChildWindowGeometryUpdate):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::scheduleChildWindowGeometryUpdate):
(WebKit::WebView::updateChildWindowGeometries):
* UIProcess/win/WebView.h:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange):
* WebProcess/Plugins/PluginController.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate):
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::scheduleChildWindowGeometryUpdate):
Changed to use WindowGeometry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 6 May 2011 17:22:52 +0000 (17:22 +0000)]
2011-05-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Mihai Parparita.
[results.html] zoomed pixel results should not be antialiased
https://bugs.webkit.org/show_bug.cgi?id=60330
-Use canvas instead of CSS zoom.
-Only zoom the part of the image we need to show.
-Make pixel zooming mostly work in Firefox.
-Increase the zoom from 3x to 6x.
* fast/harness/results.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 6 May 2011 17:22:32 +0000 (17:22 +0000)]
Remove unused GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings
Reviewed by Jon Honeycutt.
This fixes an Xcode 4 warning about using obsolete settings.
Source/JavaScriptGlue:
* JavaScriptGlue.xcodeproj/project.pbxproj: Removed
GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings.
Source/WebKit2:
* WebKit2.xcodeproj/project.pbxproj: Removed
GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 6 May 2011 17:12:48 +0000 (17:12 +0000)]
2011-05-06 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
Lazily allocate ScrollAnimator in ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=60327
Avoid allocating the ScrollAnimator up-front, because we
create lots of ScrollableAreas via RenderLayer, and we should
only need the animator when scrolling.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::scrollAnimator):
(WebCore::ScrollableArea::scroll):
(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollableArea::handleWheelEvent):
(WebCore::ScrollableArea::handleGestureEvent):
* platform/ScrollableArea.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 6 May 2011 17:04:39 +0000 (17:04 +0000)]
2011-05-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r85919.
http://trac.webkit.org/changeset/85919
https://bugs.webkit.org/show_bug.cgi?id=60378
broke chromium database tests (Requested by inferno-sec on
#webkit).
* public/WebPermissionClient.h:
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::open):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 6 May 2011 16:55:47 +0000 (16:55 +0000)]
2011-05-06 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement NetscapePlugin::platformPaint for GTK platform
https://bugs.webkit.org/show_bug.cgi?id=60368
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPaint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 6 May 2011 16:03:59 +0000 (16:03 +0000)]
2011-05-06 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
Share PluginInfoStore implementation between Qt and GTK ports
https://bugs.webkit.org/show_bug.cgi?id=60366
* GNUmakefile.am:
* UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp: Removed.
* UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: Renamed from Source/WebKit2/UIProcess/Plugins/qt/PluginInfoStoreQt.cpp.
(WebKit::PluginInfoStore::pluginsDirectories):
(WebKit::PluginInfoStore::pluginPathsInDirectory):
(WebKit::PluginInfoStore::individualPluginPaths):
(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::shouldUsePlugin):
* WebKit2.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Fri, 6 May 2011 15:51:11 +0000 (15:51 +0000)]
2011-05-06 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, fix parse errors in test_expectations.
I will annotate bug 60356 so that this case gets looked at.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Fri, 6 May 2011 15:23:01 +0000 (15:23 +0000)]
2011-05-06 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
REGRESSION (r77954): HTTP Live Streams have incorrect controller UI
https://bugs.webkit.org/show_bug.cgi?id=60304
<rdar://problem/
9392609>
Don't assume that the only time the media controls UI may need to change is on a
network state change, readyState changes can be significant as well.
Tested manually because we don't have any live streams to test in DRT.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setNetworkState): changedNetworkState -> updateStatusDisplay.
(WebCore::HTMLMediaElement::setReadyState): Call updateStatusDisplay.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::reset): changedNetworkState -> updateStatusDisplay.
(WebCore::MediaControlRootElement::updateStatusDisplay): Ditto.
* html/shadow/MediaControlRootElement.h:
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::reset): Ditto.
(WebCore::MediaControlRootElementChromium::updateStatusDisplay): Ditto.
* html/shadow/MediaControlRootElementChromium.h:
* html/shadow/MediaControls.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 6 May 2011 15:06:47 +0000 (15:06 +0000)]
Roll out r85946
I didn't mean to commit it!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 6 May 2011 15:04:06 +0000 (15:04 +0000)]
Touch WebKit.idl to fix the build
I needed this on my own machine. Maybe others will need it, too.
* Interfaces/WebKit.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 6 May 2011 15:02:37 +0000 (15:02 +0000)]
Add a test for visibility:hidden for plugins
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Fri, 6 May 2011 14:46:49 +0000 (14:46 +0000)]
2011-05-06 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix with gcc 4.6.0 on linux and c++0x support.
std::tr1::has_trivial_constructor is in <tr1/memory>.
* wtf/TypeTraits.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Fri, 6 May 2011 14:35:27 +0000 (14:35 +0000)]
2011-05-06 Andreas Kling <andreas.kling@nokia.com>
Unreviewed Qt 4.8 build fix.
* WebCore.pro: Don't set HAVE_QRAWFONT yet. Left a FIXME so we can
enable it after the 4.8 bots are updated with the full QRawFont APIs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 6 May 2011 13:48:58 +0000 (13:48 +0000)]
2011-05-06 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: editing CSS in the Resources panel and not committing does not revert the change.
https://bugs.webkit.org/show_bug.cgi?id=60319
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame.prototype.cancelEditing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rgabor@webkit.org [Fri, 6 May 2011 13:24:51 +0000 (13:24 +0000)]
[Qt] Use qt-arm platform instead of qt-linux on ARM platform.
Reviewed by Csaba Osztrogonác.
* Scripts/old-run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 6 May 2011 10:51:13 +0000 (10:51 +0000)]
Unreviewed expectations update.
[Qt]fast/events/backspace-navigates-back.html fails
https://bugs.webkit.org/show_bug.cgi?id=60349
* platform/mac-wk2/Skipped: Add fast/events/backspace-navigates-back.html because of missing layoutTestController.setEditingBehavior().
* platform/qt-arm/Skipped: Add fast/events/backspace-navigates-back.html.
* platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
* platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
* platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
* platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
* platform/qt-mac/Skipped: Add fast/events/backspace-navigates-back.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 6 May 2011 09:17:06 +0000 (09:17 +0000)]
2011-05-06 Philippe Normand <pnormand@igalia.com>
Windows DRT needs an implementation of shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=59081
Skip media/video-controls-visible-audio-only.html that now
requires shadowRoot support.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 May 2011 08:58:44 +0000 (08:58 +0000)]
2011-05-06 Joe Mason <jmason@rim.com>
Reviewed by Adam Barth.
WebSocket urls should always be encoded as UTF-8. Relative urls should not be expanded.
https://bugs.webkit.org/show_bug.cgi?id=57138
* http/tests/websocket/tests/url-with-nonascii-query-expected.txt: Added.
* http/tests/websocket/tests/url-with-nonascii-query.html: Added.
* http/tests/websocket/tests/url-parsing-expected.txt: Failure message for relative url has changed since it is no longer expanded.
2011-05-06 Joe Mason <jmason@rim.com>
Reviewed by Adam Barth.
WebSocket urls should always be encoded as UTF-8.
https://bugs.webkit.org/show_bug.cgi?id=57138
Change WebSocket::connect to take the raw URL string and parse it
internally using the simple KURL constructor, which expects an absolute
UTF-8 encoded URL. This ensures that all code that creates a WebSocket
goes through this method instead of completeURL.
Test: http/tests/websocket/tests/url-with-nonascii-query.html
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocketConstructor::constructJSWebSocket): Pass String instead of KURL to WebSocket::connect().
* websockets/WebSocket.cpp:
(WebCore::WebSocket::connect): Now takes a String instead of a KURL and parses it using UTF-8.
* websockets/WebSocket.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 May 2011 08:42:10 +0000 (08:42 +0000)]
2011-05-06 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Make CSSStyleSelector::applyProperty() CSSPropertyWebkitColorCorrection case use appropriate macro.
https://bugs.webkit.org/show_bug.cgi?id=60339
No tests added as no functionality changed.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use correct macro for CSSPropertySpeak.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::initialColorSpace):
Add initialColorSpace() static method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 6 May 2011 08:33:26 +0000 (08:33 +0000)]
2011-05-06 MORITA Hajime <morrita@google.com>
Unreviewed, marking tests whose expectations became obsolete since r85926.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 May 2011 08:27:55 +0000 (08:27 +0000)]
2011-05-06 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Make RenderStyle::setPageBreakInside() reject unsupported enum values.
https://bugs.webkit.org/show_bug.cgi?id=60235
No tests added as no functionality changed.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove special-case code and use appropriate macro.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setPageBreakInside):
Assert that only supported values are used.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 May 2011 08:17:21 +0000 (08:17 +0000)]
2011-05-06 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Move burden of checking for BJustify box alignment into RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=60246
No new tests added as no functionality changed.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove special-case logic checking for BJUSTIFY and use existing macro.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBoxAlign):
Assert valid values are used.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 6 May 2011 08:00:43 +0000 (08:00 +0000)]
2011-05-03 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
Layout tests shouldn't have to hard code media controller element locations
https://bugs.webkit.org/show_bug.cgi?id=28220
New mediaControlsButtonCoordinates() function to get the middle
coordinates of a media controls button. This avoids hardcoding
positions in the tests.
Also unskipped the affected GTK media tests now passing.
* media/audio-delete-while-step-button-clicked.html:
* media/video-controls-transformed.html:
* media/video-controls-zoomed.html:
* media/video-test.js:
(mediaControlsButtonCoordinates):
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 May 2011 07:48:52 +0000 (07:48 +0000)]
2011-05-06 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Make CSSStyleSelector::applyProperty() CSSPropertyPointerEvents use the correct macro.
https://bugs.webkit.org/show_bug.cgi?id=60338
No tests added as no functionality changed.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use correct macro for CSSPropertySpeak.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 6 May 2011 07:47:03 +0000 (07:47 +0000)]
2011-05-06 MORITA Hajime <morrita@google.com>
Unreviewed flakiness marking. (send-form-data-with-sliced-file.html)
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 6 May 2011 07:45:49 +0000 (07:45 +0000)]
2011-05-06 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after r85860.
* UIProcess/API/gtk/PageClientImpl.h: Fix typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 6 May 2011 07:43:35 +0000 (07:43 +0000)]
2011-05-06 MORITA Hajime <morrita@google.com>
Unreviewed flakiness marking. (resource-tree-frame-navigate.html)
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 6 May 2011 07:39:11 +0000 (07:39 +0000)]
Unreviewed expectations update.
* platform/mac-wk2/Skipped:
- Add http/tests/navigation/response204.html because of missing layoutTestController.queueLoad()
* platform/qt-arm/Skipped:
- Add fast/css/hover-update.html, because it fails intermittently.
- Add failing http/tests/websocket/tests/frame-lengths.html and http/tests/websocket/tests/simple-stress.html.
* platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
* platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
* platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
* platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
* platform/qt-wk2/Skipped:
- Add new but failing test: editing/pasteboard/paste-placeholder-input.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Fri, 6 May 2011 07:35:46 +0000 (07:35 +0000)]
2011-05-06 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Alexey Proskuryakov.
Build fix with gcc 4.6 and c++0x support.
https://bugs.webkit.org/show_bug.cgi?id=60284
When enabling support of c++0x the compilation fails because of an
ambiguous overload error. In this code when constructing the pair
we use the new c++0x rvalue reference feature (&&). It means we are
calling String(const WTF::AtomicString&) which becomes ambiguous because
it has an overload WTF::String::String(const WTF::String&) and usually one
with the native port string type (e.g. QString). In this code we want the
String version because the pair store Strings.
No new tests, build fix.
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 6 May 2011 07:33:46 +0000 (07:33 +0000)]
2011-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Ojan Vafai.
Add an option to NRWT to skip failing tests
https://bugs.webkit.org/show_bug.cgi?id=60295
This option is similar to the way old-run-webkit-tests works. We're
planning to use this option on the testing EWS bots because they don't
use information from failing tests yet.
* Scripts/webkitpy/layout_tests/layout_package/manager.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdn@chromium.org [Fri, 6 May 2011 07:33:18 +0000 (07:33 +0000)]
2011-05-06 Cris Neckar <cdn@chromium.org>
Reviewed by Dirk Schulze.
Change maxEffectRect to a FloatRect.
https://bugs.webkit.org/show_bug.cgi?id=59551
* svg/filters/filter-after-transform-crash-expected.txt: Added.
* svg/filters/filter-after-transform-crash.svg: Added.
2011-05-06 Cris Neckar <cdn@chromium.org>
Reviewed by Dirk Schulze.
Tests for crash when a transform is applied to certain filters.
https://bugs.webkit.org/show_bug.cgi?id=59551
Test: svg/filters/filter-after-transform-crash.svg
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::determineAbsolutePaintRect):
* platform/graphics/filters/FEConvolveMatrix.h:
(WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
* platform/graphics/filters/FEDisplacementMap.h:
(WebCore::FEDisplacementMap::determineAbsolutePaintRect):
* platform/graphics/filters/FEFlood.h:
(WebCore::FEFlood::determineAbsolutePaintRect):
* platform/graphics/filters/FELighting.h:
(WebCore::FELighting::determineAbsolutePaintRect):
* platform/graphics/filters/FETile.h:
(WebCore::FETile::determineAbsolutePaintRect):
* platform/graphics/filters/FETurbulence.h:
(WebCore::FETurbulence::determineAbsolutePaintRect):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::isFilterSizeValid):
(WebCore::FilterEffect::determineAbsolutePaintRect):
(WebCore::FilterEffect::asUnmultipliedImage):
(WebCore::FilterEffect::asPremultipliedImage):
(WebCore::FilterEffect::copyUnmultipliedImage):
(WebCore::FilterEffect::copyPremultipliedImage):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):
* platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::maxEffectRect):
(WebCore::FilterEffect::setMaxEffectRect):
* rendering/svg/RenderSVGResourceFilter.cpp:
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 6 May 2011 07:27:25 +0000 (07:27 +0000)]
Tools:
2011-05-04 Philippe Normand <pnormand@igalia.com>
Reviewed by Dimitri Glazkov.
Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034
shadowPseudoId support in the various LayoutTestController
implementations.
* DumpRenderTree/LayoutTestController.cpp:
(shadowPseudoIdCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::shadowPseudoId):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::shadowPseudoId):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::shadowPseudoId):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::shadowPseudoId):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::shadowPseudoId):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::shadowPseudoId):
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::shadowPseudoId):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
WebKit2:
2011-05-05 Philippe Normand <pnormand@igalia.com>
Reviewed by Dimitri Glazkov.
Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleShadowPseudoId):
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::elementRemoveShadowRoot):
(WebKit::InjectedBundleNodeHandle::elementShadowPseudoId):
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
WebKit/win:
2011-05-04 Philippe Normand <pnormand@igalia.com>
Reviewed by Dimitri Glazkov.
Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034
* DOMCoreClasses.cpp:
(DOMElement::shadowPseudoId):
* DOMCoreClasses.h:
WebKit/qt:
2011-05-04 Philippe Normand <pnormand@igalia.com>
Reviewed by Dimitri Glazkov.
Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::shadowPseudoId):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
WebKit/mac:
2011-05-04 Philippe Normand <pnormand@igalia.com>
Reviewed by Dimitri Glazkov.
Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034
* DOM/WebDOMOperations.mm:
(-[DOMElement _shadowPseudoId]):
* DOM/WebDOMOperationsPrivate.h:
WebKit/gtk:
2011-05-04 Philippe Normand <pnormand@igalia.com>
Reviewed by Dimitri Glazkov.
Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::shadowPseudoId):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
WebKit/chromium:
2011-05-04 Philippe Normand <pnormand@igalia.com>
Reviewed by Dimitri Glazkov.
Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034
* public/WebElement.h:
* src/WebElement.cpp:
(WebKit::WebElement::shadowPseudoId):
LayoutTests:
2011-05-04 Philippe Normand <pnormand@igalia.com>
Reviewed by Dimitri Glazkov.
Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034
* media/video-controls-transformed.html: Refactored to use the
pseudoShadowId() LayoutTestController method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 6 May 2011 07:19:24 +0000 (07:19 +0000)]
2011-05-06 MORITA Hajime <morrita@google.com>
Unreviewed flakiness marking. (test_boolean_expr.html)
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 May 2011 07:11:59 +0000 (07:11 +0000)]
2011-05-06 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Use cast to convert primitive value to FontSmoothingMode.
https://bugs.webkit.org/show_bug.cgi?id=60242
No tests added as no functionality changed.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use cast to convert primitive value to FontSmoothingMode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 6 May 2011 07:06:56 +0000 (07:06 +0000)]
2011-05-06 Adam Barth <abarth@webkit.org>
EWS can't reject patches
https://bugs.webkit.org/show_bug.cgi?id=60345
We're supposed to use patch.id() for the attachment ID, silly.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 May 2011 06:46:53 +0000 (06:46 +0000)]
2011-05-05 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Make CSSPropertySpeak use the correct macro.
https://bugs.webkit.org/show_bug.cgi?id=60335
No tests added as no functionality changed.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use correct macro for CSSPropertySpeak.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 6 May 2011 06:44:48 +0000 (06:44 +0000)]
2011-05-05 MORITA Hajime <morrita@google.com>
Unreviewed flakiness marking.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jam@chromium.org [Fri, 6 May 2011 06:25:47 +0000 (06:25 +0000)]
2011-05-05 John Abd-El-Malek <jam@chromium.org>
Reviewed by James Robinson.
[chromium] Make IndexedDB code use WebPermissionClient API
https://bugs.webkit.org/show_bug.cgi?id=60340
* public/WebPermissionClient.h:
(WebKit::WebPermissionClient::allowIndexedDB):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::open):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Fri, 6 May 2011 06:22:11 +0000 (06:22 +0000)]
2011-05-05 Eric Carlson <eric.carlson@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/
9390864>
https://bugs.webkit.org/show_bug.cgi?id=60343
Crash on Recovery System when trying to load page that includes media element
Automated test not possible, tested manually.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable): Only return true if
AVFoundation and CoreMedia are installed.
* platform/mac/SoftLinking.h: Define SOFT_LINK_FRAMEWORK_OPTIONAL, identical to
SOFT_LINK_FRAMEWORK except that it doesn't ASSERT if the framework doesn't exist.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 6 May 2011 06:06:57 +0000 (06:06 +0000)]
2011-05-05 MORITA Hajime <morrita@google.com>
Unreviewed attempt to error fix on test_expectations.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 6 May 2011 05:38:21 +0000 (05:38 +0000)]
2011-05-05 MORITA Hajime <morrita@google.com>
Unreviewed error fix on test_expectations.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 6 May 2011 03:44:36 +0000 (03:44 +0000)]
2011-05-05 MORITA Hajime <morrita@google.com>
Unreviewed error fix on test_expectations.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 6 May 2011 03:36:49 +0000 (03:36 +0000)]
2011-05-05 MORITA Hajime <morrita@google.com>
Unreviewed addding skip line for full-screen-stacking-context.html.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Fri, 6 May 2011 02:29:09 +0000 (02:29 +0000)]
2011-05-05 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Live streams sometimes won't play with AVFoundation backend
https://bugs.webkit.org/show_bug.cgi?id=58961
rdar://problem/
9284748
Tested manually because we don't have any live streams to test in DRT.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Don't special case seeking, assume
AVFoundation will notify us when internal states change.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Make m_timeObserver
a RetainPtr
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 6 May 2011 02:18:23 +0000 (02:18 +0000)]
2011-05-05 Ojan Vafai <ojan@chromium.org>
Now that win has a failing result, chromium-win needs to
have the passing result. http://trac.webkit.org/changeset/85911
* platform/chromium/fast/harness/results-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 6 May 2011 02:04:38 +0000 (02:04 +0000)]
2011-05-05 Ojan Vafai <ojan@chromium.org>
Move failing result as it appears to be failing on all Apple Win platforms.
* platform/win/fast/harness/results-expected.txt: Renamed from LayoutTests/platform/win-7sp0/fast/harness/results-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
evan@chromium.org [Fri, 6 May 2011 01:43:00 +0000 (01:43 +0000)]
2011-05-05 Evan Martin <evan@chromium.org>
Unreviewed, just skipping a test.
New test fast/events/backspace-nagivates-back fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=60311
Skip this test until Antonoi has time to look at it.
* platform/qt-linux/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jcivelli@chromium.org [Fri, 6 May 2011 01:37:54 +0000 (01:37 +0000)]
2011-05-05 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Added convenience methods to convert from a byte to hex ASCII digit
characters and vice-versa.
https://bugs.webkit.org/show_bug.cgi?id=59834
* wtf/ASCIICType.h:
(WTF::toASCIIHexValue):
(WTF::lowerNibbleToASCIIHexDigit):
(WTF::upperNibbleToASCIIHexDigit):
2011-05-05 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Adding quoted-printable encoding/decoding capabilities.
This is needed for MHTML support.
https://bugs.webkit.org/show_bug.cgi?id=59834
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/text/QuotedPrintable.cpp: Added.
* platform/text/QuotedPrintable.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 6 May 2011 01:00:22 +0000 (01:00 +0000)]
2011-05-05 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
REGRESSION (r85689): Unresponsive timer firing when closing background tabs
<rdar://problem/
9385988>
https://bugs.webkit.org/show_bug.cgi?id=60325
When calling WKPageTryClose(), if the page close succeeded, the notification to stop
the responsiveness timer would be dropped because the page was closed by the time it
got to the UIProcess.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::closePage):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
Add parameter to closePage stipulating whether or not to stop the responsiveness timer.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::tryClose):
(WebKit::WebPage::sendClose):
Instead of sending a StopResponsivenessTimer message after sending the ClosePage message,
add a bit to the ClosePage message.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 6 May 2011 00:52:31 +0000 (00:52 +0000)]
Unreviewed, partial rollout of r85843 and r85824. r85897 made these expected results unnecessary.
* platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.txt: Removed.
* platform/chromium-win/fullscreen/full-screen-stacking-context-expected.txt: Removed.
* platform/gtk/fullscreen/full-screen-stacking-context-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 6 May 2011 00:48:07 +0000 (00:48 +0000)]
Fixed typos in a comment
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 May 2011 00:28:21 +0000 (00:28 +0000)]
2011-05-05 Steve Lacey <sjl@chromium.org>
Reviewed by Ojan Vafai.
Fix generation of results html file by passing relative path to scm
methods.
Generate diff images for results html file.
https://bugs.webkit.org/show_bug.cgi?id=60086
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
imasaki@chromium.org [Fri, 6 May 2011 00:19:36 +0000 (00:19 +0000)]
2011-05-05 Kenji Imasaki <imasaki@chromium.org>
Reviewed by Jian Li.
[Chromium] Remove non-flaky tests (BUGCR81682, BUGCR80067)
and skip one unsupported test in test expectation file (BUGCR59399).
https://bugs.webkit.org/show_bug.cgi?id=60282
The skipped test is a cliking test that is specific to Mac and we
(Chrome Video Stack team) decided not to support it.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 6 May 2011 00:12:45 +0000 (00:12 +0000)]
2011-05-05 Andy Estes <aestes@apple.com>
Reviewed by Eric Seidel.
Implement document.innerHTML
https://bugs.webkit.org/show_bug.cgi?id=60316
ASSERT that contextElement is non-0 when constructing a HTMLTreeBuilder
for fragment parsing. This assertion will become invalid when
document.innerHTML is implemented, which is the only case where HTML5
specifies that a fragment will not have a context element.
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 6 May 2011 00:12:05 +0000 (00:12 +0000)]
[wx] Unreviewed build fixes after recent trunk changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 6 May 2011 00:09:17 +0000 (00:09 +0000)]
Source/WebCore: WebCore part of <rdar://problem/
9155590> Broken animation in iAd producer
Reviewed by Simon Fraser.
* WebCore.exp.in: Export wkExecutableWasLinkedOnOrBeforeSnowLeopard.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): Account for the binary-compatiblity
check in Core Animation.
* platform/mac/WebCoreSystemInterface.h: Added wkExecutableWasLinkedOnOrBeforeSnowLeopard.
* platform/mac/WebCoreSystemInterface.mm: Ditto.
Source/WebKit/mac: WebKit part of <rdar://problem/
9155590> Broken animation in iAd producer
Reviewed by Simon Fraser.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.
Source/WebKit2: WebKit2 part of <rdar://problem/
9155590> Broken animation in iAd producer
Reviewed by Simon Fraser.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.
WebKitLibraries: WebKitSystemInterface part of <rdar://problem/
9155590> Broken animation in iAd producer
Reviewed by Simon Fraser.
* WebKitSystemInterface.h: Added WKExecutableWasLinkedOnOrBeforeSnowLeopard().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 5 May 2011 23:56:19 +0000 (23:56 +0000)]
2011-05-05 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2 (Mac): Background tabs/windows can force themselves to the front
<rdar://problem/
9386346>
https://bugs.webkit.org/show_bug.cgi?id=60315
* platform/mac/WidgetMac.mm:
(WebCore::Widget::setFocus):
It is incorrect for us to call Chrome::focus() here, which could bring a window/tab
to the front. Calling focusNSView() was only necessary because in WebKit we must inform
the platform widget that the focus has changed. WebKit2 Mac now matches other ports.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 5 May 2011 23:54:06 +0000 (23:54 +0000)]
2011-05-05 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Seidel.
Rebaseline various media tests after absolute positioning change. This rebaseline also
fixes outstanding minor pixel diffs.
[chromium] Rebaseline various media tests after controls absolute positioning changes
https://bugs.webkit.org/show_bug.cgi?id=60230
* platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
* platform/chromium-gpu-linux/media/video-no-audio-expected.png:
* platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
* platform/chromium-gpu-mac/media/video-no-audio-expected.png:
* platform/chromium-gpu-win/media/video-display-toggle-expected.png:
* platform/chromium-gpu-win/media/video-no-audio-expected.png:
* platform/chromium-linux/media/audio-controls-rendering-expected.png:
* platform/chromium-linux/media/media-document-audio-repaint-expected.png:
* platform/chromium-linux/media/video-controls-rendering-expected.png:
* platform/chromium-linux/media/video-display-toggle-expected.png:
* platform/chromium-linux/media/video-empty-source-expected.png:
* platform/chromium-linux/media/video-no-audio-expected.png:
* platform/chromium-linux/media/video-volume-slider-expected.png:
* platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
* platform/chromium-mac-leopard/media/audio-controls-rendering-expected.txt: Removed.
* platform/chromium-mac-leopard/media/controls-after-reload-expected.txt: Removed.
* platform/chromium-mac-leopard/media/controls-strict-expected.txt: Removed.
* platform/chromium-mac-leopard/media/controls-styling-expected.txt: Removed.
* platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
* platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
* platform/chromium-mac-leopard/media/video-empty-source-expected.png:
* platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Removed.
* platform/chromium-mac-leopard/media/video-no-audio-expected.png:
* platform/chromium-mac-leopard/media/video-no-audio-expected.txt: Removed.
* platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
* platform/chromium-mac-leopard/media/video-volume-slider-expected.txt: Removed.
* platform/chromium-mac/media/audio-controls-rendering-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.txt:
* platform/chromium-mac/media/controls-after-reload-expected.txt:
* platform/chromium-mac/media/controls-strict-expected.txt:
* platform/chromium-mac/media/controls-styling-expected.txt:
* platform/chromium-mac/media/controls-without-preload-expected.txt:
* platform/chromium-mac/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
* platform/chromium-mac/media/video-controls-rendering-expected.png:
* platform/chromium-mac/media/video-controls-rendering-expected.txt:
* platform/chromium-mac/media/video-display-toggle-expected.png:
* platform/chromium-mac/media/video-display-toggle-expected.txt:
* platform/chromium-mac/media/video-empty-source-expected.png:
* platform/chromium-mac/media/video-empty-source-expected.txt:
* platform/chromium-mac/media/video-no-audio-expected.png:
* platform/chromium-mac/media/video-no-audio-expected.txt:
* platform/chromium-mac/media/video-volume-slider-expected.png:
* platform/chromium-mac/media/video-volume-slider-expected.txt:
* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/audio-controls-rendering-expected.txt:
* platform/chromium-win/media/controls-after-reload-expected.txt:
* platform/chromium-win/media/controls-strict-expected.txt:
* platform/chromium-win/media/controls-styling-expected.txt:
* platform/chromium-win/media/controls-without-preload-expected.txt:
* platform/chromium-win/media/media-document-audio-repaint-expected.png:
* platform/chromium-win/media/media-document-audio-repaint-expected.txt:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.txt:
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.txt:
* platform/chromium-win/media/video-empty-source-expected.png:
* platform/chromium-win/media/video-empty-source-expected.txt:
* platform/chromium-win/media/video-no-audio-expected.png:
* platform/chromium-win/media/video-no-audio-expected.txt:
* platform/chromium-win/media/video-volume-slider-expected.png:
* platform/chromium-win/media/video-volume-slider-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 5 May 2011 23:34:19 +0000 (23:34 +0000)]
2011-05-05 Andy Estes <aestes@apple.com>
Reviewed by Daniel Bates.
update-webkit should handle Internal using a different VCS than OpenSource.
https://bugs.webkit.org/show_bug.cgi?id=60310
isGit() and isSVN() cache their results, so Internal will always be
updated using the VCS commands used for OpenSource. If Internal uses a
different VCS, this will fail. Fix this by calling isGitDirectory() and
isSVNDirectory() instead, which do not cache their results.
* Scripts/update-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Thu, 5 May 2011 23:07:57 +0000 (23:07 +0000)]
2011-05-05 Jer Noble <jer.noble@apple.com>
Reviewed by Tony Chang.
full-screen-stacking-context-expected.txt should be under platform/mac
https://bugs.webkit.org/show_bug.cgi?id=60236
Make the text output of full screen pixel tests platform agnostic.
* fullscreen/full-screen-stacking-context-expected.txt:
* fullscreen/full-screen-test.js:
* fullscreen/full-screen-zIndex-expected.txt:
* platform/chromium-linux/fullscreen/full-screen-zIndex-expected.txt: Removed.
* platform/chromium-win/fullscreen/full-screen-zIndex-expected.txt: Removed.
* platform/gtk/fullscreen/full-screen-zIndex-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 5 May 2011 22:42:32 +0000 (22:42 +0000)]
2011-05-05 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
nrwt: revamp integration tests incl. tests for servers
https://bugs.webkit.org/show_bug.cgi?id=59985
This change adds the ability to run "integration tests" that
depend on (and affect) the local environment on your machine.
These tests can be run manually by invoking python on the
test file in question and passing the '-i' flag, but are
not run automatically as part of test-webkitpy.
Integration tests are identified by being methods named as
"integration_test_*" instead of "test_*", and we use a
custom TestLoader instead of the default one provided by
unittest.
This change also adds a protected "_default_to_apache" method
to the port object so we can do the right thing when starting
and stopping web servers with less mechanism.
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 5 May 2011 22:39:16 +0000 (22:39 +0000)]
2011-05-05 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
https://bugs.webkit.org/show_bug.cgi?id=60173
* platform/chromium/test_expectations.txt:
Adding expected failures for the the switch to Ganesh
2011-05-05 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
https://bugs.webkit.org/show_bug.cgi?id=60173
* page/Page.cpp:
(WebCore::Page::sharedGraphicsContext3D):
Flipping the switch to make Skia the default for the accelerated 2d canvas
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 5 May 2011 22:38:09 +0000 (22:38 +0000)]
2011-05-05 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
https://bugs.webkit.org/show_bug.cgi?id=60101
* fast/parser/close-while-stopping-expected.txt: Added.
* fast/parser/close-while-stopping.html: Added.
2011-05-05 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
https://bugs.webkit.org/show_bug.cgi?id=60101
Test: fast/parser/close-while-stopping.html
* dom/Document.cpp:
(WebCore::Document::close): According to http://www.whatwg.org/specs/web-apps/current-work/#dom-document-close,
the close() steps should be aborted if there is no script-created parser
associated with the document. Our parser lives throughout
http://www.whatwg.org/specs/web-apps/current-work/#the-end, but it seems
the spec doesn't consider the parser active any more. So to properly
respect this, we need to check that the parser is still parsing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
evan@chromium.org [Thu, 5 May 2011 22:23:22 +0000 (22:23 +0000)]
2011-05-03 Evan Martin <evan@chromium.org>
Reviewed by Ojan Vafai.
REGRESSION: backspace should not go back on Linux
https://bugs.webkit.org/show_bug.cgi?id=59731
Add a test that verifies that pressing backspace goes back on Mac
and Windows but does not go back on Linux.
* fast/events/backspace-navigates-back-expected.txt: Added.
* fast/events/backspace-navigates-back.html: Added.
2011-04-28 Evan Martin <evan@chromium.org>
Reviewed by Ojan Vafai.
REGRESSION: backspace should not go back on Linux
https://bugs.webkit.org/show_bug.cgi?id=59731
Add a new EditingBehavior, shouldNavigateBackOnBackspace, which is false on
Linux, and test for it in the default backspace handler.
* editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
* page/EventHandler.cpp:
(WebCore::EventHandler::defaultBackspaceEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Thu, 5 May 2011 22:14:29 +0000 (22:14 +0000)]
2011-05-05 Alpha Lam <hclam@chromium.org>
Build fix. Not reviewed.
Add test expectations.
* platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
* platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
* platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
* platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
* platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
* platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
* platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
* platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 5 May 2011 22:10:02 +0000 (22:10 +0000)]
2011-05-05 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Kenneth Russell.
Framebuffer object is being created twice
https://bugs.webkit.org/show_bug.cgi?id=60207
Does not create more than one opengl framebuffer
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/gtk/DrawingBufferGtk.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 5 May 2011 22:09:02 +0000 (22:09 +0000)]
2011-05-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Beth Dakin.
Every RenderLayer registers itself as a ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=59650
Rather than registering every RenderLayer as a ScrollableArea
on layer creation, only register RenderLayers which are overflow-
scrollable. Use the m_scrollableAreaPage pointer to keep track
of whether we've registered to avoid excess work.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::scrollsOverflow):
(WebCore::RenderLayer::styleChanged):
* rendering/RenderLayer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 5 May 2011 22:06:26 +0000 (22:06 +0000)]
Update pixel results for draws-gradient.html to have an alpha channel
These pixel results were generated in r71418, when DRT was changed not to use an alpha
channel for pixel results. DRT was changed back to using an alpha channel in r71516, but
these pixel results were never updated. Now that DRT ensures that the alpha channel is
filled with constant opacity, we can safely update these pixel results without negatively
affecting their appearance. (The draws-gradient plugin uses ::GradientFill, which fills the
alpha channel with 0, so the plugin would have shown up as fully transparent in the pixel
results if DRT didn't modify the alpha channel.)
Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
generated due to alpha channel weirdness
Reviewed by Sam Weinig.
LayoutTests:
* platform/win/platform/win/plugins/draws-gradient-expected.png: Regenerated. Looks the same
as before, but with an alpha channel.
Tools:
Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
alpha channel will even get filled with zeros (like when ::GradientFill is used). To
safeguard against this, we fill the alpha channel with constant full opacity after the
WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
results need an alpha channel, too.)
* DumpRenderTree/win/PixelDumpSupportWin.cpp:
(makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
constant full opacity.
(createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
in a CGContext or cairo_surface.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 5 May 2011 22:05:36 +0000 (22:05 +0000)]
Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
Passing true tells the test harness to dump pixels even though we're not dumping a render
tree.
Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
WebKitTestRunner doesn't result in pixel results being generated
Reviewed by Sam Weinig.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
argument to dumpAsText.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
* WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
developers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 5 May 2011 22:04:21 +0000 (22:04 +0000)]
2011-05-05 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [WK2] Add method to disable plugins under WK2
https://bugs.webkit.org/show_bug.cgi?id=57796
* config.h: Allow PLUGIN_ARCHITECTURE_UNSUPPORTED to be defined on build command line
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Thu, 5 May 2011 21:59:17 +0000 (21:59 +0000)]
2011-05-05 Jer Noble <jer.noble@apple.com>
Reviewed by Steve Falkenburg.
Workaround iTunes' incorrect registry entry for .m4a extensions.
https://bugs.webkit.org/show_bug.cgi?id=60229
No new tests, as a test already exits for .m4a support (LayoutTests/media/audio-mpeg4-supported.html).
The test failed to catch this regression because the build bots haven't installed iTunes.
Add a hard-coded MIME type mapping for 'm4a' -> 'audio/x-m4a'.
* platform/win/MIMETypeRegistryWin.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 5 May 2011 21:57:01 +0000 (21:57 +0000)]
2011-05-05 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Minor rebaselines for gtk after my r85876.
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 5 May 2011 21:49:55 +0000 (21:49 +0000)]
2011-05-05 Tony Chang <tony@chromium.org>
Remove google-chrome-linux results. We're switching the official
builders from hardy to lucid and want to clear the old hardy based
results.
* platform/google-chrome-linux32/css1: Removed.
* platform/google-chrome-linux32/css2.1: Removed.
* platform/google-chrome-linux32/editing: Removed.
* platform/google-chrome-linux32/fast: Removed.
* platform/google-chrome-linux32/plugins: Removed.
* platform/google-chrome-linux32/svg: Removed.
* platform/google-chrome-linux32/tables: Removed.
* platform/google-chrome-linux32/transforms: Removed.
* platform/google-chrome-linux64/fast: Removed.
* platform/google-chrome-linux64/svg: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Thu, 5 May 2011 21:49:16 +0000 (21:49 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 5 May 2011 21:42:59 +0000 (21:42 +0000)]
2011-05-05 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Minor rebaselines for qt after my r85876.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 5 May 2011 21:41:06 +0000 (21:41 +0000)]
2011-05-05 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
Modify the chromium expectations so that you no longer need to
specify both the operating system and the version. I.e., you
don't need "MAC LEOPARD", just "LEOPARD".
* platform/chromium/test_expectations.txt:
2011-05-05 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: merge os, version fields in test config
https://bugs.webkit.org/show_bug.cgi?id=60004
This change removes the 'o/s' field from the TestConfiguration
object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
the expectations file to macros that expand to the version names
for each platform.
This means that you can once again put any subset of the
operating system versions on a single line, e.g.:
BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
This change will break any existing test_expectations.txt
file that uses the "OS-VERSION" macros, which are no longer
needed. It turns out they were never needed, as just VERSION
by itself was sufficient. The test_expectations.txt file should
be updated accordingly prior to landing this change.
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
* Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
* Scripts/webkitpy/layout_tests/port/base.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log