14 years agoFix http://bugs.webkit.org/show_bug.cgi?id=17007 ([GTK] autogen.sh attempts to use...
mrowe@apple.com [Sat, 26 Jan 2008 12:32:49 +0000 (12:32 +0000)]
Fix bugs.webkit.org/show_bug.cgi?id=17007 ([GTK] autogen.sh attempts to use "libtoolize" on the Mac).

Reviewed by Alp Toker.

libtoolize is installed as glibtoolize on Mac OS X to avoid naming conflicts
with other system commands.  Check for the presence of glibtoolize if libtoolize
cannot be found.

* autogen.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix http://bugs.webkit.org/show_bug.cgi?id=17001 (Build error with Gtk port on Mac...
mrowe@apple.com [Sat, 26 Jan 2008 10:01:46 +0000 (10:01 +0000)]
Fix bugs.webkit.org/show_bug.cgi?id=17001 (Build error with Gtk port on Mac OS X).

Reviewed by Darin Adler.

If both XP_MACOSX and XP_UNIX are defined then X11.h and Carbon.h will both be included.
These provide conflicting definitions for a type named 'Cursor'.  As XP_UNIX is set by
the build system when targeting X11, it doesn't make sense for XP_MACOSX to also be set
in this instance.

* bindings/npapi.h: Don't define XP_MACOSX if XP_UNIX is defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam and Darin.
eric@webkit.org [Sat, 26 Jan 2008 09:42:39 +0000 (09:42 +0000)]
    Reviewed by Sam and Darin.

        Fire a warning shot in DeprecatedChar's direction.

        Remove DeprecatedChar::isSpace() usage, in preparation for removing DeprecatedChar
        Remove a needless String -> DeprecatedString -> String conversion for <script> tags

        * css/MediaQueryEvaluator.cpp:
        * css/SVGCSSParser.cpp:
        * dom/Position.cpp:
        * editing/TextIterator.cpp:
        * html/HTMLFontElement.cpp:
        * html/HTMLTokenizer.cpp:
        * html/HTMLTokenizer.h:
        * loader/CachedCSSStyleSheet.cpp:
        * loader/TextResourceDecoder.cpp:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        * platform/mac/ClipboardMac.mm:
        * platform/network/HTTPParsers.cpp:
        * platform/text/PlatformString.h:
        * platform/text/StringImpl.cpp:
        * platform/text/StringImpl.h:
        * rendering/InlineFlowBox.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/bidi.cpp:
        * svg/SVGFontFaceElement.cpp:
        * svg/SVGLength.cpp:
        * svg/SVGStyledElement.cpp:
        * xml/XPathParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin@apple.com [Sat, 26 Jan 2008 09:01:40 +0000 (09:01 +0000)]

        Reviewed by Oliver.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17013
          JSC can't round trip certain for-loops

        Test: fast/js/toString-for-var-decl.html

        * kjs/nodes.h: Added PlaceholderTrueNode so we can put nodes into
        for loops without injecting the word "true" into them (nice, but not
        the bug fix). Fixed ForNode constructor so expr1WasVarDecl is set
        only when there is an expression, since it's common for the actual
        variable declaration to be moved by the parser.

        * kjs/nodes2string.cpp:
        (KJS::PlaceholderTrueNode::streamTo): Added. Empty.


        Reviewed by Oliver.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17013
          JSC can't round trip certain for-loops

        * fast/js/resources/toString-for-var-decl.js: Streamlined the test a bit, with more
        of the execution within shouldBe so that exceptions are caught for us. Added a new
        test case reflecting the just-fixed bug.
        * fast/js/toString-for-var-decl-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix typo in changelog
oliver@apple.com [Sat, 26 Jan 2008 07:58:45 +0000 (07:58 +0000)]
Fix typo in changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix for bug 17012: REGRESSION: JSC can't round trip an object literal
oliver@apple.com [Sat, 26 Jan 2008 07:54:50 +0000 (07:54 +0000)]
Fix for bug 17012: REGRESSION: JSC can't round trip an object literal

Reviewed by Maciej.

Add logic to ensure that object literals and function expressions get
parenthesis when necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agofix changelog
slewis@apple.com [Sat, 26 Jan 2008 01:16:29 +0000 (01:16 +0000)]
fix changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago 2008-01-25 U-SLEWIS-WIN\Stephanie <slewis@apple.com>
slewis@apple.com [Sat, 26 Jan 2008 01:09:43 +0000 (01:09 +0000)]
 2008-01-25  U-SLEWIS-WIN\Stephanie  <slewis@apple.com>

         Reviewed by Tim.

         expand workaround for <rdar://5695848> to include js files so that the
         web inspector can work

         * platform/network/cf/ResourceResponseCFNet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
antti@apple.com [Sat, 26 Jan 2008 01:03:17 +0000 (01:03 +0000)]
    Reviewed by Adele.

        (this is for r29798, my commit failed to include the log)

        Windows fix to match r29773
        If the media is playing and the load stalls the playback wont restart by seeking backwards.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
antti@apple.com [Fri, 25 Jan 2008 23:41:25 +0000 (23:41 +0000)]
    Reviewed by Adele.

        Windows fix to match r29773
        If the media is playing and the load stalls the playback wont restart by seeking backwards.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Fri, 25 Jan 2008 23:40:56 +0000 (23:40 +0000)]

        Reviewed by Anders.

        - fix <rdar://problem/5691072> ASSERTION FAILED: isPrepared() when executing an empty statement

        For empty statements, SQLite returns 0 for the statement. We have to cope with that.

        Test: storage/empty-statement.html

        * platform/sql/SQLiteStatement.cpp:
        (WebCore::sqlite3_prepare16_v2): Added overload so we don't need an #if inside the prepare
        (WebCore::SQLiteStatement::SQLiteStatement): Initialize the m_isPrepared boolean. Removed
        the code to add a null character to the end of the string; instead we will use
        (WebCore::SQLiteStatement::prepare): Set m_isPrepared based on the error value returned.
        Use the error value from sqlite3_prepare16_v2, not from lastError().
        (WebCore::SQLiteStatement::step): Assert that the statement is prepared rather than checking
        it at runtime. However, in the case where this is called with m_statement of 0, return
        success rather than an error. That's needed for empty statements.
        (WebCore::SQLiteStatement::finalize): Use early return idiom for clarity. When there is no
        statement, return SQLITE_OK instead of calling lastError().
        (WebCore::SQLiteStatement::reset): Use early return idiom for clarity. When there is no
        statement, return SQLITE_OK rather than SQLITE_ERROR, but assert the statement is prepared.
        (WebCore::SQLiteStatement::executeCommand): Adjust the code that does a prepare so that it
        will work for empty statements. Do we really need to allow calling this without prepare?
        It would be simpler to just be able to assert that it's prepared.
        (WebCore::SQLiteStatement::returnsAtLeastOneResult): Ditto.
        (WebCore::SQLiteStatement::bindBlob): Added some assertions. Return SQLITE_ERROR if this
        is called with m_statement of 0 (should not be possible without assertions firing first).
        Return the actual error code rather than lastError().
        (WebCore::SQLiteStatement::bindText): Ditto. Also simplified the special case for empty
        strings, since it requires any non-null pointer, not a pointer to a global zero character.
        (WebCore::SQLiteStatement::bindInt64): Ditto.
        (WebCore::SQLiteStatement::bindDouble): Ditto.
        (WebCore::SQLiteStatement::bindNull): Ditto.
        (WebCore::SQLiteStatement::bindValue): Moved default case out of the switch to take
        advantage of the gcc compiler warning for unhandled enum values in a switch.
        (WebCore::SQLiteStatement::bindParameterCount): Added assertion and code to handle the
        empty statement case.
        (WebCore::SQLiteStatement::columnCount): Added assertion and changed the code to use
        the early-return idiom.
        (WebCore::SQLiteStatement::getColumnName): Removed getColumnName16 -- we always use 16-bit
        characters and have no reason to ever use the 8-bit function. Added assertions about the
        passed-in column number. It's a little strange that this function checks the column number
        for too-large column numbers, but not for negative ones. I didn't change that for now.
        (WebCore::SQLiteStatement::getColumnText): Ditto.
        (WebCore::SQLiteStatement::getColumnDouble): Ditto.
        (WebCore::SQLiteStatement::getColumnInt): Ditto.
        (WebCore::SQLiteStatement::getColumnInt64): Ditto.
        (WebCore::SQLiteStatement::getColumnBlobAsVector): Ditto.
        (WebCore::SQLiteStatement::getColumnBlob): Tightened up function a bit, including use of
        the early-return idiom and replacing the multiple "size = 0" with a single one at the
        start of the function.
        (WebCore::SQLiteStatement::returnTextResults): Added a failure case when the prepare
        call doesn't work. Cleared the vector earlier to make the failure code simpler. Moved
        the declaration of the result boolean down lower to make it clearer what it's for.
        Changed use of lastError() to call on the database, to make it clearer that there's
        no per-statement last error kept around. It'd be even better to not use lastError() here.
        (WebCore::SQLiteStatement::returnIntResults): Ditto.
        (WebCore::SQLiteStatement::returnInt64Results): Ditto.
        (WebCore::SQLiteStatement::returnDoubleResults): Ditto.
        (WebCore::SQLiteStatement::isExpired): Changed to use || rather than ?: because I think
        it's slightly easier to read that way.

        * platform/sql/SQLiteStatement.h: Removed unneeded includes and forward declarations.
        Also removed unnneeded functions isPrepared, getColumnName16, getColumnText16,
        returnTextResults16, lastError, and lastErrorMsg. Changed prepareAndStep so that it
        checks the result of prepare before callling step. Added a debug-only m_isPrepared boolean.

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::checkIntegrity): Remove 16 suffix from text-related function names.
        (WebCore::IconDatabase::performURLImport): Ditto.
        (WebCore::IconDatabase::pruneUnretainedIcons): Ditto.
        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::clearAllTables): Ditto.
        * storage/Database.cpp:
        (WebCore::retrieveTextResultFromDatabase): Ditto.
        (WebCore::Database::performGetTableNames): Ditto.
        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::fullPathForDatabase): Ditto.
        (WebCore::DatabaseTracker::populateOrigins): Ditto.
        (WebCore::DatabaseTracker::databaseNamesForOrigin): Ditto.
        (WebCore::DatabaseTracker::addDatabase): Ditto.
        * storage/SQLStatement.cpp:
        (WebCore::SQLStatement::execute): Ditto.

        * platform/sql/SQLiteDatabase.h: Removed unneeded includes.
        * storage/SQLResultSet.h: Ditto.
        * storage/SQLResultSetRowList.h: Ditto.


        Reviewed by Anders.

        - test for <rdar://problem/5691072> ASSERTION FAILED: isPrepared() when executing an empty statement

        * storage/empty-statement-expected.txt: Added.
        * storage/empty-statement.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
antti@apple.com [Fri, 25 Jan 2008 23:07:13 +0000 (23:07 +0000)]
    Reviewed by Darin.

        Fix <rdar://problem/5674282>
        Some media tests fail on Windows

        - fix the script to exit cleanly
        - slightly increase the amount of data to hand out before stalling, apparently
          QT on Windows needs more to start playback

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele@apple.com [Fri, 25 Jan 2008 22:28:49 +0000 (22:28 +0000)]

        Reviewed by Sam.

        Fix for <rdar://problem/5679452> Finish tweaking layout/alignment of media controls slider to match QuickTime plug-in

        * css/html4.css: Add horizontal padding to the media slider.
        * rendering/RenderSlider.cpp:
        (WebCore::HTMLSliderThumbElement::defaultEventHandler): Replace use of absoluteBoundingBox() with width() and height()
        (WebCore::RenderSlider::positionForOffset): ditto. Also, use the trackSize() for the maximum offset.
        (WebCore::RenderSlider::layout):  Use contentWidth() and contentHeight() to take padding into account.
        (WebCore::RenderSlider::trackSize): ditto.


        Reviewed by Sam.

        Adding new test and updated results for:
        <rdar://problem/5679452> Finish tweaking layout/alignment of media controls slider to match QuickTime plug-in

        * fast/forms/slider-padding.html: Added.
        * platform/mac/fast/forms/slider-padding-expected.checksum: Added.
        * platform/mac/fast/forms/slider-padding-expected.png: Added.
        * platform/mac/fast/forms/slider-padding-expected.txt: Added.
        * platform/mac/media/audio-controls-rendering-expected.checksum:
        * platform/mac/media/audio-controls-rendering-expected.png:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/broken-video-expected.checksum:
        * platform/mac/media/broken-video-expected.png:
        * platform/mac/media/progress-event-expected.checksum:
        * platform/mac/media/progress-event-expected.png:
        * platform/mac/media/unsupported-rtsp-expected.checksum:
        * platform/mac/media/unsupported-rtsp-expected.png:
        * platform/mac/media/unsupported-tracks-expected.checksum:
        * platform/mac/media/unsupported-tracks-expected.png:
        * platform/mac/media/video-append-source-expected.checksum:
        * platform/mac/media/video-append-source-expected.png:
        * platform/mac/media/video-autoplay-expected.checksum:
        * platform/mac/media/video-autoplay-expected.png:
        * platform/mac/media/video-buffered-expected.checksum:
        * platform/mac/media/video-buffered-expected.png:
        * platform/mac/media/video-controls-expected.checksum:
        * platform/mac/media/video-controls-expected.png:
        * platform/mac/media/video-controls-rendering-expected.checksum:
        * platform/mac/media/video-controls-rendering-expected.png:
        * platform/mac/media/video-controls-rendering-expected.txt:
        * platform/mac/media/video-currentTime-set2-expected.checksum:
        * platform/mac/media/video-currentTime-set2-expected.png:
        * platform/mac/media/video-display-toggle-expected.checksum:
        * platform/mac/media/video-display-toggle-expected.png:
        * platform/mac/media/video-display-toggle-expected.txt:
        * platform/mac/media/video-dom-autoplay-expected.checksum:
        * platform/mac/media/video-dom-autoplay-expected.png:
        * platform/mac/media/video-dom-src-expected.checksum:
        * platform/mac/media/video-dom-src-expected.png:
        * platform/mac/media/video-dom-start-expected.checksum:
        * platform/mac/media/video-dom-start-expected.png:
        * platform/mac/media/video-error-abort-expected.checksum:
        * platform/mac/media/video-error-abort-expected.png:
        * platform/mac/media/video-error-does-not-exist-expected.checksum:
        * platform/mac/media/video-error-does-not-exist-expected.png:
        * platform/mac/media/video-load-networkState-expected.checksum:
        * platform/mac/media/video-load-networkState-expected.png:
        * platform/mac/media/video-load-readyState-expected.checksum:
        * platform/mac/media/video-load-readyState-expected.png:
        * platform/mac/media/video-muted-expected.checksum:
        * platform/mac/media/video-muted-expected.png:
        * platform/mac/media/video-no-autoplay-expected.checksum:
        * platform/mac/media/video-no-autoplay-expected.png:
        * platform/mac/media/video-pause-empty-events-expected.checksum:
        * platform/mac/media/video-pause-empty-events-expected.png:
        * platform/mac/media/video-play-empty-events-expected.checksum:
        * platform/mac/media/video-play-empty-events-expected.png:
        * platform/mac/media/video-play-pause-events-expected.checksum:
        * platform/mac/media/video-play-pause-events-expected.png:
        * platform/mac/media/video-play-pause-exception-expected.checksum:
        * platform/mac/media/video-play-pause-exception-expected.png:
        * platform/mac/media/video-seek-past-end-paused-expected.checksum:
        * platform/mac/media/video-seek-past-end-paused-expected.png:
        * platform/mac/media/video-seek-past-end-playing-expected.checksum:
        * platform/mac/media/video-seek-past-end-playing-expected.png:
        * platform/mac/media/video-seekable-expected.checksum:
        * platform/mac/media/video-seekable-expected.png:
        * platform/mac/media/video-seeking-expected.checksum:
        * platform/mac/media/video-seeking-expected.png:
        * platform/mac/media/video-size-expected.checksum:
        * platform/mac/media/video-size-expected.png:
        * platform/mac/media/video-source-expected.checksum:
        * platform/mac/media/video-source-expected.png:
        * platform/mac/media/video-source-media-expected.checksum:
        * platform/mac/media/video-source-media-expected.png:
        * platform/mac/media/video-source-type-expected.checksum:
        * platform/mac/media/video-source-type-expected.png:
        * platform/mac/media/video-src-change-expected.checksum:
        * platform/mac/media/video-src-change-expected.png:
        * platform/mac/media/video-src-expected.checksum:
        * platform/mac/media/video-src-expected.png:
        * platform/mac/media/video-src-remove-expected.checksum:
        * platform/mac/media/video-src-remove-expected.png:
        * platform/mac/media/video-src-set-expected.checksum:
        * platform/mac/media/video-src-set-expected.png:
        * platform/mac/media/video-src-source-expected.checksum:
        * platform/mac/media/video-src-source-expected.png:
        * platform/mac/media/video-start-expected.checksum:
        * platform/mac/media/video-start-expected.png:
        * platform/mac/media/video-volume-expected.checksum:
        * platform/mac/media/video-volume-expected.png:
        * platform/mac/media/video-width-height-expected.checksum:
        * platform/mac/media/video-width-height-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5674277>
antti@apple.com [Fri, 25 Jan 2008 21:38:28 +0000 (21:38 +0000)]
        Test media/video-display-toggle.html crashes on Windows

        Appears to be some problem in DRT when test ends with layout pending.
        Fixed by forcing layout, this improves test coverage too.

        * media/video-display-toggle.html:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-25 Ori Bernstein <ori@eigenstate.org>
alp@webkit.org [Fri, 25 Jan 2008 18:31:04 +0000 (18:31 +0000)]
2008-01-25  Ori Bernstein  <ori@eigenstate.org>

        Reviewed by Alp Toker.

        WebKitGtk crashes when there is no focused Frame

        Add a null check. focusedFrame() isn't used directly anywhere else so
        this is the only case that needs to be fixed.

        * WebView/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5706788> http/tests/security/cross-frame-access-port-explicit...
ap@webkit.org [Fri, 25 Jan 2008 15:01:01 +0000 (15:01 +0000)]
    <rdar://problem/5706788> http/tests/security/cross-frame-access-port-explicit-domain.html fails on Windows

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago http/tests/xmlhttprequest/readystatechange.html fails on buildbot.
ap@webkit.org [Fri, 25 Jan 2008 14:42:37 +0000 (14:42 +0000)]
    http/tests/xmlhttprequest/readystatechange.html fails on buildbot.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe.
ap@webkit.org [Fri, 25 Jan 2008 11:45:18 +0000 (11:45 +0000)]
    Reviewed by Mark Rowe.

        <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing

        * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
        (matching Mac DRT).
        * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix
sfalken@apple.com [Fri, 25 Jan 2008 01:13:38 +0000 (01:13 +0000)]
    Build fix

        * WebKit.vcproj/WebKit.sln:
        * WebKit.vcproj/WebKit.submit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
sfalken@apple.com [Fri, 25 Jan 2008 01:08:54 +0000 (01:08 +0000)]
    Build fix.

        * JavaScriptCore.vcproj/JavaScriptCore.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
sfalken@apple.com [Fri, 25 Jan 2008 01:07:16 +0000 (01:07 +0000)]
    Build fix.

        * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
weinig@apple.com [Fri, 25 Jan 2008 00:51:55 +0000 (00:51 +0000)]

        Reviewed by Ada Chan.

        Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo

        - Adds simplified UndoManager to windows DRT to allow testing the
          undo/redo code paths in WebCore and WebKit.  This is a temporary
          solution to an issue that should eventually be solved by having a
          shared UndoManager in WebKit.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        * DumpRenderTree/win/UIDelegate.cpp:
        * DumpRenderTree/win/UIDelegate.h:


        Reviewed by Ada Chan.

        <rdar://5131975> DumpRenderTree doesn't support undo/redo

        * platform/win/Skipped: With undo/redo support enabled, we can now
        remove the undo tests from the Skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Better fix for Bug 16996
aroben@apple.com [Thu, 24 Jan 2008 23:50:34 +0000 (23:50 +0000)]
    Better fix for Bug 16996

        Rubberstamped by Mitz.

        * loader/CachedFont.cpp:
        (WebCore::CachedFont::ensureCustomFontData): Don't call
        createFontCustomPlatformData if m_data is null.
        * platform/graphics/gtk/FontCustomPlatformData.cpp:
        (WebCore::createFontCustomPlatformData): Added an assertion.
        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::createFontCustomPlatformData): Ditto.
        * platform/graphics/qt/FontCustomPlatformData.cpp:
        (WebCore::createFontCustomPlatformData): Ditto.
        * platform/graphics/win/FontCustomPlatformData.cpp:
        (WebCore::createFontCustomPlatformData): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix Bug 16996: Crash in createFontCustomPlatformData when loading 0-byte font via...
aroben@apple.com [Thu, 24 Jan 2008 23:13:26 +0000 (23:13 +0000)]
 Fix Bug 16996: Crash in createFontCustomPlatformData when loading 0-byte font via @font-face


         Fix Bug 16996: Crash in createFontCustomPlatformData when loading
         0-byte font via @font-face


         Reviewed by Hyatt.

         Test: fast/loader/font-face-empty.html

         * platform/graphics/win/FontCustomPlatformData.cpp:
         (WebCore::createFontCustomPlatformData): Null-check the buffer


         Test for Bug 16996: Crash in createFontCustomPlatformData when loading
         0-byte font via @font-face


         Reviewed by Hyatt.

         * fast/loader/font-face-empty-expected.txt: Added.
         * fast/loader/font-face-empty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate results for an editing test that changed from Acid3 fix.
hyatt@apple.com [Thu, 24 Jan 2008 22:02:11 +0000 (22:02 +0000)]
Update results for an editing test that changed from Acid3 fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-24 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Jan 2008 21:53:29 +0000 (21:53 +0000)]
2008-01-24  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Anders.

        <rdar://problem/5588807> Crash in Flash when destroying plug-in (found
        using yahoo beta mail)

        Flash can dereference NULL in the call to NPP_URLNotify if a request
        made with NPN_PostURLNotify fails before NPP_NewStream is called.

        Work around this by creating a quirk, PluginQuirkFlashURLNotifyBug, and
        checking for this quirk before calling NPP_URLNotify for any request
        made with NPN_PostURLNotify. If the quirk is present, call NPP_NewStream
        and NPP_DestroyStream before calling NPP_URLNotify.

        * WebCore.vcproj/WebCore.vcproj:
        * plugins/PluginQuirkSet.h: Added. Moved quirks out of PluginViewWin so
        PluginViewWin and PluginStream could share it. Created a class,
        PluginQuirkSet, to store plug-in quirks
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::PluginStream): Copy the PluginQuirkSet for this
        (WebCore::PluginStream::destroyStream): Check for the FlashURLNotifyBug
        * plugins/PluginStream.h:
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginViewWin::performRequest): Pass the quirks when creating
        the PluginStream
        (WebCore::PluginViewWin::didReceiveResponse): Same
        (WebCore::PluginViewWin::wndProc): Use add / contains instead of
        bit ops
        (WebCore::PluginViewWin::userAgent): Same
        (WebCore::PluginViewWin::invalidateRect): Same
        (WebCore::PluginViewWin::~PluginViewWin): Same
        (WebCore::PluginViewWin::determineQuirks): Same
        (WebCore::PluginViewWin::setParameters): Same
        (WebCore::PluginViewWin::PluginViewWin): Same
        (WebCore::PluginViewWin::init): Same
        (WebCore::PluginViewWin::setCallingPlugin): Same
        * plugins/win/PluginViewWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd test results for Acid3 buckets parsing issue.
hyatt@apple.com [Thu, 24 Jan 2008 21:52:07 +0000 (21:52 +0000)]
Add test results for Acid3 buckets parsing issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd test of Acid3 buckets parsing issue.
hyatt@apple.com [Thu, 24 Jan 2008 21:51:37 +0000 (21:51 +0000)]
Add test of Acid3 buckets parsing issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago http://bugs.webkit.org/show_bug.cgi?id=16982
hyatt@apple.com [Thu, 24 Jan 2008 21:49:25 +0000 (21:49 +0000)]

        Make sure to make <head> the current block if it is created before a <body> already exists.

        Reviewed by Dan

        * html/HTMLParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago http://bugs.webkit.org/show_bug.cgi?id=16993
ap@webkit.org [Thu, 24 Jan 2008 19:40:05 +0000 (19:40 +0000)]
        <rdar://problem/5704331> REGRESSION: Loading page leads to many unexpected redirections

        Rolled out r29590, which was not a correct fix for <rdar://problem/5692566>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti@apple.com [Thu, 24 Jan 2008 18:24:59 +0000 (18:24 +0000)]

        Reviewed by Adam.

        If the media is playing and the load stalls the playback wont restart by seeking backwards.

        We should be in CAN_PLAY state if the current time is less than the maximum loaded time. Rate
        tricks were for streaming case and are not necessary now since that is now disabled.

        Windows patch coming separately.

        Test: http/tests/media/video-play-stall-seek.html

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:


        Reviewed by Adam.

        Test that playback can be resumed by seeking backwards after a stall.

        * http/tests/media/video-play-stall-seek-expected.txt: Added.
        * http/tests/media/video-play-stall-seek.html: Added.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
antti@apple.com [Thu, 24 Jan 2008 18:18:30 +0000 (18:18 +0000)]
    Reviewed by Adam.

        Fix <rdar://problem/5684815>
        After navigating back to the page that contains a <audio> that has been muted, the audio is still heard

        - get rid of the separate muted state in MediaPlayer, maintain the state in the cross platform code only
        - remove volumeChanged() callbacks from HTMLMediaElement and OS X MediaPlayer, they were not used for anything
        - rename updateMediaPlayer -> updatePlayState which tells more about what it actually does

        * html/HTMLMediaElement.cpp:
        * html/HTMLMediaElement.h:
        * platform/graphics/MediaPlayer.cpp:
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
        * platform/graphics/win/QTMovieWin.cpp:
        * platform/graphics/win/QTMovieWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix
aroben@apple.com [Thu, 24 Jan 2008 17:38:33 +0000 (17:38 +0000)]
    Build fix

        * WebView.cpp: Added a comma.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Allow directories containing ChangeLogs to be passed to resolve-ChangeLogs
aroben@apple.com [Thu, 24 Jan 2008 17:27:26 +0000 (17:27 +0000)]
     Allow directories containing ChangeLogs to be passed to resolve-ChangeLogs

         Reviewed by David Kilzer.

         * Scripts/resolve-ChangeLogs:
         (sub findChangeLog): Return a ChangeLog contained within the specified
         directory if one exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
ap@webkit.org [Thu, 24 Jan 2008 16:36:54 +0000 (16:36 +0000)]
    Reviewed by Adam Roben.

        <rdar://problem/5702734> REGRESSION(r28936/r15890): Shift+del does not work in win Safari

        * WebView.cpp: Fixed keyDownEntries to list this shortcut (and related ones, for consistency).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:52:05 +0000 (14:52 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Fix "QObject::startTimer: QTimer can only be used with threads started with QThread"
* The JSC GCController gets automatically destructed on application exit, it will stop
  its timer and we try to schedule the next timer. Now the GCController can get destructed
  after our QApplication is gone. This will trigger the above warning, we can avoid this
  by checking if our qApp is still around.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMorten Johan Sørvig <msorvig@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:27:58 +0000 (14:27 +0000)]
Morten Johan Sørvig <msorvig@trolltech.com>

Qt/Mac: Make sure the scrollbars does not overlap the grow box.

When showing only one scrollbar we need to move it so it doesn't overlap the
grow box. This is similar to the code in QAbstractScrollArea.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoDavid Boddie <dboddie@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:24:48 +0000 (14:24 +0000)]
David Boddie <dboddie@trolltech.com>

Documentation tidying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJarek Kobus <jkobus@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:23:50 +0000 (14:23 +0000)]
Jarek Kobus <jkobus@trolltech.com>

Text for translations were used wrongly as comments

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:18:34 +0000 (14:18 +0000)]
Michael Goddard  <michael.goddard@trolltech.com>


Fix for CSS crash in -webkit-border-image.
Reviewed by Darin.

While parsing -webkit-border-image, store
the border widths as naked pointers rather
than as OwnPtrs, since they point to the
middle of an array.

Test: fast/css/border-image-crash.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:13:36 +0000 (14:13 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* We have a KURL->QUrl conversion on KURL itself, make use of it.
* This conversion is supposed to be loss-free

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:08:12 +0000 (14:08 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Attempt to fix showing of popup again after a popup has been shown but
  the user did not select any item (e.g. clicked outside of the popup)
* Keep track of the popup status using the virtuals showPopup and hidePopup
  and do not go into recursion when hiding a popup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:01:48 +0000 (14:01 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Assert the presence of the PopupMenuClient

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 13:56:49 +0000 (13:56 +0000)]
Michael Goddard <michael.goddard@trolltech.com>

Fix QDateTime to JS Date conversion.
Several conversion errors (some UTC related, some month
offset related) and the conversion distance for Date
to DateTime conversion weights were fixed (it should never
be better to convert a JS Number into a Date rather than
an int).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 13:51:26 +0000 (13:51 +0000)]
Michael Goddard <michael.goddard@trolltech.com>

Add support for calling QObjects.
Add support for invokeDefaultMethod (via a call to
a specific slot), and also allow using it as a
constructor, like QtScript.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 13:44:46 +0000 (13:44 +0000)]
Michael Goddard <michael.goddard@trolltech.com>

Code style cleanups.
Add spaces before/after braces in inline function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 13:41:14 +0000 (13:41 +0000)]
Michael Goddard <michael.goddard@trolltech.com>

Code style cleanups.
Remove spaces and unneeded declared parameter names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 13:37:49 +0000 (13:37 +0000)]
Michael Goddard <michael.goddard@trolltech.com>

Clear stale RuntimeObjectImps.
Since other objects can have refs to the QtInstance,
we can't rely on the QtInstance being deleted when the
RuntimeObjectImp is invalidate or deleted.  This
could result in a stale JSObject being returned for
a valid Instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoVersioning.
mrowe@apple.com [Thu, 24 Jan 2008 07:44:50 +0000 (07:44 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5702947> WebCore: CGContextDrawPDFDocument will be deprecated
ddkilzer@apple.com [Thu, 24 Jan 2008 00:47:00 +0000 (00:47 +0000)]
    <rdar://problem/5702947> WebCore: CGContextDrawPDFDocument will be deprecated

        Reviewed by Darin.

        No test cases added since there is no change in behavior.

        * platform/graphics/cg/PDFDocumentImage.cpp:
        (WebCore::PDFDocumentImage::draw): Replace CGContextDrawPDFDocument() with
        calls to CG methods that perform the equivalent work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt, Adele.
antti@apple.com [Wed, 23 Jan 2008 23:08:54 +0000 (23:08 +0000)]
    Reviewed by Hyatt, Adele.

        Timers for media controls keep running when the page is in the page cache.

        Stop timers in RenderMedia and get rid of the controls tree when the page goes to the cache.

        * html/HTMLMediaElement.cpp:
        * html/HTMLMediaElement.h:
        * rendering/RenderMedia.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
antti@apple.com [Wed, 23 Jan 2008 22:26:01 +0000 (22:26 +0000)]
    Reviewed by Adam.

        Video that had already played to the end would start playing (from beginning) on back/forward navigation.

        Use setPausedInternal() instead of pause(). This avoid generating pause/play events and matches specification text.

        * html/HTMLMediaElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Wed, 23 Jan 2008 22:20:55 +0000 (22:20 +0000)]
    Reviewed by Darin.

        <rdar://problem/4200075> Missing support for accented chars in mailto forms

        With some combinations of form parameters, this was resulting in regressed behavior.

        Tests: fast/forms/mailto/get-non-ascii-text-plain-latin-1.html

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::formData): Ignore accept-charset for mailto forms, which are always
        encoded as UTF-8.
        (WebCore::HTMLFormElement::isMailtoForm): Added.
        (WebCore::HTMLFormElement::dataEncoding): Added (factored out from formData).
        (WebCore::HTMLFormElement::submit): When round-tripping in text/plain case, use utf-8 encoding.
        * html/HTMLFormElement.h: Added a isMailtoForm() function. It may be a bit unfortunate that
        its result is calculated repeatedly, but this doesn't seem to be anywhere near hot code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
sfalken@apple.com [Wed, 23 Jan 2008 22:04:16 +0000 (22:04 +0000)]

        Reviewed by Alice Liu.

        <rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::updateFromElement): If value == text() and
        m_innerText is empty, then value and text() are "". In that case both DOM
        mutations are no-ops and there is no reason to clear the Undo stack.


        <rdar://problem/5698732> Copyright strings should include 2008

        Reviewed by Sam.

        * WebKit.vcproj/WebKit.rc:


        <rdar://problem/5698732> Copyright strings should include 2008

        Reviewed by Sam.

        * Drosera/win/Drosera.vcproj/Drosera.rc:
        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justin.garcia@apple.com [Wed, 23 Jan 2008 21:51:13 +0000 (21:51 +0000)]

        Reviewed by Alice Liu.

        <rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::updateFromElement): If value == text() and
        m_innerText is empty, then value and text() are "". In that case both DOM
        mutations are no-ops and there is no reason to clear the Undo stack.


        Reviewed by Alice Liu.

        <rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

        * editing/undo/5658727-expected.txt: Added.
        * editing/undo/5658727.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix <rdar://5698502> Inspector window reverts to default position/size unexp...
aroben@apple.com [Wed, 23 Jan 2008 21:08:15 +0000 (21:08 +0000)]
     Fix <rdar://5698502> Inspector window reverts to default position/size unexpectedly

         Reviewed by Hyatt.

         * WebInspectorClient.cpp:
         (defaultWindowRect): Added.
             - Use defaultWindowRect() to set the initial size/position of the
               Inspector window.
             - Pass the Inspector window's client rect to
               IWebView::initWithFrame so that the WebView will be initially
               sized to fill the window.
         (WebInspectorClient::showWindow): Don't move/resize the window back to
         the defaults every time this method is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open...
aroben@apple.com [Wed, 23 Jan 2008 21:07:47 +0000 (21:07 +0000)]
 Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com


         Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com

         Test: fast/events/contextmenu-scrolled-page-with-frame.html

         Reviewed by Dan.

         * WebView.cpp:
         (WebView::handleContextMenuEvent): Translate the mouse coordinates
         into document coordinates before performing the hit-test. This is what
         EventHandler does internally.


         Add a test for <rdar://5700620> REGRESSION (r28190): "Open frame in
         new tab" instead of "Open link in new tab" @ digg.com

         Reviewed by Dan.

         * fast/events/contextmenu-scrolled-page-with-frame-expected.txt: Added.
         * fast/events/contextmenu-scrolled-page-with-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
sfalken@apple.com [Wed, 23 Jan 2008 19:43:14 +0000 (19:43 +0000)]

        <rdar://problem/5699509> Allow file upload dialog to be localized.

        Reviewed by Darin.

        * platform/LocalizedStrings.h:
        * platform/win/FileChooserWin.cpp:


        Update localization exceptions.

        Reviewed by Darin.

        * English.lproj/Localizable.strings:
        * StringsNotToBeLocalized.txt:


        <rdar://problem/5699509> Allow file upload dialog to be localized.

        Reviewed by Darin.

        * English.lproj/Localizable.strings: Updated.
        * WebCoreLocalizedStrings.cpp:
        (WebCore::uploadFileText): Added.
        (WebCore::allFilesText): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
dsmith@webkit.org [Wed, 23 Jan 2008 17:49:23 +0000 (17:49 +0000)]
    Reviewed by Darin.

        Added a modified version of the MooTools SlickSpeed Selector Test/Benchmark to show off querySelectorAll. MIT licensed.

        * perf/slickspeed: Added.
        * perf/slickspeed/config.ini: Added.
        * perf/slickspeed/footer.html: Added.
        * perf/slickspeed/frameworks: Added.
        * perf/slickspeed/frameworks/DomQuery.js: Added.
        * perf/slickspeed/frameworks/dummy.js: Added.
        * perf/slickspeed/frameworks/jquery-1.2.1.js: Added.
        * perf/slickspeed/frameworks/prototype.js: Added.
        * perf/slickspeed/header.html: Added.
        * perf/slickspeed/index.php: Added.
        * perf/slickspeed/instructions.txt: Added.
        * perf/slickspeed/logo.png: Added.
        * perf/slickspeed/selectors.list: Added.
        * perf/slickspeed/style.css: Added.
        * perf/slickspeed/system: Added.
        * perf/slickspeed/system/index.php: Added.
        * perf/slickspeed/system/slickspeed.js: Added.
        * perf/slickspeed/system/template.php: Added.
        * perf/slickspeed/template.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix behavior of type-to-select in <select> menus
aroben@apple.com [Wed, 23 Jan 2008 17:38:17 +0000 (17:38 +0000)]
     Fix behavior of type-to-select in <select> menus

         In r27825 we started posting both a WM_KEYDOWN and WM_CHAR message
         whenever a key was pressed in the dropdown menu. However, since posted
         messages go through TranslateMessage, the WM_KEYDOWN was generating
         another WM_CHAR message, so two WM_CHAR messages in a row would reach
         the WebView. This caused the searching to happen twice for each key,
         so typing "dog" would search for "ddoogg".

         Reviewed by Darin.

         * platform/win/PopupMenuWin.cpp:
         (WebCore::PopupWndProc): Repost the WM_KEYDOWN message to the WebView.
         This is will generate a WM_CHAR message which will trigger the
         type-to-select behavior. This is very similar to our behavior prior to
         r27825, except that we're now calling PostMessage instead of

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - updated results following <http://trac.webkit.org/projects/webkit/changeset...
mitz@apple.com [Wed, 23 Jan 2008 16:18:24 +0000 (16:18 +0000)]
    - updated results following <trac.webkit.org/projects/webkit/changeset/29721>

        * platform/mac/fast/frames/viewsource-attribute-expected.checksum:
        * platform/mac/fast/frames/viewsource-attribute-expected.png:
        * platform/mac/fast/frames/viewsource-attribute-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-23 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 23 Jan 2008 15:55:41 +0000 (15:55 +0000)]
2008-01-23  Alp Toker  <alp@atoker.com>

        Rubber-stamped by Mark Rowe.

        Remove whitespace after -I in automake include lists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 11:16:45 +0000 (11:16 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Fix leaking of sub frames (WebCore::Frame). We keep one reference too many.
  This was found while working on the page-cache, other ports are not affected.
* Rubber stamped by Simon

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 11:14:06 +0000 (11:14 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Load images incrementally. This will show warnings on the console
  and we want to fix them for Qt4.4. If that happens we have to remove
  the comment from the enum inside the ImageDecoderQt.cpp

* Rubber stamped by Simon

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRohan McGovern <rohan.mcgovern@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 11:11:27 +0000 (11:11 +0000)]
Rohan McGovern <rohan.mcgovern@trolltech.com>

Fix Qtopia compilation with QT_NO_TOOLTIP

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoGeir Vattekar <gvatteka@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 11:11:13 +0000 (11:11 +0000)]
Geir Vattekar <gvatteka@trolltech.com>

Doc: Replaced \code with snippets in the docs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLars Knoll <lars@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 11:10:57 +0000 (11:10 +0000)]
Lars Knoll <lars@trolltech.com>

Fix rendering of the Scrollbar as well as mouse handling for some styles.

The QStyle expects that that painter is set up to clip to the scrollbar bounds
and some of the styles seem to paint somewhat outside of these bounds. Clipping to
the scrollbar bounds before drawing removes some artifacts.

Also set m_opt.rect.topLeft to (0/0) in the mouse handlers. Fixes some issues with
the oxygen style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMichael Brasser <michael.brasser@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 09:55:46 +0000 (09:55 +0000)]
Michael Brasser <michael.brasser@trolltech.com>

Rendering fixes for Qtopia.

Make the focus ring work with line breaks (until we have QPainterPath::simplify) and
call QStyle with better arguments when painting themed elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 09:55:28 +0000 (09:55 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* FormData::flatten does not include to be uploaded files. Create our own QIODevice
  for the QNetworkAccessManager and feed the complete content of the FormData* to
  the (HTTP) backend.
* Try to optimize the ::readData implementation to fill the buffer as best as possible

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 09:55:08 +0000 (09:55 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Coding-Style fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMichael Brasser <michael.brasser@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 09:48:22 +0000 (09:48 +0000)]
Michael Brasser <michael.brasser@trolltech.com>

use PopupClient's font for popup menu. Otherwise, in Qtopia, the popup's font is much bigger (QApplication::font()?) and the text doesn't fit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 09:44:09 +0000 (09:44 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Tweak key presses even to match commonly expected behavior
- space key == page down
- page down moved down not a page, but slightly less then a page so you don't loose your spot when reading.
- Use font height rather then a hard coded "10" for left, right, up, down
- Ctrl-Up moves to the top of the page
- Ctrl-Down move to the bottom of the page
- Backspace == GoBack
- Shift-Backspace == GoForward

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplemented FrameLoaderClient::startDownload() and FrameLoaderClient::download().
hausmann@webkit.org [Wed, 23 Jan 2008 09:43:52 +0000 (09:43 +0000)]
Implemented FrameLoaderClient::startDownload() and FrameLoaderClient::download().

Added two signals to QWebPage to handle downloading of links and handling of
unsupported content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 09:39:04 +0000 (09:39 +0000)]
Michael Goddard <michael.goddard@trolltech.com>

Reworked the JavaScriptCore Qt bindings:

* Add initial support for string and variant arrays, as well
  as sub QObjects in the JS bindings.

* Don't expose fields marked as not scriptable by moc.

* Add support for dynamic properties and accessing named
  QObject children of an object (like QtScript and older
  IE DOM style JS).
* Add support for custom toString methods.

* Fine tune some bindings to be closer to QtScript.
  Make void functions return undefined, and empty/
  null QStrings return a zero length string.

* Create framework for allowing more direct method calls.
  Since RuntimeMethod doesn't allow us to add additional
  methods/properties to a function, add these classes.
  Start prototyping object.signal.connect(...).

* Add signal support to the Qt bindings.
  Allow connecting to signals (object.signal.connect(slot)),
  disconnecting, and emitting signals.  Currently chooses
  the first signal that matches the name, so this will need

* Add property names, and resolve signals closer to use.
  Enumerating properties now returns some of the Qt properties
  and signals.  Slots and methods aren't quite present.  Also,
  resolve signal connections etc. closer to the time of use, so
  we can do more dynamic resolution based on argument type etc.
  Still picks the first one with the same name, at the moment.

* Make signature comparison code consistent.
  Use the same code for checking meta signatures in
  the method and fallback getters, and avoid a
  QByteArray construction when we can.

* Fix minor memory leak, and handle pointers better.
  Delete the private object in the dtors, and use RefPtrs
  for holding Instances etc.

* Handle method lookup better.
  Allow invocation time method lookup based on the arguments,
  which is closer to QtScript behaviour.  Also, cache the
  method lists and delete them in the QtClass dtor (stops
  a memory leak).

* Improve JS to Qt data type conversions.
  Add some support for Date & RegExp JS objects,
  and provide some metrics on the quality of the

* A couple of fixes for autotest failures.
  Better support for converting lists, read/write only
  QMetaProperty support, modified slot search order...)

* Update JS DRT controller for Qt JS binding changes.
  There were two functions that needed some changes
  so that the layout tests would work, so this makes
  a few tests pass again.

* Bump the timeout for layout tests up to 11s.
  At least some tests have an internal timeout of
  10 seconds, so make the waitUntilDone approach
  wait at least 11s.  fast/dom/open-and-close-by-DOM.html
  is one of these - now the failure message is more

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele Peterson.
mitz@apple.com [Wed, 23 Jan 2008 04:01:09 +0000 (04:01 +0000)]
    Reviewed by Adele Peterson.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16905
          <rdar://problem/5692407> REGRESSION (3.0.4-TOT): "menu" pseudocolor is badly chosen

        The regression test for this is fast/css/css2-system-color.html which
        is currently disabled.

        * rendering/RenderThemeMac.mm:
        (WebCore::menuBackgroundColor): Added. Uses HIThemeDrawMenuBackground
        to draw the menu item background into a bitmap graphics context and
        returns the color of the pixel at (0, 0).
        (WebCore::RenderThemeMac::systemColor): Changed to call
        menuBackgroundColor for the CSS2 menu color.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver Hunt.
darin@apple.com [Wed, 23 Jan 2008 00:29:49 +0000 (00:29 +0000)]
    Reviewed by Oliver Hunt.

        - turn full repainting back on for <canvas> until we get incremental
          repaint working properly

        Ollie and I came up with a plan for testing this, but for now we should
        just fall back on the "repaint everything" behavior we have always had.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::willDraw): Just call repaint.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
andersca@apple.com [Tue, 22 Jan 2008 23:16:37 +0000 (23:16 +0000)]

        Reviewed by Darin and Adam.

        div element on microsoft site has wrong left offset.

        Return true even if NPN_GetProperty returns null or undefined. This matches Firefox
        (and is what the Silverlight plug-in expects).

        * bindings/NP_jsobject.cpp:


        Reviewed by Darin and Adam.

        div element on microsoft site has wrong left offset.

        Add new method for testing the return vale of NPN_GetProperty.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:


        Reviewed by Darin and Adam.

        div element on microsoft site has wrong left offset.

        Add test.

        * plugins/netscape-get-property-return-value-expected.txt: Added.
        * plugins/netscape-get-property-return-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-22 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 22 Jan 2008 21:23:44 +0000 (21:23 +0000)]
2008-01-22  Alp Toker  <alp@atoker.com>

        GTK+/qmake build fix.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
ap@webkit.org [Tue, 22 Jan 2008 20:46:16 +0000 (20:46 +0000)]
    Reviewed by Adam Roben.

        <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail

        * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-22 Christian Dywan <christian@imendio.com>
alp@webkit.org [Tue, 22 Jan 2008 20:45:18 +0000 (20:45 +0000)]
2008-01-22  Christian Dywan  <christian@imendio.com>

        Reviewed by Alp Toker.

        [GTK] API: WebKitWebSettings is not usable

        Implement WebKitWebSettings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn...
aroben@apple.com [Tue, 22 Jan 2008 19:33:26 +0000 (19:33 +0000)]
 Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com


         Add HTMLFrameOwnerElement::scrollingMode

         This new virtual method is overridden by HTMLFrameElementBase to
         provide the scrolling mode set on the frame or iframe element. Object
         elements always have scrolling=auto, so there's no need to override
         this method for HTMLPlugInElement.

         Reviewed by Hyatt.

         * html/HTMLFrameElementBase.h: Declare scrollingMode as virtual.
         * html/HTMLFrameOwnerElement.h:
         (WebCore::HTMLFrameOwnerElement::scrollingMode): Added.


         Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com

         Now that we have multiple FrameViews per Frame on Windows, we need to
         make sure each FrameView gets its scrolling mode set correctly. On Mac
         this works because WebFrameView holds the scrolling mode and a single
         WebFrameView is shared by many FrameViews. On Windows, we have no such
         shared object, so we just ask the Frame's owner element for the
         scrolling mode.

         Tests: fast/frames/frame-scrolling-attribute.html

         Reviewed by Hyatt.

         * WebFrame.cpp:
         (WebFrame::transitionToCommittedForNewPage): Set the scrolling mode
         on the FrameView based on the scrolling mode of the Frame's owner


         Tests for <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com

         Reviewed by Hyatt.

         * fast/frames/frame-scrolling-attribute.html: Added.
         * fast/frames/iframe-scrolling-attribute.html: Added.
         * platform/mac/fast/frames/frame-scrolling-attribute-expected.checksum: Added.
         * platform/mac/fast/frames/frame-scrolling-attribute-expected.png: Added.
         * platform/mac/fast/frames/frame-scrolling-attribute-expected.txt: Added.
         * platform/mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Added.
         * platform/mac/fast/frames/iframe-scrolling-attribute-expected.png: Added.
         * platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for <rdar://problem/5698481> REGRESSION: Web Inspector source view gutter...
hyatt@apple.com [Tue, 22 Jan 2008 17:36:26 +0000 (17:36 +0000)]
    Fix for <rdar://problem/5698481> REGRESSION: Web Inspector source view gutter double divider and no padding

        Now that cellpadding cascades properly on <td>s, we need to make the view source padding rules in the user
        agent sheet have !important in order to override author settings.

        Reviewed by Tim

        * css/view-source.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Alp.
zimmermann@webkit.org [Tue, 22 Jan 2008 16:09:01 +0000 (16:09 +0000)]
Reviewed by Alp.
Allow to use SVGPaintServerSolid without RenderObject/RenderStyle. Used later to draw SVG Fonts in HTML.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Alp.
zimmermann@webkit.org [Tue, 22 Jan 2008 14:57:47 +0000 (14:57 +0000)]
Reviewed by Alp.

Initialize missing variables, m_lineGap / m_lineSpacing.
Only noticeable when trying to render HTML text using SVG Fonts (which is not possible with trunk, but with my local version).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-22 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 22 Jan 2008 13:53:37 +0000 (13:53 +0000)]
2008-01-22  Alp Toker  <alp@atoker.com>

        Reviewed by Nikolas.

        Fix Cairo SVG fonts following changes in r29700.

        Set the font description's details as needed in FontPlatformData and
        eliminate GraphicsContext::setPlatformFont() since it was redundant
        and assumed all fonts were Cairo fonts.

        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/gtk/FontPlatformDataGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Eric.
zimmermann@webkit.org [Tue, 22 Jan 2008 11:10:45 +0000 (11:10 +0000)]
Reviewed by Eric.

- fix http://bugs.webkit.org/show_bug.cgi?id=16967
<rdar://problem/5699344> Reproducible crash when navigating back to a page using SVG fonts

Test: svg/custom/font-platformDestroy-crash.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLars Knoll <lars@trolltech.com>
hausmann@webkit.org [Tue, 22 Jan 2008 10:03:54 +0000 (10:03 +0000)]
Lars Knoll <lars@trolltech.com>

setup a family for cursive and fantasy fonts as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLars Knoll <lars@trolltech.com>
hausmann@webkit.org [Tue, 22 Jan 2008 10:03:40 +0000 (10:03 +0000)]
Lars Knoll <lars@trolltech.com>

cleanup the CookieJarQt implementation and implement cookiesEnabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Tue, 22 Jan 2008 10:03:26 +0000 (10:03 +0000)]
Simon Hausmann <hausmann@webkit.org>

Don't compile the ICO plugin when building against Qt >= 4.4

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Tue, 22 Jan 2008 10:03:14 +0000 (10:03 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Implement ChromeClientQt::setToolTip
Implement ChromeClientQt::mouseDidMoveOverElement

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLars Knoll <lars@trolltech.com>
hausmann@webkit.org [Tue, 22 Jan 2008 08:38:52 +0000 (08:38 +0000)]
Lars Knoll <lars@trolltech.com>

Ported the font implementation to use the new QFont features of Qt 4.4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Nikolas & Oliver.
eric@webkit.org [Tue, 22 Jan 2008 06:48:57 +0000 (06:48 +0000)]
    Reviewed by Nikolas & Oliver.

        Tested by svg/custom/svg-features.html

        * dom/DOMImplementation.cpp:
        (WebCore::isSVG10Feature): use ENABLE(SVG_*) conditionals
        (WebCore::isSVG11Feature): use ENABLE(SVG_*) conditionals

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren@apple.com [Tue, 22 Jan 2008 06:18:10 +0000 (06:18 +0000)]

        Reviewed by Maciej Stachowiak.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=16909
        REGRESSION: Amazon.com crash (ActivationImp)

        (and a bunch of other crashes)

        Plus, a .7% SunSpider speedup to boot.

        Replaced the buggy currentExec and savedExec mechanisms with an
        explicit ExecState stack.

        * kjs/collector.cpp:
        (KJS::Collector::collect): Explicitly mark the ExecState stack.

        (KJS::Collector::reportOutOfMemoryToAllExecStates): Slight change in
        behavior: We no longer throw an exception in any global ExecStates,
        since global ExecStates are more like pseudo-ExecStates, and aren't
        used for script execution. (It's unclear what would happen if you left
        an exception waiting around in a global ExecState, but it probably
        wouldn't be good.)


        Reviewed by Maciej Stachowiak.

        Adapted WebCore to the fix for http://bugs.webkit.org/show_bug.cgi?id=16909
        REGRESSION: Amazon.com crash (ActivationImp)

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::~KJSProxy): No convenient way to make this assertion
        anymore. (It wasn't firing for anyone, anyway, so it's no big loss.)

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]): Use the ExecState stack, instead
        of currentExec.
        (-[WebScriptObject setException:]): ditto. Also, a slight change in
        behavior: If no ExecStates are active, we no longer throw an exception
        in the global ExecState. The JavaScriptCore ChangeLog explains why.
        This also matches the behavior of +throwException.


        Layout test for http://bugs.webkit.org/show_bug.cgi?id=16909
        REGRESSION: Amazon.com crash (ActivationImp)

        * fast/js/exec-state-marking-expected.txt: Added.
        * fast/js/exec-state-marking.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoNot reviewed. Try to fix Qt build, after the rmdir() fixes.
zimmermann@webkit.org [Tue, 22 Jan 2008 00:52:38 +0000 (00:52 +0000)]
Not reviewed. Try to fix Qt build, after the rmdir() fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoNot reviewed. Another Wx build fix.
zimmermann@webkit.org [Tue, 22 Jan 2008 00:49:41 +0000 (00:49 +0000)]
Not reviewed. Another Wx build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix Qt build
darin@apple.com [Tue, 22 Jan 2008 00:30:41 +0000 (00:30 +0000)]
    - try to fix Qt build

        * platform/qt/FileSystemQt.cpp:
        (WebCore::deleteEmptyDirectory): QDir::root().rmdir() instead of QDir::rmdir().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoNot reviewed. Yet another win/gtk build fix.
zimmermann@webkit.org [Tue, 22 Jan 2008 00:05:28 +0000 (00:05 +0000)]
Not reviewed. Yet another win/gtk build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoNot reviewed. Another build fix for Gtk/Linux & Wx/Mac.
zimmermann@webkit.org [Mon, 21 Jan 2008 23:43:32 +0000 (23:43 +0000)]
Not reviewed. Another build fix for Gtk/Linux & Wx/Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoNot reviewed. Build fix for Qt/Gtk & Wx.
zimmermann@webkit.org [Mon, 21 Jan 2008 23:26:06 +0000 (23:26 +0000)]
Not reviewed. Build fix for Qt/Gtk & Wx.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoNot reviewed. Build fix for ports that don't build SVG: wx.
zimmermann@webkit.org [Mon, 21 Jan 2008 23:16:59 +0000 (23:16 +0000)]
Not reviewed. Build fix for ports that don't build SVG: wx.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29703 268f45cc-cd09-0410-ab3c-d52691b4dbfc