WebKit-https.git
8 years agocommitters-autocomplete.js works only with WebKit based browsers
ossy@webkit.org [Tue, 6 Nov 2012 10:26:08 +0000 (10:26 +0000)]
committers-autocomplete.js works only with WebKit based browsers
https://bugs.webkit.org/show_bug.cgi?id=66752

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2012-11-06
Reviewed by Csaba Osztrogon√°c.

Based on the patch posted by Peter Gal. Attach event listeners
to all input elements we want to enable auto-completions on.

* committers-autocomplete.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow] ShadowRoot should know the existence of elements having ElementShadow.
shinyak@chromium.org [Tue, 6 Nov 2012 10:15:06 +0000 (10:15 +0000)]
[Shadow] ShadowRoot should know the existence of elements having ElementShadow.
https://bugs.webkit.org/show_bug.cgi?id=100922

Reviewed by Hajime Morita.

Source/WebCore:

We count the elements having ElementShadow in ShadowRoot. This is a prepation patch for to solve Bug 100451.
We have a count-up and count-down login in ShadowRoot::insertedInto and ShadowRoot::removedFrom.

For performance reason, we have a flag that an element should be unregistered in ShadowRoot.

Test: fast/dom/shadow/has-elementshadow.html

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::insertedInto): Count up the number of elements having ElementShadow. ElementShadow
is created only when the oldest ShadowRoot is created, we only count up only when this ShadowRoot is oldest.
(WebCore):
(WebCore::ShadowRoot::removedFrom): Count down if we used this ShadowRoot for count up.
* dom/ShadowRoot.h:
(ShadowRoot):
(WebCore::ShadowRoot::registerElementShadow):
(WebCore::ShadowRoot::unregisterElementShadow):
(WebCore::ShadowRoot::hasElementShadow):
(WebCore::ShadowRoot::countElementShadow):
* testing/Internals.cpp:
(WebCore::Internals::countElementShadow):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

* fast/dom/shadow/has-elementshadow-expected.txt: Added.
* fast/dom/shadow/has-elementshadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDumpRenderTree should have --pixel-tests option again
kbalazs@webkit.org [Tue, 6 Nov 2012 10:12:29 +0000 (10:12 +0000)]
DumpRenderTree should have --pixel-tests option again
https://bugs.webkit.org/show_bug.cgi?id=98648

Reviewed by Dirk Pranke.

Add back the --pixel-tests command line option to DumpRenderTree.
It was removed r124581 because tools don't use it after that patch.
However, it turned out that it is useful for debugging and working
with pixel tests.

* DumpRenderTree/efl/DumpRenderTree.cpp:
(parseCommandLineOptions):
(runTest):
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGlobalsFromCommandLineOptions):
(runTest):
* DumpRenderTree/mac/DumpRenderTree.mm:
(initializeGlobalsFromCommandLineOptions):
(runTest):
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(isOption):
(printUsage):
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::processLine):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(WebCore::DumpRenderTree::setShouldDumpPixelsForAllTests):
(DumpRenderTree):
* DumpRenderTree/win/DumpRenderTree.cpp:
(runTest):
(dllLauncherEntryPoint):
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
(runTest):
(MyApp::OnInit):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
* WebKitTestRunner/TestController.h:
(TestController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: show "debugging session terminated" message when remote debuggign...
pfeldman@chromium.org [Tue, 6 Nov 2012 10:06:27 +0000 (10:06 +0000)]
Web Inspector: show "debugging session terminated" message when remote debuggign connection is closed unexpectedly.
https://bugs.webkit.org/show_bug.cgi?id=101030

Reviewed by Vsevolod Vlasov.

* inspector/front-end/inspector.js:
(WebInspector.loaded.WebInspector.socket.onclose):
(WebInspector.loaded):
(WebInspector.detached):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Overrides] Add Chrome for Android and Firefox for Android user agent...
apavlov@chromium.org [Tue, 6 Nov 2012 10:04:33 +0000 (10:04 +0000)]
Web Inspector: [Overrides] Add Chrome for Android and Firefox for Android user agent strings
https://bugs.webkit.org/show_bug.cgi?id=100666

Reviewed by Pavel Feldman.

* inspector/front-end/SettingsScreen.js:
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.get const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[QT] [GTK] Remove fast/forms/week-multiple-fields from TestExpectations of gtk and qt.
commit-queue@webkit.org [Tue, 6 Nov 2012 09:49:52 +0000 (09:49 +0000)]
[QT] [GTK] Remove fast/forms/week-multiple-fields from TestExpectations of gtk and qt.
https://bugs.webkit.org/show_bug.cgi?id=101317

Unreviewed gardening.

fast/forms/week-multiple-fields is removed by http://trac.webkit.org/changeset/133440.

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-11-06

* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] [WK2] Random crash in Minibrowser
commit-queue@webkit.org [Tue, 6 Nov 2012 09:34:49 +0000 (09:34 +0000)]
[EFL] [WK2] Random crash in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=101241

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-06
Reviewed by Gyuyoung Kim.

Do not clear GL context and GL surface in exitAcceleratedCompositing.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::exitAcceleratedCompositingMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: JavaScript web workers debugging crashes
yurys@chromium.org [Tue, 6 Nov 2012 08:49:20 +0000 (08:49 +0000)]
Web Inspector: JavaScript web workers debugging crashes
https://bugs.webkit.org/show_bug.cgi?id=101065

Reviewed by Alexander Pavlov.

Source/WebCore:

Clear m_pageInspector when page inspector instance is deleted.
Disable worker inspection when front-end disconnects.

Test: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): notify
WorkerMessagingProxy so that it can clear pointer to the channel.

LayoutTests:

Test that inspected page won't crash if inspected worker is terminated when it is paused
on a breakpoint.

* inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt: Added.
* inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html: Added.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Console: wrap long URLs
commit-queue@webkit.org [Tue, 6 Nov 2012 08:02:38 +0000 (08:02 +0000)]
Web Inspector: Console: wrap long URLs
https://bugs.webkit.org/show_bug.cgi?id=100970

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-06
Reviewed by Yury Semikhatsky.

* inspector/front-end/inspector.css:
(.console-message-url):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should not fall down to patchable GetById just because a prototype had things...
fpizlo@apple.com [Tue, 6 Nov 2012 07:47:51 +0000 (07:47 +0000)]
DFG should not fall down to patchable GetById just because a prototype had things added to it
https://bugs.webkit.org/show_bug.cgi?id=101299

Reviewed by Geoffrey Garen.

This looks like a slight win on V8v7 and SunSpider.

* bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch rebaseline*: fix typo for --results-directory
dpranke@chromium.org [Tue, 6 Nov 2012 07:44:18 +0000 (07:44 +0000)]
webkit-patch rebaseline*: fix typo for --results-directory
https://bugs.webkit.org/show_bug.cgi?id=101295

Reviewed by Ojan Vafai.

Had --results_directory instead of --results-directory in both the
code and the unit test.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand._rebaseline_commands):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineJson.test_results_directory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroduce Day class to calendar picker
keishi@webkit.org [Tue, 6 Nov 2012 07:18:12 +0000 (07:18 +0000)]
Introduce Day class to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101194

Reviewed by Kent Tamura.

Introducing Day class so day, week, and month can all be abstracted. To
solve some of the complexity around which months to show, I made
CalendarPicker in charge of it. This also made YearMonthController and
DaysTable independent of each other.

No new tests. Covered by existing calendar-picker-*.html tests.

* Resources/pagepopups/calendarPicker.js:
(createUTCDate): Allow negative month or date.
(parseDateString): Will return Day or Month depending on string format.
(Day): Represents a day.
(Day.parse): Parse yyyy-mm-dd.
(Day.createFromDate): Creates a Day that contains a datetime.
(Day.createFromToday): Creates Day for today. A method with the same name will be added to Week and Month in the future.
(Day.prototype.equals): Returns true if they are the same.
(Day.prototype.previous): Returns the previous day.
(Day.prototype.next): Returns the next day.
(Day.prototype.startDate): Returns the datetime that is the start of this day.
(Day.prototype.endDate): Returns the datetime that is the start of this day.
(Day.prototype.valueOf): Returns the milliseconds since epoch.
(Day.prototype.toString): Returns an ISO date string.
(Month): Fix bug in calculating month from value.
(Month.prototype.endDate): Use Day.Maximum.
(CalendarPicker): Added _currentMonth. yearMonthController and daysTable can be private members now.
(CalendarPicker.prototype._layout):
(CalendarPicker.prototype.handleToday): Use Day.createFromToday.
(CalendarPicker.prototype.shouldShowMonth): Returns true if the month should be shown.
(CalendarPicker.prototype.showMonth): Shows the given month. If the month is out of the range of months that should be shown, we clamp the month and show that.
(CalendarPicker.prototype.currentMonth): Returns the current month that is shown.
(YearMonthController): Removed _currentMonth.
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype.setMonth):
(YearMonthController.prototype._handleYearMonthChange): Use CalendarPicker.showMonth
(YearMonthController.prototype.moveRelatively):
(DaysTable):
(CalendarPicker.prototype._stepMismatch): Made private.
(CalendarPicker.prototype._outOfRange): Made private.
(CalendarPicker.prototype.isValidDate): Take Day or Month instead of milliseconds since epoch.
(DaysTable.prototype._renderMonth):
(DaysTable.prototype.navigateToMonth): Shows a given month. Can use animation and leave the selection position as is.
(DaysTable.prototype.selectRange): Select a range.
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGet rid of method_check
fpizlo@apple.com [Tue, 6 Nov 2012 07:16:27 +0000 (07:16 +0000)]
Get rid of method_check
https://bugs.webkit.org/show_bug.cgi?id=101147

Reviewed by Geoffrey Garen.

op_method_check no longer buys us anything, since get_by_id proto caching
gives just as much profiling information and the DFG inlines monomorphic
proto accesses anyway.

This also has the potential for a speed-up since it makes parsing of
profiling data easier. No longer do we have to deal with the confusion of
the get_by_id portion of a method_check appearing monomorphic even though
we're really dealing with a bimorphic access (method_check specializes for
one case and get_by_id for another).

This looks like a 1% speed-up on both SunSpider and V8v7.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::unlinkCalls):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::callLinkInfo):
(CodeBlock):
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
* bytecode/MethodCallLinkInfo.cpp: Removed.
* bytecode/MethodCallLinkInfo.h: Removed.
* bytecode/MethodCallLinkStatus.cpp: Removed.
* bytecode/MethodCallLinkStatus.h: Removed.
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC):
* bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::FunctionCallDotNode::emitBytecode):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::PropertyStubCompilationInfo::slowCaseInfo):
(PropertyStubCompilationInfo):
(JSC):
(JIT):
* jit/JITPropertyAccess.cpp:
(JSC):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::compileGetByIdSlowCase):
* jit/JITPropertyAccess32_64.cpp:
(JSC):
(JSC::JIT::compileGetByIdSlowCase):
* jit/JITStubs.cpp:
(JSC):
* jit/JITStubs.h:
* llint/LowLevelInterpreter.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, Adding #if PLATFORM(CHROMIUM) for the fix of
bashi@chromium.org [Tue, 6 Nov 2012 06:43:10 +0000 (06:43 +0000)]
Unreviewed, Adding #if PLATFORM(CHROMIUM) for the fix of
https://bugs.webkit.org/show_bug.cgi?id=101009

This fix requires the most recent version of harfbuzz-ng.
EFL port uses version 0.9.2, which doesn't have the fix.

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnsure acquireLineBreakIterator signature consistency on non-ICU ports.
commit-queue@webkit.org [Tue, 6 Nov 2012 06:41:29 +0000 (06:41 +0000)]
Ensure acquireLineBreakIterator signature consistency on non-ICU ports.
https://bugs.webkit.org/show_bug.cgi?id=101281

Patch by Glenn Adams <glenn@skynav.com> on 2012-11-05
Reviewed by Ryosuke Niwa.

Fix (newly) inconsistent signature for acquireLineBreakIterator for non-ICU ports
caused by http://trac.webkit.org/changeset/133529.

See new tests added from https://bugs.webkit.org/show_bug.cgi?id=89235.

* platform/text/TextBreakIterator.cpp:
(WebCore::acquireLineBreakIterator):
* platform/text/gtk/TextBreakIteratorGtk.cpp:
(WebCore::setUpIterator):
(WebCore::acquireLineBreakIterator):
* platform/text/wince/TextBreakIteratorWinCE.cpp:
(WebCore::acquireLineBreakIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse switch/case statements instead of if/elseif in CSSSelector.cpp
hayato@chromium.org [Tue, 6 Nov 2012 06:25:40 +0000 (06:25 +0000)]
Use switch/case statements instead of if/elseif in CSSSelector.cpp
https://bugs.webkit.org/show_bug.cgi?id=100470

Reviewed by Ryosuke Niwa.

Minor clean up. We can get compiler warnings if we use switch/case statements here.

No changes to functionality, so no new tests.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed morning gardening, skip new failing tests.
ossy@webkit.org [Tue, 6 Nov 2012 06:24:01 +0000 (06:24 +0000)]
[Qt] Unreviewed morning gardening, skip new failing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch rebaseline*: fix handling of local file urls
dpranke@chromium.org [Tue, 6 Nov 2012 06:06:05 +0000 (06:06 +0000)]
webkit-patch rebaseline*: fix handling of local file urls
https://bugs.webkit.org/show_bug.cgi?id=101296

Reviewed by Ojan Vafai.

When using --results-directory, we need to make sure we're converting
paths to file:/// urls for urllib to work correctly. Also, this
patch reworks the unit tests to get better coverage (of the execute()
command) and reduce copy/pasting of mock options.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.setUp):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test_with_results_directory):
(test_rebaseline_test_internal_with_move_overwritten_baselines_to):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNeed a way to send and receive messages between the WKWebProcessPlugIn object and...
weinig@apple.com [Tue, 6 Nov 2012 05:52:30 +0000 (05:52 +0000)]
Need a way to send and receive messages between the WKWebProcessPlugIn object and the client
https://bugs.webkit.org/show_bug.cgi?id=101282

Reviewed by Anders Carlsson.

API wise, this adds:
    - A connection property on the WKWebProcessPlugInController
    - A method to send messages across a WKConnection (sendMessageWithName:body).

It also implements message sending and receiving for WKConnection. Message bodies are currently
restricted to being object graphs with values that are property list types, but in the future, should
support all types conforming to the NSSecureCoding protocol.

* Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
(WebKit::WebConnection::handleMessage):
* Shared/WebConnection.h:
(WebConnection):
* Shared/WebConnection.messages.in:
Switch HandleMessage to be a variadic message to avoid an extra copy and support attachments correctly.

* Shared/mac/ArgumentCodersMac.h:
* Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::typeFromObject):
(CoreIPC::encode):
(CoreIPC::decode):
Add support for encoding/decoding NSArray, NSDate and NSData.

* UIProcess/API/mac/WKConnection.h:
* UIProcess/API/mac/WKConnection.mm:
(-[WKConnection sendMessageWithName:body:]):
(didReceiveMessage):
Implement message sending and receiving.

* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
(-[WKWebProcessPlugInController _initWithPrincipalClassInstance:bundleRef:]):
(-[WKWebProcessPlugInController connection]):
Add a wrapper for the WKConnectionRef vended via WKBundleGetApplicationConnection() and expose it as
API on the WKWebProcessPlugInController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Updating MathML chromium baselines.
dbarton@mathscribe.com [Tue, 6 Nov 2012 05:04:18 +0000 (05:04 +0000)]
Unreviewed gardening. Updating MathML chromium baselines.

* platform/chromium-linux-x86/mathml/presentation: Added.
* platform/chromium-linux-x86/mathml/presentation/attributes-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/attributes-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/fenced-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/fenced-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/fenced-mi-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/fenced-mi-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/fractions-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/fractions-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/mo-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/mo-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/mo-stretch-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/mo-stretch-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/mroot-pref-width-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/mroot-pref-width-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/over-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/over-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/roots-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/roots-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/row-alignment-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/row-alignment-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/row-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/row-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/style-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/style-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/sub-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/sub-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/subsup-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/subsup-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/sup-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/sup-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/tables-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/tables-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/tokenElements-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/tokenElements-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/under-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/under-expected.txt: Added.
* platform/chromium-linux-x86/mathml/presentation/underover-expected.png: Added.
* platform/chromium-linux-x86/mathml/presentation/underover-expected.txt: Added.
* platform/chromium-linux-x86/mathml/xHeight-expected.txt:
* platform/chromium-linux/mathml/presentation: Added.
* platform/chromium-linux/mathml/presentation/attributes-expected.png: Added.
* platform/chromium-linux/mathml/presentation/attributes-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/fenced-expected.png: Added.
* platform/chromium-linux/mathml/presentation/fenced-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/fenced-mi-expected.png: Added.
* platform/chromium-linux/mathml/presentation/fenced-mi-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/fractions-expected.png: Added.
* platform/chromium-linux/mathml/presentation/fractions-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
* platform/chromium-linux/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/mo-expected.png: Added.
* platform/chromium-linux/mathml/presentation/mo-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/mo-stretch-expected.png: Added.
* platform/chromium-linux/mathml/presentation/mo-stretch-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/mroot-pref-width-expected.png: Added.
* platform/chromium-linux/mathml/presentation/mroot-pref-width-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/over-expected.png: Added.
* platform/chromium-linux/mathml/presentation/over-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/roots-expected.png: Added.
* platform/chromium-linux/mathml/presentation/roots-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/row-alignment-expected.png: Added.
* platform/chromium-linux/mathml/presentation/row-alignment-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/row-expected.png: Added.
* platform/chromium-linux/mathml/presentation/row-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/style-expected.png: Added.
* platform/chromium-linux/mathml/presentation/style-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/sub-expected.png: Added.
* platform/chromium-linux/mathml/presentation/sub-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/subsup-expected.png: Added.
* platform/chromium-linux/mathml/presentation/subsup-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/sup-expected.png: Added.
* platform/chromium-linux/mathml/presentation/sup-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/tables-expected.png: Added.
* platform/chromium-linux/mathml/presentation/tables-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/tokenElements-expected.png: Added.
* platform/chromium-linux/mathml/presentation/tokenElements-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/under-expected.png: Added.
* platform/chromium-linux/mathml/presentation/under-expected.txt: Added.
* platform/chromium-linux/mathml/presentation/underover-expected.png: Added.
* platform/chromium-linux/mathml/presentation/underover-expected.txt: Added.
* platform/chromium-linux/mathml/xHeight-expected.txt:
* platform/chromium-mac-lion/mathml/presentation/mo-stretch-expected.txt: Added.
* platform/chromium-mac-lion/mathml/presentation/row-alignment-expected.png:
* platform/chromium-mac-lion/mathml/presentation/row-alignment-expected.txt: Added.
* platform/chromium-mac-lion/mathml/presentation/subsup-expected.png:
* platform/chromium-mac-lion/mathml/presentation/subsup-expected.txt:
* platform/chromium-mac-lion/mathml/presentation/tables-expected.png:
* platform/chromium-mac-lion/mathml/presentation/tables-expected.txt: Added.
* platform/chromium-mac-snowleopard/mathml/presentation/mo-stretch-expected.txt:
* platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.png:
* platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.txt:
* platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.png:
* platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.txt:
* platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.png:
* platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.txt:
* platform/chromium-mac/mathml/presentation/mo-stretch-expected.txt: Added.
* platform/chromium-mac/mathml/presentation/row-alignment-expected.png:
* platform/chromium-mac/mathml/presentation/row-alignment-expected.txt: Added.
* platform/chromium-mac/mathml/presentation/subsup-expected.png:
* platform/chromium-mac/mathml/presentation/subsup-expected.txt:
* platform/chromium-mac/mathml/presentation/tables-expected.png:
* platform/chromium-mac/mathml/presentation/tables-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation: Added.
* platform/chromium-win-xp/mathml/presentation/attributes-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/attributes-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/fenced-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/fenced-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/fenced-mi-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/fenced-mi-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/fractions-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/fractions-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/mo-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/mo-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/mo-stretch-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/mo-stretch-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/mroot-pref-width-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/mroot-pref-width-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/over-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/over-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/roots-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/roots-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/row-alignment-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/row-alignment-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/row-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/row-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/style-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/style-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/sub-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/sub-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/subsup-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/subsup-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/sup-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/sup-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/tables-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/tables-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/tokenElements-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/tokenElements-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/under-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/under-expected.txt: Added.
* platform/chromium-win-xp/mathml/presentation/underover-expected.png: Added.
* platform/chromium-win-xp/mathml/presentation/underover-expected.txt: Added.
* platform/chromium-win/mathml/presentation: Added.
* platform/chromium-win/mathml/presentation/attributes-expected.png: Added.
* platform/chromium-win/mathml/presentation/attributes-expected.txt: Added.
* platform/chromium-win/mathml/presentation/fenced-expected.png: Added.
* platform/chromium-win/mathml/presentation/fenced-expected.txt: Added.
* platform/chromium-win/mathml/presentation/fenced-mi-expected.png: Added.
* platform/chromium-win/mathml/presentation/fenced-mi-expected.txt: Added.
* platform/chromium-win/mathml/presentation/fractions-expected.png: Added.
* platform/chromium-win/mathml/presentation/fractions-expected.txt: Added.
* platform/chromium-win/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
* platform/chromium-win/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
* platform/chromium-win/mathml/presentation/mo-expected.png: Added.
* platform/chromium-win/mathml/presentation/mo-expected.txt: Added.
* platform/chromium-win/mathml/presentation/mo-stretch-expected.png: Added.
* platform/chromium-win/mathml/presentation/mo-stretch-expected.txt: Added.
* platform/chromium-win/mathml/presentation/mroot-pref-width-expected.png: Added.
* platform/chromium-win/mathml/presentation/mroot-pref-width-expected.txt: Added.
* platform/chromium-win/mathml/presentation/over-expected.png: Added.
* platform/chromium-win/mathml/presentation/over-expected.txt: Added.
* platform/chromium-win/mathml/presentation/roots-expected.png: Added.
* platform/chromium-win/mathml/presentation/roots-expected.txt: Added.
* platform/chromium-win/mathml/presentation/row-alignment-expected.png: Added.
* platform/chromium-win/mathml/presentation/row-alignment-expected.txt: Added.
* platform/chromium-win/mathml/presentation/row-expected.png: Added.
* platform/chromium-win/mathml/presentation/row-expected.txt: Added.
* platform/chromium-win/mathml/presentation/style-expected.png: Added.
* platform/chromium-win/mathml/presentation/style-expected.txt: Added.
* platform/chromium-win/mathml/presentation/sub-expected.png: Added.
* platform/chromium-win/mathml/presentation/sub-expected.txt: Added.
* platform/chromium-win/mathml/presentation/subsup-expected.png: Added.
* platform/chromium-win/mathml/presentation/subsup-expected.txt: Added.
* platform/chromium-win/mathml/presentation/sup-expected.png: Added.
* platform/chromium-win/mathml/presentation/sup-expected.txt: Added.
* platform/chromium-win/mathml/presentation/tables-expected.png: Added.
* platform/chromium-win/mathml/presentation/tables-expected.txt: Added.
* platform/chromium-win/mathml/presentation/tokenElements-expected.png: Added.
* platform/chromium-win/mathml/presentation/tokenElements-expected.txt: Added.
* platform/chromium-win/mathml/presentation/under-expected.png: Added.
* platform/chromium-win/mathml/presentation/under-expected.txt: Added.
* platform/chromium-win/mathml/presentation/underover-expected.png: Added.
* platform/chromium-win/mathml/presentation/underover-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/chromium/mathml/presentation/attributes-expected.png: Removed.
* platform/chromium/mathml/presentation/fractions-expected.png: Removed.
* platform/chromium/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
* platform/chromium/mathml/presentation/mo-expected.png: Removed.
* platform/chromium/mathml/presentation/mo-stretch-expected.png: Removed.
* platform/chromium/mathml/presentation/mroot-pref-width-expected.png: Removed.
* platform/chromium/mathml/presentation/over-expected.png: Removed.
* platform/chromium/mathml/presentation/roots-expected.png: Removed.
* platform/chromium/mathml/presentation/row-alignment-expected.png: Removed.
* platform/chromium/mathml/presentation/row-expected.png: Removed.
* platform/chromium/mathml/presentation/style-expected.png: Removed.
* platform/chromium/mathml/presentation/subsup-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded secondary email address and IRC nick.
kbr@google.com [Tue, 6 Nov 2012 04:15:15 +0000 (04:15 +0000)]
Added secondary email address and IRC nick.
https://bugs.webkit.org/show_bug.cgi?id=101290

Unreviewed change to committers.py.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Do not show error page for main loads denied by client application
commit-queue@webkit.org [Tue, 6 Nov 2012 04:08:21 +0000 (04:08 +0000)]
[BlackBerry] Do not show error page for main loads denied by client application
https://bugs.webkit.org/show_bug.cgi?id=101287

Internal PR: 237574.
Internally reviewed by Arvid Nilsson, Joe Mason.
Patch by Lianghui Chen <liachen@rim.com> on 2012-11-05
Reviewed by George Staikos.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Fix wrong coding style in the boilerplates
commit-queue@webkit.org [Tue, 6 Nov 2012 03:46:16 +0000 (03:46 +0000)]
[EFL][WK2] Fix wrong coding style in the boilerplates
https://bugs.webkit.org/show_bug.cgi?id=101283

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-05
Reviewed by Gyuyoung Kim.

Fix boilerplate which have wrong coding style.

* UIProcess/efl/InputMethodContextEfl.cpp:
* UIProcess/efl/InputMethodContextEfl.h:
* UIProcess/efl/PageClientDefaultImpl.cpp:
* UIProcess/efl/PageClientDefaultImpl.h:
* UIProcess/efl/PageClientLegacyImpl.cpp:
* UIProcess/efl/PageClientLegacyImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2][PixelTests] Add missing expectations
commit-queue@webkit.org [Tue, 6 Nov 2012 03:46:05 +0000 (03:46 +0000)]
[EFL][WK2][PixelTests] Add missing expectations
https://bugs.webkit.org/show_bug.cgi?id=101289

Unreviewed, EFL gardening.

Add 16 missing pixel test expectations.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-05

* platform/efl/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
* platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
* platform/efl/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/efl/compositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
* platform/efl/fast/forms/basic-inputs-expected.png: Added.
* platform/efl/fast/media/view-mode-media-feature-expected.png: Added.
* platform/efl/media/video-aspect-ratio-expected.png: Added.
* platform/efl/media/video-layer-crash-expected.png: Added.
* platform/efl/media/video-transformed-expected.png: Added.
* platform/efl/media/video-zoom-controls-expected.png: Added.
* platform/efl/media/video-zoom-expected.png: Added.
* platform/efl/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update chromium-mac-mountainlion baselines for svg failures after r133538
dpranke@chromium.org [Tue, 6 Nov 2012 03:37:01 +0000 (03:37 +0000)]
Unreviewed, update chromium-mac-mountainlion baselines for svg failures after r133538

* platform/chromium-mac-lion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png.
* platform/chromium-mac-lion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png.
* platform/chromium-mac-lion/svg/batik/filters/filterRegions-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/filters/filterRegions-expected.png.
* platform/chromium-mac-lion/svg/batik/masking/maskRegions-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/masking/maskRegions-expected.png.
* platform/chromium-mac-lion/svg/batik/paints/gradientLimit-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png.
* platform/chromium-mac-lion/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png.
* platform/chromium-mac-lion/svg/batik/paints/patternRegionA-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png.
* platform/chromium-mac-lion/svg/batik/paints/patternRegions-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternRegions-expected.png.
* platform/chromium-mac-lion/svg/batik/paints/patternRegions-positioned-objects-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png.
* platform/chromium-mac-lion/svg/batik/text/longTextOnPath-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/longTextOnPath-expected.png.
* platform/chromium-mac-lion/svg/batik/text/smallFonts-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/smallFonts-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textAnchor-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textAnchor-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textDecoration-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textDecoration-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textEffect-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textEffect-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textEffect2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textEffect2-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textEffect3-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textEffect3-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textFeatures-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textFeatures-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textLayout-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLayout-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textLayout2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLayout2-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textLength-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLength-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textOnPath-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textOnPath-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textOnPathSpaces-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textPosition-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textPosition-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textPosition2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textPosition2-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textProperties-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textProperties-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textProperties2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textProperties2-expected.png.
* platform/chromium-mac-lion/svg/batik/text/textStyles-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textStyles-expected.png.
* platform/chromium-mac-lion/svg/batik/text/verticalText-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/verticalText-expected.png.
* platform/chromium-mac-lion/svg/batik/text/verticalTextOnPath-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png.
* platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png.
* platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png.
* platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/chromium-mac/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-mac/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-mac/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-mac/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
* platform/chromium-mac/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac/svg/batik/text/textEffect-expected.png:
* platform/chromium-mac/svg/batik/text/textEffect2-expected.png:
* platform/chromium-mac/svg/batik/text/textEffect3-expected.png:
* platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
* platform/chromium-mac/svg/batik/text/textLayout-expected.png:
* platform/chromium-mac/svg/batik/text/textLayout2-expected.png:
* platform/chromium-mac/svg/batik/text/textLength-expected.png:
* platform/chromium-mac/svg/batik/text/textOnPath-expected.png:
* platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-mac/svg/batik/text/textPosition-expected.png:
* platform/chromium-mac/svg/batik/text/textPosition2-expected.png:
* platform/chromium-mac/svg/batik/text/textProperties-expected.png:
* platform/chromium-mac/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac/svg/batik/text/textStyles-expected.png:
* platform/chromium-mac/svg/batik/text/verticalText-expected.png:
* platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor LLInt64 to distinguish the pointer operations from the 64-bit integer operations
yuqiang.xian@intel.com [Tue, 6 Nov 2012 03:12:25 +0000 (03:12 +0000)]
Refactor LLInt64 to distinguish the pointer operations from the 64-bit integer operations
https://bugs.webkit.org/show_bug.cgi?id=100321

Reviewed by Filip Pizlo.

We have refactored the MacroAssembler and JIT compilers to distinguish
the pointer operations from the 64-bit integer operations (see bug #99154).
Now we want to do the similar work for LLInt, and the goal is same as
the one mentioned in 99154.

This is the second part of the modification: in the low level interpreter,
changing the operations on 64-bit integers to use the "<foo>q" instructions.
This also removes some unused/meaningless "<foo>p" instructions.

* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
* llint/LowLevelInterpreter64.asm:
* offlineasm/armv7.rb:
* offlineasm/cloop.rb:
* offlineasm/instructions.rb:
* offlineasm/x86.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unicode combining diacritical aren't always combined on Linux
bashi@chromium.org [Tue, 6 Nov 2012 03:04:17 +0000 (03:04 +0000)]
[Chromium] Unicode combining diacritical aren't always combined on Linux
https://bugs.webkit.org/show_bug.cgi?id=101009

Reviewed by Kent Tamura.

Source/WebCore:

Add a space character to harfbuzzBuffer as pre-context. This will prevent
harfbuzz from inserting dotted-circle.

Test: fast/text/international/combining-marks-position.html

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

LayoutTests:

Add a test that checks whether combining marks are combined with base characters.

* fast/text/international/combining-marks-position-expected.txt: Added.
* fast/text/international/combining-marks-position.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
kov@webkit.org [Tue, 6 Nov 2012 02:18:32 +0000 (02:18 +0000)]
[l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
https://bugs.webkit.org/show_bug.cgi?id=100817

Patch by Sandeep Shedmake <sshedmak@redhat.com> on 2012-11-05
Rubber-stamped by Gustavo Noronha.

* mr.po: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayoutTest fast/dom/shadow/shadowroot-type.html is failing on Windows
shinyak@chromium.org [Tue, 6 Nov 2012 02:13:22 +0000 (02:13 +0000)]
LayoutTest fast/dom/shadow/shadowroot-type.html is failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=101201

Reviewed by Hajime Morita.

When we use a bit field for enum, Windows compiler seems returning some wrong value.
We would like to avoid using a bit field for enum value.

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
* dom/ShadowRoot.h:
(WebCore::ShadowRoot::type):
(WebCore::ShadowRoot::setType):
(ShadowRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[l10n] updated id.po for WebKitGTK+
kov@webkit.org [Tue, 6 Nov 2012 02:05:04 +0000 (02:05 +0000)]
[l10n] updated id.po for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100264

Patch by Andika Triwidada <andika@gmail.com> on 2012-11-05
Rubber-stamped by Gustavo Noronha.

* id.po: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPrototype chain caching should check that the path from the base object to the slot...
fpizlo@apple.com [Tue, 6 Nov 2012 01:53:09 +0000 (01:53 +0000)]
Prototype chain caching should check that the path from the base object to the slot base involves prototype hops only
https://bugs.webkit.org/show_bug.cgi?id=101276

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Changed normalizePrototypeChain() to report an invalid prototype chain if any object is a proxy.
This catches cases where our prototype chain checks would have been insufficient to guard against
newly introduced properties, despecialized properties, or deleted properties in the chain of
objects involved in the access.

* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/Operations.h:
(JSC):
(JSC::normalizePrototypeChain):

LayoutTests:

This test already covered this case, but only for method_check. Modified it to
also cover the get_by_id case.

* fast/js/toString-and-valueOf-override-expected.txt:
* fast/js/toString-and-valueOf-override.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTransformOperationInfo's constructor is really slow
benjamin@webkit.org [Tue, 6 Nov 2012 01:48:19 +0000 (01:48 +0000)]
TransformOperationInfo's constructor is really slow
https://bugs.webkit.org/show_bug.cgi?id=101143

Reviewed by Sam Weinig.

TransformOperationInfo() was slow for a few reasons:
-The function used a lot of branches. The basic assumption is that the input
 is incorrect, thus every character is an opportunity to fail.
-Every branch had to be tested in order. If the name was matching the last if()
 all the previous names had to be tested.
-Since equalIgnoringCase() was used in every branch, it was forcing the case folding
 every time.
-When the string is 16bits, the case folding was using ICU, which was incredibly inefficient.

This can be fixed by either
1) Compute the lowercase name, then match it to a HashMap.
2) Write a tree to quickly reduce the number of branch needed.

The first solution is not viable because 16bits strings case folding
remains an important bottleneck.

Instead, the code now splits the names on simple characteristics to
match any name in a limited number of branches.

The assumption is the input is correct, so & is used instead of && to
avoid branches in favor of conditional instructions.

* css/CSSParser.cpp:
(WebCore::TransformOperationInfo::TransformOperationInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderGeometryMap asserts when loading http://en.softonic.com/mac
simon.fraser@apple.com [Tue, 6 Nov 2012 01:45:43 +0000 (01:45 +0000)]
RenderGeometryMap asserts when loading en.softonic.com/mac
https://bugs.webkit.org/show_bug.cgi?id=101284
<rdar://problem/11540560>

Reviewed by Tim Horton.

When FrameView::layout() calls document->updateStyleIfNeeded(), we
can be in a state where FrameView::needsLayout() is false. However,
this is a bad time to update compositing layers, because we're about
to do layout, which will require us to update them again soon anyway,
and some RenderLayers may not have been sized or positioned yet.

Fix by adding a m_doingPreLayoutStyleUpdate member to FrameView,
and toggling it around this call to updateStyleIfNeeded().
Read this state in updateCompositingLayersAfterStyleChange(), which is
now called unconditionally by recalcStyle(), but returns early
if this flag is set, or layout is pending.

* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::layout):
* page/FrameView.h:
(FrameView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Fix build warning in PageClientLegacyImpl.cpp
commit-queue@webkit.org [Tue, 6 Nov 2012 00:54:19 +0000 (00:54 +0000)]
[EFL][WK2] Fix build warning in PageClientLegacyImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=101266

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-05
Reviewed by Laszlo Gombos.

The 'size' is not used when !USE(TILED_BACKING_STORE)
Use UNUSED_PARAM macro for removing -Wunused-parameter warning

* UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::updateViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=101275
bdakin@apple.com [Tue, 6 Nov 2012 00:48:06 +0000 (00:48 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=101275
Clean up ScrollingConstraints.h

Reviewed by Simon Fraser.

This class cleans up ScrollingConstraints.h by removing the constructors since the
compiler will generate those constructors for us anyway. The patch also makes the
two override functions private.
* page/scrolling/ScrollingConstraints.h:
(ViewportConstraints):
(FixedPositionViewportConstraints):
(StickyPositionViewportConstraints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake Document::updateStyleIfNeeded() non-virtual
simon.fraser@apple.com [Tue, 6 Nov 2012 00:35:57 +0000 (00:35 +0000)]
Make Document::updateStyleIfNeeded() non-virtual
https://bugs.webkit.org/show_bug.cgi?id=101273

Reviewed by Eric Seidel.

Document::updateStyleIfNeeded() has been virtual like forever, but
no-one ever overrides it, so make it non-virtual.

* dom/Document.h:
(Document):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed flaky fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html.
mark.lam@apple.com [Tue, 6 Nov 2012 00:23:27 +0000 (00:23 +0000)]
Fixed flaky fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html.
https://bugs.webkit.org/show_bug.cgi?id=101268.

Reviewed by Geoffrey Garen.

* fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit should have performance tests for book chapter reflow
ggaren@apple.com [Tue, 6 Nov 2012 00:14:52 +0000 (00:14 +0000)]
WebKit should have performance tests for book chapter reflow
https://bugs.webkit.org/show_bug.cgi?id=101271

Reviewed by Dan Bernstein.

I grabbed a book chapter from the Project Gutenberg front page:

* Layout/chapter-reflow-once.html: Added.
* Layout/chapter-reflow-thrice.html: Added.
* Layout/chapter-reflow-twice.html: Added.
* Layout/chapter-reflow.html: Added.

I also created a torture-test random text generator:

* Layout/chapter-reflow-once-random.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnblock SVG external references
pdr@google.com [Tue, 6 Nov 2012 00:13:50 +0000 (00:13 +0000)]
Unblock SVG external references
https://bugs.webkit.org/show_bug.cgi?id=100635

Reviewed by Adam Barth.

This patch reverts r132849 and r132869 because the potential XSS issue
turned out to not be an issue after all.

Covered by existing tests, many of which are re-whitelisted with this patch.

Source/WebCore:

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):

Source/WTF:

* wtf/Platform.h:

LayoutTests:

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd IRC alias for Glenn Adams
commit-queue@webkit.org [Mon, 5 Nov 2012 23:41:25 +0000 (23:41 +0000)]
Add IRC alias for Glenn Adams
https://bugs.webkit.org/show_bug.cgi?id=101262

Patch by Glenn Adams <glenn@skynav.com> on 2012-11-05
Reviewed by Eric Seidel.

Add IRC alias for Glenn Adams.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=101001
bdakin@apple.com [Mon, 5 Nov 2012 23:31:58 +0000 (23:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=101001
Pages with position:fixed elements should still be able to scroll on
the scrolling thread
-and corresponding-
<rdar://problem/10857315>

Reviewed by Simon Fraser.

Source/WebCore:

This patch adds two new classes. ScrollingStateFixedNode is a class
to represent fixed nodes in the state tree, and
ScrollingTreeFixedNode represents fixed node in the scrolling tree
over on the scrolling thread.
* WebCore.xcodeproj/project.pbxproj:

When we are (non-programatically) scrolling fixed objects on the
scrolling thread, we do not want to do any work here.
* page/FrameView.cpp:
(WebCore::FrameView::updateFixedElementsAfterScrolling):

Whenever we sync the position of the main frame's layer, we have to
do the same for scrolling tree children.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

New ScrollingNodeType -- FixedNode, yay! And two new functions
specific to dealing with FixedNodes.
* page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::updateViewportConstrainedNode):
(WebCore::ScrollingCoordinator::syncChildPositions):

This is the new class that represents fixed nodes in the state tree.
All of the changed properties are stored within
FixedPositionViewportConstraints.
* page/scrolling/ScrollingStateFixedNode.cpp: Added.
(WebCore):
(WebCore::ScrollingStateFixedNode::create):
(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::~ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::updateConstraints):
(WebCore::ScrollingStateFixedNode::dumpProperties):
* page/scrolling/ScrollingStateFixedNode.h: Added.
(WebCore):
(ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::viewportConstraints):
(WebCore::toScrollingStateFixedNode):

Make sure to create the right type of clone for each node.
* page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::cloneAndReset):

Now that m_children may be anything other than null, I found this
bug. We encounter it when the parameter to removeChild is this and we
want to remove all of our children. In that case, this is obviously
not found in its own child array.
(WebCore::ScrollingStateNode::removeChild):

ScrollingStateNode now caches the GraphicsLayer in addition to the
PlatformLayer. This will allow us to sync the GraphicsLayer position
at the appropriate times.
* page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::isScrollingStateFixedNode):
(WebCore::ScrollingStateNode::graphicsLayer):
(ScrollingStateNode):

Handle fixed nodes.
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):

New function parentScrollPositionDidChange() is called on children
when the parent has scrolled.
* page/scrolling/ScrollingTreeNode.h:
(ScrollingTreeNode):
* page/scrolling/ScrollingTreeScrollingNode.h:
(ScrollingTreeScrollingNode):

Return true for supportsFixedPositionLayers().
* page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollingCoordinatorMac):

Handle fixed nodes.
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::attachToStateTree):

Now that m_children can be non-null I caught this pre-existing bug
where we would come times remove a node without updating the HashMap.
This patch fixes that by consolidating the removal into one function.
(WebCore::ScrollingCoordinatorMac::removeNode):
(WebCore::ScrollingCoordinatorMac::detachFromStateTree):
(WebCore::ScrollingCoordinatorMac::clearStateTree):

Update the GraphicsLayers to reflect the new position that the
Scrolling thread has moved the underlying CALayer to already.
(WebCore::ScrollingCoordinatorMac::syncChildPositions):

Pass new constraints over to the appropriate state node.
(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):

Cache the GraphicsLayer in addition to the PlatformLayer.
* page/scrolling/mac/ScrollingStateNodeMac.mm:
(WebCore::ScrollingStateNode::setScrollLayer):

Here is the new class that represents fixed nodes over on the
scrolling thread.
* page/scrolling/mac/ScrollingTreeFixedNode.h: Added.
(WebCore):
(ScrollingTreeFixedNode):
* page/scrolling/mac/ScrollingTreeFixedNode.mm: Added.
(WebCore):
(WebCore::ScrollingTreeFixedNode::create):
(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):
(WebCore::ScrollingTreeFixedNode::~ScrollingTreeFixedNode):
(WebCore::ScrollingTreeFixedNode::update):

This is where the magic happens. re-position the fixed object when
its parent has scrolled so that it appears to have not moved at all.
(WebCore::ScrollingTreeFixedNode::parentScrollPositionDidChange):

Whenever we change the position of a scrolling layer, tell our
children.
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

Handle fixed nodes.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::attachToScrollingCoordinator):

detachFromScrollingCoordinator() needs to be public so that it can be
called from RenderLayerCompositor for fixed nodes.
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):

RenderLayerCompositor takes control of attaching and detaching fixed
nodes to/from the ScrollingCoordinator.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::didFlushChangesForLayer):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::didMoveOnscreen):
(WebCore::RenderLayerCompositor::willMoveOffscreen):
(WebCore::RenderLayerCompositor::clearBackingForLayerIncludingDescendants):
(WebCore::isRootmostFixedOrStickyLayer):
(WebCore):
(WebCore::RenderLayerCompositor::updateViewportConstraintStatus):
(WebCore::RenderLayerCompositor::addViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::removeViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::computeViewportConstraints):
(WebCore::nearestScrollingCoordinatorAncestor):
(WebCore::RenderLayerCompositor::registerOrUpdateViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::unregisterViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
(WebCore::RenderLayerCompositor::unregisterAllViewportConstrainedLayers):
* rendering/RenderLayerCompositor.h:
(WebCore):
(RenderLayerCompositor):

LayoutTests:

New tests.
* platform/mac/tiled-drawing/fixed: Added.
* platform/mac/tiled-drawing/fixed/absolute-inside-fixed-expected.txt: Added.
* platform/mac/tiled-drawing/fixed/absolute-inside-fixed.html: Added.
* platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt: Added.
* platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt: Added.
* platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html: Added.
* platform/mac/tiled-drawing/fixed/fixed-position-out-of-view.html: Added.
* platform/mac/tiled-drawing/fixed/four-bars-expected.txt: Added.
* platform/mac/tiled-drawing/fixed/four-bars.html: Added.
* platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt: Added.
* platform/mac/tiled-drawing/fixed/nested-fixed.html: Added.
* platform/mac/tiled-drawing/fixed/percentage-inside-fixed-expected.txt: Added.
* platform/mac/tiled-drawing/fixed/percentage-inside-fixed.html: Added.

These two tests are supposed to be in "slow scrolling" mode. Now that
fixed elements can scroll "fast," we need something else to force
slow scrolling. We should probably just add something to
window.internals to do that, but in the meantime,
background-attachment:fixed will work.
* platform/mac/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt:
* platform/mac/tiled-drawing/scrolling-tree-slow-scrolling.html:
* platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
* platform/mac/tiled-drawing/tile-coverage-slow-scrolling.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Mark fonts/cursive.html as flaky on MountainLion as well as...
aboxhall@chromium.org [Mon, 5 Nov 2012 23:22:08 +0000 (23:22 +0000)]
Unreviewed gardening. Mark fonts/cursive.html as flaky on MountainLion as well as Lion.
https://bugs.webkit.org/show_bug.cgi?id=83219

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleaned up the Font class in preparation for optimizing kerning and ligatures
ggaren@apple.com [Mon, 5 Nov 2012 23:18:51 +0000 (23:18 +0000)]
Cleaned up the Font class in preparation for optimizing kerning and ligatures
https://bugs.webkit.org/show_bug.cgi?id=101258

Reviewed by Dan Bernstein.

* platform/graphics/Font.h:
(WebCore::Font::typesettingFeatures):
(WebCore::Font::computeTypesettingFeatures): Compute and cache our
typesetting features instead of recomputing each time a client asks
for them. This makes the class interface easier to use because
"typesettingFeatures()" can appear in more than one expression without
undue performance cost. This may also be a small speedup to code that
calls typesettingFeatures() often for other reasons.

* platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::update): Ditto.

(WebCore::Font::width): Unforked the width() function so all width-related
interfaces can benefit from optimization without duplicate code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBack out controversial changes from Bug 98665.
commit-queue@webkit.org [Mon, 5 Nov 2012 23:10:07 +0000 (23:10 +0000)]
Back out controversial changes from Bug 98665.
https://bugs.webkit.org/show_bug.cgi?id=101244

Patch by Dima Gorbik <dgorbik@apple.com> on 2012-11-05
Reviewed by David Kilzer.

Backing out changes from Bug 98665 until further discussions take place on rules for including Platform.h in Assertions.h.

Source/JavaScriptCore:

* API/tests/minidom.c:
* API/tests/testapi.c:

Source/WTF:

* wtf/Assertions.h:

Tools:

* DumpRenderTree/mac/MockGeolocationProvider.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Mon, 5 Nov 2012 23:07:32 +0000 (23:07 +0000)]
[chromium] Unreviewed gardening.

* platform/chromium-mac-mountainlion/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebkit does not handle some media keys correctly On Linux gtk platform.
commit-queue@webkit.org [Mon, 5 Nov 2012 22:56:46 +0000 (22:56 +0000)]
Webkit does not handle some media keys correctly On Linux gtk platform.
https://bugs.webkit.org/show_bug.cgi?id=101221

Patch by Peng Huang <penghuang@google.com> on 2012-11-05
Reviewed by Alexey Proskuryakov.

Add media keyboard support on Linux gtk platform.

* platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBegin stubbing out the new remote layer tree drawing area
andersca@apple.com [Mon, 5 Nov 2012 22:52:04 +0000 (22:52 +0000)]
Begin stubbing out the new remote layer tree drawing area
https://bugs.webkit.org/show_bug.cgi?id=101256

Reviewed by Andreas Kling.

* Shared/DrawingAreaInfo.h:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingArea.cpp:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd support to -webkit-line-break property for CSS3 Text line-break property values...
commit-queue@webkit.org [Mon, 5 Nov 2012 22:39:10 +0000 (22:39 +0000)]
Add support to -webkit-line-break property for CSS3 Text line-break property values and semantics.
https://bugs.webkit.org/show_bug.cgi?id=89235

Patch by Glenn Adams <glenn@skynav.com> on 2012-11-05
Reviewed by Eric Seidel.

See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping

Source/WebCore:

Web exposed changes include:
(1) The default (initial) value for -webkit-line-break becomes 'auto', instead of 'normal';
(2) The values 'auto', 'loose', 'normal', and 'strict' are added to -webkit-line-break;
(3) See [2] above for details regarding interpretation.

Tests: css3/line-break/line-break-auto-centered.html
       css3/line-break/line-break-auto-half-kana.html
       css3/line-break/line-break-auto-hyphens.html
       css3/line-break/line-break-auto-inseparables.html
       css3/line-break/line-break-auto-iteration-marks.html
       css3/line-break/line-break-auto-postfixes.html
       css3/line-break/line-break-auto-prefixes.html
       css3/line-break/line-break-auto-sound-marks.html
       css3/line-break/line-break-loose-centered.html
       css3/line-break/line-break-loose-half-kana.html
       css3/line-break/line-break-loose-hyphens.html
       css3/line-break/line-break-loose-inseparables.html
       css3/line-break/line-break-loose-iteration-marks.html
       css3/line-break/line-break-loose-postfixes.html
       css3/line-break/line-break-loose-prefixes.html
       css3/line-break/line-break-loose-sound-marks.html
       css3/line-break/line-break-normal-centered.html
       css3/line-break/line-break-normal-half-kana.html
       css3/line-break/line-break-normal-hyphens.html
       css3/line-break/line-break-normal-inseparables.html
       css3/line-break/line-break-normal-iteration-marks.html
       css3/line-break/line-break-normal-postfixes.html
       css3/line-break/line-break-normal-prefixes.html
       css3/line-break/line-break-normal-sound-marks.html
       css3/line-break/line-break-strict-centered.html
       css3/line-break/line-break-strict-half-kana.html
       css3/line-break/line-break-strict-hyphens.html
       css3/line-break/line-break-strict-inseparables.html
       css3/line-break/line-break-strict-iteration-marks.html
       css3/line-break/line-break-strict-postfixes.html
       css3/line-break/line-break-strict-prefixes.html
       css3/line-break/line-break-strict-sound-marks.html

* platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
Add static function to construct ICU locale argument (also used as pool key) with additional
break keyword.
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):
Remove direct dependency from ICU library (and types), moving that dependency into
new {open,close}LineBreakIterator() functions (defined in TextBreakIteratorICU.cpp).
Update to take line break mode into account.
Create (and cache) different break iterators depending on line break mode (in addition to locale),
which entails expanding pool entry key format to optionally append "@break=" +
"loose"|"normal"|"strict" keyword to locale string.

* platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::isLooseCJKMode):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
Define LineBreakIteratorMode enumeration for use in TextBreakIterator et al.
Add state member to indicate line break mode.

* platform/text/TextBreakIteratorICU.cpp:
(WebCore::acquireLineBreakIterator):
Use new line break mode when making iterator from pool.
Handle change of return type of LineBreakIteratorPool::take() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::releaseLineBreakIterator):
Handle change of parameter type of LineBreakIteratorPool::put() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::isCJKLocale):
New functions for determining if CJK rules apply.
(WebCore::openLineBreakIterator):
New function for abstracting opening of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
This function also takes into account the line break mode.
(WebCore::closeLineBreakIterator):
(WebCore::mapLineIteratorModeToRules):
New function for abstracting closing of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Pass line break iterator mode flag when reseting LazyLineBreakIterator.
Add looseMode local variable to prevent need for computing under isBreakable().

* rendering/RenderText.cpp:
(WebCore::mapLineBreakToIteratorMode):
Add implementation for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
(WebCore::RenderText::computePreferredLogicalWidths):
Ensure (lazy line) breakIterator is initialized for line break mode.
Ensure isBreakable() is passed loose mode flag to match behavior in RenderBlock::LineBreaker::nextLineBreak.

* rendering/RenderText.h:
(WebCore):
Add declaration for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.

* rendering/break_lines.cpp:
(WebCore):
Introduce two (local) enums NBSPBehavior and LooseBehavior for expanding template on nextBreakablePosition
to include loose mode parameter.
(WebCore::isBreakableSpace):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation. Use new loose mode flavors off NBP functions.
(WebCore::needsLineBreakIterator):
Introduce loose mode behavior template parameter to optimize loose mode behavior code path in order
to prevent regression to non loose mode path.
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
Use new template parameter enums described above.
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
(WebCore::nextBreakablePositionLoose):
Introduce two additional 'loose' mode flavors of NBP template expansions.

* rendering/break_lines.h:
(WebCore):
(WebCore::isBreakable):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation.

LayoutTests:

* css3/line-break/line-break-auto-centered-expected.html: Added.
* css3/line-break/line-break-auto-centered.html: Added.
* css3/line-break/line-break-auto-half-kana-expected.html: Added.
* css3/line-break/line-break-auto-half-kana.html: Added.
* css3/line-break/line-break-auto-hyphens-expected.html: Added.
* css3/line-break/line-break-auto-hyphens.html: Added.
* css3/line-break/line-break-auto-inseparables-expected.html: Added.
* css3/line-break/line-break-auto-inseparables.html: Added.
* css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
* css3/line-break/line-break-auto-iteration-marks.html: Added.
* css3/line-break/line-break-auto-postfixes-expected.html: Added.
* css3/line-break/line-break-auto-postfixes.html: Added.
* css3/line-break/line-break-auto-prefixes-expected.html: Added.
* css3/line-break/line-break-auto-prefixes.html: Added.
* css3/line-break/line-break-auto-sound-marks-expected.html: Added.
* css3/line-break/line-break-auto-sound-marks.html: Added.
* css3/line-break/line-break-loose-centered-expected.html: Added.
* css3/line-break/line-break-loose-centered.html: Added.
* css3/line-break/line-break-loose-half-kana-expected.html: Added.
* css3/line-break/line-break-loose-half-kana.html: Added.
* css3/line-break/line-break-loose-hyphens-expected.html: Added.
* css3/line-break/line-break-loose-hyphens.html: Added.
* css3/line-break/line-break-loose-inseparables-expected.html: Added.
* css3/line-break/line-break-loose-inseparables.html: Added.
* css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
* css3/line-break/line-break-loose-iteration-marks.html: Added.
* css3/line-break/line-break-loose-postfixes-expected.html: Added.
* css3/line-break/line-break-loose-postfixes.html: Added.
* css3/line-break/line-break-loose-prefixes-expected.html: Added.
* css3/line-break/line-break-loose-prefixes.html: Added.
* css3/line-break/line-break-loose-sound-marks-expected.html: Added.
* css3/line-break/line-break-loose-sound-marks.html: Added.
* css3/line-break/line-break-normal-centered-expected.html: Added.
* css3/line-break/line-break-normal-centered.html: Added.
* css3/line-break/line-break-normal-half-kana-expected.html: Added.
* css3/line-break/line-break-normal-half-kana.html: Added.
* css3/line-break/line-break-normal-hyphens-expected.html: Added.
* css3/line-break/line-break-normal-hyphens.html: Added.
* css3/line-break/line-break-normal-inseparables-expected.html: Added.
* css3/line-break/line-break-normal-inseparables.html: Added.
* css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
* css3/line-break/line-break-normal-iteration-marks.html: Added.
* css3/line-break/line-break-normal-postfixes-expected.html: Added.
* css3/line-break/line-break-normal-postfixes.html: Added.
* css3/line-break/line-break-normal-prefixes-expected.html: Added.
* css3/line-break/line-break-normal-prefixes.html: Added.
* css3/line-break/line-break-normal-sound-marks-expected.html: Added.
* css3/line-break/line-break-normal-sound-marks.html: Added.
* css3/line-break/line-break-strict-centered-expected.html: Added.
* css3/line-break/line-break-strict-centered.html: Added.
* css3/line-break/line-break-strict-half-kana-expected.html: Added.
* css3/line-break/line-break-strict-half-kana.html: Added.
* css3/line-break/line-break-strict-hyphens-expected.html: Added.
* css3/line-break/line-break-strict-hyphens.html: Added.
* css3/line-break/line-break-strict-inseparables-expected.html: Added.
* css3/line-break/line-break-strict-inseparables.html: Added.
* css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
* css3/line-break/line-break-strict-iteration-marks.html: Added.
* css3/line-break/line-break-strict-postfixes-expected.html: Added.
* css3/line-break/line-break-strict-postfixes.html: Added.
* css3/line-break/line-break-strict-prefixes-expected.html: Added.
* css3/line-break/line-break-strict-prefixes.html: Added.
* css3/line-break/line-break-strict-sound-marks-expected.html: Added.
* css3/line-break/line-break-strict-sound-marks.html: Added.

* platform/chromium/css3/line-break/line-break-auto-half-kana-expected.html: Added.
* platform/chromium/css3/line-break/line-break-auto-sound-marks-expected.html: Added.
Override reftest expectations on chromium due to different ICU auto behavior.

* platform/chromium-android/css3/line-break/line-break-auto-half-kana-expected.html: Added.
* platform/chromium-android/css3/line-break/line-break-auto-sound-marks-expected.html: Added.
Override override of reftest expectations on chromium due to different ICU auto behavior;
that is, chromium-android seems to follow the generic expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] screenX/Y gives wrong values
rwlbuis@webkit.org [Mon, 5 Nov 2012 22:34:38 +0000 (22:34 +0000)]
[BlackBerry] screenX/Y gives wrong values
https://bugs.webkit.org/show_bug.cgi?id=101259

Reviewed by Yong Li.

PR 237071

Reviewed internally by Gen Mak.

Do not transform screenPos coordinates.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::mouseEvent):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitRegionLayoutUpdate is incorrectly named
abarth@webkit.org [Mon, 5 Nov 2012 22:32:07 +0000 (22:32 +0000)]
webkitRegionLayoutUpdate is incorrectly named
https://bugs.webkit.org/show_bug.cgi?id=100335

Reviewed by Ojan Vafai.

Source/WebCore:

DOM event names are supposed to be lower case.

* dom/EventNames.h:
(WebCore):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Update tests to use the proper name.

* fast/regions/webkit-named-flow-event-add-to-flow.html:
* fast/regions/webkit-named-flow-event-no-regions.html:
* fast/regions/webkit-named-flow-event-remove-from-dom.html:
* fast/regions/webkit-named-flow-event-remove-from-flow.html:
* fast/regions/webkit-named-flow-event-target.html:
* fast/regions/webkit-named-flow-event-to-null.html:
* fast/regions/webkit-named-flow-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
abarth@webkit.org [Mon, 5 Nov 2012 22:15:50 +0000 (22:15 +0000)]
[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110

Reviewed by Kentaro Hara.

Source/WebCore:

This patch generalizes our support for storing wrappers in DOM objects
to be usable for more than just nodes. After this patch, any object
with a ScriptWrappable base class will have its wrapper stored inline
in the object in the main world.

To achieve this goal, this patch hides the details of how we map from
objects to wrappers inside DOMDataStore and then removes the
IntrusiveDOMWrapperMap class entirely. This approach lets us remove the
DOMWrapperMap base class and make all of these functions non-virtual.

* UseV8.cmake:
* WebCore.gypi:
    - Remove deleted files.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
    - Rather than grabbing at the DOMWrapperMap directly, we now ask
      the DOMDataStore to do this work for us.
* bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::V8Float64Array::wrap):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::V8TestActiveDOMObject::wrap):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::V8TestCustomNamedGetter::wrap):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::V8TestEventConstructor::wrap):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::V8TestEventTarget::wrap):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::wrap):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::wrap):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::wrap):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::wrap):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::wrap):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::wrap):
* bindings/v8/DOMDataStore.cpp:
    - Updated run-bindings-test results.
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
    - Simplify constructor and destructor now that there is only one
      hash map.
(WebCore::DOMDataStore::current):
    - Now that V8DOMMap.cpp doesn't handle the null isolate case, we
      need to handle it here.
(WebCore::DOMDataStore::reportMemoryUsage):
    - Simplfied now that there is only one wrapper map.
(WebCore::DOMDataStore::weakCallback):
    - Moved from IntrusiveDOMWrapperMap.h
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
    - These functions now handle the intrusive case with a branch
      rather than with a virtual function call. In many cases, the
      branch can be optimized away by the compiler when the overloaded
      inline functions are inlined.
(WebCore::DOMDataStore::wrapperIsStoredInObject):
    - Overloaded functions to determine whether to store the wrapper
      inside the object or in the hashmap.
(WebCore::DOMDataStore::getWrapperFromObject):
(WebCore::DOMDataStore::storeWrapperInObject):
    - Overloaded functions to get/set the wrapper from inside the
      object itself.
* bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperHashMap::get):
(WebCore::DOMWrapperHashMap::set):
(WebCore::DOMWrapperHashMap::clear):
(WebCore::DOMWrapperHashMap::reportMemoryUsage):
(WebCore::DOMWrapperHashMap::remove):
    - These functions are no longer virtual.
* bindings/v8/DOMWrapperWorld.h:
* bindings/v8/IntrusiveDOMWrapperMap.h: Removed.
* bindings/v8/ScriptProfiler.cpp:
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::neuterBinding):
    - We need to keep the type information slightly longer so that we
      look in the right wrapper map.
* bindings/v8/V8DOMMap.cpp: Removed.
* bindings/v8/V8DOMMap.h: Removed.
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
    - Defer this work to the store.
(WebCore::V8DOMWrapper::setWrapperClass):
    - An overloaded function to set the right wrapper class.
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
    - This function is now general enough to handle ever kind of object.
* bindings/v8/V8GCController.cpp:
* bindings/v8/V8NPObject.cpp:
* bindings/v8/WorkerContextExecutionProxy.cpp:
* bindings/v8/WorkerScriptController.cpp:
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
    - Call the more general function (instead of the now-deleted specialized function).

Source/WebKit/chromium:

* src/WebScriptController.cpp:
    - Remove unneeded include of deleted file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove fast/forms/week-multiple-fields from
senorblanco@chromium.org [Mon, 5 Nov 2012 22:11:26 +0000 (22:11 +0000)]
Remove fast/forms/week-multiple-fields from
platform/mac/TestExpectations, since it no longer exists and makes the
style script complain.  Unreviewed.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Get rid of setCookieStoragePrivateBrowsingEnabled.
ap@apple.com [Mon, 5 Nov 2012 22:07:46 +0000 (22:07 +0000)]
    Get rid of setCookieStoragePrivateBrowsingEnabled.
        https://bugs.webkit.org/show_bug.cgi?id=101247

        Reviewed by Brady Eidson.

        We were only doing anything here on Mac, and only because we couldn't know if
        sessions were in use. But sessions are always in use, and those obsolete changing
        cookie storage explicitly.

        * platform/network/win/CookieStorageWin.cpp: Removed.
        * PlatformWinCE.cmake:
        * WebCore.gypi:
        No more CookieStorageWin.cpp with an empty implementation.

        * WebCore.exp.in:
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
        We no longer need this WKSI function.

        * page/Settings.cpp: (WebCore::Settings::setPrivateBrowsingEnabled):
        Removed the only call to setCookieStoragePrivateBrowsingEnabled().

        * platform/network/CookieStorage.h:
        * platform/network/cf/CookieStorageCFNet.cpp:
        * platform/network/curl/CookieJarCurl.cpp:
        * platform/network/soup/CookieStorageSoup.cpp:
        * platform/qt/TemporaryLinkStubsQt.cpp:
        Removed empty setCookieStoragePrivateBrowsingEnabled implementations.

        * platform/network/mac/CookieStorageMac.mm: This function used to have a FIXME
        that we should observe private storage while in private browsing mode. I don't think
        that it was correct - Safari doesn't display content of private storage, and thus
        doesn't need to know about changes.
        The removal of this function has an effect on WebKit1 clients that enable private
        browsing. We used to globally change cookie storage, even for loads not initiated
        by WebKit. Now we match API description: "If private browsing is enabled, WebKit
        will not store information about sites the user visits."

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Give actual bug IDs to some past gardening. Unreviewed.
senorblanco@chromium.org [Mon, 5 Nov 2012 22:03:56 +0000 (22:03 +0000)]
[chromium] Give actual bug IDs to some past gardening.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Do not display error page for failed downloads
commit-queue@webkit.org [Mon, 5 Nov 2012 21:59:44 +0000 (21:59 +0000)]
[BlackBerry] Do not display error page for failed downloads
https://bugs.webkit.org/show_bug.cgi?id=101246

Internal PR: 236318
Internal reviewed by Joe Mason, Leo Yang.
Patch by Lianghui Chen <liachen@rim.com> on 2012-11-05
Reviewed by Rob Buis.

Right now when a main load, including all downloads, failed, it will
display an error page. This is not very user friendly, especially for
WebWorks application, which want to use its own user interface to info
user about the failure.
So we just stop displaying error page for downloads.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash when mixing layers, foreignObjects and SVG hidden containers
fmalita@chromium.org [Mon, 5 Nov 2012 21:51:24 +0000 (21:51 +0000)]
Crash when mixing layers, foreignObjects and SVG hidden containers
https://bugs.webkit.org/show_bug.cgi?id=87297

Reviewed by Dirk Schulze.

Source/WebCore:

Foreign objects may introduce content which requires layers, but layer creation is
suppressed within RenderSVGHiddenContainer subtrees and this yields an inconsistent render
tree state. This patch prevents foreignObject renderer instantiation under
RenderSVGHiddenContainers.

Test: svg/foreignObject/foreign-object-defs-crash.svg

* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::rendererIsNeeded):
(WebCore):
* svg/SVGForeignObjectElement.h:
(SVGForeignObjectElement):

LayoutTests:

* platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
* platform/chromium-win/svg/foreignObject/fO-parent-display-none-expected.txt:
* platform/chromium-win/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
* platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
* platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
* platform/chromium/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/chromium/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
* platform/chromium/svg/foreignObject/fO-parent-display-none-expected.txt:
* platform/chromium/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
* platform/chromium/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
* platform/chromium/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
* platform/efl/svg/foreignObject/fO-parent-display-none-expected.txt:
* platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
* platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
* platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
* platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/gtk/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
* platform/gtk/svg/foreignObject/fO-parent-display-none-expected.txt:
* platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
* platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
* platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
* platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
* platform/mac/svg/foreignObject/fO-parent-display-none-expected.txt:
* platform/mac/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
* platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
* platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
* platform/qt/svg/foreignObject/fO-parent-display-none-expected.txt:
* platform/qt/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
* platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
* platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
* svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
* svg/foreignObject/foreign-object-defs-crash-expected.txt: Added.
* svg/foreignObject/foreign-object-defs-crash.svg: Added.
* svg/foreignObject/text-tref-02-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the unused m_fixedPositionedElements from RenderView
simon.fraser@apple.com [Mon, 5 Nov 2012 21:43:13 +0000 (21:43 +0000)]
Remove the unused m_fixedPositionedElements from RenderView
https://bugs.webkit.org/show_bug.cgi?id=101251

Reviewed by Anders Carlsson.

m_fixedPositionedElements was completely unused. Remove it
and the related typedef.

* rendering/RenderView.h:
(RenderView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark several compositing tests as only failing Image
senorblanco@chromium.org [Mon, 5 Nov 2012 21:38:30 +0000 (21:38 +0000)]
[chromium] Mark several compositing tests as only failing Image
and not Text, after r133513.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] New compositing/tiling tests fail
ossy@webkit.org [Mon, 5 Nov 2012 21:25:07 +0000 (21:25 +0000)]
[Qt][WK2] New compositing/tiling tests fail
https://bugs.webkit.org/show_bug.cgi?id=101166

Unskip now passing tests after r133513.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix layer borders to cleaning appear and disappear on switching
simon.fraser@apple.com [Mon, 5 Nov 2012 21:07:33 +0000 (21:07 +0000)]
Fix layer borders to cleaning appear and disappear on switching
https://bugs.webkit.org/show_bug.cgi?id=101136

Source/WebCore:

Reviewed by Sam Weinig.

GraphicsLayers decided whether to show layer borders based
on a callback through the GraphicsLayerClient. This made it
hard to manage state, resulting in a failure to cleanly
hide layers when toggled off via the preference.

Changed the layer border and repaint counter visibility to be bits
stored on GraphicsLayer just like other properties, with getters
and setters. RenderLayerBacking now updates these debug
indicators when we update other compositing layer properties.

In GraphicsLayerCA, avoid calling updateDebugIndicators() explicitly
in several places by setting the change flag DebugIndicatorsChanged
for properties whose values affect the appearance of the debug border.

Removed the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter() which are no longer required.

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::updateDebugIndicators):
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setShowDebugBorder):
(WebCore::GraphicsLayer::isShowingDebugBorder):
(WebCore::GraphicsLayer::setShowRepaintCounter):
(WebCore::GraphicsLayer::isShowingRepaintCounter):
(WebCore::GraphicsLayer::repaintCount):
(WebCore::GraphicsLayer::incrementRepaintCount):
* platform/graphics/GraphicsLayerClient.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setMasksToBounds):
(WebCore::GraphicsLayerCA::setDrawsContent):
(WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateMasksToBounds):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateDebugBorder):
(WebCore::GraphicsLayerCA::setShowDebugBorder):
(WebCore::GraphicsLayerCA::setShowRepaintCounter):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::setupContentsLayer):
(WebCore::GraphicsLayerCA::cloneLayer):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
(WebCore::GraphicsLayerCA::platformCALayerShowDebugBorders):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDebugIndicators):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

Source/WebKit/blackberry:

Reviewed by Sam Weinig.

Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().

* Api/WebOverlay_p.h:
(WebOverlayPrivateWebKitThread):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
* Api/WebPage_p.h:
* WebKitSupport/DefaultTapHighlight.cpp:
* WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):
* WebKitSupport/InspectorOverlayBlackBerry.cpp:
* WebKitSupport/InspectorOverlayBlackBerry.h:
(InspectorOverlay):
* WebKitSupport/SelectionOverlay.cpp:
* WebKitSupport/SelectionOverlay.h:
(SelectionOverlay):

Source/WebKit/chromium:

Reviewed by Sam Weinig.

Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().

* src/NonCompositedContentHost.cpp:
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* src/PageOverlay.cpp:
* tests/GraphicsLayerChromiumTest.cpp:
* tests/ImageLayerChromiumTest.cpp:

Source/WebKit/gtk:

Reviewed by Sam Weinig.

Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().

* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
* WebCoreSupport/AcceleratedCompositingContextCairo.cpp:
* WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:

Source/WebKit/win:

Reviewed by Sam Weinig.

Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().

* WebView.cpp:
* WebView.h:

Source/WebKit2:

Reviewed by Sam Weinig.

Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().

* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
* WebProcess/WebPage/ca/LayerTreeHostCA.h:
(LayerTreeHostCA):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
* WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas
jamesr@google.com [Mon, 5 Nov 2012 20:49:05 +0000 (20:49 +0000)]
[chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas
https://bugs.webkit.org/show_bug.cgi?id=101016

Reviewed by Adrienne Walker.

Passing SkBitmap by value requires including SkBitmap.h, which is tricky for some clients to do since it
requires having the rest of skia's headers on the include path and setting up the correct config to set
preprocessor defines.  Also shuffles the parameter order around to make rolling easier since you can't override
just by const ref-ness.

* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::setFontAtlas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Input date should not popup dialog when readonly is set
rwlbuis@webkit.org [Mon, 5 Nov 2012 20:40:13 +0000 (20:40 +0000)]
[BlackBerry] Input date should not popup dialog when readonly is set
https://bugs.webkit.org/show_bug.cgi?id=101234

Reviewed by Yong Li.

PR 236114

Reviewed internally by Mike Fenton.

Suppress popup dialog if the input element has readonly attribute set.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::openColorPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] New compositing/tiling tests fail
simon.fraser@apple.com [Mon, 5 Nov 2012 20:36:06 +0000 (20:36 +0000)]
[Qt][WK2] New compositing/tiling tests fail
https://bugs.webkit.org/show_bug.cgi?id=101166

The platform-independent results should not contain visibleRect, since this is
only dumped on Mac.

* compositing/tiling/rotated-tiled-clamped-expected.txt:
* compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline some Lion results that were affected by enabling subpixel layout.
simon.fraser@apple.com [Mon, 5 Nov 2012 20:28:42 +0000 (20:28 +0000)]
Rebaseline some Lion results that were affected by enabling subpixel layout.

* platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/mac-lion/fast/text/international/hindi-spacing-expected.txt:
* platform/mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt:
* platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/mac-lion/fast/writing-mode/vertical-font-fallback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: lint, clean up rebaseline.py
dpranke@chromium.org [Mon, 5 Nov 2012 19:47:57 +0000 (19:47 +0000)]
webkitpy: lint, clean up rebaseline.py
https://bugs.webkit.org/show_bug.cgi?id=101240

Reviewed by Ojan Vafai.

Miscellaneous cleanup of lint errors and warnings.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(RebaselineTest._test_root):
(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AnalyzeBaselines.__init__):
(AbstractParallelRebaselineCommand):
(AbstractParallelRebaselineCommand._builders_to_fetch_from):
(AbstractParallelRebaselineCommand._files_to_add):
(AbstractParallelRebaselineCommand._rebaseline):
(RebaselineExpectations.__init__):
(Rebaseline.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(_BaseTestCase.setUp):
(TestAnalyzeBaselines.setUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch optimize-baselines should take a --platform arg
dpranke@chromium.org [Mon, 5 Nov 2012 19:28:01 +0000 (19:28 +0000)]
webkit-patch optimize-baselines should take a --platform arg
https://bugs.webkit.org/show_bug.cgi?id=97623

Reviewed by Ojan Vafai.

So that we can optionally limit/control which platforms' results
are affected.

This patch adds --platform to analyze-baselines as well.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(_baseline_search_hypergraph):
(BaselineOptimizer.__init__):
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(TestBaselineOptimizer.__init__):
(BaselineOptimizerTest.test_move_baselines):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(OptimizeBaselines.__init__):
(OptimizeBaselines.execute):
(AnalyzeBaselines.__init__):
(AnalyzeBaselines.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestAnalyzeBaselines.test_default):
(TestAnalyzeBaselines.test_missing_baselines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch rebaseline-expectations should take a --platform arg
dpranke@chromium.org [Mon, 5 Nov 2012 19:26:36 +0000 (19:26 +0000)]
webkit-patch rebaseline-expectations should take a --platform arg
https://bugs.webkit.org/show_bug.cgi?id=97621

Reviewed by Ojan Vafai.

So that we can limit which platforms we attempt to rebaseline;
this can reduce the noise the command produces if some ports
have errors or warnings in their TestExpectations files and/or
help produce more predictable results.

In testing this patch, I realized that the rebaseline-in-parallel
commands (rebaseline-json, rebaseline-expectations, etc.) can
cause multiple rebaseline-test-internal commands to attempt to
modify the TestExpectations files concurrently, and that we needed
to lock the files to prevent corruption; it would be nice if
we can split the updating-the-expectations-files out separately
from updating the filesystem (much like we do with the scm updates)
to avoid this concurrency.

* Scripts/webkitpy/common/system/file_lock_mock.py: Added.
(MockFileLock):
(MockFileLock.__init__):
(MockFileLock.acquire_lock):
(MockFileLock.release_lock):
* Scripts/webkitpy/common/system/systemhost.py:
(SystemHost.copy_current_environment):
(SystemHost):
(SystemHost.make_file_lock):
* Scripts/webkitpy/common/system/systemhost_mock.py:
(MockSystemHost.copy_current_environment):
(MockSystemHost):
(MockSystemHost.make_file_lock):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._update_expectations_file):
(RebaselineExpectations.__init__):
(RebaselineExpectations._add_tests_to_rebaseline_for_port):
(RebaselineExpectations.execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: clean up options for specifying multiple platforms at once
dpranke@chromium.org [Mon, 5 Nov 2012 19:24:39 +0000 (19:24 +0000)]
webkitpy: clean up options for specifying multiple platforms at once
https://bugs.webkit.org/show_bug.cgi?id=101140

Reviewed by Ojan Vafai.

This patch reworks how we display the help strings for --platform
options and how we filter out platforms matching a glob. This will
be useful as I add patches to ensure that all the webkit-patch
commands are using --platform consistently to filter ports.

There should be no functional changes resulting from this patch.

* Scripts/webkitpy/layout_tests/port/factory.py:
(platform_options):
(PortFactory.all_port_names):
(PortFactory.get_from_builder_name):
* Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.__init__):
(PrintBaselines.__init__):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(RebaselineJson.__init__):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineExpectations.setUp):
(TestRebaselineExpectations.test_rebaseline_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe layout test runner shouldn't wait for data if stdout/stderr have been closed
peter@chromium.org [Mon, 5 Nov 2012 19:21:39 +0000 (19:21 +0000)]
The layout test runner shouldn't wait for data if stdout/stderr have been closed
https://bugs.webkit.org/show_bug.cgi?id=101233

Reviewed by Dirk Pranke.

Trying to read the file descriptor for the stdout or stderr pipes when DumpRenderTree
has crashed during a Chromium Android layout test-run, which uses FIFOs for
communication, causes the File.fileno() method to raise a ValueError. Return early
if either of the pipes has already been closed.

* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._wait_for_data_and_update_buffers_using_select):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch rebaseline is broken
dpranke@chromium.org [Mon, 5 Nov 2012 19:17:13 +0000 (19:17 +0000)]
webkit-patch rebaseline is broken
https://bugs.webkit.org/show_bug.cgi?id=101235

Reviewed by Ojan Vafai.

It didn't get updated to handle the change in parsing --suffixes
properly, and the unit test didn't get updated either, masking the
problem.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(Rebaseline._tests_to_update):
(Rebaseline.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agolint-webkitpy doesn't autoinstall pylint properly.
dpranke@chromium.org [Mon, 5 Nov 2012 19:12:18 +0000 (19:12 +0000)]
lint-webkitpy doesn't autoinstall pylint properly.
https://bugs.webkit.org/show_bug.cgi?id=101106

Reviewed by Ojan Vafai.

Re-land r133381 with fix; ironically, lint-webkitpy would've
complained about the problem. Also modify pylintrc and clean up
any other lint errors in the modified files.

* Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._set_up_target_dir):
(AutoInstaller):
(AutoInstaller._make_package):
(AutoInstaller._create_scratch_directory):
(AutoInstaller._install):
(AutoInstaller.install):
* Scripts/webkitpy/pylintrc:
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
(AutoinstallImportHook):
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install_webpagereplay):
(AutoinstallImportHook._install):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.__init__):
(ThirdpartyTest.test_import_hook):
(ThirdpartyTest.test_imports):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExpose hit test related methods in public chromium port
commit-queue@webkit.org [Mon, 5 Nov 2012 19:10:39 +0000 (19:10 +0000)]
Expose hit test related methods in public chromium port
https://bugs.webkit.org/show_bug.cgi?id=101204

Patch by Bo Liu <boliu@chromium.org> on 2012-11-05
Reviewed by Adam Barth.

The methods are needed in implementating hit test related methods in the
Android WebView API.

The specific methods are:
[Web]HitTestResult::urlElement
[Web]HitTestResult::absoluteImageURL
[Web]HitTestResult::absoluteLinkURL
[Web]HitTestResult::isContentEditable
WebViewImpl::hitTestResultAt

* public/WebHitTestResult.h:
(WebKit):
(WebHitTestResult):
* public/WebView.h:
(WebKit):
(WebView):
* src/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::urlElement):
(WebKit):
(WebKit::WebHitTestResult::absoluteImageURL):
(WebKit::WebHitTestResult::absoluteLinkURL):
(WebKit::WebHitTestResult::isContentEditable):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::hitTestResultAt):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BLACKBERRY] Update touch code to reflect touch refactor
commit-queue@webkit.org [Mon, 5 Nov 2012 19:09:55 +0000 (19:09 +0000)]
[BLACKBERRY] Update touch code to reflect touch refactor
https://bugs.webkit.org/show_bug.cgi?id=101227

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-05
Reviewed by Rob Buis.

PR #2706785
Reviewed Internally by: Mike Lattanzio

Source/WebCore:

* platform/blackberry/PlatformTouchEventBlackBerry.cpp:
(WebCore::touchEventType):
(WebCore::PlatformTouchEvent::PlatformTouchEvent):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark css3/filters/custom/custom-filter-animation.html
senorblanco@chromium.org [Mon, 5 Nov 2012 19:08:26 +0000 (19:08 +0000)]
[chromium] Mark css3/filters/custom/custom-filter-animation.html
as timing out intermittently.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents
alokp@chromium.org [Mon, 5 Nov 2012 18:56:05 +0000 (18:56 +0000)]
[chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents
https://bugs.webkit.org/show_bug.cgi?id=99083

Reviewed by Stephen White.

Use LCD text setting passed to WebContentLayerClient::paintContents instead of turning it off for all composited layers.

Source/Platform:

* chromium/public/WebContentLayerClient.h:
(WebContentLayerClient):
(WebKit::WebContentLayerClient::paintContents):

Source/WebCore:

No new tests needed. This patch does not change anything functionally.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::paint):
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:
(OpaqueRectTrackingContentLayerDelegate):

Source/WebKit/chromium:

* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::paintContents):
* src/LinkHighlight.h:
(LinkHighlight):
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit::NonCompositedContentHost::paintContents):
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Build fix after http://trac.webkit.org/changeset/133488.
senorblanco@chromium.org [Mon, 5 Nov 2012 18:51:19 +0000 (18:51 +0000)]
[chromium] Build fix after trac.webkit.org/changeset/133488.
Removed a deleted file.  Unreviewed.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] toV8(impl) should return null if impl is 0
haraken@chromium.org [Mon, 5 Nov 2012 18:41:13 +0000 (18:41 +0000)]
[V8] toV8(impl) should return null if impl is 0
https://bugs.webkit.org/show_bug.cgi?id=101206

Reviewed by Adam Barth.

toV8(impl) should return null if impl is 0. However,
V8HTMLCollection::toV8() does not have the null check.
All other toV8()s return null.

No tests. I think there will be no call path that hits the change.

* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
alokp@chromium.org [Mon, 5 Nov 2012 18:18:10 +0000 (18:18 +0000)]
Unreviewed. Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement SimpleFontData::platformBoundsForGlyph on skia
dbarton@mathscribe.com [Mon, 5 Nov 2012 18:17:57 +0000 (18:17 +0000)]
Implement SimpleFontData::platformBoundsForGlyph on skia
https://bugs.webkit.org/show_bug.cgi?id=101115

Reviewed by Eric Seidel.

Source/WebCore:

The implementation is similar to SimpleFontData::platformWidthForGlyph on skia.

Tested by: fast/block/lineboxcontain/*glyphs*, mathml/presentation/*

* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph): Implemented.

LayoutTests:

Some lineboxcontain/etc. tests will need rebaselining.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReduce the verbosity of referring to QNaN in JavaScriptCore
fpizlo@apple.com [Mon, 5 Nov 2012 18:15:23 +0000 (18:15 +0000)]
Reduce the verbosity of referring to QNaN in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=101174

Reviewed by Geoffrey Garen.

Introduces a #define QNaN in JSValue.h, and replaces all previous uses of
std::numeric_limits<double>::quiet_NaN() with QNaN.

* API/JSValueRef.cpp:
(JSValueMakeNumber):
(JSValueToNumber):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitFloatTypedArrayGetByVal):
* runtime/CachedTranscendentalFunction.h:
(JSC::CachedTranscendentalFunction::initialize):
* runtime/DateConstructor.cpp:
(JSC::constructDate):
* runtime/DateInstanceCache.h:
(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
* runtime/JSCell.h:
(JSC::JSValue::getPrimitiveNumber):
* runtime/JSDateMath.cpp:
(JSC::parseDateFromNullTerminatedCharacters):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::toDouble):
(JSC::jsToNumber):
(JSC::parseFloat):
* runtime/JSValue.cpp:
(JSC::JSValue::toNumberSlowCase):
* runtime/JSValue.h:
(JSC):
* runtime/JSValueInlineMethods.h:
(JSC::jsNaN):
* runtime/MathObject.cpp:
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDecouple Attr logic from ElementAttributeData.
kling@webkit.org [Mon, 5 Nov 2012 18:06:23 +0000 (18:06 +0000)]
Decouple Attr logic from ElementAttributeData.
<http://webkit.org/b/101126>

Reviewed by Antti Koivisto.

Move all logic dealing with Attr DOM nodes from ElementAttributeData to Element.
This makes more sense since an Attr is tied to a single Element, but an ElementAttributeData
can be shared by any number of Elements at a given time.

Also updated naming convention from just "Attr" to "Attr node" in the code I was touching.
"Attr" is way too generic, and has been historically confused with WebCore::Attribute a lot.

* dom/Element.h:
* dom/ElementAttributeData.h:
* dom/Element.cpp:
(WebCore::attrNodeListMap):
(WebCore::attrNodeListForElement):
(WebCore::ensureAttrNodeListForElement):
(WebCore::removeAttrNodeListForElement):
(WebCore::findAttrNodeInList):
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
(WebCore::Element::detachAttrNodeFromElementWithValue):
(WebCore::Element::detachAllAttrNodesFromElement):
(WebCore::Element::cloneAttributesFromElement):

    Move everything Attr-related into Element.cpp while simplifying some loops and remove
    conditions that are no longer needed as they used to depend on having an attributeData().

* dom/Node.h:
(WebCore::Node::hasSyntheticAttrChildNodes):
(WebCore::Node::setHasSyntheticAttrChildNodes):

    Renamed the hasAttrList() node flag to hasSyntheticAttrChildNodes().

* dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):

    Remove awkward indirection and let the call site deal with removing the Attr node from
    the Element's list of Attr nodes.

* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::clearAttributes):

    Remove now-unused Element* argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, unskip a now passing test.
ossy@webkit.org [Mon, 5 Nov 2012 18:01:23 +0000 (18:01 +0000)]
[Qt] Unreviewed gardening, unskip a now passing test.

* platform/qt-5.0-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Exclusions] Polygon edges should span colinear vertices
commit-queue@webkit.org [Mon, 5 Nov 2012 17:53:01 +0000 (17:53 +0000)]
[CSS Exclusions] Polygon edges should span colinear vertices
https://bugs.webkit.org/show_bug.cgi?id=99343

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-05
Reviewed by Dirk Schulze.

Source/WebCore:

ExclusionPolygonEdges now span coincident and collinear vertices. Currently
pairs of vertices are only considered coincident if their coordinates are exactly
equal. Similarly, a vertex is only considered collinear with an edge if the area
of the triangle defined by the three vertices is exactly zero.  In the future it
may be useful to relax the comparison with zero.

Tests: fast/exclusions/shape-inside/shape-inside-coincident-vertices.html
       fast/exclusions/shape-inside/shape-inside-collinear-vertices.html

* rendering/ExclusionPolygon.cpp:
(WebCore::determinant): Used to measure collinearity.
(WebCore):
(WebCore::areCollinearPoints): True if three FloatPoint arguments are collinear per the test outlined above.
(WebCore::areCoincidentPoints): True if the two FloatPoint arguments are equal.
(WebCore::nextVertexIndex): The next vertex index in clockwise or counterclockwise order.
(WebCore::ExclusionPolygon::findNextEdgeVertexIndex): Return the index of the next non-coincident, non-collinear vertex.
(WebCore::ExclusionPolygon::ExclusionPolygon): Skip coincident and collinear vertices when building the list of edges.
* rendering/ExclusionPolygon.h: Added private findNextEdgeVertexIndex() declaration.

LayoutTests:

Verify that exclusion polygonal shape-inside layout is unaffected by coincident
or collinear vertices.

* fast/exclusions/shape-inside/shape-inside-coincident-vertices-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-coincident-vertices.html: Added.
* fast/exclusions/shape-inside/shape-inside-collinear-vertices-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-collinear-vertices.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Use POSIX implementation of SharedBuffer::createWithContentsOfFile()
commit-queue@webkit.org [Mon, 5 Nov 2012 17:33:27 +0000 (17:33 +0000)]
[EFL] Use POSIX implementation of SharedBuffer::createWithContentsOfFile()
https://bugs.webkit.org/show_bug.cgi?id=101228

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Get rid of EFL-specific implementation of SharedBuffer::createWithContentsOfFile()
and reuse the POSIX one since it is pretty much the same.

No new tests, no behavior change.

* PlatformEfl.cmake:
* platform/efl/SharedBufferEfl.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, unskip now passing tests.
ossy@webkit.org [Mon, 5 Nov 2012 17:25:15 +0000 (17:25 +0000)]
[Qt] Unreviewed gardening, unskip now passing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark inspector-protocol/debugger-pause-dedicated-worker.html
senorblanco@chromium.org [Mon, 5 Nov 2012 17:22:04 +0000 (17:22 +0000)]
[chromium] Mark inspector-protocol/debugger-pause-dedicated-worker.html
as also crashy, and give it a bug ID.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a comment about a return value of IDBKey::toV8()
haraken@chromium.org [Mon, 5 Nov 2012 16:32:07 +0000 (16:32 +0000)]
Add a comment about a return value of IDBKey::toV8()
https://bugs.webkit.org/show_bug.cgi?id=101212

Reviewed by Adam Barth.

Although all other toV8(impl) return null when impl is 0,
IDBKey::toV8(impl) is expected to return undefined when impl is 0.
This patch adds a comment about it.

No tests.

* bindings/js/JSIDBKeyCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Cairo] Make Cairo honor image orientation
dominik.rottsches@intel.com [Mon, 5 Nov 2012 16:23:48 +0000 (16:23 +0000)]
[Cairo] Make Cairo honor image orientation
https://bugs.webkit.org/show_bug.cgi?id=101207

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Implement transformed image drawing in BitmapImageCairo, similar
as it was done for Skia in bug 100179, r132384.
The image drawing code needs to transform the graphics context
depending on exif orientation in order for this to work.

No new tests, covered by fast/images/exif-* which are passing now.

* platform/graphics/BitmapImage.h: Enable draw function which respects image orientation for Cairo.
* platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::draw): Apply ImageOrientation's transformFromDefault() transformation to context.
(WebCore):

LayoutTests:

Unskip and rebaseline exif orientation tests for EFL.

* platform/efl-wk1/TestExpectations: Tests not passing here yet, since DRT needs a setShouldRespectImageOrientation setting.
* platform/efl/TestExpectations: Unskipping three exif orientation tests.
* platform/efl/fast/images/exif-orientation-css-expected.png: Added.
* platform/efl/fast/images/exif-orientation-css-expected.txt: Added.
* platform/efl/fast/images/exif-orientation-expected.png: Added.
* platform/efl/fast/images/exif-orientation-expected.txt: Added.
* platform/efl/fast/images/exif-orientation-image-document-expected.png: Added.
* platform/efl/fast/images/exif-orientation-image-document-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Dispose() and Clear() should be always coupled for safety
haraken@chromium.org [Mon, 5 Nov 2012 16:14:27 +0000 (16:14 +0000)]
[V8] Dispose() and Clear() should be always coupled for safety
https://bugs.webkit.org/show_bug.cgi?id=101191

Reviewed by Adam Barth.

Clear() is not mandatory. However, to avoid misusing already
disposed wrappers, Clear() should be always called just
after Dispose().

No tests. No change in behavior.

* bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperHashMap::defaultWeakCallback):
* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::IntrusiveDOMWrapperMap::weakCallback):
* bindings/v8/NPV8Object.cpp:
(WebCore::freeV8NPObject):
* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::~ScheduledAction):
* bindings/v8/V8NPObject.cpp:
(WebCore::V8NPTemplateMap::dispose):
(WebCore::weakNPObjectCallback):
(WebCore::forgetV8ObjectForNPObject):
* bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::dispose):
* bindings/v8/V8ValueCache.cpp:
(WebCore::cachedStringCallback):
(WebCore::IntegerCache::~IntegerCache):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::WeakReferenceCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Web Inspector: Add InspectorInstrumentaiton calls for timeline compositing.
kpiascik@rim.com [Mon, 5 Nov 2012 15:42:42 +0000 (15:42 +0000)]
[BlackBerry] Web Inspector: Add InspectorInstrumentaiton calls for timeline compositing.
https://bugs.webkit.org/show_bug.cgi?id=101213
RIM PR 178131

Reviewed by Rob Buis.

Internally Reviewed by Arvid Nilsson.

Added compositing events to the timeline for BlackBerry.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::willComposite):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::didComposite):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Exclusions] Layout of the first shape-inside line can be incorrect
commit-queue@webkit.org [Mon, 5 Nov 2012 15:25:12 +0000 (15:25 +0000)]
[CSS Exclusions] Layout of the first shape-inside line can be incorrect
https://bugs.webkit.org/show_bug.cgi?id=100996

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-05
Reviewed by Dirk Schulze.

Source/WebCore:

Made the conversion from floating point top/bottom logical shape bounds coordinates
LayoutUnits explicit and corrected the case where the top value was truncated.  A
float logicalTop value is converted to LayoutUnit with fromFloatCeil() to ensure
that the LayoutUnit value is within the shape.

Test: fast/exclusions/shape-inside/shape-inside-shape-logical-top.html

* rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::shapeLogicalTop): Redefined this method in terms of shapeLogicalBoundsY,Max().
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBottom):  Ditto.
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds):  Ditto.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBoundsY): Explicit conversion from floating point shape coordinates to LayoutUnits.
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBoundsMaxY): Ditto.

LayoutTests:

Verify that the first line of shape-inside content is laid out correctly
when the top of the shape's bounds has a non-integral value.

* fast/exclusions/shape-inside/shape-inside-shape-logical-top-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-shape-logical-top.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark a flaky test. Unreviewed.
senorblanco@chromium.org [Mon, 5 Nov 2012 15:17:52 +0000 (15:17 +0000)]
[chromium] Mark a flaky test.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add a now-failing test, remove a now-passing test. Unreviewed.
senorblanco@chromium.org [Mon, 5 Nov 2012 15:08:07 +0000 (15:08 +0000)]
[chromium] Add a now-failing test, remove a now-passing test.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoProtect against resource deletion during iteration in MemoryCache::pruneDeadResources...
antti@apple.com [Mon, 5 Nov 2012 15:02:29 +0000 (15:02 +0000)]
Protect against resource deletion during iteration in MemoryCache::pruneDeadResourcesToSize
https://bugs.webkit.org/show_bug.cgi?id=101211

Reviewed by Andreas Kling.

Some crashes have been seen under MemoryCache::pruneDeadResourcesToSize. A possible cause is that
destroyDecodedData() call ends up evicting the resource pointed by 'previous' pointer during iteration
and deleting the object. This looks in principle possible via stylesheets and SVG images.

Speculative fix, no repro, no obvious way to construct a test.

* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneDeadResourcesToSize):

    Use CachedResourceHandle to protect the 'previous' pointer during iteration. Check if the
    resource has been kicked out from the cache during destroyDecodedData() and stop iterating
    if has (as it may die when CachedResourceHandle releases it).
    The 'current' pointer is not protected as the resource it points to is allowed to die.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Disable registerProtocolHandler on Android
commit-queue@webkit.org [Mon, 5 Nov 2012 14:27:53 +0000 (14:27 +0000)]
[Chromium] Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=101199

Patch by Miguel Garcia <miguelg@chromium.org> on 2012-11-05
Reviewed by Julien Chaffraix.

Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
actually wired up internally. Disable the feature to avoid breaking feature detection
until we can implement it properly.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS
commit-queue@webkit.org [Mon, 5 Nov 2012 14:22:33 +0000 (14:22 +0000)]
[EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS
https://bugs.webkit.org/show_bug.cgi?id=100674

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Make a distinction between calling ewk_view_base_add and ewk_view_smart_add.
Calling ewk_view_base_add creates a desktop style view, that does not support
fixed layout size, while calling ewk_view_smart_add does support fixed layout size.
As a result, WebKitTestRunner and the inspector window do not support
fixed layout size, while MiniBrowser does. This change allows many DumpAsText
layout tests to pass without modification, when AC is enabled.

* PlatformEfl.cmake:
* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::informLoadCommitted):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::informContentsSizeChange):
* UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
(EwkViewImpl::pageClient):
(EwkViewImpl::setScaleFactor):
(EwkViewImpl::scaleFactor):
(EwkViewImpl::setScrollPosition):
(EwkViewImpl::scrollPosition):
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):
(createEwkView):
(ewk_view_base_add):
* UIProcess/efl/PageClientBase.cpp: Copied from Source/WebKit2/UIProcess/efl/PageClientImpl.cpp.
(WebKit::PageClientBase::PageClientBase):
(WebKit::PageClientBase::~PageClientBase):
(WebKit::PageClientBase::viewImpl):
(WebKit::PageClientBase::createDrawingAreaProxy):
(WebKit::PageClientBase::setViewNeedsDisplay):
(WebKit::PageClientBase::displayView):
(WebKit::PageClientBase::scrollView):
(WebKit::PageClientBase::viewSize):
(WebKit::PageClientBase::isViewWindowActive):
(WebKit::PageClientBase::isViewFocused):
(WebKit::PageClientBase::isViewVisible):
(WebKit::PageClientBase::isViewInWindow):
(WebKit::PageClientBase::processDidCrash):
(WebKit::PageClientBase::didRelaunchProcess):
(WebKit::PageClientBase::pageClosed):
(WebKit::PageClientBase::toolTipChanged):
(WebKit::PageClientBase::setCursor):
(WebKit::PageClientBase::setCursorHiddenUntilMouseMoves):
(WebKit::PageClientBase::registerEditCommand):
(WebKit::PageClientBase::clearAllEditCommands):
(WebKit::PageClientBase::canUndoRedo):
(WebKit::PageClientBase::executeUndoRedo):
(WebKit::PageClientBase::convertToDeviceSpace):
(WebKit::PageClientBase::convertToUserSpace):
(WebKit::PageClientBase::screenToWindow):
(WebKit::PageClientBase::windowToScreen):
(WebKit::PageClientBase::doneWithKeyEvent):
(WebKit::PageClientBase::doneWithTouchEvent):
(WebKit::PageClientBase::createPopupMenuProxy):
(WebKit::PageClientBase::createContextMenuProxy):
(WebKit::PageClientBase::createColorChooserProxy):
(WebKit::PageClientBase::setFindIndicator):
(WebKit::PageClientBase::enterAcceleratedCompositingMode):
(WebKit::PageClientBase::exitAcceleratedCompositingMode):
(WebKit::PageClientBase::updateAcceleratedCompositingMode):
(WebKit::PageClientBase::didChangeScrollbarsForMainFrame):
(WebKit::PageClientBase::didCommitLoadForMainFrame):
(WebKit::PageClientBase::didFinishLoadingDataForCustomRepresentation):
(WebKit::PageClientBase::customRepresentationZoomFactor):
(WebKit::PageClientBase::setCustomRepresentationZoomFactor):
(WebKit::PageClientBase::flashBackingStoreUpdates):
(WebKit::PageClientBase::findStringInCustomRepresentation):
(WebKit::PageClientBase::countStringMatchesInCustomRepresentation):
(WebKit::PageClientBase::updateTextInputState):
(WebKit::PageClientBase::handleDownloadRequest):
* UIProcess/efl/PageClientBase.h: Copied from Source/WebKit2/UIProcess/efl/PageClientImpl.h.
(PageClientBase):
* UIProcess/efl/PageClientDefaultImpl.cpp: Added.
(WebKit):
(WebKit::PageClientDefaultImpl::PageClientDefaultImpl):
(WebKit::PageClientDefaultImpl::didCommitLoad):
(WebKit::PageClientDefaultImpl::updateViewportSize):
(WebKit::PageClientDefaultImpl::didChangeViewportProperties):
(WebKit::PageClientDefaultImpl::didChangeContentsSize):
(WebKit::PageClientDefaultImpl::pageDidRequestScroll):
(WebKit::PageClientDefaultImpl::didRenderFrame):
(WebKit::PageClientDefaultImpl::pageTransitionViewportReady):
* UIProcess/efl/PageClientDefaultImpl.h: Added.
(WebKit):
(PageClientDefaultImpl):
(WebKit::PageClientDefaultImpl::create):
(WebKit::PageClientDefaultImpl::~PageClientDefaultImpl):
* UIProcess/efl/PageClientImpl.cpp: Removed.
* UIProcess/efl/PageClientImpl.h: Removed.
* UIProcess/efl/PageClientLegacyImpl.cpp: Added.
(WebKit):
(WebKit::PageClientLegacyImpl::PageClientLegacyImpl):
(WebKit::PageClientLegacyImpl::didCommitLoad):
(WebKit::PageClientLegacyImpl::updateViewportSize):
(WebKit::PageClientLegacyImpl::didChangeViewportProperties):
(WebKit::PageClientLegacyImpl::didChangeContentsSize):
(WebKit::PageClientLegacyImpl::pageDidRequestScroll):
(WebKit::PageClientLegacyImpl::didRenderFrame):
(WebKit::PageClientLegacyImpl::pageTransitionViewportReady):
* UIProcess/efl/PageClientLegacyImpl.h: Added.
(WebKit):
(PageClientLegacyImpl):
(WebKit::PageClientLegacyImpl::create):
(WebKit::PageClientLegacyImpl::~PageClientLegacyImpl):
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setContentsScale):
* UIProcess/efl/PageViewportControllerClientEfl.h:
* UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::viewWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Fix jscompiler cast syntax
commit-queue@webkit.org [Mon, 5 Nov 2012 14:15:14 +0000 (14:15 +0000)]
Web Inspector: Fix jscompiler cast syntax
https://bugs.webkit.org/show_bug.cgi?id=101066

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-05
Reviewed by Pavel Feldman.

Casts should be in the form of "/** @type {TypeName} */ (expr)" instead of "/** @type {TypeName} */ expr".

* inspector/InjectedScriptCanvasModuleSource.js:
(.):
* inspector/InjectedScriptSource.js:
(.):
* inspector/front-end/ApplicationCacheModel.js:
(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype._onRequestStarted):
(WebInspector.AuditLauncherView.prototype._onRequestFinished):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype._uiSourceCodeFormatted):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.Breakpoint.prototype._locationUpdated):
(WebInspector.BreakpointManager.Storage):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):
* inspector/front-end/CSSNamedFlowCollectionsView.js:
(WebInspector.CSSNamedFlowCollectionsView.prototype._documentUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._namedFlowCreated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._regionLayoutUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._selectedNodeChanged):
* inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSProfileHeader.prototype.createView):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.LiveLocation.prototype.uiLocation):
(WebInspector.CSSStyleDeclaration.parseComputedStylePayload):
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._frameAdded):
(WebInspector.ConsoleView.prototype._frameRemoved):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMDocument):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointByURL):
(WebInspector.DebuggerModel.prototype.):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.CallFrame.prototype.get location):
* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping.prototype._parsedScriptSource):
* inspector/front-end/DirectoryContentView.js:
(WebInspector.DirectoryContentView.prototype._sort):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._updateBreadcrumbIfNeeded):
* inspector/front-end/ElementsPanelDescriptor.js:
(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):
* inspector/front-end/ElementsTreeOutline.js:
(.get node):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype._notifyUISourceCodeContentCommitted):
(WebInspector.ExtensionServer.prototype._notifyRequestFinished):
* inspector/front-end/FileContentView.js:
(WebInspector.FileContentView.prototype._metadataReceived):
(WebInspector.FileContentView.FileContentProvider.prototype.requestContent):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._frameAdded):
(WebInspector.FileSystemModel.prototype._frameNavigated):
(WebInspector.FileSystemModel.prototype._frameDetached):
* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView.EntryTreeElement.prototype.onselect):
(WebInspector.FileSystemView.EntryTreeElement.prototype.refresh):
* inspector/front-end/HandlerRegistry.js:
(WebInspector.HandlerRegistry.prototype._appendHrefItems):
* inspector/front-end/HeapSnapshotLoader.js:
(WebInspector.HeapSnapshotLoader.prototype.write):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._changeBase):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._snapshotReceived):
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.prototype._frameNavigated):
(WebInspector.IndexedDBModel.prototype._frameDetached):
* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._keyColumnHeaderFragment):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._handleGutterClick):
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype.show):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._uiSourceCodeTitleChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyCommitted):
(WebInspector.NavigatorView.prototype._uiSourceCodeFormattedChanged):
* inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog.prototype._onRequestStarted):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._onRequestUpdated):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):
(WebInspector.NetworkPanel.prototype.reveal):
(WebInspector.NetworkPanel.prototype.appendApplicableItems):
* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
* inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleMessageAdded):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onRequestFinished):
(WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._databaseAdded):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBLoaded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemAdded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemTreeElementByName):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):
* inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView.prototype._uiSourceCodeRemoved):
* inspector/front-end/SASSSourceMapping.js:
(rawLocationToUILocation):
* inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update):
* inspector/front-end/Script.js:
(WebInspector.Script.Location.prototype.uiLocation):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype.get _worker):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
(WebInspector.ScriptsPanel.prototype.canSearchAndReplace):
(WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
(WebInspector.ScriptsPanel.prototype.replaceAllWith):
(WebInspector.ScriptsPanel.prototype._toggleBreakpoint):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
* inspector/front-end/ScriptsPanelDescriptor.js:
(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):
* inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._scrollChanged):
(WebInspector.TabbedEditorContainer.prototype._selectionChanged):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._tabSelected):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeTitleChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyCommitted):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeFormattedChanged):
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModelLoader.prototype.write):
* inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):
* inspector/front-end/Workspace.js:
(WebInspector.WorkspaceController.prototype._frameAdded):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix broken comment in WK2 TestExpectations
pierre.rossi@gmail.com [Mon, 5 Nov 2012 14:09:28 +0000 (14:09 +0000)]
[Qt] Fix broken comment in WK2 TestExpectations

Unreviewed fix, just an obviously missing '#' character.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/events/popup-allowed-from-gesture-initiated-event.html is flaky
commit-queue@webkit.org [Mon, 5 Nov 2012 14:08:00 +0000 (14:08 +0000)]
fast/events/popup-allowed-from-gesture-initiated-event.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101208

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Close the new popup between each test to make sure the new window
does not mask the buttons and therefore prevent them from being
clicked. This addresses flakiness for this test.

* fast/events/popup-allowed-from-gesture-initiated-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: render message bubbles in CodeMirror experiment.
pfeldman@chromium.org [Mon, 5 Nov 2012 13:43:11 +0000 (13:43 +0000)]
Web Inspector: render message bubbles in CodeMirror experiment.
https://bugs.webkit.org/show_bug.cgi?id=101164

Reviewed by Vsevolod Vlasov.

It sounds like addLineWidget just makes it happen.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.addDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.get if):
(WebInspector.CodeMirrorTextEditor.prototype.removeDecoration):
(WebInspector.CodeMirrorTextEditor.prototype._change):
* inspector/front-end/DefaultTextEditor.js:
(.preventDefaultOnMouseUp):
* inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper):
* inspector/front-end/cm/cmdevtools.css:
(.CodeMirror .webkit-html-message-bubble):
(.CodeMirror .webkit-html-message-bubble img):
(.CodeMirror .webkit-html-warning-message):
(.CodeMirror .webkit-html-error-message):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133460 268f45cc-cd09-0410-ab3c-d52691b4dbfc