bfulgham@apple.com [Wed, 17 Jul 2013 23:27:27 +0000 (23:27 +0000)]
Correct webkit.org blog RSS address.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achristensen@apple.com [Wed, 17 Jul 2013 23:04:16 +0000 (23:04 +0000)]
Unreviewed. Skip more failing WebGL tests on Mac.
* platform/mac-lion/TestExpectations:
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Wed, 17 Jul 2013 23:02:44 +0000 (23:02 +0000)]
fullscreen/full-screen-iframe-with-max-width-height.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=118820
Unreviewed.
Label a flaky test as flaky
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 17 Jul 2013 22:14:47 +0000 (22:14 +0000)]
JSStringCreateWithCFString should not convert the empty string into the NULL string
https://bugs.webkit.org/show_bug.cgi?id=118816
Reviewed by Sam Weinig.
* API/JSStringRef.cpp:
(JSStringCreateWithUTF8CString): Removed an extraneous comment, which
a previous version of the patch made incorrect.
* API/JSStringRefCF.cpp:
(JSStringCreateWithCFString): Don't convert the empty string into the
null string.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 17 Jul 2013 22:08:35 +0000 (22:08 +0000)]
Optimize RenderLayerCompositor's OverlapMap
https://bugs.webkit.org/show_bug.cgi?id=118764
Reviewed by Tim Horton.
Overlap stack items can have RectLists with hundreds of rectangles.
This makes the linear search in OverlapMap::overlapsLayers() very slow.
Optimize by storing the bounding rect of the list of rects, and doing an early
check on that. This reduces time spent in RenderLayer::scrollTo() by 13% in some
content with lots of layers inside an overflow:scroll.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::OverlapMap::overlapsLayers):
(WebCore::RenderLayerCompositor::OverlapMap::popCompositingContainer):
(WebCore::RenderLayerCompositor::OverlapMap::RectList::append):
(WebCore::RenderLayerCompositor::OverlapMap::RectList::intersects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 17 Jul 2013 22:05:45 +0000 (22:05 +0000)]
[Mac] Crashes in CFURLGetBytes under WebProcess::updateActivePages()
https://bugs.webkit.org/show_bug.cgi?id=118814
<rdar://problem/
14173389>
Reviewed by Brady Eidson.
Speculative fix. It's unclear how we end up with an invalid URL when committing
a load.
* WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::updateActivePages):
Added a null check.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Wed, 17 Jul 2013 21:22:01 +0000 (21:22 +0000)]
Unreviewed gardening after r152800.
https://bugs.webkit.org/show_bug.cgi?id=118810.
CSS_SHAPES not yet supported on AppleWin port.
* platform/win/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Wed, 17 Jul 2013 21:16:06 +0000 (21:16 +0000)]
Unreviewed gardening.
Skip some tests on AppleWin port that requires AVFoundation, since it does not support it yet.
* platform/win/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Wed, 17 Jul 2013 20:42:00 +0000 (20:42 +0000)]
Unreviewed. Rebaseline tests for AppleWin port after r152789.
* platform/win/editing/pasteboard/paste-noplugin-expected.txt: Added.
* platform/win/platform/win/plugins/draws-gradient-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
betravis@adobe.com [Wed, 17 Jul 2013 20:31:29 +0000 (20:31 +0000)]
[CSS Shapes][CSS Exclusions] Cleanup tests to reflect split between CSS Shapes and CSS Exclusions
https://bugs.webkit.org/show_bug.cgi?id=117164
Reviewed by Alexandru Chiculita.
Moving shapes tests from the fast/exclusions directory to the new fast/shapes directory.
In addition, some parsing tests which included both exclusions and shapes properties
have been split in order for each piece of functionality to sit within its own directory.
* fast/exclusions/parsing/script-tests/parsing-test-utils.js:
* fast/shapes/css-shapes-disabled-expected.txt: Added.
* fast/shapes/css-shapes-disabled.html: Added.
* fast/shapes/css-shapes-enabled-expected.txt: Added.
* fast/shapes/css-shapes-enabled.html: Added.
* fast/shapes/parsing/parsing-shape-inside-expected.txt: Added.
* fast/shapes/parsing/parsing-shape-inside.html: Added.
* fast/shapes/parsing/parsing-shape-lengths-expected.txt: Added.
* fast/shapes/parsing/parsing-shape-lengths.html: Added.
* fast/shapes/parsing/parsing-shape-margin-expected.txt: Added.
* fast/shapes/parsing/parsing-shape-margin.html: Added.
* fast/shapes/parsing/parsing-shape-outside-expected.txt: Added.
* fast/shapes/parsing/parsing-shape-outside.html: Added.
* fast/shapes/parsing/parsing-shape-padding-expected.txt: Added.
* fast/shapes/parsing/parsing-shape-padding.html: Added.
* fast/shapes/parsing/script-tests/parsing-shape-inside.js: Added.
* fast/shapes/parsing/script-tests/parsing-shape-lengths.js: Added.
* fast/shapes/parsing/script-tests/parsing-shape-margin.js: Added.
* fast/shapes/parsing/script-tests/parsing-shape-outside.js: Added.
* fast/shapes/parsing/script-tests/parsing-shape-padding.js: Added.
* fast/shapes/parsing/script-tests/parsing-test-utils.js: Added.
* fast/shapes/resources/multi-segment-polygon.js: Added.
* fast/shapes/resources/rounded-rectangle.js: Added.
* fast/shapes/resources/simple-polygon.js: Added.
* fast/shapes/resources/simple-rectangle.js: Added.
* fast/shapes/resources/subpixel-utils.js: Added.
* fast/shapes/shape-inside/shape-inside-animation-expected.txt: Added.
* fast/shapes/shape-inside/shape-inside-animation.html: Added.
* fast/shapes/shape-inside/shape-inside-bottom-edge-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-bottom-edge.html: Added.
* fast/shapes/shape-inside/shape-inside-box-sizing-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-box-sizing.html: Added.
* fast/shapes/shape-inside/shape-inside-circle-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-circle-padding-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-circle-padding.html: Added.
* fast/shapes/shape-inside/shape-inside-circle.html: Added.
* fast/shapes/shape-inside/shape-inside-coincident-vertices-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-coincident-vertices.html: Added.
* fast/shapes/shape-inside/shape-inside-collinear-vertices-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-collinear-vertices.html: Added.
* fast/shapes/shape-inside/shape-inside-counterclockwise-polygon-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-counterclockwise-polygon.html: Added.
* fast/shapes/shape-inside/shape-inside-dynamic-nested-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-dynamic-nested.html: Added.
* fast/shapes/shape-inside/shape-inside-dynamic-shape-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-dynamic-shape.html: Added.
* fast/shapes/shape-inside/shape-inside-dynamic-text-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-dynamic-text.html: Added.
* fast/shapes/shape-inside/shape-inside-ellipse-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-ellipse-padding-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-ellipse-padding.html: Added.
* fast/shapes/shape-inside/shape-inside-ellipse.html: Added.
* fast/shapes/shape-inside/shape-inside-empty-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-empty-segments-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-empty-segments.html: Added.
* fast/shapes/shape-inside/shape-inside-empty.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-001-horizontal-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-001-horizontal.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-001-vertical-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-001-vertical.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-002.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-003-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-003.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-004-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-004.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-reflex-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-first-fit-reflex.html: Added.
* fast/shapes/shape-inside/shape-inside-floats-simple-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-floats-simple.html: Added.
* fast/shapes/shape-inside/shape-inside-inline-elements-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-inline-elements.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-blocks-dynamic-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-blocks-dynamic.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-blocks-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-blocks-vertical-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-blocks-vertical.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-blocks.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-001.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-002.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-003-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-003.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-004-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-multiple-segments-004.html: Added.
* fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Added.
* fast/shapes/shape-inside/shape-inside-outside-shape-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-outside-shape.html: Added.
* fast/shapes/shape-inside/shape-inside-overflow-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html: Added.
* fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions.html: Added.
* fast/shapes/shape-inside/shape-inside-overflow.html: Added.
* fast/shapes/shape-inside/shape-inside-partial-fill-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-partial-fill-001.html: Added.
* fast/shapes/shape-inside/shape-inside-partial-fill-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-partial-fill-002.html: Added.
* fast/shapes/shape-inside/shape-inside-percentage-auto-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-percentage-auto.html: Added.
* fast/shapes/shape-inside/shape-inside-percentage-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-percentage.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-layout-expected.txt: Added.
* fast/shapes/shape-inside/shape-inside-polygon-layout.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-padding-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-padding-001.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-padding-002-expected.txt: Added.
* fast/shapes/shape-inside/shape-inside-polygon-padding-002.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-padding-003-expected.txt: Added.
* fast/shapes/shape-inside/shape-inside-polygon-padding-003.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-rectangle-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-rectangle.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-zoom-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-polygon-zoom.html: Added.
* fast/shapes/shape-inside/shape-inside-rectangle-padding-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rectangle-padding.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-001.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-002.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-003-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-003.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-004-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rectilinear-polygon-004.html: Added.
* fast/shapes/shape-inside/shape-inside-recursive-layout-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-recursive-layout.html: Added.
* fast/shapes/shape-inside/shape-inside-regular-polygon16-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-regular-polygon16.html: Added.
* fast/shapes/shape-inside/shape-inside-regular-polygon8-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-regular-polygon8.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-001.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-002.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-003-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-003.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-004-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-004.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-001.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-003-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-003.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-large-radius-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-large-radius.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-padding-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-rounded-rectangle-padding.html: Added.
* fast/shapes/shape-inside/shape-inside-shape-logical-top-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-shape-logical-top.html: Added.
* fast/shapes/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-001-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-001.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-002-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-002.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-003-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-003.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-004-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-simple-polygon-004.html: Added.
* fast/shapes/shape-inside/shape-inside-subsequent-blocks-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-subsequent-blocks.html: Added.
* fast/shapes/shape-inside/shape-inside-text-align-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-text-align.html: Added.
* fast/shapes/shape-inside/shape-inside-text-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-text.html: Added.
* fast/shapes/shape-inside/shape-inside-vertical-text-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-vertical-text.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-circle-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-circle.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-ellipse.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-polygon-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-polygon.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-horizontal-multiple-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-horizontal-multiple.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-percentage-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-percentage.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-001-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-002-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-002.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-003-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-003.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-stacked-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-stacked.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 19:31:39 +0000 (19:31 +0000)]
Unreviewed, rolling out r152786 and r152789.
http://trac.webkit.org/changeset/152786
http://trac.webkit.org/changeset/152789
https://bugs.webkit.org/show_bug.cgi?id=118807
overly platform specific and dirty API (and Sam says no)
(Requested by thorton on #webkit).
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
* WebProcess/WebPage/PageOverlay.cpp:
* WebProcess/WebPage/PageOverlay.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 19:24:50 +0000 (19:24 +0000)]
[CSS Shapes] Port refactoring of shape-outside code from Blink
https://bugs.webkit.org/show_bug.cgi?id=118757
Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-07-17
Reviewed by Dean Jackson.
Refactor the left and right offset methods to reduce the number of
arguments by splitting the methods into smaller methods. This
refactoring was requested as part of porting support for stacked
floats with shape-outside to Blink.
Also add a variable when calling computeSegmentsForLine to make it
more readable and easier to follow the coordinate system change.
No new tests, no behavior change.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Update to use
the refactored IgnoringShapeOutside methods.
(WebCore::RenderBlock::logicalLeftFloatOffsetForLine): New method to
compute the offset contributed by left floats.
(WebCore::RenderBlock::adjustLogicalLeftOffsetForLine): New method to
compute misc adjustments to the left offset.
(WebCore::RenderBlock::logicalRightFloatOffsetForLine): New method to
compute the offset contributed by right floats.
(WebCore::RenderBlock::adjustLogicalRightOffsetForLine): New method to
compute misc adjustments to the right offset.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine): Implement original
method in terms of the float offset computation method and the
offset adjustment method. This method takes into account the
shape-outside on any floats when computing the offset.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Ditto.
(WebCore::RenderBlock::logicalRightOffsetForLineIgnoringShapeOutside):
Compute the right offset as if there was no shape-outside on any
of the floats.
(WebCore::RenderBlock::logicalLeftOffsetForLineIgnoringShapeOutside):
Compute the left offset as if there was no shape-outside on any
of the floats.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Update
to use a variable to make the calls to computeSegmentsForLine more
explicit about the coordinate system conversion.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Wed, 17 Jul 2013 18:46:39 +0000 (18:46 +0000)]
Wrong linebox height, when block element parent has vertical-align property defined.
https://bugs.webkit.org/show_bug.cgi?id=118245
Patch by Zalan Bujtas <zalan@apple.com> on 2013-07-17
Reviewed by David Hyatt.
Do not push the current element to the next, when it is still considered empty, even with
some object(s) in front. Behave as if it was actually empty.
Inline elements like <span></span> generate such lines.
Source/WebCore:
Test: fast/css/empty-span-with-parent-div-and-vertical-align.html
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
* fast/css/empty-span-with-parent-div-and-vertical-align-expected.html: Added.
* fast/css/empty-span-with-parent-div-and-vertical-align.html: Added.
* platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.png: Rebased.
* platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Rebased.
* platform/mac/tables/mozilla/marvin/backgr_index-expected.png: Rebased.
* platform/mac/tables/mozilla/marvin/backgr_index-expected.txt: Rebased.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 18:07:49 +0000 (18:07 +0000)]
Unreviewed, rolling out r151535.
http://trac.webkit.org/changeset/151535
https://bugs.webkit.org/show_bug.cgi?id=118804
Re-disable WinEWS tests (Requested by rfong on #webkit).
* Scripts/webkitpy/common/config/ews.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achristensen@apple.com [Wed, 17 Jul 2013 17:59:30 +0000 (17:59 +0000)]
Unreviewed. Skip failing WebGL tests.
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Wed, 17 Jul 2013 17:38:24 +0000 (17:38 +0000)]
AX: VoiceOver not working with data detection page overlays
https://bugs.webkit.org/show_bug.cgi?id=118680
Reviewed by Anders Carlsson.
Bump the API version after r152786.
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Wed, 17 Jul 2013 17:21:51 +0000 (17:21 +0000)]
CSS selector list splitting should be by component, not by selector.
<http://webkit.org/b/118761>
<rdar://problem/
14421609>
Reviewed by Antti Koivisto.
Source/WebCore:
Test (amended): fast/css/rule-selector-overflow.html
* css/CSSSelectorList.h:
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::componentCount):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
Renamed CSSSelectorList::length() to componentCount() and made it public.
* css/RuleSet.h:
maximumSelectorCount => maximumSelectorComponentCount
* css/StyleRule.cpp:
(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount):
Make the splits after accumulating 'maximumSelectorComponentCount' components.
* css/StyleRule.h:
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parserAppendRule):
splitIntoMultipleRulesWithMaximumSelectorCount => splitIntoMultipleRulesWithMaximumSelectorComponentCount
LayoutTests:
Added more cases to the already existing selector list splitting test.
* fast/css/rule-selector-overflow-expected.txt:
* fast/css/rule-selector-overflow.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 17:10:21 +0000 (17:10 +0000)]
YouTube webcam capture (Flash Plug-in) in Safari can't see built-in camera
https://bugs.webkit.org/show_bug.cgi?id=118787
<rdar://problem/
14418799>
Patch by Simon Cooper <scooper@apple.com> on 2013-07-17
Reviewed by Alexey Proskuryakov.
Add support for built-in cameras, including the original iSight.
* Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
* Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Wed, 17 Jul 2013 16:44:43 +0000 (16:44 +0000)]
AX: VoiceOver not working with data detection page overlays
https://bugs.webkit.org/show_bug.cgi?id=118680
Reviewed by Tim Horton.
Expose API methods so that a client implementing data detectors is able to respond
to the needs of accessibility clients like VoiceOver.
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(PageOverlayClientImpl::supportsDataDetection):
(PageOverlayClientImpl::dataDetectorExistsAtPoint):
(PageOverlayClientImpl::dataDetectorCopyTypeAtPoint):
(PageOverlayClientImpl::showDataDetectorMenuAtPoint):
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::supportsDataDetection):
(WebKit::PageOverlay::dataDetectorExistsAtPoint):
(WebKit::PageOverlay::dataDetectorCopyTypeAtPoint):
(WebKit::PageOverlay::dataDetectorOpenMenuAtPoint):
* WebProcess/WebPage/PageOverlay.h:
(WebKit::PageOverlay::Client::supportsDataDetection):
(WebKit::PageOverlay::Client::dataDetectorExistsAtPoint):
(WebKit::PageOverlay::Client::dataDetectorCopyTypeAtPoint):
(WebKit::PageOverlay::Client::showDataDetectorMenuAtPoint):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::pageOverlayOpenDataDetectorMenuAtPoint):
(WebKit::WebPage::pageOverlayDataDetectorCopyTypeAtPoint):
(WebKit::WebPage::pageOverlayDataDetectorExistsAtPoint):
(WebKit::WebPage::pageOverlaySupportsDataDetection):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]):
(-[WKAccessibilityWebPageObject _convertScreenPointToWindow:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Wed, 17 Jul 2013 16:40:11 +0000 (16:40 +0000)]
[Mac] REGRESSION(r152685): svg/custom/xlink-prefix-in-attributes.html failed unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=118701
Reviewed by Ryosuke Niwa.
Source/WebCore:
Use the computed attribute prefix, otherwise href being in xlink namespace but not having any prefix
will cause outputting the xlink namespace in appendNamespace.
Patch fixes svg/custom/xlink-prefix-in-attributes.html.
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendAttribute):
LayoutTests:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 16:26:52 +0000 (16:26 +0000)]
Naming convention on createInvalidParamError is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=118756
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-07-17
Reviewed by Geoffrey Garen.
Changed the naming of createInvalidParamError to createInvalidParameterError.
This corrects the naming convention for the function listed in the WebKit code styling.
* interpreter/Interpreter.cpp:
(JSC::loadVarargs):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::opIn):
* runtime/ExceptionHelpers.cpp:
(JSC::createInvalidParameterError):
* runtime/ExceptionHelpers.h:
* runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Wed, 17 Jul 2013 16:15:35 +0000 (16:15 +0000)]
Regression: columnheader/rowheader roles not exposed correctly
https://bugs.webkit.org/show_bug.cgi?id=113628
Reviewed by Tim Horton.
Source/WebCore:
When we determine the row and column headers we look at the ARIA role being returned, but
since TableCell overrides the determineAccessibilityRole method, the ARIA role is never set.
Test: platform/mac/accessibility/aria-columnrowheaders.html
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::determineAccessibilityRole):
LayoutTests:
* platform/mac/accessibility/aria-columnrowheaders-expected.txt: Added.
* platform/mac/accessibility/aria-columnrowheaders.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 15:34:44 +0000 (15:34 +0000)]
[GTK] Make DRT obbey testRunner's addURLToRedirect
https://bugs.webkit.org/show_bug.cgi?id=118239
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-17
Reviewed by Gustavo Noronha Silva.
Tools:
Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
to the proper URI when indicated.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(willSendRequestCallback):
LayoutTests:
Unskip http/tests/loading/cross-origin-XHR-willLoadRequest.html now that DRT obbeys
testRunner's addURLToRedirect.
* platform/gtk/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zarvai@inf.u-szeged.hu [Wed, 17 Jul 2013 13:54:36 +0000 (13:54 +0000)]
[Qt] Unreviewd gardening. Rebase and skip failing tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-17
* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/fast/replaced/border-radius-clip-expected.png: Added.
* platform/qt-5.0-wk2/fast/replaced/border-radius-clip-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ch.dumez@sisa.samsung.com [Wed, 17 Jul 2013 10:27:51 +0000 (10:27 +0000)]
Get rid of SVGPoint special case from the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=118783
Reviewed by Kentaro Hara.
Get rid of SVGPoint special case from the bindings generator by adding a
new SVGPoint.h header that contains a typedef to FloatPoint.
Also use SVGPoint type in the implementation API for consistency with
the IDL.
No new tests, no behavior change.
* bindings/scripts/CodeGenerator.pm:
(SkipIncludeHeader):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjMutablePoint):
(WebCore::jsTestObjImmutablePoint):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::jsTestObjPrototypeFunctionMutablePointFunction):
(WebCore::jsTestObjPrototypeFunctionImmutablePointFunction):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsPrototypeFunctionImmutablePointFunction):
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj mutablePoint]):
(-[DOMTestObj immutablePoint]):
(-[DOMTestObj mutablePointFunction]):
(-[DOMTestObj immutablePointFunction]):
* bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
(-[DOMTestTypedefs immutablePointFunction]):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::startPositionOfCharacter):
(WebCore::SVGTextQuery::endPositionOfCharacter):
(WebCore::SVGTextQuery::characterNumberAtPosition):
* rendering/svg/SVGTextQuery.h:
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::getPointAtLength):
* svg/SVGPathElement.h:
* svg/SVGPathTraversalStateBuilder.cpp:
(WebCore::SVGPathTraversalStateBuilder::currentPoint):
* svg/SVGPathTraversalStateBuilder.h:
* svg/SVGPathUtilities.cpp:
(WebCore::getPointAtLengthOfSVGPathByteStream):
* svg/SVGPathUtilities.h:
* svg/SVGPoint.h: Added.
* svg/SVGPointList.cpp:
(WebCore::SVGPointList::valueAsString):
* svg/SVGPointList.h:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::createSVGPoint):
* svg/SVGSVGElement.h:
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::getStartPositionOfChar):
(WebCore::SVGTextContentElement::getEndPositionOfChar):
(WebCore::SVGTextContentElement::getCharNumAtPosition):
* svg/SVGTextContentElement.h:
* svg/SVGZoomEvent.cpp:
(WebCore::SVGZoomEvent::previousTranslate):
(WebCore::SVGZoomEvent::newTranslate):
* svg/SVGZoomEvent.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 17 Jul 2013 10:11:20 +0000 (10:11 +0000)]
Add a new find-resolved-bugs command to webkit-patch.
https://bugs.webkit.org/show_bug.cgi?id=118060
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-17
Reviewed by Csaba Osztrogonác.
* Scripts/webkitpy/tool/commands/queries.py:
(PrintBaselines._platform_for_path):
(FindResolvedBugs):
(FindResolvedBugs.execute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 17 Jul 2013 09:39:21 +0000 (09:39 +0000)]
[GStreamer] webkitwebsrc: use SubResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=73743
Reviewed by Philippe Normand.
* GNUmakefile.list.am: Add new files to compilation.
* PlatformEfl.cmake: Ditto.
* PlatformGTK.cmake: Ditto.
* loader/SubresourceLoader.h: Add getOrCreateReadBuffer() when
using SOUP.
* loader/cache/CachedRawResource.h:
* loader/cache/CachedRawResourceClient.h:
(WebCore::CachedRawResourceClient::getOrCreateReadBuffer): Added
to allow the client to allocate the read buffer.
* loader/cache/CachedResource.h:
(WebCore::CachedResource::getOrCreateReadBuffer):
* loader/soup/CachedRawResourceSoup.cpp: Added.
(WebCore::CachedRawResource::getOrCreateReadBuffer): Iterate the
clients until one returns a valid read buffer or return NULL to
fallback to the default read buffer.
* loader/soup/SubresourceLoaderSoup.cpp: Added.
(WebCore::SubresourceLoader::getOrCreateReadBuffer): Call
CachedResource::getOrCreateReadBuffer().
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient): Make this a CachedRawResourceClient.
(_WebKitWebSrcPrivate): Remove frame and resourceHandle and add a
cached resource handle.
(webKitWebSrcDispose): Clear the player pointer.
(webKitWebSrcStop): Remove the client from the cached resource.
(webKitWebSrcStart): Use CachedResourceLoader to schedule a
CachedRawResource load for the media without buffering the data.
(webKitWebSrcNeedDataMainCb): Call CachedResource::setDefersLoading.
(webKitWebSrcEnoughDataMainCb): Ditto.
(webKitWebSrcSetMediaPlayer): Simply update the player pointer.
(StreamingClient::responseReceived): Update to the
CachedRawResourceClient API.
(StreamingClient::dataReceived): Ditto.
(StreamingClient::getOrCreateReadBuffer): Ditto.
(StreamingClient::notifyFinished): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 09:16:53 +0000 (09:16 +0000)]
Replace MathML pixel tests by reftests.
https://bugs.webkit.org/show_bug.cgi?id=118599
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-07-17
Reviewed by Chris Fleizach.
- attributes.xhtml is replaced by attributes*.html
- underover.xhtml, under.xhtml, sub.xhtml, sup.xhtml, over.xhtml and subsup.xhtml are replaced by scripts*.html and bug*.html.
- tokenElements.xhtml is replaced by replaced tokenElements-mathvariant.html
* mathml/presentation/attributes-background-color-expected.html: Added.
* mathml/presentation/attributes-background-color.html: Added.
* mathml/presentation/attributes-display-expected.html: Added.
* mathml/presentation/attributes-display.html: Added.
* mathml/presentation/attributes-mathsize-expected.html: Added.
* mathml/presentation/attributes-mathsize.html: Added.
* mathml/presentation/attributes-mathvariant-expected.html: Added.
* mathml/presentation/attributes-mathvariant.html: Added.
* mathml/presentation/attributes-style-expected-mismatch.html: Added.
* mathml/presentation/attributes-style.html: Added.
* mathml/presentation/attributes.xhtml: Removed.
* mathml/presentation/bug95015-expected.html: Added.
* mathml/presentation/bug95015.html: Added.
* mathml/presentation/bug95404-expected.html: Added.
* mathml/presentation/bug95404.html: Added.
* mathml/presentation/bug97990-expected.html: Added.
* mathml/presentation/bug97990.html: Added.
* mathml/presentation/over.xhtml: Removed.
* mathml/presentation/scripts-font-size-expected-mismatch.html: Added.
* mathml/presentation/scripts-font-size.html: Added.
* mathml/presentation/scripts-height-expected.html: Added.
* mathml/presentation/scripts-height.html: Added.
* mathml/presentation/scripts-mrow-expected.html: Added.
* mathml/presentation/scripts-mrow.html: Added.
* mathml/presentation/scripts-subsup-expected.html: Added.
* mathml/presentation/scripts-subsup.html: Added.
* mathml/presentation/scripts-underover-expected.html: Added.
* mathml/presentation/scripts-underover.html: Added.
* mathml/presentation/scripts-width-expected.html: Added.
* mathml/presentation/scripts-width.html: Added.
* mathml/presentation/sub.xhtml: Removed.
* mathml/presentation/subsup.xhtml: Removed.
* mathml/presentation/sup.xhtml: Removed.
* mathml/presentation/tokenElements-mathvariant-expected.html: Added.
* mathml/presentation/tokenElements-mathvariant.html: Added.
* mathml/presentation/tokenElements.xhtml: Removed.
* mathml/presentation/under.xhtml: Removed.
* mathml/presentation/underover.xhtml: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 08:47:54 +0000 (08:47 +0000)]
[EFL][WK2] EWK2CookieManagerTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118721
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(compareHostNames):
(onCookiesChanged):
(EWK2CookieManagerTest::getAcceptPolicy):
(EWK2CookieManagerTest::getHostnamesWithCookies):
(EWK2CookieManagerTest::freeHostNames):
(EWK2CookieManagerTest::countHostnamesWithCookies):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kseo@webkit.org [Wed, 17 Jul 2013 08:40:12 +0000 (08:40 +0000)]
Remove unused member variable m_domURL from WorkerGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=118784
Reviewed by Christophe Dumez.
WorkerContext::webkitURL() was removed in r107082, and this was the
only place where the member variable |m_domURL| in WorkerContext was
mutated. This variable is no longer needed and so it should be removed.
No behavior change.
* workers/WorkerGlobalScope.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Wed, 17 Jul 2013 08:37:03 +0000 (08:37 +0000)]
[CMake] Undefined references should be detected at build time
https://bugs.webkit.org/show_bug.cgi?id=110236
Patch by Balazs Kelemen <kbalazs@webkit.org> on 2013-07-16
Reviewed by Christophe Dumez.
.:
Pass the --no-undefined argument to the linker on platforms where it is available.
* Source/cmake/OptionsCommon.cmake:
Source/WebKit:
Add library dependencies that were not defined explicitly before.
* CMakeLists.txt:
* PlatformEfl.cmake:
Source/WebKit2:
Add library dependencies that were not defined explicitly before.
* CMakeLists.txt:
* PlatformEfl.cmake:
Tools:
Add library dependencies that were not defined explicitly before.
* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
* TestWebKitAPI/CMakeLists.txt:
* WebKitTestRunner/CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:27:41 +0000 (07:27 +0000)]
[EFL][WK2] EWK2WindowFeaturesTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118780
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_window_features.cpp:
(EWK2WindowFeaturesTest::createDefaultWindow):
(EWK2WindowFeaturesTest::createWindow):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Wed, 17 Jul 2013 07:26:27 +0000 (07:26 +0000)]
[CSS Shapes] Remove setCSSShapesEnabled(true) from shape-inside-on-first-region-inline-content-expected.html since it's no longer using shapes
https://bugs.webkit.org/show_bug.cgi?id=117952
Reviewed by Alexandru Chiculita.
* fast/regions/shape-inside/shape-inside-on-first-region-inline-content-expected.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:25:04 +0000 (07:25 +0000)]
[EFL][WK2] EWK2ViewTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118779
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(EWK2ViewTest::onLoadFinishedForRedirection):
(EWK2ViewTest::serverCallbackNavigation):
(EWK2ViewTest::onFormAboutToBeSubmitted):
(EWK2ViewTest::fullScreenCallback):
(EWK2ViewTest::fullScreenExitCallback):
(EWK2ViewTest::checkAlert):
(EWK2ViewTest::checkConfirm):
(EWK2ViewTest::checkPrompt):
(EWK2ViewTest::onTextFound):
(EWK2ViewTest::onVibrate):
(EWK2ViewTest::onCancelVibration):
(EWK2ViewTest::loadVibrationHTMLString):
(EWK2ViewTest::onContentsSizeChangedPortrait):
(EWK2ViewTest::onContentsSizeChangedLandscape):
(EWK2ViewTest::PageContentsAsMHTMLCallback):
(EWK2ViewTest::PageContentsAsStringCallback):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:23:25 +0000 (07:23 +0000)]
[EFL][WK2] EWK2StorageManagerTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118777
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
(EWK2StorageManagerTest::OriginData::OriginData):
(EWK2StorageManagerTest::getStorageOriginsCallback):
(EWK2StorageManagerTest::timerCallback):
(EWK2StorageManagerTest::checkOrigin):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:22:43 +0000 (07:22 +0000)]
[EFL][WK2] EWK2PopupMenuTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118775
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp:
(EWK2PopupMenuTest::checkBasicPopupMenuItem):
(EWK2PopupMenuTest::selectItemAfterDelayed):
(EWK2PopupMenuTest::showPopupMenu):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:20:34 +0000 (07:20 +0000)]
ASSERTION FAILED: layoutState->m_renderer == this in WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage
https://bugs.webkit.org/show_bug.cgi?id=118587
Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-07-17
Reviewed by David Hyatt.
Source/WebCore:
The fix consists in not calling containingBlockLogicalHeightForPositioned for flow threads (in
RenderBox::availableLogicalHeightUsing) as it gets to handle the RenderView as it would have been flowed into
the flow thread.
Test: fast/regions/crash-div-outside-body-vertical-rl.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::availableLogicalHeightUsing):
LayoutTests:
* fast/regions/crash-div-outside-body-vertical-rl-expected.html: Added.
* fast/regions/crash-div-outside-body-vertical-rl.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:19:15 +0000 (07:19 +0000)]
[EFL][WK2] EWK2FileChooserRequestTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118773
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
(EWK2FileChooserRequestTest::onFileChooserRequest):
(EWK2FileChooserRequestTest::compareStrings):
(EWK2FileChooserRequestTest::freeStringList):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:18:31 +0000 (07:18 +0000)]
[EFL][WK2] EWK2FaviconDatabaseTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118772
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
(EWK2FaviconDatabaseTest::serverCallback):
(EWK2FaviconDatabaseTest::requestFaviconData):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:16:42 +0000 (07:16 +0000)]
[EFL][WK2] EWK2EinaSharedStringTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118771
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:
(EWK2EinaSharedStringTest::checkString):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:15:09 +0000 (07:15 +0000)]
[EFL][WK2] EWK2DownloadJobTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118769
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
(EWK2DownloadJobTest::fileExists):
(EWK2DownloadJobTest::serverCallback):
(EWK2DownloadJobTest::on_download_requested):
(EWK2DownloadJobTest::on_download_cancelled):
(EWK2DownloadJobTest::on_download_failed):
(EWK2DownloadJobTest::on_download_finished):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kangil.han@samsung.com [Wed, 17 Jul 2013 07:12:11 +0000 (07:12 +0000)]
Use toHTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=118727
Reviewed by Ryosuke Niwa.
To avoid direct use of static_cast, this patch uses toHTMLMediaElement for code cleanup.
Source/WebCore:
* bindings/js/JSHTMLMediaElementCustom.cpp:
(WebCore::JSHTMLMediaElement::setController):
* html/HTMLMediaElement.h:
(WebCore::toHTMLMediaElement):
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::insertedInto):
(WebCore::HTMLSourceElement::removedFrom):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::removedFrom):
(WebCore::HTMLTrackElement::mediaElement):
* html/shadow/MediaControlElementTypes.cpp:
(WebCore::toParentMediaElement):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
* page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
(WebCore::RenderThemeEfl::paintMediaMuteButton):
(WebCore::RenderThemeEfl::paintMediaToggleClosedCaptionsButton):
* platform/graphics/wince/MediaPlayerProxy.cpp:
(WebCore::WebMediaPlayerProxy::initEngine):
(WebCore::WebMediaPlayerProxy::element):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::getMediaElementFromRenderObject):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::mediaElement):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::mediaElement):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaSliderTrack):
* rendering/RenderThemeWinCE.cpp:
(WebCore::mediaElementParent):
* testing/Internals.cpp:
(WebCore::Internals::simulateAudioInterruption):
Source/WebKit/blackberry:
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
(BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):
Source/WebKit/gtk:
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::enterFullscreenForNode):
(WebKit::ChromeClient::exitFullscreenForNode):
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):
Source/WebKit/mac:
* WebView/WebView.mm:
(-[WebView _enterFullscreenForNode:WebCore::]):
Source/WebKit/win:
* WebView.cpp:
(WebView::enterFullscreenForNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:11:19 +0000 (07:11 +0000)]
[EFL][WK2] EWK2AuthRequestTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118766
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
(EWK2AuthRequestTest::serverCallback):
(EWK2AuthRequestTest::onAuthenticationRequest):
(EWK2AuthRequestTest::onLoadFinished):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:09:51 +0000 (07:09 +0000)]
[EFL][WK2] EWK2ContextMenuTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118767
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
(EWK2ContextMenuTest::checkBasicContextMenuItem):
(EWK2ContextMenuTest::customItemSelected):
(EWK2ContextMenuTest::showContextMenu):
(EWK2ContextMenuTest::showContextMenuForRemoveAndAppend):
(EWK2ContextMenuTest::showContextMenuForSubmenu):
(EWK2ContextMenuTest::hideContextMenu):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:06:18 +0000 (07:06 +0000)]
[EFL][WK2] EWK2ContextTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118763
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(EWK2ContextTest::schemeRequestCallback):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:05:40 +0000 (07:05 +0000)]
[EFL][WK2] EWK2DatabaseManagerTest should be defined by inheriting from EWK2UnitTestBase
https://bugs.webkit.org/show_bug.cgi?id=118726
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
(EWK2DatabaseManagerTest::OriginData::OriginData):
(EWK2DatabaseManagerTest::databaseOriginsCallback):
(EWK2DatabaseManagerTest::timerCallback):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 07:03:48 +0000 (07:03 +0000)]
[EFL][WK2] EWK2ColorPickerTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118762
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.
It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.
* UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
(EWK2ColorPickerTest::onColorPickerDone):
(EWK2ColorPickerTest::setColorPickerColor):
(EWK2ColorPickerTest::showColorPicker):
(EWK2ColorPickerTest::hideColorPicker):
(EWK2ColorPickerTest::hideColorPickerByRemovingElement):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Wed, 17 Jul 2013 06:43:07 +0000 (06:43 +0000)]
Remove Platform(EFL) guard from Widget::frameRectsChanged
https://bugs.webkit.org/show_bug.cgi?id=118782
Reviewed by Christophe Dumez.
Since r58487, Widget::frameRectsChanged was moved to cpp and guarded.
But we can move back to header because WebKit/Efl refactored related code in r145710.
No new tests, refactoring.
* platform/Widget.cpp: Removed platform guard and move frameRectsChangd() back to header.
* platform/Widget.h:
(WebCore::Widget::frameRectsChanged):
* platform/efl/WidgetEfl.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 06:04:04 +0000 (06:04 +0000)]
setPluginUnavailabilityReason can destroy renderObject before obscurity check
https://bugs.webkit.org/show_bug.cgi?id=118770
<rdar://problem/
14462331>
Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2013-07-16
Reviewed by Tim Horton.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Moved obscurity check to before renderObject is potentially destroyed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achristensen@apple.com [Wed, 17 Jul 2013 05:34:17 +0000 (05:34 +0000)]
Source/ThirdParty/ANGLE: Update ANGLE from r1987 to r2426 while keeping these changes:
Keeping #if defined(_MSC_VER) around #pragma warning(disable: 4718) in DependencyGraph.cpp.
Keeping include khrplatform.h instead of KHR/khrplatform.h in ShaderLang.h.
Added static_casts in Intermediate.cpp to fix compiling on Mac.
Changed enum bit fields to just enums for GCC in Types.h to fix compiling for GTK.
Ran Bison on Mac after removing the unsupported %code tag (See diff uploaded to bug for details).
Added YYLTYPE definition to glslang_tab.h which would have been put there by the unsupported %code tag.
https://bugs.webkit.org/show_bug.cgi?id=118550
Reviewed by Dean Jackson.
* ANGLE.plist: Updated revision of ANGLE to 2426.
* ANGLE.xcodeproj/project.pbxproj:
* GNUmakefile.am:
* Target.pri:
Renamed DetectRecursion to DetectCallDepth and added builtin_symbol_table.
* include/GLSLANG/ShaderLang.h:
* src/common/version.h:
* src/compiler/BaseTypes.h:
(getQualifierString):
* src/compiler/Common.h:
* src/compiler/Compiler.cpp:
(TCompiler::TCompiler):
(TCompiler::Init):
(TCompiler::compile):
(TCompiler::detectCallDepth):
(TCompiler::enforceTimingRestrictions):
(TCompiler::limitExpressionComplexity):
* src/compiler/ConstantUnion.h:
(ConstantUnion::ConstantUnion):
* src/compiler/DetectCallDepth.cpp: Added.
(DetectCallDepth::FunctionNode::FunctionNode):
(DetectCallDepth::FunctionNode::getName):
(DetectCallDepth::FunctionNode::addCallee):
(DetectCallDepth::FunctionNode::detectCallDepth):
(DetectCallDepth::FunctionNode::reset):
(DetectCallDepth::DetectCallDepth):
(DetectCallDepth::~DetectCallDepth):
(DetectCallDepth::visitAggregate):
(DetectCallDepth::checkExceedsMaxDepth):
(DetectCallDepth::resetFunctionNodes):
(DetectCallDepth::detectCallDepthForFunction):
(DetectCallDepth::detectCallDepth):
(DetectCallDepth::findFunctionByName):
* src/compiler/DetectCallDepth.h: Added.
(DetectCallDepth::getInfoSink):
* src/compiler/DetectRecursion.cpp: Removed.
* src/compiler/DetectRecursion.h: Removed.
* src/compiler/Diagnostics.cpp:
(TDiagnostics::writeInfo):
* src/compiler/ForLoopUnroll.cpp:
(ForLoopUnroll::evaluateIntConstant):
* src/compiler/InfoSink.cpp:
(TInfoSinkBase::prefix):
(TInfoSinkBase::location):
(TInfoSinkBase::message):
* src/compiler/InfoSink.h:
* src/compiler/Initialize.cpp:
(TBuiltIns::initialize):
(IdentifyBuiltIns):
(InitExtensionBehavior):
* src/compiler/Intermediate.cpp: Updated and added static_casts to fix build errors on Mac.
(TIntermediate::addSymbol):
(TIntermediate::addBinaryMath):
(TIntermediate::addAssign):
(TIntermediate::addIndex):
(TIntermediate::addUnaryMath):
(TIntermediate::setAggregateOperator):
(TIntermediate::addConversion):
(TIntermediate::growAggregate):
(TIntermediate::makeAggregate):
(TIntermediate::addSelection):
(TIntermediate::addComma):
(TIntermediate::addConstantUnion):
(TIntermediate::addSwizzle):
(TIntermediate::addLoop):
(TIntermediate::addBranch):
(TIntermUnary::promote):
(TIntermBinary::promote):
(CompareStruct):
(CompareStructure):
(TIntermConstantUnion::fold):
(TIntermediate::promoteConstantUnion):
* src/compiler/OutputGLSL.cpp:
(TOutputGLSL::visitSymbol):
* src/compiler/OutputGLSL.h:
* src/compiler/OutputGLSLBase.cpp:
(TOutputGLSLBase::writeVariableType):
(TOutputGLSLBase::writeConstantUnion):
(TOutputGLSLBase::visitBinary):
(TOutputGLSLBase::visitAggregate):
(TOutputGLSLBase::getTypeName):
(TOutputGLSLBase::hashFunctionName):
(TOutputGLSLBase::structDeclared):
(TOutputGLSLBase::declareStruct):
* src/compiler/OutputGLSLBase.h:
* src/compiler/OutputHLSL.cpp:
(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitSymbol):
(sh::OutputHLSL::visitBinary):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::typeString):
(sh::OutputHLSL::initializer):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::writeConstantUnion):
(sh::OutputHLSL::decorateField):
* src/compiler/OutputHLSL.h:
* src/compiler/ParseHelper.cpp:
(TParseContext::parseVectorFields):
(TParseContext::parseMatrixFields):
(TParseContext::error):
(TParseContext::warning):
(TParseContext::assignError):
(TParseContext::unaryOpError):
(TParseContext::binaryOpError):
(TParseContext::precisionErrorCheck):
(TParseContext::lValueErrorCheck):
(TParseContext::globalErrorCheck):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::voidErrorCheck):
(TParseContext::boolErrorCheck):
(TParseContext::samplerErrorCheck):
(TParseContext::structQualifierErrorCheck):
(TParseContext::parameterSamplerErrorCheck):
(TParseContext::containsSampler):
(TParseContext::arraySizeErrorCheck):
(TParseContext::arrayQualifierErrorCheck):
(TParseContext::arrayTypeErrorCheck):
(TParseContext::arrayErrorCheck):
(TParseContext::nonInitConstErrorCheck):
(TParseContext::nonInitErrorCheck):
(TParseContext::paramErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::findFunction):
(TParseContext::isVariableBuiltIn):
(TParseContext::executeInitializer):
(TParseContext::addConstructor):
(TParseContext::constructBuiltIn):
(TParseContext::constructStruct):
(TParseContext::addConstVectorNode):
(TParseContext::addConstMatrixNode):
(TParseContext::addConstArrayNode):
(TParseContext::addConstStruct):
(TParseContext::enterStructDeclaration):
(TParseContext::structNestingErrorCheck):
* src/compiler/ParseHelper.h:
(TParseContext::TParseContext):
(TParseContext::pragma):
* src/compiler/PoolAlloc.cpp:
(TPoolAllocator::allocate):
* src/compiler/ShHandle.h:
* src/compiler/ShaderLang.cpp:
(ShInitBuiltInResources):
* src/compiler/SymbolTable.cpp:
(TType::TType):
(TType::buildMangledName):
(TType::getObjectSize):
(TStructure::containsArrays):
(TStructure::buildMangledName):
(TStructure::calculateObjectSize):
(TStructure::calculateDeepestNesting):
(TSymbolTableLevel::relateToExtension):
* src/compiler/SymbolTable.h:
(TSymbol::relateToExtension):
(TSymbol::getExtension):
(TVariable::TVariable):
(TVariable::setQualifier):
(TVariable::shareConstPointer):
* src/compiler/Types.h: Updated and changed enum bit fields to enums to fix compiling with GCC.
(TField::TField):
(TField::type):
(TField::name):
(NewPoolTFieldList):
(TStructure::TStructure):
(TStructure::name):
(TStructure::fields):
(TStructure::mangledName):
(TStructure::objectSize):
(TStructure::deepestNesting):
(TType::TType):
(TType::clearArrayness):
(TType::getStruct):
(TType::setStruct):
(TType::getMangledName):
(TType::getDeepestStructNesting):
(TType::isStructureContainingArrays):
(TPublicType::setBasic):
* src/compiler/VariableInfo.cpp:
(getUserDefinedVariableInfo):
* src/compiler/builtin_symbol_table.cpp: Added.
(builtin1):
(builtin2):
(builtin3):
(InsertBuiltInFunctionsCommon):
(InsertBuiltInFunctionsVertex):
* src/compiler/builtin_symbol_table.h: Added.
* src/compiler/glslang.l:
* src/compiler/glslang.y:
* src/compiler/glslang_lex.cpp:
(yy_get_previous_state):
(yy_try_NUL_trans):
(yyget_lloc):
(yyset_lloc):
(string_input):
(check_type):
(reserved_word):
(glslang_scan):
* src/compiler/glslang_tab.cpp:
(yysyntax_error):
(yyerror):
(glslang_parse):
* src/compiler/glslang_tab.h: Readded YYLTYPE definition after Bison removed it.
* src/compiler/intermOut.cpp:
(TOutputTraverser::visitUnary):
(TOutputTraverser::visitAggregate):
(TOutputTraverser::visitConstantUnion):
* src/compiler/intermediate.h:
(TIntermNode::TIntermNode):
(TIntermNode::~TIntermNode):
(TIntermNode::getLine):
(TIntermNode::setLine):
(TIntermNode::getAsLoopNode):
(TIntermConstantUnion::getIConst):
(TIntermConstantUnion::getFConst):
(TIntermConstantUnion::getBConst):
(TIntermAggregate::TIntermAggregate):
(TIntermTraverser::TIntermTraverser):
(TIntermTraverser::getMaxDepth):
(TIntermTraverser::incrementDepth):
* src/compiler/localintermediate.h:
* src/compiler/parseConst.cpp:
(TConstTraverser::visitSymbol):
(TConstTraverser::visitBinary):
(TConstTraverser::visitUnary):
(TConstTraverser::visitAggregate):
(TConstTraverser::visitSelection):
(TConstTraverser::visitConstantUnion):
(TConstTraverser::visitLoop):
(TConstTraverser::visitBranch):
(TIntermediate::parseConstTree):
* src/compiler/preprocessor/ExpressionParser.cpp:
* src/compiler/timing/RestrictVertexShaderTiming.cpp:
(RestrictVertexShaderTiming::visitSymbol):
Updated ANGLE to r2426 and ran Bison.
Source/WebCore: Update ANGLE to r2426.
https://bugs.webkit.org/show_bug.cgi?id=118550
Reviewed by Dean Jackson.
* CMakeLists.txt: Renamed DetectRecursion to DetectCallDepth and added builtin_symbol_table.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Wed, 17 Jul 2013 02:04:00 +0000 (02:04 +0000)]
Many crashes loading Java applets after r152701
https://bugs.webkit.org/show_bug.cgi?id=118760
<rdar://problem/
14462836>
Reviewed by Dean Jackson.
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::updateWidget):
Re-acquire the renderer after calling createJavaAppletWidget,
because it can cause reattach, leaving our renderer pointer stale.
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
Null-check renderer, as element->renderEmbeddedObject() can very clearly
return null in some cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 00:50:16 +0000 (00:50 +0000)]
AX: Add a 'choose product' link for the new-ax-bug alias.
https://bugs.webkit.org/show_bug.cgi?id=118697
Patch by James Craig <james@cookiecrook.com> on 2013-07-16
Reviewed by Chris Fleizach.
* template/en/custom/global/choose-product.html.tmpl: Added new link for accessibility bugs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
psolanki@apple.com [Wed, 17 Jul 2013 00:33:03 +0000 (00:33 +0000)]
Missing break in WebGLRenderingContext::validateCompressedTexFuncData()
https://bugs.webkit.org/show_bug.cgi?id=118742
Reviewed by Ryosuke Niwa.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Jul 2013 00:32:14 +0000 (00:32 +0000)]
Web Inspector: InspectorFrontendHost is undefined
https://bugs.webkit.org/show_bug.cgi?id=118715
Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-07-16
Reviewed by Timothy Hatcher.
Add InspectorFrontendHostStub.js to New Inspector because of the InspectorFrontendHost initialization.
* UserInterface/InspectorFrontendHostStub.js: Added.
(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.platform):
(.WebInspector.InspectorFrontendHostStub.prototype.port):
(.WebInspector.InspectorFrontendHostStub.prototype.bringToFront):
(.WebInspector.InspectorFrontendHostStub.prototype.closeWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):
(.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight):
(.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowWidth):
(.WebInspector.InspectorFrontendHostStub.prototype.setToolbarHeight):
(.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy):
(.WebInspector.InspectorFrontendHostStub.prototype.loaded):
(.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL):
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
(.WebInspector.InspectorFrontendHostStub.prototype.copyText):
(.WebInspector.InspectorFrontendHostStub.prototype.openInNewTab):
(.WebInspector.InspectorFrontendHostStub.prototype.canSave):
(.WebInspector.InspectorFrontendHostStub.prototype.save):
(.WebInspector.InspectorFrontendHostStub.prototype.append):
(.WebInspector.InspectorFrontendHostStub.prototype.close.cleanup):
(.WebInspector.InspectorFrontendHostStub.prototype.close):
(.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend):
(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
* UserInterface/Main.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kseo@webkit.org [Wed, 17 Jul 2013 00:12:22 +0000 (00:12 +0000)]
check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
https://bugs.webkit.org/show_bug.cgi?id=118755
Reviewed by Ryosuke Niwa.
Fix r152719 to check "using namespace foo;" only in headers.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_using_namespace):
(check_style):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_using_namespace):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dfarler@apple.com [Tue, 16 Jul 2013 23:24:33 +0000 (23:24 +0000)]
Typo in DFGInsertionSet.h header guard: "DFGInsectionSet_h" -> "DFGInsertionSet_h"
https://bugs.webkit.org/show_bug.cgi?id=118753
Reviewed by Geoffrey Garen.
* dfg/DFGInsertionSet.h:
"DFGInsectionSet_h" -> "DFGInsertionSet_h"
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achristensen@apple.com [Tue, 16 Jul 2013 22:57:11 +0000 (22:57 +0000)]
Added passing WebGL tests.
https://bugs.webkit.org/show_bug.cgi?id=118696
Reviewed by Dean Jackson.
* platform/mac/TestExpectations: Replaced webgl directory with list of failing webgl tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Tue, 16 Jul 2013 22:03:18 +0000 (22:03 +0000)]
Atomicize HTMLAnchorElement.hash before passing it to JS.
<http://webkit.org/b/118748>
<rdar://problem/
14459780>
Reviewed by Sam Weinig.
Instead of generating a unique string from '#' + the URL hash every time HTMLAnchorElement.hash
is queried, turn it into an AtomicString. This prevents massive memory usage in scripts that
fetch .hash a lot.
Reduces memory consumption by 4.65 MB when viewing the full HTML5 spec at <http://whatwg.org/c>
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::hash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 16 Jul 2013 21:41:06 +0000 (21:41 +0000)]
MakeRope fixup shouldn't lead to an Identity without kids
https://bugs.webkit.org/show_bug.cgi?id=118745
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Make the empty string pruning part of fixupMakeRope() stop if it's on the last child.
Make Node::convertToIdentity release-assert that it has exactly one kid.
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupMakeRope):
* dfg/DFGNode.h:
(JSC::DFG::Node::convertToIdentity):
LayoutTests:
Reviewed by Mark Hahnenberg.
* fast/js/dfg-make-rope-all-empty-strings.html: Added.
* fast/js/dfg-make-rope-all-empty-strings-expected.txt: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-make-rope-all-empty-strings.js: Added.
(foo):
(bar):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Jul 2013 21:34:12 +0000 (21:34 +0000)]
Make WebVTTParser return cue data instead of cue DOM objects
https://bugs.webkit.org/show_bug.cgi?id=118687
Patch by Brendan Long <b.long@cablelabs.com> on 2013-07-16
Reviewed by Eric Carlson.
No new tests because this doesn't change functionality.
* html/track/InbandTextTrack.cpp:
Make TextTrackCueMap handle WebVTTCues instead of just generic cues.
m_dataToCueMap and m_cueToDataMap were renamed m_genericDataToCueMap
and m_genericCueToDataMap. The cue maps were turned into pointers so we
only allocate the ones we need.
(WebCore::TextTrackCueMap::TextTrackCueMap): Initialize maps to 0.
(WebCore::TextTrackCueMap::~TextTrackCueMap): Delete allocated maps.
(WebCore::TextTrackCueMap::add): Changed to allocate cue maps as needed, and added WebVTT version.
(WebCore::TextTrackCueMap::find): Checked to check if cue maps are allocated, and added WebVTT version.
(WebCore::TextTrackCueMap::findGenericData): Changed to accept TextTrackCue instead of TextTrackCueGeneric.
(WebCore::TextTrackCueMap::findWebVTTData): Same as findGenericData, except for WebVTTCueData.
(WebCore::TextTrackCueMap::remove): Accept TextTrackCue instead of TextTrackCueGeneric, and look in both maps.
(WebCore::InbandTextTrack::addWebVTTCue): Added, based on addGenericCue.
(WebCore::InbandTextTrack::removeWebVTTCue): Added, almost identical to removeGenericCue.
(WebCore::InbandTextTrack::removeCue): m_cueMap.remove() takes a TextTrackCue now so it can remove both types of cue.
(WebCore::InbandTextTrack::willRemoveTextTrackPrivate): Use ASSERT_UNUSED instead of UNUSED_PARAM + ASSERT.
* html/track/InbandTextTrack.h: Add new functions above, change maps to pointers and add maps for holding WebVTT cues.
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::getNewCues): Return WebVTTCueData instead of TextTrackCue.
(WebCore::WebVTTParser::createNewCue): Create WebVTTCueData instead of TextTrackCue.
* html/track/WebVTTParser.h: Add WebVTTCueData class, based on GenericCueData.
The following functions are just constructors, destructors, getters, or setters.
(WebCore::WebVTTCueData::create):
(WebCore::WebVTTCueData::~WebVTTCueData):
(WebCore::WebVTTCueData::startTime):
(WebCore::WebVTTCueData::setStartTime):
(WebCore::WebVTTCueData::endTime):
(WebCore::WebVTTCueData::setEndTime):
(WebCore::WebVTTCueData::id):
(WebCore::WebVTTCueData::setId):
(WebCore::WebVTTCueData::content):
(WebCore::WebVTTCueData::setContent):
(WebCore::WebVTTCueData::settings):
(WebCore::WebVTTCueData::setSettings):
(WebCore::WebVTTCueData::WebVTTCueData):
* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::getNewCues): Convert WebVTTCueData to TextTrackCue when we get them.
* platform/graphics/InbandTextTrackPrivateClient.h: Add addWebVTTCue and removeWebVTTCue functions to the interface.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 16 Jul 2013 21:14:58 +0000 (21:14 +0000)]
REGRESSION (r150291): Chinese predictive input pop-up disappears on twitter.com
https://bugs.webkit.org/show_bug.cgi?id=118739
<rdar://problem/
14300350>
Reviewed by Daniel Bates.
EditorState tracking on UI side is very fragile. This is a targeted fix just for
this specific scenario.
The issue was that we had a stale m_temporarilyClosedComposition flag, which was
making UI process believe that a composition was closed from WebProcess side,
and notify input method about that. It shouldn't have been a problem, because there
is no composition at this point indeed, but this extra call is a problem for
predictive input, which works in a somewhat unconventional way (<rdar://problem/
14458297>).
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::insertText): Reset m_temporarilyClosedComposition flag when
getting new EditorState in response to performing this action. There is certainly
no composition after insertText, and all interested parties are on the same page
already.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Tue, 16 Jul 2013 21:02:59 +0000 (21:02 +0000)]
Use the correct cursor value for the unavailable plugin indicator
https://bugs.webkit.org/show_bug.cgi?id=118747
<rdar://problem/
14456498>
Reviewed by Dean Jackson.
CSS says "pointer" is the hand cursor, not "hand".
* css/unavailablePlugIns.css:
(object::-webkit-unavailable-plugin-content > div):
(object::-webkit-unavailable-plugin-content > div > span):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Tue, 16 Jul 2013 20:35:30 +0000 (20:35 +0000)]
Remove reference to JSValueStructSupport.h from JSExport.h
https://bugs.webkit.org/show_bug.cgi?id=118746
Reviewed by Filip Pizlo.
* API/JSExport.h: No such header exists, so it doesn't make sense to reference it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Tue, 16 Jul 2013 20:32:13 +0000 (20:32 +0000)]
Unreviewed rebaseline test added in r152612 for Apple Windows port.
* platform/win/editing/caret: Added.
* platform/win/editing/caret/caret-color-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Tue, 16 Jul 2013 19:38:09 +0000 (19:38 +0000)]
Unreviewed rebaselines, AppleWin port.
* platform/win/fast/js/global-constructors-attributes-dedicated-worker-expected.txt:
* platform/win/fast/js/global-constructors-attributes-shared-worker-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Tue, 16 Jul 2013 18:51:20 +0000 (18:51 +0000)]
Unreviewed. Adjust test and update results for AppleWin port after r151868.
* platform/win/accessibility/multiple-select-element-role-expected.txt:
* platform/win/accessibility/multiple-select-element-role.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 16 Jul 2013 18:44:45 +0000 (18:44 +0000)]
Source/WebCore: Protect against the LayerFlushController being deleted inside its flushLayers() callback
https://bugs.webkit.org/show_bug.cgi?id=118741
Reviewed by Tim Horton.
It's possible (especially on iOS) for the LayerFlushController to be destroyed
inside its callback, via -[WebView _close]. Protect against this by making
it refcounted, and holding a ref across the callback.
Due to the odd relationship in which LayerFlushController owns its LayerFlushScheduler
by value, we achieve this by allowing subclasses of LayerFlushScheduler
to override runLoopObserverCallback(). WebViewLayerFlushScheduler uses the
override to protect the owner of the LayerFlushScheduler, which is the
LayerFlushController, when the callback is firing.
* WebCore.exp.in:
* platform/graphics/ca/LayerFlushScheduler.h: Make runLoopObserverCallback() and the dtor virtual.
Source/WebKit/mac: Protect against the LayerFlushController being deleted inside its flushLayers() callback
https://bugs.webkit.org/show_bug.cgi?id=118741
<rdar://problem/
14402651>
Reviewed by Tim Horton.
It's possible (especially on iOS) for the LayerFlushController to be destroyed
inside its callback, via -[WebView _close]. Protect against this by making
it refcounted, and holding a ref across the callback.
Due to the odd relationship in which LayerFlushController owns its LayerFlushScheduler
by value, we achieve this by allowing subclasses of LayerFlushScheduler
to override runLoopObserverCallback(). WebViewLayerFlushScheduler uses the
override to protect the owner of the LayerFlushScheduler, which is the
LayerFlushController, when the callback is firing.
* WebView/WebView.mm:
(-[WebView _close]):
* WebView/WebViewData.h:
(WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
(LayerFlushController::create):
* WebView/WebViewData.mm:
(LayerFlushController::invalidate):
(WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Tue, 16 Jul 2013 18:38:09 +0000 (18:38 +0000)]
Unreviewed rebaselines, AppleWin port.
* platform/win/fast/js/global-constructors-attributes-dedicated-worker-expected.txt: Added.
* platform/win/fast/js/global-constructors-attributes-shared-worker-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Tue, 16 Jul 2013 18:16:38 +0000 (18:16 +0000)]
Unreviewed gardening. -webkit-user-select: all not supported on AppleWin port.
https://bugs.webkit.org/show_bug.cgi?id=118740
* platform/win/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Tue, 16 Jul 2013 18:04:15 +0000 (18:04 +0000)]
Fix some NSDictionary misuse pointed out by the clang static analyzer
https://bugs.webkit.org/show_bug.cgi?id=118736
Reviewed by Anders Carlsson.
Source/WebKit/mac:
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):
Explicitly cast the CFStringRef to an NSString *.
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::documentFragmentFromAttributedString):
Do not put a key with a nil value pair into the NSDictionary.
Source/WebKit2:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::documentFragmentFromAttributedString):
Do not put a key with a nil value pair into the NSDictionary.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ch.dumez@sisa.samsung.com [Tue, 16 Jul 2013 16:24:45 +0000 (16:24 +0000)]
Get rid of multiple inheritance support from the bindings generators
https://bugs.webkit.org/show_bug.cgi?id=118353
Reviewed by Kentaro Hara.
Source/WebCore:
Remove multiple inheritance support from the bindings generators (except
the ObjC one which still needs it for now). Multiple inheritance is no
longer supported in Web IDL and it makes the scripts more complex than
they needs to be.
Multiple inheritance support is no longer needed now that our SVG
interfaces have been updated to use the simpler SVG2 inheritance model
and use Web IDL 'implements' statements.
Note that the IDL parser still support multiple inheritance for now in
order not to break the ObjC bindings generator.
No new tests, no behavior change.
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorCPP.pm:
(GetParentImplClassName):
(GetParent):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorGObject.pm:
(GetParentClassName):
(GetParentImplClassName):
(GetParentGObjType):
* bindings/scripts/CodeGeneratorJS.pm:
(GetParentClassName):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDefinition):
* bindings/scripts/CodeGeneratorObjC.pm:
(AddMethodsConstantsAndAttributesFromParentInterfaces):
(GenerateImplementation):
* bindings/scripts/IDLParser.pm:
(parseInterface):
(parseException):
(parseInheritance):
Tools:
Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
deprecated domInterface->parents.
* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
(_parentInterface):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Jul 2013 16:08:31 +0000 (16:08 +0000)]
[GTK] Unreviewed gardening. Update test expectations after r152701
https://bugs.webkit.org/show_bug.cgi?id=118731
Unreviewed GTK gardening.
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-16
* platform/gtk/TestExpectations: Skip failing tests after r152701.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Tue, 16 Jul 2013 15:12:46 +0000 (15:12 +0000)]
HTMLMediaElement should not add cues for disabled text tracks
https://bugs.webkit.org/show_bug.cgi?id=118682
Source/WebCore:
Reviewed by Ryosuke Niwa.
Merge https://src.chromium.org/viewvc/blink?view=rev&revision=153810
Tests: media/track/track-disabled-addcue.html
media/track/track-disabled.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackAddCues): Do nothing if the track is disabled.
(WebCore::HTMLMediaElement::textTrackAddCue): Ditto.
LayoutTests:
Merge https://src.chromium.org/viewvc/blink?view=rev&revision=153810
Reviewed by Ryosuke Niwa.
* media/track/track-disabled-addcue-expected.txt: Added.
* media/track/track-disabled-addcue.html: Added.
* media/track/track-disabled-expected.txt: Added.
* media/track/track-disabled.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michael.bruning@digia.com [Tue, 16 Jul 2013 13:51:32 +0000 (13:51 +0000)]
[Qt] Replace Nokia with Qt Project in service name.
https://bugs.webkit.org/show_bug.cgi?id=118729
Reviewed by Simon Hausmann.
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Jul 2013 13:05:24 +0000 (13:05 +0000)]
check-webkit-style: "using namespace foo;" should be flagged as an error in headers
https://bugs.webkit.org/show_bug.cgi?id=57241
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-16
Reviewed by Ryosuke Niwa.
Added check for "using namespace foo" and unit test.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_using_namespace):
(check_style):
(CppChecker):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_using_namespace):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Jul 2013 13:03:38 +0000 (13:03 +0000)]
[GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=110222
Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-07-16
Reviewed by Gustavo Noronha Silva.
Tools:
Added handling of zero mouse scroll deltas in EventSender.
* DumpRenderTree/gtk/EventSender.cpp:
(mouseScrollByCallback):
LayoutTests:
* platform/gtk/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Jul 2013 12:58:57 +0000 (12:58 +0000)]
webkitpy: replace urllib with urllib2 for downloading additional modules
https://bugs.webkit.org/show_bug.cgi?id=118671
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-16
Reviewed by Ryosuke Niwa.
Urllib2 is available whereever urllib is, but has better proxy support.
* Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._download_to_stream):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Jul 2013 12:55:56 +0000 (12:55 +0000)]
[ATK] Adds support for aria-haspopup property.
https://bugs.webkit.org/show_bug.cgi?id=117834
Source/WebCore:
Patch by Krzysztof Czech <k.czech@ymail.com> on 2013-07-16
Reviewed by Christophe Dumez.
Adds support for aria-haspopup property.
Tests: accessibility/element-haspopup.html
accessibility/popup-button-title.html
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
Tools:
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-07-16
Reviewed by Christophe Dumez.
Adds implementation for testing aria-haspopup property.
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(getAttributeSetValueForId):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::hasPopup):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::getAttributeSetValueForId):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::hasPopup):
LayoutTests:
Patch by Krzysztof Czech <k.czech@ymail.com> on 2013-07-16
Reviewed by Christophe Dumez.
Moving accessibility tests related to aria-haspopup property.
* accessibility/element-haspopup-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-haspopup-expected.txt.
* accessibility/element-haspopup.html: Renamed from LayoutTests/platform/mac/accessibility/element-haspopup.html.
* accessibility/popup-button-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/popup-button-title-expected.txt.
* accessibility/popup-button-title.html: Renamed from LayoutTests/platform/mac/accessibility/popup-button-title.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michael.bruning@digia.com [Tue, 16 Jul 2013 12:22:20 +0000 (12:22 +0000)]
[Qt] Replace Nokia references.
https://bugs.webkit.org/show_bug.cgi?id=118728
Reviewed by Simon Hausmann.
Source/WebKit/qt:
* Api/qwebkitplatformplugin.h:
* examples/platformplugin/qwebkitplatformplugin.h:
Tools:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication):
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::LauncherApplication):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zarvai@inf.u-szeged.hu [Tue, 16 Jul 2013 11:57:08 +0000 (11:57 +0000)]
[Qt]Unreviewed gardening. New baseline and skip failing tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-16
* platform/qt-5.0-wk1/TestExpectations:
* platform/qt-5.0-wk1/http/tests/security/contentSecurityPolicy/object-src-none-allowed-expected.txt: Added.
* platform/qt/TestExpectations:
* platform/qt/editing/caret/caret-color-expected.png: Added.
* platform/qt/editing/caret/caret-color-expected.txt: Added.
* platform/qt/http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Jul 2013 11:10:43 +0000 (11:10 +0000)]
EWK2BackForwardListTest should be defined by inheriting from EWK2UnitTestBase.
https://bugs.webkit.org/show_bug.cgi?id=118717
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-16
Reviewed by Christophe Dumez.
* UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
(EWK2BackForwardListTest::checkItem):
(EWK2BackForwardListTest::urlFromTitle):
(EWK2BackForwardListTest::freeEinaList):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 16 Jul 2013 10:47:17 +0000 (10:47 +0000)]
[GTK] Remove compile warnings about GTK+ API deprecated after 3.6
https://bugs.webkit.org/show_bug.cgi?id=118237
Reviewed by Philippe Normand.
We depend on GTK+3.6 so we are not interested in compile warnings
about deprecated API after 3.6
* Source/autotools/SetupAutoconfHeader.m4: Define
GDK_VERSION_MIN_REQUIRED in config.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Jul 2013 10:16:46 +0000 (10:16 +0000)]
[texmap][GStreamer] upload onto the texture only the buffer to be painted
https://bugs.webkit.org/show_bug.cgi?id=118471
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-07-16
Reviewed by Philippe Normand.
Right now all the buffers are uploaded onto the texture. With this
logic pose situations where buffers that will not be painted are
uploaded.
This patch uploads only the buffers that are going to be shown.
With this approach, the buffers may arrive before a GraphicsLayer is
set, so we should be more cautious with GraphicsLayerTextureMapper's
client.
No new tests, covered by existing tests.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::~GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Jul 2013 09:50:24 +0000 (09:50 +0000)]
[GStreamer] verify and log the received caps in the video sink
https://bugs.webkit.org/show_bug.cgi?id=118559
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-07-16
Reviewed by Philippe Normand.
Verify the correctness of the received caps in the video sink, and
also log them for debugging purposes.
No new tests, no behavior change.
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkSetCaps):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kangil.han@samsung.com [Tue, 16 Jul 2013 09:20:04 +0000 (09:20 +0000)]
Use toHTMLSelectElement and dismiss isHTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=118714
Reviewed by Ryosuke Niwa.
To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup.
Additionally, this patch removes isHTMLSelectElement because not all element subclasses can be checked by a combination of tag names.
Source/WebCore:
* html/HTMLSelectElement.h:
(WebCore::toHTMLSelectElement):
* testing/Internals.cpp:
(WebCore::Internals::isSelectPopupVisible):
Source/WebKit/blackberry:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
(BlackBerry::WebKit::InputHandler::setPopupListIndex):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
Source/WebKit/win:
* DOMHTMLClasses.cpp:
(DOMHTMLSelectElement::options):
(DOMHTMLSelectElement::activateItemAtIndex):
Source/WebKit2:
* WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::commit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Jul 2013 07:35:49 +0000 (07:35 +0000)]
Replace mouseClick with more meaningful method in test_ewk2_text_checker.cpp
https://bugs.webkit.org/show_bug.cgi?id=118699
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-16
Reviewed by Christophe Dumez.
Many mouseClick methods are used in test_ewk2_text_checker.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.
* UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(EWK2TextCheckerTest::clickSelectAllWordsWithSpellcheckButton):
(EWK2TextCheckerTest::clickSelectAllWordsWithoutSpellcheckButton):
(EWK2TextCheckerTest::clickSelectSubWordWithSpellcheckButton):
(EWK2TextCheckerTest::showContextMenuWithFirstLineText):
(EWK2TextCheckerTest::showContextMenuWithSecondLineText):
(EWK2TextCheckerTest::selectFirstWordInFirstLineText):
(EWK2TextCheckerTest::selectFirstWordInSecondLineText):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Tue, 16 Jul 2013 06:55:31 +0000 (06:55 +0000)]
Source/WebCore: Fix a crash in Range::processContents().
NULL ptr in WebCore::Range::processAncestorsAndTheirSiblings
https://bugs.webkit.org/show_bug.cgi?id=77614
Reviewed by Ryosuke Niwa.
This change is ported from Blink revision 153483:
https://src.chromium.org/viewvc/blink?revision=153483&view=revision
This crash can be initiated by calling Range.detach() while deleteContents()
is processing the same range. Range::processContents() should save the state
of the range since mutation events can change the state of the range.
Test: fast/dom/Range/detach-range-during-deletecontents.html
* dom/Range.cpp:
(WebCore::Range::processContents):
* dom/RangeBoundaryPoint.h:
(WebCore::RangeBoundaryPoint::RangeBoundaryPoint):
LayoutTests: NULL ptr in WebCore::Range::processAncestorsAndTheirSiblings
https://bugs.webkit.org/show_bug.cgi?id=77614
Reviewed by Ryosuke Niwa.
This change is ported from Blink revision 153483:
https://src.chromium.org/viewvc/blink?revision=153483&view=revision
* fast/dom/Range/detach-range-during-deletecontents-expected.txt: Added.
* fast/dom/Range/detach-range-during-deletecontents.html: Added.
* fast/dom/Range/resources/detach-range-during-deletecontents-iframe.xhtml: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Tue, 16 Jul 2013 06:32:43 +0000 (06:32 +0000)]
Add a threading assertion to AtomicString::remove
https://bugs.webkit.org/show_bug.cgi?id=118695
Reviewed by Sam Weinig.
* wtf/text/AtomicString.cpp:
(WTF::AtomicString::remove): The destructor of StringImpl remove
the string from the string table if it is atomic. This needs to be done
on the same thread as the one on which the string was added (otherwise the original
table would keep a dangling pointer to a dead string).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 16 Jul 2013 05:19:36 +0000 (05:19 +0000)]
Input element that becomes visible during a simulated click event from an associated label element doesn't get focused
https://bugs.webkit.org/show_bug.cgi?id=118700
Reviewed by Kent Tamura.
Source/WebCore:
Inspired by https://chromium.googlesource.com/chromium/blink/+/
6435f70d53403b250e261a914f30d55142f81476.
The bug was caused by isMouseFocusable() check in HTMLLabelElement::defaultEventHandler not updating the layout even
though the call to dispatchSimulatedClick may have dirtied the render tree.
Explicitly update the layout so that we have up-to-date render tree.
Test: fast/forms/label/label-becomes-visible-while-clicking-on-label.html
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::defaultEventHandler):
LayoutTests:
Add a regression test.
* fast/forms/label/label-becomes-visible-while-clicking-on-label-expected.txt: Added.
* fast/forms/label/label-becomes-visible-while-clicking-on-label.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kangil.han@samsung.com [Tue, 16 Jul 2013 05:01:15 +0000 (05:01 +0000)]
Introduce toHTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=118672
Reviewed by Ryosuke Niwa.
To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup.
Source/WebCore:
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* dom/Document.cpp:
(WebCore::Document::seamlessParentIFrame):
* html/HTMLIFrameElement.h:
(WebCore::toHTMLIFrameElement):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::viewCleared):
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::isSeamless):
(WebCore::RenderIFrame::flattenFrame):
Source/WebKit/win:
* DOMHTMLClasses.cpp:
(DOMHTMLIFrameElement::contentFrame):
Source/WebKit2:
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Tue, 16 Jul 2013 04:56:29 +0000 (04:56 +0000)]
Unreviewed rebaselines after r152701.
* editing/pasteboard/paste-noplugin-expected.txt:
* http/tests/security/contentSecurityPolicy/object-src-url-blocked-expected.txt:
* platform/mac/accessibility/plugin-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Tue, 16 Jul 2013 04:55:32 +0000 (04:55 +0000)]
Add support for WaveShaperNode.oversample
https://bugs.webkit.org/show_bug.cgi?id=117435
Reviewed by Kenneth Russell.
Source/WebCore:
Adapted from Blink:
https://codereview.chromium.org/
15619003/
Please see specification for details:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#WaveShaperNode
.oversample specifies what type of oversampling (if any) should be used when applying the shaping curve.
The default value is "none", meaning the curve will be applied directly to the input samples.
A value of "2x" or "4x" can improve the quality of the processing by avoiding some aliasing,
with the "4x" value yielding the highest quality.
Tests: webaudio/waveshaper-oversample-2x.html
webaudio/waveshaper-oversample-4x.html
* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/webaudio/WaveShaperDSPKernel.cpp:
(WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):
(WebCore::WaveShaperDSPKernel::lazyInitializeOversampling):
(WebCore::WaveShaperDSPKernel::process):
(WebCore::WaveShaperDSPKernel::processCurve):
(WebCore::WaveShaperDSPKernel::processCurve2x):
(WebCore::WaveShaperDSPKernel::processCurve4x):
(WebCore::WaveShaperDSPKernel::reset):
(WebCore::WaveShaperDSPKernel::latencyTime):
* Modules/webaudio/WaveShaperDSPKernel.h:
* Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::WaveShaperNode):
(WebCore::WaveShaperNode::setOversample):
(WebCore::WaveShaperNode::oversample):
* Modules/webaudio/WaveShaperNode.h:
(WebCore::WaveShaperNode::latency):
* Modules/webaudio/WaveShaperNode.idl:
* Modules/webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::WaveShaperProcessor):
(WebCore::WaveShaperProcessor::setOversample):
* Modules/webaudio/WaveShaperProcessor.h:
(WebCore::WaveShaperProcessor::oversample):
* WebCore.xcodeproj/project.pbxproj:
* platform/audio/DownSampler.cpp: Added.
(WebCore::DownSampler::DownSampler):
(WebCore::DownSampler::initializeKernel):
(WebCore::DownSampler::process):
(WebCore::DownSampler::reset):
(WebCore::DownSampler::latencyFrames):
* platform/audio/DownSampler.h: Added.
* platform/audio/UpSampler.cpp: Added.
(WebCore::UpSampler::UpSampler):
(WebCore::UpSampler::initializeKernel):
(WebCore::UpSampler::process):
(WebCore::UpSampler::reset):
(WebCore::UpSampler::latencyFrames):
* platform/audio/UpSampler.h: Added.
LayoutTests:
* webaudio/resources/waveshaper-testing.js: Added.
(T0):
(T1):
(T2):
(T3):
(T4):
(generateWaveShapingCurve):
(checkShapedCurve):
(createImpulseBuffer):
(runWaveShaperOversamplingTest):
* webaudio/waveshaper-oversample-2x-expected.txt: Added.
* webaudio/waveshaper-oversample-2x.html: Added.
* webaudio/waveshaper-oversample-4x-expected.txt: Added.
* webaudio/waveshaper-oversample-4x.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Tue, 16 Jul 2013 04:01:36 +0000 (04:01 +0000)]
Update blocked/missing plug-in UI
https://bugs.webkit.org/show_bug.cgi?id=118347
<rdar://problem/
14209318>
Reviewed by Sam Weinig.
Patch by Anders Carlsson, Antoine Quint, Sam Weinig, and myself.
* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSDefaultStyleSheets.cpp:
* css/unavailablePlugIns.css: Added.
Add new Source/WebCore/css/unavailablePlugIns.css stylesheet.
* dom/EventListener.h:
New event listener type to support the creation of an event listener
for the label and icon for missing / blocked plug-in UI.
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
Remove explicit event handling since we're now using a DOM event handler
on the label and icon in the shadow root.
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
Don't populate the shadow root with plugin snapshotting elements
if we're not planning on showing a snapshot, because this means that
the shadow root was created for the unavailable plugin indicator instead.
* page/ChromeClient.h:
(WebCore::ChromeClient::shouldUnavailablePluginMessageIncludeButton):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
(WebCore::shouldUnavailablePluginMessageIncludeButton):
Rename from shouldUnavailablePluginMessageBeButton to
shouldUnavailablePluginMessageIncludeButton for accuracy.
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReasonDescription):
Set custom text to be displayed in the unavailability indicator.
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginButtonClickEvent):
(WebCore::RenderEmbeddedObject::willBeDestroyed):
(WebCore::RenderEmbeddedObject::isReplacementObscured):
(WebCore::RenderEmbeddedObjectEventListener::handleEvent):
(WebCore::RenderEmbeddedObjectEventListener::operator==):
Remove the old code used to render the missing / blocked plug-in UI in C++ in favor
of populating a shadow root in setPluginUnavailabilityReason(). We add a DOM event
listener in the shadow root to eventually call into unavailablePluginButtonClicked()
on the ChromeClient.
(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::layout):
Paint and lay out UA shadow root children.
(WebCore::RenderEmbeddedObject::canHaveChildren):
canHaveChildren can use the existence of a UA shadow root to decide
whether a RenderEmbeddedObject can have children.
* rendering/RenderEmbeddedObject.h:
(WebCore::RenderEmbeddedObjectEventListener::create):
(WebCore::RenderEmbeddedObjectEventListener::cast):
(WebCore::RenderEmbeddedObjectEventListener::RenderEmbeddedObjectEventListener):
Create the new event listener class necessary to handle events in the shadow root.
(WebCore::RenderEmbeddedObject::pluginUnavailabilityReasonDescription): Added.
* rendering/RenderWidget.h:
Promote willBeDestroyed() to be public so we may override it in the RenderEmbeddedObject subclass.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageIncludeButton):
Rename from shouldUnavailablePluginMessageBeButton to
shouldUnavailablePluginMessageIncludeButton for accuracy.
* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add a 6 argument -> 4 reply message handler.
(It seems that FindPlugin is getting a little out of hand.)
* Shared/APIClientTraits.cpp:
* Shared/APIClientTraits.h:
* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::pluginLoadPolicy):
* UIProcess/WebLoaderClient.h:
Add an unavailability description out-argument to a new version of
pluginLoadPolicy, so clients can override the text of the unavailable
plugin indicator. Bump the WKPageLoaderClient version and update APIClientTraits.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
Plumb the unavailability description through to the WebProcess via
the FindPlugin message.
* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didClose):
Make a strongly referencing copy of the list of PluginProxies, so we can
throw them away without the HashMap being mutated underneath us (see the comment).
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginProcessCrashed):
Invalidate the plug-in's widget before setting the plugin unavailability reason,
because doing so would cause the plug-in's renderer to be torn down, making
invalidate() crash.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageIncludeButton):
* WebProcess/WebCoreSupport/WebChromeClient.h:
Rename from shouldUnavailablePluginMessageBeButton to
shouldUnavailablePluginMessageIncludeButton for accuracy.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Acquire the unavailability description from the client
(via FindPlugin) and hand it to the RenderEmbeddedObject.
(WebKit::WebPage::canPluginHandleResponse):
Re-acquire the plugin's renderer, in case setPluginUnavailabilityReason destroyed it.
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
Match new WKPageLoaderClient entry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kseo@webkit.org [Tue, 16 Jul 2013 03:56:49 +0000 (03:56 +0000)]
Unreviewed. Add Gwang Yoon Hwang to contributor list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jpfau@apple.com [Tue, 16 Jul 2013 03:32:08 +0000 (03:32 +0000)]
Mark svg/custom/xlink-prefix-in-attributes.html as failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=118701
Unreviewed, changing test expectations
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Jul 2013 02:36:28 +0000 (02:36 +0000)]
PluginProcess deny file-read-data /Library/Application Support/Macromedia/FlashPlayerTrust
https://bugs.webkit.org/show_bug.cgi?id=118690
<rdar://problem/
14255963>
Patch by Simon Cooper <scooper@apple.com> on 2013-07-15
Reviewed by Dean Jackson.
Silently deny access to FlashPlayerTrust. This location contains
files containing lists of paths that Flash Player will
"allow" access to (without asking the user). Since the plugin
sandbox won't permit the access to the listed paths it is better
to silently block attempts to read these "whitelists". The
"whitelists" are created by other Adobe "installer" like
applications.
* Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Tue, 16 Jul 2013 01:29:30 +0000 (01:29 +0000)]
Update James Craig's email address.
* Scripts/webkitpy/common/config/contributors.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Tue, 16 Jul 2013 01:19:17 +0000 (01:19 +0000)]
Pack WebCore::Font slightly better.
<http://webkit.org/b/118681>
<rdar://problem/
14446014>
Reviewed by Sam Weinig.
Knock 8 bytes off of Font by packing the members better. Reduces memory consumption by 429 kB when
viewing the full HTML5 spec at <http://whatwg.org/c>
* platform/graphics/Font.h:
(WebCore::Font::typesettingFeatures):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Tue, 16 Jul 2013 00:37:02 +0000 (00:37 +0000)]
XMLSerializer doesn't include namespaces on nodes in HTML documents
https://bugs.webkit.org/show_bug.cgi?id=16496
Patch by Rob Buis <rwlbuis@webkit.org> on 2013-07-15
Reviewed by Ryosuke Niwa.
Source/WebCore:
Introduce a xml fragment serialization mode as indicated by
http://html5.org/specs/dom-parsing.html#xmlserializer (commit
00b84d2). In this mode
the XML fragment serialization algorithm is respected, the changes in this patch do the following:
- elements are self-closing if otherwise this would lead to invalid xml syntax.
- the resulting xml is XML namespace-well-formed (http://www.w3.org/TR/xml-names11/#Conformance).
This is achieved by always, when in xml fragment serialization mode, attempting to write out the element/attribute namespace,
preventing using the XML namespace as a default namespace and special casing the use of element's in XML namespace by using the xml prefix.
The chosen approach matches FireFox 25 behavior.
Test: fast/dom/dom-serialize-namespace.html
* WebCore.order: Adapt to changed createMarkup signature.
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::MarkupAccumulator):
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces): makes sure xml namespace/prefix is known so it is never used in namespace declarations.
(WebCore::MarkupAccumulator::appendNamespace): Avoid adding namespace declarations that do not differ from current default namespace.
(WebCore::MarkupAccumulator::appendOpenTag): Print xml prefix if the element's namespace is XML to avoid conflicts.
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute): Also take into account xmlns attributes with no namespace.
(WebCore::MarkupAccumulator::shouldSelfClose): Force self-closing to create well-formed XML elements.
* editing/MarkupAccumulator.h: Use EFragmentSerialization.
(WebCore::MarkupAccumulator::inXMLFragmentSerialization):
* editing/markup.cpp:
(WebCore::createMarkup):
* editing/markup.h: Add EFragmentSerialization enum.
* xml/XMLSerializer.cpp:
(WebCore::XMLSerializer::serializeToString):
LayoutTests:
The updated tests are progressions and match FF.
* fast/dom/Element/getAttribute-check-case-sensitivity-expected.txt:
* fast/dom/Element/script-tests/getAttribute-check-case-sensitivity.js:
* fast/dom/XMLSerializer-xml-namespace-expected.txt:
* fast/dom/dom-serialize-namespace-expected.txt: Added.
* fast/dom/dom-serialize-namespace.html: Added.
* fast/xsl/xslt-processor-expected.txt:
* inspector/elements/set-outer-html-expected.txt:
* svg/custom/xlink-prefix-in-attributes-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Jul 2013 00:32:40 +0000 (00:32 +0000)]
Web Inspector: Remove unused columns from select query in ImageUtilities.js
https://bugs.webkit.org/show_bug.cgi?id=118694
Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-07-15
Reviewed by Timothy Hatcher.
* UserInterface/ImageUtilities.js: Remove pixelRatio and formatVersion from select query.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc