mitz@apple.com [Sun, 13 Jan 2008 08:51:50 +0000 (08:51 +0000)]
Change test to match the results landed in r29424. The test changes were
omitted in that check-in.
* editing/pasteboard/paste-RTFD.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 13 Jan 2008 07:33:53 +0000 (07:33 +0000)]
2008-01-12 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Hide non-public symbols in GTK+/autotools release builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sun, 13 Jan 2008 06:54:57 +0000 (06:54 +0000)]
wx build fix. Add WebCore/icu/include for Mac builds using only stock ICU.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 13 Jan 2008 04:52:01 +0000 (04:52 +0000)]
2008-01-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Mark Rowe.
Fix http://bugs.webkit.org/show_bug.cgi?id=16852
Fixes leaking of ActivationStackNode objects.
* kjs/JSGlobalObject.cpp:
(KJS::JSGlobalObject::deleteActivationStack):
(KJS::JSGlobalObject::~JSGlobalObject):
(KJS::JSGlobalObject::init):
(KJS::JSGlobalObject::reset):
* kjs/JSGlobalObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Jan 2008 19:25:23 +0000 (19:25 +0000)]
2008-01-12 Rodney Dawes <dobey@wayofthemonkey.com>
Gtk debug build fix. Reviewed by Mark Rowe.
Add plugin logging channel, and use it rather than Win32-specific debugging methods _RPTF1 _RPTF2 and _CRT_WARN.
* WebCore.pro: Add plugins directory to DEPENDPATH so dependencies are correctly tracked.
* platform/Logging.cpp:
* platform/Logging.h:
* plugins/PluginDebug.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 12 Jan 2008 18:35:27 +0000 (18:35 +0000)]
Update expected results for fast/replaced/image-map-expected after
r29432 disabled document replacement by the JavaScript result in this
case.
* fast/replaced/image-map-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 12 Jan 2008 18:19:57 +0000 (18:19 +0000)]
- try to fix Qt Windows build
* pcre/dftables: Remove reliance on the list form of Perl pipes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 12 Jan 2008 18:05:44 +0000 (18:05 +0000)]
- try to fix Qt build
* kjs/function.cpp: Added include of scope_chain_mark.h.
* kjs/scope_chain_mark.h: Added multiple-include guards.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Jan 2008 15:43:03 +0000 (15:43 +0000)]
Roll out r29435 as it introduces many, many crashes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Jan 2008 14:25:03 +0000 (14:25 +0000)]
2008-01-12 Mark Rowe <mrowe@apple.com>
Another Windows build fix.
* kjs/Activation.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Jan 2008 14:12:55 +0000 (14:12 +0000)]
2008-01-12 Mark Rowe <mrowe@apple.com>
Attempted Windows build fix. Use struct consistently when forward-declaring
ActivationStackNode and StackActivation.
* kjs/Activation.h:
* kjs/JSGlobalObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Jan 2008 14:06:33 +0000 (14:06 +0000)]
2008-01-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Mark Rowe.
Fixes leaking of ActivationStackNode objects.
* kjs/JSGlobalObject.cpp:
(KJS::JSGlobalObject::deleteActivationStack):
(KJS::JSGlobalObject::~JSGlobalObject):
(KJS::JSGlobalObject::init):
(KJS::JSGlobalObject::reset):
* kjs/JSGlobalObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29435
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Sat, 12 Jan 2008 13:48:09 +0000 (13:48 +0000)]
* Make launching of the WebKit httpd work on GNU/Debian/Linux
The configuration of Apache2 and installation does not depend on
the kernel but on the distribution policy. Make launching of httpd
work for Debian derived distributions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Jan 2008 13:19:22 +0000 (13:19 +0000)]
Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
Reviewed by Maciej Stachowiak.
* DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
match the callers expectations that it can take ownership of the string.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Sat, 12 Jan 2008 12:03:28 +0000 (12:03 +0000)]
Reviewed by Maciej (and also tweaked a little bit).
- more thorough fix for some crashing tests
http://bugs.webkit.org/show_bug.cgi?id=16782
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::executeIfJavaScriptURL):
* loader/FrameLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Sat, 12 Jan 2008 11:03:30 +0000 (11:03 +0000)]
Reviewed by Maciej.
Fixes a problem with the ActivationImp tear-off patch (r29425) where
some of the calls to JSGlobalObject::tearOffActivation() were using
the wrong test to determine whether it should leave a relic behind.
* kjs/function.cpp:
(KJS::FunctionImp::argumentsGetter):
(KJS::ActivationImp::getOwnPropertySlot):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29431
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Sat, 12 Jan 2008 08:37:20 +0000 (08:37 +0000)]
Reviewed by Sam.
- fixed <rdar://problem/
5556374> REGRESSION: cross-domain error when one URL uses an explicit port number and another doesn't
* platform/SecurityOrigin.cpp:
(WebCore::isDefaultPortForProtocol):
(WebCore::SecurityOrigin::SecurityOrigin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29430
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 12 Jan 2008 07:40:52 +0000 (07:40 +0000)]
2008-01-11 Alp Toker <alp@atoker.com>
Reviewed by Oliver Hunt.
Enable FastMalloc by default in GTK+/autotools and add a configure
switch.
* GNUmakefile.am:
* configure.ac:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29429
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 12 Jan 2008 07:19:27 +0000 (07:19 +0000)]
JavaScriptCore:
Reviewed by Oliver Hunt.
Fixed <rdar://problem/
5665251> REGRESSION (r28880-r28886): Global
variable access (16644)
This bug was caused by var declarations shadowing built-in properties of
the global object.
To match Firefox, we've decided that var declarations will never shadow
built-in properties of the global object or its prototypes. We used to
behave more like IE, which allows shadowing, but walking that line got
us into trouble with websites that sent us down the Firefox codepath.
* kjs/JSVariableObject.h:
(KJS::JSVariableObject::symbolTableGet): New code to support calling
hasProperty before the variable object is fully initialized (so you
can call it during initialization).
* kjs/nodes.cpp:.
(KJS::ProgramNode::initializeSymbolTable): Always do a full hasProperty
check when looking for duplicates, not getDirect, since it only checks
the property map, and not hasOwnProperty, since it doesn't check
prototypes.
(KJS::EvalNode::processDeclarations): ditto
* kjs/property_slot.h:
(KJS::PropertySlot::ungettableGetter): Best function name evar.
WebCore:
Reviewed by Oliver Hunt.
Fixed <rdar://problem/
5665251> REGRESSION (r28880-r28886): Global
variable access (16644)
Removed the ReadOnly bit from some properties, to match Firefox. Also
removed status-related setters, to allow using their names as variable
names.
* bindings/scripts/CodeGeneratorJS.pm: Added support for properties that
are one-way across domain boundaries, to match Firefox.
* bindings/js/kjs_window.cpp: Changed ReadOnly declarations to match FF.
* bindings/scripts/CodeGeneratorJS.pm: Don't use JSObject:: because
we don't know that JSObject is our base class.
* page/DOMWindow.idl: Replaced lots of readonly declarations with
[Replaceable] declarations.
* page/DOMWindow.h: Removed interfaces for setting status text via the
DOM. (They were getting in the way of, e.g., "var status"
declarations.) By default, IE 7 and FF disable these interfaces in order
to defend against phishing attacks that try to spoof domain names in the
statusbar.
* page/DOMWindow.cpp:
LayoutTests:
Reviewed by Oliver Hunt.
Fixed <rdar://problem/
5665251> REGRESSION (r28880-r28886): Global
variable access (16644)
Added a test. Updated other tests to match new behavior.
* fast/js/var-declarations-shadowing-expected.txt: Added.
* fast/js/var-declarations-shadowing.html: Added.
* fast/dom/HTMLScriptElement/script-load-events.html: Changed this test
a bit because the original design made it hard to understand why it was failing.
* fast/dom/HTMLScriptElement/script-load-events-expected.txt:
* fast/dom/Window/get-set-properties.html: Changed this test to expect
our new behavior, which matches Firefox.
* fast/dom/Window/get-set-properties-expected.txt:
* fast/dom/Window/window-property-shadowing.html: Removed some cases
that differed from Firefox.
* fast/dom/Window/window-property-shadowing-expected.txt:
* http/tests/security/cross-frame-access-put-expected.txt: This test emits
more "Unsafe JavaScript attempt" messages now because property sets that
used to be prohibited (somewhat accidentally) by the ReadOnly attribute
are now prohibited by security checks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29428
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 12 Jan 2008 05:50:36 +0000 (05:50 +0000)]
WebCore:
2008-01-11 Anyang Ren <anyang.ren@gmail.com>
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=15960
The view source mode should skip an empty attribute value only if
the attribute name is not followed by an equal sign (=).
Test: fast/frames/viewsource-empty-attribute-value.html
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addViewSourceToken):
LayoutTests:
2008-01-11 Anyang Ren <anyang.ren@gmail.com>
Reviewed by Darin Adler.
Add a new regression test for
http://bugs.webkit.org/show_bug.cgi?id=15960
The view source mode should skip an empty attribute value only if
the attribute name is not followed by an equal sign (=).
* fast/frames/resources/viewsource-frame-1.html: Added.
* fast/frames/viewsource-empty-attribute-value-expected.txt: Added.
* fast/frames/viewsource-empty-attribute-value.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29427
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 12 Jan 2008 02:22:48 +0000 (02:22 +0000)]
2008-01-11 Sylvain Pasche <sylvain.pasche@gmail.com>
Reviewed by Alp Toker.
[Gtk] Uneven glyph spacing with subpixel antialiasing
http://bugs.webkit.org/show_bug.cgi?id=16715
Use cairo font options from the default GDK screen when creating a
scaled font.
* platform/graphics/gtk/FontPlatformDataGtk.cpp:
(WebCore::FontPlatformData::FontPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Sat, 12 Jan 2008 02:08:50 +0000 (02:08 +0000)]
JavaScriptCore:
Reviewed by Maciej.
Optimized ActivationImp allocation, so that activation records are now
first allocated on an explicitly managed stack and only heap allocated
when necessary. Roughly a 5% improvement on SunSpider, and a larger
improvement on benchmarks that use more function calls.
* JavaScriptCore.xcodeproj/project.pbxproj:
* kjs/Activation.h: Added.
(KJS::ActivationImp::ActivationData::ActivationData):
(KJS::ActivationImp::ActivationImp):
(KJS::ActivationImp::classInfo):
(KJS::ActivationImp::isActivationObject):
(KJS::ActivationImp::isOnStack):
(KJS::ActivationImp::d):
(KJS::StackActivation::StackActivation):
* kjs/ExecState.cpp:
(KJS::ExecState::ExecState):
(KJS::ExecState::~ExecState):
* kjs/ExecState.h:
(KJS::ExecState::replaceScopeChainTop):
(KJS::ExecState::setActivationObject):
(KJS::ExecState::setLocalStorage):
* kjs/JSGlobalObject.cpp:
(KJS::JSGlobalObject::reset):
(KJS::JSGlobalObject::pushActivation):
(KJS::JSGlobalObject::checkActivationCount):
(KJS::JSGlobalObject::popActivationHelper):
(KJS::JSGlobalObject::popActivation):
(KJS::JSGlobalObject::tearOffActivation):
* kjs/JSGlobalObject.h:
* kjs/JSVariableObject.h:
(KJS::JSVariableObject::JSVariableObjectData::JSVariableObjectData):
(KJS::JSVariableObject::JSVariableObject):
* kjs/function.cpp:
(KJS::FunctionImp::argumentsGetter):
(KJS::ActivationImp::ActivationImp):
(KJS::ActivationImp::~ActivationImp):
(KJS::ActivationImp::init):
(KJS::ActivationImp::getOwnPropertySlot):
(KJS::ActivationImp::markHelper):
(KJS::ActivationImp::mark):
(KJS::ActivationImp::ActivationData::ActivationData):
(KJS::GlobalFuncImp::callAsFunction):
* kjs/function.h:
* kjs/nodes.cpp:
(KJS::PostIncResolveNode::evaluate):
(KJS::PostDecResolveNode::evaluate):
(KJS::PreIncResolveNode::evaluate):
(KJS::PreDecResolveNode::evaluate):
(KJS::ReadModifyResolveNode::evaluate):
(KJS::AssignResolveNode::evaluate):
(KJS::WithNode::execute):
(KJS::TryNode::execute):
(KJS::FunctionBodyNode::processDeclarations):
(KJS::FuncExprNode::evaluate):
* kjs/object.h:
* kjs/scope_chain.h:
(KJS::ScopeChain::replace):
* kjs/scope_chain_mark.h: Added.
(KJS::ScopeChain::mark):
WebCore:
Reviewed by Maciej.
Added a new forwarding header, because Activation.h has been separated
from function.h
* ForwardingHeaders/kjs/Activation.h: Added.
LayoutTests:
Reviewed by Maciej.
Added a test case that came up when developing the ActivationImp tear-off.
* fast/js/resources/vardecl-preserve-arguments.js:
* fast/js/vardecl-preserve-arguments-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Sat, 12 Jan 2008 01:52:54 +0000 (01:52 +0000)]
<rdar://problem/
5541054> editing/pasteboard/paste-RTFD.html failing on Tiger
* editing/pasteboard/paste-RTFD.html: Mention the Tiger bug that this demonstrates.
* platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.checksum: Added.
* platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
* platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt: Updated expected results
to reflect the new info included in the test.
* platform/mac/editing/pasteboard/paste-RTFD-expected.checksum: Ditto.
* platform/mac/editing/pasteboard/paste-RTFD-expected.png:
* platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 12 Jan 2008 01:36:02 +0000 (01:36 +0000)]
2008-01-11 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16729
[cURL] Allow multiple files for upload
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::readCallback): added
(WebCore::ResourceHandleManager::setupPOST): setup for streaming the POST
(WebCore::ResourceHandleManager::startJob):
(WebCore::ResourceHandleManager::cancel): revert the previous patch for regression
* platform/network/curl/ResourceHandleManager.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 12 Jan 2008 00:25:41 +0000 (00:25 +0000)]
2008-01-11 Christian Dywan <christian@imendio.com>
Reviewed by Alp Toker.
[Gtk] Menu items need underscores
http://bugs.webkit.org/show_bug.cgi?id=16817
Add underscores to appropriate menu labels.
Also adjust strings slightly.
* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::createNativeMenuItem):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::searchableIndexIntroduction):
(WebCore::fileButtonChooseFileLabel):
(WebCore::fileButtonNoFileSelectedLabel):
(WebCore::contextMenuItemTagOpenLinkInNewWindow):
(WebCore::contextMenuItemTagDownloadLinkToDisk):
(WebCore::contextMenuItemTagCopyLinkToClipboard):
(WebCore::contextMenuItemTagOpenImageInNewWindow):
(WebCore::contextMenuItemTagDownloadImageToDisk):
(WebCore::contextMenuItemTagCopyImageToClipboard):
(WebCore::contextMenuItemTagOpenFrameInNewWindow):
(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagReload):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagIgnoreSpelling):
(WebCore::contextMenuItemTagLearnSpelling):
(WebCore::contextMenuItemTagSearchWeb):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::contextMenuItemTagOpenLink):
(WebCore::contextMenuItemTagIgnoreGrammar):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckSpelling):
(WebCore::contextMenuItemTagCheckSpellingWhileTyping):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagFontMenu):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):
(WebCore::contextMenuItemTagOutline):
(WebCore::contextMenuItemTagWritingDirectionMenu):
(WebCore::contextMenuItemTagDefaultDirection):
(WebCore::contextMenuItemTagLeftToRight):
(WebCore::contextMenuItemTagRightToLeft):
(WebCore::contextMenuItemTagInspectElement):
(WebCore::searchMenuClearRecentSearchesText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Fri, 11 Jan 2008 23:56:40 +0000 (23:56 +0000)]
<rdar://problem/
5681557> On Windows Safari, mouse events are ignored after clicking on link that triggers download
Moved the call to cache page from provisionalLoadStarted() to commitProvisionalLoad(), since
provisionalLoadStarted() can be called for cases that do not result in a page navigation, for example,
when a link to download a file has been clicked.
Reviewed by John and Anders.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::provisionalLoadStarted):
(WebCore::FrameLoader::commitProvisionalLoad):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Fri, 11 Jan 2008 22:42:12 +0000 (22:42 +0000)]
2008-01-11 Jon Honeycutt <jhoneycutt@apple.com>
* platform/win/Skipped: Remove a test that was fixed in r29419.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Fri, 11 Jan 2008 22:38:31 +0000 (22:38 +0000)]
2008-01-11 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
<rdar://problem/
5683529> plugins/embed-inside-object.html is timing
out/failing
Revert to using FrameTree::find() so that frame aliases like "_self" and
"_current" are interpreted properly
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::performRequest):
(WebCore::PluginViewWin::load):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 11 Jan 2008 21:58:11 +0000 (21:58 +0000)]
2008-01-11 Alp Toker <alp@atoker.com>
Reviewed by Dave Hyatt and Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=16089
[GTK] Support custom fonts, CachedFont::platformDataFromCustomData()
Add support for CSS2 @font-face custom/downloadable fonts to the GTK+
port.
* GNUmakefile.am:
* WebCore.pro:
* loader/CachedFont.cpp:
(WebCore::CachedFont::~CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::platformDataFromCustomData):
(WebCore::CachedFont::allReferencesRemoved):
* platform/graphics/gtk/FontCustomPlatformData.cpp: Added.
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::releaseData):
(WebCore::createFontCustomPlatformData):
* platform/graphics/gtk/FontCustomPlatformData.h: Added.
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
* platform/graphics/gtk/FontPlatformData.h:
* platform/graphics/gtk/FontPlatformDataGtk.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::init):
(WebCore::FontPlatformData::isFixedPitch):
* platform/graphics/gtk/SimpleFontDataGtk.cpp:
(WebCore::SimpleFontData::platformDestroy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 11 Jan 2008 21:04:36 +0000 (21:04 +0000)]
Reviewed by Adam Roben.
<rdar://problem/
5667275> fast/dynamic/layer-hit-test-crash.html is failing
* DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
as these are only posted because the test window is not a normal visible one, and
they confuse drag&drop machinery.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 11 Jan 2008 20:51:19 +0000 (20:51 +0000)]
Remove FrameLoader::committedFirstRealDocumentLoad
This method no longer has any callers.
Reviewed by Hyatt.
* loader/FrameLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 11 Jan 2008 20:50:52 +0000 (20:50 +0000)]
Fix Bug 16828: WebView never paints if first page load is canceled after being committed but before layout
<http://bugs.webkit.org/show_bug.cgi?id=16828>
<rdar://
5682402>
Now that we have 1) a real loader and 2) multiple FrameViews per
Frame, we no longer need the hackery we had in our WM_PAINT handler
that decided whether or not to paint. We now always want to paint,
letting the swapping of FrameViews that happens in
transitionToCommittedForNewPage handle which document gets painted.
Reviewed by Hyatt.
* WebView.cpp:
(WebViewWndProc): Removed hackery that decided sometimes not to paint.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 11 Jan 2008 20:19:13 +0000 (20:19 +0000)]
Add a standalone version of the blog post video player as a manual test.
* manual-tests/resources/touch-poster.png: Added.
* manual-tests/video-player.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Fri, 11 Jan 2008 20:07:54 +0000 (20:07 +0000)]
test is failing on trunk-win-release, so putting it back to make it green
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 11 Jan 2008 19:47:02 +0000 (19:47 +0000)]
Add shared vsprops to help unify our Windows tools settings.
Reviewed by Hyatt.
* win/tools: Added.
* win/tools/WinTools.make: Added.
* win/tools/vsprops: Added.
* win/tools/vsprops/common.vsprops: Added.
* win/tools/vsprops/debug.vsprops: Added.
* win/tools/vsprops/release.vsprops: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Fri, 11 Jan 2008 19:29:29 +0000 (19:29 +0000)]
removing test that doesn't fail
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 11 Jan 2008 19:19:57 +0000 (19:19 +0000)]
Reviewed by Adam.
Fix <rdar://problem/
5682767>
Video does not show up in http://webkit.org/blog/140/html5-media-support/ on Windows
Take care that GWorld is created and deletes when needed as size or visibility changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 11 Jan 2008 18:27:18 +0000 (18:27 +0000)]
Fix for bug 11188, setting hspace on a table overrides align=center. Fix align=center to be done using
mapped attributes so that it does not get overridden by hspace all the time.
Reviewed by mitz
Added fast/table/table-hspace-align-center.html
* css/html4.css:
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::parseMappedAttribute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 11 Jan 2008 18:25:44 +0000 (18:25 +0000)]
Add layout test for table bug.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Fri, 11 Jan 2008 18:15:32 +0000 (18:15 +0000)]
moved couple of tests to a better category
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29407
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 11 Jan 2008 18:14:34 +0000 (18:14 +0000)]
Fix a crash when pathToLocalResource fails and a leak
Reviewed by Darin.
* DumpRenderTree/LayoutTestController.cpp:
(pathToLocalResourceCallback): Dont leak the JSStringRef, and make
sure not to pass null to JSValueMakeString.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::pathToLocalResource): Print an error message if
the conversion fails so it's clear what happened.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29406
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 11 Jan 2008 16:32:29 +0000 (16:32 +0000)]
* platform/win/Skipped: Added some new failures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 11 Jan 2008 16:31:34 +0000 (16:31 +0000)]
2008-01-11 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16838
[GTK] Bad autotools debug and video options
Fix some configure options.
* configure.ac:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 11 Jan 2008 12:40:32 +0000 (12:40 +0000)]
Qt build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 11 Jan 2008 12:26:21 +0000 (12:26 +0000)]
Reviewed by Mark Rowe.
Fix the (clean) qmake build. For generating chartables.c we don't
depend on a separate input source file anymore, the dftables perl
script is enough. So use that instead as value for the .input
variable, to ensure that qmake also generates a rule to call dftables.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 11 Jan 2008 11:56:58 +0000 (11:56 +0000)]
Windows build fix. Update to match method name in WebCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 11 Jan 2008 11:53:48 +0000 (11:53 +0000)]
Qt build fix. Add link stubs for the new FileSystem.h functions introduced in r29399.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 11 Jan 2008 11:32:46 +0000 (11:32 +0000)]
2008-01-11 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Anders Carlsson.
Bug 16779: Make the PluginStream implementation be shared across platforms
http://bugs.webkit.org/show_bug.cgi?id=16779
Add the new shared PluginStream files to the GTK+ and Win32 builds.
Add PluginStreamClient class for the streamDidFinishLoading method.
Add open/close/write methods to FileSystem for temporary file handling.
Add PluginDebug.h and npfunctions.h for shared PluginStream.
Add shared PluginStream.
Remove PluginStreamWin.
Update PluginViewWin to use shared PluginStream and PluginStreamClass.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* platform/FileSystem.h:
* platform/gtk/FileSystemGtk.cpp:
* platform/win/FileSystemWin.cpp:
* plugins/PluginDebug.h:
* plugins/PluginStream.cpp:
* plugins/PluginStream.h:
* plugins/npfunctions.h:
* plugins/win/PluginDebug: Moved to PluginDebug.h.
* plugins/win/PluginStreamWin.cpp: Moved to PluginStream.cpp.
* plugins/win/PluginStreamWin.h: Moved to PluginStream.h
* plugins/win/PluginViewWin.cpp:
* plugins/win/PluginViewWin.h:
* plugins/win/npfunctions.h: Moved to npfunctions.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 11 Jan 2008 10:09:51 +0000 (10:09 +0000)]
Try to fix Mac build: Edit the right .exp file.
* WebCore.base.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 11 Jan 2008 10:03:38 +0000 (10:03 +0000)]
Try to fix Qt build: don't use pthreads if they're not available.
* bindings/js/GCController.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 11 Jan 2008 09:52:27 +0000 (09:52 +0000)]
JavaScriptCore:
Reviewed by John Sullivan.
Fixed some world leak reports:
* <rdar://problem/
5669436> PLT complains about world leak of 1 JavaScript
Interpreter after running cvs-base suite
* <rdar://problem/
5669423> PLT complains about world leak if browser
window is open when PLT starts
* kjs/collector.h: Added the ability to distinguish between global
objects and GC-protected global objects, since we only consider the
latter to be world leaks.
* kjs/collector.cpp:
WebCore:
Reviewed by John Sullivan.
Fixed some world leak reports:
* <rdar://problem/
5669436> PLT complains about world leak of 1 JavaScript
Interpreter after running cvs-base suite
* <rdar://problem/
5669423> PLT complains about world leak if browser
window is open when PLT starts
These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.
Stupid class, I kill you:
* bridge/JavaScriptStatistics.cpp: Removed.
* bridge/JavaScriptStatistics.h: Removed.
* bindings/js/GCController.h: Adopted the only useful features of
JavaScriptStatistics, since they were GC-related.
* bindings/js/GCController.cpp:
WebKit/mac:
Reviewed by John Sullivan.
Fixed some world leak reports:
* <rdar://problem/
5669436> PLT complains about world leak of 1 JavaScript
Interpreter after running cvs-base suite
* <rdar://problem/
5669423> PLT complains about world leak if browser
window is open when PLT starts
These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.
* Misc/WebCoreStatistics.h: Did a little renaming, to match
JavaScriptCore better. I kept the methods with the old names around,
though, because old versions of Safari need them.
* Misc/WebCoreStatistics.mm: Removed dependence on
WebCore::JavaScriptStatistics, which is gone now.
These two methods are now distinct, for the sake of world leak reporting:
(+[WebCoreStatistics javaScriptGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
WebKit/win:
Reviewed by John Sullivan.
Updated for transition away from JavaScriptStatistics, which is gone now.
* WebJavaScriptCollector.cpp:
(WebJavaScriptCollector::collect):
(WebJavaScriptCollector::collectOnAlternateThread):
(WebJavaScriptCollector::objectCount):
WebKitTools:
Reviewed by John Sullivan.
* DumpRenderTree/mac/GCControllerMac.mm:
(GCController::collectOnAlternateThread): Updated for name change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 11 Jan 2008 08:22:47 +0000 (08:22 +0000)]
Silence qmake warning about ctgen lacking input. Rubber-stamped by Alp Toker.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 11 Jan 2008 08:04:21 +0000 (08:04 +0000)]
Attempt to fix the GTK+ and Qt builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 11 Jan 2008 07:50:44 +0000 (07:50 +0000)]
Not reviewed, build fix.
- more build fixing
* WebDatabaseManager.cpp:
* WebSecurityOrigin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 11 Jan 2008 07:30:41 +0000 (07:30 +0000)]
Not reviewed, build fix.
- try to fix build
* WebDatabaseManager.cpp:
(WebDatabaseManager::databasesWithOrigin):
* WebSecurityOrigin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 11 Jan 2008 05:29:08 +0000 (05:29 +0000)]
wx build fix. Don't build dftables any longer since it's now a Perl script.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 11 Jan 2008 05:12:34 +0000 (05:12 +0000)]
Add FIXME for replacing YYPARSE_PARAM with %parse-param to CSSGrammar.y
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 11 Jan 2008 04:42:35 +0000 (04:42 +0000)]
Reviewed by Adele.
No functional changes, only code cleanup.
* css/MediaQueryEvaluator.cpp:
(WebCore::compareValue): renamed from cmpvalue
(WebCore::colorMediaFeatureEval):
(WebCore::device_aspect_ratioMediaFeatureEval):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::gridMediaFeatureEval):
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 11 Jan 2008 04:19:48 +0000 (04:19 +0000)]
Reviewed by Anders Carlsson.
- fix a crash when calling alert() from a repeating timer
On non-Mac platforms, the PageGroupLoadDeferrer pauses DOM timers during
alert() and other similar functions, which deletes the actual
DOMWindowTimer objects and replaces them with new objects when resuming.
* bindings/js/kjs_window.cpp:
(KJS::Window::timerFired): Re-fetch the timer object from the map in
case it has been deleted or replaced.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 11 Jan 2008 03:51:00 +0000 (03:51 +0000)]
Not reviewed. Build fix.
- Attempt to fix mac build.
* Storage/WebDatabaseManager.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 11 Jan 2008 03:36:14 +0000 (03:36 +0000)]
WebCore:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* GNUmakefile.am:
* WebCore.base.exp:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::postMessage):
* dom/Document.cpp:
(WebCore::Document::domain):
* page/Chrome.cpp:
(WebCore::Chrome::requestQuotaIncreaseForNewDatabase):
(WebCore::Chrome::requestQuotaIncreaseForDatabaseOperation):
* page/Chrome.h:
* page/ChromeClient.h:
* platform/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::copy):
(WebCore::SecurityOrigin::createFromIdentifier):
(WebCore::SecurityOrigin::stringIdentifier):
* platform/SecurityOrigin.h:
(WebCore::SecurityOrigin::host):
(WebCore::SecurityOrigin::protocol):
(WebCore::SecurityOrigin::port):
(WebCore::SecurityOrigin::equal):
* platform/SecurityOriginData.cpp: Removed.
* platform/SecurityOriginData.h: Removed.
* storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::securityOriginCopy):
* storage/Database.h:
* storage/DatabaseTracker.cpp:
(WebCore::SecurityOriginHash::hash):
(WebCore::SecurityOriginHash::equal):
(WebCore::SecurityOriginTraits::deletedValue):
(WebCore::SecurityOriginTraits::emptyValue):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::hasEntryForDatabase):
(WebCore::DatabaseTracker::establishEntryForOrigin):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
(WebCore::DatabaseTracker::setDatabaseDetails):
(WebCore::DatabaseTracker::usageForDatabase):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::addDatabase):
(WebCore::DatabaseTracker::deleteAllDatabases):
(WebCore::DatabaseTracker::deleteDatabasesWithOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
(WebCore::notificationQueue):
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):
(WebCore::DatabaseTracker::notifyDatabasesChanged):
* storage/DatabaseTracker.h:
* storage/DatabaseTrackerClient.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
(WebCore::SQLTransaction::postflightAndCommit):
(WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
* svg/graphics/SVGImageEmptyClients.h:
(WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForNewDatabase):
(WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForDatabaseOperation):
WebKit/gtk:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::requestQuotaIncreaseForNewDatabase):
(WebKit::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
* WebCoreSupport/ChromeClientGtk.h:
WebKit/mac:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager origins]):
(-[WebDatabaseManager databasesWithOrigin:]):
(-[WebDatabaseManager detailsForDatabase:withOrigin:]):
(-[WebDatabaseManager deleteDatabasesWithOrigin:]):
(-[WebDatabaseManager deleteDatabase:withOrigin:]):
* Storage/WebDatabaseTrackerClient.h:
* Storage/WebDatabaseTrackerClient.mm:
(WebDatabaseTrackerClient::dispatchDidModifyOrigin):
(WebDatabaseTrackerClient::dispatchDidModifyDatabase):
* Storage/WebSecurityOrigin.mm:
(-[WebSecurityOrigin initWithProtocol:domain:port:]):
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin port]):
(-[WebSecurityOrigin usage]):
(-[WebSecurityOrigin quota]):
(-[WebSecurityOrigin setQuota:]):
(-[WebSecurityOrigin isEqual:]):
(-[WebSecurityOrigin dealloc]):
(-[WebSecurityOrigin finalize]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
(-[WebSecurityOrigin _core]):
* Storage/WebSecurityOriginInternal.h:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requestQuotaIncreaseForNewDatabase):
(WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
WebKit/qt:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::requestQuotaIncreaseForNewDatabase):
(WebCore::ChromeClientQt::requestQuotaIncreaseForDatabaseOperation):
* WebCoreSupport/ChromeClientQt.h:
WebKit/win:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* WebChromeClient.cpp:
(WebChromeClient::requestQuotaIncreaseForNewDatabase):
(WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
* WebChromeClient.h:
* WebDatabaseManager.cpp:
(WebDatabaseManager::origins):
(WebDatabaseManager::databasesWithOrigin):
(WebDatabaseManager::detailsForDatabaseWithOrigin):
(WebDatabaseManager::deleteDatabasesWithOrigin):
(WebDatabaseManager::deleteDatabaseWithOrigin):
(WebDatabaseManager::dispatchDidModifyOrigin):
(WebDatabaseManager::dispatchDidModifyDatabase):
* WebDatabaseManager.h:
* WebSecurityOrigin.cpp:
(WebSecurityOrigin::createInstance):
(WebSecurityOrigin::WebSecurityOrigin):
(WebSecurityOrigin::protocol):
(WebSecurityOrigin::domain):
(WebSecurityOrigin::port):
(WebSecurityOrigin::usage):
(WebSecurityOrigin::quota):
(WebSecurityOrigin::setQuota):
* WebSecurityOrigin.h:
WebKit/wx:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::requestQuotaIncreaseForNewDatabase):
(WebCore::ChromeClientWx::requestQuotaIncreaseForDatabaseOperation):
* WebKitSupport/ChromeClientWx.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Fri, 11 Jan 2008 02:48:06 +0000 (02:48 +0000)]
2008-01-10 Stephanie <slewis@apple.com>
RS=Oliver.
Move svg/batik/text/smallfonts.svg to the right skip list.
* platform/mac-tiger/Skipped:
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 11 Jan 2008 02:09:55 +0000 (02:09 +0000)]
Reviewed by Sam.
Use the correct frame loader load method. Using the old method would not cause a
new window to be open if the frame navigation was not allowed.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::performRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 11 Jan 2008 00:55:03 +0000 (00:55 +0000)]
2008-01-10 Alp Toker <alp@atoker.com>
SVG font build fix for GTK+/autotools.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 11 Jan 2008 00:41:44 +0000 (00:41 +0000)]
BUILD FIX: Make dftables executable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 11 Jan 2008 00:35:14 +0000 (00:35 +0000)]
JavaScriptCore:
dftables should be rewritten as a script
<http://bugs.webkit.org/show_bug.cgi?id=16818>
<rdar://problem/
5681463>
Reviewed by Darin.
Rewrote the dftables utility in Perl. Attempted to switch all
build systems to call the script directly instead of building
a binary first. Only the Xcode build was able to be tested.
* DerivedSources.make: Added pcre directory to VPATH and changed
to invoke dftables directly.
* GNUmakefile.am: Removed build information and changed to invoke
dftables directly.
* JavaScriptCore.vcproj/JavaScriptCore.sln: Removed reference to
dftables project.
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Ditto.
* JavaScriptCore.vcproj/dftables: Removed.
* JavaScriptCore.vcproj/dftables/dftables.vcproj: Removed.
* JavaScriptCore.xcodeproj/project.pbxproj: Removed dftables target.
* jscore.bkl: Removed dftables executable definition.
* pcre/dftables: Copied from JavaScriptCore/pcre/dftables.cpp.
* pcre/dftables.cpp: Removed.
* pcre/dftables.pro: Removed.
* pcre/pcre.pri: Removed references to dftables.cpp and changed to
invoke dftables directly.
WebKit/win:
dftables should be rewritten as a script
<http://bugs.webkit.org/show_bug.cgi?id=16818>
<rdar://problem/
5681463>
Reviewed by Darin.
* WebKit.vcproj/WebKit.sln: Removed reference to dftables project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 11 Jan 2008 00:23:13 +0000 (00:23 +0000)]
WebCore:
Reviewed by Sam Weinig and Anders Carlsson.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/
5657355>
This patch makes two changes:
1) Java calls FrameLoader::load in a slightly different way than
JavaScript, which previously let a malicious web site bypass the
shouldAllowNavigation check. This patch adds that check to that
code path.
2) FrameLoader now wraps calls to m_frame->tree()->find(name) with
findFrameForNavigation, which calls shouldAllowNavigation. This
treats disallowed frame navigations as if the named frame did not
exist, resulting in a popup window when appropriate.
Tests: http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html
http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html
* WebCore.base.exp:
* bindings/js/kjs_window.cpp:
(KJS::WindowProtoFuncOpen::callAsFunction):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::createWindow):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::post):
(WebCore::FrameLoader::findFrameForNavigation):
* loader/FrameLoader.h:
WebKit/mac:
Reviewed by Anders Carlsson.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/
5657355>
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation
to ensure the shouldAllowNavigation check is made.
WebKitTools:
Reviewed by Anders Carlsson.
Make DRT track open windows instead of allocated windows so that
we can avoid ASSERTION due to late deallocs out of our control.
* DumpRenderTree/mac/DumpRenderTree.mm:
(dumpBackForwardListForAllWindows):
(runTest):
* DumpRenderTree/mac/DumpRenderTreeMac.h:
* DumpRenderTree/mac/DumpRenderTreeWindow.h:
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
(+[DumpRenderTreeWindow openWindows]):
(-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
(-[DumpRenderTreeWindow close]):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::windowCount):
LayoutTests:
Reviewed by Anders Carlsson.
Tests for http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/
5657355>
* http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Added.
* http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Added.
* http/tests/security/frameNavigation/resources/navigation-happened.html: Added.
* http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Added.
* http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Added.
* http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Added.
* http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Added.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 11 Jan 2008 00:10:05 +0000 (00:10 +0000)]
Written by Hyatt, reviewed by me
- fixed <rdar://problem/
5654297> Mail crashes occurs at WebCore::FontFallbackList::fontDataAt() when attempting to display
a <video> element that uses controls attribute
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
force the render style to inherit from the media element's style; Hyatt filed
5682383 to cover cleaning
up this architecture, but this one-line fix will prevent the crash in the meantime
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 11 Jan 2008 00:02:16 +0000 (00:02 +0000)]
Whoops, did not mean to commit that.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 11 Jan 2008 00:00:57 +0000 (00:00 +0000)]
Fix fast/forms/input-radio-checked-tab.html
Meta key is not the same as Alt key on windows.
Reviewed by Darin.
* platform/win/KeyEventWin.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 10 Jan 2008 23:11:54 +0000 (23:11 +0000)]
Meta key is not the same as Alt key on windows.
Reviewed by Darin.
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 10 Jan 2008 23:11:27 +0000 (23:11 +0000)]
Fix fast/forms/input-radio-checked-tab.html
Meta key is not the same as Alt key on windows.
Reviewed by Darin.
* platform/win/KeyEventWin.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 10 Jan 2008 22:17:26 +0000 (22:17 +0000)]
* platform/win/Skipped: Removed a test that was fixed in r26826.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 10 Jan 2008 22:14:14 +0000 (22:14 +0000)]
* platform/win/Skipped: Removed a test that was fixed in r28372.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 10 Jan 2008 21:51:40 +0000 (21:51 +0000)]
Reviewed by John Sullivan.
<rdar://problem/
5455889>
REGRESSION: BumperCar crashes when attempting to load a long invalid URL
Make sure to call FrameLoader::receivedMainResourceError before calling
FrameLoader::didFailToLoad. The call to receivedMainResourceError takes care of
clearing out the provisional document loader so that we won't call the didFail
ResourceLoadDelegate method twice. This also makes us call the FrameLoadDelegate method
didFailPrivisionalLoad before calling the ResourceLoadDelegate method, which Safari 2.0 does.
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::receivedError):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 10 Jan 2008 21:48:18 +0000 (21:48 +0000)]
Reviewed by Adele.
Fix <rdar://problem/
5658048>
After <video> has finished playing, dragging the scroller on different location of controller starts to play movie
- Move to paused state if the playback had ended and the controller is used to seek to earlier time
- Pause video playback during drag so the knob does not constantly try to escape from the mouse pointer
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::updateMediaPlayer):
(WebCore::HTMLMediaElement::setPausedInternal):
* html/HTMLMediaElement.h:
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::defaultEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 10 Jan 2008 21:33:19 +0000 (21:33 +0000)]
Reviewed by Adam Roben.
<rdar://problem/
5667003> fast/dom/xmlhttprequest-html-response-encoding.html is failing
* xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Do not disable sniffing for file://
requests, as CFNetwork doesn't perform extension to MIME type mapping then.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 10 Jan 2008 21:23:34 +0000 (21:23 +0000)]
Fix many bugs by giving Windows one FrameView per page load
WebCore:
Fixes to allow multiple FrameViews on Windows
Reviewed by Hyatt.
* page/FrameView.cpp:
(WebCore::FrameView::FrameView): Added a new constructor that takes an
IntSize to specify the FrameView's initial size.
(WebCore::FrameView::scheduleRelayout): Added an assertion that our
Document is not in the page cache.
* page/FrameView.h:
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::~Widget): Add a warm, fuzzy ASSERT.
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::~Widget): Ditto.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget): Make sure to remove any existing
Widget from the Widget hierarchy before deleting it. One instance
where this is needed is when setWidget is called during FrameView
creation on Windows.
WebKit/win:
Fix many bugs by giving Windows one FrameView per page load
Bugs include:
<rdar://
5659200>
Windows back/forward cache causes crashes in the layout tests
<rdar://
5659355>
<http://bugs.webkit.org/show_bug.cgi?id=16808>
REGRESSION: PLT broken on Windows due to back/forward cache
<rdar://
5663654>
<http://bugs.webkit.org/show_bug.cgi?id=16607>
Random crashes in FrameView::scheduleRelayout while surfing
Thinkgeek
On Windows until now we've only had one FrameView per Frame. Once the
back/forward cache was turned on this started causing assertions to
fail and crashes to occur due to a single FrameView being both in the
back/forward cache (possibly multiple times!) and used by a live
document. We now create a new FrameView for each page load, just as
Mac does.
This has the side-effect of plugging some of the world leaks seen at
the end of the PLT.
Reviewed by Hyatt.
* WebFrame.cpp:
(WebFrame::initWithWebFrameView): Don't create the FrameView right
away -- it'll be created when the load is committed.
(WebFrame::transitionToCommittedFromCachedPage): Match the Mac by no
longer calling resetMultipleFormSubmissionProtection here.
(WebFrame::transitionToCommittedForNewPage): Ported code from
-[WebCoreFrameBridge
createFrameViewWithNSView:marginWidth:marginHeight:],
-[WebCoreFrameBridge installInFrame:], and moved code here from
WebFrame::initWithWebFrameView and WebView::initWithFrame. WebCore
takes care of resetMultipleFormSubmissionProtection, just like it does
on the Mac.
* WebView.cpp:
(WebView::initWithFrame): Moved FrameView initialization code to
WebFrame::transitionToCommittedForNewPage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 10 Jan 2008 21:10:31 +0000 (21:10 +0000)]
2008-01-10 Alp Toker <alp@atoker.com>
Include math.h to get ceilf(). Part of the SVG font GTK+ build fix.
* svg/SVGFontFaceElement.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Thu, 10 Jan 2008 20:40:34 +0000 (20:40 +0000)]
Reviewed by Alice Liu.
<rdar://problem/
5658603> Crash in InsertNodeBefore::doUnapply() on Undo in Yahoo Mail
<rdar://problem/
5658709> Crash in RenderView::setSelection on Undo in Yahoo Mail
Make sure we have an updated layout before we perform any editing work.
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply):
(WebCore::EditCommand::unapply):
(WebCore::EditCommand::reapply):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 10 Jan 2008 20:29:39 +0000 (20:29 +0000)]
2008-01-10 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Back out r29206 which was causing regressions in curl http job
cancellation.
* platform/network/curl/ResourceHandleManager.cpp
(ResourceHandleManager::cancel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Thu, 10 Jan 2008 19:33:44 +0000 (19:33 +0000)]
WebCore:
Reviewed by Darin, Sam, and Adam.
- <rdar://problem/
5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
- link in gmail message displays JavaScript alert falsely complaining
about pop-up blocking
- When trying to open a new window, we now see if the user gesture
occurred in the global dynamic object instead of the frame since that is
the only place an event can occur.
* bindings/js/kjs_window.cpp: - Check the dynamic global object instead
of the frame.
(KJS::allowPopUp):
(KJS::showModalDialog):
(KJS::WindowProtoFuncOpen::callAsFunction):
WebKitTools:
Reviewed by Darin, Sam and Adam.
-<rdar://problem/
5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
link in gmail message displays JavaScript alert falsely complaining
about pop-up blocking.
- Added the ability to enable the pop-up blocker via the
LayoutTestController.
* DumpRenderTree/LayoutTestController.cpp:
(setPopupBlockingEnabledCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting):
(resetWebViewToConsistentStateBeforeTesting):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setPopupBlockingEnabled):
LayoutTests:
Reviewed by Darin, Sam, and Adam.
-<rdar://problem/
5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
link in gmail message displays JavaScript alert falsely complaining
about pop-up blocking
- When trying to open a new window, we now see if the user gesture
occurred in the global dynamic object instead of the frame since that is
the only place an event can occur.
* fast/events/open-window-from-another-frame-expected.txt: Added.
* fast/events/open-window-from-another-frame.html: Added.
* fast/events/resources/open-window-from-another-frame-otherFrame.html: Added.
* fast/events/resources/window-opened.html: Added.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 10 Jan 2008 19:29:32 +0000 (19:29 +0000)]
Fix for bug 16247, visibility:hidden not honored when hit testing inline replaced elements.
Reviewed by adele
Added fast/css/visibility-hit-test.html test case.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 10 Jan 2008 19:28:14 +0000 (19:28 +0000)]
Add new layout test for visibility bug.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 10 Jan 2008 17:39:03 +0000 (17:39 +0000)]
JavaScriptCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=16782
<rdar://problem/
5675331> REGRESSION(r29266): Reproducible crash in fast/replaced/image-map.html
The crash resulted from a native object (DumpRenderTree's
EventSender) causing its wrapper to be invalidated (by clicking a
link that replaced the document in the window) and consequently
deallocated. The fix is to use RefPtrs to protect the native object
from deletion by self-invalidation.
* bindings/runtime_method.cpp:
(RuntimeMethod::callAsFunction):
* bindings/runtime_object.cpp:
(RuntimeObjectImp::fallbackObjectGetter):
(RuntimeObjectImp::fieldGetter):
(RuntimeObjectImp::methodGetter):
(RuntimeObjectImp::put):
(RuntimeObjectImp::defaultValue):
(RuntimeObjectImp::callAsFunction):
LayoutTests:
Reviewed by Darin Adler.
- re-enable crashing test after fixing http://bugs.webkit.org/show_bug.cgi?id=16782
<rdar://problem/
5675331> REGRESSION(r29266): Reproducible crash in fast/replaced/image-map.html
* fast/replaced/image-map-expected.txt: Updated results for the new
behavior, which is to replace the document with the success message.
* fast/replaced/image-map.html: Copied from LayoutTests/fast/replaced/image-map.html-disabled.
* fast/replaced/image-map.html-disabled: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:47:59 +0000 (16:47 +0000)]
document QWebHistory
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:47:42 +0000 (16:47 +0000)]
Make the reset() functions not do anything on the default QWebSettings object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:47:24 +0000 (16:47 +0000)]
rename QWebPageHistory to QWebHistory.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:39:06 +0000 (16:39 +0000)]
Documentation for QWebSettings
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:38:51 +0000 (16:38 +0000)]
Document QWebHistoryInterface.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:38:33 +0000 (16:38 +0000)]
Documentation for QWebFrame.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:19:55 +0000 (16:19 +0000)]
fix the drawing errors that where introduced due to refactoring.
Correctly clip to the rectangle we want to draw in ScrollView::paint().
Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:19:23 +0000 (16:19 +0000)]
Added a whole bunch of docs for QWebPage and fixed some minor doc glitches in QWebView.
Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 16:19:04 +0000 (16:19 +0000)]
Temporarily disable gzip decompression in qhttp due to a bug.
Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 10 Jan 2008 15:28:59 +0000 (15:28 +0000)]
http://bugs.webkit.org/show_bug.cgi?id=16588
Added a (last) Frame argument to ResourceHandle::loadResourceSynchronously.
This allows implementing the synchronous loading correctly for the Qt port where the networking
backend is bound to the page.
Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 10 Jan 2008 15:22:07 +0000 (15:22 +0000)]
Reviewed by John Sullivan.
- make more tests pass on Windows by forcing font fallback to match
Mac OS X.
* fast/css/beforeSelectorOnCodeElement.html:
* fast/css/rtl-ordering.html:
* fast/css/text-security.html:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 10 Jan 2008 08:49:42 +0000 (08:49 +0000)]
wx build fix for changes in r29328
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 10 Jan 2008 03:48:41 +0000 (03:48 +0000)]
Reviewed by Sam.
- refactor SecurityOrigin in preparation for merging with SecurityOriginData
* platform/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::createForFrame):
* platform/SecurityOrigin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 10 Jan 2008 03:03:11 +0000 (03:03 +0000)]
WebCore:
Tabs with ctrl, meta, or altgraph modifier key down should not advance focus.
Reviewed by Darin.
Test: fast/forms/tabs-with-modifiers.html
* page/EventHandler.cpp:
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::defaultTabEventHandler): bail if ctrl, meta, or altgraph key is down.
Clean up the code a bit.
* page/EventHandler.h:
* page/FocusController.cpp: Remove the advanceFocus() that takes in a KeyboardEvent. It was
only called in EventHandler::defaultTabEventHandler() but we have cleaned up the code there and
no longer needs it.
* page/FocusController.h:
LayoutTests:
Tests tabbing with different combinations of modifiers keys, where some
should advance focus and some should not.
Reviewed by Darin.
* fast/forms/tabs-with-modifiers-expected.txt: Added.
* fast/forms/tabs-with-modifiers.html: Copied from fast/forms/focus2.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 10 Jan 2008 02:57:42 +0000 (02:57 +0000)]
Fix crash that could happen if the key we are passing to the HashMap is 0 in WebView::interpretKeyEvent().
Reviewed by Darin.
* WebView.cpp:
(WebView::interpretKeyEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc